{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/bitters/issues/197","labels_url":"https://api.github.com/repos/thoughtbot/bitters/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/issues/197/comments","events_url":"https://api.github.com/repos/thoughtbot/bitters/issues/197/events","html_url":"https://github.com/thoughtbot/bitters/pull/197","id":108219147,"number":197,"title":"Update `fieldset` styling","user":{"login":"tysongach","id":903327,"avatar_url":"https://avatars.githubusercontent.com/u/903327?v=3","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-24T21:37:33Z","updated_at":"2015-10-02T16:38:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/bitters/pulls/197","html_url":"https://github.com/thoughtbot/bitters/pull/197","diff_url":"https://github.com/thoughtbot/bitters/pull/197.diff","patch_url":"https://github.com/thoughtbot/bitters/pull/197.patch"},"body":"I’ve always found the default styling for `fieldset`’s too harsh, visually. Their purpose is to “group several controls as well as labels within a web form” ([1]). So, for example, you could group three individual inputs for month, day and year within a `fieldset` to represent a birthdate. For the sake of semantics, you would also give that `fieldset` a legend: `<legend>Birthdate</legend>`.\r\n\r\nBut if that `fieldset` was follow by an individual input that isn’t also grouped in a `fieldset` (so it doesn’t have all the spacing and `background-color`), they visually look _super_ different for almost no reason. So I say we clear out the visual styling of `fieldset`s:\r\n\r\n- Remove `background-color`, `border`, `margin` and `padding` from `fieldset`\r\n- Add `legend` styles to reflect updated `fieldset` styling\r\n\r\n### Before\r\n\r\n<img width=\"984\" alt=\"screen shot 2015-09-24 at 5 25 30 pm\" src=\"https://cloud.githubusercontent.com/assets/903327/10087513/46cda768-62e2-11e5-8c1c-e77561422525.png\">\r\n\r\n### After\r\n\r\n<img width=\"984\" alt=\"screen shot 2015-09-24 at 5 25 57 pm\" src=\"https://cloud.githubusercontent.com/assets/903327/10087516/4a598956-62e2-11e5-8b53-3589e67986fe.png\">\r\n\r\n[1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset \"MDN\""},"comment":{"url":"https://api.github.com/repos/thoughtbot/bitters/issues/comments/145081714","html_url":"https://github.com/thoughtbot/bitters/pull/197#issuecomment-145081714","issue_url":"https://api.github.com/repos/thoughtbot/bitters/issues/197","id":145081714,"user":{"login":"whmii","id":2489247,"avatar_url":"https://avatars.githubusercontent.com/u/2489247?v=3","gravatar_id":"","url":"https://api.github.com/users/whmii","html_url":"https://github.com/whmii","followers_url":"https://api.github.com/users/whmii/followers","following_url":"https://api.github.com/users/whmii/following{/other_user}","gists_url":"https://api.github.com/users/whmii/gists{/gist_id}","starred_url":"https://api.github.com/users/whmii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whmii/subscriptions","organizations_url":"https://api.github.com/users/whmii/orgs","repos_url":"https://api.github.com/users/whmii/repos","events_url":"https://api.github.com/users/whmii/events{/privacy}","received_events_url":"https://api.github.com/users/whmii/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T16:38:02Z","updated_at":"2015-10-02T16:38:02Z","body":"I agree that the legends look super meh with this update. I think they need a little :heart: "}}