{"action":"created","comment":{"url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/comments/41698590","id":41698590,"diff_hunk":"@@ -86,7 +86,7 @@ We can also combine tests using `and` and `or`.\n `and` is only true if both parts are true:\n \n ~~~ {.python}\n-if (1 > 0) and (-1 > 0):\n+if 1 > 0 and -1 > 0:","path":"05-cond.md","position":5,"original_position":5,"commit_id":"9687daf5a5cc4ace60b111b5df9ae47e46eb6895","original_commit_id":"9687daf5a5cc4ace60b111b5df9ae47e46eb6895","user":{"login":"tpoisot","id":579329,"avatar_url":"https://avatars.githubusercontent.com/u/579329?v=3","gravatar_id":"","url":"https://api.github.com/users/tpoisot","html_url":"https://github.com/tpoisot","followers_url":"https://api.github.com/users/tpoisot/followers","following_url":"https://api.github.com/users/tpoisot/following{/other_user}","gists_url":"https://api.github.com/users/tpoisot/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoisot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoisot/subscriptions","organizations_url":"https://api.github.com/users/tpoisot/orgs","repos_url":"https://api.github.com/users/tpoisot/repos","events_url":"https://api.github.com/users/tpoisot/events{/privacy}","received_events_url":"https://api.github.com/users/tpoisot/received_events","type":"User","site_admin":false},"body":"I've seen people get confused when there are no parentheses: `1 > 0 and -1` can be parsed as `1 > (0 and -1)` -- unless you've already read the whole line. I tend to use parentheses because they improve *reading* code, which I think is worth emphasizing.\r\n\r\nIf we want to not use the parentheses, maybe there needs to be something on the precedence of operators, and I think this lesson is dense already.\r\n\r\nI think the parentheses should stay.","created_at":"2015-10-10T16:07:43Z","updated_at":"2015-10-10T16:07:43Z","html_url":"https://github.com/swcarpentry/python-novice-inflammation/pull/154#discussion_r41698590","pull_request_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/comments/41698590"},"html":{"href":"https://github.com/swcarpentry/python-novice-inflammation/pull/154#discussion_r41698590"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154","id":43687810,"html_url":"https://github.com/swcarpentry/python-novice-inflammation/pull/154","diff_url":"https://github.com/swcarpentry/python-novice-inflammation/pull/154.diff","patch_url":"https://github.com/swcarpentry/python-novice-inflammation/pull/154.patch","issue_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/154","number":154,"state":"open","locked":false,"title":"Many small changes from runthrough","user":{"login":"tbekolay","id":203709,"avatar_url":"https://avatars.githubusercontent.com/u/203709?v=3","gravatar_id":"","url":"https://api.github.com/users/tbekolay","html_url":"https://github.com/tbekolay","followers_url":"https://api.github.com/users/tbekolay/followers","following_url":"https://api.github.com/users/tbekolay/following{/other_user}","gists_url":"https://api.github.com/users/tbekolay/gists{/gist_id}","starred_url":"https://api.github.com/users/tbekolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbekolay/subscriptions","organizations_url":"https://api.github.com/users/tbekolay/orgs","repos_url":"https://api.github.com/users/tbekolay/repos","events_url":"https://api.github.com/users/tbekolay/events{/privacy}","received_events_url":"https://api.github.com/users/tbekolay/received_events","type":"User","site_admin":false},"body":"In going through the Python 3 runthrough (see #153) I saw a bunch of little things that I felt should be changed.\r\n\r\nNote that this branch is based off of #153 (i.e., it picks up where that PR leaves off -- it assumes that that PR has already been merged) so I recommend that we deal with #153 first, and even merge `py3k` into `gh-pages` before looking at this PR (it'll make merging much simpler).\r\n\r\nI also think that we should ensure that these fixes aren't already done in other PRs. I was just blindly going through and changing things I saw that needed changing, but some of them struck me as things I've seen fly through my email at one time or another, and I definitely would rather an earlier PR be merged before looking at this one.\r\n\r\nThe history of this PR will be easier to read once those other things are merged, but if you want to check out the changes now, look at the Commits tab. This PR is essentially all of the commits from 20923d8c9a5770a9 onwards.","created_at":"2015-08-29T03:32:14Z","updated_at":"2015-10-10T16:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a764c2011e4fe57a8367477ea24f87c927253d12","assignee":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154/commits","review_comments_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154/comments","review_comment_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/154/comments","statuses_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/statuses/9687daf5a5cc4ace60b111b5df9ae47e46eb6895","head":{"label":"swcarpentry:runthrough","ref":"runthrough","sha":"9687daf5a5cc4ace60b111b5df9ae47e46eb6895","user":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"repo":{"id":27150322,"name":"python-novice-inflammation","full_name":"swcarpentry/python-novice-inflammation","owner":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swcarpentry/python-novice-inflammation","description":"Software Carpentry introduction to Python for novices using inflammation data.","fork":false,"url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation","forks_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/forks","keys_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/teams","hooks_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/hooks","issue_events_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/events{/number}","events_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/events","assignees_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/assignees{/user}","branches_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/branches{/branch}","tags_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/tags","blobs_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/statuses/{sha}","languages_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/languages","stargazers_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/stargazers","contributors_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/contributors","subscribers_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/subscribers","subscription_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/subscription","commits_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/contents/{+path}","compare_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/merges","archive_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/downloads","issues_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues{/number}","pulls_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls{/number}","milestones_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/milestones{/number}","notifications_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/labels{/name}","releases_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/releases{/id}","created_at":"2014-11-25T23:05:27Z","updated_at":"2015-09-28T21:00:30Z","pushed_at":"2015-10-10T04:32:06Z","git_url":"git://github.com/swcarpentry/python-novice-inflammation.git","ssh_url":"git@github.com:swcarpentry/python-novice-inflammation.git","clone_url":"https://github.com/swcarpentry/python-novice-inflammation.git","svn_url":"https://github.com/swcarpentry/python-novice-inflammation","homepage":"http://swcarpentry.github.io/python-novice-inflammation/","size":6602,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"open_issues_count":35,"forks":111,"open_issues":35,"watchers":21,"default_branch":"gh-pages"}},"base":{"label":"swcarpentry:gh-pages","ref":"gh-pages","sha":"a73ea75fc899122671bb137a91850f6bc595dba4","user":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"repo":{"id":27150322,"name":"python-novice-inflammation","full_name":"swcarpentry/python-novice-inflammation","owner":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swcarpentry/python-novice-inflammation","description":"Software Carpentry introduction to Python for novices using inflammation data.","fork":false,"url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation","forks_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/forks","keys_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/teams","hooks_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/hooks","issue_events_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/events{/number}","events_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/events","assignees_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/assignees{/user}","branches_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/branches{/branch}","tags_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/tags","blobs_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/statuses/{sha}","languages_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/languages","stargazers_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/stargazers","contributors_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/contributors","subscribers_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/subscribers","subscription_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/subscription","commits_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/contents/{+path}","compare_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/merges","archive_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/downloads","issues_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues{/number}","pulls_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls{/number}","milestones_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/milestones{/number}","notifications_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/labels{/name}","releases_url":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/releases{/id}","created_at":"2014-11-25T23:05:27Z","updated_at":"2015-09-28T21:00:30Z","pushed_at":"2015-10-10T04:32:06Z","git_url":"git://github.com/swcarpentry/python-novice-inflammation.git","ssh_url":"git@github.com:swcarpentry/python-novice-inflammation.git","clone_url":"https://github.com/swcarpentry/python-novice-inflammation.git","svn_url":"https://github.com/swcarpentry/python-novice-inflammation","homepage":"http://swcarpentry.github.io/python-novice-inflammation/","size":6602,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"open_issues_count":35,"forks":111,"open_issues":35,"watchers":21,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154"},"html":{"href":"https://github.com/swcarpentry/python-novice-inflammation/pull/154"},"issue":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/154"},"comments":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/swcarpentry/python-novice-inflammation/statuses/9687daf5a5cc4ace60b111b5df9ae47e46eb6895"}}}}