{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/35852380","id":35852380,"diff_hunk":"@@ -45,6 +46,7 @@ function temp_pkg_dir(fn::Function)\n     fn()\n   finally\n     rm(tmpdir, recursive=true)\n+    ENV = environment","path":"test/replcompletions.jl","position":12,"original_position":12,"commit_id":"80df493672c7c5addaf6eddc49bde27af0a30387","original_commit_id":"80df493672c7c5addaf6eddc49bde27af0a30387","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"This doesn't seem right - at the REPL this kind of thing gives a `WARNING: imported binding for ENV overwritten in module Main`. There's a `withenv` function that would probably be better for this.","created_at":"2015-07-30T09:15:47Z","updated_at":"2015-07-30T09:15:47Z","html_url":"https://github.com/JuliaLang/julia/pull/12339#discussion_r35852380","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12339","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/35852380"},"html":{"href":"https://github.com/JuliaLang/julia/pull/12339#discussion_r35852380"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12339"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/12339","id":40974844,"html_url":"https://github.com/JuliaLang/julia/pull/12339","diff_url":"https://github.com/JuliaLang/julia/pull/12339.diff","patch_url":"https://github.com/JuliaLang/julia/pull/12339.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/12339","number":12339,"state":"open","locked":false,"title":"interactiveutil.jl tests","user":{"login":"Rory-Finnegan","id":5276097,"avatar_url":"https://avatars.githubusercontent.com/u/5276097?v=3","gravatar_id":"","url":"https://api.github.com/users/Rory-Finnegan","html_url":"https://github.com/Rory-Finnegan","followers_url":"https://api.github.com/users/Rory-Finnegan/followers","following_url":"https://api.github.com/users/Rory-Finnegan/following{/other_user}","gists_url":"https://api.github.com/users/Rory-Finnegan/gists{/gist_id}","starred_url":"https://api.github.com/users/Rory-Finnegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rory-Finnegan/subscriptions","organizations_url":"https://api.github.com/users/Rory-Finnegan/orgs","repos_url":"https://api.github.com/users/Rory-Finnegan/repos","events_url":"https://api.github.com/users/Rory-Finnegan/events{/privacy}","received_events_url":"https://api.github.com/users/Rory-Finnegan/received_events","type":"User","site_admin":false},"body":"Added some tests for interactiveutil.jl\r\n\r\n* Moved most of the edit function code into an editcmd function that returns the `run` or `spawn` function and the command string. This was to make it easier to test what editor is being selected.\r\n* Currently, this only gets the interactiveutil coverage just above 50%. The remainder of the missing coverage is 1) OS dependent code 2) `gen_call_with_extracted_types(fcn, ex0)` (which isn't exported and only a small portion of the function is used) and 3) The `download`, `workspace` and `runtests` functions (which I'm not sure how best to unit test).","created_at":"2015-07-28T04:43:11Z","updated_at":"2015-07-30T09:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"556709fc0d13c570c88824ffcf12bfe0e463c45c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12339/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/12339/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/12339/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/80df493672c7c5addaf6eddc49bde27af0a30387","head":{"label":"Rory-Finnegan:master","ref":"master","sha":"80df493672c7c5addaf6eddc49bde27af0a30387","user":{"login":"Rory-Finnegan","id":5276097,"avatar_url":"https://avatars.githubusercontent.com/u/5276097?v=3","gravatar_id":"","url":"https://api.github.com/users/Rory-Finnegan","html_url":"https://github.com/Rory-Finnegan","followers_url":"https://api.github.com/users/Rory-Finnegan/followers","following_url":"https://api.github.com/users/Rory-Finnegan/following{/other_user}","gists_url":"https://api.github.com/users/Rory-Finnegan/gists{/gist_id}","starred_url":"https://api.github.com/users/Rory-Finnegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rory-Finnegan/subscriptions","organizations_url":"https://api.github.com/users/Rory-Finnegan/orgs","repos_url":"https://api.github.com/users/Rory-Finnegan/repos","events_url":"https://api.github.com/users/Rory-Finnegan/events{/privacy}","received_events_url":"https://api.github.com/users/Rory-Finnegan/received_events","type":"User","site_admin":false},"repo":{"id":33395518,"name":"julia","full_name":"Rory-Finnegan/julia","owner":{"login":"Rory-Finnegan","id":5276097,"avatar_url":"https://avatars.githubusercontent.com/u/5276097?v=3","gravatar_id":"","url":"https://api.github.com/users/Rory-Finnegan","html_url":"https://github.com/Rory-Finnegan","followers_url":"https://api.github.com/users/Rory-Finnegan/followers","following_url":"https://api.github.com/users/Rory-Finnegan/following{/other_user}","gists_url":"https://api.github.com/users/Rory-Finnegan/gists{/gist_id}","starred_url":"https://api.github.com/users/Rory-Finnegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rory-Finnegan/subscriptions","organizations_url":"https://api.github.com/users/Rory-Finnegan/orgs","repos_url":"https://api.github.com/users/Rory-Finnegan/repos","events_url":"https://api.github.com/users/Rory-Finnegan/events{/privacy}","received_events_url":"https://api.github.com/users/Rory-Finnegan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rory-Finnegan/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/Rory-Finnegan/julia","forks_url":"https://api.github.com/repos/Rory-Finnegan/julia/forks","keys_url":"https://api.github.com/repos/Rory-Finnegan/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rory-Finnegan/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rory-Finnegan/julia/teams","hooks_url":"https://api.github.com/repos/Rory-Finnegan/julia/hooks","issue_events_url":"https://api.github.com/repos/Rory-Finnegan/julia/issues/events{/number}","events_url":"https://api.github.com/repos/Rory-Finnegan/julia/events","assignees_url":"https://api.github.com/repos/Rory-Finnegan/julia/assignees{/user}","branches_url":"https://api.github.com/repos/Rory-Finnegan/julia/branches{/branch}","tags_url":"https://api.github.com/repos/Rory-Finnegan/julia/tags","blobs_url":"https://api.github.com/repos/Rory-Finnegan/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rory-Finnegan/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rory-Finnegan/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rory-Finnegan/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rory-Finnegan/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/Rory-Finnegan/julia/languages","stargazers_url":"https://api.github.com/repos/Rory-Finnegan/julia/stargazers","contributors_url":"https://api.github.com/repos/Rory-Finnegan/julia/contributors","subscribers_url":"https://api.github.com/repos/Rory-Finnegan/julia/subscribers","subscription_url":"https://api.github.com/repos/Rory-Finnegan/julia/subscription","commits_url":"https://api.github.com/repos/Rory-Finnegan/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rory-Finnegan/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rory-Finnegan/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rory-Finnegan/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rory-Finnegan/julia/contents/{+path}","compare_url":"https://api.github.com/repos/Rory-Finnegan/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rory-Finnegan/julia/merges","archive_url":"https://api.github.com/repos/Rory-Finnegan/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rory-Finnegan/julia/downloads","issues_url":"https://api.github.com/repos/Rory-Finnegan/julia/issues{/number}","pulls_url":"https://api.github.com/repos/Rory-Finnegan/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/Rory-Finnegan/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/Rory-Finnegan/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rory-Finnegan/julia/labels{/name}","releases_url":"https://api.github.com/repos/Rory-Finnegan/julia/releases{/id}","created_at":"2015-04-04T05:36:21Z","updated_at":"2015-04-04T05:36:26Z","pushed_at":"2015-07-30T03:30:26Z","git_url":"git://github.com/Rory-Finnegan/julia.git","ssh_url":"git@github.com:Rory-Finnegan/julia.git","clone_url":"https://github.com/Rory-Finnegan/julia.git","svn_url":"https://github.com/Rory-Finnegan/julia","homepage":"http://julialang.org/","size":78685,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"9390c71ace034e00e3c0a36837094bd89e465ac9","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-07-30T07:30:07Z","pushed_at":"2015-07-30T09:00:37Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":212185,"stargazers_count":5809,"watchers_count":5809,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1255,"mirror_url":null,"open_issues_count":1318,"forks":1255,"open_issues":1318,"watchers":5809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12339"},"html":{"href":"https://github.com/JuliaLang/julia/pull/12339"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12339"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/12339/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12339/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/12339/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/80df493672c7c5addaf6eddc49bde27af0a30387"}}}}