{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/30404226","id":30404226,"diff_hunk":"@@ -515,5 +527,11 @@ def ensure_valid_docker_attributes\n         errors.add(:base, N_(\"Repository URL or Upstream Name is empty. Both are required for syncing from the upstream.\"))\n       end\n     end\n+\n+    def ensure_has_url_for_ostree\n+      if url.blank? && library_instance_id.nil?\n+        errors.add(field, N_(\"cannot be blank. RPM OSTree Repository URL required for syncing from the upstream.\"))\n+      end","path":"app/models/katello/repository.rb","position":59,"original_position":59,"commit_id":"e2659155601341605ccdcadcef907f590981b293","original_commit_id":"e2659155601341605ccdcadcef907f590981b293","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"After watching a Sandi Metz talk, I have become a fan of using guards in situations like this, e.g.:\r\n\r\n```\r\ndef ensure_branch_only_for_ostree\r\n  return true if url.blank? && library_instance_id.nil?\r\n  errors.add(field, N_(\"cannot be blank. RPM OSTree Repository URL required for syncing from the upstream.\"))\r\nend\r\n```","created_at":"2015-05-15T12:29:09Z","updated_at":"2015-05-15T12:29:09Z","html_url":"https://github.com/Katello/katello/pull/5229#discussion_r30404226","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/5229","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/30404226"},"html":{"href":"https://github.com/Katello/katello/pull/5229#discussion_r30404226"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/5229"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/5229","id":35453386,"html_url":"https://github.com/Katello/katello/pull/5229","diff_url":"https://github.com/Katello/katello/pull/5229.diff","patch_url":"https://github.com/Katello/katello/pull/5229.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/5229","number":5229,"state":"open","locked":false,"title":"Refs #10055 - Initial model bindings for OSTREE CRUD","user":{"login":"parthaa","id":1069779,"avatar_url":"https://avatars.githubusercontent.com/u/1069779?v=3","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-14T19:28:38Z","updated_at":"2015-05-15T12:29:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43c8fe5285305d4ddab7d28b339d8fedd2cc35bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/5229/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/5229/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/5229/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/e2659155601341605ccdcadcef907f590981b293","head":{"label":"parthaa:ostree","ref":"ostree","sha":"e2659155601341605ccdcadcef907f590981b293","user":{"login":"parthaa","id":1069779,"avatar_url":"https://avatars.githubusercontent.com/u/1069779?v=3","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"repo":{"id":4150075,"name":"katello","full_name":"parthaa/katello","owner":{"login":"parthaa","id":1069779,"avatar_url":"https://avatars.githubusercontent.com/u/1069779?v=3","gravatar_id":"","url":"https://api.github.com/users/parthaa","html_url":"https://github.com/parthaa","followers_url":"https://api.github.com/users/parthaa/followers","following_url":"https://api.github.com/users/parthaa/following{/other_user}","gists_url":"https://api.github.com/users/parthaa/gists{/gist_id}","starred_url":"https://api.github.com/users/parthaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parthaa/subscriptions","organizations_url":"https://api.github.com/users/parthaa/orgs","repos_url":"https://api.github.com/users/parthaa/repos","events_url":"https://api.github.com/users/parthaa/events{/privacy}","received_events_url":"https://api.github.com/users/parthaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parthaa/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/parthaa/katello","forks_url":"https://api.github.com/repos/parthaa/katello/forks","keys_url":"https://api.github.com/repos/parthaa/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parthaa/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parthaa/katello/teams","hooks_url":"https://api.github.com/repos/parthaa/katello/hooks","issue_events_url":"https://api.github.com/repos/parthaa/katello/issues/events{/number}","events_url":"https://api.github.com/repos/parthaa/katello/events","assignees_url":"https://api.github.com/repos/parthaa/katello/assignees{/user}","branches_url":"https://api.github.com/repos/parthaa/katello/branches{/branch}","tags_url":"https://api.github.com/repos/parthaa/katello/tags","blobs_url":"https://api.github.com/repos/parthaa/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parthaa/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parthaa/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/parthaa/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parthaa/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/parthaa/katello/languages","stargazers_url":"https://api.github.com/repos/parthaa/katello/stargazers","contributors_url":"https://api.github.com/repos/parthaa/katello/contributors","subscribers_url":"https://api.github.com/repos/parthaa/katello/subscribers","subscription_url":"https://api.github.com/repos/parthaa/katello/subscription","commits_url":"https://api.github.com/repos/parthaa/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/parthaa/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/parthaa/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/parthaa/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/parthaa/katello/contents/{+path}","compare_url":"https://api.github.com/repos/parthaa/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parthaa/katello/merges","archive_url":"https://api.github.com/repos/parthaa/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parthaa/katello/downloads","issues_url":"https://api.github.com/repos/parthaa/katello/issues{/number}","pulls_url":"https://api.github.com/repos/parthaa/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/parthaa/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/parthaa/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parthaa/katello/labels{/name}","releases_url":"https://api.github.com/repos/parthaa/katello/releases{/id}","created_at":"2012-04-26T17:15:07Z","updated_at":"2014-06-20T13:40:33Z","pushed_at":"2015-05-14T22:58:05Z","git_url":"git://github.com/parthaa/katello.git","ssh_url":"git@github.com:parthaa/katello.git","clone_url":"https://github.com/parthaa/katello.git","svn_url":"https://github.com/parthaa/katello","homepage":"katello.org","size":66046,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"0258943e95e811bfb73bc1d55cefa90fdfe36a9c","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","created_at":"2012-04-12T16:59:08Z","updated_at":"2015-05-08T17:26:26Z","pushed_at":"2015-05-14T22:58:06Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":236019,"stargazers_count":155,"watchers_count":155,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":97,"forks":108,"open_issues":97,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/5229"},"html":{"href":"https://github.com/Katello/katello/pull/5229"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/5229"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/5229/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/5229/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/5229/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/e2659155601341605ccdcadcef907f590981b293"}}}}