{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/41704741","id":41704741,"diff_hunk":"@@ -202,6 +204,12 @@ - (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionVi\n   // and should not trigger a relayout.\n   _ignoreMaxSizeChange = CGSizeEqualToSize(_maxSizeForNodesConstrainedSize, CGSizeZero);\n   \n+  // Register the default layout inspector delegate for flow layouts, custom layouts\n+  // will need to roll their own ASCollectionViewLayoutInspecting implementation.\n+  _layoutDelegate = [self flowLayoutInspector];","path":"AsyncDisplayKit/ASCollectionView.mm","position":65,"original_position":65,"commit_id":"6b891dda9409a9710c66a00a0e9f8c59651bd86e","original_commit_id":"6b891dda9409a9710c66a00a0e9f8c59651bd86e","user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"body":"Yeah, I think we should refactor this to be = [self layoutInspector] (rename the method) at the least, even if it only ever returns nil or a flow layout inspector.  The comment should also be slightly tweaked to indicate this is the behavior, just making clear that it only has a default for flow layouts.","created_at":"2015-10-11T03:34:57Z","updated_at":"2015-10-11T03:34:57Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/694#discussion_r41704741","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/41704741"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/694#discussion_r41704741"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694","id":46351997,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/694","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/694.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/694.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/694","number":694,"state":"open","locked":false,"title":"[WIP] Support for supplementary views in ASCollectionView","user":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"body":"A bit far from being runnable within an example project, but I wanted to put up what I had as of now to get the ball rolling on feedback. I saw a bunch of new patches showing up that impact ASDataController and I definitely didn't want to miss the party!\r\n\r\nMight be best to read through #691 before skimming through this code, as I briefly outlined the direction I'm embarking on in that issue.\r\n\r\nWhat remains to get to get this to a point where can be landed:\r\n- [x] Finish up abstracting some of the internal insert/update/delete behavior in `ASDataController` to be exposed in such a way that a subclass like `ASCollectionDataController` can insert its supplementary view measure/layout passes.\r\n- [x] Get this running in a sample project and battle test the various issues that arise\r\n- [x] Handle section insertion/update/deletion and item insertion/update/deletion from collection view\r\n- [ ] Investigate ways in which I can use `invalidateLayout` events to resize the supplementary views without competing with the existing implementation of `reloadData` and `layoutSubviews`. UICollectionView actually invokes `invalidateLayout` on account of these events, so it would be much better if we moved toward using layout invalidation exclusively for ASCollectionView data controller updates.\r\n- [ ] Write a bunch of unit tests\r\n\r\nWould love feedback on this. I don't have much time during the week, but have been making this a priority nights/weekends so we can have this ready for 2.0 in November.\r\n\r\nFixes: #669, #588","created_at":"2015-09-30T01:19:42Z","updated_at":"2015-10-11T03:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"640cef74b90d32490a9cd47f284d41cbd765cc84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/694/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/6b891dda9409a9710c66a00a0e9f8c59651bd86e","head":{"label":"levi:supplementary-views","ref":"supplementary-views","sha":"6b891dda9409a9710c66a00a0e9f8c59651bd86e","user":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"repo":{"id":35245356,"name":"AsyncDisplayKit","full_name":"levi/AsyncDisplayKit","owner":{"login":"levi","id":8493,"avatar_url":"https://avatars.githubusercontent.com/u/8493?v=3","gravatar_id":"","url":"https://api.github.com/users/levi","html_url":"https://github.com/levi","followers_url":"https://api.github.com/users/levi/followers","following_url":"https://api.github.com/users/levi/following{/other_user}","gists_url":"https://api.github.com/users/levi/gists{/gist_id}","starred_url":"https://api.github.com/users/levi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levi/subscriptions","organizations_url":"https://api.github.com/users/levi/orgs","repos_url":"https://api.github.com/users/levi/repos","events_url":"https://api.github.com/users/levi/events{/privacy}","received_events_url":"https://api.github.com/users/levi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/levi/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/levi/AsyncDisplayKit","forks_url":"https://api.github.com/repos/levi/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/levi/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levi/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levi/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/levi/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/levi/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/levi/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/levi/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/levi/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levi/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/levi/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/levi/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/levi/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/levi/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/levi/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/levi/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/levi/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/levi/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/levi/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/levi/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levi/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/levi/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levi/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/levi/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/levi/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/levi/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/levi/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levi/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/levi/AsyncDisplayKit/releases{/id}","created_at":"2015-05-07T21:50:39Z","updated_at":"2015-05-08T04:58:49Z","pushed_at":"2015-10-09T04:24:13Z","git_url":"git://github.com/levi/AsyncDisplayKit.git","ssh_url":"git@github.com:levi/AsyncDisplayKit.git","clone_url":"https://github.com/levi/AsyncDisplayKit.git","svn_url":"https://github.com/levi/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":4295,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"supplementary-views"}},"base":{"label":"facebook:master","ref":"master","sha":"ca5780f6f4c4310ec31840573ac7f5f555f36f84","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","created_at":"2014-06-27T05:29:02Z","updated_at":"2015-10-11T03:20:49Z","pushed_at":"2015-10-11T03:20:39Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":7314,"stargazers_count":5841,"watchers_count":5841,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":787,"mirror_url":null,"open_issues_count":108,"forks":787,"open_issues":108,"watchers":5841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/694"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/694"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/6b891dda9409a9710c66a00a0e9f8c59651bd86e"}}}}