{"action":"created","comment":{"url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/comments/48562579","id":48562579,"diff_hunk":"@@ -7,6 +7,7 @@ EXTRA_DIST = pi-blaster.service\n sbin_PROGRAMS = pi-blaster\n pi_blaster_SOURCES = pi-blaster.c mailbox.c\n \n+if !DEBIAN_PKG","path":"Makefile.am","position":4,"original_position":4,"commit_id":"fc8d42298a1817a1feb5af1edc792bfdbdd2f749","original_commit_id":"fc8d42298a1817a1feb5af1edc792bfdbdd2f749","user":{"login":"sarfata","id":779005,"avatar_url":"https://avatars.githubusercontent.com/u/779005?v=3","gravatar_id":"","url":"https://api.github.com/users/sarfata","html_url":"https://github.com/sarfata","followers_url":"https://api.github.com/users/sarfata/followers","following_url":"https://api.github.com/users/sarfata/following{/other_user}","gists_url":"https://api.github.com/users/sarfata/gists{/gist_id}","starred_url":"https://api.github.com/users/sarfata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarfata/subscriptions","organizations_url":"https://api.github.com/users/sarfata/orgs","repos_url":"https://api.github.com/users/sarfata/repos","events_url":"https://api.github.com/users/sarfata/events{/privacy}","received_events_url":"https://api.github.com/users/sarfata/received_events","type":"User","site_admin":false},"body":"You have removed the file `pi-blaster.boot.sh` so it will not work anymore. We need some way to keep it working for people who are not using systemd and not using the debian package.\r\n\r\nThis [StackOverflow question](http://stackoverflow.com/questions/26837148/autoconf-and-init-scripts) offers two solutions. The first one is very debian specific and you seem to be more familiar with dh-tools than I am. \r\n\r\nThe second one suggests how to cp the file in an `install-exec-hook`. We could use that.","created_at":"2015-12-29T19:13:12Z","updated_at":"2015-12-29T19:13:12Z","html_url":"https://github.com/sarfata/pi-blaster/pull/53#discussion_r48562579","pull_request_url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/comments/48562579"},"html":{"href":"https://github.com/sarfata/pi-blaster/pull/53#discussion_r48562579"},"pull_request":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53","id":48660245,"html_url":"https://github.com/sarfata/pi-blaster/pull/53","diff_url":"https://github.com/sarfata/pi-blaster/pull/53.diff","patch_url":"https://github.com/sarfata/pi-blaster/pull/53.patch","issue_url":"https://api.github.com/repos/sarfata/pi-blaster/issues/53","number":53,"state":"open","locked":false,"title":"Add files for packaging into deb","user":{"login":"hosiet","id":8443926,"avatar_url":"https://avatars.githubusercontent.com/u/8443926?v=3","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nI came back with a PR for pi-blaster. This one still has nothing to do with C source code (as I found it rather complicated to fully understand), but provides files essential to make pi-blaster into deb package. This may be useful, because `make install` and `make uninstall` is not friendly to package management system at all.\r\n\r\nA full list of changes is written below:\r\n* Modify `Makefile.am` and `configure.ac` to provide a new configure-time option to ignore the system-service-installation process. This option is used in deb packaging.\r\n* Add all necessary files into `debian` dir.\r\n* Move and rename the original sysvinit / systemd service files into `debian` dir. Symlinks are left for compatibility with original Makefile.\r\n* Modify `README.md` for new installation / uninstallation instructions.\r\n\r\nBesides, I suggested a minor version bump in the PR since a lot of changes have been introduced since the last update of the version number. If you think it really unnecessary, I will cancel the version number change inside the PR.\r\n\r\nI am sure that there must be some kind of mistakes or something similar in the PR. Please review it and give your opinion. Thanks.","created_at":"2015-10-24T17:02:16Z","updated_at":"2015-12-29T19:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5682225a5d2c260b864c6d0ecbe6a2e50f619b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53/commits","review_comments_url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53/comments","review_comment_url":"https://api.github.com/repos/sarfata/pi-blaster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sarfata/pi-blaster/issues/53/comments","statuses_url":"https://api.github.com/repos/sarfata/pi-blaster/statuses/fc8d42298a1817a1feb5af1edc792bfdbdd2f749","head":{"label":"hosiet:debian-pkg","ref":"debian-pkg","sha":"fc8d42298a1817a1feb5af1edc792bfdbdd2f749","user":{"login":"hosiet","id":8443926,"avatar_url":"https://avatars.githubusercontent.com/u/8443926?v=3","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"repo":{"id":37371391,"name":"pi-blaster","full_name":"hosiet/pi-blaster","owner":{"login":"hosiet","id":8443926,"avatar_url":"https://avatars.githubusercontent.com/u/8443926?v=3","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hosiet/pi-blaster","description":"PWM on the Raspberry pi - done properly (in hardware, stable)","fork":true,"url":"https://api.github.com/repos/hosiet/pi-blaster","forks_url":"https://api.github.com/repos/hosiet/pi-blaster/forks","keys_url":"https://api.github.com/repos/hosiet/pi-blaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hosiet/pi-blaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hosiet/pi-blaster/teams","hooks_url":"https://api.github.com/repos/hosiet/pi-blaster/hooks","issue_events_url":"https://api.github.com/repos/hosiet/pi-blaster/issues/events{/number}","events_url":"https://api.github.com/repos/hosiet/pi-blaster/events","assignees_url":"https://api.github.com/repos/hosiet/pi-blaster/assignees{/user}","branches_url":"https://api.github.com/repos/hosiet/pi-blaster/branches{/branch}","tags_url":"https://api.github.com/repos/hosiet/pi-blaster/tags","blobs_url":"https://api.github.com/repos/hosiet/pi-blaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hosiet/pi-blaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hosiet/pi-blaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/hosiet/pi-blaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hosiet/pi-blaster/statuses/{sha}","languages_url":"https://api.github.com/repos/hosiet/pi-blaster/languages","stargazers_url":"https://api.github.com/repos/hosiet/pi-blaster/stargazers","contributors_url":"https://api.github.com/repos/hosiet/pi-blaster/contributors","subscribers_url":"https://api.github.com/repos/hosiet/pi-blaster/subscribers","subscription_url":"https://api.github.com/repos/hosiet/pi-blaster/subscription","commits_url":"https://api.github.com/repos/hosiet/pi-blaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/hosiet/pi-blaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/hosiet/pi-blaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/hosiet/pi-blaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/hosiet/pi-blaster/contents/{+path}","compare_url":"https://api.github.com/repos/hosiet/pi-blaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hosiet/pi-blaster/merges","archive_url":"https://api.github.com/repos/hosiet/pi-blaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hosiet/pi-blaster/downloads","issues_url":"https://api.github.com/repos/hosiet/pi-blaster/issues{/number}","pulls_url":"https://api.github.com/repos/hosiet/pi-blaster/pulls{/number}","milestones_url":"https://api.github.com/repos/hosiet/pi-blaster/milestones{/number}","notifications_url":"https://api.github.com/repos/hosiet/pi-blaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hosiet/pi-blaster/labels{/name}","releases_url":"https://api.github.com/repos/hosiet/pi-blaster/releases{/id}","created_at":"2015-06-13T12:55:19Z","updated_at":"2015-06-13T12:55:20Z","pushed_at":"2015-10-24T16:14:46Z","git_url":"git://github.com/hosiet/pi-blaster.git","ssh_url":"git@github.com:hosiet/pi-blaster.git","clone_url":"https://github.com/hosiet/pi-blaster.git","svn_url":"https://github.com/hosiet/pi-blaster","homepage":"","size":546,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sarfata:master","ref":"master","sha":"ec5e1b4c6191d8f9a538497dbbb86f9cf0de7016","user":{"login":"sarfata","id":779005,"avatar_url":"https://avatars.githubusercontent.com/u/779005?v=3","gravatar_id":"","url":"https://api.github.com/users/sarfata","html_url":"https://github.com/sarfata","followers_url":"https://api.github.com/users/sarfata/followers","following_url":"https://api.github.com/users/sarfata/following{/other_user}","gists_url":"https://api.github.com/users/sarfata/gists{/gist_id}","starred_url":"https://api.github.com/users/sarfata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarfata/subscriptions","organizations_url":"https://api.github.com/users/sarfata/orgs","repos_url":"https://api.github.com/users/sarfata/repos","events_url":"https://api.github.com/users/sarfata/events{/privacy}","received_events_url":"https://api.github.com/users/sarfata/received_events","type":"User","site_admin":false},"repo":{"id":8090626,"name":"pi-blaster","full_name":"sarfata/pi-blaster","owner":{"login":"sarfata","id":779005,"avatar_url":"https://avatars.githubusercontent.com/u/779005?v=3","gravatar_id":"","url":"https://api.github.com/users/sarfata","html_url":"https://github.com/sarfata","followers_url":"https://api.github.com/users/sarfata/followers","following_url":"https://api.github.com/users/sarfata/following{/other_user}","gists_url":"https://api.github.com/users/sarfata/gists{/gist_id}","starred_url":"https://api.github.com/users/sarfata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarfata/subscriptions","organizations_url":"https://api.github.com/users/sarfata/orgs","repos_url":"https://api.github.com/users/sarfata/repos","events_url":"https://api.github.com/users/sarfata/events{/privacy}","received_events_url":"https://api.github.com/users/sarfata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarfata/pi-blaster","description":"PWM on the Raspberry pi - done properly (in hardware, stable)","fork":true,"url":"https://api.github.com/repos/sarfata/pi-blaster","forks_url":"https://api.github.com/repos/sarfata/pi-blaster/forks","keys_url":"https://api.github.com/repos/sarfata/pi-blaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarfata/pi-blaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarfata/pi-blaster/teams","hooks_url":"https://api.github.com/repos/sarfata/pi-blaster/hooks","issue_events_url":"https://api.github.com/repos/sarfata/pi-blaster/issues/events{/number}","events_url":"https://api.github.com/repos/sarfata/pi-blaster/events","assignees_url":"https://api.github.com/repos/sarfata/pi-blaster/assignees{/user}","branches_url":"https://api.github.com/repos/sarfata/pi-blaster/branches{/branch}","tags_url":"https://api.github.com/repos/sarfata/pi-blaster/tags","blobs_url":"https://api.github.com/repos/sarfata/pi-blaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarfata/pi-blaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarfata/pi-blaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarfata/pi-blaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarfata/pi-blaster/statuses/{sha}","languages_url":"https://api.github.com/repos/sarfata/pi-blaster/languages","stargazers_url":"https://api.github.com/repos/sarfata/pi-blaster/stargazers","contributors_url":"https://api.github.com/repos/sarfata/pi-blaster/contributors","subscribers_url":"https://api.github.com/repos/sarfata/pi-blaster/subscribers","subscription_url":"https://api.github.com/repos/sarfata/pi-blaster/subscription","commits_url":"https://api.github.com/repos/sarfata/pi-blaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarfata/pi-blaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarfata/pi-blaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarfata/pi-blaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarfata/pi-blaster/contents/{+path}","compare_url":"https://api.github.com/repos/sarfata/pi-blaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarfata/pi-blaster/merges","archive_url":"https://api.github.com/repos/sarfata/pi-blaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarfata/pi-blaster/downloads","issues_url":"https://api.github.com/repos/sarfata/pi-blaster/issues{/number}","pulls_url":"https://api.github.com/repos/sarfata/pi-blaster/pulls{/number}","milestones_url":"https://api.github.com/repos/sarfata/pi-blaster/milestones{/number}","notifications_url":"https://api.github.com/repos/sarfata/pi-blaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarfata/pi-blaster/labels{/name}","releases_url":"https://api.github.com/repos/sarfata/pi-blaster/releases{/id}","created_at":"2013-02-08T09:19:01Z","updated_at":"2015-12-27T22:19:55Z","pushed_at":"2015-10-24T17:02:18Z","git_url":"git://github.com/sarfata/pi-blaster.git","ssh_url":"git@github.com:sarfata/pi-blaster.git","clone_url":"https://github.com/sarfata/pi-blaster.git","svn_url":"https://github.com/sarfata/pi-blaster","homepage":"","size":787,"stargazers_count":332,"watchers_count":332,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":22,"forks":55,"open_issues":22,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53"},"html":{"href":"https://github.com/sarfata/pi-blaster/pull/53"},"issue":{"href":"https://api.github.com/repos/sarfata/pi-blaster/issues/53"},"comments":{"href":"https://api.github.com/repos/sarfata/pi-blaster/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sarfata/pi-blaster/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/sarfata/pi-blaster/statuses/fc8d42298a1817a1feb5af1edc792bfdbdd2f749"}}}}