{"action":"created","comment":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/comments/33780596","id":33780596,"diff_hunk":"@@ -260,12 +365,14 @@ def get_accredit_info(self,keys):\n             try:\n                 accredit = self.proj_details['accredited_({})'.format(k)]\n                 if accredit in ['Yes','No']:\n-                    accredit_info[k] = \"{} Validated under ISO accreditation 17025:2005\".format([\"[cross]\",\"[tick]\"][accredit == \"Yes\"])\n+                    accredit_info[k] = \"{} under ISO accreditation 17025:2005\".format([\"[cross] Not validated\",\"[tick] Validated\"][accredit == \"Yes\"])\n                 else:\n-                    accredit_info[k] = accredit\n+                    accredit_info[k] = accredit.replace(\"N/A\",\"Not Applicable\")","path":"ngi_reports/stockholm/project_summary.py","position":371,"original_position":371,"commit_id":"2a8f244a23e1999919225cea81aa441a4459ca88","original_commit_id":"2a8f244a23e1999919225cea81aa441a4459ca88","user":{"login":"ewels","id":465550,"avatar_url":"https://avatars.githubusercontent.com/u/465550?v=3","gravatar_id":"","url":"https://api.github.com/users/ewels","html_url":"https://github.com/ewels","followers_url":"https://api.github.com/users/ewels/followers","following_url":"https://api.github.com/users/ewels/following{/other_user}","gists_url":"https://api.github.com/users/ewels/gists{/gist_id}","starred_url":"https://api.github.com/users/ewels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewels/subscriptions","organizations_url":"https://api.github.com/users/ewels/orgs","repos_url":"https://api.github.com/users/ewels/repos","events_url":"https://api.github.com/users/ewels/events{/privacy}","received_events_url":"https://api.github.com/users/ewels/received_events","type":"User","site_admin":false},"body":"Ok. Can we change to an `else if accredit == 'NA'` in that case? To be more explicit? Then have an else catch which throws an error. I'm being paranoid, but I can see this being updated in the future, leading to confusing reports.","created_at":"2015-07-02T14:04:42Z","updated_at":"2015-07-02T14:04:42Z","html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50#discussion_r33780596","pull_request_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/comments/33780596"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50#discussion_r33780596"},"pull_request":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50","id":38983980,"html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50","diff_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50.diff","patch_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50.patch","issue_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/50","number":50,"state":"open","locked":false,"title":"Almost done delivery reports.","user":{"login":"senthil10","id":5311007,"avatar_url":"https://avatars.githubusercontent.com/u/5311007?v=3","gravatar_id":"","url":"https://api.github.com/users/senthil10","html_url":"https://github.com/senthil10","followers_url":"https://api.github.com/users/senthil10/followers","following_url":"https://api.github.com/users/senthil10/following{/other_user}","gists_url":"https://api.github.com/users/senthil10/gists{/gist_id}","starred_url":"https://api.github.com/users/senthil10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senthil10/subscriptions","organizations_url":"https://api.github.com/users/senthil10/orgs","repos_url":"https://api.github.com/users/senthil10/repos","events_url":"https://api.github.com/users/senthil10/events{/privacy}","received_events_url":"https://api.github.com/users/senthil10/received_events","type":"User","site_admin":false},"body":"The code is almost done and I have tested with couple of projects and for couple of months. After validation and deployment there might be some changes in the code but should not be anything major.\r\n\r\nIn the PR there may be things which can be done in a more optimal/cool/better way or some methods/texts might be better at different scripts/files. So let me know all your awesome suggestions/advice/thoughts/corrections. I AM ALL :ear: s ;)","created_at":"2015-07-01T13:52:16Z","updated_at":"2015-07-02T14:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94c44e4ee1f41cdb9e1bba969c5d76871b850d55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50/commits","review_comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50/comments","review_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/50/comments","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/statuses/2a8f244a23e1999919225cea81aa441a4459ca88","head":{"label":"senthil10:master","ref":"master","sha":"2a8f244a23e1999919225cea81aa441a4459ca88","user":{"login":"senthil10","id":5311007,"avatar_url":"https://avatars.githubusercontent.com/u/5311007?v=3","gravatar_id":"","url":"https://api.github.com/users/senthil10","html_url":"https://github.com/senthil10","followers_url":"https://api.github.com/users/senthil10/followers","following_url":"https://api.github.com/users/senthil10/following{/other_user}","gists_url":"https://api.github.com/users/senthil10/gists{/gist_id}","starred_url":"https://api.github.com/users/senthil10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senthil10/subscriptions","organizations_url":"https://api.github.com/users/senthil10/orgs","repos_url":"https://api.github.com/users/senthil10/repos","events_url":"https://api.github.com/users/senthil10/events{/privacy}","received_events_url":"https://api.github.com/users/senthil10/received_events","type":"User","site_admin":false},"repo":{"id":27480174,"name":"ngi_reports","full_name":"senthil10/ngi_reports","owner":{"login":"senthil10","id":5311007,"avatar_url":"https://avatars.githubusercontent.com/u/5311007?v=3","gravatar_id":"","url":"https://api.github.com/users/senthil10","html_url":"https://github.com/senthil10","followers_url":"https://api.github.com/users/senthil10/followers","following_url":"https://api.github.com/users/senthil10/following{/other_user}","gists_url":"https://api.github.com/users/senthil10/gists{/gist_id}","starred_url":"https://api.github.com/users/senthil10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senthil10/subscriptions","organizations_url":"https://api.github.com/users/senthil10/orgs","repos_url":"https://api.github.com/users/senthil10/repos","events_url":"https://api.github.com/users/senthil10/events{/privacy}","received_events_url":"https://api.github.com/users/senthil10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/senthil10/ngi_reports","description":"Code to generate reports for use by the NGI in SciLifeLab","fork":true,"url":"https://api.github.com/repos/senthil10/ngi_reports","forks_url":"https://api.github.com/repos/senthil10/ngi_reports/forks","keys_url":"https://api.github.com/repos/senthil10/ngi_reports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/senthil10/ngi_reports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/senthil10/ngi_reports/teams","hooks_url":"https://api.github.com/repos/senthil10/ngi_reports/hooks","issue_events_url":"https://api.github.com/repos/senthil10/ngi_reports/issues/events{/number}","events_url":"https://api.github.com/repos/senthil10/ngi_reports/events","assignees_url":"https://api.github.com/repos/senthil10/ngi_reports/assignees{/user}","branches_url":"https://api.github.com/repos/senthil10/ngi_reports/branches{/branch}","tags_url":"https://api.github.com/repos/senthil10/ngi_reports/tags","blobs_url":"https://api.github.com/repos/senthil10/ngi_reports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/senthil10/ngi_reports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/senthil10/ngi_reports/git/refs{/sha}","trees_url":"https://api.github.com/repos/senthil10/ngi_reports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/senthil10/ngi_reports/statuses/{sha}","languages_url":"https://api.github.com/repos/senthil10/ngi_reports/languages","stargazers_url":"https://api.github.com/repos/senthil10/ngi_reports/stargazers","contributors_url":"https://api.github.com/repos/senthil10/ngi_reports/contributors","subscribers_url":"https://api.github.com/repos/senthil10/ngi_reports/subscribers","subscription_url":"https://api.github.com/repos/senthil10/ngi_reports/subscription","commits_url":"https://api.github.com/repos/senthil10/ngi_reports/commits{/sha}","git_commits_url":"https://api.github.com/repos/senthil10/ngi_reports/git/commits{/sha}","comments_url":"https://api.github.com/repos/senthil10/ngi_reports/comments{/number}","issue_comment_url":"https://api.github.com/repos/senthil10/ngi_reports/issues/comments{/number}","contents_url":"https://api.github.com/repos/senthil10/ngi_reports/contents/{+path}","compare_url":"https://api.github.com/repos/senthil10/ngi_reports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/senthil10/ngi_reports/merges","archive_url":"https://api.github.com/repos/senthil10/ngi_reports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/senthil10/ngi_reports/downloads","issues_url":"https://api.github.com/repos/senthil10/ngi_reports/issues{/number}","pulls_url":"https://api.github.com/repos/senthil10/ngi_reports/pulls{/number}","milestones_url":"https://api.github.com/repos/senthil10/ngi_reports/milestones{/number}","notifications_url":"https://api.github.com/repos/senthil10/ngi_reports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/senthil10/ngi_reports/labels{/name}","releases_url":"https://api.github.com/repos/senthil10/ngi_reports/releases{/id}","created_at":"2014-12-03T09:48:48Z","updated_at":"2015-07-01T11:08:56Z","pushed_at":"2015-07-01T13:43:59Z","git_url":"git://github.com/senthil10/ngi_reports.git","ssh_url":"git@github.com:senthil10/ngi_reports.git","clone_url":"https://github.com/senthil10/ngi_reports.git","svn_url":"https://github.com/senthil10/ngi_reports","homepage":null,"size":10956,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NationalGenomicsInfrastructure:master","ref":"master","sha":"4cfea6b7a00c42eac8d78e5e232fe2401d254d38","user":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":26805191,"name":"ngi_reports","full_name":"NationalGenomicsInfrastructure/ngi_reports","owner":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports","description":"Code to generate reports for use by the NGI in SciLifeLab","fork":false,"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports","forks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/forks","keys_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/teams","hooks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/hooks","issue_events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/events{/number}","events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/events","assignees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/assignees{/user}","branches_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/branches{/branch}","tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/tags","blobs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/languages","stargazers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/stargazers","contributors_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/contributors","subscribers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/subscribers","subscription_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/subscription","commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/contents/{+path}","compare_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/merges","archive_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/downloads","issues_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues{/number}","pulls_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/labels{/name}","releases_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/releases{/id}","created_at":"2014-11-18T11:02:48Z","updated_at":"2015-04-01T12:07:03Z","pushed_at":"2015-07-01T13:52:16Z","git_url":"git://github.com/NationalGenomicsInfrastructure/ngi_reports.git","ssh_url":"git@github.com:NationalGenomicsInfrastructure/ngi_reports.git","clone_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports.git","svn_url":"https://github.com/NationalGenomicsInfrastructure/ngi_reports","homepage":null,"size":12651,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/ngi_reports/pull/50"},"issue":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/50"},"comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_reports/statuses/2a8f244a23e1999919225cea81aa441a4459ca88"}}}}