{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/44094164","id":44094164,"diff_hunk":"@@ -596,10 +617,11 @@ internal static bool IsLoadedSyntaxTree(SyntaxTree tree, ImmutableDictionary<str\n                                 loadDirectiveMap,\n                                 loadedSyntaxTreeMap);\n                         }\n-\n-                        treesBuilder.Add(tree);\n-\n-                        ordinalMapBuilder.Add(tree, ordinalMapBuilder.Count);\n+                        else\n+                        {\n+                            // If we don't have a tree for this directive, there should be errors.\n+                            Debug.Assert(directive.Diagnostics.HasAnyErrors());\n+                        }","path":"src/Compilers/CSharp/Portable/Compilation/SyntaxAndDeclarationManager.cs","position":82,"original_position":82,"commit_id":"669a4f8aa0c479d661dc4ac761820136e6951e13","original_commit_id":"669a4f8aa0c479d661dc4ac761820136e6951e13","user":{"login":"cston","id":10732005,"avatar_url":"https://avatars.githubusercontent.com/u/10732005?v=3","gravatar_id":"","url":"https://api.github.com/users/cston","html_url":"https://github.com/cston","followers_url":"https://api.github.com/users/cston/followers","following_url":"https://api.github.com/users/cston/following{/other_user}","gists_url":"https://api.github.com/users/cston/gists{/gist_id}","starred_url":"https://api.github.com/users/cston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cston/subscriptions","organizations_url":"https://api.github.com/users/cston/orgs","repos_url":"https://api.github.com/users/cston/repos","events_url":"https://api.github.com/users/cston/events{/privacy}","received_events_url":"https://api.github.com/users/cston/received_events","type":"User","site_admin":false},"body":"The same ```if (loadedSyntaxTreeMap.TryGetValue(...)) ... else Debug.Assert(...);``` appears multiple times. Consider extracting to a method.","created_at":"2015-11-06T01:26:42Z","updated_at":"2015-11-06T01:26:42Z","html_url":"https://github.com/dotnet/roslyn/pull/6609#discussion_r44094164","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6609","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/44094164"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6609#discussion_r44094164"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6609"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6609","id":49904638,"html_url":"https://github.com/dotnet/roslyn/pull/6609","diff_url":"https://github.com/dotnet/roslyn/pull/6609.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6609.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6609","number":6609,"state":"open","locked":false,"title":"[AskMode] Fix issue with #load of files that can't be read as text...","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"body":"If a #load'ed file can be resolved, but cannot be read (or cannot be read as text), it doesn't get added to the map of resolved file paths -> SyntaxTrees (because there is no SyntaxTree to add).  This wasn't handled in the remove and replace helpers that rebuild the various syntax maps.  In addition, we were attempting to add #load'ed trees to the ordinal map twice in the case that their ordinal position needed to be shifted after a remove or replace.\r\n\r\n(fixes #6589)","created_at":"2015-11-06T01:13:28Z","updated_at":"2015-11-06T01:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1236e3e2b7d12de2f776e002553c88ae90fb545c","assignee":null,"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/3","html_url":"https://github.com/dotnet/roslyn/milestones/1.1","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/3/labels","id":937401,"number":3,"title":"1.1","description":"This is our 1.1 Milestone.\r\n\r\n<!---\r\n@huboard:{\"order\":1.5}\r\n-->\r\n","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":758,"state":"open","created_at":"2015-01-15T20:48:41Z","updated_at":"2015-11-06T01:13:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6609/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6609/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6609/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/669a4f8aa0c479d661dc4ac761820136e6951e13","head":{"label":"KevinH-MS:stabilization","ref":"stabilization","sha":"669a4f8aa0c479d661dc4ac761820136e6951e13","user":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"repo":{"id":30554696,"name":"roslyn","full_name":"KevinH-MS/roslyn","owner":{"login":"KevinH-MS","id":6464209,"avatar_url":"https://avatars.githubusercontent.com/u/6464209?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinH-MS","html_url":"https://github.com/KevinH-MS","followers_url":"https://api.github.com/users/KevinH-MS/followers","following_url":"https://api.github.com/users/KevinH-MS/following{/other_user}","gists_url":"https://api.github.com/users/KevinH-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinH-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinH-MS/subscriptions","organizations_url":"https://api.github.com/users/KevinH-MS/orgs","repos_url":"https://api.github.com/users/KevinH-MS/repos","events_url":"https://api.github.com/users/KevinH-MS/events{/privacy}","received_events_url":"https://api.github.com/users/KevinH-MS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinH-MS/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/KevinH-MS/roslyn","forks_url":"https://api.github.com/repos/KevinH-MS/roslyn/forks","keys_url":"https://api.github.com/repos/KevinH-MS/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinH-MS/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinH-MS/roslyn/teams","hooks_url":"https://api.github.com/repos/KevinH-MS/roslyn/hooks","issue_events_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/KevinH-MS/roslyn/events","assignees_url":"https://api.github.com/repos/KevinH-MS/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/KevinH-MS/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/tags","blobs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinH-MS/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinH-MS/roslyn/languages","stargazers_url":"https://api.github.com/repos/KevinH-MS/roslyn/stargazers","contributors_url":"https://api.github.com/repos/KevinH-MS/roslyn/contributors","subscribers_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscribers","subscription_url":"https://api.github.com/repos/KevinH-MS/roslyn/subscription","commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinH-MS/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinH-MS/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinH-MS/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/KevinH-MS/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinH-MS/roslyn/merges","archive_url":"https://api.github.com/repos/KevinH-MS/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinH-MS/roslyn/downloads","issues_url":"https://api.github.com/repos/KevinH-MS/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/KevinH-MS/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinH-MS/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinH-MS/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinH-MS/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/KevinH-MS/roslyn/releases{/id}","created_at":"2015-02-09T19:43:41Z","updated_at":"2015-05-04T16:17:24Z","pushed_at":"2015-11-06T01:02:06Z","git_url":"git://github.com/KevinH-MS/roslyn.git","ssh_url":"git@github.com:KevinH-MS/roslyn.git","clone_url":"https://github.com/KevinH-MS/roslyn.git","svn_url":"https://github.com/KevinH-MS/roslyn","homepage":"","size":107624,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:stabilization","ref":"stabilization","sha":"15b927eb8d8ef738b3240294b0be135e950f22df","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-11-06T00:57:08Z","pushed_at":"2015-11-06T01:13:31Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":219292,"stargazers_count":3667,"watchers_count":3667,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":868,"mirror_url":null,"open_issues_count":1587,"forks":868,"open_issues":1587,"watchers":3667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6609"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6609"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6609"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6609/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6609/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6609/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/669a4f8aa0c479d661dc4ac761820136e6951e13"}}}}