{"action":"created","comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/27749160","id":27749160,"diff_hunk":"@@ -470,7 +470,7 @@ function menu.clients(args, item_args)\n                 if not c:isvisible() then\n                     tags.viewmore(c:tags(), c.screen)\n                 end\n-                capi.client.focus = c\n+                c:emit_signal(\"request::activate\", \"focus\")","path":"lib/awful/menu.lua.in","position":5,"original_position":5,"commit_id":"bacd56cd2d23acf9427757e216fa705291a1a358","original_commit_id":"bacd56cd2d23acf9427757e216fa705291a1a358","user":{"login":"Elv13","id":340384,"avatar_url":"https://avatars.githubusercontent.com/u/340384?v=3","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"body":"sorry to have missed this in my previous review, but I think \"menu.clients\" would be more descriptive. Other than that this PR look good. Once you fix this, if nobody complain I will go ahead and merge it.","created_at":"2015-04-03T19:12:35Z","updated_at":"2015-04-03T19:12:35Z","html_url":"https://github.com/awesomeWM/awesome/pull/194#discussion_r27749160","pull_request_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/27749160"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/194#discussion_r27749160"},"pull_request":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/194","id":32560505,"html_url":"https://github.com/awesomeWM/awesome/pull/194","diff_url":"https://github.com/awesomeWM/awesome/pull/194.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/194.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/194","number":194,"state":"open","locked":false,"title":"focus: emit `request::activate` signal","user":{"login":"Ram-Z","id":1587259,"avatar_url":"https://avatars.githubusercontent.com/u/1587259?v=3","gravatar_id":"","url":"https://api.github.com/users/Ram-Z","html_url":"https://github.com/Ram-Z","followers_url":"https://api.github.com/users/Ram-Z/followers","following_url":"https://api.github.com/users/Ram-Z/following{/other_user}","gists_url":"https://api.github.com/users/Ram-Z/gists{/gist_id}","starred_url":"https://api.github.com/users/Ram-Z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ram-Z/subscriptions","organizations_url":"https://api.github.com/users/Ram-Z/orgs","repos_url":"https://api.github.com/users/Ram-Z/repos","events_url":"https://api.github.com/users/Ram-Z/events{/privacy}","received_events_url":"https://api.github.com/users/Ram-Z/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-02T23:41:31Z","updated_at":"2015-04-03T19:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2123d3eb4b75c62d200194993b18aa78352442f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/194/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/194/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/194/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/bacd56cd2d23acf9427757e216fa705291a1a358","head":{"label":"Ram-Z:master","ref":"master","sha":"bacd56cd2d23acf9427757e216fa705291a1a358","user":{"login":"Ram-Z","id":1587259,"avatar_url":"https://avatars.githubusercontent.com/u/1587259?v=3","gravatar_id":"","url":"https://api.github.com/users/Ram-Z","html_url":"https://github.com/Ram-Z","followers_url":"https://api.github.com/users/Ram-Z/followers","following_url":"https://api.github.com/users/Ram-Z/following{/other_user}","gists_url":"https://api.github.com/users/Ram-Z/gists{/gist_id}","starred_url":"https://api.github.com/users/Ram-Z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ram-Z/subscriptions","organizations_url":"https://api.github.com/users/Ram-Z/orgs","repos_url":"https://api.github.com/users/Ram-Z/repos","events_url":"https://api.github.com/users/Ram-Z/events{/privacy}","received_events_url":"https://api.github.com/users/Ram-Z/received_events","type":"User","site_admin":false},"repo":{"id":29871417,"name":"awesome","full_name":"Ram-Z/awesome","owner":{"login":"Ram-Z","id":1587259,"avatar_url":"https://avatars.githubusercontent.com/u/1587259?v=3","gravatar_id":"","url":"https://api.github.com/users/Ram-Z","html_url":"https://github.com/Ram-Z","followers_url":"https://api.github.com/users/Ram-Z/followers","following_url":"https://api.github.com/users/Ram-Z/following{/other_user}","gists_url":"https://api.github.com/users/Ram-Z/gists{/gist_id}","starred_url":"https://api.github.com/users/Ram-Z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ram-Z/subscriptions","organizations_url":"https://api.github.com/users/Ram-Z/orgs","repos_url":"https://api.github.com/users/Ram-Z/repos","events_url":"https://api.github.com/users/Ram-Z/events{/privacy}","received_events_url":"https://api.github.com/users/Ram-Z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ram-Z/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/Ram-Z/awesome","forks_url":"https://api.github.com/repos/Ram-Z/awesome/forks","keys_url":"https://api.github.com/repos/Ram-Z/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ram-Z/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ram-Z/awesome/teams","hooks_url":"https://api.github.com/repos/Ram-Z/awesome/hooks","issue_events_url":"https://api.github.com/repos/Ram-Z/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/Ram-Z/awesome/events","assignees_url":"https://api.github.com/repos/Ram-Z/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/Ram-Z/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/Ram-Z/awesome/tags","blobs_url":"https://api.github.com/repos/Ram-Z/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ram-Z/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ram-Z/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ram-Z/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ram-Z/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/Ram-Z/awesome/languages","stargazers_url":"https://api.github.com/repos/Ram-Z/awesome/stargazers","contributors_url":"https://api.github.com/repos/Ram-Z/awesome/contributors","subscribers_url":"https://api.github.com/repos/Ram-Z/awesome/subscribers","subscription_url":"https://api.github.com/repos/Ram-Z/awesome/subscription","commits_url":"https://api.github.com/repos/Ram-Z/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ram-Z/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ram-Z/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ram-Z/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ram-Z/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/Ram-Z/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ram-Z/awesome/merges","archive_url":"https://api.github.com/repos/Ram-Z/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ram-Z/awesome/downloads","issues_url":"https://api.github.com/repos/Ram-Z/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/Ram-Z/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/Ram-Z/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/Ram-Z/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ram-Z/awesome/labels{/name}","releases_url":"https://api.github.com/repos/Ram-Z/awesome/releases{/id}","created_at":"2015-01-26T16:58:55Z","updated_at":"2015-04-03T12:01:54Z","pushed_at":"2015-04-03T12:01:54Z","git_url":"git://github.com/Ram-Z/awesome.git","ssh_url":"git@github.com:Ram-Z/awesome.git","clone_url":"https://github.com/Ram-Z/awesome.git","svn_url":"https://github.com/Ram-Z/awesome","homepage":"https://awesome.naquadah.org/","size":7718,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"594825c929f8ac37939e9f056525143a234d6fde","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","created_at":"2014-03-03T19:56:16Z","updated_at":"2015-04-03T12:34:54Z","pushed_at":"2015-04-03T12:01:56Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesome.naquadah.org/","size":15346,"stargazers_count":256,"watchers_count":256,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":62,"forks":44,"open_issues":62,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/194"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/194"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/194"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/bacd56cd2d23acf9427757e216fa705291a1a358"}}}}