{"action":"closed","issue":{"url":"https://api.github.com/repos/excon/excon/issues/511","labels_url":"https://api.github.com/repos/excon/excon/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/excon/excon/issues/511/comments","events_url":"https://api.github.com/repos/excon/excon/issues/511/events","html_url":"https://github.com/excon/excon/issues/511","id":85415200,"number":511,"title":"Potential Feature: Allow cert objects as well as paths in ssl_socket","user":{"login":"aselder","id":11577,"avatar_url":"https://avatars.githubusercontent.com/u/11577?v=3","gravatar_id":"","url":"https://api.github.com/users/aselder","html_url":"https://github.com/aselder","followers_url":"https://api.github.com/users/aselder/followers","following_url":"https://api.github.com/users/aselder/following{/other_user}","gists_url":"https://api.github.com/users/aselder/gists{/gist_id}","starred_url":"https://api.github.com/users/aselder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aselder/subscriptions","organizations_url":"https://api.github.com/users/aselder/orgs","repos_url":"https://api.github.com/users/aselder/repos","events_url":"https://api.github.com/users/aselder/events{/privacy}","received_events_url":"https://api.github.com/users/aselder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-05T04:21:13Z","updated_at":"2015-06-12T00:20:01Z","closed_at":"2015-06-12T00:20:01Z","body":"We use Faraday in our project and I'm trying switch out adapters from :net_http to :excon, and I'm having to do a lot of work.\r\n\r\nMost relates to the fact that when using the net/http adapter, the client_cert expects an OpenSSL::X509::Certificate object while client_key expects an OpenSSL::PKey::RSA object. When using the excon adapter those same Faraday options need to be set to the file paths instead of the instantiated objects.\r\n\r\nI proposed modifying ssl_socket to check to see if the option passed is an instantiated OpenSSL object before trying to read files assuming the objects are file names.\r\n\r\nThis should have no impact an existing users and facilitate easy adapter swapping when using Faraday.\r\n\r\nI'm more that happy to do the work, just wanted to make sure people were receptive to the idea.\r\n\r\nLet me know what you think.\r\n"}}