{"action":"created","issue":{"url":"https://api.github.com/repos/iojs/io.js/issues/758","labels_url":"https://api.github.com/repos/iojs/io.js/issues/758/labels{/name}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/758/comments","events_url":"https://api.github.com/repos/iojs/io.js/issues/758/events","html_url":"https://github.com/iojs/io.js/pull/758","id":56959710,"number":758,"title":"Implement unhandled rejection tracking","user":{"login":"petkaantonov","id":829734,"avatar_url":"https://avatars.githubusercontent.com/u/829734?v=3","gravatar_id":"","url":"https://api.github.com/users/petkaantonov","html_url":"https://github.com/petkaantonov","followers_url":"https://api.github.com/users/petkaantonov/followers","following_url":"https://api.github.com/users/petkaantonov/following{/other_user}","gists_url":"https://api.github.com/users/petkaantonov/gists{/gist_id}","starred_url":"https://api.github.com/users/petkaantonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petkaantonov/subscriptions","organizations_url":"https://api.github.com/users/petkaantonov/orgs","repos_url":"https://api.github.com/users/petkaantonov/repos","events_url":"https://api.github.com/users/petkaantonov/events{/privacy}","received_events_url":"https://api.github.com/users/petkaantonov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/iojs/io.js/labels/discuss","name":"discuss","color":"02d7e1"},{"url":"https://api.github.com/repos/iojs/io.js/labels/tc-agenda","name":"tc-agenda","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":90,"created_at":"2015-02-08T17:38:00Z","updated_at":"2015-02-12T12:22:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/758","html_url":"https://github.com/iojs/io.js/pull/758","diff_url":"https://github.com/iojs/io.js/pull/758.diff","patch_url":"https://github.com/iojs/io.js/pull/758.patch"},"body":"Implement unhandled rejection tracking for promises as\r\nspecified in https://gist.github.com/benjamingr/0237932cee84712951a2\r\n\r\nFixes #256\r\n\r\nNote that I did not implement any default action - so errors are still\r\nswallowed by default and many developers are therefore not going\r\nto discover the hooks. My recommendation would be by default\r\nto log the error as `\"Potentially unhandled: \" + error.stack` (and\r\nfor example `\"no stack trace\"` for non-errors).\r\n\r\nThese hooks are enough to implement any kind of error handling scheme, including\r\nlog-on-gc (needs native module I think).\r\n\r\n@Domenic , @rvagg , @vkurchatkin , @benjamingr ,@bnoordhuis\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/iojs/io.js/issues/comments/74062455","html_url":"https://github.com/iojs/io.js/pull/758#issuecomment-74062455","issue_url":"https://api.github.com/repos/iojs/io.js/issues/758","id":74062455,"user":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars.githubusercontent.com/u/1315533?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T12:22:58Z","updated_at":"2015-02-12T12:22:58Z","body":"Right, so the performance concerns have been addressed and the fix for the timing of calling `runMicrotasksCallback` has been fixed.\r\n\r\n@vkurchatkin in terms of code functionality are we good to go?"}}