{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/46592941","id":46592941,"diff_hunk":"@@ -53,8 +53,12 @@ dnl\n AC_DEFUN([FI_PROVIDER_SETUP],[\n \tAC_MSG_NOTICE([*** Configuring $1 provider])\n \tAC_ARG_ENABLE([$1],\n-\t      [AS_HELP_STRING([--enable-$1],\n-\t\t\t      [Enable $1 provider @<:@default=auto@:>@])\n+\t      [AS_HELP_STRING([--enable-$1@<:@=yes|no|auto|dl|PATH@:>@],\n+\t\t\t      [Enable $1 provider @<:@default=auto@:>@ \n+\t\t\t\t(yes: enable $1 provider; no: disable $1 provider;\n+\t\t\t\tauto: enable $1 provider if possible;\n+\t\t\t\tdl: build $1 provider as loadable library;","path":"config/fi_provider.m4","position":10,"original_position":10,"commit_id":"5f61358437ff55d25ca86867d060b52396576608","original_commit_id":"5f61358437ff55d25ca86867d060b52396576608","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Do we even want to document the dl option?  This was added more for testing.","created_at":"2015-12-03T18:47:44Z","updated_at":"2015-12-03T18:47:44Z","html_url":"https://github.com/ofiwg/libfabric/pull/1519#discussion_r46592941","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/46592941"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1519#discussion_r46592941"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519","id":52492324,"html_url":"https://github.com/ofiwg/libfabric/pull/1519","diff_url":"https://github.com/ofiwg/libfabric/pull/1519.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1519.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1519","number":1519,"state":"open","locked":false,"title":"configure: list all valid settings for the \"--enable-xxx\" options","user":{"login":"j-xiong","id":8517165,"avatar_url":"https://avatars.githubusercontent.com/u/8517165?v=3","gravatar_id":"","url":"https://api.github.com/users/j-xiong","html_url":"https://github.com/j-xiong","followers_url":"https://api.github.com/users/j-xiong/followers","following_url":"https://api.github.com/users/j-xiong/following{/other_user}","gists_url":"https://api.github.com/users/j-xiong/gists{/gist_id}","starred_url":"https://api.github.com/users/j-xiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-xiong/subscriptions","organizations_url":"https://api.github.com/users/j-xiong/orgs","repos_url":"https://api.github.com/users/j-xiong/repos","events_url":"https://api.github.com/users/j-xiong/events{/privacy}","received_events_url":"https://api.github.com/users/j-xiong/received_events","type":"User","site_admin":false},"body":"The \"--enable-xxx\" options (where \"xxx\" is the provider name) have\r\nmore choices than the standard yes|no|auto values. Listing all the\r\npossible choices in the help text can be useful to new users.\r\n\r\nAs a special note, the option format \"--enable-xxx=<PATH>\" is the\r\nequivalence of the \"--with-xxx=<PATH>\" option found elsewhere.\r\n\r\nSigned-off-by: Jianxin Xiong <jianxin.xiong@intel.com>","created_at":"2015-12-03T05:02:19Z","updated_at":"2015-12-03T18:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9da7ffc0dea849a428334e22b53306414d7b1b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1519/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/5f61358437ff55d25ca86867d060b52396576608","head":{"label":"j-xiong:master","ref":"master","sha":"5f61358437ff55d25ca86867d060b52396576608","user":{"login":"j-xiong","id":8517165,"avatar_url":"https://avatars.githubusercontent.com/u/8517165?v=3","gravatar_id":"","url":"https://api.github.com/users/j-xiong","html_url":"https://github.com/j-xiong","followers_url":"https://api.github.com/users/j-xiong/followers","following_url":"https://api.github.com/users/j-xiong/following{/other_user}","gists_url":"https://api.github.com/users/j-xiong/gists{/gist_id}","starred_url":"https://api.github.com/users/j-xiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-xiong/subscriptions","organizations_url":"https://api.github.com/users/j-xiong/orgs","repos_url":"https://api.github.com/users/j-xiong/repos","events_url":"https://api.github.com/users/j-xiong/events{/privacy}","received_events_url":"https://api.github.com/users/j-xiong/received_events","type":"User","site_admin":false},"repo":{"id":23201185,"name":"libfabric","full_name":"j-xiong/libfabric","owner":{"login":"j-xiong","id":8517165,"avatar_url":"https://avatars.githubusercontent.com/u/8517165?v=3","gravatar_id":"","url":"https://api.github.com/users/j-xiong","html_url":"https://github.com/j-xiong","followers_url":"https://api.github.com/users/j-xiong/followers","following_url":"https://api.github.com/users/j-xiong/following{/other_user}","gists_url":"https://api.github.com/users/j-xiong/gists{/gist_id}","starred_url":"https://api.github.com/users/j-xiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-xiong/subscriptions","organizations_url":"https://api.github.com/users/j-xiong/orgs","repos_url":"https://api.github.com/users/j-xiong/repos","events_url":"https://api.github.com/users/j-xiong/events{/privacy}","received_events_url":"https://api.github.com/users/j-xiong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-xiong/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/j-xiong/libfabric","forks_url":"https://api.github.com/repos/j-xiong/libfabric/forks","keys_url":"https://api.github.com/repos/j-xiong/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-xiong/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-xiong/libfabric/teams","hooks_url":"https://api.github.com/repos/j-xiong/libfabric/hooks","issue_events_url":"https://api.github.com/repos/j-xiong/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/j-xiong/libfabric/events","assignees_url":"https://api.github.com/repos/j-xiong/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/j-xiong/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/j-xiong/libfabric/tags","blobs_url":"https://api.github.com/repos/j-xiong/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-xiong/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-xiong/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-xiong/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-xiong/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/j-xiong/libfabric/languages","stargazers_url":"https://api.github.com/repos/j-xiong/libfabric/stargazers","contributors_url":"https://api.github.com/repos/j-xiong/libfabric/contributors","subscribers_url":"https://api.github.com/repos/j-xiong/libfabric/subscribers","subscription_url":"https://api.github.com/repos/j-xiong/libfabric/subscription","commits_url":"https://api.github.com/repos/j-xiong/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-xiong/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-xiong/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-xiong/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-xiong/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/j-xiong/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-xiong/libfabric/merges","archive_url":"https://api.github.com/repos/j-xiong/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-xiong/libfabric/downloads","issues_url":"https://api.github.com/repos/j-xiong/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/j-xiong/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/j-xiong/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/j-xiong/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-xiong/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/j-xiong/libfabric/releases{/id}","created_at":"2014-08-21T20:04:38Z","updated_at":"2015-05-04T18:34:16Z","pushed_at":"2015-12-03T18:11:52Z","git_url":"git://github.com/j-xiong/libfabric.git","ssh_url":"git@github.com:j-xiong/libfabric.git","clone_url":"https://github.com/j-xiong/libfabric.git","svn_url":"https://github.com/j-xiong/libfabric","homepage":null,"size":7749,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"366adc29a0a4473ac2869e5fb36f7247b28d5317","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-11-25T21:01:42Z","pushed_at":"2015-12-03T18:11:52Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":9302,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":59,"forks":53,"open_issues":59,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1519"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1519"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1519/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1519/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/5f61358437ff55d25ca86867d060b52396576608"}}}}