{"action":"created","issue":{"url":"https://api.github.com/repos/madengr/ham2mon/issues/8","labels_url":"https://api.github.com/repos/madengr/ham2mon/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/madengr/ham2mon/issues/8/comments","events_url":"https://api.github.com/repos/madengr/ham2mon/issues/8/events","html_url":"https://github.com/madengr/ham2mon/pull/8","id":102678730,"number":8,"title":"[RFC] Clean up empty wav files","user":{"login":"lachesis","id":347481,"avatar_url":"https://avatars.githubusercontent.com/u/347481?v=3","gravatar_id":"","url":"https://api.github.com/users/lachesis","html_url":"https://github.com/lachesis","followers_url":"https://api.github.com/users/lachesis/followers","following_url":"https://api.github.com/users/lachesis/following{/other_user}","gists_url":"https://api.github.com/users/lachesis/gists{/gist_id}","starred_url":"https://api.github.com/users/lachesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachesis/subscriptions","organizations_url":"https://api.github.com/users/lachesis/orgs","repos_url":"https://api.github.com/users/lachesis/repos","events_url":"https://api.github.com/users/lachesis/events{/privacy}","received_events_url":"https://api.github.com/users/lachesis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-08-24T00:52:39Z","updated_at":"2015-08-25T04:10:57Z","closed_at":"2015-08-25T02:17:57Z","pull_request":{"url":"https://api.github.com/repos/madengr/ham2mon/pulls/8","html_url":"https://github.com/madengr/ham2mon/pull/8","diff_url":"https://github.com/madengr/ham2mon/pull/8.diff","patch_url":"https://github.com/madengr/ham2mon/pull/8.patch"},"body":"I also moved some base tuner code into the \"BaseTuner\" class to avoid code duplication.\r\n\r\nThis should avoid a massive proliferation of 44-byte wav files. Maybe I've got something configured wrong that's causing these? I'm not super happy with the approach I took to determine if a wavfile should be deleted - if it's size 0 or 44, it's either completely empty, or just a header, and should be trashed.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/madengr/ham2mon/issues/comments/134469057","html_url":"https://github.com/madengr/ham2mon/pull/8#issuecomment-134469057","issue_url":"https://api.github.com/repos/madengr/ham2mon/issues/8","id":134469057,"user":{"login":"john-","id":2359125,"avatar_url":"https://avatars.githubusercontent.com/u/2359125?v=3","gravatar_id":"","url":"https://api.github.com/users/john-","html_url":"https://github.com/john-","followers_url":"https://api.github.com/users/john-/followers","following_url":"https://api.github.com/users/john-/following{/other_user}","gists_url":"https://api.github.com/users/john-/gists{/gist_id}","starred_url":"https://api.github.com/users/john-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-/subscriptions","organizations_url":"https://api.github.com/users/john-/orgs","repos_url":"https://api.github.com/users/john-/repos","events_url":"https://api.github.com/users/john-/events{/privacy}","received_events_url":"https://api.github.com/users/john-/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T04:10:57Z","updated_at":"2015-08-25T04:10:57Z","body":"As far as contributors github does a pretty good job of tracking that.  \nI would say remove that from the README.md and let github handle that part.\n\nFor new features there should be a flag for that when creating an \nissue.  Might make sense to add them there.\n\nJohn\n\nOn 08/24/2015 09:17 PM, Louis Brown wrote:\n>\n> Seems to work good. I'll go ahead and merge it. I'll update README.md \n> contributors tomorrow to add you and john-.\n>\n> Anyone want to add synchronous AM detection? Some of those air band \n> signals are just above the squelch, and don't demodulate very well.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/madengr/ham2mon/pull/8#issuecomment-134450161>.\n>\n\n"}}