{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/44975220","id":44975220,"diff_hunk":"@@ -2438,6 +2438,17 @@ bool Creature::SetDisableGravity(bool disable, bool packetOnly/*=false*/)\n     return true;\n }\n \n+bool Creature::CanSwim() const\n+{\n+    if (Unit* owner = GetCharmerOrOwner())\n+    {","path":"src/server/game/Entities/Creature/Creature.cpp","position":7,"original_position":7,"commit_id":"83050ff155ca7abf01fd9dc7a0b8d5361943e9af","original_commit_id":"83050ff155ca7abf01fd9dc7a0b8d5361943e9af","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"Could you add a bit more detail on how you suggest it should be applied?\r\nTrying to find out more, I searched and found the word `IsCharmedOwnedByPlayerOrPlayer` in Unit.h:\r\nhttps://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Entities/Unit/Unit.h#L1614\r\n```cpp\r\nbool IsCharmedOwnedByPlayerOrPlayer() const { return GetCharmerOrOwnerOrOwnGUID().IsPlayer(); }\r\n```\r\nDoes your suggestion interact with that code?","created_at":"2015-11-16T20:05:32Z","updated_at":"2015-11-16T20:05:32Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15749#discussion_r44975220","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/44975220"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15749#discussion_r44975220"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749","id":48246142,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/15749","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15749.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15749.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15749","number":15749,"state":"open","locked":false,"title":"3.3.5 Core/Pet: Modified following speed and distance between owner and pet","user":{"login":"gashole","id":11144027,"avatar_url":"https://avatars.githubusercontent.com/u/11144027?v=3","gravatar_id":"","url":"https://api.github.com/users/gashole","html_url":"https://github.com/gashole","followers_url":"https://api.github.com/users/gashole/followers","following_url":"https://api.github.com/users/gashole/following{/other_user}","gists_url":"https://api.github.com/users/gashole/gists{/gist_id}","starred_url":"https://api.github.com/users/gashole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashole/subscriptions","organizations_url":"https://api.github.com/users/gashole/orgs","repos_url":"https://api.github.com/users/gashole/repos","events_url":"https://api.github.com/users/gashole/events{/privacy}","received_events_url":"https://api.github.com/users/gashole/received_events","type":"User","site_admin":false},"body":"Original PR #15719 was closed after trying to undo a push mistake\r\n\r\nChanges\r\n* Move pets closer to their owner\r\n* Help prevent stop-and-go movement in follow mode\r\n* Cap pet follow speed bonus\r\n* Only sync speed with owner when near or slower\r\n* Pets only walk when near their owner\r\n* Creature pets can walk\r\n* Pets swim at thier swim speed not run/walk speed\r\n* Pets can sync swim speed with their owner\r\n* SetSwim() checks if water IsSwimmable()\r\n* Creatures move at run/walk speed in water until it gets too deep\r\n* Creatures can be slowed in the water\r\n* All minions (pets, guardians, companions) can sync speed with their owner\r\n* Player pets change the direction they are looking to match their owners \r\n\r\nCloses #8924 #10865 #12595 #12817","created_at":"2015-10-20T19:26:53Z","updated_at":"2015-11-16T20:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15290d5ed121345de4481d07b587e221f164790a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15749/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/83050ff155ca7abf01fd9dc7a0b8d5361943e9af","head":{"label":"gashole:3.3.5","ref":"3.3.5","sha":"83050ff155ca7abf01fd9dc7a0b8d5361943e9af","user":{"login":"gashole","id":11144027,"avatar_url":"https://avatars.githubusercontent.com/u/11144027?v=3","gravatar_id":"","url":"https://api.github.com/users/gashole","html_url":"https://github.com/gashole","followers_url":"https://api.github.com/users/gashole/followers","following_url":"https://api.github.com/users/gashole/following{/other_user}","gists_url":"https://api.github.com/users/gashole/gists{/gist_id}","starred_url":"https://api.github.com/users/gashole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashole/subscriptions","organizations_url":"https://api.github.com/users/gashole/orgs","repos_url":"https://api.github.com/users/gashole/repos","events_url":"https://api.github.com/users/gashole/events{/privacy}","received_events_url":"https://api.github.com/users/gashole/received_events","type":"User","site_admin":false},"repo":{"id":44623761,"name":"TrinityCore","full_name":"gashole/TrinityCore","owner":{"login":"gashole","id":11144027,"avatar_url":"https://avatars.githubusercontent.com/u/11144027?v=3","gravatar_id":"","url":"https://api.github.com/users/gashole","html_url":"https://github.com/gashole","followers_url":"https://api.github.com/users/gashole/followers","following_url":"https://api.github.com/users/gashole/following{/other_user}","gists_url":"https://api.github.com/users/gashole/gists{/gist_id}","starred_url":"https://api.github.com/users/gashole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gashole/subscriptions","organizations_url":"https://api.github.com/users/gashole/orgs","repos_url":"https://api.github.com/users/gashole/repos","events_url":"https://api.github.com/users/gashole/events{/privacy}","received_events_url":"https://api.github.com/users/gashole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gashole/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/gashole/TrinityCore","forks_url":"https://api.github.com/repos/gashole/TrinityCore/forks","keys_url":"https://api.github.com/repos/gashole/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gashole/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gashole/TrinityCore/teams","hooks_url":"https://api.github.com/repos/gashole/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/gashole/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/gashole/TrinityCore/events","assignees_url":"https://api.github.com/repos/gashole/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/gashole/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/gashole/TrinityCore/tags","blobs_url":"https://api.github.com/repos/gashole/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gashole/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gashole/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/gashole/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gashole/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/gashole/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/gashole/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/gashole/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/gashole/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/gashole/TrinityCore/subscription","commits_url":"https://api.github.com/repos/gashole/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/gashole/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/gashole/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/gashole/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/gashole/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/gashole/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gashole/TrinityCore/merges","archive_url":"https://api.github.com/repos/gashole/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gashole/TrinityCore/downloads","issues_url":"https://api.github.com/repos/gashole/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/gashole/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/gashole/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/gashole/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gashole/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/gashole/TrinityCore/releases{/id}","created_at":"2015-10-20T17:38:58Z","updated_at":"2015-10-20T17:39:57Z","pushed_at":"2015-11-13T17:20:38Z","git_url":"git://github.com/gashole/TrinityCore.git","ssh_url":"git@github.com:gashole/TrinityCore.git","clone_url":"https://github.com/gashole/TrinityCore.git","svn_url":"https://github.com/gashole/TrinityCore","homepage":"http://www.trinitycore.org","size":360435,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"536365a70ffc1c443dc8ca2b95081a3061be5478","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-11-15T21:55:20Z","pushed_at":"2015-11-16T15:24:56Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":851884,"stargazers_count":3023,"watchers_count":3023,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3190,"mirror_url":null,"open_issues_count":1194,"forks":3190,"open_issues":1194,"watchers":3023,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15749"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15749"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15749/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15749/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/83050ff155ca7abf01fd9dc7a0b8d5361943e9af"}}}}