{"action":"created","issue":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/427","labels_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/427/labels{/name}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/427/comments","events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/427/events","html_url":"https://github.com/ElektraInitiative/libelektra/pull/427","id":123312660,"number":427,"title":"Crypto-Plugin: implement OpenSSL crypto provider","user":{"login":"petermax2","id":2538677,"avatar_url":"https://avatars.githubusercontent.com/u/2538677?v=3","gravatar_id":"","url":"https://api.github.com/users/petermax2","html_url":"https://github.com/petermax2","followers_url":"https://api.github.com/users/petermax2/followers","following_url":"https://api.github.com/users/petermax2/following{/other_user}","gists_url":"https://api.github.com/users/petermax2/gists{/gist_id}","starred_url":"https://api.github.com/users/petermax2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermax2/subscriptions","organizations_url":"https://api.github.com/users/petermax2/orgs","repos_url":"https://api.github.com/users/petermax2/repos","events_url":"https://api.github.com/users/petermax2/events{/privacy}","received_events_url":"https://api.github.com/users/petermax2/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/labels/in%20progress","name":"in progress","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-21T16:36:34Z","updated_at":"2015-12-23T11:04:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/427","html_url":"https://github.com/ElektraInitiative/libelektra/pull/427","diff_url":"https://github.com/ElektraInitiative/libelektra/pull/427.diff","patch_url":"https://github.com/ElektraInitiative/libelektra/pull/427.patch"},"body":"Added OpenSSL as crypto provider and also improved the test cases.\r\n\r\n- [ ] use compilation variants as described in `doc/tutorials/compilation-variants.md`\r\n- [x] fix conditional jump on uninitialized values\r\n- [x] make libcrypto callback functions **static**"},"comment":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/comments/166863691","html_url":"https://github.com/ElektraInitiative/libelektra/pull/427#issuecomment-166863691","issue_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/427","id":166863691,"user":{"login":"petermax2","id":2538677,"avatar_url":"https://avatars.githubusercontent.com/u/2538677?v=3","gravatar_id":"","url":"https://api.github.com/users/petermax2","html_url":"https://github.com/petermax2","followers_url":"https://api.github.com/users/petermax2/followers","following_url":"https://api.github.com/users/petermax2/following{/other_user}","gists_url":"https://api.github.com/users/petermax2/gists{/gist_id}","starred_url":"https://api.github.com/users/petermax2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermax2/subscriptions","organizations_url":"https://api.github.com/users/petermax2/orgs","repos_url":"https://api.github.com/users/petermax2/repos","events_url":"https://api.github.com/users/petermax2/events{/privacy}","received_events_url":"https://api.github.com/users/petermax2/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T11:04:04Z","updated_at":"2015-12-23T11:04:04Z","body":"FYI I manually ran valgrind on `testmod_crypto` with OpenSSL as crypto provider since Jenkins can not check it atm. Result looks good.\r\n\r\n\troot@f3d98a17b8d1:~/elektra# valgrind --leak-check=full --track-origins=yes bin/testmod_crypto \r\n\t==16599== Memcheck, a memory error detector\r\n\t==16599== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.\r\n\t==16599== Using Valgrind-3.10.0 and LibVEX; rerun with -h for copyright info\r\n\t==16599== Command: bin/testmod_crypto\r\n\t==16599== \r\n\tCYPTO        TESTS\r\n\t==================\r\n\r\n\r\n\ttestmod_crypto RESULTS: 51 test(s) done. 0 error(s).\r\n\t==16599== \r\n\t==16599== HEAP SUMMARY:\r\n\t==16599==     in use at exit: 1,344 bytes in 10 blocks\r\n\t==16599==   total heap usage: 566 allocs, 556 frees, 43,166 bytes allocated\r\n\t==16599== \r\n\t==16599== LEAK SUMMARY:\r\n\t==16599==    definitely lost: 0 bytes in 0 blocks\r\n\t==16599==    indirectly lost: 0 bytes in 0 blocks\r\n\t==16599==      possibly lost: 0 bytes in 0 blocks\r\n\t==16599==    still reachable: 1,344 bytes in 10 blocks\r\n\t==16599==         suppressed: 0 bytes in 0 blocks\r\n\t==16599== Reachable blocks (those to which a pointer was found) are not shown.\r\n\t==16599== To see them, rerun with: --leak-check=full --show-leak-kinds=all\r\n\t==16599== \r\n\t==16599== For counts of detected and suppressed errors, rerun with: -v\r\n\t==16599== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)"}}