{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2","id":29548532,"html_url":"https://github.com/Metaswitch/libmemcached-upstream/pull/2","diff_url":"https://github.com/Metaswitch/libmemcached-upstream/pull/2.diff","patch_url":"https://github.com/Metaswitch/libmemcached-upstream/pull/2.patch","issue_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/2","number":2,"state":"closed","locked":false,"title":"Reviewer Alex - Support vbuckets","user":{"login":"bossmc","id":1073983,"avatar_url":"https://avatars.githubusercontent.com/u/1073983?v=3","gravatar_id":"","url":"https://api.github.com/users/bossmc","html_url":"https://github.com/bossmc","followers_url":"https://api.github.com/users/bossmc/followers","following_url":"https://api.github.com/users/bossmc/following{/other_user}","gists_url":"https://api.github.com/users/bossmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bossmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bossmc/subscriptions","organizations_url":"https://api.github.com/users/bossmc/orgs","repos_url":"https://api.github.com/users/bossmc/repos","events_url":"https://api.github.com/users/bossmc/events{/privacy}","received_events_url":"https://api.github.com/users/bossmc/received_events","type":"User","site_admin":false},"body":"Alex, if you've not got time to look at these this sprint, please push back.\r\n\r\nThis adds support for passing vbucket IDs on SET-like operations over the binary API (the ASCII API has no support for vbuckets).  I didn't just extend the existing functions as older Memcached servers should reject requests where the vbucket section of the request is non-zero (and it makes it easier to submit the change upstream, where they won't want back-compatibility breaking changes).","created_at":"2015-02-18T18:10:39Z","updated_at":"2015-02-27T13:32:04Z","closed_at":"2015-02-27T13:32:04Z","merged_at":"2015-02-27T13:32:04Z","merge_commit_sha":"4912a9a9ae74348f2ec678a42089513ff1190f1c","assignee":{"login":"bossmc","id":1073983,"avatar_url":"https://avatars.githubusercontent.com/u/1073983?v=3","gravatar_id":"","url":"https://api.github.com/users/bossmc","html_url":"https://github.com/bossmc","followers_url":"https://api.github.com/users/bossmc/followers","following_url":"https://api.github.com/users/bossmc/following{/other_user}","gists_url":"https://api.github.com/users/bossmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bossmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bossmc/subscriptions","organizations_url":"https://api.github.com/users/bossmc/orgs","repos_url":"https://api.github.com/users/bossmc/repos","events_url":"https://api.github.com/users/bossmc/events{/privacy}","received_events_url":"https://api.github.com/users/bossmc/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/2/comments","statuses_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/statuses/9d118556d37e4fa328ea2289dc58a7b508dee1ac","head":{"label":"Metaswitch:support-vbuckets","ref":"support-vbuckets","sha":"9d118556d37e4fa328ea2289dc58a7b508dee1ac","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9884484,"name":"libmemcached-upstream","full_name":"Metaswitch/libmemcached-upstream","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/libmemcached-upstream","description":"Import of libmemcached from https://launchpad.net/libmemcached","fork":false,"url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream","forks_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/forks","keys_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/teams","hooks_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/events","assignees_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/tags","blobs_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/subscription","commits_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/merges","archive_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/downloads","issues_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/releases{/id}","created_at":"2013-05-06T10:22:55Z","updated_at":"2014-01-17T17:04:43Z","pushed_at":"2015-02-27T13:32:03Z","git_url":"git://github.com/Metaswitch/libmemcached-upstream.git","ssh_url":"git@github.com:Metaswitch/libmemcached-upstream.git","clone_url":"https://github.com/Metaswitch/libmemcached-upstream.git","svn_url":"https://github.com/Metaswitch/libmemcached-upstream","homepage":null,"size":1454,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"dbd4ec66d948cc6ff33d6b3e596a71ebc15b22db","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9884484,"name":"libmemcached-upstream","full_name":"Metaswitch/libmemcached-upstream","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/libmemcached-upstream","description":"Import of libmemcached from https://launchpad.net/libmemcached","fork":false,"url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream","forks_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/forks","keys_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/teams","hooks_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/events","assignees_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/tags","blobs_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/subscription","commits_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/merges","archive_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/downloads","issues_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/releases{/id}","created_at":"2013-05-06T10:22:55Z","updated_at":"2014-01-17T17:04:43Z","pushed_at":"2015-02-27T13:32:03Z","git_url":"git://github.com/Metaswitch/libmemcached-upstream.git","ssh_url":"git@github.com:Metaswitch/libmemcached-upstream.git","clone_url":"https://github.com/Metaswitch/libmemcached-upstream.git","svn_url":"https://github.com/Metaswitch/libmemcached-upstream","homepage":null,"size":1454,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2"},"html":{"href":"https://github.com/Metaswitch/libmemcached-upstream/pull/2"},"issue":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/2"},"comments":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/libmemcached-upstream/statuses/9d118556d37e4fa328ea2289dc58a7b508dee1ac"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars.githubusercontent.com/u/5425325?v=3","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"comments":1,"review_comments":5,"commits":2,"additions":94,"deletions":17,"changed_files":3}}