{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/33082740","id":33082740,"diff_hunk":"@@ -0,0 +1,50 @@\n+# Copyright 2015 Google Inc. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Tests for resouce_manager.client.Client.\"\"\"\n+\n+import unittest2\n+\n+\n+class TestClient(unittest2.TestCase):\n+    \"\"\"Main test case for resource_manager.client.Client.\"\"\"\n+\n+    def _getTargetClass(self):\n+        from gcloud.resource_manager.client import Client\n+        return Client\n+\n+    def _makeOne(self, *args, **kw):\n+        return self._getTargetClass()(*args, **kw)\n+","path":"gcloud/resource_manager/test_client.py","position":29,"original_position":29,"commit_id":"5456bfb580b54743ea0ab2ac03154d55216d808b","original_commit_id":"5456bfb580b54743ea0ab2ac03154d55216d808b","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"I try to avoid brain dump commits for that very reason. It's way easier for the reviewer to have a tiny scope that can fit in the head at once. Can build the entire surface up over many commits / PRs.","created_at":"2015-06-23T19:42:33Z","updated_at":"2015-06-23T19:42:33Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933#discussion_r33082740","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments/33082740"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933#discussion_r33082740"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933","id":38189520,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/933","number":933,"state":"open","locked":false,"title":"Initial commit of Resource Manager API","user":{"login":"jgeewax","id":112928,"avatar_url":"https://avatars.githubusercontent.com/u/112928?v=3","gravatar_id":"","url":"https://api.github.com/users/jgeewax","html_url":"https://github.com/jgeewax","followers_url":"https://api.github.com/users/jgeewax/followers","following_url":"https://api.github.com/users/jgeewax/following{/other_user}","gists_url":"https://api.github.com/users/jgeewax/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeewax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeewax/subscriptions","organizations_url":"https://api.github.com/users/jgeewax/orgs","repos_url":"https://api.github.com/users/jgeewax/repos","events_url":"https://api.github.com/users/jgeewax/events{/privacy}","received_events_url":"https://api.github.com/users/jgeewax/received_events","type":"User","site_admin":false},"body":"Looking for feedback first. This is short on tests (hence the \"don't merge\" label), but follows the client pattern @dhermes used for PubSub.\r\n\r\nAPI overview is here: https://cloud.google.com/resource-manager/reference/rest","created_at":"2015-06-21T19:50:00Z","updated_at":"2015-06-23T19:42:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec7374f0839ee5dc861e81c034fc0c676b41d3fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/933/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/5456bfb580b54743ea0ab2ac03154d55216d808b","head":{"label":"jgeewax:resource-manager","ref":"resource-manager","sha":"5456bfb580b54743ea0ab2ac03154d55216d808b","user":{"login":"jgeewax","id":112928,"avatar_url":"https://avatars.githubusercontent.com/u/112928?v=3","gravatar_id":"","url":"https://api.github.com/users/jgeewax","html_url":"https://github.com/jgeewax","followers_url":"https://api.github.com/users/jgeewax/followers","following_url":"https://api.github.com/users/jgeewax/following{/other_user}","gists_url":"https://api.github.com/users/jgeewax/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeewax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeewax/subscriptions","organizations_url":"https://api.github.com/users/jgeewax/orgs","repos_url":"https://api.github.com/users/jgeewax/repos","events_url":"https://api.github.com/users/jgeewax/events{/privacy}","received_events_url":"https://api.github.com/users/jgeewax/received_events","type":"User","site_admin":false},"repo":{"id":17003086,"name":"gcloud-python","full_name":"jgeewax/gcloud-python","owner":{"login":"jgeewax","id":112928,"avatar_url":"https://avatars.githubusercontent.com/u/112928?v=3","gravatar_id":"","url":"https://api.github.com/users/jgeewax","html_url":"https://github.com/jgeewax","followers_url":"https://api.github.com/users/jgeewax/followers","following_url":"https://api.github.com/users/jgeewax/following{/other_user}","gists_url":"https://api.github.com/users/jgeewax/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeewax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeewax/subscriptions","organizations_url":"https://api.github.com/users/jgeewax/orgs","repos_url":"https://api.github.com/users/jgeewax/repos","events_url":"https://api.github.com/users/jgeewax/events{/privacy}","received_events_url":"https://api.github.com/users/jgeewax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgeewax/gcloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/jgeewax/gcloud-python","forks_url":"https://api.github.com/repos/jgeewax/gcloud-python/forks","keys_url":"https://api.github.com/repos/jgeewax/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgeewax/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgeewax/gcloud-python/teams","hooks_url":"https://api.github.com/repos/jgeewax/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/jgeewax/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/jgeewax/gcloud-python/events","assignees_url":"https://api.github.com/repos/jgeewax/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/jgeewax/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/jgeewax/gcloud-python/tags","blobs_url":"https://api.github.com/repos/jgeewax/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgeewax/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgeewax/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgeewax/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgeewax/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jgeewax/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/jgeewax/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/jgeewax/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/jgeewax/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/jgeewax/gcloud-python/subscription","commits_url":"https://api.github.com/repos/jgeewax/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgeewax/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgeewax/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgeewax/gcloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgeewax/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/jgeewax/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgeewax/gcloud-python/merges","archive_url":"https://api.github.com/repos/jgeewax/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgeewax/gcloud-python/downloads","issues_url":"https://api.github.com/repos/jgeewax/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/jgeewax/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jgeewax/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jgeewax/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgeewax/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/jgeewax/gcloud-python/releases{/id}","created_at":"2014-02-19T23:36:44Z","updated_at":"2015-04-17T18:50:37Z","pushed_at":"2015-06-23T13:19:00Z","git_url":"git://github.com/jgeewax/gcloud-python.git","ssh_url":"git@github.com:jgeewax/gcloud-python.git","clone_url":"https://github.com/jgeewax/gcloud-python.git","svn_url":"https://github.com/jgeewax/gcloud-python","homepage":"http://jgeewax.github.io/gcloud-python/","size":30298,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"85c7e371af08522058074d4fcbb1e188bf5bd9fe","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"gcloud-python","full_name":"GoogleCloudPlatform/gcloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/releases{/id}","created_at":"2014-01-28T15:51:47Z","updated_at":"2015-06-19T17:06:29Z","pushed_at":"2015-06-23T19:24:05Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":35308,"stargazers_count":175,"watchers_count":175,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":103,"forks":96,"open_issues":103,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/933"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/933"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/933/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/933/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/statuses/5456bfb580b54743ea0ab2ac03154d55216d808b"}}}}