{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/48589705","id":48589705,"diff_hunk":"@@ -157,7 +154,26 @@ func (g *genDeepCopy) copyableWithinPackage(t *types.Type) bool {\n \t\treturn false\n \t}\n \t// TODO: Consider generating functions for other kinds too.\n-\treturn t.Kind == types.Struct\n+\tif t.Kind != types.Struct {\n+\t\treturn false\n+\t}\n+\t// TODO: This should be removed once we start generating public DeepCopy\n+\t// functions per directory.\n+\tif t.Name.Package != g.targetPackage {\n+\t\t// We won't be able to access private fields.\n+\t\t// Thus, this type cannot have private fields.\n+\t\tfor _, member := range t.Members {\n+\t\t\tif strings.ToLower(member.Name[:1]) == member.Name[:1] {\n+\t\t\t\treturn false\n+\t\t\t}\n+\t\t\t// TODO: This is a temporary hack, to make avoid generating function\n+\t\t\t// for conversion.Equalities. We should get rid of it.","path":"cmd/libs/go2idl/deepcopy-gen/generators/deepcopy.go","position":37,"original_position":37,"commit_id":"baf97c9c5e51b1208e9f8fdaa05f780a636204b0","original_commit_id":"baf97c9c5e51b1208e9f8fdaa05f780a636204b0","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"No - actually I meant this one:\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/conversion/deep_equal.go#L25\r\n\r\nBasically, generator is currently not able to generate the deep-copy function for such structs. Since this is actually not needed for now and currently it's not causing us any other problems (all functions that are supposed to be generated are generated), I think it's temporary fine.","created_at":"2015-12-30T07:16:31Z","updated_at":"2015-12-30T07:16:31Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18156#discussion_r48589705","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/48589705"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18156#discussion_r48589705"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156","id":52544682,"html_url":"https://github.com/kubernetes/kubernetes/pull/18156","diff_url":"https://github.com/kubernetes/kubernetes/pull/18156.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18156.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18156","number":18156,"state":"open","locked":false,"title":"First use of new deep-copy generator.","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"My plan for enabling it is:\r\n- first use the new generator to generate only pkg/api/deep_copy_generated.go (to see if that really works)\r\n- once this is done (and works for few days), change it so that we generate per-directory public DeepCopy functions\r\n\r\n@lavalamp - FYI ^^","created_at":"2015-12-03T14:59:15Z","updated_at":"2015-12-30T07:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da570158eefd23e6f6c43b0d8d4b06084701237b","assignee":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18156/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/baf97c9c5e51b1208e9f8fdaa05f780a636204b0","head":{"label":"wojtek-t:use_new_deep_copies","ref":"use_new_deep_copies","sha":"baf97c9c5e51b1208e9f8fdaa05f780a636204b0","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"repo":{"id":30216785,"name":"kubernetes","full_name":"wojtek-t/kubernetes","owner":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtek-t/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/wojtek-t/kubernetes","forks_url":"https://api.github.com/repos/wojtek-t/kubernetes/forks","keys_url":"https://api.github.com/repos/wojtek-t/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtek-t/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtek-t/kubernetes/teams","hooks_url":"https://api.github.com/repos/wojtek-t/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wojtek-t/kubernetes/events","assignees_url":"https://api.github.com/repos/wojtek-t/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wojtek-t/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/tags","blobs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtek-t/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtek-t/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wojtek-t/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wojtek-t/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscription","commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtek-t/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtek-t/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wojtek-t/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtek-t/kubernetes/merges","archive_url":"https://api.github.com/repos/wojtek-t/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtek-t/kubernetes/downloads","issues_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wojtek-t/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtek-t/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtek-t/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtek-t/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wojtek-t/kubernetes/releases{/id}","created_at":"2015-02-03T00:37:55Z","updated_at":"2015-04-30T12:14:58Z","pushed_at":"2015-12-29T17:07:13Z","git_url":"git://github.com/wojtek-t/kubernetes.git","ssh_url":"git@github.com:wojtek-t/kubernetes.git","clone_url":"https://github.com/wojtek-t/kubernetes.git","svn_url":"https://github.com/wojtek-t/kubernetes","homepage":"http://kubernetes.io","size":140072,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"13a853f3717e64c3519b98dd04dbb867513fe7f9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-30T07:13:49Z","pushed_at":"2015-12-30T07:09:55Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":300287,"stargazers_count":11911,"watchers_count":11911,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3296,"mirror_url":null,"open_issues_count":2656,"forks":3296,"open_issues":2656,"watchers":11911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18156"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18156"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18156/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18156/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/baf97c9c5e51b1208e9f8fdaa05f780a636204b0"}}}}