{"action":"created","issue":{"url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/1","labels_url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/1/comments","events_url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/1/events","html_url":"https://github.com/catalyst/moodle-tool_coursebank/issues/1","id":102683032,"number":1,"title":"ajax.php","user":{"login":"danmarsden","id":362798,"avatar_url":"https://avatars.githubusercontent.com/u/362798?v=3","gravatar_id":"","url":"https://api.github.com/users/danmarsden","html_url":"https://github.com/danmarsden","followers_url":"https://api.github.com/users/danmarsden/followers","following_url":"https://api.github.com/users/danmarsden/following{/other_user}","gists_url":"https://api.github.com/users/danmarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/danmarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmarsden/subscriptions","organizations_url":"https://api.github.com/users/danmarsden/orgs","repos_url":"https://api.github.com/users/danmarsden/repos","events_url":"https://api.github.com/users/danmarsden/events{/privacy}","received_events_url":"https://api.github.com/users/danmarsden/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-24T01:35:36Z","updated_at":"2015-08-27T01:15:06Z","closed_at":"2015-08-27T01:15:06Z","body":"As a plugin guardian I saw this come through in the plugins db for approval - Great!!!\r\n\r\nThis looks strange to me:\r\nhttps://github.com/catalyst/moodle-tool_coursebank/blob/master/ajax.php#L27\r\n\r\nusually we use MOODLE_INTERNAL like this:\r\ndefined('MOODLE_INTERNAL') || die();\r\n\r\nbut that obviously isn't what you want here. You might just want to remove the line as I don't think it will actually do anything (unless I'm missing something)\r\n\r\nI'm also suspicious to see that the $action allows speedtest and conncheck to occur even if the user isn't logged in. It would probably be good to add some comments to the file to state why Anon access is required.\r\n"},"comment":{"url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/comments/135230786","html_url":"https://github.com/catalyst/moodle-tool_coursebank/issues/1#issuecomment-135230786","issue_url":"https://api.github.com/repos/catalyst/moodle-tool_coursebank/issues/1","id":135230786,"user":{"login":"danmarsden","id":362798,"avatar_url":"https://avatars.githubusercontent.com/u/362798?v=3","gravatar_id":"","url":"https://api.github.com/users/danmarsden","html_url":"https://github.com/danmarsden","followers_url":"https://api.github.com/users/danmarsden/followers","following_url":"https://api.github.com/users/danmarsden/following{/other_user}","gists_url":"https://api.github.com/users/danmarsden/gists{/gist_id}","starred_url":"https://api.github.com/users/danmarsden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmarsden/subscriptions","organizations_url":"https://api.github.com/users/danmarsden/orgs","repos_url":"https://api.github.com/users/danmarsden/repos","events_url":"https://api.github.com/users/danmarsden/events{/privacy}","received_events_url":"https://api.github.com/users/danmarsden/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T01:15:06Z","updated_at":"2015-08-27T01:15:06Z","body":"much better thanks!"}}