{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/30910025","id":30910025,"diff_hunk":"@@ -131,4 +145,29 @@ public boolean equals(Object other) {\n \tpublic String toString() {\n \t\treturn \"DeltaPolicy(\" + threshold + \", \" + deltaFuntion.getClass().getSimpleName() + \")\";\n \t}\n+\n+\tprivate void writeObject(ObjectOutputStream stream) throws IOException{\n+\t\tstream.writeObject(deltaFuntion);\n+\t\tstream.writeObject(windowBuffer);\n+\t\tstream.writeDouble(threshold);","path":"flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/windowing/policy/DeltaPolicy.java","position":87,"original_position":87,"commit_id":"9d31a3a6ca4512d3031a38154bf1475c52375b64","original_commit_id":"9d31a3a6ca4512d3031a38154bf1475c52375b64","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"as Gyula said, you can use defaultWriteObject here","created_at":"2015-05-22T16:30:22Z","updated_at":"2015-05-22T16:30:22Z","html_url":"https://github.com/apache/flink/pull/697#discussion_r30910025","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/30910025"},"html":{"href":"https://github.com/apache/flink/pull/697#discussion_r30910025"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/697","id":35733356,"html_url":"https://github.com/apache/flink/pull/697","diff_url":"https://github.com/apache/flink/pull/697.diff","patch_url":"https://github.com/apache/flink/pull/697.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/697","number":697,"state":"open","locked":false,"title":"[FLINK-2007] [streaming] Proper Delta policy serialization","user":{"login":"mbalassi","id":5990983,"avatar_url":"https://avatars.githubusercontent.com/u/5990983?v=3","gravatar_id":"","url":"https://api.github.com/users/mbalassi","html_url":"https://github.com/mbalassi","followers_url":"https://api.github.com/users/mbalassi/followers","following_url":"https://api.github.com/users/mbalassi/following{/other_user}","gists_url":"https://api.github.com/users/mbalassi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalassi/subscriptions","organizations_url":"https://api.github.com/users/mbalassi/orgs","repos_url":"https://api.github.com/users/mbalassi/repos","events_url":"https://api.github.com/users/mbalassi/events{/privacy}","received_events_url":"https://api.github.com/users/mbalassi/received_events","type":"User","site_admin":false},"body":"The initial value passed to the Delta policy has to be serialized to be transferred to the cluster. This change adds the standard Flink serializers for that job. The API is preserved on the level of the `Delta`, but the `DeltaPolicy` itself explicitly needs the serializer.\r\n\r\nTest4 in`ComplexIntegrationTest` demonstrates and tests my change in action.","created_at":"2015-05-19T14:04:07Z","updated_at":"2015-05-22T16:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f06575459f865b05d35968952ba9ad4f901e2d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/697/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/697/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/697/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/9d31a3a6ca4512d3031a38154bf1475c52375b64","head":{"label":"mbalassi:delta-serialize","ref":"delta-serialize","sha":"9d31a3a6ca4512d3031a38154bf1475c52375b64","user":{"login":"mbalassi","id":5990983,"avatar_url":"https://avatars.githubusercontent.com/u/5990983?v=3","gravatar_id":"","url":"https://api.github.com/users/mbalassi","html_url":"https://github.com/mbalassi","followers_url":"https://api.github.com/users/mbalassi/followers","following_url":"https://api.github.com/users/mbalassi/following{/other_user}","gists_url":"https://api.github.com/users/mbalassi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalassi/subscriptions","organizations_url":"https://api.github.com/users/mbalassi/orgs","repos_url":"https://api.github.com/users/mbalassi/repos","events_url":"https://api.github.com/users/mbalassi/events{/privacy}","received_events_url":"https://api.github.com/users/mbalassi/received_events","type":"User","site_admin":false},"repo":{"id":23103516,"name":"flink","full_name":"mbalassi/flink","owner":{"login":"mbalassi","id":5990983,"avatar_url":"https://avatars.githubusercontent.com/u/5990983?v=3","gravatar_id":"","url":"https://api.github.com/users/mbalassi","html_url":"https://github.com/mbalassi","followers_url":"https://api.github.com/users/mbalassi/followers","following_url":"https://api.github.com/users/mbalassi/following{/other_user}","gists_url":"https://api.github.com/users/mbalassi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalassi/subscriptions","organizations_url":"https://api.github.com/users/mbalassi/orgs","repos_url":"https://api.github.com/users/mbalassi/repos","events_url":"https://api.github.com/users/mbalassi/events{/privacy}","received_events_url":"https://api.github.com/users/mbalassi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbalassi/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/mbalassi/flink","forks_url":"https://api.github.com/repos/mbalassi/flink/forks","keys_url":"https://api.github.com/repos/mbalassi/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbalassi/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbalassi/flink/teams","hooks_url":"https://api.github.com/repos/mbalassi/flink/hooks","issue_events_url":"https://api.github.com/repos/mbalassi/flink/issues/events{/number}","events_url":"https://api.github.com/repos/mbalassi/flink/events","assignees_url":"https://api.github.com/repos/mbalassi/flink/assignees{/user}","branches_url":"https://api.github.com/repos/mbalassi/flink/branches{/branch}","tags_url":"https://api.github.com/repos/mbalassi/flink/tags","blobs_url":"https://api.github.com/repos/mbalassi/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbalassi/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbalassi/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbalassi/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbalassi/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/mbalassi/flink/languages","stargazers_url":"https://api.github.com/repos/mbalassi/flink/stargazers","contributors_url":"https://api.github.com/repos/mbalassi/flink/contributors","subscribers_url":"https://api.github.com/repos/mbalassi/flink/subscribers","subscription_url":"https://api.github.com/repos/mbalassi/flink/subscription","commits_url":"https://api.github.com/repos/mbalassi/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbalassi/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbalassi/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbalassi/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbalassi/flink/contents/{+path}","compare_url":"https://api.github.com/repos/mbalassi/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbalassi/flink/merges","archive_url":"https://api.github.com/repos/mbalassi/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbalassi/flink/downloads","issues_url":"https://api.github.com/repos/mbalassi/flink/issues{/number}","pulls_url":"https://api.github.com/repos/mbalassi/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/mbalassi/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/mbalassi/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbalassi/flink/labels{/name}","releases_url":"https://api.github.com/repos/mbalassi/flink/releases{/id}","created_at":"2014-08-19T08:57:18Z","updated_at":"2015-05-08T10:30:07Z","pushed_at":"2015-05-21T23:30:20Z","git_url":"git://github.com/mbalassi/flink.git","ssh_url":"git@github.com:mbalassi/flink.git","clone_url":"https://github.com/mbalassi/flink.git","svn_url":"https://github.com/mbalassi/flink","homepage":null,"size":52513,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3cd36a51d104865540ec23ee326e1c810317c860","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-05-22T15:54:57Z","pushed_at":"2015-05-22T16:15:25Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":3156693,"stargazers_count":420,"watchers_count":420,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":48,"forks":263,"open_issues":48,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/697"},"html":{"href":"https://github.com/apache/flink/pull/697"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/697"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/9d31a3a6ca4512d3031a38154bf1475c52375b64"}}}}