{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/28937324","id":28937324,"diff_hunk":"@@ -36,6 +36,8 @@ private[spark] object SQLConf {\n   val PARQUET_INT96_AS_TIMESTAMP = \"spark.sql.parquet.int96AsTimestamp\"\n   val PARQUET_CACHE_METADATA = \"spark.sql.parquet.cacheMetadata\"\n   val PARQUET_COMPRESSION = \"spark.sql.parquet.compression.codec\"\n+  val PARQUET_BLOCK_SIZE = \"spark.sql.parquet.blocksize\"\n+  val PARQUET_PAGE_SIZE = \"spark.sql.parquet.pagesize\"","path":"sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala","position":5,"original_position":5,"commit_id":"62e587f40f7b06127c761152cddab7e75dc83879","original_commit_id":"62e587f40f7b06127c761152cddab7e75dc83879","user":{"login":"yhuai","id":2072857,"avatar_url":"https://avatars.githubusercontent.com/u/2072857?v=3","gravatar_id":"","url":"https://api.github.com/users/yhuai","html_url":"https://github.com/yhuai","followers_url":"https://api.github.com/users/yhuai/followers","following_url":"https://api.github.com/users/yhuai/following{/other_user}","gists_url":"https://api.github.com/users/yhuai/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuai/subscriptions","organizations_url":"https://api.github.com/users/yhuai/orgs","repos_url":"https://api.github.com/users/yhuai/repos","events_url":"https://api.github.com/users/yhuai/events{/privacy}","received_events_url":"https://api.github.com/users/yhuai/received_events","type":"User","site_admin":false},"body":"I meant Parquet should have its own conf keys for those, right? I do not need to add spark sql ones.\r\n\r\nSee https://github.com/apache/parquet-mr/blob/parquet-1.6.0rc3/parquet-hadoop/src/main/java/parquet/hadoop/ParquetOutputFormat.java#L98-L106 ","created_at":"2015-04-23T05:31:59Z","updated_at":"2015-04-23T05:31:59Z","html_url":"https://github.com/apache/spark/pull/5630#discussion_r28937324","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5630","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/28937324"},"html":{"href":"https://github.com/apache/spark/pull/5630#discussion_r28937324"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5630"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5630","id":33834380,"html_url":"https://github.com/apache/spark/pull/5630","diff_url":"https://github.com/apache/spark/pull/5630.diff","patch_url":"https://github.com/apache/spark/pull/5630.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5630","number":5630,"state":"open","locked":false,"title":"[SPARK-7051] [SQL] Configuration for parquet data writting","user":{"login":"chenghao-intel","id":2367031,"avatar_url":"https://avatars.githubusercontent.com/u/2367031?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghao-intel","html_url":"https://github.com/chenghao-intel","followers_url":"https://api.github.com/users/chenghao-intel/followers","following_url":"https://api.github.com/users/chenghao-intel/following{/other_user}","gists_url":"https://api.github.com/users/chenghao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghao-intel/subscriptions","organizations_url":"https://api.github.com/users/chenghao-intel/orgs","repos_url":"https://api.github.com/users/chenghao-intel/repos","events_url":"https://api.github.com/users/chenghao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/chenghao-intel/received_events","type":"User","site_admin":false},"body":"```\r\nCREATE TABLE parquet_test (\r\n id int,\r\n str string) \r\nSTORED AS PARQUET;\r\nset spark.sql.parquet.compression.codec=snappy;\r\ninsert into table parquet_test select * from src;\r\n```","created_at":"2015-04-22T08:01:20Z","updated_at":"2015-04-23T05:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cbe37b902a56665ccd7148d49e5f06f31e80c9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5630/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5630/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5630/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/62e587f40f7b06127c761152cddab7e75dc83879","head":{"label":"chenghao-intel:parquet","ref":"parquet","sha":"62e587f40f7b06127c761152cddab7e75dc83879","user":{"login":"chenghao-intel","id":2367031,"avatar_url":"https://avatars.githubusercontent.com/u/2367031?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghao-intel","html_url":"https://github.com/chenghao-intel","followers_url":"https://api.github.com/users/chenghao-intel/followers","following_url":"https://api.github.com/users/chenghao-intel/following{/other_user}","gists_url":"https://api.github.com/users/chenghao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghao-intel/subscriptions","organizations_url":"https://api.github.com/users/chenghao-intel/orgs","repos_url":"https://api.github.com/users/chenghao-intel/repos","events_url":"https://api.github.com/users/chenghao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/chenghao-intel/received_events","type":"User","site_admin":false},"repo":{"id":18098468,"name":"spark","full_name":"chenghao-intel/spark","owner":{"login":"chenghao-intel","id":2367031,"avatar_url":"https://avatars.githubusercontent.com/u/2367031?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghao-intel","html_url":"https://github.com/chenghao-intel","followers_url":"https://api.github.com/users/chenghao-intel/followers","following_url":"https://api.github.com/users/chenghao-intel/following{/other_user}","gists_url":"https://api.github.com/users/chenghao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghao-intel/subscriptions","organizations_url":"https://api.github.com/users/chenghao-intel/orgs","repos_url":"https://api.github.com/users/chenghao-intel/repos","events_url":"https://api.github.com/users/chenghao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/chenghao-intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenghao-intel/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/chenghao-intel/spark","forks_url":"https://api.github.com/repos/chenghao-intel/spark/forks","keys_url":"https://api.github.com/repos/chenghao-intel/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenghao-intel/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenghao-intel/spark/teams","hooks_url":"https://api.github.com/repos/chenghao-intel/spark/hooks","issue_events_url":"https://api.github.com/repos/chenghao-intel/spark/issues/events{/number}","events_url":"https://api.github.com/repos/chenghao-intel/spark/events","assignees_url":"https://api.github.com/repos/chenghao-intel/spark/assignees{/user}","branches_url":"https://api.github.com/repos/chenghao-intel/spark/branches{/branch}","tags_url":"https://api.github.com/repos/chenghao-intel/spark/tags","blobs_url":"https://api.github.com/repos/chenghao-intel/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenghao-intel/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenghao-intel/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenghao-intel/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenghao-intel/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/chenghao-intel/spark/languages","stargazers_url":"https://api.github.com/repos/chenghao-intel/spark/stargazers","contributors_url":"https://api.github.com/repos/chenghao-intel/spark/contributors","subscribers_url":"https://api.github.com/repos/chenghao-intel/spark/subscribers","subscription_url":"https://api.github.com/repos/chenghao-intel/spark/subscription","commits_url":"https://api.github.com/repos/chenghao-intel/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenghao-intel/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenghao-intel/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenghao-intel/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenghao-intel/spark/contents/{+path}","compare_url":"https://api.github.com/repos/chenghao-intel/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenghao-intel/spark/merges","archive_url":"https://api.github.com/repos/chenghao-intel/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenghao-intel/spark/downloads","issues_url":"https://api.github.com/repos/chenghao-intel/spark/issues{/number}","pulls_url":"https://api.github.com/repos/chenghao-intel/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/chenghao-intel/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/chenghao-intel/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenghao-intel/spark/labels{/name}","releases_url":"https://api.github.com/repos/chenghao-intel/spark/releases{/id}","created_at":"2014-03-25T11:52:04Z","updated_at":"2015-03-05T08:13:37Z","pushed_at":"2015-04-22T07:58:02Z","git_url":"git://github.com/chenghao-intel/spark.git","ssh_url":"git@github.com:chenghao-intel/spark.git","clone_url":"https://github.com/chenghao-intel/spark.git","svn_url":"https://github.com/chenghao-intel/spark","homepage":null,"size":102661,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bdc5c16e76c5d0bc147408353b2ba4faa8e914fc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-04-23T05:09:01Z","pushed_at":"2015-04-23T05:28:20Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1531101,"stargazers_count":3706,"watchers_count":3706,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3227,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":301,"forks":3227,"open_issues":301,"watchers":3706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5630"},"html":{"href":"https://github.com/apache/spark/pull/5630"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5630"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5630/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5630/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5630/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/62e587f40f7b06127c761152cddab7e75dc83879"}}}}