{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/25177523","id":25177523,"diff_hunk":"@@ -202,22 +202,10 @@ DGKernel::computeOffDiagElemNeighJacobian(Moose::DGJacobianType type,unsigned in\n void\n DGKernel::computeOffDiagJacobian(unsigned int jvar)\n {\n-  if (jvar == _var.number())\n-    computeJacobian();\n-  else\n-  {\n-    // Compute element-element Jacobian\n-    computeOffDiagElemNeighJacobian(Moose::ElementElement,jvar);\n-\n-    // Compute element-neighbor Jacobian\n-    computeOffDiagElemNeighJacobian(Moose::ElementNeighbor,jvar);\n-\n-    // Compute neighbor-element Jacobian\n-    computeOffDiagElemNeighJacobian(Moose::NeighborElement,jvar);\n-\n-    // Compute neighbor-neighbor Jacobian\n-    computeOffDiagElemNeighJacobian(Moose::NeighborNeighbor,jvar);\n-  }\n+  computeOffDiagElemNeighJacobian(Moose::ElementElement,jvar);\n+  computeOffDiagElemNeighJacobian(Moose::ElementNeighbor,jvar);\n+  computeOffDiagElemNeighJacobian(Moose::NeighborElement,jvar);\n+  computeOffDiagElemNeighJacobian(Moose::NeighborNeighbor,jvar);","path":"framework/src/dgkernels/DGKernel.C","position":23,"original_position":23,"commit_id":"45171331088b139efcd80f39953ee5665ef79953","original_commit_id":"45171331088b139efcd80f39953ee5665ef79953","user":{"login":"jwpeterson","id":1775907,"avatar_url":"https://avatars.githubusercontent.com/u/1775907?v=3","gravatar_id":"","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"It seems like you are now assuming that `DGKernel::computeOffDiagJacobian()` will *never* be called with `jvar==_var.number()`.  This is certainly true based on your change to ComputeFullJacobianThread.C, but I wonder if it might be worth mooseAsserting that jvar != _var.number() in DGKernel::computeOffDiagJacobian() just to be sure someone doesn't call it in the wrong way later?","created_at":"2015-02-23T16:28:59Z","updated_at":"2015-02-23T16:28:59Z","html_url":"https://github.com/idaholab/moose/pull/4694#discussion_r25177523","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/4694","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/25177523"},"html":{"href":"https://github.com/idaholab/moose/pull/4694#discussion_r25177523"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4694"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/4694","id":29571528,"html_url":"https://github.com/idaholab/moose/pull/4694","diff_url":"https://github.com/idaholab/moose/pull/4694.diff","patch_url":"https://github.com/idaholab/moose/pull/4694.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/4694","number":4694,"state":"open","locked":false,"title":"Moved call to dgkernel computeJacobian from computeOffDiagJacobian to co...","user":{"login":"snschune","id":7524371,"avatar_url":"https://avatars.githubusercontent.com/u/7524371?v=3","gravatar_id":"","url":"https://api.github.com/users/snschune","html_url":"https://github.com/snschune","followers_url":"https://api.github.com/users/snschune/followers","following_url":"https://api.github.com/users/snschune/following{/other_user}","gists_url":"https://api.github.com/users/snschune/gists{/gist_id}","starred_url":"https://api.github.com/users/snschune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snschune/subscriptions","organizations_url":"https://api.github.com/users/snschune/orgs","repos_url":"https://api.github.com/users/snschune/repos","events_url":"https://api.github.com/users/snschune/events{/privacy}","received_events_url":"https://api.github.com/users/snschune/received_events","type":"User","site_admin":false},"body":"...mputeInternalFaceJacobian  #4693","created_at":"2015-02-18T22:49:52Z","updated_at":"2015-02-23T16:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae639cd925ae1e6ffe752865045612df80b0b603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/4694/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/4694/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/4694/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/45171331088b139efcd80f39953ee5665ef79953","head":{"label":"snschune:dg_jacobian_4693","ref":"dg_jacobian_4693","sha":"45171331088b139efcd80f39953ee5665ef79953","user":{"login":"snschune","id":7524371,"avatar_url":"https://avatars.githubusercontent.com/u/7524371?v=3","gravatar_id":"","url":"https://api.github.com/users/snschune","html_url":"https://github.com/snschune","followers_url":"https://api.github.com/users/snschune/followers","following_url":"https://api.github.com/users/snschune/following{/other_user}","gists_url":"https://api.github.com/users/snschune/gists{/gist_id}","starred_url":"https://api.github.com/users/snschune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snschune/subscriptions","organizations_url":"https://api.github.com/users/snschune/orgs","repos_url":"https://api.github.com/users/snschune/repos","events_url":"https://api.github.com/users/snschune/events{/privacy}","received_events_url":"https://api.github.com/users/snschune/received_events","type":"User","site_admin":false},"repo":{"id":19577338,"name":"moose","full_name":"snschune/moose","owner":{"login":"snschune","id":7524371,"avatar_url":"https://avatars.githubusercontent.com/u/7524371?v=3","gravatar_id":"","url":"https://api.github.com/users/snschune","html_url":"https://github.com/snschune","followers_url":"https://api.github.com/users/snschune/followers","following_url":"https://api.github.com/users/snschune/following{/other_user}","gists_url":"https://api.github.com/users/snschune/gists{/gist_id}","starred_url":"https://api.github.com/users/snschune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snschune/subscriptions","organizations_url":"https://api.github.com/users/snschune/orgs","repos_url":"https://api.github.com/users/snschune/repos","events_url":"https://api.github.com/users/snschune/events{/privacy}","received_events_url":"https://api.github.com/users/snschune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snschune/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/snschune/moose","forks_url":"https://api.github.com/repos/snschune/moose/forks","keys_url":"https://api.github.com/repos/snschune/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snschune/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snschune/moose/teams","hooks_url":"https://api.github.com/repos/snschune/moose/hooks","issue_events_url":"https://api.github.com/repos/snschune/moose/issues/events{/number}","events_url":"https://api.github.com/repos/snschune/moose/events","assignees_url":"https://api.github.com/repos/snschune/moose/assignees{/user}","branches_url":"https://api.github.com/repos/snschune/moose/branches{/branch}","tags_url":"https://api.github.com/repos/snschune/moose/tags","blobs_url":"https://api.github.com/repos/snschune/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snschune/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snschune/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/snschune/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snschune/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/snschune/moose/languages","stargazers_url":"https://api.github.com/repos/snschune/moose/stargazers","contributors_url":"https://api.github.com/repos/snschune/moose/contributors","subscribers_url":"https://api.github.com/repos/snschune/moose/subscribers","subscription_url":"https://api.github.com/repos/snschune/moose/subscription","commits_url":"https://api.github.com/repos/snschune/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/snschune/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/snschune/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/snschune/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/snschune/moose/contents/{+path}","compare_url":"https://api.github.com/repos/snschune/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snschune/moose/merges","archive_url":"https://api.github.com/repos/snschune/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snschune/moose/downloads","issues_url":"https://api.github.com/repos/snschune/moose/issues{/number}","pulls_url":"https://api.github.com/repos/snschune/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/snschune/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/snschune/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snschune/moose/labels{/name}","releases_url":"https://api.github.com/repos/snschune/moose/releases{/id}","created_at":"2014-05-08T14:54:30Z","updated_at":"2014-06-23T21:24:12Z","pushed_at":"2015-02-18T22:48:57Z","git_url":"git://github.com/snschune/moose.git","ssh_url":"git@github.com:snschune/moose.git","clone_url":"https://github.com/snschune/moose.git","svn_url":"https://github.com/snschune/moose","homepage":null,"size":82960,"stargazers_count":0,"watchers_count":0,"language":"Eiffel","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"5c1a542a3db5c4e7781aeb3706eeaa6ea8ffd626","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2015-02-23T16:20:41Z","pushed_at":"2015-02-23T16:20:29Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":null,"size":108265,"stargazers_count":71,"watchers_count":71,"language":"PostScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"open_issues_count":396,"forks":115,"open_issues":396,"watchers":71,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4694"},"html":{"href":"https://github.com/idaholab/moose/pull/4694"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/4694"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/4694/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4694/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/4694/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/45171331088b139efcd80f39953ee5665ef79953"}}}}