{"push_id":585345542,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"d71146b24db685bedaa9a6b5e6945607c0ec612b","before":"6ea0e46a37e2997d558c0f8f03d600b01c0dfa98","commits":[{"sha":"442fdddc185075347d04f99d9219ab02262f7230","author":{"email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org","name":"xor-freenet"},"message":"IdentityFetcher.stop(): JavaDoc\n\nThis unifies the doc with SubscriptionManager.stop()","distinct":true,"url":"https://api.github.com/repos/freenet/plugin-WebOfTrust/commits/442fdddc185075347d04f99d9219ab02262f7230"},{"sha":"d71146b24db685bedaa9a6b5e6945607c0ec612b","author":{"email":"f1922a234bb92764a276a8524d28cdb446d3c7da@freenetproject.org","name":"xor-freenet"},"message":"SubscriptionManager: Fix some unit tests failing due to \"Should not be\ncalled  before start() or after stop()\"\n\nSubscriptionManagerFCPTest.testSubscribeUnsubscribe() would\nfail with:\n[junit] Testcase: testSubscribeUnsubscribe took 14.278 sec\n[junit]     FAILED\n[junit] expected:<true> but was:<false>\n[junit] junit.framework.AssertionFailedError: expected:<true> but\nwas:<false>\n[junit]     at\nplugins.WebOfTrust.SubscriptionManagerFCPTest.testSubscribeTo(SubscriptionManagerFCPTest.java:203)\n[junit]     at\nplugins.WebOfTrust.SubscriptionManagerFCPTest.testSubscribeUnsubscribe(SubscriptionManagerFCPTest.java:159)\n[junit]     at\nplugins.WebOfTrust.SubscriptionManagerFCPTest.testSubscribeUnsubscribe(SubscriptionManagerFCPTest.java:150)\n\nThe fix is to make scheduleNotificationProcessing() NOT assert() that\nthe SubscriptionManager was not stop()ed yet. The unit tests\nintentionally stop() it, see AbstractFullNodeTest.setUpNode().\nTo make this fix possible, the class is modified to have its\nstart()/stop() and scheduleNotificationProcessing() to work the same way\nas the similar functions in IdentityFetcher\n(scheduleNotificationProcessing is called scheduleCommandProcessing\nthere). Particularly, the possible states of the mJob variable are\nchanged to clearly distinguish between the three states \"start() not\ncalled  yet\", \"start() called\", \"stop() called\". This allows us to keep\nan \"assert(!(start not called))\" in scheduleNotificationProcessing()\ninstead of only having an \"assert(!(start() not called OR stop not\ncalled))\". So we can preserve some assert-safety.\n\nThis fix is only for class SubscriptionManager. Similar fixes are to\nfollow for TransferThread.","distinct":true,"url":"https://api.github.com/repos/freenet/plugin-WebOfTrust/commits/d71146b24db685bedaa9a6b5e6945607c0ec612b"}]}