{"action":"created","issue":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/1946","labels_url":"https://api.github.com/repos/torchbox/wagtail/issues/1946/labels{/name}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/1946/comments","events_url":"https://api.github.com/repos/torchbox/wagtail/issues/1946/events","html_url":"https://github.com/torchbox/wagtail/pull/1946","id":117938973,"number":1946,"title":"Move rollbacks to contrib module, added diff view for textual diffs","user":{"login":"JoshBarr","id":1715456,"avatar_url":"https://avatars.githubusercontent.com/u/1715456?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBarr","html_url":"https://github.com/JoshBarr","followers_url":"https://api.github.com/users/JoshBarr/followers","following_url":"https://api.github.com/users/JoshBarr/following{/other_user}","gists_url":"https://api.github.com/users/JoshBarr/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBarr/subscriptions","organizations_url":"https://api.github.com/users/JoshBarr/orgs","repos_url":"https://api.github.com/users/JoshBarr/repos","events_url":"https://api.github.com/users/JoshBarr/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBarr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/torchbox/wagtail/labels/Needs%20review","name":"Needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/torchbox/wagtail/milestones/19","html_url":"https://github.com/torchbox/wagtail/milestones/1.3","labels_url":"https://api.github.com/repos/torchbox/wagtail/milestones/19/labels","id":1347538,"number":19,"title":"1.3","description":"☃ The Christmas Special ☃","creator":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":20,"state":"open","created_at":"2015-10-09T16:33:13Z","updated_at":"2015-11-27T16:16:15Z","due_on":"2015-12-17T00:00:00Z","closed_at":null},"comments":5,"created_at":"2015-11-20T00:20:14Z","updated_at":"2015-11-27T20:05:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/1946","html_url":"https://github.com/torchbox/wagtail/pull/1946","diff_url":"https://github.com/torchbox/wagtail/pull/1946.diff","patch_url":"https://github.com/torchbox/wagtail/pull/1946.patch"},"body":"I've imported the rollbacks module from Wagtailplus and wired it up in contrib.\r\n\r\nAlso, have included a simple diff view for comparing the text contents of a page: \r\n\r\n![screen shot 2015-11-20 at 12 48 43 pm](https://cloud.githubusercontent.com/assets/1715456/11288451/04160b6c-8f89-11e5-9630-c338d0ca089a.png)\r\n \r\nThis needs a little work (what do do if a Page has no text fields, for instance), but thought it would be a useful addition to the history module – especially if you're using Wagtail as an API, where previewing via the front-end won't work so well. \r\n"},"comment":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/comments/160198211","html_url":"https://github.com/torchbox/wagtail/pull/1946#issuecomment-160198211","issue_url":"https://api.github.com/repos/torchbox/wagtail/issues/1946","id":160198211,"user":{"login":"tomdyson","id":15543,"avatar_url":"https://avatars.githubusercontent.com/u/15543?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdyson","html_url":"https://github.com/tomdyson","followers_url":"https://api.github.com/users/tomdyson/followers","following_url":"https://api.github.com/users/tomdyson/following{/other_user}","gists_url":"https://api.github.com/users/tomdyson/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdyson/subscriptions","organizations_url":"https://api.github.com/users/tomdyson/orgs","repos_url":"https://api.github.com/users/tomdyson/repos","events_url":"https://api.github.com/users/tomdyson/events{/privacy}","received_events_url":"https://api.github.com/users/tomdyson/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T20:05:20Z","updated_at":"2015-11-27T20:05:20Z","body":"Some context on @bouncingdan's comment, for @JoshBarr and others. Torchbox and fffunction discussed revisions today, as part of a day-long sprint. We agreed that a new tab (as used in the Wagtailplus Rollbacks app) isn't the right place to access revision history; for one thing, the current edited state of the content edit form shouldn't be lost when moving between tabs, and clicking 'compare' within the 'history' tab breaks this pattern by moving to a new URL. We suggested that the right hand side of the footer bar is a better fit, partly because it's linked to the existing information about the most recent edit. \r\n\r\nThe next question is where to present the listing of revisions, if it's not in a new tab. We want to avoid another modal, because modals are hard to handle on mobile devices. We suggest a new view, with enough context so that it's easy to return to the edit view. On a related point, we want to implement a 'dirty forms' handler, e.g. https://github.com/codedance/jquery.AreYouSure, to prevent users from inadvertently losing their edits when they navigate away."}}