{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/36051711","id":36051711,"diff_hunk":"@@ -36,7 +36,11 @@ case class UnaryMinus(child: Expression) extends UnaryExpression with ExpectsInp\n \n   override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = dataType match {\n     case dt: DecimalType => defineCodeGen(ctx, ev, c => s\"$c.unary_$$minus()\")\n-    case dt: NumericType => defineCodeGen(ctx, ev, c => s\"(${ctx.javaType(dt)})(-($c))\")\n+    case dt: NumericType => nullSafeCodeGen(ctx, ev, eval => {\n+      s\"\"\"\n+        ${ctx.javaType(dt)} um = (${ctx.javaType(dt)})($eval);","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala","position":7,"original_position":7,"commit_id":"42769b068aa215e98de6fc8cbce2a2e76e715042","original_commit_id":"42769b068aa215e98de6fc8cbce2a2e76e715042","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"what is um?\r\n\r\nDon't you need to use a fresh name for this?","created_at":"2015-08-03T01:49:26Z","updated_at":"2015-08-03T01:49:26Z","html_url":"https://github.com/apache/spark/pull/7855#discussion_r36051711","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7855","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/36051711"},"html":{"href":"https://github.com/apache/spark/pull/7855#discussion_r36051711"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7855"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7855","id":41403699,"html_url":"https://github.com/apache/spark/pull/7855","diff_url":"https://github.com/apache/spark/pull/7855.diff","patch_url":"https://github.com/apache/spark/pull/7855.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7855","number":7855,"state":"open","locked":false,"title":"[SPARK-9526][SQL] Utilize randomized tests to reveal potential bugs in sql expressions","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.apache.org/jira/browse/SPARK-9526\r\n\r\nThis PR is a follow up of #7830, aiming at utilizing randomized tests to reveal more potential bugs in sql expression.","created_at":"2015-08-01T16:11:42Z","updated_at":"2015-08-03T01:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"259165bb395df2efe7f88f02392c9cbfca9defe2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7855/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7855/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7855/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/42769b068aa215e98de6fc8cbce2a2e76e715042","head":{"label":"yjshen:property_check","ref":"property_check","sha":"42769b068aa215e98de6fc8cbce2a2e76e715042","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"repo":{"id":32433144,"name":"spark","full_name":"yjshen/spark","owner":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjshen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yjshen/spark","forks_url":"https://api.github.com/repos/yjshen/spark/forks","keys_url":"https://api.github.com/repos/yjshen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjshen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjshen/spark/teams","hooks_url":"https://api.github.com/repos/yjshen/spark/hooks","issue_events_url":"https://api.github.com/repos/yjshen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yjshen/spark/events","assignees_url":"https://api.github.com/repos/yjshen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yjshen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yjshen/spark/tags","blobs_url":"https://api.github.com/repos/yjshen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjshen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjshen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjshen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjshen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yjshen/spark/languages","stargazers_url":"https://api.github.com/repos/yjshen/spark/stargazers","contributors_url":"https://api.github.com/repos/yjshen/spark/contributors","subscribers_url":"https://api.github.com/repos/yjshen/spark/subscribers","subscription_url":"https://api.github.com/repos/yjshen/spark/subscription","commits_url":"https://api.github.com/repos/yjshen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjshen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjshen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjshen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjshen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yjshen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjshen/spark/merges","archive_url":"https://api.github.com/repos/yjshen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjshen/spark/downloads","issues_url":"https://api.github.com/repos/yjshen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yjshen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yjshen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yjshen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjshen/spark/labels{/name}","releases_url":"https://api.github.com/repos/yjshen/spark/releases{/id}","created_at":"2015-03-18T02:27:58Z","updated_at":"2015-05-02T04:50:02Z","pushed_at":"2015-08-02T16:30:31Z","git_url":"git://github.com/yjshen/spark.git","ssh_url":"git@github.com:yjshen/spark.git","clone_url":"https://github.com/yjshen/spark.git","svn_url":"https://github.com/yjshen/spark","homepage":null,"size":116956,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"16b928c5436b9b500d25b49bf3670bc50ddafbf9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-08-03T01:22:04Z","pushed_at":"2015-08-03T01:16:22Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1642747,"stargazers_count":4942,"watchers_count":4942,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4482,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":328,"forks":4482,"open_issues":328,"watchers":4942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7855"},"html":{"href":"https://github.com/apache/spark/pull/7855"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7855"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7855/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7855/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7855/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/42769b068aa215e98de6fc8cbce2a2e76e715042"}}}}