{"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/mmozuras/pronto/pulls/75","id":30998984,"html_url":"https://github.com/mmozuras/pronto/pull/75","diff_url":"https://github.com/mmozuras/pronto/pull/75.diff","patch_url":"https://github.com/mmozuras/pronto/pull/75.patch","issue_url":"https://api.github.com/repos/mmozuras/pronto/issues/75","number":75,"state":"closed","locked":false,"title":"Possible fix for issue with Github PR formatter commenting on wrong lines","user":{"login":"11mdlow","id":698419,"avatar_url":"https://avatars.githubusercontent.com/u/698419?v=3","gravatar_id":"","url":"https://api.github.com/users/11mdlow","html_url":"https://github.com/11mdlow","followers_url":"https://api.github.com/users/11mdlow/followers","following_url":"https://api.github.com/users/11mdlow/following{/other_user}","gists_url":"https://api.github.com/users/11mdlow/gists{/gist_id}","starred_url":"https://api.github.com/users/11mdlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/11mdlow/subscriptions","organizations_url":"https://api.github.com/users/11mdlow/orgs","repos_url":"https://api.github.com/users/11mdlow/repos","events_url":"https://api.github.com/users/11mdlow/events{/privacy}","received_events_url":"https://api.github.com/users/11mdlow/received_events","type":"User","site_admin":false},"body":"Alright, this is to follow up to my previous pr: https://github.com/mmozuras/pronto/pull/72 and is an attempt to fix #39.\r\n\r\nThe issue is still the same: pronto has issues where you make commits/changes around the same sections of code, as it will actually pick up a line from it's last context, and not when it was added. This then calculates an incorrect position, and comments on a wrong line.\r\n\r\nI'll admit this isn't be ideal behavior, as it will now comment on an outdated diff, but to me it is better than commenting on the wrong line.\r\n\r\nWhat do you think?","created_at":"2015-03-12T00:30:43Z","updated_at":"2015-09-20T08:49:56Z","closed_at":"2015-09-20T08:49:56Z","merged_at":null,"merge_commit_sha":"4fa18ed7ff6988c76413a9a2af7af3c4c999016f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mmozuras/pronto/pulls/75/commits","review_comments_url":"https://api.github.com/repos/mmozuras/pronto/pulls/75/comments","review_comment_url":"https://api.github.com/repos/mmozuras/pronto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mmozuras/pronto/issues/75/comments","statuses_url":"https://api.github.com/repos/mmozuras/pronto/statuses/1ae25d466cc7b1c9d9bbbace8db0e14efd9772eb","head":{"label":"11mdlow:only_additions","ref":"only_additions","sha":"1ae25d466cc7b1c9d9bbbace8db0e14efd9772eb","user":{"login":"11mdlow","id":698419,"avatar_url":"https://avatars.githubusercontent.com/u/698419?v=3","gravatar_id":"","url":"https://api.github.com/users/11mdlow","html_url":"https://github.com/11mdlow","followers_url":"https://api.github.com/users/11mdlow/followers","following_url":"https://api.github.com/users/11mdlow/following{/other_user}","gists_url":"https://api.github.com/users/11mdlow/gists{/gist_id}","starred_url":"https://api.github.com/users/11mdlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/11mdlow/subscriptions","organizations_url":"https://api.github.com/users/11mdlow/orgs","repos_url":"https://api.github.com/users/11mdlow/repos","events_url":"https://api.github.com/users/11mdlow/events{/privacy}","received_events_url":"https://api.github.com/users/11mdlow/received_events","type":"User","site_admin":false},"repo":{"id":31743126,"name":"pronto","full_name":"11mdlow/pronto","owner":{"login":"11mdlow","id":698419,"avatar_url":"https://avatars.githubusercontent.com/u/698419?v=3","gravatar_id":"","url":"https://api.github.com/users/11mdlow","html_url":"https://github.com/11mdlow","followers_url":"https://api.github.com/users/11mdlow/followers","following_url":"https://api.github.com/users/11mdlow/following{/other_user}","gists_url":"https://api.github.com/users/11mdlow/gists{/gist_id}","starred_url":"https://api.github.com/users/11mdlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/11mdlow/subscriptions","organizations_url":"https://api.github.com/users/11mdlow/orgs","repos_url":"https://api.github.com/users/11mdlow/repos","events_url":"https://api.github.com/users/11mdlow/events{/privacy}","received_events_url":"https://api.github.com/users/11mdlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/11mdlow/pronto","description":"Quick automated code review of your changes","fork":true,"url":"https://api.github.com/repos/11mdlow/pronto","forks_url":"https://api.github.com/repos/11mdlow/pronto/forks","keys_url":"https://api.github.com/repos/11mdlow/pronto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/11mdlow/pronto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/11mdlow/pronto/teams","hooks_url":"https://api.github.com/repos/11mdlow/pronto/hooks","issue_events_url":"https://api.github.com/repos/11mdlow/pronto/issues/events{/number}","events_url":"https://api.github.com/repos/11mdlow/pronto/events","assignees_url":"https://api.github.com/repos/11mdlow/pronto/assignees{/user}","branches_url":"https://api.github.com/repos/11mdlow/pronto/branches{/branch}","tags_url":"https://api.github.com/repos/11mdlow/pronto/tags","blobs_url":"https://api.github.com/repos/11mdlow/pronto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/11mdlow/pronto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/11mdlow/pronto/git/refs{/sha}","trees_url":"https://api.github.com/repos/11mdlow/pronto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/11mdlow/pronto/statuses/{sha}","languages_url":"https://api.github.com/repos/11mdlow/pronto/languages","stargazers_url":"https://api.github.com/repos/11mdlow/pronto/stargazers","contributors_url":"https://api.github.com/repos/11mdlow/pronto/contributors","subscribers_url":"https://api.github.com/repos/11mdlow/pronto/subscribers","subscription_url":"https://api.github.com/repos/11mdlow/pronto/subscription","commits_url":"https://api.github.com/repos/11mdlow/pronto/commits{/sha}","git_commits_url":"https://api.github.com/repos/11mdlow/pronto/git/commits{/sha}","comments_url":"https://api.github.com/repos/11mdlow/pronto/comments{/number}","issue_comment_url":"https://api.github.com/repos/11mdlow/pronto/issues/comments{/number}","contents_url":"https://api.github.com/repos/11mdlow/pronto/contents/{+path}","compare_url":"https://api.github.com/repos/11mdlow/pronto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/11mdlow/pronto/merges","archive_url":"https://api.github.com/repos/11mdlow/pronto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/11mdlow/pronto/downloads","issues_url":"https://api.github.com/repos/11mdlow/pronto/issues{/number}","pulls_url":"https://api.github.com/repos/11mdlow/pronto/pulls{/number}","milestones_url":"https://api.github.com/repos/11mdlow/pronto/milestones{/number}","notifications_url":"https://api.github.com/repos/11mdlow/pronto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/11mdlow/pronto/labels{/name}","releases_url":"https://api.github.com/repos/11mdlow/pronto/releases{/id}","created_at":"2015-03-05T23:48:56Z","updated_at":"2015-03-05T23:48:57Z","pushed_at":"2015-03-12T00:15:59Z","git_url":"git://github.com/11mdlow/pronto.git","ssh_url":"git@github.com:11mdlow/pronto.git","clone_url":"https://github.com/11mdlow/pronto.git","svn_url":"https://github.com/11mdlow/pronto","homepage":"","size":3158,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mmozuras:master","ref":"master","sha":"6cc8badb31aa03e945ef9f2a81f79707051b6d9c","user":{"login":"mmozuras","id":54526,"avatar_url":"https://avatars.githubusercontent.com/u/54526?v=3","gravatar_id":"","url":"https://api.github.com/users/mmozuras","html_url":"https://github.com/mmozuras","followers_url":"https://api.github.com/users/mmozuras/followers","following_url":"https://api.github.com/users/mmozuras/following{/other_user}","gists_url":"https://api.github.com/users/mmozuras/gists{/gist_id}","starred_url":"https://api.github.com/users/mmozuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmozuras/subscriptions","organizations_url":"https://api.github.com/users/mmozuras/orgs","repos_url":"https://api.github.com/users/mmozuras/repos","events_url":"https://api.github.com/users/mmozuras/events{/privacy}","received_events_url":"https://api.github.com/users/mmozuras/received_events","type":"User","site_admin":false},"repo":{"id":11131276,"name":"pronto","full_name":"mmozuras/pronto","owner":{"login":"mmozuras","id":54526,"avatar_url":"https://avatars.githubusercontent.com/u/54526?v=3","gravatar_id":"","url":"https://api.github.com/users/mmozuras","html_url":"https://github.com/mmozuras","followers_url":"https://api.github.com/users/mmozuras/followers","following_url":"https://api.github.com/users/mmozuras/following{/other_user}","gists_url":"https://api.github.com/users/mmozuras/gists{/gist_id}","starred_url":"https://api.github.com/users/mmozuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmozuras/subscriptions","organizations_url":"https://api.github.com/users/mmozuras/orgs","repos_url":"https://api.github.com/users/mmozuras/repos","events_url":"https://api.github.com/users/mmozuras/events{/privacy}","received_events_url":"https://api.github.com/users/mmozuras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmozuras/pronto","description":"Quick automated code review of your changes","fork":false,"url":"https://api.github.com/repos/mmozuras/pronto","forks_url":"https://api.github.com/repos/mmozuras/pronto/forks","keys_url":"https://api.github.com/repos/mmozuras/pronto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmozuras/pronto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmozuras/pronto/teams","hooks_url":"https://api.github.com/repos/mmozuras/pronto/hooks","issue_events_url":"https://api.github.com/repos/mmozuras/pronto/issues/events{/number}","events_url":"https://api.github.com/repos/mmozuras/pronto/events","assignees_url":"https://api.github.com/repos/mmozuras/pronto/assignees{/user}","branches_url":"https://api.github.com/repos/mmozuras/pronto/branches{/branch}","tags_url":"https://api.github.com/repos/mmozuras/pronto/tags","blobs_url":"https://api.github.com/repos/mmozuras/pronto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmozuras/pronto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmozuras/pronto/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmozuras/pronto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmozuras/pronto/statuses/{sha}","languages_url":"https://api.github.com/repos/mmozuras/pronto/languages","stargazers_url":"https://api.github.com/repos/mmozuras/pronto/stargazers","contributors_url":"https://api.github.com/repos/mmozuras/pronto/contributors","subscribers_url":"https://api.github.com/repos/mmozuras/pronto/subscribers","subscription_url":"https://api.github.com/repos/mmozuras/pronto/subscription","commits_url":"https://api.github.com/repos/mmozuras/pronto/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmozuras/pronto/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmozuras/pronto/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmozuras/pronto/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmozuras/pronto/contents/{+path}","compare_url":"https://api.github.com/repos/mmozuras/pronto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmozuras/pronto/merges","archive_url":"https://api.github.com/repos/mmozuras/pronto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmozuras/pronto/downloads","issues_url":"https://api.github.com/repos/mmozuras/pronto/issues{/number}","pulls_url":"https://api.github.com/repos/mmozuras/pronto/pulls{/number}","milestones_url":"https://api.github.com/repos/mmozuras/pronto/milestones{/number}","notifications_url":"https://api.github.com/repos/mmozuras/pronto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmozuras/pronto/labels{/name}","releases_url":"https://api.github.com/repos/mmozuras/pronto/releases{/id}","created_at":"2013-07-02T17:58:41Z","updated_at":"2015-09-16T04:26:04Z","pushed_at":"2015-09-20T08:43:51Z","git_url":"git://github.com/mmozuras/pronto.git","ssh_url":"git@github.com:mmozuras/pronto.git","clone_url":"https://github.com/mmozuras/pronto.git","svn_url":"https://github.com/mmozuras/pronto","homepage":"","size":4397,"stargazers_count":753,"watchers_count":753,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":24,"forks":46,"open_issues":24,"watchers":753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mmozuras/pronto/pulls/75"},"html":{"href":"https://github.com/mmozuras/pronto/pull/75"},"issue":{"href":"https://api.github.com/repos/mmozuras/pronto/issues/75"},"comments":{"href":"https://api.github.com/repos/mmozuras/pronto/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/mmozuras/pronto/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/mmozuras/pronto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mmozuras/pronto/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/mmozuras/pronto/statuses/1ae25d466cc7b1c9d9bbbace8db0e14efd9772eb"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":16,"deletions":4,"changed_files":2}}