{"action":"opened","number":568,"pull_request":{"url":"https://api.github.com/repos/stepmania/stepmania/pulls/568","id":33724069,"html_url":"https://github.com/stepmania/stepmania/pull/568","diff_url":"https://github.com/stepmania/stepmania/pull/568.diff","patch_url":"https://github.com/stepmania/stepmania/pull/568.patch","issue_url":"https://api.github.com/repos/stepmania/stepmania/issues/568","number":568,"state":"open","locked":false,"title":"Integer math for tweening","user":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"body":"This is intended to eliminate the possibility of precision loss related problems in the tweening system.\r\nThe profiling code in GameLoop is just there to show how I tested to see whether there was any performance benefit, no performance change was measured.  The profiling code will be removed when this pull request is finalized.\r\n\r\nThis also changes all classes that derive from Actor to use UpdateInternal because of this comment in Actor.h:\r\n\t// TODO: make Update non virtual and change all classes to override UpdateInternal instead.\r\n\r\nIf moving to integer math is considered good by other devs, my next target is TimingData, where a simfile with thousands of stops or bpm changes probably accumulates measurable error from all the additions.","created_at":"2015-04-21T02:26:26Z","updated_at":"2015-04-21T02:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stepmania/stepmania/pulls/568/commits","review_comments_url":"https://api.github.com/repos/stepmania/stepmania/pulls/568/comments","review_comment_url":"https://api.github.com/repos/stepmania/stepmania/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stepmania/stepmania/issues/568/comments","statuses_url":"https://api.github.com/repos/stepmania/stepmania/statuses/4564a7846444855002f105e3fd3ea91db10c9faa","head":{"label":"kyzentun:go_faster_stripes","ref":"go_faster_stripes","sha":"4564a7846444855002f105e3fd3ea91db10c9faa","user":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"repo":{"id":16755813,"name":"stepmania","full_name":"kyzentun/stepmania","owner":{"login":"kyzentun","id":6657507,"avatar_url":"https://avatars.githubusercontent.com/u/6657507?v=3","gravatar_id":"","url":"https://api.github.com/users/kyzentun","html_url":"https://github.com/kyzentun","followers_url":"https://api.github.com/users/kyzentun/followers","following_url":"https://api.github.com/users/kyzentun/following{/other_user}","gists_url":"https://api.github.com/users/kyzentun/gists{/gist_id}","starred_url":"https://api.github.com/users/kyzentun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyzentun/subscriptions","organizations_url":"https://api.github.com/users/kyzentun/orgs","repos_url":"https://api.github.com/users/kyzentun/repos","events_url":"https://api.github.com/users/kyzentun/events{/privacy}","received_events_url":"https://api.github.com/users/kyzentun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyzentun/stepmania","description":"Advanced rhythm game for Windows, Linux and OS X. Designed for both home and arcade use.","fork":true,"url":"https://api.github.com/repos/kyzentun/stepmania","forks_url":"https://api.github.com/repos/kyzentun/stepmania/forks","keys_url":"https://api.github.com/repos/kyzentun/stepmania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyzentun/stepmania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyzentun/stepmania/teams","hooks_url":"https://api.github.com/repos/kyzentun/stepmania/hooks","issue_events_url":"https://api.github.com/repos/kyzentun/stepmania/issues/events{/number}","events_url":"https://api.github.com/repos/kyzentun/stepmania/events","assignees_url":"https://api.github.com/repos/kyzentun/stepmania/assignees{/user}","branches_url":"https://api.github.com/repos/kyzentun/stepmania/branches{/branch}","tags_url":"https://api.github.com/repos/kyzentun/stepmania/tags","blobs_url":"https://api.github.com/repos/kyzentun/stepmania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyzentun/stepmania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyzentun/stepmania/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyzentun/stepmania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyzentun/stepmania/statuses/{sha}","languages_url":"https://api.github.com/repos/kyzentun/stepmania/languages","stargazers_url":"https://api.github.com/repos/kyzentun/stepmania/stargazers","contributors_url":"https://api.github.com/repos/kyzentun/stepmania/contributors","subscribers_url":"https://api.github.com/repos/kyzentun/stepmania/subscribers","subscription_url":"https://api.github.com/repos/kyzentun/stepmania/subscription","commits_url":"https://api.github.com/repos/kyzentun/stepmania/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyzentun/stepmania/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyzentun/stepmania/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyzentun/stepmania/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyzentun/stepmania/contents/{+path}","compare_url":"https://api.github.com/repos/kyzentun/stepmania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyzentun/stepmania/merges","archive_url":"https://api.github.com/repos/kyzentun/stepmania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyzentun/stepmania/downloads","issues_url":"https://api.github.com/repos/kyzentun/stepmania/issues{/number}","pulls_url":"https://api.github.com/repos/kyzentun/stepmania/pulls{/number}","milestones_url":"https://api.github.com/repos/kyzentun/stepmania/milestones{/number}","notifications_url":"https://api.github.com/repos/kyzentun/stepmania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyzentun/stepmania/labels{/name}","releases_url":"https://api.github.com/repos/kyzentun/stepmania/releases{/id}","created_at":"2014-02-12T04:21:50Z","updated_at":"2014-06-23T19:53:24Z","pushed_at":"2015-04-21T02:19:39Z","git_url":"git://github.com/kyzentun/stepmania.git","ssh_url":"git@github.com:kyzentun/stepmania.git","clone_url":"https://github.com/kyzentun/stepmania.git","svn_url":"https://github.com/kyzentun/stepmania","homepage":"http://www.stepmania.com/","size":479938,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stepmania:master","ref":"master","sha":"88f295d2952d6eb41dcb6e0a309a5cff54a9bfdf","user":{"login":"stepmania","id":4809468,"avatar_url":"https://avatars.githubusercontent.com/u/4809468?v=3","gravatar_id":"","url":"https://api.github.com/users/stepmania","html_url":"https://github.com/stepmania","followers_url":"https://api.github.com/users/stepmania/followers","following_url":"https://api.github.com/users/stepmania/following{/other_user}","gists_url":"https://api.github.com/users/stepmania/gists{/gist_id}","starred_url":"https://api.github.com/users/stepmania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepmania/subscriptions","organizations_url":"https://api.github.com/users/stepmania/orgs","repos_url":"https://api.github.com/users/stepmania/repos","events_url":"https://api.github.com/users/stepmania/events{/privacy}","received_events_url":"https://api.github.com/users/stepmania/received_events","type":"Organization","site_admin":false},"repo":{"id":10923187,"name":"stepmania","full_name":"stepmania/stepmania","owner":{"login":"stepmania","id":4809468,"avatar_url":"https://avatars.githubusercontent.com/u/4809468?v=3","gravatar_id":"","url":"https://api.github.com/users/stepmania","html_url":"https://github.com/stepmania","followers_url":"https://api.github.com/users/stepmania/followers","following_url":"https://api.github.com/users/stepmania/following{/other_user}","gists_url":"https://api.github.com/users/stepmania/gists{/gist_id}","starred_url":"https://api.github.com/users/stepmania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepmania/subscriptions","organizations_url":"https://api.github.com/users/stepmania/orgs","repos_url":"https://api.github.com/users/stepmania/repos","events_url":"https://api.github.com/users/stepmania/events{/privacy}","received_events_url":"https://api.github.com/users/stepmania/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stepmania/stepmania","description":"Advanced rhythm game for Windows, Linux and OS X. Designed for both home and arcade use.","fork":false,"url":"https://api.github.com/repos/stepmania/stepmania","forks_url":"https://api.github.com/repos/stepmania/stepmania/forks","keys_url":"https://api.github.com/repos/stepmania/stepmania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stepmania/stepmania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stepmania/stepmania/teams","hooks_url":"https://api.github.com/repos/stepmania/stepmania/hooks","issue_events_url":"https://api.github.com/repos/stepmania/stepmania/issues/events{/number}","events_url":"https://api.github.com/repos/stepmania/stepmania/events","assignees_url":"https://api.github.com/repos/stepmania/stepmania/assignees{/user}","branches_url":"https://api.github.com/repos/stepmania/stepmania/branches{/branch}","tags_url":"https://api.github.com/repos/stepmania/stepmania/tags","blobs_url":"https://api.github.com/repos/stepmania/stepmania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stepmania/stepmania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stepmania/stepmania/git/refs{/sha}","trees_url":"https://api.github.com/repos/stepmania/stepmania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stepmania/stepmania/statuses/{sha}","languages_url":"https://api.github.com/repos/stepmania/stepmania/languages","stargazers_url":"https://api.github.com/repos/stepmania/stepmania/stargazers","contributors_url":"https://api.github.com/repos/stepmania/stepmania/contributors","subscribers_url":"https://api.github.com/repos/stepmania/stepmania/subscribers","subscription_url":"https://api.github.com/repos/stepmania/stepmania/subscription","commits_url":"https://api.github.com/repos/stepmania/stepmania/commits{/sha}","git_commits_url":"https://api.github.com/repos/stepmania/stepmania/git/commits{/sha}","comments_url":"https://api.github.com/repos/stepmania/stepmania/comments{/number}","issue_comment_url":"https://api.github.com/repos/stepmania/stepmania/issues/comments{/number}","contents_url":"https://api.github.com/repos/stepmania/stepmania/contents/{+path}","compare_url":"https://api.github.com/repos/stepmania/stepmania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stepmania/stepmania/merges","archive_url":"https://api.github.com/repos/stepmania/stepmania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stepmania/stepmania/downloads","issues_url":"https://api.github.com/repos/stepmania/stepmania/issues{/number}","pulls_url":"https://api.github.com/repos/stepmania/stepmania/pulls{/number}","milestones_url":"https://api.github.com/repos/stepmania/stepmania/milestones{/number}","notifications_url":"https://api.github.com/repos/stepmania/stepmania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stepmania/stepmania/labels{/name}","releases_url":"https://api.github.com/repos/stepmania/stepmania/releases{/id}","created_at":"2013-06-24T23:40:10Z","updated_at":"2015-04-20T22:06:02Z","pushed_at":"2015-04-20T23:54:20Z","git_url":"git://github.com/stepmania/stepmania.git","ssh_url":"git@github.com:stepmania/stepmania.git","clone_url":"https://github.com/stepmania/stepmania.git","svn_url":"https://github.com/stepmania/stepmania","homepage":"http://www.stepmania.com/","size":527860,"stargazers_count":204,"watchers_count":204,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":131,"forks":78,"open_issues":131,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/568"},"html":{"href":"https://github.com/stepmania/stepmania/pull/568"},"issue":{"href":"https://api.github.com/repos/stepmania/stepmania/issues/568"},"comments":{"href":"https://api.github.com/repos/stepmania/stepmania/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stepmania/stepmania/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/stepmania/stepmania/statuses/4564a7846444855002f105e3fd3ea91db10c9faa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":832,"deletions":678,"changed_files":158}}