{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6281","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6281/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6281/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6281/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6281","id":88090036,"number":6281,"title":"Limit mempool size","user":{"login":"pstratem","id":620611,"avatar_url":"https://avatars.githubusercontent.com/u/620611?v=3","gravatar_id":"","url":"https://api.github.com/users/pstratem","html_url":"https://github.com/pstratem","followers_url":"https://api.github.com/users/pstratem/followers","following_url":"https://api.github.com/users/pstratem/following{/other_user}","gists_url":"https://api.github.com/users/pstratem/gists{/gist_id}","starred_url":"https://api.github.com/users/pstratem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstratem/subscriptions","organizations_url":"https://api.github.com/users/pstratem/orgs","repos_url":"https://api.github.com/users/pstratem/repos","events_url":"https://api.github.com/users/pstratem/events{/privacy}","received_events_url":"https://api.github.com/users/pstratem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-14T00:28:34Z","updated_at":"2015-06-14T13:11:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6281","html_url":"https://github.com/bitcoin/bitcoin/pull/6281","diff_url":"https://github.com/bitcoin/bitcoin/pull/6281.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6281.patch"},"body":"Restrict the maximum memory pool size to avoid potential DoS issues.\r\n\r\nThe mechanism is simply to recursively remove the transactions which have the lowest priority until the memory pool is below the maximum size.\r\n\r\ncompiles and passes tests, but has not been extensively tested\r\n\r\nthis is intended to replace #3753"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/111825309","html_url":"https://github.com/bitcoin/bitcoin/pull/6281#issuecomment-111825309","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6281","id":111825309,"user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"created_at":"2015-06-14T13:11:35Z","updated_at":"2015-06-14T13:11:35Z","body":"Iterating though the entire mempool whenever the limit size is exceeded seems inefficient, especially with larger mempools. I would either keep an index ordered by priority/whatever, or use random deletes instead.\r\n\r\nAlso, needs a hook for the wallet to mark its own transactions as \"precious\", or the conflict detection mechanism will break."}}