{"action":"created","issue":{"url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/76","labels_url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/76/comments","events_url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/76/events","html_url":"https://github.com/PocketRent/hhvm-pgsql/issues/76","id":63312150,"number":76,"title":"Centos 7: make problems","user":{"login":"no1youknowz","id":387463,"avatar_url":"https://avatars.githubusercontent.com/u/387463?v=3","gravatar_id":"","url":"https://api.github.com/users/no1youknowz","html_url":"https://github.com/no1youknowz","followers_url":"https://api.github.com/users/no1youknowz/followers","following_url":"https://api.github.com/users/no1youknowz/following{/other_user}","gists_url":"https://api.github.com/users/no1youknowz/gists{/gist_id}","starred_url":"https://api.github.com/users/no1youknowz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no1youknowz/subscriptions","organizations_url":"https://api.github.com/users/no1youknowz/orgs","repos_url":"https://api.github.com/users/no1youknowz/repos","events_url":"https://api.github.com/users/no1youknowz/events{/privacy}","received_events_url":"https://api.github.com/users/no1youknowz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-20T21:32:49Z","updated_at":"2015-03-21T00:39:41Z","closed_at":"2015-03-21T00:39:41Z","body":"Trying to make this extension with centos 7 with hhvm 3.6.0.\r\n\r\n\t+ /usr/local/bin/hphpize\r\n\t** hphpize complete, now run `cmake . && make` to build, `make test` to test\r\n\t+ cmake .\r\n\t-- The C compiler identification is GNU 4.8.2\r\n\t-- The CXX compiler identification is GNU 4.8.2\r\n\t-- The ASM compiler identification is GNU\r\n\t-- Found assembler: /usr/bin/cc\r\n\t-- Check for working C compiler: /usr/bin/cc\r\n\t-- Check for working C compiler: /usr/bin/cc -- works\r\n\t-- Detecting C compiler ABI info\r\n\t-- Detecting C compiler ABI info - done\r\n\t-- Check for working CXX compiler: /usr/bin/c++\r\n\t-- Check for working CXX compiler: /usr/bin/c++ -- works\r\n\t-- Detecting CXX compiler ABI info\r\n\t-- Detecting CXX compiler ABI info - done\r\n\t-- Configuring for HHVM API version 20150212\r\n\t-- pgSQL Include dir: /usr/include\r\n\t-- libpq library: /usr/lib64/libpq.so\r\n\t-- Configuring done\r\n\t-- Generating done\r\n\t-- Build files have been written to: /root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql\r\n\t+ make\r\n\tScanning dependencies of target pgsql\r\n\t[ 25%] Building CXX object CMakeFiles/pgsql.dir/pgsql.cpp.o\r\n\t[ 50%] Building CXX object CMakeFiles/pgsql.dir/pdo_pgsql_statement.cpp.o\r\n\tIn file included from /root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql_statement.cpp:4:0:\r\n\t/root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql.h:10:35: error: conflicting return type specified for 'virtual HPHP::SmartPtr<HPHP::PDOResource> HPHP::PDOPgSql::createResourceImpl()'\r\n\t     virtual SmartPtr<PDOResource> createResourceImpl() override;\r\n\t                                   ^\r\n\tIn file included from /root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql_resource.h:4:0,\r\n\t                 from /root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql_statement.cpp:1:\r\n\t/usr/local/include/hphp/runtime/ext/pdo_driver.h:235:24: error:   overriding 'virtual HPHP::PDOResource* HPHP::PDODriver::createResourceImpl()'\r\n\t   virtual PDOResource* createResourceImpl() = 0;\r\n\t                        ^\r\n\t/root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql_statement.cpp: In member function 'bool HPHP::PDOPgSqlStatement::create(const HPHP::String&, const HPHP::Array&)':\r\n\t/root/rpmbuild/BUILD/hhvm-ext-pgsql-1.1.0/hhvm-ext-pgsql/pdo_pgsql_statement.cpp:62:72: error: cannot convert 'HPHP::sp_PDOStatement {aka HPHP::SmartPtr<HPHP::PDOStatement>}' to 'HPHP::PDOStatement*' for argument '1' to 'int HPHP::pdo_parse_params(HPHP::PDOStatement*, const HPHP::String&, HPHP::String&)'\r\n\t             int ret = pdo_parse_params(sp_PDOStatement(this), sql, nsql);\r\n\t                                                                        ^\r\n\tmake[2]: *** [CMakeFiles/pgsql.dir/pdo_pgsql_statement.cpp.o] Error 1\r\n\tmake[1]: *** [CMakeFiles/pgsql.dir/all] Error 2\r\n\tmake: *** [all] Error 2"},"comment":{"url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/comments/84208001","html_url":"https://github.com/PocketRent/hhvm-pgsql/issues/76#issuecomment-84208001","issue_url":"https://api.github.com/repos/PocketRent/hhvm-pgsql/issues/76","id":84208001,"user":{"login":"no1youknowz","id":387463,"avatar_url":"https://avatars.githubusercontent.com/u/387463?v=3","gravatar_id":"","url":"https://api.github.com/users/no1youknowz","html_url":"https://github.com/no1youknowz","followers_url":"https://api.github.com/users/no1youknowz/followers","following_url":"https://api.github.com/users/no1youknowz/following{/other_user}","gists_url":"https://api.github.com/users/no1youknowz/gists{/gist_id}","starred_url":"https://api.github.com/users/no1youknowz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no1youknowz/subscriptions","organizations_url":"https://api.github.com/users/no1youknowz/orgs","repos_url":"https://api.github.com/users/no1youknowz/repos","events_url":"https://api.github.com/users/no1youknowz/events{/privacy}","received_events_url":"https://api.github.com/users/no1youknowz/received_events","type":"User","site_admin":false},"created_at":"2015-03-21T00:39:41Z","updated_at":"2015-03-21T00:39:41Z","body":"Compiles fine against the 3.6.0 tag.\r\n\r\nThanks @simonwelsh."}}