{"action":"created","issue":{"url":"https://api.github.com/repos/dmwm/CRABServer/issues/5046","labels_url":"https://api.github.com/repos/dmwm/CRABServer/issues/5046/labels{/name}","comments_url":"https://api.github.com/repos/dmwm/CRABServer/issues/5046/comments","events_url":"https://api.github.com/repos/dmwm/CRABServer/issues/5046/events","html_url":"https://github.com/dmwm/CRABServer/pull/5046","id":112895802,"number":5046,"title":"Save input dataset lumis from DBS data discovery to file in schedd.","user":{"login":"AndresTanasijczuk","id":6575844,"avatar_url":"https://avatars.githubusercontent.com/u/6575844?v=3","gravatar_id":"","url":"https://api.github.com/users/AndresTanasijczuk","html_url":"https://github.com/AndresTanasijczuk","followers_url":"https://api.github.com/users/AndresTanasijczuk/followers","following_url":"https://api.github.com/users/AndresTanasijczuk/following{/other_user}","gists_url":"https://api.github.com/users/AndresTanasijczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AndresTanasijczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndresTanasijczuk/subscriptions","organizations_url":"https://api.github.com/users/AndresTanasijczuk/orgs","repos_url":"https://api.github.com/users/AndresTanasijczuk/repos","events_url":"https://api.github.com/users/AndresTanasijczuk/events{/privacy}","received_events_url":"https://api.github.com/users/AndresTanasijczuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-10-22T21:30:46Z","updated_at":"2015-11-24T10:11:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmwm/CRABServer/pulls/5046","html_url":"https://github.com/dmwm/CRABServer/pull/5046","diff_url":"https://github.com/dmwm/CRABServer/pull/5046.diff","patch_url":"https://github.com/dmwm/CRABServer/pull/5046.patch"},"body":"The information contained in these files will be needed for the fixes in the report (https://github.com/dmwm/CRABClient/issues/4522).\r\nIf possible, I would like to have this PR included in the November release, so that in the next release (i.e. February) when the changes are implemented to the report, these files are already there for all tasks (simplifies life to not have to care about backward compatibility).\r\n\r\nNote that this PR includes also the change made in https://github.com/dmwm/CRABServer/pull/5045"},"comment":{"url":"https://api.github.com/repos/dmwm/CRABServer/issues/comments/159216250","html_url":"https://github.com/dmwm/CRABServer/pull/5046#issuecomment-159216250","issue_url":"https://api.github.com/repos/dmwm/CRABServer/issues/5046","id":159216250,"user":{"login":"cmsdmwmbot","id":15169205,"avatar_url":"https://avatars.githubusercontent.com/u/15169205?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsdmwmbot","html_url":"https://github.com/cmsdmwmbot","followers_url":"https://api.github.com/users/cmsdmwmbot/followers","following_url":"https://api.github.com/users/cmsdmwmbot/following{/other_user}","gists_url":"https://api.github.com/users/cmsdmwmbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsdmwmbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsdmwmbot/subscriptions","organizations_url":"https://api.github.com/users/cmsdmwmbot/orgs","repos_url":"https://api.github.com/users/cmsdmwmbot/repos","events_url":"https://api.github.com/users/cmsdmwmbot/events{/privacy}","received_events_url":"https://api.github.com/users/cmsdmwmbot/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T10:11:17Z","updated_at":"2015-11-24T10:11:17Z","body":"Summary of pylint changes for pull request 5046:\n* Score for src/python/CRABInterface/DataUserWorkflow.py changed from 10.00 to 9.67 with 0 (1) total errors (warnings)\n* Score for src/python/CRABInterface/HTCondorDataWorkflow.py changed from 9.18 to 9.24 with 2 (47) total errors (warnings)\n* Score for src/python/TaskWorker/Actions/DagmanCreator.py changed from 9.40 to 9.39 with 0 (21) total errors (warnings)\n\nsrc/python/CRABInterface/DataUserWorkflow.py got worse in pylint. Report follows:\n* Line 41 in DataUserWorkflow.report W0613 Unused argument 'usedbs'\n* Line 121 in DataUserWorkflow.resubmit R0913 Too many arguments (13/7)\n* Line 4 in DataUserWorkflow R0921 Abstract class not referenced\n* plus 5 comments on code style\n\nsrc/python/CRABInterface/HTCondorDataWorkflow.py got worse in pylint. Report follows:\n* Line 315 W0312 Found indentation with tabs instead of spaces\n* Line 57 in HTCondorDataWorkflow.getRootTasks W1201 Specify string format arguments as logging function parameters\n* Line 62 in HTCondorDataWorkflow.logs W0221 Arguments number differs from overridden method\n* Line 63 in HTCondorDataWorkflow.logs W1201 Specify string format arguments as logging function parameters\n* Line 77 in HTCondorDataWorkflow.output W0221 Arguments number differs from overridden method\n* Line 78 in HTCondorDataWorkflow.output W1201 Specify string format arguments as logging function parameters\n* Line 93 in HTCondorDataWorkflow.getFiles R0913 Too many arguments (12/7)\n* Line 116 in HTCondorDataWorkflow.getFiles W1201 Specify string format arguments as logging function parameters\n* Line 119 in HTCondorDataWorkflow.getFiles W1201 Specify string format arguments as logging function parameters\n* Line 121 in HTCondorDataWorkflow.getFiles W0141 Used builtin function 'filter'\n* Line 121 in HTCondorDataWorkflow.getFiles W0110 map/filter on lambda could be replaced by comprehension\n* Line 131 in HTCondorDataWorkflow.getFiles W1201 Specify string format arguments as logging function parameters\n* Line 137 in HTCondorDataWorkflow.getFiles W1201 Specify string format arguments as logging function parameters\n* Line 142 in HTCondorDataWorkflow.getFiles W1201 Specify string format arguments as logging function parameters\n* Line 93 in HTCondorDataWorkflow.getFiles W0613 Unused argument 'username'\n* Line 93 in HTCondorDataWorkflow.getFiles W0613 Unused argument 'userproxy'\n* Line 93 in HTCondorDataWorkflow.getFiles W0613 Unused argument 'group'\n* Line 93 in HTCondorDataWorkflow.getFiles W0613 Unused argument 'userdn'\n* Line 93 in HTCondorDataWorkflow.getFiles W0613 Unused argument 'role'\n* Line 158 in HTCondorDataWorkflow.report R0914 Too many local variables (40/30)\n* Line 158 in HTCondorDataWorkflow.report W0221 Arguments number differs from overridden method\n* Line 197 in HTCondorDataWorkflow.report W1201 Specify string format arguments as logging function parameters\n* Line 272 in HTCondorDataWorkflow.report W1201 Specify string format arguments as logging function parameters\n* Line 301 in HTCondorDataWorkflow.report W1201 Specify string format arguments as logging function parameters\n* Line 313 in HTCondorDataWorkflow.report W0703 Catching too general exception Exception\n* Line 338 in HTCondorDataWorkflow.report W1201 Specify string format arguments as logging function parameters\n* Line 356 in HTCondorDataWorkflow.report W0141 Used builtin function 'map'\n* Line 356 in HTCondorDataWorkflow.report W0110 map/filter on lambda could be replaced by comprehension\n* Line 357 in HTCondorDataWorkflow.report W1201 Specify string format arguments as logging function parameters\n* Line 158 in HTCondorDataWorkflow.report R0912 Too many branches (31/12)\n* Line 158 in HTCondorDataWorkflow.report R0915 Too many statements (136/100)\n* Line 368 in HTCondorDataWorkflow.status R0914 Too many local variables (37/30)\n* Line 368 in HTCondorDataWorkflow.status W0221 Arguments number differs from overridden method\n* Line 388 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 401 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 431 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 461 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 502 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 510 in HTCondorDataWorkflow.status W0703 Catching too general exception Exception\n* Line 505 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 506 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 509 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 522 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 590 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 597 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 601 in HTCondorDataWorkflow.status W1201 Specify string format arguments as logging function parameters\n* Line 368 in HTCondorDataWorkflow.status R0912 Too many branches (48/12)\n* Line 368 in HTCondorDataWorkflow.status R0915 Too many statements (137/100)\n* Line 670 in HTCondorDataWorkflow.taskWebStatus W1201 Specify string format arguments as logging function parameters\n* Line 661 in HTCondorDataWorkflow.taskWebStatus R0912 Too many branches (14/12)\n* Line 757 in HTCondorDataWorkflow.publicationStatus E1101 Instance of 'HTCondorDataWorkflow' has no 'serverKey' member\n* Line 757 in HTCondorDataWorkflow.publicationStatus E1101 Instance of 'HTCondorDataWorkflow' has no 'serverCert' member\n* Line 760 in HTCondorDataWorkflow.publicationStatus W0703 Catching too general exception Exception\n* Line 773 in HTCondorDataWorkflow.publicationStatus W0703 Catching too general exception Exception\n* Line 791 in HTCondorDataWorkflow.publicationStatus W0703 Catching too general exception Exception\n* Line 916 in HTCondorDataWorkflow.parseJobLog W1201 Specify string format arguments as logging function parameters\n* Line 918 in HTCondorDataWorkflow.parseJobLog W1201 Specify string format arguments as logging function parameters\n* Line 807 in HTCondorDataWorkflow.parseJobLog R0912 Too many branches (36/12)\n* Line 807 in HTCondorDataWorkflow.parseJobLog R0915 Too many statements (114/100)\n* Line 930 in HTCondorDataWorkflow.parseASOState R0201 Method could be a function\n* Line 976 in HTCondorDataWorkflow.parseNodeState R0912 Too many branches (18/12)\n* Line 1021 in HTCondorDataWorkflow.parseNodeStateV2 R0912 Too many branches (17/12)\n* Line 34 in HTCondorDataWorkflow R0904 Too many public methods (26/20)\n* plus 75 comments on code style\n\nsrc/python/TaskWorker/Actions/DBSDataDiscovery.py fails the pylint check. Report follows:\n* Line 49 W0511 TODO use certs from the config!\n* Line 57 W0511 TODO addo the nodes phedex so the user can check themselves\n* Line 105 W0511 TODO should we catch HttpException instead?\n* Line 139 W0511 TODO should we catch HttpException instead?\n* Line 143 W0511 TODO addo the nodes phedex so the user can check themselves\n* Line 9 E0611 No name 'WorkQueue' in module 'WMCore'\n* Line 19 in DBSDataDiscovery.checkDatasetStatus W0621 Redefining name 'dataset' from outer scope (line 174)\n* Line 26 in DBSDataDiscovery.checkDatasetStatus W1201 Specify string format arguments as logging function parameters\n* Line 87 in DBSDataDiscovery.execute W1201 Specify string format arguments as logging function parameters\n* Line 119 in DBSDataDiscovery.execute W1201 Specify string format arguments as logging function parameters\n* Line 162 in DBSDataDiscovery.execute W1201 Specify string format arguments as logging function parameters\n* Line 66 in DBSDataDiscovery.execute W0613 Unused argument 'args'\n* Line 66 in DBSDataDiscovery.execute R0912 Too many branches (19/12)\n* Line 76 in DBSDataDiscovery.execute W0201 Attribute 'dbs' defined outside __init__\n* Line 77 in DBSDataDiscovery.execute W0201 Attribute 'dbsInstance' defined outside __init__\n* Line 48 in DBSDataDiscovery.keepOnlyDisks W0201 Attribute 'otherLocations' defined outside __init__\n* Line 60 in DBSDataDiscovery.keepOnlyDisks W0201 Attribute 'otherLocations' defined outside __init__\n* Line 172 W0105 String statement has no effect\n* Line 180 E1101 Instance of 'Configuration' has no 'Services' member\n* Line 183 E1101 Instance of 'Configuration' has no 'TaskWorker' member\n* Line 184 E1101 Instance of 'Configuration' has no 'TaskWorker' member\n* Line 188 E1101 Instance of 'Configuration' has no 'Services' member\n* plus 29 comments on code style\n\nsrc/python/TaskWorker/Actions/DagmanCreator.py got worse in pylint. Report follows:\n* Line 284 W0511 TODO use config certs!\n* Line 638 W0511 TODO add the sitedb url so the user can check themselves!\n* Line 863 W0511 TODO url!?\n* Line 11 W0402 Uses of a deprecated module 'string'\n* Line 185 in makeLFNPrefixes W0622 Redefining built-in 'hash'\n* Line 201 in transform_strings W0622 Redefining built-in 'input'\n* Line 313 in DagmanCreator.sendDashboardTask W1201 Specify string format arguments as logging function parameters\n* Line 356 in DagmanCreator.populateGlideinMatching W0621 Redefining name 'os' from outer scope (line 7)\n* Line 345 in DagmanCreator.populateGlideinMatching R0201 Method could be a function\n* Line 461 in DagmanCreator.makeDagSpecs R0913 Too many arguments (10/7)\n* Line 461 in DagmanCreator.makeDagSpecs R0914 Too many local variables (38/30)\n* Line 539 in DagmanCreator.createSubdag R0914 Too many local variables (50/30)\n* Line 561 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 578 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 579 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 594 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 603 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 609 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 643 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 691 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 771 in DagmanCreator.createSubdag W0141 Used builtin function 'map'\n* Line 794 in DagmanCreator.createSubdag W1201 Specify string format arguments as logging function parameters\n* Line 539 in DagmanCreator.createSubdag R0912 Too many branches (34/12)\n* Line 539 in DagmanCreator.createSubdag R0915 Too many statements (163/100)\n* Line 828 in DagmanCreator.extractMonitorFiles W0703 Catching too general exception Exception\n* Line 895 in DagmanCreator.executeInternal W0633 Attempting to unpack a non-sequence defined at line 799\n* Line 874 in DagmanCreator.executeInternal W0201 Attribute 'task' defined outside __init__\n* plus 75 comments on code style\n\nAbbreviated pylint report for src/python/TaskWorker/Actions/Handler.py follows:\n* Line 97 in TaskHandler.actionWork W0613 Unused argument 'kwargs'\n* Line 179 in handleNewTask.glidein W0612 Unused variable 'glidein'\n* Line 204 in handleResubmit.glidein W0612 Unused variable 'glidein'\n* Line 226 in handleKill.glidein W0612 Unused variable 'glidein'\n* Line 236 E0602 Undefined variable 'task'\n* Line 238 E0602 Undefined variable 'task'\n* Line 240 E0602 Undefined variable 'task'\n* plus 8 total warnings\n* plus 6 comments on code style\n"}}