{"action":"created","issue":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/2621","labels_url":"https://api.github.com/repos/kennethreitz/requests/issues/2621/labels{/name}","comments_url":"https://api.github.com/repos/kennethreitz/requests/issues/2621/comments","events_url":"https://api.github.com/repos/kennethreitz/requests/issues/2621/events","html_url":"https://github.com/kennethreitz/requests/issues/2621","id":83582676,"number":2621,"title":"TLS hostname validation logic does not support subjectAltName with IP records","user":{"login":"itamarst","id":3266662,"avatar_url":"https://avatars.githubusercontent.com/u/3266662?v=3","gravatar_id":"","url":"https://api.github.com/users/itamarst","html_url":"https://github.com/itamarst","followers_url":"https://api.github.com/users/itamarst/followers","following_url":"https://api.github.com/users/itamarst/following{/other_user}","gists_url":"https://api.github.com/users/itamarst/gists{/gist_id}","starred_url":"https://api.github.com/users/itamarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itamarst/subscriptions","organizations_url":"https://api.github.com/users/itamarst/orgs","repos_url":"https://api.github.com/users/itamarst/repos","events_url":"https://api.github.com/users/itamarst/events{/privacy}","received_events_url":"https://api.github.com/users/itamarst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-06-01T16:13:37Z","updated_at":"2015-06-02T11:01:04Z","closed_at":null,"body":"If I am running a custom certificate authority I might want to generate a TLS certificate that encodes its `subjectAltName` using an IP address (`iPAddress` in https://tools.ietf.org/html/rfc5280#section-4.2.1.6). this is useful when I do not have DNS records for servers in my application but I still want to validate identity.\r\n\r\nUnfortunately, the hostname validation logic `requests` uses does not validate these records. It only validates DNS records within `subjectAltName`."},"comment":{"url":"https://api.github.com/repos/kennethreitz/requests/issues/comments/107916123","html_url":"https://github.com/kennethreitz/requests/issues/2621#issuecomment-107916123","issue_url":"https://api.github.com/repos/kennethreitz/requests/issues/2621","id":107916123,"user":{"login":"tiran","id":444071,"avatar_url":"https://avatars.githubusercontent.com/u/444071?v=3","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T11:01:04Z","updated_at":"2015-06-02T11:01:04Z","body":"Mozilla's NSS library doesn't support IP addresses in dNSName either: https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/certdb/certdb.c#1427"}}