{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/26152516","id":26152516,"diff_hunk":"@@ -10,6 +11,14 @@\n     'null': (),\n }\n \n+SWAGGER_PRIMITIVES = (\n+    'integer',\n+    'number',\n+    'string',\n+    'boolean',\n+    'null'     # TODO: Do we need this?","path":"bravado/mapping/schema.py","position":18,"original_position":18,"commit_id":"c3eb0acb3ed3c86c3f11cc5a8015dffb8392b714","original_commit_id":"c3eb0acb3ed3c86c3f11cc5a8015dffb8392b714","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"body":"according to the spec, this is correct\r\n\r\nhttps://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#data-types\r\n\r\nreferences\r\n\r\nhttp://json-schema.org/latest/json-schema-core.html#anchor8\r\n\r\nAlthough I guess swagger special cases \"array\" and \"object\", and \"file\" is missing, but I guess that's a known deficiency right now? Do we have an issue open for \"add file support for bravado\" ?","created_at":"2015-03-10T18:43:35Z","updated_at":"2015-03-10T18:43:35Z","html_url":"https://github.com/Yelp/swagger-py/pull/115#discussion_r26152516","pull_request_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments/26152516"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/115#discussion_r26152516"},"pull_request":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/swagger-py/pulls/115","id":30659555,"html_url":"https://github.com/Yelp/swagger-py/pull/115","diff_url":"https://github.com/Yelp/swagger-py/pull/115.diff","patch_url":"https://github.com/Yelp/swagger-py/pull/115.patch","issue_url":"https://api.github.com/repos/Yelp/swagger-py/issues/115","number":115,"state":"open","locked":false,"title":"Remove dead code in bravado.swagger_type","user":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"body":"Highlights:\r\n- `bravado/swagger_type.py` was mostly dead code and is now gone\r\n- The still used funcs such as `is_dict_like()` and  `is_list_like()` were moved to `bravado/mapping/schema.py`\r\n- `bravado.swagger_type.get_swagger_type()` was moved to `bravado/mapping/docstring.py` since it was only used for docstring purposes.  Also renamed it to `formatted_type()`\r\n- move `SwaggerException` to `bravado.mapping.exception`","created_at":"2015-03-06T16:43:44Z","updated_at":"2015-03-10T18:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"070524e45889c6a690c80e1cfd6cfdc26bb0c810","assignee":null,"milestone":{"url":"https://api.github.com/repos/Yelp/swagger-py/milestones/2","html_url":"https://github.com/Yelp/swagger-py/milestones/Swagger%202.0%20Support","labels_url":"https://api.github.com/repos/Yelp/swagger-py/milestones/2/labels","id":936058,"number":2,"title":"Swagger 2.0 Support","description":"Full support for the Swagger 2.0 specification","creator":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2015-01-15T00:47:20Z","updated_at":"2015-03-07T00:53:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/115/commits","review_comments_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/115/comments","review_comment_url":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/issues/115/comments","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/c3eb0acb3ed3c86c3f11cc5a8015dffb8392b714","head":{"label":"analogue:cleanup","ref":"cleanup","sha":"c3eb0acb3ed3c86c3f11cc5a8015dffb8392b714","user":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"repo":{"id":25488246,"name":"swagger-py","full_name":"analogue/swagger-py","owner":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/analogue/swagger-py","description":"Generic client library for Python2.6 - adopts SwaggerVersion 1.2","fork":true,"url":"https://api.github.com/repos/analogue/swagger-py","forks_url":"https://api.github.com/repos/analogue/swagger-py/forks","keys_url":"https://api.github.com/repos/analogue/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogue/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogue/swagger-py/teams","hooks_url":"https://api.github.com/repos/analogue/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/analogue/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/analogue/swagger-py/events","assignees_url":"https://api.github.com/repos/analogue/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/analogue/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/analogue/swagger-py/tags","blobs_url":"https://api.github.com/repos/analogue/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogue/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogue/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogue/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogue/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/analogue/swagger-py/languages","stargazers_url":"https://api.github.com/repos/analogue/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/analogue/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/analogue/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/analogue/swagger-py/subscription","commits_url":"https://api.github.com/repos/analogue/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogue/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogue/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogue/swagger-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/analogue/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/analogue/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogue/swagger-py/merges","archive_url":"https://api.github.com/repos/analogue/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogue/swagger-py/downloads","issues_url":"https://api.github.com/repos/analogue/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/analogue/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/analogue/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/analogue/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogue/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/analogue/swagger-py/releases{/id}","created_at":"2014-10-20T21:50:53Z","updated_at":"2015-03-06T17:38:54Z","pushed_at":"2015-03-07T00:51:17Z","git_url":"git://github.com/analogue/swagger-py.git","ssh_url":"git@github.com:analogue/swagger-py.git","clone_url":"https://github.com/analogue/swagger-py.git","svn_url":"https://github.com/analogue/swagger-py","homepage":"","size":1033,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:swagger2.0","ref":"swagger2.0","sha":"6e4ad9b690973d1f7f250ba077df738acb36fa18","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":20313056,"name":"swagger-py","full_name":"Yelp/swagger-py","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/swagger-py","description":"Generic client library for Python2.6 - adopts SwaggerVersion 1.2","fork":false,"url":"https://api.github.com/repos/Yelp/swagger-py","forks_url":"https://api.github.com/repos/Yelp/swagger-py/forks","keys_url":"https://api.github.com/repos/Yelp/swagger-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/swagger-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/swagger-py/teams","hooks_url":"https://api.github.com/repos/Yelp/swagger-py/hooks","issue_events_url":"https://api.github.com/repos/Yelp/swagger-py/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/swagger-py/events","assignees_url":"https://api.github.com/repos/Yelp/swagger-py/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/swagger-py/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/swagger-py/tags","blobs_url":"https://api.github.com/repos/Yelp/swagger-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/swagger-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/swagger-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/swagger-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/swagger-py/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/swagger-py/languages","stargazers_url":"https://api.github.com/repos/Yelp/swagger-py/stargazers","contributors_url":"https://api.github.com/repos/Yelp/swagger-py/contributors","subscribers_url":"https://api.github.com/repos/Yelp/swagger-py/subscribers","subscription_url":"https://api.github.com/repos/Yelp/swagger-py/subscription","commits_url":"https://api.github.com/repos/Yelp/swagger-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/swagger-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/swagger-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/swagger-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/swagger-py/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/swagger-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/swagger-py/merges","archive_url":"https://api.github.com/repos/Yelp/swagger-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/swagger-py/downloads","issues_url":"https://api.github.com/repos/Yelp/swagger-py/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/swagger-py/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/swagger-py/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/swagger-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/swagger-py/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/swagger-py/releases{/id}","created_at":"2014-05-30T01:03:02Z","updated_at":"2015-03-07T15:40:25Z","pushed_at":"2015-03-06T02:04:28Z","git_url":"git://github.com/Yelp/swagger-py.git","ssh_url":"git@github.com:Yelp/swagger-py.git","clone_url":"https://github.com/Yelp/swagger-py.git","svn_url":"https://github.com/Yelp/swagger-py","homepage":"","size":1866,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":20,"forks":11,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/115"},"html":{"href":"https://github.com/Yelp/swagger-py/pull/115"},"issue":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/115"},"comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/swagger-py/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/swagger-py/statuses/c3eb0acb3ed3c86c3f11cc5a8015dffb8392b714"}}}}