{"action":"closed","number":8130,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130","id":48563654,"html_url":"https://github.com/joomla/joomla-cms/pull/8130","diff_url":"https://github.com/joomla/joomla-cms/pull/8130.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/8130.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8130","number":8130,"state":"closed","locked":false,"title":"Hide database error prefix","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"This PR implements the hide of the SQL Table Prefix from error messages if the webseite is not in debugging mode.\r\n\r\nIn debugging mode we get the full error message.\r\n\r\n#### How to test\r\n\r\n- produce a SQL Error message in the frontend\r\n- see that the prefixes get shown\r\n- apply this patch\r\n- see the prefixes are replaced with `#__`\r\n- enable debug for your user\r\n- see the prefixes are back\r\n\r\nThis implements the good idea by @ryandemmer from here: https://github.com/joomla/joomla-cms/issues/8129 Thanks. ","created_at":"2015-10-23T10:21:39Z","updated_at":"2015-10-25T10:30:36Z","closed_at":"2015-10-25T10:30:36Z","merged_at":"2015-10-25T10:30:36Z","merge_commit_sha":"27d4917a8f9f0de64099532aa93d9e7b77ff5ebe","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/11","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.4.6","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/11/labels","id":1269516,"number":11,"title":"Joomla! 3.4.6","description":"","creator":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":135,"state":"open","created_at":"2015-08-24T14:19:20Z","updated_at":"2015-10-25T10:30:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8130/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/4833e979b51ca73d1736fa44c0cede13185fb6be","head":{"label":"zero-24:HideDatabaseErrorPrefix","ref":"HideDatabaseErrorPrefix","sha":"4833e979b51ca73d1736fa44c0cede13185fb6be","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"repo":{"id":9977367,"name":"joomla-cms","full_name":"zero-24/joomla-cms","owner":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zero-24/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/zero-24/joomla-cms","forks_url":"https://api.github.com/repos/zero-24/joomla-cms/forks","keys_url":"https://api.github.com/repos/zero-24/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-24/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-24/joomla-cms/teams","hooks_url":"https://api.github.com/repos/zero-24/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/zero-24/joomla-cms/events","assignees_url":"https://api.github.com/repos/zero-24/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/zero-24/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/zero-24/joomla-cms/tags","blobs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-24/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-24/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-24/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-24/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-24/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/zero-24/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/zero-24/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/zero-24/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/zero-24/joomla-cms/subscription","commits_url":"https://api.github.com/repos/zero-24/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-24/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-24/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-24/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-24/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/zero-24/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-24/joomla-cms/merges","archive_url":"https://api.github.com/repos/zero-24/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-24/joomla-cms/downloads","issues_url":"https://api.github.com/repos/zero-24/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/zero-24/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-24/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-24/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-24/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/zero-24/joomla-cms/releases{/id}","created_at":"2013-05-10T08:20:03Z","updated_at":"2015-03-31T19:00:26Z","pushed_at":"2015-10-25T10:14:41Z","git_url":"git://github.com/zero-24/joomla-cms.git","ssh_url":"git@github.com:zero-24/joomla-cms.git","clone_url":"https://github.com/zero-24/joomla-cms.git","svn_url":"https://github.com/zero-24/joomla-cms","homepage":"http://joomla.org","size":137826,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"0cd99a8fe1f6b7bc49175ae890a3fd6c327077c3","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-10-25T09:21:25Z","pushed_at":"2015-10-25T10:30:36Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":349267,"stargazers_count":1695,"watchers_count":1695,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1918,"mirror_url":null,"open_issues_count":568,"forks":1918,"open_issues":568,"watchers":1695,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/8130"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8130"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8130/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8130/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/4833e979b51ca73d1736fa44c0cede13185fb6be"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":22,"review_comments":5,"commits":50,"additions":224,"deletions":22,"changed_files":5}}