{"push_id":869550159,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"7be4f29c7caaccead7a6d9014839a8b3a63da315","before":"ad922ae3c3f35fdd838b3f61718f994c9d1a110e","commits":[{"sha":"f7ee5ae6e99cd5503de8916174012f98f6518862","author":{"email":"dfed532b761fec7a0abb89359351f22f7617978d@gmail.com","name":"Andreas Hellwig"},"message":"My goal was to reveal the main part of install_gem_from_spec. From my\nperspective the main part is:\n1. Install\n2. Generate stubs\n3. Print message to the user\n(4. handle exceptions)\n\nWhile working on it I found that Bundler::Installer's run method and\ninstance variables weren't used when installing gems with\ninstall_gem_from_spec. The installer was (and still is) only used to\ngenerate executable stubs.\nSo I inserted the new GemInstaller in ParallelInstaller; passing the\ninstantiated Bundler::Installer to the GemInstaller only to generate\nthe executable stubs.\n\nBased on this I would continue by extracting two BinstubGenerator\nclasses and removing GemInstaller's dependency on Bundler::Installer,\npossibly allowing for a more concise way to generate binstubs in other\nparts of bundler.\n\nI was a bit intimidated by the amount of installers and weary to add\nanother one to this contested namespace. So I checked in with\n@indirect who approved of the general direction of the refactoring and\nsuggested to rename the old GemInstaller to RubyGemsGemInstaller.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/f7ee5ae6e99cd5503de8916174012f98f6518862"},{"sha":"7be4f29c7caaccead7a6d9014839a8b3a63da315","author":{"email":"5c2bd99229d434a2f7174ea3f8798d821bc7f9ae@barosl.com","name":"Homu"},"message":"Auto merge of #4063 - A5308Y:master, r=segiddins\n\nExtracting a new \"GemInstaller\" from installer.rb\n\nMy goal was to reveal the main part of install_gem_from_spec. From my\nperspective the main part is:\n1. Install\n2. Generate stubs\n3. Print message to the user\n(4. handle exceptions)\n\nWhile working on it I found that Bundler::Installer's run method and\ninstance variables weren't used when installing gems with\ninstall_gem_from_spec. The installer was (and still is) only used to\ngenerate executable stubs.\nSo I inserted the new GemInstaller in ParallelInstaller; passing the\ninstantiated Bundler::Installer to the GemInstaller only to generate\nthe executable stubs.\n\nBased on this I would continue by extracting two BinstubGenerator\nclasses and removing GemInstaller's dependency on Bundler::Installer,\npossibly allowing for a more concise way to generate binstubs in other\nparts of bundler.\n\nI was a bit intimidated by the amount of installers and weary to add\nanother one to this contested namespace. So I checked in with\n@indirect who approved of the general direction of the refactoring and\nsuggested to rename the old GemInstaller to RubyGemsGemInstaller.","distinct":false,"url":"https://api.github.com/repos/bundler/bundler/commits/7be4f29c7caaccead7a6d9014839a8b3a63da315"}]}