{"push_id":756380305,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"1b08cc170a84077afd4d15f4639a9a2cf398e9a2","before":"69a3b0df2ddba98d4fcbfa5d188894575c242643","commits":[{"sha":"8d46386bfe01b84982e25e915ad9cfbae5cf4cb1","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"conf: Add SCSI hostdev check for disk drive address already in use\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1210587  (partial)\n\nIf a SCSI subsystem <hostdev> element address is provided, we need to\nmake sure the address provided doesn't conflict with an existing or\nlibvirt generated address for a SCSI <disk> element. We can handle\nthis condition in device post processing since we're not generating an\naddress based on some target name - rather it's either generated based\non space or provided from the user. If the user provides one that conflicts,\nthen we need to disallow the change.\n\nThis will fix the issue where the domain XML provided an <address> for\nthe <hostdev>, but not the <disk> element where the address provided\nends up being the same address used for the <disk>. A <disk> address\nis generated using it's assigned <target> 'dev' name prior to the\ncheck/validation of the <hostdev> address value.","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/8d46386bfe01b84982e25e915ad9cfbae5cf4cb1"},{"sha":"d6ea4adbfcb3f66a1cf3e4d54d2ec7e79d7247e3","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"conf: Create locals for virDomainDiskDefAssignAddress\n\nCreate local controller/bus variables to be used by a future patch","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/d6ea4adbfcb3f66a1cf3e4d54d2ec7e79d7247e3"},{"sha":"1b08cc170a84077afd4d15f4639a9a2cf398e9a2","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"conf: Check for hostdev conflicts when assign default disk address\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1210587  (completed)\n\nWhen generating the default drive address for a SCSI <disk> device,\ncheck the generated address to ensure it doesn't conflict with a SCSI\n<hostdev> address. The <disk> address generation algorithm uses the\n<target> \"dev\" name in order to determine which controller and unit\nin order to place the device. Since a SCSI <hostdev> device doesn't\nrequire a target device name, its placement on the guest SCSI address\n\"could\" conflict.  For instance, if a SCSI <hostdev> exists at\ncontroller=0 unit=0 and an attempt to hotplug 'sda' into the guest\nmade, there would be a conflict if the <hostdev> is already using\n/dev/sda.","distinct":true,"url":"https://api.github.com/repos/libvirt/libvirt/commits/1b08cc170a84077afd4d15f4639a9a2cf398e9a2"}]}