{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/45428447","id":45428447,"diff_hunk":"@@ -74,6 +74,12 @@ fi\n AM_CONDITIONAL(ENABLE_TESTS_GLES,\n     [test \"x$enable_tests_gles\" = \"xyes\"])\n \n+HAVE_GTEST=\"no\"\n+ifdef([GTEST_LIB_CHECK],","path":"configure.ac","position":5,"original_position":5,"commit_id":"d0682a9a141a00918b1b4360bca2ca4c3193ed78","original_commit_id":"d0682a9a141a00918b1b4360bca2ca4c3193ed78","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"body":"Is it possible just use pkg-config to check gtest?","created_at":"2015-11-20T01:58:04Z","updated_at":"2015-11-20T01:58:04Z","html_url":"https://github.com/01org/libyami/pull/359#discussion_r45428447","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/45428447"},"html":{"href":"https://github.com/01org/libyami/pull/359#discussion_r45428447"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/359","id":51166820,"html_url":"https://github.com/01org/libyami/pull/359","diff_url":"https://github.com/01org/libyami/pull/359.diff","patch_url":"https://github.com/01org/libyami/pull/359.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/359","number":359,"state":"open","locked":false,"title":"Integrate GTest Framework","user":{"login":"uartie","id":677859,"avatar_url":"https://avatars.githubusercontent.com/u/677859?v=3","gravatar_id":"","url":"https://api.github.com/users/uartie","html_url":"https://github.com/uartie","followers_url":"https://api.github.com/users/uartie/followers","following_url":"https://api.github.com/users/uartie/following{/other_user}","gists_url":"https://api.github.com/users/uartie/gists{/gist_id}","starred_url":"https://api.github.com/users/uartie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uartie/subscriptions","organizations_url":"https://api.github.com/users/uartie/orgs","repos_url":"https://api.github.com/users/uartie/repos","events_url":"https://api.github.com/users/uartie/events{/privacy}","received_events_url":"https://api.github.com/users/uartie/received_events","type":"User","site_admin":false},"body":"GTest is a C++ test framework with a rich set of features that allow you to easily write tests for your project (https://code.google.com/p/googletest/).  This set of patches adds gtest as a dependency (currently optional, but required for unit test compilation).  Each libyami library will compile its own `unittest` executable, which can be individually executed directly or all of them through `make check`.  The unit tests do not require any user interaction and provides multiple types of result output formats. Therefore, they can be easily integrated into an automated testing framework.\r\n\r\nOn Fedora, the `gtest` and `gtest-devel` packages can be installed via 'yum' or 'dnf'.  I have not checked if other distros provide pre-built packages for gtest.  If they don't, then gtest can be compiled and installed from source easily.\r\n\r\nThe recommendation is that developers create unit tests to test new code they add, as appropriate.  However, this does not mean that everything can be tested with a unit test, so that judgement will need to be made on a case-by-case basis.\r\n\r\nI also recommend that the policy be that all unit tests pass before submitting/merging code to libyami (i.e. no unit test regressions allowed).\r\n\r\nOnce this patchset is merged, we can start filling in the unit tests to cover the current code.  I've already started some of this in the following branches [unittest-common](https://github.com/uartie/libyami/commits/unittest-common), [unittest-decoder](https://github.com/uartie/libyami/commits/unittest-decoder), and [unittest-encoder](https://github.com/uartie/libyami/commits/unittest-encoder)\r\n","created_at":"2015-11-19T01:07:07Z","updated_at":"2015-11-20T01:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cb8e914e38f7b1682058e3ba537add2104c9d27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/359/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/359/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/359/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/d0682a9a141a00918b1b4360bca2ca4c3193ed78","head":{"label":"uartie:unittest","ref":"unittest","sha":"d0682a9a141a00918b1b4360bca2ca4c3193ed78","user":{"login":"uartie","id":677859,"avatar_url":"https://avatars.githubusercontent.com/u/677859?v=3","gravatar_id":"","url":"https://api.github.com/users/uartie","html_url":"https://github.com/uartie","followers_url":"https://api.github.com/users/uartie/followers","following_url":"https://api.github.com/users/uartie/following{/other_user}","gists_url":"https://api.github.com/users/uartie/gists{/gist_id}","starred_url":"https://api.github.com/users/uartie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uartie/subscriptions","organizations_url":"https://api.github.com/users/uartie/orgs","repos_url":"https://api.github.com/users/uartie/repos","events_url":"https://api.github.com/users/uartie/events{/privacy}","received_events_url":"https://api.github.com/users/uartie/received_events","type":"User","site_admin":false},"repo":{"id":37226246,"name":"libyami","full_name":"uartie/libyami","owner":{"login":"uartie","id":677859,"avatar_url":"https://avatars.githubusercontent.com/u/677859?v=3","gravatar_id":"","url":"https://api.github.com/users/uartie","html_url":"https://github.com/uartie","followers_url":"https://api.github.com/users/uartie/followers","following_url":"https://api.github.com/users/uartie/following{/other_user}","gists_url":"https://api.github.com/users/uartie/gists{/gist_id}","starred_url":"https://api.github.com/users/uartie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uartie/subscriptions","organizations_url":"https://api.github.com/users/uartie/orgs","repos_url":"https://api.github.com/users/uartie/repos","events_url":"https://api.github.com/users/uartie/events{/privacy}","received_events_url":"https://api.github.com/users/uartie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uartie/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/uartie/libyami","forks_url":"https://api.github.com/repos/uartie/libyami/forks","keys_url":"https://api.github.com/repos/uartie/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uartie/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uartie/libyami/teams","hooks_url":"https://api.github.com/repos/uartie/libyami/hooks","issue_events_url":"https://api.github.com/repos/uartie/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/uartie/libyami/events","assignees_url":"https://api.github.com/repos/uartie/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/uartie/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/uartie/libyami/tags","blobs_url":"https://api.github.com/repos/uartie/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uartie/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uartie/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/uartie/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uartie/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/uartie/libyami/languages","stargazers_url":"https://api.github.com/repos/uartie/libyami/stargazers","contributors_url":"https://api.github.com/repos/uartie/libyami/contributors","subscribers_url":"https://api.github.com/repos/uartie/libyami/subscribers","subscription_url":"https://api.github.com/repos/uartie/libyami/subscription","commits_url":"https://api.github.com/repos/uartie/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/uartie/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/uartie/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/uartie/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/uartie/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/uartie/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uartie/libyami/merges","archive_url":"https://api.github.com/repos/uartie/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uartie/libyami/downloads","issues_url":"https://api.github.com/repos/uartie/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/uartie/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/uartie/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/uartie/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uartie/libyami/labels{/name}","releases_url":"https://api.github.com/repos/uartie/libyami/releases{/id}","created_at":"2015-06-10T22:35:57Z","updated_at":"2015-06-20T00:53:05Z","pushed_at":"2015-11-19T23:18:28Z","git_url":"git://github.com/uartie/libyami.git","ssh_url":"git@github.com:uartie/libyami.git","clone_url":"https://github.com/uartie/libyami.git","svn_url":"https://github.com/uartie/libyami","homepage":null,"size":2224,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"d8a8979f4c5c2aa82fe5152eaeb8fa9e150313f8","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","created_at":"2014-04-01T06:44:19Z","updated_at":"2015-11-10T04:35:43Z","pushed_at":"2015-11-20T01:54:05Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":2989,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":20,"forks":35,"open_issues":20,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/359"},"html":{"href":"https://github.com/01org/libyami/pull/359"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/359"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/d0682a9a141a00918b1b4360bca2ca4c3193ed78"}}}}