{"action":"created","issue":{"url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/3","labels_url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/3/comments","events_url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/3/events","html_url":"https://github.com/bodokaiser/node-shortify/pull/3","id":91656363,"number":3,"title":"Add ES6 import support","user":{"login":"morleyzhi","id":1668327,"avatar_url":"https://avatars.githubusercontent.com/u/1668327?v=3","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-28T23:50:15Z","updated_at":"2015-07-01T00:09:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bodokaiser/node-shortify/pulls/3","html_url":"https://github.com/bodokaiser/node-shortify/pull/3","diff_url":"https://github.com/bodokaiser/node-shortify/pull/3.diff","patch_url":"https://github.com/bodokaiser/node-shortify/pull/3.patch"},"body":"Firstly, sorry for the whitespace changes; ?w=1 might be a huge help.\r\n\r\nI made a bunch of changes that all add up to getting ES6 import support running. \r\n\r\n(1) The main file is written in ES6. I use babel to compile an ES5 file to a new `dist` folder.\r\n(2) I couldn't get the phantomjs-mocha testing to work, so I replaced it with vanilla mocha for testing.\r\n(3) Rewrite the test files to work with ES6 imports.\r\n\r\nSome other potential changes:\r\n\r\n* We don't use a lot of ES6 features, so it's no big deal to use ES5 for lib/index.js, and kill the dist thing.\r\n* This doesn't support rewriting `from\"moduleName\"`. I was too lazy to see if that is valid, or if changing the regex will just support it.\r\n\r\nI'm happy to make any suggestions you think are warranted!"},"comment":{"url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/comments/117376231","html_url":"https://github.com/bodokaiser/node-shortify/pull/3#issuecomment-117376231","issue_url":"https://api.github.com/repos/bodokaiser/node-shortify/issues/3","id":117376231,"user":{"login":"morleyzhi","id":1668327,"avatar_url":"https://avatars.githubusercontent.com/u/1668327?v=3","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T00:09:59Z","updated_at":"2015-07-01T00:09:59Z","body":"I added bare import support.  I also added a test case for issue #2, which appears to longer be an issue."}}