{"action":"created","issue":{"url":"https://api.github.com/repos/quantopian/zipline/issues/731","labels_url":"https://api.github.com/repos/quantopian/zipline/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/731/comments","events_url":"https://api.github.com/repos/quantopian/zipline/issues/731/events","html_url":"https://github.com/quantopian/zipline/pull/731","id":108723952,"number":731,"title":"TST: Remove instant fill from close position test.","user":{"login":"ehebert","id":185744,"avatar_url":"https://avatars.githubusercontent.com/u/185744?v=3","gravatar_id":"","url":"https://api.github.com/users/ehebert","html_url":"https://github.com/ehebert","followers_url":"https://api.github.com/users/ehebert/followers","following_url":"https://api.github.com/users/ehebert/following{/other_user}","gists_url":"https://api.github.com/users/ehebert/gists{/gist_id}","starred_url":"https://api.github.com/users/ehebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehebert/subscriptions","organizations_url":"https://api.github.com/users/ehebert/orgs","repos_url":"https://api.github.com/users/ehebert/repos","events_url":"https://api.github.com/users/ehebert/events{/privacy}","received_events_url":"https://api.github.com/users/ehebert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-28T18:54:56Z","updated_at":"2015-09-28T18:58:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/731","html_url":"https://github.com/quantopian/zipline/pull/731","diff_url":"https://github.com/quantopian/zipline/pull/731.diff","patch_url":"https://github.com/quantopian/zipline/pull/731.patch"},"body":"'instant fill' execution may be on the path to deprecation, (the removal\r\nis currently proposed by the branch which removes events in favor of\r\noperating over dts.), so remove instant_fill from the close position\r\ntests so that the input and output is the same between the proposed\r\nbranch and here.\r\n\r\n(This was one of the few places where instant fill was used that\r\nwas not testing instant fill behavior explicitly, so may be better to\r\nalign this test with the rest of the suite.)\r\n\r\nAlso, change test methods to make it more clear on which day the values\r\nthe expected and actual results differed."},"comment":{"url":"https://api.github.com/repos/quantopian/zipline/issues/comments/143843997","html_url":"https://github.com/quantopian/zipline/pull/731#issuecomment-143843997","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/731","id":143843997,"user":{"login":"jfkirk","id":10326791,"avatar_url":"https://avatars.githubusercontent.com/u/10326791?v=3","gravatar_id":"","url":"https://api.github.com/users/jfkirk","html_url":"https://github.com/jfkirk","followers_url":"https://api.github.com/users/jfkirk/followers","following_url":"https://api.github.com/users/jfkirk/following{/other_user}","gists_url":"https://api.github.com/users/jfkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/jfkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfkirk/subscriptions","organizations_url":"https://api.github.com/users/jfkirk/orgs","repos_url":"https://api.github.com/users/jfkirk/repos","events_url":"https://api.github.com/users/jfkirk/events{/privacy}","received_events_url":"https://api.github.com/users/jfkirk/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T18:58:29Z","updated_at":"2015-09-28T18:58:29Z","body":"LGTM!"}}