{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/6723","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/6723/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6723/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/6723/events","html_url":"https://github.com/dotnet/roslyn/pull/6723","id":116438423,"number":6723,"title":"Update result provider to support MC++ EE","user":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-11T22:50:21Z","updated_at":"2015-11-11T22:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6723","html_url":"https://github.com/dotnet/roslyn/pull/6723","diff_url":"https://github.com/dotnet/roslyn/pull/6723.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6723.patch"},"body":"This change updates the result provider to support the new managed C++ EE.  Per prior discussion, support is provided by adding an InternalsVisibleTo declaration, since the existing public interfaces are insufficient to meet the MC++ EE's needs.  The MC++ EE now inherits from ResultProvider and Formatter and overrides the methods that are made virtual in this pull request.\r\n\r\nThis change also requires a debugger reference update, so that Roslyn is now referencing the Update 2 version of Microsoft.VisualStudio.Debugger.Engine.dll and Microsoft.VisualStudio.Debugger.Metadata.dll.  This is necessary to take advantage of new api's to allow us to keep track of modopts and modreqs inside of DkmClrCustomTypeInfo.  (The MC++ compiler emits modopts for several language-specific constructs, such as reference types and boxed value-types, the MC++ EE must recognize these modopts to provide the correct experience when performing inspection on code that uses such constructs)."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/155934642","html_url":"https://github.com/dotnet/roslyn/pull/6723#issuecomment-155934642","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6723","id":155934642,"user":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T22:52:11Z","updated_at":"2015-11-11T22:52:11Z","body":"This pull request is a replacement for my previous pull request, which was never checked in.  Between then and now, I cleaned up a bunch of stuff and tweaked the interfaces as additional needs came up that I was not aware of at the time.  The new pull request generates the internals visible to attribute the way we will actually do so for shipping, using the real public key for the MCppEE assembly."}}