{"action":"created","comment":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments/44736776","id":44736776,"diff_hunk":"@@ -0,0 +1,57 @@\n+/** @file\n+    @brief Auto-generated configuration header - do not edit!\n+\n+    @date 2015\n+\n+    @author\n+    Sensics, Inc.\n+    <http://sensics.com/osvr>\n+*/\n+\n+// Copyright 2015 Sensics, Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#ifndef INCLUDED_ConfigFilePaths_h_GUID_241E9C9C_0E0E_46B0_9DED_8F8059306192\n+#define INCLUDED_ConfigFilePaths_h_GUID_241E9C9C_0E0E_46B0_9DED_8F8059306192\n+\n+#include <osvr/Util/PlatformConfig.h>\n+namespace osvr {\n+namespace server {\n+\n+    std::vector<std::string> getDefaultConfigFilePaths() {\n+\n+#ifdef OSVR_WINDOWS\n+        std::string appdata = std::getenv(\"APPDATA\");\n+#else\n+        std::string home = std::getenv(\"HOME\");\n+#endif\n+\n+        std::vector<std::string> names;\n+        names.push_back(home + \"/.osvr/osvr_server_config.json\");\n+        names.push_back(\n+            \"@CMAKE_INSTALL_FULL_SYSCONFDIR@/osvr_server_config.json\");\n+\n+#if defined(OSVR_WINDOWS)\n+        names.push_back(appdata + \"\\\\OSVR\\\\osvr_server_config.json\");\n+        names.push_back(\"osvr_server_config.json\");\n+#elif defined(OSVR_MACOSX)\n+        names.push_back(\n+            home + \"/Library/Application Support/OSVR/osvr_server_config.json\");","path":"src/osvr/Server/ConfigFilePaths.h.cmake_in","position":50,"original_position":50,"commit_id":"ac1720a84d737cad173a8108b0d2f2583ce89727","original_commit_id":"ac1720a84d737cad173a8108b0d2f2583ce89727","user":{"login":"d235j","id":44988,"avatar_url":"https://avatars.githubusercontent.com/u/44988?v=3","gravatar_id":"","url":"https://api.github.com/users/d235j","html_url":"https://github.com/d235j","followers_url":"https://api.github.com/users/d235j/followers","following_url":"https://api.github.com/users/d235j/following{/other_user}","gists_url":"https://api.github.com/users/d235j/gists{/gist_id}","starred_url":"https://api.github.com/users/d235j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d235j/subscriptions","organizations_url":"https://api.github.com/users/d235j/orgs","repos_url":"https://api.github.com/users/d235j/repos","events_url":"https://api.github.com/users/d235j/events{/privacy}","received_events_url":"https://api.github.com/users/d235j/received_events","type":"User","site_admin":false},"body":"Apple doesn't do localization this way. For localization, a directory gets named .localized, and a plist defines what the localized names should be. So no, /Library/Application Support never gets localized.","created_at":"2015-11-13T00:37:30Z","updated_at":"2015-11-13T00:37:30Z","html_url":"https://github.com/OSVR/OSVR-Core/pull/265#discussion_r44736776","pull_request_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments/44736776"},"html":{"href":"https://github.com/OSVR/OSVR-Core/pull/265#discussion_r44736776"},"pull_request":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265","id":50042931,"html_url":"https://github.com/OSVR/OSVR-Core/pull/265","diff_url":"https://github.com/OSVR/OSVR-Core/pull/265.diff","patch_url":"https://github.com/OSVR/OSVR-Core/pull/265.patch","issue_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/265","number":265,"state":"open","locked":false,"title":"Automatically find config data or load default","user":{"login":"d235j","id":44988,"avatar_url":"https://avatars.githubusercontent.com/u/44988?v=3","gravatar_id":"","url":"https://api.github.com/users/d235j","html_url":"https://github.com/d235j","followers_url":"https://api.github.com/users/d235j/followers","following_url":"https://api.github.com/users/d235j/following{/other_user}","gists_url":"https://api.github.com/users/d235j/gists{/gist_id}","starred_url":"https://api.github.com/users/d235j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d235j/subscriptions","organizations_url":"https://api.github.com/users/d235j/orgs","repos_url":"https://api.github.com/users/d235j/repos","events_url":"https://api.github.com/users/d235j/events{/privacy}","received_events_url":"https://api.github.com/users/d235j/received_events","type":"User","site_admin":false},"body":"This enables automatic searching for config files based on a list of hardcoded paths (this can be changed if needed), or loads a default empty config if no config filename is passed.\r\n\r\nThis, together with https://github.com/OSVR/OSVR-Core/pull/264, should solve https://github.com/OSVR/OSVR-Core/issues/238, https://github.com/OSVR/OSVR-Core/issues/185, and https://github.com/OSVR/OSVR-Core/issues/171, https://github.com/OSVR/OSVR-Core/issues/172, at least, but may need some changes/tweaks.\r\n\r\nBefore we can claim full autoconfig support we also need to implement plugin directory path detection.","created_at":"2015-11-07T19:12:11Z","updated_at":"2015-11-13T00:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6979e0be0fc3f9575a2eda337bc69d33cec1da5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265/commits","review_comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265/comments","review_comment_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/265/comments","statuses_url":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/ac1720a84d737cad173a8108b0d2f2583ce89727","head":{"label":"d235j:find-config","ref":"find-config","sha":"ac1720a84d737cad173a8108b0d2f2583ce89727","user":{"login":"d235j","id":44988,"avatar_url":"https://avatars.githubusercontent.com/u/44988?v=3","gravatar_id":"","url":"https://api.github.com/users/d235j","html_url":"https://github.com/d235j","followers_url":"https://api.github.com/users/d235j/followers","following_url":"https://api.github.com/users/d235j/following{/other_user}","gists_url":"https://api.github.com/users/d235j/gists{/gist_id}","starred_url":"https://api.github.com/users/d235j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d235j/subscriptions","organizations_url":"https://api.github.com/users/d235j/orgs","repos_url":"https://api.github.com/users/d235j/repos","events_url":"https://api.github.com/users/d235j/events{/privacy}","received_events_url":"https://api.github.com/users/d235j/received_events","type":"User","site_admin":false},"repo":{"id":43470183,"name":"OSVR-Core","full_name":"d235j/OSVR-Core","owner":{"login":"d235j","id":44988,"avatar_url":"https://avatars.githubusercontent.com/u/44988?v=3","gravatar_id":"","url":"https://api.github.com/users/d235j","html_url":"https://github.com/d235j","followers_url":"https://api.github.com/users/d235j/followers","following_url":"https://api.github.com/users/d235j/following{/other_user}","gists_url":"https://api.github.com/users/d235j/gists{/gist_id}","starred_url":"https://api.github.com/users/d235j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d235j/subscriptions","organizations_url":"https://api.github.com/users/d235j/orgs","repos_url":"https://api.github.com/users/d235j/repos","events_url":"https://api.github.com/users/d235j/events{/privacy}","received_events_url":"https://api.github.com/users/d235j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d235j/OSVR-Core","description":"The core libraries, applications, and plugins of the OSVR software platform.","fork":true,"url":"https://api.github.com/repos/d235j/OSVR-Core","forks_url":"https://api.github.com/repos/d235j/OSVR-Core/forks","keys_url":"https://api.github.com/repos/d235j/OSVR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d235j/OSVR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d235j/OSVR-Core/teams","hooks_url":"https://api.github.com/repos/d235j/OSVR-Core/hooks","issue_events_url":"https://api.github.com/repos/d235j/OSVR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/d235j/OSVR-Core/events","assignees_url":"https://api.github.com/repos/d235j/OSVR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/d235j/OSVR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/d235j/OSVR-Core/tags","blobs_url":"https://api.github.com/repos/d235j/OSVR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d235j/OSVR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d235j/OSVR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/d235j/OSVR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d235j/OSVR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/d235j/OSVR-Core/languages","stargazers_url":"https://api.github.com/repos/d235j/OSVR-Core/stargazers","contributors_url":"https://api.github.com/repos/d235j/OSVR-Core/contributors","subscribers_url":"https://api.github.com/repos/d235j/OSVR-Core/subscribers","subscription_url":"https://api.github.com/repos/d235j/OSVR-Core/subscription","commits_url":"https://api.github.com/repos/d235j/OSVR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/d235j/OSVR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/d235j/OSVR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/d235j/OSVR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/d235j/OSVR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/d235j/OSVR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d235j/OSVR-Core/merges","archive_url":"https://api.github.com/repos/d235j/OSVR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d235j/OSVR-Core/downloads","issues_url":"https://api.github.com/repos/d235j/OSVR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/d235j/OSVR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/d235j/OSVR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/d235j/OSVR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d235j/OSVR-Core/labels{/name}","releases_url":"https://api.github.com/repos/d235j/OSVR-Core/releases{/id}","created_at":"2015-10-01T00:44:29Z","updated_at":"2015-10-01T00:44:32Z","pushed_at":"2015-11-07T22:18:00Z","git_url":"git://github.com/d235j/OSVR-Core.git","ssh_url":"git@github.com:d235j/OSVR-Core.git","clone_url":"https://github.com/d235j/OSVR-Core.git","svn_url":"https://github.com/d235j/OSVR-Core","homepage":"","size":10789,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OSVR:master","ref":"master","sha":"1284398363a9b7ef0f82d7c533f23eec7f806443","user":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"repo":{"id":25528375,"name":"OSVR-Core","full_name":"OSVR/OSVR-Core","owner":{"login":"OSVR","id":10343613,"avatar_url":"https://avatars.githubusercontent.com/u/10343613?v=3","gravatar_id":"","url":"https://api.github.com/users/OSVR","html_url":"https://github.com/OSVR","followers_url":"https://api.github.com/users/OSVR/followers","following_url":"https://api.github.com/users/OSVR/following{/other_user}","gists_url":"https://api.github.com/users/OSVR/gists{/gist_id}","starred_url":"https://api.github.com/users/OSVR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSVR/subscriptions","organizations_url":"https://api.github.com/users/OSVR/orgs","repos_url":"https://api.github.com/users/OSVR/repos","events_url":"https://api.github.com/users/OSVR/events{/privacy}","received_events_url":"https://api.github.com/users/OSVR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSVR/OSVR-Core","description":"The core libraries, applications, and plugins of the OSVR software platform.","fork":false,"url":"https://api.github.com/repos/OSVR/OSVR-Core","forks_url":"https://api.github.com/repos/OSVR/OSVR-Core/forks","keys_url":"https://api.github.com/repos/OSVR/OSVR-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSVR/OSVR-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSVR/OSVR-Core/teams","hooks_url":"https://api.github.com/repos/OSVR/OSVR-Core/hooks","issue_events_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/events{/number}","events_url":"https://api.github.com/repos/OSVR/OSVR-Core/events","assignees_url":"https://api.github.com/repos/OSVR/OSVR-Core/assignees{/user}","branches_url":"https://api.github.com/repos/OSVR/OSVR-Core/branches{/branch}","tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/tags","blobs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/OSVR/OSVR-Core/languages","stargazers_url":"https://api.github.com/repos/OSVR/OSVR-Core/stargazers","contributors_url":"https://api.github.com/repos/OSVR/OSVR-Core/contributors","subscribers_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscribers","subscription_url":"https://api.github.com/repos/OSVR/OSVR-Core/subscription","commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSVR/OSVR-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSVR/OSVR-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSVR/OSVR-Core/contents/{+path}","compare_url":"https://api.github.com/repos/OSVR/OSVR-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSVR/OSVR-Core/merges","archive_url":"https://api.github.com/repos/OSVR/OSVR-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSVR/OSVR-Core/downloads","issues_url":"https://api.github.com/repos/OSVR/OSVR-Core/issues{/number}","pulls_url":"https://api.github.com/repos/OSVR/OSVR-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/OSVR/OSVR-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/OSVR/OSVR-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSVR/OSVR-Core/labels{/name}","releases_url":"https://api.github.com/repos/OSVR/OSVR-Core/releases{/id}","created_at":"2014-10-21T14:56:46Z","updated_at":"2015-11-09T18:20:04Z","pushed_at":"2015-11-13T00:13:24Z","git_url":"git://github.com/OSVR/OSVR-Core.git","ssh_url":"git@github.com:OSVR/OSVR-Core.git","clone_url":"https://github.com/OSVR/OSVR-Core.git","svn_url":"https://github.com/OSVR/OSVR-Core","homepage":"","size":21896,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":114,"forks":20,"open_issues":114,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265"},"html":{"href":"https://github.com/OSVR/OSVR-Core/pull/265"},"issue":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/issues/265"},"comments":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/OSVR/OSVR-Core/statuses/ac1720a84d737cad173a8108b0d2f2583ce89727"}}}}