{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/9082","labels_url":"https://api.github.com/repos/laravel/framework/issues/9082/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9082/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/9082/events","html_url":"https://github.com/laravel/framework/pull/9082","id":85467720,"number":9082,"title":"Enhance the checks in Encrypter constructor","user":{"login":"ibrasho","id":188776,"avatar_url":"https://avatars.githubusercontent.com/u/188776?v=3","gravatar_id":"","url":"https://api.github.com/users/ibrasho","html_url":"https://github.com/ibrasho","followers_url":"https://api.github.com/users/ibrasho/followers","following_url":"https://api.github.com/users/ibrasho/following{/other_user}","gists_url":"https://api.github.com/users/ibrasho/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrasho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrasho/subscriptions","organizations_url":"https://api.github.com/users/ibrasho/orgs","repos_url":"https://api.github.com/users/ibrasho/repos","events_url":"https://api.github.com/users/ibrasho/events{/privacy}","received_events_url":"https://api.github.com/users/ibrasho/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-06-05T08:06:44Z","updated_at":"2015-06-06T17:36:59Z","closed_at":"2015-06-05T11:58:43Z","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9082","html_url":"https://github.com/laravel/framework/pull/9082","diff_url":"https://github.com/laravel/framework/pull/9082.diff","patch_url":"https://github.com/laravel/framework/pull/9082.patch"},"body":"One issue I see with the length enforced checks is that if someone was using an invalid key (shorter or longer than they should) this would break BC for them. This applies to @GrahamCampbell RP https://github.com/laravel/framework/pull/9063 too\r\n\r\nWhat do you think @taylorotwell ?\r\n\r\ncc/ @ircmaxell @paragonie-scott"},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/109622084","html_url":"https://github.com/laravel/framework/pull/9082#issuecomment-109622084","issue_url":"https://api.github.com/repos/laravel/framework/issues/9082","id":109622084,"user":{"login":"paragonie-scott","id":11591518,"avatar_url":"https://avatars.githubusercontent.com/u/11591518?v=3","gravatar_id":"","url":"https://api.github.com/users/paragonie-scott","html_url":"https://github.com/paragonie-scott","followers_url":"https://api.github.com/users/paragonie-scott/followers","following_url":"https://api.github.com/users/paragonie-scott/following{/other_user}","gists_url":"https://api.github.com/users/paragonie-scott/gists{/gist_id}","starred_url":"https://api.github.com/users/paragonie-scott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paragonie-scott/subscriptions","organizations_url":"https://api.github.com/users/paragonie-scott/orgs","repos_url":"https://api.github.com/users/paragonie-scott/repos","events_url":"https://api.github.com/users/paragonie-scott/events{/privacy}","received_events_url":"https://api.github.com/users/paragonie-scott/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T17:36:59Z","updated_at":"2015-06-06T17:36:59Z","body":"> Adding the cipher used to the final payload should be fine, right?\r\n\r\nI believe so. It probably doesn't even need to be MAC'd, esp. if the MAC algorithm can change in the future."}}