{"action":"created","comment":{"url":"https://api.github.com/repos/ament/ament_tools/pulls/comments/41662508","id":41662508,"diff_hunk":"@@ -167,12 +177,15 @@ def _common_cmake_on_test(self, context, build_type):\n         prefix = self._get_command_prefix('test', context)\n         if not IS_WINDOWS:\n             if has_make_target(context.build_space, 'test') or context.dry_run:\n-                if MAKE_EXECUTABLE is None:\n-                    raise VerbExecutionError(\"Could not find 'make' executable\")\n-                cmd = prefix + [MAKE_EXECUTABLE, 'test']\n-                if 'ARGS' not in os.environ:\n-                    cmd.append('ARGS=\"-V\"')\n-                yield BuildAction(cmd)\n+                if CTEST_EXECUTABLE is None:\n+                    raise VerbExecutionError(\"Could not find 'ctest' executable\")\n+                # invoke CTest directly in order to pass arguments\n+                yield BuildAction(prefix + [\n+                    CTEST_EXECUTABLE,\n+                    # show all test output\n+                    '-V',\n+                    '--force-new-ctest-process'] +\n+                    context.ctest_args)","path":"ament_tools/build_types/cmake.py","position":50,"original_position":50,"commit_id":"0340ec5816a6015a103f94d938bf3be83384645e","original_commit_id":"0340ec5816a6015a103f94d938bf3be83384645e","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Is the `make test` target nothing more than invoking `ctest`? Do you not need to tell `ctest` where the tests are? Why not continue to use the `ARGS` method?","created_at":"2015-10-09T18:26:20Z","updated_at":"2015-10-09T18:26:20Z","html_url":"https://github.com/ament/ament_tools/pull/54#discussion_r41662508","pull_request_url":"https://api.github.com/repos/ament/ament_tools/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/comments/41662508"},"html":{"href":"https://github.com/ament/ament_tools/pull/54#discussion_r41662508"},"pull_request":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/ament/ament_tools/pulls/54","id":47302223,"html_url":"https://github.com/ament/ament_tools/pull/54","diff_url":"https://github.com/ament/ament_tools/pull/54.diff","patch_url":"https://github.com/ament/ament_tools/pull/54.patch","issue_url":"https://api.github.com/repos/ament/ament_tools/issues/54","number":54,"state":"open","locked":false,"title":"add --ctest-args option, use ctest to run tests on non-windows","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Test results are the same after as well as before this patch:\r\n* http://ci.ros2.org/job/ros2_batch_ci_linux/409/testReport/\r\n* http://ci.ros2.org/job/ros2_batch_ci_linux/408/testReport/\r\n\r\n<!-- -->\r\n\r\n* http://ci.ros2.org/job/ros2_batch_ci_osx/306/testReport/\r\n* http://ci.ros2.org/job/ros2_batch_ci_osx/305/testReport/","created_at":"2015-10-09T18:07:55Z","updated_at":"2015-10-09T18:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca9d709f8edb208ab35028b51b28e0674f6c0bf2","assignee":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ament/ament_tools/pulls/54/commits","review_comments_url":"https://api.github.com/repos/ament/ament_tools/pulls/54/comments","review_comment_url":"https://api.github.com/repos/ament/ament_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ament/ament_tools/issues/54/comments","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/0340ec5816a6015a103f94d938bf3be83384645e","head":{"label":"ament:test_labels","ref":"test_labels","sha":"0340ec5816a6015a103f94d938bf3be83384645e","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19927831,"name":"ament_tools","full_name":"ament/ament_tools","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_tools","description":"Command line tools for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_tools","forks_url":"https://api.github.com/repos/ament/ament_tools/forks","keys_url":"https://api.github.com/repos/ament/ament_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_tools/teams","hooks_url":"https://api.github.com/repos/ament/ament_tools/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_tools/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_tools/events","assignees_url":"https://api.github.com/repos/ament/ament_tools/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_tools/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_tools/tags","blobs_url":"https://api.github.com/repos/ament/ament_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_tools/languages","stargazers_url":"https://api.github.com/repos/ament/ament_tools/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_tools/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_tools/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_tools/subscription","commits_url":"https://api.github.com/repos/ament/ament_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_tools/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_tools/merges","archive_url":"https://api.github.com/repos/ament/ament_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_tools/downloads","issues_url":"https://api.github.com/repos/ament/ament_tools/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_tools/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_tools/releases{/id}","created_at":"2014-05-19T03:13:15Z","updated_at":"2015-04-15T22:04:56Z","pushed_at":"2015-10-09T18:07:56Z","git_url":"git://github.com/ament/ament_tools.git","ssh_url":"git@github.com:ament/ament_tools.git","clone_url":"https://github.com/ament/ament_tools.git","svn_url":"https://github.com/ament/ament_tools","homepage":"","size":867,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"ament:master","ref":"master","sha":"60c0ac484161c4490ec157206f56055d4fccb3cc","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19927831,"name":"ament_tools","full_name":"ament/ament_tools","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_tools","description":"Command line tools for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_tools","forks_url":"https://api.github.com/repos/ament/ament_tools/forks","keys_url":"https://api.github.com/repos/ament/ament_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_tools/teams","hooks_url":"https://api.github.com/repos/ament/ament_tools/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_tools/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_tools/events","assignees_url":"https://api.github.com/repos/ament/ament_tools/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_tools/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_tools/tags","blobs_url":"https://api.github.com/repos/ament/ament_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_tools/languages","stargazers_url":"https://api.github.com/repos/ament/ament_tools/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_tools/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_tools/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_tools/subscription","commits_url":"https://api.github.com/repos/ament/ament_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_tools/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_tools/merges","archive_url":"https://api.github.com/repos/ament/ament_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_tools/downloads","issues_url":"https://api.github.com/repos/ament/ament_tools/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_tools/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_tools/releases{/id}","created_at":"2014-05-19T03:13:15Z","updated_at":"2015-04-15T22:04:56Z","pushed_at":"2015-10-09T18:07:56Z","git_url":"git://github.com/ament/ament_tools.git","ssh_url":"git@github.com:ament/ament_tools.git","clone_url":"https://github.com/ament/ament_tools.git","svn_url":"https://github.com/ament/ament_tools","homepage":"","size":867,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/54"},"html":{"href":"https://github.com/ament/ament_tools/pull/54"},"issue":{"href":"https://api.github.com/repos/ament/ament_tools/issues/54"},"comments":{"href":"https://api.github.com/repos/ament/ament_tools/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/ament/ament_tools/statuses/0340ec5816a6015a103f94d938bf3be83384645e"}}}}