{"action":"created","comment":{"url":"https://api.github.com/repos/pkp/ojs/pulls/comments/25714967","id":25714967,"diff_hunk":"@@ -434,7 +434,7 @@ function termsAgreed($journalId) {\n \t\t$termsAgreed = unserialize($this->getSetting($journalId, 'terms_of_use_agreement'));\n \t\t\n \t\tforeach (array_keys($terms) as $term) {\n-\t\t\tif (!isset($termsAgreed[$term]) || ($termsAgreed[$term] == false)) return false;\n+\t\t\tif (!isset($termsAgreed[$term]) || ($termsAgreed[$term] == null)) return false;","path":"plugins/generic/pln/PLNPlugin.inc.php","position":5,"original_position":5,"commit_id":"41950394b86532aa253744fe18d7d4d5191d6958","original_commit_id":"41950394b86532aa253744fe18d7d4d5191d6958","user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"body":"With ==, I don't this change has any effect -- null and false both evaluate to false.","created_at":"2015-03-03T18:56:53Z","updated_at":"2015-03-03T18:56:53Z","html_url":"https://github.com/pkp/ojs/pull/438#discussion_r25714967","pull_request_url":"https://api.github.com/repos/pkp/ojs/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/pkp/ojs/pulls/comments/25714967"},"html":{"href":"https://github.com/pkp/ojs/pull/438#discussion_r25714967"},"pull_request":{"href":"https://api.github.com/repos/pkp/ojs/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/pkp/ojs/pulls/438","id":30401197,"html_url":"https://github.com/pkp/ojs/pull/438","diff_url":"https://github.com/pkp/ojs/pull/438.diff","patch_url":"https://github.com/pkp/ojs/pull/438.patch","issue_url":"https://api.github.com/repos/pkp/ojs/issues/438","number":438,"state":"open","locked":false,"title":"Include terms of use agreement date in deposit xml","user":{"login":"ubermichael","id":1328893,"avatar_url":"https://avatars.githubusercontent.com/u/1328893?v=3","gravatar_id":"","url":"https://api.github.com/users/ubermichael","html_url":"https://github.com/ubermichael","followers_url":"https://api.github.com/users/ubermichael/followers","following_url":"https://api.github.com/users/ubermichael/following{/other_user}","gists_url":"https://api.github.com/users/ubermichael/gists{/gist_id}","starred_url":"https://api.github.com/users/ubermichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubermichael/subscriptions","organizations_url":"https://api.github.com/users/ubermichael/orgs","repos_url":"https://api.github.com/users/ubermichael/repos","events_url":"https://api.github.com/users/ubermichael/events{/privacy}","received_events_url":"https://api.github.com/users/ubermichael/received_events","type":"User","site_admin":false},"body":"Make the terms_of_use_agreement plugin setting a date (or null) instead of a boolean. Use the date in the terms of use XML with the deposit package.\r\n\r\nFixes pkp/pkp-lib#375","created_at":"2015-03-03T18:51:20Z","updated_at":"2015-03-03T18:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6df496ab227ca22938d9ede65115029cda72f92c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pkp/ojs/pulls/438/commits","review_comments_url":"https://api.github.com/repos/pkp/ojs/pulls/438/comments","review_comment_url":"https://api.github.com/repos/pkp/ojs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pkp/ojs/issues/438/comments","statuses_url":"https://api.github.com/repos/pkp/ojs/statuses/41950394b86532aa253744fe18d7d4d5191d6958","head":{"label":"ubermichael:ojs-dev-2_4-gh375","ref":"ojs-dev-2_4-gh375","sha":"41950394b86532aa253744fe18d7d4d5191d6958","user":{"login":"ubermichael","id":1328893,"avatar_url":"https://avatars.githubusercontent.com/u/1328893?v=3","gravatar_id":"","url":"https://api.github.com/users/ubermichael","html_url":"https://github.com/ubermichael","followers_url":"https://api.github.com/users/ubermichael/followers","following_url":"https://api.github.com/users/ubermichael/following{/other_user}","gists_url":"https://api.github.com/users/ubermichael/gists{/gist_id}","starred_url":"https://api.github.com/users/ubermichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubermichael/subscriptions","organizations_url":"https://api.github.com/users/ubermichael/orgs","repos_url":"https://api.github.com/users/ubermichael/repos","events_url":"https://api.github.com/users/ubermichael/events{/privacy}","received_events_url":"https://api.github.com/users/ubermichael/received_events","type":"User","site_admin":false},"repo":{"id":27395446,"name":"ojs","full_name":"ubermichael/ojs","owner":{"login":"ubermichael","id":1328893,"avatar_url":"https://avatars.githubusercontent.com/u/1328893?v=3","gravatar_id":"","url":"https://api.github.com/users/ubermichael","html_url":"https://github.com/ubermichael","followers_url":"https://api.github.com/users/ubermichael/followers","following_url":"https://api.github.com/users/ubermichael/following{/other_user}","gists_url":"https://api.github.com/users/ubermichael/gists{/gist_id}","starred_url":"https://api.github.com/users/ubermichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubermichael/subscriptions","organizations_url":"https://api.github.com/users/ubermichael/orgs","repos_url":"https://api.github.com/users/ubermichael/repos","events_url":"https://api.github.com/users/ubermichael/events{/privacy}","received_events_url":"https://api.github.com/users/ubermichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ubermichael/ojs","description":"Open Journal Systems","fork":true,"url":"https://api.github.com/repos/ubermichael/ojs","forks_url":"https://api.github.com/repos/ubermichael/ojs/forks","keys_url":"https://api.github.com/repos/ubermichael/ojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubermichael/ojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubermichael/ojs/teams","hooks_url":"https://api.github.com/repos/ubermichael/ojs/hooks","issue_events_url":"https://api.github.com/repos/ubermichael/ojs/issues/events{/number}","events_url":"https://api.github.com/repos/ubermichael/ojs/events","assignees_url":"https://api.github.com/repos/ubermichael/ojs/assignees{/user}","branches_url":"https://api.github.com/repos/ubermichael/ojs/branches{/branch}","tags_url":"https://api.github.com/repos/ubermichael/ojs/tags","blobs_url":"https://api.github.com/repos/ubermichael/ojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubermichael/ojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubermichael/ojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubermichael/ojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubermichael/ojs/statuses/{sha}","languages_url":"https://api.github.com/repos/ubermichael/ojs/languages","stargazers_url":"https://api.github.com/repos/ubermichael/ojs/stargazers","contributors_url":"https://api.github.com/repos/ubermichael/ojs/contributors","subscribers_url":"https://api.github.com/repos/ubermichael/ojs/subscribers","subscription_url":"https://api.github.com/repos/ubermichael/ojs/subscription","commits_url":"https://api.github.com/repos/ubermichael/ojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubermichael/ojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubermichael/ojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubermichael/ojs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubermichael/ojs/contents/{+path}","compare_url":"https://api.github.com/repos/ubermichael/ojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubermichael/ojs/merges","archive_url":"https://api.github.com/repos/ubermichael/ojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubermichael/ojs/downloads","issues_url":"https://api.github.com/repos/ubermichael/ojs/issues{/number}","pulls_url":"https://api.github.com/repos/ubermichael/ojs/pulls{/number}","milestones_url":"https://api.github.com/repos/ubermichael/ojs/milestones{/number}","notifications_url":"https://api.github.com/repos/ubermichael/ojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubermichael/ojs/labels{/name}","releases_url":"https://api.github.com/repos/ubermichael/ojs/releases{/id}","created_at":"2014-12-01T19:20:28Z","updated_at":"2015-02-26T22:57:43Z","pushed_at":"2015-03-03T18:42:25Z","git_url":"git://github.com/ubermichael/ojs.git","ssh_url":"git@github.com:ubermichael/ojs.git","clone_url":"https://github.com/ubermichael/ojs.git","svn_url":"https://github.com/ubermichael/ojs","homepage":"http://pkp.sfu.ca/ojs","size":105303,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pkp:ojs-dev-2_4","ref":"ojs-dev-2_4","sha":"fbff5cf855e61a47b264d78767fee5d8143e0ce6","user":{"login":"pkp","id":130896,"avatar_url":"https://avatars.githubusercontent.com/u/130896?v=3","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"repo":{"id":375152,"name":"ojs","full_name":"pkp/ojs","owner":{"login":"pkp","id":130896,"avatar_url":"https://avatars.githubusercontent.com/u/130896?v=3","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pkp/ojs","description":"Open Journal Systems","fork":false,"url":"https://api.github.com/repos/pkp/ojs","forks_url":"https://api.github.com/repos/pkp/ojs/forks","keys_url":"https://api.github.com/repos/pkp/ojs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkp/ojs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkp/ojs/teams","hooks_url":"https://api.github.com/repos/pkp/ojs/hooks","issue_events_url":"https://api.github.com/repos/pkp/ojs/issues/events{/number}","events_url":"https://api.github.com/repos/pkp/ojs/events","assignees_url":"https://api.github.com/repos/pkp/ojs/assignees{/user}","branches_url":"https://api.github.com/repos/pkp/ojs/branches{/branch}","tags_url":"https://api.github.com/repos/pkp/ojs/tags","blobs_url":"https://api.github.com/repos/pkp/ojs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkp/ojs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkp/ojs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkp/ojs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkp/ojs/statuses/{sha}","languages_url":"https://api.github.com/repos/pkp/ojs/languages","stargazers_url":"https://api.github.com/repos/pkp/ojs/stargazers","contributors_url":"https://api.github.com/repos/pkp/ojs/contributors","subscribers_url":"https://api.github.com/repos/pkp/ojs/subscribers","subscription_url":"https://api.github.com/repos/pkp/ojs/subscription","commits_url":"https://api.github.com/repos/pkp/ojs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkp/ojs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkp/ojs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkp/ojs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkp/ojs/contents/{+path}","compare_url":"https://api.github.com/repos/pkp/ojs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkp/ojs/merges","archive_url":"https://api.github.com/repos/pkp/ojs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkp/ojs/downloads","issues_url":"https://api.github.com/repos/pkp/ojs/issues{/number}","pulls_url":"https://api.github.com/repos/pkp/ojs/pulls{/number}","milestones_url":"https://api.github.com/repos/pkp/ojs/milestones{/number}","notifications_url":"https://api.github.com/repos/pkp/ojs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkp/ojs/labels{/name}","releases_url":"https://api.github.com/repos/pkp/ojs/releases{/id}","created_at":"2009-11-16T21:19:14Z","updated_at":"2015-03-02T22:51:02Z","pushed_at":"2015-03-02T22:51:02Z","git_url":"git://github.com/pkp/ojs.git","ssh_url":"git@github.com:pkp/ojs.git","clone_url":"https://github.com/pkp/ojs.git","svn_url":"https://github.com/pkp/ojs","homepage":"http://pkp.sfu.ca/ojs","size":132284,"stargazers_count":184,"watchers_count":184,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":13,"forks":184,"open_issues":13,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pkp/ojs/pulls/438"},"html":{"href":"https://github.com/pkp/ojs/pull/438"},"issue":{"href":"https://api.github.com/repos/pkp/ojs/issues/438"},"comments":{"href":"https://api.github.com/repos/pkp/ojs/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/pkp/ojs/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/pkp/ojs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pkp/ojs/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/pkp/ojs/statuses/41950394b86532aa253744fe18d7d4d5191d6958"}}}}