{"action":"created","issue":{"url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/7","labels_url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/7/comments","events_url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/7/events","html_url":"https://github.com/rotundasoftware/cartero-node-hook/pull/7","id":116442222,"number":7,"title":"getAssetUrl fix and update to work with new assetMap","user":{"login":"dxuehu","id":485316,"avatar_url":"https://avatars.githubusercontent.com/u/485316?v=3","gravatar_id":"","url":"https://api.github.com/users/dxuehu","html_url":"https://github.com/dxuehu","followers_url":"https://api.github.com/users/dxuehu/followers","following_url":"https://api.github.com/users/dxuehu/following{/other_user}","gists_url":"https://api.github.com/users/dxuehu/gists{/gist_id}","starred_url":"https://api.github.com/users/dxuehu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxuehu/subscriptions","organizations_url":"https://api.github.com/users/dxuehu/orgs","repos_url":"https://api.github.com/users/dxuehu/repos","events_url":"https://api.github.com/users/dxuehu/events{/privacy}","received_events_url":"https://api.github.com/users/dxuehu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-11T23:15:05Z","updated_at":"2015-11-13T19:01:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/pulls/7","html_url":"https://github.com/rotundasoftware/cartero-node-hook/pull/7","diff_url":"https://github.com/rotundasoftware/cartero-node-hook/pull/7.diff","patch_url":"https://github.com/rotundasoftware/cartero-node-hook/pull/7.patch"},"body":"Update `getAssetUrl` to have more expected behavior and work with the new fingerprinted assets: the fn checks for the asset first in `assetMap`, then tries `getAssetsForEntryPoint` (thus checking for the asset in `entryPointMap`), then finally falls through to pathMapper. \r\n\r\nBecause it tries `getAssetsForEntryPoint` (which is async), this fn signature requires a cb so this is a breaking change.\r\n\r\nIt would be nice to discuss the pathMapper fall through. I added a commented out test that should work once that's figured out (this worked in previous versions because the images were not fingerprinted).\r\n\r\nparallel cartero PR:  https://github.com/rotundasoftware/cartero/pull/46\r\n\r\n@ferlores @dgbeck \r\n"},"comment":{"url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/comments/156525594","html_url":"https://github.com/rotundasoftware/cartero-node-hook/pull/7#issuecomment-156525594","issue_url":"https://api.github.com/repos/rotundasoftware/cartero-node-hook/issues/7","id":156525594,"user":{"login":"dxuehu","id":485316,"avatar_url":"https://avatars.githubusercontent.com/u/485316?v=3","gravatar_id":"","url":"https://api.github.com/users/dxuehu","html_url":"https://github.com/dxuehu","followers_url":"https://api.github.com/users/dxuehu/followers","following_url":"https://api.github.com/users/dxuehu/following{/other_user}","gists_url":"https://api.github.com/users/dxuehu/gists{/gist_id}","starred_url":"https://api.github.com/users/dxuehu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxuehu/subscriptions","organizations_url":"https://api.github.com/users/dxuehu/orgs","repos_url":"https://api.github.com/users/dxuehu/repos","events_url":"https://api.github.com/users/dxuehu/events{/privacy}","received_events_url":"https://api.github.com/users/dxuehu/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T19:01:37Z","updated_at":"2015-11-13T19:01:37Z","body":"@dgbeck fixed, thanks!"}}