{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/307","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/307/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/307/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/307/events","html_url":"https://github.com/weaveworks/weave/issues/307","id":53158643,"number":307,"title":"weave script is becoming unmaintainable and limiting","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/weaveworks/weave/labels/chore","name":"chore","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-12-31T00:21:51Z","updated_at":"2015-07-04T11:45:23Z","closed_at":null,"body":"The weave script is doing quite a lot of work and keeps growing. It's getting to the point where it becomes quite hard to maintain and extend. Also, `sh` is a rather limited environment for complex programming, and access to any kernel features is always mediated by tools, which introduces dependencies, versioning issues etc.\r\n\r\nOn a positive note, the script has served us well as being the single thing that needs to be downloaded and installed - no need for packaging an OS specifics. Also, it has proved very hackable - we've received quite a few PRs for the script; far more than the go code.\r\n\r\nReplacing the script with a statically linked exe would retain the \"single download, no fuss install\" of the current script."},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/118503297","html_url":"https://github.com/weaveworks/weave/issues/307#issuecomment-118503297","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/307","id":118503297,"user":{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},"created_at":"2015-07-04T11:45:23Z","updated_at":"2015-07-04T11:45:23Z","body":"It would be great if user could compile the executable with go get too. It\nwould be also quite usefull if it worked in a multi-step way, so user could\ncomment out bits of the script, if they know what they are doing and wish\nto skip some checks, e.g. the kernel version check. Alternativelly, there\ncould be control flags, but that seems like an overkill... Just a few\nthoughts.\n\nOn Wed, 1 Jul 2015 12:15 Matthias Radestock <notifications@github.com>\nwrote:\n\n> I like the \"gradually expanding exe\" approach. That will make it much\n> easier to tackle this issue, since we can make incremental progress.\n>\n> Plus, it addresses the duplication of functionality between the script,\n> proxy and plugin that is currently creeping in.\n>\n> Re the executable... we *could* make it a release artifact, so people\n> running weave --local have a convenient way of grabbing it.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/weaveworks/weave/issues/307#issuecomment-117613238>.\n>\n"}}