{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/47923328","id":47923328,"diff_hunk":"@@ -0,0 +1,43 @@\n+// +build !windows","path":"integration-cli/docker_api_set_unix_test.go","position":1,"original_position":1,"commit_id":"d16e3dfdd15acf3a0aac05b2db416f373c62a290","original_commit_id":"d16e3dfdd15acf3a0aac05b2db416f373c62a290","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"body":"Don't we want the windows CLI to test against a linux server?","created_at":"2015-12-17T16:06:39Z","updated_at":"2015-12-17T16:06:39Z","html_url":"https://github.com/docker/docker/pull/15078#discussion_r47923328","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/15078","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/47923328"},"html":{"href":"https://github.com/docker/docker/pull/15078#discussion_r47923328"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/15078"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/15078","id":40992947,"html_url":"https://github.com/docker/docker/pull/15078","diff_url":"https://github.com/docker/docker/pull/15078.diff","patch_url":"https://github.com/docker/docker/pull/15078.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/15078","number":15078,"state":"open","locked":false,"title":"Implement docker set command","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"body":"fixes #6323\r\n\r\nIt's used for change properties of one or more containers, we only\r\nsupport resource configs for now. It can be extended in the future.\r\n\r\nSigned-off-by: Qiang Huang <h.huangqiang@huawei.com>\r\n\r\n-------------------------\r\n\r\nThe original PR #11442, compared to the former one, changelog:\r\n - support set for both running and stopped containers\r\n - support more cgroup configs as the new ones were merged\r\n - move some container config change logic to container daemon/container_xxx.go\r\n - addressed all issues pointed by @duglin \r\n\r\nWe have strong needs for this feature for a long time, see #3285. It's really useful feature and necessary for most product usage.\r\n\r\n@icecrime @crosbymichael as we discussed on DockerCon, we should reconsider this feature, I have pinged you guys several times hope we can reopen the original one but got no reply, so I opened this new PR, hope it's ok. If the old one can be reopened, I'm ok to close this and continue the original discussion.","created_at":"2015-07-28T09:46:31Z","updated_at":"2015-12-17T16:06:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85076401a30d37eceaa21a7db8d81f92891f0035","assignee":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/15078/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/15078/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/15078/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/d16e3dfdd15acf3a0aac05b2db416f373c62a290","head":{"label":"hqhq:hq_add_set_api_v2","ref":"hq_add_set_api_v2","sha":"d16e3dfdd15acf3a0aac05b2db416f373c62a290","user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"repo":{"id":23826530,"name":"docker","full_name":"hqhq/docker","owner":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars.githubusercontent.com/u/6415670?v=3","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqhq/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/hqhq/docker","forks_url":"https://api.github.com/repos/hqhq/docker/forks","keys_url":"https://api.github.com/repos/hqhq/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqhq/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqhq/docker/teams","hooks_url":"https://api.github.com/repos/hqhq/docker/hooks","issue_events_url":"https://api.github.com/repos/hqhq/docker/issues/events{/number}","events_url":"https://api.github.com/repos/hqhq/docker/events","assignees_url":"https://api.github.com/repos/hqhq/docker/assignees{/user}","branches_url":"https://api.github.com/repos/hqhq/docker/branches{/branch}","tags_url":"https://api.github.com/repos/hqhq/docker/tags","blobs_url":"https://api.github.com/repos/hqhq/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqhq/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqhq/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqhq/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqhq/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/hqhq/docker/languages","stargazers_url":"https://api.github.com/repos/hqhq/docker/stargazers","contributors_url":"https://api.github.com/repos/hqhq/docker/contributors","subscribers_url":"https://api.github.com/repos/hqhq/docker/subscribers","subscription_url":"https://api.github.com/repos/hqhq/docker/subscription","commits_url":"https://api.github.com/repos/hqhq/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqhq/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqhq/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqhq/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqhq/docker/contents/{+path}","compare_url":"https://api.github.com/repos/hqhq/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqhq/docker/merges","archive_url":"https://api.github.com/repos/hqhq/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqhq/docker/downloads","issues_url":"https://api.github.com/repos/hqhq/docker/issues{/number}","pulls_url":"https://api.github.com/repos/hqhq/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/hqhq/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/hqhq/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqhq/docker/labels{/name}","releases_url":"https://api.github.com/repos/hqhq/docker/releases{/id}","created_at":"2014-09-09T09:03:12Z","updated_at":"2015-05-05T07:31:31Z","pushed_at":"2015-12-15T05:55:19Z","git_url":"git://github.com/hqhq/docker.git","ssh_url":"git@github.com:hqhq/docker.git","clone_url":"https://github.com/hqhq/docker.git","svn_url":"https://github.com/hqhq/docker","homepage":"http://www.docker.com","size":75449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"a398536d5e001efe06c329cdea3c33a075db8594","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-12-17T15:53:59Z","pushed_at":"2015-12-17T16:01:55Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":118772,"stargazers_count":27089,"watchers_count":27089,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7387,"mirror_url":null,"open_issues_count":1242,"forks":7387,"open_issues":1242,"watchers":27089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/15078"},"html":{"href":"https://github.com/docker/docker/pull/15078"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/15078"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/15078/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/15078/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/15078/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/d16e3dfdd15acf3a0aac05b2db416f373c62a290"}}}}