{"action":"created","issue":{"url":"https://api.github.com/repos/cloudmatrix/esky/issues/30","labels_url":"https://api.github.com/repos/cloudmatrix/esky/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/cloudmatrix/esky/issues/30/comments","events_url":"https://api.github.com/repos/cloudmatrix/esky/issues/30/events","html_url":"https://github.com/cloudmatrix/esky/pull/30","id":7962628,"number":30,"title":"Fix for issue #27","user":{"login":"orng","id":603622,"avatar_url":"https://avatars.githubusercontent.com/u/603622?v=3","gravatar_id":"","url":"https://api.github.com/users/orng","html_url":"https://github.com/orng","followers_url":"https://api.github.com/users/orng/followers","following_url":"https://api.github.com/users/orng/following{/other_user}","gists_url":"https://api.github.com/users/orng/gists{/gist_id}","starred_url":"https://api.github.com/users/orng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orng/subscriptions","organizations_url":"https://api.github.com/users/orng/orgs","repos_url":"https://api.github.com/users/orng/repos","events_url":"https://api.github.com/users/orng/events{/privacy}","received_events_url":"https://api.github.com/users/orng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2012-10-30T09:31:41Z","updated_at":"2015-11-24T09:25:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudmatrix/esky/pulls/30","html_url":"https://github.com/cloudmatrix/esky/pull/30","diff_url":"https://github.com/cloudmatrix/esky/pull/30.diff","patch_url":"https://github.com/cloudmatrix/esky/pull/30.patch"},"body":"This is a proposed fix for the issue described in:\r\nhttps://github.com/cloudmatrix/esky/issues/27\r\n\r\nInstead of going though the entire folder and hash that, we now include,\r\nupon freezing, a \"manifest\"-file called esky_filelist in the esky-files\r\nfolder that contains a list of all the files of the frozen project.\r\nWhen creating a patch, we calculate the md5 checksum of all the files\r\nlisted in esky_filelist, and upon applying the patch we do the same\r\nthing and compare the values, thus ensuring the integrity of the files\r\nbut ignoring any extra files in the folder.\r\n\r\nBy including the filelist with the original frozen application we don't\r\nhave to include it in the patches themselves and thus get smaller\r\npatches. We can even apply patches to the filelist!\r\n\r\nI have only tested this on Windows, but I see no reason why it shouldn't work on mac or linux.\r\nI didn't have time to add parameters for making the checksum check  optional but it should be pretty straightforward to add if it's something we really want."},"comment":{"url":"https://api.github.com/repos/cloudmatrix/esky/issues/comments/159205873","html_url":"https://github.com/cloudmatrix/esky/pull/30#issuecomment-159205873","issue_url":"https://api.github.com/repos/cloudmatrix/esky/issues/30","id":159205873,"user":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T09:25:00Z","updated_at":"2015-11-24T09:25:00Z","body":"OK, sounds good, thanks for diving into this!\r\n\r\n> I'm up for implementing removal of pyc and pyo files by default\r\n\r\nSounds fine to me.  FWIW I don't think people should be writing files into the app dir, but I guess there's no harm in supporting them if they choose to do so."}}