{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments/47655548","id":47655548,"diff_hunk":"@@ -42,10 +42,10 @@\n #ifndef MEM_POOL_INTERNAL_H__\r\n #define MEM_POOL_INTERNAL_H__\r\n \r\n-#define TX_BUF_SIZE       4u    /**< TX buffer size in bytes. */\n-#define RX_BUF_SIZE       32u   /**< RX buffer size in bytes. */\n+#define TX_BUF_SIZE       32u    /**< TX buffer size in bytes. */\r","path":"source/nordic_sdk/components/libraries/bootloader_dfu/hci_transport/hci_mem_pool_internal.h","position":null,"original_position":6,"commit_id":"7f488715edac24556101e3488e2ff7930153821d","original_commit_id":"9da4af9c11bd2138b9566f61d6c30ace2302e155","user":{"login":"rgrover","id":112704,"avatar_url":"https://avatars.githubusercontent.com/u/112704?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrover","html_url":"https://github.com/rgrover","followers_url":"https://api.github.com/users/rgrover/followers","following_url":"https://api.github.com/users/rgrover/following{/other_user}","gists_url":"https://api.github.com/users/rgrover/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrover/subscriptions","organizations_url":"https://api.github.com/users/rgrover/orgs","repos_url":"https://api.github.com/users/rgrover/repos","events_url":"https://api.github.com/users/rgrover/events{/privacy}","received_events_url":"https://api.github.com/users/rgrover/received_events","type":"User","site_admin":false},"body":"Perhaps these values have been used in the bootloader sources.\r\n\r\nFrom: LIYOU ZHOU [mailto:notifications@github.com]\r\nSent: 15 December 2015 14:51\r\nTo: ARMmbed/nrf51-sdk\r\nCc: Rohit Grover\r\nSubject: Re: [nrf51-sdk] Update files to Nordic sdk 9.0.0 (#8)\r\n\r\n\r\nIn source/nordic_sdk/components/libraries/bootloader_dfu/hci_transport/hci_mem_pool_internal.h<https://github.com/ARMmbed/nrf51-sdk/pull/8#discussion_r47644751>:\r\n\r\n> @@ -42,10 +42,10 @@\r\n\r\n>  #ifndef MEM_POOL_INTERNAL_H__\r\n\r\n>  #define MEM_POOL_INTERNAL_H__\r\n\r\n>\r\n\r\n> -#define TX_BUF_SIZE       4u    /**< TX buffer size in bytes. */\r\n\r\n> -#define RX_BUF_SIZE       32u   /**< RX buffer size in bytes. */\r\n\r\n> +#define TX_BUF_SIZE       32u    /**< TX buffer size in bytes. */\r\n\r\n@rgrover<https://github.com/rgrover> I can't find how these values are being use. hci_mem_pool_internal.h is being included in components/libraries/hci/hci_mem_pool.c. But I cannot find where components/libraries/hci/hci_mem_pool.h is being used. Can you remember how it was used?\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/ARMmbed/nrf51-sdk/pull/8/files#r47644751>.\r\n\r\nIMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.\r\n","created_at":"2015-12-15T15:59:27Z","updated_at":"2015-12-15T15:59:27Z","html_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8#discussion_r47655548","pull_request_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments/47655548"},"html":{"href":"https://github.com/ARMmbed/nrf51-sdk/pull/8#discussion_r47655548"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8","id":53426164,"html_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8","diff_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8.diff","patch_url":"https://github.com/ARMmbed/nrf51-sdk/pull/8.patch","issue_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8","number":8,"state":"open","locked":false,"title":"Update files to Nordic sdk 9.0.0","user":{"login":"LiyouZhou","id":2660805,"avatar_url":"https://avatars.githubusercontent.com/u/2660805?v=3","gravatar_id":"","url":"https://api.github.com/users/LiyouZhou","html_url":"https://github.com/LiyouZhou","followers_url":"https://api.github.com/users/LiyouZhou/followers","following_url":"https://api.github.com/users/LiyouZhou/following{/other_user}","gists_url":"https://api.github.com/users/LiyouZhou/gists{/gist_id}","starred_url":"https://api.github.com/users/LiyouZhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiyouZhou/subscriptions","organizations_url":"https://api.github.com/users/LiyouZhou/orgs","repos_url":"https://api.github.com/users/LiyouZhou/repos","events_url":"https://api.github.com/users/LiyouZhou/events{/privacy}","received_events_url":"https://api.github.com/users/LiyouZhou/received_events","type":"User","site_admin":false},"body":"Tests:\r\n\r\nclitest - all expected passes pass, all expected fails fail.\r\nbuild - all ble-examples build successfully\r\npstorage - tested against https://github.com/andresag01/ble-examples-1/tree/eddystone_pstorage and works\r\ndfu - tested to work\r\n\r\n### Highlight from sdk 9 release notes:\r\n#### Changes\r\n- Flash access module has been refactored (pstorage).\r\n\r\n#### Fixed issues:\r\n- Pstorage now supports updates of bond split across two pages.\r\n- Advertising module can be set to infinite time-out.\r\n- Serialization HCI transport layer: Receiving packet-buffer is not\r\n freed while sending ACK or NACK.\r\n\r\n#### Known issues:\r\n- Device Manager is not supported in multi-role S130 operation.\r\n  - Device Manager works in peripheral or central only operation on\r\n    S130. This must be decided at compile time.\r\n- The DFU over BLE example has been tested to work with a minimum\r\n  connection interval of 11.25 ms. The application cannot handle\r\n  connection intervals lower than 11.25 ms and may undergo a system\r\n  reset in the middle of a firmware update.\r\n     Workaround: If you face unexpected disconnects during the firmware\r\n     update process, consider increasing the connection interval used\r\n     by the master.\r\n- App_pwm occasionally gives inverted signal.\r\n- The old manual procedure for testing buttonless DFU, as specified in\r\n  the documentation, can lead to the DFU process hanging or returning\r\n  an error when used with Master Control Panel 3.8 and newer.\r\n\r\n@ARMmbed/ble-owners  Please review.","created_at":"2015-12-11T18:21:20Z","updated_at":"2015-12-15T15:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0ace53bd203de195d920515dfa0b0f25a04aabf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8/comments","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/7f488715edac24556101e3488e2ff7930153821d","head":{"label":"ARMmbed:nordic_sdk_9.0.0","ref":"nordic_sdk_9.0.0","sha":"7f488715edac24556101e3488e2ff7930153821d","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":45975419,"name":"nrf51-sdk","full_name":"ARMmbed/nrf51-sdk","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nrf51-sdk","description":"Module to contain files provided by the nordic nRF51 SDK","fork":false,"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk","forks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/forks","keys_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/events","assignees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/merges","archive_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/releases{/id}","created_at":"2015-11-11T10:36:01Z","updated_at":"2015-11-23T21:15:13Z","pushed_at":"2015-12-15T10:42:46Z","git_url":"git://github.com/ARMmbed/nrf51-sdk.git","ssh_url":"git@github.com:ARMmbed/nrf51-sdk.git","clone_url":"https://github.com/ARMmbed/nrf51-sdk.git","svn_url":"https://github.com/ARMmbed/nrf51-sdk","homepage":null,"size":784,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"21d0f023a2b072cdbc138deb3b4d25ae1a54e145","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":45975419,"name":"nrf51-sdk","full_name":"ARMmbed/nrf51-sdk","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/nrf51-sdk","description":"Module to contain files provided by the nordic nRF51 SDK","fork":false,"url":"https://api.github.com/repos/ARMmbed/nrf51-sdk","forks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/forks","keys_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/teams","hooks_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/events","assignees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/tags","blobs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/subscription","commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/merges","archive_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/downloads","issues_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/nrf51-sdk/releases{/id}","created_at":"2015-11-11T10:36:01Z","updated_at":"2015-11-23T21:15:13Z","pushed_at":"2015-12-15T10:42:46Z","git_url":"git://github.com/ARMmbed/nrf51-sdk.git","ssh_url":"git@github.com:ARMmbed/nrf51-sdk.git","clone_url":"https://github.com/ARMmbed/nrf51-sdk.git","svn_url":"https://github.com/ARMmbed/nrf51-sdk","homepage":null,"size":784,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8"},"html":{"href":"https://github.com/ARMmbed/nrf51-sdk/pull/8"},"issue":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8"},"comments":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/nrf51-sdk/statuses/7f488715edac24556101e3488e2ff7930153821d"}}}}