{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33089955","id":33089955,"diff_hunk":"@@ -19,6 +19,12 @@\n   <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Linux_Release|AnyCPU' \" />\n   <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'OSX_Debug|AnyCPU' \" />\n   <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'OSX_Release|AnyCPU' \" />\n+  <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'FreeBSD_Debug|AnyCPU' \"/>\n+  <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'FreeBSD_Release|AnyCPU' \"/>\n+  <PropertyGroup>\n+    <TargetsBSD Condition=\"'$(TargetsOSX)' == 'true' or '$(TargetsFreeBSD)' == 'true'\">true</TargetsBSD>\n+  </PropertyGroup>","path":"src/System.IO.FileSystem.DriveInfo/src/System.IO.FileSystem.DriveInfo.csproj","position":8,"original_position":8,"commit_id":"954aabd17fd3e0f81a6cf9a2313301b4cbeea887","original_commit_id":"954aabd17fd3e0f81a6cf9a2313301b4cbeea887","user":{"login":"janhenke","id":592974,"avatar_url":"https://avatars.githubusercontent.com/u/592974?v=3","gravatar_id":"","url":"https://api.github.com/users/janhenke","html_url":"https://github.com/janhenke","followers_url":"https://api.github.com/users/janhenke/followers","following_url":"https://api.github.com/users/janhenke/following{/other_user}","gists_url":"https://api.github.com/users/janhenke/gists{/gist_id}","starred_url":"https://api.github.com/users/janhenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janhenke/subscriptions","organizations_url":"https://api.github.com/users/janhenke/orgs","repos_url":"https://api.github.com/users/janhenke/repos","events_url":"https://api.github.com/users/janhenke/events{/privacy}","received_events_url":"https://api.github.com/users/janhenke/received_events","type":"User","site_admin":false},"body":"We should not introduce a \"is BSD\" here. We already have the \"is Unix\". Also OS X is not a BSD system, even if inherited some parts from it.\r\n\r\nPlease remove the \"is BSD\" part.","created_at":"2015-06-23T20:45:00Z","updated_at":"2015-06-23T20:45:00Z","html_url":"https://github.com/dotnet/corefx/pull/2136#discussion_r33089955","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2136","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33089955"},"html":{"href":"https://github.com/dotnet/corefx/pull/2136#discussion_r33089955"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2136"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2136","id":38371437,"html_url":"https://github.com/dotnet/corefx/pull/2136","diff_url":"https://github.com/dotnet/corefx/pull/2136.diff","patch_url":"https://github.com/dotnet/corefx/pull/2136.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2136","number":2136,"state":"open","locked":false,"title":"Refactoring DriveInfo on OS X, Linux, and FreeBSD","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Refactoring DriveInfo to work on Linux, OS X, and FreeBSD \r\n\r\n@stephentoub @ellismg @josteink @ghuntley\r\n\r\nThis moves DriveInfo into 3 distinct areas -\r\n1) DriveInfo.cs which is OS agnostic\r\n2) DriveInfo.Unix.cs which is common to all OSes where we can use statfs to get info about a specific mount point\r\n3) DriveInfo.<OS>.cs which is specific to each OS, which is where we need to enumerate all mount points, which does not have a common PInvoke for platforms\r\n\r\nAlso fixing readdir to use the same pattern as DriveInfo","created_at":"2015-06-23T19:06:19Z","updated_at":"2015-06-23T20:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1df3545f5d82f1b5c9a9c9c41baad7dcf8c09b05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2136/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2136/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2136/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/954aabd17fd3e0f81a6cf9a2313301b4cbeea887","head":{"label":"sokket:driveinfo","ref":"driveinfo","sha":"954aabd17fd3e0f81a6cf9a2313301b4cbeea887","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","created_at":"2015-03-10T18:45:28Z","updated_at":"2015-05-06T18:55:19Z","pushed_at":"2015-06-23T19:02:01Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":20382,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d4211961ff638d82b849398b4df053006b50e0d5","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-06-23T15:13:18Z","pushed_at":"2015-06-23T20:38:40Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":49135,"stargazers_count":7953,"watchers_count":7953,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1625,"mirror_url":null,"open_issues_count":435,"forks":1625,"open_issues":435,"watchers":7953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2136"},"html":{"href":"https://github.com/dotnet/corefx/pull/2136"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2136"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2136/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2136/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2136/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/954aabd17fd3e0f81a6cf9a2313301b4cbeea887"}}}}