{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/646","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/646/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/646/events","html_url":"https://github.com/facebook/rocksdb/pull/646","id":92506803,"number":646,"title":"Windows Port from Microsoft","user":{"login":"yuslepukhin","id":11303988,"avatar_url":"https://avatars.githubusercontent.com/u/11303988?v=3","gravatar_id":"","url":"https://api.github.com/users/yuslepukhin","html_url":"https://github.com/yuslepukhin","followers_url":"https://api.github.com/users/yuslepukhin/followers","following_url":"https://api.github.com/users/yuslepukhin/following{/other_user}","gists_url":"https://api.github.com/users/yuslepukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/yuslepukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuslepukhin/subscriptions","organizations_url":"https://api.github.com/users/yuslepukhin/orgs","repos_url":"https://api.github.com/users/yuslepukhin/repos","events_url":"https://api.github.com/users/yuslepukhin/events{/privacy}","received_events_url":"https://api.github.com/users/yuslepukhin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-07-01T23:29:30Z","updated_at":"2015-07-07T21:41:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/646","html_url":"https://github.com/facebook/rocksdb/pull/646","diff_url":"https://github.com/facebook/rocksdb/pull/646.diff","patch_url":"https://github.com/facebook/rocksdb/pull/646.patch"},"body":" Summary: Make RocksDb build and run on Windows to be functionally\r\n complete and performant. All existing test cases run with no\r\n regressions. Performance numbers are in the pull-request.\r\n\r\n Test plan: make all of the existing unit tests pass, obtain perf numbers.\r\n\r\n Co-authored-by: Praveen Rao praveensinghrao@outlook.com\r\n Co-authored-by: Sherlock Huang baihan.huang@gmail.com\r\n Co-authored-by: Alex Zinoviev alexander.zinoviev@me.com\r\n Co-authored-by: Dmitri Smirnov dmitrism@microsoft.com"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/119351112","html_url":"https://github.com/facebook/rocksdb/pull/646#issuecomment-119351112","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/646","id":119351112,"user":{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T21:41:53Z","updated_at":"2015-07-07T21:41:53Z","body":"env_win.cc, line 972 \"assert(!options.use_mmap_reads);\" fails on my 32-bit laptop, because mmap is chosen to be not executed:\r\nif (options.use_mmap_reads && sizeof(void*) >= 8) {\r\n}\r\nNeed to fix this assert."}}