{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1","id":37791035,"html_url":"https://github.com/SQiShER/health-exporter/pull/1","diff_url":"https://github.com/SQiShER/health-exporter/pull/1.diff","patch_url":"https://github.com/SQiShER/health-exporter/pull/1.patch","issue_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/1","number":1,"state":"closed","locked":false,"title":"Connection Timeout for Health Check Requests","user":{"login":"SQiShER","id":369730,"avatar_url":"https://avatars.githubusercontent.com/u/369730?v=3","gravatar_id":"","url":"https://api.github.com/users/SQiShER","html_url":"https://github.com/SQiShER","followers_url":"https://api.github.com/users/SQiShER/followers","following_url":"https://api.github.com/users/SQiShER/following{/other_user}","gists_url":"https://api.github.com/users/SQiShER/gists{/gist_id}","starred_url":"https://api.github.com/users/SQiShER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SQiShER/subscriptions","organizations_url":"https://api.github.com/users/SQiShER/orgs","repos_url":"https://api.github.com/users/SQiShER/repos","events_url":"https://api.github.com/users/SQiShER/events{/privacy}","received_events_url":"https://api.github.com/users/SQiShER/received_events","type":"User","site_admin":false},"body":"Under certain conditions it is possible for health check requests to never return. This commit adds a connection timeout to the http client in order to prevent this from bringing down the entire health exporter. The problem can be easily reproduced by adding a non-routable IP (like 10.255.255.1) as health check target to the configuration.","created_at":"2015-06-16T12:50:32Z","updated_at":"2015-06-16T12:54:55Z","closed_at":"2015-06-16T12:54:55Z","merged_at":null,"merge_commit_sha":"2ee61840b58fcb2edbd10db06298f56f803c310e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SQiShER/health-exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/1/comments","statuses_url":"https://api.github.com/repos/SQiShER/health-exporter/statuses/bf44fac0be1f056afa75eb79025002c98576ad1d","head":{"label":"SQiShER:SQiShER-patch-2","ref":"SQiShER-patch-2","sha":"bf44fac0be1f056afa75eb79025002c98576ad1d","user":{"login":"SQiShER","id":369730,"avatar_url":"https://avatars.githubusercontent.com/u/369730?v=3","gravatar_id":"","url":"https://api.github.com/users/SQiShER","html_url":"https://github.com/SQiShER","followers_url":"https://api.github.com/users/SQiShER/followers","following_url":"https://api.github.com/users/SQiShER/following{/other_user}","gists_url":"https://api.github.com/users/SQiShER/gists{/gist_id}","starred_url":"https://api.github.com/users/SQiShER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SQiShER/subscriptions","organizations_url":"https://api.github.com/users/SQiShER/orgs","repos_url":"https://api.github.com/users/SQiShER/repos","events_url":"https://api.github.com/users/SQiShER/events{/privacy}","received_events_url":"https://api.github.com/users/SQiShER/received_events","type":"User","site_admin":false},"repo":{"id":37517950,"name":"health-exporter","full_name":"SQiShER/health-exporter","owner":{"login":"SQiShER","id":369730,"avatar_url":"https://avatars.githubusercontent.com/u/369730?v=3","gravatar_id":"","url":"https://api.github.com/users/SQiShER","html_url":"https://github.com/SQiShER","followers_url":"https://api.github.com/users/SQiShER/followers","following_url":"https://api.github.com/users/SQiShER/following{/other_user}","gists_url":"https://api.github.com/users/SQiShER/gists{/gist_id}","starred_url":"https://api.github.com/users/SQiShER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SQiShER/subscriptions","organizations_url":"https://api.github.com/users/SQiShER/orgs","repos_url":"https://api.github.com/users/SQiShER/repos","events_url":"https://api.github.com/users/SQiShER/events{/privacy}","received_events_url":"https://api.github.com/users/SQiShER/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SQiShER/health-exporter","description":"Health Exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/SQiShER/health-exporter","forks_url":"https://api.github.com/repos/SQiShER/health-exporter/forks","keys_url":"https://api.github.com/repos/SQiShER/health-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SQiShER/health-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SQiShER/health-exporter/teams","hooks_url":"https://api.github.com/repos/SQiShER/health-exporter/hooks","issue_events_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/SQiShER/health-exporter/events","assignees_url":"https://api.github.com/repos/SQiShER/health-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/SQiShER/health-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/SQiShER/health-exporter/tags","blobs_url":"https://api.github.com/repos/SQiShER/health-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SQiShER/health-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SQiShER/health-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/SQiShER/health-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SQiShER/health-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/SQiShER/health-exporter/languages","stargazers_url":"https://api.github.com/repos/SQiShER/health-exporter/stargazers","contributors_url":"https://api.github.com/repos/SQiShER/health-exporter/contributors","subscribers_url":"https://api.github.com/repos/SQiShER/health-exporter/subscribers","subscription_url":"https://api.github.com/repos/SQiShER/health-exporter/subscription","commits_url":"https://api.github.com/repos/SQiShER/health-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/SQiShER/health-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/SQiShER/health-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/SQiShER/health-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/SQiShER/health-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SQiShER/health-exporter/merges","archive_url":"https://api.github.com/repos/SQiShER/health-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SQiShER/health-exporter/downloads","issues_url":"https://api.github.com/repos/SQiShER/health-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/SQiShER/health-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/SQiShER/health-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/SQiShER/health-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SQiShER/health-exporter/labels{/name}","releases_url":"https://api.github.com/repos/SQiShER/health-exporter/releases{/id}","created_at":"2015-06-16T08:31:33Z","updated_at":"2015-06-16T08:31:34Z","pushed_at":"2015-06-16T12:53:13Z","git_url":"git://github.com/SQiShER/health-exporter.git","ssh_url":"git@github.com:SQiShER/health-exporter.git","clone_url":"https://github.com/SQiShER/health-exporter.git","svn_url":"https://github.com/SQiShER/health-exporter","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SQiShER:master","ref":"master","sha":"d66bffe59becdd83ef0747013d10c2ecc920b83c","user":{"login":"SQiShER","id":369730,"avatar_url":"https://avatars.githubusercontent.com/u/369730?v=3","gravatar_id":"","url":"https://api.github.com/users/SQiShER","html_url":"https://github.com/SQiShER","followers_url":"https://api.github.com/users/SQiShER/followers","following_url":"https://api.github.com/users/SQiShER/following{/other_user}","gists_url":"https://api.github.com/users/SQiShER/gists{/gist_id}","starred_url":"https://api.github.com/users/SQiShER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SQiShER/subscriptions","organizations_url":"https://api.github.com/users/SQiShER/orgs","repos_url":"https://api.github.com/users/SQiShER/repos","events_url":"https://api.github.com/users/SQiShER/events{/privacy}","received_events_url":"https://api.github.com/users/SQiShER/received_events","type":"User","site_admin":false},"repo":{"id":37517950,"name":"health-exporter","full_name":"SQiShER/health-exporter","owner":{"login":"SQiShER","id":369730,"avatar_url":"https://avatars.githubusercontent.com/u/369730?v=3","gravatar_id":"","url":"https://api.github.com/users/SQiShER","html_url":"https://github.com/SQiShER","followers_url":"https://api.github.com/users/SQiShER/followers","following_url":"https://api.github.com/users/SQiShER/following{/other_user}","gists_url":"https://api.github.com/users/SQiShER/gists{/gist_id}","starred_url":"https://api.github.com/users/SQiShER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SQiShER/subscriptions","organizations_url":"https://api.github.com/users/SQiShER/orgs","repos_url":"https://api.github.com/users/SQiShER/repos","events_url":"https://api.github.com/users/SQiShER/events{/privacy}","received_events_url":"https://api.github.com/users/SQiShER/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SQiShER/health-exporter","description":"Health Exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/SQiShER/health-exporter","forks_url":"https://api.github.com/repos/SQiShER/health-exporter/forks","keys_url":"https://api.github.com/repos/SQiShER/health-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SQiShER/health-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SQiShER/health-exporter/teams","hooks_url":"https://api.github.com/repos/SQiShER/health-exporter/hooks","issue_events_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/SQiShER/health-exporter/events","assignees_url":"https://api.github.com/repos/SQiShER/health-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/SQiShER/health-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/SQiShER/health-exporter/tags","blobs_url":"https://api.github.com/repos/SQiShER/health-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SQiShER/health-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SQiShER/health-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/SQiShER/health-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SQiShER/health-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/SQiShER/health-exporter/languages","stargazers_url":"https://api.github.com/repos/SQiShER/health-exporter/stargazers","contributors_url":"https://api.github.com/repos/SQiShER/health-exporter/contributors","subscribers_url":"https://api.github.com/repos/SQiShER/health-exporter/subscribers","subscription_url":"https://api.github.com/repos/SQiShER/health-exporter/subscription","commits_url":"https://api.github.com/repos/SQiShER/health-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/SQiShER/health-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/SQiShER/health-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/SQiShER/health-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/SQiShER/health-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/SQiShER/health-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SQiShER/health-exporter/merges","archive_url":"https://api.github.com/repos/SQiShER/health-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SQiShER/health-exporter/downloads","issues_url":"https://api.github.com/repos/SQiShER/health-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/SQiShER/health-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/SQiShER/health-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/SQiShER/health-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SQiShER/health-exporter/labels{/name}","releases_url":"https://api.github.com/repos/SQiShER/health-exporter/releases{/id}","created_at":"2015-06-16T08:31:33Z","updated_at":"2015-06-16T08:31:34Z","pushed_at":"2015-06-16T12:53:13Z","git_url":"git://github.com/SQiShER/health-exporter.git","ssh_url":"git@github.com:SQiShER/health-exporter.git","clone_url":"https://github.com/SQiShER/health-exporter.git","svn_url":"https://github.com/SQiShER/health-exporter","homepage":"","size":159,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1"},"html":{"href":"https://github.com/SQiShER/health-exporter/pull/1"},"issue":{"href":"https://api.github.com/repos/SQiShER/health-exporter/issues/1"},"comments":{"href":"https://api.github.com/repos/SQiShER/health-exporter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SQiShER/health-exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SQiShER/health-exporter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SQiShER/health-exporter/statuses/bf44fac0be1f056afa75eb79025002c98576ad1d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}