{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/36085590","id":36085590,"diff_hunk":"@@ -125,3 +125,41 @@ func (s *REST) findStreamForMapping(ctx kapi.Context, mapping *api.ImageStreamMa\n \t}\n \treturn nil, errors.NewNotFound(\"ImageStream\", \"\")\n }\n+\n+// Delete deletes the given image and the image stream tag associated with it\n+func (s *REST) Delete(ctx kapi.Context, id string) (runtime.Object, error) {\n+\tstreamName, tag, _ := api.SplitImageStreamTag(id)\n+\n+\t// Get image stream\n+\tstream, err := s.imageStreamRegistry.GetImageStream(ctx, streamName)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\t// Find associated image name via image stream tags\n+\tvar image string\n+\tif stream.Status.Tags != nil {\n+\t\teventList, ok := stream.Status.Tags[tag]\n+\t\tif !ok {\n+\t\t\treturn &kapi.Status{Status: kapi.StatusSuccess}, nil\n+\t\t}\n+\t\t// Check if list is empty? Sort based on timestamp?\n+\t\timage = eventList.Items[0].Image\n+\t}\n+\tif len(image) == 0 {\n+\t\treturn &kapi.Status{Status: kapi.StatusSuccess}, nil\n+\t}\n+\n+\t// Delete image\n+\tif err := s.imageRegistry.DeleteImage(ctx, image); err != nil {","path":"pkg/image/registry/imagestreammapping/rest.go","position":30,"original_position":30,"commit_id":"c6098bdd2af7df2010b24f232baaf76dcb52618b","original_commit_id":"c6098bdd2af7df2010b24f232baaf76dcb52618b","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Do not delete the image. Only delete the tag. `oadm prune images` will delete the image, if appropriate.","created_at":"2015-08-03T13:41:49Z","updated_at":"2015-08-03T13:41:49Z","html_url":"https://github.com/openshift/origin/pull/3982#discussion_r36085590","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/3982","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/36085590"},"html":{"href":"https://github.com/openshift/origin/pull/3982#discussion_r36085590"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/3982"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3982","id":41448421,"html_url":"https://github.com/openshift/origin/pull/3982","diff_url":"https://github.com/openshift/origin/pull/3982.diff","patch_url":"https://github.com/openshift/origin/pull/3982.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/3982","number":3982,"state":"open","locked":false,"title":"Support deleting image stream tags via imageStreamMappings","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"@ncdc PTAL\r\n\r\nFixes #3485","created_at":"2015-08-03T09:21:17Z","updated_at":"2015-08-03T13:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"842139dba81f3209f554638a22295b007ccd66af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/3982/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/3982/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3982/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/c6098bdd2af7df2010b24f232baaf76dcb52618b","head":{"label":"kargakis:delete-image-stream-tags","ref":"delete-image-stream-tags","sha":"c6098bdd2af7df2010b24f232baaf76dcb52618b","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":29889288,"name":"origin","full_name":"kargakis/origin","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/kargakis/origin","forks_url":"https://api.github.com/repos/kargakis/origin/forks","keys_url":"https://api.github.com/repos/kargakis/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/origin/teams","hooks_url":"https://api.github.com/repos/kargakis/origin/hooks","issue_events_url":"https://api.github.com/repos/kargakis/origin/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/origin/events","assignees_url":"https://api.github.com/repos/kargakis/origin/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/origin/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/origin/tags","blobs_url":"https://api.github.com/repos/kargakis/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/origin/languages","stargazers_url":"https://api.github.com/repos/kargakis/origin/stargazers","contributors_url":"https://api.github.com/repos/kargakis/origin/contributors","subscribers_url":"https://api.github.com/repos/kargakis/origin/subscribers","subscription_url":"https://api.github.com/repos/kargakis/origin/subscription","commits_url":"https://api.github.com/repos/kargakis/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/origin/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/origin/merges","archive_url":"https://api.github.com/repos/kargakis/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/origin/downloads","issues_url":"https://api.github.com/repos/kargakis/origin/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/origin/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/origin/releases{/id}","created_at":"2015-01-27T00:24:14Z","updated_at":"2015-05-07T09:50:35Z","pushed_at":"2015-08-03T12:00:36Z","git_url":"git://github.com/kargakis/origin.git","ssh_url":"git@github.com:kargakis/origin.git","clone_url":"https://github.com/kargakis/origin.git","svn_url":"https://github.com/kargakis/origin","homepage":"https://openshift.github.io","size":124181,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4bc1af7d29eb1321fcb7fe25911c7935a5f526b4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-08-03T05:59:28Z","pushed_at":"2015-08-03T13:33:37Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":194184,"stargazers_count":593,"watchers_count":593,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":460,"forks":334,"open_issues":460,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/3982"},"html":{"href":"https://github.com/openshift/origin/pull/3982"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/3982"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/3982/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/3982/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/3982/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/c6098bdd2af7df2010b24f232baaf76dcb52618b"}}}}