{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/pfff/issues/134","labels_url":"https://api.github.com/repos/facebook/pfff/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/facebook/pfff/issues/134/comments","events_url":"https://api.github.com/repos/facebook/pfff/issues/134/events","html_url":"https://github.com/facebook/pfff/pull/134","id":115078051,"number":134,"title":"Remove GNU make version check","user":{"login":"mmcco","id":1668979,"avatar_url":"https://avatars.githubusercontent.com/u/1668979?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcco","html_url":"https://github.com/mmcco","followers_url":"https://api.github.com/users/mmcco/followers","following_url":"https://api.github.com/users/mmcco/following{/other_user}","gists_url":"https://api.github.com/users/mmcco/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcco/subscriptions","organizations_url":"https://api.github.com/users/mmcco/orgs","repos_url":"https://api.github.com/users/mmcco/repos","events_url":"https://api.github.com/users/mmcco/events{/privacy}","received_events_url":"https://api.github.com/users/mmcco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-04T15:27:31Z","updated_at":"2015-11-04T15:32:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/pfff/pulls/134","html_url":"https://github.com/facebook/pfff/pull/134","diff_url":"https://github.com/facebook/pfff/pull/134.diff","patch_url":"https://github.com/facebook/pfff/pull/134.patch"},"body":"Build systems very often (usually?) don't check the make version.\r\n\r\nRegardless, the existing check is really brittle. For example, only GNU\r\ngrep has the --colour flag, and it's available on the BSDs only as\r\nggrep. Even when fixing this, the make version check doesn't work for me\r\non OpenBSD. It's probably easiest just to remove it.\r\n\r\nThis patch fixes configuration on OpenBSD for me.\r\n\r\nAlso corrects a typo."},"comment":{"url":"https://api.github.com/repos/facebook/pfff/issues/comments/153764138","html_url":"https://github.com/facebook/pfff/pull/134#issuecomment-153764138","issue_url":"https://api.github.com/repos/facebook/pfff/issues/134","id":153764138,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T15:32:24Z","updated_at":"2015-11-04T15:32:24Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!"}}