{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/tools/pulls/comments/42046568","id":42046568,"diff_hunk":"@@ -18,6 +24,24 @@ const List<String> _kDensities = const ['drawable-xxhdpi'];\n const List<String> _kThemes = const ['white', 'black'];\n const List<int> _kSizes = const [24];\n \n+// The ECDSA algorithm parameters we're using. These match the parameters used\n+// by the Flutter updater package.\n+final ECDomainParameters _ecDomain = new ECDomainParameters('prime256v1');\n+final String kSignerAlgorithm = 'SHA-256/ECDSA';\n+final String kHashAlgorithm = 'SHA-256';","path":"lib/src/build.dart","position":25,"original_position":25,"commit_id":"5357c24802e572795ed0619d36b52ee3ed0625b9","original_commit_id":"5357c24802e572795ed0619d36b52ee3ed0625b9","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Can you factor this new code into a separate file that's used by the BuildCommand?","created_at":"2015-10-14T20:15:10Z","updated_at":"2015-10-14T20:15:10Z","html_url":"https://github.com/flutter/tools/pull/99#discussion_r42046568","pull_request_url":"https://api.github.com/repos/flutter/tools/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/flutter/tools/pulls/comments/42046568"},"html":{"href":"https://github.com/flutter/tools/pull/99#discussion_r42046568"},"pull_request":{"href":"https://api.github.com/repos/flutter/tools/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/tools/pulls/99","id":47699711,"html_url":"https://github.com/flutter/tools/pull/99","diff_url":"https://github.com/flutter/tools/pull/99.diff","patch_url":"https://github.com/flutter/tools/pull/99.patch","issue_url":"https://api.github.com/repos/flutter/tools/issues/99","number":99,"state":"open","locked":false,"title":"Add support for signing flx packages with ECDSA key pair","user":{"login":"mpcomplete","id":1071986,"avatar_url":"https://avatars.githubusercontent.com/u/1071986?v=3","gravatar_id":"","url":"https://api.github.com/users/mpcomplete","html_url":"https://github.com/mpcomplete","followers_url":"https://api.github.com/users/mpcomplete/followers","following_url":"https://api.github.com/users/mpcomplete/following{/other_user}","gists_url":"https://api.github.com/users/mpcomplete/gists{/gist_id}","starred_url":"https://api.github.com/users/mpcomplete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpcomplete/subscriptions","organizations_url":"https://api.github.com/users/mpcomplete/orgs","repos_url":"https://api.github.com/users/mpcomplete/repos","events_url":"https://api.github.com/users/mpcomplete/events{/privacy}","received_events_url":"https://api.github.com/users/mpcomplete/received_events","type":"User","site_admin":false},"body":"Adds a --private-key option to the build command, which specifies an ECDSA private key. When this is provided along with a manifest, the manifest is prepended to the .flx package and signed with the private key. The manifest also includes a SHA-256 hash of the zipped content portion of the .flx package.\r\n\r\nThis is used by the Flutter updater package, to verify that updates are from the right publisher.","created_at":"2015-10-14T18:53:55Z","updated_at":"2015-10-14T20:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/tools/pulls/99/commits","review_comments_url":"https://api.github.com/repos/flutter/tools/pulls/99/comments","review_comment_url":"https://api.github.com/repos/flutter/tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/tools/issues/99/comments","statuses_url":"https://api.github.com/repos/flutter/tools/statuses/5357c24802e572795ed0619d36b52ee3ed0625b9","head":{"label":"mpcomplete:signing","ref":"signing","sha":"5357c24802e572795ed0619d36b52ee3ed0625b9","user":{"login":"mpcomplete","id":1071986,"avatar_url":"https://avatars.githubusercontent.com/u/1071986?v=3","gravatar_id":"","url":"https://api.github.com/users/mpcomplete","html_url":"https://github.com/mpcomplete","followers_url":"https://api.github.com/users/mpcomplete/followers","following_url":"https://api.github.com/users/mpcomplete/following{/other_user}","gists_url":"https://api.github.com/users/mpcomplete/gists{/gist_id}","starred_url":"https://api.github.com/users/mpcomplete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpcomplete/subscriptions","organizations_url":"https://api.github.com/users/mpcomplete/orgs","repos_url":"https://api.github.com/users/mpcomplete/repos","events_url":"https://api.github.com/users/mpcomplete/events{/privacy}","received_events_url":"https://api.github.com/users/mpcomplete/received_events","type":"User","site_admin":false},"repo":{"id":43778086,"name":"flutter_tools","full_name":"mpcomplete/flutter_tools","owner":{"login":"mpcomplete","id":1071986,"avatar_url":"https://avatars.githubusercontent.com/u/1071986?v=3","gravatar_id":"","url":"https://api.github.com/users/mpcomplete","html_url":"https://github.com/mpcomplete","followers_url":"https://api.github.com/users/mpcomplete/followers","following_url":"https://api.github.com/users/mpcomplete/following{/other_user}","gists_url":"https://api.github.com/users/mpcomplete/gists{/gist_id}","starred_url":"https://api.github.com/users/mpcomplete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpcomplete/subscriptions","organizations_url":"https://api.github.com/users/mpcomplete/orgs","repos_url":"https://api.github.com/users/mpcomplete/repos","events_url":"https://api.github.com/users/mpcomplete/events{/privacy}","received_events_url":"https://api.github.com/users/mpcomplete/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpcomplete/flutter_tools","description":"Tools for building Flutter applications","fork":true,"url":"https://api.github.com/repos/mpcomplete/flutter_tools","forks_url":"https://api.github.com/repos/mpcomplete/flutter_tools/forks","keys_url":"https://api.github.com/repos/mpcomplete/flutter_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpcomplete/flutter_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpcomplete/flutter_tools/teams","hooks_url":"https://api.github.com/repos/mpcomplete/flutter_tools/hooks","issue_events_url":"https://api.github.com/repos/mpcomplete/flutter_tools/issues/events{/number}","events_url":"https://api.github.com/repos/mpcomplete/flutter_tools/events","assignees_url":"https://api.github.com/repos/mpcomplete/flutter_tools/assignees{/user}","branches_url":"https://api.github.com/repos/mpcomplete/flutter_tools/branches{/branch}","tags_url":"https://api.github.com/repos/mpcomplete/flutter_tools/tags","blobs_url":"https://api.github.com/repos/mpcomplete/flutter_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpcomplete/flutter_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpcomplete/flutter_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpcomplete/flutter_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpcomplete/flutter_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/mpcomplete/flutter_tools/languages","stargazers_url":"https://api.github.com/repos/mpcomplete/flutter_tools/stargazers","contributors_url":"https://api.github.com/repos/mpcomplete/flutter_tools/contributors","subscribers_url":"https://api.github.com/repos/mpcomplete/flutter_tools/subscribers","subscription_url":"https://api.github.com/repos/mpcomplete/flutter_tools/subscription","commits_url":"https://api.github.com/repos/mpcomplete/flutter_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpcomplete/flutter_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpcomplete/flutter_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpcomplete/flutter_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpcomplete/flutter_tools/contents/{+path}","compare_url":"https://api.github.com/repos/mpcomplete/flutter_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpcomplete/flutter_tools/merges","archive_url":"https://api.github.com/repos/mpcomplete/flutter_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpcomplete/flutter_tools/downloads","issues_url":"https://api.github.com/repos/mpcomplete/flutter_tools/issues{/number}","pulls_url":"https://api.github.com/repos/mpcomplete/flutter_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/mpcomplete/flutter_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/mpcomplete/flutter_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpcomplete/flutter_tools/labels{/name}","releases_url":"https://api.github.com/repos/mpcomplete/flutter_tools/releases{/id}","created_at":"2015-10-06T20:54:14Z","updated_at":"2015-10-06T20:54:49Z","pushed_at":"2015-10-14T18:49:29Z","git_url":"git://github.com/mpcomplete/flutter_tools.git","ssh_url":"git@github.com:mpcomplete/flutter_tools.git","clone_url":"https://github.com/mpcomplete/flutter_tools.git","svn_url":"https://github.com/mpcomplete/flutter_tools","homepage":"","size":179,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"57ba33369ebf90ced91cfc3d13a3976a1996eac3","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39414832,"name":"tools","full_name":"flutter/tools","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/tools","description":"Tools for building Flutter applications","fork":false,"url":"https://api.github.com/repos/flutter/tools","forks_url":"https://api.github.com/repos/flutter/tools/forks","keys_url":"https://api.github.com/repos/flutter/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/tools/teams","hooks_url":"https://api.github.com/repos/flutter/tools/hooks","issue_events_url":"https://api.github.com/repos/flutter/tools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/tools/events","assignees_url":"https://api.github.com/repos/flutter/tools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/tools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/tools/tags","blobs_url":"https://api.github.com/repos/flutter/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/tools/languages","stargazers_url":"https://api.github.com/repos/flutter/tools/stargazers","contributors_url":"https://api.github.com/repos/flutter/tools/contributors","subscribers_url":"https://api.github.com/repos/flutter/tools/subscribers","subscription_url":"https://api.github.com/repos/flutter/tools/subscription","commits_url":"https://api.github.com/repos/flutter/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/tools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/tools/merges","archive_url":"https://api.github.com/repos/flutter/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/tools/downloads","issues_url":"https://api.github.com/repos/flutter/tools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/tools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/tools/releases{/id}","created_at":"2015-07-21T00:19:47Z","updated_at":"2015-09-19T15:49:23Z","pushed_at":"2015-10-14T18:53:56Z","git_url":"git://github.com/flutter/tools.git","ssh_url":"git@github.com:flutter/tools.git","clone_url":"https://github.com/flutter/tools.git","svn_url":"https://github.com/flutter/tools","homepage":"","size":926,"stargazers_count":2,"watchers_count":2,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/tools/pulls/99"},"html":{"href":"https://github.com/flutter/tools/pull/99"},"issue":{"href":"https://api.github.com/repos/flutter/tools/issues/99"},"comments":{"href":"https://api.github.com/repos/flutter/tools/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/tools/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/tools/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/tools/statuses/5357c24802e572795ed0619d36b52ee3ed0625b9"}}}}