{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/platatus/issues/161","labels_url":"https://api.github.com/repos/mozilla/platatus/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/platatus/issues/161/comments","events_url":"https://api.github.com/repos/mozilla/platatus/issues/161/events","html_url":"https://github.com/mozilla/platatus/pull/161","id":117655686,"number":161,"title":"Basic search functionality","user":{"login":"potch","id":253470,"avatar_url":"https://avatars.githubusercontent.com/u/253470?v=3","gravatar_id":"","url":"https://api.github.com/users/potch","html_url":"https://github.com/potch","followers_url":"https://api.github.com/users/potch/followers","following_url":"https://api.github.com/users/potch/following{/other_user}","gists_url":"https://api.github.com/users/potch/gists{/gist_id}","starred_url":"https://api.github.com/users/potch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potch/subscriptions","organizations_url":"https://api.github.com/users/potch/orgs","repos_url":"https://api.github.com/users/potch/repos","events_url":"https://api.github.com/users/potch/events{/privacy}","received_events_url":"https://api.github.com/users/potch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/platatus/labels/status:in%20progress","name":"status:in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mozilla/platatus/milestones/1","html_url":"https://github.com/mozilla/platatus/milestones/v1","labels_url":"https://api.github.com/repos/mozilla/platatus/milestones/1/labels","id":1357983,"number":1,"title":"v1","description":"Show Firefox platform features and their respective status, with focus on standardization and enthusiasm/implementation status.\r\n\r\nHosted github, mapped to mozilla.com.","creator":{"login":"digitarald","id":8599,"avatar_url":"https://avatars.githubusercontent.com/u/8599?v=3","gravatar_id":"","url":"https://api.github.com/users/digitarald","html_url":"https://github.com/digitarald","followers_url":"https://api.github.com/users/digitarald/followers","following_url":"https://api.github.com/users/digitarald/following{/other_user}","gists_url":"https://api.github.com/users/digitarald/gists{/gist_id}","starred_url":"https://api.github.com/users/digitarald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitarald/subscriptions","organizations_url":"https://api.github.com/users/digitarald/orgs","repos_url":"https://api.github.com/users/digitarald/repos","events_url":"https://api.github.com/users/digitarald/events{/privacy}","received_events_url":"https://api.github.com/users/digitarald/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":32,"state":"open","created_at":"2015-10-15T18:54:39Z","updated_at":"2015-11-24T19:44:01Z","due_on":"2015-11-20T08:00:00Z","closed_at":null},"comments":13,"created_at":"2015-11-18T18:57:10Z","updated_at":"2015-11-24T19:44:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/platatus/pulls/161","html_url":"https://github.com/mozilla/platatus/pull/161","diff_url":"https://github.com/mozilla/platatus/pull/161.diff","patch_url":"https://github.com/mozilla/platatus/pull/161.patch"},"body":"Basic search functionality with lunr is available on this branch. This is as-of-yet a work-in-progress and point of discussion for the overall search feature.\r\n\r\nBreakdown of the search feature as I see it in my mind\r\n\r\n- [x] Import `lunr` library\r\n- [x] Basic search (features show/hide based on live typing)\r\n- [x] Search styling (open questions about appearance)\r\n- [x] \"Clear Search\" button/link\r\n- [x] Result ranking by relevance (right now alpha order is preserved)\r\n- [ ] Tests!\r\n\r\nBig questions are around styling. The `#features` element is only as big as its widest visible child's intrinsic width. This means as you search the column randomly resizes. Is this intended or can we set the width on the list?\r\n\r\nWe could potentially use flexbox for the features list. This would allow for purely style-based re-ordering of results using the `order` property. Might have layout perf implications, need to investigate.\r\n\r\nWould appreciate an initial code once-through and thoughts on the direction!\r\n\r\nThis will resolve #129."},"comment":{"url":"https://api.github.com/repos/mozilla/platatus/issues/comments/159384599","html_url":"https://github.com/mozilla/platatus/pull/161#issuecomment-159384599","issue_url":"https://api.github.com/repos/mozilla/platatus/issues/161","id":159384599,"user":{"login":"potch","id":253470,"avatar_url":"https://avatars.githubusercontent.com/u/253470?v=3","gravatar_id":"","url":"https://api.github.com/users/potch","html_url":"https://github.com/potch","followers_url":"https://api.github.com/users/potch/followers","following_url":"https://api.github.com/users/potch/following{/other_user}","gists_url":"https://api.github.com/users/potch/gists{/gist_id}","starred_url":"https://api.github.com/users/potch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potch/subscriptions","organizations_url":"https://api.github.com/users/potch/orgs","repos_url":"https://api.github.com/users/potch/repos","events_url":"https://api.github.com/users/potch/events{/privacy}","received_events_url":"https://api.github.com/users/potch/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T19:44:20Z","updated_at":"2015-11-24T19:44:20Z","body":"@wfwalker http://platatus-pr-161.herokuapp.com/ theoretically is that very thing, but hasn't updated when I pushed subsequent updates. not sure how to knock that ball out of the tree.\r\n\r\n@digitarald can I perhaps start the discussion of making search a v1 feature?"}}