{"comment":{"url":"https://api.github.com/repos/open62541/open62541/comments/14964845","html_url":"https://github.com/open62541/open62541/commit/b2ac767f7464b764ba7756486fc7740a8ef267bc#commitcomment-14964845","id":14964845,"user":{"login":"jpfr","id":1726411,"avatar_url":"https://avatars.githubusercontent.com/u/1726411?v=3","gravatar_id":"","url":"https://api.github.com/users/jpfr","html_url":"https://github.com/jpfr","followers_url":"https://api.github.com/users/jpfr/followers","following_url":"https://api.github.com/users/jpfr/following{/other_user}","gists_url":"https://api.github.com/users/jpfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfr/subscriptions","organizations_url":"https://api.github.com/users/jpfr/orgs","repos_url":"https://api.github.com/users/jpfr/repos","events_url":"https://api.github.com/users/jpfr/events{/privacy}","received_events_url":"https://api.github.com/users/jpfr/received_events","type":"User","site_admin":false},"position":10,"line":207,"path":"src/client/ua_client.c","commit_id":"b2ac767f7464b764ba7756486fc7740a8ef267bc","created_at":"2015-12-14T17:17:53Z","updated_at":"2015-12-14T17:17:53Z","body":"@Stasik0 Are you sure about this line?\r\n\r\na) We init a bytestring without freeing first, possibly leaking data\r\nb) We copy UA_STRING_NULL into the request. But the nonce in the request has already be initialized to UA_STRING_NULL\r\n\r\nAnd yeah, that was bad already in the existing code."}}