{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/34","labels_url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/34/comments","events_url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/34/events","html_url":"https://github.com/maidsafe/maidsafe_client/pull/34","id":83361072,"number":34,"title":"Maid 1082 file helper","user":{"login":"krishnaIndia","id":7702996,"avatar_url":"https://avatars.githubusercontent.com/u/7702996?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnaIndia","html_url":"https://github.com/krishnaIndia","followers_url":"https://api.github.com/users/krishnaIndia/followers","following_url":"https://api.github.com/users/krishnaIndia/following{/other_user}","gists_url":"https://api.github.com/users/krishnaIndia/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnaIndia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnaIndia/subscriptions","organizations_url":"https://api.github.com/users/krishnaIndia/orgs","repos_url":"https://api.github.com/users/krishnaIndia/repos","events_url":"https://api.github.com/users/krishnaIndia/events{/privacy}","received_events_url":"https://api.github.com/users/krishnaIndia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-06-01T07:26:50Z","updated_at":"2015-06-02T07:11:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/maidsafe_client/pulls/34","html_url":"https://github.com/maidsafe/maidsafe_client/pull/34","diff_url":"https://github.com/maidsafe/maidsafe_client/pull/34.diff","patch_url":"https://github.com/maidsafe/maidsafe_client/pull/34.patch"},"body":"FileHelper implemented with create, update and update_user_metadata functions.\r\nImplemented the network operations like get and put in NetworkStorage and this can be used for performing network operations over the MaidSafe network. This approach gives flexibility to share the NetworkStorage instance easily rather than sharing &mut client. If this approach is fine, then the DirectoryHeper can be re-factored.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/maidsafe_client/34)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/comments/107834196","html_url":"https://github.com/maidsafe/maidsafe_client/pull/34#issuecomment-107834196","issue_url":"https://api.github.com/repos/maidsafe/maidsafe_client/issues/34","id":107834196,"user":{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T07:11:05Z","updated_at":"2015-06-02T07:11:05Z","body":"\n\n\n\nReview status: all files reviewed, 1 unresolved discussion, some commit checks pending.\nReviewed files:\n- .gitignore @ r1\n- README.md @ r3\n- src/client/mod.rs @ r8\n- src/nfs/helper/directory_helper.rs @ r5\n- src/nfs/helper/file_helper.rs @ r4\n- src/nfs/helper/mod.rs @ r1\n- src/nfs/io/mod.rs @ r1\n- src/nfs/io/network_storage.rs @ r2\n- src/nfs/io/writer.rs @ r4\n- src/nfs/mod.rs @ r1\n- src/nfs/types/directory_listing.rs @ r1\n- src/nfs/types/file.rs @ r1\n- src/nfs/types/metadata.rs @ r1\n\n---\n\n<sup>**[src/nfs/types/metadata.rs, line 66 \\[r8\\]](https://reviewable.io:443/reviews/maidsafe/maidsafe_client/34#-Jqn5_PLMwZFTIchK-Xs)** ([raw file](https://github.com/maidsafe/maidsafe_client/blob/c8795fa8a47f2d410d00088f873a1e3e224df3af/src/nfs/types/metadata.rs#L66)):</sup>\nRust idiom is avoid `return` whenever you can. So maybe `if condition { Some(stuff) } else { None }` (of-course not in a single line) is better\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/maidsafe/maidsafe_client/34)\n<!-- Sent from Reviewable.io -->\n"}}