{"action":"closed","number":669,"pull_request":{"url":"https://api.github.com/repos/ndlib/sipity/pulls/669","id":36867710,"html_url":"https://github.com/ndlib/sipity/pull/669","diff_url":"https://github.com/ndlib/sipity/pull/669.diff","patch_url":"https://github.com/ndlib/sipity/pull/669.patch","issue_url":"https://api.github.com/repos/ndlib/sipity/issues/669","number":669,"state":"closed","locked":false,"title":"ETD add publication intent and patent intent to the access policy form","user":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars.githubusercontent.com/u/2130?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"body":"## Claiming issue 611\r\n\r\n@f867977730b44553dc9d9a385784d66977de2bc2\r\n\r\nrelates to #611\r\n\r\n$ ./script/start-issue 611\r\n\r\n[skip ci]\r\n\r\n## Tidying up a spec\r\n\r\n@265968378c4e44f79f55a1fed134537a38d5ff24\r\n\r\nRearranging for clarity and brevity\r\n\r\n## Removing deprecated form object\r\n\r\n@205ebe3008a6a76f3943cdf99c969df89e8d8d8e\r\n\r\n\r\n## Adding Work patent strategy to initial page\r\n\r\n@5af3c4c4a6ba02e356bb4368d4904e67e9a43488\r\n\r\nI have pushed this as an additional attribute, which is something I'd\r\nlike to capture for the work publication intent as well.\r\n\r\nFair well symmetry. Instead of the nice 4 boxes, we have 5.\r\n\r\n## Extracting methods to appease rubocop\r\n\r\n@295da02c3949035cf07231866998051a796ad24a\r\n\r\nThe method was getting a little too complex; So I'm instead extracting\r\nsome methods to improve clarity and intent.\r\n\r\n## Adding publication and patent action\r\n\r\n@99191f5f378f08c63dff13478410d8e551c2b614\r\n\r\n\r\n## Adding PublishingAndPatentingIntentExtension\r\n\r\n@fd656d895b0918fd248aa3b04e6ddeefb0d5a8a2\r\n\r\nExtracting common behavior to improve composition of the publishing\r\nand patenting intent.\r\n\r\n## Adding WORK_PUBLICATION_STRATEGY to predicates\r\n\r\n@bd59d00e1a630ae7ab7529cd2e42c391792b5041\r\n\r\nInstead of treating this answer as a fundamental bit of data for a\r\nWork (i.e. a property directly on the Work), I'd prefer to push this\r\nto the additional attributes.\r\n\r\nThough the tyranny of the #title remains.\r\n\r\n## Adding translations for TODO items\r\n\r\n@412843dba1c544cc21668581ede64920c79d5a52\r\n\r\n\r\n## Performing dual data maintenance\r\n\r\n@5875cb103a1a4b998b94b19699a6e7913e8d56a2\r\n\r\nOnce #668 is done, the dual data maintenance need not exist.\r\n\r\n> As part of the #611 issue, I'm creating additional attributes for\r\n> both publication and patent strategy. However, as part of the data\r\n> migration, I need to to step;\r\n>\r\n> First expose the new method of capture, then remove the old method.\r\n\r\n## Adding form to capture Publishing and Patenting\r\n\r\n@9a794b5a15d6910655595e9b163c18fb65f3901b\r\n\r\n\r\n## Removing duplication for Start a Submission\r\n\r\n@a5737f5948fcd02594dfdefa7ae09ae555f85049\r\n\r\nGiven that we are capturing patent and publishing information and\r\nexposing it for user updates, I wanted to make sure to leverage the\r\nextension class for building this object.\r\n\r\n## Adding a reasonable default identifier for #translate\r\n\r\n@907c9d83c7c8c81857e5dd68ead7c3b112e0d0a8\r\n\r\n\r\n## Adding default translation scope\r\n\r\n@7cd5f0ff15ae1d43e29a9372304a1fd3818192ed\r\n\r\nI had arranged the translations in the wrong direction; After\r\nconsulting with Don and Dan, I believe the default translation scope\r\nis a better mechanism.\r\n\r\n## Rearranging methods for hound appeasement\r\n\r\n@10ecd23a64714826e25e8b58afe10128da095ece\r\n\r\n\r\n## Appeasing the hound\r\n\r\n@3dd7f6399d471dea44892738253d15237fa28438\r\n\r\nAdjusting scope definition to be within module_exec\r\n\r\n## Closing issue 611\r\n\r\n@08168852976b1f344d2f3ae1ce7752fc671dccf6\r\n\r\nCloses #611\r\n\r\n$ ./script/close-issue 611\r\n","created_at":"2015-06-03T19:18:38Z","updated_at":"2015-06-03T19:50:51Z","closed_at":"2015-06-03T19:50:51Z","merged_at":"2015-06-03T19:50:50Z","merge_commit_sha":"798e5bfa48cb2c0dcc4c696fb25f0818245aaa04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/sipity/pulls/669/commits","review_comments_url":"https://api.github.com/repos/ndlib/sipity/pulls/669/comments","review_comment_url":"https://api.github.com/repos/ndlib/sipity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndlib/sipity/issues/669/comments","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/08168852976b1f344d2f3ae1ce7752fc671dccf6","head":{"label":"ndlib:611-ETD-Add-Publication-Intent-and-Patent-Intent-to-the-AccessPolicyForm","ref":"611-ETD-Add-Publication-Intent-and-Patent-Intent-to-the-AccessPolicyForm","sha":"08168852976b1f344d2f3ae1ce7752fc671dccf6","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":26916085,"name":"sipity","full_name":"ndlib/sipity","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/sipity","description":"Sipity is a patron-oriented deposit interface into CurateND.","fork":false,"url":"https://api.github.com/repos/ndlib/sipity","forks_url":"https://api.github.com/repos/ndlib/sipity/forks","keys_url":"https://api.github.com/repos/ndlib/sipity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/sipity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/sipity/teams","hooks_url":"https://api.github.com/repos/ndlib/sipity/hooks","issue_events_url":"https://api.github.com/repos/ndlib/sipity/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/sipity/events","assignees_url":"https://api.github.com/repos/ndlib/sipity/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/sipity/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/sipity/tags","blobs_url":"https://api.github.com/repos/ndlib/sipity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/sipity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/sipity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/sipity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/sipity/languages","stargazers_url":"https://api.github.com/repos/ndlib/sipity/stargazers","contributors_url":"https://api.github.com/repos/ndlib/sipity/contributors","subscribers_url":"https://api.github.com/repos/ndlib/sipity/subscribers","subscription_url":"https://api.github.com/repos/ndlib/sipity/subscription","commits_url":"https://api.github.com/repos/ndlib/sipity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/sipity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/sipity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/sipity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/sipity/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/sipity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/sipity/merges","archive_url":"https://api.github.com/repos/ndlib/sipity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/sipity/downloads","issues_url":"https://api.github.com/repos/ndlib/sipity/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/sipity/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/sipity/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/sipity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/sipity/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/sipity/releases{/id}","created_at":"2014-11-20T14:31:53Z","updated_at":"2015-05-08T17:27:49Z","pushed_at":"2015-06-03T19:50:51Z","git_url":"git://github.com/ndlib/sipity.git","ssh_url":"git@github.com:ndlib/sipity.git","clone_url":"https://github.com/ndlib/sipity.git","svn_url":"https://github.com/ndlib/sipity","homepage":"https://github.com/ndlib/sipity","size":21283,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":3,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"e22e81443d0f4e1dba05dae3382b12c972d99cb7","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":26916085,"name":"sipity","full_name":"ndlib/sipity","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/sipity","description":"Sipity is a patron-oriented deposit interface into CurateND.","fork":false,"url":"https://api.github.com/repos/ndlib/sipity","forks_url":"https://api.github.com/repos/ndlib/sipity/forks","keys_url":"https://api.github.com/repos/ndlib/sipity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/sipity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/sipity/teams","hooks_url":"https://api.github.com/repos/ndlib/sipity/hooks","issue_events_url":"https://api.github.com/repos/ndlib/sipity/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/sipity/events","assignees_url":"https://api.github.com/repos/ndlib/sipity/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/sipity/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/sipity/tags","blobs_url":"https://api.github.com/repos/ndlib/sipity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/sipity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/sipity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/sipity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/sipity/languages","stargazers_url":"https://api.github.com/repos/ndlib/sipity/stargazers","contributors_url":"https://api.github.com/repos/ndlib/sipity/contributors","subscribers_url":"https://api.github.com/repos/ndlib/sipity/subscribers","subscription_url":"https://api.github.com/repos/ndlib/sipity/subscription","commits_url":"https://api.github.com/repos/ndlib/sipity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/sipity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/sipity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/sipity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/sipity/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/sipity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/sipity/merges","archive_url":"https://api.github.com/repos/ndlib/sipity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/sipity/downloads","issues_url":"https://api.github.com/repos/ndlib/sipity/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/sipity/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/sipity/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/sipity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/sipity/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/sipity/releases{/id}","created_at":"2014-11-20T14:31:53Z","updated_at":"2015-05-08T17:27:49Z","pushed_at":"2015-06-03T19:50:51Z","git_url":"git://github.com/ndlib/sipity.git","ssh_url":"git@github.com:ndlib/sipity.git","clone_url":"https://github.com/ndlib/sipity.git","svn_url":"https://github.com/ndlib/sipity","homepage":"https://github.com/ndlib/sipity","size":21283,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":27,"forks":1,"open_issues":27,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/669"},"html":{"href":"https://github.com/ndlib/sipity/pull/669"},"issue":{"href":"https://api.github.com/repos/ndlib/sipity/issues/669"},"comments":{"href":"https://api.github.com/repos/ndlib/sipity/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/sipity/statuses/08168852976b1f344d2f3ae1ce7752fc671dccf6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rbalekai","id":428610,"avatar_url":"https://avatars.githubusercontent.com/u/428610?v=3","gravatar_id":"","url":"https://api.github.com/users/rbalekai","html_url":"https://github.com/rbalekai","followers_url":"https://api.github.com/users/rbalekai/followers","following_url":"https://api.github.com/users/rbalekai/following{/other_user}","gists_url":"https://api.github.com/users/rbalekai/gists{/gist_id}","starred_url":"https://api.github.com/users/rbalekai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbalekai/subscriptions","organizations_url":"https://api.github.com/users/rbalekai/orgs","repos_url":"https://api.github.com/users/rbalekai/repos","events_url":"https://api.github.com/users/rbalekai/events{/privacy}","received_events_url":"https://api.github.com/users/rbalekai/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":17,"additions":506,"deletions":342,"changed_files":22}}