{"action":"created","issue":{"url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/587","labels_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/587/labels{/name}","comments_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/587/comments","events_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/587/events","html_url":"https://github.com/markovmodel/PyEMMA/issues/587","id":113388525,"number":587,"title":"rename ctor arg topology of MDFeaturizer back to topfile to preserve API","user":{"login":"marscher","id":170287,"avatar_url":"https://avatars.githubusercontent.com/u/170287?v=3","gravatar_id":"","url":"https://api.github.com/users/marscher","html_url":"https://github.com/marscher","followers_url":"https://api.github.com/users/marscher/followers","following_url":"https://api.github.com/users/marscher/following{/other_user}","gists_url":"https://api.github.com/users/marscher/gists{/gist_id}","starred_url":"https://api.github.com/users/marscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marscher/subscriptions","organizations_url":"https://api.github.com/users/marscher/orgs","repos_url":"https://api.github.com/users/marscher/repos","events_url":"https://api.github.com/users/marscher/events{/privacy}","received_events_url":"https://api.github.com/users/marscher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"marscher","id":170287,"avatar_url":"https://avatars.githubusercontent.com/u/170287?v=3","gravatar_id":"","url":"https://api.github.com/users/marscher","html_url":"https://github.com/marscher","followers_url":"https://api.github.com/users/marscher/followers","following_url":"https://api.github.com/users/marscher/following{/other_user}","gists_url":"https://api.github.com/users/marscher/gists{/gist_id}","starred_url":"https://api.github.com/users/marscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marscher/subscriptions","organizations_url":"https://api.github.com/users/marscher/orgs","repos_url":"https://api.github.com/users/marscher/repos","events_url":"https://api.github.com/users/marscher/events{/privacy}","received_events_url":"https://api.github.com/users/marscher/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-10-26T16:01:59Z","updated_at":"2015-10-26T16:09:14Z","closed_at":null,"body":"we can just add another arg named topology, set topfile and topology to None and require at least one valid arg."},"comment":{"url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/comments/151190195","html_url":"https://github.com/markovmodel/PyEMMA/issues/587#issuecomment-151190195","issue_url":"https://api.github.com/repos/markovmodel/PyEMMA/issues/587","id":151190195,"user":{"login":"franknoe","id":6495810,"avatar_url":"https://avatars.githubusercontent.com/u/6495810?v=3","gravatar_id":"","url":"https://api.github.com/users/franknoe","html_url":"https://github.com/franknoe","followers_url":"https://api.github.com/users/franknoe/followers","following_url":"https://api.github.com/users/franknoe/following{/other_user}","gists_url":"https://api.github.com/users/franknoe/gists{/gist_id}","starred_url":"https://api.github.com/users/franknoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franknoe/subscriptions","organizations_url":"https://api.github.com/users/franknoe/orgs","repos_url":"https://api.github.com/users/franknoe/repos","events_url":"https://api.github.com/users/franknoe/events{/privacy}","received_events_url":"https://api.github.com/users/franknoe/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T16:09:14Z","updated_at":"2015-10-26T16:09:14Z","body":"No, I don't intend to break the api. I suggest to keep topfile=None as a \nfirst argument, but to add the additional argument top=... One of the \ntwo is required and either a file or a Topology object is accepted. In \nprinciple the new argument has no effect - it is just a semantic thing \nbecause the user might find it confusing that \"topfile\" can also be an \nobject.\n\nAm 26/10/15 um 17:07 schrieb Martin K. Scherer:\n>\n> But, by changing the name to a new one, we'll brake the api. Is this \n> desired?\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/markovmodel/PyEMMA/issues/587#issuecomment-151189065>.\n>\n\n\n-- \n\n----------------------------------------------\nProf. Dr. Frank Noe\nHead of Computational Molecular Biology group\nFreie Universitaet Berlin\n\nPhone: (+49) (0)30 838 75354\nWeb:   research.franknoe.de\nMail:  Arnimallee 6, 14195 Berlin, Germany\n----------------------------------------------\n\n"}}