{"action":"closed","number":1310,"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310","id":32694864,"html_url":"https://github.com/asciidoctor/asciidoctor/pull/1310","diff_url":"https://github.com/asciidoctor/asciidoctor/pull/1310.diff","patch_url":"https://github.com/asciidoctor/asciidoctor/pull/1310.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1310","number":1310,"state":"closed","locked":false,"title":"Avoid direct access to config instance variable","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"body":"There is currently a false positive in the AsciidoctorJ tests.\r\nThe tests for the InlineMacroProcessor should fail but they don't.\r\nDepending on the regexp the ManPageProcessor should be applied or not but it always applies.\r\nhttps://github.com/asciidoctor/asciidoctorj/blob/master/asciidoctorj-core/src/test/java/org/asciidoctor/extension/WhenJavaExtensionIsRegistered.java#L554\r\n\r\nThe reason is that Asciidoctor does not see the regexp in the options because it directly accesses the config instance variable.\r\nThereby it bypasses the possibility of the extension proxy to make the config of the instance visible.\r\nThe PR changes the access to the config by not accessing the config ivar directly but by calling the accessor that invokes the extension proxy and makes the correct configuration visible.\r\n","created_at":"2015-04-06T17:42:28Z","updated_at":"2015-04-11T06:12:44Z","closed_at":"2015-04-11T06:12:44Z","merged_at":null,"merge_commit_sha":"5335f790d89c925f22922b3e7ab83a20459b9e14","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1310/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/24c8819f84375260bcd8aacb945b824b556d42db","head":{"label":"robertpanzer:NoDirectAccessConfig","ref":"NoDirectAccessConfig","sha":"24c8819f84375260bcd8aacb945b824b556d42db","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"repo":{"id":33495342,"name":"asciidoctor","full_name":"robertpanzer/asciidoctor","owner":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertpanzer/asciidoctor","description":":gem: A fast, open source text processor and publishing toolchain, written in Ruby, for converting AsciiDoc content to HTML5, DocBook 5 (or 4.5) and other formats.","fork":true,"url":"https://api.github.com/repos/robertpanzer/asciidoctor","forks_url":"https://api.github.com/repos/robertpanzer/asciidoctor/forks","keys_url":"https://api.github.com/repos/robertpanzer/asciidoctor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertpanzer/asciidoctor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertpanzer/asciidoctor/teams","hooks_url":"https://api.github.com/repos/robertpanzer/asciidoctor/hooks","issue_events_url":"https://api.github.com/repos/robertpanzer/asciidoctor/issues/events{/number}","events_url":"https://api.github.com/repos/robertpanzer/asciidoctor/events","assignees_url":"https://api.github.com/repos/robertpanzer/asciidoctor/assignees{/user}","branches_url":"https://api.github.com/repos/robertpanzer/asciidoctor/branches{/branch}","tags_url":"https://api.github.com/repos/robertpanzer/asciidoctor/tags","blobs_url":"https://api.github.com/repos/robertpanzer/asciidoctor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertpanzer/asciidoctor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertpanzer/asciidoctor/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertpanzer/asciidoctor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertpanzer/asciidoctor/statuses/{sha}","languages_url":"https://api.github.com/repos/robertpanzer/asciidoctor/languages","stargazers_url":"https://api.github.com/repos/robertpanzer/asciidoctor/stargazers","contributors_url":"https://api.github.com/repos/robertpanzer/asciidoctor/contributors","subscribers_url":"https://api.github.com/repos/robertpanzer/asciidoctor/subscribers","subscription_url":"https://api.github.com/repos/robertpanzer/asciidoctor/subscription","commits_url":"https://api.github.com/repos/robertpanzer/asciidoctor/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertpanzer/asciidoctor/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertpanzer/asciidoctor/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertpanzer/asciidoctor/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertpanzer/asciidoctor/contents/{+path}","compare_url":"https://api.github.com/repos/robertpanzer/asciidoctor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertpanzer/asciidoctor/merges","archive_url":"https://api.github.com/repos/robertpanzer/asciidoctor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertpanzer/asciidoctor/downloads","issues_url":"https://api.github.com/repos/robertpanzer/asciidoctor/issues{/number}","pulls_url":"https://api.github.com/repos/robertpanzer/asciidoctor/pulls{/number}","milestones_url":"https://api.github.com/repos/robertpanzer/asciidoctor/milestones{/number}","notifications_url":"https://api.github.com/repos/robertpanzer/asciidoctor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertpanzer/asciidoctor/labels{/name}","releases_url":"https://api.github.com/repos/robertpanzer/asciidoctor/releases{/id}","created_at":"2015-04-06T17:35:32Z","updated_at":"2015-04-06T17:35:34Z","pushed_at":"2015-04-06T17:37:08Z","git_url":"git://github.com/robertpanzer/asciidoctor.git","ssh_url":"git@github.com:robertpanzer/asciidoctor.git","clone_url":"https://github.com/robertpanzer/asciidoctor.git","svn_url":"https://github.com/robertpanzer/asciidoctor","homepage":"http://asciidoctor.org","size":11782,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:master","ref":"master","sha":"d5862cf8da967ea4f58924d575ce52c3250ab3d7","user":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":4523235,"name":"asciidoctor","full_name":"asciidoctor/asciidoctor","owner":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asciidoctor/asciidoctor","description":":gem: A fast, open source text processor and publishing toolchain, written in Ruby, for converting AsciiDoc content to HTML5, DocBook 5 (or 4.5) and other formats.","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctor","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctor/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctor/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctor/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctor/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctor/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctor/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctor/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctor/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctor/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctor/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctor/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctor/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctor/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctor/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctor/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctor/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctor/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctor/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctor/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctor/releases{/id}","created_at":"2012-06-01T19:09:20Z","updated_at":"2015-04-11T05:09:16Z","pushed_at":"2015-04-08T08:31:58Z","git_url":"git://github.com/asciidoctor/asciidoctor.git","ssh_url":"git@github.com:asciidoctor/asciidoctor.git","clone_url":"https://github.com/asciidoctor/asciidoctor.git","svn_url":"https://github.com/asciidoctor/asciidoctor","homepage":"http://asciidoctor.org","size":11782,"stargazers_count":496,"watchers_count":496,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":286,"forks":125,"open_issues":286,"watchers":496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310"},"html":{"href":"https://github.com/asciidoctor/asciidoctor/pull/1310"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1310"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctor/statuses/24c8819f84375260bcd8aacb945b824b556d42db"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}