{"action":"created","comment":{"url":"https://api.github.com/repos/scalameter/scalameter/pulls/comments/32884130","id":32884130,"diff_hunk":"@@ -74,27 +76,27 @@ object Gen {\n \n   def unit(axisName: String): Gen[Unit] = new Gen[Unit] {\n     def warmupset = Iterator.single(())\n-    def dataset = Iterator.single(Parameters((axisName, ())))\n+    def dataset = Iterator.single(Parameters((Parameter[Unit](axisName), ())))\n     def generate(params: Parameters) = params[Unit](axisName)\n   }\n \n-  def single[T](axisName: String)(v: T): Gen[T] = enumeration(axisName)(v)\n+  def single[T: Pickler](axisName: String)(v: T): Gen[T] = enumeration(axisName)(v)\n \n   def range(axisName: String)(from: Int, upto: Int, hop: Int): Gen[Int] = new Gen[Int] {\n     def warmupset = Iterator.single(upto)\n-    def dataset = (from to upto by hop).iterator.map(x => Parameters(axisName -> x))\n+    def dataset = (from to upto by hop).iterator.map(x => Parameters(Parameter[Int](axisName) -> x))\n     def generate(params: Parameters) = params[Int](axisName)\n   }\n \n-  def enumeration[T](axisName: String)(xs: T*): Gen[T] = new Gen[T] {\n+  def enumeration[T: Pickler](axisName: String)(xs: T*): Gen[T] = new Gen[T] {","path":"src/main/scala/org/scalameter/Gen.scala","position":29,"original_position":29,"commit_id":"92db57f6968b9400a8d151948c76e581cd6db5b7","original_commit_id":"92db57f6968b9400a8d151948c76e581cd6db5b7","user":{"login":"axel22","id":151774,"avatar_url":"https://avatars.githubusercontent.com/u/151774?v=3","gravatar_id":"","url":"https://api.github.com/users/axel22","html_url":"https://github.com/axel22","followers_url":"https://api.github.com/users/axel22/followers","following_url":"https://api.github.com/users/axel22/following{/other_user}","gists_url":"https://api.github.com/users/axel22/gists{/gist_id}","starred_url":"https://api.github.com/users/axel22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel22/subscriptions","organizations_url":"https://api.github.com/users/axel22/orgs","repos_url":"https://api.github.com/users/axel22/repos","events_url":"https://api.github.com/users/axel22/events{/privacy}","received_events_url":"https://api.github.com/users/axel22/received_events","type":"User","site_admin":false},"body":"Besides the `SerializationPersistor`, the benchmark classes are serialized when sent to another JVM for execution.\r\nThis also means that the generators are serialized, so we would have to avoid embedding the picklers themselves into the generator, and instead embed their classnames.","created_at":"2015-06-20T12:02:00Z","updated_at":"2015-06-20T12:02:00Z","html_url":"https://github.com/scalameter/scalameter/pull/121#discussion_r32884130","pull_request_url":"https://api.github.com/repos/scalameter/scalameter/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/comments/32884130"},"html":{"href":"https://github.com/scalameter/scalameter/pull/121#discussion_r32884130"},"pull_request":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/scalameter/scalameter/pulls/121","id":38165803,"html_url":"https://github.com/scalameter/scalameter/pull/121","diff_url":"https://github.com/scalameter/scalameter/pull/121.diff","patch_url":"https://github.com/scalameter/scalameter/pull/121.patch","issue_url":"https://api.github.com/repos/scalameter/scalameter/issues/121","number":121,"state":"open","locked":false,"title":"Modify parameter and config keys.","user":{"login":"kjanosz","id":1921482,"avatar_url":"https://avatars.githubusercontent.com/u/1921482?v=3","gravatar_id":"","url":"https://api.github.com/users/kjanosz","html_url":"https://github.com/kjanosz","followers_url":"https://api.github.com/users/kjanosz/followers","following_url":"https://api.github.com/users/kjanosz/following{/other_user}","gists_url":"https://api.github.com/users/kjanosz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjanosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjanosz/subscriptions","organizations_url":"https://api.github.com/users/kjanosz/orgs","repos_url":"https://api.github.com/users/kjanosz/repos","events_url":"https://api.github.com/users/kjanosz/events{/privacy}","received_events_url":"https://api.github.com/users/kjanosz/received_events","type":"User","site_admin":false},"body":"Make Parameter[_] key in Parameters map.\r\nRefactor Gen to take Picklers.\r\nEmbed Pickler in Key[T] and Parameter[T].","created_at":"2015-06-20T10:00:06Z","updated_at":"2015-06-20T12:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83fb835d3b114e8f7b64f36fb9c0ced6abfa0959","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scalameter/scalameter/pulls/121/commits","review_comments_url":"https://api.github.com/repos/scalameter/scalameter/pulls/121/comments","review_comment_url":"https://api.github.com/repos/scalameter/scalameter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalameter/scalameter/issues/121/comments","statuses_url":"https://api.github.com/repos/scalameter/scalameter/statuses/92db57f6968b9400a8d151948c76e581cd6db5b7","head":{"label":"kjanosz:maps-keys-refactor","ref":"maps-keys-refactor","sha":"92db57f6968b9400a8d151948c76e581cd6db5b7","user":{"login":"kjanosz","id":1921482,"avatar_url":"https://avatars.githubusercontent.com/u/1921482?v=3","gravatar_id":"","url":"https://api.github.com/users/kjanosz","html_url":"https://github.com/kjanosz","followers_url":"https://api.github.com/users/kjanosz/followers","following_url":"https://api.github.com/users/kjanosz/following{/other_user}","gists_url":"https://api.github.com/users/kjanosz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjanosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjanosz/subscriptions","organizations_url":"https://api.github.com/users/kjanosz/orgs","repos_url":"https://api.github.com/users/kjanosz/repos","events_url":"https://api.github.com/users/kjanosz/events{/privacy}","received_events_url":"https://api.github.com/users/kjanosz/received_events","type":"User","site_admin":false},"repo":{"id":35629278,"name":"scalameter","full_name":"kjanosz/scalameter","owner":{"login":"kjanosz","id":1921482,"avatar_url":"https://avatars.githubusercontent.com/u/1921482?v=3","gravatar_id":"","url":"https://api.github.com/users/kjanosz","html_url":"https://github.com/kjanosz","followers_url":"https://api.github.com/users/kjanosz/followers","following_url":"https://api.github.com/users/kjanosz/following{/other_user}","gists_url":"https://api.github.com/users/kjanosz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjanosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjanosz/subscriptions","organizations_url":"https://api.github.com/users/kjanosz/orgs","repos_url":"https://api.github.com/users/kjanosz/repos","events_url":"https://api.github.com/users/kjanosz/events{/privacy}","received_events_url":"https://api.github.com/users/kjanosz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjanosz/scalameter","description":"Microbenchmarking and performance regression testing framework for the JVM platform.","fork":true,"url":"https://api.github.com/repos/kjanosz/scalameter","forks_url":"https://api.github.com/repos/kjanosz/scalameter/forks","keys_url":"https://api.github.com/repos/kjanosz/scalameter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjanosz/scalameter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjanosz/scalameter/teams","hooks_url":"https://api.github.com/repos/kjanosz/scalameter/hooks","issue_events_url":"https://api.github.com/repos/kjanosz/scalameter/issues/events{/number}","events_url":"https://api.github.com/repos/kjanosz/scalameter/events","assignees_url":"https://api.github.com/repos/kjanosz/scalameter/assignees{/user}","branches_url":"https://api.github.com/repos/kjanosz/scalameter/branches{/branch}","tags_url":"https://api.github.com/repos/kjanosz/scalameter/tags","blobs_url":"https://api.github.com/repos/kjanosz/scalameter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjanosz/scalameter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjanosz/scalameter/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjanosz/scalameter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjanosz/scalameter/statuses/{sha}","languages_url":"https://api.github.com/repos/kjanosz/scalameter/languages","stargazers_url":"https://api.github.com/repos/kjanosz/scalameter/stargazers","contributors_url":"https://api.github.com/repos/kjanosz/scalameter/contributors","subscribers_url":"https://api.github.com/repos/kjanosz/scalameter/subscribers","subscription_url":"https://api.github.com/repos/kjanosz/scalameter/subscription","commits_url":"https://api.github.com/repos/kjanosz/scalameter/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjanosz/scalameter/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjanosz/scalameter/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjanosz/scalameter/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjanosz/scalameter/contents/{+path}","compare_url":"https://api.github.com/repos/kjanosz/scalameter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjanosz/scalameter/merges","archive_url":"https://api.github.com/repos/kjanosz/scalameter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjanosz/scalameter/downloads","issues_url":"https://api.github.com/repos/kjanosz/scalameter/issues{/number}","pulls_url":"https://api.github.com/repos/kjanosz/scalameter/pulls{/number}","milestones_url":"https://api.github.com/repos/kjanosz/scalameter/milestones{/number}","notifications_url":"https://api.github.com/repos/kjanosz/scalameter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjanosz/scalameter/labels{/name}","releases_url":"https://api.github.com/repos/kjanosz/scalameter/releases{/id}","created_at":"2015-05-14T18:35:41Z","updated_at":"2015-05-14T18:35:41Z","pushed_at":"2015-06-20T11:29:19Z","git_url":"git://github.com/kjanosz/scalameter.git","ssh_url":"git@github.com:kjanosz/scalameter.git","clone_url":"https://github.com/kjanosz/scalameter.git","svn_url":"https://github.com/kjanosz/scalameter","homepage":"http://scalameter.github.io","size":16643,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalameter:master","ref":"master","sha":"ca4b6ee8b90755e4f340d61f844df286b136dfdb","user":{"login":"scalameter","id":6672795,"avatar_url":"https://avatars.githubusercontent.com/u/6672795?v=3","gravatar_id":"","url":"https://api.github.com/users/scalameter","html_url":"https://github.com/scalameter","followers_url":"https://api.github.com/users/scalameter/followers","following_url":"https://api.github.com/users/scalameter/following{/other_user}","gists_url":"https://api.github.com/users/scalameter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameter/subscriptions","organizations_url":"https://api.github.com/users/scalameter/orgs","repos_url":"https://api.github.com/users/scalameter/repos","events_url":"https://api.github.com/users/scalameter/events{/privacy}","received_events_url":"https://api.github.com/users/scalameter/received_events","type":"Organization","site_admin":false},"repo":{"id":6751208,"name":"scalameter","full_name":"scalameter/scalameter","owner":{"login":"scalameter","id":6672795,"avatar_url":"https://avatars.githubusercontent.com/u/6672795?v=3","gravatar_id":"","url":"https://api.github.com/users/scalameter","html_url":"https://github.com/scalameter","followers_url":"https://api.github.com/users/scalameter/followers","following_url":"https://api.github.com/users/scalameter/following{/other_user}","gists_url":"https://api.github.com/users/scalameter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameter/subscriptions","organizations_url":"https://api.github.com/users/scalameter/orgs","repos_url":"https://api.github.com/users/scalameter/repos","events_url":"https://api.github.com/users/scalameter/events{/privacy}","received_events_url":"https://api.github.com/users/scalameter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalameter/scalameter","description":"Microbenchmarking and performance regression testing framework for the JVM platform.","fork":false,"url":"https://api.github.com/repos/scalameter/scalameter","forks_url":"https://api.github.com/repos/scalameter/scalameter/forks","keys_url":"https://api.github.com/repos/scalameter/scalameter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalameter/scalameter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalameter/scalameter/teams","hooks_url":"https://api.github.com/repos/scalameter/scalameter/hooks","issue_events_url":"https://api.github.com/repos/scalameter/scalameter/issues/events{/number}","events_url":"https://api.github.com/repos/scalameter/scalameter/events","assignees_url":"https://api.github.com/repos/scalameter/scalameter/assignees{/user}","branches_url":"https://api.github.com/repos/scalameter/scalameter/branches{/branch}","tags_url":"https://api.github.com/repos/scalameter/scalameter/tags","blobs_url":"https://api.github.com/repos/scalameter/scalameter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalameter/scalameter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalameter/scalameter/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalameter/scalameter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalameter/scalameter/statuses/{sha}","languages_url":"https://api.github.com/repos/scalameter/scalameter/languages","stargazers_url":"https://api.github.com/repos/scalameter/scalameter/stargazers","contributors_url":"https://api.github.com/repos/scalameter/scalameter/contributors","subscribers_url":"https://api.github.com/repos/scalameter/scalameter/subscribers","subscription_url":"https://api.github.com/repos/scalameter/scalameter/subscription","commits_url":"https://api.github.com/repos/scalameter/scalameter/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalameter/scalameter/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalameter/scalameter/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalameter/scalameter/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalameter/scalameter/contents/{+path}","compare_url":"https://api.github.com/repos/scalameter/scalameter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalameter/scalameter/merges","archive_url":"https://api.github.com/repos/scalameter/scalameter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalameter/scalameter/downloads","issues_url":"https://api.github.com/repos/scalameter/scalameter/issues{/number}","pulls_url":"https://api.github.com/repos/scalameter/scalameter/pulls{/number}","milestones_url":"https://api.github.com/repos/scalameter/scalameter/milestones{/number}","notifications_url":"https://api.github.com/repos/scalameter/scalameter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalameter/scalameter/labels{/name}","releases_url":"https://api.github.com/repos/scalameter/scalameter/releases{/id}","created_at":"2012-11-18T20:56:32Z","updated_at":"2015-06-16T01:51:37Z","pushed_at":"2015-06-20T11:29:20Z","git_url":"git://github.com/scalameter/scalameter.git","ssh_url":"git@github.com:scalameter/scalameter.git","clone_url":"https://github.com/scalameter/scalameter.git","svn_url":"https://github.com/scalameter/scalameter","homepage":"http://scalameter.github.io","size":17497,"stargazers_count":180,"watchers_count":180,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":26,"forks":32,"open_issues":26,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/121"},"html":{"href":"https://github.com/scalameter/scalameter/pull/121"},"issue":{"href":"https://api.github.com/repos/scalameter/scalameter/issues/121"},"comments":{"href":"https://api.github.com/repos/scalameter/scalameter/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalameter/scalameter/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/scalameter/scalameter/statuses/92db57f6968b9400a8d151948c76e581cd6db5b7"}}}}