{"action":"closed","number":118,"pull_request":{"url":"https://api.github.com/repos/appc/spec/pulls/118","id":27437314,"html_url":"https://github.com/appc/spec/pull/118","diff_url":"https://github.com/appc/spec/pull/118.diff","patch_url":"https://github.com/appc/spec/pull/118.patch","issue_url":"https://api.github.com/repos/appc/spec/issues/118","number":118,"state":"closed","locked":false,"title":"discovery: implement simple discovery","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"This patch needs coreos/rocket#382 implemented in rocket (or fetch will fail as it will use only the first simple discovery url).\r\n\r\nWhen applied, as it changes the name of DiscoverEndpoints to MetaDiscoverEndpoints, rocket should be changed to handle this different name (in rkt/fetch.go, done in coreos/rocket#383)\r\n\r\nImplement simple discovery as defined in the spec.\r\nIf insecure is true, also the http scheme, in addition to https is used to\r\nrender the simple template.\r\nThis adds a new function for simple discovery so users can separately\r\ncall Simple and Meta discovery (and get per discovery type errors).\r\nFix and improve tests.","created_at":"2015-01-15T15:42:45Z","updated_at":"2015-03-19T18:55:25Z","closed_at":"2015-03-19T18:55:25Z","merged_at":null,"merge_commit_sha":"285bd20d9f1300a72664febe1fbc8276b484afb1","assignee":null,"milestone":{"url":"https://api.github.com/repos/appc/spec/milestones/3","html_url":"https://github.com/appc/spec/milestones/v0.5.0","labels_url":"https://api.github.com/repos/appc/spec/milestones/3/labels","id":934163,"number":3,"title":"v0.5.0","description":"This milestone captures the first version of the spec where we feel comfortable with the core primitives (i.e that they will be stable) and will be stricter about versioning.","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":10,"state":"open","created_at":"2015-01-13T21:42:16Z","updated_at":"2015-03-19T18:55:25Z","due_on":"2015-03-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/appc/spec/pulls/118/commits","review_comments_url":"https://api.github.com/repos/appc/spec/pulls/118/comments","review_comment_url":"https://api.github.com/repos/appc/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/spec/issues/118/comments","statuses_url":"https://api.github.com/repos/appc/spec/statuses/a727b014ece42a85f0a46348fc6a281a881f6267","head":{"label":"sgotti:simplediscovery","ref":"simplediscovery","sha":"a727b014ece42a85f0a46348fc6a281a881f6267","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"repo":{"id":27816510,"name":"spec","full_name":"sgotti/spec","owner":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgotti/spec","description":"App Container Specification and Tooling","fork":true,"url":"https://api.github.com/repos/sgotti/spec","forks_url":"https://api.github.com/repos/sgotti/spec/forks","keys_url":"https://api.github.com/repos/sgotti/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgotti/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgotti/spec/teams","hooks_url":"https://api.github.com/repos/sgotti/spec/hooks","issue_events_url":"https://api.github.com/repos/sgotti/spec/issues/events{/number}","events_url":"https://api.github.com/repos/sgotti/spec/events","assignees_url":"https://api.github.com/repos/sgotti/spec/assignees{/user}","branches_url":"https://api.github.com/repos/sgotti/spec/branches{/branch}","tags_url":"https://api.github.com/repos/sgotti/spec/tags","blobs_url":"https://api.github.com/repos/sgotti/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgotti/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgotti/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgotti/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgotti/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/sgotti/spec/languages","stargazers_url":"https://api.github.com/repos/sgotti/spec/stargazers","contributors_url":"https://api.github.com/repos/sgotti/spec/contributors","subscribers_url":"https://api.github.com/repos/sgotti/spec/subscribers","subscription_url":"https://api.github.com/repos/sgotti/spec/subscription","commits_url":"https://api.github.com/repos/sgotti/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgotti/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgotti/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgotti/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgotti/spec/contents/{+path}","compare_url":"https://api.github.com/repos/sgotti/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgotti/spec/merges","archive_url":"https://api.github.com/repos/sgotti/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgotti/spec/downloads","issues_url":"https://api.github.com/repos/sgotti/spec/issues{/number}","pulls_url":"https://api.github.com/repos/sgotti/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/sgotti/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/sgotti/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgotti/spec/labels{/name}","releases_url":"https://api.github.com/repos/sgotti/spec/releases{/id}","created_at":"2014-12-10T11:19:40Z","updated_at":"2015-01-21T10:30:43Z","pushed_at":"2015-02-28T09:31:34Z","git_url":"git://github.com/sgotti/spec.git","ssh_url":"git@github.com:sgotti/spec.git","clone_url":"https://github.com/sgotti/spec.git","svn_url":"https://github.com/sgotti/spec","homepage":null,"size":1059,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"c7876f0505e3dcb77c9d6e612810d049db2873bf","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":27782596,"name":"spec","full_name":"appc/spec","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/spec","description":"App Container Specification and Tooling","fork":false,"url":"https://api.github.com/repos/appc/spec","forks_url":"https://api.github.com/repos/appc/spec/forks","keys_url":"https://api.github.com/repos/appc/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/spec/teams","hooks_url":"https://api.github.com/repos/appc/spec/hooks","issue_events_url":"https://api.github.com/repos/appc/spec/issues/events{/number}","events_url":"https://api.github.com/repos/appc/spec/events","assignees_url":"https://api.github.com/repos/appc/spec/assignees{/user}","branches_url":"https://api.github.com/repos/appc/spec/branches{/branch}","tags_url":"https://api.github.com/repos/appc/spec/tags","blobs_url":"https://api.github.com/repos/appc/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/spec/languages","stargazers_url":"https://api.github.com/repos/appc/spec/stargazers","contributors_url":"https://api.github.com/repos/appc/spec/contributors","subscribers_url":"https://api.github.com/repos/appc/spec/subscribers","subscription_url":"https://api.github.com/repos/appc/spec/subscription","commits_url":"https://api.github.com/repos/appc/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/spec/contents/{+path}","compare_url":"https://api.github.com/repos/appc/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/spec/merges","archive_url":"https://api.github.com/repos/appc/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/spec/downloads","issues_url":"https://api.github.com/repos/appc/spec/issues{/number}","pulls_url":"https://api.github.com/repos/appc/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/spec/labels{/name}","releases_url":"https://api.github.com/repos/appc/spec/releases{/id}","created_at":"2014-12-09T19:17:54Z","updated_at":"2015-03-19T17:22:29Z","pushed_at":"2015-03-19T17:22:28Z","git_url":"git://github.com/appc/spec.git","ssh_url":"git@github.com:appc/spec.git","clone_url":"https://github.com/appc/spec.git","svn_url":"https://github.com/appc/spec","homepage":null,"size":3416,"stargazers_count":434,"watchers_count":434,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":54,"forks":49,"open_issues":54,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/spec/pulls/118"},"html":{"href":"https://github.com/appc/spec/pull/118"},"issue":{"href":"https://api.github.com/repos/appc/spec/issues/118"},"comments":{"href":"https://api.github.com/repos/appc/spec/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/spec/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/spec/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/appc/spec/statuses/a727b014ece42a85f0a46348fc6a281a881f6267"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":11,"commits":2,"additions":220,"deletions":81,"changed_files":3}}