{"action":"created","issue":{"url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/45","labels_url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/45/comments","events_url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/45/events","html_url":"https://github.com/magfest/ubersystem-puppet/pull/45","id":101422256,"number":45,"title":"fix FQDN not being set correctly on vagrant machines","user":{"login":"binary1230","id":5413064,"avatar_url":"https://avatars.githubusercontent.com/u/5413064?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1230","html_url":"https://github.com/binary1230","followers_url":"https://api.github.com/users/binary1230/followers","following_url":"https://api.github.com/users/binary1230/following{/other_user}","gists_url":"https://api.github.com/users/binary1230/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1230/subscriptions","organizations_url":"https://api.github.com/users/binary1230/orgs","repos_url":"https://api.github.com/users/binary1230/repos","events_url":"https://api.github.com/users/binary1230/events{/privacy}","received_events_url":"https://api.github.com/users/binary1230/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-17T13:37:54Z","updated_at":"2015-08-17T14:00:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magfest/ubersystem-puppet/pulls/45","html_url":"https://github.com/magfest/ubersystem-puppet/pull/45","diff_url":"https://github.com/magfest/ubersystem-puppet/pull/45.diff","patch_url":"https://github.com/magfest/ubersystem-puppet/pull/45.patch"},"body":"I now bestow upon @earl7399 the title of 'Lead QA builder' for identifying this one.\r\n\r\nfix hostname not being correctly calculated on vagrant machines\r\n\r\nIssue:\r\n- this was breaking local vagrant builds\r\n- facter doesn't set 'fqdn' fact at all if 'domain' fact isn't present\r\n- on production nodes this was working fine because domain was fine\r\n- on vagrant, domain wasn't set, so fqdn was \"\" which was causing nginx puppet (and other stuff) to crash out\r\n\r\nTo fix: puppet class uber::hostname falls back to 'hostname' if 'fqdn' isn't set.  Everything else now looks at this class for $uber::hostname.  Check out init.pp for the real fix.\r\n\r\nI think this is actually fixed in exactly the same way in more recent versions of facter, we're using a pretty old version because it's what comes bundled on Ubuntu 14.04 .1 LTS\r\n\r\n--------\r\n\r\nThis would have been broken by the new puppet refactors because I reworked some of the hostname stuff, though, I swear I tested this with a from-scratch deploy and it worked. Weird.\r\n\r\nMust be merged with https://github.com/magfest/ubersystem-deploy/pull/39"},"comment":{"url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/comments/131827527","html_url":"https://github.com/magfest/ubersystem-puppet/pull/45#issuecomment-131827527","issue_url":"https://api.github.com/repos/magfest/ubersystem-puppet/issues/45","id":131827527,"user":{"login":"EliAndrewC","id":651592,"avatar_url":"https://avatars.githubusercontent.com/u/651592?v=3","gravatar_id":"","url":"https://api.github.com/users/EliAndrewC","html_url":"https://github.com/EliAndrewC","followers_url":"https://api.github.com/users/EliAndrewC/followers","following_url":"https://api.github.com/users/EliAndrewC/following{/other_user}","gists_url":"https://api.github.com/users/EliAndrewC/gists{/gist_id}","starred_url":"https://api.github.com/users/EliAndrewC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliAndrewC/subscriptions","organizations_url":"https://api.github.com/users/EliAndrewC/orgs","repos_url":"https://api.github.com/users/EliAndrewC/repos","events_url":"https://api.github.com/users/EliAndrewC/events{/privacy}","received_events_url":"https://api.github.com/users/EliAndrewC/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T14:00:25Z","updated_at":"2015-08-17T14:00:25Z","body":"+1"}}