{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/15943","labels_url":"https://api.github.com/repos/symfony/symfony/issues/15943/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15943/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/15943/events","html_url":"https://github.com/symfony/symfony/pull/15943","id":108539575,"number":15943,"title":"Remove failing test to fix #15935","user":{"login":"mpdude","id":1202333,"avatar_url":"https://avatars.githubusercontent.com/u/1202333?v=3","gravatar_id":"","url":"https://api.github.com/users/mpdude","html_url":"https://github.com/mpdude","followers_url":"https://api.github.com/users/mpdude/followers","following_url":"https://api.github.com/users/mpdude/following{/other_user}","gists_url":"https://api.github.com/users/mpdude/gists{/gist_id}","starred_url":"https://api.github.com/users/mpdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpdude/subscriptions","organizations_url":"https://api.github.com/users/mpdude/orgs","repos_url":"https://api.github.com/users/mpdude/repos","events_url":"https://api.github.com/users/mpdude/events{/privacy}","received_events_url":"https://api.github.com/users/mpdude/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-27T14:28:33Z","updated_at":"2015-09-28T08:40:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15943","html_url":"https://github.com/symfony/symfony/pull/15943","diff_url":"https://github.com/symfony/symfony/pull/15943.diff","patch_url":"https://github.com/symfony/symfony/pull/15943.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #15935\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nTest has been removed on 2.8 already in https://github.com/symfony/symfony/pull/15738/files#diff-990df0e8238847f8ae54e8227f295c22L107"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/143678984","html_url":"https://github.com/symfony/symfony/pull/15943#issuecomment-143678984","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15943","id":143678984,"user":{"login":"mpdude","id":1202333,"avatar_url":"https://avatars.githubusercontent.com/u/1202333?v=3","gravatar_id":"","url":"https://api.github.com/users/mpdude","html_url":"https://github.com/mpdude","followers_url":"https://api.github.com/users/mpdude/followers","following_url":"https://api.github.com/users/mpdude/following{/other_user}","gists_url":"https://api.github.com/users/mpdude/gists{/gist_id}","starred_url":"https://api.github.com/users/mpdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpdude/subscriptions","organizations_url":"https://api.github.com/users/mpdude/orgs","repos_url":"https://api.github.com/users/mpdude/repos","events_url":"https://api.github.com/users/mpdude/events{/privacy}","received_events_url":"https://api.github.com/users/mpdude/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T08:40:53Z","updated_at":"2015-09-28T08:40:53Z","body":"@xabbuh If it is a useful and well designed test, yes.\r\n\r\nIn this particular case, the test loads translations from a fixture in `prod` mode. It then repeats this to make sure the cached information is used (all green so far).\r\n\r\nThen, in a third step, it re-creates the Translator *without*  adding the resource *and* switches to `debug` mode; it then expects the cache to be invalid.\r\n\r\nThe problems with this are as follows:\r\n\r\n* When using different resource sets, the `Translator` should internally make sure it uses different cache files. This is not the case.\r\n* Switching from `prod` to `debug` probably considered the cache stale before #15738, because in `prod` the `.meta` file was not created. This is, however, an implementation detail not relevant for the working of `ConfigCache`. So, I'd say that this behaviour has even been fixed now because the resource used (the translation fixture file) is unchanged, to it is right to still consider the cache fresh.\r\n\r\nOf course you may ask whether we shouldn't fix the test instead of removing it, but honestly I don't even understand what it actually tries to test for (that hasn't been covered elsewhere already)."}}