{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/40580021","id":40580021,"diff_hunk":"@@ -1063,10 +1062,9 @@ public virtual Task<IdentityResult> RemoveClaimAsync(TUser user, Claim claim)\n                 throw new ArgumentNullException(\"roles\");\n             }\n \n-            var userRoles = await userRoleStore.GetRolesAsync(user, CancellationToken);\n             foreach (var role in roles)","path":"src/Microsoft.AspNet.Identity/UserManager.cs","position":13,"original_position":13,"commit_id":"bad4829284ea4e9bec6dd21be1ac6de72b8e87e6","original_commit_id":"bad4829284ea4e9bec6dd21be1ac6de72b8e87e6","user":{"login":"divega","id":1253414,"avatar_url":"https://avatars.githubusercontent.com/u/1253414?v=3","gravatar_id":"","url":"https://api.github.com/users/divega","html_url":"https://github.com/divega","followers_url":"https://api.github.com/users/divega/followers","following_url":"https://api.github.com/users/divega/following{/other_user}","gists_url":"https://api.github.com/users/divega/gists{/gist_id}","starred_url":"https://api.github.com/users/divega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divega/subscriptions","organizations_url":"https://api.github.com/users/divega/orgs","repos_url":"https://api.github.com/users/divega/repos","events_url":"https://api.github.com/users/divega/events{/privacy}","received_events_url":"https://api.github.com/users/divega/received_events","type":"User","site_admin":false},"body":"Should we do `roles.Distinct()` here to prevent duplicate roles from being added? I haven't looked very deep in `IsInRoleAsync()` but I assume it is possible it won't return true until things are saved to the database.","created_at":"2015-09-28T17:30:44Z","updated_at":"2015-09-28T17:30:44Z","html_url":"https://github.com/aspnet/Identity/pull/575#discussion_r40580021","pull_request_url":"https://api.github.com/repos/aspnet/Identity/pulls/575","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/40580021"},"html":{"href":"https://github.com/aspnet/Identity/pull/575#discussion_r40580021"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/575"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/575","id":46180177,"html_url":"https://github.com/aspnet/Identity/pull/575","diff_url":"https://github.com/aspnet/Identity/pull/575.diff","patch_url":"https://github.com/aspnet/Identity/pull/575.patch","issue_url":"https://api.github.com/repos/aspnet/Identity/issues/575","number":575,"state":"open","locked":false,"title":"Tweak IsInRole check","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"cc @divega ","created_at":"2015-09-28T16:47:57Z","updated_at":"2015-09-28T17:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"799210265b408f18bc600b45e0d78f423794cce9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Identity/pulls/575/commits","review_comments_url":"https://api.github.com/repos/aspnet/Identity/pulls/575/comments","review_comment_url":"https://api.github.com/repos/aspnet/Identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Identity/issues/575/comments","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/bad4829284ea4e9bec6dd21be1ac6de72b8e87e6","head":{"label":"aspnet:haok/9-28check","ref":"haok/9-28check","sha":"bad4829284ea4e9bec6dd21be1ac6de72b8e87e6","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-09-28T07:20:55Z","pushed_at":"2015-09-28T17:20:53Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":8551,"stargazers_count":525,"watchers_count":525,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":37,"forks":212,"open_issues":37,"watchers":525,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"1c861c6f8a61b7fff5df07ac3750dfd3205d4219","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"Membership system for building ASP.NET web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","created_at":"2014-02-03T20:23:53Z","updated_at":"2015-09-28T07:20:55Z","pushed_at":"2015-09-28T17:20:53Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":8551,"stargazers_count":525,"watchers_count":525,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":37,"forks":212,"open_issues":37,"watchers":525,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/575"},"html":{"href":"https://github.com/aspnet/Identity/pull/575"},"issue":{"href":"https://api.github.com/repos/aspnet/Identity/issues/575"},"comments":{"href":"https://api.github.com/repos/aspnet/Identity/issues/575/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/575/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/575/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Identity/statuses/bad4829284ea4e9bec6dd21be1ac6de72b8e87e6"}}}}