{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38261009","id":38261009,"diff_hunk":"@@ -1045,6 +1045,16 @@ void Spell::EffectJumpDest(SpellEffIndex effIndex)\n     if (!m_targets.HasDst())\n         return;\n \n+    if (m_caster != m_originalCaster)\n+    {\n+        Creature* casterCreature = m_caster->ToCreature();\n+        if (casterCreature && casterCreature->GetCreatureTemplate()->flags_extra & CREATURE_FLAG_EXTRA_NO_PULL_BY_GRIP)\n+        {\n+            m_originalCaster->SendSpellMiss(m_caster, this->GetSpellInfo()->Id, SpellMissInfo::SPELL_MISS_IMMUNE);","path":"src/server/game/Spells/SpellEffects.cpp","position":9,"original_position":9,"commit_id":"9394660be2da6ea94e5b2177b3667d1e3bedb19a","original_commit_id":"9394660be2da6ea94e5b2177b3667d1e3bedb19a","user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"body":"please avoid using \"this->\" when it's unneeded","created_at":"2015-08-29T10:19:48Z","updated_at":"2015-08-29T10:19:48Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15354#discussion_r38261009","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38261009"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15354#discussion_r38261009"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354","id":43349510,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/15354","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15354.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15354.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354","number":15354,"state":"open","locked":false,"title":"[WP] Spells/Death Grip fix. The pull effect shouldn't work on some bosses","user":{"login":"chaodhib","id":6612710,"avatar_url":"https://avatars.githubusercontent.com/u/6612710?v=3","gravatar_id":"","url":"https://api.github.com/users/chaodhib","html_url":"https://github.com/chaodhib","followers_url":"https://api.github.com/users/chaodhib/followers","following_url":"https://api.github.com/users/chaodhib/following{/other_user}","gists_url":"https://api.github.com/users/chaodhib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodhib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodhib/subscriptions","organizations_url":"https://api.github.com/users/chaodhib/orgs","repos_url":"https://api.github.com/users/chaodhib/repos","events_url":"https://api.github.com/users/chaodhib/events{/privacy}","received_events_url":"https://api.github.com/users/chaodhib/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/TrinityCore/TrinityCore/issues/14870\r\n\r\n* An extra flag CREATURE_FLAG_EXTRA_NO_PULL_BY_GRIP has been created to handle the immunity to the pull component of the spell Death Grip\r\n* a spell script has been written to the third spell called by the Death Grip chain in order to send to the client the message \"immune\" if the creature has the flag mentioned above.\r\n* the 3 spell scripts are grouped together in the spell_dk for convenience.\r\n\r\nPatchwerk (16028) is taken as the dummy:\r\n![wowscrnshot_082615_012611](https://cloud.githubusercontent.com/assets/6612710/9482281/c47f795a-4b92-11e5-95e8-e3a9f6b6778d.jpg)\r\nThis screenshot is taken after the fix is applied. It show that indeed the taunt is applied but not the pull.\r\n\r\nFor some reason, the dk didnt got the same threat as the highest in list and only got aggro for the 3s duration of the taunt. Unsure if this is linked to the PR.\r\n\r\nTo do:\r\n- [X] implement the extra flag\r\n- [X] Make use of it by spell script\r\n- [ ] Message \"immune\" should be shown to the caster if the mob is immune to the pull effect.\r\n- [ ] Investigate the thing about the bugged threat. See if it's linked to this PR.\r\n- [ ] Update the flag of each boss. And then, update the known exceptions. (SQL queries)","created_at":"2015-08-25T23:38:25Z","updated_at":"2015-08-29T10:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6208a2e9533b2c4fce2082f1a39de6fbe5bbd9b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/9394660be2da6ea94e5b2177b3667d1e3bedb19a","head":{"label":"chaodhib:death_grip_fix","ref":"death_grip_fix","sha":"9394660be2da6ea94e5b2177b3667d1e3bedb19a","user":{"login":"chaodhib","id":6612710,"avatar_url":"https://avatars.githubusercontent.com/u/6612710?v=3","gravatar_id":"","url":"https://api.github.com/users/chaodhib","html_url":"https://github.com/chaodhib","followers_url":"https://api.github.com/users/chaodhib/followers","following_url":"https://api.github.com/users/chaodhib/following{/other_user}","gists_url":"https://api.github.com/users/chaodhib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodhib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodhib/subscriptions","organizations_url":"https://api.github.com/users/chaodhib/orgs","repos_url":"https://api.github.com/users/chaodhib/repos","events_url":"https://api.github.com/users/chaodhib/events{/privacy}","received_events_url":"https://api.github.com/users/chaodhib/received_events","type":"User","site_admin":false},"repo":{"id":32586040,"name":"TrinityCore","full_name":"chaodhib/TrinityCore","owner":{"login":"chaodhib","id":6612710,"avatar_url":"https://avatars.githubusercontent.com/u/6612710?v=3","gravatar_id":"","url":"https://api.github.com/users/chaodhib","html_url":"https://github.com/chaodhib","followers_url":"https://api.github.com/users/chaodhib/followers","following_url":"https://api.github.com/users/chaodhib/following{/other_user}","gists_url":"https://api.github.com/users/chaodhib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodhib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodhib/subscriptions","organizations_url":"https://api.github.com/users/chaodhib/orgs","repos_url":"https://api.github.com/users/chaodhib/repos","events_url":"https://api.github.com/users/chaodhib/events{/privacy}","received_events_url":"https://api.github.com/users/chaodhib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaodhib/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/chaodhib/TrinityCore","forks_url":"https://api.github.com/repos/chaodhib/TrinityCore/forks","keys_url":"https://api.github.com/repos/chaodhib/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaodhib/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaodhib/TrinityCore/teams","hooks_url":"https://api.github.com/repos/chaodhib/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/chaodhib/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/chaodhib/TrinityCore/events","assignees_url":"https://api.github.com/repos/chaodhib/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/chaodhib/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/chaodhib/TrinityCore/tags","blobs_url":"https://api.github.com/repos/chaodhib/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaodhib/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaodhib/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaodhib/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaodhib/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/chaodhib/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/chaodhib/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/chaodhib/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/chaodhib/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/chaodhib/TrinityCore/subscription","commits_url":"https://api.github.com/repos/chaodhib/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaodhib/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaodhib/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaodhib/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaodhib/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/chaodhib/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaodhib/TrinityCore/merges","archive_url":"https://api.github.com/repos/chaodhib/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaodhib/TrinityCore/downloads","issues_url":"https://api.github.com/repos/chaodhib/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/chaodhib/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/chaodhib/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/chaodhib/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaodhib/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/chaodhib/TrinityCore/releases{/id}","created_at":"2015-03-20T13:44:30Z","updated_at":"2015-06-10T16:16:47Z","pushed_at":"2015-08-28T20:18:38Z","git_url":"git://github.com/chaodhib/TrinityCore.git","ssh_url":"git@github.com:chaodhib/TrinityCore.git","clone_url":"https://github.com/chaodhib/TrinityCore.git","svn_url":"https://github.com/chaodhib/TrinityCore","homepage":"http://www.trinitycore.org","size":305291,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"5c97594a1691b78ab881437985dc5eeebb31a979","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-08-28T17:32:09Z","pushed_at":"2015-08-29T03:13:51Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":855938,"stargazers_count":2941,"watchers_count":2941,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3081,"mirror_url":null,"open_issues_count":1122,"forks":3081,"open_issues":1122,"watchers":2941,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15354"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15354/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15354/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/9394660be2da6ea94e5b2177b3667d1e3bedb19a"}}}}