{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/29961606","id":29961606,"diff_hunk":"@@ -498,6 +499,15 @@ setMethod(\"sampleDF\",\n             dataFrame(sdf)\n           })\n \n+#' @rdname sampleDF\n+#' @alias sampleDF\n+setMethod(\"sample_frac\",\n+          signature(x = \"DataFrame\", withReplacement = \"logical\",\n+                    fraction = \"numeric\"),","path":"R/pkg/R/DataFrame.R","position":16,"original_position":16,"commit_id":"05211490e6e0dec3187131a465f251907cb77562","original_commit_id":"05211490e6e0dec3187131a465f251907cb77562","user":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"body":"Mostly because at one point we were using 80 char line limit for SparkR. The style isnt' fully changed to 100 char. We can do a full cleanup as a part of https://issues.apache.org/jira/browse/SPARK-6813","created_at":"2015-05-08T17:58:22Z","updated_at":"2015-05-08T17:58:22Z","html_url":"https://github.com/apache/spark/pull/6005#discussion_r29961606","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6005","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/29961606"},"html":{"href":"https://github.com/apache/spark/pull/6005#discussion_r29961606"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6005"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6005","id":34986246,"html_url":"https://github.com/apache/spark/pull/6005","diff_url":"https://github.com/apache/spark/pull/6005.diff","patch_url":"https://github.com/apache/spark/pull/6005.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6005","number":6005,"state":"open","locked":false,"title":"[SPARK-7231] [SPARKR] Changes to make SparkR DataFrame dplyr friendly.","user":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"body":"Changes include\r\n1. Rename sortDF to arrange\r\n2. Add new aliases `group_by` and `sample_frac`, `summarize`\r\n3. Add more user friendly column addition (mutate), rename\r\n4. Support mean as an alias for avg in Scala and also support n_distinct, n as in dplyr\r\n\r\nUsing these changes we can pretty much run the examples as described in http://cran.rstudio.com/web/packages/dplyr/vignettes/introduction.html with the same syntax\r\n\r\nThe only thing missing in SparkR is auto resolving column names when used in an expression i.e. making something like `select(flights, delay)` works in dply but we right now need `select(flights, flights$delay)` or `select(flights, \"delay\")`. But this is a complicated change and I'll file a new issue for it\r\n\r\ncc @sun-rui @rxin ","created_at":"2015-05-08T07:30:52Z","updated_at":"2015-05-08T17:58:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a829d5cfc7a8d8ef00154741c69e3562e127f5a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6005/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6005/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6005/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/05211490e6e0dec3187131a465f251907cb77562","head":{"label":"shivaram:sparkr-df-api","ref":"sparkr-df-api","sha":"05211490e6e0dec3187131a465f251907cb77562","user":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"repo":{"id":18046181,"name":"spark-1","full_name":"shivaram/spark-1","owner":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivaram/spark-1","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/shivaram/spark-1","forks_url":"https://api.github.com/repos/shivaram/spark-1/forks","keys_url":"https://api.github.com/repos/shivaram/spark-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivaram/spark-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivaram/spark-1/teams","hooks_url":"https://api.github.com/repos/shivaram/spark-1/hooks","issue_events_url":"https://api.github.com/repos/shivaram/spark-1/issues/events{/number}","events_url":"https://api.github.com/repos/shivaram/spark-1/events","assignees_url":"https://api.github.com/repos/shivaram/spark-1/assignees{/user}","branches_url":"https://api.github.com/repos/shivaram/spark-1/branches{/branch}","tags_url":"https://api.github.com/repos/shivaram/spark-1/tags","blobs_url":"https://api.github.com/repos/shivaram/spark-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivaram/spark-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivaram/spark-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivaram/spark-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivaram/spark-1/statuses/{sha}","languages_url":"https://api.github.com/repos/shivaram/spark-1/languages","stargazers_url":"https://api.github.com/repos/shivaram/spark-1/stargazers","contributors_url":"https://api.github.com/repos/shivaram/spark-1/contributors","subscribers_url":"https://api.github.com/repos/shivaram/spark-1/subscribers","subscription_url":"https://api.github.com/repos/shivaram/spark-1/subscription","commits_url":"https://api.github.com/repos/shivaram/spark-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivaram/spark-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivaram/spark-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivaram/spark-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivaram/spark-1/contents/{+path}","compare_url":"https://api.github.com/repos/shivaram/spark-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivaram/spark-1/merges","archive_url":"https://api.github.com/repos/shivaram/spark-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivaram/spark-1/downloads","issues_url":"https://api.github.com/repos/shivaram/spark-1/issues{/number}","pulls_url":"https://api.github.com/repos/shivaram/spark-1/pulls{/number}","milestones_url":"https://api.github.com/repos/shivaram/spark-1/milestones{/number}","notifications_url":"https://api.github.com/repos/shivaram/spark-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivaram/spark-1/labels{/name}","releases_url":"https://api.github.com/repos/shivaram/spark-1/releases{/id}","created_at":"2014-03-23T23:19:53Z","updated_at":"2014-05-10T02:43:28Z","pushed_at":"2015-05-08T08:08:52Z","git_url":"git://github.com/shivaram/spark-1.git","ssh_url":"git@github.com:shivaram/spark-1.git","clone_url":"https://github.com/shivaram/spark-1.git","svn_url":"https://github.com/shivaram/spark-1","homepage":null,"size":102236,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"pipelines"}},"base":{"label":"apache:master","ref":"master","sha":"f496bf3c539a873ffdf3aa803847ef7b50135bd7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-08T16:13:58Z","pushed_at":"2015-05-08T17:53:30Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1615036,"stargazers_count":3895,"watchers_count":3895,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3414,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":325,"forks":3414,"open_issues":325,"watchers":3895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6005"},"html":{"href":"https://github.com/apache/spark/pull/6005"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6005"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6005/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6005/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6005/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/05211490e6e0dec3187131a465f251907cb77562"}}}}