{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/nodesource/distributions/pulls/22","id":22523962,"html_url":"https://github.com/nodesource/distributions/pull/22","diff_url":"https://github.com/nodesource/distributions/pull/22.diff","patch_url":"https://github.com/nodesource/distributions/pull/22.patch","issue_url":"https://api.github.com/repos/nodesource/distributions/issues/22","number":22,"state":"closed","locked":false,"title":"Move sudo to only where needed to fix proxy issues","user":{"login":"terkiterje","id":4727700,"avatar_url":"https://avatars.githubusercontent.com/u/4727700?v=3","gravatar_id":"","url":"https://api.github.com/users/terkiterje","html_url":"https://github.com/terkiterje","followers_url":"https://api.github.com/users/terkiterje/followers","following_url":"https://api.github.com/users/terkiterje/following{/other_user}","gists_url":"https://api.github.com/users/terkiterje/gists{/gist_id}","starred_url":"https://api.github.com/users/terkiterje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terkiterje/subscriptions","organizations_url":"https://api.github.com/users/terkiterje/orgs","repos_url":"https://api.github.com/users/terkiterje/repos","events_url":"https://api.github.com/users/terkiterje/events{/privacy}","received_events_url":"https://api.github.com/users/terkiterje/received_events","type":"User","site_admin":false},"body":"I propose moving sudo to only those operations that need it rather than the whole script. This fixes being behind a corporate proxy server configured through environment variables which do not survive \"sudo\" without -E option. Additionally, if the curl request fails it is nice to see why (with the -S option), since the error message saying the distribution is not supported is misleading in the event of an network error.","created_at":"2014-10-09T21:09:50Z","updated_at":"2015-07-04T09:52:56Z","closed_at":"2015-07-04T09:52:56Z","merged_at":null,"merge_commit_sha":"8e63e3285da8949b5c4272f11501d6c8eed84fad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodesource/distributions/pulls/22/commits","review_comments_url":"https://api.github.com/repos/nodesource/distributions/pulls/22/comments","review_comment_url":"https://api.github.com/repos/nodesource/distributions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodesource/distributions/issues/22/comments","statuses_url":"https://api.github.com/repos/nodesource/distributions/statuses/3c0d153824e2fa54831db06c3c0f5be09f4278af","head":{"label":"terkiterje:master","ref":"master","sha":"3c0d153824e2fa54831db06c3c0f5be09f4278af","user":{"login":"terkiterje","id":4727700,"avatar_url":"https://avatars.githubusercontent.com/u/4727700?v=3","gravatar_id":"","url":"https://api.github.com/users/terkiterje","html_url":"https://github.com/terkiterje","followers_url":"https://api.github.com/users/terkiterje/followers","following_url":"https://api.github.com/users/terkiterje/following{/other_user}","gists_url":"https://api.github.com/users/terkiterje/gists{/gist_id}","starred_url":"https://api.github.com/users/terkiterje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terkiterje/subscriptions","organizations_url":"https://api.github.com/users/terkiterje/orgs","repos_url":"https://api.github.com/users/terkiterje/repos","events_url":"https://api.github.com/users/terkiterje/events{/privacy}","received_events_url":"https://api.github.com/users/terkiterje/received_events","type":"User","site_admin":false},"repo":{"id":25008081,"name":"distributions","full_name":"terkiterje/distributions","owner":{"login":"terkiterje","id":4727700,"avatar_url":"https://avatars.githubusercontent.com/u/4727700?v=3","gravatar_id":"","url":"https://api.github.com/users/terkiterje","html_url":"https://github.com/terkiterje","followers_url":"https://api.github.com/users/terkiterje/followers","following_url":"https://api.github.com/users/terkiterje/following{/other_user}","gists_url":"https://api.github.com/users/terkiterje/gists{/gist_id}","starred_url":"https://api.github.com/users/terkiterje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terkiterje/subscriptions","organizations_url":"https://api.github.com/users/terkiterje/orgs","repos_url":"https://api.github.com/users/terkiterje/repos","events_url":"https://api.github.com/users/terkiterje/events{/privacy}","received_events_url":"https://api.github.com/users/terkiterje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terkiterje/distributions","description":"NodeSource Node.js Binary Distributions","fork":true,"url":"https://api.github.com/repos/terkiterje/distributions","forks_url":"https://api.github.com/repos/terkiterje/distributions/forks","keys_url":"https://api.github.com/repos/terkiterje/distributions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terkiterje/distributions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terkiterje/distributions/teams","hooks_url":"https://api.github.com/repos/terkiterje/distributions/hooks","issue_events_url":"https://api.github.com/repos/terkiterje/distributions/issues/events{/number}","events_url":"https://api.github.com/repos/terkiterje/distributions/events","assignees_url":"https://api.github.com/repos/terkiterje/distributions/assignees{/user}","branches_url":"https://api.github.com/repos/terkiterje/distributions/branches{/branch}","tags_url":"https://api.github.com/repos/terkiterje/distributions/tags","blobs_url":"https://api.github.com/repos/terkiterje/distributions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terkiterje/distributions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terkiterje/distributions/git/refs{/sha}","trees_url":"https://api.github.com/repos/terkiterje/distributions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terkiterje/distributions/statuses/{sha}","languages_url":"https://api.github.com/repos/terkiterje/distributions/languages","stargazers_url":"https://api.github.com/repos/terkiterje/distributions/stargazers","contributors_url":"https://api.github.com/repos/terkiterje/distributions/contributors","subscribers_url":"https://api.github.com/repos/terkiterje/distributions/subscribers","subscription_url":"https://api.github.com/repos/terkiterje/distributions/subscription","commits_url":"https://api.github.com/repos/terkiterje/distributions/commits{/sha}","git_commits_url":"https://api.github.com/repos/terkiterje/distributions/git/commits{/sha}","comments_url":"https://api.github.com/repos/terkiterje/distributions/comments{/number}","issue_comment_url":"https://api.github.com/repos/terkiterje/distributions/issues/comments{/number}","contents_url":"https://api.github.com/repos/terkiterje/distributions/contents/{+path}","compare_url":"https://api.github.com/repos/terkiterje/distributions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terkiterje/distributions/merges","archive_url":"https://api.github.com/repos/terkiterje/distributions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terkiterje/distributions/downloads","issues_url":"https://api.github.com/repos/terkiterje/distributions/issues{/number}","pulls_url":"https://api.github.com/repos/terkiterje/distributions/pulls{/number}","milestones_url":"https://api.github.com/repos/terkiterje/distributions/milestones{/number}","notifications_url":"https://api.github.com/repos/terkiterje/distributions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terkiterje/distributions/labels{/name}","releases_url":"https://api.github.com/repos/terkiterje/distributions/releases{/id}","created_at":"2014-10-09T20:52:55Z","updated_at":"2014-10-09T20:57:57Z","pushed_at":"2014-10-09T20:57:57Z","git_url":"git://github.com/terkiterje/distributions.git","ssh_url":"git@github.com:terkiterje/distributions.git","clone_url":"https://github.com/terkiterje/distributions.git","svn_url":"https://github.com/terkiterje/distributions","homepage":null,"size":124,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodesource:master","ref":"master","sha":"5170e72c6703f845f5118a6a44b46a4399e372cc","user":{"login":"nodesource","id":6759417,"avatar_url":"https://avatars.githubusercontent.com/u/6759417?v=3","gravatar_id":"","url":"https://api.github.com/users/nodesource","html_url":"https://github.com/nodesource","followers_url":"https://api.github.com/users/nodesource/followers","following_url":"https://api.github.com/users/nodesource/following{/other_user}","gists_url":"https://api.github.com/users/nodesource/gists{/gist_id}","starred_url":"https://api.github.com/users/nodesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodesource/subscriptions","organizations_url":"https://api.github.com/users/nodesource/orgs","repos_url":"https://api.github.com/users/nodesource/repos","events_url":"https://api.github.com/users/nodesource/events{/privacy}","received_events_url":"https://api.github.com/users/nodesource/received_events","type":"Organization","site_admin":false},"repo":{"id":22938893,"name":"distributions","full_name":"nodesource/distributions","owner":{"login":"nodesource","id":6759417,"avatar_url":"https://avatars.githubusercontent.com/u/6759417?v=3","gravatar_id":"","url":"https://api.github.com/users/nodesource","html_url":"https://github.com/nodesource","followers_url":"https://api.github.com/users/nodesource/followers","following_url":"https://api.github.com/users/nodesource/following{/other_user}","gists_url":"https://api.github.com/users/nodesource/gists{/gist_id}","starred_url":"https://api.github.com/users/nodesource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodesource/subscriptions","organizations_url":"https://api.github.com/users/nodesource/orgs","repos_url":"https://api.github.com/users/nodesource/repos","events_url":"https://api.github.com/users/nodesource/events{/privacy}","received_events_url":"https://api.github.com/users/nodesource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodesource/distributions","description":"NodeSource Node.js Binary Distributions","fork":false,"url":"https://api.github.com/repos/nodesource/distributions","forks_url":"https://api.github.com/repos/nodesource/distributions/forks","keys_url":"https://api.github.com/repos/nodesource/distributions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodesource/distributions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodesource/distributions/teams","hooks_url":"https://api.github.com/repos/nodesource/distributions/hooks","issue_events_url":"https://api.github.com/repos/nodesource/distributions/issues/events{/number}","events_url":"https://api.github.com/repos/nodesource/distributions/events","assignees_url":"https://api.github.com/repos/nodesource/distributions/assignees{/user}","branches_url":"https://api.github.com/repos/nodesource/distributions/branches{/branch}","tags_url":"https://api.github.com/repos/nodesource/distributions/tags","blobs_url":"https://api.github.com/repos/nodesource/distributions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodesource/distributions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodesource/distributions/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodesource/distributions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodesource/distributions/statuses/{sha}","languages_url":"https://api.github.com/repos/nodesource/distributions/languages","stargazers_url":"https://api.github.com/repos/nodesource/distributions/stargazers","contributors_url":"https://api.github.com/repos/nodesource/distributions/contributors","subscribers_url":"https://api.github.com/repos/nodesource/distributions/subscribers","subscription_url":"https://api.github.com/repos/nodesource/distributions/subscription","commits_url":"https://api.github.com/repos/nodesource/distributions/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodesource/distributions/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodesource/distributions/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodesource/distributions/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodesource/distributions/contents/{+path}","compare_url":"https://api.github.com/repos/nodesource/distributions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodesource/distributions/merges","archive_url":"https://api.github.com/repos/nodesource/distributions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodesource/distributions/downloads","issues_url":"https://api.github.com/repos/nodesource/distributions/issues{/number}","pulls_url":"https://api.github.com/repos/nodesource/distributions/pulls{/number}","milestones_url":"https://api.github.com/repos/nodesource/distributions/milestones{/number}","notifications_url":"https://api.github.com/repos/nodesource/distributions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodesource/distributions/labels{/name}","releases_url":"https://api.github.com/repos/nodesource/distributions/releases{/id}","created_at":"2014-08-14T02:44:10Z","updated_at":"2015-07-03T22:12:21Z","pushed_at":"2015-07-04T09:51:43Z","git_url":"git://github.com/nodesource/distributions.git","ssh_url":"git@github.com:nodesource/distributions.git","clone_url":"https://github.com/nodesource/distributions.git","svn_url":"https://github.com/nodesource/distributions","homepage":null,"size":490,"stargazers_count":270,"watchers_count":270,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":36,"forks":44,"open_issues":36,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodesource/distributions/pulls/22"},"html":{"href":"https://github.com/nodesource/distributions/pull/22"},"issue":{"href":"https://api.github.com/repos/nodesource/distributions/issues/22"},"comments":{"href":"https://api.github.com/repos/nodesource/distributions/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/nodesource/distributions/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/nodesource/distributions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodesource/distributions/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/nodesource/distributions/statuses/3c0d153824e2fa54831db06c3c0f5be09f4278af"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":11,"deletions":13,"changed_files":2}}