{"action":"closed","number":136,"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/136","id":54676788,"html_url":"https://github.com/uber/tchannel-go/pull/136","diff_url":"https://github.com/uber/tchannel-go/pull/136.diff","patch_url":"https://github.com/uber/tchannel-go/pull/136.patch","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/136","number":136,"state":"closed","locked":false,"title":"Fix flaky TestStreamSendError","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":"Test was seeing \"connection reset by peer\" errors. This occurs when the\r\nremote side sends a RST. The sequence of events that led to this:\r\n\r\n - client sends \"send me an error\" message\r\n - server sends error message, does not close the reader.\r\n - client reads error message\r\n - client then calls \"Close\" on the argWriter, which causes\r\n   callReqContinue to be sent\r\n - test function ends, Closing the server\r\n - server receives the callReqContinue on a now closed TCP connection,\r\n   and sends a RST packet to force close the connection\r\n - client receives an error instead of EOF on the connection\r\n\r\nThe fix is simple: instead of flushing the \"send me an error\" message,\r\ncall Close which flushes the message to the other side.","created_at":"2015-12-28T19:12:39Z","updated_at":"2015-12-28T19:14:53Z","closed_at":"2015-12-28T19:14:53Z","merged_at":"2015-12-28T19:14:53Z","merge_commit_sha":"203cef4b433d87d594cab1e5ef915e8ddc5ab7e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-go/pulls/136/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-go/pulls/136/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/136/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/803789bdc08de65d10045e0180a0e724f1370930","head":{"label":"uber:flaky_test","ref":"flaky_test","sha":"803789bdc08de65d10045e0180a0e724f1370930","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","created_at":"2015-09-18T18:28:15Z","updated_at":"2015-12-25T06:05:44Z","pushed_at":"2015-12-28T19:14:53Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":null,"size":1579,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":44,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"b845bfa23781f1f82cb9d1ffc514a0a527d6996f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","created_at":"2015-09-18T18:28:15Z","updated_at":"2015-12-25T06:05:44Z","pushed_at":"2015-12-28T19:14:53Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":null,"size":1579,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/136"},"html":{"href":"https://github.com/uber/tchannel-go/pull/136"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/136"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-go/statuses/803789bdc08de65d10045e0180a0e724f1370930"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}