{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/37133920","id":37133920,"diff_hunk":"@@ -409,15 +414,20 @@ int ModApiMainMenu::l_get_modstore_list(lua_State *L)\n {\n \tJson::Value mods;\n \tstd::string url = \"\";\n-\ttry{\n+\ttry {\n \t\turl = g_settings->get(\"modstore_listmods_url\");\n-\t}\n-\tcatch(SettingNotFoundException &e) {\n+\t} catch(SettingNotFoundException &e) {","path":"src/script/lua_api/l_mainmenu.cpp","position":23,"original_position":23,"commit_id":"05a0de97e7d518601e4ab432b98259d7cd5fe309","original_commit_id":"05a0de97e7d518601e4ab432b98259d7cd5fe309","user":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"body":"This can use Settings::getNoEx() instead of catching the exception manually.","created_at":"2015-08-15T06:16:12Z","updated_at":"2015-08-15T06:16:12Z","html_url":"https://github.com/minetest/minetest/pull/3058#discussion_r37133920","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3058","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/37133920"},"html":{"href":"https://github.com/minetest/minetest/pull/3058#discussion_r37133920"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3058"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3058","id":42496982,"html_url":"https://github.com/minetest/minetest/pull/3058","diff_url":"https://github.com/minetest/minetest/pull/3058.diff","patch_url":"https://github.com/minetest/minetest/pull/3058.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3058","number":3058,"state":"open","locked":false,"title":"Modstore: show an ui error if retrieving failed","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"Fixes #3042.","created_at":"2015-08-14T20:55:22Z","updated_at":"2015-08-15T06:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d817237eab5995b368c0859310d5d38958f0a1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3058/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3058/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3058/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/05a0de97e7d518601e4ab432b98259d7cd5fe309","head":{"label":"est31:modstore_show_ui_error","ref":"modstore_show_ui_error","sha":"05a0de97e7d518601e4ab432b98259d7cd5fe309","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"repo":{"id":28881630,"name":"minetest","full_name":"est31/minetest","owner":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est31/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also [minetest_game](https://github.com/minetest/minetest_game)]","fork":true,"url":"https://api.github.com/repos/est31/minetest","forks_url":"https://api.github.com/repos/est31/minetest/forks","keys_url":"https://api.github.com/repos/est31/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est31/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est31/minetest/teams","hooks_url":"https://api.github.com/repos/est31/minetest/hooks","issue_events_url":"https://api.github.com/repos/est31/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/est31/minetest/events","assignees_url":"https://api.github.com/repos/est31/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/est31/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/est31/minetest/tags","blobs_url":"https://api.github.com/repos/est31/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est31/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est31/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/est31/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est31/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/est31/minetest/languages","stargazers_url":"https://api.github.com/repos/est31/minetest/stargazers","contributors_url":"https://api.github.com/repos/est31/minetest/contributors","subscribers_url":"https://api.github.com/repos/est31/minetest/subscribers","subscription_url":"https://api.github.com/repos/est31/minetest/subscription","commits_url":"https://api.github.com/repos/est31/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/est31/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/est31/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/est31/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/est31/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/est31/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est31/minetest/merges","archive_url":"https://api.github.com/repos/est31/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est31/minetest/downloads","issues_url":"https://api.github.com/repos/est31/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/est31/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/est31/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/est31/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est31/minetest/labels{/name}","releases_url":"https://api.github.com/repos/est31/minetest/releases{/id}","created_at":"2015-01-06T20:18:47Z","updated_at":"2015-07-31T00:20:40Z","pushed_at":"2015-08-14T21:42:26Z","git_url":"git://github.com/est31/minetest.git","ssh_url":"git@github.com:est31/minetest.git","clone_url":"https://github.com/est31/minetest.git","svn_url":"https://github.com/est31/minetest","homepage":"http://minetest.net/","size":37053,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"25dfd1bbf5cfdcf863e3281f87164915bccc4299","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-08-15T04:57:09Z","pushed_at":"2015-08-14T23:24:04Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":101339,"stargazers_count":1576,"watchers_count":1576,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":524,"mirror_url":null,"open_issues_count":591,"forks":524,"open_issues":591,"watchers":1576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3058"},"html":{"href":"https://github.com/minetest/minetest/pull/3058"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3058"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3058/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3058/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3058/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/05a0de97e7d518601e4ab432b98259d7cd5fe309"}}}}