{"action":"created","comment":{"url":"https://api.github.com/repos/antirez/redis-doc/pulls/comments/26974463","id":26974463,"diff_hunk":"@@ -402,31 +405,66 @@ The following is a list of accepted commands:\n * **SENTINEL masters** Show a list of monitored masters and their state.\n * **SENTINEL master `<master name>`** Show the state and info of the specified master.\n * **SENTINEL slaves `<master name>`** Show a list of slaves for this master, and their state.\n-* **SENTINEL get-master-addr-by-name `<master name>`** Return the ip and port number of the master with that name. If a failover is in progress or terminated successfully for this master it returns the address and port of the promoted slave.\n+* **SENTINEL sentinels `<master name>`** Show a list of sentinels for this master, and their state.\n+* **SENTINEL get-master-addr-by-name `<master name>`** Return the IP and port number of the master with that name. If a failover is in progress or terminated successfully for this master it returns the address and port of the promoted slave.\n * **SENTINEL reset `<pattern>`** This command will reset all the masters with matching name. The pattern argument is a glob-style pattern. The reset process clears any previous state in a master (including a failover in progress), and removes every slave and sentinel already discovered and associated with the master.\n * **SENTINEL failover `<master name>`** Force a failover as if the master was not reachable, and without asking for agreement to other Sentinels (however a new version of the configuration will be published so that the other Sentinels will update their configurations).\n \n-Reconfiguring Sentinel at Runtime\n+Reconfiguring Sentinel at Run-time\n ---\n \n-Starting with Redis version 2.8.4, Sentinel provides an API in order to add, remove, or change the configuration of a given master. Note that if you have multiple sentinels you should apply the changes to all to your instances for Redis Sentinel to work properly. This means that changing the configuration of a single Sentinel does not automatically propagates the changes to the other Sentinels in the network.\n+Starting with Redis version 2.8.4, Sentinel provides an API in order to add, remove, or change the configuration of a given master. Note that if you have multiple sentinels you should apply the changes to all to your instances for Redis Sentinel to work properly. This means that changing the configuration of a single Sentinel does not automatically propagate the changes to the other Sentinels in the network.\n \n The following is a list of `SENTINEL` sub commands used in order to update the configuration of a Sentinel instance.\n \n-* **SENTINEL MONITOR `<name>` `<ip>` `<port>` `<quorum>`** This command tells the Sentinel to start monitoring a new master with the specified name, ip, port, and quorum. It is identical to the `sentinel monitor` configuration directive in `sentinel.conf` configuration file, with the difference that you can't use an hostname in as `ip`, but you need to provide an IPv4 or IPv6 address.\n-* **SENTINEL REMOVE `<name>`** is used in order to remove the specified master: the master will no longer be monitored, and will totally be removed from the internal state of the Sentinel, so it will no longer listed by `SENTINEL masters` and so forth.\n+* **SENTINEL MONITOR `<name>` `<IP>` `<port>` `<quorum>`** This command tells the Sentinel to start monitoring a new master with the specified name, IP, port, and quorum. It is identical to the `sentinel monitor` configuration directive in `sentinel.conf` configuration file, with the difference that you can't use a hostname in as `IP`, but you need to provide an IPv4 or IPv6 address.\n+* **SENTINEL REMOVE `<name>`** is used in order to remove the specified master: the master will no longer be monitored, and will totally be removed from the internal state of the Sentinel, so it will no longer listed by `SENTINEL masters` and so forth. Note that currently, this event is not propagated to the other Sentinels managing the master, thus their info other sentinels will be stale.\n * **SENTINEL SET `<name>` `<option>` `<value>`** The SET command is very similar to the `CONFIG SET` command of Redis, and is used in order to change configuration parameters of a specific master. Multiple option / value pairs can be specified (or none at all). All the configuration parameters that can be configured via `sentinel.conf` are also configurable using the SET command.\n \n The following is an example of `SENTINEL SET` command in order to modify the `down-after-milliseconds` configuration of a master called `objects-cache`:\n \n     SENTINEL SET objects-cache-master down-after-milliseconds 1000\n \n-As already stated, `SENTINEL SET` can be used to set all the configuration parameters that are settable in the startup configuration file. Moreover it is possible to change just the master quorum configuration without removing and re-adding the master with `SENTINEL REMOVE` followed by `SENTINEL MONITOR`, but simply using:\n+As already stated, `SENTINEL SET` can be used to set all the configuration parameters that are settable in the start-up configuration file. Moreover it is possible to change just the master quorum configuration without removing and re-adding the master with `SENTINEL REMOVE` followed by `SENTINEL MONITOR`, but simply using:\n \n     SENTINEL SET objects-cache-master quorum 5\n \n Note that there is no equivalent GET command since `SENTINEL MASTER` provides all the configuration parameters in a simple to parse format (as a field/value pairs array).\n \n+The following is an example of completely using the API to add a master to the\n+sentinel, including the setting of the master's password.\n+\n+\tSENTINEL MONITOR objects-cache-master 192.168.1.101 2\n+    SENTINEL SET objects-cache-master auth-pass mysecretauthstring","path":"topics/sentinel.md","position":147,"original_position":147,"commit_id":"243061e1cd6f356f4c762c206aa972f44e94fab6","original_commit_id":"243061e1cd6f356f4c762c206aa972f44e94fab6","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"body":"indent","created_at":"2015-03-23T20:11:17Z","updated_at":"2015-03-23T20:11:17Z","html_url":"https://github.com/antirez/redis-doc/pull/422#discussion_r26974463","pull_request_url":"https://api.github.com/repos/antirez/redis-doc/pulls/422","_links":{"self":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/comments/26974463"},"html":{"href":"https://github.com/antirez/redis-doc/pull/422#discussion_r26974463"},"pull_request":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/422"}}},"pull_request":{"url":"https://api.github.com/repos/antirez/redis-doc/pulls/422","id":21046700,"html_url":"https://github.com/antirez/redis-doc/pull/422","diff_url":"https://github.com/antirez/redis-doc/pull/422.diff","patch_url":"https://github.com/antirez/redis-doc/pull/422.patch","issue_url":"https://api.github.com/repos/antirez/redis-doc/issues/422","number":422,"state":"open","locked":false,"title":"updating sentinel docs","user":{"login":"TheRealBill","id":467499,"avatar_url":"https://avatars.githubusercontent.com/u/467499?v=3","gravatar_id":"","url":"https://api.github.com/users/TheRealBill","html_url":"https://github.com/TheRealBill","followers_url":"https://api.github.com/users/TheRealBill/followers","following_url":"https://api.github.com/users/TheRealBill/following{/other_user}","gists_url":"https://api.github.com/users/TheRealBill/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealBill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealBill/subscriptions","organizations_url":"https://api.github.com/users/TheRealBill/orgs","repos_url":"https://api.github.com/users/TheRealBill/repos","events_url":"https://api.github.com/users/TheRealBill/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealBill/received_events","type":"User","site_admin":false},"body":"Now it is nice and clean. FIxes #404 ","created_at":"2014-09-10T20:11:34Z","updated_at":"2015-03-23T20:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47f73e82e7aa9573837965649d31a5c531f057fa","assignee":{"login":"soveran","id":951,"avatar_url":"https://avatars.githubusercontent.com/u/951?v=3","gravatar_id":"","url":"https://api.github.com/users/soveran","html_url":"https://github.com/soveran","followers_url":"https://api.github.com/users/soveran/followers","following_url":"https://api.github.com/users/soveran/following{/other_user}","gists_url":"https://api.github.com/users/soveran/gists{/gist_id}","starred_url":"https://api.github.com/users/soveran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soveran/subscriptions","organizations_url":"https://api.github.com/users/soveran/orgs","repos_url":"https://api.github.com/users/soveran/repos","events_url":"https://api.github.com/users/soveran/events{/privacy}","received_events_url":"https://api.github.com/users/soveran/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/antirez/redis-doc/pulls/422/commits","review_comments_url":"https://api.github.com/repos/antirez/redis-doc/pulls/422/comments","review_comment_url":"https://api.github.com/repos/antirez/redis-doc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/antirez/redis-doc/issues/422/comments","statuses_url":"https://api.github.com/repos/antirez/redis-doc/statuses/243061e1cd6f356f4c762c206aa972f44e94fab6","head":{"label":"TheRealBill:update-sentinel-docs","ref":"update-sentinel-docs","sha":"243061e1cd6f356f4c762c206aa972f44e94fab6","user":{"login":"TheRealBill","id":467499,"avatar_url":"https://avatars.githubusercontent.com/u/467499?v=3","gravatar_id":"","url":"https://api.github.com/users/TheRealBill","html_url":"https://github.com/TheRealBill","followers_url":"https://api.github.com/users/TheRealBill/followers","following_url":"https://api.github.com/users/TheRealBill/following{/other_user}","gists_url":"https://api.github.com/users/TheRealBill/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealBill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealBill/subscriptions","organizations_url":"https://api.github.com/users/TheRealBill/orgs","repos_url":"https://api.github.com/users/TheRealBill/repos","events_url":"https://api.github.com/users/TheRealBill/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealBill/received_events","type":"User","site_admin":false},"repo":{"id":23890283,"name":"redis-doc","full_name":"TheRealBill/redis-doc","owner":{"login":"TheRealBill","id":467499,"avatar_url":"https://avatars.githubusercontent.com/u/467499?v=3","gravatar_id":"","url":"https://api.github.com/users/TheRealBill","html_url":"https://github.com/TheRealBill","followers_url":"https://api.github.com/users/TheRealBill/followers","following_url":"https://api.github.com/users/TheRealBill/following{/other_user}","gists_url":"https://api.github.com/users/TheRealBill/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealBill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealBill/subscriptions","organizations_url":"https://api.github.com/users/TheRealBill/orgs","repos_url":"https://api.github.com/users/TheRealBill/repos","events_url":"https://api.github.com/users/TheRealBill/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealBill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheRealBill/redis-doc","description":"Redis documentation source code for markdown and metadata files, conversion scripts, and so forth","fork":true,"url":"https://api.github.com/repos/TheRealBill/redis-doc","forks_url":"https://api.github.com/repos/TheRealBill/redis-doc/forks","keys_url":"https://api.github.com/repos/TheRealBill/redis-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheRealBill/redis-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheRealBill/redis-doc/teams","hooks_url":"https://api.github.com/repos/TheRealBill/redis-doc/hooks","issue_events_url":"https://api.github.com/repos/TheRealBill/redis-doc/issues/events{/number}","events_url":"https://api.github.com/repos/TheRealBill/redis-doc/events","assignees_url":"https://api.github.com/repos/TheRealBill/redis-doc/assignees{/user}","branches_url":"https://api.github.com/repos/TheRealBill/redis-doc/branches{/branch}","tags_url":"https://api.github.com/repos/TheRealBill/redis-doc/tags","blobs_url":"https://api.github.com/repos/TheRealBill/redis-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheRealBill/redis-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheRealBill/redis-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheRealBill/redis-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheRealBill/redis-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/TheRealBill/redis-doc/languages","stargazers_url":"https://api.github.com/repos/TheRealBill/redis-doc/stargazers","contributors_url":"https://api.github.com/repos/TheRealBill/redis-doc/contributors","subscribers_url":"https://api.github.com/repos/TheRealBill/redis-doc/subscribers","subscription_url":"https://api.github.com/repos/TheRealBill/redis-doc/subscription","commits_url":"https://api.github.com/repos/TheRealBill/redis-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheRealBill/redis-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheRealBill/redis-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheRealBill/redis-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheRealBill/redis-doc/contents/{+path}","compare_url":"https://api.github.com/repos/TheRealBill/redis-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheRealBill/redis-doc/merges","archive_url":"https://api.github.com/repos/TheRealBill/redis-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheRealBill/redis-doc/downloads","issues_url":"https://api.github.com/repos/TheRealBill/redis-doc/issues{/number}","pulls_url":"https://api.github.com/repos/TheRealBill/redis-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/TheRealBill/redis-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/TheRealBill/redis-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheRealBill/redis-doc/labels{/name}","releases_url":"https://api.github.com/repos/TheRealBill/redis-doc/releases{/id}","created_at":"2014-09-10T20:08:26Z","updated_at":"2014-09-09T19:21:53Z","pushed_at":"2014-09-10T20:10:39Z","git_url":"git://github.com/TheRealBill/redis-doc.git","ssh_url":"git@github.com:TheRealBill/redis-doc.git","clone_url":"https://github.com/TheRealBill/redis-doc.git","svn_url":"https://github.com/TheRealBill/redis-doc","homepage":"","size":2010,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"antirez:master","ref":"master","sha":"49840c4d3ddc19fb04f7bf620991c5a7d6992cec","user":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"repo":{"id":915844,"name":"redis-doc","full_name":"antirez/redis-doc","owner":{"login":"antirez","id":65632,"avatar_url":"https://avatars.githubusercontent.com/u/65632?v=3","gravatar_id":"","url":"https://api.github.com/users/antirez","html_url":"https://github.com/antirez","followers_url":"https://api.github.com/users/antirez/followers","following_url":"https://api.github.com/users/antirez/following{/other_user}","gists_url":"https://api.github.com/users/antirez/gists{/gist_id}","starred_url":"https://api.github.com/users/antirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antirez/subscriptions","organizations_url":"https://api.github.com/users/antirez/orgs","repos_url":"https://api.github.com/users/antirez/repos","events_url":"https://api.github.com/users/antirez/events{/privacy}","received_events_url":"https://api.github.com/users/antirez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antirez/redis-doc","description":"Redis documentation source code for markdown and metadata files, conversion scripts, and so forth","fork":false,"url":"https://api.github.com/repos/antirez/redis-doc","forks_url":"https://api.github.com/repos/antirez/redis-doc/forks","keys_url":"https://api.github.com/repos/antirez/redis-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antirez/redis-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antirez/redis-doc/teams","hooks_url":"https://api.github.com/repos/antirez/redis-doc/hooks","issue_events_url":"https://api.github.com/repos/antirez/redis-doc/issues/events{/number}","events_url":"https://api.github.com/repos/antirez/redis-doc/events","assignees_url":"https://api.github.com/repos/antirez/redis-doc/assignees{/user}","branches_url":"https://api.github.com/repos/antirez/redis-doc/branches{/branch}","tags_url":"https://api.github.com/repos/antirez/redis-doc/tags","blobs_url":"https://api.github.com/repos/antirez/redis-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antirez/redis-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antirez/redis-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/antirez/redis-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antirez/redis-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/antirez/redis-doc/languages","stargazers_url":"https://api.github.com/repos/antirez/redis-doc/stargazers","contributors_url":"https://api.github.com/repos/antirez/redis-doc/contributors","subscribers_url":"https://api.github.com/repos/antirez/redis-doc/subscribers","subscription_url":"https://api.github.com/repos/antirez/redis-doc/subscription","commits_url":"https://api.github.com/repos/antirez/redis-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/antirez/redis-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/antirez/redis-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/antirez/redis-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/antirez/redis-doc/contents/{+path}","compare_url":"https://api.github.com/repos/antirez/redis-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antirez/redis-doc/merges","archive_url":"https://api.github.com/repos/antirez/redis-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antirez/redis-doc/downloads","issues_url":"https://api.github.com/repos/antirez/redis-doc/issues{/number}","pulls_url":"https://api.github.com/repos/antirez/redis-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/antirez/redis-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/antirez/redis-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antirez/redis-doc/labels{/name}","releases_url":"https://api.github.com/repos/antirez/redis-doc/releases{/id}","created_at":"2010-09-16T15:34:02Z","updated_at":"2015-03-23T20:02:32Z","pushed_at":"2015-03-23T20:02:32Z","git_url":"git://github.com/antirez/redis-doc.git","ssh_url":"git@github.com:antirez/redis-doc.git","clone_url":"https://github.com/antirez/redis-doc.git","svn_url":"https://github.com/antirez/redis-doc","homepage":"","size":6260,"stargazers_count":465,"watchers_count":465,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":420,"mirror_url":null,"open_issues_count":65,"forks":420,"open_issues":65,"watchers":465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/422"},"html":{"href":"https://github.com/antirez/redis-doc/pull/422"},"issue":{"href":"https://api.github.com/repos/antirez/redis-doc/issues/422"},"comments":{"href":"https://api.github.com/repos/antirez/redis-doc/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/antirez/redis-doc/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/antirez/redis-doc/statuses/243061e1cd6f356f4c762c206aa972f44e94fab6"}}}}