{"action":"created","comment":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/45128809","id":45128809,"diff_hunk":"@@ -556,8 +556,8 @@ public function removeMobileUnfriendlyPlugins() {\n         foreach ($this->enabledPlugins() as $PluginName => $Trash) {\n             $PluginInfo = $this->getPluginInfo($PluginName);\n \n-            // Remove plugin hooks from plugins that dont explicitly claim to be friendly with mobile themes\n-            if (!val('MobileFriendly', $PluginInfo)) {\n+            // Remove plugin hooks from plugins that explicitly claim to not be mobile friendly\n+            if (array_key_exists('MobileFriendly', $PluginInfo) && !val('MobileFriendly', $PluginInfo)) {","path":"library/core/class.pluginmanager.php","position":7,"original_position":7,"commit_id":"aa3837725ce8545d49c520ebcb48e34fc71b3f9a","original_commit_id":"aa3837725ce8545d49c520ebcb48e34fc71b3f9a","user":{"login":"tburry","id":97432,"avatar_url":"https://avatars.githubusercontent.com/u/97432?v=3","gravatar_id":"","url":"https://api.github.com/users/tburry","html_url":"https://github.com/tburry","followers_url":"https://api.github.com/users/tburry/followers","following_url":"https://api.github.com/users/tburry/following{/other_user}","gists_url":"https://api.github.com/users/tburry/gists{/gist_id}","starred_url":"https://api.github.com/users/tburry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tburry/subscriptions","organizations_url":"https://api.github.com/users/tburry/orgs","repos_url":"https://api.github.com/users/tburry/repos","events_url":"https://api.github.com/users/tburry/events{/privacy}","received_events_url":"https://api.github.com/users/tburry/received_events","type":"User","site_admin":false},"body":"Use the default parameter of `val()` instead.\r\n\r\n```php\r\nif (!val('MobileFriendly', $PluginInfo, true)) {\r\n```","created_at":"2015-11-17T22:03:52Z","updated_at":"2015-11-17T22:03:52Z","html_url":"https://github.com/vanilla/vanilla/pull/3295#discussion_r45128809","pull_request_url":"https://api.github.com/repos/vanilla/vanilla/pulls/3295","_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/45128809"},"html":{"href":"https://github.com/vanilla/vanilla/pull/3295#discussion_r45128809"},"pull_request":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3295"}}},"pull_request":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/3295","id":50980175,"html_url":"https://github.com/vanilla/vanilla/pull/3295","diff_url":"https://github.com/vanilla/vanilla/pull/3295.diff","patch_url":"https://github.com/vanilla/vanilla/pull/3295.patch","issue_url":"https://api.github.com/repos/vanilla/vanilla/issues/3295","number":3295,"state":"open","locked":false,"title":"Make mobile unfriendly plugins the exception","user":{"login":"beckyvb","id":3805381,"avatar_url":"https://avatars.githubusercontent.com/u/3805381?v=3","gravatar_id":"","url":"https://api.github.com/users/beckyvb","html_url":"https://github.com/beckyvb","followers_url":"https://api.github.com/users/beckyvb/followers","following_url":"https://api.github.com/users/beckyvb/following{/other_user}","gists_url":"https://api.github.com/users/beckyvb/gists{/gist_id}","starred_url":"https://api.github.com/users/beckyvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckyvb/subscriptions","organizations_url":"https://api.github.com/users/beckyvb/orgs","repos_url":"https://api.github.com/users/beckyvb/repos","events_url":"https://api.github.com/users/beckyvb/events{/privacy}","received_events_url":"https://api.github.com/users/beckyvb/received_events","type":"User","site_admin":false},"body":"Changes the way mobile friendliness is determined in a plugin's settings, as MobileFriendly should be the rule, not the exception.\r\nBefore we would need to mark a plugin as 'MobileFriendly' => true for it to work on mobile.\r\nThis pr would make is necessary to mark 'MobileFriendly' => false to disable it on mobile.","created_at":"2015-11-17T17:48:39Z","updated_at":"2015-11-17T22:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34ba0cf60cab3f69fecf4922c9e269156d689d8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vanilla/vanilla/pulls/3295/commits","review_comments_url":"https://api.github.com/repos/vanilla/vanilla/pulls/3295/comments","review_comment_url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanilla/vanilla/issues/3295/comments","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/aa3837725ce8545d49c520ebcb48e34fc71b3f9a","head":{"label":"vanilla:tweak/mobile-friendly-flag","ref":"tweak/mobile-friendly-flag","sha":"aa3837725ce8545d49c520ebcb48e34fc71b3f9a","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","created_at":"2009-06-21T01:41:25Z","updated_at":"2015-11-17T19:28:17Z","pushed_at":"2015-11-17T21:52:52Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"http://vanillaforums.org","size":39028,"stargazers_count":1429,"watchers_count":1429,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":553,"mirror_url":null,"open_issues_count":255,"forks":553,"open_issues":255,"watchers":1429,"default_branch":"master"}},"base":{"label":"vanilla:master","ref":"master","sha":"de3b834977b4cffefbfb3d953e61ed7269203998","user":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"avatar_url":"https://avatars.githubusercontent.com/u/7443552?v=3","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","created_at":"2009-06-21T01:41:25Z","updated_at":"2015-11-17T19:28:17Z","pushed_at":"2015-11-17T21:52:52Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"http://vanillaforums.org","size":39028,"stargazers_count":1429,"watchers_count":1429,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":553,"mirror_url":null,"open_issues_count":255,"forks":553,"open_issues":255,"watchers":1429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3295"},"html":{"href":"https://github.com/vanilla/vanilla/pull/3295"},"issue":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/3295"},"comments":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/3295/comments"},"review_comments":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3295/comments"},"review_comment":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/3295/commits"},"statuses":{"href":"https://api.github.com/repos/vanilla/vanilla/statuses/aa3837725ce8545d49c520ebcb48e34fc71b3f9a"}}}}