{"action":"created","issue":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1822","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1822/labels{/name}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1822/comments","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1822/events","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1822","id":70902523,"number":1822,"title":"Random Battle Refactor: Check for teammate's weather in script","user":{"login":"ascriptmaster","id":6027117,"avatar_url":"https://avatars.githubusercontent.com/u/6027117?v=3","gravatar_id":"","url":"https://api.github.com/users/ascriptmaster","html_url":"https://github.com/ascriptmaster","followers_url":"https://api.github.com/users/ascriptmaster/followers","following_url":"https://api.github.com/users/ascriptmaster/following{/other_user}","gists_url":"https://api.github.com/users/ascriptmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ascriptmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascriptmaster/subscriptions","organizations_url":"https://api.github.com/users/ascriptmaster/orgs","repos_url":"https://api.github.com/users/ascriptmaster/repos","events_url":"https://api.github.com/users/ascriptmaster/events{/privacy}","received_events_url":"https://api.github.com/users/ascriptmaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-25T12:21:52Z","updated_at":"2015-04-25T12:56:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1822","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1822","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1822.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1822.patch"},"body":"Refactor randomSet to accept an object with different arguments in it. For\r\nnow the object tracks weather and the Mega Pokemon count only, but can be\r\nexpanded for Trick Room, etc.\r\n\r\nAdd some checks in randomSet to accomodate the fact that team weather is\r\npresent, as well as some extra rejection guidelines in randomTeam.\r\n\r\n----\r\n\r\nI spent most of the night working on this when I should have been sleeping,\r\nso it definitely needs to be discussed and polished up. This is a very big\r\nchange and definitely could use a lot of improvement. For starters, Pokemon\r\nchosen before the weather is set are unaffected by all the rejection patterns\r\nused after the weather is set (except for Shedinja). Should the rejection for\r\nPokemon/moves under a certain weather be more lenient? Or should we\r\nattempt to re-build previous sets to accommodate the weather?\r\n\r\n@TheImmortal @Joimer @Zarel "},"comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments/96196290","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1822#issuecomment-96196290","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1822","id":96196290,"user":{"login":"Joimer","id":3244216,"avatar_url":"https://avatars.githubusercontent.com/u/3244216?v=3","gravatar_id":"","url":"https://api.github.com/users/Joimer","html_url":"https://github.com/Joimer","followers_url":"https://api.github.com/users/Joimer/followers","following_url":"https://api.github.com/users/Joimer/following{/other_user}","gists_url":"https://api.github.com/users/Joimer/gists{/gist_id}","starred_url":"https://api.github.com/users/Joimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joimer/subscriptions","organizations_url":"https://api.github.com/users/Joimer/orgs","repos_url":"https://api.github.com/users/Joimer/repos","events_url":"https://api.github.com/users/Joimer/events{/privacy}","received_events_url":"https://api.github.com/users/Joimer/received_events","type":"User","site_admin":false},"created_at":"2015-04-25T12:56:27Z","updated_at":"2015-04-25T12:56:27Z","body":"I like this very much, and I think you should attempt to accomodate the current team members with the weather."}}