{"action":"created","comment":{"url":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments/43358600","id":43358600,"diff_hunk":"@@ -36,27 +36,95 @@ function Clock() {\n   this.timerID = null;\n \n   /**\n-   * Start the timer used to refresh the clock, will call the specified\n-   * callback at every timer tick to refresh the UI. The callback used to\n-   * refresh the UI will also be called immediately to ensure the UI is\n-   * consistent.\n+   * Contains time format (12 Hour or 24 Hour)\n+   * @type {string from localization}\n+   */\n+  this.timeFormat = null;\n+\n+  /**\n+   * Dom Object that contains time\n+   * @type {Dom element}\n+   */\n+  this.clockTime = document.getElementById('clock-time');\n+\n+  /**\n+   * This dom object contains date information\n+   * @type {date}\n+   */\n+  this.date = document.getElementById('date');\n+\n+  window.addEventListener('timeformatchange', this);\n+\n+  /**\n+   * Handle the event which fires when time format is chaned\n+   * @param  {object} e [Event object]\n+   */\n+  this.handleEvent = function cl_handleEvents(e){\n+\n+    switch(e.type) {\n+      case 'timeformatchange':\n+        if (!this.l10nready) {\n+          return;\n+        }\n+\n+        this.timeFormat = window.navigator.mozHour12 ?\n+          navigator.mozL10n.get('shortTimeFormat12') :\n+          navigator.mozL10n.get('shortTimeFormat24');\n+        this.refreshClock(new Date());\n+\n+        break;\n+    };\n+\n+  };\n+\n+  /**\n+   * We need to do some refreshing thing after l10n is ready.\n+   *\n+   * @memberof LockScreen","path":"apps/verticalhome/js/clock.js","position":52,"original_position":52,"commit_id":"1b58eae7280f9bc7e3d12199f680743bcab76a0b","original_commit_id":"1b58eae7280f9bc7e3d12199f680743bcab76a0b","user":{"login":"egorlevichev","id":7557901,"avatar_url":"https://avatars.githubusercontent.com/u/7557901?v=3","gravatar_id":"","url":"https://api.github.com/users/egorlevichev","html_url":"https://github.com/egorlevichev","followers_url":"https://api.github.com/users/egorlevichev/followers","following_url":"https://api.github.com/users/egorlevichev/following{/other_user}","gists_url":"https://api.github.com/users/egorlevichev/gists{/gist_id}","starred_url":"https://api.github.com/users/egorlevichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egorlevichev/subscriptions","organizations_url":"https://api.github.com/users/egorlevichev/orgs","repos_url":"https://api.github.com/users/egorlevichev/repos","events_url":"https://api.github.com/users/egorlevichev/events{/privacy}","received_events_url":"https://api.github.com/users/egorlevichev/received_events","type":"User","site_admin":false},"body":"and still LockScreen smell in your commit. BTW why for this particular function you specified '@memberof' tag, and for others no? Probably it'll be better to align documentation either delete here, or add for remaining functions.","created_at":"2015-10-29T08:13:53Z","updated_at":"2015-10-29T08:13:53Z","html_url":"https://github.com/harman-red-square/gaia/pull/15#discussion_r43358600","pull_request_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments/43358600"},"html":{"href":"https://github.com/harman-red-square/gaia/pull/15#discussion_r43358600"},"pull_request":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/harman-red-square/gaia/pulls/15","id":49003276,"html_url":"https://github.com/harman-red-square/gaia/pull/15","diff_url":"https://github.com/harman-red-square/gaia/pull/15.diff","patch_url":"https://github.com/harman-red-square/gaia/pull/15.patch","issue_url":"https://api.github.com/repos/harman-red-square/gaia/issues/15","number":15,"state":"open","locked":false,"title":"Bug 1210304 - David's comments related to clock were fixed..","user":{"login":"ruvsmirnov","id":14997339,"avatar_url":"https://avatars.githubusercontent.com/u/14997339?v=3","gravatar_id":"","url":"https://api.github.com/users/ruvsmirnov","html_url":"https://github.com/ruvsmirnov","followers_url":"https://api.github.com/users/ruvsmirnov/followers","following_url":"https://api.github.com/users/ruvsmirnov/following{/other_user}","gists_url":"https://api.github.com/users/ruvsmirnov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruvsmirnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruvsmirnov/subscriptions","organizations_url":"https://api.github.com/users/ruvsmirnov/orgs","repos_url":"https://api.github.com/users/ruvsmirnov/repos","events_url":"https://api.github.com/users/ruvsmirnov/events{/privacy}","received_events_url":"https://api.github.com/users/ruvsmirnov/received_events","type":"User","site_admin":false},"body":"Clock functionality was transfered (installing localization and handling timeformatchange event) from \"app.js\" file to \"clock.js\" file.","created_at":"2015-10-28T13:11:43Z","updated_at":"2015-10-29T08:13:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"add11a7b3d648a6c89946ca56930fef174b72599","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/15/commits","review_comments_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/15/comments","review_comment_url":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harman-red-square/gaia/issues/15/comments","statuses_url":"https://api.github.com/repos/harman-red-square/gaia/statuses/1b58eae7280f9bc7e3d12199f680743bcab76a0b","head":{"label":"ruvsmirnov:homescreen-clock","ref":"homescreen-clock","sha":"1b58eae7280f9bc7e3d12199f680743bcab76a0b","user":{"login":"ruvsmirnov","id":14997339,"avatar_url":"https://avatars.githubusercontent.com/u/14997339?v=3","gravatar_id":"","url":"https://api.github.com/users/ruvsmirnov","html_url":"https://github.com/ruvsmirnov","followers_url":"https://api.github.com/users/ruvsmirnov/followers","following_url":"https://api.github.com/users/ruvsmirnov/following{/other_user}","gists_url":"https://api.github.com/users/ruvsmirnov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruvsmirnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruvsmirnov/subscriptions","organizations_url":"https://api.github.com/users/ruvsmirnov/orgs","repos_url":"https://api.github.com/users/ruvsmirnov/repos","events_url":"https://api.github.com/users/ruvsmirnov/events{/privacy}","received_events_url":"https://api.github.com/users/ruvsmirnov/received_events","type":"User","site_admin":false},"repo":{"id":43955023,"name":"gaia","full_name":"ruvsmirnov/gaia","owner":{"login":"ruvsmirnov","id":14997339,"avatar_url":"https://avatars.githubusercontent.com/u/14997339?v=3","gravatar_id":"","url":"https://api.github.com/users/ruvsmirnov","html_url":"https://github.com/ruvsmirnov","followers_url":"https://api.github.com/users/ruvsmirnov/followers","following_url":"https://api.github.com/users/ruvsmirnov/following{/other_user}","gists_url":"https://api.github.com/users/ruvsmirnov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruvsmirnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruvsmirnov/subscriptions","organizations_url":"https://api.github.com/users/ruvsmirnov/orgs","repos_url":"https://api.github.com/users/ruvsmirnov/repos","events_url":"https://api.github.com/users/ruvsmirnov/events{/privacy}","received_events_url":"https://api.github.com/users/ruvsmirnov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruvsmirnov/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/ruvsmirnov/gaia","forks_url":"https://api.github.com/repos/ruvsmirnov/gaia/forks","keys_url":"https://api.github.com/repos/ruvsmirnov/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruvsmirnov/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruvsmirnov/gaia/teams","hooks_url":"https://api.github.com/repos/ruvsmirnov/gaia/hooks","issue_events_url":"https://api.github.com/repos/ruvsmirnov/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/ruvsmirnov/gaia/events","assignees_url":"https://api.github.com/repos/ruvsmirnov/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/ruvsmirnov/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/ruvsmirnov/gaia/tags","blobs_url":"https://api.github.com/repos/ruvsmirnov/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruvsmirnov/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruvsmirnov/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruvsmirnov/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruvsmirnov/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/ruvsmirnov/gaia/languages","stargazers_url":"https://api.github.com/repos/ruvsmirnov/gaia/stargazers","contributors_url":"https://api.github.com/repos/ruvsmirnov/gaia/contributors","subscribers_url":"https://api.github.com/repos/ruvsmirnov/gaia/subscribers","subscription_url":"https://api.github.com/repos/ruvsmirnov/gaia/subscription","commits_url":"https://api.github.com/repos/ruvsmirnov/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruvsmirnov/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruvsmirnov/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruvsmirnov/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruvsmirnov/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/ruvsmirnov/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruvsmirnov/gaia/merges","archive_url":"https://api.github.com/repos/ruvsmirnov/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruvsmirnov/gaia/downloads","issues_url":"https://api.github.com/repos/ruvsmirnov/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/ruvsmirnov/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/ruvsmirnov/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/ruvsmirnov/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruvsmirnov/gaia/labels{/name}","releases_url":"https://api.github.com/repos/ruvsmirnov/gaia/releases{/id}","created_at":"2015-10-09T12:49:26Z","updated_at":"2015-10-09T12:50:35Z","pushed_at":"2015-10-29T08:00:53Z","git_url":"git://github.com/ruvsmirnov/gaia.git","ssh_url":"git@github.com:ruvsmirnov/gaia.git","clone_url":"https://github.com/ruvsmirnov/gaia.git","svn_url":"https://github.com/ruvsmirnov/gaia","homepage":"https://wiki.mozilla.org/B2G","size":962727,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v2.2r"}},"base":{"label":"harman-red-square:bug-1210304-homescreen","ref":"bug-1210304-homescreen","sha":"06a972ade922cb6b51a8a37721cbb21201f7f80e","user":{"login":"harman-red-square","id":14936980,"avatar_url":"https://avatars.githubusercontent.com/u/14936980?v=3","gravatar_id":"","url":"https://api.github.com/users/harman-red-square","html_url":"https://github.com/harman-red-square","followers_url":"https://api.github.com/users/harman-red-square/followers","following_url":"https://api.github.com/users/harman-red-square/following{/other_user}","gists_url":"https://api.github.com/users/harman-red-square/gists{/gist_id}","starred_url":"https://api.github.com/users/harman-red-square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harman-red-square/subscriptions","organizations_url":"https://api.github.com/users/harman-red-square/orgs","repos_url":"https://api.github.com/users/harman-red-square/repos","events_url":"https://api.github.com/users/harman-red-square/events{/privacy}","received_events_url":"https://api.github.com/users/harman-red-square/received_events","type":"Organization","site_admin":false},"repo":{"id":43541057,"name":"gaia","full_name":"harman-red-square/gaia","owner":{"login":"harman-red-square","id":14936980,"avatar_url":"https://avatars.githubusercontent.com/u/14936980?v=3","gravatar_id":"","url":"https://api.github.com/users/harman-red-square","html_url":"https://github.com/harman-red-square","followers_url":"https://api.github.com/users/harman-red-square/followers","following_url":"https://api.github.com/users/harman-red-square/following{/other_user}","gists_url":"https://api.github.com/users/harman-red-square/gists{/gist_id}","starred_url":"https://api.github.com/users/harman-red-square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harman-red-square/subscriptions","organizations_url":"https://api.github.com/users/harman-red-square/orgs","repos_url":"https://api.github.com/users/harman-red-square/repos","events_url":"https://api.github.com/users/harman-red-square/events{/privacy}","received_events_url":"https://api.github.com/users/harman-red-square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harman-red-square/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/harman-red-square/gaia","forks_url":"https://api.github.com/repos/harman-red-square/gaia/forks","keys_url":"https://api.github.com/repos/harman-red-square/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harman-red-square/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harman-red-square/gaia/teams","hooks_url":"https://api.github.com/repos/harman-red-square/gaia/hooks","issue_events_url":"https://api.github.com/repos/harman-red-square/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/harman-red-square/gaia/events","assignees_url":"https://api.github.com/repos/harman-red-square/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/harman-red-square/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/harman-red-square/gaia/tags","blobs_url":"https://api.github.com/repos/harman-red-square/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harman-red-square/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harman-red-square/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/harman-red-square/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harman-red-square/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/harman-red-square/gaia/languages","stargazers_url":"https://api.github.com/repos/harman-red-square/gaia/stargazers","contributors_url":"https://api.github.com/repos/harman-red-square/gaia/contributors","subscribers_url":"https://api.github.com/repos/harman-red-square/gaia/subscribers","subscription_url":"https://api.github.com/repos/harman-red-square/gaia/subscription","commits_url":"https://api.github.com/repos/harman-red-square/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/harman-red-square/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/harman-red-square/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/harman-red-square/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/harman-red-square/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/harman-red-square/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harman-red-square/gaia/merges","archive_url":"https://api.github.com/repos/harman-red-square/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harman-red-square/gaia/downloads","issues_url":"https://api.github.com/repos/harman-red-square/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/harman-red-square/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/harman-red-square/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/harman-red-square/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harman-red-square/gaia/labels{/name}","releases_url":"https://api.github.com/repos/harman-red-square/gaia/releases{/id}","created_at":"2015-10-02T07:40:12Z","updated_at":"2015-10-06T11:18:30Z","pushed_at":"2015-10-29T08:00:55Z","git_url":"git://github.com/harman-red-square/gaia.git","ssh_url":"git@github.com:harman-red-square/gaia.git","clone_url":"https://github.com/harman-red-square/gaia.git","svn_url":"https://github.com/harman-red-square/gaia","homepage":"https://wiki.mozilla.org/B2G","size":963263,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":3,"forks":27,"open_issues":3,"watchers":0,"default_branch":"v2.2r"}},"_links":{"self":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/15"},"html":{"href":"https://github.com/harman-red-square/gaia/pull/15"},"issue":{"href":"https://api.github.com/repos/harman-red-square/gaia/issues/15"},"comments":{"href":"https://api.github.com/repos/harman-red-square/gaia/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harman-red-square/gaia/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/harman-red-square/gaia/statuses/1b58eae7280f9bc7e3d12199f680743bcab76a0b"}}}}