{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/comments/48564863","id":48564863,"diff_hunk":"@@ -153,6 +153,13 @@ protected IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures,\n                 ? GetResourceNamesFromCultureHierarchy(culture)\n                 : GetResourceNamesForCulture(culture);\n \n+            if (resourceNames == null && !includeParentCultures)\n+            {\n+                var resourceStreamName = GetResourceStreamName(culture);\n+                throw new MissingManifestResourceException(\n+                            string.Format(Resources.Localization_MissingManifest, resourceStreamName));","path":"src/Microsoft.Extensions.Localization/ResourceManagerStringLocalizer.cs","position":8,"original_position":8,"commit_id":"7e803f6dce8eab8bbeb17c63d83e7fb18676fe9f","original_commit_id":"7e803f6dce8eab8bbeb17c63d83e7fb18676fe9f","user":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars.githubusercontent.com/u/174281?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"body":"Nope. Run `build resx` and it should be generated.","created_at":"2015-12-29T19:45:18Z","updated_at":"2015-12-29T19:45:18Z","html_url":"https://github.com/aspnet/Localization/pull/184#discussion_r48564863","pull_request_url":"https://api.github.com/repos/aspnet/Localization/pulls/184","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments/48564863"},"html":{"href":"https://github.com/aspnet/Localization/pull/184#discussion_r48564863"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/184"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Localization/pulls/184","id":54298422,"html_url":"https://github.com/aspnet/Localization/pull/184","diff_url":"https://github.com/aspnet/Localization/pull/184.diff","patch_url":"https://github.com/aspnet/Localization/pull/184.patch","issue_url":"https://api.github.com/repos/aspnet/Localization/issues/184","number":184,"state":"open","locked":false,"title":"Throw proper exception when missing resource","user":{"login":"ryanbrandenburg","id":14987221,"avatar_url":"https://avatars.githubusercontent.com/u/14987221?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrandenburg","html_url":"https://github.com/ryanbrandenburg","followers_url":"https://api.github.com/users/ryanbrandenburg/followers","following_url":"https://api.github.com/users/ryanbrandenburg/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrandenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrandenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrandenburg/subscriptions","organizations_url":"https://api.github.com/users/ryanbrandenburg/orgs","repos_url":"https://api.github.com/users/ryanbrandenburg/repos","events_url":"https://api.github.com/users/ryanbrandenburg/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrandenburg/received_events","type":"User","site_admin":false},"body":"Fixes #143 ","created_at":"2015-12-21T20:20:44Z","updated_at":"2015-12-29T19:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25ebeb5209dd10daeb39f75832e3eed4e7318f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Localization/pulls/184/commits","review_comments_url":"https://api.github.com/repos/aspnet/Localization/pulls/184/comments","review_comment_url":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Localization/issues/184/comments","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/7e803f6dce8eab8bbeb17c63d83e7fb18676fe9f","head":{"label":"aspnet:rybrande/GetAllStringsNull","ref":"rybrande/GetAllStringsNull","sha":"7e803f6dce8eab8bbeb17c63d83e7fb18676fe9f","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35138798,"name":"Localization","full_name":"aspnet/Localization","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":false,"url":"https://api.github.com/repos/aspnet/Localization","forks_url":"https://api.github.com/repos/aspnet/Localization/forks","keys_url":"https://api.github.com/repos/aspnet/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Localization/teams","hooks_url":"https://api.github.com/repos/aspnet/Localization/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Localization/events","assignees_url":"https://api.github.com/repos/aspnet/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Localization/tags","blobs_url":"https://api.github.com/repos/aspnet/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Localization/languages","stargazers_url":"https://api.github.com/repos/aspnet/Localization/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Localization/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Localization/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Localization/subscription","commits_url":"https://api.github.com/repos/aspnet/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Localization/merges","archive_url":"https://api.github.com/repos/aspnet/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Localization/downloads","issues_url":"https://api.github.com/repos/aspnet/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Localization/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Localization/releases{/id}","created_at":"2015-05-06T04:07:17Z","updated_at":"2015-12-25T05:23:17Z","pushed_at":"2015-12-29T18:00:14Z","git_url":"git://github.com/aspnet/Localization.git","ssh_url":"git@github.com:aspnet/Localization.git","clone_url":"https://github.com/aspnet/Localization.git","svn_url":"https://github.com/aspnet/Localization","homepage":null,"size":595,"stargazers_count":31,"watchers_count":31,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":31,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"2ce31c5122498b2a7941ab01c4156ff1ed7c9f4a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35138798,"name":"Localization","full_name":"aspnet/Localization","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Localization","description":"Interfaces and implementations for providing localization in applications. ","fork":false,"url":"https://api.github.com/repos/aspnet/Localization","forks_url":"https://api.github.com/repos/aspnet/Localization/forks","keys_url":"https://api.github.com/repos/aspnet/Localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Localization/teams","hooks_url":"https://api.github.com/repos/aspnet/Localization/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Localization/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Localization/events","assignees_url":"https://api.github.com/repos/aspnet/Localization/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Localization/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Localization/tags","blobs_url":"https://api.github.com/repos/aspnet/Localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Localization/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Localization/languages","stargazers_url":"https://api.github.com/repos/aspnet/Localization/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Localization/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Localization/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Localization/subscription","commits_url":"https://api.github.com/repos/aspnet/Localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Localization/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Localization/merges","archive_url":"https://api.github.com/repos/aspnet/Localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Localization/downloads","issues_url":"https://api.github.com/repos/aspnet/Localization/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Localization/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Localization/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Localization/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Localization/releases{/id}","created_at":"2015-05-06T04:07:17Z","updated_at":"2015-12-25T05:23:17Z","pushed_at":"2015-12-29T18:00:14Z","git_url":"git://github.com/aspnet/Localization.git","ssh_url":"git@github.com:aspnet/Localization.git","clone_url":"https://github.com/aspnet/Localization.git","svn_url":"https://github.com/aspnet/Localization","homepage":null,"size":595,"stargazers_count":31,"watchers_count":31,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":31,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/184"},"html":{"href":"https://github.com/aspnet/Localization/pull/184"},"issue":{"href":"https://api.github.com/repos/aspnet/Localization/issues/184"},"comments":{"href":"https://api.github.com/repos/aspnet/Localization/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Localization/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Localization/statuses/7e803f6dce8eab8bbeb17c63d83e7fb18676fe9f"}}}}