{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/308","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/308/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/308/events","html_url":"https://github.com/vufind-org/vufind/pull/308","id":58558353,"number":308,"title":"refactoring of the shibboleth authentification and authorization","user":{"login":"jochen-lienhard","id":7045910,"avatar_url":"https://avatars.githubusercontent.com/u/7045910?v=3","gravatar_id":"","url":"https://api.github.com/users/jochen-lienhard","html_url":"https://github.com/jochen-lienhard","followers_url":"https://api.github.com/users/jochen-lienhard/followers","following_url":"https://api.github.com/users/jochen-lienhard/following{/other_user}","gists_url":"https://api.github.com/users/jochen-lienhard/gists{/gist_id}","starred_url":"https://api.github.com/users/jochen-lienhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochen-lienhard/subscriptions","organizations_url":"https://api.github.com/users/jochen-lienhard/orgs","repos_url":"https://api.github.com/users/jochen-lienhard/repos","events_url":"https://api.github.com/users/jochen-lienhard/events{/privacy}","received_events_url":"https://api.github.com/users/jochen-lienhard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-02-23T08:49:21Z","updated_at":"2015-03-11T12:41:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/308","html_url":"https://github.com/vufind-org/vufind/pull/308","diff_url":"https://github.com/vufind-org/vufind/pull/308.diff","patch_url":"https://github.com/vufind-org/vufind/pull/308.patch"},"body":"follow up PR 209 ... contains only the shibboleth part"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/78255277","html_url":"https://github.com/vufind-org/vufind/pull/308#issuecomment-78255277","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/308","id":78255277,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T12:41:38Z","updated_at":"2015-03-11T12:41:38Z","body":"1.) Do you mind updating config.ini so we don't forget about this? (Or, if you prefer, you can give me write access to this branch -- assuming I don't already have it -- and I can take care of it).\r\n\r\n2/5/7.) Thanks!\r\n\r\n6.) I agree that it's possible people might want to restrict the other tabs... that's why I think it might make sense to update the AbstractBase::isVisible with the new logic you've added to the staff view tabs, rather than only implementing it in the subclasses. That way, anyone can simply add a line to a constructor in another tab and get the behavior.\r\n\r\nI'll await hearing more from you about the still-outstanding issues before proceeding on this end. Thanks again!"}}