{"action":"opened","issue":{"url":"https://api.github.com/repos/takluyver/terminado/issues/18","labels_url":"https://api.github.com/repos/takluyver/terminado/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/takluyver/terminado/issues/18/comments","events_url":"https://api.github.com/repos/takluyver/terminado/issues/18/events","html_url":"https://github.com/takluyver/terminado/issues/18","id":95621075,"number":18,"title":"TermSocket variable `_log` conflicts with `tornado.RequestHandler._log`","user":{"login":"mgmarino","id":124705,"avatar_url":"https://avatars.githubusercontent.com/u/124705?v=3","gravatar_id":"","url":"https://api.github.com/users/mgmarino","html_url":"https://github.com/mgmarino","followers_url":"https://api.github.com/users/mgmarino/followers","following_url":"https://api.github.com/users/mgmarino/following{/other_user}","gists_url":"https://api.github.com/users/mgmarino/gists{/gist_id}","starred_url":"https://api.github.com/users/mgmarino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgmarino/subscriptions","organizations_url":"https://api.github.com/users/mgmarino/orgs","repos_url":"https://api.github.com/users/mgmarino/repos","events_url":"https://api.github.com/users/mgmarino/events{/privacy}","received_events_url":"https://api.github.com/users/mgmarino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-17T09:24:02Z","updated_at":"2015-07-17T09:24:02Z","closed_at":null,"body":"I am using `tornado` version 4.2 and `terminado` 0.5.  \r\n\r\n`TermSocket` defines the variable `_log` [defined here](https://github.com/takluyver/terminado/blob/master/terminado/websocket.py#L57) which conflicts with `tornado.RequestHandler._log` [defined here](https://github.com/tornadoweb/tornado/blob/master/tornado/web.py#L1438).\r\n\r\nThis causes an error for example when a class derived from TermSocket throws an exception in `get`, e.g.:\r\n\r\n```python\r\nclass TermSocket(terminado.TermSocket):\r\n    def get(self, *args, **kwargs):\r\n        throw web.HTTPError(404)\r\n```\r\n\r\nStack trace:\r\n\r\n```python\r\nERROR:tornado.application:Exception in exception handler\r\nTraceback (most recent call last):\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/web.py\", line 1422, in _execute\r\n    self._handle_request_exception(e)\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/web.py\", line 1476, in _handle_request_exception\r\n    self.send_error(500, exc_info=sys.exc_info())\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/websocket.py\", line 371, in send_error\r\n    super(WebSocketHandler, self).send_error(*args, **kwargs)\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/web.py\", line 980, in send_error\r\n    self.finish()\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/websocket.py\", line 389, in _disallow_for_websocket\r\n    method(self, *args, **kwargs)\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/tornado/web.py\", line 936, in finish\r\n    self._log()\r\nTypeError: 'Logger' object is not callable\r\n```\r\n\r\nIt is noted in the `tornado` code that this function is 'somewhat' deprecated.  Probably the simplest solution since `_log` is only used locally is to change the name."}}