{"action":"created","comment":{"url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/comments/39576285","id":39576285,"diff_hunk":"@@ -1,4 +1,15 @@\n-(function ($) {\n+(function (factory) {\n+    if (typeof define === 'function' && define.amd) {\n+        // AMD\n+        define(['jquery'], factory);\n+    } else if (typeof exports === 'object') {\n+        // CommonJS\n+        module.exports = factory;","path":"jquery.countTo.js","position":8,"original_position":8,"commit_id":"0df0980d4485021e024d404490db1577f5308f80","original_commit_id":"0df0980d4485021e024d404490db1577f5308f80","user":{"login":"mhuggins","id":169093,"avatar_url":"https://avatars.githubusercontent.com/u/169093?v=3","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"body":"I don't have the free time to do that at the moment unfortunately. :)  I've used this pattern in other libraries, and it works great.  I'm okay with shipping it like this.  If there's an issue in, let's say AMD, well AMD wasn't even supported before, so nothing's broken. :)","created_at":"2015-09-15T22:54:48Z","updated_at":"2015-09-15T22:54:48Z","html_url":"https://github.com/mhuggins/jquery-countTo/pull/49#discussion_r39576285","pull_request_url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/comments/39576285"},"html":{"href":"https://github.com/mhuggins/jquery-countTo/pull/49#discussion_r39576285"},"pull_request":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49","id":45106886,"html_url":"https://github.com/mhuggins/jquery-countTo/pull/49","diff_url":"https://github.com/mhuggins/jquery-countTo/pull/49.diff","patch_url":"https://github.com/mhuggins/jquery-countTo/pull/49.patch","issue_url":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/49","number":49,"state":"open","locked":false,"title":"Added UMD definition. Made tests pass.","user":{"login":"whoacowboy","id":8116953,"avatar_url":"https://avatars.githubusercontent.com/u/8116953?v=3","gravatar_id":"","url":"https://api.github.com/users/whoacowboy","html_url":"https://github.com/whoacowboy","followers_url":"https://api.github.com/users/whoacowboy/followers","following_url":"https://api.github.com/users/whoacowboy/following{/other_user}","gists_url":"https://api.github.com/users/whoacowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/whoacowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoacowboy/subscriptions","organizations_url":"https://api.github.com/users/whoacowboy/orgs","repos_url":"https://api.github.com/users/whoacowboy/repos","events_url":"https://api.github.com/users/whoacowboy/events{/privacy}","received_events_url":"https://api.github.com/users/whoacowboy/received_events","type":"User","site_admin":false},"body":"I have been using this with requirejs and needed to make it compatible.\r\n\r\nhttps://github.com/umdjs/umd/blob/master/jqueryPlugin.js\r\n\r\nhttps://github.com/umdjs/umd\r\n\r\n The tests weren't working so i \"fixed\" them. You might want to make sure the tests test what you expect to test.","created_at":"2015-09-15T21:48:12Z","updated_at":"2015-09-15T22:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb296a4d981828e9b2b096ddd779e2807fd90d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49/commits","review_comments_url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49/comments","review_comment_url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/49/comments","statuses_url":"https://api.github.com/repos/mhuggins/jquery-countTo/statuses/0df0980d4485021e024d404490db1577f5308f80","head":{"label":"whoacowboy:master","ref":"master","sha":"0df0980d4485021e024d404490db1577f5308f80","user":{"login":"whoacowboy","id":8116953,"avatar_url":"https://avatars.githubusercontent.com/u/8116953?v=3","gravatar_id":"","url":"https://api.github.com/users/whoacowboy","html_url":"https://github.com/whoacowboy","followers_url":"https://api.github.com/users/whoacowboy/followers","following_url":"https://api.github.com/users/whoacowboy/following{/other_user}","gists_url":"https://api.github.com/users/whoacowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/whoacowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoacowboy/subscriptions","organizations_url":"https://api.github.com/users/whoacowboy/orgs","repos_url":"https://api.github.com/users/whoacowboy/repos","events_url":"https://api.github.com/users/whoacowboy/events{/privacy}","received_events_url":"https://api.github.com/users/whoacowboy/received_events","type":"User","site_admin":false},"repo":{"id":42546667,"name":"jquery-countTo","full_name":"whoacowboy/jquery-countTo","owner":{"login":"whoacowboy","id":8116953,"avatar_url":"https://avatars.githubusercontent.com/u/8116953?v=3","gravatar_id":"","url":"https://api.github.com/users/whoacowboy","html_url":"https://github.com/whoacowboy","followers_url":"https://api.github.com/users/whoacowboy/followers","following_url":"https://api.github.com/users/whoacowboy/following{/other_user}","gists_url":"https://api.github.com/users/whoacowboy/gists{/gist_id}","starred_url":"https://api.github.com/users/whoacowboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoacowboy/subscriptions","organizations_url":"https://api.github.com/users/whoacowboy/orgs","repos_url":"https://api.github.com/users/whoacowboy/repos","events_url":"https://api.github.com/users/whoacowboy/events{/privacy}","received_events_url":"https://api.github.com/users/whoacowboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whoacowboy/jquery-countTo","description":"A jQuery plugin that will count up (or down) to a target number at a specified speed.","fork":true,"url":"https://api.github.com/repos/whoacowboy/jquery-countTo","forks_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/forks","keys_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/teams","hooks_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/hooks","issue_events_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/issues/events{/number}","events_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/events","assignees_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/assignees{/user}","branches_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/branches{/branch}","tags_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/tags","blobs_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/git/refs{/sha}","trees_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/statuses/{sha}","languages_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/languages","stargazers_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/stargazers","contributors_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/contributors","subscribers_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/subscribers","subscription_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/subscription","commits_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/commits{/sha}","git_commits_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/git/commits{/sha}","comments_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/comments{/number}","issue_comment_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/issues/comments{/number}","contents_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/contents/{+path}","compare_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/merges","archive_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/downloads","issues_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/issues{/number}","pulls_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/pulls{/number}","milestones_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/milestones{/number}","notifications_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/labels{/name}","releases_url":"https://api.github.com/repos/whoacowboy/jquery-countTo/releases{/id}","created_at":"2015-09-15T21:07:50Z","updated_at":"2015-09-15T21:07:51Z","pushed_at":"2015-09-15T21:45:29Z","git_url":"git://github.com/whoacowboy/jquery-countTo.git","ssh_url":"git@github.com:whoacowboy/jquery-countTo.git","clone_url":"https://github.com/whoacowboy/jquery-countTo.git","svn_url":"https://github.com/whoacowboy/jquery-countTo","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mhuggins:master","ref":"master","sha":"86e2a63d849388843b2c16e16f89e14b90da5506","user":{"login":"mhuggins","id":169093,"avatar_url":"https://avatars.githubusercontent.com/u/169093?v=3","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"repo":{"id":4178521,"name":"jquery-countTo","full_name":"mhuggins/jquery-countTo","owner":{"login":"mhuggins","id":169093,"avatar_url":"https://avatars.githubusercontent.com/u/169093?v=3","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhuggins/jquery-countTo","description":"A jQuery plugin that will count up (or down) to a target number at a specified speed.","fork":false,"url":"https://api.github.com/repos/mhuggins/jquery-countTo","forks_url":"https://api.github.com/repos/mhuggins/jquery-countTo/forks","keys_url":"https://api.github.com/repos/mhuggins/jquery-countTo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhuggins/jquery-countTo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhuggins/jquery-countTo/teams","hooks_url":"https://api.github.com/repos/mhuggins/jquery-countTo/hooks","issue_events_url":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/events{/number}","events_url":"https://api.github.com/repos/mhuggins/jquery-countTo/events","assignees_url":"https://api.github.com/repos/mhuggins/jquery-countTo/assignees{/user}","branches_url":"https://api.github.com/repos/mhuggins/jquery-countTo/branches{/branch}","tags_url":"https://api.github.com/repos/mhuggins/jquery-countTo/tags","blobs_url":"https://api.github.com/repos/mhuggins/jquery-countTo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhuggins/jquery-countTo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhuggins/jquery-countTo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhuggins/jquery-countTo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhuggins/jquery-countTo/statuses/{sha}","languages_url":"https://api.github.com/repos/mhuggins/jquery-countTo/languages","stargazers_url":"https://api.github.com/repos/mhuggins/jquery-countTo/stargazers","contributors_url":"https://api.github.com/repos/mhuggins/jquery-countTo/contributors","subscribers_url":"https://api.github.com/repos/mhuggins/jquery-countTo/subscribers","subscription_url":"https://api.github.com/repos/mhuggins/jquery-countTo/subscription","commits_url":"https://api.github.com/repos/mhuggins/jquery-countTo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhuggins/jquery-countTo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhuggins/jquery-countTo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhuggins/jquery-countTo/contents/{+path}","compare_url":"https://api.github.com/repos/mhuggins/jquery-countTo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhuggins/jquery-countTo/merges","archive_url":"https://api.github.com/repos/mhuggins/jquery-countTo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhuggins/jquery-countTo/downloads","issues_url":"https://api.github.com/repos/mhuggins/jquery-countTo/issues{/number}","pulls_url":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls{/number}","milestones_url":"https://api.github.com/repos/mhuggins/jquery-countTo/milestones{/number}","notifications_url":"https://api.github.com/repos/mhuggins/jquery-countTo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhuggins/jquery-countTo/labels{/name}","releases_url":"https://api.github.com/repos/mhuggins/jquery-countTo/releases{/id}","created_at":"2012-04-30T00:11:13Z","updated_at":"2015-09-15T21:58:41Z","pushed_at":"2015-09-15T21:48:12Z","git_url":"git://github.com/mhuggins/jquery-countTo.git","ssh_url":"git@github.com:mhuggins/jquery-countTo.git","clone_url":"https://github.com/mhuggins/jquery-countTo.git","svn_url":"https://github.com/mhuggins/jquery-countTo","homepage":null,"size":260,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":11,"forks":110,"open_issues":11,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49"},"html":{"href":"https://github.com/mhuggins/jquery-countTo/pull/49"},"issue":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/49"},"comments":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/mhuggins/jquery-countTo/statuses/0df0980d4485021e024d404490db1577f5308f80"}}}}