{"action":"created","comment":{"url":"https://api.github.com/repos/netzob/netzob/pulls/comments/48105810","id":48105810,"diff_hunk":"@@ -82,7 +83,7 @@ class AbstractType(object):\n     # This value will be used if generate() method is called\n     # without any upper size limit\n     # 8192 is completly arbitrary and equals 1k of data (1024 bytes)\n-    MAXIMUM_GENERATED_DATA_SIZE = 8192\n+    #MAXIMUM_GENERATED_DATA_SIZE = 8192","path":"src/netzob/Common/Models/Types/AbstractType.py","position":13,"original_position":13,"commit_id":"767a60dbd6470eb60f497d88d81a039d8c37f567","original_commit_id":"767a60dbd6470eb60f497d88d81a039d8c37f567","user":{"login":"netzob","id":1853789,"avatar_url":"https://avatars.githubusercontent.com/u/1853789?v=3","gravatar_id":"","url":"https://api.github.com/users/netzob","html_url":"https://github.com/netzob","followers_url":"https://api.github.com/users/netzob/followers","following_url":"https://api.github.com/users/netzob/following{/other_user}","gists_url":"https://api.github.com/users/netzob/gists{/gist_id}","starred_url":"https://api.github.com/users/netzob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzob/subscriptions","organizations_url":"https://api.github.com/users/netzob/orgs","repos_url":"https://api.github.com/users/netzob/repos","events_url":"https://api.github.com/users/netzob/events{/privacy}","received_events_url":"https://api.github.com/users/netzob/received_events","type":"User","site_admin":false},"body":"you can remove old code","created_at":"2015-12-20T17:23:27Z","updated_at":"2015-12-20T17:23:27Z","html_url":"https://github.com/netzob/netzob/pull/18#discussion_r48105810","pull_request_url":"https://api.github.com/repos/netzob/netzob/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/netzob/netzob/pulls/comments/48105810"},"html":{"href":"https://github.com/netzob/netzob/pull/18#discussion_r48105810"},"pull_request":{"href":"https://api.github.com/repos/netzob/netzob/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/netzob/netzob/pulls/18","id":53605449,"html_url":"https://github.com/netzob/netzob/pull/18","diff_url":"https://github.com/netzob/netzob/pull/18.diff","patch_url":"https://github.com/netzob/netzob/pull/18.patch","issue_url":"https://api.github.com/repos/netzob/netzob/issues/18","number":18,"state":"open","locked":false,"title":"Moved default packet size to central class to be adjustable.","user":{"login":"violentinternet","id":8313265,"avatar_url":"https://avatars.githubusercontent.com/u/8313265?v=3","gravatar_id":"","url":"https://api.github.com/users/violentinternet","html_url":"https://github.com/violentinternet","followers_url":"https://api.github.com/users/violentinternet/followers","following_url":"https://api.github.com/users/violentinternet/following{/other_user}","gists_url":"https://api.github.com/users/violentinternet/gists{/gist_id}","starred_url":"https://api.github.com/users/violentinternet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/violentinternet/subscriptions","organizations_url":"https://api.github.com/users/violentinternet/orgs","repos_url":"https://api.github.com/users/violentinternet/repos","events_url":"https://api.github.com/users/violentinternet/events{/privacy}","received_events_url":"https://api.github.com/users/violentinternet/received_events","type":"User","site_admin":false},"body":"This enables users to set the upper size limit of packets globally. \r\n\r\nWas not sure about the unit size. Should I also move all the options of unit size from AbstractType to NetzobConfig class? ","created_at":"2015-12-14T18:51:49Z","updated_at":"2015-12-20T17:23:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7128148b23fff7487fb7b1dd5798ce5874e1c170","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netzob/netzob/pulls/18/commits","review_comments_url":"https://api.github.com/repos/netzob/netzob/pulls/18/comments","review_comment_url":"https://api.github.com/repos/netzob/netzob/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netzob/netzob/issues/18/comments","statuses_url":"https://api.github.com/repos/netzob/netzob/statuses/767a60dbd6470eb60f497d88d81a039d8c37f567","head":{"label":"violentinternet:master","ref":"master","sha":"767a60dbd6470eb60f497d88d81a039d8c37f567","user":{"login":"violentinternet","id":8313265,"avatar_url":"https://avatars.githubusercontent.com/u/8313265?v=3","gravatar_id":"","url":"https://api.github.com/users/violentinternet","html_url":"https://github.com/violentinternet","followers_url":"https://api.github.com/users/violentinternet/followers","following_url":"https://api.github.com/users/violentinternet/following{/other_user}","gists_url":"https://api.github.com/users/violentinternet/gists{/gist_id}","starred_url":"https://api.github.com/users/violentinternet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/violentinternet/subscriptions","organizations_url":"https://api.github.com/users/violentinternet/orgs","repos_url":"https://api.github.com/users/violentinternet/repos","events_url":"https://api.github.com/users/violentinternet/events{/privacy}","received_events_url":"https://api.github.com/users/violentinternet/received_events","type":"User","site_admin":false},"repo":{"id":45253191,"name":"netzob","full_name":"violentinternet/netzob","owner":{"login":"violentinternet","id":8313265,"avatar_url":"https://avatars.githubusercontent.com/u/8313265?v=3","gravatar_id":"","url":"https://api.github.com/users/violentinternet","html_url":"https://github.com/violentinternet","followers_url":"https://api.github.com/users/violentinternet/followers","following_url":"https://api.github.com/users/violentinternet/following{/other_user}","gists_url":"https://api.github.com/users/violentinternet/gists{/gist_id}","starred_url":"https://api.github.com/users/violentinternet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/violentinternet/subscriptions","organizations_url":"https://api.github.com/users/violentinternet/orgs","repos_url":"https://api.github.com/users/violentinternet/repos","events_url":"https://api.github.com/users/violentinternet/events{/privacy}","received_events_url":"https://api.github.com/users/violentinternet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/violentinternet/netzob","description":"Netzob's repository on github","fork":true,"url":"https://api.github.com/repos/violentinternet/netzob","forks_url":"https://api.github.com/repos/violentinternet/netzob/forks","keys_url":"https://api.github.com/repos/violentinternet/netzob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/violentinternet/netzob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/violentinternet/netzob/teams","hooks_url":"https://api.github.com/repos/violentinternet/netzob/hooks","issue_events_url":"https://api.github.com/repos/violentinternet/netzob/issues/events{/number}","events_url":"https://api.github.com/repos/violentinternet/netzob/events","assignees_url":"https://api.github.com/repos/violentinternet/netzob/assignees{/user}","branches_url":"https://api.github.com/repos/violentinternet/netzob/branches{/branch}","tags_url":"https://api.github.com/repos/violentinternet/netzob/tags","blobs_url":"https://api.github.com/repos/violentinternet/netzob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/violentinternet/netzob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/violentinternet/netzob/git/refs{/sha}","trees_url":"https://api.github.com/repos/violentinternet/netzob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/violentinternet/netzob/statuses/{sha}","languages_url":"https://api.github.com/repos/violentinternet/netzob/languages","stargazers_url":"https://api.github.com/repos/violentinternet/netzob/stargazers","contributors_url":"https://api.github.com/repos/violentinternet/netzob/contributors","subscribers_url":"https://api.github.com/repos/violentinternet/netzob/subscribers","subscription_url":"https://api.github.com/repos/violentinternet/netzob/subscription","commits_url":"https://api.github.com/repos/violentinternet/netzob/commits{/sha}","git_commits_url":"https://api.github.com/repos/violentinternet/netzob/git/commits{/sha}","comments_url":"https://api.github.com/repos/violentinternet/netzob/comments{/number}","issue_comment_url":"https://api.github.com/repos/violentinternet/netzob/issues/comments{/number}","contents_url":"https://api.github.com/repos/violentinternet/netzob/contents/{+path}","compare_url":"https://api.github.com/repos/violentinternet/netzob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/violentinternet/netzob/merges","archive_url":"https://api.github.com/repos/violentinternet/netzob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/violentinternet/netzob/downloads","issues_url":"https://api.github.com/repos/violentinternet/netzob/issues{/number}","pulls_url":"https://api.github.com/repos/violentinternet/netzob/pulls{/number}","milestones_url":"https://api.github.com/repos/violentinternet/netzob/milestones{/number}","notifications_url":"https://api.github.com/repos/violentinternet/netzob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/violentinternet/netzob/labels{/name}","releases_url":"https://api.github.com/repos/violentinternet/netzob/releases{/id}","created_at":"2015-10-30T13:41:28Z","updated_at":"2015-10-30T13:41:31Z","pushed_at":"2015-12-14T18:48:51Z","git_url":"git://github.com/violentinternet/netzob.git","ssh_url":"git@github.com:violentinternet/netzob.git","clone_url":"https://github.com/violentinternet/netzob.git","svn_url":"https://github.com/violentinternet/netzob","homepage":null,"size":15638,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netzob:master","ref":"master","sha":"ab22feb4b8b48d69634eb359c50fcf7c136621ab","user":{"login":"netzob","id":1853789,"avatar_url":"https://avatars.githubusercontent.com/u/1853789?v=3","gravatar_id":"","url":"https://api.github.com/users/netzob","html_url":"https://github.com/netzob","followers_url":"https://api.github.com/users/netzob/followers","following_url":"https://api.github.com/users/netzob/following{/other_user}","gists_url":"https://api.github.com/users/netzob/gists{/gist_id}","starred_url":"https://api.github.com/users/netzob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzob/subscriptions","organizations_url":"https://api.github.com/users/netzob/orgs","repos_url":"https://api.github.com/users/netzob/repos","events_url":"https://api.github.com/users/netzob/events{/privacy}","received_events_url":"https://api.github.com/users/netzob/received_events","type":"User","site_admin":false},"repo":{"id":4675010,"name":"netzob","full_name":"netzob/netzob","owner":{"login":"netzob","id":1853789,"avatar_url":"https://avatars.githubusercontent.com/u/1853789?v=3","gravatar_id":"","url":"https://api.github.com/users/netzob","html_url":"https://github.com/netzob","followers_url":"https://api.github.com/users/netzob/followers","following_url":"https://api.github.com/users/netzob/following{/other_user}","gists_url":"https://api.github.com/users/netzob/gists{/gist_id}","starred_url":"https://api.github.com/users/netzob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netzob/subscriptions","organizations_url":"https://api.github.com/users/netzob/orgs","repos_url":"https://api.github.com/users/netzob/repos","events_url":"https://api.github.com/users/netzob/events{/privacy}","received_events_url":"https://api.github.com/users/netzob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/netzob/netzob","description":"Netzob's repository on github","fork":false,"url":"https://api.github.com/repos/netzob/netzob","forks_url":"https://api.github.com/repos/netzob/netzob/forks","keys_url":"https://api.github.com/repos/netzob/netzob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netzob/netzob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netzob/netzob/teams","hooks_url":"https://api.github.com/repos/netzob/netzob/hooks","issue_events_url":"https://api.github.com/repos/netzob/netzob/issues/events{/number}","events_url":"https://api.github.com/repos/netzob/netzob/events","assignees_url":"https://api.github.com/repos/netzob/netzob/assignees{/user}","branches_url":"https://api.github.com/repos/netzob/netzob/branches{/branch}","tags_url":"https://api.github.com/repos/netzob/netzob/tags","blobs_url":"https://api.github.com/repos/netzob/netzob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netzob/netzob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netzob/netzob/git/refs{/sha}","trees_url":"https://api.github.com/repos/netzob/netzob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netzob/netzob/statuses/{sha}","languages_url":"https://api.github.com/repos/netzob/netzob/languages","stargazers_url":"https://api.github.com/repos/netzob/netzob/stargazers","contributors_url":"https://api.github.com/repos/netzob/netzob/contributors","subscribers_url":"https://api.github.com/repos/netzob/netzob/subscribers","subscription_url":"https://api.github.com/repos/netzob/netzob/subscription","commits_url":"https://api.github.com/repos/netzob/netzob/commits{/sha}","git_commits_url":"https://api.github.com/repos/netzob/netzob/git/commits{/sha}","comments_url":"https://api.github.com/repos/netzob/netzob/comments{/number}","issue_comment_url":"https://api.github.com/repos/netzob/netzob/issues/comments{/number}","contents_url":"https://api.github.com/repos/netzob/netzob/contents/{+path}","compare_url":"https://api.github.com/repos/netzob/netzob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netzob/netzob/merges","archive_url":"https://api.github.com/repos/netzob/netzob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netzob/netzob/downloads","issues_url":"https://api.github.com/repos/netzob/netzob/issues{/number}","pulls_url":"https://api.github.com/repos/netzob/netzob/pulls{/number}","milestones_url":"https://api.github.com/repos/netzob/netzob/milestones{/number}","notifications_url":"https://api.github.com/repos/netzob/netzob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netzob/netzob/labels{/name}","releases_url":"https://api.github.com/repos/netzob/netzob/releases{/id}","created_at":"2012-06-15T12:38:05Z","updated_at":"2015-12-20T00:06:16Z","pushed_at":"2015-12-14T18:51:49Z","git_url":"git://github.com/netzob/netzob.git","ssh_url":"git@github.com:netzob/netzob.git","clone_url":"https://github.com/netzob/netzob.git","svn_url":"https://github.com/netzob/netzob","homepage":null,"size":15754,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netzob/netzob/pulls/18"},"html":{"href":"https://github.com/netzob/netzob/pull/18"},"issue":{"href":"https://api.github.com/repos/netzob/netzob/issues/18"},"comments":{"href":"https://api.github.com/repos/netzob/netzob/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/netzob/netzob/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/netzob/netzob/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netzob/netzob/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/netzob/netzob/statuses/767a60dbd6470eb60f497d88d81a039d8c37f567"}}}}