{"action":"created","issue":{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/150","labels_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/150/comments","events_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/150/events","html_url":"https://github.com/armenzg/mozilla_ci_tools/pull/150","id":65299748,"number":150,"title":"Rewrote test_platforms to use mocking based approach.","user":{"login":"adusca","id":8979476,"avatar_url":"https://avatars.githubusercontent.com/u/8979476?v=3","gravatar_id":"","url":"https://api.github.com/users/adusca","html_url":"https://github.com/adusca","followers_url":"https://api.github.com/users/adusca/followers","following_url":"https://api.github.com/users/adusca/following{/other_user}","gists_url":"https://api.github.com/users/adusca/gists{/gist_id}","starred_url":"https://api.github.com/users/adusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adusca/subscriptions","organizations_url":"https://api.github.com/users/adusca/orgs","repos_url":"https://api.github.com/users/adusca/repos","events_url":"https://api.github.com/users/adusca/events{/privacy}","received_events_url":"https://api.github.com/users/adusca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-30T20:50:12Z","updated_at":"2015-03-31T19:25:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/pulls/150","html_url":"https://github.com/armenzg/mozilla_ci_tools/pull/150","diff_url":"https://github.com/armenzg/mozilla_ci_tools/pull/150.diff","patch_url":"https://github.com/armenzg/mozilla_ci_tools/pull/150.patch"},"body":"As seen in #144 most of our previous tests depended on specific buildernames being in allthethings.json. I rewrote those tests to use mock_allthethings.json instead (and deleted test_platforms.json, which is no longer used).\r\n\r\nThis will probably reduce coverage because we are no longer indirectly testing allthethings.py."},"comment":{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/comments/88218039","html_url":"https://github.com/armenzg/mozilla_ci_tools/pull/150#issuecomment-88218039","issue_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/150","id":88218039,"user":{"login":"adusca","id":8979476,"avatar_url":"https://avatars.githubusercontent.com/u/8979476?v=3","gravatar_id":"","url":"https://api.github.com/users/adusca","html_url":"https://github.com/adusca","followers_url":"https://api.github.com/users/adusca/followers","following_url":"https://api.github.com/users/adusca/following{/other_user}","gists_url":"https://api.github.com/users/adusca/gists{/gist_id}","starred_url":"https://api.github.com/users/adusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adusca/subscriptions","organizations_url":"https://api.github.com/users/adusca/orgs","repos_url":"https://api.github.com/users/adusca/repos","events_url":"https://api.github.com/users/adusca/events{/privacy}","received_events_url":"https://api.github.com/users/adusca/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T19:25:41Z","updated_at":"2015-03-31T19:25:41Z","body":"Is it possible that both \"Platform repo pgo talos test\" and \"Platform repo talos test\" are valid for some repo? If not it's probably better to just remove the \"if 'mozilla-beta' in buildername or 'mozilla-aurora' in buildername\"\r\n\r\nIt would be possible to use the same logic with schedulers: \r\nSince both \"tests-mozilla-aurora-linux64-talos\" and \"tests-mozilla-aurora-linux64-pgo-talos\" exist, we should ignore every job in \"tests-mozilla-aurora-linux64-talos\", and since \"mozilla-aurora-macosx64-pgo-talos\" does not exist we should not ignore \"mozilla-aurora-macosx64-talos\". We would need to keep a list of every scheduler name."}}