{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Baragon/pulls/comments/45517154","id":45517154,"diff_hunk":"@@ -162,6 +169,7 @@ private void registerNewInstances(List<LoadBalancerDescription> elbs, BaragonGro\n           LOG.info(String.format(\"Registered instances %s with ELB %s\", request.getInstances(), request.getLoadBalancerName()));\n         } catch (AmazonClientException e) {\n           LOG.error(\"Could not register %s with elb %s due to error %s\", request.getInstances(), request.getLoadBalancerName(), e);\n+          exceptionNotifier.notify(e, ImmutableMap.of(\"elb\", request.getLoadBalancerName(), \"toAdd\", request.getInstances().toString()));","path":"BaragonService/src/main/java/com/hubspot/baragon/service/managers/ElbManager.java","position":65,"original_position":65,"commit_id":"72cb32bca8ac47bd92293bf5fb9e7ed1a22d06a2","original_commit_id":"5051d2268a627083c378c34d94b8e7b81b74ef5b","user":{"login":"tpetr","id":47152,"avatar_url":"https://avatars.githubusercontent.com/u/47152?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetr","html_url":"https://github.com/tpetr","followers_url":"https://api.github.com/users/tpetr/followers","following_url":"https://api.github.com/users/tpetr/following{/other_user}","gists_url":"https://api.github.com/users/tpetr/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetr/subscriptions","organizations_url":"https://api.github.com/users/tpetr/orgs","repos_url":"https://api.github.com/users/tpetr/repos","events_url":"https://api.github.com/users/tpetr/events{/privacy}","received_events_url":"https://api.github.com/users/tpetr/received_events","type":"User","site_admin":false},"body":"Kieran attempted the logback thing a long time ago, and it never really worked. But more than that, explicitly triggering the notification allows us to add extra information, and control how the messages are deduped in Sentry.","created_at":"2015-11-20T20:53:46Z","updated_at":"2015-11-20T20:53:46Z","html_url":"https://github.com/HubSpot/Baragon/pull/137#discussion_r45517154","pull_request_url":"https://api.github.com/repos/HubSpot/Baragon/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/comments/45517154"},"html":{"href":"https://github.com/HubSpot/Baragon/pull/137#discussion_r45517154"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Baragon/pulls/137","id":50855811,"html_url":"https://github.com/HubSpot/Baragon/pull/137","diff_url":"https://github.com/HubSpot/Baragon/pull/137.diff","patch_url":"https://github.com/HubSpot/Baragon/pull/137.patch","issue_url":"https://api.github.com/repos/HubSpot/Baragon/issues/137","number":137,"state":"open","locked":false,"title":"wire up baragon service for sentry","user":{"login":"ssalinas","id":6034439,"avatar_url":"https://avatars.githubusercontent.com/u/6034439?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas","html_url":"https://github.com/ssalinas","followers_url":"https://api.github.com/users/ssalinas/followers","following_url":"https://api.github.com/users/ssalinas/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas/subscriptions","organizations_url":"https://api.github.com/users/ssalinas/orgs","repos_url":"https://api.github.com/users/ssalinas/repos","events_url":"https://api.github.com/users/ssalinas/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas/received_events","type":"User","site_admin":false},"body":"/cc @tpetr \r\nGets BaragonService ready for sentry. I didn't do the agents initially here since exceptions from the agents will generally come back as failed apply requests. In the service I wired up for uncaught exceptions, 50* responses, and a few catch blocks in different workers","created_at":"2015-11-16T19:44:04Z","updated_at":"2015-11-20T20:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6af56db95a5919279d43f44323253d998842d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Baragon/pulls/137/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Baragon/pulls/137/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Baragon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Baragon/issues/137/comments","statuses_url":"https://api.github.com/repos/HubSpot/Baragon/statuses/72cb32bca8ac47bd92293bf5fb9e7ed1a22d06a2","head":{"label":"HubSpot:sentry","ref":"sentry","sha":"72cb32bca8ac47bd92293bf5fb9e7ed1a22d06a2","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":14145875,"name":"Baragon","full_name":"HubSpot/Baragon","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Baragon","description":"Load balancer API","fork":false,"url":"https://api.github.com/repos/HubSpot/Baragon","forks_url":"https://api.github.com/repos/HubSpot/Baragon/forks","keys_url":"https://api.github.com/repos/HubSpot/Baragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Baragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Baragon/teams","hooks_url":"https://api.github.com/repos/HubSpot/Baragon/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Baragon/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Baragon/events","assignees_url":"https://api.github.com/repos/HubSpot/Baragon/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Baragon/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Baragon/tags","blobs_url":"https://api.github.com/repos/HubSpot/Baragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Baragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Baragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Baragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Baragon/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Baragon/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Baragon/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Baragon/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Baragon/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Baragon/subscription","commits_url":"https://api.github.com/repos/HubSpot/Baragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Baragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Baragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Baragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Baragon/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Baragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Baragon/merges","archive_url":"https://api.github.com/repos/HubSpot/Baragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Baragon/downloads","issues_url":"https://api.github.com/repos/HubSpot/Baragon/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Baragon/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Baragon/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Baragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Baragon/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Baragon/releases{/id}","created_at":"2013-11-05T15:51:09Z","updated_at":"2015-11-12T08:22:01Z","pushed_at":"2015-11-20T19:09:33Z","git_url":"git://github.com/HubSpot/Baragon.git","ssh_url":"git@github.com:HubSpot/Baragon.git","clone_url":"https://github.com/HubSpot/Baragon.git","svn_url":"https://github.com/HubSpot/Baragon","homepage":null,"size":7091,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":47,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"e358ddd8a5728b710044b0c9728a860747d940a2","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":14145875,"name":"Baragon","full_name":"HubSpot/Baragon","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Baragon","description":"Load balancer API","fork":false,"url":"https://api.github.com/repos/HubSpot/Baragon","forks_url":"https://api.github.com/repos/HubSpot/Baragon/forks","keys_url":"https://api.github.com/repos/HubSpot/Baragon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Baragon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Baragon/teams","hooks_url":"https://api.github.com/repos/HubSpot/Baragon/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Baragon/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Baragon/events","assignees_url":"https://api.github.com/repos/HubSpot/Baragon/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Baragon/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Baragon/tags","blobs_url":"https://api.github.com/repos/HubSpot/Baragon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Baragon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Baragon/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Baragon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Baragon/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Baragon/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Baragon/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Baragon/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Baragon/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Baragon/subscription","commits_url":"https://api.github.com/repos/HubSpot/Baragon/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Baragon/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Baragon/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Baragon/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Baragon/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Baragon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Baragon/merges","archive_url":"https://api.github.com/repos/HubSpot/Baragon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Baragon/downloads","issues_url":"https://api.github.com/repos/HubSpot/Baragon/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Baragon/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Baragon/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Baragon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Baragon/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Baragon/releases{/id}","created_at":"2013-11-05T15:51:09Z","updated_at":"2015-11-12T08:22:01Z","pushed_at":"2015-11-20T19:09:33Z","git_url":"git://github.com/HubSpot/Baragon.git","ssh_url":"git@github.com:HubSpot/Baragon.git","clone_url":"https://github.com/HubSpot/Baragon.git","svn_url":"https://github.com/HubSpot/Baragon","homepage":null,"size":7091,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/137"},"html":{"href":"https://github.com/HubSpot/Baragon/pull/137"},"issue":{"href":"https://api.github.com/repos/HubSpot/Baragon/issues/137"},"comments":{"href":"https://api.github.com/repos/HubSpot/Baragon/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Baragon/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Baragon/statuses/72cb32bca8ac47bd92293bf5fb9e7ed1a22d06a2"}}}}