{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1652","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1652/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1652/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1652/events","html_url":"https://github.com/OpenMS/OpenMS/pull/1652","id":110645085,"number":1652,"title":"Refactoring of mass shift generation in FeatureFinderMultiplex","user":{"login":"lars20070","id":6149805,"avatar_url":"https://avatars.githubusercontent.com/u/6149805?v=3","gravatar_id":"","url":"https://api.github.com/users/lars20070","html_url":"https://github.com/lars20070","followers_url":"https://api.github.com/users/lars20070/followers","following_url":"https://api.github.com/users/lars20070/following{/other_user}","gists_url":"https://api.github.com/users/lars20070/gists{/gist_id}","starred_url":"https://api.github.com/users/lars20070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars20070/subscriptions","organizations_url":"https://api.github.com/users/lars20070/orgs","repos_url":"https://api.github.com/users/lars20070/repos","events_url":"https://api.github.com/users/lars20070/events{/privacy}","received_events_url":"https://api.github.com/users/lars20070/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-09T12:10:48Z","updated_at":"2015-10-10T17:27:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1652","html_url":"https://github.com/OpenMS/OpenMS/pull/1652","diff_url":"https://github.com/OpenMS/OpenMS/pull/1652.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/1652.patch"},"body":"Isotopic labelling introduces mass shifts between peptide features. Before peptide feature multiplets can be detected, a complete list of all possible mass shifts needs to be constructed. This pull request moves this functionality from `FeatureFinderMultiplex.cpp` to two new classes.\r\n\r\n`MultiplexMassPattern` is a data structure for a single mass shift pattern (the equivalent of `MultiplexPeakPattern`for m/z shift patterns). `MultiplexMassPatternList` contains the functionality for the construction of the complete list."},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/147111395","html_url":"https://github.com/OpenMS/OpenMS/pull/1652#issuecomment-147111395","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1652","id":147111395,"user":{"login":"timosachsenberg","id":5803621,"avatar_url":"https://avatars.githubusercontent.com/u/5803621?v=3","gravatar_id":"","url":"https://api.github.com/users/timosachsenberg","html_url":"https://github.com/timosachsenberg","followers_url":"https://api.github.com/users/timosachsenberg/followers","following_url":"https://api.github.com/users/timosachsenberg/following{/other_user}","gists_url":"https://api.github.com/users/timosachsenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/timosachsenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timosachsenberg/subscriptions","organizations_url":"https://api.github.com/users/timosachsenberg/orgs","repos_url":"https://api.github.com/users/timosachsenberg/repos","events_url":"https://api.github.com/users/timosachsenberg/events{/privacy}","received_events_url":"https://api.github.com/users/timosachsenberg/received_events","type":"User","site_admin":false},"created_at":"2015-10-10T17:27:57Z","updated_at":"2015-10-10T17:27:57Z","body":"Please correct me if I misunderstood how you use the terms *Mass and *PeakPattern: \r\nI think you use the term *Mass in your naming convention for shifts between different labelling states and *PeakPattern for the set of mass shifts describing the isotopic peaks.\r\nThis is misleading in my view and I would choose a name that allows to better distinguish these different sets of mass (or m/z) shifts. Choosing *DeltaMz and *DeltaMasses does't help here as it would just suggest that both are basically the same (except that one is in Da and the other in Th).\r\n\r\n"}}