{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/6110","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6110/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6110/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6110/events","html_url":"https://github.com/mozilla/pdf.js/pull/6110","id":87975327,"number":6110,"title":"Refactor viewer code to fix issues with the \"pageviewer\" components example (issue 6056)","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-06-13T09:57:46Z","updated_at":"2015-07-12T13:08:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6110","html_url":"https://github.com/mozilla/pdf.js/pull/6110","diff_url":"https://github.com/mozilla/pdf.js/pull/6110.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6110.patch"},"body":"Fixes #6056.\r\n\r\nWhen working of addressing the issue, it quickly became apparent that a number of (smaller) things needed to be re-factored in order for it to work. Hence the use of multiple commits (despite the total size of the PR), to make it easier to follow the reasoning.\r\n\r\n*Please refer to the individual commit messages for a more detailed description of the patches.*"},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/120720129","html_url":"https://github.com/mozilla/pdf.js/pull/6110#issuecomment-120720129","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6110","id":120720129,"user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2015-07-12T13:08:34Z","updated_at":"2015-07-12T13:08:34Z","body":"Well, that was a silly mistake. I had built the components before applying the patch, but forgot to rebuild them after applying the patch. Now it does work for me, so I will continue the review. Thanks!"}}