{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/shmul/mule/pulls/1","id":42539544,"html_url":"https://github.com/shmul/mule/pull/1","diff_url":"https://github.com/shmul/mule/pull/1.diff","patch_url":"https://github.com/shmul/mule/pull/1.patch","issue_url":"https://api.github.com/repos/shmul/mule/issues/1","number":1,"state":"closed","locked":false,"title":"Propostion for Lua 5.3 fix","user":{"login":"catwell","id":221332,"avatar_url":"https://avatars.githubusercontent.com/u/221332?v=3","gravatar_id":"","url":"https://api.github.com/users/catwell","html_url":"https://github.com/catwell","followers_url":"https://api.github.com/users/catwell/followers","following_url":"https://api.github.com/users/catwell/following{/other_user}","gists_url":"https://api.github.com/users/catwell/gists{/gist_id}","starred_url":"https://api.github.com/users/catwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catwell/subscriptions","organizations_url":"https://api.github.com/users/catwell/orgs","repos_url":"https://api.github.com/users/catwell/repos","events_url":"https://api.github.com/users/catwell/events{/privacy}","received_events_url":"https://api.github.com/users/catwell/received_events","type":"User","site_admin":false},"body":"Mostly implements a \"native\" packer that uses `string.pack` and `string.unpack` from the standard library instead of lpack.\r\n\r\nI believe this fixes at least part of the issues raised in [this comment](https://github.com/shmul/lightningmdb/pull/7#issuecomment-131556741) on the lightningmdb project. On my machine, it makes the purepack tests pass. Some other tests still fail, for instance the trie tests fail because no packing library is set so they use NOPs:\r\n\r\n```\r\n  1) Error! (test_trie.test_pack):\r\n./purepack.lua:230: ./purepack.lua:192: wrong number of arguments to 'insert'\r\n\t[C]: in function 'push'\r\n\t./purepack.lua:230: in function 'helper'\r\n\t./purepack.lua:243: in function 'pack_helper'\r\n\t./purepack.lua:248: in function <./purepack.lua:246>\r\n\ttests/test_trie.lua:174: in function <tests/test_trie.lua:166>\r\n\t[C]: in function 'xpcall'\r\n\tstdin:11: in main chunk\r\n\t[C]: ?\r\n```\r\n\r\nand the \"mule\" test fails for a reason I do not know:\r\n\r\n```\r\n  1) Failure (test_mule.test_create):\r\ntests/test_mule.lua:36: expected 11392 but was 2111\r\n```\r\n\r\nDCO 1.1 Signed-off-by: Pierre Chapuis <catwell@archlinux.us>","created_at":"2015-08-16T17:04:57Z","updated_at":"2015-08-18T06:59:49Z","closed_at":"2015-08-18T06:59:49Z","merged_at":"2015-08-18T06:59:49Z","merge_commit_sha":"74ccbe8237ca8123ea00aba2ee227862f3f22a7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shmul/mule/pulls/1/commits","review_comments_url":"https://api.github.com/repos/shmul/mule/pulls/1/comments","review_comment_url":"https://api.github.com/repos/shmul/mule/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shmul/mule/issues/1/comments","statuses_url":"https://api.github.com/repos/shmul/mule/statuses/90950b8e727b19d7f6464790056aa2c50a14c6e4","head":{"label":"catwell:master","ref":"master","sha":"90950b8e727b19d7f6464790056aa2c50a14c6e4","user":{"login":"catwell","id":221332,"avatar_url":"https://avatars.githubusercontent.com/u/221332?v=3","gravatar_id":"","url":"https://api.github.com/users/catwell","html_url":"https://github.com/catwell","followers_url":"https://api.github.com/users/catwell/followers","following_url":"https://api.github.com/users/catwell/following{/other_user}","gists_url":"https://api.github.com/users/catwell/gists{/gist_id}","starred_url":"https://api.github.com/users/catwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catwell/subscriptions","organizations_url":"https://api.github.com/users/catwell/orgs","repos_url":"https://api.github.com/users/catwell/repos","events_url":"https://api.github.com/users/catwell/events{/privacy}","received_events_url":"https://api.github.com/users/catwell/received_events","type":"User","site_admin":false},"repo":{"id":40828912,"name":"mule","full_name":"catwell/mule","owner":{"login":"catwell","id":221332,"avatar_url":"https://avatars.githubusercontent.com/u/221332?v=3","gravatar_id":"","url":"https://api.github.com/users/catwell","html_url":"https://github.com/catwell","followers_url":"https://api.github.com/users/catwell/followers","following_url":"https://api.github.com/users/catwell/following{/other_user}","gists_url":"https://api.github.com/users/catwell/gists{/gist_id}","starred_url":"https://api.github.com/users/catwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catwell/subscriptions","organizations_url":"https://api.github.com/users/catwell/orgs","repos_url":"https://api.github.com/users/catwell/repos","events_url":"https://api.github.com/users/catwell/events{/privacy}","received_events_url":"https://api.github.com/users/catwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/catwell/mule","description":"Mule is an RRD tool designed with simplicity of use in mind for applicative monitoring.","fork":true,"url":"https://api.github.com/repos/catwell/mule","forks_url":"https://api.github.com/repos/catwell/mule/forks","keys_url":"https://api.github.com/repos/catwell/mule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catwell/mule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catwell/mule/teams","hooks_url":"https://api.github.com/repos/catwell/mule/hooks","issue_events_url":"https://api.github.com/repos/catwell/mule/issues/events{/number}","events_url":"https://api.github.com/repos/catwell/mule/events","assignees_url":"https://api.github.com/repos/catwell/mule/assignees{/user}","branches_url":"https://api.github.com/repos/catwell/mule/branches{/branch}","tags_url":"https://api.github.com/repos/catwell/mule/tags","blobs_url":"https://api.github.com/repos/catwell/mule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catwell/mule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catwell/mule/git/refs{/sha}","trees_url":"https://api.github.com/repos/catwell/mule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catwell/mule/statuses/{sha}","languages_url":"https://api.github.com/repos/catwell/mule/languages","stargazers_url":"https://api.github.com/repos/catwell/mule/stargazers","contributors_url":"https://api.github.com/repos/catwell/mule/contributors","subscribers_url":"https://api.github.com/repos/catwell/mule/subscribers","subscription_url":"https://api.github.com/repos/catwell/mule/subscription","commits_url":"https://api.github.com/repos/catwell/mule/commits{/sha}","git_commits_url":"https://api.github.com/repos/catwell/mule/git/commits{/sha}","comments_url":"https://api.github.com/repos/catwell/mule/comments{/number}","issue_comment_url":"https://api.github.com/repos/catwell/mule/issues/comments{/number}","contents_url":"https://api.github.com/repos/catwell/mule/contents/{+path}","compare_url":"https://api.github.com/repos/catwell/mule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catwell/mule/merges","archive_url":"https://api.github.com/repos/catwell/mule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catwell/mule/downloads","issues_url":"https://api.github.com/repos/catwell/mule/issues{/number}","pulls_url":"https://api.github.com/repos/catwell/mule/pulls{/number}","milestones_url":"https://api.github.com/repos/catwell/mule/milestones{/number}","notifications_url":"https://api.github.com/repos/catwell/mule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catwell/mule/labels{/name}","releases_url":"https://api.github.com/repos/catwell/mule/releases{/id}","created_at":"2015-08-16T16:52:15Z","updated_at":"2015-08-16T16:52:21Z","pushed_at":"2015-08-16T17:01:35Z","git_url":"git://github.com/catwell/mule.git","ssh_url":"git@github.com:catwell/mule.git","clone_url":"https://github.com/catwell/mule.git","svn_url":"https://github.com/catwell/mule","homepage":null,"size":14465,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shmul:master","ref":"master","sha":"295ee864e6682303a8438bf3b807f2fc94a41985","user":{"login":"shmul","id":701036,"avatar_url":"https://avatars.githubusercontent.com/u/701036?v=3","gravatar_id":"","url":"https://api.github.com/users/shmul","html_url":"https://github.com/shmul","followers_url":"https://api.github.com/users/shmul/followers","following_url":"https://api.github.com/users/shmul/following{/other_user}","gists_url":"https://api.github.com/users/shmul/gists{/gist_id}","starred_url":"https://api.github.com/users/shmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmul/subscriptions","organizations_url":"https://api.github.com/users/shmul/orgs","repos_url":"https://api.github.com/users/shmul/repos","events_url":"https://api.github.com/users/shmul/events{/privacy}","received_events_url":"https://api.github.com/users/shmul/received_events","type":"User","site_admin":false},"repo":{"id":39386548,"name":"mule","full_name":"shmul/mule","owner":{"login":"shmul","id":701036,"avatar_url":"https://avatars.githubusercontent.com/u/701036?v=3","gravatar_id":"","url":"https://api.github.com/users/shmul","html_url":"https://github.com/shmul","followers_url":"https://api.github.com/users/shmul/followers","following_url":"https://api.github.com/users/shmul/following{/other_user}","gists_url":"https://api.github.com/users/shmul/gists{/gist_id}","starred_url":"https://api.github.com/users/shmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmul/subscriptions","organizations_url":"https://api.github.com/users/shmul/orgs","repos_url":"https://api.github.com/users/shmul/repos","events_url":"https://api.github.com/users/shmul/events{/privacy}","received_events_url":"https://api.github.com/users/shmul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shmul/mule","description":"Mule is an RRD tool designed with simplicity of use in mind for applicative monitoring.","fork":false,"url":"https://api.github.com/repos/shmul/mule","forks_url":"https://api.github.com/repos/shmul/mule/forks","keys_url":"https://api.github.com/repos/shmul/mule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shmul/mule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shmul/mule/teams","hooks_url":"https://api.github.com/repos/shmul/mule/hooks","issue_events_url":"https://api.github.com/repos/shmul/mule/issues/events{/number}","events_url":"https://api.github.com/repos/shmul/mule/events","assignees_url":"https://api.github.com/repos/shmul/mule/assignees{/user}","branches_url":"https://api.github.com/repos/shmul/mule/branches{/branch}","tags_url":"https://api.github.com/repos/shmul/mule/tags","blobs_url":"https://api.github.com/repos/shmul/mule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shmul/mule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shmul/mule/git/refs{/sha}","trees_url":"https://api.github.com/repos/shmul/mule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shmul/mule/statuses/{sha}","languages_url":"https://api.github.com/repos/shmul/mule/languages","stargazers_url":"https://api.github.com/repos/shmul/mule/stargazers","contributors_url":"https://api.github.com/repos/shmul/mule/contributors","subscribers_url":"https://api.github.com/repos/shmul/mule/subscribers","subscription_url":"https://api.github.com/repos/shmul/mule/subscription","commits_url":"https://api.github.com/repos/shmul/mule/commits{/sha}","git_commits_url":"https://api.github.com/repos/shmul/mule/git/commits{/sha}","comments_url":"https://api.github.com/repos/shmul/mule/comments{/number}","issue_comment_url":"https://api.github.com/repos/shmul/mule/issues/comments{/number}","contents_url":"https://api.github.com/repos/shmul/mule/contents/{+path}","compare_url":"https://api.github.com/repos/shmul/mule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shmul/mule/merges","archive_url":"https://api.github.com/repos/shmul/mule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shmul/mule/downloads","issues_url":"https://api.github.com/repos/shmul/mule/issues{/number}","pulls_url":"https://api.github.com/repos/shmul/mule/pulls{/number}","milestones_url":"https://api.github.com/repos/shmul/mule/milestones{/number}","notifications_url":"https://api.github.com/repos/shmul/mule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shmul/mule/labels{/name}","releases_url":"https://api.github.com/repos/shmul/mule/releases{/id}","created_at":"2015-07-20T13:49:48Z","updated_at":"2015-08-09T12:51:16Z","pushed_at":"2015-08-18T06:59:49Z","git_url":"git://github.com/shmul/mule.git","ssh_url":"git@github.com:shmul/mule.git","clone_url":"https://github.com/shmul/mule.git","svn_url":"https://github.com/shmul/mule","homepage":null,"size":14533,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shmul/mule/pulls/1"},"html":{"href":"https://github.com/shmul/mule/pull/1"},"issue":{"href":"https://api.github.com/repos/shmul/mule/issues/1"},"comments":{"href":"https://api.github.com/repos/shmul/mule/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/shmul/mule/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/shmul/mule/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shmul/mule/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/shmul/mule/statuses/90950b8e727b19d7f6464790056aa2c50a14c6e4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shmul","id":701036,"avatar_url":"https://avatars.githubusercontent.com/u/701036?v=3","gravatar_id":"","url":"https://api.github.com/users/shmul","html_url":"https://github.com/shmul","followers_url":"https://api.github.com/users/shmul/followers","following_url":"https://api.github.com/users/shmul/following{/other_user}","gists_url":"https://api.github.com/users/shmul/gists{/gist_id}","starred_url":"https://api.github.com/users/shmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmul/subscriptions","organizations_url":"https://api.github.com/users/shmul/orgs","repos_url":"https://api.github.com/users/shmul/repos","events_url":"https://api.github.com/users/shmul/events{/privacy}","received_events_url":"https://api.github.com/users/shmul/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":2,"changed_files":2}}