{"action":"created","issue":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/80","labels_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/80/comments","events_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/80/events","html_url":"https://github.com/TypeStrong/ts-loader/pull/80","id":110623438,"number":80,"title":"Simplify build; de-hardcode typescript typings","user":{"login":"use-strict","id":9483866,"avatar_url":"https://avatars.githubusercontent.com/u/9483866?v=3","gravatar_id":"","url":"https://api.github.com/users/use-strict","html_url":"https://github.com/use-strict","followers_url":"https://api.github.com/users/use-strict/followers","following_url":"https://api.github.com/users/use-strict/following{/other_user}","gists_url":"https://api.github.com/users/use-strict/gists{/gist_id}","starred_url":"https://api.github.com/users/use-strict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/use-strict/subscriptions","organizations_url":"https://api.github.com/users/use-strict/orgs","repos_url":"https://api.github.com/users/use-strict/repos","events_url":"https://api.github.com/users/use-strict/events{/privacy}","received_events_url":"https://api.github.com/users/use-strict/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-09T09:41:46Z","updated_at":"2015-10-09T11:06:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/80","html_url":"https://github.com/TypeStrong/ts-loader/pull/80","diff_url":"https://github.com/TypeStrong/ts-loader/pull/80.diff","patch_url":"https://github.com/TypeStrong/ts-loader/pull/80.patch"},"body":"Some questions and things I might have gotten wrong:\r\n\r\n- Why rely on the global typescript module for building ts-loader? Build dependency should be well fixed. Only runtime version varies.\r\n\r\n- Do we need a build.js file if we just ran tsc with no arguments?\r\n\r\n- The signature for readConfigFile seems wrong, even for older typescript versions.\r\n\r\n- I would also add \"noImplicitAny\" as a compilation option.\r\n\r\n- Is there a reason for still supporting TS < 1.6 for building ts-loader?\r\n\r\nP.S. Sorry about the whitespaces, my editor trims trailing whitespaces by default and I didn't notice before creating the pull request. But it is something you should also use."},"comment":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/comments/146834929","html_url":"https://github.com/TypeStrong/ts-loader/pull/80#issuecomment-146834929","issue_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/80","id":146834929,"user":{"login":"use-strict","id":9483866,"avatar_url":"https://avatars.githubusercontent.com/u/9483866?v=3","gravatar_id":"","url":"https://api.github.com/users/use-strict","html_url":"https://github.com/use-strict","followers_url":"https://api.github.com/users/use-strict/followers","following_url":"https://api.github.com/users/use-strict/following{/other_user}","gists_url":"https://api.github.com/users/use-strict/gists{/gist_id}","starred_url":"https://api.github.com/users/use-strict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/use-strict/subscriptions","organizations_url":"https://api.github.com/users/use-strict/orgs","repos_url":"https://api.github.com/users/use-strict/repos","events_url":"https://api.github.com/users/use-strict/events{/privacy}","received_events_url":"https://api.github.com/users/use-strict/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T11:06:11Z","updated_at":"2015-10-09T11:06:11Z","body":"OK, just saw your comment now. I did exactly what you didn't want, which is to do version detection. Tests pass though (1.5.3 should be removed from the tests).\r\n\r\nv0.6 is just a label. I agree it should not be in 0.5.x for semver reasons, but is there a problem going from v0.5.6 to v0.6 with this PR? :)\r\n\r\nIs there any way to detect which version of readConfigFile we should be using? I know at runtime it will work even with extra arguments being passed, but we are relying on a side-effect and this won't work for signatures that are completely diffferent. I also see no way to detect this at runtime, so we need a way to detect this at compile-type, even for custom typescript builds."}}