{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22443683","id":22443683,"diff_hunk":"@@ -348,8 +324,7 @@ u32 Read_Opcode(u32 _Address)\n \t\treturn 0x00000000;\n \t}\n \n-\tif (SConfig::GetInstance().m_LocalCoreStartupParameter.bMMU &&\n-\t\t(_Address & ADDR_MASK_MEM1))\n+\tif ((_Address & ADDR_MASK_MEM1))","path":"Source/Core/Core/HW/MemmapFunctions.cpp","position":80,"original_position":80,"commit_id":"b7c901522467703a109f942fb75a48bcf2cfdba5","original_commit_id":"b7c901522467703a109f942fb75a48bcf2cfdba5","user":{"login":"BhaaLseN","id":826052,"avatar_url":"https://avatars.githubusercontent.com/u/826052?v=3","gravatar_id":"","url":"https://api.github.com/users/BhaaLseN","html_url":"https://github.com/BhaaLseN","followers_url":"https://api.github.com/users/BhaaLseN/followers","following_url":"https://api.github.com/users/BhaaLseN/following{/other_user}","gists_url":"https://api.github.com/users/BhaaLseN/gists{/gist_id}","starred_url":"https://api.github.com/users/BhaaLseN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BhaaLseN/subscriptions","organizations_url":"https://api.github.com/users/BhaaLseN/orgs","repos_url":"https://api.github.com/users/BhaaLseN/repos","events_url":"https://api.github.com/users/BhaaLseN/events{/privacy}","received_events_url":"https://api.github.com/users/BhaaLseN/received_events","type":"User","site_admin":false},"body":"Does it? We don't do it in other places either iirc.","created_at":"2015-01-04T22:58:13Z","updated_at":"2015-01-04T22:58:13Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1831#discussion_r22443683","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/22443683"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1831#discussion_r22443683"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831","id":26800214,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1831","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1831.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1831.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1831","number":1831,"state":"open","locked":false,"title":"[WIP] Remove MMU-hack, and always turn on MMU.","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"body":"Making the assumption that games never cause DSI or ISI exceptions doesn't provide much performance benefit, and keeping around the fake memory region makes improving our MMU implementation (e.g. adding a correct BAT implementation) difficult, and JIT modifications in general more complicated.\r\n\r\nAs a bonus, this makes it harder for games to crash Dolphin.\r\n\r\nProbably doesn't make sense to start seriously benchmarking/testing this until Fiora's latest batch of changes are merged; there are a couple of important changes in there which affect the performance of non-MMU games in MMU mode.  I want to start the discussion now, though, to make sure there isn't some other reason I'm missing to keep around MMU-disabled mode.\r\n\r\nThis patch doesn't remove all the code which checks `ADDR_MASK_MEM1` (0x20000000) because we still make assumptions about that bit in addresses even if we don't physically map a fake-vmem region; fixing that mess will probably be a followup to this patch.","created_at":"2015-01-04T22:06:01Z","updated_at":"2015-01-04T22:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23489265496dca3b7eda5e0f1da99b23d9e36d39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1831/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/b7c901522467703a109f942fb75a48bcf2cfdba5","head":{"label":"magumagu:always-mmu","ref":"always-mmu","sha":"b7c901522467703a109f942fb75a48bcf2cfdba5","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"repo":{"id":17995392,"name":"dolphin","full_name":"magumagu/dolphin","owner":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magumagu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/magumagu/dolphin","forks_url":"https://api.github.com/repos/magumagu/dolphin/forks","keys_url":"https://api.github.com/repos/magumagu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magumagu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magumagu/dolphin/teams","hooks_url":"https://api.github.com/repos/magumagu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/magumagu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/magumagu/dolphin/events","assignees_url":"https://api.github.com/repos/magumagu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/magumagu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/magumagu/dolphin/tags","blobs_url":"https://api.github.com/repos/magumagu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magumagu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magumagu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/magumagu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magumagu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/magumagu/dolphin/languages","stargazers_url":"https://api.github.com/repos/magumagu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/magumagu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/magumagu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/magumagu/dolphin/subscription","commits_url":"https://api.github.com/repos/magumagu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/magumagu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/magumagu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/magumagu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/magumagu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/magumagu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magumagu/dolphin/merges","archive_url":"https://api.github.com/repos/magumagu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magumagu/dolphin/downloads","issues_url":"https://api.github.com/repos/magumagu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/magumagu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/magumagu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/magumagu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magumagu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/magumagu/dolphin/releases{/id}","created_at":"2014-03-21T21:43:50Z","updated_at":"2015-01-02T05:29:49Z","pushed_at":"2015-01-03T23:47:06Z","git_url":"git://github.com/magumagu/dolphin.git","ssh_url":"git@github.com:magumagu/dolphin.git","clone_url":"https://github.com/magumagu/dolphin.git","svn_url":"https://github.com/magumagu/dolphin","homepage":null,"size":201781,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"upstream-master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"1b4b8367312aed04505a15e44cc66f784bed71da","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-01-04T21:45:31Z","pushed_at":"2015-01-04T21:45:31Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":249891,"stargazers_count":902,"watchers_count":902,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":72,"forks":288,"open_issues":72,"watchers":902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1831"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1831"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1831/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1831/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/b7c901522467703a109f942fb75a48bcf2cfdba5"}}}}