{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/40264805","id":40264805,"diff_hunk":"@@ -5,9 +5,33 @@\n Marionette.Application = Marionette.Object.extend({\n   cidPrefix: 'mna',\n \n+  rootEl: 'body',\n+\n+  constructor: function(options) {\n+    options = options || {};\n+\n+    this._initRootRegion(options);\n+\n+    Marionette.Object.prototype.constructor.apply(this, arguments);\n+  },\n+\n+  _initRootRegion: function(options) {\n+    var rootEl = options.rootEl || this.rootEl;","path":"src/application.js","position":15,"original_position":15,"commit_id":"fbc5c8bf94be1492e05d6c2a43188d93530a76e5","original_commit_id":"fbc5c8bf94be1492e05d6c2a43188d93530a76e5","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"```js\r\nvar rootEl = this.getOption('rootEl');\r\n```","created_at":"2015-09-23T22:13:03Z","updated_at":"2015-09-23T22:13:03Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2763#discussion_r40264805","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/40264805"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2763#discussion_r40264805"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763","id":45730179,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/2763","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/2763.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/2763.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2763","number":2763,"state":"open","locked":false,"title":"Introduce a \"rootEl\" property on the application object","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/marionettejs/backbone.marionette/issues/2279\r\n\r\nAlso https://github.com/marionettejs/backbone.marionette/issues/2326\r\n\r\nAlternate to https://github.com/marionettejs/backbone.marionette/pull/2757\r\n\r\nI think we want the rootEl to be a `Marionette.Region`.. otherwise we could be duplicating much of the region related code relating to a view's lifecycle and introducing new areas for regression.\r\n\r\n","created_at":"2015-09-22T23:32:50Z","updated_at":"2015-09-23T22:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79d24e1c8902d3c93f35ddd344fc1d68336421fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2763/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/fbc5c8bf94be1492e05d6c2a43188d93530a76e5","head":{"label":"paulfalgout:feature/app-root","ref":"feature/app-root","sha":"fbc5c8bf94be1492e05d6c2a43188d93530a76e5","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"repo":{"id":20825660,"name":"backbone.marionette","full_name":"paulfalgout/backbone.marionette","owner":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulfalgout/backbone.marionette","description":"Make your Backbone.js applications dance!","fork":true,"url":"https://api.github.com/repos/paulfalgout/backbone.marionette","forks_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/forks","keys_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/events","assignees_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/merges","archive_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/paulfalgout/backbone.marionette/releases{/id}","created_at":"2014-06-14T05:19:05Z","updated_at":"2014-07-01T06:11:27Z","pushed_at":"2015-09-23T21:59:29Z","git_url":"git://github.com/paulfalgout/backbone.marionette.git","ssh_url":"git@github.com:paulfalgout/backbone.marionette.git","clone_url":"https://github.com/paulfalgout/backbone.marionette.git","svn_url":"https://github.com/paulfalgout/backbone.marionette","homepage":"http://marionettejs.com","size":11647,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:next","ref":"next","sha":"cf389ec7a8bd62f5012dc2632546ca6784891142","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone Framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","created_at":"2011-12-12T16:36:09Z","updated_at":"2015-09-23T17:22:34Z","pushed_at":"2015-09-23T22:00:48Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":23021,"stargazers_count":6476,"watchers_count":6476,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1281,"mirror_url":null,"open_issues_count":119,"forks":1281,"open_issues":119,"watchers":6476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2763"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2763"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2763/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2763/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/fbc5c8bf94be1492e05d6c2a43188d93530a76e5"}}}}