{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40579644","id":40579644,"diff_hunk":"@@ -219,25 +232,27 @@ private long GetOptions(SslProtocols protocols)\n                 {\n                     outputBuffer.token = new byte[outputBuffer.size];\n                     Marshal.Copy(outputPtr, outputBuffer.token, 0, outputBuffer.size);\n-                    Marshal.FreeHGlobal(outputPtr);\n                 }\n                 else\n                 {\n                     outputBuffer.token = null;\n-                }      \n+                }\n+\n+                if (outputPtr != IntPtr.Zero)\n+                {\n+                     Marshal.FreeHGlobal(outputPtr);\n+                     outputPtr = IntPtr.Zero;\n+                }\n \n                 return done ? SecurityStatus.OK : SecurityStatus.ContinueNeeded;\n             }\n-            catch\n+            catch(Exception Ex)\n             {\n-                return SecurityStatus.InternalError;\n+                Debug.Fail(\"Exception Caught. StackTrace - \" +Ex.StackTrace);","path":"src/System.Net.Security/src/System/Net/Unix/SSPISecureChannelType.cs","position":106,"original_position":106,"commit_id":"024b41e614992eed7f716d3df6ee017c8d8707b6","original_commit_id":"024b41e614992eed7f716d3df6ee017c8d8707b6","user":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-09-28T17:27:37Z","updated_at":"2015-09-28T17:27:37Z","html_url":"https://github.com/dotnet/corefx/pull/3490#discussion_r40579644","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3490","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40579644"},"html":{"href":"https://github.com/dotnet/corefx/pull/3490#discussion_r40579644"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3490"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3490","id":46125841,"html_url":"https://github.com/dotnet/corefx/pull/3490","diff_url":"https://github.com/dotnet/corefx/pull/3490.diff","patch_url":"https://github.com/dotnet/corefx/pull/3490.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3490","number":3490,"state":"open","locked":false,"title":"Incorporated some comments - Net Secure Xplat Implementation","user":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"body":"This is same as \r\nhttps://github.com/dotnet/corefx/pull/3369\r\nComments have already been addressed/replied. Any new comments can be given here.\r\nSince it's pending for roughly ~6 days, would like a quick closure. Thanks.\r\n\r\nCreating a PR to dotnet/master as we will no longer be using dev-sslstream.\r\nI will squash the commits once,I get the sign off.","created_at":"2015-09-28T07:09:41Z","updated_at":"2015-09-28T17:27:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8807e5f395357f5b6e82a7d0663e2bc0701d3134","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3490/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3490/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3490/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/024b41e614992eed7f716d3df6ee017c8d8707b6","head":{"label":"rajansingh10:NetFeature2","ref":"NetFeature2","sha":"024b41e614992eed7f716d3df6ee017c8d8707b6","user":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"repo":{"id":40076943,"name":"corefx","full_name":"rajansingh10/corefx","owner":{"login":"rajansingh10","id":13608570,"avatar_url":"https://avatars.githubusercontent.com/u/13608570?v=3","gravatar_id":"","url":"https://api.github.com/users/rajansingh10","html_url":"https://github.com/rajansingh10","followers_url":"https://api.github.com/users/rajansingh10/followers","following_url":"https://api.github.com/users/rajansingh10/following{/other_user}","gists_url":"https://api.github.com/users/rajansingh10/gists{/gist_id}","starred_url":"https://api.github.com/users/rajansingh10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajansingh10/subscriptions","organizations_url":"https://api.github.com/users/rajansingh10/orgs","repos_url":"https://api.github.com/users/rajansingh10/repos","events_url":"https://api.github.com/users/rajansingh10/events{/privacy}","received_events_url":"https://api.github.com/users/rajansingh10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajansingh10/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/rajansingh10/corefx","forks_url":"https://api.github.com/repos/rajansingh10/corefx/forks","keys_url":"https://api.github.com/repos/rajansingh10/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajansingh10/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajansingh10/corefx/teams","hooks_url":"https://api.github.com/repos/rajansingh10/corefx/hooks","issue_events_url":"https://api.github.com/repos/rajansingh10/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/rajansingh10/corefx/events","assignees_url":"https://api.github.com/repos/rajansingh10/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/rajansingh10/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/rajansingh10/corefx/tags","blobs_url":"https://api.github.com/repos/rajansingh10/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajansingh10/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajansingh10/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajansingh10/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajansingh10/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/rajansingh10/corefx/languages","stargazers_url":"https://api.github.com/repos/rajansingh10/corefx/stargazers","contributors_url":"https://api.github.com/repos/rajansingh10/corefx/contributors","subscribers_url":"https://api.github.com/repos/rajansingh10/corefx/subscribers","subscription_url":"https://api.github.com/repos/rajansingh10/corefx/subscription","commits_url":"https://api.github.com/repos/rajansingh10/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajansingh10/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajansingh10/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajansingh10/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajansingh10/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/rajansingh10/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajansingh10/corefx/merges","archive_url":"https://api.github.com/repos/rajansingh10/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajansingh10/corefx/downloads","issues_url":"https://api.github.com/repos/rajansingh10/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/rajansingh10/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/rajansingh10/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/rajansingh10/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajansingh10/corefx/labels{/name}","releases_url":"https://api.github.com/repos/rajansingh10/corefx/releases{/id}","created_at":"2015-08-02T11:08:04Z","updated_at":"2015-08-02T11:08:22Z","pushed_at":"2015-09-28T07:51:20Z","git_url":"git://github.com/rajansingh10/corefx.git","ssh_url":"git@github.com:rajansingh10/corefx.git","clone_url":"https://github.com/rajansingh10/corefx.git","svn_url":"https://github.com/rajansingh10/corefx","homepage":"http://dotnet.github.io/core/","size":32563,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d64ed004af63e29d4469def79b4c4ba8cb66df63","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-09-28T16:20:02Z","pushed_at":"2015-09-28T16:51:42Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":73739,"stargazers_count":8390,"watchers_count":8390,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1818,"mirror_url":null,"open_issues_count":601,"forks":1818,"open_issues":601,"watchers":8390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3490"},"html":{"href":"https://github.com/dotnet/corefx/pull/3490"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3490"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3490/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3490/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3490/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/024b41e614992eed7f716d3df6ee017c8d8707b6"}}}}