{"action":"created","issue":{"url":"https://api.github.com/repos/datastax/python-driver/issues/448","labels_url":"https://api.github.com/repos/datastax/python-driver/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/datastax/python-driver/issues/448/comments","events_url":"https://api.github.com/repos/datastax/python-driver/issues/448/events","html_url":"https://github.com/datastax/python-driver/pull/448","id":119742760,"number":448,"title":"Add tornado reactor","user":{"login":"coldeasy","id":3442846,"avatar_url":"https://avatars.githubusercontent.com/u/3442846?v=3","gravatar_id":"","url":"https://api.github.com/users/coldeasy","html_url":"https://github.com/coldeasy","followers_url":"https://api.github.com/users/coldeasy/followers","following_url":"https://api.github.com/users/coldeasy/following{/other_user}","gists_url":"https://api.github.com/users/coldeasy/gists{/gist_id}","starred_url":"https://api.github.com/users/coldeasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coldeasy/subscriptions","organizations_url":"https://api.github.com/users/coldeasy/orgs","repos_url":"https://api.github.com/users/coldeasy/repos","events_url":"https://api.github.com/users/coldeasy/events{/privacy}","received_events_url":"https://api.github.com/users/coldeasy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-01T15:38:52Z","updated_at":"2015-12-03T17:53:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/datastax/python-driver/pulls/448","html_url":"https://github.com/datastax/python-driver/pull/448","diff_url":"https://github.com/datastax/python-driver/pull/448.diff","patch_url":"https://github.com/datastax/python-driver/pull/448.patch"},"body":"- Adds basic integration with tornado, creating a separate ioloop in a separate thread\r\n- TODO add tests, cleanup"},"comment":{"url":"https://api.github.com/repos/datastax/python-driver/issues/comments/161730647","html_url":"https://github.com/datastax/python-driver/pull/448#issuecomment-161730647","issue_url":"https://api.github.com/repos/datastax/python-driver/issues/448","id":161730647,"user":{"login":"aholmberg","id":1443722,"avatar_url":"https://avatars.githubusercontent.com/u/1443722?v=3","gravatar_id":"","url":"https://api.github.com/users/aholmberg","html_url":"https://github.com/aholmberg","followers_url":"https://api.github.com/users/aholmberg/followers","following_url":"https://api.github.com/users/aholmberg/following{/other_user}","gists_url":"https://api.github.com/users/aholmberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aholmberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aholmberg/subscriptions","organizations_url":"https://api.github.com/users/aholmberg/orgs","repos_url":"https://api.github.com/users/aholmberg/repos","events_url":"https://api.github.com/users/aholmberg/events{/privacy}","received_events_url":"https://api.github.com/users/aholmberg/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T17:53:21Z","updated_at":"2015-12-03T17:53:21Z","body":"@coldeasy we always appreciate feature contributions, but we may not be able to accept a new IO reactor at this time. We have much to do, with limited resources, and new reactors multiply the surface area for test, maintenance and support.\r\n\r\nThe existing reactors (save Twisted) are maintained internally because each removes a barrier to entry for a broad class of applications (for example, gevent is required for applications with monkey patching active). I am not aware of anything in the Tornado framework that precludes using one of the existing core reactors inside the driver (e.g. asyncore or libev -- correct me if I'm wrong).\r\n\r\nIs this reactor something you might consider maintaining in a separate contrib repository? We could reference that from the project docs if you're interested."}}