{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/24120137","id":24120137,"diff_hunk":"@@ -137,8 +137,7 @@ the view in a Region causes it to be attached to the `document`. Like other Mari\n executes a callback method, `onAttach`, if you've specified one. The `\"attach\"` event is great for jQuery\n plugins or other logic that must be executed *after* the view is attached to the `document`.\n \n-Because the `attach` event is only fired when the view is a child of the `document`, it is a requirement\n-that the Region you're showing it in be a child of the `document` at the time that you call `show`.\n+The `attach` event is only fired when the view becomes a child of the `document`. If the Region you're showing the view in is not a child of the `document` at the time that you call `show` then the `attach` event will not fire until the Region becomes a child of the `document`.","path":"docs/marionette.view.md","position":6,"original_position":6,"commit_id":"a2b75a006ee3386999467cb84881d4f1cbcb711f","original_commit_id":"a2b75a006ee3386999467cb84881d4f1cbcb711f","user":{"login":"thejameskyle","id":952783,"avatar_url":"https://avatars.githubusercontent.com/u/952783?v=3","gravatar_id":"","url":"https://api.github.com/users/thejameskyle","html_url":"https://github.com/thejameskyle","followers_url":"https://api.github.com/users/thejameskyle/followers","following_url":"https://api.github.com/users/thejameskyle/following{/other_user}","gists_url":"https://api.github.com/users/thejameskyle/gists{/gist_id}","starred_url":"https://api.github.com/users/thejameskyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thejameskyle/subscriptions","organizations_url":"https://api.github.com/users/thejameskyle/orgs","repos_url":"https://api.github.com/users/thejameskyle/repos","events_url":"https://api.github.com/users/thejameskyle/events{/privacy}","received_events_url":"https://api.github.com/users/thejameskyle/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2015-02-04T21:14:27Z","updated_at":"2015-02-04T21:14:27Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/2277#discussion_r24120137","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/24120137"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2277#discussion_r24120137"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277","id":28674369,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/2277","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/2277.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/2277.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2277","number":2277,"state":"open","locked":false,"title":"Clairfy 'onAttach' documentation","user":{"login":"MeoMix","id":1380995,"avatar_url":"https://avatars.githubusercontent.com/u/1380995?v=3","gravatar_id":"","url":"https://api.github.com/users/MeoMix","html_url":"https://github.com/MeoMix","followers_url":"https://api.github.com/users/MeoMix/followers","following_url":"https://api.github.com/users/MeoMix/following{/other_user}","gists_url":"https://api.github.com/users/MeoMix/gists{/gist_id}","starred_url":"https://api.github.com/users/MeoMix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeoMix/subscriptions","organizations_url":"https://api.github.com/users/MeoMix/orgs","repos_url":"https://api.github.com/users/MeoMix/repos","events_url":"https://api.github.com/users/MeoMix/events{/privacy}","received_events_url":"https://api.github.com/users/MeoMix/received_events","type":"User","site_admin":false},"body":"This change is intended to resolve #2208. The original language used was misleading to me.","created_at":"2015-02-04T20:58:50Z","updated_at":"2015-02-04T21:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f85d4b55650ee90698f9bf215f7bcfee5423c8a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2277/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/a2b75a006ee3386999467cb84881d4f1cbcb711f","head":{"label":"MeoMix:patch-1","ref":"patch-1","sha":"a2b75a006ee3386999467cb84881d4f1cbcb711f","user":{"login":"MeoMix","id":1380995,"avatar_url":"https://avatars.githubusercontent.com/u/1380995?v=3","gravatar_id":"","url":"https://api.github.com/users/MeoMix","html_url":"https://github.com/MeoMix","followers_url":"https://api.github.com/users/MeoMix/followers","following_url":"https://api.github.com/users/MeoMix/following{/other_user}","gists_url":"https://api.github.com/users/MeoMix/gists{/gist_id}","starred_url":"https://api.github.com/users/MeoMix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeoMix/subscriptions","organizations_url":"https://api.github.com/users/MeoMix/orgs","repos_url":"https://api.github.com/users/MeoMix/repos","events_url":"https://api.github.com/users/MeoMix/events{/privacy}","received_events_url":"https://api.github.com/users/MeoMix/received_events","type":"User","site_admin":false},"repo":{"id":30320637,"name":"backbone.marionette","full_name":"MeoMix/backbone.marionette","owner":{"login":"MeoMix","id":1380995,"avatar_url":"https://avatars.githubusercontent.com/u/1380995?v=3","gravatar_id":"","url":"https://api.github.com/users/MeoMix","html_url":"https://github.com/MeoMix","followers_url":"https://api.github.com/users/MeoMix/followers","following_url":"https://api.github.com/users/MeoMix/following{/other_user}","gists_url":"https://api.github.com/users/MeoMix/gists{/gist_id}","starred_url":"https://api.github.com/users/MeoMix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeoMix/subscriptions","organizations_url":"https://api.github.com/users/MeoMix/orgs","repos_url":"https://api.github.com/users/MeoMix/repos","events_url":"https://api.github.com/users/MeoMix/events{/privacy}","received_events_url":"https://api.github.com/users/MeoMix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MeoMix/backbone.marionette","description":"The Backbone Framework","fork":true,"url":"https://api.github.com/repos/MeoMix/backbone.marionette","forks_url":"https://api.github.com/repos/MeoMix/backbone.marionette/forks","keys_url":"https://api.github.com/repos/MeoMix/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeoMix/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeoMix/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/MeoMix/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/MeoMix/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/MeoMix/backbone.marionette/events","assignees_url":"https://api.github.com/repos/MeoMix/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/MeoMix/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/MeoMix/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/MeoMix/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeoMix/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeoMix/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeoMix/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeoMix/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/MeoMix/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/MeoMix/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/MeoMix/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/MeoMix/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/MeoMix/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/MeoMix/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeoMix/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeoMix/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeoMix/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/MeoMix/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/MeoMix/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeoMix/backbone.marionette/merges","archive_url":"https://api.github.com/repos/MeoMix/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeoMix/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/MeoMix/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/MeoMix/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/MeoMix/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/MeoMix/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeoMix/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/MeoMix/backbone.marionette/releases{/id}","created_at":"2015-02-04T20:54:13Z","updated_at":"2015-02-04T20:54:14Z","pushed_at":"2015-02-04T20:58:32Z","git_url":"git://github.com/MeoMix/backbone.marionette.git","ssh_url":"git@github.com:MeoMix/backbone.marionette.git","clone_url":"https://github.com/MeoMix/backbone.marionette.git","svn_url":"https://github.com/MeoMix/backbone.marionette","homepage":"http://marionettejs.com","size":20690,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:master","ref":"master","sha":"586335228295b32cb08fdf17b0af74711edc8dfe","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone Framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments/{number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","created_at":"2011-12-12T16:36:09Z","updated_at":"2015-02-04T20:32:18Z","pushed_at":"2015-02-04T20:28:52Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":20690,"stargazers_count":5830,"watchers_count":5830,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1083,"mirror_url":null,"open_issues_count":103,"forks":1083,"open_issues":103,"watchers":5830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/2277"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2277"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/2277/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/2277/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/a2b75a006ee3386999467cb84881d4f1cbcb711f"}}}}