{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/43884613","id":43884613,"diff_hunk":"@@ -3042,8 +3048,8 @@ function oncontroller_testsetup()\n     fi\n \n     # wait for image to finish uploading\n-    imageid=`perl -ne \"m/ id [ |]*([0-9a-f-]+)/ && print \\\\$1\" glance.out`\n-    if [ \"x$imageid\" == \"x\" ]; then\n+    imageid=$(glance_image_get_id $image_name)\n+    if [[ -z $imageid ]]; then","path":"scripts/qa_crowbarsetup.sh","position":68,"original_position":68,"commit_id":"bfe581ae52f62c0a52de85bee543aa92331aa738","original_commit_id":"bfe581ae52f62c0a52de85bee543aa92331aa738","user":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"body":"yep, that's nicer. Updating PR.","created_at":"2015-11-04T14:16:09Z","updated_at":"2015-11-04T14:16:09Z","html_url":"https://github.com/SUSE-Cloud/automation/pull/636#discussion_r43884613","pull_request_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636","_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/43884613"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/636#discussion_r43884613"},"pull_request":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636","id":49041282,"html_url":"https://github.com/SUSE-Cloud/automation/pull/636","diff_url":"https://github.com/SUSE-Cloud/automation/pull/636.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/636.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/636","number":636,"state":"open","locked":false,"title":"Using glance image instead of openstack image","user":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"body":"With Liberty, the openstack CLI is not able to retrieve and image by\r\nits name, as it is used in qa_crowbarsetup.sh. This patch substitutes\r\nthose calls to glance image commands.","created_at":"2015-10-28T17:40:35Z","updated_at":"2015-11-04T14:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e4bc3c01695d5e0f99b9c40b482ddc85680d784","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/636/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/bfe581ae52f62c0a52de85bee543aa92331aa738","head":{"label":"abel-navarro:to_glance","ref":"to_glance","sha":"bfe581ae52f62c0a52de85bee543aa92331aa738","user":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"repo":{"id":42574280,"name":"automation","full_name":"abel-navarro/automation","owner":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abel-navarro/automation","description":"Automation scripts for development, testing, and CI","fork":true,"url":"https://api.github.com/repos/abel-navarro/automation","forks_url":"https://api.github.com/repos/abel-navarro/automation/forks","keys_url":"https://api.github.com/repos/abel-navarro/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abel-navarro/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abel-navarro/automation/teams","hooks_url":"https://api.github.com/repos/abel-navarro/automation/hooks","issue_events_url":"https://api.github.com/repos/abel-navarro/automation/issues/events{/number}","events_url":"https://api.github.com/repos/abel-navarro/automation/events","assignees_url":"https://api.github.com/repos/abel-navarro/automation/assignees{/user}","branches_url":"https://api.github.com/repos/abel-navarro/automation/branches{/branch}","tags_url":"https://api.github.com/repos/abel-navarro/automation/tags","blobs_url":"https://api.github.com/repos/abel-navarro/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abel-navarro/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abel-navarro/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/abel-navarro/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abel-navarro/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/abel-navarro/automation/languages","stargazers_url":"https://api.github.com/repos/abel-navarro/automation/stargazers","contributors_url":"https://api.github.com/repos/abel-navarro/automation/contributors","subscribers_url":"https://api.github.com/repos/abel-navarro/automation/subscribers","subscription_url":"https://api.github.com/repos/abel-navarro/automation/subscription","commits_url":"https://api.github.com/repos/abel-navarro/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/abel-navarro/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/abel-navarro/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/abel-navarro/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/abel-navarro/automation/contents/{+path}","compare_url":"https://api.github.com/repos/abel-navarro/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abel-navarro/automation/merges","archive_url":"https://api.github.com/repos/abel-navarro/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abel-navarro/automation/downloads","issues_url":"https://api.github.com/repos/abel-navarro/automation/issues{/number}","pulls_url":"https://api.github.com/repos/abel-navarro/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/abel-navarro/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/abel-navarro/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abel-navarro/automation/labels{/name}","releases_url":"https://api.github.com/repos/abel-navarro/automation/releases{/id}","created_at":"2015-09-16T08:19:01Z","updated_at":"2015-09-16T08:19:02Z","pushed_at":"2015-11-04T09:30:37Z","git_url":"git://github.com/abel-navarro/automation.git","ssh_url":"git@github.com:abel-navarro/automation.git","clone_url":"https://github.com/abel-navarro/automation.git","svn_url":"https://github.com/abel-navarro/automation","homepage":"","size":3905,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:master","ref":"master","sha":"547a4b7e875614be30af5eb6594dac559d970ba1","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6384356,"name":"automation","full_name":"SUSE-Cloud/automation","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/automation","description":"Automation scripts for development, testing, and CI","fork":false,"url":"https://api.github.com/repos/SUSE-Cloud/automation","forks_url":"https://api.github.com/repos/SUSE-Cloud/automation/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/automation/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/automation/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/automation/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/automation/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/automation/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/automation/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/automation/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/automation/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/automation/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/automation/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/automation/releases{/id}","created_at":"2012-10-25T08:45:31Z","updated_at":"2015-07-08T13:11:06Z","pushed_at":"2015-11-04T13:57:23Z","git_url":"git://github.com/SUSE-Cloud/automation.git","ssh_url":"git@github.com:SUSE-Cloud/automation.git","clone_url":"https://github.com/SUSE-Cloud/automation.git","svn_url":"https://github.com/SUSE-Cloud/automation","homepage":"","size":8825,"stargazers_count":12,"watchers_count":12,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":14,"forks":40,"open_issues":14,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/636"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/636"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/bfe581ae52f62c0a52de85bee543aa92331aa738"}}}}