{"action":"created","comment":{"url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/comments/36191239","id":36191239,"diff_hunk":"@@ -113,6 +112,10 @@ var BrowserStackBrowser = function(id, emitter, args, logger,\n              process.env.BUILD_TAG || process.env.CIRCLE_BUILD_NUM || null\n     };\n \n+    if (args.real_mobile) {","path":"index.js","position":null,"original_position":12,"commit_id":"fbd0bb1746e3635a1a44faa587759a3294ffd270","original_commit_id":"9b120c94a9feb3358d11fbf3b6e2a14cd8da1d6b","user":{"login":"donato","id":939778,"avatar_url":"https://avatars.githubusercontent.com/u/939778?v=3","gravatar_id":"","url":"https://api.github.com/users/donato","html_url":"https://github.com/donato","followers_url":"https://api.github.com/users/donato/followers","following_url":"https://api.github.com/users/donato/following{/other_user}","gists_url":"https://api.github.com/users/donato/gists{/gist_id}","starred_url":"https://api.github.com/users/donato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donato/subscriptions","organizations_url":"https://api.github.com/users/donato/orgs","repos_url":"https://api.github.com/users/donato/repos","events_url":"https://api.github.com/users/donato/events{/privacy}","received_events_url":"https://api.github.com/users/donato/received_events","type":"User","site_admin":false},"body":"Good point. I decided to move in the direction of \"if set\", which covers us if BrowserStack starts allowing booleans.\r\n\r\n","created_at":"2015-08-04T14:07:40Z","updated_at":"2015-08-04T14:07:40Z","html_url":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34#discussion_r36191239","pull_request_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/comments/36191239"},"html":{"href":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34#discussion_r36191239"},"pull_request":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34","id":41571987,"html_url":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34","diff_url":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34.diff","patch_url":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34.patch","issue_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/34","number":34,"state":"open","locked":false,"title":"Do not use a default value for \"real_mobile\"","user":{"login":"donato","id":939778,"avatar_url":"https://avatars.githubusercontent.com/u/939778?v=3","gravatar_id":"","url":"https://api.github.com/users/donato","html_url":"https://github.com/donato","followers_url":"https://api.github.com/users/donato/followers","following_url":"https://api.github.com/users/donato/following{/other_user}","gists_url":"https://api.github.com/users/donato/gists{/gist_id}","starred_url":"https://api.github.com/users/donato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donato/subscriptions","organizations_url":"https://api.github.com/users/donato/orgs","repos_url":"https://api.github.com/users/donato/repos","events_url":"https://api.github.com/users/donato/events{/privacy}","received_events_url":"https://api.github.com/users/donato/received_events","type":"User","site_admin":false},"body":"Since the default changes based on the type of device on browserstack,\r\nwe cannot know the correct default. For this reason we will only use the\r\nvalue when given.\r\n\r\nhttps://github.com/karma-runner/karma-browserstack-launcher/issues/33","created_at":"2015-08-04T13:54:53Z","updated_at":"2015-08-04T14:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ea510bd7981d478830ba416a0c1314f3d22e546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34/commits","review_comments_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34/comments","review_comment_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/34/comments","statuses_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/statuses/fbd0bb1746e3635a1a44faa587759a3294ffd270","head":{"label":"karma-runner:bugfix/real-mobile","ref":"bugfix/real-mobile","sha":"fbd0bb1746e3635a1a44faa587759a3294ffd270","user":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"repo":{"id":11941666,"name":"karma-browserstack-launcher","full_name":"karma-runner/karma-browserstack-launcher","owner":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karma-runner/karma-browserstack-launcher","description":"A Karma plugin. Launch any browser on BrowserStack!","fork":false,"url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher","forks_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/forks","keys_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/teams","hooks_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/hooks","issue_events_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/events{/number}","events_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/events","assignees_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/assignees{/user}","branches_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/branches{/branch}","tags_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/tags","blobs_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/languages","stargazers_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/stargazers","contributors_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/contributors","subscribers_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/subscribers","subscription_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/subscription","commits_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/contents/{+path}","compare_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/merges","archive_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/downloads","issues_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues{/number}","pulls_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/labels{/name}","releases_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/releases{/id}","created_at":"2013-08-07T04:51:53Z","updated_at":"2015-07-29T13:53:32Z","pushed_at":"2015-08-04T14:05:12Z","git_url":"git://github.com/karma-runner/karma-browserstack-launcher.git","ssh_url":"git@github.com:karma-runner/karma-browserstack-launcher.git","clone_url":"https://github.com/karma-runner/karma-browserstack-launcher.git","svn_url":"https://github.com/karma-runner/karma-browserstack-launcher","homepage":null,"size":527,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":49,"default_branch":"master"}},"base":{"label":"karma-runner:master","ref":"master","sha":"21fc5739dcff1caf8080d5b0dafef675017ad32e","user":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"repo":{"id":11941666,"name":"karma-browserstack-launcher","full_name":"karma-runner/karma-browserstack-launcher","owner":{"login":"karma-runner","id":3284117,"avatar_url":"https://avatars.githubusercontent.com/u/3284117?v=3","gravatar_id":"","url":"https://api.github.com/users/karma-runner","html_url":"https://github.com/karma-runner","followers_url":"https://api.github.com/users/karma-runner/followers","following_url":"https://api.github.com/users/karma-runner/following{/other_user}","gists_url":"https://api.github.com/users/karma-runner/gists{/gist_id}","starred_url":"https://api.github.com/users/karma-runner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karma-runner/subscriptions","organizations_url":"https://api.github.com/users/karma-runner/orgs","repos_url":"https://api.github.com/users/karma-runner/repos","events_url":"https://api.github.com/users/karma-runner/events{/privacy}","received_events_url":"https://api.github.com/users/karma-runner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karma-runner/karma-browserstack-launcher","description":"A Karma plugin. Launch any browser on BrowserStack!","fork":false,"url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher","forks_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/forks","keys_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/teams","hooks_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/hooks","issue_events_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/events{/number}","events_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/events","assignees_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/assignees{/user}","branches_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/branches{/branch}","tags_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/tags","blobs_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/statuses/{sha}","languages_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/languages","stargazers_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/stargazers","contributors_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/contributors","subscribers_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/subscribers","subscription_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/subscription","commits_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/contents/{+path}","compare_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/merges","archive_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/downloads","issues_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues{/number}","pulls_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls{/number}","milestones_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/milestones{/number}","notifications_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/labels{/name}","releases_url":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/releases{/id}","created_at":"2013-08-07T04:51:53Z","updated_at":"2015-07-29T13:53:32Z","pushed_at":"2015-08-04T14:05:12Z","git_url":"git://github.com/karma-runner/karma-browserstack-launcher.git","ssh_url":"git@github.com:karma-runner/karma-browserstack-launcher.git","clone_url":"https://github.com/karma-runner/karma-browserstack-launcher.git","svn_url":"https://github.com/karma-runner/karma-browserstack-launcher","homepage":null,"size":527,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34"},"html":{"href":"https://github.com/karma-runner/karma-browserstack-launcher/pull/34"},"issue":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/34"},"comments":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/karma-runner/karma-browserstack-launcher/statuses/fbd0bb1746e3635a1a44faa587759a3294ffd270"}}}}