{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/46144144","id":46144144,"diff_hunk":"@@ -288,36 +303,60 @@ Query query( String keyOrNull, Object value, QueryContext contextOrNull )\n \n     abstract void addToDocument( Document document, String key, Object value );\n \n-    public static Fieldable instantiateField( String key, Object value, Index analyzed )\n+    public static IndexableField instantiateField( String key, Object value, FieldType fieldType )\n     {\n-        Fieldable field;\n+        IndexableField field;\n         if ( value instanceof Number )\n         {\n             Number number = (Number) value;\n-            NumericField numberField = new NumericField( key, Store.YES, true );\n             if ( value instanceof Long )\n             {\n-                numberField.setLongValue( number.longValue() );\n+                field = new LongField( key, number.longValue(), Store.YES );\n             }\n             else if ( value instanceof Float )\n             {\n-                numberField.setFloatValue( number.floatValue() );\n+                field = new FloatField( key, number.floatValue(), Store.YES );\n             }\n             else if ( value instanceof Double )\n             {\n-                numberField.setDoubleValue( number.doubleValue() );\n+                field = new DoubleField( key, number.doubleValue(), Store.YES );\n             }\n             else\n             {\n-                numberField.setIntValue( number.intValue() );\n+                field = new IntField( key, number.intValue(), Store.YES );\n             }\n-            field = numberField;\n         }\n         else\n         {\n-            field = new Field( key, value.toString(), Store.YES, analyzed );\n+            field = new Field( key, value.toString(), fieldType );\n+        }\n+        // TODO: ensure  omitNorms on fieldType?","path":"community/lucene-index/src/main/java/org/neo4j/index/lucene/legacy/IndexType.java","position":172,"original_position":172,"commit_id":"a132d0311fa61e48fb545e42d40ef64f6c15acfc","original_commit_id":"96f7e53766c4c18a521da00dbe668b1a7a5f13e0","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"@tinwelint  currently people can create fields with omitNorms false and can have a functionality that depends on it, do no think that we can and to remove it. wdyt?","created_at":"2015-11-30T13:50:23Z","updated_at":"2015-11-30T13:50:23Z","html_url":"https://github.com/neo4j/neo4j/pull/5861#discussion_r46144144","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5861","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/46144144"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5861#discussion_r46144144"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5861"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5861","id":49981148,"html_url":"https://github.com/neo4j/neo4j/pull/5861","diff_url":"https://github.com/neo4j/neo4j/pull/5861.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5861.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5861","number":5861,"state":"open","locked":false,"title":"Neo4j upgrade to lucene 5","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"To be able to use new lucene features and improvements,\r\ncleanup legacy code that was written for old no longer supported 3.6.2 version\r\nwe giving a try to migrate neo to latest 5.x available version.\r\n\r\nThis change set represent only part of required work and includes:\r\nchanges done by Paul Horn, fix of failed tests (excluding upgrade testing - those are disabled)\r\n\r\nThis change does not include cleanups/rethinking/logic update/compatibility code and should only be treated as baseline.","created_at":"2015-11-06T17:26:52Z","updated_at":"2015-11-30T13:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34e4452d172bcf57589d4bbf80ec0881f82b7239","assignee":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5861/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5861/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5861/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/a132d0311fa61e48fb545e42d40ef64f6c15acfc","head":{"label":"MishaDemianenko:3.0-lucene5-migration","ref":"3.0-lucene5-migration","sha":"a132d0311fa61e48fb545e42d40ef64f6c15acfc","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"repo":{"id":36607274,"name":"neo4j","full_name":"MishaDemianenko/neo4j","owner":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishaDemianenko/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/MishaDemianenko/neo4j","forks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/forks","keys_url":"https://api.github.com/repos/MishaDemianenko/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishaDemianenko/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishaDemianenko/neo4j/teams","hooks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/hooks","issue_events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/events","assignees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/MishaDemianenko/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/tags","blobs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishaDemianenko/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MishaDemianenko/neo4j/languages","stargazers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/stargazers","contributors_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contributors","subscribers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscribers","subscription_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscription","commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/MishaDemianenko/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishaDemianenko/neo4j/merges","archive_url":"https://api.github.com/repos/MishaDemianenko/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishaDemianenko/neo4j/downloads","issues_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/MishaDemianenko/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MishaDemianenko/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MishaDemianenko/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishaDemianenko/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/MishaDemianenko/neo4j/releases{/id}","created_at":"2015-05-31T14:44:24Z","updated_at":"2015-05-31T14:44:50Z","pushed_at":"2015-11-30T12:32:23Z","git_url":"git://github.com/MishaDemianenko/neo4j.git","ssh_url":"git@github.com:MishaDemianenko/neo4j.git","clone_url":"https://github.com/MishaDemianenko/neo4j.git","svn_url":"https://github.com/MishaDemianenko/neo4j","homepage":"http://neo4j.com","size":266666,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"80d4838dc716483d09830f397d3cc4c1d0f571b2","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-11-30T07:24:43Z","pushed_at":"2015-11-30T13:48:27Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":312054,"stargazers_count":2154,"watchers_count":2154,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":796,"mirror_url":null,"open_issues_count":504,"forks":796,"open_issues":504,"watchers":2154,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5861"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5861"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5861"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5861/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5861/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5861/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/a132d0311fa61e48fb545e42d40ef64f6c15acfc"}}}}