{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel.py/pulls/comments/25562003","id":25562003,"diff_hunk":"@@ -18,10 +22,103 @@ class CallRequestMessage(BaseMessage):\n         'trace_id',\n \n         'traceflags',\n+\n         'service',\n         'headers',\n \n-        'arg1',\n-        'arg2',\n-        'arg3',\n+        'checksum_type',\n+        'checksum',\n+\n+        'arg_1',\n+        'arg_2',\n+        'arg_3',\n     )\n+\n+    FLAGS_SIZE = 1\n+    TTL_SIZE = 4\n+    TRACE_SIZE = 8\n+    TRACEFLAGS_SIZE = 1\n+    SERVICE_SIZE = 2\n+    NH_SIZE = 1\n+    HEADER_SIZE = 1\n+    CSUMTYPE_SIZE = 1\n+    CSUM_SIZE = 4\n+\n+    ARG_SIZE = 2\n+\n+    def parse(self, payload, size):\n+        \"\"\"Parse a call request message from a payload.\"\"\"\n+        self.flags = read_number(payload, self.FLAGS_SIZE)\n+        self.ttl = read_number(payload, self.TTL_SIZE)\n+\n+        self.span_id = read_number(payload, self.TRACE_SIZE)\n+        self.parent_id = read_number(payload, self.TRACE_SIZE)\n+        self.trace_id = read_number(payload, self.TRACE_SIZE)\n+\n+        self.traceflags = read_number(payload, self.TRACEFLAGS_SIZE)\n+\n+        self.service, _ = read_variable_length_key(payload, self.SERVICE_SIZE)\n+\n+        self.headers, _ = self._read_headers(\n+            payload,\n+            self.NH_SIZE,\n+            self.HEADER_SIZE,\n+        )\n+\n+        self.checksum_type = read_number(payload, self.CSUMTYPE_SIZE)\n+        if self.checksum_type:\n+            self.checksum = read_number(payload, self.CSUM_SIZE)","path":"tchannel/messages/call_request.py","position":63,"original_position":63,"commit_id":"521cfacd74a119dc72f8ecd774e204f7e4762c69","original_commit_id":"521cfacd74a119dc72f8ecd774e204f7e4762c69","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"add a todo about verifying arg_1, arg_2, arg_3 against the checksum ?","created_at":"2015-02-28T22:43:13Z","updated_at":"2015-02-28T22:43:13Z","html_url":"https://github.com/uber/tchannel.py/pull/28#discussion_r25562003","pull_request_url":"https://api.github.com/repos/uber/tchannel.py/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/comments/25562003"},"html":{"href":"https://github.com/uber/tchannel.py/pull/28#discussion_r25562003"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel.py/pulls/28","id":30201077,"html_url":"https://github.com/uber/tchannel.py/pull/28","diff_url":"https://github.com/uber/tchannel.py/pull/28.diff","patch_url":"https://github.com/uber/tchannel.py/pull/28.patch","issue_url":"https://api.github.com/repos/uber/tchannel.py/issues/28","number":28,"state":"open","locked":false,"title":"Add call request body round-tripping","user":{"login":"sectioneight","id":97087,"avatar_url":"https://avatars.githubusercontent.com/u/97087?v=3","gravatar_id":"","url":"https://api.github.com/users/sectioneight","html_url":"https://github.com/sectioneight","followers_url":"https://api.github.com/users/sectioneight/followers","following_url":"https://api.github.com/users/sectioneight/following{/other_user}","gists_url":"https://api.github.com/users/sectioneight/gists{/gist_id}","starred_url":"https://api.github.com/users/sectioneight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sectioneight/subscriptions","organizations_url":"https://api.github.com/users/sectioneight/orgs","repos_url":"https://api.github.com/users/sectioneight/repos","events_url":"https://api.github.com/users/sectioneight/events{/privacy}","received_events_url":"https://api.github.com/users/sectioneight/received_events","type":"User","site_admin":false},"body":"This implements happy-path round-tripping for CallRequest messages and\nfixes a bug or two along the way. It also adds a deserialization step to\nthe message tests to ensure symmetry in implementations.\n\n@uber/soap","created_at":"2015-02-27T21:08:41Z","updated_at":"2015-02-28T22:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98baeb8caf65ac848e9e0235ceec6342392dd61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel.py/pulls/28/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel.py/pulls/28/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel.py/issues/28/comments","statuses_url":"https://api.github.com/repos/uber/tchannel.py/statuses/521cfacd74a119dc72f8ecd774e204f7e4762c69","head":{"label":"uber:calls","ref":"calls","sha":"521cfacd74a119dc72f8ecd774e204f7e4762c69","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":30721622,"name":"tchannel.py","full_name":"uber/tchannel.py","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel.py","description":"Network multiplexing and framing protocol for RPC - Python edition","fork":false,"url":"https://api.github.com/repos/uber/tchannel.py","forks_url":"https://api.github.com/repos/uber/tchannel.py/forks","keys_url":"https://api.github.com/repos/uber/tchannel.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel.py/teams","hooks_url":"https://api.github.com/repos/uber/tchannel.py/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel.py/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel.py/events","assignees_url":"https://api.github.com/repos/uber/tchannel.py/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel.py/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel.py/tags","blobs_url":"https://api.github.com/repos/uber/tchannel.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel.py/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel.py/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel.py/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel.py/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel.py/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel.py/subscription","commits_url":"https://api.github.com/repos/uber/tchannel.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel.py/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel.py/merges","archive_url":"https://api.github.com/repos/uber/tchannel.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel.py/downloads","issues_url":"https://api.github.com/repos/uber/tchannel.py/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel.py/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel.py/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel.py/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel.py/releases{/id}","created_at":"2015-02-12T20:16:59Z","updated_at":"2015-02-27T18:52:25Z","pushed_at":"2015-02-27T21:27:00Z","git_url":"git://github.com/uber/tchannel.py.git","ssh_url":"git@github.com:uber/tchannel.py.git","clone_url":"https://github.com/uber/tchannel.py.git","svn_url":"https://github.com/uber/tchannel.py","homepage":"http://tchannel.readthedocs.org","size":412,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"5def9aba884293f403bb8bd53107ac97f13c72e1","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":30721622,"name":"tchannel.py","full_name":"uber/tchannel.py","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel.py","description":"Network multiplexing and framing protocol for RPC - Python edition","fork":false,"url":"https://api.github.com/repos/uber/tchannel.py","forks_url":"https://api.github.com/repos/uber/tchannel.py/forks","keys_url":"https://api.github.com/repos/uber/tchannel.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel.py/teams","hooks_url":"https://api.github.com/repos/uber/tchannel.py/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel.py/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel.py/events","assignees_url":"https://api.github.com/repos/uber/tchannel.py/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel.py/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel.py/tags","blobs_url":"https://api.github.com/repos/uber/tchannel.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel.py/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel.py/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel.py/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel.py/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel.py/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel.py/subscription","commits_url":"https://api.github.com/repos/uber/tchannel.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel.py/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel.py/merges","archive_url":"https://api.github.com/repos/uber/tchannel.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel.py/downloads","issues_url":"https://api.github.com/repos/uber/tchannel.py/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel.py/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel.py/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel.py/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel.py/releases{/id}","created_at":"2015-02-12T20:16:59Z","updated_at":"2015-02-27T18:52:25Z","pushed_at":"2015-02-27T21:27:00Z","git_url":"git://github.com/uber/tchannel.py.git","ssh_url":"git@github.com:uber/tchannel.py.git","clone_url":"https://github.com/uber/tchannel.py.git","svn_url":"https://github.com/uber/tchannel.py","homepage":"http://tchannel.readthedocs.org","size":412,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/28"},"html":{"href":"https://github.com/uber/tchannel.py/pull/28"},"issue":{"href":"https://api.github.com/repos/uber/tchannel.py/issues/28"},"comments":{"href":"https://api.github.com/repos/uber/tchannel.py/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel.py/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel.py/statuses/521cfacd74a119dc72f8ecd774e204f7e4762c69"}}}}