{"action":"created","issue":{"url":"https://api.github.com/repos/knolleary/pubsubclient/issues/70","labels_url":"https://api.github.com/repos/knolleary/pubsubclient/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/knolleary/pubsubclient/issues/70/comments","events_url":"https://api.github.com/repos/knolleary/pubsubclient/issues/70/events","html_url":"https://github.com/knolleary/pubsubclient/issues/70","id":103556292,"number":70,"title":"Library doesn't compile for ESP8266","user":{"login":"l-sch","id":5341193,"avatar_url":"https://avatars.githubusercontent.com/u/5341193?v=3","gravatar_id":"","url":"https://api.github.com/users/l-sch","html_url":"https://github.com/l-sch","followers_url":"https://api.github.com/users/l-sch/followers","following_url":"https://api.github.com/users/l-sch/following{/other_user}","gists_url":"https://api.github.com/users/l-sch/gists{/gist_id}","starred_url":"https://api.github.com/users/l-sch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l-sch/subscriptions","organizations_url":"https://api.github.com/users/l-sch/orgs","repos_url":"https://api.github.com/users/l-sch/repos","events_url":"https://api.github.com/users/l-sch/events{/privacy}","received_events_url":"https://api.github.com/users/l-sch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-27T17:23:58Z","updated_at":"2015-08-27T22:24:20Z","closed_at":null,"body":"Hello knolleary,\r\n\r\nI'm referring to my [pull request](https://github.com/knolleary/pubsubclient/pull/69) on this topic.\r\n\r\nI think that its, of course, better to check if PROGMEM is defined, instead of just checking if you are on that one platform, like the ESP8266.\r\n\r\nThe problem is: It doesn't work. PROGMEM seems to be still defined on an ESP8266. Your library would only compile, if I insert `#undef PROGMEM` in both the header and cpp-files.\r\n\r\nMaybe, you could combine the two?\r\n\r\nThanks, l-sch."},"comment":{"url":"https://api.github.com/repos/knolleary/pubsubclient/issues/comments/135572960","html_url":"https://github.com/knolleary/pubsubclient/issues/70#issuecomment-135572960","issue_url":"https://api.github.com/repos/knolleary/pubsubclient/issues/70","id":135572960,"user":{"login":"knolleary","id":51083,"avatar_url":"https://avatars.githubusercontent.com/u/51083?v=3","gravatar_id":"","url":"https://api.github.com/users/knolleary","html_url":"https://github.com/knolleary","followers_url":"https://api.github.com/users/knolleary/followers","following_url":"https://api.github.com/users/knolleary/following{/other_user}","gists_url":"https://api.github.com/users/knolleary/gists{/gist_id}","starred_url":"https://api.github.com/users/knolleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knolleary/subscriptions","organizations_url":"https://api.github.com/users/knolleary/orgs","repos_url":"https://api.github.com/users/knolleary/repos","events_url":"https://api.github.com/users/knolleary/events{/privacy}","received_events_url":"https://api.github.com/users/knolleary/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T22:24:20Z","updated_at":"2015-08-27T22:24:20Z","body":"Ok, got to the bottom of it - this wasn't to do with PROGMEM missing, it was a specific way the code was trying to use progmem. I think I've sort it - it compiles cleanly against an ESP8266 target now, but I don't have the hardware to test.\r\n\r\nLet me know how you get on."}}