{"action":"created","comment":{"url":"https://api.github.com/repos/PDAL/PDAL/pulls/comments/47299969","id":47299969,"diff_hunk":"@@ -123,11 +125,83 @@ T convert(const StringList& s, const std::string& name, size_t fieldno)\n }\n \n \n+// If longitude between 0-180, just return it, degrees east; if between 180\n+// and 360, subtract 360 to get negative value.\n+double Ilvis2Reader::convertLongitude(double longitude)\n+{\n+  if (longitude > 180.0)\n+  {\n+    return longitude - 360.0;\n+  }\n+  else\n+  {\n+    return longitude;\n+  }\n+}\n+\n+\n+void Ilvis2Reader::readPoint(PointViewPtr view, PointId nextId, StringList s, std::string pointMap)\n+{\n+  PointLayoutPtr layout = view->layout();\n+\n+  std::string name(\"LVIS_LFID\");","path":"io/ilvis2/Ilvis2Reader.cpp","position":43,"original_position":43,"commit_id":"dd3ec7a508c7910b3ffae11bbd8e255ea7c045cb","original_commit_id":"dd3ec7a508c7910b3ffae11bbd8e255ea7c045cb","user":{"login":"abellgithub","id":1316400,"avatar_url":"https://avatars.githubusercontent.com/u/1316400?v=3","gravatar_id":"","url":"https://api.github.com/users/abellgithub","html_url":"https://github.com/abellgithub","followers_url":"https://api.github.com/users/abellgithub/followers","following_url":"https://api.github.com/users/abellgithub/following{/other_user}","gists_url":"https://api.github.com/users/abellgithub/gists{/gist_id}","starred_url":"https://api.github.com/users/abellgithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellgithub/subscriptions","organizations_url":"https://api.github.com/users/abellgithub/orgs","repos_url":"https://api.github.com/users/abellgithub/repos","events_url":"https://api.github.com/users/abellgithub/events{/privacy}","received_events_url":"https://api.github.com/users/abellgithub/received_events","type":"User","site_admin":false},"body":"Up to you, but I'll just say that I was going to make this change anyway and probably will at some point if you don't.  Just because they're in the list doesn't mean they're general.  It means that we know about them from the specification -- they aren't variable strings that we don't know until runtime.  I allowed for 65,000+ known dimensions.  We have a long way to go :)","created_at":"2015-12-10T23:00:11Z","updated_at":"2015-12-10T23:00:11Z","html_url":"https://github.com/PDAL/PDAL/pull/1068#discussion_r47299969","pull_request_url":"https://api.github.com/repos/PDAL/PDAL/pulls/1068","_links":{"self":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/comments/47299969"},"html":{"href":"https://github.com/PDAL/PDAL/pull/1068#discussion_r47299969"},"pull_request":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/1068"}}},"pull_request":{"url":"https://api.github.com/repos/PDAL/PDAL/pulls/1068","id":53324299,"html_url":"https://github.com/PDAL/PDAL/pull/1068","diff_url":"https://github.com/PDAL/PDAL/pull/1068.diff","patch_url":"https://github.com/PDAL/PDAL/pull/1068.patch","issue_url":"https://api.github.com/repos/PDAL/PDAL/issues/1068","number":1068,"state":"open","locked":false,"title":"Ilvis2 reader update","user":{"login":"scott-lewis-nsidc","id":4761881,"avatar_url":"https://avatars.githubusercontent.com/u/4761881?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-lewis-nsidc","html_url":"https://github.com/scott-lewis-nsidc","followers_url":"https://api.github.com/users/scott-lewis-nsidc/followers","following_url":"https://api.github.com/users/scott-lewis-nsidc/following{/other_user}","gists_url":"https://api.github.com/users/scott-lewis-nsidc/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-lewis-nsidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-lewis-nsidc/subscriptions","organizations_url":"https://api.github.com/users/scott-lewis-nsidc/orgs","repos_url":"https://api.github.com/users/scott-lewis-nsidc/repos","events_url":"https://api.github.com/users/scott-lewis-nsidc/events{/privacy}","received_events_url":"https://api.github.com/users/scott-lewis-nsidc/received_events","type":"User","site_admin":false},"body":"Modified the ILVIS reader to allow either HIGH or LOW value to be used, or ALL, which will generate two points if the elevations of HIGH and LOW differ.  CENTROID will not be used at this time, per discussion with the LVIS science team.\r\n\r\nAlso modified the longitude conversion.  Values 0-180 should remain \"as is\"; values start from 0 and go east, so past 180 you have wrapped around the dateline; to get the correct longitude, you thus subtract 360 from values that have \"wrapped\" to get a negative value, representing negative degrees east.\r\n\r\nModified the ILVIS Reader Test to accommodate these changes, as well as to add a few more test cases.\r\n\r\nNOTE: The reader will also be implementing a method to read a metadata XML file.  This will be done via a separate pull request.","created_at":"2015-12-10T22:05:35Z","updated_at":"2015-12-10T23:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"050453f0459f6dffd26cb7d7ac3e16d784eb3cc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PDAL/PDAL/pulls/1068/commits","review_comments_url":"https://api.github.com/repos/PDAL/PDAL/pulls/1068/comments","review_comment_url":"https://api.github.com/repos/PDAL/PDAL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PDAL/PDAL/issues/1068/comments","statuses_url":"https://api.github.com/repos/PDAL/PDAL/statuses/dd3ec7a508c7910b3ffae11bbd8e255ea7c045cb","head":{"label":"scott-lewis-nsidc:ilvis2-reader-update","ref":"ilvis2-reader-update","sha":"dd3ec7a508c7910b3ffae11bbd8e255ea7c045cb","user":{"login":"scott-lewis-nsidc","id":4761881,"avatar_url":"https://avatars.githubusercontent.com/u/4761881?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-lewis-nsidc","html_url":"https://github.com/scott-lewis-nsidc","followers_url":"https://api.github.com/users/scott-lewis-nsidc/followers","following_url":"https://api.github.com/users/scott-lewis-nsidc/following{/other_user}","gists_url":"https://api.github.com/users/scott-lewis-nsidc/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-lewis-nsidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-lewis-nsidc/subscriptions","organizations_url":"https://api.github.com/users/scott-lewis-nsidc/orgs","repos_url":"https://api.github.com/users/scott-lewis-nsidc/repos","events_url":"https://api.github.com/users/scott-lewis-nsidc/events{/privacy}","received_events_url":"https://api.github.com/users/scott-lewis-nsidc/received_events","type":"User","site_admin":false},"repo":{"id":45632835,"name":"PDAL","full_name":"scott-lewis-nsidc/PDAL","owner":{"login":"scott-lewis-nsidc","id":4761881,"avatar_url":"https://avatars.githubusercontent.com/u/4761881?v=3","gravatar_id":"","url":"https://api.github.com/users/scott-lewis-nsidc","html_url":"https://github.com/scott-lewis-nsidc","followers_url":"https://api.github.com/users/scott-lewis-nsidc/followers","following_url":"https://api.github.com/users/scott-lewis-nsidc/following{/other_user}","gists_url":"https://api.github.com/users/scott-lewis-nsidc/gists{/gist_id}","starred_url":"https://api.github.com/users/scott-lewis-nsidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott-lewis-nsidc/subscriptions","organizations_url":"https://api.github.com/users/scott-lewis-nsidc/orgs","repos_url":"https://api.github.com/users/scott-lewis-nsidc/repos","events_url":"https://api.github.com/users/scott-lewis-nsidc/events{/privacy}","received_events_url":"https://api.github.com/users/scott-lewis-nsidc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scott-lewis-nsidc/PDAL","description":"PDAL is Point Data Abstraction Library. GDAL for point cloud data.","fork":true,"url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL","forks_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/forks","keys_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/teams","hooks_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/hooks","issue_events_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/issues/events{/number}","events_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/events","assignees_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/assignees{/user}","branches_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/branches{/branch}","tags_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/tags","blobs_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/statuses/{sha}","languages_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/languages","stargazers_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/stargazers","contributors_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/contributors","subscribers_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/subscribers","subscription_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/subscription","commits_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/issues/comments{/number}","contents_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/contents/{+path}","compare_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/merges","archive_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/downloads","issues_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/issues{/number}","pulls_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/pulls{/number}","milestones_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/milestones{/number}","notifications_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/labels{/name}","releases_url":"https://api.github.com/repos/scott-lewis-nsidc/PDAL/releases{/id}","created_at":"2015-11-05T19:03:34Z","updated_at":"2015-11-05T19:03:40Z","pushed_at":"2015-12-10T21:59:54Z","git_url":"git://github.com/scott-lewis-nsidc/PDAL.git","ssh_url":"git@github.com:scott-lewis-nsidc/PDAL.git","clone_url":"https://github.com/scott-lewis-nsidc/PDAL.git","svn_url":"https://github.com/scott-lewis-nsidc/PDAL","homepage":"http://pdal.io","size":73066,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PDAL:master","ref":"master","sha":"f53f4a39912d639edfef9d3d0d2a7da7e82826f6","user":{"login":"PDAL","id":859797,"avatar_url":"https://avatars.githubusercontent.com/u/859797?v=3","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"repo":{"id":2234863,"name":"PDAL","full_name":"PDAL/PDAL","owner":{"login":"PDAL","id":859797,"avatar_url":"https://avatars.githubusercontent.com/u/859797?v=3","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PDAL/PDAL","description":"PDAL is Point Data Abstraction Library. GDAL for point cloud data.","fork":false,"url":"https://api.github.com/repos/PDAL/PDAL","forks_url":"https://api.github.com/repos/PDAL/PDAL/forks","keys_url":"https://api.github.com/repos/PDAL/PDAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PDAL/PDAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PDAL/PDAL/teams","hooks_url":"https://api.github.com/repos/PDAL/PDAL/hooks","issue_events_url":"https://api.github.com/repos/PDAL/PDAL/issues/events{/number}","events_url":"https://api.github.com/repos/PDAL/PDAL/events","assignees_url":"https://api.github.com/repos/PDAL/PDAL/assignees{/user}","branches_url":"https://api.github.com/repos/PDAL/PDAL/branches{/branch}","tags_url":"https://api.github.com/repos/PDAL/PDAL/tags","blobs_url":"https://api.github.com/repos/PDAL/PDAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PDAL/PDAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PDAL/PDAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/PDAL/PDAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PDAL/PDAL/statuses/{sha}","languages_url":"https://api.github.com/repos/PDAL/PDAL/languages","stargazers_url":"https://api.github.com/repos/PDAL/PDAL/stargazers","contributors_url":"https://api.github.com/repos/PDAL/PDAL/contributors","subscribers_url":"https://api.github.com/repos/PDAL/PDAL/subscribers","subscription_url":"https://api.github.com/repos/PDAL/PDAL/subscription","commits_url":"https://api.github.com/repos/PDAL/PDAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/PDAL/PDAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/PDAL/PDAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/PDAL/PDAL/issues/comments{/number}","contents_url":"https://api.github.com/repos/PDAL/PDAL/contents/{+path}","compare_url":"https://api.github.com/repos/PDAL/PDAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PDAL/PDAL/merges","archive_url":"https://api.github.com/repos/PDAL/PDAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PDAL/PDAL/downloads","issues_url":"https://api.github.com/repos/PDAL/PDAL/issues{/number}","pulls_url":"https://api.github.com/repos/PDAL/PDAL/pulls{/number}","milestones_url":"https://api.github.com/repos/PDAL/PDAL/milestones{/number}","notifications_url":"https://api.github.com/repos/PDAL/PDAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PDAL/PDAL/labels{/name}","releases_url":"https://api.github.com/repos/PDAL/PDAL/releases{/id}","created_at":"2011-08-19T15:57:50Z","updated_at":"2015-12-02T11:48:54Z","pushed_at":"2015-12-10T22:05:35Z","git_url":"git://github.com/PDAL/PDAL.git","ssh_url":"git@github.com:PDAL/PDAL.git","clone_url":"https://github.com/PDAL/PDAL.git","svn_url":"https://github.com/PDAL/PDAL","homepage":"http://pdal.io","size":74059,"stargazers_count":108,"watchers_count":108,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":59,"forks":75,"open_issues":59,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/1068"},"html":{"href":"https://github.com/PDAL/PDAL/pull/1068"},"issue":{"href":"https://api.github.com/repos/PDAL/PDAL/issues/1068"},"comments":{"href":"https://api.github.com/repos/PDAL/PDAL/issues/1068/comments"},"review_comments":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/1068/comments"},"review_comment":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/1068/commits"},"statuses":{"href":"https://api.github.com/repos/PDAL/PDAL/statuses/dd3ec7a508c7910b3ffae11bbd8e255ea7c045cb"}}}}