{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2143","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2143/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2143/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2143/events","html_url":"https://github.com/aspnet/EntityFramework/issues/2143","id":74310904,"number":2143,"title":"String formatting tests defined by CSharpHelperTest are depend on the local system's culture","user":{"login":"MichaelKetting","id":6972548,"avatar_url":"https://avatars.githubusercontent.com/u/6972548?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelKetting","html_url":"https://github.com/MichaelKetting","followers_url":"https://api.github.com/users/MichaelKetting/followers","following_url":"https://api.github.com/users/MichaelKetting/following{/other_user}","gists_url":"https://api.github.com/users/MichaelKetting/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelKetting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelKetting/subscriptions","organizations_url":"https://api.github.com/users/MichaelKetting/orgs","repos_url":"https://api.github.com/users/MichaelKetting/repos","events_url":"https://api.github.com/users/MichaelKetting/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelKetting/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-08T10:11:05Z","updated_at":"2015-05-08T17:26:23Z","closed_at":null,"body":"When running the tests in CSharpHelperTest on a system using a culture other than US English, the tests fail because the date and number formats are different from the expectation.\r\n\r\nTest output (abbreviated) when running with German Culture settings:\r\n\r\nMicrosoft.Data.Entity.Commands.Utilities.CSharpHelperTest.Literal_works_when_DateTime [FAIL]\r\nAssert.Equal() Failure\r\nExpected: DateTime.Parse(\"3/12/2015 12:00:00 AM\")\r\nActual:   DateTime.Parse(\"12.03.2015 00:00:00\")\r\n\r\nMicrosoft.Data.Entity.Commands.Utilities.CSharpHelperTest.Literal_works_when_DateTimeOffset [FAIL]\r\nAssert.Equal() Failure\r\nExpected: ···teTimeOffset.Parse(\"3/12/2015 12:00:00 AM -07:00\")\r\nActual:   ···teTimeOffset.Parse(\"12.03.2015 00:00:00 -07:00\")\r\n\r\nMicrosoft.Data.Entity.Commands.Utilities.CSharpHelperTest.Literal_works_when_decimal [FAIL]\r\nAssert.Equal() Failure\r\nExpected: 4.2m\r\nActual:   4,2m\r\n\r\nMicrosoft.Data.Entity.Commands.Utilities.CSharpHelperTest.Literal_works(value: 4,2, expected: \"4.2\") [FAIL]\r\nAssert.Equal() Failure\r\nExpected: 4.2\r\nActual:   4,2\r\n\r\nMicrosoft.Data.Entity.Commands.Utilities.CSharpHelperTest.Literal_works(value: 4,2, expected: \"4.2f\") [FAIL]\r\nAssert.Equal() Failure\r\nExpected: 4.2f\r\nActual:   4,2f\r\n"},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments/100304184","html_url":"https://github.com/aspnet/EntityFramework/issues/2143#issuecomment-100304184","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2143","id":100304184,"user":{"login":"bricelam","id":1226749,"avatar_url":"https://avatars.githubusercontent.com/u/1226749?v=3","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T17:26:23Z","updated_at":"2015-05-08T17:26:23Z","body":"(Update from PR #2144)\r\n\r\nThis is actually a product bug--not a test bug. We should be generating valid C# regardless of the culture."}}