{"action":"created","issue":{"url":"https://api.github.com/repos/mootools/mootools-more/issues/1311","labels_url":"https://api.github.com/repos/mootools/mootools-more/issues/1311/labels{/name}","comments_url":"https://api.github.com/repos/mootools/mootools-more/issues/1311/comments","events_url":"https://api.github.com/repos/mootools/mootools-more/issues/1311/events","html_url":"https://github.com/mootools/mootools-more/pull/1311","id":88052397,"number":1311,"title":"Fixes wrong module definitions","user":{"login":"IvanGuardado","id":767493,"avatar_url":"https://avatars.githubusercontent.com/u/767493?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanGuardado","html_url":"https://github.com/IvanGuardado","followers_url":"https://api.github.com/users/IvanGuardado/followers","following_url":"https://api.github.com/users/IvanGuardado/following{/other_user}","gists_url":"https://api.github.com/users/IvanGuardado/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanGuardado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanGuardado/subscriptions","organizations_url":"https://api.github.com/users/IvanGuardado/orgs","repos_url":"https://api.github.com/users/IvanGuardado/repos","events_url":"https://api.github.com/users/IvanGuardado/events{/privacy}","received_events_url":"https://api.github.com/users/IvanGuardado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-13T19:26:57Z","updated_at":"2015-08-10T17:09:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mootools/mootools-more/pulls/1311","html_url":"https://github.com/mootools/mootools-more/pull/1311","diff_url":"https://github.com/mootools/mootools-more/pull/1311.diff","patch_url":"https://github.com/mootools/mootools-more/pull/1311.patch"},"body":"This PR fixes #1310 and #1294.\r\n\r\nSome modules wasn't well defined to use them with a dependency loader.\r\n\r\nI've checked all modules and these are what I found:\r\nDrag, Slider, Sortables, OverText, HtmlTable, Mask, Scroller, Spinner, Asset.\r\n\r\nI've also changed some modules to follow the same module definition format:\r\nTips, Group, IframeShim\r\n\r\nAlthough this doesn't make them CommonJS compliance, it's enough to load all modules in the global scope (window).\r\n\r\nIf you are using webpack, you can include the library with this workaround without any problems now:\r\n```js\r\nrequire('imports?this=>window!path/to/mootools-more-all.js);\r\n```"},"comment":{"url":"https://api.github.com/repos/mootools/mootools-more/issues/comments/129528640","html_url":"https://github.com/mootools/mootools-more/pull/1311#issuecomment-129528640","issue_url":"https://api.github.com/repos/mootools/mootools-more/issues/1311","id":129528640,"user":{"login":"anutron","id":13230,"avatar_url":"https://avatars.githubusercontent.com/u/13230?v=3","gravatar_id":"","url":"https://api.github.com/users/anutron","html_url":"https://github.com/anutron","followers_url":"https://api.github.com/users/anutron/followers","following_url":"https://api.github.com/users/anutron/following{/other_user}","gists_url":"https://api.github.com/users/anutron/gists{/gist_id}","starred_url":"https://api.github.com/users/anutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anutron/subscriptions","organizations_url":"https://api.github.com/users/anutron/orgs","repos_url":"https://api.github.com/users/anutron/repos","events_url":"https://api.github.com/users/anutron/events{/privacy}","received_events_url":"https://api.github.com/users/anutron/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T17:09:16Z","updated_at":"2015-08-10T17:09:16Z","body":":+1: \r\n\r\nAlso, we should really kill IframeShim. It's only a fix for IE6 I think."}}