{"action":"created","issue":{"url":"https://api.github.com/repos/rodricios/eatiht/issues/20","labels_url":"https://api.github.com/repos/rodricios/eatiht/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/rodricios/eatiht/issues/20/comments","events_url":"https://api.github.com/repos/rodricios/eatiht/issues/20/events","html_url":"https://github.com/rodricios/eatiht/pull/20","id":68678890,"number":20,"title":"Python 3 Compatibility and Relative Module Imports","user":{"login":"jjangsangy","id":3851682,"avatar_url":"https://avatars.githubusercontent.com/u/3851682?v=3","gravatar_id":"","url":"https://api.github.com/users/jjangsangy","html_url":"https://github.com/jjangsangy","followers_url":"https://api.github.com/users/jjangsangy/followers","following_url":"https://api.github.com/users/jjangsangy/following{/other_user}","gists_url":"https://api.github.com/users/jjangsangy/gists{/gist_id}","starred_url":"https://api.github.com/users/jjangsangy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjangsangy/subscriptions","organizations_url":"https://api.github.com/users/jjangsangy/orgs","repos_url":"https://api.github.com/users/jjangsangy/repos","events_url":"https://api.github.com/users/jjangsangy/events{/privacy}","received_events_url":"https://api.github.com/users/jjangsangy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-04-15T13:12:41Z","updated_at":"2015-04-15T19:13:44Z","closed_at":"2015-04-15T18:51:14Z","pull_request":{"url":"https://api.github.com/repos/rodricios/eatiht/pulls/20","html_url":"https://github.com/rodricios/eatiht/pull/20","diff_url":"https://github.com/rodricios/eatiht/pull/20.diff","patch_url":"https://github.com/rodricios/eatiht/pull/20.patch"},"body":"Hey Rodrigo\r\n\r\nSo your library doesn't work on Python 3 and you use both relative and absolute imports in your module. This might work for you since you have your library installed, but it won't work for people who are installing your package.\r\n\r\nI've patched up both of these issues in this PR.\r\n\r\nAlso I might recommend some refactoring so there is less code duplication in your packages. That way, you only need to patch up one location rather than 3."},"comment":{"url":"https://api.github.com/repos/rodricios/eatiht/issues/comments/93536237","html_url":"https://github.com/rodricios/eatiht/pull/20#issuecomment-93536237","issue_url":"https://api.github.com/repos/rodricios/eatiht/issues/20","id":93536237,"user":{"login":"jjangsangy","id":3851682,"avatar_url":"https://avatars.githubusercontent.com/u/3851682?v=3","gravatar_id":"","url":"https://api.github.com/users/jjangsangy","html_url":"https://github.com/jjangsangy","followers_url":"https://api.github.com/users/jjangsangy/followers","following_url":"https://api.github.com/users/jjangsangy/following{/other_user}","gists_url":"https://api.github.com/users/jjangsangy/gists{/gist_id}","starred_url":"https://api.github.com/users/jjangsangy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjangsangy/subscriptions","organizations_url":"https://api.github.com/users/jjangsangy/orgs","repos_url":"https://api.github.com/users/jjangsangy/repos","events_url":"https://api.github.com/users/jjangsangy/events{/privacy}","received_events_url":"https://api.github.com/users/jjangsangy/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T19:13:44Z","updated_at":"2015-04-15T19:13:44Z","body":"Cool thanks!\r\n\r\nSphinx docs? I could help out setting up `sphinx-build`, and configuring the webhooks for building on [readthedocs](https://readthedocs.org/). The setup is pretty trivial in itself.\r\n\r\nHard part is documenting your API accurately, ensuring that the docs can be authoritative source of information. So that means figuring out which parts of your code to use as the public facing interfaces. I see that you guys are implementing strategy to generically swap algorithms. Each one of your strategies should have it's own interface and documentation. Actually I'm a little curious as to the implementations, if you want I could probably help build those interfaces if you show me how they're implemented ;)"}}