{"action":"created","issue":{"url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/63","labels_url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/63/comments","events_url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/63/events","html_url":"https://github.com/18F/dolores-landingham-bot/pull/63","id":109596888,"number":63,"title":"Issue #33:  Slack Username Validation","user":{"login":"ccostino","id":121565,"avatar_url":"https://avatars.githubusercontent.com/u/121565?v=3","gravatar_id":"","url":"https://api.github.com/users/ccostino","html_url":"https://github.com/ccostino","followers_url":"https://api.github.com/users/ccostino/followers","following_url":"https://api.github.com/users/ccostino/following{/other_user}","gists_url":"https://api.github.com/users/ccostino/gists{/gist_id}","starred_url":"https://api.github.com/users/ccostino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccostino/subscriptions","organizations_url":"https://api.github.com/users/ccostino/orgs","repos_url":"https://api.github.com/users/ccostino/repos","events_url":"https://api.github.com/users/ccostino/events{/privacy}","received_events_url":"https://api.github.com/users/ccostino/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-03T01:52:07Z","updated_at":"2015-10-08T20:05:18Z","closed_at":"2015-10-08T20:04:17Z","pull_request":{"url":"https://api.github.com/repos/18F/dolores-landingham-bot/pulls/63","html_url":"https://github.com/18F/dolores-landingham-bot/pull/63","diff_url":"https://github.com/18F/dolores-landingham-bot/pull/63.diff","patch_url":"https://github.com/18F/dolores-landingham-bot/pull/63.patch"},"body":"This is the initial changeset with full support and passing tests for the Slack username validation.  There is still one outstanding thing to investigate further with the employee model validation tests as the \"allow_values\" shoulda matcher method seems to be failing.  I want to look into that a bit further to see if it's something that needs to be reported to the shoulda matchers (and gather full details if so), but otherwise this is ready for review and discussion!  Thank you @jessieay for your help with this and coming up with a cleaner approach, especially with the tests!"},"comment":{"url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/comments/146671052","html_url":"https://github.com/18F/dolores-landingham-bot/pull/63#issuecomment-146671052","issue_url":"https://api.github.com/repos/18F/dolores-landingham-bot/issues/63","id":146671052,"user":{"login":"jessieay","id":601515,"avatar_url":"https://avatars.githubusercontent.com/u/601515?v=3","gravatar_id":"","url":"https://api.github.com/users/jessieay","html_url":"https://github.com/jessieay","followers_url":"https://api.github.com/users/jessieay/followers","following_url":"https://api.github.com/users/jessieay/following{/other_user}","gists_url":"https://api.github.com/users/jessieay/gists{/gist_id}","starred_url":"https://api.github.com/users/jessieay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessieay/subscriptions","organizations_url":"https://api.github.com/users/jessieay/orgs","repos_url":"https://api.github.com/users/jessieay/repos","events_url":"https://api.github.com/users/jessieay/events{/privacy}","received_events_url":"https://api.github.com/users/jessieay/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T20:05:18Z","updated_at":"2015-10-08T20:05:18Z","body":"nice! for future: if you rebase your branch and force push before merging to master, the PR will automatically get closed when you merge (because the commit hashes will line up) :sparkles: "}}