{"action":"created","issue":{"url":"https://api.github.com/repos/unt-libraries/django-name/issues/55","labels_url":"https://api.github.com/repos/unt-libraries/django-name/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/unt-libraries/django-name/issues/55/comments","events_url":"https://api.github.com/repos/unt-libraries/django-name/issues/55/events","html_url":"https://github.com/unt-libraries/django-name/pull/55","id":76121109,"number":55,"title":"Fix merge validation","user":{"login":"damonkelley","id":4121849,"avatar_url":"https://avatars.githubusercontent.com/u/4121849?v=3","gravatar_id":"","url":"https://api.github.com/users/damonkelley","html_url":"https://github.com/damonkelley","followers_url":"https://api.github.com/users/damonkelley/followers","following_url":"https://api.github.com/users/damonkelley/following{/other_user}","gists_url":"https://api.github.com/users/damonkelley/gists{/gist_id}","starred_url":"https://api.github.com/users/damonkelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damonkelley/subscriptions","organizations_url":"https://api.github.com/users/damonkelley/orgs","repos_url":"https://api.github.com/users/damonkelley/repos","events_url":"https://api.github.com/users/damonkelley/events{/privacy}","received_events_url":"https://api.github.com/users/damonkelley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/unt-libraries/django-name/labels/models","name":"models","color":"bfdadc"},{"url":"https://api.github.com/repos/unt-libraries/django-name/labels/ready","name":"ready","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/unt-libraries/django-name/milestones/1","html_url":"https://github.com/unt-libraries/django-name/milestones/First%20Open%20Source%20Release","labels_url":"https://api.github.com/repos/unt-libraries/django-name/milestones/1/labels","id":995563,"number":1,"title":"First Open Source Release","description":"","creator":{"login":"damonkelley","id":4121849,"avatar_url":"https://avatars.githubusercontent.com/u/4121849?v=3","gravatar_id":"","url":"https://api.github.com/users/damonkelley","html_url":"https://github.com/damonkelley","followers_url":"https://api.github.com/users/damonkelley/followers","following_url":"https://api.github.com/users/damonkelley/following{/other_user}","gists_url":"https://api.github.com/users/damonkelley/gists{/gist_id}","starred_url":"https://api.github.com/users/damonkelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damonkelley/subscriptions","organizations_url":"https://api.github.com/users/damonkelley/orgs","repos_url":"https://api.github.com/users/damonkelley/repos","events_url":"https://api.github.com/users/damonkelley/events{/privacy}","received_events_url":"https://api.github.com/users/damonkelley/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":31,"state":"open","created_at":"2015-02-25T17:33:42Z","updated_at":"2015-05-13T23:01:31Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-05-13T20:55:28Z","updated_at":"2015-05-14T18:44:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/unt-libraries/django-name/pulls/55","html_url":"https://github.com/unt-libraries/django-name/pull/55","diff_url":"https://github.com/unt-libraries/django-name/pull/55.diff","patch_url":"https://github.com/unt-libraries/django-name/pull/55.patch"},"body":"Resolves #41 \r\n\r\nIt seems that the reason this was failing is some scenarios because in order to properly validate the FK, we needed have the target Name and the Name being merged. _Normal_ validators are only passed the ID of the related model for ForeignKey fields. \r\n\r\nSo...\r\n\r\nI modified `validate_merged_with` to accept a Name instance in order to properly validate with itself and the merge target, and it is now being called from the `clean` method on the Name model.\r\n\r\n\r\nP.S. There is an issue with TravisCI ATM so the builds are not as reliable here. There is something going on with the ability to pick up env variables which is not allowing the tests to connect to the database."},"comment":{"url":"https://api.github.com/repos/unt-libraries/django-name/issues/comments/102132401","html_url":"https://github.com/unt-libraries/django-name/pull/55#issuecomment-102132401","issue_url":"https://api.github.com/repos/unt-libraries/django-name/issues/55","id":102132401,"user":{"login":"somexpert","id":5580991,"avatar_url":"https://avatars.githubusercontent.com/u/5580991?v=3","gravatar_id":"","url":"https://api.github.com/users/somexpert","html_url":"https://github.com/somexpert","followers_url":"https://api.github.com/users/somexpert/followers","following_url":"https://api.github.com/users/somexpert/following{/other_user}","gists_url":"https://api.github.com/users/somexpert/gists{/gist_id}","starred_url":"https://api.github.com/users/somexpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somexpert/subscriptions","organizations_url":"https://api.github.com/users/somexpert/orgs","repos_url":"https://api.github.com/users/somexpert/repos","events_url":"https://api.github.com/users/somexpert/events{/privacy}","received_events_url":"https://api.github.com/users/somexpert/received_events","type":"User","site_admin":false},"created_at":"2015-05-14T18:44:26Z","updated_at":"2015-05-14T18:44:26Z","body":":thumbsup:"}}