{"action":"opened","number":158,"pull_request":{"url":"https://api.github.com/repos/karelzak/util-linux/pulls/158","id":30453251,"html_url":"https://github.com/karelzak/util-linux/pull/158","diff_url":"https://github.com/karelzak/util-linux/pull/158.diff","patch_url":"https://github.com/karelzak/util-linux/pull/158.patch","issue_url":"https://api.github.com/repos/karelzak/util-linux/issues/158","number":158,"state":"open","locked":false,"title":"logger: fix inconsistent format regression when logging locally","user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"body":"The message format when writing to local sockets is inconsistent. Example:\r\n```\r\n$ ./logger --stderr test\r\n<5>Mär  4 11:03:30 logger: test\r\n$ ./logger -u /dev/log --stderr test\r\n<5>1 2015-03-04T11:03:31.699841+0100 ubuntu1404esp rger - [timeQuality tzKnown=\"1\" isSynced=\"1\" syncAccuracy=\"29000\"] test\r\n```\r\nThe regression was introduced with 4de2e8a03859aaab2c25dc98f33409cd28de6acc\r\nAs far as the commit comments and man page indicates, this was meant to affect\r\nremote system logging only, but it also affects local logging when the -u\r\noption is given.\r\n\r\nThis causes problems with receivers who do not expect full-blown RFC format\r\non the log socket, like rsyslog. In consequence, this can also affect\r\nlog analysis programs and invalidate some of their results.\r\n\r\nThe patch corrects the behaviour so that the same old-style format is used for\r\nany type of local logging. New-style can always be selected by command line-options.\r\nRFC5424 is still the default for remote logging, as intended in the orignal\r\ncommit.\r\n\r\nResult with the patch:\r\n```\r\n$ ./logger --stderr test\r\n<5>Mär  4 11:15:35 logger: test\r\n$ ./logger -u /dev/log --stderr test\r\n<5>Mär  4 11:15:40 logger: test\r\n$ ./logger -u /dev/log --rfc5424 --stderr test\r\n<5>1 2015-03-04T11:21:28.796170+0100 ubuntu1404esp rger - [timeQuality tzKnown=\"1\" isSynced=\"1\" syncAccuracy=\"27500\"] test\r\n```\r\ncloses https://github.com/karelzak/util-linux/issues/157","created_at":"2015-03-04T10:25:10Z","updated_at":"2015-03-04T10:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/karelzak/util-linux/pulls/158/commits","review_comments_url":"https://api.github.com/repos/karelzak/util-linux/pulls/158/comments","review_comment_url":"https://api.github.com/repos/karelzak/util-linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karelzak/util-linux/issues/158/comments","statuses_url":"https://api.github.com/repos/karelzak/util-linux/statuses/12664018c762c99acfae3a3abce829d7a0b55b10","head":{"label":"rgerhards:logger-format-fix","ref":"logger-format-fix","sha":"12664018c762c99acfae3a3abce829d7a0b55b10","user":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"repo":{"id":31650199,"name":"util-linux","full_name":"rgerhards/util-linux","owner":{"login":"rgerhards","id":1482123,"avatar_url":"https://avatars.githubusercontent.com/u/1482123?v=3","gravatar_id":"","url":"https://api.github.com/users/rgerhards","html_url":"https://github.com/rgerhards","followers_url":"https://api.github.com/users/rgerhards/followers","following_url":"https://api.github.com/users/rgerhards/following{/other_user}","gists_url":"https://api.github.com/users/rgerhards/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerhards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerhards/subscriptions","organizations_url":"https://api.github.com/users/rgerhards/orgs","repos_url":"https://api.github.com/users/rgerhards/repos","events_url":"https://api.github.com/users/rgerhards/events{/privacy}","received_events_url":"https://api.github.com/users/rgerhards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgerhards/util-linux","description":"backup upstream repository","fork":true,"url":"https://api.github.com/repos/rgerhards/util-linux","forks_url":"https://api.github.com/repos/rgerhards/util-linux/forks","keys_url":"https://api.github.com/repos/rgerhards/util-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgerhards/util-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgerhards/util-linux/teams","hooks_url":"https://api.github.com/repos/rgerhards/util-linux/hooks","issue_events_url":"https://api.github.com/repos/rgerhards/util-linux/issues/events{/number}","events_url":"https://api.github.com/repos/rgerhards/util-linux/events","assignees_url":"https://api.github.com/repos/rgerhards/util-linux/assignees{/user}","branches_url":"https://api.github.com/repos/rgerhards/util-linux/branches{/branch}","tags_url":"https://api.github.com/repos/rgerhards/util-linux/tags","blobs_url":"https://api.github.com/repos/rgerhards/util-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgerhards/util-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgerhards/util-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgerhards/util-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgerhards/util-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/rgerhards/util-linux/languages","stargazers_url":"https://api.github.com/repos/rgerhards/util-linux/stargazers","contributors_url":"https://api.github.com/repos/rgerhards/util-linux/contributors","subscribers_url":"https://api.github.com/repos/rgerhards/util-linux/subscribers","subscription_url":"https://api.github.com/repos/rgerhards/util-linux/subscription","commits_url":"https://api.github.com/repos/rgerhards/util-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgerhards/util-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgerhards/util-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgerhards/util-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgerhards/util-linux/contents/{+path}","compare_url":"https://api.github.com/repos/rgerhards/util-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgerhards/util-linux/merges","archive_url":"https://api.github.com/repos/rgerhards/util-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgerhards/util-linux/downloads","issues_url":"https://api.github.com/repos/rgerhards/util-linux/issues{/number}","pulls_url":"https://api.github.com/repos/rgerhards/util-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/rgerhards/util-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/rgerhards/util-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgerhards/util-linux/labels{/name}","releases_url":"https://api.github.com/repos/rgerhards/util-linux/releases{/id}","created_at":"2015-03-04T10:01:10Z","updated_at":"2015-03-04T10:01:15Z","pushed_at":"2015-03-04T10:24:02Z","git_url":"git://github.com/rgerhards/util-linux.git","ssh_url":"git@github.com:rgerhards/util-linux.git","clone_url":"https://github.com/rgerhards/util-linux.git","svn_url":"https://github.com/rgerhards/util-linux","homepage":"http://en.wikipedia.org/wiki/Util-linux","size":89058,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"karelzak:master","ref":"master","sha":"f71d1104df68e9ab7f06878c1c324566721acd66","user":{"login":"karelzak","id":1031987,"avatar_url":"https://avatars.githubusercontent.com/u/1031987?v=3","gravatar_id":"","url":"https://api.github.com/users/karelzak","html_url":"https://github.com/karelzak","followers_url":"https://api.github.com/users/karelzak/followers","following_url":"https://api.github.com/users/karelzak/following{/other_user}","gists_url":"https://api.github.com/users/karelzak/gists{/gist_id}","starred_url":"https://api.github.com/users/karelzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelzak/subscriptions","organizations_url":"https://api.github.com/users/karelzak/orgs","repos_url":"https://api.github.com/users/karelzak/repos","events_url":"https://api.github.com/users/karelzak/events{/privacy}","received_events_url":"https://api.github.com/users/karelzak/received_events","type":"User","site_admin":false},"repo":{"id":2339555,"name":"util-linux","full_name":"karelzak/util-linux","owner":{"login":"karelzak","id":1031987,"avatar_url":"https://avatars.githubusercontent.com/u/1031987?v=3","gravatar_id":"","url":"https://api.github.com/users/karelzak","html_url":"https://github.com/karelzak","followers_url":"https://api.github.com/users/karelzak/followers","following_url":"https://api.github.com/users/karelzak/following{/other_user}","gists_url":"https://api.github.com/users/karelzak/gists{/gist_id}","starred_url":"https://api.github.com/users/karelzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelzak/subscriptions","organizations_url":"https://api.github.com/users/karelzak/orgs","repos_url":"https://api.github.com/users/karelzak/repos","events_url":"https://api.github.com/users/karelzak/events{/privacy}","received_events_url":"https://api.github.com/users/karelzak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karelzak/util-linux","description":"backup upstream repository","fork":false,"url":"https://api.github.com/repos/karelzak/util-linux","forks_url":"https://api.github.com/repos/karelzak/util-linux/forks","keys_url":"https://api.github.com/repos/karelzak/util-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karelzak/util-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karelzak/util-linux/teams","hooks_url":"https://api.github.com/repos/karelzak/util-linux/hooks","issue_events_url":"https://api.github.com/repos/karelzak/util-linux/issues/events{/number}","events_url":"https://api.github.com/repos/karelzak/util-linux/events","assignees_url":"https://api.github.com/repos/karelzak/util-linux/assignees{/user}","branches_url":"https://api.github.com/repos/karelzak/util-linux/branches{/branch}","tags_url":"https://api.github.com/repos/karelzak/util-linux/tags","blobs_url":"https://api.github.com/repos/karelzak/util-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karelzak/util-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karelzak/util-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/karelzak/util-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karelzak/util-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/karelzak/util-linux/languages","stargazers_url":"https://api.github.com/repos/karelzak/util-linux/stargazers","contributors_url":"https://api.github.com/repos/karelzak/util-linux/contributors","subscribers_url":"https://api.github.com/repos/karelzak/util-linux/subscribers","subscription_url":"https://api.github.com/repos/karelzak/util-linux/subscription","commits_url":"https://api.github.com/repos/karelzak/util-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/karelzak/util-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/karelzak/util-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/karelzak/util-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/karelzak/util-linux/contents/{+path}","compare_url":"https://api.github.com/repos/karelzak/util-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karelzak/util-linux/merges","archive_url":"https://api.github.com/repos/karelzak/util-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karelzak/util-linux/downloads","issues_url":"https://api.github.com/repos/karelzak/util-linux/issues{/number}","pulls_url":"https://api.github.com/repos/karelzak/util-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/karelzak/util-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/karelzak/util-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karelzak/util-linux/labels{/name}","releases_url":"https://api.github.com/repos/karelzak/util-linux/releases{/id}","created_at":"2011-09-07T05:08:38Z","updated_at":"2015-03-03T10:44:46Z","pushed_at":"2015-03-03T10:44:45Z","git_url":"git://github.com/karelzak/util-linux.git","ssh_url":"git@github.com:karelzak/util-linux.git","clone_url":"https://github.com/karelzak/util-linux.git","svn_url":"https://github.com/karelzak/util-linux","homepage":"http://en.wikipedia.org/wiki/Util-linux","size":89058,"stargazers_count":168,"watchers_count":168,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":20,"forks":112,"open_issues":20,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karelzak/util-linux/pulls/158"},"html":{"href":"https://github.com/karelzak/util-linux/pull/158"},"issue":{"href":"https://api.github.com/repos/karelzak/util-linux/issues/158"},"comments":{"href":"https://api.github.com/repos/karelzak/util-linux/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/karelzak/util-linux/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/karelzak/util-linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karelzak/util-linux/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/karelzak/util-linux/statuses/12664018c762c99acfae3a3abce829d7a0b55b10"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":8,"changed_files":1}}