{"action":"closed","number":2163,"pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/2163","id":34486862,"html_url":"https://github.com/kangax/fabric.js/pull/2163","diff_url":"https://github.com/kangax/fabric.js/pull/2163.diff","patch_url":"https://github.com/kangax/fabric.js/pull/2163.patch","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/2163","number":2163,"state":"closed","locked":false,"title":"node.js segmentation fault when image couldn't be loaded","user":{"login":"kibao","id":1156678,"avatar_url":"https://avatars.githubusercontent.com/u/1156678?v=3","gravatar_id":"","url":"https://api.github.com/users/kibao","html_url":"https://github.com/kibao","followers_url":"https://api.github.com/users/kibao/followers","following_url":"https://api.github.com/users/kibao/following{/other_user}","gists_url":"https://api.github.com/users/kibao/gists{/gist_id}","starred_url":"https://api.github.com/users/kibao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibao/subscriptions","organizations_url":"https://api.github.com/users/kibao/orgs","repos_url":"https://api.github.com/users/kibao/repos","events_url":"https://api.github.com/users/kibao/events{/privacy}","received_events_url":"https://api.github.com/users/kibao/received_events","type":"User","site_admin":false},"body":"Don't create image Buffer based on `data` when `data` is empty.\r\nIt happens when response status code of accessed image is other than 200.\r\n\r\nShould also fix #1355\r\n\r\nExample of crashing code:\r\n```\r\nvar fabric = require('fabric').fabric;\r\n\r\nfabric.util.loadImage('http://www.google.com/non-existing', function() {\r\n  console.log('Loaded');\r\n});\r\n```","created_at":"2015-04-30T18:22:08Z","updated_at":"2015-05-13T15:47:06Z","closed_at":"2015-05-13T15:47:06Z","merged_at":"2015-05-13T15:47:06Z","merge_commit_sha":"18488e05caa31101e45cff968491e1ec86e47104","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2163/commits","review_comments_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2163/comments","review_comment_url":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/2163/comments","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/69d616ad2371bee9a930cd0a8351975c96606429","head":{"label":"kibao:fix/node-segmentation-fault","ref":"fix/node-segmentation-fault","sha":"69d616ad2371bee9a930cd0a8351975c96606429","user":{"login":"kibao","id":1156678,"avatar_url":"https://avatars.githubusercontent.com/u/1156678?v=3","gravatar_id":"","url":"https://api.github.com/users/kibao","html_url":"https://github.com/kibao","followers_url":"https://api.github.com/users/kibao/followers","following_url":"https://api.github.com/users/kibao/following{/other_user}","gists_url":"https://api.github.com/users/kibao/gists{/gist_id}","starred_url":"https://api.github.com/users/kibao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibao/subscriptions","organizations_url":"https://api.github.com/users/kibao/orgs","repos_url":"https://api.github.com/users/kibao/repos","events_url":"https://api.github.com/users/kibao/events{/privacy}","received_events_url":"https://api.github.com/users/kibao/received_events","type":"User","site_admin":false},"repo":{"id":34825892,"name":"fabric.js","full_name":"kibao/fabric.js","owner":{"login":"kibao","id":1156678,"avatar_url":"https://avatars.githubusercontent.com/u/1156678?v=3","gravatar_id":"","url":"https://api.github.com/users/kibao","html_url":"https://github.com/kibao","followers_url":"https://api.github.com/users/kibao/followers","following_url":"https://api.github.com/users/kibao/following{/other_user}","gists_url":"https://api.github.com/users/kibao/gists{/gist_id}","starred_url":"https://api.github.com/users/kibao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibao/subscriptions","organizations_url":"https://api.github.com/users/kibao/orgs","repos_url":"https://api.github.com/users/kibao/repos","events_url":"https://api.github.com/users/kibao/events{/privacy}","received_events_url":"https://api.github.com/users/kibao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kibao/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":true,"url":"https://api.github.com/repos/kibao/fabric.js","forks_url":"https://api.github.com/repos/kibao/fabric.js/forks","keys_url":"https://api.github.com/repos/kibao/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kibao/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kibao/fabric.js/teams","hooks_url":"https://api.github.com/repos/kibao/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/kibao/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/kibao/fabric.js/events","assignees_url":"https://api.github.com/repos/kibao/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/kibao/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/kibao/fabric.js/tags","blobs_url":"https://api.github.com/repos/kibao/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kibao/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kibao/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kibao/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kibao/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kibao/fabric.js/languages","stargazers_url":"https://api.github.com/repos/kibao/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/kibao/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/kibao/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/kibao/fabric.js/subscription","commits_url":"https://api.github.com/repos/kibao/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kibao/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kibao/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kibao/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kibao/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/kibao/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kibao/fabric.js/merges","archive_url":"https://api.github.com/repos/kibao/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kibao/fabric.js/downloads","issues_url":"https://api.github.com/repos/kibao/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/kibao/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kibao/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kibao/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kibao/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/kibao/fabric.js/releases{/id}","created_at":"2015-04-30T00:39:08Z","updated_at":"2015-04-30T00:39:09Z","pushed_at":"2015-05-06T19:41:17Z","git_url":"git://github.com/kibao/fabric.js.git","ssh_url":"git@github.com:kibao/fabric.js.git","clone_url":"https://github.com/kibao/fabric.js.git","svn_url":"https://github.com/kibao/fabric.js","homepage":"http://fabricjs.com","size":94412,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kangax:master","ref":"master","sha":"91897de4957fcf02e2b07854abeaba75c3893184","user":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"repo":{"id":712530,"name":"fabric.js","full_name":"kangax/fabric.js","owner":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kangax/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":false,"url":"https://api.github.com/repos/kangax/fabric.js","forks_url":"https://api.github.com/repos/kangax/fabric.js/forks","keys_url":"https://api.github.com/repos/kangax/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kangax/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kangax/fabric.js/teams","hooks_url":"https://api.github.com/repos/kangax/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/kangax/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/kangax/fabric.js/events","assignees_url":"https://api.github.com/repos/kangax/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/kangax/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/kangax/fabric.js/tags","blobs_url":"https://api.github.com/repos/kangax/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kangax/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kangax/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kangax/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kangax/fabric.js/languages","stargazers_url":"https://api.github.com/repos/kangax/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/kangax/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/kangax/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/kangax/fabric.js/subscription","commits_url":"https://api.github.com/repos/kangax/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kangax/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kangax/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kangax/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kangax/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/kangax/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kangax/fabric.js/merges","archive_url":"https://api.github.com/repos/kangax/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kangax/fabric.js/downloads","issues_url":"https://api.github.com/repos/kangax/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/kangax/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kangax/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kangax/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kangax/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/kangax/fabric.js/releases{/id}","created_at":"2010-06-09T22:24:38Z","updated_at":"2015-05-13T11:01:59Z","pushed_at":"2015-05-13T15:47:06Z","git_url":"git://github.com/kangax/fabric.js.git","ssh_url":"git@github.com:kangax/fabric.js.git","clone_url":"https://github.com/kangax/fabric.js.git","svn_url":"https://github.com/kangax/fabric.js","homepage":"http://fabricjs.com","size":112936,"stargazers_count":4307,"watchers_count":4307,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":732,"mirror_url":null,"open_issues_count":235,"forks":732,"open_issues":235,"watchers":4307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2163"},"html":{"href":"https://github.com/kangax/fabric.js/pull/2163"},"issue":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2163"},"comments":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2163/comments"},"review_comments":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2163/comments"},"review_comment":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2163/commits"},"statuses":{"href":"https://api.github.com/repos/kangax/fabric.js/statuses/69d616ad2371bee9a930cd0a8351975c96606429"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":30,"deletions":4,"changed_files":2}}