{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/1344","labels_url":"https://api.github.com/repos/request/request/issues/1344/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/1344/comments","events_url":"https://api.github.com/repos/request/request/issues/1344/events","html_url":"https://github.com/request/request/pull/1344","id":53700428,"number":1344,"title":"Removed need for HTTPS sites to be proxied by tunnels only. Fixes #1293","user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-08T00:25:48Z","updated_at":"2015-01-08T16:28:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/request/request/pulls/1344","html_url":"https://github.com/request/request/pull/1344","diff_url":"https://github.com/request/request/pull/1344.diff","patch_url":"https://github.com/request/request/pull/1344.patch"},"body":"As discussed in #1293, it is possible to want to do the same HTTP to HTTP proxying when talking to an HTTPS server. This PR allows that by removing the enforcement of HTTPS going to tunneling. In this PR:\r\n\r\n- Removed HTTPS requiring usage of HTTP tunnelling\r\n- Added test via @nylen \r\n- Updated documentation\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/69204913","html_url":"https://github.com/request/request/pull/1344#issuecomment-69204913","issue_url":"https://api.github.com/repos/request/request/issues/1344","id":69204913,"user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T16:28:07Z","updated_at":"2015-01-08T16:28:07Z","body":"Oh... I think I missed something here...\r\n\r\n**By default**, we still want to tunnel proxied requests to a HTTPS endpoint.  If we had had a test for that behavior (like we really should have) then that test would have broken with this change.\r\n\r\nWhat we should be adding here is the **option** to disable tunneling HTTPS requests.\r\n\r\nMake sense?"}}