{"action":"created","issue":{"url":"https://api.github.com/repos/hw-cookbooks/runit/issues/158","labels_url":"https://api.github.com/repos/hw-cookbooks/runit/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/hw-cookbooks/runit/issues/158/comments","events_url":"https://api.github.com/repos/hw-cookbooks/runit/issues/158/events","html_url":"https://github.com/hw-cookbooks/runit/pull/158","id":111265052,"number":158,"title":"Revert `manage_env_dir` feature, fix env dir management regression","user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hw-cookbooks/runit/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-13T20:34:27Z","updated_at":"2015-10-13T20:40:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hw-cookbooks/runit/pulls/158","html_url":"https://github.com/hw-cookbooks/runit/pull/158","diff_url":"https://github.com/hw-cookbooks/runit/pull/158.diff","patch_url":"https://github.com/hw-cookbooks/runit/pull/158.patch"},"body":"In preparing changelog notes for a new release I realized that we are adding a feature flag to block cleaning up the environment, when this might be better treated as a regression from the [behavior introduced in v1.6.0](https://github.com/hw-cookbooks/runit/blob/v1.6.0/libraries/provider_runit_service.rb#L108).\r\n\r\nIn the prior implementation, \"zapping\" env files which aren't explicitly declared in Chef is only called if the Chef runit_service resource has a non-empty `env` hash. The changes in #107 reimplemented the \"zapping\" behavior, but did not retain the same guard preventing action when `env` is empty. This change should resolve that regression."},"comment":{"url":"https://api.github.com/repos/hw-cookbooks/runit/issues/comments/147845925","html_url":"https://github.com/hw-cookbooks/runit/pull/158#issuecomment-147845925","issue_url":"https://api.github.com/repos/hw-cookbooks/runit/issues/158","id":147845925,"user":{"login":"chrisroberts","id":266674,"avatar_url":"https://avatars.githubusercontent.com/u/266674?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroberts","html_url":"https://github.com/chrisroberts","followers_url":"https://api.github.com/users/chrisroberts/followers","following_url":"https://api.github.com/users/chrisroberts/following{/other_user}","gists_url":"https://api.github.com/users/chrisroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroberts/subscriptions","organizations_url":"https://api.github.com/users/chrisroberts/orgs","repos_url":"https://api.github.com/users/chrisroberts/repos","events_url":"https://api.github.com/users/chrisroberts/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroberts/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T20:40:37Z","updated_at":"2015-10-13T20:40:37Z","body":"(:+1: + :beers:) * :100: "}}