{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/12405","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12405/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12405/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12405/events","html_url":"https://github.com/cms-sw/cmssw/pull/12405","id":116585616,"number":12405,"title":"Update tracking MiniAOD validation","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":216,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2015-11-18T10:50:54Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-11-12T16:28:30Z","updated_at":"2015-11-18T10:55:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12405","html_url":"https://github.com/cms-sw/cmssw/pull/12405","diff_url":"https://github.com/cms-sw/cmssw/pull/12405.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12405.patch"},"body":"This PR gives a major update to the tracking MiniAOD validation code.\r\n* Compare only charged PackedCandidates\r\n* Check `normalizedChi2` only if PackedCandidate ndof != 0\r\n  * it it is 0, its `normalizedChi2` is 0 by construction\r\n* Check `hasValidHitInFirstPixelBarrel()` only if there are no lost inner hits\r\n  * if there are, this information is not valid\r\n* Record the number of tracks used in the two cases above in the selection flow histogram\r\n* Monitor the overflow of pixel hits, strip hits, and total number of hits\r\n* Add (LogInfo) printout for track-PackedCandidate pairs where differences are outside tolerances\r\n  * Helps to track them down\r\n* Detailed monitoring of the precision of packed floating point values\r\n  * Try to catch and monitor under/overflows and sign changes\r\n  * Limit monitoring mainly to the packed quantities (e.g. prefer covariance matrix elements over the corresponding \"errors\"), but provide monitoring of most interesting quantities where \"equality within packing precision\" is not expected (e.g. pT)\r\n\r\nTested in CMSSW_8_0_X_2015-11-11-2300, expecting changes in `Tracking/PackedCandidate` DQM folder.\r\n\r\n@rovere @VinInn @arizzi @gpetruc "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/157678162","html_url":"https://github.com/cms-sw/cmssw/pull/12405#issuecomment-157678162","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12405","id":157678162,"user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T10:55:23Z","updated_at":"2015-11-18T10:55:23Z","body":"ping"}}