{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/27766789","id":27766789,"diff_hunk":"@@ -1,149 +1,148 @@\n-{stdenv, fetchurl, bash, perl, yasm\n-, vp8Support ? true # VP8\n+{stdenv, fetchFromGitHub, perl, yasm\n , vp8DecoderSupport ? true # VP8 decoder\n , vp8EncoderSupport ? true # VP8 encoder\n-, vp9Support ? true # VP9\n , vp9DecoderSupport ? true # VP9 decoder\n , vp9EncoderSupport ? true # VP9 encoder\n , extraWarningsSupport ? false # emit non-fatal warnings\n , werrorSupport ? false # treat warnings as errors (not available with all compilers)\n-, installBinsSupport ? true # install binaries (vpxdec & vpxenc)\n-, installLibsSupport ? true # install libraries\n-, installSrcsSupport ? false # install sources\n , debugSupport ? false # debug mode\n , gprofSupport ? false # gprof profiling instrumentation\n , gcovSupport ? false # gcov coverage instrumentation\n+, sizeLimitSupport ? true # limit max size to allow in the decoder\n , optimizationsSupport ? true # compiler optimization flags\n , runtimeCpuDetectSupport ? true # detect cpu capabilities at runtime\n , thumbSupport ? false # build arm assembly in thumb mode\n-, libsSupport ? true # build librares\n , examplesSupport ? true # build examples (vpxdec & vpxenc are part of examples)\n , fastUnalignedSupport ? true # use unaligned accesses if supported by hardware\n-, codecSrcsSupport ? false # codec library source code\n , debugLibsSupport ? false # include debug version of each library\n-, md5Support ? true # support for output of checksum data\n , postprocSupport ? true # postprocessing\n-, vp9PostprocSupport ? true # VP9 specific postprocessing\n , multithreadSupport ? true # multithreaded decoding & encoding\n , internalStatsSupport ? false # output of encoder internal stats for debug, if supported (encoders)\n , memTrackerSupport ? false # track memory usage\n+, spatialResamplingSupport ? true # spatial sampling (scaling)\n , realtimeOnlySupport ? false # build for real-time encoding\n , ontheflyBitpackingSupport ? false # on-the-fly bitpacking in real-time encoding\n , errorConcealmentSupport ? false # decoder conceals losses\n , smallSupport ? false # favor smaller binary over speed\n , postprocVisualizerSupport ? false # macro block/block level visualizers\n , unitTestsSupport ? false, curl ? null, coreutils ? null # unit tests\n+, webmIOSupport ? true # input from and output to webm container\n+, libyuvSupport ? true # libyuv\n+, decodePerfTestsSupport ? false # build decoder perf tests with unit tests\n+, encodePerfTestsSupport ? false # build encoder perf tests with unit tests\n , multiResEncodingSupport ? false # multiple-resolution encoding\n , temporalDenoisingSupport ? true # use temporal denoising instead of spatial denoising\n-, decryptSupport ? false\n+, coefficientRangeCheckingSupport ? false # decoder checks if intermediate transform coefficients are in valid range\n+, vp9HighbitdepthSupport ? true # 10/12 bit color support in VP9\n , experimentalSupport ? false # experimental features\n # Experimental features\n-, experimentalMultipleArfSupport ? false\n-, experimentalNon420Support ? false\n-, experimentalAlphaSupport ? false\n+, experimentalSpatialSvcSupport ? false # Spatial scalable video coding\n+, experimentalFpMbStatsSupport ? false\n+, experimentalEmulateHardwareSupport ? false\n }:\n \n-assert (vp8Support || vp9Support);\n-assert (vp8DecoderSupport || vp8EncoderSupport || vp9DecoderSupport || vp9EncoderSupport);\n-assert vp8DecoderSupport -> vp8Support;\n-assert vp8EncoderSupport -> vp8Support;\n-assert vp9DecoderSupport -> vp9Support;\n-assert vp9EncoderSupport -> vp9Support;\n-assert installLibsSupport -> libsSupport;\n-# libvpx will not build binaries if examplesSupport is not enabled (ie. vpxdec & vpxenc)\n-assert installBinsSupport -> examplesSupport;\n-assert examplesSupport -> md5Support;\n-assert vp9PostprocSupport -> (vp9Support && postprocSupport);\n-assert (internalStatsSupport && vp9Support) -> vp9PostprocSupport;\n-assert postprocVisualizerSupport -> postprocSupport;\n-assert (postprocVisualizerSupport && vp9Support) -> vp9PostprocSupport;\n-assert unitTestsSupport -> ((curl != null) && (coreutils != null));\n-assert (experimentalMultipleArfSupport || experimentalNon420Support || experimentalAlphaSupport) -> experimentalSupport;\n-assert stdenv.isCygwin -> unitTestsSupport;\n-\n let\n-  mkFlag = optSet: flag: if optSet then \"--enable-${flag}\" else \"--disable-${flag}\";\n+  inherit (stdenv) isi686 isx86_64 isArm is64bit isMips isDarwin isCygwin;\n+  inherit (stdenv.lib) enableFeature optional optionals;\n in\n \n-with stdenv.lib;\n-stdenv.mkDerivation rec {\n-  name = \"libvpx-${version}\";\n-  version = \"1.3.0\";\n+assert isi686 || isx86_64 || isArm || isMips; # Requires ARM with floating point support\n \n-  src = fetchurl {\n-    url = \"http://webm.googlecode.com/files/libvpx-v${version}.tar.bz2\";\n-    sha1 = \"191b95817aede8c136cc3f3745fb1b8c50e6d5dc\";\n-  };\n+assert vp8DecoderSupport || vp8EncoderSupport || vp9DecoderSupport || vp9EncoderSupport;\n+assert internalStatsSupport && (vp9DecoderSupport || vp9EncoderSupport) -> postprocSupport;\n+/* If spatialResamplingSupport not enabled, build will fail with undeclared variable errors.\n+   Variables called in vpx_scale/generic/vpx_scale.c are declared by vpx_scale/vpx_scale_rtcd.pl,\n+   but is only executed if spatialResamplingSupport is enabled */\n+assert spatialResamplingSupport;\n+assert postprocVisualizerSupport -> postprocSupport;\n+assert unitTestsSupport -> curl != null && coreutils != null;\n+assert vp9HighbitdepthSupport -> (vp9DecoderSupport || vp9EncoderSupport);\n+assert isCygwin -> unitTestsSupport && webmIOSupport && libyuvSupport;\n \n-  patchPhase = ''\n-    patchShebangs .\n-  '';\n+stdenv.mkDerivation rec {\n+  name = \"libvpx-git-${version}\";","path":"pkgs/development/libraries/libvpx/default.nix","position":107,"original_position":107,"commit_id":"23e00ca9c8d49e658aa3daece6a67577ec388e26","original_commit_id":"23e00ca9c8d49e658aa3daece6a67577ec388e26","user":{"login":"spwhitt","id":1414088,"avatar_url":"https://avatars.githubusercontent.com/u/1414088?v=3","gravatar_id":"","url":"https://api.github.com/users/spwhitt","html_url":"https://github.com/spwhitt","followers_url":"https://api.github.com/users/spwhitt/followers","following_url":"https://api.github.com/users/spwhitt/following{/other_user}","gists_url":"https://api.github.com/users/spwhitt/gists{/gist_id}","starred_url":"https://api.github.com/users/spwhitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spwhitt/subscriptions","organizations_url":"https://api.github.com/users/spwhitt/orgs","repos_url":"https://api.github.com/users/spwhitt/repos","events_url":"https://api.github.com/users/spwhitt/events{/privacy}","received_events_url":"https://api.github.com/users/spwhitt/received_events","type":"User","site_admin":false},"body":"Name shouldn't have -git","created_at":"2015-04-04T05:39:03Z","updated_at":"2015-04-04T05:39:03Z","html_url":"https://github.com/NixOS/nixpkgs/pull/7159#discussion_r27766789","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/27766789"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7159#discussion_r27766789"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159","id":32618227,"html_url":"https://github.com/NixOS/nixpkgs/pull/7159","diff_url":"https://github.com/NixOS/nixpkgs/pull/7159.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/7159.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7159","number":7159,"state":"open","locked":false,"title":"libvpx: refactor & 1.3.0 -> 1.4.0","user":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"body":"~~Fixed compilation using clang 3.5+\r\nFixed building on Darwin\r\nRemoved unnecessary optionals simplifying the build~~\r\n\r\n@spwhitt @gridaphobe \r\n~~This should resolve compilation using clang 3.5+ for 1.3.0, and hopefully fixes the build on Darwin.  I also refactored the build to simplify everything as much as possible in case more fixes are needed.~~","created_at":"2015-04-03T21:34:24Z","updated_at":"2015-04-04T05:39:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77125d84333370a6fb786977f775924c6c9592f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7159/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/23e00ca9c8d49e658aa3daece6a67577ec388e26","head":{"label":"codyopel:libvpx-cleanup","ref":"libvpx-cleanup","sha":"23e00ca9c8d49e658aa3daece6a67577ec388e26","user":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"repo":{"id":30282343,"name":"nixpkgs","full_name":"codyopel/nixpkgs","owner":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codyopel/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/codyopel/nixpkgs","forks_url":"https://api.github.com/repos/codyopel/nixpkgs/forks","keys_url":"https://api.github.com/repos/codyopel/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codyopel/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codyopel/nixpkgs/teams","hooks_url":"https://api.github.com/repos/codyopel/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/codyopel/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/codyopel/nixpkgs/events","assignees_url":"https://api.github.com/repos/codyopel/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/codyopel/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/codyopel/nixpkgs/tags","blobs_url":"https://api.github.com/repos/codyopel/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codyopel/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codyopel/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/codyopel/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codyopel/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/codyopel/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/codyopel/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/codyopel/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/codyopel/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/codyopel/nixpkgs/subscription","commits_url":"https://api.github.com/repos/codyopel/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/codyopel/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/codyopel/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/codyopel/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/codyopel/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/codyopel/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codyopel/nixpkgs/merges","archive_url":"https://api.github.com/repos/codyopel/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codyopel/nixpkgs/downloads","issues_url":"https://api.github.com/repos/codyopel/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/codyopel/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/codyopel/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/codyopel/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codyopel/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/codyopel/nixpkgs/releases{/id}","created_at":"2015-02-04T05:02:33Z","updated_at":"2015-04-03T17:50:00Z","pushed_at":"2015-04-04T05:26:14Z","git_url":"git://github.com/codyopel/nixpkgs.git","ssh_url":"git@github.com:codyopel/nixpkgs.git","clone_url":"https://github.com/codyopel/nixpkgs.git","svn_url":"https://github.com/codyopel/nixpkgs","homepage":null,"size":155786,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"755230967b9a34f6e3c9980c3fb3d4288bc88bb1","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-04-04T04:55:02Z","pushed_at":"2015-04-04T05:26:16Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":333710,"stargazers_count":589,"watchers_count":589,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":742,"mirror_url":null,"open_issues_count":650,"forks":742,"open_issues":650,"watchers":589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7159"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7159"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7159/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7159/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/23e00ca9c8d49e658aa3daece6a67577ec388e26"}}}}