{"action":"created","comment":{"url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments/48588021","id":48588021,"diff_hunk":"@@ -351,5 +373,9 @@ def destroy_image(image)\n       image.destroy! if image.respond_to?(:destroy!)\n     end\n \n+    def rmagick_image\n+      ::Magick::Image.ping(current_path).first","path":"lib/carrierwave/processing/rmagick.rb","position":34,"original_position":34,"commit_id":"ca296b6875357cd000c96c1ba4d4e02c2cd90494","original_commit_id":"ca296b6875357cd000c96c1ba4d4e02c2cd90494","user":{"login":"thomasfedb","id":193831,"avatar_url":"https://avatars.githubusercontent.com/u/193831?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasfedb","html_url":"https://github.com/thomasfedb","followers_url":"https://api.github.com/users/thomasfedb/followers","following_url":"https://api.github.com/users/thomasfedb/following{/other_user}","gists_url":"https://api.github.com/users/thomasfedb/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfedb/subscriptions","organizations_url":"https://api.github.com/users/thomasfedb/orgs","repos_url":"https://api.github.com/users/thomasfedb/repos","events_url":"https://api.github.com/users/thomasfedb/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfedb/received_events","type":"User","site_admin":false},"body":"I'm a little concerned about this. Calling `ping` will return an image with invalid pixel data, and naming this `rmagick_image` seems to be asking for trouble.\r\n\r\nEither we need to read the entire image, or we should rename the method.","created_at":"2015-12-30T06:00:35Z","updated_at":"2015-12-30T06:00:35Z","html_url":"https://github.com/carrierwaveuploader/carrierwave/pull/1805#discussion_r48588021","pull_request_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805","_links":{"self":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments/48588021"},"html":{"href":"https://github.com/carrierwaveuploader/carrierwave/pull/1805#discussion_r48588021"},"pull_request":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805"}}},"pull_request":{"url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805","id":54759736,"html_url":"https://github.com/carrierwaveuploader/carrierwave/pull/1805","diff_url":"https://github.com/carrierwaveuploader/carrierwave/pull/1805.diff","patch_url":"https://github.com/carrierwaveuploader/carrierwave/pull/1805.patch","issue_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/1805","number":1805,"state":"open","locked":false,"title":"Add `#width` and `#height` methods to the RMagick processor","user":{"login":"mehlah","id":224928,"avatar_url":"https://avatars.githubusercontent.com/u/224928?v=3","gravatar_id":"","url":"https://api.github.com/users/mehlah","html_url":"https://github.com/mehlah","followers_url":"https://api.github.com/users/mehlah/followers","following_url":"https://api.github.com/users/mehlah/following{/other_user}","gists_url":"https://api.github.com/users/mehlah/gists{/gist_id}","starred_url":"https://api.github.com/users/mehlah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehlah/subscriptions","organizations_url":"https://api.github.com/users/mehlah/orgs","repos_url":"https://api.github.com/users/mehlah/repos","events_url":"https://api.github.com/users/mehlah/events{/privacy}","received_events_url":"https://api.github.com/users/mehlah/received_events","type":"User","site_admin":false},"body":"This keeps the symmetry with MiniMagick processor where `#width` and\r\n`#height` methods has been introduced by #1405.","created_at":"2015-12-29T21:32:37Z","updated_at":"2015-12-30T06:00:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06ba3775f8633b50fce8a35aa4409a5923f78884","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805/commits","review_comments_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805/comments","review_comment_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/1805/comments","statuses_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/statuses/ca296b6875357cd000c96c1ba4d4e02c2cd90494","head":{"label":"mehlah:rmagick_width_and_height","ref":"rmagick_width_and_height","sha":"ca296b6875357cd000c96c1ba4d4e02c2cd90494","user":{"login":"mehlah","id":224928,"avatar_url":"https://avatars.githubusercontent.com/u/224928?v=3","gravatar_id":"","url":"https://api.github.com/users/mehlah","html_url":"https://github.com/mehlah","followers_url":"https://api.github.com/users/mehlah/followers","following_url":"https://api.github.com/users/mehlah/following{/other_user}","gists_url":"https://api.github.com/users/mehlah/gists{/gist_id}","starred_url":"https://api.github.com/users/mehlah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehlah/subscriptions","organizations_url":"https://api.github.com/users/mehlah/orgs","repos_url":"https://api.github.com/users/mehlah/repos","events_url":"https://api.github.com/users/mehlah/events{/privacy}","received_events_url":"https://api.github.com/users/mehlah/received_events","type":"User","site_admin":false},"repo":{"id":48620389,"name":"carrierwave","full_name":"mehlah/carrierwave","owner":{"login":"mehlah","id":224928,"avatar_url":"https://avatars.githubusercontent.com/u/224928?v=3","gravatar_id":"","url":"https://api.github.com/users/mehlah","html_url":"https://github.com/mehlah","followers_url":"https://api.github.com/users/mehlah/followers","following_url":"https://api.github.com/users/mehlah/following{/other_user}","gists_url":"https://api.github.com/users/mehlah/gists{/gist_id}","starred_url":"https://api.github.com/users/mehlah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehlah/subscriptions","organizations_url":"https://api.github.com/users/mehlah/orgs","repos_url":"https://api.github.com/users/mehlah/repos","events_url":"https://api.github.com/users/mehlah/events{/privacy}","received_events_url":"https://api.github.com/users/mehlah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mehlah/carrierwave","description":"Classier solution for file uploads for Rails, Sinatra and other Ruby web frameworks","fork":true,"url":"https://api.github.com/repos/mehlah/carrierwave","forks_url":"https://api.github.com/repos/mehlah/carrierwave/forks","keys_url":"https://api.github.com/repos/mehlah/carrierwave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mehlah/carrierwave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mehlah/carrierwave/teams","hooks_url":"https://api.github.com/repos/mehlah/carrierwave/hooks","issue_events_url":"https://api.github.com/repos/mehlah/carrierwave/issues/events{/number}","events_url":"https://api.github.com/repos/mehlah/carrierwave/events","assignees_url":"https://api.github.com/repos/mehlah/carrierwave/assignees{/user}","branches_url":"https://api.github.com/repos/mehlah/carrierwave/branches{/branch}","tags_url":"https://api.github.com/repos/mehlah/carrierwave/tags","blobs_url":"https://api.github.com/repos/mehlah/carrierwave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mehlah/carrierwave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mehlah/carrierwave/git/refs{/sha}","trees_url":"https://api.github.com/repos/mehlah/carrierwave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mehlah/carrierwave/statuses/{sha}","languages_url":"https://api.github.com/repos/mehlah/carrierwave/languages","stargazers_url":"https://api.github.com/repos/mehlah/carrierwave/stargazers","contributors_url":"https://api.github.com/repos/mehlah/carrierwave/contributors","subscribers_url":"https://api.github.com/repos/mehlah/carrierwave/subscribers","subscription_url":"https://api.github.com/repos/mehlah/carrierwave/subscription","commits_url":"https://api.github.com/repos/mehlah/carrierwave/commits{/sha}","git_commits_url":"https://api.github.com/repos/mehlah/carrierwave/git/commits{/sha}","comments_url":"https://api.github.com/repos/mehlah/carrierwave/comments{/number}","issue_comment_url":"https://api.github.com/repos/mehlah/carrierwave/issues/comments{/number}","contents_url":"https://api.github.com/repos/mehlah/carrierwave/contents/{+path}","compare_url":"https://api.github.com/repos/mehlah/carrierwave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mehlah/carrierwave/merges","archive_url":"https://api.github.com/repos/mehlah/carrierwave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mehlah/carrierwave/downloads","issues_url":"https://api.github.com/repos/mehlah/carrierwave/issues{/number}","pulls_url":"https://api.github.com/repos/mehlah/carrierwave/pulls{/number}","milestones_url":"https://api.github.com/repos/mehlah/carrierwave/milestones{/number}","notifications_url":"https://api.github.com/repos/mehlah/carrierwave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mehlah/carrierwave/labels{/name}","releases_url":"https://api.github.com/repos/mehlah/carrierwave/releases{/id}","created_at":"2015-12-26T18:47:08Z","updated_at":"2015-12-26T18:47:09Z","pushed_at":"2015-12-29T23:13:40Z","git_url":"git://github.com/mehlah/carrierwave.git","ssh_url":"git@github.com:mehlah/carrierwave.git","clone_url":"https://github.com/mehlah/carrierwave.git","svn_url":"https://github.com/mehlah/carrierwave","homepage":"https://github.com/carrierwaveuploader/carrierwave","size":3350,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carrierwaveuploader:master","ref":"master","sha":"ecf57fe5fed17657b258d708a59feeec9fac74cd","user":{"login":"carrierwaveuploader","id":3982589,"avatar_url":"https://avatars.githubusercontent.com/u/3982589?v=3","gravatar_id":"","url":"https://api.github.com/users/carrierwaveuploader","html_url":"https://github.com/carrierwaveuploader","followers_url":"https://api.github.com/users/carrierwaveuploader/followers","following_url":"https://api.github.com/users/carrierwaveuploader/following{/other_user}","gists_url":"https://api.github.com/users/carrierwaveuploader/gists{/gist_id}","starred_url":"https://api.github.com/users/carrierwaveuploader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrierwaveuploader/subscriptions","organizations_url":"https://api.github.com/users/carrierwaveuploader/orgs","repos_url":"https://api.github.com/users/carrierwaveuploader/repos","events_url":"https://api.github.com/users/carrierwaveuploader/events{/privacy}","received_events_url":"https://api.github.com/users/carrierwaveuploader/received_events","type":"Organization","site_admin":false},"repo":{"id":47087,"name":"carrierwave","full_name":"carrierwaveuploader/carrierwave","owner":{"login":"carrierwaveuploader","id":3982589,"avatar_url":"https://avatars.githubusercontent.com/u/3982589?v=3","gravatar_id":"","url":"https://api.github.com/users/carrierwaveuploader","html_url":"https://github.com/carrierwaveuploader","followers_url":"https://api.github.com/users/carrierwaveuploader/followers","following_url":"https://api.github.com/users/carrierwaveuploader/following{/other_user}","gists_url":"https://api.github.com/users/carrierwaveuploader/gists{/gist_id}","starred_url":"https://api.github.com/users/carrierwaveuploader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrierwaveuploader/subscriptions","organizations_url":"https://api.github.com/users/carrierwaveuploader/orgs","repos_url":"https://api.github.com/users/carrierwaveuploader/repos","events_url":"https://api.github.com/users/carrierwaveuploader/events{/privacy}","received_events_url":"https://api.github.com/users/carrierwaveuploader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carrierwaveuploader/carrierwave","description":"Classier solution for file uploads for Rails, Sinatra and other Ruby web frameworks","fork":false,"url":"https://api.github.com/repos/carrierwaveuploader/carrierwave","forks_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/forks","keys_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/teams","hooks_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/hooks","issue_events_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/events{/number}","events_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/events","assignees_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/assignees{/user}","branches_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/branches{/branch}","tags_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/tags","blobs_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/git/refs{/sha}","trees_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/statuses/{sha}","languages_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/languages","stargazers_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/stargazers","contributors_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/contributors","subscribers_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/subscribers","subscription_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/subscription","commits_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/commits{/sha}","git_commits_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/git/commits{/sha}","comments_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/comments{/number}","issue_comment_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/comments{/number}","contents_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/contents/{+path}","compare_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/merges","archive_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/downloads","issues_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues{/number}","pulls_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls{/number}","milestones_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/milestones{/number}","notifications_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/labels{/name}","releases_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/releases{/id}","created_at":"2008-08-28T18:39:49Z","updated_at":"2015-12-30T04:18:33Z","pushed_at":"2015-12-30T05:43:22Z","git_url":"git://github.com/carrierwaveuploader/carrierwave.git","ssh_url":"git@github.com:carrierwaveuploader/carrierwave.git","clone_url":"https://github.com/carrierwaveuploader/carrierwave.git","svn_url":"https://github.com/carrierwaveuploader/carrierwave","homepage":"https://github.com/carrierwaveuploader/carrierwave","size":5041,"stargazers_count":6348,"watchers_count":6348,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1113,"mirror_url":null,"open_issues_count":32,"forks":1113,"open_issues":32,"watchers":6348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805"},"html":{"href":"https://github.com/carrierwaveuploader/carrierwave/pull/1805"},"issue":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/1805"},"comments":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/issues/1805/comments"},"review_comments":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805/comments"},"review_comment":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1805/commits"},"statuses":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/statuses/ca296b6875357cd000c96c1ba4d4e02c2cd90494"}}}}