{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/4597","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/4597/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/4597/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/4597/events","html_url":"https://github.com/sequelize/sequelize/issues/4597","id":109265311,"number":4597,"title":"Naming collision in N-M options","user":{"login":"glutentag","id":7855229,"avatar_url":"https://avatars.githubusercontent.com/u/7855229?v=3","gravatar_id":"","url":"https://api.github.com/users/glutentag","html_url":"https://github.com/glutentag","followers_url":"https://api.github.com/users/glutentag/followers","following_url":"https://api.github.com/users/glutentag/following{/other_user}","gists_url":"https://api.github.com/users/glutentag/gists{/gist_id}","starred_url":"https://api.github.com/users/glutentag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glutentag/subscriptions","organizations_url":"https://api.github.com/users/glutentag/orgs","repos_url":"https://api.github.com/users/glutentag/repos","events_url":"https://api.github.com/users/glutentag/events{/privacy}","received_events_url":"https://api.github.com/users/glutentag/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sequelize/sequelize/labels/feature","name":"feature","color":"0b02e1"},{"url":"https://api.github.com/repos/sequelize/sequelize/labels/good-first-pr","name":"good-first-pr","color":"bfe5bf"},{"url":"https://api.github.com/repos/sequelize/sequelize/labels/refactor","name":"refactor","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-01T09:43:31Z","updated_at":"2015-10-02T06:51:35Z","closed_at":null,"body":"When using a N-M association accessor method, addAssociation for instance, the signature is:\r\n```\r\n(newInstances, additionalAttributes)\r\n```\r\ntransformed in\r\n```\r\noptions = additionalAttributes\r\n```\r\nThus, options is used in all queries (association.through.model.findAll), but also as additional attribute when creating the association through model. It can create bugs when this attribute is a keyword, 'order' for instance.\r\n\r\nCould it be possible to separate in the signature additionalAttributes from options?"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/144937551","html_url":"https://github.com/sequelize/sequelize/issues/4597#issuecomment-144937551","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/4597","id":144937551,"user":{"login":"mickhansen","id":699049,"avatar_url":"https://avatars.githubusercontent.com/u/699049?v=3","gravatar_id":"","url":"https://api.github.com/users/mickhansen","html_url":"https://github.com/mickhansen","followers_url":"https://api.github.com/users/mickhansen/followers","following_url":"https://api.github.com/users/mickhansen/following{/other_user}","gists_url":"https://api.github.com/users/mickhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/mickhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickhansen/subscriptions","organizations_url":"https://api.github.com/users/mickhansen/orgs","repos_url":"https://api.github.com/users/mickhansen/repos","events_url":"https://api.github.com/users/mickhansen/events{/privacy}","received_events_url":"https://api.github.com/users/mickhansen/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T06:51:35Z","updated_at":"2015-10-02T06:51:35Z","body":"I've never liked this piece of the code. But from the end user it made sense if you never used options for the setters and didnt want to pass an empty object/null."}}