{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/34768456","id":34768456,"diff_hunk":"@@ -249,24 +249,18 @@ def CopyResources(project_source, out_dir, out_project_dir, shared):\n   # Since there might be some resource files with same names from\n   # different folders like ui_java, content_java and others,\n   # it's necessary to rename some files to avoid overridding.\n-  if shared:\n-    res_to_copy = [\n-        # zip file list\n-        'xwalk_app_strings.zip',\n-        'xwalk_core_java.zip'\n-    ]\n-  else:\n-    res_to_copy = [\n-        # zip file list\n-        'content_java.zip',\n-        'content_strings_grd.zip',\n-        'ui_java.zip',\n-        'ui_strings_grd.zip',\n-        'web_contents_delegate_android_java.zip',\n-        'xwalk_core_internal_java.zip',\n-        'xwalk_core_strings.zip',\n-        'xwalk_app_strings.zip'\n-    ]\n+  res_to_copy = [\n+      # zip file list\n+      'content_java.zip',","path":"build/android/generate_xwalk_core_library.py","position":24,"original_position":24,"commit_id":"66a93f5b77396fa2c60afc2369ad37f16b35179e","original_commit_id":"5f3d8006248935363644e70fc1705a264f4c42ce","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"body":"Sometimes the app need to get chromium's resources in shared mode by XWalkApplication's help. Now we have to pack all resources in the app to avoid crash errors, even they are used a few","created_at":"2015-07-16T09:08:01Z","updated_at":"2015-07-16T09:08:01Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3138#discussion_r34768456","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/34768456"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3138#discussion_r34768456"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138","id":40103282,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/3138","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3138.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3138.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3138","number":3138,"state":"open","locked":false,"title":"[Android] Deprecate XWalkApplication","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"body":"XWalkApplication's role is to help the app to get resources from the\r\nXWalkRuntimeLib.apk in shared mode, but it also cause the\r\ninconvenience of developers. So we integrate the whole resources to\r\nthe app even in shared mode to get rid of this class.","created_at":"2015-07-16T07:56:28Z","updated_at":"2015-07-16T09:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f5ffd0b09d0b96f95f68366932f4b3a1acc500b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3138/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/66a93f5b77396fa2c60afc2369ad37f16b35179e","head":{"label":"lincsoon:resources","ref":"resources","sha":"66a93f5b77396fa2c60afc2369ad37f16b35179e","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"repo":{"id":22664891,"name":"crosswalk","full_name":"lincsoon/crosswalk","owner":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lincsoon/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/lincsoon/crosswalk","forks_url":"https://api.github.com/repos/lincsoon/crosswalk/forks","keys_url":"https://api.github.com/repos/lincsoon/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lincsoon/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lincsoon/crosswalk/teams","hooks_url":"https://api.github.com/repos/lincsoon/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/lincsoon/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/lincsoon/crosswalk/events","assignees_url":"https://api.github.com/repos/lincsoon/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/lincsoon/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/lincsoon/crosswalk/tags","blobs_url":"https://api.github.com/repos/lincsoon/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lincsoon/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lincsoon/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/lincsoon/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lincsoon/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/lincsoon/crosswalk/languages","stargazers_url":"https://api.github.com/repos/lincsoon/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/lincsoon/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/lincsoon/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/lincsoon/crosswalk/subscription","commits_url":"https://api.github.com/repos/lincsoon/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/lincsoon/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/lincsoon/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/lincsoon/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/lincsoon/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/lincsoon/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lincsoon/crosswalk/merges","archive_url":"https://api.github.com/repos/lincsoon/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lincsoon/crosswalk/downloads","issues_url":"https://api.github.com/repos/lincsoon/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/lincsoon/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/lincsoon/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/lincsoon/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lincsoon/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/lincsoon/crosswalk/releases{/id}","created_at":"2014-08-06T01:04:55Z","updated_at":"2015-05-07T07:34:06Z","pushed_at":"2015-07-16T09:02:37Z","git_url":"git://github.com/lincsoon/crosswalk.git","ssh_url":"git@github.com:lincsoon/crosswalk.git","clone_url":"https://github.com/lincsoon/crosswalk.git","svn_url":"https://github.com/lincsoon/crosswalk","homepage":"https://crosswalk-project.org/","size":14117,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"bb32a8e82ce4d5eaf35272ae5b1aee8db970e0c5","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2015-07-16T05:38:23Z","pushed_at":"2015-07-16T09:02:39Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":137102,"stargazers_count":899,"watchers_count":899,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":112,"forks":267,"open_issues":112,"watchers":899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3138"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3138"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3138/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3138/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/66a93f5b77396fa2c60afc2369ad37f16b35179e"}}}}