{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/33425104","id":33425104,"diff_hunk":"@@ -108,7 +108,10 @@ public Accumulator(Sink<E, CompletionStage<A>> sink) {\n      * @return A new accumulator with the given flow in its graph.\n      */\n     public <D> Accumulator<D, A> through(Flow<D, E, ?> flow) {\n-        return new Accumulator<>(flow.to(sink, Keep.right()));\n+    \t// This should be written: new Accumulator<>(flow.to(sink, Keep.right()));","path":"framework/src/play-streams/src/main/java/play/libs/streams/Accumulator.java","position":13,"original_position":13,"commit_id":"c993bd82d634abe869ba940cd29eeb599cb53a60","original_commit_id":"c993bd82d634abe869ba940cd29eeb599cb53a60","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"I can't test it myself, as I'm going to be without a laptop for a few weeks ;-) But hopefully someone can give it a try and let you know. Thanks again!","created_at":"2015-06-28T17:55:04Z","updated_at":"2015-06-28T17:55:04Z","html_url":"https://github.com/playframework/playframework/pull/4776#discussion_r33425104","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/4776","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/33425104"},"html":{"href":"https://github.com/playframework/playframework/pull/4776#discussion_r33425104"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4776"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/4776","id":38652397,"html_url":"https://github.com/playframework/playframework/pull/4776","diff_url":"https://github.com/playframework/playframework/pull/4776.diff","patch_url":"https://github.com/playframework/playframework/pull/4776.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/4776","number":4776,"state":"open","locked":false,"title":"Bumped akka-stream and akka-http to 1.0-RC4. Fix #4774","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"body":"*This PR was built on top of https://github.com/playframework/playframework/pull/4768 (hence, the linked PR must be merged before this).*\r\n\r\n[The only commit relevant for this PR is https://github.com/playframework/playframework/commit/eea1b3112a2be1e38787b3dda83b818f914f6d5f] \r\n\r\n* Moving from RC3 to RC4 had quite an impact because of the many class'\r\n  renamings.\r\n\r\n* It seems there is an overloading issue with `Flow.to` (see comment in\r\n  `play.libs.streams.Accumulator.through`). We should report the problem\r\n  to the akka team.\r\n\r\n* Had to make `play.it.http.JavaResultsHandlingSpec` and\r\n  `play.it.http.ScalaResultsHandlingSpec` running sequentially because they\r\n  would fail otherwise (not sure what has changed in akka-http to cause it, but\r\n  I assumed it may have been caused by additional asynchronism in the impl).\r\n\r\nOne thing that worries me is that some akka-strems type leak into the Play user\r\nAPI (for instance, see `FlowMaterializer` in `play.api.mvc.Filters`), ~~and the\r\nname changes that occurred between RC3 and RC4 are such that I don't think this\r\ncommit can be backported to the 2.4.x branch (because of binary compatibility).~~ \r\nand akka-streams is an experimental module that hence doesn't ensure backward \r\nbinary compatibility across releases. I'm not sure if this is actually going to be an \r\nissue, but I think we should keep it in mind.\r\n\r\n~~Because of the above, I'm wondering if we should have a 2.5 release that only\r\nupgrades Play 2.4 to use akka-streams 1.0 final (once 1.0 is actually out, which\r\nshould happen soon enough).~~ (EDIT: We don't use akka-stream in Play 2.4, so \r\nforget about what I said).","created_at":"2015-06-26T14:06:46Z","updated_at":"2015-06-28T17:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"896d4048ae6af9013db17f1ba8c101ea2007cc29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/4776/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/4776/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/4776/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/c993bd82d634abe869ba940cd29eeb599cb53a60","head":{"label":"dotta:wip/update-akka-streams-rc4","ref":"wip/update-akka-streams-rc4","sha":"c993bd82d634abe869ba940cd29eeb599cb53a60","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"repo":{"id":27679969,"name":"playframework","full_name":"dotta/playframework","owner":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotta/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/dotta/playframework","forks_url":"https://api.github.com/repos/dotta/playframework/forks","keys_url":"https://api.github.com/repos/dotta/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotta/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotta/playframework/teams","hooks_url":"https://api.github.com/repos/dotta/playframework/hooks","issue_events_url":"https://api.github.com/repos/dotta/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/dotta/playframework/events","assignees_url":"https://api.github.com/repos/dotta/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/dotta/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/dotta/playframework/tags","blobs_url":"https://api.github.com/repos/dotta/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotta/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotta/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotta/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotta/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/dotta/playframework/languages","stargazers_url":"https://api.github.com/repos/dotta/playframework/stargazers","contributors_url":"https://api.github.com/repos/dotta/playframework/contributors","subscribers_url":"https://api.github.com/repos/dotta/playframework/subscribers","subscription_url":"https://api.github.com/repos/dotta/playframework/subscription","commits_url":"https://api.github.com/repos/dotta/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotta/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotta/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotta/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotta/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/dotta/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotta/playframework/merges","archive_url":"https://api.github.com/repos/dotta/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotta/playframework/downloads","issues_url":"https://api.github.com/repos/dotta/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/dotta/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/dotta/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/dotta/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotta/playframework/labels{/name}","releases_url":"https://api.github.com/repos/dotta/playframework/releases{/id}","created_at":"2014-12-07T18:26:54Z","updated_at":"2015-05-06T16:18:19Z","pushed_at":"2015-06-27T14:11:01Z","git_url":"git://github.com/dotta/playframework.git","ssh_url":"git@github.com:dotta/playframework.git","clone_url":"https://github.com/dotta/playframework.git","svn_url":"https://github.com/dotta/playframework","homepage":"http://www.playframework.com/","size":77491,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"24c009c596cd52b0d6003be6ebb3d800979de7da","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-06-28T16:30:33Z","pushed_at":"2015-06-28T17:00:16Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":126923,"stargazers_count":6465,"watchers_count":6465,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2290,"mirror_url":null,"open_issues_count":253,"forks":2290,"open_issues":253,"watchers":6465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4776"},"html":{"href":"https://github.com/playframework/playframework/pull/4776"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/4776"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/4776/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4776/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4776/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/c993bd82d634abe869ba940cd29eeb599cb53a60"}}}}