{"action":"created","issue":{"url":"https://api.github.com/repos/smhg/date-period/issues/4","labels_url":"https://api.github.com/repos/smhg/date-period/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/smhg/date-period/issues/4/comments","events_url":"https://api.github.com/repos/smhg/date-period/issues/4/events","html_url":"https://github.com/smhg/date-period/issues/4","id":73938790,"number":4,"title":"End of period is inclusive?","user":{"login":"robations","id":205320,"avatar_url":"https://avatars.githubusercontent.com/u/205320?v=3","gravatar_id":"","url":"https://api.github.com/users/robations","html_url":"https://github.com/robations","followers_url":"https://api.github.com/users/robations/followers","following_url":"https://api.github.com/users/robations/following{/other_user}","gists_url":"https://api.github.com/users/robations/gists{/gist_id}","starred_url":"https://api.github.com/users/robations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robations/subscriptions","organizations_url":"https://api.github.com/users/robations/orgs","repos_url":"https://api.github.com/users/robations/repos","events_url":"https://api.github.com/users/robations/events{/privacy}","received_events_url":"https://api.github.com/users/robations/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T10:46:57Z","updated_at":"2015-05-07T11:27:54Z","closed_at":null,"body":"Firstly thanks for this component : ) I notice there is a difference from the PHP DatePeriod class in that the end date in PHP is exclusive, but in this class/function it is inclusive. If compatibility with PHP is important then might be worth either changing the behaviour, or noting this in the documentation. (I'm porting a library from PHP to TypeScript so I got hit by this.)\r\n\r\nhttp://php.net/manual/en/dateperiod.construct.php (see comments for description of exclusive behaviour)"},"comment":{"url":"https://api.github.com/repos/smhg/date-period/issues/comments/99821685","html_url":"https://github.com/smhg/date-period/issues/4#issuecomment-99821685","issue_url":"https://api.github.com/repos/smhg/date-period/issues/4","id":99821685,"user":{"login":"smhg","id":2411348,"avatar_url":"https://avatars.githubusercontent.com/u/2411348?v=3","gravatar_id":"","url":"https://api.github.com/users/smhg","html_url":"https://github.com/smhg","followers_url":"https://api.github.com/users/smhg/followers","following_url":"https://api.github.com/users/smhg/following{/other_user}","gists_url":"https://api.github.com/users/smhg/gists{/gist_id}","starred_url":"https://api.github.com/users/smhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smhg/subscriptions","organizations_url":"https://api.github.com/users/smhg/orgs","repos_url":"https://api.github.com/users/smhg/repos","events_url":"https://api.github.com/users/smhg/events{/privacy}","received_events_url":"https://api.github.com/users/smhg/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T11:27:54Z","updated_at":"2015-05-07T11:27:54Z","body":"Thank you for your feedback! I'll have a look at this right away.\r\nI guess I'm only using it with a number of recurrences or an ISO string. In which case it acts the same as the PHP version."}}