{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46672120","id":46672120,"diff_hunk":"@@ -135,9 +135,14 @@ def checkHostName():\n                 self.syscfg.svo.disableService(\"tomcat6\")\n         except:\n             pass\n-            \n+\n         self.syscfg.svo.stopService(\"cloudstack-management\")\n-        if self.syscfg.svo.enableService(\"cloudstack-management\"):\n-            return True\n+\n+        if self.syscfg.env.noStart == False:\n+            if self.syscfg.svo.enableService(\"cloudstack-management\"):\n+                return True\n+            else:\n+                raise CloudRuntimeException(\"Failed to configure %s, please see the /var/log/cloudstack/management/setupManagement.log for detail\"%self.serviceName)","path":"python/lib/cloudutils/serviceConfigServer.py","position":87,"original_position":87,"commit_id":"e0e65f5cd6fe03ff8ae0ce58103c3f762604b50a","original_commit_id":"e0e65f5cd6fe03ff8ae0ce58103c3f762604b50a","user":{"login":"ProjectMoon","id":183856,"avatar_url":"https://avatars.githubusercontent.com/u/183856?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectMoon","html_url":"https://github.com/ProjectMoon","followers_url":"https://api.github.com/users/ProjectMoon/followers","following_url":"https://api.github.com/users/ProjectMoon/following{/other_user}","gists_url":"https://api.github.com/users/ProjectMoon/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectMoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectMoon/subscriptions","organizations_url":"https://api.github.com/users/ProjectMoon/orgs","repos_url":"https://api.github.com/users/ProjectMoon/repos","events_url":"https://api.github.com/users/ProjectMoon/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectMoon/received_events","type":"User","site_admin":false},"body":"The original message had the log message in the wrong place (I think it was pointing at `/var/log/cloudstack-management/setupManagement.log`). I changed it to the right path on Linux systems (for Ubuntu and friends). But probably the log path can be fixed as part of this commit or in another one. But in order for the replace.properties stuff to work, there is an antrun task I believe. Not sure it would currently process files in the directory that serviceConfigServer.py is in.","created_at":"2015-12-04T11:18:57Z","updated_at":"2015-12-04T11:18:57Z","html_url":"https://github.com/apache/cloudstack/pull/1162#discussion_r46672120","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/1162","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46672120"},"html":{"href":"https://github.com/apache/cloudstack/pull/1162#discussion_r46672120"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1162"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1162","id":52574328,"html_url":"https://github.com/apache/cloudstack/pull/1162","diff_url":"https://github.com/apache/cloudstack/pull/1162.diff","patch_url":"https://github.com/apache/cloudstack/pull/1162.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1162","number":1162,"state":"open","locked":false,"title":"Add support for not (re)starting server after cloud-setup-management.","user":{"login":"ProjectMoon","id":183856,"avatar_url":"https://avatars.githubusercontent.com/u/183856?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectMoon","html_url":"https://github.com/ProjectMoon","followers_url":"https://api.github.com/users/ProjectMoon/followers","following_url":"https://api.github.com/users/ProjectMoon/following{/other_user}","gists_url":"https://api.github.com/users/ProjectMoon/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectMoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectMoon/subscriptions","organizations_url":"https://api.github.com/users/ProjectMoon/orgs","repos_url":"https://api.github.com/users/ProjectMoon/repos","events_url":"https://api.github.com/users/ProjectMoon/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectMoon/received_events","type":"User","site_admin":false},"body":"This adds an option to the cloud-setup-management script to not start the management server after a successful configuration of it. \r\n\r\nThe primary motivation for this is to avoid circular dependency issues on systems that use systemd. When calling cloud-setup-management from a unit with a Before= directive on a service depending on\r\ncloudstack-management, the process will deadlock because /usr/bin/service will delegate to systemd, which is waiting for the Before service to start.\r\n\r\nExecuting the cloud-setup-management script with this new `--no-start` option will simply leave the management server stopped after a successful configuration. systemd can then be bypassed with `export _SYSTEMCTL_SKIP_REDIRECT=1` and using the init.d script.","created_at":"2015-12-03T18:42:21Z","updated_at":"2015-12-04T11:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2e66ad7ca7fa31f0dbee160a6de498b35b812fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1162/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/e0e65f5cd6fe03ff8ae0ce58103c3f762604b50a","head":{"label":"greenqloud:pr-no-start","ref":"pr-no-start","sha":"e0e65f5cd6fe03ff8ae0ce58103c3f762604b50a","user":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"repo":{"id":36817746,"name":"cloudstack","full_name":"greenqloud/cloudstack","owner":{"login":"greenqloud","id":228758,"avatar_url":"https://avatars.githubusercontent.com/u/228758?v=3","gravatar_id":"","url":"https://api.github.com/users/greenqloud","html_url":"https://github.com/greenqloud","followers_url":"https://api.github.com/users/greenqloud/followers","following_url":"https://api.github.com/users/greenqloud/following{/other_user}","gists_url":"https://api.github.com/users/greenqloud/gists{/gist_id}","starred_url":"https://api.github.com/users/greenqloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenqloud/subscriptions","organizations_url":"https://api.github.com/users/greenqloud/orgs","repos_url":"https://api.github.com/users/greenqloud/repos","events_url":"https://api.github.com/users/greenqloud/events{/privacy}","received_events_url":"https://api.github.com/users/greenqloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenqloud/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/greenqloud/cloudstack","forks_url":"https://api.github.com/repos/greenqloud/cloudstack/forks","keys_url":"https://api.github.com/repos/greenqloud/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenqloud/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenqloud/cloudstack/teams","hooks_url":"https://api.github.com/repos/greenqloud/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/greenqloud/cloudstack/events","assignees_url":"https://api.github.com/repos/greenqloud/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/greenqloud/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/greenqloud/cloudstack/tags","blobs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenqloud/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenqloud/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenqloud/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenqloud/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/greenqloud/cloudstack/languages","stargazers_url":"https://api.github.com/repos/greenqloud/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/greenqloud/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/greenqloud/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/greenqloud/cloudstack/subscription","commits_url":"https://api.github.com/repos/greenqloud/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenqloud/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenqloud/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenqloud/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenqloud/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/greenqloud/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenqloud/cloudstack/merges","archive_url":"https://api.github.com/repos/greenqloud/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenqloud/cloudstack/downloads","issues_url":"https://api.github.com/repos/greenqloud/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/greenqloud/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/greenqloud/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/greenqloud/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenqloud/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/greenqloud/cloudstack/releases{/id}","created_at":"2015-06-03T16:58:20Z","updated_at":"2015-06-03T16:58:41Z","pushed_at":"2015-12-04T10:00:18Z","git_url":"git://github.com/greenqloud/cloudstack.git","ssh_url":"git@github.com:greenqloud/cloudstack.git","clone_url":"https://github.com/greenqloud/cloudstack.git","svn_url":"https://github.com/greenqloud/cloudstack","homepage":null,"size":500353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:4.6","ref":"4.6","sha":"4f6ff6ca0835b322d0ddcbb0e4687f8e7c826c47","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-12-02T15:08:25Z","pushed_at":"2015-12-04T10:06:01Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":506813,"stargazers_count":321,"watchers_count":321,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":413,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":145,"forks":413,"open_issues":145,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1162"},"html":{"href":"https://github.com/apache/cloudstack/pull/1162"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1162"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/e0e65f5cd6fe03ff8ae0ce58103c3f762604b50a"}}}}