{"action":"opened","number":40,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40","id":33361992,"html_url":"https://github.com/alphagov/govuk-content-schemas/pull/40","diff_url":"https://github.com/alphagov/govuk-content-schemas/pull/40.diff","patch_url":"https://github.com/alphagov/govuk-content-schemas/pull/40.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40","number":40,"state":"open","locked":false,"title":"[DISCUSS] Make public_updated_at required for everything","user":{"login":"jamiecobbett","id":93739,"avatar_url":"https://avatars.githubusercontent.com/u/93739?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiecobbett","html_url":"https://github.com/jamiecobbett","followers_url":"https://api.github.com/users/jamiecobbett/followers","following_url":"https://api.github.com/users/jamiecobbett/following{/other_user}","gists_url":"https://api.github.com/users/jamiecobbett/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiecobbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiecobbett/subscriptions","organizations_url":"https://api.github.com/users/jamiecobbett/orgs","repos_url":"https://api.github.com/users/jamiecobbett/repos","events_url":"https://api.github.com/users/jamiecobbett/events{/privacy}","received_events_url":"https://api.github.com/users/jamiecobbett/received_events","type":"User","site_admin":false},"body":"This is currently optional in content-store, making it required here is a route\r\nto making it required there (and then backfilling the data).\r\n\r\nWe have been thinking of public_updated_at as \"the updated date which users\r\nsee\" and because some formats don't display this (eg gone/redirect items), it\r\nhas been optional.\r\n\r\nHowever, it seems to me that it isn't about what the user sees, but when there\r\nwas last a (significant) semantic change to the content at the URL. Therefore,\r\neverything should have a public_updated_at.\r\n\r\nAs an example, it being optional meant that a placeholder without a\r\npublic_updated_at was added by publisher which then broke an expectation in\r\nemail-alert-service and stopped it from consuming any more messages from the\r\nqueue.\r\n\r\nTo make the Whitehall tests pass for \"coming soon\" items, we'd need to do something like: https://github.com/alphagov/whitehall/compare/supply_public_updated_at_for_coming_soon?expand=1","created_at":"2015-04-15T14:48:17Z","updated_at":"2015-04-15T14:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/0796af7cd07975433ec1810548a054019100f018","head":{"label":"alphagov:make_public_updated_at_required","ref":"make_public_updated_at_required","sha":"0796af7cd07975433ec1810548a054019100f018","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":27441121,"name":"govuk-content-schemas","full_name":"alphagov/govuk-content-schemas","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-schemas","description":"Definitions of the data formats used to represent content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-schemas","forks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/releases{/id}","created_at":"2014-12-02T16:20:33Z","updated_at":"2015-04-13T08:39:04Z","pushed_at":"2015-04-15T14:43:51Z","git_url":"git://github.com/alphagov/govuk-content-schemas.git","ssh_url":"git@github.com:alphagov/govuk-content-schemas.git","clone_url":"https://github.com/alphagov/govuk-content-schemas.git","svn_url":"https://github.com/alphagov/govuk-content-schemas","homepage":null,"size":1060,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"493d12f2833a351ec8f9075a3a61a3c81f70a1a0","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":27441121,"name":"govuk-content-schemas","full_name":"alphagov/govuk-content-schemas","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-schemas","description":"Definitions of the data formats used to represent content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-schemas","forks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/releases{/id}","created_at":"2014-12-02T16:20:33Z","updated_at":"2015-04-13T08:39:04Z","pushed_at":"2015-04-15T14:43:51Z","git_url":"git://github.com/alphagov/govuk-content-schemas.git","ssh_url":"git@github.com:alphagov/govuk-content-schemas.git","clone_url":"https://github.com/alphagov/govuk-content-schemas.git","svn_url":"https://github.com/alphagov/govuk-content-schemas","homepage":null,"size":1060,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40"},"html":{"href":"https://github.com/alphagov/govuk-content-schemas/pull/40"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/0796af7cd07975433ec1810548a054019100f018"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":12,"changed_files":12}}