{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24","id":27696360,"html_url":"https://github.com/pusher/pusher-php-server/pull/24","diff_url":"https://github.com/pusher/pusher-php-server/pull/24.diff","patch_url":"https://github.com/pusher/pusher-php-server/pull/24.patch","issue_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/24","number":24,"state":"closed","locked":false,"title":"Replace multiple constructor parameters with $options parameter. With backwards compatibility.","user":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"body":"The purpose of this pull request is really to simplify the `Pusher` constructor.\r\n\r\nHowever, the README was also updated, travis integration was added and debug & logging information was clarified as there are a lot of questions about this to Pusher support.\r\n\r\nAdditionally, we wanted to make it easier to use SSL (access the API via HTTPS) so a single `encrypted` options parameter is now available.\r\n\r\n## v3 - the next version update\r\n\r\n@Gufran - your pull request #21 has not been forgotten and there is a bigger project coming up where we're going to be looking at all our libraries. In the case of the PHP library this will be version 3 where the library should demonstrate better practice than the current version does.\r\n\r\nOne thing we have to consider is that we've also a newer version of the library that has been developed that offers some additional functionality e.g. validation of WebHooks. So, part of the future project will be to look at the pull request and compare it to the internal library that has been developed.\r\n\r\nThe updated library should also address things like #13 and #14 since it should allow the underlying request mechanism to be changed for different environments - since that's a clear requirement.\r\n\r\nThis also fixes #20.\r\n\r\n","created_at":"2015-01-20T17:34:44Z","updated_at":"2015-01-26T10:56:45Z","closed_at":"2015-01-26T10:56:45Z","merged_at":"2015-01-26T10:56:45Z","merge_commit_sha":"2909cbe145dd755536a8c645950c694fc0465b53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24/commits","review_comments_url":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24/comments","review_comment_url":"https://api.github.com/repos/pusher/pusher-php-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/24/comments","statuses_url":"https://api.github.com/repos/pusher/pusher-php-server/statuses/b35f8b6e833b8d49869ae5d1c2663cb2d0f89651","head":{"label":"pusher:options-parameter","ref":"options-parameter","sha":"b35f8b6e833b8d49869ae5d1c2663cb2d0f89651","user":{"login":"pusher","id":739550,"avatar_url":"https://avatars.githubusercontent.com/u/739550?v=3","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":5249039,"name":"pusher-php-server","full_name":"pusher/pusher-php-server","owner":{"login":"pusher","id":739550,"avatar_url":"https://avatars.githubusercontent.com/u/739550?v=3","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pusher/pusher-php-server","description":"PHP library for interacting with the Pusher HTTP API","fork":true,"url":"https://api.github.com/repos/pusher/pusher-php-server","forks_url":"https://api.github.com/repos/pusher/pusher-php-server/forks","keys_url":"https://api.github.com/repos/pusher/pusher-php-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-php-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-php-server/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-php-server/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-php-server/events","assignees_url":"https://api.github.com/repos/pusher/pusher-php-server/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-php-server/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-php-server/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-php-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-php-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-php-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-php-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-php-server/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-php-server/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-php-server/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-php-server/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-php-server/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-php-server/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-php-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-php-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-php-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/pusher/pusher-php-server/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-php-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-php-server/merges","archive_url":"https://api.github.com/repos/pusher/pusher-php-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-php-server/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-php-server/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-php-server/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-php-server/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-php-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-php-server/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-php-server/releases{/id}","created_at":"2012-07-31T17:21:19Z","updated_at":"2015-01-20T14:14:55Z","pushed_at":"2015-01-26T10:56:45Z","git_url":"git://github.com/pusher/pusher-php-server.git","ssh_url":"git@github.com:pusher/pusher-php-server.git","clone_url":"https://github.com/pusher/pusher-php-server.git","svn_url":"https://github.com/pusher/pusher-php-server","homepage":"","size":419,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":9,"forks":78,"open_issues":9,"watchers":143,"default_branch":"master"}},"base":{"label":"pusher:master","ref":"master","sha":"d5b4e8bec7fc5e53651c879495a74e96b1bc2cea","user":{"login":"pusher","id":739550,"avatar_url":"https://avatars.githubusercontent.com/u/739550?v=3","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"repo":{"id":5249039,"name":"pusher-php-server","full_name":"pusher/pusher-php-server","owner":{"login":"pusher","id":739550,"avatar_url":"https://avatars.githubusercontent.com/u/739550?v=3","gravatar_id":"","url":"https://api.github.com/users/pusher","html_url":"https://github.com/pusher","followers_url":"https://api.github.com/users/pusher/followers","following_url":"https://api.github.com/users/pusher/following{/other_user}","gists_url":"https://api.github.com/users/pusher/gists{/gist_id}","starred_url":"https://api.github.com/users/pusher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pusher/subscriptions","organizations_url":"https://api.github.com/users/pusher/orgs","repos_url":"https://api.github.com/users/pusher/repos","events_url":"https://api.github.com/users/pusher/events{/privacy}","received_events_url":"https://api.github.com/users/pusher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pusher/pusher-php-server","description":"PHP library for interacting with the Pusher HTTP API","fork":true,"url":"https://api.github.com/repos/pusher/pusher-php-server","forks_url":"https://api.github.com/repos/pusher/pusher-php-server/forks","keys_url":"https://api.github.com/repos/pusher/pusher-php-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pusher/pusher-php-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pusher/pusher-php-server/teams","hooks_url":"https://api.github.com/repos/pusher/pusher-php-server/hooks","issue_events_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/events{/number}","events_url":"https://api.github.com/repos/pusher/pusher-php-server/events","assignees_url":"https://api.github.com/repos/pusher/pusher-php-server/assignees{/user}","branches_url":"https://api.github.com/repos/pusher/pusher-php-server/branches{/branch}","tags_url":"https://api.github.com/repos/pusher/pusher-php-server/tags","blobs_url":"https://api.github.com/repos/pusher/pusher-php-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pusher/pusher-php-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pusher/pusher-php-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/pusher/pusher-php-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pusher/pusher-php-server/statuses/{sha}","languages_url":"https://api.github.com/repos/pusher/pusher-php-server/languages","stargazers_url":"https://api.github.com/repos/pusher/pusher-php-server/stargazers","contributors_url":"https://api.github.com/repos/pusher/pusher-php-server/contributors","subscribers_url":"https://api.github.com/repos/pusher/pusher-php-server/subscribers","subscription_url":"https://api.github.com/repos/pusher/pusher-php-server/subscription","commits_url":"https://api.github.com/repos/pusher/pusher-php-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/pusher/pusher-php-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/pusher/pusher-php-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/pusher/pusher-php-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/pusher/pusher-php-server/contents/{+path}","compare_url":"https://api.github.com/repos/pusher/pusher-php-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pusher/pusher-php-server/merges","archive_url":"https://api.github.com/repos/pusher/pusher-php-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pusher/pusher-php-server/downloads","issues_url":"https://api.github.com/repos/pusher/pusher-php-server/issues{/number}","pulls_url":"https://api.github.com/repos/pusher/pusher-php-server/pulls{/number}","milestones_url":"https://api.github.com/repos/pusher/pusher-php-server/milestones{/number}","notifications_url":"https://api.github.com/repos/pusher/pusher-php-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pusher/pusher-php-server/labels{/name}","releases_url":"https://api.github.com/repos/pusher/pusher-php-server/releases{/id}","created_at":"2012-07-31T17:21:19Z","updated_at":"2015-01-20T14:14:55Z","pushed_at":"2015-01-26T10:56:45Z","git_url":"git://github.com/pusher/pusher-php-server.git","ssh_url":"git@github.com:pusher/pusher-php-server.git","clone_url":"https://github.com/pusher/pusher-php-server.git","svn_url":"https://github.com/pusher/pusher-php-server","homepage":"","size":419,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":9,"forks":78,"open_issues":9,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24"},"html":{"href":"https://github.com/pusher/pusher-php-server/pull/24"},"issue":{"href":"https://api.github.com/repos/pusher/pusher-php-server/issues/24"},"comments":{"href":"https://api.github.com/repos/pusher/pusher-php-server/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/pusher/pusher-php-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pusher/pusher-php-server/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/pusher/pusher-php-server/statuses/b35f8b6e833b8d49869ae5d1c2663cb2d0f89651"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":20,"additions":459,"deletions":168,"changed_files":11}}