{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/31713838","id":31713838,"diff_hunk":"@@ -33,63 +33,83 @@\n \n return $.widget( \"mobile.page\", $.mobile.page, {\n \toptions: {\n+\t\tclasses: {\n+\t\t\t\"ui-page-dialog-close-button\":\n+\t\t\t\"ui-button ui-corner-all ui-button-icon-only\",\n+\t\t\t\"ui-page-dialog-close-button-icon\": \"ui-icon-delete ui-icon\",\n+\t\t\t\"ui-page-dialog-contain\": \"ui-overlay-shadow ui-corner-all\"\n+\t\t},\n \n \t\t// Accepts left, right and none\n \t\tcloseBtn: \"left\",\n \t\tcloseBtnText: \"Close\",\n \t\toverlayTheme: \"a\",\n-\t\tcorners: true,\n \t\tdialog: false\n \t},\n \n \t_create: function() {\n+\t\tthis._ui = {};","path":"js/widgets/page.dialog.js","position":20,"original_position":20,"commit_id":"cae3d8971cd3de233d287eb19edaef94b50a1a88","original_commit_id":"cae3d8971cd3de233d287eb19edaef94b50a1a88","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"body":"Im not a fan of the `_ui` name space here it does not actually describe what it is. We also have a mixed convention on the use of `_` for private. We have gone back and forth on this. I think i would prefer to go with the ui convention that the `_ ` is only for methods we have never had public properties in any widget im aware of so there is no need to mark them private. They are also not effected by the widget bridge which makes private methods not directly callable through the bridge.\r\n\r\nI think i would prefer `this.dialog = {};` here personally  ","created_at":"2015-06-04T12:02:24Z","updated_at":"2015-06-04T12:02:24Z","html_url":"https://github.com/jquery/jquery-mobile/pull/8121#discussion_r31713838","pull_request_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/31713838"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/8121#discussion_r31713838"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121","id":33642217,"html_url":"https://github.com/jquery/jquery-mobile/pull/8121","diff_url":"https://github.com/jquery/jquery-mobile/pull/8121.diff","patch_url":"https://github.com/jquery/jquery-mobile/pull/8121.patch","issue_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/8121","number":8121,"state":"open","locked":false,"title":"Page: Implement classes option","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars.githubusercontent.com/u/976081?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"body":"Fixes gh-7707","created_at":"2015-04-20T07:52:42Z","updated_at":"2015-06-04T12:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"442760442c598a05ccca9b50e9a84f0e55de4025","assignee":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/24","html_url":"https://github.com/jquery/jquery-mobile/milestones/1.5.0","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/24/labels","id":265123,"number":24,"title":"1.5.0","description":"","creator":{"login":"jaspermdegroot","id":1296793,"avatar_url":"https://avatars.githubusercontent.com/u/1296793?v=3","gravatar_id":"","url":"https://api.github.com/users/jaspermdegroot","html_url":"https://github.com/jaspermdegroot","followers_url":"https://api.github.com/users/jaspermdegroot/followers","following_url":"https://api.github.com/users/jaspermdegroot/following{/other_user}","gists_url":"https://api.github.com/users/jaspermdegroot/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspermdegroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspermdegroot/subscriptions","organizations_url":"https://api.github.com/users/jaspermdegroot/orgs","repos_url":"https://api.github.com/users/jaspermdegroot/repos","events_url":"https://api.github.com/users/jaspermdegroot/events{/privacy}","received_events_url":"https://api.github.com/users/jaspermdegroot/received_events","type":"User","site_admin":false},"open_issues":122,"closed_issues":176,"state":"open","created_at":"2013-02-12T09:05:39Z","updated_at":"2015-06-01T14:34:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/8121/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/cae3d8971cd3de233d287eb19edaef94b50a1a88","head":{"label":"gabrielschulhof:7707-page-classes-option","ref":"7707-page-classes-option","sha":"cae3d8971cd3de233d287eb19edaef94b50a1a88","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars.githubusercontent.com/u/976081?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"repo":{"id":2510626,"name":"jquery-mobile","full_name":"gabrielschulhof/jquery-mobile","owner":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars.githubusercontent.com/u/976081?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrielschulhof/jquery-mobile","description":"jQuery Mobile Framework","fork":true,"url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile","forks_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/forks","keys_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/events","assignees_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/merges","archive_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/gabrielschulhof/jquery-mobile/releases{/id}","created_at":"2011-10-04T08:30:43Z","updated_at":"2015-04-07T13:42:17Z","pushed_at":"2015-06-03T08:55:11Z","git_url":"git://github.com/gabrielschulhof/jquery-mobile.git","ssh_url":"git@github.com:gabrielschulhof/jquery-mobile.git","clone_url":"https://github.com/gabrielschulhof/jquery-mobile.git","svn_url":"https://github.com/gabrielschulhof/jquery-mobile","homepage":"http://jquerymobile.com/","size":136310,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"jquery:1.5-dev","ref":"1.5-dev","sha":"dd4467ffd11c8f2b4b3109fa9d5072647bc90c0a","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":907410,"name":"jquery-mobile","full_name":"jquery/jquery-mobile","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-mobile","description":"jQuery Mobile Framework","fork":false,"url":"https://api.github.com/repos/jquery/jquery-mobile","forks_url":"https://api.github.com/repos/jquery/jquery-mobile/forks","keys_url":"https://api.github.com/repos/jquery/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-mobile/events","assignees_url":"https://api.github.com/repos/jquery/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-mobile/merges","archive_url":"https://api.github.com/repos/jquery/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-mobile/releases{/id}","created_at":"2010-09-13T15:02:22Z","updated_at":"2015-06-04T06:55:23Z","pushed_at":"2015-06-03T08:55:13Z","git_url":"git://github.com/jquery/jquery-mobile.git","ssh_url":"git@github.com:jquery/jquery-mobile.git","clone_url":"https://github.com/jquery/jquery-mobile.git","svn_url":"https://github.com/jquery/jquery-mobile","homepage":"http://jquerymobile.com/","size":188598,"stargazers_count":9562,"watchers_count":9562,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2536,"mirror_url":null,"open_issues_count":305,"forks":2536,"open_issues":305,"watchers":9562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/8121"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/8121"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/8121/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/8121/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-mobile/statuses/cae3d8971cd3de233d287eb19edaef94b50a1a88"}}}}