{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/7447","labels_url":"https://api.github.com/repos/servo/servo/issues/7447/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/7447/comments","events_url":"https://api.github.com/repos/servo/servo/issues/7447/events","html_url":"https://github.com/servo/servo/pull/7447","id":103884903,"number":7447,"title":"Issue #7382 Use descriptive enums instead of booleans for MIMEClassifier::classifer","user":{"login":"ddrmanxbxfr","id":445401,"avatar_url":"https://avatars.githubusercontent.com/u/445401?v=3","gravatar_id":"","url":"https://api.github.com/users/ddrmanxbxfr","html_url":"https://github.com/ddrmanxbxfr","followers_url":"https://api.github.com/users/ddrmanxbxfr/followers","following_url":"https://api.github.com/users/ddrmanxbxfr/following{/other_user}","gists_url":"https://api.github.com/users/ddrmanxbxfr/gists{/gist_id}","starred_url":"https://api.github.com/users/ddrmanxbxfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddrmanxbxfr/subscriptions","organizations_url":"https://api.github.com/users/ddrmanxbxfr/orgs","repos_url":"https://api.github.com/users/ddrmanxbxfr/repos","events_url":"https://api.github.com/users/ddrmanxbxfr/events{/privacy}","received_events_url":"https://api.github.com/users/ddrmanxbxfr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-answer","name":"S-awaiting-answer","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2015-08-29T21:33:59Z","updated_at":"2015-09-13T00:02:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/7447","html_url":"https://github.com/servo/servo/pull/7447","diff_url":"https://github.com/servo/servo/pull/7447.diff","patch_url":"https://github.com/servo/servo/pull/7447.patch"},"body":"Hi guys i've done a small pass of refactor in the MIMEClassifier implementation. (See issue #7382 )\r\n   - Moved the predicates to separate functions\r\n   - Added a mimetype enum so we can compare them easily after calling MIMEClassifier::get_media_type\r\n\r\nI hope it follows rust good pratices (care it's my first time doing rust).\r\n\r\nImprovements and tips are welcome :).\r\n\r\nThanks for looking at it.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/7447)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/139829846","html_url":"https://github.com/servo/servo/pull/7447#issuecomment-139829846","issue_url":"https://api.github.com/repos/servo/servo/issues/7447","id":139829846,"user":{"login":"ddrmanxbxfr","id":445401,"avatar_url":"https://avatars.githubusercontent.com/u/445401?v=3","gravatar_id":"","url":"https://api.github.com/users/ddrmanxbxfr","html_url":"https://github.com/ddrmanxbxfr","followers_url":"https://api.github.com/users/ddrmanxbxfr/followers","following_url":"https://api.github.com/users/ddrmanxbxfr/following{/other_user}","gists_url":"https://api.github.com/users/ddrmanxbxfr/gists{/gist_id}","starred_url":"https://api.github.com/users/ddrmanxbxfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddrmanxbxfr/subscriptions","organizations_url":"https://api.github.com/users/ddrmanxbxfr/orgs","repos_url":"https://api.github.com/users/ddrmanxbxfr/repos","events_url":"https://api.github.com/users/ddrmanxbxfr/events{/privacy}","received_events_url":"https://api.github.com/users/ddrmanxbxfr/received_events","type":"User","site_admin":false},"created_at":"2015-09-13T00:02:25Z","updated_at":"2015-09-13T00:02:25Z","body":"We'll get it right @jdm once it looks ok let me know i'll rebase commits to not polute the git log."}}