{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/31489280","id":31489280,"diff_hunk":"@@ -159,8 +159,26 @@\n   startup.globalVariables = function() {\n     global.process = process;\n     global.global = global;\n-    global.GLOBAL = global;\n-    global.root = global;\n+\n+    // Deprecate GLOBAL and root\n+    ['GLOBAL', 'root'].forEach(function(name) {\n+      // getter\n+      const get = NativeModule.require('util').deprecate(function() {\n+        return this;\n+      }, \"'\" + name + \"' is deprecated, use 'global'\");\n+      // setter\n+      const set = function(value) {\n+        const desc = {configurable: true, enumerable: true, value: value};","path":"src/node.js","position":15,"original_position":15,"commit_id":"8196180611ce7b9648eb05dcd23ea1a989e211d4","original_commit_id":"8196180611ce7b9648eb05dcd23ea1a989e211d4","user":{"login":"JacksonTian","id":327019,"avatar_url":"https://avatars.githubusercontent.com/u/327019?v=3","gravatar_id":"","url":"https://api.github.com/users/JacksonTian","html_url":"https://github.com/JacksonTian","followers_url":"https://api.github.com/users/JacksonTian/followers","following_url":"https://api.github.com/users/JacksonTian/following{/other_user}","gists_url":"https://api.github.com/users/JacksonTian/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonTian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonTian/subscriptions","organizations_url":"https://api.github.com/users/JacksonTian/orgs","repos_url":"https://api.github.com/users/JacksonTian/repos","events_url":"https://api.github.com/users/JacksonTian/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonTian/received_events","type":"User","site_admin":false},"body":"sorry. @targos is right.","created_at":"2015-06-02T02:34:52Z","updated_at":"2015-06-02T02:34:52Z","html_url":"https://github.com/nodejs/io.js/pull/1838#discussion_r31489280","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/1838","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/31489280"},"html":{"href":"https://github.com/nodejs/io.js/pull/1838#discussion_r31489280"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1838"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/1838","id":36535943,"html_url":"https://github.com/nodejs/io.js/pull/1838","diff_url":"https://github.com/nodejs/io.js/pull/1838.diff","patch_url":"https://github.com/nodejs/io.js/pull/1838.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/1838","number":1838,"state":"open","locked":false,"title":"src: deprecate root and GLOBAL variables","user":{"login":"JacksonTian","id":327019,"avatar_url":"https://avatars.githubusercontent.com/u/327019?v=3","gravatar_id":"","url":"https://api.github.com/users/JacksonTian","html_url":"https://github.com/JacksonTian","followers_url":"https://api.github.com/users/JacksonTian/followers","following_url":"https://api.github.com/users/JacksonTian/following{/other_user}","gists_url":"https://api.github.com/users/JacksonTian/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonTian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonTian/subscriptions","organizations_url":"https://api.github.com/users/JacksonTian/orgs","repos_url":"https://api.github.com/users/JacksonTian/repos","events_url":"https://api.github.com/users/JacksonTian/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonTian/received_events","type":"User","site_admin":false},"body":"The `root` and `GLOBAL` never be documented.","created_at":"2015-05-29T19:10:22Z","updated_at":"2015-06-02T02:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b08e73bfab1f4cad45cf4a0b945405b9b1482e43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/1838/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/1838/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/1838/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/8196180611ce7b9648eb05dcd23ea1a989e211d4","head":{"label":"JacksonTian:remove_root","ref":"remove_root","sha":"8196180611ce7b9648eb05dcd23ea1a989e211d4","user":{"login":"JacksonTian","id":327019,"avatar_url":"https://avatars.githubusercontent.com/u/327019?v=3","gravatar_id":"","url":"https://api.github.com/users/JacksonTian","html_url":"https://github.com/JacksonTian","followers_url":"https://api.github.com/users/JacksonTian/followers","following_url":"https://api.github.com/users/JacksonTian/following{/other_user}","gists_url":"https://api.github.com/users/JacksonTian/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonTian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonTian/subscriptions","organizations_url":"https://api.github.com/users/JacksonTian/orgs","repos_url":"https://api.github.com/users/JacksonTian/repos","events_url":"https://api.github.com/users/JacksonTian/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonTian/received_events","type":"User","site_admin":false},"repo":{"id":28173772,"name":"io.js","full_name":"JacksonTian/io.js","owner":{"login":"JacksonTian","id":327019,"avatar_url":"https://avatars.githubusercontent.com/u/327019?v=3","gravatar_id":"","url":"https://api.github.com/users/JacksonTian","html_url":"https://github.com/JacksonTian","followers_url":"https://api.github.com/users/JacksonTian/followers","following_url":"https://api.github.com/users/JacksonTian/following{/other_user}","gists_url":"https://api.github.com/users/JacksonTian/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonTian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonTian/subscriptions","organizations_url":"https://api.github.com/users/JacksonTian/orgs","repos_url":"https://api.github.com/users/JacksonTian/repos","events_url":"https://api.github.com/users/JacksonTian/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonTian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacksonTian/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/JacksonTian/io.js","forks_url":"https://api.github.com/repos/JacksonTian/io.js/forks","keys_url":"https://api.github.com/repos/JacksonTian/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacksonTian/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacksonTian/io.js/teams","hooks_url":"https://api.github.com/repos/JacksonTian/io.js/hooks","issue_events_url":"https://api.github.com/repos/JacksonTian/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/JacksonTian/io.js/events","assignees_url":"https://api.github.com/repos/JacksonTian/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/JacksonTian/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/JacksonTian/io.js/tags","blobs_url":"https://api.github.com/repos/JacksonTian/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacksonTian/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacksonTian/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacksonTian/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacksonTian/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/JacksonTian/io.js/languages","stargazers_url":"https://api.github.com/repos/JacksonTian/io.js/stargazers","contributors_url":"https://api.github.com/repos/JacksonTian/io.js/contributors","subscribers_url":"https://api.github.com/repos/JacksonTian/io.js/subscribers","subscription_url":"https://api.github.com/repos/JacksonTian/io.js/subscription","commits_url":"https://api.github.com/repos/JacksonTian/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacksonTian/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacksonTian/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacksonTian/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacksonTian/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/JacksonTian/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacksonTian/io.js/merges","archive_url":"https://api.github.com/repos/JacksonTian/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacksonTian/io.js/downloads","issues_url":"https://api.github.com/repos/JacksonTian/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/JacksonTian/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/JacksonTian/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/JacksonTian/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacksonTian/io.js/labels{/name}","releases_url":"https://api.github.com/repos/JacksonTian/io.js/releases{/id}","created_at":"2014-12-18T07:50:35Z","updated_at":"2015-01-22T04:01:30Z","pushed_at":"2015-06-02T02:03:15Z","git_url":"git://github.com/JacksonTian/io.js.git","ssh_url":"git@github.com:JacksonTian/io.js.git","clone_url":"https://github.com/JacksonTian/io.js.git","svn_url":"https://github.com/JacksonTian/io.js","homepage":null,"size":131174,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"v1.x"}},"base":{"label":"nodejs:master","ref":"master","sha":"1baba0580d932d7199b8144edc8951a459d569ec","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Node.js, but with bigger and faster version numbers","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-06-01T23:40:18Z","pushed_at":"2015-06-02T02:03:16Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":185658,"stargazers_count":12563,"watchers_count":12563,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":954,"mirror_url":null,"open_issues_count":288,"forks":954,"open_issues":288,"watchers":12563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1838"},"html":{"href":"https://github.com/nodejs/io.js/pull/1838"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1838"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/1838/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1838/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/1838/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/8196180611ce7b9648eb05dcd23ea1a989e211d4"}}}}