{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/32538869","id":32538869,"diff_hunk":"@@ -211,9 +212,41 @@\n                                                 '$(TargetFramework)' == 'XNA\\5.0' OR \n                                                 '$(TargetFramework)' == 'sl3-wp' \"/>\n   </ItemGroup>\n+  <ItemGroup Condition=\"'$(TargetFramework)' == 'coreclr'\">\n+    <Reference Include=\"$(FSharpSourcesRoot)\\..\\packages\\System.Collections\\4.0.10-beta-22809\\ref\\any\\System.Collections.dll\" />","path":"src/fsharp/FSharp.Core/FSharp.Core.fsproj","position":22,"original_position":22,"commit_id":"f868485d5382748529e178552eaa5e91f6f24d13","original_commit_id":"f868485d5382748529e178552eaa5e91f6f24d13","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"I also have a project.json file too, it was necessary to get the nugget downloads working, I still have to learn what the syntax differences are for referencing them that way.  To be honest I was focused for now on getting something working, where I could easily diagnose what was going on.  I fully expect to modify things moving forward.\r\n","created_at":"2015-06-16T16:22:55Z","updated_at":"2015-06-16T16:22:55Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/499#discussion_r32538869","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/32538869"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/499#discussion_r32538869"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499","id":37811740,"html_url":"https://github.com/Microsoft/visualfsharp/pull/499","diff_url":"https://github.com/Microsoft/visualfsharp/pull/499.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/499.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/499","number":499,"state":"open","locked":false,"title":"Coreclr build of fsharp.core","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"This is an initial attempt to build fsharp.core for the coreclr:\r\n\r\nIn a working F# OSS enlistment:\r\n   fetch the DotNet buildtools using:\r\n`.nuget\\NuGet.exe restore packages.config -PackagesDirectory packages`\r\n\r\nTo build and pull in the corefx assemblies for nuget build coreclr using this command:\r\n`msbuild src\\fsharp\\FSharp.Core\\FSharp.Core.fsproj /p:TargetFramework=coreclr /t:Rebuild /p:RestorePackages=true\r\n`\r\notherwise build fsharp.core like this:\r\n`msbuild src\\fsharp\\FSharp.Core\\FSharp.Core.fsproj /p:TargetFramework=coreclr`\r\n\r\n* Next a simple console app that uses coreclr and fsharp.core\r\n* the unit tests\r\n\r\n","created_at":"2015-06-16T16:03:28Z","updated_at":"2015-06-16T16:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fefe0538e09488c405cc9430e9a31d4546b88e83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/499/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/f868485d5382748529e178552eaa5e91f6f24d13","head":{"label":"KevinRansom:coreclr","ref":"coreclr","sha":"f868485d5382748529e178552eaa5e91f6f24d13","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"repo":{"id":30044748,"name":"visualfsharp","full_name":"KevinRansom/visualfsharp","owner":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinRansom/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/KevinRansom/visualfsharp","forks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/forks","keys_url":"https://api.github.com/repos/KevinRansom/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinRansom/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinRansom/visualfsharp/teams","hooks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/events","assignees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/KevinRansom/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/tags","blobs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinRansom/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinRansom/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscription","commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/KevinRansom/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinRansom/visualfsharp/merges","archive_url":"https://api.github.com/repos/KevinRansom/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinRansom/visualfsharp/downloads","issues_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/KevinRansom/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinRansom/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinRansom/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinRansom/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/KevinRansom/visualfsharp/releases{/id}","created_at":"2015-01-29T22:35:46Z","updated_at":"2015-04-24T18:03:10Z","pushed_at":"2015-06-16T15:54:40Z","git_url":"git://github.com/KevinRansom/visualfsharp.git","ssh_url":"git@github.com:KevinRansom/visualfsharp.git","clone_url":"https://github.com/KevinRansom/visualfsharp.git","svn_url":"https://github.com/KevinRansom/visualfsharp","homepage":null,"size":50140,"stargazers_count":1,"watchers_count":1,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"fsharp4"}},"base":{"label":"Microsoft:fsharp4","ref":"fsharp4","sha":"c2335c0191f95cc1d84ce245b13c599b65640b57","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","created_at":"2015-01-10T05:58:43Z","updated_at":"2015-06-16T02:42:36Z","pushed_at":"2015-06-16T16:03:29Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":54087,"stargazers_count":476,"watchers_count":476,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":153,"forks":91,"open_issues":153,"watchers":476,"default_branch":"fsharp4"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/499"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/499"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/f868485d5382748529e178552eaa5e91f6f24d13"}}}}