{"comment":{"url":"https://api.github.com/repos/HarpyWar/pvpgn/comments/13085204","html_url":"https://github.com/HarpyWar/pvpgn/commit/7f58487a413f5e0c782eb0e0a10d1b37d893b79f#commitcomment-13085204","id":13085204,"user":{"login":"HarpyWar","id":1132835,"avatar_url":"https://avatars.githubusercontent.com/u/1132835?v=3","gravatar_id":"","url":"https://api.github.com/users/HarpyWar","html_url":"https://github.com/HarpyWar","followers_url":"https://api.github.com/users/HarpyWar/followers","following_url":"https://api.github.com/users/HarpyWar/following{/other_user}","gists_url":"https://api.github.com/users/HarpyWar/gists{/gist_id}","starred_url":"https://api.github.com/users/HarpyWar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarpyWar/subscriptions","organizations_url":"https://api.github.com/users/HarpyWar/orgs","repos_url":"https://api.github.com/users/HarpyWar/repos","events_url":"https://api.github.com/users/HarpyWar/events{/privacy}","received_events_url":"https://api.github.com/users/HarpyWar/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"7f58487a413f5e0c782eb0e0a10d1b37d893b79f","created_at":"2015-09-06T08:16:58Z","updated_at":"2015-09-06T08:16:58Z","body":"`sql2` is a self-made key-value storage mechanism where each account property is saved as a single row. \r\nI'm not sure why it was added by previous developers. May be they think that select a single property will be faster than get all account properties. But PvPGN is so constituted that it uses a lot of of account properties at the same time in most parts of the code. So, it will trigger many queries in `sql2` implementation (selects and updates). Even with current cache mechanism it looks much wasteful than several queries in default `sql` implementation (I have tuned it to decrease count of queries to a minimum). \r\n`sql2` has no advantages over `sql` and nobody use it. Also there is no 3dparty tools for `sql2` (registration, statistics, etc.).\r\nEven if add support for modern key-value database engines, I doubt that it's a true way, and I made a decision to completely exclude it."}}