{"action":"created","issue":{"url":"https://api.github.com/repos/clementine-player/Clementine/issues/4731","labels_url":"https://api.github.com/repos/clementine-player/Clementine/issues/4731/labels{/name}","comments_url":"https://api.github.com/repos/clementine-player/Clementine/issues/4731/comments","events_url":"https://api.github.com/repos/clementine-player/Clementine/issues/4731/events","html_url":"https://github.com/clementine-player/Clementine/pull/4731","id":56138813,"number":4731,"title":"Add support for custom lastfm:// URLs","user":{"login":"Chocobozzz","id":5180488,"avatar_url":"https://avatars.githubusercontent.com/u/5180488?v=3","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-31T20:48:03Z","updated_at":"2015-02-03T12:20:56Z","closed_at":"2015-02-02T16:54:34Z","pull_request":{"url":"https://api.github.com/repos/clementine-player/Clementine/pulls/4731","html_url":"https://github.com/clementine-player/Clementine/pull/4731","diff_url":"https://github.com/clementine-player/Clementine/pull/4731.diff","patch_url":"https://github.com/clementine-player/Clementine/pull/4731.patch"},"body":"I removed liblastfm as dependecy (see the other pull request of the Dependencies repo) in the purpose that Clementine builds itself custom liblastfm in which we can override the host (see this commit of my fork to view the changes from the official library https://github.com/Chocobozzz/liblastfm/commit/e54e539547930ec142f2f077b722620db116b214 to facilitate the review).\r\n\r\nSo now we are sure user have liblastfm1, I removed the `HAVE_LIBLASTFM1` defines.\r\n\r\nIf the server field is not set the behaviour is the same as before.\r\n\r\nCloses #1"},"comment":{"url":"https://api.github.com/repos/clementine-player/Clementine/issues/comments/72641343","html_url":"https://github.com/clementine-player/Clementine/pull/4731#issuecomment-72641343","issue_url":"https://api.github.com/repos/clementine-player/Clementine/issues/4731","id":72641343,"user":{"login":"Chocobozzz","id":5180488,"avatar_url":"https://avatars.githubusercontent.com/u/5180488?v=3","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T12:20:56Z","updated_at":"2015-02-03T12:20:56Z","body":"I understand. I chose this solution because I hadn't any protests of my comment in https://github.com/clementine-player/Clementine/issues/1\r\n\r\nSubmitted a PR yesterday, just hope they'll accept."}}