{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/andreek/node-eibd/pulls/24","id":52048350,"html_url":"https://github.com/andreek/node-eibd/pull/24","diff_url":"https://github.com/andreek/node-eibd/pull/24.diff","patch_url":"https://github.com/andreek/node-eibd/pull/24.patch","issue_url":"https://api.github.com/repos/andreek/node-eibd/issues/24","number":24,"state":"closed","locked":false,"title":"Fixed incoming data stream and support for socket reconnect","user":{"login":"stasee","id":16062493,"avatar_url":"https://avatars.githubusercontent.com/u/16062493?v=3","gravatar_id":"","url":"https://api.github.com/users/stasee","html_url":"https://github.com/stasee","followers_url":"https://api.github.com/users/stasee/followers","following_url":"https://api.github.com/users/stasee/following{/other_user}","gists_url":"https://api.github.com/users/stasee/gists{/gist_id}","starred_url":"https://api.github.com/users/stasee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasee/subscriptions","organizations_url":"https://api.github.com/users/stasee/orgs","repos_url":"https://api.github.com/users/stasee/repos","events_url":"https://api.github.com/users/stasee/events{/privacy}","received_events_url":"https://api.github.com/users/stasee/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nthere is one impreovement here:\r\nemit the close event from the socket to allow detection of a dropped connectiion (e.g. eibd restarted).\r\nThe groupsocketlisten example now uses it.\r\n\r\nThere is also a fix for the parser:\r\nIt did not correctly scan the input stream for messages, it just took the first message in the read data stream.\r\nThe parser can now handle messages:\r\n-coming fast (more than one message coming in one read request)\r\n-fragmented (only a partial message coming in one read request)\r\n\r\nI how you will accept my pull request.","created_at":"2015-11-28T21:02:09Z","updated_at":"2015-12-01T09:46:42Z","closed_at":"2015-12-01T09:46:42Z","merged_at":"2015-12-01T09:46:42Z","merge_commit_sha":"1fafd74448762e1d79c565e850052eacca388f35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andreek/node-eibd/pulls/24/commits","review_comments_url":"https://api.github.com/repos/andreek/node-eibd/pulls/24/comments","review_comment_url":"https://api.github.com/repos/andreek/node-eibd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andreek/node-eibd/issues/24/comments","statuses_url":"https://api.github.com/repos/andreek/node-eibd/statuses/ba1b205c16def7de40ed50dd8d434a8a3564c754","head":{"label":"stasee:master","ref":"master","sha":"ba1b205c16def7de40ed50dd8d434a8a3564c754","user":{"login":"stasee","id":16062493,"avatar_url":"https://avatars.githubusercontent.com/u/16062493?v=3","gravatar_id":"","url":"https://api.github.com/users/stasee","html_url":"https://github.com/stasee","followers_url":"https://api.github.com/users/stasee/followers","following_url":"https://api.github.com/users/stasee/following{/other_user}","gists_url":"https://api.github.com/users/stasee/gists{/gist_id}","starred_url":"https://api.github.com/users/stasee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasee/subscriptions","organizations_url":"https://api.github.com/users/stasee/orgs","repos_url":"https://api.github.com/users/stasee/repos","events_url":"https://api.github.com/users/stasee/events{/privacy}","received_events_url":"https://api.github.com/users/stasee/received_events","type":"User","site_admin":false},"repo":{"id":47038411,"name":"node-eibd","full_name":"stasee/node-eibd","owner":{"login":"stasee","id":16062493,"avatar_url":"https://avatars.githubusercontent.com/u/16062493?v=3","gravatar_id":"","url":"https://api.github.com/users/stasee","html_url":"https://github.com/stasee","followers_url":"https://api.github.com/users/stasee/followers","following_url":"https://api.github.com/users/stasee/following{/other_user}","gists_url":"https://api.github.com/users/stasee/gists{/gist_id}","starred_url":"https://api.github.com/users/stasee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasee/subscriptions","organizations_url":"https://api.github.com/users/stasee/orgs","repos_url":"https://api.github.com/users/stasee/repos","events_url":"https://api.github.com/users/stasee/events{/privacy}","received_events_url":"https://api.github.com/users/stasee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stasee/node-eibd","description":"node.js eibd client (EIB/KNX daemon)","fork":true,"url":"https://api.github.com/repos/stasee/node-eibd","forks_url":"https://api.github.com/repos/stasee/node-eibd/forks","keys_url":"https://api.github.com/repos/stasee/node-eibd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stasee/node-eibd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stasee/node-eibd/teams","hooks_url":"https://api.github.com/repos/stasee/node-eibd/hooks","issue_events_url":"https://api.github.com/repos/stasee/node-eibd/issues/events{/number}","events_url":"https://api.github.com/repos/stasee/node-eibd/events","assignees_url":"https://api.github.com/repos/stasee/node-eibd/assignees{/user}","branches_url":"https://api.github.com/repos/stasee/node-eibd/branches{/branch}","tags_url":"https://api.github.com/repos/stasee/node-eibd/tags","blobs_url":"https://api.github.com/repos/stasee/node-eibd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stasee/node-eibd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stasee/node-eibd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stasee/node-eibd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stasee/node-eibd/statuses/{sha}","languages_url":"https://api.github.com/repos/stasee/node-eibd/languages","stargazers_url":"https://api.github.com/repos/stasee/node-eibd/stargazers","contributors_url":"https://api.github.com/repos/stasee/node-eibd/contributors","subscribers_url":"https://api.github.com/repos/stasee/node-eibd/subscribers","subscription_url":"https://api.github.com/repos/stasee/node-eibd/subscription","commits_url":"https://api.github.com/repos/stasee/node-eibd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stasee/node-eibd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stasee/node-eibd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stasee/node-eibd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stasee/node-eibd/contents/{+path}","compare_url":"https://api.github.com/repos/stasee/node-eibd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stasee/node-eibd/merges","archive_url":"https://api.github.com/repos/stasee/node-eibd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stasee/node-eibd/downloads","issues_url":"https://api.github.com/repos/stasee/node-eibd/issues{/number}","pulls_url":"https://api.github.com/repos/stasee/node-eibd/pulls{/number}","milestones_url":"https://api.github.com/repos/stasee/node-eibd/milestones{/number}","notifications_url":"https://api.github.com/repos/stasee/node-eibd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stasee/node-eibd/labels{/name}","releases_url":"https://api.github.com/repos/stasee/node-eibd/releases{/id}","created_at":"2015-11-28T20:29:22Z","updated_at":"2015-11-28T20:29:23Z","pushed_at":"2015-11-30T11:32:12Z","git_url":"git://github.com/stasee/node-eibd.git","ssh_url":"git@github.com:stasee/node-eibd.git","clone_url":"https://github.com/stasee/node-eibd.git","svn_url":"https://github.com/stasee/node-eibd","homepage":"","size":89,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andreek:master","ref":"master","sha":"ab191c182d8bde5e717f3bc92dd880e59c25b623","user":{"login":"andreek","id":1627377,"avatar_url":"https://avatars.githubusercontent.com/u/1627377?v=3","gravatar_id":"","url":"https://api.github.com/users/andreek","html_url":"https://github.com/andreek","followers_url":"https://api.github.com/users/andreek/followers","following_url":"https://api.github.com/users/andreek/following{/other_user}","gists_url":"https://api.github.com/users/andreek/gists{/gist_id}","starred_url":"https://api.github.com/users/andreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreek/subscriptions","organizations_url":"https://api.github.com/users/andreek/orgs","repos_url":"https://api.github.com/users/andreek/repos","events_url":"https://api.github.com/users/andreek/events{/privacy}","received_events_url":"https://api.github.com/users/andreek/received_events","type":"User","site_admin":false},"repo":{"id":5824468,"name":"node-eibd","full_name":"andreek/node-eibd","owner":{"login":"andreek","id":1627377,"avatar_url":"https://avatars.githubusercontent.com/u/1627377?v=3","gravatar_id":"","url":"https://api.github.com/users/andreek","html_url":"https://github.com/andreek","followers_url":"https://api.github.com/users/andreek/followers","following_url":"https://api.github.com/users/andreek/following{/other_user}","gists_url":"https://api.github.com/users/andreek/gists{/gist_id}","starred_url":"https://api.github.com/users/andreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreek/subscriptions","organizations_url":"https://api.github.com/users/andreek/orgs","repos_url":"https://api.github.com/users/andreek/repos","events_url":"https://api.github.com/users/andreek/events{/privacy}","received_events_url":"https://api.github.com/users/andreek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreek/node-eibd","description":"node.js eibd client (EIB/KNX daemon)","fork":false,"url":"https://api.github.com/repos/andreek/node-eibd","forks_url":"https://api.github.com/repos/andreek/node-eibd/forks","keys_url":"https://api.github.com/repos/andreek/node-eibd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreek/node-eibd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreek/node-eibd/teams","hooks_url":"https://api.github.com/repos/andreek/node-eibd/hooks","issue_events_url":"https://api.github.com/repos/andreek/node-eibd/issues/events{/number}","events_url":"https://api.github.com/repos/andreek/node-eibd/events","assignees_url":"https://api.github.com/repos/andreek/node-eibd/assignees{/user}","branches_url":"https://api.github.com/repos/andreek/node-eibd/branches{/branch}","tags_url":"https://api.github.com/repos/andreek/node-eibd/tags","blobs_url":"https://api.github.com/repos/andreek/node-eibd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreek/node-eibd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreek/node-eibd/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreek/node-eibd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreek/node-eibd/statuses/{sha}","languages_url":"https://api.github.com/repos/andreek/node-eibd/languages","stargazers_url":"https://api.github.com/repos/andreek/node-eibd/stargazers","contributors_url":"https://api.github.com/repos/andreek/node-eibd/contributors","subscribers_url":"https://api.github.com/repos/andreek/node-eibd/subscribers","subscription_url":"https://api.github.com/repos/andreek/node-eibd/subscription","commits_url":"https://api.github.com/repos/andreek/node-eibd/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreek/node-eibd/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreek/node-eibd/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreek/node-eibd/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreek/node-eibd/contents/{+path}","compare_url":"https://api.github.com/repos/andreek/node-eibd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreek/node-eibd/merges","archive_url":"https://api.github.com/repos/andreek/node-eibd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreek/node-eibd/downloads","issues_url":"https://api.github.com/repos/andreek/node-eibd/issues{/number}","pulls_url":"https://api.github.com/repos/andreek/node-eibd/pulls{/number}","milestones_url":"https://api.github.com/repos/andreek/node-eibd/milestones{/number}","notifications_url":"https://api.github.com/repos/andreek/node-eibd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreek/node-eibd/labels{/name}","releases_url":"https://api.github.com/repos/andreek/node-eibd/releases{/id}","created_at":"2012-09-15T21:38:08Z","updated_at":"2015-11-26T16:22:21Z","pushed_at":"2015-12-01T09:46:42Z","git_url":"git://github.com/andreek/node-eibd.git","ssh_url":"git@github.com:andreek/node-eibd.git","clone_url":"https://github.com/andreek/node-eibd.git","svn_url":"https://github.com/andreek/node-eibd","homepage":"","size":91,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":0,"forks":10,"open_issues":0,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andreek/node-eibd/pulls/24"},"html":{"href":"https://github.com/andreek/node-eibd/pull/24"},"issue":{"href":"https://api.github.com/repos/andreek/node-eibd/issues/24"},"comments":{"href":"https://api.github.com/repos/andreek/node-eibd/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/andreek/node-eibd/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/andreek/node-eibd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andreek/node-eibd/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/andreek/node-eibd/statuses/ba1b205c16def7de40ed50dd8d434a8a3564c754"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andreek","id":1627377,"avatar_url":"https://avatars.githubusercontent.com/u/1627377?v=3","gravatar_id":"","url":"https://api.github.com/users/andreek","html_url":"https://github.com/andreek","followers_url":"https://api.github.com/users/andreek/followers","following_url":"https://api.github.com/users/andreek/following{/other_user}","gists_url":"https://api.github.com/users/andreek/gists{/gist_id}","starred_url":"https://api.github.com/users/andreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreek/subscriptions","organizations_url":"https://api.github.com/users/andreek/orgs","repos_url":"https://api.github.com/users/andreek/repos","events_url":"https://api.github.com/users/andreek/events{/privacy}","received_events_url":"https://api.github.com/users/andreek/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":36,"deletions":35,"changed_files":3}}