{"action":"created","issue":{"url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/13","labels_url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/13/comments","events_url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/13/events","html_url":"https://github.com/thorstenwagner/ij-ridgedetection/issues/13","id":116115566,"number":13,"title":"Make macro recordable","user":{"login":"hinerm","id":1123809,"avatar_url":"https://avatars.githubusercontent.com/u/1123809?v=3","gravatar_id":"","url":"https://api.github.com/users/hinerm","html_url":"https://github.com/hinerm","followers_url":"https://api.github.com/users/hinerm/followers","following_url":"https://api.github.com/users/hinerm/following{/other_user}","gists_url":"https://api.github.com/users/hinerm/gists{/gist_id}","starred_url":"https://api.github.com/users/hinerm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hinerm/subscriptions","organizations_url":"https://api.github.com/users/hinerm/orgs","repos_url":"https://api.github.com/users/hinerm/repos","events_url":"https://api.github.com/users/hinerm/events{/privacy}","received_events_url":"https://api.github.com/users/hinerm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T14:16:59Z","updated_at":"2015-11-10T14:45:44Z","closed_at":null,"body":"I would really like to call this plugin from a macro, recording all parameters so that a dialog does not need to be shown.\r\n\r\n@thorstenwagner I spent a few minutes on it this morning but gave up. It is not clear to me what would need to be done to make this nicely macro recordable in the ImageJ 1.x framework.\r\n\r\nIf you can give me some direction I am willing to do the work. But I looked at other plugins that I know are fully recordable and still couldn't figure it out. :(\r\n\r\nAnyway another option would be to just convert to ImageJ 2 where we could use [`@Parameter`](http://imagej.net/Writing_plugins#What_makes_up_the_SciJava_plugin_framework.3F) notation and get rid of the generic dialog and macro language restrictions altogether. I would be happy to work on this as well but only if you are OK moving to IJ2.\r\n\r\nLet me know! :)"},"comment":{"url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/comments/155438820","html_url":"https://github.com/thorstenwagner/ij-ridgedetection/issues/13#issuecomment-155438820","issue_url":"https://api.github.com/repos/thorstenwagner/ij-ridgedetection/issues/13","id":155438820,"user":{"login":"imagejan","id":2033938,"avatar_url":"https://avatars.githubusercontent.com/u/2033938?v=3","gravatar_id":"","url":"https://api.github.com/users/imagejan","html_url":"https://github.com/imagejan","followers_url":"https://api.github.com/users/imagejan/followers","following_url":"https://api.github.com/users/imagejan/following{/other_user}","gists_url":"https://api.github.com/users/imagejan/gists{/gist_id}","starred_url":"https://api.github.com/users/imagejan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imagejan/subscriptions","organizations_url":"https://api.github.com/users/imagejan/orgs","repos_url":"https://api.github.com/users/imagejan/repos","events_url":"https://api.github.com/users/imagejan/events{/privacy}","received_events_url":"https://api.github.com/users/imagejan/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T14:45:44Z","updated_at":"2015-11-10T14:45:44Z","body":"@hinerm I just tried and macro recording worked as expected:\r\n\r\n```javascript\r\nrun(\"Ridge Detection\", \"line=3.5 high=230 low=87 darkline extend display add sigma=1.50 lower=3.06 upper=7.99\");\r\n```\r\nThe only issue currently is the duplicate keyword `show` (recorded when you check both *Show junction points* and *Show IDs*) that can be eliminated by [introducing an underscore in one of the labels](https://github.com/thorstenwagner/ij-ridgedetection/blob/master/src/main/java/de/biomedical_imaging/ij/steger/Lines_.java#L197), e.g. *Show_IDs*.\r\n\r\n@thorstenwagner Why are you re-implementing `GenericDialogPlus` when you can just use the one included in Fiji (`fiji.util.gui.GenericDialogPlus`)?\r\n\r\nThat said, I agree that switching to ImageJ2 parameter notation is the preferred solution in the long term, of course.\r\n\r\n"}}