{"action":"created","issue":{"url":"https://api.github.com/repos/Moya/Moya/issues/293","labels_url":"https://api.github.com/repos/Moya/Moya/issues/293/labels{/name}","comments_url":"https://api.github.com/repos/Moya/Moya/issues/293/comments","events_url":"https://api.github.com/repos/Moya/Moya/issues/293/events","html_url":"https://github.com/Moya/Moya/issues/293","id":116466902,"number":293,"title":"Change completion block type.","user":{"login":"petester42","id":296718,"avatar_url":"https://avatars.githubusercontent.com/u/296718?v=3","gravatar_id":"","url":"https://api.github.com/users/petester42","html_url":"https://github.com/petester42","followers_url":"https://api.github.com/users/petester42/followers","following_url":"https://api.github.com/users/petester42/following{/other_user}","gists_url":"https://api.github.com/users/petester42/gists{/gist_id}","starred_url":"https://api.github.com/users/petester42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petester42/subscriptions","organizations_url":"https://api.github.com/users/petester42/orgs","repos_url":"https://api.github.com/users/petester42/repos","events_url":"https://api.github.com/users/petester42/events{/privacy}","received_events_url":"https://api.github.com/users/petester42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Moya/Moya/milestones/4","html_url":"https://github.com/Moya/Moya/milestones/5.0.0","labels_url":"https://api.github.com/repos/Moya/Moya/milestones/4/labels","id":1411806,"number":4,"title":"5.0.0","description":"Per https://github.com/Moya/Moya/pull/289, master now contains breaking changes and thus justifies a new major version number. I believe these changes are beneficial but should be carefully considered && released ASAP. Any other breaking API changes we should sneak in *nao* while the version number is being cut.","creator":{"login":"swizzlr","id":1848665,"avatar_url":"https://avatars.githubusercontent.com/u/1848665?v=3","gravatar_id":"","url":"https://api.github.com/users/swizzlr","html_url":"https://github.com/swizzlr","followers_url":"https://api.github.com/users/swizzlr/followers","following_url":"https://api.github.com/users/swizzlr/following{/other_user}","gists_url":"https://api.github.com/users/swizzlr/gists{/gist_id}","starred_url":"https://api.github.com/users/swizzlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swizzlr/subscriptions","organizations_url":"https://api.github.com/users/swizzlr/orgs","repos_url":"https://api.github.com/users/swizzlr/repos","events_url":"https://api.github.com/users/swizzlr/events{/privacy}","received_events_url":"https://api.github.com/users/swizzlr/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2015-11-14T19:39:17Z","updated_at":"2015-11-16T14:56:05Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2015-11-12T02:34:01Z","updated_at":"2015-11-16T16:29:58Z","closed_at":null,"body":"Since we are going to merge a breaking change with #289 I'd like to propose that we change the completion block type.\r\n\r\nFrom\r\n`public typealias Completion = (data: NSData?, statusCode: Int?, response: NSURLResponse?, error: ErrorType?) -> ()`\r\n\r\nTo\r\n`public typealias Completion = (response: MoyaResponse?, error: ErrorType?) -> ()`\r\n\r\nThis would allow people that do not use the reactive extensions to be able to use the helpful mapping functions and simplify the integrating with various json parsing libraries.\r\n\r\nWhat do people think?\r\n"},"comment":{"url":"https://api.github.com/repos/Moya/Moya/issues/comments/157088841","html_url":"https://github.com/Moya/Moya/issues/293#issuecomment-157088841","issue_url":"https://api.github.com/repos/Moya/Moya/issues/293","id":157088841,"user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars.githubusercontent.com/u/498212?v=3","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T16:29:58Z","updated_at":"2015-11-16T16:29:58Z","body":"I'm not a fan of the double-optional parameters, just because there's this weird state where both are nil that no one is quite sure what to do about and mostly ignore it. A result type feels like a reasonable compromise. "}}