{"action":"created","comment":{"url":"https://api.github.com/repos/opencog/opencog/pulls/comments/36175069","id":36175069,"diff_hunk":"@@ -2122,7 +2115,7 @@ std::string AtomSpaceUtil::getObjIdFromName( AtomSpace& atomSpace,\n \n Handle AtomSpaceUtil::getMostRecentPetSchemaExecLink(AtomSpace& atomSpace,\n         unsigned long timestamp,\n-        bool schemaSuccessful)\n+\tbool schemaSuccessful)","path":"opencog/embodiment/AtomSpaceExtensions/AtomSpaceUtil.cc","position":227,"original_position":227,"commit_id":"067e587f79c0aa394976a66d917f1fa75c6d31c2","original_commit_id":"067e587f79c0aa394976a66d917f1fa75c6d31c2","user":{"login":"ngeiswei","id":819225,"avatar_url":"https://avatars.githubusercontent.com/u/819225?v=3","gravatar_id":"","url":"https://api.github.com/users/ngeiswei","html_url":"https://github.com/ngeiswei","followers_url":"https://api.github.com/users/ngeiswei/followers","following_url":"https://api.github.com/users/ngeiswei/following{/other_user}","gists_url":"https://api.github.com/users/ngeiswei/gists{/gist_id}","starred_url":"https://api.github.com/users/ngeiswei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngeiswei/subscriptions","organizations_url":"https://api.github.com/users/ngeiswei/orgs","repos_url":"https://api.github.com/users/ngeiswei/repos","events_url":"https://api.github.com/users/ngeiswei/events{/privacy}","received_events_url":"https://api.github.com/users/ngeiswei/received_events","type":"User","site_admin":false},"body":"Is a tab while the indentation style of that file seems to be 4-ws.","created_at":"2015-08-04T10:31:12Z","updated_at":"2015-08-04T10:31:12Z","html_url":"https://github.com/opencog/opencog/pull/1677#discussion_r36175069","pull_request_url":"https://api.github.com/repos/opencog/opencog/pulls/1677","_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments/36175069"},"html":{"href":"https://github.com/opencog/opencog/pull/1677#discussion_r36175069"},"pull_request":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1677"}}},"pull_request":{"url":"https://api.github.com/repos/opencog/opencog/pulls/1677","id":40001654,"html_url":"https://github.com/opencog/opencog/pull/1677","diff_url":"https://github.com/opencog/opencog/pull/1677.diff","patch_url":"https://github.com/opencog/opencog/pull/1677.patch","issue_url":"https://api.github.com/repos/opencog/opencog/issues/1677","number":1677,"state":"open","locked":false,"title":"add time domain in the TimeServer","user":{"login":"chenesan","id":7620906,"avatar_url":"https://avatars.githubusercontent.com/u/7620906?v=3","gravatar_id":"","url":"https://api.github.com/users/chenesan","html_url":"https://github.com/chenesan","followers_url":"https://api.github.com/users/chenesan/followers","following_url":"https://api.github.com/users/chenesan/following{/other_user}","gists_url":"https://api.github.com/users/chenesan/gists{/gist_id}","starred_url":"https://api.github.com/users/chenesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenesan/subscriptions","organizations_url":"https://api.github.com/users/chenesan/orgs","repos_url":"https://api.github.com/users/chenesan/repos","events_url":"https://api.github.com/users/chenesan/events{/privacy}","received_events_url":"https://api.github.com/users/chenesan/received_events","type":"User","site_admin":false},"body":"Why to do this: \r\n\r\nSometimes in the embodiment we may have different time zone. For example, when we play the game we know that the time in game is in the morning and the time in the real world may be 9pm. We have different time domain concepts. And in the GSoC Minecraft embodiment we find that we may want to save both the ROS timestamp and Minecraft timestamp. Because the unit of Minecraft timestamp is too large(1 sec per tick), we need ROS timestamp to help us save the order of event; but the Minecraft timestamp is still necessary for knowing the world(for example, judging if the monster will appear or not). So we want to keep those two time domain in the TimeServer. I think we can regard this change as the same one in SpaceServer, to save multiple spaceMap in SpaceServer.\r\n\r\nWhat changed:\r\n\r\n*Add a map<timedomain, temporaltable*> in the time server, and get the table by finding it in this map\r\n*Add function: \r\ngetTimeDomain()\r\ngetTimeDomains()\r\nexistTimeDomain()\r\nto get/query time domain in the TimeServer.\r\nNotice that the getTimeDomain() is used for old code which assume there's only one time domain in the system. \r\n*Change the interface of TimeServer. Add a time domain param.\r\n*fix all the code using the TimeServer by adding the timedomain in the argument(mostly just call the timeServer().getTimeDomain())\r\n\r\nI haven't added unit test to test the multiple time domain. but I have checked that I can fix and pass the unit tests (without anaphora, pythonmodule, plnrule, which is broken in my environment before this change.)under these changes.","created_at":"2015-07-15T09:07:49Z","updated_at":"2015-08-04T10:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b7318a67d76259d21681e5d52ba3e5efcdebc1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencog/opencog/pulls/1677/commits","review_comments_url":"https://api.github.com/repos/opencog/opencog/pulls/1677/comments","review_comment_url":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/opencog/issues/1677/comments","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/067e587f79c0aa394976a66d917f1fa75c6d31c2","head":{"label":"chenesan:TimeDomainFeature","ref":"TimeDomainFeature","sha":"067e587f79c0aa394976a66d917f1fa75c6d31c2","user":{"login":"chenesan","id":7620906,"avatar_url":"https://avatars.githubusercontent.com/u/7620906?v=3","gravatar_id":"","url":"https://api.github.com/users/chenesan","html_url":"https://github.com/chenesan","followers_url":"https://api.github.com/users/chenesan/followers","following_url":"https://api.github.com/users/chenesan/following{/other_user}","gists_url":"https://api.github.com/users/chenesan/gists{/gist_id}","starred_url":"https://api.github.com/users/chenesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenesan/subscriptions","organizations_url":"https://api.github.com/users/chenesan/orgs","repos_url":"https://api.github.com/users/chenesan/repos","events_url":"https://api.github.com/users/chenesan/events{/privacy}","received_events_url":"https://api.github.com/users/chenesan/received_events","type":"User","site_admin":false},"repo":{"id":35936753,"name":"opencog","full_name":"chenesan/opencog","owner":{"login":"chenesan","id":7620906,"avatar_url":"https://avatars.githubusercontent.com/u/7620906?v=3","gravatar_id":"","url":"https://api.github.com/users/chenesan","html_url":"https://github.com/chenesan","followers_url":"https://api.github.com/users/chenesan/followers","following_url":"https://api.github.com/users/chenesan/following{/other_user}","gists_url":"https://api.github.com/users/chenesan/gists{/gist_id}","starred_url":"https://api.github.com/users/chenesan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenesan/subscriptions","organizations_url":"https://api.github.com/users/chenesan/orgs","repos_url":"https://api.github.com/users/chenesan/repos","events_url":"https://api.github.com/users/chenesan/events{/privacy}","received_events_url":"https://api.github.com/users/chenesan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenesan/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":true,"url":"https://api.github.com/repos/chenesan/opencog","forks_url":"https://api.github.com/repos/chenesan/opencog/forks","keys_url":"https://api.github.com/repos/chenesan/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenesan/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenesan/opencog/teams","hooks_url":"https://api.github.com/repos/chenesan/opencog/hooks","issue_events_url":"https://api.github.com/repos/chenesan/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/chenesan/opencog/events","assignees_url":"https://api.github.com/repos/chenesan/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/chenesan/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/chenesan/opencog/tags","blobs_url":"https://api.github.com/repos/chenesan/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenesan/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenesan/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenesan/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenesan/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/chenesan/opencog/languages","stargazers_url":"https://api.github.com/repos/chenesan/opencog/stargazers","contributors_url":"https://api.github.com/repos/chenesan/opencog/contributors","subscribers_url":"https://api.github.com/repos/chenesan/opencog/subscribers","subscription_url":"https://api.github.com/repos/chenesan/opencog/subscription","commits_url":"https://api.github.com/repos/chenesan/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenesan/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenesan/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenesan/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenesan/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/chenesan/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenesan/opencog/merges","archive_url":"https://api.github.com/repos/chenesan/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenesan/opencog/downloads","issues_url":"https://api.github.com/repos/chenesan/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/chenesan/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/chenesan/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/chenesan/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenesan/opencog/labels{/name}","releases_url":"https://api.github.com/repos/chenesan/opencog/releases{/id}","created_at":"2015-05-20T08:50:09Z","updated_at":"2015-05-20T08:50:15Z","pushed_at":"2015-08-04T04:22:27Z","git_url":"git://github.com/chenesan/opencog.git","ssh_url":"git@github.com:chenesan/opencog.git","clone_url":"https://github.com/chenesan/opencog.git","svn_url":"https://github.com/chenesan/opencog","homepage":"http://wiki.opencog.org/w/Development","size":139878,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"f06e29468bd0e4cb76a083e1b3159c88e5e47749","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":6365343,"name":"opencog","full_name":"opencog/opencog","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":false,"url":"https://api.github.com/repos/opencog/opencog","forks_url":"https://api.github.com/repos/opencog/opencog/forks","keys_url":"https://api.github.com/repos/opencog/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/opencog/teams","hooks_url":"https://api.github.com/repos/opencog/opencog/hooks","issue_events_url":"https://api.github.com/repos/opencog/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/opencog/events","assignees_url":"https://api.github.com/repos/opencog/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/opencog/tags","blobs_url":"https://api.github.com/repos/opencog/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/opencog/languages","stargazers_url":"https://api.github.com/repos/opencog/opencog/stargazers","contributors_url":"https://api.github.com/repos/opencog/opencog/contributors","subscribers_url":"https://api.github.com/repos/opencog/opencog/subscribers","subscription_url":"https://api.github.com/repos/opencog/opencog/subscription","commits_url":"https://api.github.com/repos/opencog/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/opencog/merges","archive_url":"https://api.github.com/repos/opencog/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/opencog/downloads","issues_url":"https://api.github.com/repos/opencog/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/opencog/labels{/name}","releases_url":"https://api.github.com/repos/opencog/opencog/releases{/id}","created_at":"2012-10-24T06:10:15Z","updated_at":"2015-08-03T06:39:23Z","pushed_at":"2015-08-04T05:19:21Z","git_url":"git://github.com/opencog/opencog.git","ssh_url":"git@github.com:opencog/opencog.git","clone_url":"https://github.com/opencog/opencog.git","svn_url":"https://github.com/opencog/opencog","homepage":"http://wiki.opencog.org/w/Development","size":151703,"stargazers_count":647,"watchers_count":647,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":312,"mirror_url":null,"open_issues_count":107,"forks":312,"open_issues":107,"watchers":647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1677"},"html":{"href":"https://github.com/opencog/opencog/pull/1677"},"issue":{"href":"https://api.github.com/repos/opencog/opencog/issues/1677"},"comments":{"href":"https://api.github.com/repos/opencog/opencog/issues/1677/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1677/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/opencog/pulls/1677/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/opencog/statuses/067e587f79c0aa394976a66d917f1fa75c6d31c2"}}}}