{"action":"created","issue":{"url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/991","labels_url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/991/labels{/name}","comments_url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/991/comments","events_url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/991/events","html_url":"https://github.com/SupSuper/OpenXcom/pull/991","id":60284282,"number":991,"title":"Fix gcc warnings (unused variable + un/signed comparisons)","user":{"login":"WorMzy","id":1131333,"avatar_url":"https://avatars.githubusercontent.com/u/1131333?v=3","gravatar_id":"","url":"https://api.github.com/users/WorMzy","html_url":"https://github.com/WorMzy","followers_url":"https://api.github.com/users/WorMzy/followers","following_url":"https://api.github.com/users/WorMzy/following{/other_user}","gists_url":"https://api.github.com/users/WorMzy/gists{/gist_id}","starred_url":"https://api.github.com/users/WorMzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WorMzy/subscriptions","organizations_url":"https://api.github.com/users/WorMzy/orgs","repos_url":"https://api.github.com/users/WorMzy/repos","events_url":"https://api.github.com/users/WorMzy/events{/privacy}","received_events_url":"https://api.github.com/users/WorMzy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-09T00:09:38Z","updated_at":"2015-03-11T21:27:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SupSuper/OpenXcom/pulls/991","html_url":"https://github.com/SupSuper/OpenXcom/pull/991","diff_url":"https://github.com/SupSuper/OpenXcom/pull/991.diff","patch_url":"https://github.com/SupSuper/OpenXcom/pull/991.patch"},"body":"This pull request fixes the following errors:\r\n```\r\nsrc/Battlescape/UnitDieBState.cpp: In member function 'virtual void OpenXcom::UnitDieBState::think()':\r\nsrc/Battlescape/UnitDieBState.cpp:208:16: error: unused variable 'newUnit' [-Werror=unused-variable]\r\n    BattleUnit *newUnit = _parent->convertUnit(_unit, _unit->getSpawnUnit());\r\n                ^\r\n```\r\n```\r\nsrc/Engine/FlcPlayer.cpp: In member function 'void OpenXcom::FlcPlayer::playAudioFrame(Uint16)':\r\nsrc/Engine/FlcPlayer.cpp:471:20: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]\r\n  for (int i = 0; i < _audioFrameSize; i++)\r\n                    ^\r\n```\r\nand\r\n```\r\nsrc/Geoscape/GeoscapeState.cpp: In member function 'void OpenXcom::GeoscapeState::setupLandMission()':\r\nsrc/Geoscape/GeoscapeState.cpp:2186:40: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]\r\n   if (region->getMissionZones().size() > missionRules.getSpawnZone() &&\r\n                                        ^\r\n```"},"comment":{"url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/comments/78375738","html_url":"https://github.com/SupSuper/OpenXcom/pull/991#issuecomment-78375738","issue_url":"https://api.github.com/repos/SupSuper/OpenXcom/issues/991","id":78375738,"user":{"login":"Yankes","id":993167,"avatar_url":"https://avatars.githubusercontent.com/u/993167?v=3","gravatar_id":"","url":"https://api.github.com/users/Yankes","html_url":"https://github.com/Yankes","followers_url":"https://api.github.com/users/Yankes/followers","following_url":"https://api.github.com/users/Yankes/following{/other_user}","gists_url":"https://api.github.com/users/Yankes/gists{/gist_id}","starred_url":"https://api.github.com/users/Yankes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yankes/subscriptions","organizations_url":"https://api.github.com/users/Yankes/orgs","repos_url":"https://api.github.com/users/Yankes/repos","events_url":"https://api.github.com/users/Yankes/events{/privacy}","received_events_url":"https://api.github.com/users/Yankes/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T21:27:59Z","updated_at":"2015-03-11T21:27:59Z","body":"Exactly that line, without context every change of code can break it even if is warning fix.\r\nI think you should have first some fun on your own with the code without trying fix bugs in it.\r\nAfter that, when you have enough confidence you should start fixing bugs and warnings.\r\n\r\nOverall, I wish you happy hacking OXC :)"}}