{"action":"created","issue":{"url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/27","labels_url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/27/comments","events_url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/27/events","html_url":"https://github.com/dmitryme/erlang_localtime/pull/27","id":118227579,"number":27,"title":"GMT offset fix","user":{"login":"dhull","id":395287,"avatar_url":"https://avatars.githubusercontent.com/u/395287?v=3","gravatar_id":"","url":"https://api.github.com/users/dhull","html_url":"https://github.com/dhull","followers_url":"https://api.github.com/users/dhull/followers","following_url":"https://api.github.com/users/dhull/following{/other_user}","gists_url":"https://api.github.com/users/dhull/gists{/gist_id}","starred_url":"https://api.github.com/users/dhull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhull/subscriptions","organizations_url":"https://api.github.com/users/dhull/orgs","repos_url":"https://api.github.com/users/dhull/repos","events_url":"https://api.github.com/users/dhull/events{/privacy}","received_events_url":"https://api.github.com/users/dhull/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-21T23:34:42Z","updated_at":"2015-12-05T09:21:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmitryme/erlang_localtime/pulls/27","html_url":"https://github.com/dmitryme/erlang_localtime/pull/27","diff_url":"https://github.com/dmitryme/erlang_localtime/pull/27.diff","patch_url":"https://github.com/dmitryme/erlang_localtime/pull/27.patch"},"body":"Fixed the GMT+H and GMT-H entries in tz_database.hrl, in which the UTC offset was too small by a factor of 60. The tz-erl script had a bug in the `offset_minutes` function where it treated an offset that was a plain integer as the offset in minutes instead of hours. (Most entries use \"HH:MM\" or \"0\".)\r\n\r\nUpdate `fmt_shift` to handle an argument of `0`. This is necessary for `tz_shift/3`, because `tz_shift(_, \"UTC\")` return `0` instead of `{+, 0, 0}`, and this can cause a problem when using `tz_shift/3` to convert to or from UTC.\r\n\r\nIn tz-erl, made the future date test in zone lines more precise.\r\n\r\nIn tz-erl, better documented the problem with zone that begin or end using DST in the current year. (But did not solve the problem. This happened in Uruguay in 2015.)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/comments/162163853","html_url":"https://github.com/dmitryme/erlang_localtime/pull/27#issuecomment-162163853","issue_url":"https://api.github.com/repos/dmitryme/erlang_localtime/issues/27","id":162163853,"user":{"login":"jacktang","id":44341,"avatar_url":"https://avatars.githubusercontent.com/u/44341?v=3","gravatar_id":"","url":"https://api.github.com/users/jacktang","html_url":"https://github.com/jacktang","followers_url":"https://api.github.com/users/jacktang/followers","following_url":"https://api.github.com/users/jacktang/following{/other_user}","gists_url":"https://api.github.com/users/jacktang/gists{/gist_id}","starred_url":"https://api.github.com/users/jacktang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacktang/subscriptions","organizations_url":"https://api.github.com/users/jacktang/orgs","repos_url":"https://api.github.com/users/jacktang/repos","events_url":"https://api.github.com/users/jacktang/events{/privacy}","received_events_url":"https://api.github.com/users/jacktang/received_events","type":"User","site_admin":false},"created_at":"2015-12-05T09:21:50Z","updated_at":"2015-12-05T09:21:50Z","body":"Well, the database is still not correct, the clock in GMT+X zone faster than GMT+0, so for example GMT+8 should plus 480 minutes not minus.\r\n\r\nsee commit: https://github.com/dhull/erlang_localtime/commit/b36ea2cec2b5fac3dbbbc64898262057cde2f888\r\n "}}