{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/37453401","id":37453401,"diff_hunk":"@@ -137,10 +137,17 @@ Execute each of the listeners in order with the supplied arguments.\n Returns `true` if event had listeners, `false` otherwise.\n \n \n+### emitter.listenerCount(type)\n+\n+* `type` {String} The type of event","path":"doc/api/events.markdown","position":6,"original_position":6,"commit_id":"7154613947c9bc4b5ce6db0e520a5896d0aab05b","original_commit_id":"7154613947c9bc4b5ce6db0e520a5896d0aab05b","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"But we have a check now, which expects the `type` to be string. Is that okay to change this to `Value`?","created_at":"2015-08-19T18:56:11Z","updated_at":"2015-08-19T18:56:11Z","html_url":"https://github.com/nodejs/node/pull/2349#discussion_r37453401","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/2349","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/37453401"},"html":{"href":"https://github.com/nodejs/node/pull/2349#discussion_r37453401"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/2349"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2349","id":42161972,"html_url":"https://github.com/nodejs/node/pull/2349","diff_url":"https://github.com/nodejs/node/pull/2349.diff","patch_url":"https://github.com/nodejs/node/pull/2349.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/2349","number":2349,"state":"open","locked":false,"title":"events: deprecate static listenerCount function","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"As per the discussion in #734, this patch deprecates the usage of\r\n`EventEmitter.listenerCount` static function and introduces the `listenerCount`\r\nfunction in the prototype of `EventEmitter` itself.","created_at":"2015-08-11T18:35:07Z","updated_at":"2015-08-19T18:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04304af6c0a67a0cb3ccf083892003ad856f2ff1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/2349/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/2349/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2349/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/7154613947c9bc4b5ce6db0e520a5896d0aab05b","head":{"label":"thefourtheye:event-emitter-listener-count","ref":"event-emitter-listener-count","sha":"7154613947c9bc4b5ce6db0e520a5896d0aab05b","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"repo":{"id":35113605,"name":"io.js","full_name":"thefourtheye/io.js","owner":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thefourtheye/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/thefourtheye/io.js","forks_url":"https://api.github.com/repos/thefourtheye/io.js/forks","keys_url":"https://api.github.com/repos/thefourtheye/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefourtheye/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefourtheye/io.js/teams","hooks_url":"https://api.github.com/repos/thefourtheye/io.js/hooks","issue_events_url":"https://api.github.com/repos/thefourtheye/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/thefourtheye/io.js/events","assignees_url":"https://api.github.com/repos/thefourtheye/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/thefourtheye/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/thefourtheye/io.js/tags","blobs_url":"https://api.github.com/repos/thefourtheye/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefourtheye/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefourtheye/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefourtheye/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefourtheye/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/thefourtheye/io.js/languages","stargazers_url":"https://api.github.com/repos/thefourtheye/io.js/stargazers","contributors_url":"https://api.github.com/repos/thefourtheye/io.js/contributors","subscribers_url":"https://api.github.com/repos/thefourtheye/io.js/subscribers","subscription_url":"https://api.github.com/repos/thefourtheye/io.js/subscription","commits_url":"https://api.github.com/repos/thefourtheye/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefourtheye/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefourtheye/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefourtheye/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefourtheye/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/thefourtheye/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefourtheye/io.js/merges","archive_url":"https://api.github.com/repos/thefourtheye/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefourtheye/io.js/downloads","issues_url":"https://api.github.com/repos/thefourtheye/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/thefourtheye/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/thefourtheye/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/thefourtheye/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefourtheye/io.js/labels{/name}","releases_url":"https://api.github.com/repos/thefourtheye/io.js/releases{/id}","created_at":"2015-05-05T17:20:53Z","updated_at":"2015-05-05T17:20:56Z","pushed_at":"2015-08-19T14:19:15Z","git_url":"git://github.com/thefourtheye/io.js.git","ssh_url":"git@github.com:thefourtheye/io.js.git","clone_url":"https://github.com/thefourtheye/io.js.git","svn_url":"https://github.com/thefourtheye/io.js","homepage":"https://iojs.org","size":139984,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"71119284f99129482d658033223461e931121fd9","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Future Node.js releases will be from this repo.","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-08-19T18:54:17Z","pushed_at":"2015-08-19T18:12:48Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://iojs.org","size":193603,"stargazers_count":13466,"watchers_count":13466,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1103,"mirror_url":null,"open_issues_count":341,"forks":1103,"open_issues":341,"watchers":13466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/2349"},"html":{"href":"https://github.com/nodejs/node/pull/2349"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/2349"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/2349/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/2349/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/2349/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/7154613947c9bc4b5ce6db0e520a5896d0aab05b"}}}}