{"action":"closed","number":571,"pull_request":{"url":"https://api.github.com/repos/scopatz/xonsh/pulls/571","id":53653184,"html_url":"https://github.com/scopatz/xonsh/pull/571","diff_url":"https://github.com/scopatz/xonsh/pull/571.diff","patch_url":"https://github.com/scopatz/xonsh/pull/571.patch","issue_url":"https://api.github.com/repos/scopatz/xonsh/issues/571","number":571,"state":"closed","locked":false,"title":"Improvements for Completer: Names with Spaces, and Partial Strings","user":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"body":"This changeset is a long-overdue continuation of #72.  It implements a couple of fixes/changes for the completer, basically trying to mimic the way Windows cmd.exe handles quoted paths:\r\n* implements completion of partial strings (e.g, `\"name with spa<tab>` will now complete to include the full name, as well as the proper ending quote)\r\n* implements completion of full strings (e.g. `\"name with spaces/\"<tab>` will complete to show subdirectories of `name with spaces`, properly quoted [I think])\r\n\r\nAs it always has (modulo the issue in #181), it still wraps names containing spaces in quotes if they aren't already there.\r\n\r\nThe main reason I am marking as a work-in-progress is that I haven't yet gotten it to work in readline mode (nor have I tried yet).  Also, I'm not 100% sure I haven't broken something along the way.  Happy for other suggestions as well.","created_at":"2015-12-15T02:43:08Z","updated_at":"2015-12-19T00:57:38Z","closed_at":"2015-12-19T00:57:38Z","merged_at":"2015-12-19T00:57:38Z","merge_commit_sha":"6b7e5c9be039030d678e66415566c18b171bbe53","assignee":null,"milestone":{"url":"https://api.github.com/repos/scopatz/xonsh/milestones/2","html_url":"https://github.com/scopatz/xonsh/milestones/v0.3","labels_url":"https://api.github.com/repos/scopatz/xonsh/milestones/2/labels","id":1302567,"number":2,"title":"v0.3","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":127,"state":"open","created_at":"2015-09-12T18:28:59Z","updated_at":"2015-12-19T00:57:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/scopatz/xonsh/pulls/571/commits","review_comments_url":"https://api.github.com/repos/scopatz/xonsh/pulls/571/comments","review_comment_url":"https://api.github.com/repos/scopatz/xonsh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scopatz/xonsh/issues/571/comments","statuses_url":"https://api.github.com/repos/scopatz/xonsh/statuses/abe1e32076a12166015dfcb3f4aa598219569f99","head":{"label":"adqm:completer","ref":"completer","sha":"abe1e32076a12166015dfcb3f4aa598219569f99","user":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"repo":{"id":32187841,"name":"xonsh","full_name":"adqm/xonsh","owner":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adqm/xonsh","description":"xonsh is a Python-ish, BASHwards-compatible shell.","fork":true,"url":"https://api.github.com/repos/adqm/xonsh","forks_url":"https://api.github.com/repos/adqm/xonsh/forks","keys_url":"https://api.github.com/repos/adqm/xonsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adqm/xonsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adqm/xonsh/teams","hooks_url":"https://api.github.com/repos/adqm/xonsh/hooks","issue_events_url":"https://api.github.com/repos/adqm/xonsh/issues/events{/number}","events_url":"https://api.github.com/repos/adqm/xonsh/events","assignees_url":"https://api.github.com/repos/adqm/xonsh/assignees{/user}","branches_url":"https://api.github.com/repos/adqm/xonsh/branches{/branch}","tags_url":"https://api.github.com/repos/adqm/xonsh/tags","blobs_url":"https://api.github.com/repos/adqm/xonsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adqm/xonsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adqm/xonsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/adqm/xonsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adqm/xonsh/statuses/{sha}","languages_url":"https://api.github.com/repos/adqm/xonsh/languages","stargazers_url":"https://api.github.com/repos/adqm/xonsh/stargazers","contributors_url":"https://api.github.com/repos/adqm/xonsh/contributors","subscribers_url":"https://api.github.com/repos/adqm/xonsh/subscribers","subscription_url":"https://api.github.com/repos/adqm/xonsh/subscription","commits_url":"https://api.github.com/repos/adqm/xonsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/adqm/xonsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/adqm/xonsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/adqm/xonsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/adqm/xonsh/contents/{+path}","compare_url":"https://api.github.com/repos/adqm/xonsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adqm/xonsh/merges","archive_url":"https://api.github.com/repos/adqm/xonsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adqm/xonsh/downloads","issues_url":"https://api.github.com/repos/adqm/xonsh/issues{/number}","pulls_url":"https://api.github.com/repos/adqm/xonsh/pulls{/number}","milestones_url":"https://api.github.com/repos/adqm/xonsh/milestones{/number}","notifications_url":"https://api.github.com/repos/adqm/xonsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adqm/xonsh/labels{/name}","releases_url":"https://api.github.com/repos/adqm/xonsh/releases{/id}","created_at":"2015-03-14T00:10:49Z","updated_at":"2015-05-07T12:12:54Z","pushed_at":"2015-12-18T20:31:52Z","git_url":"git://github.com/adqm/xonsh.git","ssh_url":"git@github.com:adqm/xonsh.git","clone_url":"https://github.com/adqm/xonsh.git","svn_url":"https://github.com/adqm/xonsh","homepage":"http://xonsh.org","size":3148,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scopatz:master","ref":"master","sha":"795929ff0bb088326b1f8a4da5bcf89ed6467852","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"repo":{"id":29620400,"name":"xonsh","full_name":"scopatz/xonsh","owner":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scopatz/xonsh","description":"xonsh is a Python-ish, BASHwards-facing shell.","fork":false,"url":"https://api.github.com/repos/scopatz/xonsh","forks_url":"https://api.github.com/repos/scopatz/xonsh/forks","keys_url":"https://api.github.com/repos/scopatz/xonsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scopatz/xonsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scopatz/xonsh/teams","hooks_url":"https://api.github.com/repos/scopatz/xonsh/hooks","issue_events_url":"https://api.github.com/repos/scopatz/xonsh/issues/events{/number}","events_url":"https://api.github.com/repos/scopatz/xonsh/events","assignees_url":"https://api.github.com/repos/scopatz/xonsh/assignees{/user}","branches_url":"https://api.github.com/repos/scopatz/xonsh/branches{/branch}","tags_url":"https://api.github.com/repos/scopatz/xonsh/tags","blobs_url":"https://api.github.com/repos/scopatz/xonsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scopatz/xonsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scopatz/xonsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/scopatz/xonsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scopatz/xonsh/statuses/{sha}","languages_url":"https://api.github.com/repos/scopatz/xonsh/languages","stargazers_url":"https://api.github.com/repos/scopatz/xonsh/stargazers","contributors_url":"https://api.github.com/repos/scopatz/xonsh/contributors","subscribers_url":"https://api.github.com/repos/scopatz/xonsh/subscribers","subscription_url":"https://api.github.com/repos/scopatz/xonsh/subscription","commits_url":"https://api.github.com/repos/scopatz/xonsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/scopatz/xonsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/scopatz/xonsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/scopatz/xonsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/scopatz/xonsh/contents/{+path}","compare_url":"https://api.github.com/repos/scopatz/xonsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scopatz/xonsh/merges","archive_url":"https://api.github.com/repos/scopatz/xonsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scopatz/xonsh/downloads","issues_url":"https://api.github.com/repos/scopatz/xonsh/issues{/number}","pulls_url":"https://api.github.com/repos/scopatz/xonsh/pulls{/number}","milestones_url":"https://api.github.com/repos/scopatz/xonsh/milestones{/number}","notifications_url":"https://api.github.com/repos/scopatz/xonsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scopatz/xonsh/labels{/name}","releases_url":"https://api.github.com/repos/scopatz/xonsh/releases{/id}","created_at":"2015-01-21T22:05:27Z","updated_at":"2015-12-17T23:48:21Z","pushed_at":"2015-12-19T00:57:37Z","git_url":"git://github.com/scopatz/xonsh.git","ssh_url":"git@github.com:scopatz/xonsh.git","clone_url":"https://github.com/scopatz/xonsh.git","svn_url":"https://github.com/scopatz/xonsh","homepage":"http://xonsh.org","size":3860,"stargazers_count":612,"watchers_count":612,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":100,"forks":79,"open_issues":100,"watchers":612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/571"},"html":{"href":"https://github.com/scopatz/xonsh/pull/571"},"issue":{"href":"https://api.github.com/repos/scopatz/xonsh/issues/571"},"comments":{"href":"https://api.github.com/repos/scopatz/xonsh/issues/571/comments"},"review_comments":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/571/comments"},"review_comment":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/571/commits"},"statuses":{"href":"https://api.github.com/repos/scopatz/xonsh/statuses/abe1e32076a12166015dfcb3f4aa598219569f99"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"comments":10,"review_comments":16,"commits":24,"additions":240,"deletions":32,"changed_files":5}}