{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/25186592","id":25186592,"diff_hunk":"@@ -157,9 +154,39 @@\n     <DebugEngines>{2E36F1D4-B23C-435D-AB41-18E608940038}</DebugEngines>\n   </PropertyGroup>\n \n+  <Target Name=\"CheckTestCategories\"\n+          AfterTargets=\"Test\"\n+          Condition=\"'$(IsTestProject)'=='True' And '$(SkipTests)'!='True'\">\n+    <PropertyGroup>\n+      <!-- By default project has inner- and outer- loop tests. -->\n+      <TestCategories Condition=\"'$(TestCategories)'==''\">InnerLoop;OuterLoop</TestCategories>\n+    </PropertyGroup>\n+    <ItemGroup>\n+      <!-- Split semicolon separated list -->\n+      <TestCategoriesItems Include=\"$(TestCategories)\" />\n+      \n+      <!-- If category not found then list will be empty -->\n+      <InnerLoop Include=\"@(TestCategoriesItems)\" Condition=\"'%(TestCategoriesItems.Identity)'=='InnerLoop'\" />\n+      <OuterLoop Include=\"@(TestCategoriesItems)\" Condition=\"'%(TestCategoriesItems.Identity)'=='OuterLoop'\" />\n+    </ItemGroup>\n+    <PropertyGroup>\n+      <!-- If list not empty then category found -->\n+      <IsInnerLoop Condition=\"'@(InnerLoop)'!=''\">True</IsInnerLoop>\n+      <IsOuterLoop Condition=\"'@(OuterLoop)'!=''\">True</IsOuterLoop>\n+\n+      <!-- What categories of tests do we want to run by default  -->\n+      <RunInnerLoop Condition=\"'$(RunInnerLoop)'==''\">True</RunInnerLoop>\n+      \n+      <!-- Run tests only if we want to run tests of the given category and the test has this category -->\n+      <RunTestsForProject>False</RunTestsForProject>","path":"src/dir.targets","position":38,"original_position":38,"commit_id":"9081e66cb3f6bd86b6e1ada21e362d9ede53efe0","original_commit_id":"9081e66cb3f6bd86b6e1ada21e362d9ede53efe0","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"SkipTests is intended for an entire test/build run not for one project. RunTestsForProject is for just one project. ","created_at":"2015-02-23T18:13:38Z","updated_at":"2015-02-23T18:13:38Z","html_url":"https://github.com/dotnet/corefx/pull/961#discussion_r25186592","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/961","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/25186592"},"html":{"href":"https://github.com/dotnet/corefx/pull/961#discussion_r25186592"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/961"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/961","id":29663832,"html_url":"https://github.com/dotnet/corefx/pull/961","diff_url":"https://github.com/dotnet/corefx/pull/961.diff","patch_url":"https://github.com/dotnet/corefx/pull/961.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/961","number":961,"state":"open","locked":false,"title":"Add IsInnerLoopTestProject and IsOuterLoopTestProject property support during the build","user":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"Add properties to disable selected projects from Inner- or Outer- loop run. By default all projects are both Inner and Outer loop. You can disable it from particular run by explicitly setting it.","created_at":"2015-02-20T00:36:46Z","updated_at":"2015-02-23T18:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbc586396863a8e01a08eb81df95169f83916ffb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/961/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/961/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/961/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/9081e66cb3f6bd86b6e1ada21e362d9ede53efe0","head":{"label":"krwq:IsInnerOuterLoop","ref":"IsInnerOuterLoop","sha":"9081e66cb3f6bd86b6e1ada21e362d9ede53efe0","user":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"repo":{"id":26556399,"name":"corefx","full_name":"krwq/corefx","owner":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krwq/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/krwq/corefx","forks_url":"https://api.github.com/repos/krwq/corefx/forks","keys_url":"https://api.github.com/repos/krwq/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krwq/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krwq/corefx/teams","hooks_url":"https://api.github.com/repos/krwq/corefx/hooks","issue_events_url":"https://api.github.com/repos/krwq/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/krwq/corefx/events","assignees_url":"https://api.github.com/repos/krwq/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/krwq/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/krwq/corefx/tags","blobs_url":"https://api.github.com/repos/krwq/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krwq/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krwq/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/krwq/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krwq/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/krwq/corefx/languages","stargazers_url":"https://api.github.com/repos/krwq/corefx/stargazers","contributors_url":"https://api.github.com/repos/krwq/corefx/contributors","subscribers_url":"https://api.github.com/repos/krwq/corefx/subscribers","subscription_url":"https://api.github.com/repos/krwq/corefx/subscription","commits_url":"https://api.github.com/repos/krwq/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/krwq/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/krwq/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/krwq/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/krwq/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/krwq/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krwq/corefx/merges","archive_url":"https://api.github.com/repos/krwq/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krwq/corefx/downloads","issues_url":"https://api.github.com/repos/krwq/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/krwq/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/krwq/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/krwq/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krwq/corefx/labels{/name}","releases_url":"https://api.github.com/repos/krwq/corefx/releases{/id}","created_at":"2014-11-12T21:11:44Z","updated_at":"2014-12-12T21:52:55Z","pushed_at":"2015-02-20T21:11:34Z","git_url":"git://github.com/krwq/corefx.git","ssh_url":"git@github.com:krwq/corefx.git","clone_url":"https://github.com/krwq/corefx.git","svn_url":"https://github.com/krwq/corefx","homepage":"","size":10980,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"97c866909e564dd984c915cdca16220018674a0e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-02-23T17:39:00Z","pushed_at":"2015-02-23T17:39:00Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":22670,"stargazers_count":7027,"watchers_count":7027,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1277,"mirror_url":null,"open_issues_count":266,"forks":1277,"open_issues":266,"watchers":7027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/961"},"html":{"href":"https://github.com/dotnet/corefx/pull/961"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/961"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/961/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/961/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/961/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/9081e66cb3f6bd86b6e1ada21e362d9ede53efe0"}}}}