{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/71","labels_url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/71/comments","events_url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/71/events","html_url":"https://github.com/jupyter/docker-demo-images/pull/71","id":106216421,"number":71,"title":"Rebase on jupyter/minimal-notebook:4.0","user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-13T13:14:28Z","updated_at":"2015-09-13T19:34:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jupyter/docker-demo-images/pulls/71","html_url":"https://github.com/jupyter/docker-demo-images/pull/71","diff_url":"https://github.com/jupyter/docker-demo-images/pull/71.diff","patch_url":"https://github.com/jupyter/docker-demo-images/pull/71.patch"},"body":"@rgbkrk First crack at updating docker-demo-images to 4.0. Need many more eyes and testing, particularly against how it'll be run at tmpnb.org.\r\n\r\n### Key points\r\n\r\n* Now based on the `jupyter/minimal-notebook:4.0` image from docker-stacks to DRY\r\n* It builds to completion with all kernels showing when the notebook server starts. Fixes the various defects currently open against this repo like #63, #64, #68.\r\n* No version pinning throughout (yet).\r\n* Inverts the original Dockerfile install order so that site specific customizations come **after** the install of all the demo-wares. This change means site-specific install steps can later be split off as a subimage, with a Dockerfile inheritance chain like `jupyter/minimal-notebook -> jupyter/demo -> jupyter/tmpnb-demo`. Then other folks can simply start `FROM jupyter/demo` and add their own site customizations without having to rebuild the massive middle image.\r\n  * But for the time being, I haven't done that split so there's just one Dockerfile. Trying to KISS until everything works. Splitting is an easy later refactor.\r\n\r\nI added comments galore throughout the Dockerfile.\r\n\r\n### Known problems\r\n\r\n* It won't work if the `static_url_prefix` in the jupyter config is in play because the CDN site does not have the piece parts yet. So for testing, I simply removed that part of the config for now. (And since it's near the end of the Dockerfile now, I didn't have to wait 3 hours to test again! Yay!)\r\n* The IHaskell widget demos don't work. There's kernel comm errors in the JS log. I did have to remove the version pinning on ihaskell-widgets to get the install to work but it looks that version installed anyway (and might be the only released version anyway). Briefly perusing the IHaskell commits, maybe this is still a WIP for 4.0 compatibility? Or simply unreleased? /cc @gibiansky @sumitsahrawat \r\n* The Julia logo doesn't appear. JS console reports `http://mydomain:8889/kernelspecs/julia-0.3/logo-64x64.png Failed to load resource: the server responded with 404` Not sure why considering the logo is right where it needs to be. For comparison, the python2 logo is in its proper spot and loads just fine:\r\n\r\n```\r\njovyan@266f76e05efd:~/.local/share/jupyter/kernels/julia-0.3$ ls -l                     \r\ntotal 12                                                                                \r\n-rw-r--r-- 1 jovyan users  195 Sep 13 05:00 kernel.json                                 \r\n-rw-r--r-- 1 jovyan users 1310 Sep 13 05:00 logo-32x32.png                              \r\n-rw-r--r-- 1 jovyan users 2843 Sep 13 05:00 logo-64x64.png                              \r\njovyan@266f76e05efd:~/.local/share/jupyter/kernels/julia-0.3$ cd ../python2                              \r\njovyan@266f76e05efd:~/.local/share/jupyter/kernels/python2$ ls -l                       \r\ntotal 12                                                                                \r\n-rw-r--r-- 1 jovyan users  168 Sep 13 04:58 kernel.json                                 \r\n-rw-rw-r-- 1 jovyan users 1084 May  8 20:15 logo-32x32.png                              \r\n-rw-rw-r-- 1 jovyan users 2180 May  8 20:15 logo-64x64.png                              \r\n```\r\n\r\n### Unknowns\r\n\r\n* Does it work with tmpnb? I know jupyter/minimal-notebook does because I've tried it recently.\r\n* Anything else broken? I didn't test every kernel with every sample notebook.\r\n\r\n### DevOps impact\r\n\r\n* The jupyter static dir is now `/opt/conda/lib/python3.4/site-packages/notebook/static/custom/` which appears to be nginx mounted according to the original Dockerfile comments. That'll need to change on deploy."},"comment":{"url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/comments/139911546","html_url":"https://github.com/jupyter/docker-demo-images/pull/71#issuecomment-139911546","issue_url":"https://api.github.com/repos/jupyter/docker-demo-images/issues/71","id":139911546,"user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"created_at":"2015-09-13T19:34:58Z","updated_at":"2015-09-13T19:34:58Z","body":"One deprecation note: should we migrate the tmpnb example to using jupyter/minimal-notebook and delete the jupyter/minimal image from docker hub? The alternative is making jupyter/minimal just \"FROM jupyter/minimal-notebook\" or set up hooks to create minimal from the same spot."}}