{"action":"created","issue":{"url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/237","labels_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/237/comments","events_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/237/events","html_url":"https://github.com/sandstorm-io/capnproto/pull/237","id":103302608,"number":237,"title":"Fix for `CAPNP_GENERATE_CPP` function output path mismatch","user":{"login":"MarPiRK","id":1504981,"avatar_url":"https://avatars.githubusercontent.com/u/1504981?v=3","gravatar_id":"","url":"https://api.github.com/users/MarPiRK","html_url":"https://github.com/MarPiRK","followers_url":"https://api.github.com/users/MarPiRK/followers","following_url":"https://api.github.com/users/MarPiRK/following{/other_user}","gists_url":"https://api.github.com/users/MarPiRK/gists{/gist_id}","starred_url":"https://api.github.com/users/MarPiRK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarPiRK/subscriptions","organizations_url":"https://api.github.com/users/MarPiRK/orgs","repos_url":"https://api.github.com/users/MarPiRK/repos","events_url":"https://api.github.com/users/MarPiRK/events{/privacy}","received_events_url":"https://api.github.com/users/MarPiRK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2015-08-26T15:46:34Z","updated_at":"2015-11-05T14:35:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/capnproto/pulls/237","html_url":"https://github.com/sandstorm-io/capnproto/pull/237","diff_url":"https://github.com/sandstorm-io/capnproto/pull/237.diff","patch_url":"https://github.com/sandstorm-io/capnproto/pull/237.patch"},"body":"Before, when no `CAPNPC_OUTPUT_DIR` was defined, output path was ambiguous (set to `.` for custom command).\r\n`SOURCES` and `HEADERS` were statically set to input file name (plus suffix) without concidering where custom command will place generated files.\r\nNow if no `CAPNPC_OUTPUT_DIR` is defined, it's set by default to `CMAKE_CURRENT_BINARY_DIR` (this is basically `.`) and prevents any ambiguity."},"comment":{"url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/comments/154077602","html_url":"https://github.com/sandstorm-io/capnproto/pull/237#issuecomment-154077602","issue_url":"https://api.github.com/repos/sandstorm-io/capnproto/issues/237","id":154077602,"user":{"login":"joshuawarner32","id":182686,"avatar_url":"https://avatars.githubusercontent.com/u/182686?v=3","gravatar_id":"","url":"https://api.github.com/users/joshuawarner32","html_url":"https://github.com/joshuawarner32","followers_url":"https://api.github.com/users/joshuawarner32/followers","following_url":"https://api.github.com/users/joshuawarner32/following{/other_user}","gists_url":"https://api.github.com/users/joshuawarner32/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuawarner32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuawarner32/subscriptions","organizations_url":"https://api.github.com/users/joshuawarner32/orgs","repos_url":"https://api.github.com/users/joshuawarner32/repos","events_url":"https://api.github.com/users/joshuawarner32/events{/privacy}","received_events_url":"https://api.github.com/users/joshuawarner32/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T14:35:19Z","updated_at":"2015-11-05T14:35:19Z","body":"@pqu - is it possible to get this merged?  IMHO, this does improve the general state of affairs, and while it's not perfect, we can always come back and _improve it again_ at a later date.  I don't want to see this just bitrot."}}