{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/435","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/435/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/435/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/435/events","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/435","id":70006777,"number":435,"title":"Add waterfall layout into ASCollectionView","user":{"login":"xujim","id":3032016,"avatar_url":"https://avatars.githubusercontent.com/u/3032016?v=3","gravatar_id":"","url":"https://api.github.com/users/xujim","html_url":"https://github.com/xujim","followers_url":"https://api.github.com/users/xujim/followers","following_url":"https://api.github.com/users/xujim/following{/other_user}","gists_url":"https://api.github.com/users/xujim/gists{/gist_id}","starred_url":"https://api.github.com/users/xujim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xujim/subscriptions","organizations_url":"https://api.github.com/users/xujim/orgs","repos_url":"https://api.github.com/users/xujim/repos","events_url":"https://api.github.com/users/xujim/events{/privacy}","received_events_url":"https://api.github.com/users/xujim/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels/pr%20%E2%80%94%C2%A0revision%20needed","name":"pr — revision needed","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-22T02:52:21Z","updated_at":"2015-06-28T05:02:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/435","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/435","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/435.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/435.patch"},"body":"Implemented a waterfall layout for ASCollectionView, which support three type item append mode. \r\nHowever, it has following limitation:\r\n1, The shortest item append mode doesn't support insert node operation\r\n2, Not incorporate into existing ASCollectionView due to its initWithFrame function is hardcoded to support Flowlayout only.\r\n\r\nIf this changes was approved, we need to extend ASCollectionView to support more type of layout."},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/116193476","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/435#issuecomment-116193476","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/435","id":116193476,"user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"created_at":"2015-06-28T05:02:42Z","updated_at":"2015-06-28T05:02:42Z","body":"@xujim, check out the master branch for these changes.  Namely, there is now ASCollectionViewLayoutController, which allows usage of any UICollectionViewLayout with ASCollectionView (no longer flow layouts only).\r\n\r\nIn thinking about this, it is possible that your implementation is more efficient than it could otherwise be if contained in a UICollectionViewLayout because it has a more specifically targeted API for usage with ASDK.  That said, I think it's important to better understand that impact; it may be very small, in which case we should prefer providing a UICollectionViewLayout implementation.\r\n\r\nLet me know if you plan to spend any further time here.  If you'll be unavailable for a while, we can let this sit or save the code for follow-up in a Github Issue."}}