{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/33999161","id":33999161,"diff_hunk":"@@ -158,13 +137,38 @@ def SetVmSpecDefaults(cls, vm_spec):\n       region = vm_spec.zone[:-1]\n       vm_spec.image = cls._GetDefaultImage(vm_spec.machine_type, region)\n \n-  @staticmethod\n-  def _GetDefaultImage(machine_type, region):\n+  @classmethod\n+  def _GetDefaultImage(cls, machine_type, region):\n     \"\"\"Returns the default image given the machine type and region.\n \n     If no default is configured, this will return None.\n     \"\"\"\n-    return None\n+    if cls.IMAGE_NAME_FILTER is None:\n+      return None\n+\n+    prefix = machine_type.split('.')[0]\n+    virt_type = 'paravirtual' if prefix in NON_HVM_PREFIXES else 'hvm'\n+\n+    describe_cmd = util.AWS_PREFIX + [\n+        '--region=%s' % region,\n+        'ec2',\n+        'describe-images',\n+        '--query', 'Images[*].{Name:Name,ImageId:ImageId}',\n+        '--filters',\n+        'Name=name,Values=%s' % cls.IMAGE_NAME_FILTER,\n+        'Name=block-device-mapping.volume-type,Values=%s' %\n+        cls.DEFAULT_ROOT_DISK_TYPE,","path":"perfkitbenchmarker/aws/aws_virtual_machine.py","position":66,"original_position":66,"commit_id":"54d8c723216447be663d4deed3e9fd48f81d739b","original_commit_id":"54d8c723216447be663d4deed3e9fd48f81d739b","user":{"login":"klausw","id":1392351,"avatar_url":"https://avatars.githubusercontent.com/u/1392351?v=3","gravatar_id":"","url":"https://api.github.com/users/klausw","html_url":"https://github.com/klausw","followers_url":"https://api.github.com/users/klausw/followers","following_url":"https://api.github.com/users/klausw/following{/other_user}","gists_url":"https://api.github.com/users/klausw/gists{/gist_id}","starred_url":"https://api.github.com/users/klausw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausw/subscriptions","organizations_url":"https://api.github.com/users/klausw/orgs","repos_url":"https://api.github.com/users/klausw/repos","events_url":"https://api.github.com/users/klausw/events{/privacy}","received_events_url":"https://api.github.com/users/klausw/received_events","type":"User","site_admin":false},"body":"Shouldn't this be indented? Looks a bit odd, but I'll let flake8 decide.","created_at":"2015-07-07T00:46:38Z","updated_at":"2015-07-07T00:46:38Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364#discussion_r33999161","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/33999161"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364#discussion_r33999161"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364","id":39321572,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/364","number":364,"state":"open","locked":false,"title":"Use 'describe-images' to get ami ids","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"body":"Instead of keeping track of amis, use 'describe-images' to get an appropriate one if the image is not specified","created_at":"2015-07-06T23:27:29Z","updated_at":"2015-07-07T00:46:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bf7c16e9d06b93d27d96be500328c5fdb89414c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/364/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/54d8c723216447be663d4deed3e9fd48f81d739b","head":{"label":"ehankland:aws","ref":"aws","sha":"54d8c723216447be663d4deed3e9fd48f81d739b","user":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"repo":{"id":36402001,"name":"PerfKitBenchmarker","full_name":"ehankland/PerfKitBenchmarker","owner":{"login":"ehankland","id":8193699,"avatar_url":"https://avatars.githubusercontent.com/u/8193699?v=3","gravatar_id":"","url":"https://api.github.com/users/ehankland","html_url":"https://github.com/ehankland","followers_url":"https://api.github.com/users/ehankland/followers","following_url":"https://api.github.com/users/ehankland/following{/other_user}","gists_url":"https://api.github.com/users/ehankland/gists{/gist_id}","starred_url":"https://api.github.com/users/ehankland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehankland/subscriptions","organizations_url":"https://api.github.com/users/ehankland/orgs","repos_url":"https://api.github.com/users/ehankland/repos","events_url":"https://api.github.com/users/ehankland/events{/privacy}","received_events_url":"https://api.github.com/users/ehankland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehankland/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/ehankland/PerfKitBenchmarker/releases{/id}","created_at":"2015-05-27T23:24:42Z","updated_at":"2015-05-27T23:24:43Z","pushed_at":"2015-07-07T00:44:36Z","git_url":"git://github.com/ehankland/PerfKitBenchmarker.git","ssh_url":"git@github.com:ehankland/PerfKitBenchmarker.git","clone_url":"https://github.com/ehankland/PerfKitBenchmarker.git","svn_url":"https://github.com/ehankland/PerfKitBenchmarker","homepage":"","size":2392,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:dev","ref":"dev","sha":"6672b60a0aeb6ae2e6d9e6d622d2b6ef095a0c01","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks are not tuned (i.e. use defaults) to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","created_at":"2014-07-17T17:23:26Z","updated_at":"2015-07-02T19:06:53Z","pushed_at":"2015-07-07T00:44:48Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"","size":150367,"stargazers_count":458,"watchers_count":458,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":78,"forks":56,"open_issues":78,"watchers":458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/364"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/364"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/54d8c723216447be663d4deed3e9fd48f81d739b"}}}}