{"action":"opened","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1021","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1021/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1021/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1021/events","html_url":"https://github.com/PCSX2/pcsx2/issues/1021","id":120632301,"number":1021,"title":"Clang and others unused variable warning","user":{"login":"willkuer","id":11938782,"avatar_url":"https://avatars.githubusercontent.com/u/11938782?v=3","gravatar_id":"","url":"https://api.github.com/users/willkuer","html_url":"https://github.com/willkuer","followers_url":"https://api.github.com/users/willkuer/followers","following_url":"https://api.github.com/users/willkuer/following{/other_user}","gists_url":"https://api.github.com/users/willkuer/gists{/gist_id}","starred_url":"https://api.github.com/users/willkuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkuer/subscriptions","organizations_url":"https://api.github.com/users/willkuer/orgs","repos_url":"https://api.github.com/users/willkuer/repos","events_url":"https://api.github.com/users/willkuer/events{/privacy}","received_events_url":"https://api.github.com/users/willkuer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-06T12:47:31Z","updated_at":"2015-12-06T12:47:31Z","closed_at":null,"body":"Clang shows a lot of unused parameters (-Wunused-parameter ~ 2800). This spams the output and possibly is also not nice to have in production code. Is there interest to tackle this?\r\n\r\nIf yes, what would be the preferred way?\r\n\r\n1. casting unused variables to void\r\n    #define Unused(var) ((void)var)\r\n\r\n2. Omiting variable name in function definition\r\n    void function(type1 used, type2 unused)\r\nto\r\n    void function(type1 used, type2 /*unused*/)\r\n\r\n3. Removing variable from function definition and possibly adjust all caller\r\n    void function(type1 used, type2 unused)\r\nto\r\n    void function(type1 used)"}}