{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/23301896","id":23301896,"diff_hunk":"@@ -126,8 +126,17 @@ def addFileToSuite(self, eclfile):\n             versions = eclfile.getVersions()\n             versionId = 1\n             for version in versions:\n-                files.append({'basename':basename, 'version':version,  'id':versionId })\n-                versionId += 1\n+                if 'no'+self.name in version:\n+                    # Exclude it from this target\n+                    pass\n+                else:\n+                    # Remove exclusion key(s) from version string\n+                    config = getConfig();","path":"testing/regress/hpcc/regression/suite.py","position":20,"original_position":20,"commit_id":"5f70022ab5a1b1146b8984692ca1cfdb27e975ef","original_commit_id":"5f70022ab5a1b1146b8984692ca1cfdb27e975ef","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"I don't think it is - it looks like two concepts have got confused.\r\n\r\nFor example I have two hthor clusters on my machine - hthor and hthor2\r\n\r\nIf I do not have hthor2 in the cluster list I get the following error:\r\n\r\n```\r\ngavin:~/dev/hpcc/testing/regress$ ./ecl-test query 'bcd1.ecl' -t=hthor2\r\n[Failure] 1. Unknown target cluster:'hthor2'!\r\n[Error] Error (4000): Unknown cluster! \r\n^CTraceback (most recent call last):\r\n  File \"./ecl-test\", line 274, in <module>\r\n    regressMain.main()\r\n  File \"./ecl-test\", line 269, in main\r\n    self.regress.StopTimeoutThread()\r\n ```\r\n\r\nIf I add //nohthor to a test and run \r\n```./ecl-test query test.ecl -t=hthor```\r\nthen it isn't executed.\r\n\r\nBut if I run \r\n\r\nIf I add //nohthor to a test and run \r\n```./ecl-test query test.ecl -t=hthor```\r\nthen it is.\r\n\r\nThat isn't correct.  The cluster is the name that is supplied to the -t=xxx.  The value used in //nohthor etc. is the platform type (which probably needs to be derived from the environment, or added to the cluster information).\r\n","created_at":"2015-01-21T14:27:09Z","updated_at":"2015-01-21T14:27:09Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861#discussion_r23301896","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/23301896"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861#discussion_r23301896"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861","id":27755578,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6861","number":6861,"state":"open","locked":false,"title":"HPCC-12862 Need to support nothor and noroxie etc. as option on //version","user":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"body":"\r\nAdd code to process exclusion(s) defined in //version tag\r\n\r\nUpdate README.rst\r\n\r\nSigned-off-by: Attila Vamos <attila.vamos@gmail.com>","created_at":"2015-01-21T12:25:41Z","updated_at":"2015-01-21T14:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4a665cccc2c79da65a6c4a37d8f7501014c026a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6861/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5f70022ab5a1b1146b8984692ca1cfdb27e975ef","head":{"label":"AttilaVamos:HPCC-12862-improvement","ref":"HPCC-12862-improvement","sha":"5f70022ab5a1b1146b8984692ca1cfdb27e975ef","user":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"repo":{"id":9005214,"name":"HPCC-Platform","full_name":"AttilaVamos/HPCC-Platform","owner":{"login":"AttilaVamos","id":3518475,"avatar_url":"https://avatars.githubusercontent.com/u/3518475?v=3","gravatar_id":"","url":"https://api.github.com/users/AttilaVamos","html_url":"https://github.com/AttilaVamos","followers_url":"https://api.github.com/users/AttilaVamos/followers","following_url":"https://api.github.com/users/AttilaVamos/following{/other_user}","gists_url":"https://api.github.com/users/AttilaVamos/gists{/gist_id}","starred_url":"https://api.github.com/users/AttilaVamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttilaVamos/subscriptions","organizations_url":"https://api.github.com/users/AttilaVamos/orgs","repos_url":"https://api.github.com/users/AttilaVamos/repos","events_url":"https://api.github.com/users/AttilaVamos/events{/privacy}","received_events_url":"https://api.github.com/users/AttilaVamos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AttilaVamos/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform","forks_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/AttilaVamos/HPCC-Platform/releases{/id}","created_at":"2013-03-25T12:04:47Z","updated_at":"2015-01-21T11:35:35Z","pushed_at":"2015-01-21T12:24:35Z","git_url":"git://github.com/AttilaVamos/HPCC-Platform.git","ssh_url":"git@github.com:AttilaVamos/HPCC-Platform.git","clone_url":"https://github.com/AttilaVamos/HPCC-Platform.git","svn_url":"https://github.com/AttilaVamos/HPCC-Platform","homepage":"track.hpccsystems.com","size":134300,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"f6ad1a0763fd8ee4f493313e87bbe965c705c786","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-01-21T12:55:05Z","pushed_at":"2015-01-21T12:55:05Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":263022,"stargazers_count":240,"watchers_count":240,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":423,"forks":96,"open_issues":423,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/6861"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6861"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/6861/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/6861/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5f70022ab5a1b1146b8984692ca1cfdb27e975ef"}}}}