{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31351680","id":31351680,"diff_hunk":"@@ -0,0 +1,97 @@\n+﻿","path":"src/System.Composition.sln","position":1,"original_position":1,"commit_id":"8620ba7e63ea10d5fad82dffe538388bf79a50a3","original_commit_id":"8620ba7e63ea10d5fad82dffe538388bf79a50a3","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars.githubusercontent.com/u/1376924?v=3","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"I'm not a fan of keeping this directly in \\src, all the other solution files are inside a subfolder and it looks much cleaner. Can we move this to \\src\\System.Composition?","created_at":"2015-05-29T18:31:20Z","updated_at":"2015-05-29T18:31:20Z","html_url":"https://github.com/dotnet/corefx/pull/1851#discussion_r31351680","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/1851","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31351680"},"html":{"href":"https://github.com/dotnet/corefx/pull/1851#discussion_r31351680"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1851"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1851","id":36355427,"html_url":"https://github.com/dotnet/corefx/pull/1851","diff_url":"https://github.com/dotnet/corefx/pull/1851.diff","patch_url":"https://github.com/dotnet/corefx/pull/1851.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1851","number":1851,"state":"open","locked":false,"title":"Add System.Composition","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"body":"This PR adds System.Composition to CoreFx.\r\n\r\nSystem.Composition consists of 5 different assemblies:\r\n\r\n- System.Composition.AttributedModel\r\n- System.Composition.Convention\r\n- System.Composition.Hosting\r\n- System.Composition.Runtime\r\n- System.Composition.TypedParts\r\n\r\nThere is a general test project for all the assemblies, and another one specific to System.Composition.Convention.  There are also two assemblies referenced by the general test project, and a project for perf testing.\r\n\r\nI've created separate folders under /src for each of the five main assemblies, and put the general test project, the assemblies it references, and the perf test project in /src/System.Composition.  I've put the solution file (System.Composition.sln) directly under /src.\r\n\r\nI think this follows the current repository structure as closely as possible.  Perhaps it makes more sense to put everything here under a System.Composition folder.  Feedback is welcome.","created_at":"2015-05-27T22:27:06Z","updated_at":"2015-05-29T18:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22cb0035321cb78736fdf768877808c15db2a22b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1851/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1851/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1851/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8620ba7e63ea10d5fad82dffe538388bf79a50a3","head":{"label":"dsplaisted:AddSystemComposition","ref":"AddSystemComposition","sha":"8620ba7e63ea10d5fad82dffe538388bf79a50a3","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"repo":{"id":27615066,"name":"corefx","full_name":"dsplaisted/corefx","owner":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsplaisted/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/dsplaisted/corefx","forks_url":"https://api.github.com/repos/dsplaisted/corefx/forks","keys_url":"https://api.github.com/repos/dsplaisted/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsplaisted/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsplaisted/corefx/teams","hooks_url":"https://api.github.com/repos/dsplaisted/corefx/hooks","issue_events_url":"https://api.github.com/repos/dsplaisted/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dsplaisted/corefx/events","assignees_url":"https://api.github.com/repos/dsplaisted/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dsplaisted/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dsplaisted/corefx/tags","blobs_url":"https://api.github.com/repos/dsplaisted/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsplaisted/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsplaisted/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsplaisted/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsplaisted/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dsplaisted/corefx/languages","stargazers_url":"https://api.github.com/repos/dsplaisted/corefx/stargazers","contributors_url":"https://api.github.com/repos/dsplaisted/corefx/contributors","subscribers_url":"https://api.github.com/repos/dsplaisted/corefx/subscribers","subscription_url":"https://api.github.com/repos/dsplaisted/corefx/subscription","commits_url":"https://api.github.com/repos/dsplaisted/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsplaisted/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsplaisted/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsplaisted/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsplaisted/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dsplaisted/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsplaisted/corefx/merges","archive_url":"https://api.github.com/repos/dsplaisted/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsplaisted/corefx/downloads","issues_url":"https://api.github.com/repos/dsplaisted/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dsplaisted/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dsplaisted/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dsplaisted/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsplaisted/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dsplaisted/corefx/releases{/id}","created_at":"2014-12-05T23:42:13Z","updated_at":"2015-01-30T00:16:06Z","pushed_at":"2015-05-29T17:24:33Z","git_url":"git://github.com/dsplaisted/corefx.git","ssh_url":"git@github.com:dsplaisted/corefx.git","clone_url":"https://github.com/dsplaisted/corefx.git","svn_url":"https://github.com/dsplaisted/corefx","homepage":"","size":19305,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9246c6a74947f7ab372972ef505c0168c47fe2ad","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-05-28T19:28:00Z","pushed_at":"2015-05-29T17:36:51Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":47763,"stargazers_count":7846,"watchers_count":7846,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1582,"mirror_url":null,"open_issues_count":397,"forks":1582,"open_issues":397,"watchers":7846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1851"},"html":{"href":"https://github.com/dotnet/corefx/pull/1851"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1851"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1851/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1851/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1851/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8620ba7e63ea10d5fad82dffe538388bf79a50a3"}}}}