{"action":"created","comment":{"url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments/40274554","id":40274554,"diff_hunk":"@@ -341,20 +341,17 @@ def set_volume_choices(self):\n         self.volume_id.choices = choices\n \n     @staticmethod\n-    def suggest_next_device_name(request, instance):\n-        cloud_type = request.session.get('cloud_type')\n+    def suggest_next_device_name(cloud_type, mappings):","path":"eucaconsole/forms/instances.py","position":6,"original_position":6,"commit_id":"de51581f85ec114a3bcb0ce8e893e55835dfce70","original_commit_id":"de51581f85ec114a3bcb0ce8e893e55835dfce70","user":{"login":"kamalgill","id":133923,"avatar_url":"https://avatars.githubusercontent.com/u/133923?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalgill","html_url":"https://github.com/kamalgill","followers_url":"https://api.github.com/users/kamalgill/followers","following_url":"https://api.github.com/users/kamalgill/following{/other_user}","gists_url":"https://api.github.com/users/kamalgill/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalgill/subscriptions","organizations_url":"https://api.github.com/users/kamalgill/orgs","repos_url":"https://api.github.com/users/kamalgill/repos","events_url":"https://api.github.com/users/kamalgill/events{/privacy}","received_events_url":"https://api.github.com/users/kamalgill/received_events","type":"User","site_admin":false},"body":"@coyote240:  Since we've changed the method signature here, we'll also need to update line 329 in forms/instances.py...\r\n `self.device.data = AttachVolumeForm.suggest_next_device_name(request, instance)`","created_at":"2015-09-24T00:22:27Z","updated_at":"2015-09-24T00:22:27Z","html_url":"https://github.com/eucalyptus/eucaconsole/pull/1585#discussion_r40274554","pull_request_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585","_links":{"self":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments/40274554"},"html":{"href":"https://github.com/eucalyptus/eucaconsole/pull/1585#discussion_r40274554"},"pull_request":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585"}}},"pull_request":{"url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585","id":45434618,"html_url":"https://github.com/eucalyptus/eucaconsole/pull/1585","diff_url":"https://github.com/eucalyptus/eucaconsole/pull/1585.diff","patch_url":"https://github.com/eucalyptus/eucaconsole/pull/1585.patch","issue_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/1585","number":1585,"state":"open","locked":false,"title":"GUI-2016 Utilize existing service to deliver suggested device mapping…","user":{"login":"coyote240","id":661351,"avatar_url":"https://avatars.githubusercontent.com/u/661351?v=3","gravatar_id":"","url":"https://api.github.com/users/coyote240","html_url":"https://github.com/coyote240","followers_url":"https://api.github.com/users/coyote240/followers","following_url":"https://api.github.com/users/coyote240/following{/other_user}","gists_url":"https://api.github.com/users/coyote240/gists{/gist_id}","starred_url":"https://api.github.com/users/coyote240/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyote240/subscriptions","organizations_url":"https://api.github.com/users/coyote240/orgs","repos_url":"https://api.github.com/users/coyote240/repos","events_url":"https://api.github.com/users/coyote240/events{/privacy}","received_events_url":"https://api.github.com/users/coyote240/received_events","type":"User","site_admin":false},"body":"https://eucalyptus.atlassian.net/browse/GUI-2016\r\n\r\nAddresses bug by reusing an existing service.  Modified the service slightly to loosen the coupling just a bit and introduce a usage pattern where a new path may be recommended for an instance without an ID - a new instance.","created_at":"2015-09-18T18:00:32Z","updated_at":"2015-09-24T00:22:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfcc9cbccd7b4a2d7851aa86f2b43182c2497afb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/1585/comments","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/de51581f85ec114a3bcb0ce8e893e55835dfce70","head":{"label":"eucalyptus:GUI-2016","ref":"GUI-2016","sha":"de51581f85ec114a3bcb0ce8e893e55835dfce70","user":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"repo":{"id":13843551,"name":"eucaconsole","full_name":"eucalyptus/eucaconsole","owner":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eucalyptus/eucaconsole","description":"Eucalyptus Management Console","fork":false,"url":"https://api.github.com/repos/eucalyptus/eucaconsole","forks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/forks","keys_url":"https://api.github.com/repos/eucalyptus/eucaconsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eucalyptus/eucaconsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eucalyptus/eucaconsole/teams","hooks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/hooks","issue_events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/events{/number}","events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/events","assignees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/assignees{/user}","branches_url":"https://api.github.com/repos/eucalyptus/eucaconsole/branches{/branch}","tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/tags","blobs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/{sha}","languages_url":"https://api.github.com/repos/eucalyptus/eucaconsole/languages","stargazers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/stargazers","contributors_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contributors","subscribers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscribers","subscription_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscription","commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contents/{+path}","compare_url":"https://api.github.com/repos/eucalyptus/eucaconsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eucalyptus/eucaconsole/merges","archive_url":"https://api.github.com/repos/eucalyptus/eucaconsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eucalyptus/eucaconsole/downloads","issues_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues{/number}","pulls_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls{/number}","milestones_url":"https://api.github.com/repos/eucalyptus/eucaconsole/milestones{/number}","notifications_url":"https://api.github.com/repos/eucalyptus/eucaconsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eucalyptus/eucaconsole/labels{/name}","releases_url":"https://api.github.com/repos/eucalyptus/eucaconsole/releases{/id}","created_at":"2013-10-24T20:31:49Z","updated_at":"2015-08-25T19:47:06Z","pushed_at":"2015-09-23T23:36:27Z","git_url":"git://github.com/eucalyptus/eucaconsole.git","ssh_url":"git@github.com:eucalyptus/eucaconsole.git","clone_url":"https://github.com/eucalyptus/eucaconsole.git","svn_url":"https://github.com/eucalyptus/eucaconsole","homepage":"","size":47323,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":9,"default_branch":"master"}},"base":{"label":"eucalyptus:master","ref":"master","sha":"a04b05ac0dc76144af2f0b78f22cb2d384790739","user":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"repo":{"id":13843551,"name":"eucaconsole","full_name":"eucalyptus/eucaconsole","owner":{"login":"eucalyptus","id":808244,"avatar_url":"https://avatars.githubusercontent.com/u/808244?v=3","gravatar_id":"","url":"https://api.github.com/users/eucalyptus","html_url":"https://github.com/eucalyptus","followers_url":"https://api.github.com/users/eucalyptus/followers","following_url":"https://api.github.com/users/eucalyptus/following{/other_user}","gists_url":"https://api.github.com/users/eucalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/eucalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eucalyptus/subscriptions","organizations_url":"https://api.github.com/users/eucalyptus/orgs","repos_url":"https://api.github.com/users/eucalyptus/repos","events_url":"https://api.github.com/users/eucalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/eucalyptus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eucalyptus/eucaconsole","description":"Eucalyptus Management Console","fork":false,"url":"https://api.github.com/repos/eucalyptus/eucaconsole","forks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/forks","keys_url":"https://api.github.com/repos/eucalyptus/eucaconsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eucalyptus/eucaconsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eucalyptus/eucaconsole/teams","hooks_url":"https://api.github.com/repos/eucalyptus/eucaconsole/hooks","issue_events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/events{/number}","events_url":"https://api.github.com/repos/eucalyptus/eucaconsole/events","assignees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/assignees{/user}","branches_url":"https://api.github.com/repos/eucalyptus/eucaconsole/branches{/branch}","tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/tags","blobs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/{sha}","languages_url":"https://api.github.com/repos/eucalyptus/eucaconsole/languages","stargazers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/stargazers","contributors_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contributors","subscribers_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscribers","subscription_url":"https://api.github.com/repos/eucalyptus/eucaconsole/subscription","commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/eucalyptus/eucaconsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/eucalyptus/eucaconsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/eucalyptus/eucaconsole/contents/{+path}","compare_url":"https://api.github.com/repos/eucalyptus/eucaconsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eucalyptus/eucaconsole/merges","archive_url":"https://api.github.com/repos/eucalyptus/eucaconsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eucalyptus/eucaconsole/downloads","issues_url":"https://api.github.com/repos/eucalyptus/eucaconsole/issues{/number}","pulls_url":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls{/number}","milestones_url":"https://api.github.com/repos/eucalyptus/eucaconsole/milestones{/number}","notifications_url":"https://api.github.com/repos/eucalyptus/eucaconsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eucalyptus/eucaconsole/labels{/name}","releases_url":"https://api.github.com/repos/eucalyptus/eucaconsole/releases{/id}","created_at":"2013-10-24T20:31:49Z","updated_at":"2015-08-25T19:47:06Z","pushed_at":"2015-09-23T23:36:27Z","git_url":"git://github.com/eucalyptus/eucaconsole.git","ssh_url":"git@github.com:eucalyptus/eucaconsole.git","clone_url":"https://github.com/eucalyptus/eucaconsole.git","svn_url":"https://github.com/eucalyptus/eucaconsole","homepage":"","size":47323,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585"},"html":{"href":"https://github.com/eucalyptus/eucaconsole/pull/1585"},"issue":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/1585"},"comments":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/eucalyptus/eucaconsole/statuses/de51581f85ec114a3bcb0ce8e893e55835dfce70"}}}}