{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/41175819","id":41175819,"diff_hunk":"@@ -0,0 +1,17 @@\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one or more\n+# contributor license agreements.  See the NOTICE file distributed with\n+# this work for additional information regarding copyright ownership.\n+# The ASF licenses this file to You under the Apache License, Version 2.0\n+# (the \"License\"); you may not use this file except in compliance with\n+# the License.  You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+__version__ = '1.5.0'","path":"python/pyspark/pyspark_version.py","position":17,"original_position":17,"commit_id":"7ad1a8d629eb63d4dc71d7b05d634a4951826aad","original_commit_id":"a288923d7600055b9af346ed74f88c7be598fbb1","user":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"body":"I think it's error-prone to have multiple copy of version in different places, if someone forget to update his, PySpark will break (even within the repo).\r\n\r\nI'd vote for generate the version during generating PyPI package. If PySpark came along with Spark, we don't need this check (at least it shouldn't fail or slow).","created_at":"2015-10-05T18:00:15Z","updated_at":"2015-10-05T18:00:15Z","html_url":"https://github.com/apache/spark/pull/8318#discussion_r41175819","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8318","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/41175819"},"html":{"href":"https://github.com/apache/spark/pull/8318#discussion_r41175819"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8318"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8318","id":42853035,"html_url":"https://github.com/apache/spark/pull/8318","diff_url":"https://github.com/apache/spark/pull/8318.diff","patch_url":"https://github.com/apache/spark/pull/8318.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8318","number":8318,"state":"open","locked":false,"title":"[SPARK-1267][PYSPARK] Adds pip installer for pyspark","user":{"login":"alope107","id":9411388,"avatar_url":"https://avatars.githubusercontent.com/u/9411388?v=3","gravatar_id":"","url":"https://api.github.com/users/alope107","html_url":"https://github.com/alope107","followers_url":"https://api.github.com/users/alope107/followers","following_url":"https://api.github.com/users/alope107/following{/other_user}","gists_url":"https://api.github.com/users/alope107/gists{/gist_id}","starred_url":"https://api.github.com/users/alope107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alope107/subscriptions","organizations_url":"https://api.github.com/users/alope107/orgs","repos_url":"https://api.github.com/users/alope107/repos","events_url":"https://api.github.com/users/alope107/events{/privacy}","received_events_url":"https://api.github.com/users/alope107/received_events","type":"User","site_admin":false},"body":"Adds a setup.py so that pyspark can be installed and packaged for pip.  This allows for easier setup, and declaration of dependencies.  Please see this discussion for more of the rationale behind this PR:\r\nhttp://apache-spark-developers-list.1001551.n3.nabble.com/PySpark-on-PyPi-td12626.html\r\n\r\nIt is enforced at runtime that there must be a valid SPARK_HOME set, and that the version of pyspark and spark must match exactly.\r\n\r\nTo be used with pip, the package will need to be registered and uploaded to PyPi, see:\r\nhttps://docs.python.org/2/distutils/packageindex.html\r\n\r\nThis code is based on a PR by @prabinb that I've updated due to renewed interest, see:\r\nhttps://github.com/apache/spark/pull/464","created_at":"2015-08-19T19:18:07Z","updated_at":"2015-10-05T18:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b9ac1de07ea476b60576713a928fa232ae638fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8318/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8318/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8318/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/7ad1a8d629eb63d4dc71d7b05d634a4951826aad","head":{"label":"alope107:pip-installer","ref":"pip-installer","sha":"7ad1a8d629eb63d4dc71d7b05d634a4951826aad","user":{"login":"alope107","id":9411388,"avatar_url":"https://avatars.githubusercontent.com/u/9411388?v=3","gravatar_id":"","url":"https://api.github.com/users/alope107","html_url":"https://github.com/alope107","followers_url":"https://api.github.com/users/alope107/followers","following_url":"https://api.github.com/users/alope107/following{/other_user}","gists_url":"https://api.github.com/users/alope107/gists{/gist_id}","starred_url":"https://api.github.com/users/alope107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alope107/subscriptions","organizations_url":"https://api.github.com/users/alope107/orgs","repos_url":"https://api.github.com/users/alope107/repos","events_url":"https://api.github.com/users/alope107/events{/privacy}","received_events_url":"https://api.github.com/users/alope107/received_events","type":"User","site_admin":false},"repo":{"id":37877612,"name":"spark","full_name":"alope107/spark","owner":{"login":"alope107","id":9411388,"avatar_url":"https://avatars.githubusercontent.com/u/9411388?v=3","gravatar_id":"","url":"https://api.github.com/users/alope107","html_url":"https://github.com/alope107","followers_url":"https://api.github.com/users/alope107/followers","following_url":"https://api.github.com/users/alope107/following{/other_user}","gists_url":"https://api.github.com/users/alope107/gists{/gist_id}","starred_url":"https://api.github.com/users/alope107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alope107/subscriptions","organizations_url":"https://api.github.com/users/alope107/orgs","repos_url":"https://api.github.com/users/alope107/repos","events_url":"https://api.github.com/users/alope107/events{/privacy}","received_events_url":"https://api.github.com/users/alope107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alope107/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/alope107/spark","forks_url":"https://api.github.com/repos/alope107/spark/forks","keys_url":"https://api.github.com/repos/alope107/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alope107/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alope107/spark/teams","hooks_url":"https://api.github.com/repos/alope107/spark/hooks","issue_events_url":"https://api.github.com/repos/alope107/spark/issues/events{/number}","events_url":"https://api.github.com/repos/alope107/spark/events","assignees_url":"https://api.github.com/repos/alope107/spark/assignees{/user}","branches_url":"https://api.github.com/repos/alope107/spark/branches{/branch}","tags_url":"https://api.github.com/repos/alope107/spark/tags","blobs_url":"https://api.github.com/repos/alope107/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alope107/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alope107/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/alope107/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alope107/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/alope107/spark/languages","stargazers_url":"https://api.github.com/repos/alope107/spark/stargazers","contributors_url":"https://api.github.com/repos/alope107/spark/contributors","subscribers_url":"https://api.github.com/repos/alope107/spark/subscribers","subscription_url":"https://api.github.com/repos/alope107/spark/subscription","commits_url":"https://api.github.com/repos/alope107/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/alope107/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/alope107/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/alope107/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/alope107/spark/contents/{+path}","compare_url":"https://api.github.com/repos/alope107/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alope107/spark/merges","archive_url":"https://api.github.com/repos/alope107/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alope107/spark/downloads","issues_url":"https://api.github.com/repos/alope107/spark/issues{/number}","pulls_url":"https://api.github.com/repos/alope107/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/alope107/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/alope107/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alope107/spark/labels{/name}","releases_url":"https://api.github.com/repos/alope107/spark/releases{/id}","created_at":"2015-06-22T20:00:15Z","updated_at":"2015-06-22T20:00:36Z","pushed_at":"2015-08-20T18:01:52Z","git_url":"git://github.com/alope107/spark.git","ssh_url":"git@github.com:alope107/spark.git","clone_url":"https://github.com/alope107/spark.git","svn_url":"https://github.com/alope107/spark","homepage":null,"size":120551,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"28a98464ea65aa7b35e24fca5ddaa60c2e5d53ee","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-05T17:01:06Z","pushed_at":"2015-10-05T17:45:51Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1679582,"stargazers_count":5663,"watchers_count":5663,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5236,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":346,"forks":5236,"open_issues":346,"watchers":5663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8318"},"html":{"href":"https://github.com/apache/spark/pull/8318"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8318"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8318/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8318/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8318/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/7ad1a8d629eb63d4dc71d7b05d634a4951826aad"}}}}