{"action":"opened","number":66,"pull_request":{"url":"https://api.github.com/repos/rockymeza/wifi/pulls/66","id":34929147,"html_url":"https://github.com/rockymeza/wifi/pull/66","diff_url":"https://github.com/rockymeza/wifi/pull/66.diff","patch_url":"https://github.com/rockymeza/wifi/pull/66.patch","issue_url":"https://api.github.com/repos/rockymeza/wifi/issues/66","number":66,"state":"open","locked":false,"title":"Add sudo argument to Cell.all","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"A user must have root access to list interfaces, but we don't\r\nwant to run python as root, which would be a big security issue.\r\nSo this PR allows to only give sudo access to `iwlist` to the user\r\nrunning python.\r\n\r\nI haven't see any unittests on `Cell.all` so I haven't added any. If I missed\r\nsomething, please point me to it :)\r\n\r\ncc @ametaireau","created_at":"2015-05-07T15:44:14Z","updated_at":"2015-05-07T15:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rockymeza/wifi/pulls/66/commits","review_comments_url":"https://api.github.com/repos/rockymeza/wifi/pulls/66/comments","review_comment_url":"https://api.github.com/repos/rockymeza/wifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rockymeza/wifi/issues/66/comments","statuses_url":"https://api.github.com/repos/rockymeza/wifi/statuses/7023f1f43a9f4d61b075ac1983464545d1008962","head":{"label":"yohanboniface:add-sudo","ref":"add-sudo","sha":"7023f1f43a9f4d61b075ac1983464545d1008962","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"repo":{"id":35228626,"name":"wifi","full_name":"yohanboniface/wifi","owner":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yohanboniface/wifi","description":"WiFi tools for linux","fork":true,"url":"https://api.github.com/repos/yohanboniface/wifi","forks_url":"https://api.github.com/repos/yohanboniface/wifi/forks","keys_url":"https://api.github.com/repos/yohanboniface/wifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yohanboniface/wifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yohanboniface/wifi/teams","hooks_url":"https://api.github.com/repos/yohanboniface/wifi/hooks","issue_events_url":"https://api.github.com/repos/yohanboniface/wifi/issues/events{/number}","events_url":"https://api.github.com/repos/yohanboniface/wifi/events","assignees_url":"https://api.github.com/repos/yohanboniface/wifi/assignees{/user}","branches_url":"https://api.github.com/repos/yohanboniface/wifi/branches{/branch}","tags_url":"https://api.github.com/repos/yohanboniface/wifi/tags","blobs_url":"https://api.github.com/repos/yohanboniface/wifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yohanboniface/wifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yohanboniface/wifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yohanboniface/wifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yohanboniface/wifi/statuses/{sha}","languages_url":"https://api.github.com/repos/yohanboniface/wifi/languages","stargazers_url":"https://api.github.com/repos/yohanboniface/wifi/stargazers","contributors_url":"https://api.github.com/repos/yohanboniface/wifi/contributors","subscribers_url":"https://api.github.com/repos/yohanboniface/wifi/subscribers","subscription_url":"https://api.github.com/repos/yohanboniface/wifi/subscription","commits_url":"https://api.github.com/repos/yohanboniface/wifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yohanboniface/wifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yohanboniface/wifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yohanboniface/wifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yohanboniface/wifi/contents/{+path}","compare_url":"https://api.github.com/repos/yohanboniface/wifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yohanboniface/wifi/merges","archive_url":"https://api.github.com/repos/yohanboniface/wifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yohanboniface/wifi/downloads","issues_url":"https://api.github.com/repos/yohanboniface/wifi/issues{/number}","pulls_url":"https://api.github.com/repos/yohanboniface/wifi/pulls{/number}","milestones_url":"https://api.github.com/repos/yohanboniface/wifi/milestones{/number}","notifications_url":"https://api.github.com/repos/yohanboniface/wifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yohanboniface/wifi/labels{/name}","releases_url":"https://api.github.com/repos/yohanboniface/wifi/releases{/id}","created_at":"2015-05-07T15:40:23Z","updated_at":"2015-05-07T15:40:23Z","pushed_at":"2015-05-07T15:40:52Z","git_url":"git://github.com/yohanboniface/wifi.git","ssh_url":"git@github.com:yohanboniface/wifi.git","clone_url":"https://github.com/yohanboniface/wifi.git","svn_url":"https://github.com/yohanboniface/wifi","homepage":"http://pypi.python.org/pypi/wifi","size":217,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rockymeza:master","ref":"master","sha":"a9d0d67996394431c08a9d104abb20085bb606ec","user":{"login":"rockymeza","id":21784,"avatar_url":"https://avatars.githubusercontent.com/u/21784?v=3","gravatar_id":"","url":"https://api.github.com/users/rockymeza","html_url":"https://github.com/rockymeza","followers_url":"https://api.github.com/users/rockymeza/followers","following_url":"https://api.github.com/users/rockymeza/following{/other_user}","gists_url":"https://api.github.com/users/rockymeza/gists{/gist_id}","starred_url":"https://api.github.com/users/rockymeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockymeza/subscriptions","organizations_url":"https://api.github.com/users/rockymeza/orgs","repos_url":"https://api.github.com/users/rockymeza/repos","events_url":"https://api.github.com/users/rockymeza/events{/privacy}","received_events_url":"https://api.github.com/users/rockymeza/received_events","type":"User","site_admin":false},"repo":{"id":6185157,"name":"wifi","full_name":"rockymeza/wifi","owner":{"login":"rockymeza","id":21784,"avatar_url":"https://avatars.githubusercontent.com/u/21784?v=3","gravatar_id":"","url":"https://api.github.com/users/rockymeza","html_url":"https://github.com/rockymeza","followers_url":"https://api.github.com/users/rockymeza/followers","following_url":"https://api.github.com/users/rockymeza/following{/other_user}","gists_url":"https://api.github.com/users/rockymeza/gists{/gist_id}","starred_url":"https://api.github.com/users/rockymeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockymeza/subscriptions","organizations_url":"https://api.github.com/users/rockymeza/orgs","repos_url":"https://api.github.com/users/rockymeza/repos","events_url":"https://api.github.com/users/rockymeza/events{/privacy}","received_events_url":"https://api.github.com/users/rockymeza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rockymeza/wifi","description":"WiFi tools for linux","fork":false,"url":"https://api.github.com/repos/rockymeza/wifi","forks_url":"https://api.github.com/repos/rockymeza/wifi/forks","keys_url":"https://api.github.com/repos/rockymeza/wifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockymeza/wifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockymeza/wifi/teams","hooks_url":"https://api.github.com/repos/rockymeza/wifi/hooks","issue_events_url":"https://api.github.com/repos/rockymeza/wifi/issues/events{/number}","events_url":"https://api.github.com/repos/rockymeza/wifi/events","assignees_url":"https://api.github.com/repos/rockymeza/wifi/assignees{/user}","branches_url":"https://api.github.com/repos/rockymeza/wifi/branches{/branch}","tags_url":"https://api.github.com/repos/rockymeza/wifi/tags","blobs_url":"https://api.github.com/repos/rockymeza/wifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockymeza/wifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockymeza/wifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockymeza/wifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockymeza/wifi/statuses/{sha}","languages_url":"https://api.github.com/repos/rockymeza/wifi/languages","stargazers_url":"https://api.github.com/repos/rockymeza/wifi/stargazers","contributors_url":"https://api.github.com/repos/rockymeza/wifi/contributors","subscribers_url":"https://api.github.com/repos/rockymeza/wifi/subscribers","subscription_url":"https://api.github.com/repos/rockymeza/wifi/subscription","commits_url":"https://api.github.com/repos/rockymeza/wifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockymeza/wifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockymeza/wifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockymeza/wifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockymeza/wifi/contents/{+path}","compare_url":"https://api.github.com/repos/rockymeza/wifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockymeza/wifi/merges","archive_url":"https://api.github.com/repos/rockymeza/wifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockymeza/wifi/downloads","issues_url":"https://api.github.com/repos/rockymeza/wifi/issues{/number}","pulls_url":"https://api.github.com/repos/rockymeza/wifi/pulls{/number}","milestones_url":"https://api.github.com/repos/rockymeza/wifi/milestones{/number}","notifications_url":"https://api.github.com/repos/rockymeza/wifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockymeza/wifi/labels{/name}","releases_url":"https://api.github.com/repos/rockymeza/wifi/releases{/id}","created_at":"2012-10-12T04:14:06Z","updated_at":"2015-05-01T18:06:09Z","pushed_at":"2015-04-18T17:44:48Z","git_url":"git://github.com/rockymeza/wifi.git","ssh_url":"git@github.com:rockymeza/wifi.git","clone_url":"https://github.com/rockymeza/wifi.git","svn_url":"https://github.com/rockymeza/wifi","homepage":"http://pypi.python.org/pypi/wifi","size":885,"stargazers_count":85,"watchers_count":85,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":18,"forks":34,"open_issues":18,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rockymeza/wifi/pulls/66"},"html":{"href":"https://github.com/rockymeza/wifi/pull/66"},"issue":{"href":"https://api.github.com/repos/rockymeza/wifi/issues/66"},"comments":{"href":"https://api.github.com/repos/rockymeza/wifi/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/rockymeza/wifi/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/rockymeza/wifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rockymeza/wifi/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/rockymeza/wifi/statuses/7023f1f43a9f4d61b075ac1983464545d1008962"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}