{"action":"created","issue":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/34","labels_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/34/comments","events_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/34/events","html_url":"https://github.com/bloomberg/blpapi-http/pull/34","id":55570211,"number":34,"title":"Update/Cleanup type declaration files","user":{"login":"ericlu88","id":3301112,"avatar_url":"https://avatars.githubusercontent.com/u/3301112?v=3","gravatar_id":"","url":"https://api.github.com/users/ericlu88","html_url":"https://github.com/ericlu88","followers_url":"https://api.github.com/users/ericlu88/followers","following_url":"https://api.github.com/users/ericlu88/following{/other_user}","gists_url":"https://api.github.com/users/ericlu88/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlu88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlu88/subscriptions","organizations_url":"https://api.github.com/users/ericlu88/orgs","repos_url":"https://api.github.com/users/ericlu88/repos","events_url":"https://api.github.com/users/ericlu88/events{/privacy}","received_events_url":"https://api.github.com/users/ericlu88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bloomberg/blpapi-http/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-27T03:07:04Z","updated_at":"2015-01-27T04:38:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/pulls/34","html_url":"https://github.com/bloomberg/blpapi-http/pull/34","diff_url":"https://github.com/bloomberg/blpapi-http/pull/34.diff","patch_url":"https://github.com/bloomberg/blpapi-http/pull/34.patch"},"body":"This PR add/updates type declaration files needed by subscription changes. "},"comment":{"url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/comments/71588721","html_url":"https://github.com/bloomberg/blpapi-http/pull/34#issuecomment-71588721","issue_url":"https://api.github.com/repos/bloomberg/blpapi-http/issues/34","id":71588721,"user":{"login":"ericlu88","id":3301112,"avatar_url":"https://avatars.githubusercontent.com/u/3301112?v=3","gravatar_id":"","url":"https://api.github.com/users/ericlu88","html_url":"https://github.com/ericlu88","followers_url":"https://api.github.com/users/ericlu88/followers","following_url":"https://api.github.com/users/ericlu88/following{/other_user}","gists_url":"https://api.github.com/users/ericlu88/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlu88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlu88/subscriptions","organizations_url":"https://api.github.com/users/ericlu88/orgs","repos_url":"https://api.github.com/users/ericlu88/repos","events_url":"https://api.github.com/users/ericlu88/events{/privacy}","received_events_url":"https://api.github.com/users/ericlu88/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T04:38:19Z","updated_at":"2015-01-27T04:38:19Z","body":"Wow, this is cool. Definitely better than maintaining a local copy of all those type files.\r\n\r\nI guess the only downside I see is when DefinitelyTyped add the same property eventually(by someone else) and we may end up with a type conflict error in compile time if we do a `tsd update`. Since we are not making customized typings files specific to our app, this could be a good work around while we submit PR and before it is accepted. After merged, we still should update via tsd and get rid of our local modification."}}