{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/36154752","id":36154752,"diff_hunk":"@@ -326,6 +329,38 @@ export module Components {\n       }\n     }\n \n+    /**\n+     * Gets the function determining the opacity of the symbols of the Legend.\n+     *\n+     * @returns {(datum: any, index: number) => number}\n+     */\n+    public symbolOpacity(): (datum: any, index: number) => number;\n+    /**\n+     * Sets the function determining the symbols of the Legend.\n+     *\n+     * @param {(datum: any, index: number) => number} opacityFunction\n+     * @returns {Legend} The calling Legend\n+     */\n+    public symbolOpacity(opacityFunction: (datum: any, index: number) => number): Legend;\n+    /**\n+     * Sets the function determining the symbols of the Legend.\n+     *\n+     * @param {number} constantOpacity\n+     * @returns {Legend} The calling Legend\n+     */\n+    public symbolOpacity(constantOpacity: number): Legend;\n+    public symbolOpacity(opacity?: number|((datum: any, index: number) => number)): any {","path":"src/components/legend.ts","position":48,"original_position":48,"commit_id":"20b5d1a751175e1e4a4969b4597e0f644050fb86","original_commit_id":"20b5d1a751175e1e4a4969b4597e0f644050fb86","user":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"body":"Can you put whitespace in between the union types?","created_at":"2015-08-04T03:26:46Z","updated_at":"2015-08-04T03:26:46Z","html_url":"https://github.com/palantir/plottable/pull/2550#discussion_r36154752","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/2550","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/36154752"},"html":{"href":"https://github.com/palantir/plottable/pull/2550#discussion_r36154752"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/2550"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/2550","id":41531101,"html_url":"https://github.com/palantir/plottable/pull/2550","diff_url":"https://github.com/palantir/plottable/pull/2550.diff","patch_url":"https://github.com/palantir/plottable/pull/2550.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/2550","number":2550,"state":"open","locked":false,"title":"API endpoint to specify opacity of legend (take 2)","user":{"login":"yqlu","id":6540967,"avatar_url":"https://avatars.githubusercontent.com/u/6540967?v=3","gravatar_id":"","url":"https://api.github.com/users/yqlu","html_url":"https://github.com/yqlu","followers_url":"https://api.github.com/users/yqlu/followers","following_url":"https://api.github.com/users/yqlu/following{/other_user}","gists_url":"https://api.github.com/users/yqlu/gists{/gist_id}","starred_url":"https://api.github.com/users/yqlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yqlu/subscriptions","organizations_url":"https://api.github.com/users/yqlu/orgs","repos_url":"https://api.github.com/users/yqlu/repos","events_url":"https://api.github.com/users/yqlu/events{/privacy}","received_events_url":"https://api.github.com/users/yqlu/received_events","type":"User","site_admin":false},"body":"Follow-up from https://github.com/palantir/plottable/pull/2461\r\n\r\nImplements a cleaner API for legend symbol opacity:\r\n\r\n```\r\npublic symbolOpacity(constantOpacity: number);\r\npublic symbolOpacity(opacityFunction: (d: any, i: index) => number);\r\n```\r\n\r\nSee http://plnkr.co/edit/nyEuE8L7rekfoftjeOSt?p=preview for demo","created_at":"2015-08-04T03:20:25Z","updated_at":"2015-08-04T03:26:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b205e64c8c60c8ff4f5513dded46da3140d7836","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/2550/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/2550/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/2550/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/20b5d1a751175e1e4a4969b4597e0f644050fb86","head":{"label":"yqlu:2434-fix","ref":"2434-fix","sha":"20b5d1a751175e1e4a4969b4597e0f644050fb86","user":{"login":"yqlu","id":6540967,"avatar_url":"https://avatars.githubusercontent.com/u/6540967?v=3","gravatar_id":"","url":"https://api.github.com/users/yqlu","html_url":"https://github.com/yqlu","followers_url":"https://api.github.com/users/yqlu/followers","following_url":"https://api.github.com/users/yqlu/following{/other_user}","gists_url":"https://api.github.com/users/yqlu/gists{/gist_id}","starred_url":"https://api.github.com/users/yqlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yqlu/subscriptions","organizations_url":"https://api.github.com/users/yqlu/orgs","repos_url":"https://api.github.com/users/yqlu/repos","events_url":"https://api.github.com/users/yqlu/events{/privacy}","received_events_url":"https://api.github.com/users/yqlu/received_events","type":"User","site_admin":false},"repo":{"id":39094793,"name":"plottable","full_name":"yqlu/plottable","owner":{"login":"yqlu","id":6540967,"avatar_url":"https://avatars.githubusercontent.com/u/6540967?v=3","gravatar_id":"","url":"https://api.github.com/users/yqlu","html_url":"https://github.com/yqlu","followers_url":"https://api.github.com/users/yqlu/followers","following_url":"https://api.github.com/users/yqlu/following{/other_user}","gists_url":"https://api.github.com/users/yqlu/gists{/gist_id}","starred_url":"https://api.github.com/users/yqlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yqlu/subscriptions","organizations_url":"https://api.github.com/users/yqlu/orgs","repos_url":"https://api.github.com/users/yqlu/repos","events_url":"https://api.github.com/users/yqlu/events{/privacy}","received_events_url":"https://api.github.com/users/yqlu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yqlu/plottable","description":"A library of modular chart components, built on D3","fork":true,"url":"https://api.github.com/repos/yqlu/plottable","forks_url":"https://api.github.com/repos/yqlu/plottable/forks","keys_url":"https://api.github.com/repos/yqlu/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yqlu/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yqlu/plottable/teams","hooks_url":"https://api.github.com/repos/yqlu/plottable/hooks","issue_events_url":"https://api.github.com/repos/yqlu/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/yqlu/plottable/events","assignees_url":"https://api.github.com/repos/yqlu/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/yqlu/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/yqlu/plottable/tags","blobs_url":"https://api.github.com/repos/yqlu/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yqlu/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yqlu/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/yqlu/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yqlu/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/yqlu/plottable/languages","stargazers_url":"https://api.github.com/repos/yqlu/plottable/stargazers","contributors_url":"https://api.github.com/repos/yqlu/plottable/contributors","subscribers_url":"https://api.github.com/repos/yqlu/plottable/subscribers","subscription_url":"https://api.github.com/repos/yqlu/plottable/subscription","commits_url":"https://api.github.com/repos/yqlu/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/yqlu/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/yqlu/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/yqlu/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/yqlu/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/yqlu/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yqlu/plottable/merges","archive_url":"https://api.github.com/repos/yqlu/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yqlu/plottable/downloads","issues_url":"https://api.github.com/repos/yqlu/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/yqlu/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/yqlu/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/yqlu/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yqlu/plottable/labels{/name}","releases_url":"https://api.github.com/repos/yqlu/plottable/releases{/id}","created_at":"2015-07-14T19:04:16Z","updated_at":"2015-07-14T19:04:17Z","pushed_at":"2015-08-04T03:13:36Z","git_url":"git://github.com/yqlu/plottable.git","ssh_url":"git@github.com:yqlu/plottable.git","clone_url":"https://github.com/yqlu/plottable.git","svn_url":"https://github.com/yqlu/plottable","homepage":"plottablejs.org","size":56560,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"31f0c47352049dcd01a2070056cfe71af1a75551","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2015-08-03T19:24:33Z","pushed_at":"2015-08-04T03:20:26Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":129028,"stargazers_count":642,"watchers_count":642,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":151,"forks":62,"open_issues":151,"watchers":642,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/2550"},"html":{"href":"https://github.com/palantir/plottable/pull/2550"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/2550"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/2550/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/2550/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/2550/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/20b5d1a751175e1e4a4969b4597e0f644050fb86"}}}}