{"action":"created","issue":{"url":"https://api.github.com/repos/meanjs/mean/issues/898","labels_url":"https://api.github.com/repos/meanjs/mean/issues/898/labels{/name}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/898/comments","events_url":"https://api.github.com/repos/meanjs/mean/issues/898/events","html_url":"https://github.com/meanjs/mean/issues/898","id":105464948,"number":898,"title":"Travis CI webhooks shouldn't be static","user":{"login":"mleanos","id":5613734,"avatar_url":"https://avatars.githubusercontent.com/u/5613734?v=3","gravatar_id":"","url":"https://api.github.com/users/mleanos","html_url":"https://github.com/mleanos","followers_url":"https://api.github.com/users/mleanos/followers","following_url":"https://api.github.com/users/mleanos/following{/other_user}","gists_url":"https://api.github.com/users/mleanos/gists{/gist_id}","starred_url":"https://api.github.com/users/mleanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mleanos/subscriptions","organizations_url":"https://api.github.com/users/mleanos/orgs","repos_url":"https://api.github.com/users/mleanos/repos","events_url":"https://api.github.com/users/mleanos/events{/privacy}","received_events_url":"https://api.github.com/users/mleanos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/meanjs/mean/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/meanjs/mean/milestones/8","html_url":"https://github.com/meanjs/mean/milestones/0.4.2","labels_url":"https://api.github.com/repos/meanjs/mean/milestones/8/labels","id":1285066,"number":8,"title":"0.4.2","description":"","creator":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":73,"state":"open","created_at":"2015-09-01T22:36:52Z","updated_at":"2015-10-18T18:13:00Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2015-09-08T20:42:31Z","updated_at":"2015-10-18T20:15:51Z","closed_at":null,"body":"The webhooks defined here are static. This will cause activity notifications, for repo's originating from this codebase, to be sent to the meanjs/mean Gitter room. https://github.com/meanjs/mean/blob/master/.travis.yml#L19\r\n\r\nIf a user of this project doesn't change the settings in *travis.yml*, their project will use this webhook whenever it runs through the Travis CI build process. I don't think this is a desirable behavior.\r\n\r\nI'm not too familiar with Travis CI, but I did some research on this subject. This led me to two possible options to solve this issue...\r\n\r\n1) Use an environment variable to define the Gitter webhook. This may be useful to provide separate settings for the different environment configs. Perhaps something like this in the *config/env* settings...\r\n```\r\ntravis: {\r\n  gitter: {\r\n    webhook: 'https://webhooks.gitter.im/e/249daf9851ea4776f34e'\r\n  }\r\n}\r\n```\r\n2) Use custom variables, and set them in the Travis CI Repository Settings as described here. http://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings I'm not sure about this solution though.\r\n\r\nI don't really have a way (that I know of) to test these types of settings/variables for Travis CI. I'm hoping someone might have some insight into this issue. \r\n\r\n@lirantal @ilanbiala @codydaig @rhutchison Any thoughts/ideas?\r\n"},"comment":{"url":"https://api.github.com/repos/meanjs/mean/issues/comments/149043448","html_url":"https://github.com/meanjs/mean/issues/898#issuecomment-149043448","issue_url":"https://api.github.com/repos/meanjs/mean/issues/898","id":149043448,"user":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"created_at":"2015-10-18T20:15:51Z","updated_at":"2015-10-18T20:15:51Z","body":"@lirantal if it works, sounds good!"}}