{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37784704","id":37784704,"diff_hunk":"@@ -921,6 +921,9 @@ type PodSpec struct {\n \t// used must be specified.\n \t// Optional: Default to false.\n \tHostNetwork bool `json:\"hostNetwork,omitempty\"`\n+\t// Run the container using the host ipc mode.\n+\t// Optional: Default to false.\n+\tHostIPC bool `json:\"hostIPC,omitempty\"`","path":"pkg/api/types.go","position":6,"original_position":6,"commit_id":"91151981dbdb3380c46ca6fbc7afb1c96a03944e","original_commit_id":"73b1e4990e06cb6ab00190abb18e58d1bc4f6f5d","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"ah, misread... we're currently using the infra pod's id as the IPC namespace, so it is shared. should `createPodInfraContainer` create the infra pod in the host IPC namespace also if `pod.spec.HostIPC` is true?","created_at":"2015-08-24T18:26:21Z","updated_at":"2015-08-24T18:26:21Z","html_url":"https://github.com/kubernetes/kubernetes/pull/12470#discussion_r37784704","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/37784704"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12470#discussion_r37784704"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470","id":42010221,"html_url":"https://github.com/kubernetes/kubernetes/pull/12470","diff_url":"https://github.com/kubernetes/kubernetes/pull/12470.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/12470.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12470","number":12470,"state":"open","locked":false,"title":"Support containers with host ipc in a pod","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"body":"Add a UseHostIpc field to the SecurityContext of containers to create containers that can share the same ipc with the host.\r\n\r\nThis feature must be explicitly enabled (in apiserver and kubelet using the capability/option AllowUseHostIpc/--allow-host-ipc)\r\n\r\ncc @bgrant0607 @smarterclayton @derekwaynecarr @eparis \r\n\r\nI am not sure if you allow additions to v1 API and if we can \"easily\" get this in at this stage. My best case scenario is that I could get this merged/backported in some form in v1.0.x","created_at":"2015-08-10T11:27:00Z","updated_at":"2015-08-24T18:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dfab8c04b8adde2efd12e9bc7391f4a57423d7c","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12470/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/91151981dbdb3380c46ca6fbc7afb1c96a03944e","head":{"label":"simon3z:add-host-ipc","ref":"add-host-ipc","sha":"91151981dbdb3380c46ca6fbc7afb1c96a03944e","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"repo":{"id":23426377,"name":"kubernetes","full_name":"simon3z/kubernetes","owner":{"login":"simon3z","id":130393,"avatar_url":"https://avatars.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simon3z/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/simon3z/kubernetes","forks_url":"https://api.github.com/repos/simon3z/kubernetes/forks","keys_url":"https://api.github.com/repos/simon3z/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simon3z/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simon3z/kubernetes/teams","hooks_url":"https://api.github.com/repos/simon3z/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/simon3z/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/simon3z/kubernetes/events","assignees_url":"https://api.github.com/repos/simon3z/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/simon3z/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/simon3z/kubernetes/tags","blobs_url":"https://api.github.com/repos/simon3z/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simon3z/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simon3z/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/simon3z/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simon3z/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/simon3z/kubernetes/languages","stargazers_url":"https://api.github.com/repos/simon3z/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/simon3z/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/simon3z/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/simon3z/kubernetes/subscription","commits_url":"https://api.github.com/repos/simon3z/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/simon3z/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/simon3z/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/simon3z/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/simon3z/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/simon3z/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simon3z/kubernetes/merges","archive_url":"https://api.github.com/repos/simon3z/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simon3z/kubernetes/downloads","issues_url":"https://api.github.com/repos/simon3z/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/simon3z/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/simon3z/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/simon3z/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simon3z/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/simon3z/kubernetes/releases{/id}","created_at":"2014-08-28T12:05:55Z","updated_at":"2015-02-11T22:47:51Z","pushed_at":"2015-08-19T23:36:57Z","git_url":"git://github.com/simon3z/kubernetes.git","ssh_url":"git@github.com:simon3z/kubernetes.git","clone_url":"https://github.com/simon3z/kubernetes.git","svn_url":"https://github.com/simon3z/kubernetes","homepage":null,"size":99767,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"41e6c2c9e02d5336573262dc6e52a3d96054e317","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-24T17:42:29Z","pushed_at":"2015-08-24T18:14:17Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":359636,"stargazers_count":9868,"watchers_count":9868,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2383,"mirror_url":null,"open_issues_count":1775,"forks":2383,"open_issues":1775,"watchers":9868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12470"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12470"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12470/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12470/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/91151981dbdb3380c46ca6fbc7afb1c96a03944e"}}}}