{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/sergev/pic32prog/pulls/17","id":43417094,"html_url":"https://github.com/sergev/pic32prog/pull/17","diff_url":"https://github.com/sergev/pic32prog/pull/17.diff","patch_url":"https://github.com/sergev/pic32prog/pull/17.patch","issue_url":"https://api.github.com/repos/sergev/pic32prog/issues/17","number":17,"state":"closed","locked":false,"title":"Update pic32prog.c","user":{"login":"robert-rozee","id":13412066,"avatar_url":"https://avatars.githubusercontent.com/u/13412066?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-rozee","html_url":"https://github.com/robert-rozee","followers_url":"https://api.github.com/users/robert-rozee/followers","following_url":"https://api.github.com/users/robert-rozee/following{/other_user}","gists_url":"https://api.github.com/users/robert-rozee/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-rozee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-rozee/subscriptions","organizations_url":"https://api.github.com/users/robert-rozee/orgs","repos_url":"https://api.github.com/users/robert-rozee/repos","events_url":"https://api.github.com/users/robert-rozee/events{/privacy}","received_events_url":"https://api.github.com/users/robert-rozee/received_events","type":"User","site_admin":false},"body":"this is a HORRIBLE HACK, to prevent validating the baud rate (under linux) if the bitbang/'ascii ICSP' protocol is selected. this is necessary because the baud rate is repurposed by adapter-bitbang.c as a command to select several special functions:\r\n-b1 to -b4 trigger upload of 'ascii ICSP' firmware to an attached Arduino NANO\r\n-b8 and -b9 trigger a 'blind' erase of a uncooperative PIC32MX or PIC32MZ processor respectively\r\n\r\nnote that the 'ascii ICSP' protocol uses a fixed baud rate of 500000 that can not be changed, hence why the -b switch could be repurposed.\r\n\r\nthere is almost certainly a cleaner way to achieve the same result as this rather inelegant 1-line hack. please do feel free to reject this change and substitute a better alternative.\r\n\r\ni've also found some other issues that are preventing 'ascii ICSP' from working under linux, where responses from the NANO seem to have characters missing. unfortunately i can't compile pic32prog for a linux target, so will have to resort to thinking through the issues to find a solution.\r\n\r\non a positive note, i have validated that the linux 32-bit compile works with a PICkit 2 under 32-bit linux mint, programming a PIC32MX170F256B quite successfully.\r\n\r\ncheers,\r\nrob   :-)","created_at":"2015-08-26T15:39:19Z","updated_at":"2015-08-30T18:03:11Z","closed_at":"2015-08-30T18:03:11Z","merged_at":null,"merge_commit_sha":"fdd954845154cc0cd4025a8d409a4b9b254e3d94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sergev/pic32prog/pulls/17/commits","review_comments_url":"https://api.github.com/repos/sergev/pic32prog/pulls/17/comments","review_comment_url":"https://api.github.com/repos/sergev/pic32prog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sergev/pic32prog/issues/17/comments","statuses_url":"https://api.github.com/repos/sergev/pic32prog/statuses/619a9f20f3f0fe28763dbdab578779de1f3b45ea","head":{"label":"robert-rozee:master","ref":"master","sha":"619a9f20f3f0fe28763dbdab578779de1f3b45ea","user":{"login":"robert-rozee","id":13412066,"avatar_url":"https://avatars.githubusercontent.com/u/13412066?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-rozee","html_url":"https://github.com/robert-rozee","followers_url":"https://api.github.com/users/robert-rozee/followers","following_url":"https://api.github.com/users/robert-rozee/following{/other_user}","gists_url":"https://api.github.com/users/robert-rozee/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-rozee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-rozee/subscriptions","organizations_url":"https://api.github.com/users/robert-rozee/orgs","repos_url":"https://api.github.com/users/robert-rozee/repos","events_url":"https://api.github.com/users/robert-rozee/events{/privacy}","received_events_url":"https://api.github.com/users/robert-rozee/received_events","type":"User","site_admin":false},"repo":{"id":40190221,"name":"pic32prog","full_name":"robert-rozee/pic32prog","owner":{"login":"robert-rozee","id":13412066,"avatar_url":"https://avatars.githubusercontent.com/u/13412066?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-rozee","html_url":"https://github.com/robert-rozee","followers_url":"https://api.github.com/users/robert-rozee/followers","following_url":"https://api.github.com/users/robert-rozee/following{/other_user}","gists_url":"https://api.github.com/users/robert-rozee/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-rozee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-rozee/subscriptions","organizations_url":"https://api.github.com/users/robert-rozee/orgs","repos_url":"https://api.github.com/users/robert-rozee/repos","events_url":"https://api.github.com/users/robert-rozee/events{/privacy}","received_events_url":"https://api.github.com/users/robert-rozee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robert-rozee/pic32prog","description":"Flash programming utility for Microchip PIC32 microcontrollers","fork":true,"url":"https://api.github.com/repos/robert-rozee/pic32prog","forks_url":"https://api.github.com/repos/robert-rozee/pic32prog/forks","keys_url":"https://api.github.com/repos/robert-rozee/pic32prog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robert-rozee/pic32prog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robert-rozee/pic32prog/teams","hooks_url":"https://api.github.com/repos/robert-rozee/pic32prog/hooks","issue_events_url":"https://api.github.com/repos/robert-rozee/pic32prog/issues/events{/number}","events_url":"https://api.github.com/repos/robert-rozee/pic32prog/events","assignees_url":"https://api.github.com/repos/robert-rozee/pic32prog/assignees{/user}","branches_url":"https://api.github.com/repos/robert-rozee/pic32prog/branches{/branch}","tags_url":"https://api.github.com/repos/robert-rozee/pic32prog/tags","blobs_url":"https://api.github.com/repos/robert-rozee/pic32prog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robert-rozee/pic32prog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robert-rozee/pic32prog/git/refs{/sha}","trees_url":"https://api.github.com/repos/robert-rozee/pic32prog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robert-rozee/pic32prog/statuses/{sha}","languages_url":"https://api.github.com/repos/robert-rozee/pic32prog/languages","stargazers_url":"https://api.github.com/repos/robert-rozee/pic32prog/stargazers","contributors_url":"https://api.github.com/repos/robert-rozee/pic32prog/contributors","subscribers_url":"https://api.github.com/repos/robert-rozee/pic32prog/subscribers","subscription_url":"https://api.github.com/repos/robert-rozee/pic32prog/subscription","commits_url":"https://api.github.com/repos/robert-rozee/pic32prog/commits{/sha}","git_commits_url":"https://api.github.com/repos/robert-rozee/pic32prog/git/commits{/sha}","comments_url":"https://api.github.com/repos/robert-rozee/pic32prog/comments{/number}","issue_comment_url":"https://api.github.com/repos/robert-rozee/pic32prog/issues/comments{/number}","contents_url":"https://api.github.com/repos/robert-rozee/pic32prog/contents/{+path}","compare_url":"https://api.github.com/repos/robert-rozee/pic32prog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robert-rozee/pic32prog/merges","archive_url":"https://api.github.com/repos/robert-rozee/pic32prog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robert-rozee/pic32prog/downloads","issues_url":"https://api.github.com/repos/robert-rozee/pic32prog/issues{/number}","pulls_url":"https://api.github.com/repos/robert-rozee/pic32prog/pulls{/number}","milestones_url":"https://api.github.com/repos/robert-rozee/pic32prog/milestones{/number}","notifications_url":"https://api.github.com/repos/robert-rozee/pic32prog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robert-rozee/pic32prog/labels{/name}","releases_url":"https://api.github.com/repos/robert-rozee/pic32prog/releases{/id}","created_at":"2015-08-04T14:39:51Z","updated_at":"2015-08-04T14:39:52Z","pushed_at":"2015-08-30T17:43:00Z","git_url":"git://github.com/robert-rozee/pic32prog.git","ssh_url":"git@github.com:robert-rozee/pic32prog.git","clone_url":"https://github.com/robert-rozee/pic32prog.git","svn_url":"https://github.com/robert-rozee/pic32prog","homepage":null,"size":2452,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sergev:master","ref":"master","sha":"17cb617616d8a3273d0c5e6f1aaabdbfd0b46397","user":{"login":"sergev","id":1139878,"avatar_url":"https://avatars.githubusercontent.com/u/1139878?v=3","gravatar_id":"","url":"https://api.github.com/users/sergev","html_url":"https://github.com/sergev","followers_url":"https://api.github.com/users/sergev/followers","following_url":"https://api.github.com/users/sergev/following{/other_user}","gists_url":"https://api.github.com/users/sergev/gists{/gist_id}","starred_url":"https://api.github.com/users/sergev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergev/subscriptions","organizations_url":"https://api.github.com/users/sergev/orgs","repos_url":"https://api.github.com/users/sergev/repos","events_url":"https://api.github.com/users/sergev/events{/privacy}","received_events_url":"https://api.github.com/users/sergev/received_events","type":"User","site_admin":false},"repo":{"id":31643700,"name":"pic32prog","full_name":"sergev/pic32prog","owner":{"login":"sergev","id":1139878,"avatar_url":"https://avatars.githubusercontent.com/u/1139878?v=3","gravatar_id":"","url":"https://api.github.com/users/sergev","html_url":"https://github.com/sergev","followers_url":"https://api.github.com/users/sergev/followers","following_url":"https://api.github.com/users/sergev/following{/other_user}","gists_url":"https://api.github.com/users/sergev/gists{/gist_id}","starred_url":"https://api.github.com/users/sergev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergev/subscriptions","organizations_url":"https://api.github.com/users/sergev/orgs","repos_url":"https://api.github.com/users/sergev/repos","events_url":"https://api.github.com/users/sergev/events{/privacy}","received_events_url":"https://api.github.com/users/sergev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergev/pic32prog","description":"Flash programming utility for Microchip PIC32 microcontrollers","fork":false,"url":"https://api.github.com/repos/sergev/pic32prog","forks_url":"https://api.github.com/repos/sergev/pic32prog/forks","keys_url":"https://api.github.com/repos/sergev/pic32prog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergev/pic32prog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergev/pic32prog/teams","hooks_url":"https://api.github.com/repos/sergev/pic32prog/hooks","issue_events_url":"https://api.github.com/repos/sergev/pic32prog/issues/events{/number}","events_url":"https://api.github.com/repos/sergev/pic32prog/events","assignees_url":"https://api.github.com/repos/sergev/pic32prog/assignees{/user}","branches_url":"https://api.github.com/repos/sergev/pic32prog/branches{/branch}","tags_url":"https://api.github.com/repos/sergev/pic32prog/tags","blobs_url":"https://api.github.com/repos/sergev/pic32prog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergev/pic32prog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergev/pic32prog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergev/pic32prog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergev/pic32prog/statuses/{sha}","languages_url":"https://api.github.com/repos/sergev/pic32prog/languages","stargazers_url":"https://api.github.com/repos/sergev/pic32prog/stargazers","contributors_url":"https://api.github.com/repos/sergev/pic32prog/contributors","subscribers_url":"https://api.github.com/repos/sergev/pic32prog/subscribers","subscription_url":"https://api.github.com/repos/sergev/pic32prog/subscription","commits_url":"https://api.github.com/repos/sergev/pic32prog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergev/pic32prog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergev/pic32prog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergev/pic32prog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergev/pic32prog/contents/{+path}","compare_url":"https://api.github.com/repos/sergev/pic32prog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergev/pic32prog/merges","archive_url":"https://api.github.com/repos/sergev/pic32prog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergev/pic32prog/downloads","issues_url":"https://api.github.com/repos/sergev/pic32prog/issues{/number}","pulls_url":"https://api.github.com/repos/sergev/pic32prog/pulls{/number}","milestones_url":"https://api.github.com/repos/sergev/pic32prog/milestones{/number}","notifications_url":"https://api.github.com/repos/sergev/pic32prog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergev/pic32prog/labels{/name}","releases_url":"https://api.github.com/repos/sergev/pic32prog/releases{/id}","created_at":"2015-03-04T07:20:50Z","updated_at":"2015-08-29T17:37:33Z","pushed_at":"2015-08-30T17:43:00Z","git_url":"git://github.com/sergev/pic32prog.git","ssh_url":"git@github.com:sergev/pic32prog.git","clone_url":"https://github.com/sergev/pic32prog.git","svn_url":"https://github.com/sergev/pic32prog","homepage":null,"size":2837,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sergev/pic32prog/pulls/17"},"html":{"href":"https://github.com/sergev/pic32prog/pull/17"},"issue":{"href":"https://api.github.com/repos/sergev/pic32prog/issues/17"},"comments":{"href":"https://api.github.com/repos/sergev/pic32prog/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/sergev/pic32prog/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/sergev/pic32prog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sergev/pic32prog/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/sergev/pic32prog/statuses/619a9f20f3f0fe28763dbdab578779de1f3b45ea"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":4,"additions":970,"deletions":49,"changed_files":4}}