{"action":"created","issue":{"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/349","labels_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/349/comments","events_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/349/events","html_url":"https://github.com/ESAPI/esapi-java-legacy/pull/349","id":72862830,"number":349,"title":"Package correctly the esapi.tld into ESAPI jar","user":{"login":"taringamberini","id":4944077,"avatar_url":"https://avatars.githubusercontent.com/u/4944077?v=3","gravatar_id":"","url":"https://api.github.com/users/taringamberini","html_url":"https://github.com/taringamberini","followers_url":"https://api.github.com/users/taringamberini/followers","following_url":"https://api.github.com/users/taringamberini/following{/other_user}","gists_url":"https://api.github.com/users/taringamberini/gists{/gist_id}","starred_url":"https://api.github.com/users/taringamberini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taringamberini/subscriptions","organizations_url":"https://api.github.com/users/taringamberini/orgs","repos_url":"https://api.github.com/users/taringamberini/repos","events_url":"https://api.github.com/users/taringamberini/events{/privacy}","received_events_url":"https://api.github.com/users/taringamberini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-03T20:37:02Z","updated_at":"2015-05-04T03:15:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/349","html_url":"https://github.com/ESAPI/esapi-java-legacy/pull/349","diff_url":"https://github.com/ESAPI/esapi-java-legacy/pull/349.diff","patch_url":"https://github.com/ESAPI/esapi-java-legacy/pull/349.patch"},"body":"PROBLEM\r\n\r\nUsing the ESAPI tag library in a JSP generates an error related to missing tag\r\nlibrary.\r\n\r\nCAUSE\r\n\r\nThe tag library descriptor `esapi.tld` is not correctly package in the jar\r\naccordingly to JEE 5 specification\r\nhttp://download.oracle.com/javaee/5/tutorial/doc/bnamu.htm\r\n\r\nSOLUTION\r\n\r\nMaven is the build automation tool used, so in order to get the `esapi.tld`\r\nincluded into the `esapi.jar` META-INF directory the .tld file is added into\r\nthe `/src/main/resources/META-INF/` directory.\r\n\r\nFixes ESAPI/esapi-java-legacy#212\r\nFixes ESAPI/esapi-java-legacy#213\r\nFixes ESAPI/esapi-java-legacy#244\r\nFixes https://owasp-esapi.atlassian.net/browse/ESAPILEG-46\r\nFixes https://owasp-esapi.atlassian.net/browse/ESAPILEG-47\r\nFixes https://owasp-esapi.atlassian.net/browse/ESAPILEG-243"},"comment":{"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/comments/98579845","html_url":"https://github.com/ESAPI/esapi-java-legacy/pull/349#issuecomment-98579845","issue_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/349","id":98579845,"user":{"login":"kwwall","id":1959835,"avatar_url":"https://avatars.githubusercontent.com/u/1959835?v=3","gravatar_id":"","url":"https://api.github.com/users/kwwall","html_url":"https://github.com/kwwall","followers_url":"https://api.github.com/users/kwwall/followers","following_url":"https://api.github.com/users/kwwall/following{/other_user}","gists_url":"https://api.github.com/users/kwwall/gists{/gist_id}","starred_url":"https://api.github.com/users/kwwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwwall/subscriptions","organizations_url":"https://api.github.com/users/kwwall/orgs","repos_url":"https://api.github.com/users/kwwall/repos","events_url":"https://api.github.com/users/kwwall/events{/privacy}","received_events_url":"https://api.github.com/users/kwwall/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T03:15:52Z","updated_at":"2015-05-04T03:15:52Z","body":"First off all, I presume that you meant:\r\nhttp://docs.oracle.com/javaee/5/tutorial/doc/bnaiy.html\r\nrather than \r\nhttp://download.oracle.com/javaee/5/tutorial/doc/bnamu.htm\r\nas the later is not found.\r\n\r\nSecond, there was already an esapi.tld under 'configuration/META-INF/' directory. Is your intent just to move it from there to 'src/resources/META-INF/' or is this a new esapi.tld? (I haven't bothered to compare them as I have a lot of other emails to attend to.)\r\n\r\nAlso, are any other changes needed to the pom.xml for maven to handle the packaging the esapi.tld into the ESAPI jar correctly? I thought that we originally had it placed under 'resources/META-INF' somewhere, but later moved it to 'configuration' because something in maven wasn't working as expected."}}