{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/30","labels_url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/30/comments","events_url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/30/events","html_url":"https://github.com/JuliaAstro/FITSIO.jl/pull/30","id":73111700,"number":30,"title":"Rename a few functions, create Libcfitsio submodule","user":{"login":"kbarbary","id":970135,"avatar_url":"https://avatars.githubusercontent.com/u/970135?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarbary","html_url":"https://github.com/kbarbary","followers_url":"https://api.github.com/users/kbarbary/followers","following_url":"https://api.github.com/users/kbarbary/following{/other_user}","gists_url":"https://api.github.com/users/kbarbary/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarbary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarbary/subscriptions","organizations_url":"https://api.github.com/users/kbarbary/orgs","repos_url":"https://api.github.com/users/kbarbary/repos","events_url":"https://api.github.com/users/kbarbary/events{/privacy}","received_events_url":"https://api.github.com/users/kbarbary/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-04T19:49:44Z","updated_at":"2015-05-04T20:02:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/pulls/30","html_url":"https://github.com/JuliaAstro/FITSIO.jl/pull/30","diff_url":"https://github.com/JuliaAstro/FITSIO.jl/pull/30.diff","patch_url":"https://github.com/JuliaAstro/FITSIO.jl/pull/30.patch"},"body":"This PR consists of two commits:\r\n\r\n## Renames\r\n\r\nThe first commit renames some functions in the high-level API according to the style guide:\r\n\r\n- `readkey` -> `read_key`\r\n- `readheader` -> `read_header`\r\n- `getcomment` -> `get_comment`\r\n- `setcomment!` -> `set_comment!`\r\n\r\nIt's my fault that these functions weren't named this way to begin with. I was trying to mimic naming conventions in Base (e.g., `haskey(d)`), not realizing that the style guide is a \"do as we say, not as we do\" sort of thing.\r\n\r\nIt also deprecates the `hdu[i:j, k:l]` syntax for reading a subset of an image HDU in favor of the more explicit `read(hdu, i:j, k:l)`. I really like this change as it makes all read and writes from the file explicit, making the whole API more consistent.\r\n\r\nThere are deprecation warnings for all these changes.\r\n\r\n## Libcfitsio submodule\r\n\r\nThe second commit moves all of the low-level interface into a `Libcfitsio` submodule, as proposed in #27. This would require users of the low-level `fits_*` functions to do `using FITSIO.Libcfitsio` rather than just `using FITSIO`. Otherwise all low-level code would remain the same. What do users of the low-level API think about this? cc @emmt @ziotom78 \r\n\r\nThere are **not** deprecation warnings for this change, but users only need to replace `using FITSIO` with `using FITSIO.Libcfitsio` to comply with the change."},"comment":{"url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/comments/98834148","html_url":"https://github.com/JuliaAstro/FITSIO.jl/pull/30#issuecomment-98834148","issue_url":"https://api.github.com/repos/JuliaAstro/FITSIO.jl/issues/30","id":98834148,"user":{"login":"ziotom78","id":377795,"avatar_url":"https://avatars.githubusercontent.com/u/377795?v=3","gravatar_id":"","url":"https://api.github.com/users/ziotom78","html_url":"https://github.com/ziotom78","followers_url":"https://api.github.com/users/ziotom78/followers","following_url":"https://api.github.com/users/ziotom78/following{/other_user}","gists_url":"https://api.github.com/users/ziotom78/gists{/gist_id}","starred_url":"https://api.github.com/users/ziotom78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziotom78/subscriptions","organizations_url":"https://api.github.com/users/ziotom78/orgs","repos_url":"https://api.github.com/users/ziotom78/repos","events_url":"https://api.github.com/users/ziotom78/events{/privacy}","received_events_url":"https://api.github.com/users/ziotom78/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T20:02:43Z","updated_at":"2015-05-04T20:02:43Z","body":"@kbarbary , thanks a lot for this PR, as I said before I find your idea of having a low-level submodule perfect. No objections about changing `using FITSIO` into `using FITSIO.Libcfitsio`, it's a minor change that's easy to remember."}}