{"action":"created","comment":{"url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/comments/33988285","id":33988285,"diff_hunk":"@@ -0,0 +1,51 @@\n+/****************** SPLIT STRING *******************/\n+\n+\n+CREATE PROCEDURE split_string(IN schema_name VARCHAR(255), IN table_name VARCHAR(255), IN column_name VARCHAR(255), IN delim VARCHAR(10))\n+BEGIN\n+\n+  -- --------------------------------------------------------------------------------------------------------------------------------------\n+  --   SPLIT STRING\n+  --   KEY/VALUE PAIR OF ORIGINAL STRINGS AND SPLIT VALUES\n+  -- --------------------------------------------------------------------------------------------------------------------------------------\n+\n+  CREATE TABLE IF NOT EXISTS split_string (","path":"procs/SplitString.sql","position":12,"original_position":12,"commit_id":"c272d25e64f19350c7e1cf35e111782f805d0c9e","original_commit_id":"c272d25e64f19350c7e1cf35e111782f805d0c9e","user":{"login":"austinarose","id":4147154,"avatar_url":"https://avatars.githubusercontent.com/u/4147154?v=3","gravatar_id":"","url":"https://api.github.com/users/austinarose","html_url":"https://github.com/austinarose","followers_url":"https://api.github.com/users/austinarose/followers","following_url":"https://api.github.com/users/austinarose/following{/other_user}","gists_url":"https://api.github.com/users/austinarose/gists{/gist_id}","starred_url":"https://api.github.com/users/austinarose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinarose/subscriptions","organizations_url":"https://api.github.com/users/austinarose/orgs","repos_url":"https://api.github.com/users/austinarose/repos","events_url":"https://api.github.com/users/austinarose/events{/privacy}","received_events_url":"https://api.github.com/users/austinarose/received_events","type":"User","site_admin":false},"body":"Another note is I've intentionally called split_list_values in custom_filters as well as again in the competitive momentum dataflow - knowing that only the distinct values will remain. This allows for the multi-value fields in custom filters without duplicating values in the output table.\r\n\r\nThe above comment about not knowing which Filter to use in the join condition is for allowing this functionality generically in custom filters. Just because we could join on b.ColumnName = 'Competition' in this case doesn't omit the necessity to create a new procedure for joins conditions to accommodate a field reference in the output table.","created_at":"2015-07-06T22:09:19Z","updated_at":"2015-07-06T22:09:19Z","html_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20#discussion_r33988285","pull_request_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/comments/33988285"},"html":{"href":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20#discussion_r33988285"},"pull_request":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20","id":39133556,"html_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20","diff_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20.diff","patch_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20.patch","issue_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/20","number":20,"state":"open","locked":false,"title":"Custom Filters - Allow Concatenated Lists","user":{"login":"austinarose","id":4147154,"avatar_url":"https://avatars.githubusercontent.com/u/4147154?v=3","gravatar_id":"","url":"https://api.github.com/users/austinarose","html_url":"https://github.com/austinarose","followers_url":"https://api.github.com/users/austinarose/followers","following_url":"https://api.github.com/users/austinarose/following{/other_user}","gists_url":"https://api.github.com/users/austinarose/gists{/gist_id}","starred_url":"https://api.github.com/users/austinarose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinarose/subscriptions","organizations_url":"https://api.github.com/users/austinarose/orgs","repos_url":"https://api.github.com/users/austinarose/repos","events_url":"https://api.github.com/users/austinarose/events{/privacy}","received_events_url":"https://api.github.com/users/austinarose/received_events","type":"User","site_admin":false},"body":"Competitive Momentum as driver","created_at":"2015-07-02T22:56:35Z","updated_at":"2015-07-06T22:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b971fc1294de93710a943be3336c3ff5cd3e7819","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20/commits","review_comments_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20/comments","review_comment_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/20/comments","statuses_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/statuses/c272d25e64f19350c7e1cf35e111782f805d0c9e","head":{"label":"austinarose:CustomFilters","ref":"CustomFilters","sha":"c272d25e64f19350c7e1cf35e111782f805d0c9e","user":{"login":"austinarose","id":4147154,"avatar_url":"https://avatars.githubusercontent.com/u/4147154?v=3","gravatar_id":"","url":"https://api.github.com/users/austinarose","html_url":"https://github.com/austinarose","followers_url":"https://api.github.com/users/austinarose/followers","following_url":"https://api.github.com/users/austinarose/following{/other_user}","gists_url":"https://api.github.com/users/austinarose/gists{/gist_id}","starred_url":"https://api.github.com/users/austinarose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinarose/subscriptions","organizations_url":"https://api.github.com/users/austinarose/orgs","repos_url":"https://api.github.com/users/austinarose/repos","events_url":"https://api.github.com/users/austinarose/events{/privacy}","received_events_url":"https://api.github.com/users/austinarose/received_events","type":"User","site_admin":false},"repo":{"id":34423774,"name":"DomoStrategicSolutionsData","full_name":"austinarose/DomoStrategicSolutionsData","owner":{"login":"austinarose","id":4147154,"avatar_url":"https://avatars.githubusercontent.com/u/4147154?v=3","gravatar_id":"","url":"https://api.github.com/users/austinarose","html_url":"https://github.com/austinarose","followers_url":"https://api.github.com/users/austinarose/followers","following_url":"https://api.github.com/users/austinarose/following{/other_user}","gists_url":"https://api.github.com/users/austinarose/gists{/gist_id}","starred_url":"https://api.github.com/users/austinarose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinarose/subscriptions","organizations_url":"https://api.github.com/users/austinarose/orgs","repos_url":"https://api.github.com/users/austinarose/repos","events_url":"https://api.github.com/users/austinarose/events{/privacy}","received_events_url":"https://api.github.com/users/austinarose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/austinarose/DomoStrategicSolutionsData","description":"Stored procedures used in Domo Apps","fork":true,"url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData","forks_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/forks","keys_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/keys{/key_id}","collaborators_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/teams","hooks_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/hooks","issue_events_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/issues/events{/number}","events_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/events","assignees_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/assignees{/user}","branches_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/branches{/branch}","tags_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/tags","blobs_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/git/refs{/sha}","trees_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/git/trees{/sha}","statuses_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/statuses/{sha}","languages_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/languages","stargazers_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/stargazers","contributors_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/contributors","subscribers_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/subscribers","subscription_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/subscription","commits_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/commits{/sha}","git_commits_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/git/commits{/sha}","comments_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/comments{/number}","issue_comment_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/issues/comments{/number}","contents_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/contents/{+path}","compare_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/compare/{base}...{head}","merges_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/merges","archive_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/downloads","issues_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/issues{/number}","pulls_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/pulls{/number}","milestones_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/milestones{/number}","notifications_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/labels{/name}","releases_url":"https://api.github.com/repos/austinarose/DomoStrategicSolutionsData/releases{/id}","created_at":"2015-04-23T00:24:30Z","updated_at":"2015-05-04T18:50:57Z","pushed_at":"2015-07-06T17:19:57Z","git_url":"git://github.com/austinarose/DomoStrategicSolutionsData.git","ssh_url":"git@github.com:austinarose/DomoStrategicSolutionsData.git","clone_url":"https://github.com/austinarose/DomoStrategicSolutionsData.git","svn_url":"https://github.com/austinarose/DomoStrategicSolutionsData","homepage":"","size":319,"stargazers_count":0,"watchers_count":0,"language":"SQLPL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DomoStrategicSolutionsData:master","ref":"master","sha":"624befb6a2a9143d26618fdc2567166d6b02cdd0","user":{"login":"DomoStrategicSolutionsData","id":11931126,"avatar_url":"https://avatars.githubusercontent.com/u/11931126?v=3","gravatar_id":"","url":"https://api.github.com/users/DomoStrategicSolutionsData","html_url":"https://github.com/DomoStrategicSolutionsData","followers_url":"https://api.github.com/users/DomoStrategicSolutionsData/followers","following_url":"https://api.github.com/users/DomoStrategicSolutionsData/following{/other_user}","gists_url":"https://api.github.com/users/DomoStrategicSolutionsData/gists{/gist_id}","starred_url":"https://api.github.com/users/DomoStrategicSolutionsData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomoStrategicSolutionsData/subscriptions","organizations_url":"https://api.github.com/users/DomoStrategicSolutionsData/orgs","repos_url":"https://api.github.com/users/DomoStrategicSolutionsData/repos","events_url":"https://api.github.com/users/DomoStrategicSolutionsData/events{/privacy}","received_events_url":"https://api.github.com/users/DomoStrategicSolutionsData/received_events","type":"Organization","site_admin":false},"repo":{"id":33889117,"name":"DomoStrategicSolutionsData","full_name":"DomoStrategicSolutionsData/DomoStrategicSolutionsData","owner":{"login":"DomoStrategicSolutionsData","id":11931126,"avatar_url":"https://avatars.githubusercontent.com/u/11931126?v=3","gravatar_id":"","url":"https://api.github.com/users/DomoStrategicSolutionsData","html_url":"https://github.com/DomoStrategicSolutionsData","followers_url":"https://api.github.com/users/DomoStrategicSolutionsData/followers","following_url":"https://api.github.com/users/DomoStrategicSolutionsData/following{/other_user}","gists_url":"https://api.github.com/users/DomoStrategicSolutionsData/gists{/gist_id}","starred_url":"https://api.github.com/users/DomoStrategicSolutionsData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomoStrategicSolutionsData/subscriptions","organizations_url":"https://api.github.com/users/DomoStrategicSolutionsData/orgs","repos_url":"https://api.github.com/users/DomoStrategicSolutionsData/repos","events_url":"https://api.github.com/users/DomoStrategicSolutionsData/events{/privacy}","received_events_url":"https://api.github.com/users/DomoStrategicSolutionsData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData","description":"Stored procedures used in Domo Apps","fork":false,"url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData","forks_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/forks","keys_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/teams","hooks_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/hooks","issue_events_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/events{/number}","events_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/events","assignees_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/assignees{/user}","branches_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/branches{/branch}","tags_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/tags","blobs_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/statuses/{sha}","languages_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/languages","stargazers_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/stargazers","contributors_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/contributors","subscribers_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/subscribers","subscription_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/subscription","commits_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/comments{/number}","contents_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/contents/{+path}","compare_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/merges","archive_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/downloads","issues_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues{/number}","pulls_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls{/number}","milestones_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/milestones{/number}","notifications_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/labels{/name}","releases_url":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/releases{/id}","created_at":"2015-04-13T19:28:30Z","updated_at":"2015-05-06T00:13:17Z","pushed_at":"2015-07-06T17:20:05Z","git_url":"git://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData.git","ssh_url":"git@github.com:DomoStrategicSolutionsData/DomoStrategicSolutionsData.git","clone_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData.git","svn_url":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData","homepage":"","size":532,"stargazers_count":0,"watchers_count":0,"language":"SQLPL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20"},"html":{"href":"https://github.com/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pull/20"},"issue":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/20"},"comments":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/DomoStrategicSolutionsData/DomoStrategicSolutionsData/statuses/c272d25e64f19350c7e1cf35e111782f805d0c9e"}}}}