{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/25204481","id":25204481,"diff_hunk":"@@ -2,71 +2,21 @@ ezbake: {\n    pe: {}\n    foss: {\n       redhat: { dependencies: [\"puppet-agent\"],\n-               # TODO: With AIO packages, ruby-load-path is now the same\n-               # across all platforms, so we don't need this. It should be\n-               # moved to a regular config file. See SERVER-331.\n-               install: [\"echo \\\\\\\"os-settings: {\\\\\\\"                         > %{buildroot}%{_sysconfdir}/%{realname}/conf.d/os-settings.conf\",\n-                         \"echo \\\\\\\"    ruby-load-path: [/opt/puppetlabs/agent/lib/ruby/vendor_ruby]\\\\\\\" >> %{buildroot}%{_sysconfdir}/%{realname}/conf.d/os-settings.conf\",\n-                         \"echo \\\\\\\"}\\\\\\\"                                      >> %{buildroot}%{_sysconfdir}/%{realname}/conf.d/os-settings.conf\" ],\n-               # This is terrible, but we need write access to puppet's\n-               # var/conf dirs, so we need to add ourselves to the group.\n-               # Then we need to chmod some dirs until the Puppet packaging\n-               # is changed to allow group write.\n-               # TODO: The Puppet agent package is currently missing some\n-               # things. We should clean this up if possible once puppet-agent\n-               # packages are settled. See SERVER-333.\n-               postinst: [\"install --directory --group=puppet --owner=puppet /var/lib/puppet/jruby-gems\",\n-                          \"usermod -d /opt/puppetlabs/agent/cache puppet\",\n-                          \"chown puppet:puppet /opt/puppetlabs/agent/cache\",\n-                          \"chmod 775 /opt/puppetlabs/agent/cache\",\n-                          \"install --directory /opt/puppetlabs/agent/cache/reports\",\n-                          \"chown puppet:puppet /opt/puppetlabs/agent/cache/reports\",\n-                          \"chmod 775 /opt/puppetlabs/agent/cache/reports\",\n-                          \"echo \\\\\\\"[master]\\\\\\\"                               > /etc/puppetlabs/agent/puppet.conf\"\n-                          \"echo \\\\\\\"vardir = /opt/puppetlabs/agent/cache\\\\\\\"   >> /etc/puppetlabs/agent/puppet.conf\",\n-                          \"echo \\\\\\\"logdir = /var/log/puppetlabs\\\\\\\"           >> /etc/puppetlabs/agent/puppet.conf\",\n-                          \"echo \\\\\\\"rundir = /var/run/puppetlabs\\\\\\\"           >> /etc/puppetlabs/agent/puppet.conf\",\n-                          \"chown puppet:puppet /etc/puppetlabs/agent/\",\n-                          \"chmod 775 /etc/puppetlabs/agent\",\n-                          \"install --directory /etc/puppetlabs/agent/ssl\",\n-                          \"chown -R puppet:puppet /etc/puppetlabs/agent/ssl\",\n-                          \"chmod -R 770 /etc/puppetlabs/agent/ssl\",\n-                          \"chown -R puppet:puppet /var/log/puppetlabs/\",\n-                          \"chmod -R 770 /var/log/puppetlabs\"]\n+               postinst: [\n+                 \"/opt/puppetlabs/puppet/bin/puppet config set --section master vardir  /opt/puppetlabs/server/data/puppetserver\",\n+                 \"/opt/puppetlabs/puppet/bin/puppet config set --section master codedir /etc/puppetlabs/code\",\n+                 \"usermod --home /opt/puppetlabs/server/data/puppetserver puppet\",\n+                 \"install --directory --owner=puppet --group=puppet --mode=775 /opt/puppetlabs/server/data\"","path":"resources/ext/ezbake.conf","position":39,"original_position":39,"commit_id":"449cfd9b9f34b7fd23586cb450a8a4c3586819a5","original_commit_id":"449cfd9b9f34b7fd23586cb450a8a4c3586819a5","user":{"login":"camlow325","id":5652737,"avatar_url":"https://avatars.githubusercontent.com/u/5652737?v=3","gravatar_id":"","url":"https://api.github.com/users/camlow325","html_url":"https://github.com/camlow325","followers_url":"https://api.github.com/users/camlow325/followers","following_url":"https://api.github.com/users/camlow325/following{/other_user}","gists_url":"https://api.github.com/users/camlow325/gists{/gist_id}","starred_url":"https://api.github.com/users/camlow325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camlow325/subscriptions","organizations_url":"https://api.github.com/users/camlow325/orgs","repos_url":"https://api.github.com/users/camlow325/repos","events_url":"https://api.github.com/users/camlow325/events{/privacy}","received_events_url":"https://api.github.com/users/camlow325/received_events","type":"User","site_admin":false},"body":"Ok, that seems reasonable.  @cprice404 - you good with that?","created_at":"2015-02-23T21:33:23Z","updated_at":"2015-02-23T21:33:23Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/411#discussion_r25204481","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/25204481"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/411#discussion_r25204481"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411","id":29833314,"html_url":"https://github.com/puppetlabs/puppet-server/pull/411","diff_url":"https://github.com/puppetlabs/puppet-server/pull/411.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/411.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411","number":411,"state":"open","locked":false,"title":"(SERVER-369) Get EL-7 Smoke Tests Passing","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"body":"This set of changes results in EL-7 smoke tests passing again, which is a step\nin the direction of getting CI green again.\n\n(SERVER-357) Change to Puppet Server Layout vardir\n\nThis patch updates puppet server to the vardir specified in the [Puppet Server\nLayout][layout].  This patch also resolves the following tickets:\n\n * (SERVER-339) Remove postinstall hacks\n * (SERVER-331) Remove os-settings.conf\n\nThis patch also updates the location of the puppet-agent dependency to the\nspecified layout value of `/opt/puppetlabs/puppet`.\n\n[layout]: https://github.com/puppetlabs/puppet-specifications/blob/af825090dba94c56d332b0e61d73395eb6eb0535/file_paths.md\n\n(SERVER-339) Override beaker default AIO paths for centos7\n\nWithout this patch the paths assumed by beaker are incorrect.  This patch\naddresses the problem by overriding the paths explicitly in the host\nconfiguration.\n\nThis is not ideal, ideally beaker would have no knowledge of platform specific\ndetails, however it does and we cannot wait around for beaker to be released so\nthis patch resolves the problem by explicitly overriding the paths for centos7.\n\nThe other host configurations should be updated once acceptance tests are green\non CentOS 7.","created_at":"2015-02-23T18:36:35Z","updated_at":"2015-02-23T21:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3e9224f5cfe10d0ac664af8581cf18ed4cf95fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/449cfd9b9f34b7fd23586cb450a8a4c3586819a5","head":{"label":"jeffmccune:s369_the_vardir_that_is_not","ref":"s369_the_vardir_that_is_not","sha":"449cfd9b9f34b7fd23586cb450a8a4c3586819a5","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"repo":{"id":26023101,"name":"puppet-server","full_name":"jeffmccune/puppet-server","owner":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmccune/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/jeffmccune/puppet-server","forks_url":"https://api.github.com/repos/jeffmccune/puppet-server/forks","keys_url":"https://api.github.com/repos/jeffmccune/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmccune/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmccune/puppet-server/teams","hooks_url":"https://api.github.com/repos/jeffmccune/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmccune/puppet-server/events","assignees_url":"https://api.github.com/repos/jeffmccune/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmccune/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/tags","blobs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmccune/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmccune/puppet-server/languages","stargazers_url":"https://api.github.com/repos/jeffmccune/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/jeffmccune/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscription","commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmccune/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmccune/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmccune/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmccune/puppet-server/merges","archive_url":"https://api.github.com/repos/jeffmccune/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmccune/puppet-server/downloads","issues_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmccune/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmccune/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmccune/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmccune/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/jeffmccune/puppet-server/releases{/id}","created_at":"2014-10-31T16:07:28Z","updated_at":"2014-12-01T21:46:54Z","pushed_at":"2015-02-23T19:49:34Z","git_url":"git://github.com/jeffmccune/puppet-server.git","ssh_url":"git@github.com:jeffmccune/puppet-server.git","clone_url":"https://github.com/jeffmccune/puppet-server.git","svn_url":"https://github.com/jeffmccune/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":1889,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"81029cab3d2f7a5de77c60541d4c63ae5eee7dca","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-02-20T19:27:39Z","pushed_at":"2015-02-23T20:23:16Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":5080,"stargazers_count":81,"watchers_count":81,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":10,"forks":41,"open_issues":10,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/411"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/449cfd9b9f34b7fd23586cb450a8a4c3586819a5"}}}}