{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/34611165","id":34611165,"diff_hunk":"@@ -1,7 +1,13 @@\n FROM golang:1.4\n \n RUN echo \"deb http://ftp.us.debian.org/debian testing main contrib\" >> /etc/apt/sources.list\n-RUN apt-get update && apt-get install -y iptables criu=1.6-2 && rm -rf /var/lib/apt/lists/*\n+RUN apt-get update && apt-get install -y iptables criu=1.6-2 git build-essential autoconf libtool && rm -rf /var/lib/apt/lists/*\n+\n+# Need Libseccomp v2.2.1\n+RUN git clone https://github.com/seccomp/libseccomp /libseccomp","path":"script/test_Dockerfile","position":8,"original_position":8,"commit_id":"1767c9ecd3e7213b957a8e5829988c0ddcb45085","original_commit_id":"1767c9ecd3e7213b957a8e5829988c0ddcb45085","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"Fair point on v2.2.3 being out - using the latest version of the v2.2 release is desirable, and I think v2.2.3 actually fixes build failures on ARM.","created_at":"2015-07-14T19:50:45Z","updated_at":"2015-07-14T19:50:45Z","html_url":"https://github.com/opencontainers/runc/pull/70#discussion_r34611165","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/34611165"},"html":{"href":"https://github.com/opencontainers/runc/pull/70#discussion_r34611165"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/70","id":38902235,"html_url":"https://github.com/opencontainers/runc/pull/70","diff_url":"https://github.com/opencontainers/runc/pull/70.diff","patch_url":"https://github.com/opencontainers/runc/pull/70.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/70","number":70,"state":"open","locked":false,"title":"Convert Seccomp support to use Libseccomp","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"This is a continuation of docker/libcontainer#633 (itself a continuation of a number of other pull requests).\r\n\r\nThe reasons for this were already stated in the previous PR, but I'll paraphrase what I said in that PR:\r\nThe library-based solution is at present a better solution than the current Golang version. Libseccomp is well-tested, well-supported, and high-performance, and removes the burden of supporting filter generation code.\r\n\r\nThe code is almost identical to the previous libcontainer PR, save a few import path changes, and exposing it via the runc Linux spec. My testing has been somewhat minimal, but everything still seems to work.","created_at":"2015-06-30T17:17:25Z","updated_at":"2015-07-14T19:50:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dd303910b72bf0c28f90ae64ee76841008bae90","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/70/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/70/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/70/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/1767c9ecd3e7213b957a8e5829988c0ddcb45085","head":{"label":"mheon:seccomp","ref":"seccomp","sha":"1767c9ecd3e7213b957a8e5829988c0ddcb45085","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"repo":{"id":38123313,"name":"runc","full_name":"mheon/runc","owner":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mheon/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/mheon/runc","forks_url":"https://api.github.com/repos/mheon/runc/forks","keys_url":"https://api.github.com/repos/mheon/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mheon/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mheon/runc/teams","hooks_url":"https://api.github.com/repos/mheon/runc/hooks","issue_events_url":"https://api.github.com/repos/mheon/runc/issues/events{/number}","events_url":"https://api.github.com/repos/mheon/runc/events","assignees_url":"https://api.github.com/repos/mheon/runc/assignees{/user}","branches_url":"https://api.github.com/repos/mheon/runc/branches{/branch}","tags_url":"https://api.github.com/repos/mheon/runc/tags","blobs_url":"https://api.github.com/repos/mheon/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mheon/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mheon/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mheon/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mheon/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/mheon/runc/languages","stargazers_url":"https://api.github.com/repos/mheon/runc/stargazers","contributors_url":"https://api.github.com/repos/mheon/runc/contributors","subscribers_url":"https://api.github.com/repos/mheon/runc/subscribers","subscription_url":"https://api.github.com/repos/mheon/runc/subscription","commits_url":"https://api.github.com/repos/mheon/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mheon/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mheon/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mheon/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mheon/runc/contents/{+path}","compare_url":"https://api.github.com/repos/mheon/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mheon/runc/merges","archive_url":"https://api.github.com/repos/mheon/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mheon/runc/downloads","issues_url":"https://api.github.com/repos/mheon/runc/issues{/number}","pulls_url":"https://api.github.com/repos/mheon/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/mheon/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/mheon/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mheon/runc/labels{/name}","releases_url":"https://api.github.com/repos/mheon/runc/releases{/id}","created_at":"2015-06-26T17:05:39Z","updated_at":"2015-06-26T17:05:39Z","pushed_at":"2015-07-14T17:32:43Z","git_url":"git://github.com/mheon/runc.git","ssh_url":"git@github.com:mheon/runc.git","clone_url":"https://github.com/mheon/runc.git","svn_url":"https://github.com/mheon/runc","homepage":"","size":1842,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"0d12ac20c71b624e7acae19d5e51caa4fc16f8e4","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"runc container cli tools","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","created_at":"2015-06-05T23:30:45Z","updated_at":"2015-07-14T19:31:32Z","pushed_at":"2015-07-14T17:50:21Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"","size":4134,"stargazers_count":1697,"watchers_count":1697,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":32,"forks":126,"open_issues":32,"watchers":1697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/70"},"html":{"href":"https://github.com/opencontainers/runc/pull/70"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/70"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/1767c9ecd3e7213b957a8e5829988c0ddcb45085"}}}}