{"action":"created","issue":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/1171","labels_url":"https://api.github.com/repos/torchbox/wagtail/issues/1171/labels{/name}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/1171/comments","events_url":"https://api.github.com/repos/torchbox/wagtail/issues/1171/events","html_url":"https://github.com/torchbox/wagtail/pull/1171","id":67713746,"number":1171,"title":"Feature/airbnbify","user":{"login":"JoshBarr","id":1715456,"avatar_url":"https://avatars.githubusercontent.com/u/1715456?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBarr","html_url":"https://github.com/JoshBarr","followers_url":"https://api.github.com/users/JoshBarr/followers","following_url":"https://api.github.com/users/JoshBarr/following{/other_user}","gists_url":"https://api.github.com/users/JoshBarr/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBarr/subscriptions","organizations_url":"https://api.github.com/users/JoshBarr/orgs","repos_url":"https://api.github.com/users/JoshBarr/repos","events_url":"https://api.github.com/users/JoshBarr/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBarr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-11T00:54:27Z","updated_at":"2015-04-11T14:09:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/1171","html_url":"https://github.com/torchbox/wagtail/pull/1171","diff_url":"https://github.com/torchbox/wagtail/pull/1171.diff","patch_url":"https://github.com/torchbox/wagtail/pull/1171.patch"},"body":"Addresses #1157, conforming Javascript to Airbnb style guidelines. \r\n\r\nAdds two commands to the makefile:\r\n\r\n```shell\r\n# Runs a lint on the project\r\nmake lint-js\r\n\r\n# Safely formats Javascript to the Airbnb style.\r\nmake format-js\r\n```\r\n\r\nThis is achieved by some very lightweight nodejs tooling. A front-end dev who wishes to run the commands will need to run an npm install from the wagtial directory. I'm leaving out of tox.ini and setup.py node as a hard dependency until we reach a decision on the JS workflow. \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/comments/91851221","html_url":"https://github.com/torchbox/wagtail/pull/1171#issuecomment-91851221","issue_url":"https://api.github.com/repos/torchbox/wagtail/issues/1171","id":91851221,"user":{"login":"JoshBarr","id":1715456,"avatar_url":"https://avatars.githubusercontent.com/u/1715456?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshBarr","html_url":"https://github.com/JoshBarr","followers_url":"https://api.github.com/users/JoshBarr/followers","following_url":"https://api.github.com/users/JoshBarr/following{/other_user}","gists_url":"https://api.github.com/users/JoshBarr/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshBarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshBarr/subscriptions","organizations_url":"https://api.github.com/users/JoshBarr/orgs","repos_url":"https://api.github.com/users/JoshBarr/repos","events_url":"https://api.github.com/users/JoshBarr/events{/privacy}","received_events_url":"https://api.github.com/users/JoshBarr/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T14:09:21Z","updated_at":"2015-04-11T14:09:21Z","body":"It's strange that the linter didn't seem to care too much about those! I've added it to the configuration. \r\n\r\nI've also gone through and addressed some of the things that required manual fixing, mainly dealing with single/double quote mark inconsistencies and whitespace after statements. \r\n\r\nOne small change was to camelCase the very few snake_case variables declared in the Javascript itself (not accessing data from AJAX calls), such as [here](https://github.com/torchbox/wagtail/pull/1171/files#diff-d1a0e1b01ba27cd28868e27b68f23b97L88). \r\n\r\nLet me know if you spot anything else and I'll get it fixed up.\r\n\r\n\r\n"}}