{"action":"opened","number":30,"pull_request":{"url":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30","id":43109120,"html_url":"https://github.com/cnect/sails-sqlserver/pull/30","diff_url":"https://github.com/cnect/sails-sqlserver/pull/30.diff","patch_url":"https://github.com/cnect/sails-sqlserver/pull/30.patch","issue_url":"https://api.github.com/repos/cnect/sails-sqlserver/issues/30","number":30,"state":"open","locked":false,"title":"Use callback with connection.connect() instead of promise","user":{"login":"cwfa","id":10607536,"avatar_url":"https://avatars.githubusercontent.com/u/10607536?v=3","gravatar_id":"","url":"https://api.github.com/users/cwfa","html_url":"https://github.com/cwfa","followers_url":"https://api.github.com/users/cwfa/followers","following_url":"https://api.github.com/users/cwfa/following{/other_user}","gists_url":"https://api.github.com/users/cwfa/gists{/gist_id}","starred_url":"https://api.github.com/users/cwfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwfa/subscriptions","organizations_url":"https://api.github.com/users/cwfa/orgs","repos_url":"https://api.github.com/users/cwfa/repos","events_url":"https://api.github.com/users/cwfa/events{/privacy}","received_events_url":"https://api.github.com/users/cwfa/received_events","type":"User","site_admin":false},"body":"The code currently uses a promise with connection.connect, but only passes one of the two necessary functions (success and error). When an error occurs, there's no way for it to surface because no error function was given. I've updated this to simply use a callback","created_at":"2015-08-22T19:50:29Z","updated_at":"2015-08-22T19:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847ca003ef01f2995d5cdfb07c3a1392a8e60c55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30/commits","review_comments_url":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30/comments","review_comment_url":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cnect/sails-sqlserver/issues/30/comments","statuses_url":"https://api.github.com/repos/cnect/sails-sqlserver/statuses/9d8536d267dd76cb51d73d45148e70df5d84f1bd","head":{"label":"cwfa:master","ref":"master","sha":"9d8536d267dd76cb51d73d45148e70df5d84f1bd","user":{"login":"cwfa","id":10607536,"avatar_url":"https://avatars.githubusercontent.com/u/10607536?v=3","gravatar_id":"","url":"https://api.github.com/users/cwfa","html_url":"https://github.com/cwfa","followers_url":"https://api.github.com/users/cwfa/followers","following_url":"https://api.github.com/users/cwfa/following{/other_user}","gists_url":"https://api.github.com/users/cwfa/gists{/gist_id}","starred_url":"https://api.github.com/users/cwfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwfa/subscriptions","organizations_url":"https://api.github.com/users/cwfa/orgs","repos_url":"https://api.github.com/users/cwfa/repos","events_url":"https://api.github.com/users/cwfa/events{/privacy}","received_events_url":"https://api.github.com/users/cwfa/received_events","type":"User","site_admin":false},"repo":{"id":40385005,"name":"sails-sqlserver","full_name":"cwfa/sails-sqlserver","owner":{"login":"cwfa","id":10607536,"avatar_url":"https://avatars.githubusercontent.com/u/10607536?v=3","gravatar_id":"","url":"https://api.github.com/users/cwfa","html_url":"https://github.com/cwfa","followers_url":"https://api.github.com/users/cwfa/followers","following_url":"https://api.github.com/users/cwfa/following{/other_user}","gists_url":"https://api.github.com/users/cwfa/gists{/gist_id}","starred_url":"https://api.github.com/users/cwfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwfa/subscriptions","organizations_url":"https://api.github.com/users/cwfa/orgs","repos_url":"https://api.github.com/users/cwfa/repos","events_url":"https://api.github.com/users/cwfa/events{/privacy}","received_events_url":"https://api.github.com/users/cwfa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwfa/sails-sqlserver","description":"Official Microsoft SQL Server Adapter for sails.js, by","fork":true,"url":"https://api.github.com/repos/cwfa/sails-sqlserver","forks_url":"https://api.github.com/repos/cwfa/sails-sqlserver/forks","keys_url":"https://api.github.com/repos/cwfa/sails-sqlserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwfa/sails-sqlserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwfa/sails-sqlserver/teams","hooks_url":"https://api.github.com/repos/cwfa/sails-sqlserver/hooks","issue_events_url":"https://api.github.com/repos/cwfa/sails-sqlserver/issues/events{/number}","events_url":"https://api.github.com/repos/cwfa/sails-sqlserver/events","assignees_url":"https://api.github.com/repos/cwfa/sails-sqlserver/assignees{/user}","branches_url":"https://api.github.com/repos/cwfa/sails-sqlserver/branches{/branch}","tags_url":"https://api.github.com/repos/cwfa/sails-sqlserver/tags","blobs_url":"https://api.github.com/repos/cwfa/sails-sqlserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwfa/sails-sqlserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwfa/sails-sqlserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwfa/sails-sqlserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwfa/sails-sqlserver/statuses/{sha}","languages_url":"https://api.github.com/repos/cwfa/sails-sqlserver/languages","stargazers_url":"https://api.github.com/repos/cwfa/sails-sqlserver/stargazers","contributors_url":"https://api.github.com/repos/cwfa/sails-sqlserver/contributors","subscribers_url":"https://api.github.com/repos/cwfa/sails-sqlserver/subscribers","subscription_url":"https://api.github.com/repos/cwfa/sails-sqlserver/subscription","commits_url":"https://api.github.com/repos/cwfa/sails-sqlserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwfa/sails-sqlserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwfa/sails-sqlserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwfa/sails-sqlserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwfa/sails-sqlserver/contents/{+path}","compare_url":"https://api.github.com/repos/cwfa/sails-sqlserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwfa/sails-sqlserver/merges","archive_url":"https://api.github.com/repos/cwfa/sails-sqlserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwfa/sails-sqlserver/downloads","issues_url":"https://api.github.com/repos/cwfa/sails-sqlserver/issues{/number}","pulls_url":"https://api.github.com/repos/cwfa/sails-sqlserver/pulls{/number}","milestones_url":"https://api.github.com/repos/cwfa/sails-sqlserver/milestones{/number}","notifications_url":"https://api.github.com/repos/cwfa/sails-sqlserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwfa/sails-sqlserver/labels{/name}","releases_url":"https://api.github.com/repos/cwfa/sails-sqlserver/releases{/id}","created_at":"2015-08-07T23:30:26Z","updated_at":"2015-08-07T23:30:27Z","pushed_at":"2015-08-10T02:01:22Z","git_url":"git://github.com/cwfa/sails-sqlserver.git","ssh_url":"git@github.com:cwfa/sails-sqlserver.git","clone_url":"https://github.com/cwfa/sails-sqlserver.git","svn_url":"https://github.com/cwfa/sails-sqlserver","homepage":"http://www.cnectdata.com","size":187,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cnect:master","ref":"master","sha":"f764cfb557f777812c39eb7d07d4f21cca8d1798","user":{"login":"cnect","id":10492338,"avatar_url":"https://avatars.githubusercontent.com/u/10492338?v=3","gravatar_id":"","url":"https://api.github.com/users/cnect","html_url":"https://github.com/cnect","followers_url":"https://api.github.com/users/cnect/followers","following_url":"https://api.github.com/users/cnect/following{/other_user}","gists_url":"https://api.github.com/users/cnect/gists{/gist_id}","starred_url":"https://api.github.com/users/cnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnect/subscriptions","organizations_url":"https://api.github.com/users/cnect/orgs","repos_url":"https://api.github.com/users/cnect/repos","events_url":"https://api.github.com/users/cnect/events{/privacy}","received_events_url":"https://api.github.com/users/cnect/received_events","type":"Organization","site_admin":false},"repo":{"id":29316851,"name":"sails-sqlserver","full_name":"cnect/sails-sqlserver","owner":{"login":"cnect","id":10492338,"avatar_url":"https://avatars.githubusercontent.com/u/10492338?v=3","gravatar_id":"","url":"https://api.github.com/users/cnect","html_url":"https://github.com/cnect","followers_url":"https://api.github.com/users/cnect/followers","following_url":"https://api.github.com/users/cnect/following{/other_user}","gists_url":"https://api.github.com/users/cnect/gists{/gist_id}","starred_url":"https://api.github.com/users/cnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnect/subscriptions","organizations_url":"https://api.github.com/users/cnect/orgs","repos_url":"https://api.github.com/users/cnect/repos","events_url":"https://api.github.com/users/cnect/events{/privacy}","received_events_url":"https://api.github.com/users/cnect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cnect/sails-sqlserver","description":"Official Microsoft SQL Server Adapter for sails.js, by","fork":true,"url":"https://api.github.com/repos/cnect/sails-sqlserver","forks_url":"https://api.github.com/repos/cnect/sails-sqlserver/forks","keys_url":"https://api.github.com/repos/cnect/sails-sqlserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnect/sails-sqlserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnect/sails-sqlserver/teams","hooks_url":"https://api.github.com/repos/cnect/sails-sqlserver/hooks","issue_events_url":"https://api.github.com/repos/cnect/sails-sqlserver/issues/events{/number}","events_url":"https://api.github.com/repos/cnect/sails-sqlserver/events","assignees_url":"https://api.github.com/repos/cnect/sails-sqlserver/assignees{/user}","branches_url":"https://api.github.com/repos/cnect/sails-sqlserver/branches{/branch}","tags_url":"https://api.github.com/repos/cnect/sails-sqlserver/tags","blobs_url":"https://api.github.com/repos/cnect/sails-sqlserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnect/sails-sqlserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnect/sails-sqlserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnect/sails-sqlserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnect/sails-sqlserver/statuses/{sha}","languages_url":"https://api.github.com/repos/cnect/sails-sqlserver/languages","stargazers_url":"https://api.github.com/repos/cnect/sails-sqlserver/stargazers","contributors_url":"https://api.github.com/repos/cnect/sails-sqlserver/contributors","subscribers_url":"https://api.github.com/repos/cnect/sails-sqlserver/subscribers","subscription_url":"https://api.github.com/repos/cnect/sails-sqlserver/subscription","commits_url":"https://api.github.com/repos/cnect/sails-sqlserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnect/sails-sqlserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnect/sails-sqlserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnect/sails-sqlserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnect/sails-sqlserver/contents/{+path}","compare_url":"https://api.github.com/repos/cnect/sails-sqlserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnect/sails-sqlserver/merges","archive_url":"https://api.github.com/repos/cnect/sails-sqlserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnect/sails-sqlserver/downloads","issues_url":"https://api.github.com/repos/cnect/sails-sqlserver/issues{/number}","pulls_url":"https://api.github.com/repos/cnect/sails-sqlserver/pulls{/number}","milestones_url":"https://api.github.com/repos/cnect/sails-sqlserver/milestones{/number}","notifications_url":"https://api.github.com/repos/cnect/sails-sqlserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnect/sails-sqlserver/labels{/name}","releases_url":"https://api.github.com/repos/cnect/sails-sqlserver/releases{/id}","created_at":"2015-01-15T20:32:25Z","updated_at":"2015-08-08T17:03:31Z","pushed_at":"2015-08-22T19:50:29Z","git_url":"git://github.com/cnect/sails-sqlserver.git","ssh_url":"git@github.com:cnect/sails-sqlserver.git","clone_url":"https://github.com/cnect/sails-sqlserver.git","svn_url":"https://github.com/cnect/sails-sqlserver","homepage":"http://www.cnectdata.com","size":539,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":11,"forks":22,"open_issues":11,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30"},"html":{"href":"https://github.com/cnect/sails-sqlserver/pull/30"},"issue":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/issues/30"},"comments":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/cnect/sails-sqlserver/statuses/9d8536d267dd76cb51d73d45148e70df5d84f1bd"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}