{"action":"created","comment":{"url":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/22864566","id":22864566,"diff_hunk":"@@ -60,67 +60,67 @@ def _indtosub_converter(dims, order='F', onebased=True):\n     Series.indtosub\n     \"\"\"\n \n-    _check_order(order)\n+    _checkOrder(order)\n \n-    def indtosub_inline_onebased(k, dimprod):\n-        return tuple(map(lambda (x, y): int(mod(ceil(float(k)/y) - 1, x) + 1), dimprod))\n+    def indToSub_InlineOneBased(k, dimProd_):\n+        return tuple(map(lambda (x, y): int(mod(ceil(float(k)/y) - 1, x) + 1), dimProd_))\n \n-    def indtosub_inline_zerobased(k, dimprod):\n-        return tuple(map(lambda (x, y): int(mod(ceil(float(k+1)/y) - 1, x)), dimprod))\n+    def indToSub_InlineZeroBased(k, dimProd_):\n+        return tuple(map(lambda (x, y): int(mod(ceil(float(k+1)/y) - 1, x)), dimProd_))\n \n-    inline_fcn = indtosub_inline_onebased if onebased else indtosub_inline_zerobased\n+    inlineFcn = indToSub_InlineOneBased if isOneBased else indToSub_InlineZeroBased\n \n     if size(dims) > 1:\n         if order == 'F':\n-            dimprod = zip(dims, append(1, cumprod(dims)[0:-1]))\n+            dimProd = zip(dims, append(1, cumprod(dims)[0:-1]))\n         else:\n-            dimprod = zip(dims, append(1, cumprod(dims[::-1])[0:-1])[::-1])\n-        converter = lambda k: inline_fcn(k, dimprod)\n+            dimProd = zip(dims, append(1, cumprod(dims[::-1])[0:-1])[::-1])\n+        converter = lambda k: inlineFcn(k, dimProd)\n     else:\n         converter = lambda k: (k,)\n \n     return converter\n \n \n-def _subtoind_converter(dims, order='F', onebased=True):\n+def _subToIndConverter(dims, order='F', isOneBased=True):\n     \"\"\"Converter for changing subscript indexing to linear indexing\n \n     See also\n     --------\n     Series.subtoind\n     \"\"\"\n-    _check_order(order)\n+    _checkOrder(order)\n \n-    def onebased_prod(x_y):\n-        x, y = x_y\n+    def onebasedProd(xy):\n+        x, y = xy\n         return (x - 1) * y\n \n-    def zerobased_prod(x_y):\n-        x, y = x_y\n+    def zerobasedProd(xy):\n+        x, y = xy\n         return x * y\n \n-    def subtoind_inline_colmajor(k, dimprod, p_func):\n-        return sum(map(p_func, zip(k[1:], dimprod))) + k[0]\n+    def subToInd_InlineColmajor(k, dimProd_, prodFunc):","path":"python/thunder/rdds/keys.py","position":78,"original_position":78,"commit_id":"a6e18ea2db0656c31b3facf6ef3c5fbc2b896280","original_commit_id":"a6e18ea2db0656c31b3facf6ef3c5fbc2b896280","user":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=3","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"body":"Hobgoblin of little minds, @freeman-lab. ;)\r\n\r\nYeah, here (and to some degree in the other remaining underscore) I thought that the underscore was useful in separating components of the name. subToIndInlineColmajor - are \"subs\" being converted to \"IndInlineColmajors\"? This version I think keeps it more clear that it's the \"InlineColmajor\" flavor of \"subToInd\"","created_at":"2015-01-13T14:30:46Z","updated_at":"2015-01-13T14:30:46Z","html_url":"https://github.com/freeman-lab/thunder/pull/75#discussion_r22864566","pull_request_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/22864566"},"html":{"href":"https://github.com/freeman-lab/thunder/pull/75#discussion_r22864566"},"pull_request":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/freeman-lab/thunder/pulls/75","id":26914897,"html_url":"https://github.com/freeman-lab/thunder/pull/75","diff_url":"https://github.com/freeman-lab/thunder/pull/75.diff","patch_url":"https://github.com/freeman-lab/thunder/pull/75.patch","issue_url":"https://api.github.com/repos/freeman-lab/thunder/issues/75","number":75,"state":"open","locked":false,"title":"Camel casing","user":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=3","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"body":"Minor updates across the code base for better consistency with the style guide (docs/style_guide.rst). \r\n\r\nMost changes are to variable and method names, moving from an inconsistent mix of camel-casing, underscores, and all-lowercase to a more uniform use of camel casing throughout. ","created_at":"2015-01-06T20:18:38Z","updated_at":"2015-01-13T14:30:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ec7c6ec58e9cb7f2f0bc2bf9e32c6880bc0a603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/75/commits","review_comments_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/75/comments","review_comment_url":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/{number}","comments_url":"https://api.github.com/repos/freeman-lab/thunder/issues/75/comments","statuses_url":"https://api.github.com/repos/freeman-lab/thunder/statuses/a6e18ea2db0656c31b3facf6ef3c5fbc2b896280","head":{"label":"industrial-sloth:camelCasing","ref":"camelCasing","sha":"a6e18ea2db0656c31b3facf6ef3c5fbc2b896280","user":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=3","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"repo":{"id":23590305,"name":"thunder","full_name":"industrial-sloth/thunder","owner":{"login":"industrial-sloth","id":8592708,"avatar_url":"https://avatars.githubusercontent.com/u/8592708?v=3","gravatar_id":"","url":"https://api.github.com/users/industrial-sloth","html_url":"https://github.com/industrial-sloth","followers_url":"https://api.github.com/users/industrial-sloth/followers","following_url":"https://api.github.com/users/industrial-sloth/following{/other_user}","gists_url":"https://api.github.com/users/industrial-sloth/gists{/gist_id}","starred_url":"https://api.github.com/users/industrial-sloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/industrial-sloth/subscriptions","organizations_url":"https://api.github.com/users/industrial-sloth/orgs","repos_url":"https://api.github.com/users/industrial-sloth/repos","events_url":"https://api.github.com/users/industrial-sloth/events{/privacy}","received_events_url":"https://api.github.com/users/industrial-sloth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/industrial-sloth/thunder","description":"Large-scale neural data analysis with Spark","fork":true,"url":"https://api.github.com/repos/industrial-sloth/thunder","forks_url":"https://api.github.com/repos/industrial-sloth/thunder/forks","keys_url":"https://api.github.com/repos/industrial-sloth/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/industrial-sloth/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/industrial-sloth/thunder/teams","hooks_url":"https://api.github.com/repos/industrial-sloth/thunder/hooks","issue_events_url":"https://api.github.com/repos/industrial-sloth/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/industrial-sloth/thunder/events","assignees_url":"https://api.github.com/repos/industrial-sloth/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/industrial-sloth/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/industrial-sloth/thunder/tags","blobs_url":"https://api.github.com/repos/industrial-sloth/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/industrial-sloth/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/industrial-sloth/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/industrial-sloth/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/industrial-sloth/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/industrial-sloth/thunder/languages","stargazers_url":"https://api.github.com/repos/industrial-sloth/thunder/stargazers","contributors_url":"https://api.github.com/repos/industrial-sloth/thunder/contributors","subscribers_url":"https://api.github.com/repos/industrial-sloth/thunder/subscribers","subscription_url":"https://api.github.com/repos/industrial-sloth/thunder/subscription","commits_url":"https://api.github.com/repos/industrial-sloth/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/industrial-sloth/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/industrial-sloth/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/industrial-sloth/thunder/issues/comments/{number}","contents_url":"https://api.github.com/repos/industrial-sloth/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/industrial-sloth/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/industrial-sloth/thunder/merges","archive_url":"https://api.github.com/repos/industrial-sloth/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/industrial-sloth/thunder/downloads","issues_url":"https://api.github.com/repos/industrial-sloth/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/industrial-sloth/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/industrial-sloth/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/industrial-sloth/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/industrial-sloth/thunder/labels{/name}","releases_url":"https://api.github.com/repos/industrial-sloth/thunder/releases{/id}","created_at":"2014-09-02T18:23:57Z","updated_at":"2015-01-08T16:25:27Z","pushed_at":"2015-01-08T16:25:27Z","git_url":"git://github.com/industrial-sloth/thunder.git","ssh_url":"git@github.com:industrial-sloth/thunder.git","clone_url":"https://github.com/industrial-sloth/thunder.git","svn_url":"https://github.com/industrial-sloth/thunder","homepage":"","size":31797,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeman-lab:master","ref":"master","sha":"2488c9928ced4b7f2257887ee2aedbb049c665de","user":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=3","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"repo":{"id":10616272,"name":"thunder","full_name":"freeman-lab/thunder","owner":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=3","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freeman-lab/thunder","description":"Large-scale neural data analysis with Spark","fork":false,"url":"https://api.github.com/repos/freeman-lab/thunder","forks_url":"https://api.github.com/repos/freeman-lab/thunder/forks","keys_url":"https://api.github.com/repos/freeman-lab/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeman-lab/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeman-lab/thunder/teams","hooks_url":"https://api.github.com/repos/freeman-lab/thunder/hooks","issue_events_url":"https://api.github.com/repos/freeman-lab/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/freeman-lab/thunder/events","assignees_url":"https://api.github.com/repos/freeman-lab/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/freeman-lab/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/freeman-lab/thunder/tags","blobs_url":"https://api.github.com/repos/freeman-lab/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeman-lab/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeman-lab/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeman-lab/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeman-lab/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/freeman-lab/thunder/languages","stargazers_url":"https://api.github.com/repos/freeman-lab/thunder/stargazers","contributors_url":"https://api.github.com/repos/freeman-lab/thunder/contributors","subscribers_url":"https://api.github.com/repos/freeman-lab/thunder/subscribers","subscription_url":"https://api.github.com/repos/freeman-lab/thunder/subscription","commits_url":"https://api.github.com/repos/freeman-lab/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeman-lab/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeman-lab/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeman-lab/thunder/issues/comments/{number}","contents_url":"https://api.github.com/repos/freeman-lab/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/freeman-lab/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeman-lab/thunder/merges","archive_url":"https://api.github.com/repos/freeman-lab/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeman-lab/thunder/downloads","issues_url":"https://api.github.com/repos/freeman-lab/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/freeman-lab/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/freeman-lab/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/freeman-lab/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeman-lab/thunder/labels{/name}","releases_url":"https://api.github.com/repos/freeman-lab/thunder/releases{/id}","created_at":"2013-06-11T07:00:47Z","updated_at":"2015-01-13T09:30:11Z","pushed_at":"2015-01-13T05:59:44Z","git_url":"git://github.com/freeman-lab/thunder.git","ssh_url":"git@github.com:freeman-lab/thunder.git","clone_url":"https://github.com/freeman-lab/thunder.git","svn_url":"https://github.com/freeman-lab/thunder","homepage":"","size":43484,"stargazers_count":235,"watchers_count":235,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":6,"forks":53,"open_issues":6,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/75"},"html":{"href":"https://github.com/freeman-lab/thunder/pull/75"},"issue":{"href":"https://api.github.com/repos/freeman-lab/thunder/issues/75"},"comments":{"href":"https://api.github.com/repos/freeman-lab/thunder/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/freeman-lab/thunder/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/freeman-lab/thunder/statuses/a6e18ea2db0656c31b3facf6ef3c5fbc2b896280"}}}}