{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/feign/pulls/comments/47596793","id":47596793,"diff_hunk":"@@ -33,11 +33,13 @@\n import feign.RequestLine;\n import feign.Response;\n \n-import static feign.Util.UTF_8;\n-import static feign.assertj.MockWebServerAssertions.assertThat;\n import static java.util.Arrays.asList;\n+\n import static org.junit.Assert.assertEquals;\n \n+import static feign.Util.UTF_8;","path":"httpclient/src/test/java/feign/httpclient/ApacheHttpClientTest.java","position":30,"original_position":30,"commit_id":"b61285e45b1dbdf7508fac4ed240fcff3f134584","original_commit_id":"b61285e45b1dbdf7508fac4ed240fcff3f134584","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"similarly, please revert the import change so we know what's different (if anything)","created_at":"2015-12-15T04:57:03Z","updated_at":"2015-12-15T04:57:03Z","html_url":"https://github.com/Netflix/feign/pull/302#discussion_r47596793","pull_request_url":"https://api.github.com/repos/Netflix/feign/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/Netflix/feign/pulls/comments/47596793"},"html":{"href":"https://github.com/Netflix/feign/pull/302#discussion_r47596793"},"pull_request":{"href":"https://api.github.com/repos/Netflix/feign/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/feign/pulls/302","id":53654755,"html_url":"https://github.com/Netflix/feign/pull/302","diff_url":"https://github.com/Netflix/feign/pull/302.diff","patch_url":"https://github.com/Netflix/feign/pull/302.patch","issue_url":"https://api.github.com/repos/Netflix/feign/issues/302","number":302,"state":"open","locked":false,"title":"Allow responses to be streamed.","user":{"login":"cakofony","id":3854321,"avatar_url":"https://avatars.githubusercontent.com/u/3854321?v=3","gravatar_id":"","url":"https://api.github.com/users/cakofony","html_url":"https://github.com/cakofony","followers_url":"https://api.github.com/users/cakofony/followers","following_url":"https://api.github.com/users/cakofony/following{/other_user}","gists_url":"https://api.github.com/users/cakofony/gists{/gist_id}","starred_url":"https://api.github.com/users/cakofony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakofony/subscriptions","organizations_url":"https://api.github.com/users/cakofony/orgs","repos_url":"https://api.github.com/users/cakofony/repos","events_url":"https://api.github.com/users/cakofony/events{/privacy}","received_events_url":"https://api.github.com/users/cakofony/received_events","type":"User","site_admin":false},"body":"Never expands >8kb responses into memory\r\n\r\nIt seems less dangerous to avoid closing Response objects than to explode large responses in memory","created_at":"2015-12-15T03:08:59Z","updated_at":"2015-12-15T04:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be7847a78ed1a6d01963e85217a3e6f0c1788f56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/feign/pulls/302/commits","review_comments_url":"https://api.github.com/repos/Netflix/feign/pulls/302/comments","review_comment_url":"https://api.github.com/repos/Netflix/feign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/feign/issues/302/comments","statuses_url":"https://api.github.com/repos/Netflix/feign/statuses/b61285e45b1dbdf7508fac4ed240fcff3f134584","head":{"label":"cakofony:ckozak/stream_response","ref":"ckozak/stream_response","sha":"b61285e45b1dbdf7508fac4ed240fcff3f134584","user":{"login":"cakofony","id":3854321,"avatar_url":"https://avatars.githubusercontent.com/u/3854321?v=3","gravatar_id":"","url":"https://api.github.com/users/cakofony","html_url":"https://github.com/cakofony","followers_url":"https://api.github.com/users/cakofony/followers","following_url":"https://api.github.com/users/cakofony/following{/other_user}","gists_url":"https://api.github.com/users/cakofony/gists{/gist_id}","starred_url":"https://api.github.com/users/cakofony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakofony/subscriptions","organizations_url":"https://api.github.com/users/cakofony/orgs","repos_url":"https://api.github.com/users/cakofony/repos","events_url":"https://api.github.com/users/cakofony/events{/privacy}","received_events_url":"https://api.github.com/users/cakofony/received_events","type":"User","site_admin":false},"repo":{"id":48015792,"name":"feign","full_name":"cakofony/feign","owner":{"login":"cakofony","id":3854321,"avatar_url":"https://avatars.githubusercontent.com/u/3854321?v=3","gravatar_id":"","url":"https://api.github.com/users/cakofony","html_url":"https://github.com/cakofony","followers_url":"https://api.github.com/users/cakofony/followers","following_url":"https://api.github.com/users/cakofony/following{/other_user}","gists_url":"https://api.github.com/users/cakofony/gists{/gist_id}","starred_url":"https://api.github.com/users/cakofony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakofony/subscriptions","organizations_url":"https://api.github.com/users/cakofony/orgs","repos_url":"https://api.github.com/users/cakofony/repos","events_url":"https://api.github.com/users/cakofony/events{/privacy}","received_events_url":"https://api.github.com/users/cakofony/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cakofony/feign","description":"Feign makes writing java http clients easier","fork":true,"url":"https://api.github.com/repos/cakofony/feign","forks_url":"https://api.github.com/repos/cakofony/feign/forks","keys_url":"https://api.github.com/repos/cakofony/feign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakofony/feign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakofony/feign/teams","hooks_url":"https://api.github.com/repos/cakofony/feign/hooks","issue_events_url":"https://api.github.com/repos/cakofony/feign/issues/events{/number}","events_url":"https://api.github.com/repos/cakofony/feign/events","assignees_url":"https://api.github.com/repos/cakofony/feign/assignees{/user}","branches_url":"https://api.github.com/repos/cakofony/feign/branches{/branch}","tags_url":"https://api.github.com/repos/cakofony/feign/tags","blobs_url":"https://api.github.com/repos/cakofony/feign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakofony/feign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakofony/feign/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakofony/feign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakofony/feign/statuses/{sha}","languages_url":"https://api.github.com/repos/cakofony/feign/languages","stargazers_url":"https://api.github.com/repos/cakofony/feign/stargazers","contributors_url":"https://api.github.com/repos/cakofony/feign/contributors","subscribers_url":"https://api.github.com/repos/cakofony/feign/subscribers","subscription_url":"https://api.github.com/repos/cakofony/feign/subscription","commits_url":"https://api.github.com/repos/cakofony/feign/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakofony/feign/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakofony/feign/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakofony/feign/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakofony/feign/contents/{+path}","compare_url":"https://api.github.com/repos/cakofony/feign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakofony/feign/merges","archive_url":"https://api.github.com/repos/cakofony/feign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakofony/feign/downloads","issues_url":"https://api.github.com/repos/cakofony/feign/issues{/number}","pulls_url":"https://api.github.com/repos/cakofony/feign/pulls{/number}","milestones_url":"https://api.github.com/repos/cakofony/feign/milestones{/number}","notifications_url":"https://api.github.com/repos/cakofony/feign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakofony/feign/labels{/name}","releases_url":"https://api.github.com/repos/cakofony/feign/releases{/id}","created_at":"2015-12-15T02:56:00Z","updated_at":"2015-12-15T02:56:01Z","pushed_at":"2015-12-15T03:14:43Z","git_url":"git://github.com/cakofony/feign.git","ssh_url":"git@github.com:cakofony/feign.git","clone_url":"https://github.com/cakofony/feign.git","svn_url":"https://github.com/cakofony/feign","homepage":"","size":1336,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"622e2a5fd557be9d47d77b01488326ef381edc5d","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":10981994,"name":"feign","full_name":"Netflix/feign","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/feign","description":"Feign makes writing java http clients easier","fork":false,"url":"https://api.github.com/repos/Netflix/feign","forks_url":"https://api.github.com/repos/Netflix/feign/forks","keys_url":"https://api.github.com/repos/Netflix/feign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/feign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/feign/teams","hooks_url":"https://api.github.com/repos/Netflix/feign/hooks","issue_events_url":"https://api.github.com/repos/Netflix/feign/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/feign/events","assignees_url":"https://api.github.com/repos/Netflix/feign/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/feign/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/feign/tags","blobs_url":"https://api.github.com/repos/Netflix/feign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/feign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/feign/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/feign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/feign/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/feign/languages","stargazers_url":"https://api.github.com/repos/Netflix/feign/stargazers","contributors_url":"https://api.github.com/repos/Netflix/feign/contributors","subscribers_url":"https://api.github.com/repos/Netflix/feign/subscribers","subscription_url":"https://api.github.com/repos/Netflix/feign/subscription","commits_url":"https://api.github.com/repos/Netflix/feign/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/feign/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/feign/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/feign/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/feign/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/feign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/feign/merges","archive_url":"https://api.github.com/repos/Netflix/feign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/feign/downloads","issues_url":"https://api.github.com/repos/Netflix/feign/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/feign/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/feign/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/feign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/feign/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/feign/releases{/id}","created_at":"2013-06-26T23:28:16Z","updated_at":"2015-12-13T23:08:59Z","pushed_at":"2015-12-15T03:14:44Z","git_url":"git://github.com/Netflix/feign.git","ssh_url":"git@github.com:Netflix/feign.git","clone_url":"https://github.com/Netflix/feign.git","svn_url":"https://github.com/Netflix/feign","homepage":"","size":1732,"stargazers_count":654,"watchers_count":654,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":25,"forks":128,"open_issues":25,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/feign/pulls/302"},"html":{"href":"https://github.com/Netflix/feign/pull/302"},"issue":{"href":"https://api.github.com/repos/Netflix/feign/issues/302"},"comments":{"href":"https://api.github.com/repos/Netflix/feign/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/feign/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/feign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/feign/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/feign/statuses/b61285e45b1dbdf7508fac4ed240fcff3f134584"}}}}