{"action":"created","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/146","labels_url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/146/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/146/events","html_url":"https://github.com/reactioncommerce/reaction-core/pull/146","id":94913978,"number":146,"title":"Regarding multi vendor seller permissions for Products publications, and small fixes","user":{"login":"boboci9","id":9323474,"avatar_url":"https://avatars.githubusercontent.com/u/9323474?v=3","gravatar_id":"","url":"https://api.github.com/users/boboci9","html_url":"https://github.com/boboci9","followers_url":"https://api.github.com/users/boboci9/followers","following_url":"https://api.github.com/users/boboci9/following{/other_user}","gists_url":"https://api.github.com/users/boboci9/gists{/gist_id}","starred_url":"https://api.github.com/users/boboci9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boboci9/subscriptions","organizations_url":"https://api.github.com/users/boboci9/orgs","repos_url":"https://api.github.com/users/boboci9/repos","events_url":"https://api.github.com/users/boboci9/events{/privacy}","received_events_url":"https://api.github.com/users/boboci9/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reactioncommerce/reaction-core/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-14T10:22:30Z","updated_at":"2015-07-14T14:52:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction-core/pulls/146","html_url":"https://github.com/reactioncommerce/reaction-core/pull/146","diff_url":"https://github.com/reactioncommerce/reaction-core/pull/146.diff","patch_url":"https://github.com/reactioncommerce/reaction-core/pull/146.patch"},"body":"Hi Aaron,\r\n- I added a suggestion for the multi vendor support to check for seller's permission in case the shops parameter is added to the Products publication we would check if the current user is a seller in any of the shops and publish the products, this would still have to be revised because we are still publishing to many products so we could have a brainstorming when you have time on how to publish only the necessary data, but the changes I made could work for now.\r\n- I also added Boolean to the argument check for the product update because it returned error when isVisible parameter was changed.\r\n- In the new version I was getting error for the states dropdown because the formId there in the this object so I added a fix to get the country value.\r\n\r\nBest regards,\r\nBogi\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/comments/121266814","html_url":"https://github.com/reactioncommerce/reaction-core/pull/146#issuecomment-121266814","issue_url":"https://api.github.com/repos/reactioncommerce/reaction-core/issues/146","id":121266814,"user":{"login":"queso","id":106,"avatar_url":"https://avatars.githubusercontent.com/u/106?v=3","gravatar_id":"","url":"https://api.github.com/users/queso","html_url":"https://github.com/queso","followers_url":"https://api.github.com/users/queso/followers","following_url":"https://api.github.com/users/queso/following{/other_user}","gists_url":"https://api.github.com/users/queso/gists{/gist_id}","starred_url":"https://api.github.com/users/queso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/queso/subscriptions","organizations_url":"https://api.github.com/users/queso/orgs","repos_url":"https://api.github.com/users/queso/repos","events_url":"https://api.github.com/users/queso/events{/privacy}","received_events_url":"https://api.github.com/users/queso/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T14:52:12Z","updated_at":"2015-07-14T14:52:12Z","body":"@boboci9 or @aaronjudd is there any potential downside to revealing non-visible products to shop admins that aren't admins of other shops?\r\n\r\nThis solution just checks that you are at least a shop admin for one shop and then it will reveal all products to any shop you asked for, including non-visible products for shops you don't admin."}}