{"action":"created","comment":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/comments/27794582","id":27794582,"diff_hunk":"@@ -729,6 +735,61 @@ def io_wait\n       @aruba_io_wait_seconds || DEFAULT_IO_WAIT_SECONDS\n     end\n \n+    DEFAULT_ROOT_DIRECTORY = Dir.getwd\n+\n+    # The root directory of aruba\n+    def root_directory\n+      @aruba__root_directory ||= DEFAULT_ROOT_DIRECTORY\n+    end\n+\n+    DEFAULT_FIXTURES_PATH_PREFIX = '%/'\n+\n+    def fixtures_path_prefix","path":"lib/aruba/api.rb","position":35,"original_position":35,"commit_id":"883a35abf9e8186f19c1aca3d2e1615964fb02dc","original_commit_id":"883a35abf9e8186f19c1aca3d2e1615964fb02dc","user":{"login":"jarl-dk","id":191521,"avatar_url":"https://avatars.githubusercontent.com/u/191521?v=3","gravatar_id":"","url":"https://api.github.com/users/jarl-dk","html_url":"https://github.com/jarl-dk","followers_url":"https://api.github.com/users/jarl-dk/followers","following_url":"https://api.github.com/users/jarl-dk/following{/other_user}","gists_url":"https://api.github.com/users/jarl-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/jarl-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarl-dk/subscriptions","organizations_url":"https://api.github.com/users/jarl-dk/orgs","repos_url":"https://api.github.com/users/jarl-dk/repos","events_url":"https://api.github.com/users/jarl-dk/events{/privacy}","received_events_url":"https://api.github.com/users/jarl-dk/received_events","type":"User","site_admin":false},"body":"Making the fixture prefix character configurable via `@aruba_fixture_path_prefix`. To be honest I think it should not be configurable; just like `~` referring to HOME directory is not configurable. ","created_at":"2015-04-06T12:24:38Z","updated_at":"2015-04-06T12:24:38Z","html_url":"https://github.com/cucumber/aruba/pull/224#discussion_r27794582","pull_request_url":"https://api.github.com/repos/cucumber/aruba/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/comments/27794582"},"html":{"href":"https://github.com/cucumber/aruba/pull/224#discussion_r27794582"},"pull_request":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/224","id":27410394,"html_url":"https://github.com/cucumber/aruba/pull/224","diff_url":"https://github.com/cucumber/aruba/pull/224.diff","patch_url":"https://github.com/cucumber/aruba/pull/224.patch","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/224","number":224,"state":"open","locked":false,"title":"Add fixtures to aruba","user":{"login":"dg-ratiodata","id":1267524,"avatar_url":"https://avatars.githubusercontent.com/u/1267524?v=3","gravatar_id":"","url":"https://api.github.com/users/dg-ratiodata","html_url":"https://github.com/dg-ratiodata","followers_url":"https://api.github.com/users/dg-ratiodata/followers","following_url":"https://api.github.com/users/dg-ratiodata/following{/other_user}","gists_url":"https://api.github.com/users/dg-ratiodata/gists{/gist_id}","starred_url":"https://api.github.com/users/dg-ratiodata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg-ratiodata/subscriptions","organizations_url":"https://api.github.com/users/dg-ratiodata/orgs","repos_url":"https://api.github.com/users/dg-ratiodata/repos","events_url":"https://api.github.com/users/dg-ratiodata/events{/privacy}","received_events_url":"https://api.github.com/users/dg-ratiodata/received_events","type":"User","site_admin":false},"body":"This PR adds the basics to support fixtures in `aruba`. Also see  #219.\r\n\r\nThings to discuss:\r\n\r\n* [ ] Use of `OpenStruct`\r\n  \r\n  I used `OpenStruct` here to make both paths of a fixture available: The relative one which is used to find a fixture and the absolute one, which can be used by a `consumer` of the api like `copy_file`. I can replace this by a `Hash` if this is preferred. Though `OpenStruct` is part of `ruby core distribution`.\r\n  \r\n* [ ] Use of `Pathname`\r\n\r\n  I like the `relative_path_from`-functionality of `Pathname`. It makes the intention of the author clear and is quite easy to use to build relative paths.\r\n\r\n* [ ] Use of `%/` as fixture path prefix\r\n\r\n  It does not have a special meaning in ruby so far - besides percent classes which are not followed by `/`.\r\n\r\n* [ ] Order of directories to be searched\r\n  \r\n  I use \"my\" preferred order here, but I'm open to change it.\r\n\r\n* [ ] Commit Style\r\n  \r\n  I will refactor the \"commits\" after all things above are discussed to make sure that there's one commit for the tests and one commit for the implementation.\r\n\r\n* [ ] Rubocop\r\n\r\n  I think we will need to \"guard\" this [line](https://github.com/cucumber/aruba/pull/224/files#diff-65af44ccc0b346dd91178a015aee5560R39) and that [line](https://github.com/cucumber/aruba/pull/224/files#diff-65af44ccc0b346dd91178a015aee5560R786) here because of `===` (3x `=`). But `===` returns `true'/`false` for both `String` AND `Regexp` and thus is more flexible than `==`","created_at":"2015-01-15T07:25:51Z","updated_at":"2015-04-06T12:24:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed0e239befbcb5f882f8816b4d793276ab5576a1","assignee":{"login":"jarl-dk","id":191521,"avatar_url":"https://avatars.githubusercontent.com/u/191521?v=3","gravatar_id":"","url":"https://api.github.com/users/jarl-dk","html_url":"https://github.com/jarl-dk","followers_url":"https://api.github.com/users/jarl-dk/followers","following_url":"https://api.github.com/users/jarl-dk/following{/other_user}","gists_url":"https://api.github.com/users/jarl-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/jarl-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarl-dk/subscriptions","organizations_url":"https://api.github.com/users/jarl-dk/orgs","repos_url":"https://api.github.com/users/jarl-dk/repos","events_url":"https://api.github.com/users/jarl-dk/events{/privacy}","received_events_url":"https://api.github.com/users/jarl-dk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/aruba/pulls/224/commits","review_comments_url":"https://api.github.com/repos/cucumber/aruba/pulls/224/comments","review_comment_url":"https://api.github.com/repos/cucumber/aruba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/224/comments","statuses_url":"https://api.github.com/repos/cucumber/aruba/statuses/883a35abf9e8186f19c1aca3d2e1615964fb02dc","head":{"label":"dg-ratiodata:feature/fixtures","ref":"feature/fixtures","sha":"883a35abf9e8186f19c1aca3d2e1615964fb02dc","user":{"login":"dg-ratiodata","id":1267524,"avatar_url":"https://avatars.githubusercontent.com/u/1267524?v=3","gravatar_id":"","url":"https://api.github.com/users/dg-ratiodata","html_url":"https://github.com/dg-ratiodata","followers_url":"https://api.github.com/users/dg-ratiodata/followers","following_url":"https://api.github.com/users/dg-ratiodata/following{/other_user}","gists_url":"https://api.github.com/users/dg-ratiodata/gists{/gist_id}","starred_url":"https://api.github.com/users/dg-ratiodata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg-ratiodata/subscriptions","organizations_url":"https://api.github.com/users/dg-ratiodata/orgs","repos_url":"https://api.github.com/users/dg-ratiodata/repos","events_url":"https://api.github.com/users/dg-ratiodata/events{/privacy}","received_events_url":"https://api.github.com/users/dg-ratiodata/received_events","type":"User","site_admin":false},"repo":{"id":10601111,"name":"aruba","full_name":"dg-ratiodata/aruba","owner":{"login":"dg-ratiodata","id":1267524,"avatar_url":"https://avatars.githubusercontent.com/u/1267524?v=3","gravatar_id":"","url":"https://api.github.com/users/dg-ratiodata","html_url":"https://github.com/dg-ratiodata","followers_url":"https://api.github.com/users/dg-ratiodata/followers","following_url":"https://api.github.com/users/dg-ratiodata/following{/other_user}","gists_url":"https://api.github.com/users/dg-ratiodata/gists{/gist_id}","starred_url":"https://api.github.com/users/dg-ratiodata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg-ratiodata/subscriptions","organizations_url":"https://api.github.com/users/dg-ratiodata/orgs","repos_url":"https://api.github.com/users/dg-ratiodata/repos","events_url":"https://api.github.com/users/dg-ratiodata/events{/privacy}","received_events_url":"https://api.github.com/users/dg-ratiodata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dg-ratiodata/aruba","description":"CLI Steps for Cucumber","fork":true,"url":"https://api.github.com/repos/dg-ratiodata/aruba","forks_url":"https://api.github.com/repos/dg-ratiodata/aruba/forks","keys_url":"https://api.github.com/repos/dg-ratiodata/aruba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dg-ratiodata/aruba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dg-ratiodata/aruba/teams","hooks_url":"https://api.github.com/repos/dg-ratiodata/aruba/hooks","issue_events_url":"https://api.github.com/repos/dg-ratiodata/aruba/issues/events{/number}","events_url":"https://api.github.com/repos/dg-ratiodata/aruba/events","assignees_url":"https://api.github.com/repos/dg-ratiodata/aruba/assignees{/user}","branches_url":"https://api.github.com/repos/dg-ratiodata/aruba/branches{/branch}","tags_url":"https://api.github.com/repos/dg-ratiodata/aruba/tags","blobs_url":"https://api.github.com/repos/dg-ratiodata/aruba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dg-ratiodata/aruba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dg-ratiodata/aruba/git/refs{/sha}","trees_url":"https://api.github.com/repos/dg-ratiodata/aruba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dg-ratiodata/aruba/statuses/{sha}","languages_url":"https://api.github.com/repos/dg-ratiodata/aruba/languages","stargazers_url":"https://api.github.com/repos/dg-ratiodata/aruba/stargazers","contributors_url":"https://api.github.com/repos/dg-ratiodata/aruba/contributors","subscribers_url":"https://api.github.com/repos/dg-ratiodata/aruba/subscribers","subscription_url":"https://api.github.com/repos/dg-ratiodata/aruba/subscription","commits_url":"https://api.github.com/repos/dg-ratiodata/aruba/commits{/sha}","git_commits_url":"https://api.github.com/repos/dg-ratiodata/aruba/git/commits{/sha}","comments_url":"https://api.github.com/repos/dg-ratiodata/aruba/comments{/number}","issue_comment_url":"https://api.github.com/repos/dg-ratiodata/aruba/issues/comments{/number}","contents_url":"https://api.github.com/repos/dg-ratiodata/aruba/contents/{+path}","compare_url":"https://api.github.com/repos/dg-ratiodata/aruba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dg-ratiodata/aruba/merges","archive_url":"https://api.github.com/repos/dg-ratiodata/aruba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dg-ratiodata/aruba/downloads","issues_url":"https://api.github.com/repos/dg-ratiodata/aruba/issues{/number}","pulls_url":"https://api.github.com/repos/dg-ratiodata/aruba/pulls{/number}","milestones_url":"https://api.github.com/repos/dg-ratiodata/aruba/milestones{/number}","notifications_url":"https://api.github.com/repos/dg-ratiodata/aruba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dg-ratiodata/aruba/labels{/name}","releases_url":"https://api.github.com/repos/dg-ratiodata/aruba/releases{/id}","created_at":"2013-06-10T13:45:36Z","updated_at":"2014-09-02T11:25:54Z","pushed_at":"2015-03-17T15:12:23Z","git_url":"git://github.com/dg-ratiodata/aruba.git","ssh_url":"git@github.com:dg-ratiodata/aruba.git","clone_url":"https://github.com/dg-ratiodata/aruba.git","svn_url":"https://github.com/dg-ratiodata/aruba","homepage":"","size":1337,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"5ae1ba967deaa904b275197d7f1236e783d72b65","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":515585,"name":"aruba","full_name":"cucumber/aruba","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/aruba","description":"CLI Steps for Cucumber","fork":false,"url":"https://api.github.com/repos/cucumber/aruba","forks_url":"https://api.github.com/repos/cucumber/aruba/forks","keys_url":"https://api.github.com/repos/cucumber/aruba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/aruba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/aruba/teams","hooks_url":"https://api.github.com/repos/cucumber/aruba/hooks","issue_events_url":"https://api.github.com/repos/cucumber/aruba/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/aruba/events","assignees_url":"https://api.github.com/repos/cucumber/aruba/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/aruba/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/aruba/tags","blobs_url":"https://api.github.com/repos/cucumber/aruba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/aruba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/aruba/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/aruba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/aruba/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/aruba/languages","stargazers_url":"https://api.github.com/repos/cucumber/aruba/stargazers","contributors_url":"https://api.github.com/repos/cucumber/aruba/contributors","subscribers_url":"https://api.github.com/repos/cucumber/aruba/subscribers","subscription_url":"https://api.github.com/repos/cucumber/aruba/subscription","commits_url":"https://api.github.com/repos/cucumber/aruba/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/aruba/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/aruba/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/aruba/issues/comments{/number}","contents_url":"https://api.github.com/repos/cucumber/aruba/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/aruba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/aruba/merges","archive_url":"https://api.github.com/repos/cucumber/aruba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/aruba/downloads","issues_url":"https://api.github.com/repos/cucumber/aruba/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/aruba/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/aruba/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/aruba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/aruba/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/aruba/releases{/id}","created_at":"2010-02-12T19:06:31Z","updated_at":"2015-04-04T18:32:22Z","pushed_at":"2015-04-04T18:32:22Z","git_url":"git://github.com/cucumber/aruba.git","ssh_url":"git@github.com:cucumber/aruba.git","clone_url":"https://github.com/cucumber/aruba.git","svn_url":"https://github.com/cucumber/aruba","homepage":"","size":1799,"stargazers_count":592,"watchers_count":592,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":19,"forks":100,"open_issues":19,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/224"},"html":{"href":"https://github.com/cucumber/aruba/pull/224"},"issue":{"href":"https://api.github.com/repos/cucumber/aruba/issues/224"},"comments":{"href":"https://api.github.com/repos/cucumber/aruba/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cucumber/aruba/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/aruba/statuses/883a35abf9e8186f19c1aca3d2e1615964fb02dc"}}}}