{"action":"created","issue":{"url":"https://api.github.com/repos/codeclimate/radon/issues/1","labels_url":"https://api.github.com/repos/codeclimate/radon/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/codeclimate/radon/issues/1/comments","events_url":"https://api.github.com/repos/codeclimate/radon/issues/1/events","html_url":"https://github.com/codeclimate/radon/pull/1","id":117676720,"number":1,"title":"Dont analyze any files when cc config include_paths is empty list","user":{"login":"ABaldwinHunter","id":8718443,"avatar_url":"https://avatars.githubusercontent.com/u/8718443?v=3","gravatar_id":"","url":"https://api.github.com/users/ABaldwinHunter","html_url":"https://github.com/ABaldwinHunter","followers_url":"https://api.github.com/users/ABaldwinHunter/followers","following_url":"https://api.github.com/users/ABaldwinHunter/following{/other_user}","gists_url":"https://api.github.com/users/ABaldwinHunter/gists{/gist_id}","starred_url":"https://api.github.com/users/ABaldwinHunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ABaldwinHunter/subscriptions","organizations_url":"https://api.github.com/users/ABaldwinHunter/orgs","repos_url":"https://api.github.com/users/ABaldwinHunter/repos","events_url":"https://api.github.com/users/ABaldwinHunter/events{/privacy}","received_events_url":"https://api.github.com/users/ABaldwinHunter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-18T20:41:02Z","updated_at":"2015-11-18T22:02:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codeclimate/radon/pulls/1","html_url":"https://github.com/codeclimate/radon/pull/1","diff_url":"https://github.com/codeclimate/radon/pull/1.diff","patch_url":"https://github.com/codeclimate/radon/pull/1.patch"},"body":"When a user runs `codeclimate analyze <path>`, workspace paths to analyze get passed\r\ninto `config.json` as a list.\r\n\r\nThe previous implementation made the mistake of expecting an empty list to be truthy,\r\nand consequently thought the `include_paths` key was missing if include_paths == [].\r\n\r\nAs a result, it analyzed all files in directory instead of none.\r\n\r\nThis change fixes that behavior by checking the type of object that's returned\r\nby config.get(\"include_paths\").\r\n\r\ncc @codeclimate/review @mrb"},"comment":{"url":"https://api.github.com/repos/codeclimate/radon/issues/comments/157878910","html_url":"https://github.com/codeclimate/radon/pull/1#issuecomment-157878910","issue_url":"https://api.github.com/repos/codeclimate/radon/issues/1","id":157878910,"user":{"login":"wfleming","id":188402,"avatar_url":"https://avatars.githubusercontent.com/u/188402?v=3","gravatar_id":"","url":"https://api.github.com/users/wfleming","html_url":"https://github.com/wfleming","followers_url":"https://api.github.com/users/wfleming/followers","following_url":"https://api.github.com/users/wfleming/following{/other_user}","gists_url":"https://api.github.com/users/wfleming/gists{/gist_id}","starred_url":"https://api.github.com/users/wfleming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfleming/subscriptions","organizations_url":"https://api.github.com/users/wfleming/orgs","repos_url":"https://api.github.com/users/wfleming/repos","events_url":"https://api.github.com/users/wfleming/events{/privacy}","received_events_url":"https://api.github.com/users/wfleming/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T22:02:36Z","updated_at":"2015-11-18T22:02:36Z","body":"I don't think it's a spec change: the spec describes engine behavior, and if we were to make this an error upstream, the engine isn't involved at all, so the spec doesn't really come into it.\r\n\r\nThat said, this is a good fix to have right now even if we do decide to fix this behavior at a higher level. I say :shipit: "}}