{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/43715421","id":43715421,"diff_hunk":"@@ -54,7 +54,8 @@ function printInstructions(title) {\n     '  stack frame to jump to the source file. The packager will launch your ',\n     '  editor of choice. It will first look at REACT_EDITOR environment ',\n     '  variable, then at EDITOR. To set it up, you can add something like ',\n-    '  REACT_EDITOR=atom to your .bashrc.',\n+    '  REACT_EDITOR=atom to your ~/.bashrc or export REACT_EDITOR=atom to your',\n+    '  ~/.zshrc depending on which shell you use.',","path":"local-cli/server/util/launchEditor.js","position":6,"original_position":6,"commit_id":"58f71be68856f99872b1260d653f6f9bf882d459","original_commit_id":"58f71be68856f99872b1260d653f6f9bf882d459","user":{"login":"frantic","id":192222,"avatar_url":"https://avatars.githubusercontent.com/u/192222?v=3","gravatar_id":"","url":"https://api.github.com/users/frantic","html_url":"https://github.com/frantic","followers_url":"https://api.github.com/users/frantic/followers","following_url":"https://api.github.com/users/frantic/following{/other_user}","gists_url":"https://api.github.com/users/frantic/gists{/gist_id}","starred_url":"https://api.github.com/users/frantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frantic/subscriptions","organizations_url":"https://api.github.com/users/frantic/orgs","repos_url":"https://api.github.com/users/frantic/repos","events_url":"https://api.github.com/users/frantic/events{/privacy}","received_events_url":"https://api.github.com/users/frantic/received_events","type":"User","site_admin":false},"body":"I'm sure we should use `export REACT_EDITOR=atom` even for bash.\r\nA very cool DX detail could be figuring out what shell you use from `process.env` and suggesting relevant rc file.","created_at":"2015-11-03T04:30:36Z","updated_at":"2015-11-03T04:30:36Z","html_url":"https://github.com/facebook/react-native/pull/3853#discussion_r43715421","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/3853","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/43715421"},"html":{"href":"https://github.com/facebook/react-native/pull/3853#discussion_r43715421"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3853"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/3853","id":49517864,"html_url":"https://github.com/facebook/react-native/pull/3853","diff_url":"https://github.com/facebook/react-native/pull/3853.diff","patch_url":"https://github.com/facebook/react-native/pull/3853.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/3853","number":3853,"state":"open","locked":false,"title":"update pro tip to clarify how to configure zsh shell","user":{"login":"geirman","id":1640318,"avatar_url":"https://avatars.githubusercontent.com/u/1640318?v=3","gravatar_id":"","url":"https://api.github.com/users/geirman","html_url":"https://github.com/geirman","followers_url":"https://api.github.com/users/geirman/followers","following_url":"https://api.github.com/users/geirman/following{/other_user}","gists_url":"https://api.github.com/users/geirman/gists{/gist_id}","starred_url":"https://api.github.com/users/geirman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geirman/subscriptions","organizations_url":"https://api.github.com/users/geirman/orgs","repos_url":"https://api.github.com/users/geirman/repos","events_url":"https://api.github.com/users/geirman/events{/privacy}","received_events_url":"https://api.github.com/users/geirman/received_events","type":"User","site_admin":false},"body":"Thanks to @alex_frantic for helping me solve this problem...\r\nhttps://twitter.com/alex_frantic/status/657276624220659712","created_at":"2015-11-03T04:10:25Z","updated_at":"2015-11-03T04:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"202edeee41bdbc0d08d7e59261cc0df076fb211e","assignee":{"login":"frantic","id":192222,"avatar_url":"https://avatars.githubusercontent.com/u/192222?v=3","gravatar_id":"","url":"https://api.github.com/users/frantic","html_url":"https://github.com/frantic","followers_url":"https://api.github.com/users/frantic/followers","following_url":"https://api.github.com/users/frantic/following{/other_user}","gists_url":"https://api.github.com/users/frantic/gists{/gist_id}","starred_url":"https://api.github.com/users/frantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frantic/subscriptions","organizations_url":"https://api.github.com/users/frantic/orgs","repos_url":"https://api.github.com/users/frantic/repos","events_url":"https://api.github.com/users/frantic/events{/privacy}","received_events_url":"https://api.github.com/users/frantic/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/3853/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/3853/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/3853/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/58f71be68856f99872b1260d653f6f9bf882d459","head":{"label":"geirman:geirman-patch-1","ref":"geirman-patch-1","sha":"58f71be68856f99872b1260d653f6f9bf882d459","user":{"login":"geirman","id":1640318,"avatar_url":"https://avatars.githubusercontent.com/u/1640318?v=3","gravatar_id":"","url":"https://api.github.com/users/geirman","html_url":"https://github.com/geirman","followers_url":"https://api.github.com/users/geirman/followers","following_url":"https://api.github.com/users/geirman/following{/other_user}","gists_url":"https://api.github.com/users/geirman/gists{/gist_id}","starred_url":"https://api.github.com/users/geirman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geirman/subscriptions","organizations_url":"https://api.github.com/users/geirman/orgs","repos_url":"https://api.github.com/users/geirman/repos","events_url":"https://api.github.com/users/geirman/events{/privacy}","received_events_url":"https://api.github.com/users/geirman/received_events","type":"User","site_admin":false},"repo":{"id":45309130,"name":"react-native","full_name":"geirman/react-native","owner":{"login":"geirman","id":1640318,"avatar_url":"https://avatars.githubusercontent.com/u/1640318?v=3","gravatar_id":"","url":"https://api.github.com/users/geirman","html_url":"https://github.com/geirman","followers_url":"https://api.github.com/users/geirman/followers","following_url":"https://api.github.com/users/geirman/following{/other_user}","gists_url":"https://api.github.com/users/geirman/gists{/gist_id}","starred_url":"https://api.github.com/users/geirman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geirman/subscriptions","organizations_url":"https://api.github.com/users/geirman/orgs","repos_url":"https://api.github.com/users/geirman/repos","events_url":"https://api.github.com/users/geirman/events{/privacy}","received_events_url":"https://api.github.com/users/geirman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geirman/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/geirman/react-native","forks_url":"https://api.github.com/repos/geirman/react-native/forks","keys_url":"https://api.github.com/repos/geirman/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geirman/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geirman/react-native/teams","hooks_url":"https://api.github.com/repos/geirman/react-native/hooks","issue_events_url":"https://api.github.com/repos/geirman/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/geirman/react-native/events","assignees_url":"https://api.github.com/repos/geirman/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/geirman/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/geirman/react-native/tags","blobs_url":"https://api.github.com/repos/geirman/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geirman/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geirman/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/geirman/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geirman/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/geirman/react-native/languages","stargazers_url":"https://api.github.com/repos/geirman/react-native/stargazers","contributors_url":"https://api.github.com/repos/geirman/react-native/contributors","subscribers_url":"https://api.github.com/repos/geirman/react-native/subscribers","subscription_url":"https://api.github.com/repos/geirman/react-native/subscription","commits_url":"https://api.github.com/repos/geirman/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/geirman/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/geirman/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/geirman/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/geirman/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/geirman/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geirman/react-native/merges","archive_url":"https://api.github.com/repos/geirman/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geirman/react-native/downloads","issues_url":"https://api.github.com/repos/geirman/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/geirman/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/geirman/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/geirman/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geirman/react-native/labels{/name}","releases_url":"https://api.github.com/repos/geirman/react-native/releases{/id}","created_at":"2015-10-31T16:26:57Z","updated_at":"2015-10-31T16:27:03Z","pushed_at":"2015-11-03T04:07:05Z","git_url":"git://github.com/geirman/react-native.git","ssh_url":"git@github.com:geirman/react-native.git","clone_url":"https://github.com/geirman/react-native.git","svn_url":"https://github.com/geirman/react-native","homepage":"http://facebook.github.io/react-native/","size":30101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9bfadb7e1e0432079405dcd33e2deabf28e6195a","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","created_at":"2015-01-09T18:10:16Z","updated_at":"2015-11-03T03:52:25Z","pushed_at":"2015-11-03T04:10:26Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":70312,"stargazers_count":21843,"watchers_count":21843,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3346,"mirror_url":null,"open_issues_count":880,"forks":3346,"open_issues":880,"watchers":21843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3853"},"html":{"href":"https://github.com/facebook/react-native/pull/3853"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/3853"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/3853/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3853/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/3853/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/58f71be68856f99872b1260d653f6f9bf882d459"}}}}