{"action":"closed","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/89","labels_url":"https://api.github.com/repos/randombit/botan/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/89/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/89/events","html_url":"https://github.com/randombit/botan/issues/89","id":73116401,"number":89,"title":"Compression filter documentation + default secure_vector buffer size","user":{"login":"EricMCornelius","id":748917,"avatar_url":"https://avatars.githubusercontent.com/u/748917?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMCornelius","html_url":"https://github.com/EricMCornelius","followers_url":"https://api.github.com/users/EricMCornelius/followers","following_url":"https://api.github.com/users/EricMCornelius/following{/other_user}","gists_url":"https://api.github.com/users/EricMCornelius/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMCornelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMCornelius/subscriptions","organizations_url":"https://api.github.com/users/EricMCornelius/orgs","repos_url":"https://api.github.com/users/EricMCornelius/repos","events_url":"https://api.github.com/users/EricMCornelius/events{/privacy}","received_events_url":"https://api.github.com/users/EricMCornelius/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-04T20:16:02Z","updated_at":"2015-05-10T02:44:06Z","closed_at":"2015-05-10T02:44:06Z","body":"I was playing around with this lib earlier today looking for something providing a more modern interface that Crypto++.  The documentation is in general fantastic, but I noticed that there's no mention of the recent shift to treat compression as Transform* instances.\r\n\r\nAfter digging into what had changed, I discovered that the secure_vector buffer used inside the compression/decompression streams is default constructed, which causes zlib STREAM_ERROR failures because nothing is ever allocated for actual buffer space: https://github.com/randombit/botan/blob/net.randombit.botan/src/lib/filters/comp_filter.cpp#L44\r\n\r\nWanted to check in and see what would be useful as a fix for this.  Do you prefer to expose the buffer sizing as a constructor option?  Or stick with the current convention where nearly all existing filters are fixed at DEFAULT_BUFFERSIZE?"}}