{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48","id":41441542,"html_url":"https://github.com/jasonrbriggs/stomp.py/pull/48","diff_url":"https://github.com/jasonrbriggs/stomp.py/pull/48.diff","patch_url":"https://github.com/jasonrbriggs/stomp.py/pull/48.patch","issue_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/48","number":48,"state":"closed","locked":false,"title":"Auto-send content-length when message body is present","user":{"login":"scop","id":109152,"avatar_url":"https://avatars.githubusercontent.com/u/109152?v=3","gravatar_id":"","url":"https://api.github.com/users/scop","html_url":"https://github.com/scop","followers_url":"https://api.github.com/users/scop/followers","following_url":"https://api.github.com/users/scop/following{/other_user}","gists_url":"https://api.github.com/users/scop/gists{/gist_id}","starred_url":"https://api.github.com/users/scop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scop/subscriptions","organizations_url":"https://api.github.com/users/scop/orgs","repos_url":"https://api.github.com/users/scop/repos","events_url":"https://api.github.com/users/scop/events{/privacy}","received_events_url":"https://api.github.com/users/scop/received_events","type":"User","site_admin":false},"body":"For all protocol versions, sending content-length is recommended by the specs when a body is present, not only when it contains the null byte.\r\n\r\nThis essentially reverts commit a8d103eec5041fdc29fd7260c9c6ffd1b5649d77 which mentions it fixes content length header handling, but I don't see anything wrong with it apart from that it probably sent it also for empty message bodies and there's no further info in the commit message or change log.","created_at":"2015-08-03T07:36:46Z","updated_at":"2015-08-14T01:39:56Z","closed_at":"2015-08-14T01:39:56Z","merged_at":"2015-08-14T01:39:56Z","merge_commit_sha":"1f4fc4dffc3275534d05d6e10aefe08a01a98c8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48/commits","review_comments_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48/comments","review_comment_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/48/comments","statuses_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/statuses/8c9c6165ad67dc9f4d990656680f2a4a81afd6a5","head":{"label":"scop:auto-content-length","ref":"auto-content-length","sha":"8c9c6165ad67dc9f4d990656680f2a4a81afd6a5","user":{"login":"scop","id":109152,"avatar_url":"https://avatars.githubusercontent.com/u/109152?v=3","gravatar_id":"","url":"https://api.github.com/users/scop","html_url":"https://github.com/scop","followers_url":"https://api.github.com/users/scop/followers","following_url":"https://api.github.com/users/scop/following{/other_user}","gists_url":"https://api.github.com/users/scop/gists{/gist_id}","starred_url":"https://api.github.com/users/scop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scop/subscriptions","organizations_url":"https://api.github.com/users/scop/orgs","repos_url":"https://api.github.com/users/scop/repos","events_url":"https://api.github.com/users/scop/events{/privacy}","received_events_url":"https://api.github.com/users/scop/received_events","type":"User","site_admin":false},"repo":{"id":40109871,"name":"stomp.py","full_name":"scop/stomp.py","owner":{"login":"scop","id":109152,"avatar_url":"https://avatars.githubusercontent.com/u/109152?v=3","gravatar_id":"","url":"https://api.github.com/users/scop","html_url":"https://github.com/scop","followers_url":"https://api.github.com/users/scop/followers","following_url":"https://api.github.com/users/scop/following{/other_user}","gists_url":"https://api.github.com/users/scop/gists{/gist_id}","starred_url":"https://api.github.com/users/scop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scop/subscriptions","organizations_url":"https://api.github.com/users/scop/orgs","repos_url":"https://api.github.com/users/scop/repos","events_url":"https://api.github.com/users/scop/events{/privacy}","received_events_url":"https://api.github.com/users/scop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scop/stomp.py","description":"“stomp.py” is a Python client library for accessing messaging servers (such as Apollo or RabbitMQ) using the STOMP protocol (versions 1.0, 1.1 and 1.2). It can also be run as a standalone, command-line client for testing.","fork":true,"url":"https://api.github.com/repos/scop/stomp.py","forks_url":"https://api.github.com/repos/scop/stomp.py/forks","keys_url":"https://api.github.com/repos/scop/stomp.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scop/stomp.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scop/stomp.py/teams","hooks_url":"https://api.github.com/repos/scop/stomp.py/hooks","issue_events_url":"https://api.github.com/repos/scop/stomp.py/issues/events{/number}","events_url":"https://api.github.com/repos/scop/stomp.py/events","assignees_url":"https://api.github.com/repos/scop/stomp.py/assignees{/user}","branches_url":"https://api.github.com/repos/scop/stomp.py/branches{/branch}","tags_url":"https://api.github.com/repos/scop/stomp.py/tags","blobs_url":"https://api.github.com/repos/scop/stomp.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scop/stomp.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scop/stomp.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/scop/stomp.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scop/stomp.py/statuses/{sha}","languages_url":"https://api.github.com/repos/scop/stomp.py/languages","stargazers_url":"https://api.github.com/repos/scop/stomp.py/stargazers","contributors_url":"https://api.github.com/repos/scop/stomp.py/contributors","subscribers_url":"https://api.github.com/repos/scop/stomp.py/subscribers","subscription_url":"https://api.github.com/repos/scop/stomp.py/subscription","commits_url":"https://api.github.com/repos/scop/stomp.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/scop/stomp.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/scop/stomp.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/scop/stomp.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/scop/stomp.py/contents/{+path}","compare_url":"https://api.github.com/repos/scop/stomp.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scop/stomp.py/merges","archive_url":"https://api.github.com/repos/scop/stomp.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scop/stomp.py/downloads","issues_url":"https://api.github.com/repos/scop/stomp.py/issues{/number}","pulls_url":"https://api.github.com/repos/scop/stomp.py/pulls{/number}","milestones_url":"https://api.github.com/repos/scop/stomp.py/milestones{/number}","notifications_url":"https://api.github.com/repos/scop/stomp.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scop/stomp.py/labels{/name}","releases_url":"https://api.github.com/repos/scop/stomp.py/releases{/id}","created_at":"2015-08-03T06:58:27Z","updated_at":"2015-08-03T06:58:28Z","pushed_at":"2015-08-10T06:44:42Z","git_url":"git://github.com/scop/stomp.py.git","ssh_url":"git@github.com:scop/stomp.py.git","clone_url":"https://github.com/scop/stomp.py.git","svn_url":"https://github.com/scop/stomp.py","homepage":"","size":1490,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jasonrbriggs:master","ref":"master","sha":"573ad5df7272d567d5290294c12faba52ba1e674","user":{"login":"jasonrbriggs","id":1325766,"avatar_url":"https://avatars.githubusercontent.com/u/1325766?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonrbriggs","html_url":"https://github.com/jasonrbriggs","followers_url":"https://api.github.com/users/jasonrbriggs/followers","following_url":"https://api.github.com/users/jasonrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jasonrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jasonrbriggs/orgs","repos_url":"https://api.github.com/users/jasonrbriggs/repos","events_url":"https://api.github.com/users/jasonrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrbriggs/received_events","type":"User","site_admin":false},"repo":{"id":12769539,"name":"stomp.py","full_name":"jasonrbriggs/stomp.py","owner":{"login":"jasonrbriggs","id":1325766,"avatar_url":"https://avatars.githubusercontent.com/u/1325766?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonrbriggs","html_url":"https://github.com/jasonrbriggs","followers_url":"https://api.github.com/users/jasonrbriggs/followers","following_url":"https://api.github.com/users/jasonrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jasonrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jasonrbriggs/orgs","repos_url":"https://api.github.com/users/jasonrbriggs/repos","events_url":"https://api.github.com/users/jasonrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrbriggs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonrbriggs/stomp.py","description":"“stomp.py” is a Python client library for accessing messaging servers (such as Apollo or RabbitMQ) using the STOMP protocol (versions 1.0, 1.1 and 1.2). It can also be run as a standalone, command-line client for testing.","fork":false,"url":"https://api.github.com/repos/jasonrbriggs/stomp.py","forks_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/forks","keys_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/teams","hooks_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/hooks","issue_events_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/events{/number}","events_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/events","assignees_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/assignees{/user}","branches_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/branches{/branch}","tags_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/tags","blobs_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/languages","stargazers_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/stargazers","contributors_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/contributors","subscribers_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/subscribers","subscription_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/subscription","commits_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/contents/{+path}","compare_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/merges","archive_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/downloads","issues_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues{/number}","pulls_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/labels{/name}","releases_url":"https://api.github.com/repos/jasonrbriggs/stomp.py/releases{/id}","created_at":"2013-09-11T22:38:36Z","updated_at":"2015-07-26T10:29:00Z","pushed_at":"2015-08-14T01:39:56Z","git_url":"git://github.com/jasonrbriggs/stomp.py.git","ssh_url":"git@github.com:jasonrbriggs/stomp.py.git","clone_url":"https://github.com/jasonrbriggs/stomp.py.git","svn_url":"https://github.com/jasonrbriggs/stomp.py","homepage":"","size":2291,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":7,"forks":27,"open_issues":7,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48"},"html":{"href":"https://github.com/jasonrbriggs/stomp.py/pull/48"},"issue":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/48"},"comments":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/jasonrbriggs/stomp.py/statuses/8c9c6165ad67dc9f4d990656680f2a4a81afd6a5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jasonrbriggs","id":1325766,"avatar_url":"https://avatars.githubusercontent.com/u/1325766?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonrbriggs","html_url":"https://github.com/jasonrbriggs","followers_url":"https://api.github.com/users/jasonrbriggs/followers","following_url":"https://api.github.com/users/jasonrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jasonrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jasonrbriggs/orgs","repos_url":"https://api.github.com/users/jasonrbriggs/repos","events_url":"https://api.github.com/users/jasonrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrbriggs/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":13,"changed_files":3}}