{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/47909552","id":47909552,"diff_hunk":"@@ -252,11 +258,11 @@ promise_type   [a-zA-Z_]+:\n                                    return 0;\n                                  }\n                                  P.if_depth--;\n-                               }\n-\n-<if_ignore_state>[^@]      {\n-                               ParserDebug(\"\\tL:inside macro @if, ignoring text:%s\\n\", yytext);\n-                           }\n+                               }\\\n+<if_ignore_state>.    {\n+                          /* eat up al unknown chars when line starts with @*/\n+                          ParserDebug(\"\\tL:inside macro @if, ignoring text:%s\\n\", yytext);\n+                      }","path":"libpromises/cf3lex.l","position":33,"original_position":33,"commit_id":"2db3dc68238e9b254dcd1614fc6be6c900f62fd1","original_commit_id":"2db3dc68238e9b254dcd1614fc6be6c900f62fd1","user":{"login":"kacf","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"body":"@tzz: You recently made a change to add this '[^@]'. Will it still work with Bas' change?","created_at":"2015-12-17T14:17:16Z","updated_at":"2015-12-17T14:17:16Z","html_url":"https://github.com/cfengine/core/pull/2442#discussion_r47909552","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/2442","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/47909552"},"html":{"href":"https://github.com/cfengine/core/pull/2442#discussion_r47909552"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/2442"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2442","id":53952778,"html_url":"https://github.com/cfengine/core/pull/2442","diff_url":"https://github.com/cfengine/core/pull/2442.diff","patch_url":"https://github.com/cfengine/core/pull/2442.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/2442","number":2442,"state":"open","locked":false,"title":"if minimum_version did not ignore the character '@' ","user":{"login":"basvandervlies","id":431367,"avatar_url":"https://avatars.githubusercontent.com/u/431367?v=3","gravatar_id":"","url":"https://api.github.com/users/basvandervlies","html_url":"https://github.com/basvandervlies","followers_url":"https://api.github.com/users/basvandervlies/followers","following_url":"https://api.github.com/users/basvandervlies/following{/other_user}","gists_url":"https://api.github.com/users/basvandervlies/gists{/gist_id}","starred_url":"https://api.github.com/users/basvandervlies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvandervlies/subscriptions","organizations_url":"https://api.github.com/users/basvandervlies/orgs","repos_url":"https://api.github.com/users/basvandervlies/repos","events_url":"https://api.github.com/users/basvandervlies/events{/privacy}","received_events_url":"https://api.github.com/users/basvandervlies/received_events","type":"User","site_admin":false},"body":"Changelog: if minimum_version did not ignore the character '@' (Redmne #7862)","created_at":"2015-12-17T09:33:08Z","updated_at":"2015-12-17T14:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b13da7f15d8cb55e185fed16aac9e4bfcd3088","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/2442/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/2442/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2442/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/2db3dc68238e9b254dcd1614fc6be6c900f62fd1","head":{"label":"basvandervlies:fix_parser_addsign_bug","ref":"fix_parser_addsign_bug","sha":"2db3dc68238e9b254dcd1614fc6be6c900f62fd1","user":{"login":"basvandervlies","id":431367,"avatar_url":"https://avatars.githubusercontent.com/u/431367?v=3","gravatar_id":"","url":"https://api.github.com/users/basvandervlies","html_url":"https://github.com/basvandervlies","followers_url":"https://api.github.com/users/basvandervlies/followers","following_url":"https://api.github.com/users/basvandervlies/following{/other_user}","gists_url":"https://api.github.com/users/basvandervlies/gists{/gist_id}","starred_url":"https://api.github.com/users/basvandervlies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvandervlies/subscriptions","organizations_url":"https://api.github.com/users/basvandervlies/orgs","repos_url":"https://api.github.com/users/basvandervlies/repos","events_url":"https://api.github.com/users/basvandervlies/events{/privacy}","received_events_url":"https://api.github.com/users/basvandervlies/received_events","type":"User","site_admin":false},"repo":{"id":7982283,"name":"core","full_name":"basvandervlies/core","owner":{"login":"basvandervlies","id":431367,"avatar_url":"https://avatars.githubusercontent.com/u/431367?v=3","gravatar_id":"","url":"https://api.github.com/users/basvandervlies","html_url":"https://github.com/basvandervlies","followers_url":"https://api.github.com/users/basvandervlies/followers","following_url":"https://api.github.com/users/basvandervlies/following{/other_user}","gists_url":"https://api.github.com/users/basvandervlies/gists{/gist_id}","starred_url":"https://api.github.com/users/basvandervlies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvandervlies/subscriptions","organizations_url":"https://api.github.com/users/basvandervlies/orgs","repos_url":"https://api.github.com/users/basvandervlies/repos","events_url":"https://api.github.com/users/basvandervlies/events{/privacy}","received_events_url":"https://api.github.com/users/basvandervlies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basvandervlies/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/basvandervlies/core","forks_url":"https://api.github.com/repos/basvandervlies/core/forks","keys_url":"https://api.github.com/repos/basvandervlies/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basvandervlies/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basvandervlies/core/teams","hooks_url":"https://api.github.com/repos/basvandervlies/core/hooks","issue_events_url":"https://api.github.com/repos/basvandervlies/core/issues/events{/number}","events_url":"https://api.github.com/repos/basvandervlies/core/events","assignees_url":"https://api.github.com/repos/basvandervlies/core/assignees{/user}","branches_url":"https://api.github.com/repos/basvandervlies/core/branches{/branch}","tags_url":"https://api.github.com/repos/basvandervlies/core/tags","blobs_url":"https://api.github.com/repos/basvandervlies/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basvandervlies/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basvandervlies/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/basvandervlies/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basvandervlies/core/statuses/{sha}","languages_url":"https://api.github.com/repos/basvandervlies/core/languages","stargazers_url":"https://api.github.com/repos/basvandervlies/core/stargazers","contributors_url":"https://api.github.com/repos/basvandervlies/core/contributors","subscribers_url":"https://api.github.com/repos/basvandervlies/core/subscribers","subscription_url":"https://api.github.com/repos/basvandervlies/core/subscription","commits_url":"https://api.github.com/repos/basvandervlies/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/basvandervlies/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/basvandervlies/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/basvandervlies/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/basvandervlies/core/contents/{+path}","compare_url":"https://api.github.com/repos/basvandervlies/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basvandervlies/core/merges","archive_url":"https://api.github.com/repos/basvandervlies/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basvandervlies/core/downloads","issues_url":"https://api.github.com/repos/basvandervlies/core/issues{/number}","pulls_url":"https://api.github.com/repos/basvandervlies/core/pulls{/number}","milestones_url":"https://api.github.com/repos/basvandervlies/core/milestones{/number}","notifications_url":"https://api.github.com/repos/basvandervlies/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basvandervlies/core/labels{/name}","releases_url":"https://api.github.com/repos/basvandervlies/core/releases{/id}","created_at":"2013-02-02T21:35:51Z","updated_at":"2015-05-07T10:08:09Z","pushed_at":"2015-12-17T09:30:22Z","git_url":"git://github.com/basvandervlies/core.git","ssh_url":"git@github.com:basvandervlies/core.git","clone_url":"https://github.com/basvandervlies/core.git","svn_url":"https://github.com/basvandervlies/core","homepage":"https://cfengine.com/community/","size":52731,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"cdb4fc16cc0a3c7ea1143917017b9c1247f1ace9","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","created_at":"2012-02-25T09:19:05Z","updated_at":"2015-12-17T08:13:20Z","pushed_at":"2015-12-17T09:33:10Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":58744,"stargazers_count":228,"watchers_count":228,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":36,"forks":141,"open_issues":36,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/2442"},"html":{"href":"https://github.com/cfengine/core/pull/2442"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/2442"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/2442/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/2442/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/2442/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/2db3dc68238e9b254dcd1614fc6be6c900f62fd1"}}}}