{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/46504639","id":46504639,"diff_hunk":"@@ -1513,7 +1513,14 @@ static void ReportException(Environment* env,\n         name->IsUndefined()) {\n       // Not an error object. Just print as-is.\n       node::Utf8Value message(env->isolate(), er);\n-      PrintErrorString(\"%s\\n\", *message);\n+\n+      // If an error occurs while creating message, the length will be zero,\n+      // but PrintErrorString() will display garbage characters. So, if the\n+      // length is zero, just print a newline.\n+      if (message.length() == 0)\n+        PrintErrorString(\"\\n\");\n+      else\n+        PrintErrorString(\"%s\\n\", *message);","path":"src/node.cc","position":12,"original_position":12,"commit_id":"b4b4fe2e2318294e2401c008c2a4478fc0e8130f","original_commit_id":"b4b4fe2e2318294e2401c008c2a4478fc0e8130f","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"@bnoordhuis is `*message == nullptr` for you? If so, it might be platform specific based on https://github.com/nodejs/node/issues/4079#issuecomment-160836846.","created_at":"2015-12-03T01:59:08Z","updated_at":"2015-12-03T01:59:08Z","html_url":"https://github.com/nodejs/node/pull/4112#discussion_r46504639","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4112","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/46504639"},"html":{"href":"https://github.com/nodejs/node/pull/4112#discussion_r46504639"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4112"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4112","id":52342723,"html_url":"https://github.com/nodejs/node/pull/4112","diff_url":"https://github.com/nodejs/node/pull/4112.diff","patch_url":"https://github.com/nodejs/node/pull/4112.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4112","number":4112,"state":"open","locked":false,"title":"src: don't print garbage errors","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"If JS throws an object whose `toString()` method throws, then Node attempts to print an empty message, but actually prints garbage. This commit checks for this case, and prints a newline instead.\r\n\r\nCloses #4079 ","created_at":"2015-12-02T01:40:15Z","updated_at":"2015-12-03T01:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5be21989f7ad84ccb3b494c89c66276e7599c62d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4112/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4112/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4112/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b4b4fe2e2318294e2401c008c2a4478fc0e8130f","head":{"label":"cjihrig:4079","ref":"4079","sha":"b4b4fe2e2318294e2401c008c2a4478fc0e8130f","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"repo":{"id":40613511,"name":"node-1","full_name":"cjihrig/node-1","owner":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjihrig/node-1","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/cjihrig/node-1","forks_url":"https://api.github.com/repos/cjihrig/node-1/forks","keys_url":"https://api.github.com/repos/cjihrig/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjihrig/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjihrig/node-1/teams","hooks_url":"https://api.github.com/repos/cjihrig/node-1/hooks","issue_events_url":"https://api.github.com/repos/cjihrig/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/cjihrig/node-1/events","assignees_url":"https://api.github.com/repos/cjihrig/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/cjihrig/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/cjihrig/node-1/tags","blobs_url":"https://api.github.com/repos/cjihrig/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjihrig/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjihrig/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjihrig/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjihrig/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cjihrig/node-1/languages","stargazers_url":"https://api.github.com/repos/cjihrig/node-1/stargazers","contributors_url":"https://api.github.com/repos/cjihrig/node-1/contributors","subscribers_url":"https://api.github.com/repos/cjihrig/node-1/subscribers","subscription_url":"https://api.github.com/repos/cjihrig/node-1/subscription","commits_url":"https://api.github.com/repos/cjihrig/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjihrig/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjihrig/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjihrig/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjihrig/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/cjihrig/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjihrig/node-1/merges","archive_url":"https://api.github.com/repos/cjihrig/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjihrig/node-1/downloads","issues_url":"https://api.github.com/repos/cjihrig/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/cjihrig/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cjihrig/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cjihrig/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjihrig/node-1/labels{/name}","releases_url":"https://api.github.com/repos/cjihrig/node-1/releases{/id}","created_at":"2015-08-12T17:07:21Z","updated_at":"2015-08-12T17:07:25Z","pushed_at":"2015-12-02T19:02:50Z","git_url":"git://github.com/cjihrig/node-1.git","ssh_url":"git@github.com:cjihrig/node-1.git","clone_url":"https://github.com/cjihrig/node-1.git","svn_url":"https://github.com/cjihrig/node-1","homepage":"https://iojs.org","size":158278,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"451254ed25a3b9860d7b45dade6ed05b629d6bbd","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-12-03T01:50:57Z","pushed_at":"2015-12-03T01:35:38Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":175925,"stargazers_count":17856,"watchers_count":17856,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1923,"mirror_url":null,"open_issues_count":607,"forks":1923,"open_issues":607,"watchers":17856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4112"},"html":{"href":"https://github.com/nodejs/node/pull/4112"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4112"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4112/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4112/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4112/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b4b4fe2e2318294e2401c008c2a4478fc0e8130f"}}}}