{"action":"created","comment":{"url":"https://api.github.com/repos/uber/thriftrw-python/pulls/comments/43709683","id":43709683,"diff_hunk":"@@ -29,3 +29,9 @@ clean:\n \tfind tests thriftrw -name \\*.c -delete\n \tfind tests thriftrw -name \\*.so -delete\n \tmake -C docs clean\n+\n+bootstrap:","path":"Makefile","position":11,"original_position":11,"commit_id":"42e1f14c96893ce0639b0bcf125e57168c1537bf","original_commit_id":"42e1f14c96893ce0639b0bcf125e57168c1537bf","user":{"login":"breerly","id":263587,"avatar_url":"https://avatars.githubusercontent.com/u/263587?v=3","gravatar_id":"","url":"https://api.github.com/users/breerly","html_url":"https://github.com/breerly","followers_url":"https://api.github.com/users/breerly/followers","following_url":"https://api.github.com/users/breerly/following{/other_user}","gists_url":"https://api.github.com/users/breerly/gists{/gist_id}","starred_url":"https://api.github.com/users/breerly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breerly/subscriptions","organizations_url":"https://api.github.com/users/breerly/orgs","repos_url":"https://api.github.com/users/breerly/repos","events_url":"https://api.github.com/users/breerly/events{/privacy}","received_events_url":"https://api.github.com/users/breerly/received_events","type":"User","site_admin":false},"body":"We're using the term `install` in tchannel... which one is better?","created_at":"2015-11-03T02:04:01Z","updated_at":"2015-11-03T02:04:01Z","html_url":"https://github.com/uber/thriftrw-python/pull/72#discussion_r43709683","pull_request_url":"https://api.github.com/repos/uber/thriftrw-python/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/comments/43709683"},"html":{"href":"https://github.com/uber/thriftrw-python/pull/72#discussion_r43709683"},"pull_request":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/uber/thriftrw-python/pulls/72","id":49318574,"html_url":"https://github.com/uber/thriftrw-python/pull/72","diff_url":"https://github.com/uber/thriftrw-python/pull/72.diff","patch_url":"https://github.com/uber/thriftrw-python/pull/72.patch","issue_url":"https://api.github.com/repos/uber/thriftrw-python/issues/72","number":72,"state":"open","locked":false,"title":"Add support for including other Thrift files.","user":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"body":"Renamed .{services,types,constants} on generated modules to have `__` at start\r\nand end to avoid naming conflicts.\r\n\r\nRemoved force flag from load(). The caching behavior is relied upon by the\r\ninclude logic. Users can instantiate new Loaders if they need the result to\r\nnot be cached.\r\n\r\n**Update**: After discussion, we decided that relative includes must always start with `./` or `../`. This makes it clearer that the imports are relative to the .thrift file's directory and also allows us to later add different behavior around when `./` and `../` are not specified (like a thrift path environment variable).","created_at":"2015-10-30T20:28:53Z","updated_at":"2015-11-03T02:04:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"064fb1bfdb58df259ef06c8c4d7334f3f0f3fc03","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/thriftrw-python/pulls/72/commits","review_comments_url":"https://api.github.com/repos/uber/thriftrw-python/pulls/72/comments","review_comment_url":"https://api.github.com/repos/uber/thriftrw-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/thriftrw-python/issues/72/comments","statuses_url":"https://api.github.com/repos/uber/thriftrw-python/statuses/42e1f14c96893ce0639b0bcf125e57168c1537bf","head":{"label":"uber:imports","ref":"imports","sha":"42e1f14c96893ce0639b0bcf125e57168c1537bf","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":40150496,"name":"thriftrw-python","full_name":"uber/thriftrw-python","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/thriftrw-python","description":"Similar to thriftrw but for Python","fork":false,"url":"https://api.github.com/repos/uber/thriftrw-python","forks_url":"https://api.github.com/repos/uber/thriftrw-python/forks","keys_url":"https://api.github.com/repos/uber/thriftrw-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/thriftrw-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/thriftrw-python/teams","hooks_url":"https://api.github.com/repos/uber/thriftrw-python/hooks","issue_events_url":"https://api.github.com/repos/uber/thriftrw-python/issues/events{/number}","events_url":"https://api.github.com/repos/uber/thriftrw-python/events","assignees_url":"https://api.github.com/repos/uber/thriftrw-python/assignees{/user}","branches_url":"https://api.github.com/repos/uber/thriftrw-python/branches{/branch}","tags_url":"https://api.github.com/repos/uber/thriftrw-python/tags","blobs_url":"https://api.github.com/repos/uber/thriftrw-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/thriftrw-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/thriftrw-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/thriftrw-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/thriftrw-python/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/thriftrw-python/languages","stargazers_url":"https://api.github.com/repos/uber/thriftrw-python/stargazers","contributors_url":"https://api.github.com/repos/uber/thriftrw-python/contributors","subscribers_url":"https://api.github.com/repos/uber/thriftrw-python/subscribers","subscription_url":"https://api.github.com/repos/uber/thriftrw-python/subscription","commits_url":"https://api.github.com/repos/uber/thriftrw-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/thriftrw-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/thriftrw-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/thriftrw-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/thriftrw-python/contents/{+path}","compare_url":"https://api.github.com/repos/uber/thriftrw-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/thriftrw-python/merges","archive_url":"https://api.github.com/repos/uber/thriftrw-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/thriftrw-python/downloads","issues_url":"https://api.github.com/repos/uber/thriftrw-python/issues{/number}","pulls_url":"https://api.github.com/repos/uber/thriftrw-python/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/thriftrw-python/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/thriftrw-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/thriftrw-python/labels{/name}","releases_url":"https://api.github.com/repos/uber/thriftrw-python/releases{/id}","created_at":"2015-08-03T22:13:06Z","updated_at":"2015-10-26T21:57:52Z","pushed_at":"2015-11-02T21:11:34Z","git_url":"git://github.com/uber/thriftrw-python.git","ssh_url":"git@github.com:uber/thriftrw-python.git","clone_url":"https://github.com/uber/thriftrw-python.git","svn_url":"https://github.com/uber/thriftrw-python","homepage":null,"size":1407,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":8,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"0b25138b2bd8616b12b7f2d149cdf13d41cfb138","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":40150496,"name":"thriftrw-python","full_name":"uber/thriftrw-python","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/thriftrw-python","description":"Similar to thriftrw but for Python","fork":false,"url":"https://api.github.com/repos/uber/thriftrw-python","forks_url":"https://api.github.com/repos/uber/thriftrw-python/forks","keys_url":"https://api.github.com/repos/uber/thriftrw-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/thriftrw-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/thriftrw-python/teams","hooks_url":"https://api.github.com/repos/uber/thriftrw-python/hooks","issue_events_url":"https://api.github.com/repos/uber/thriftrw-python/issues/events{/number}","events_url":"https://api.github.com/repos/uber/thriftrw-python/events","assignees_url":"https://api.github.com/repos/uber/thriftrw-python/assignees{/user}","branches_url":"https://api.github.com/repos/uber/thriftrw-python/branches{/branch}","tags_url":"https://api.github.com/repos/uber/thriftrw-python/tags","blobs_url":"https://api.github.com/repos/uber/thriftrw-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/thriftrw-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/thriftrw-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/thriftrw-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/thriftrw-python/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/thriftrw-python/languages","stargazers_url":"https://api.github.com/repos/uber/thriftrw-python/stargazers","contributors_url":"https://api.github.com/repos/uber/thriftrw-python/contributors","subscribers_url":"https://api.github.com/repos/uber/thriftrw-python/subscribers","subscription_url":"https://api.github.com/repos/uber/thriftrw-python/subscription","commits_url":"https://api.github.com/repos/uber/thriftrw-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/thriftrw-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/thriftrw-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/thriftrw-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/thriftrw-python/contents/{+path}","compare_url":"https://api.github.com/repos/uber/thriftrw-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/thriftrw-python/merges","archive_url":"https://api.github.com/repos/uber/thriftrw-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/thriftrw-python/downloads","issues_url":"https://api.github.com/repos/uber/thriftrw-python/issues{/number}","pulls_url":"https://api.github.com/repos/uber/thriftrw-python/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/thriftrw-python/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/thriftrw-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/thriftrw-python/labels{/name}","releases_url":"https://api.github.com/repos/uber/thriftrw-python/releases{/id}","created_at":"2015-08-03T22:13:06Z","updated_at":"2015-10-26T21:57:52Z","pushed_at":"2015-11-02T21:11:34Z","git_url":"git://github.com/uber/thriftrw-python.git","ssh_url":"git@github.com:uber/thriftrw-python.git","clone_url":"https://github.com/uber/thriftrw-python.git","svn_url":"https://github.com/uber/thriftrw-python","homepage":null,"size":1407,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/72"},"html":{"href":"https://github.com/uber/thriftrw-python/pull/72"},"issue":{"href":"https://api.github.com/repos/uber/thriftrw-python/issues/72"},"comments":{"href":"https://api.github.com/repos/uber/thriftrw-python/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/thriftrw-python/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/uber/thriftrw-python/statuses/42e1f14c96893ce0639b0bcf125e57168c1537bf"}}}}