{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/comments/39192265","id":39192265,"diff_hunk":"@@ -17,6 +17,10 @@\n   \"At least one of these keys is required in an auth rule map.\"\n   #{:deny :allow :allow-unauthenticated})\n \n+(def valid-methods\n+  \"HTTP methods which are allowed to be configured in a rule.\"\n+  [\"get\" \"post\" \"put\" \"delete\" \"head\" \"any\"])","path":"src/puppetlabs/trapperkeeper/services/authorization/authorization_core.clj","position":6,"original_position":6,"commit_id":"4548c6a058948efa6a45f28b2dd5393e7957cd1a","original_commit_id":"e05863a0c4d542f6ab42ed4daae1c8a0db99eb4d","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://avatars.githubusercontent.com/u/1787615?v=3","gravatar_id":"","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"body":"We should re-use the `Method` schema rather than defining the list twice","created_at":"2015-09-10T18:02:39Z","updated_at":"2015-09-10T18:02:39Z","html_url":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10#discussion_r39192265","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/comments/39192265"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10#discussion_r39192265"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10","id":44498238,"html_url":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10","diff_url":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10.patch","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/10","number":10,"state":"open","locked":false,"title":"(TK-271) Allow list of methods in a rule","user":{"login":"dankreek","id":1510128,"avatar_url":"https://avatars.githubusercontent.com/u/1510128?v=3","gravatar_id":"","url":"https://api.github.com/users/dankreek","html_url":"https://github.com/dankreek","followers_url":"https://api.github.com/users/dankreek/followers","following_url":"https://api.github.com/users/dankreek/following{/other_user}","gists_url":"https://api.github.com/users/dankreek/gists{/gist_id}","starred_url":"https://api.github.com/users/dankreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankreek/subscriptions","organizations_url":"https://api.github.com/users/dankreek/orgs","repos_url":"https://api.github.com/users/dankreek/repos","events_url":"https://api.github.com/users/dankreek/events{/privacy}","received_events_url":"https://api.github.com/users/dankreek/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-09T00:18:23Z","updated_at":"2015-09-10T18:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50dbb0c183e34aab36de314e9f9be68baab53097","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/10/comments","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/statuses/4548c6a058948efa6a45f28b2dd5393e7957cd1a","head":{"label":"dankreek:TK-271/master/method-should-support-lists","ref":"TK-271/master/method-should-support-lists","sha":"4548c6a058948efa6a45f28b2dd5393e7957cd1a","user":{"login":"dankreek","id":1510128,"avatar_url":"https://avatars.githubusercontent.com/u/1510128?v=3","gravatar_id":"","url":"https://api.github.com/users/dankreek","html_url":"https://github.com/dankreek","followers_url":"https://api.github.com/users/dankreek/followers","following_url":"https://api.github.com/users/dankreek/following{/other_user}","gists_url":"https://api.github.com/users/dankreek/gists{/gist_id}","starred_url":"https://api.github.com/users/dankreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankreek/subscriptions","organizations_url":"https://api.github.com/users/dankreek/orgs","repos_url":"https://api.github.com/users/dankreek/repos","events_url":"https://api.github.com/users/dankreek/events{/privacy}","received_events_url":"https://api.github.com/users/dankreek/received_events","type":"User","site_admin":false},"repo":{"id":40329454,"name":"trapperkeeper-authorization","full_name":"dankreek/trapperkeeper-authorization","owner":{"login":"dankreek","id":1510128,"avatar_url":"https://avatars.githubusercontent.com/u/1510128?v=3","gravatar_id":"","url":"https://api.github.com/users/dankreek","html_url":"https://github.com/dankreek","followers_url":"https://api.github.com/users/dankreek/followers","following_url":"https://api.github.com/users/dankreek/following{/other_user}","gists_url":"https://api.github.com/users/dankreek/gists{/gist_id}","starred_url":"https://api.github.com/users/dankreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankreek/subscriptions","organizations_url":"https://api.github.com/users/dankreek/orgs","repos_url":"https://api.github.com/users/dankreek/repos","events_url":"https://api.github.com/users/dankreek/events{/privacy}","received_events_url":"https://api.github.com/users/dankreek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dankreek/trapperkeeper-authorization","description":"Fork of masterzen/trapperkeeper-authorization as a TK service","fork":true,"url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization","forks_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/forks","keys_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/teams","hooks_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/hooks","issue_events_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/issues/events{/number}","events_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/events","assignees_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/assignees{/user}","branches_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/branches{/branch}","tags_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/tags","blobs_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/languages","stargazers_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/stargazers","contributors_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/contributors","subscribers_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/subscribers","subscription_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/subscription","commits_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/contents/{+path}","compare_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/merges","archive_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/downloads","issues_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/issues{/number}","pulls_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/labels{/name}","releases_url":"https://api.github.com/repos/dankreek/trapperkeeper-authorization/releases{/id}","created_at":"2015-08-06T22:20:05Z","updated_at":"2015-08-06T22:20:07Z","pushed_at":"2015-09-10T18:02:05Z","git_url":"git://github.com/dankreek/trapperkeeper-authorization.git","ssh_url":"git@github.com:dankreek/trapperkeeper-authorization.git","clone_url":"https://github.com/dankreek/trapperkeeper-authorization.git","svn_url":"https://github.com/dankreek/trapperkeeper-authorization","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"23ec4f3ebebb9661536ceb41e6fe1f87c5f3fa02","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40329341,"name":"trapperkeeper-authorization","full_name":"puppetlabs/trapperkeeper-authorization","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/trapperkeeper-authorization","description":"Fork of masterzen/trapperkeeper-authorization as a TK service","fork":false,"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization","forks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/forks","keys_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/teams","hooks_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/events","assignees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/tags","blobs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/subscription","commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/merges","archive_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/downloads","issues_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/releases{/id}","created_at":"2015-08-06T22:16:12Z","updated_at":"2015-08-07T18:32:57Z","pushed_at":"2015-09-10T18:02:06Z","git_url":"git://github.com/puppetlabs/trapperkeeper-authorization.git","ssh_url":"git@github.com:puppetlabs/trapperkeeper-authorization.git","clone_url":"https://github.com/puppetlabs/trapperkeeper-authorization.git","svn_url":"https://github.com/puppetlabs/trapperkeeper-authorization","homepage":null,"size":496,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper-authorization/pull/10"},"issue":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/10"},"comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper-authorization/statuses/4548c6a058948efa6a45f28b2dd5393e7957cd1a"}}}}