{"action":"created","issue":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/564","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/564/labels{/name}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/564/comments","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/564/events","html_url":"https://github.com/Smoothieware/Smoothieware/pull/564","id":52524996,"number":564,"title":"Add option to oversample thermistor ADC values.","user":{"login":"PetteriAimonen","id":922265,"avatar_url":"https://avatars.githubusercontent.com/u/922265?v=3","gravatar_id":"","url":"https://api.github.com/users/PetteriAimonen","html_url":"https://github.com/PetteriAimonen","followers_url":"https://api.github.com/users/PetteriAimonen/followers","following_url":"https://api.github.com/users/PetteriAimonen/following{/other_user}","gists_url":"https://api.github.com/users/PetteriAimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/PetteriAimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetteriAimonen/subscriptions","organizations_url":"https://api.github.com/users/PetteriAimonen/orgs","repos_url":"https://api.github.com/users/PetteriAimonen/repos","events_url":"https://api.github.com/users/PetteriAimonen/events{/privacy}","received_events_url":"https://api.github.com/users/PetteriAimonen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2014-12-19T20:27:33Z","updated_at":"2015-02-27T10:09:59Z","closed_at":"2015-02-25T23:12:52Z","pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/564","html_url":"https://github.com/Smoothieware/Smoothieware/pull/564","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/564.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/564.patch"},"body":"This improves the stability of PID control by reducing the effect of quantization\r\non the operation of the D term.\r\n\r\nAlso switched adc_value_to_temperature() to use float math instead of unnecessarily\r\nprecise double calculations.\r\n\r\nhttp://koti.kapsi.fi/jpa/stuff/other/therm_test/report.html (current edge / new default is first image, pull request + config is last image)\r\nThis feature is off by default, set temperature_control.hotend.oversample_freq to e.g. 1000 Hz to enable it.\r\nBy oversampling the ADC value, we get more accurate and less quantized temperature readings.\r\nThis in turn makes the PID D-term behave better and improves temperature stability.\r\nThe effect is largest at high temperatures (>200 C), where the steps are larger with 100K NTC."},"comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/76368936","html_url":"https://github.com/Smoothieware/Smoothieware/pull/564#issuecomment-76368936","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/564","id":76368936,"user":{"login":"PetteriAimonen","id":922265,"avatar_url":"https://avatars.githubusercontent.com/u/922265?v=3","gravatar_id":"","url":"https://api.github.com/users/PetteriAimonen","html_url":"https://github.com/PetteriAimonen","followers_url":"https://api.github.com/users/PetteriAimonen/followers","following_url":"https://api.github.com/users/PetteriAimonen/following{/other_user}","gists_url":"https://api.github.com/users/PetteriAimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/PetteriAimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetteriAimonen/subscriptions","organizations_url":"https://api.github.com/users/PetteriAimonen/orgs","repos_url":"https://api.github.com/users/PetteriAimonen/repos","events_url":"https://api.github.com/users/PetteriAimonen/events{/privacy}","received_events_url":"https://api.github.com/users/PetteriAimonen/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T10:09:59Z","updated_at":"2015-02-27T10:09:59Z","body":"(Definitely wrong place for this rant, but the patch acceptance policy of wolfmanjm is just totally random. Sometimes if you fight him long enough, he'll just accept a patch without any comment or explanation why it is accepted now. So he ends up accepting a lot of bad code, and rejecting a lot of good code. Or maybe I'm just an idiot who cannot code, like he seems to think.)"}}