{"action":"created","comment":{"url":"https://api.github.com/repos/numenta/nupic/pulls/comments/26501586","id":26501586,"diff_hunk":"@@ -138,6 +140,7 @@ def _runLearnInference(self,\n       print \"Test succeeded\"\n \n \n+  @unittest.skip(\"Currently fails due to switch from FDRCSpatial2 to SpatialPooler.\")","path":"tests/unit/nupic/research/sp_learn_inference_test.py","position":87,"original_position":87,"commit_id":"f24b7804ca27da0556ac24e511c2470583b24088","original_commit_id":"d489545ef5149a4b9873c150682394ba47caad0d","user":{"login":"chetan51","id":310282,"avatar_url":"https://avatars.githubusercontent.com/u/310282?v=3","gravatar_id":"","url":"https://api.github.com/users/chetan51","html_url":"https://github.com/chetan51","followers_url":"https://api.github.com/users/chetan51/followers","following_url":"https://api.github.com/users/chetan51/following{/other_user}","gists_url":"https://api.github.com/users/chetan51/gists{/gist_id}","starred_url":"https://api.github.com/users/chetan51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chetan51/subscriptions","organizations_url":"https://api.github.com/users/chetan51/orgs","repos_url":"https://api.github.com/users/chetan51/repos","events_url":"https://api.github.com/users/chetan51/events{/privacy}","received_events_url":"https://api.github.com/users/chetan51/received_events","type":"User","site_admin":false},"body":"Please update the skip comment to elaborate on why the switch causes this test to fail (as you said, the new SP doesn't have explicit methods to get inhibition).","created_at":"2015-03-16T16:31:12Z","updated_at":"2015-03-16T16:31:12Z","html_url":"https://github.com/numenta/nupic/pull/1872#discussion_r26501586","pull_request_url":"https://api.github.com/repos/numenta/nupic/pulls/1872","_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic/pulls/comments/26501586"},"html":{"href":"https://github.com/numenta/nupic/pull/1872#discussion_r26501586"},"pull_request":{"href":"https://api.github.com/repos/numenta/nupic/pulls/1872"}}},"pull_request":{"url":"https://api.github.com/repos/numenta/nupic/pulls/1872","id":29950410,"html_url":"https://github.com/numenta/nupic/pull/1872","diff_url":"https://github.com/numenta/nupic/pull/1872.diff","patch_url":"https://github.com/numenta/nupic/pull/1872.patch","issue_url":"https://api.github.com/repos/numenta/nupic/issues/1872","number":1872,"state":"open","locked":false,"title":"Remove obsolete implementations of SP","user":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"body":"Fixes: #1864\r\n\r\nThis PR basically removes FDRCSpatial2 and FlatSpatialPooler classes.\r\n\r\nTo we safely remove these 2 classes we have to change `spatialImp` parameter from `oldpy` to `py` and update some old field names of these examples/tests to the field names used in the current SpatialPooler class. Example:\r\n\r\n```\r\ncoincidencesShape => columnDimensions\r\ninputShape => inputDimensions\r\ncoincInputRadius => potentialRadius\r\ncoincInputPoolPct => potentialPct\r\nnumActivePerInhArea => numActiveColumnsPerInhArea\r\n```\r\n\r\nOne positive effect of this PR is that field names become more updated and uniform throughout the code.. :smiley: ","created_at":"2015-02-25T00:26:11Z","updated_at":"2015-03-16T16:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34864bb76cf8e3ee52d5f20224ad76538bc6872c","assignee":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/numenta/nupic/milestones/50","html_url":"https://github.com/numenta/nupic/milestones/0.5.0:%20Clean%20code","labels_url":"https://api.github.com/repos/numenta/nupic/milestones/50/labels","id":995925,"number":50,"title":"0.5.0: Clean code","description":"CLEAN CODE\r\n\r\n- C++ code cleanup\r\n- Python code cleanup","creator":{"login":"rhyolight","id":15566,"avatar_url":"https://avatars.githubusercontent.com/u/15566?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyolight","html_url":"https://github.com/rhyolight","followers_url":"https://api.github.com/users/rhyolight/followers","following_url":"https://api.github.com/users/rhyolight/following{/other_user}","gists_url":"https://api.github.com/users/rhyolight/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyolight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyolight/subscriptions","organizations_url":"https://api.github.com/users/rhyolight/orgs","repos_url":"https://api.github.com/users/rhyolight/repos","events_url":"https://api.github.com/users/rhyolight/events{/privacy}","received_events_url":"https://api.github.com/users/rhyolight/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":3,"state":"open","created_at":"2015-02-25T21:37:15Z","updated_at":"2015-03-15T18:30:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numenta/nupic/pulls/1872/commits","review_comments_url":"https://api.github.com/repos/numenta/nupic/pulls/1872/comments","review_comment_url":"https://api.github.com/repos/numenta/nupic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numenta/nupic/issues/1872/comments","statuses_url":"https://api.github.com/repos/numenta/nupic/statuses/f24b7804ca27da0556ac24e511c2470583b24088","head":{"label":"david-ragazzi:remove_old_SPs","ref":"remove_old_SPs","sha":"f24b7804ca27da0556ac24e511c2470583b24088","user":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"repo":{"id":18156369,"name":"nupic","full_name":"david-ragazzi/nupic","owner":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-ragazzi/nupic","description":"Numenta Platform for Intelligent Computing: a brain-inspired machine intelligence platform, and biologically accurate neural network based on cortical learning algorithms.","fork":true,"url":"https://api.github.com/repos/david-ragazzi/nupic","forks_url":"https://api.github.com/repos/david-ragazzi/nupic/forks","keys_url":"https://api.github.com/repos/david-ragazzi/nupic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-ragazzi/nupic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-ragazzi/nupic/teams","hooks_url":"https://api.github.com/repos/david-ragazzi/nupic/hooks","issue_events_url":"https://api.github.com/repos/david-ragazzi/nupic/issues/events{/number}","events_url":"https://api.github.com/repos/david-ragazzi/nupic/events","assignees_url":"https://api.github.com/repos/david-ragazzi/nupic/assignees{/user}","branches_url":"https://api.github.com/repos/david-ragazzi/nupic/branches{/branch}","tags_url":"https://api.github.com/repos/david-ragazzi/nupic/tags","blobs_url":"https://api.github.com/repos/david-ragazzi/nupic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-ragazzi/nupic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-ragazzi/nupic/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-ragazzi/nupic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-ragazzi/nupic/statuses/{sha}","languages_url":"https://api.github.com/repos/david-ragazzi/nupic/languages","stargazers_url":"https://api.github.com/repos/david-ragazzi/nupic/stargazers","contributors_url":"https://api.github.com/repos/david-ragazzi/nupic/contributors","subscribers_url":"https://api.github.com/repos/david-ragazzi/nupic/subscribers","subscription_url":"https://api.github.com/repos/david-ragazzi/nupic/subscription","commits_url":"https://api.github.com/repos/david-ragazzi/nupic/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-ragazzi/nupic/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-ragazzi/nupic/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-ragazzi/nupic/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-ragazzi/nupic/contents/{+path}","compare_url":"https://api.github.com/repos/david-ragazzi/nupic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-ragazzi/nupic/merges","archive_url":"https://api.github.com/repos/david-ragazzi/nupic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-ragazzi/nupic/downloads","issues_url":"https://api.github.com/repos/david-ragazzi/nupic/issues{/number}","pulls_url":"https://api.github.com/repos/david-ragazzi/nupic/pulls{/number}","milestones_url":"https://api.github.com/repos/david-ragazzi/nupic/milestones{/number}","notifications_url":"https://api.github.com/repos/david-ragazzi/nupic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-ragazzi/nupic/labels{/name}","releases_url":"https://api.github.com/repos/david-ragazzi/nupic/releases{/id}","created_at":"2014-03-26T22:33:05Z","updated_at":"2014-12-23T11:50:00Z","pushed_at":"2015-03-15T15:21:14Z","git_url":"git://github.com/david-ragazzi/nupic.git","ssh_url":"git@github.com:david-ragazzi/nupic.git","clone_url":"https://github.com/david-ragazzi/nupic.git","svn_url":"https://github.com/david-ragazzi/nupic","homepage":"http://numenta.org/","size":141156,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numenta:master","ref":"master","sha":"f829dcad86ff71d9fb353faa7d8cb94feb51dea2","user":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"repo":{"id":9252533,"name":"nupic","full_name":"numenta/nupic","owner":{"login":"numenta","id":1039191,"avatar_url":"https://avatars.githubusercontent.com/u/1039191?v=3","gravatar_id":"","url":"https://api.github.com/users/numenta","html_url":"https://github.com/numenta","followers_url":"https://api.github.com/users/numenta/followers","following_url":"https://api.github.com/users/numenta/following{/other_user}","gists_url":"https://api.github.com/users/numenta/gists{/gist_id}","starred_url":"https://api.github.com/users/numenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numenta/subscriptions","organizations_url":"https://api.github.com/users/numenta/orgs","repos_url":"https://api.github.com/users/numenta/repos","events_url":"https://api.github.com/users/numenta/events{/privacy}","received_events_url":"https://api.github.com/users/numenta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numenta/nupic","description":"Numenta Platform for Intelligent Computing: a brain-inspired machine intelligence platform, and biologically accurate neural network based on cortical learning algorithms.","fork":false,"url":"https://api.github.com/repos/numenta/nupic","forks_url":"https://api.github.com/repos/numenta/nupic/forks","keys_url":"https://api.github.com/repos/numenta/nupic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numenta/nupic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numenta/nupic/teams","hooks_url":"https://api.github.com/repos/numenta/nupic/hooks","issue_events_url":"https://api.github.com/repos/numenta/nupic/issues/events{/number}","events_url":"https://api.github.com/repos/numenta/nupic/events","assignees_url":"https://api.github.com/repos/numenta/nupic/assignees{/user}","branches_url":"https://api.github.com/repos/numenta/nupic/branches{/branch}","tags_url":"https://api.github.com/repos/numenta/nupic/tags","blobs_url":"https://api.github.com/repos/numenta/nupic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numenta/nupic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numenta/nupic/git/refs{/sha}","trees_url":"https://api.github.com/repos/numenta/nupic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numenta/nupic/statuses/{sha}","languages_url":"https://api.github.com/repos/numenta/nupic/languages","stargazers_url":"https://api.github.com/repos/numenta/nupic/stargazers","contributors_url":"https://api.github.com/repos/numenta/nupic/contributors","subscribers_url":"https://api.github.com/repos/numenta/nupic/subscribers","subscription_url":"https://api.github.com/repos/numenta/nupic/subscription","commits_url":"https://api.github.com/repos/numenta/nupic/commits{/sha}","git_commits_url":"https://api.github.com/repos/numenta/nupic/git/commits{/sha}","comments_url":"https://api.github.com/repos/numenta/nupic/comments{/number}","issue_comment_url":"https://api.github.com/repos/numenta/nupic/issues/comments{/number}","contents_url":"https://api.github.com/repos/numenta/nupic/contents/{+path}","compare_url":"https://api.github.com/repos/numenta/nupic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numenta/nupic/merges","archive_url":"https://api.github.com/repos/numenta/nupic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numenta/nupic/downloads","issues_url":"https://api.github.com/repos/numenta/nupic/issues{/number}","pulls_url":"https://api.github.com/repos/numenta/nupic/pulls{/number}","milestones_url":"https://api.github.com/repos/numenta/nupic/milestones{/number}","notifications_url":"https://api.github.com/repos/numenta/nupic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numenta/nupic/labels{/name}","releases_url":"https://api.github.com/repos/numenta/nupic/releases{/id}","created_at":"2013-04-05T23:14:27Z","updated_at":"2015-03-16T10:07:24Z","pushed_at":"2015-03-15T18:30:27Z","git_url":"git://github.com/numenta/nupic.git","ssh_url":"git@github.com:numenta/nupic.git","clone_url":"https://github.com/numenta/nupic.git","svn_url":"https://github.com/numenta/nupic","homepage":"http://numenta.org/","size":299300,"stargazers_count":2852,"watchers_count":2852,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":736,"mirror_url":null,"open_issues_count":308,"forks":736,"open_issues":308,"watchers":2852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numenta/nupic/pulls/1872"},"html":{"href":"https://github.com/numenta/nupic/pull/1872"},"issue":{"href":"https://api.github.com/repos/numenta/nupic/issues/1872"},"comments":{"href":"https://api.github.com/repos/numenta/nupic/issues/1872/comments"},"review_comments":{"href":"https://api.github.com/repos/numenta/nupic/pulls/1872/comments"},"review_comment":{"href":"https://api.github.com/repos/numenta/nupic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numenta/nupic/pulls/1872/commits"},"statuses":{"href":"https://api.github.com/repos/numenta/nupic/statuses/f24b7804ca27da0556ac24e511c2470583b24088"}}}}