{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/comments/43615701","id":43615701,"diff_hunk":"@@ -82,7 +81,7 @@ def onConnect(self, response):\n             # response.origin: xyz.shotgunstudio.com\n             domain_valid = self._is_domain_valid(response.origin)\n         except:\n-            self._logger.exception()\n+            self._logger.exception(\"Unexpected error while losing connection.\")","path":"python/tk_framework_desktopserver/server_protocol.py","position":26,"original_position":26,"commit_id":"3cf32032692af5bbfa95b418b974a1c4685c8bee","original_commit_id":"3cf32032692af5bbfa95b418b974a1c4685c8bee","user":{"login":"manneohrstrom","id":337710,"avatar_url":"https://avatars.githubusercontent.com/u/337710?v=3","gravatar_id":"","url":"https://api.github.com/users/manneohrstrom","html_url":"https://github.com/manneohrstrom","followers_url":"https://api.github.com/users/manneohrstrom/followers","following_url":"https://api.github.com/users/manneohrstrom/following{/other_user}","gists_url":"https://api.github.com/users/manneohrstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/manneohrstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manneohrstrom/subscriptions","organizations_url":"https://api.github.com/users/manneohrstrom/orgs","repos_url":"https://api.github.com/users/manneohrstrom/repos","events_url":"https://api.github.com/users/manneohrstrom/events{/privacy}","received_events_url":"https://api.github.com/users/manneohrstrom/received_events","type":"User","site_admin":false},"body":"Should this message say something else for clarity? E.g. `Unexpected error while trying to determine the originating domain` or something?","created_at":"2015-11-02T10:46:36Z","updated_at":"2015-11-02T10:46:36Z","html_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9#discussion_r43615701","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/comments/43615701"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9#discussion_r43615701"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9","id":49058965,"html_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9","diff_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9.diff","patch_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/9","number":9,"state":"open","locked":false,"title":"For #33073, do not log sensitive information","user":{"login":"jfboismenu-adsk","id":8126447,"avatar_url":"https://avatars.githubusercontent.com/u/8126447?v=3","gravatar_id":"","url":"https://api.github.com/users/jfboismenu-adsk","html_url":"https://github.com/jfboismenu-adsk","followers_url":"https://api.github.com/users/jfboismenu-adsk/followers","following_url":"https://api.github.com/users/jfboismenu-adsk/following{/other_user}","gists_url":"https://api.github.com/users/jfboismenu-adsk/gists{/gist_id}","starred_url":"https://api.github.com/users/jfboismenu-adsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfboismenu-adsk/subscriptions","organizations_url":"https://api.github.com/users/jfboismenu-adsk/orgs","repos_url":"https://api.github.com/users/jfboismenu-adsk/repos","events_url":"https://api.github.com/users/jfboismenu-adsk/events{/privacy}","received_events_url":"https://api.github.com/users/jfboismenu-adsk/received_events","type":"User","site_admin":false},"body":"When Twisted is used in debug mode, message content is logged. This can pose a security risk since that information will go to a log file on the user's drive. However this feature is very handy for debugging the server, so now Twisted's logging is sent to stdout and not propagated to the parent logger when debug is set. If debug is not set, the output of Twisted is considered safe and logger messages will be propagated to the parent accordingly.\r\n\r\nThis refactoring also has the benefit that now standard Twisted logging will be logged to desktop, so we can know if there are unexpected errors inside Twisted.","created_at":"2015-10-28T20:01:14Z","updated_at":"2015-11-02T10:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba02a59af63de9cb8fd6c36ac28578a6f811e800","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/9/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/statuses/3cf32032692af5bbfa95b418b974a1c4685c8bee","head":{"label":"shotgunsoftware:33073_do_not_log_password","ref":"33073_do_not_log_password","sha":"3cf32032692af5bbfa95b418b974a1c4685c8bee","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":27185714,"name":"tk-framework-desktopserver","full_name":"shotgunsoftware/tk-framework-desktopserver","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver","description":"A framework that provides a server to run local commands.","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/releases{/id}","created_at":"2014-11-26T16:30:33Z","updated_at":"2015-08-24T23:26:36Z","pushed_at":"2015-10-30T14:46:07Z","git_url":"git://github.com/shotgunsoftware/tk-framework-desktopserver.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-desktopserver.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver","homepage":"","size":10965,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"4916eb0d9b357cd8d9e8b0216ced1f29ba1ff785","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":27185714,"name":"tk-framework-desktopserver","full_name":"shotgunsoftware/tk-framework-desktopserver","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver","description":"A framework that provides a server to run local commands.","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/releases{/id}","created_at":"2014-11-26T16:30:33Z","updated_at":"2015-08-24T23:26:36Z","pushed_at":"2015-10-30T14:46:07Z","git_url":"git://github.com/shotgunsoftware/tk-framework-desktopserver.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-desktopserver.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-desktopserver","homepage":"","size":10965,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-desktopserver/pull/9"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/9"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-desktopserver/statuses/3cf32032692af5bbfa95b418b974a1c4685c8bee"}}}}