{"action":"created","comment":{"url":"https://api.github.com/repos/skatejs/skatejs/pulls/comments/48322405","id":48322405,"diff_hunk":"@@ -79,13 +79,20 @@ function createNativePropertyDefinition (name, opts) {\n \n   prop.get = function () {\n     const info = data(this, `api/property/${name}`);\n+    const internalValue = info.internalValue;\n \n     if (opts.get) {\n-      return opts.get(this);\n+      return opts.get(this, { name, internalValue });\n     }\n \n-    return info.internalValue;\n+    return internalValue;\n   };\n+  \n+  prop.init = function () {\n+    const info = data(this, `api/property/${name}`);\n+    const init = info.internalValue;","path":"src/lifecycle/properties-init.js","position":17,"original_position":17,"commit_id":"eed42a592a2f3b9a7621b7e2988303aed7b23c33","original_commit_id":"eed42a592a2f3b9a7621b7e2988303aed7b23c33","user":{"login":"bqx","id":3261681,"avatar_url":"https://avatars.githubusercontent.com/u/3261681?v=3","gravatar_id":"","url":"https://api.github.com/users/bqx","html_url":"https://github.com/bqx","followers_url":"https://api.github.com/users/bqx/followers","following_url":"https://api.github.com/users/bqx/following{/other_user}","gists_url":"https://api.github.com/users/bqx/gists{/gist_id}","starred_url":"https://api.github.com/users/bqx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bqx/subscriptions","organizations_url":"https://api.github.com/users/bqx/orgs","repos_url":"https://api.github.com/users/bqx/repos","events_url":"https://api.github.com/users/bqx/events{/privacy}","received_events_url":"https://api.github.com/users/bqx/received_events","type":"User","site_admin":false},"body":"Could also shorten to one line by removing `info`","created_at":"2015-12-23T05:22:16Z","updated_at":"2015-12-23T05:22:16Z","html_url":"https://github.com/skatejs/skatejs/pull/458#discussion_r48322405","pull_request_url":"https://api.github.com/repos/skatejs/skatejs/pulls/458","_links":{"self":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/comments/48322405"},"html":{"href":"https://github.com/skatejs/skatejs/pull/458#discussion_r48322405"},"pull_request":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/skatejs/skatejs/pulls/458","id":54438794,"html_url":"https://github.com/skatejs/skatejs/pull/458","diff_url":"https://github.com/skatejs/skatejs/pull/458.diff","patch_url":"https://github.com/skatejs/skatejs/pull/458.patch","issue_url":"https://api.github.com/repos/skatejs/skatejs/issues/458","number":458,"state":"open","locked":false,"title":"FIx issue where the internal value wasn't being passed through to the…","user":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"body":"… setter. Also added more information to the get function.","created_at":"2015-12-23T04:03:15Z","updated_at":"2015-12-23T05:22:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0adecb5e132a1c76d583e57a0c4f6b87f79ac5a","assignee":null,"milestone":{"url":"https://api.github.com/repos/skatejs/skatejs/milestones/32","html_url":"https://github.com/skatejs/skatejs/milestones/0.15.3","labels_url":"https://api.github.com/repos/skatejs/skatejs/milestones/32/labels","id":1472052,"number":32,"title":"0.15.3","description":null,"creator":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-12-23T00:12:58Z","updated_at":"2015-12-23T04:03:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/skatejs/skatejs/pulls/458/commits","review_comments_url":"https://api.github.com/repos/skatejs/skatejs/pulls/458/comments","review_comment_url":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/458/comments","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/eed42a592a2f3b9a7621b7e2988303aed7b23c33","head":{"label":"skatejs:prop-initial-value","ref":"prop-initial-value","sha":"eed42a592a2f3b9a7621b7e2988303aed7b23c33","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"Skate is a web component library that provides an API to bind behaviour to DOM elements. It's based on the W3C specification for Custom Elements.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","created_at":"2014-02-01T00:32:47Z","updated_at":"2015-12-22T10:21:27Z","pushed_at":"2015-12-23T04:03:15Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"","size":3571,"stargazers_count":550,"watchers_count":550,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":13,"forks":27,"open_issues":13,"watchers":550,"default_branch":"master"}},"base":{"label":"skatejs:master","ref":"master","sha":"f16f3f712e8f3cad32007eb25bd2ea8a91616bff","user":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"repo":{"id":16425042,"name":"skatejs","full_name":"skatejs/skatejs","owner":{"login":"skatejs","id":7636121,"avatar_url":"https://avatars.githubusercontent.com/u/7636121?v=3","gravatar_id":"","url":"https://api.github.com/users/skatejs","html_url":"https://github.com/skatejs","followers_url":"https://api.github.com/users/skatejs/followers","following_url":"https://api.github.com/users/skatejs/following{/other_user}","gists_url":"https://api.github.com/users/skatejs/gists{/gist_id}","starred_url":"https://api.github.com/users/skatejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skatejs/subscriptions","organizations_url":"https://api.github.com/users/skatejs/orgs","repos_url":"https://api.github.com/users/skatejs/repos","events_url":"https://api.github.com/users/skatejs/events{/privacy}","received_events_url":"https://api.github.com/users/skatejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skatejs/skatejs","description":"Skate is a web component library that provides an API to bind behaviour to DOM elements. It's based on the W3C specification for Custom Elements.","fork":false,"url":"https://api.github.com/repos/skatejs/skatejs","forks_url":"https://api.github.com/repos/skatejs/skatejs/forks","keys_url":"https://api.github.com/repos/skatejs/skatejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skatejs/skatejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skatejs/skatejs/teams","hooks_url":"https://api.github.com/repos/skatejs/skatejs/hooks","issue_events_url":"https://api.github.com/repos/skatejs/skatejs/issues/events{/number}","events_url":"https://api.github.com/repos/skatejs/skatejs/events","assignees_url":"https://api.github.com/repos/skatejs/skatejs/assignees{/user}","branches_url":"https://api.github.com/repos/skatejs/skatejs/branches{/branch}","tags_url":"https://api.github.com/repos/skatejs/skatejs/tags","blobs_url":"https://api.github.com/repos/skatejs/skatejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skatejs/skatejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skatejs/skatejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/skatejs/skatejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skatejs/skatejs/statuses/{sha}","languages_url":"https://api.github.com/repos/skatejs/skatejs/languages","stargazers_url":"https://api.github.com/repos/skatejs/skatejs/stargazers","contributors_url":"https://api.github.com/repos/skatejs/skatejs/contributors","subscribers_url":"https://api.github.com/repos/skatejs/skatejs/subscribers","subscription_url":"https://api.github.com/repos/skatejs/skatejs/subscription","commits_url":"https://api.github.com/repos/skatejs/skatejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/skatejs/skatejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/skatejs/skatejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/skatejs/skatejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/skatejs/skatejs/contents/{+path}","compare_url":"https://api.github.com/repos/skatejs/skatejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skatejs/skatejs/merges","archive_url":"https://api.github.com/repos/skatejs/skatejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skatejs/skatejs/downloads","issues_url":"https://api.github.com/repos/skatejs/skatejs/issues{/number}","pulls_url":"https://api.github.com/repos/skatejs/skatejs/pulls{/number}","milestones_url":"https://api.github.com/repos/skatejs/skatejs/milestones{/number}","notifications_url":"https://api.github.com/repos/skatejs/skatejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skatejs/skatejs/labels{/name}","releases_url":"https://api.github.com/repos/skatejs/skatejs/releases{/id}","created_at":"2014-02-01T00:32:47Z","updated_at":"2015-12-22T10:21:27Z","pushed_at":"2015-12-23T04:03:15Z","git_url":"git://github.com/skatejs/skatejs.git","ssh_url":"git@github.com:skatejs/skatejs.git","clone_url":"https://github.com/skatejs/skatejs.git","svn_url":"https://github.com/skatejs/skatejs","homepage":"","size":3571,"stargazers_count":550,"watchers_count":550,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":13,"forks":27,"open_issues":13,"watchers":550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/458"},"html":{"href":"https://github.com/skatejs/skatejs/pull/458"},"issue":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/458"},"comments":{"href":"https://api.github.com/repos/skatejs/skatejs/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skatejs/skatejs/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/skatejs/skatejs/statuses/eed42a592a2f3b9a7621b7e2988303aed7b23c33"}}}}