{"action":"created","comment":{"url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/comments/42719338","id":42719338,"diff_hunk":"@@ -412,21 +415,38 @@ public void delete(final Item item, final PersistenceExceptionHandler<?>... pers\n \n     @Override\n     public <T extends Item> Collection<T> fetch(final Query query, final Class<T> itemClass) {\n+        return fetch(query, itemClass, null);\n+    }\n+\n+    @Override\n+    public <T extends Item> Collection<T> fetch(final Query query, final Class<T> itemClass,\n+            final Integer maxPageSize) {\n         final long startTimeMillis = System.currentTimeMillis();\n+\n+        if (maxPageSize != null && maxPageSize < 1) {\n+            throw new UnsuccessfulSearchException(\n+                    \"MaxPageSize value \" + maxPageSize + \" not valid, must be greater than 0\");\n+        }\n+\n         Collection<T> result;\n+\n         if (query instanceof AttributeQuery) {\n-            result = executeQuery((AttributeQuery) query, itemClass);\n+            result = executeQuery((AttributeQuery) query, itemClass, maxPageSize);\n         } else if (query instanceof KeySetQuery) {\n             result = executeQuery((KeySetQuery) query, itemClass);\n         } else {\n             throw new UnsupportedQueryException(query.getClass());\n         }\n+\n         final long elapsedTimeMillis = System.currentTimeMillis() - startTimeMillis;\n+\n         logger.debug(\"Database fetch executed in \" + elapsedTimeMillis + \"ms. Query:[\" + query + \"]\");\n+\n         return result;\n     }\n \n-    private <T extends Item> Collection<T> executeQuery(final AttributeQuery query, final Class<T> itemClass) {\n+    private <T extends Item> Collection<T> executeQuery(final AttributeQuery query, final Class<T> itemClass,\n+            final Integer maxPageSize) {","path":"cheddar/cheddar-integration-aws/src/main/java/com/clicktravel/infrastructure/persistence/aws/dynamodb/DynamoDbTemplate.java","position":153,"original_position":153,"commit_id":"f58d9dbcf1872129e9afab6a35c4676910ef613c","original_commit_id":"f58d9dbcf1872129e9afab6a35c4676910ef613c","user":{"login":"clicktravel-basharat","id":4687263,"avatar_url":"https://avatars.githubusercontent.com/u/4687263?v=3","gravatar_id":"","url":"https://api.github.com/users/clicktravel-basharat","html_url":"https://github.com/clicktravel-basharat","followers_url":"https://api.github.com/users/clicktravel-basharat/followers","following_url":"https://api.github.com/users/clicktravel-basharat/following{/other_user}","gists_url":"https://api.github.com/users/clicktravel-basharat/gists{/gist_id}","starred_url":"https://api.github.com/users/clicktravel-basharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicktravel-basharat/subscriptions","organizations_url":"https://api.github.com/users/clicktravel-basharat/orgs","repos_url":"https://api.github.com/users/clicktravel-basharat/repos","events_url":"https://api.github.com/users/clicktravel-basharat/events{/privacy}","received_events_url":"https://api.github.com/users/clicktravel-basharat/received_events","type":"User","site_admin":false},"body":"See comment above about `Integer`","created_at":"2015-10-22T07:46:17Z","updated_at":"2015-10-22T07:46:17Z","html_url":"https://github.com/ClickTravel/Cheddar/pull/131#discussion_r42719338","pull_request_url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/comments/42719338"},"html":{"href":"https://github.com/ClickTravel/Cheddar/pull/131#discussion_r42719338"},"pull_request":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131","id":48324855,"html_url":"https://github.com/ClickTravel/Cheddar/pull/131","diff_url":"https://github.com/ClickTravel/Cheddar/pull/131.diff","patch_url":"https://github.com/ClickTravel/Cheddar/pull/131.patch","issue_url":"https://api.github.com/repos/ClickTravel/Cheddar/issues/131","number":131,"state":"open","locked":false,"title":"[INV-705] : saleLine table","user":{"login":"clicktravel-craig","id":4125850,"avatar_url":"https://avatars.githubusercontent.com/u/4125850?v=3","gravatar_id":"","url":"https://api.github.com/users/clicktravel-craig","html_url":"https://github.com/clicktravel-craig","followers_url":"https://api.github.com/users/clicktravel-craig/followers","following_url":"https://api.github.com/users/clicktravel-craig/following{/other_user}","gists_url":"https://api.github.com/users/clicktravel-craig/gists{/gist_id}","starred_url":"https://api.github.com/users/clicktravel-craig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicktravel-craig/subscriptions","organizations_url":"https://api.github.com/users/clicktravel-craig/orgs","repos_url":"https://api.github.com/users/clicktravel-craig/repos","events_url":"https://api.github.com/users/clicktravel-craig/events{/privacy}","received_events_url":"https://api.github.com/users/clicktravel-craig/received_events","type":"User","site_admin":false},"body":"This commit adds the ability to set a maximum page size that DynamoDB will use when reading data, this will allow me to run tests on UAT to confirm whether changing the max page size will have the desired impact on reducing read throughputs.\r\n\r\nSigned-off-by: Craig Handley <craig.handley@clicktravel.com>\r\n\r\nthe-cheddar-chapter@clicktravel.com - please review","created_at":"2015-10-21T12:34:35Z","updated_at":"2015-10-22T07:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69bcc4802b7fdc4184d3b32cc63fcfad0ba10b3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131/commits","review_comments_url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131/comments","review_comment_url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClickTravel/Cheddar/issues/131/comments","statuses_url":"https://api.github.com/repos/ClickTravel/Cheddar/statuses/f58d9dbcf1872129e9afab6a35c4676910ef613c","head":{"label":"clicktravel-craig:master","ref":"master","sha":"f58d9dbcf1872129e9afab6a35c4676910ef613c","user":{"login":"clicktravel-craig","id":4125850,"avatar_url":"https://avatars.githubusercontent.com/u/4125850?v=3","gravatar_id":"","url":"https://api.github.com/users/clicktravel-craig","html_url":"https://github.com/clicktravel-craig","followers_url":"https://api.github.com/users/clicktravel-craig/followers","following_url":"https://api.github.com/users/clicktravel-craig/following{/other_user}","gists_url":"https://api.github.com/users/clicktravel-craig/gists{/gist_id}","starred_url":"https://api.github.com/users/clicktravel-craig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicktravel-craig/subscriptions","organizations_url":"https://api.github.com/users/clicktravel-craig/orgs","repos_url":"https://api.github.com/users/clicktravel-craig/repos","events_url":"https://api.github.com/users/clicktravel-craig/events{/privacy}","received_events_url":"https://api.github.com/users/clicktravel-craig/received_events","type":"User","site_admin":false},"repo":{"id":23071818,"name":"Cheddar","full_name":"clicktravel-craig/Cheddar","owner":{"login":"clicktravel-craig","id":4125850,"avatar_url":"https://avatars.githubusercontent.com/u/4125850?v=3","gravatar_id":"","url":"https://api.github.com/users/clicktravel-craig","html_url":"https://github.com/clicktravel-craig","followers_url":"https://api.github.com/users/clicktravel-craig/followers","following_url":"https://api.github.com/users/clicktravel-craig/following{/other_user}","gists_url":"https://api.github.com/users/clicktravel-craig/gists{/gist_id}","starred_url":"https://api.github.com/users/clicktravel-craig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicktravel-craig/subscriptions","organizations_url":"https://api.github.com/users/clicktravel-craig/orgs","repos_url":"https://api.github.com/users/clicktravel-craig/repos","events_url":"https://api.github.com/users/clicktravel-craig/events{/privacy}","received_events_url":"https://api.github.com/users/clicktravel-craig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clicktravel-craig/Cheddar","description":"Click's Hexagonal Domain Driven Architecture","fork":true,"url":"https://api.github.com/repos/clicktravel-craig/Cheddar","forks_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/forks","keys_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/teams","hooks_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/hooks","issue_events_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/issues/events{/number}","events_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/events","assignees_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/assignees{/user}","branches_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/branches{/branch}","tags_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/tags","blobs_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/git/refs{/sha}","trees_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/statuses/{sha}","languages_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/languages","stargazers_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/stargazers","contributors_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/contributors","subscribers_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/subscribers","subscription_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/subscription","commits_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/commits{/sha}","git_commits_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/git/commits{/sha}","comments_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/comments{/number}","issue_comment_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/issues/comments{/number}","contents_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/contents/{+path}","compare_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/merges","archive_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/downloads","issues_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/issues{/number}","pulls_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/pulls{/number}","milestones_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/milestones{/number}","notifications_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/labels{/name}","releases_url":"https://api.github.com/repos/clicktravel-craig/Cheddar/releases{/id}","created_at":"2014-08-18T13:16:58Z","updated_at":"2015-04-30T16:21:01Z","pushed_at":"2015-10-21T12:23:46Z","git_url":"git://github.com/clicktravel-craig/Cheddar.git","ssh_url":"git@github.com:clicktravel-craig/Cheddar.git","clone_url":"https://github.com/clicktravel-craig/Cheddar.git","svn_url":"https://github.com/clicktravel-craig/Cheddar","homepage":null,"size":1379,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ClickTravel:master","ref":"master","sha":"33ffef5f153ed0df9a6830de2fa9be88c385a526","user":{"login":"ClickTravel","id":885969,"avatar_url":"https://avatars.githubusercontent.com/u/885969?v=3","gravatar_id":"","url":"https://api.github.com/users/ClickTravel","html_url":"https://github.com/ClickTravel","followers_url":"https://api.github.com/users/ClickTravel/followers","following_url":"https://api.github.com/users/ClickTravel/following{/other_user}","gists_url":"https://api.github.com/users/ClickTravel/gists{/gist_id}","starred_url":"https://api.github.com/users/ClickTravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClickTravel/subscriptions","organizations_url":"https://api.github.com/users/ClickTravel/orgs","repos_url":"https://api.github.com/users/ClickTravel/repos","events_url":"https://api.github.com/users/ClickTravel/events{/privacy}","received_events_url":"https://api.github.com/users/ClickTravel/received_events","type":"Organization","site_admin":false},"repo":{"id":22964867,"name":"Cheddar","full_name":"ClickTravel/Cheddar","owner":{"login":"ClickTravel","id":885969,"avatar_url":"https://avatars.githubusercontent.com/u/885969?v=3","gravatar_id":"","url":"https://api.github.com/users/ClickTravel","html_url":"https://github.com/ClickTravel","followers_url":"https://api.github.com/users/ClickTravel/followers","following_url":"https://api.github.com/users/ClickTravel/following{/other_user}","gists_url":"https://api.github.com/users/ClickTravel/gists{/gist_id}","starred_url":"https://api.github.com/users/ClickTravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClickTravel/subscriptions","organizations_url":"https://api.github.com/users/ClickTravel/orgs","repos_url":"https://api.github.com/users/ClickTravel/repos","events_url":"https://api.github.com/users/ClickTravel/events{/privacy}","received_events_url":"https://api.github.com/users/ClickTravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClickTravel/Cheddar","description":"Click's Hexagonal Domain Driven Architecture","fork":false,"url":"https://api.github.com/repos/ClickTravel/Cheddar","forks_url":"https://api.github.com/repos/ClickTravel/Cheddar/forks","keys_url":"https://api.github.com/repos/ClickTravel/Cheddar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClickTravel/Cheddar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClickTravel/Cheddar/teams","hooks_url":"https://api.github.com/repos/ClickTravel/Cheddar/hooks","issue_events_url":"https://api.github.com/repos/ClickTravel/Cheddar/issues/events{/number}","events_url":"https://api.github.com/repos/ClickTravel/Cheddar/events","assignees_url":"https://api.github.com/repos/ClickTravel/Cheddar/assignees{/user}","branches_url":"https://api.github.com/repos/ClickTravel/Cheddar/branches{/branch}","tags_url":"https://api.github.com/repos/ClickTravel/Cheddar/tags","blobs_url":"https://api.github.com/repos/ClickTravel/Cheddar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClickTravel/Cheddar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClickTravel/Cheddar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClickTravel/Cheddar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClickTravel/Cheddar/statuses/{sha}","languages_url":"https://api.github.com/repos/ClickTravel/Cheddar/languages","stargazers_url":"https://api.github.com/repos/ClickTravel/Cheddar/stargazers","contributors_url":"https://api.github.com/repos/ClickTravel/Cheddar/contributors","subscribers_url":"https://api.github.com/repos/ClickTravel/Cheddar/subscribers","subscription_url":"https://api.github.com/repos/ClickTravel/Cheddar/subscription","commits_url":"https://api.github.com/repos/ClickTravel/Cheddar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClickTravel/Cheddar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClickTravel/Cheddar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClickTravel/Cheddar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClickTravel/Cheddar/contents/{+path}","compare_url":"https://api.github.com/repos/ClickTravel/Cheddar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClickTravel/Cheddar/merges","archive_url":"https://api.github.com/repos/ClickTravel/Cheddar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClickTravel/Cheddar/downloads","issues_url":"https://api.github.com/repos/ClickTravel/Cheddar/issues{/number}","pulls_url":"https://api.github.com/repos/ClickTravel/Cheddar/pulls{/number}","milestones_url":"https://api.github.com/repos/ClickTravel/Cheddar/milestones{/number}","notifications_url":"https://api.github.com/repos/ClickTravel/Cheddar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClickTravel/Cheddar/labels{/name}","releases_url":"https://api.github.com/repos/ClickTravel/Cheddar/releases{/id}","created_at":"2014-08-14T18:50:56Z","updated_at":"2015-10-15T03:42:22Z","pushed_at":"2015-10-21T12:34:36Z","git_url":"git://github.com/ClickTravel/Cheddar.git","ssh_url":"git@github.com:ClickTravel/Cheddar.git","clone_url":"https://github.com/ClickTravel/Cheddar.git","svn_url":"https://github.com/ClickTravel/Cheddar","homepage":null,"size":1994,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131"},"html":{"href":"https://github.com/ClickTravel/Cheddar/pull/131"},"issue":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/issues/131"},"comments":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/ClickTravel/Cheddar/statuses/f58d9dbcf1872129e9afab6a35c4676910ef613c"}}}}