{"action":"created","comment":{"url":"https://api.github.com/repos/spacetelescope/imexam/pulls/comments/29609309","id":29609309,"diff_hunk":"@@ -333,44 +342,30 @@ def _set_frameinfo(self):\n                                    'extname': extname,\n                                    'naxis': naxis,\n                                    'numaxis': numaxis,\n-                                   'iscube':  iscube,\n+                                   'iscube': iscube,\n                                    'user_array': user_array,\n                                    'mef': mef_file}\n \n-    def _check_filetype(self, filename=None):\n-        \"\"\"check the file to see if the file is a multi-extension fits file\"\"\"\n-        if not filename:\n-            raise ValueError(\"No filename provided\")\n         else:\n-            try:\n-                mef_file = fits.getval(filename, ext=0, keyword='EXTEND')\n-            except KeyError:\n-                mef_file = False\n-\n-            # check to see if the fits file lies\n-            if mef_file:\n-                try:\n-                    nextend = fits.getval(filename, ext=0, keyword='NEXTEND')\n-                except KeyError:\n-                    mef_file = False\n-\n-            return mef_file\n+            warnings.warn(\"No frame loaded in viewer\")\n \n     def valid_data_in_viewer(self):\n         \"\"\"return bool if valid file or array is loaded into the viewer\"\"\"\n         frame = self.frame()\n \n-        if self._viewer[frame]['filename']:\n-            return True\n-        else:\n-            try:\n-                if self._viewer[frame]['user_array'].any():\n-                    valid = True\n-            except (AttributeError, ValueError):\n-                valid = False\n-                print(\"error in array\")\n+        if frame:\n+            self._set_frameinfo()\n \n-            return valid\n+            if self._viewer[frame]['filename']:\n+                return True\n+\n+            else:\n+                try:\n+                    if self._viewer[frame]['user_array'].any():\n+                        return True\n+                except AttributeError as ValueError:","path":"imexam/ds9_viewer.py","position":245,"original_position":245,"commit_id":"9cd8760b5dfd2e6bb416d867b63f6b6548e4a8e0","original_commit_id":"9cd8760b5dfd2e6bb416d867b63f6b6548e4a8e0","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"body":"Not sure what's going on here...  Was this supposed to be `except (AttributeError, ValueError):` ?","created_at":"2015-05-04T18:26:18Z","updated_at":"2015-05-04T18:26:18Z","html_url":"https://github.com/spacetelescope/imexam/pull/28#discussion_r29609309","pull_request_url":"https://api.github.com/repos/spacetelescope/imexam/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/comments/29609309"},"html":{"href":"https://github.com/spacetelescope/imexam/pull/28#discussion_r29609309"},"pull_request":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/spacetelescope/imexam/pulls/28","id":34215787,"html_url":"https://github.com/spacetelescope/imexam/pull/28","diff_url":"https://github.com/spacetelescope/imexam/pull/28.diff","patch_url":"https://github.com/spacetelescope/imexam/pull/28.patch","issue_url":"https://api.github.com/repos/spacetelescope/imexam/issues/28","number":28,"state":"closed","locked":false,"title":"Ginga viewer with matplotlib backend addition, this updates the module to v0.5","user":{"login":"sosey","id":503615,"avatar_url":"https://avatars.githubusercontent.com/u/503615?v=3","gravatar_id":"","url":"https://api.github.com/users/sosey","html_url":"https://github.com/sosey","followers_url":"https://api.github.com/users/sosey/followers","following_url":"https://api.github.com/users/sosey/following{/other_user}","gists_url":"https://api.github.com/users/sosey/gists{/gist_id}","starred_url":"https://api.github.com/users/sosey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosey/subscriptions","organizations_url":"https://api.github.com/users/sosey/orgs","repos_url":"https://api.github.com/users/sosey/repos","events_url":"https://api.github.com/users/sosey/events{/privacy}","received_events_url":"https://api.github.com/users/sosey/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-27T22:09:40Z","updated_at":"2015-05-04T18:26:18Z","closed_at":"2015-05-01T19:12:04Z","merged_at":"2015-05-01T19:12:04Z","merge_commit_sha":"2c5670a9a216f1cc0345dcd6ddb9b05c5b0bfe96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spacetelescope/imexam/pulls/28/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/imexam/pulls/28/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/imexam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/imexam/issues/28/comments","statuses_url":"https://api.github.com/repos/spacetelescope/imexam/statuses/9cd8760b5dfd2e6bb416d867b63f6b6548e4a8e0","head":{"label":"sosey:ginga-viewer","ref":"ginga-viewer","sha":"9cd8760b5dfd2e6bb416d867b63f6b6548e4a8e0","user":{"login":"sosey","id":503615,"avatar_url":"https://avatars.githubusercontent.com/u/503615?v=3","gravatar_id":"","url":"https://api.github.com/users/sosey","html_url":"https://github.com/sosey","followers_url":"https://api.github.com/users/sosey/followers","following_url":"https://api.github.com/users/sosey/following{/other_user}","gists_url":"https://api.github.com/users/sosey/gists{/gist_id}","starred_url":"https://api.github.com/users/sosey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosey/subscriptions","organizations_url":"https://api.github.com/users/sosey/orgs","repos_url":"https://api.github.com/users/sosey/repos","events_url":"https://api.github.com/users/sosey/events{/privacy}","received_events_url":"https://api.github.com/users/sosey/received_events","type":"User","site_admin":false},"repo":{"id":20774078,"name":"imexam","full_name":"sosey/imexam","owner":{"login":"sosey","id":503615,"avatar_url":"https://avatars.githubusercontent.com/u/503615?v=3","gravatar_id":"","url":"https://api.github.com/users/sosey","html_url":"https://github.com/sosey","followers_url":"https://api.github.com/users/sosey/followers","following_url":"https://api.github.com/users/sosey/following{/other_user}","gists_url":"https://api.github.com/users/sosey/gists{/gist_id}","starred_url":"https://api.github.com/users/sosey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosey/subscriptions","organizations_url":"https://api.github.com/users/sosey/orgs","repos_url":"https://api.github.com/users/sosey/repos","events_url":"https://api.github.com/users/sosey/events{/privacy}","received_events_url":"https://api.github.com/users/sosey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sosey/imexam","description":"imexam is a Python replacement for the IRAF imexamine task.","fork":true,"url":"https://api.github.com/repos/sosey/imexam","forks_url":"https://api.github.com/repos/sosey/imexam/forks","keys_url":"https://api.github.com/repos/sosey/imexam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sosey/imexam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sosey/imexam/teams","hooks_url":"https://api.github.com/repos/sosey/imexam/hooks","issue_events_url":"https://api.github.com/repos/sosey/imexam/issues/events{/number}","events_url":"https://api.github.com/repos/sosey/imexam/events","assignees_url":"https://api.github.com/repos/sosey/imexam/assignees{/user}","branches_url":"https://api.github.com/repos/sosey/imexam/branches{/branch}","tags_url":"https://api.github.com/repos/sosey/imexam/tags","blobs_url":"https://api.github.com/repos/sosey/imexam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sosey/imexam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sosey/imexam/git/refs{/sha}","trees_url":"https://api.github.com/repos/sosey/imexam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sosey/imexam/statuses/{sha}","languages_url":"https://api.github.com/repos/sosey/imexam/languages","stargazers_url":"https://api.github.com/repos/sosey/imexam/stargazers","contributors_url":"https://api.github.com/repos/sosey/imexam/contributors","subscribers_url":"https://api.github.com/repos/sosey/imexam/subscribers","subscription_url":"https://api.github.com/repos/sosey/imexam/subscription","commits_url":"https://api.github.com/repos/sosey/imexam/commits{/sha}","git_commits_url":"https://api.github.com/repos/sosey/imexam/git/commits{/sha}","comments_url":"https://api.github.com/repos/sosey/imexam/comments{/number}","issue_comment_url":"https://api.github.com/repos/sosey/imexam/issues/comments{/number}","contents_url":"https://api.github.com/repos/sosey/imexam/contents/{+path}","compare_url":"https://api.github.com/repos/sosey/imexam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sosey/imexam/merges","archive_url":"https://api.github.com/repos/sosey/imexam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sosey/imexam/downloads","issues_url":"https://api.github.com/repos/sosey/imexam/issues{/number}","pulls_url":"https://api.github.com/repos/sosey/imexam/pulls{/number}","milestones_url":"https://api.github.com/repos/sosey/imexam/milestones{/number}","notifications_url":"https://api.github.com/repos/sosey/imexam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sosey/imexam/labels{/name}","releases_url":"https://api.github.com/repos/sosey/imexam/releases{/id}","created_at":"2014-06-12T16:08:52Z","updated_at":"2015-01-16T16:29:33Z","pushed_at":"2015-05-01T18:34:37Z","git_url":"git://github.com/sosey/imexam.git","ssh_url":"git@github.com:sosey/imexam.git","clone_url":"https://github.com/sosey/imexam.git","svn_url":"https://github.com/sosey/imexam","homepage":"","size":10183,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"29cbda217342005dcd61fed6ca229e0d9bb92276","user":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars.githubusercontent.com/u/2751928?v=3","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":18413130,"name":"imexam","full_name":"spacetelescope/imexam","owner":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars.githubusercontent.com/u/2751928?v=3","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spacetelescope/imexam","description":"imexam is a python package replacement for the IRAF imexamine task.","fork":false,"url":"https://api.github.com/repos/spacetelescope/imexam","forks_url":"https://api.github.com/repos/spacetelescope/imexam/forks","keys_url":"https://api.github.com/repos/spacetelescope/imexam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/imexam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/imexam/teams","hooks_url":"https://api.github.com/repos/spacetelescope/imexam/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/imexam/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/imexam/events","assignees_url":"https://api.github.com/repos/spacetelescope/imexam/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/imexam/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/imexam/tags","blobs_url":"https://api.github.com/repos/spacetelescope/imexam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/imexam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/imexam/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/imexam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/imexam/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/imexam/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/imexam/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/imexam/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/imexam/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/imexam/subscription","commits_url":"https://api.github.com/repos/spacetelescope/imexam/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/imexam/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/imexam/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/imexam/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/imexam/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/imexam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/imexam/merges","archive_url":"https://api.github.com/repos/spacetelescope/imexam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/imexam/downloads","issues_url":"https://api.github.com/repos/spacetelescope/imexam/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/imexam/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/imexam/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/imexam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/imexam/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/imexam/releases{/id}","created_at":"2014-04-03T18:12:04Z","updated_at":"2015-05-04T17:53:57Z","pushed_at":"2015-05-04T17:53:57Z","git_url":"git://github.com/spacetelescope/imexam.git","ssh_url":"git@github.com:spacetelescope/imexam.git","clone_url":"https://github.com/spacetelescope/imexam.git","svn_url":"https://github.com/spacetelescope/imexam","homepage":"","size":10491,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/28"},"html":{"href":"https://github.com/spacetelescope/imexam/pull/28"},"issue":{"href":"https://api.github.com/repos/spacetelescope/imexam/issues/28"},"comments":{"href":"https://api.github.com/repos/spacetelescope/imexam/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/imexam/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/imexam/statuses/9cd8760b5dfd2e6bb416d867b63f6b6548e4a8e0"}}}}