{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/esprima/pulls/comments/32500526","id":32500526,"diff_hunk":"@@ -4696,12 +4804,20 @@\n                 token = lookahead;\n                 isStatic = false;\n                 computed = match('[');\n-                key = parseObjectPropertyKey();\n-                if (key.name === 'static' && lookaheadPropertyName()) {\n-                    token = lookahead;\n-                    isStatic = true;\n-                    computed = match('[');\n+                if (match('*')) {\n+                    lex();","path":"esprima.js","position":354,"original_position":353,"commit_id":"e9cc947301705ec7b69ddf285b407d5760f0a7df","original_commit_id":"b2f266c721fd937b0349f3ba781305473bcec97d","user":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"body":"This should be taken care by `tryParseMethodDefinition`. I agree that it would be nice to centralize the handling`*` but this will do for now.","created_at":"2015-06-16T08:34:10Z","updated_at":"2015-06-16T08:34:10Z","html_url":"https://github.com/jquery/esprima/pull/1178#discussion_r32500526","pull_request_url":"https://api.github.com/repos/jquery/esprima/pulls/1178","_links":{"self":{"href":"https://api.github.com/repos/jquery/esprima/pulls/comments/32500526"},"html":{"href":"https://github.com/jquery/esprima/pull/1178#discussion_r32500526"},"pull_request":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1178"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/esprima/pulls/1178","id":35339900,"html_url":"https://github.com/jquery/esprima/pull/1178","diff_url":"https://github.com/jquery/esprima/pull/1178.diff","patch_url":"https://github.com/jquery/esprima/pull/1178.patch","issue_url":"https://api.github.com/repos/jquery/esprima/issues/1178","number":1178,"state":"open","locked":false,"title":"Generator","user":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"body":"This supercedes #1158. The original code from @dhe128 has been rebased onto the latest master and I've added a few tweaks based on the review from @jeffmo.\r\n\r\nThe remaining items:\r\n* `delegate` property to be filed on ESTree\r\n* a new test for `yield` inside an arrow function within a generator","created_at":"2015-05-13T15:36:35Z","updated_at":"2015-06-16T08:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a65955c1d92343367c55c175e1d84a97fc139ef6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/esprima/pulls/1178/commits","review_comments_url":"https://api.github.com/repos/jquery/esprima/pulls/1178/comments","review_comment_url":"https://api.github.com/repos/jquery/esprima/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/esprima/issues/1178/comments","statuses_url":"https://api.github.com/repos/jquery/esprima/statuses/e9cc947301705ec7b69ddf285b407d5760f0a7df","head":{"label":"ariya:generator","ref":"generator","sha":"e9cc947301705ec7b69ddf285b407d5760f0a7df","user":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"repo":{"id":30428679,"name":"esprima","full_name":"ariya/esprima","owner":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariya/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":true,"url":"https://api.github.com/repos/ariya/esprima","forks_url":"https://api.github.com/repos/ariya/esprima/forks","keys_url":"https://api.github.com/repos/ariya/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariya/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariya/esprima/teams","hooks_url":"https://api.github.com/repos/ariya/esprima/hooks","issue_events_url":"https://api.github.com/repos/ariya/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/ariya/esprima/events","assignees_url":"https://api.github.com/repos/ariya/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/ariya/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/ariya/esprima/tags","blobs_url":"https://api.github.com/repos/ariya/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariya/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariya/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariya/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariya/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/ariya/esprima/languages","stargazers_url":"https://api.github.com/repos/ariya/esprima/stargazers","contributors_url":"https://api.github.com/repos/ariya/esprima/contributors","subscribers_url":"https://api.github.com/repos/ariya/esprima/subscribers","subscription_url":"https://api.github.com/repos/ariya/esprima/subscription","commits_url":"https://api.github.com/repos/ariya/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariya/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariya/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariya/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariya/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/ariya/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariya/esprima/merges","archive_url":"https://api.github.com/repos/ariya/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariya/esprima/downloads","issues_url":"https://api.github.com/repos/ariya/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/ariya/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/ariya/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/ariya/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariya/esprima/labels{/name}","releases_url":"https://api.github.com/repos/ariya/esprima/releases{/id}","created_at":"2015-02-06T19:17:29Z","updated_at":"2015-06-09T12:10:14Z","pushed_at":"2015-06-03T13:50:19Z","git_url":"git://github.com/ariya/esprima.git","ssh_url":"git@github.com:ariya/esprima.git","clone_url":"https://github.com/ariya/esprima.git","svn_url":"https://github.com/ariya/esprima","homepage":"http://esprima.org","size":46282,"stargazers_count":132,"watchers_count":132,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":1,"forks":16,"open_issues":1,"watchers":132,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"b2c153e8e8ee006377067259d7965f291c7116eb","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":2833537,"name":"esprima","full_name":"jquery/esprima","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":false,"url":"https://api.github.com/repos/jquery/esprima","forks_url":"https://api.github.com/repos/jquery/esprima/forks","keys_url":"https://api.github.com/repos/jquery/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/esprima/teams","hooks_url":"https://api.github.com/repos/jquery/esprima/hooks","issue_events_url":"https://api.github.com/repos/jquery/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/esprima/events","assignees_url":"https://api.github.com/repos/jquery/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/esprima/tags","blobs_url":"https://api.github.com/repos/jquery/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/esprima/languages","stargazers_url":"https://api.github.com/repos/jquery/esprima/stargazers","contributors_url":"https://api.github.com/repos/jquery/esprima/contributors","subscribers_url":"https://api.github.com/repos/jquery/esprima/subscribers","subscription_url":"https://api.github.com/repos/jquery/esprima/subscription","commits_url":"https://api.github.com/repos/jquery/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/esprima/merges","archive_url":"https://api.github.com/repos/jquery/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/esprima/downloads","issues_url":"https://api.github.com/repos/jquery/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/esprima/labels{/name}","releases_url":"https://api.github.com/repos/jquery/esprima/releases{/id}","created_at":"2011-11-23T05:36:43Z","updated_at":"2015-06-16T08:03:04Z","pushed_at":"2015-06-15T06:24:19Z","git_url":"git://github.com/jquery/esprima.git","ssh_url":"git@github.com:jquery/esprima.git","clone_url":"https://github.com/jquery/esprima.git","svn_url":"https://github.com/jquery/esprima","homepage":"http://esprima.org","size":49092,"stargazers_count":2456,"watchers_count":2456,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":407,"mirror_url":null,"open_issues_count":61,"forks":407,"open_issues":61,"watchers":2456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1178"},"html":{"href":"https://github.com/jquery/esprima/pull/1178"},"issue":{"href":"https://api.github.com/repos/jquery/esprima/issues/1178"},"comments":{"href":"https://api.github.com/repos/jquery/esprima/issues/1178/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1178/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/esprima/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/esprima/pulls/1178/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/esprima/statuses/e9cc947301705ec7b69ddf285b407d5760f0a7df"}}}}