{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/48549171","id":48549171,"diff_hunk":"@@ -488,7 +488,7 @@ public function getAddresses($id_lang)\n         return Cache::retrieve($cache_id);\n     }\n \n-    public function getSimpleAddresses($id_lang = null)\n+    public function getSimpleAddresses($id_lang = null, $no_cache = false)","path":"classes/Customer.php","position":null,"original_position":5,"commit_id":"58baa0fd908aa4eec32cbb87699f3c8be52776b3","original_commit_id":"c88468631112905cd848b7d2b8add88c70d98fa8","user":{"login":"djfm","id":1460499,"avatar_url":"https://avatars.githubusercontent.com/u/1460499?v=3","gravatar_id":"","url":"https://api.github.com/users/djfm","html_url":"https://github.com/djfm","followers_url":"https://api.github.com/users/djfm/followers","following_url":"https://api.github.com/users/djfm/following{/other_user}","gists_url":"https://api.github.com/users/djfm/gists{/gist_id}","starred_url":"https://api.github.com/users/djfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfm/subscriptions","organizations_url":"https://api.github.com/users/djfm/orgs","repos_url":"https://api.github.com/users/djfm/repos","events_url":"https://api.github.com/users/djfm/events{/privacy}","received_events_url":"https://api.github.com/users/djfm/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2015-12-29T15:57:55Z","updated_at":"2015-12-29T15:57:55Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/4626#discussion_r48549171","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/48549171"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4626#discussion_r48549171"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626","id":54648110,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/4626","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/4626.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/4626.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4626","number":4626,"state":"open","locked":false,"title":"Starter theme/feat/checkout reworked","user":{"login":"djfm","id":1460499,"avatar_url":"https://avatars.githubusercontent.com/u/1460499?v=3","gravatar_id":"","url":"https://api.github.com/users/djfm","html_url":"https://github.com/djfm","followers_url":"https://api.github.com/users/djfm/followers","following_url":"https://api.github.com/users/djfm/following{/other_user}","gists_url":"https://api.github.com/users/djfm/gists{/gist_id}","starred_url":"https://api.github.com/users/djfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfm/subscriptions","organizations_url":"https://api.github.com/users/djfm/orgs","repos_url":"https://api.github.com/users/djfm/repos","events_url":"https://api.github.com/users/djfm/events{/privacy}","received_events_url":"https://api.github.com/users/djfm/received_events","type":"User","site_admin":false},"body":"In order to make the checkout process easier to reason about and not dump 2000+ lines of code in a single controller, we introduce the notion of a `CheckoutProcess` that manages `CheckoutStep`s.\r\n\r\nA checkout step has a few flags that allow the `CheckoutProcess` to know how to display them:\r\n- isReachable()\r\n- isComplete()\r\n- isCurrent()\r\n\r\nThe reachable and complete flags are automatically persisted for each step and tied to the Cart object.\r\n\r\nWe also add the ability for a checkout step to persist arbitrary data inbetween the requests, which allows developers to store important data that needs to survive a page refresh (example: the addresses step needs to store whether or not the customer wants to use the same address for invoice and delivery).\r\n\r\nOur goal is that:\r\n- each step of the checkout can be thought of as a \"mini-controller\" that is easy to read, write, and test\r\n- developers can change parts of the checkout process without having to worry about the whole controller\r\n- modules could add / replace steps of the checkout (not implemented, but doable if deemed useful)\r\n\r\nFeedback welcome!","created_at":"2015-12-28T11:10:00Z","updated_at":"2015-12-29T15:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fcde6084b567f553154eadc87d38250b2d719ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4626/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/58baa0fd908aa4eec32cbb87699f3c8be52776b3","head":{"label":"djfm:starter-theme/feat/checkout-reworked","ref":"starter-theme/feat/checkout-reworked","sha":"58baa0fd908aa4eec32cbb87699f3c8be52776b3","user":{"login":"djfm","id":1460499,"avatar_url":"https://avatars.githubusercontent.com/u/1460499?v=3","gravatar_id":"","url":"https://api.github.com/users/djfm","html_url":"https://github.com/djfm","followers_url":"https://api.github.com/users/djfm/followers","following_url":"https://api.github.com/users/djfm/following{/other_user}","gists_url":"https://api.github.com/users/djfm/gists{/gist_id}","starred_url":"https://api.github.com/users/djfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfm/subscriptions","organizations_url":"https://api.github.com/users/djfm/orgs","repos_url":"https://api.github.com/users/djfm/repos","events_url":"https://api.github.com/users/djfm/events{/privacy}","received_events_url":"https://api.github.com/users/djfm/received_events","type":"User","site_admin":false},"repo":{"id":8723586,"name":"PrestaShop","full_name":"djfm/PrestaShop","owner":{"login":"djfm","id":1460499,"avatar_url":"https://avatars.githubusercontent.com/u/1460499?v=3","gravatar_id":"","url":"https://api.github.com/users/djfm","html_url":"https://github.com/djfm","followers_url":"https://api.github.com/users/djfm/followers","following_url":"https://api.github.com/users/djfm/following{/other_user}","gists_url":"https://api.github.com/users/djfm/gists{/gist_id}","starred_url":"https://api.github.com/users/djfm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfm/subscriptions","organizations_url":"https://api.github.com/users/djfm/orgs","repos_url":"https://api.github.com/users/djfm/repos","events_url":"https://api.github.com/users/djfm/events{/privacy}","received_events_url":"https://api.github.com/users/djfm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djfm/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/djfm/PrestaShop","forks_url":"https://api.github.com/repos/djfm/PrestaShop/forks","keys_url":"https://api.github.com/repos/djfm/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djfm/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djfm/PrestaShop/teams","hooks_url":"https://api.github.com/repos/djfm/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/djfm/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/djfm/PrestaShop/events","assignees_url":"https://api.github.com/repos/djfm/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/djfm/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/djfm/PrestaShop/tags","blobs_url":"https://api.github.com/repos/djfm/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djfm/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djfm/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/djfm/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djfm/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/djfm/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/djfm/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/djfm/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/djfm/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/djfm/PrestaShop/subscription","commits_url":"https://api.github.com/repos/djfm/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/djfm/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/djfm/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/djfm/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/djfm/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/djfm/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djfm/PrestaShop/merges","archive_url":"https://api.github.com/repos/djfm/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djfm/PrestaShop/downloads","issues_url":"https://api.github.com/repos/djfm/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/djfm/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/djfm/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/djfm/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djfm/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/djfm/PrestaShop/releases{/id}","created_at":"2013-03-12T08:49:03Z","updated_at":"2015-09-23T13:49:20Z","pushed_at":"2015-12-29T15:56:33Z","git_url":"git://github.com/djfm/PrestaShop.git","ssh_url":"git@github.com:djfm/PrestaShop.git","clone_url":"https://github.com/djfm/PrestaShop.git","svn_url":"https://github.com/djfm/PrestaShop","homepage":"http://www.prestashop.com/","size":236753,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"feat/starter-theme"}},"base":{"label":"PrestaShop:feat/starter-theme","ref":"feat/starter-theme","sha":"8ec78811459f6ded63ab978b2aee6c853db48c02","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","created_at":"2012-11-19T16:41:31Z","updated_at":"2015-12-29T10:36:47Z","pushed_at":"2015-12-29T15:56:48Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":242938,"stargazers_count":1566,"watchers_count":1566,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1716,"mirror_url":null,"open_issues_count":398,"forks":1716,"open_issues":398,"watchers":1566,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4626"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4626"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4626/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4626/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/58baa0fd908aa4eec32cbb87699f3c8be52776b3"}}}}