{"action":"created","issue":{"url":"https://api.github.com/repos/cybereality/Perception/issues/56","labels_url":"https://api.github.com/repos/cybereality/Perception/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/cybereality/Perception/issues/56/comments","events_url":"https://api.github.com/repos/cybereality/Perception/issues/56/events","html_url":"https://github.com/cybereality/Perception/pull/56","id":68815992,"number":56,"title":"Refactoring","user":{"login":"jimrandomh","id":101191,"avatar_url":"https://avatars.githubusercontent.com/u/101191?v=3","gravatar_id":"","url":"https://api.github.com/users/jimrandomh","html_url":"https://github.com/jimrandomh","followers_url":"https://api.github.com/users/jimrandomh/followers","following_url":"https://api.github.com/users/jimrandomh/following{/other_user}","gists_url":"https://api.github.com/users/jimrandomh/gists{/gist_id}","starred_url":"https://api.github.com/users/jimrandomh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimrandomh/subscriptions","organizations_url":"https://api.github.com/users/jimrandomh/orgs","repos_url":"https://api.github.com/users/jimrandomh/repos","events_url":"https://api.github.com/users/jimrandomh/events{/privacy}","received_events_url":"https://api.github.com/users/jimrandomh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-04-16T00:22:34Z","updated_at":"2015-05-01T19:28:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cybereality/Perception/pulls/56","html_url":"https://github.com/cybereality/Perception/pull/56","diff_url":"https://github.com/cybereality/Perception/pull/56.diff","patch_url":"https://github.com/cybereality/Perception/pull/56.patch"},"body":"This pullrequest contains only refactoring, no features or fixes. My medium-term plan is to (among other things) make it so that all the hotkeys are configurable. That requires, first, getting the menu and hotkey-handling code to a point where I can comprehend it and make large changes. Hence refactoring.\r\n\r\n - Hotkeys, popups and menus are split out from D3DProxyDevice.cpp into their own files\r\n - Common idioms with strings, popups and menu drawing are nicer and denser\r\n - Relatively low risk of having broken things\r\n\r\nBecause this moves things into different files and has some find/replace-style changes, it will generate merge conflicts with just about everything. Hence making a pull request immediately, rather than waiting until there's actual feature-work behind it."},"comment":{"url":"https://api.github.com/repos/cybereality/Perception/issues/comments/98212955","html_url":"https://github.com/cybereality/Perception/pull/56#issuecomment-98212955","issue_url":"https://api.github.com/repos/cybereality/Perception/issues/56","id":98212955,"user":{"login":"jimrandomh","id":101191,"avatar_url":"https://avatars.githubusercontent.com/u/101191?v=3","gravatar_id":"","url":"https://api.github.com/users/jimrandomh","html_url":"https://github.com/jimrandomh","followers_url":"https://api.github.com/users/jimrandomh/followers","following_url":"https://api.github.com/users/jimrandomh/following{/other_user}","gists_url":"https://api.github.com/users/jimrandomh/gists{/gist_id}","starred_url":"https://api.github.com/users/jimrandomh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimrandomh/subscriptions","organizations_url":"https://api.github.com/users/jimrandomh/orgs","repos_url":"https://api.github.com/users/jimrandomh/repos","events_url":"https://api.github.com/users/jimrandomh/events{/privacy}","received_events_url":"https://api.github.com/users/jimrandomh/received_events","type":"User","site_admin":false},"created_at":"2015-05-01T19:28:57Z","updated_at":"2015-05-01T19:28:57Z","body":"I agree that the defaults should probably be set to the hotkeys as they\nwere in previous versions, at least initially. For a lot of them, for\nexample black smear correction, currently the only way to adjust the\nsetting is by hotkey; what I envision is having a menu item which leads\ninto a sub-menu where you can both set the setting it directly, and bind\nhotkeys to toggle it, and getting all that and the resetting-to-default and\nsuch handled in a way that scales cleanly with large numbers of settings.\nThere are definitely decisions to be made about menu organization; this is\nnot something I've thought through yet, but it is now in a state where\nmoving things around and making new sub-menus is easy and free of traps.\n\nI'm going to be quite busy with other things over the weekend, but if\nanyone wants to talk on Skype, Tuesday afternoon would be a good time (my\nusername is jimrandomh).\n\nOn May 1, 2015 10:36 AM, \"Grant Bagwell\" <notifications@github.com> wrote:\n\n>\n> Hi James,\n>\n> Sorry I haven't been able to give more feedback. I am currently\ntravelling but will be back in a week or so. I know that Simon is currently\nworking hard to get this branch going and then merged to the master one,\nwhich we can then all work from. I can see there are many improvements\nhere, which is great.\n>\n> However we need to keep control of this and hit one milestone at a time.\nLooking into the latest version I am concerned that all the hotkeys are by\ndefault unbound. This is going to be unintuitive for new users. Having them\nconfigurable is brilliant but a user should just be able to pick up and\nplay, and then get into configuring once they are used to the software. We\nalso need to make sure the menus are intuitive, for example in the current\nversion the hotkeys are linked to the section they are in. So for example\nthe comfort mode hotkey is in the comfort mode section. I am not sure it\nworks well to remove it from here. I would be keen to know all the devs\nthoughts.\n>\n> We also need to get to a stage where we have the main master branch up to\ndate and fully tested with all initial functionality changes agreed,\nworking and correct. I know at the moment you have your own fork, as well\nas a branch Simon setup. Although I am impressed by your speed and work can\nI suggest we all focus on getting that merged in the first instance before\nyou move on? Things like the scrolling issue on the shader analyzer need to\nbe verified fixed and that may be hard to do when there is not an easy way\nto isolate the changes on your fork from other changes that we should all\nagree on is the right direction, before committing.\n>\n> Once we have a solid base we are all happy with we can discuss how things\nshould change. It is vital that we all decide the direction functionality,\nand that we have agreed before moving things forward. Please don't take\nthis as a negative, as as I said the new functionality is looking great.\nWith any Open Source project we just need to make sure we have shared goals\nand plans.\n>\n> —\n> Reply to this email directly or view it on GitHub.\n"}}