{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/44007824","id":44007824,"diff_hunk":"@@ -390,24 +396,46 @@ var GaiaApps = {\n     };\n     return result;\n   },\n+  /**\n+  * Install the app with the specified ManifestURL\n+  */\n+  install: function(manifestURL) {\n+    let req = navigator.mozApps.install(manifestURL);\n+      req.onsuccess = function() {\n+        marionetteScriptFinished(true);\n+      };\n+      req.onerror = function() {\n+        marionetteScriptFinished(req.error);\n+      };\n+  },\n \n+  installPackage: function(manifestURL) {\n+    let req = navigator.mozApps.installPackage(manifestURL);\n+      req.onsuccess = function() {\n+        marionetteScriptFinished(true);\n+      };\n+      req.onerror = function() {\n+        marionetteScriptFinished(req.error);\n+      };\n+  },\n   /**\n-   * Uninstalls the app with the specified name.\n-   */\n-  uninstallWithName: function(name) {\n-    GaiaApps.locateWithName(name, function uninstall(app) {\n-      if (typeof(app) === 'object') {\n-        let req = navigator.mozApps.mgmt.uninstall(app);\n-          req.onsuccess = function() {\n-          marionetteScriptFinished(true);\n-        };\n-        req.onerror = function() {\n-          marionetteScriptFinished(req.error);\n-        };\n-      } else {\n-        // App was never installed, so nothing to do here\n+  * Uninstall the app with the specified ManifestURL\n+  */\n+  uninstall: function(manifestURL) {\n+    GaiaApps.locateWithManifestURL(manifestURL, null, function uninstall(app) {\n+      if (typeof(app) !== 'object') {\n+        // App is already not there, so nothing to do here\n         marionetteScriptFinished(true);\n+        return;\n       }\n+\n+    let req = navigator.mozApps.mgmt.uninstall(app);\n+      req.onsuccess = function() {","path":"tests/atoms/gaia_apps.js","position":90,"original_position":90,"commit_id":"5b3d71495de00bfd3aecd44507b4836ad4913944","original_commit_id":"5b3d71495de00bfd3aecd44507b4836ad4913944","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"Bad indentation","created_at":"2015-11-05T12:52:37Z","updated_at":"2015-11-05T12:52:37Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/32719#discussion_r44007824","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/44007824"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32719#discussion_r44007824"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719","id":48659726,"html_url":"https://github.com/mozilla-b2g/gaia/pull/32719","diff_url":"https://github.com/mozilla-b2g/gaia/pull/32719.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/32719.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32719","number":32719,"state":"open","locked":false,"title":"Bug 1212843 - Provide an install method in gaia_test.py and convert uninstall the use manifestURL","user":{"login":"mermi","id":1905513,"avatar_url":"https://avatars.githubusercontent.com/u/1905513?v=3","gravatar_id":"","url":"https://api.github.com/users/mermi","html_url":"https://github.com/mermi","followers_url":"https://api.github.com/users/mermi/followers","following_url":"https://api.github.com/users/mermi/following{/other_user}","gists_url":"https://api.github.com/users/mermi/gists{/gist_id}","starred_url":"https://api.github.com/users/mermi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mermi/subscriptions","organizations_url":"https://api.github.com/users/mermi/orgs","repos_url":"https://api.github.com/users/mermi/repos","events_url":"https://api.github.com/users/mermi/events{/privacy}","received_events_url":"https://api.github.com/users/mermi/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-24T16:41:59Z","updated_at":"2015-11-05T12:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7b133f1c979a3bebe2150fc76bba60e157f9255","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32719/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/5b3d71495de00bfd3aecd44507b4836ad4913944","head":{"label":"mermi:patchBug1212843","ref":"patchBug1212843","sha":"5b3d71495de00bfd3aecd44507b4836ad4913944","user":{"login":"mermi","id":1905513,"avatar_url":"https://avatars.githubusercontent.com/u/1905513?v=3","gravatar_id":"","url":"https://api.github.com/users/mermi","html_url":"https://github.com/mermi","followers_url":"https://api.github.com/users/mermi/followers","following_url":"https://api.github.com/users/mermi/following{/other_user}","gists_url":"https://api.github.com/users/mermi/gists{/gist_id}","starred_url":"https://api.github.com/users/mermi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mermi/subscriptions","organizations_url":"https://api.github.com/users/mermi/orgs","repos_url":"https://api.github.com/users/mermi/repos","events_url":"https://api.github.com/users/mermi/events{/privacy}","received_events_url":"https://api.github.com/users/mermi/received_events","type":"User","site_admin":false},"repo":{"id":21656013,"name":"gaia","full_name":"mermi/gaia","owner":{"login":"mermi","id":1905513,"avatar_url":"https://avatars.githubusercontent.com/u/1905513?v=3","gravatar_id":"","url":"https://api.github.com/users/mermi","html_url":"https://github.com/mermi","followers_url":"https://api.github.com/users/mermi/followers","following_url":"https://api.github.com/users/mermi/following{/other_user}","gists_url":"https://api.github.com/users/mermi/gists{/gist_id}","starred_url":"https://api.github.com/users/mermi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mermi/subscriptions","organizations_url":"https://api.github.com/users/mermi/orgs","repos_url":"https://api.github.com/users/mermi/repos","events_url":"https://api.github.com/users/mermi/events{/privacy}","received_events_url":"https://api.github.com/users/mermi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mermi/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/mermi/gaia","forks_url":"https://api.github.com/repos/mermi/gaia/forks","keys_url":"https://api.github.com/repos/mermi/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mermi/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mermi/gaia/teams","hooks_url":"https://api.github.com/repos/mermi/gaia/hooks","issue_events_url":"https://api.github.com/repos/mermi/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mermi/gaia/events","assignees_url":"https://api.github.com/repos/mermi/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mermi/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mermi/gaia/tags","blobs_url":"https://api.github.com/repos/mermi/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mermi/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mermi/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mermi/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mermi/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mermi/gaia/languages","stargazers_url":"https://api.github.com/repos/mermi/gaia/stargazers","contributors_url":"https://api.github.com/repos/mermi/gaia/contributors","subscribers_url":"https://api.github.com/repos/mermi/gaia/subscribers","subscription_url":"https://api.github.com/repos/mermi/gaia/subscription","commits_url":"https://api.github.com/repos/mermi/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mermi/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mermi/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mermi/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mermi/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mermi/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mermi/gaia/merges","archive_url":"https://api.github.com/repos/mermi/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mermi/gaia/downloads","issues_url":"https://api.github.com/repos/mermi/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mermi/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mermi/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mermi/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mermi/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mermi/gaia/releases{/id}","created_at":"2014-07-09T14:48:24Z","updated_at":"2015-08-25T22:59:01Z","pushed_at":"2015-11-04T19:50:23Z","git_url":"git://github.com/mermi/gaia.git","ssh_url":"git@github.com:mermi/gaia.git","clone_url":"https://github.com/mermi/gaia.git","svn_url":"https://github.com/mermi/gaia","homepage":"https://wiki.mozilla.org/B2G","size":979514,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"054a3b78e608b223fa61db3ac40cdc8de5727309","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-11-04T11:46:14Z","pushed_at":"2015-11-05T12:29:26Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1707383,"stargazers_count":1994,"watchers_count":1994,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2511,"mirror_url":null,"open_issues_count":1239,"forks":2511,"open_issues":1239,"watchers":1994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32719"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32719"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32719/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32719/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/5b3d71495de00bfd3aecd44507b4836ad4913944"}}}}