{"action":"created","issue":{"url":"https://api.github.com/repos/jmmv/atf/issues/10","labels_url":"https://api.github.com/repos/jmmv/atf/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/jmmv/atf/issues/10/comments","events_url":"https://api.github.com/repos/jmmv/atf/issues/10/events","html_url":"https://github.com/jmmv/atf/pull/10","id":39204977,"number":10,"title":"Add -r timeout[:interval] option to atf-check.","user":{"login":"cemeyer","id":124738,"avatar_url":"https://avatars.githubusercontent.com/u/124738?v=3","gravatar_id":"","url":"https://api.github.com/users/cemeyer","html_url":"https://github.com/cemeyer","followers_url":"https://api.github.com/users/cemeyer/followers","following_url":"https://api.github.com/users/cemeyer/following{/other_user}","gists_url":"https://api.github.com/users/cemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/cemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cemeyer/subscriptions","organizations_url":"https://api.github.com/users/cemeyer/orgs","repos_url":"https://api.github.com/users/cemeyer/repos","events_url":"https://api.github.com/users/cemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/cemeyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2014-07-31T15:20:07Z","updated_at":"2015-03-07T20:28:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jmmv/atf/pulls/10","html_url":"https://github.com/jmmv/atf/pull/10","diff_url":"https://github.com/jmmv/atf/pull/10.diff","patch_url":"https://github.com/jmmv/atf/pull/10.patch"},"body":"Sponsored by:   EMC / Isilon storage division\r\n\r\n[PR notes, not for commit log:\r\n\r\nI'm mostly soliciting feedback, I don't expect this to be merged as-is (although that would be fine with me). Let me know why it's horrible and I can try and clean it up.\r\n\r\nI looked a little bit at trying to make this less noisy (currently each iteration produces the failed status, stdout, and stderr output), but lots of `atf-check.cpp` is hardcoded to write directly out to `std::cout` or `std::cerr`. Changing this would be pretty invasive, and doing it appropriately is probably beyond my C++ abilities.\r\n\r\nDoing it right should just be a matter of directing `atf-check.cpp` output to a `stringstream` for each of stdout, stderr; on repeat (the `if ()` clause where we `usleep()`), clear the buffers with `.str(\"\")` and `.clear()`. On exiting the `do { ... } while (...)` loop, print the contents of each buffer to its appropriate stream. This won't interleave exactly the same, but I hope we were not relying on that.\r\n\r\nThanks for taking a look.]"},"comment":{"url":"https://api.github.com/repos/jmmv/atf/issues/comments/77708373","html_url":"https://github.com/jmmv/atf/pull/10#issuecomment-77708373","issue_url":"https://api.github.com/repos/jmmv/atf/issues/10","id":77708373,"user":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars.githubusercontent.com/u/1895943?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"created_at":"2015-03-07T20:28:00Z","updated_at":"2015-03-07T20:28:00Z","body":"@cemeyer: was the lawyer situation resolved for this?  Would be a shame to see EMC/Isilon unable to contribute to ATF, since I know that it is used there."}}