{"comment":{"url":"https://api.github.com/repos/anandsu/nfs-ganesha/comments/9539754","html_url":"https://github.com/anandsu/nfs-ganesha/commit/2d8bde48000337c3e71891e451daf4fab4a4a2f7#commitcomment-9539754","id":9539754,"user":{"login":"anandsu","id":4830850,"avatar_url":"https://avatars.githubusercontent.com/u/4830850?v=3","gravatar_id":"","url":"https://api.github.com/users/anandsu","html_url":"https://github.com/anandsu","followers_url":"https://api.github.com/users/anandsu/followers","following_url":"https://api.github.com/users/anandsu/following{/other_user}","gists_url":"https://api.github.com/users/anandsu/gists{/gist_id}","starred_url":"https://api.github.com/users/anandsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandsu/subscriptions","organizations_url":"https://api.github.com/users/anandsu/orgs","repos_url":"https://api.github.com/users/anandsu/repos","events_url":"https://api.github.com/users/anandsu/events{/privacy}","received_events_url":"https://api.github.com/users/anandsu/received_events","type":"User","site_admin":false},"position":147,"line":473,"path":"src/MainNFSD/9p_dispatcher.c","commit_id":"2d8bde48000337c3e71891e451daf4fab4a4a2f7","created_at":"2015-02-02T10:22:23Z","updated_at":"2015-02-02T10:22:23Z","body":"I thought the same sockopts are being set on both V4 and V6 sockets here. Its ugly duplication of the setsockopt()'s here, which I would ideally like to place in yet another function to break this up but I think we have another socket_setoptions(sock) function already present and I was actually thinking of merging all the setsockopts() within that function. But couldn't figure out why that was not already done, so maybe there is some reason I can't figure out. (I am talking of a bunch of these setsockopt()'s that do things like NODELAY, KEEPALIVE etc, then immediately after see socket_setoptions() being called."}}