{"action":"opened","number":2710,"pull_request":{"url":"https://api.github.com/repos/atom/electron/pulls/2710","id":44258730,"html_url":"https://github.com/atom/electron/pull/2710","diff_url":"https://github.com/atom/electron/pull/2710.diff","patch_url":"https://github.com/atom/electron/pull/2710.patch","issue_url":"https://api.github.com/repos/atom/electron/issues/2710","number":2710,"state":"open","locked":false,"title":"Fix build failing on windows","user":{"login":"etiktin","id":4381579,"avatar_url":"https://avatars.githubusercontent.com/u/4381579?v=3","gravatar_id":"","url":"https://api.github.com/users/etiktin","html_url":"https://github.com/etiktin","followers_url":"https://api.github.com/users/etiktin/followers","following_url":"https://api.github.com/users/etiktin/following{/other_user}","gists_url":"https://api.github.com/users/etiktin/gists{/gist_id}","starred_url":"https://api.github.com/users/etiktin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiktin/subscriptions","organizations_url":"https://api.github.com/users/etiktin/orgs","repos_url":"https://api.github.com/users/etiktin/repos","events_url":"https://api.github.com/users/etiktin/events{/privacy}","received_events_url":"https://api.github.com/users/etiktin/received_events","type":"User","site_admin":false},"body":"`build.py` would fail on Windows due to a couple of changes made in #2459 that assumed `FilePath::StringType` is always `std::string` and that `FilePath::CharType` is always `char`, which is not the case on Windows. So this commit fixes that.\r\n\r\nThe error report I got from running `build.py`: \r\n```powershell\r\n> python script\\build.py -c D\r\nninja: Entering directory `out\\D'\r\n[43/316] CXX obj\\atom\\browser\\electron_lib.atom_browser_main_parts.obj\r\nFAILED: ninja -t msvc -e environment.x86 -- \"C:\\Program Files (x86)\\Microsoft Visual Studio 12.0\\VC\\bin\\amd64_x86\\cl.exe\" /nologo /showIncludes /FC @obj\\atom\\browser\\electron_lib.atom_browser_main_parts.obj.rsp /c ..\\..\\atom\\browser\\atom_browser_main_parts.cc /Foobj\\atom\\browser\\electron_lib.atom_browser_main_parts.obj /Fdobj\\electron_lib.cc.pdb\r\nc:\\users\\eran.t\\documents\\github\\electron\\atom\\browser\\atom_browser_main_parts.cc(31) : error C2440: 'initializing' : cannot convert from 'const char [11]' to 'const base::FilePath::CharType []'\r\n        There is no context in which this conversion is possible\r\nc:\\users\\eran.t\\documents\\github\\electron\\atom\\browser\\atom_browser_main_parts.cc(80) : error C2664: 'void brightray::BrowserContext::Initialize(const std::string &,bool)' : cannot convert argument 1 from 'const base::FilePath::StringType' to 'const std::string &'\r\n        Reason: cannot convert from 'const base::FilePath::StringType' to 'const std::string'\r\n        No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called\r\n[43/316] CXX obj\\atom\\browser\\api\\electron_lib.atom_api_session.obj\r\nninja: build stopped: subcommand failed.\r\n```","created_at":"2015-09-04T20:33:15Z","updated_at":"2015-09-04T20:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a43d5b49db2f492f007f63f837a8d6565818c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/electron/pulls/2710/commits","review_comments_url":"https://api.github.com/repos/atom/electron/pulls/2710/comments","review_comment_url":"https://api.github.com/repos/atom/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/electron/issues/2710/comments","statuses_url":"https://api.github.com/repos/atom/electron/statuses/0577e911b387b0453c83b21f411e91b8e0df3f5e","head":{"label":"etiktin:fix_build_failing_on_windows","ref":"fix_build_failing_on_windows","sha":"0577e911b387b0453c83b21f411e91b8e0df3f5e","user":{"login":"etiktin","id":4381579,"avatar_url":"https://avatars.githubusercontent.com/u/4381579?v=3","gravatar_id":"","url":"https://api.github.com/users/etiktin","html_url":"https://github.com/etiktin","followers_url":"https://api.github.com/users/etiktin/followers","following_url":"https://api.github.com/users/etiktin/following{/other_user}","gists_url":"https://api.github.com/users/etiktin/gists{/gist_id}","starred_url":"https://api.github.com/users/etiktin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiktin/subscriptions","organizations_url":"https://api.github.com/users/etiktin/orgs","repos_url":"https://api.github.com/users/etiktin/repos","events_url":"https://api.github.com/users/etiktin/events{/privacy}","received_events_url":"https://api.github.com/users/etiktin/received_events","type":"User","site_admin":false},"repo":{"id":39512661,"name":"electron","full_name":"etiktin/electron","owner":{"login":"etiktin","id":4381579,"avatar_url":"https://avatars.githubusercontent.com/u/4381579?v=3","gravatar_id":"","url":"https://api.github.com/users/etiktin","html_url":"https://github.com/etiktin","followers_url":"https://api.github.com/users/etiktin/followers","following_url":"https://api.github.com/users/etiktin/following{/other_user}","gists_url":"https://api.github.com/users/etiktin/gists{/gist_id}","starred_url":"https://api.github.com/users/etiktin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiktin/subscriptions","organizations_url":"https://api.github.com/users/etiktin/orgs","repos_url":"https://api.github.com/users/etiktin/repos","events_url":"https://api.github.com/users/etiktin/events{/privacy}","received_events_url":"https://api.github.com/users/etiktin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etiktin/electron","description":"Build cross platform desktop apps with web technologies","fork":true,"url":"https://api.github.com/repos/etiktin/electron","forks_url":"https://api.github.com/repos/etiktin/electron/forks","keys_url":"https://api.github.com/repos/etiktin/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etiktin/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etiktin/electron/teams","hooks_url":"https://api.github.com/repos/etiktin/electron/hooks","issue_events_url":"https://api.github.com/repos/etiktin/electron/issues/events{/number}","events_url":"https://api.github.com/repos/etiktin/electron/events","assignees_url":"https://api.github.com/repos/etiktin/electron/assignees{/user}","branches_url":"https://api.github.com/repos/etiktin/electron/branches{/branch}","tags_url":"https://api.github.com/repos/etiktin/electron/tags","blobs_url":"https://api.github.com/repos/etiktin/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etiktin/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etiktin/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/etiktin/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etiktin/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/etiktin/electron/languages","stargazers_url":"https://api.github.com/repos/etiktin/electron/stargazers","contributors_url":"https://api.github.com/repos/etiktin/electron/contributors","subscribers_url":"https://api.github.com/repos/etiktin/electron/subscribers","subscription_url":"https://api.github.com/repos/etiktin/electron/subscription","commits_url":"https://api.github.com/repos/etiktin/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/etiktin/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/etiktin/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/etiktin/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/etiktin/electron/contents/{+path}","compare_url":"https://api.github.com/repos/etiktin/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etiktin/electron/merges","archive_url":"https://api.github.com/repos/etiktin/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etiktin/electron/downloads","issues_url":"https://api.github.com/repos/etiktin/electron/issues{/number}","pulls_url":"https://api.github.com/repos/etiktin/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/etiktin/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/etiktin/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etiktin/electron/labels{/name}","releases_url":"https://api.github.com/repos/etiktin/electron/releases{/id}","created_at":"2015-07-22T15:02:35Z","updated_at":"2015-07-22T15:02:38Z","pushed_at":"2015-09-04T20:24:57Z","git_url":"git://github.com/etiktin/electron.git","ssh_url":"git@github.com:etiktin/electron.git","clone_url":"https://github.com/etiktin/electron.git","svn_url":"https://github.com/etiktin/electron","homepage":"http://electron.atom.io","size":10194,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"619c77f409e78c6e2c5c4cd73a2e1292fcb5ac0e","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"atom/electron","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/atom/electron","forks_url":"https://api.github.com/repos/atom/electron/forks","keys_url":"https://api.github.com/repos/atom/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/electron/teams","hooks_url":"https://api.github.com/repos/atom/electron/hooks","issue_events_url":"https://api.github.com/repos/atom/electron/issues/events{/number}","events_url":"https://api.github.com/repos/atom/electron/events","assignees_url":"https://api.github.com/repos/atom/electron/assignees{/user}","branches_url":"https://api.github.com/repos/atom/electron/branches{/branch}","tags_url":"https://api.github.com/repos/atom/electron/tags","blobs_url":"https://api.github.com/repos/atom/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/electron/languages","stargazers_url":"https://api.github.com/repos/atom/electron/stargazers","contributors_url":"https://api.github.com/repos/atom/electron/contributors","subscribers_url":"https://api.github.com/repos/atom/electron/subscribers","subscription_url":"https://api.github.com/repos/atom/electron/subscription","commits_url":"https://api.github.com/repos/atom/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/electron/contents/{+path}","compare_url":"https://api.github.com/repos/atom/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/electron/merges","archive_url":"https://api.github.com/repos/atom/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/electron/downloads","issues_url":"https://api.github.com/repos/atom/electron/issues{/number}","pulls_url":"https://api.github.com/repos/atom/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/electron/labels{/name}","releases_url":"https://api.github.com/repos/atom/electron/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-09-04T19:55:31Z","pushed_at":"2015-09-04T20:33:15Z","git_url":"git://github.com/atom/electron.git","ssh_url":"git@github.com:atom/electron.git","clone_url":"https://github.com/atom/electron.git","svn_url":"https://github.com/atom/electron","homepage":"http://electron.atom.io","size":25465,"stargazers_count":15909,"watchers_count":15909,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1296,"mirror_url":null,"open_issues_count":250,"forks":1296,"open_issues":250,"watchers":15909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/electron/pulls/2710"},"html":{"href":"https://github.com/atom/electron/pull/2710"},"issue":{"href":"https://api.github.com/repos/atom/electron/issues/2710"},"comments":{"href":"https://api.github.com/repos/atom/electron/issues/2710/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/electron/pulls/2710/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/electron/pulls/2710/commits"},"statuses":{"href":"https://api.github.com/repos/atom/electron/statuses/0577e911b387b0453c83b21f411e91b8e0df3f5e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":2,"changed_files":1}}