{"action":"created","issue":{"url":"https://api.github.com/repos/OWASP/DevGuide/issues/36","labels_url":"https://api.github.com/repos/OWASP/DevGuide/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/OWASP/DevGuide/issues/36/comments","events_url":"https://api.github.com/repos/OWASP/DevGuide/issues/36/events","html_url":"https://github.com/OWASP/DevGuide/pull/36","id":60916842,"number":36,"title":"Added and completed several sections. Added some \"pretty pictures\".","user":{"login":"Crashedmind","id":11379816,"avatar_url":"https://avatars.githubusercontent.com/u/11379816?v=3","gravatar_id":"","url":"https://api.github.com/users/Crashedmind","html_url":"https://github.com/Crashedmind","followers_url":"https://api.github.com/users/Crashedmind/followers","following_url":"https://api.github.com/users/Crashedmind/following{/other_user}","gists_url":"https://api.github.com/users/Crashedmind/gists{/gist_id}","starred_url":"https://api.github.com/users/Crashedmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crashedmind/subscriptions","organizations_url":"https://api.github.com/users/Crashedmind/orgs","repos_url":"https://api.github.com/users/Crashedmind/repos","events_url":"https://api.github.com/users/Crashedmind/events{/privacy}","received_events_url":"https://api.github.com/users/Crashedmind/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kwwall","id":1959835,"avatar_url":"https://avatars.githubusercontent.com/u/1959835?v=3","gravatar_id":"","url":"https://api.github.com/users/kwwall","html_url":"https://github.com/kwwall","followers_url":"https://api.github.com/users/kwwall/followers","following_url":"https://api.github.com/users/kwwall/following{/other_user}","gists_url":"https://api.github.com/users/kwwall/gists{/gist_id}","starred_url":"https://api.github.com/users/kwwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwwall/subscriptions","organizations_url":"https://api.github.com/users/kwwall/orgs","repos_url":"https://api.github.com/users/kwwall/repos","events_url":"https://api.github.com/users/kwwall/events{/privacy}","received_events_url":"https://api.github.com/users/kwwall/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-03-12T22:04:42Z","updated_at":"2015-10-26T05:17:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OWASP/DevGuide/pulls/36","html_url":"https://github.com/OWASP/DevGuide/pull/36","diff_url":"https://github.com/OWASP/DevGuide/pull/36.diff","patch_url":"https://github.com/OWASP/DevGuide/pull/36.patch"},"body":"Summary of Edits\r\n================\r\nOrganised cryptography by Primitives, Schemes, Protocols as this is essential to understand and use crypto correctly\r\nAdded \"Use Recommended Cryptography Algorithms\" section along with \"Security Strength\" table so relative strength of algorithms is understood - along with the recommendation to use 128 bits minimum strength for a system.\r\nAdd RNG section as this is fundamental to any crypto solution.\r\nAdded a few \"pretty pictures\", included an overview one for how all this crypto sutff fits together\r\nAdded a Recommendations section.\r\nAdded Key Lifecycle section.\r\nAdded Securing Data in Use section.\r\nAdded guidance on Protocols and attacks in Securing Data in Transit section.\r\nFilled out the Cryptographic Schemes section.\r\nOverall tried to make it crisp and clear.\r\n\r\n\r\n\r\nToDos: Stuff I may add in future edits\r\n======================================\r\nKey Wrapping\r\nside channel - what it is and how to prevent it (does affect servers - not just embedded devices)\r\nentity Authentication approved protocols\r\ndiagram to illustrate modes of failure\r\ndiagram to illustrate what modes allow what manipulation\r\nexact Parameters key nonce plaintext for all algorithms\r\npasswords: \tSecurely Storing Passwords for Authentication Purposes\r\nSSH overview in terms of crypto used\r\n"},"comment":{"url":"https://api.github.com/repos/OWASP/DevGuide/issues/comments/151027208","html_url":"https://github.com/OWASP/DevGuide/pull/36#issuecomment-151027208","issue_url":"https://api.github.com/repos/OWASP/DevGuide/issues/36","id":151027208,"user":{"login":"kwwall","id":1959835,"avatar_url":"https://avatars.githubusercontent.com/u/1959835?v=3","gravatar_id":"","url":"https://api.github.com/users/kwwall","html_url":"https://github.com/kwwall","followers_url":"https://api.github.com/users/kwwall/followers","following_url":"https://api.github.com/users/kwwall/following{/other_user}","gists_url":"https://api.github.com/users/kwwall/gists{/gist_id}","starred_url":"https://api.github.com/users/kwwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwwall/subscriptions","organizations_url":"https://api.github.com/users/kwwall/orgs","repos_url":"https://api.github.com/users/kwwall/repos","events_url":"https://api.github.com/users/kwwall/events{/privacy}","received_events_url":"https://api.github.com/users/kwwall/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T05:17:25Z","updated_at":"2015-10-26T05:17:25Z","body":"@bradchesney79 - I did reach out to contact Chris Madden on this and we exchanged lots of emails, but then he got busy with other things after March and this sort of fell through the cracks. It's not that I object to Chris' new content, but only to some of the content that he revised and reorganized. Merging this is probably going to be a bear because I don't want ALL of the revisions. (You can get a rough idea based on the Word doc that I've attached which was the last time that Chris and I discussed changes back in early April.)\r\n\r\nWhat I propose is that we I come up we reject this pull request (#36) and I put together a new pull request that only incorporates Chris' new materials. (That will take me at least a couple of weeks.) But then we can go from there?\r\n\r\nSound like a plan?\r\n-kevin\r\n\r\nAttached:\r\n[chgs-devguide-chris-madden-0x11-Cryptography(CM).docx](https://github.com/OWASP/DevGuide/files/20425/chgs-devguide-chris-madden-0x11-Cryptography.CM.docx)\r\n"}}