{"action":"closed","number":3719,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/3719","id":48153651,"html_url":"https://github.com/coreos/etcd/pull/3719","diff_url":"https://github.com/coreos/etcd/pull/3719.diff","patch_url":"https://github.com/coreos/etcd/pull/3719.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/3719","number":3719,"state":"closed","locked":false,"title":"etcdctl: improve `etcdctl cluster-health`","user":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"body":"Usually, there are 3 or 5 members in an etcd cluster, `etcdctl cluster-health` will check those members' health sequentially. Although 3 and 5 is not a big number, every member will sleep 250ms to 750ms to ensure raft algorithm making progress on it, so that it can determine if itself healthy. In addition some network latency(or request timeout, which is much more terrible), user must wait about at least 3 to 5 seconds before they finally get the cluster health information.\r\n\r\nI think it's a better choice to check members health status concurrently，especially considered network latency and request time out.","created_at":"2015-10-20T03:41:14Z","updated_at":"2015-10-22T16:10:46Z","closed_at":"2015-10-22T16:10:46Z","merged_at":null,"merge_commit_sha":"7b7292e2e7ab6c78795fb547966f471affd496bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/3719/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/3719/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/3719/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/7f5dcfbf6791a79ae9fc7b4a91e17e045e0acd45","head":{"label":"mqliang:health-waitgroup","ref":"health-waitgroup","sha":"7f5dcfbf6791a79ae9fc7b4a91e17e045e0acd45","user":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"repo":{"id":43418406,"name":"etcd","full_name":"mqliang/etcd","owner":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mqliang/etcd","description":"A distributed consistent key-value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/mqliang/etcd","forks_url":"https://api.github.com/repos/mqliang/etcd/forks","keys_url":"https://api.github.com/repos/mqliang/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqliang/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqliang/etcd/teams","hooks_url":"https://api.github.com/repos/mqliang/etcd/hooks","issue_events_url":"https://api.github.com/repos/mqliang/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/mqliang/etcd/events","assignees_url":"https://api.github.com/repos/mqliang/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/mqliang/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/mqliang/etcd/tags","blobs_url":"https://api.github.com/repos/mqliang/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqliang/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqliang/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqliang/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqliang/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/mqliang/etcd/languages","stargazers_url":"https://api.github.com/repos/mqliang/etcd/stargazers","contributors_url":"https://api.github.com/repos/mqliang/etcd/contributors","subscribers_url":"https://api.github.com/repos/mqliang/etcd/subscribers","subscription_url":"https://api.github.com/repos/mqliang/etcd/subscription","commits_url":"https://api.github.com/repos/mqliang/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqliang/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqliang/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqliang/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqliang/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/mqliang/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqliang/etcd/merges","archive_url":"https://api.github.com/repos/mqliang/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqliang/etcd/downloads","issues_url":"https://api.github.com/repos/mqliang/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/mqliang/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/mqliang/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/mqliang/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqliang/etcd/labels{/name}","releases_url":"https://api.github.com/repos/mqliang/etcd/releases{/id}","created_at":"2015-09-30T07:26:49Z","updated_at":"2015-09-30T07:26:52Z","pushed_at":"2015-10-22T04:41:51Z","git_url":"git://github.com/mqliang/etcd.git","ssh_url":"git@github.com:mqliang/etcd.git","clone_url":"https://github.com/mqliang/etcd.git","svn_url":"https://github.com/mqliang/etcd","homepage":"","size":18803,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"7dcb99b60ee2c0db36153eff887239631fe957c4","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"A distributed consistent key-value store for shared configuration and service discovery","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","created_at":"2013-07-06T21:57:21Z","updated_at":"2015-10-22T16:06:56Z","pushed_at":"2015-10-22T11:19:24Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"","size":37500,"stargazers_count":7810,"watchers_count":7810,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1157,"mirror_url":null,"open_issues_count":146,"forks":1157,"open_issues":146,"watchers":7810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/3719"},"html":{"href":"https://github.com/coreos/etcd/pull/3719"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/3719"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/3719/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/3719/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/3719/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/7f5dcfbf6791a79ae9fc7b4a91e17e045e0acd45"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":2,"commits":2,"additions":55,"deletions":42,"changed_files":1}}