{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40","labels_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40/comments","events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40/events","html_url":"https://github.com/alphagov/govuk-content-schemas/pull/40","id":68702191,"number":40,"title":"[DISCUSS] Make public_updated_at required for everything","user":{"login":"jamiecobbett","id":93739,"avatar_url":"https://avatars.githubusercontent.com/u/93739?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiecobbett","html_url":"https://github.com/jamiecobbett","followers_url":"https://api.github.com/users/jamiecobbett/followers","following_url":"https://api.github.com/users/jamiecobbett/following{/other_user}","gists_url":"https://api.github.com/users/jamiecobbett/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiecobbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiecobbett/subscriptions","organizations_url":"https://api.github.com/users/jamiecobbett/orgs","repos_url":"https://api.github.com/users/jamiecobbett/repos","events_url":"https://api.github.com/users/jamiecobbett/events{/privacy}","received_events_url":"https://api.github.com/users/jamiecobbett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-15T14:48:17Z","updated_at":"2015-04-16T14:17:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/40","html_url":"https://github.com/alphagov/govuk-content-schemas/pull/40","diff_url":"https://github.com/alphagov/govuk-content-schemas/pull/40.diff","patch_url":"https://github.com/alphagov/govuk-content-schemas/pull/40.patch"},"body":"This is currently optional in content-store, making it required here is a route\r\nto making it required there (and then backfilling the data).\r\n\r\nWe have been thinking of public_updated_at as \"the updated date which users\r\nsee\" and because some formats don't display this (eg gone/redirect items), it\r\nhas been optional.\r\n\r\nHowever, it seems to me that it isn't about what the user sees, but when there\r\nwas last a (significant) semantic change to the content at the URL. Therefore,\r\neverything should have a public_updated_at.\r\n\r\nAs an example, it being optional meant that a placeholder without a\r\npublic_updated_at was added by publisher which then broke an expectation in\r\nemail-alert-service and stopped it from consuming any more messages from the\r\nqueue.\r\n\r\nTo make the Whitehall tests pass for \"coming soon\" items, we'd need to do something like: https://github.com/alphagov/whitehall/compare/supply_public_updated_at_for_coming_soon?expand=1"},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/comments/93745717","html_url":"https://github.com/alphagov/govuk-content-schemas/pull/40#issuecomment-93745717","issue_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/40","id":93745717,"user":{"login":"rboulton","id":73564,"avatar_url":"https://avatars.githubusercontent.com/u/73564?v=3","gravatar_id":"","url":"https://api.github.com/users/rboulton","html_url":"https://github.com/rboulton","followers_url":"https://api.github.com/users/rboulton/followers","following_url":"https://api.github.com/users/rboulton/following{/other_user}","gists_url":"https://api.github.com/users/rboulton/gists{/gist_id}","starred_url":"https://api.github.com/users/rboulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rboulton/subscriptions","organizations_url":"https://api.github.com/users/rboulton/orgs","repos_url":"https://api.github.com/users/rboulton/repos","events_url":"https://api.github.com/users/rboulton/events{/privacy}","received_events_url":"https://api.github.com/users/rboulton/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T14:17:35Z","updated_at":"2015-04-16T14:17:35Z","body":"I agree with the logic behind this change.  Currently failing the whitehall contract tests, though."}}