{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/38693172","id":38693172,"diff_hunk":"@@ -0,0 +1,107 @@\n+<?php\n+\n+namespace Illuminate\\Auth\\Access;\n+\n+class Grant\n+{\n+    /**\n+     * Indicates whether the request was granted.\n+     *\n+     * @var bool\n+     */\n+    protected $allowed;\n+\n+    /**\n+     * The reason the request was granted/denied.\n+     *\n+     * @var string|null\n+     */\n+    protected $reason;\n+\n+    /**\n+     * Create a new access grant instance.\n+     *\n+     * @return void\n+     */\n+    protected function __construct()\n+    {\n+        //","path":"src/Illuminate/Auth/Access/Grant.php","position":28,"original_position":28,"commit_id":"96274632a677a0acf64ba4dca6a5e0424ef5b168","original_commit_id":"96274632a677a0acf64ba4dca6a5e0424ef5b168","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"maybe include a comment here regarding the significance of making this method protected - can be useful for less experienced php developers reading laravel's source","created_at":"2015-09-03T20:33:18Z","updated_at":"2015-09-03T20:33:18Z","html_url":"https://github.com/laravel/framework/pull/10132#discussion_r38693172","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/10132","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/38693172"},"html":{"href":"https://github.com/laravel/framework/pull/10132#discussion_r38693172"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/10132"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/10132","id":43998827,"html_url":"https://github.com/laravel/framework/pull/10132","diff_url":"https://github.com/laravel/framework/pull/10132.diff","patch_url":"https://github.com/laravel/framework/pull/10132.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/10132","number":10132,"state":"open","locked":false,"title":"[5.1] Create Gate Access Grants, so that a Policy can deny access with a reason","user":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"body":"This would allow the policy to return with a reason for denying access, which would then be used in the 403 `HttpException` in the `AuthorizesRequests` trait:\r\n\r\n```php\r\nuse App\\User;\r\nuse App\\Post;\r\nuse Illumiante\\Auth\\Access\\CreatesGrants;\r\n\r\nclass PostPolicy\r\n{\r\n    use CreatesGrants;\r\n\r\n    public function update(User $user, Post $post)\r\n    {\r\n        if ($user->id !== $post->user_id) {\r\n            return $this->deny('You are not the owner of this post.');\r\n        }\r\n\r\n        if ($post->isClosed()) {\r\n            return $this->deny('Post is closed and cannot be updated.');\r\n        }\r\n\r\n        return $this->allow();\r\n    }\r\n}\r\n```\r\n\r\n---\r\n\r\nI'm not entirely set on the `Grant` nomenclature. I've played with `Pass`, `Card`, `Token` and more, but have found `Grant` to be the most semantic in this case. I'm open to suggestions.","created_at":"2015-09-02T14:33:05Z","updated_at":"2015-09-03T20:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec22f3fb0902591066edf1bb982e762796cd3dc2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/10132/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/10132/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/10132/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/96274632a677a0acf64ba4dca6a5e0424ef5b168","head":{"label":"JosephSilber:gate-deny-message","ref":"gate-deny-message","sha":"96274632a677a0acf64ba4dca6a5e0424ef5b168","user":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"repo":{"id":10986597,"name":"framework","full_name":"JosephSilber/framework","owner":{"login":"JosephSilber","id":1403741,"avatar_url":"https://avatars.githubusercontent.com/u/1403741?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephSilber","html_url":"https://github.com/JosephSilber","followers_url":"https://api.github.com/users/JosephSilber/followers","following_url":"https://api.github.com/users/JosephSilber/following{/other_user}","gists_url":"https://api.github.com/users/JosephSilber/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephSilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephSilber/subscriptions","organizations_url":"https://api.github.com/users/JosephSilber/orgs","repos_url":"https://api.github.com/users/JosephSilber/repos","events_url":"https://api.github.com/users/JosephSilber/events{/privacy}","received_events_url":"https://api.github.com/users/JosephSilber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosephSilber/framework","description":"","fork":true,"url":"https://api.github.com/repos/JosephSilber/framework","forks_url":"https://api.github.com/repos/JosephSilber/framework/forks","keys_url":"https://api.github.com/repos/JosephSilber/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosephSilber/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosephSilber/framework/teams","hooks_url":"https://api.github.com/repos/JosephSilber/framework/hooks","issue_events_url":"https://api.github.com/repos/JosephSilber/framework/issues/events{/number}","events_url":"https://api.github.com/repos/JosephSilber/framework/events","assignees_url":"https://api.github.com/repos/JosephSilber/framework/assignees{/user}","branches_url":"https://api.github.com/repos/JosephSilber/framework/branches{/branch}","tags_url":"https://api.github.com/repos/JosephSilber/framework/tags","blobs_url":"https://api.github.com/repos/JosephSilber/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosephSilber/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosephSilber/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosephSilber/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosephSilber/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/JosephSilber/framework/languages","stargazers_url":"https://api.github.com/repos/JosephSilber/framework/stargazers","contributors_url":"https://api.github.com/repos/JosephSilber/framework/contributors","subscribers_url":"https://api.github.com/repos/JosephSilber/framework/subscribers","subscription_url":"https://api.github.com/repos/JosephSilber/framework/subscription","commits_url":"https://api.github.com/repos/JosephSilber/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosephSilber/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosephSilber/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosephSilber/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosephSilber/framework/contents/{+path}","compare_url":"https://api.github.com/repos/JosephSilber/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosephSilber/framework/merges","archive_url":"https://api.github.com/repos/JosephSilber/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosephSilber/framework/downloads","issues_url":"https://api.github.com/repos/JosephSilber/framework/issues{/number}","pulls_url":"https://api.github.com/repos/JosephSilber/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/JosephSilber/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/JosephSilber/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosephSilber/framework/labels{/name}","releases_url":"https://api.github.com/repos/JosephSilber/framework/releases{/id}","created_at":"2013-06-27T03:50:55Z","updated_at":"2015-04-13T02:21:22Z","pushed_at":"2015-09-03T20:03:11Z","git_url":"git://github.com/JosephSilber/framework.git","ssh_url":"git@github.com:JosephSilber/framework.git","clone_url":"https://github.com/JosephSilber/framework.git","svn_url":"https://github.com/JosephSilber/framework","homepage":null,"size":18963,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"231b5ee6d8439edb5f7d45da00fd31d915bdf6f0","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-09-03T19:39:42Z","pushed_at":"2015-09-03T20:03:12Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":66652,"stargazers_count":4019,"watchers_count":4019,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2279,"mirror_url":null,"open_issues_count":79,"forks":2279,"open_issues":79,"watchers":4019,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/10132"},"html":{"href":"https://github.com/laravel/framework/pull/10132"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/10132"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/10132/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/10132/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/10132/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/96274632a677a0acf64ba4dca6a5e0424ef5b168"}}}}