{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20","id":35713068,"html_url":"https://github.com/juliangruber/reconnect-core/pull/20","diff_url":"https://github.com/juliangruber/reconnect-core/pull/20.diff","patch_url":"https://github.com/juliangruber/reconnect-core/pull/20.patch","issue_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/20","number":20,"state":"closed","locked":false,"title":"Emit 'connection' before 'connect'","user":{"login":"piranna","id":532414,"avatar_url":"https://avatars.githubusercontent.com/u/532414?v=3","gravatar_id":"","url":"https://api.github.com/users/piranna","html_url":"https://github.com/piranna","followers_url":"https://api.github.com/users/piranna/followers","following_url":"https://api.github.com/users/piranna/following{/other_user}","gists_url":"https://api.github.com/users/piranna/gists{/gist_id}","starred_url":"https://api.github.com/users/piranna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranna/subscriptions","organizations_url":"https://api.github.com/users/piranna/orgs","repos_url":"https://api.github.com/users/piranna/repos","events_url":"https://api.github.com/users/piranna/events{/privacy}","received_events_url":"https://api.github.com/users/piranna/received_events","type":"User","site_admin":false},"body":"onConnect is attached to the 'connection' event, so it's possible that the user attach to the 'connect' event and get called previously to the connection was correctly done (if onConnect is used to finish the connection). Emitting the 'connection' event before the 'connect' one it ensures that onConnect is the first function being called and that the connection is correctly done.","created_at":"2015-05-19T09:53:11Z","updated_at":"2015-11-12T11:02:50Z","closed_at":"2015-11-12T11:02:50Z","merged_at":null,"merge_commit_sha":"f70a307c8d2f338b429bd99d49d9ab6a3c08c8b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20/commits","review_comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20/comments","review_comment_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/20/comments","statuses_url":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/3a3b4e5163e1fcd2a95ffe6f88da87a4d55dd42e","head":{"label":"piranna:patch-1","ref":"patch-1","sha":"3a3b4e5163e1fcd2a95ffe6f88da87a4d55dd42e","user":{"login":"piranna","id":532414,"avatar_url":"https://avatars.githubusercontent.com/u/532414?v=3","gravatar_id":"","url":"https://api.github.com/users/piranna","html_url":"https://github.com/piranna","followers_url":"https://api.github.com/users/piranna/followers","following_url":"https://api.github.com/users/piranna/following{/other_user}","gists_url":"https://api.github.com/users/piranna/gists{/gist_id}","starred_url":"https://api.github.com/users/piranna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranna/subscriptions","organizations_url":"https://api.github.com/users/piranna/orgs","repos_url":"https://api.github.com/users/piranna/repos","events_url":"https://api.github.com/users/piranna/events{/privacy}","received_events_url":"https://api.github.com/users/piranna/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"juliangruber:master","ref":"master","sha":"db4556d7ae208537e6c23a4312d80e4bf0ef4f10","user":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"repo":{"id":11726960,"name":"reconnect-core","full_name":"juliangruber/reconnect-core","owner":{"login":"juliangruber","id":10247,"avatar_url":"https://avatars.githubusercontent.com/u/10247?v=3","gravatar_id":"","url":"https://api.github.com/users/juliangruber","html_url":"https://github.com/juliangruber","followers_url":"https://api.github.com/users/juliangruber/followers","following_url":"https://api.github.com/users/juliangruber/following{/other_user}","gists_url":"https://api.github.com/users/juliangruber/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangruber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangruber/subscriptions","organizations_url":"https://api.github.com/users/juliangruber/orgs","repos_url":"https://api.github.com/users/juliangruber/repos","events_url":"https://api.github.com/users/juliangruber/events{/privacy}","received_events_url":"https://api.github.com/users/juliangruber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliangruber/reconnect-core","description":"Generic stream reconnection module.","fork":false,"url":"https://api.github.com/repos/juliangruber/reconnect-core","forks_url":"https://api.github.com/repos/juliangruber/reconnect-core/forks","keys_url":"https://api.github.com/repos/juliangruber/reconnect-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliangruber/reconnect-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliangruber/reconnect-core/teams","hooks_url":"https://api.github.com/repos/juliangruber/reconnect-core/hooks","issue_events_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/events{/number}","events_url":"https://api.github.com/repos/juliangruber/reconnect-core/events","assignees_url":"https://api.github.com/repos/juliangruber/reconnect-core/assignees{/user}","branches_url":"https://api.github.com/repos/juliangruber/reconnect-core/branches{/branch}","tags_url":"https://api.github.com/repos/juliangruber/reconnect-core/tags","blobs_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/{sha}","languages_url":"https://api.github.com/repos/juliangruber/reconnect-core/languages","stargazers_url":"https://api.github.com/repos/juliangruber/reconnect-core/stargazers","contributors_url":"https://api.github.com/repos/juliangruber/reconnect-core/contributors","subscribers_url":"https://api.github.com/repos/juliangruber/reconnect-core/subscribers","subscription_url":"https://api.github.com/repos/juliangruber/reconnect-core/subscription","commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliangruber/reconnect-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliangruber/reconnect-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliangruber/reconnect-core/contents/{+path}","compare_url":"https://api.github.com/repos/juliangruber/reconnect-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliangruber/reconnect-core/merges","archive_url":"https://api.github.com/repos/juliangruber/reconnect-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliangruber/reconnect-core/downloads","issues_url":"https://api.github.com/repos/juliangruber/reconnect-core/issues{/number}","pulls_url":"https://api.github.com/repos/juliangruber/reconnect-core/pulls{/number}","milestones_url":"https://api.github.com/repos/juliangruber/reconnect-core/milestones{/number}","notifications_url":"https://api.github.com/repos/juliangruber/reconnect-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliangruber/reconnect-core/labels{/name}","releases_url":"https://api.github.com/repos/juliangruber/reconnect-core/releases{/id}","created_at":"2013-07-28T22:45:55Z","updated_at":"2015-11-09T03:32:36Z","pushed_at":"2015-11-09T09:46:27Z","git_url":"git://github.com/juliangruber/reconnect-core.git","ssh_url":"git@github.com:juliangruber/reconnect-core.git","clone_url":"https://github.com/juliangruber/reconnect-core.git","svn_url":"https://github.com/juliangruber/reconnect-core","homepage":null,"size":341,"stargazers_count":76,"watchers_count":76,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20"},"html":{"href":"https://github.com/juliangruber/reconnect-core/pull/20"},"issue":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/issues/20"},"comments":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/juliangruber/reconnect-core/statuses/3a3b4e5163e1fcd2a95ffe6f88da87a4d55dd42e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":8,"deletions":6,"changed_files":1}}