{"action":"created","comment":{"url":"https://api.github.com/repos/akvo/akvo-flow/pulls/comments/34867853","id":34867853,"diff_hunk":"@@ -211,8 +211,9 @@ FLOW.surveyInstanceControl = Ember.ArrayController.create({\n     this.set('content', FLOW.store.findQuery(FLOW.SurveyInstance, {}));\n   },\n \n-  doInstanceQuery: function (surveyId, deviceId, since, beginDate, endDate, submitterName, countryCode, level1, level2) {\n+  doInstanceQuery: function (surveyInstanceId, surveyId, deviceId, since, beginDate, endDate, submitterName, countryCode, level1, level2) {\n     this.set('content', FLOW.store.findQuery(FLOW.SurveyInstance, {\n+\t\t\t'surveyInstanceId': surveyInstanceId,","path":"Dashboard/app/js/lib/controllers/data-controllers.js","position":7,"original_position":7,"commit_id":"0ce9f8cef1959db1d4830ce88602d46e43da8501","original_commit_id":"0ce9f8cef1959db1d4830ce88602d46e43da8501","user":{"login":"muloem","id":533336,"avatar_url":"https://avatars.githubusercontent.com/u/533336?v=3","gravatar_id":"","url":"https://api.github.com/users/muloem","html_url":"https://github.com/muloem","followers_url":"https://api.github.com/users/muloem/followers","following_url":"https://api.github.com/users/muloem/following{/other_user}","gists_url":"https://api.github.com/users/muloem/gists{/gist_id}","starred_url":"https://api.github.com/users/muloem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muloem/subscriptions","organizations_url":"https://api.github.com/users/muloem/orgs","repos_url":"https://api.github.com/users/muloem/repos","events_url":"https://api.github.com/users/muloem/events{/privacy}","received_events_url":"https://api.github.com/users/muloem/received_events","type":"User","site_admin":false},"body":"Would it perhaps make sense to use the direct query instead here? `FLOW.store.find()`?","created_at":"2015-07-17T07:32:18Z","updated_at":"2015-07-17T07:32:18Z","html_url":"https://github.com/akvo/akvo-flow/pull/1336#discussion_r34867853","pull_request_url":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336","_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/comments/34867853"},"html":{"href":"https://github.com/akvo/akvo-flow/pull/1336#discussion_r34867853"},"pull_request":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336"}}},"pull_request":{"url":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336","id":40010725,"html_url":"https://github.com/akvo/akvo-flow/pull/1336","diff_url":"https://github.com/akvo/akvo-flow/pull/1336.diff","patch_url":"https://github.com/akvo/akvo-flow/pull/1336.patch","issue_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1336","number":1336,"state":"open","locked":false,"title":"Issue/872 instance id filter","user":{"login":"jonase","id":101023,"avatar_url":"https://avatars.githubusercontent.com/u/101023?v=3","gravatar_id":"","url":"https://api.github.com/users/jonase","html_url":"https://github.com/jonase","followers_url":"https://api.github.com/users/jonase/followers","following_url":"https://api.github.com/users/jonase/following{/other_user}","gists_url":"https://api.github.com/users/jonase/gists{/gist_id}","starred_url":"https://api.github.com/users/jonase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonase/subscriptions","organizations_url":"https://api.github.com/users/jonase/orgs","repos_url":"https://api.github.com/users/jonase/repos","events_url":"https://api.github.com/users/jonase/events{/privacy}","received_events_url":"https://api.github.com/users/jonase/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-15T11:01:17Z","updated_at":"2015-07-17T07:32:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7724998f9461c6c915c952b8f1d98145d571342","assignee":{"login":"muloem","id":533336,"avatar_url":"https://avatars.githubusercontent.com/u/533336?v=3","gravatar_id":"","url":"https://api.github.com/users/muloem","html_url":"https://github.com/muloem","followers_url":"https://api.github.com/users/muloem/followers","following_url":"https://api.github.com/users/muloem/following{/other_user}","gists_url":"https://api.github.com/users/muloem/gists{/gist_id}","starred_url":"https://api.github.com/users/muloem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muloem/subscriptions","organizations_url":"https://api.github.com/users/muloem/orgs","repos_url":"https://api.github.com/users/muloem/repos","events_url":"https://api.github.com/users/muloem/events{/privacy}","received_events_url":"https://api.github.com/users/muloem/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336/commits","review_comments_url":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336/comments","review_comment_url":"https://api.github.com/repos/akvo/akvo-flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akvo/akvo-flow/issues/1336/comments","statuses_url":"https://api.github.com/repos/akvo/akvo-flow/statuses/0ce9f8cef1959db1d4830ce88602d46e43da8501","head":{"label":"akvo:issue/872-instance-id-filter","ref":"issue/872-instance-id-filter","sha":"0ce9f8cef1959db1d4830ce88602d46e43da8501","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":3843585,"name":"akvo-flow","full_name":"akvo/akvo-flow","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-flow","description":"Akvo FLOW","fork":false,"url":"https://api.github.com/repos/akvo/akvo-flow","forks_url":"https://api.github.com/repos/akvo/akvo-flow/forks","keys_url":"https://api.github.com/repos/akvo/akvo-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-flow/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-flow/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-flow/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-flow/events","assignees_url":"https://api.github.com/repos/akvo/akvo-flow/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-flow/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-flow/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-flow/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-flow/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-flow/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-flow/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-flow/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-flow/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-flow/merges","archive_url":"https://api.github.com/repos/akvo/akvo-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-flow/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-flow/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-flow/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-flow/releases{/id}","created_at":"2012-03-27T12:45:18Z","updated_at":"2015-06-23T10:55:04Z","pushed_at":"2015-07-16T15:50:17Z","git_url":"git://github.com/akvo/akvo-flow.git","ssh_url":"git@github.com:akvo/akvo-flow.git","clone_url":"https://github.com/akvo/akvo-flow.git","svn_url":"https://github.com/akvo/akvo-flow","homepage":"","size":164262,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":235,"forks":14,"open_issues":235,"watchers":30,"default_branch":"develop"}},"base":{"label":"akvo:develop","ref":"develop","sha":"389a3c6eab05d7abc458930c7e32e9167767176d","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":3843585,"name":"akvo-flow","full_name":"akvo/akvo-flow","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-flow","description":"Akvo FLOW","fork":false,"url":"https://api.github.com/repos/akvo/akvo-flow","forks_url":"https://api.github.com/repos/akvo/akvo-flow/forks","keys_url":"https://api.github.com/repos/akvo/akvo-flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-flow/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-flow/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-flow/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-flow/events","assignees_url":"https://api.github.com/repos/akvo/akvo-flow/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-flow/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-flow/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-flow/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-flow/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-flow/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-flow/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-flow/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-flow/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-flow/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-flow/merges","archive_url":"https://api.github.com/repos/akvo/akvo-flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-flow/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-flow/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-flow/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-flow/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-flow/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-flow/releases{/id}","created_at":"2012-03-27T12:45:18Z","updated_at":"2015-06-23T10:55:04Z","pushed_at":"2015-07-16T15:50:17Z","git_url":"git://github.com/akvo/akvo-flow.git","ssh_url":"git@github.com:akvo/akvo-flow.git","clone_url":"https://github.com/akvo/akvo-flow.git","svn_url":"https://github.com/akvo/akvo-flow","homepage":"","size":164262,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":235,"forks":14,"open_issues":235,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336"},"html":{"href":"https://github.com/akvo/akvo-flow/pull/1336"},"issue":{"href":"https://api.github.com/repos/akvo/akvo-flow/issues/1336"},"comments":{"href":"https://api.github.com/repos/akvo/akvo-flow/issues/1336/comments"},"review_comments":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336/comments"},"review_comment":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akvo/akvo-flow/pulls/1336/commits"},"statuses":{"href":"https://api.github.com/repos/akvo/akvo-flow/statuses/0ce9f8cef1959db1d4830ce88602d46e43da8501"}}}}