{"action":"closed","number":270,"pull_request":{"url":"https://api.github.com/repos/techfort/LokiJS/pulls/270","id":50019761,"html_url":"https://github.com/techfort/LokiJS/pull/270","diff_url":"https://github.com/techfort/LokiJS/pull/270.diff","patch_url":"https://github.com/techfort/LokiJS/pull/270.patch","issue_url":"https://api.github.com/repos/techfort/LokiJS/issues/270","number":270,"state":"closed","locked":false,"title":"Added verbose option to enable/disable logging","user":{"login":"Cortys","id":1737630,"avatar_url":"https://avatars.githubusercontent.com/u/1737630?v=3","gravatar_id":"","url":"https://api.github.com/users/Cortys","html_url":"https://github.com/Cortys","followers_url":"https://api.github.com/users/Cortys/followers","following_url":"https://api.github.com/users/Cortys/following{/other_user}","gists_url":"https://api.github.com/users/Cortys/gists{/gist_id}","starred_url":"https://api.github.com/users/Cortys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cortys/subscriptions","organizations_url":"https://api.github.com/users/Cortys/orgs","repos_url":"https://api.github.com/users/Cortys/repos","events_url":"https://api.github.com/users/Cortys/events{/privacy}","received_events_url":"https://api.github.com/users/Cortys/received_events","type":"User","site_admin":false},"body":"Fixes #269\r\n\r\nThis adds a `verbose` option the the Loki constructor.\r\n\r\nLoki instances and its Collections will only log errors and warnings to console if the verbose flag is set. It is disabled by default.\r\n\r\nApart from that I also changed the IndexedDB adapter to throw instead of log if IndexedDB is not supported. I think this behavior is more reasonable and also makes the adapter completely non-logging. Thus the verbose option of a Loki instance does not have to be propagated to control logging in there.\r\n\r\nI left all „fallback“ logs (if no callback is provided) where they are so that using Loki in a REPL is still possible. Since Loki itself always provides a callback to all internal calls those logs should normally never appear.\r\n\r\nApart from that the only logs that are left can be found in the `loki-angular.js` module. I’m not sure how to handle those since they are not directly related to a single Loki instance and thus not related to any specific verbose flag value.","created_at":"2015-11-07T00:00:39Z","updated_at":"2015-11-07T01:55:30Z","closed_at":"2015-11-07T01:55:30Z","merged_at":"2015-11-07T01:55:30Z","merge_commit_sha":"ed424e7d91a225254b25e641929b9fdd1768dd38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/techfort/LokiJS/pulls/270/commits","review_comments_url":"https://api.github.com/repos/techfort/LokiJS/pulls/270/comments","review_comment_url":"https://api.github.com/repos/techfort/LokiJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/techfort/LokiJS/issues/270/comments","statuses_url":"https://api.github.com/repos/techfort/LokiJS/statuses/6c61c37df0c4451c4df08f3a8f5df68c1e27e80c","head":{"label":"runnr:master","ref":"master","sha":"6c61c37df0c4451c4df08f3a8f5df68c1e27e80c","user":{"login":"runnr","id":11589061,"avatar_url":"https://avatars.githubusercontent.com/u/11589061?v=3","gravatar_id":"","url":"https://api.github.com/users/runnr","html_url":"https://github.com/runnr","followers_url":"https://api.github.com/users/runnr/followers","following_url":"https://api.github.com/users/runnr/following{/other_user}","gists_url":"https://api.github.com/users/runnr/gists{/gist_id}","starred_url":"https://api.github.com/users/runnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runnr/subscriptions","organizations_url":"https://api.github.com/users/runnr/orgs","repos_url":"https://api.github.com/users/runnr/repos","events_url":"https://api.github.com/users/runnr/events{/privacy}","received_events_url":"https://api.github.com/users/runnr/received_events","type":"Organization","site_admin":false},"repo":{"id":42748541,"name":"LokiJS","full_name":"runnr/LokiJS","owner":{"login":"runnr","id":11589061,"avatar_url":"https://avatars.githubusercontent.com/u/11589061?v=3","gravatar_id":"","url":"https://api.github.com/users/runnr","html_url":"https://github.com/runnr","followers_url":"https://api.github.com/users/runnr/followers","following_url":"https://api.github.com/users/runnr/following{/other_user}","gists_url":"https://api.github.com/users/runnr/gists{/gist_id}","starred_url":"https://api.github.com/users/runnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runnr/subscriptions","organizations_url":"https://api.github.com/users/runnr/orgs","repos_url":"https://api.github.com/users/runnr/repos","events_url":"https://api.github.com/users/runnr/events{/privacy}","received_events_url":"https://api.github.com/users/runnr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runnr/LokiJS","description":"javascript embeddable / in-memory database","fork":true,"url":"https://api.github.com/repos/runnr/LokiJS","forks_url":"https://api.github.com/repos/runnr/LokiJS/forks","keys_url":"https://api.github.com/repos/runnr/LokiJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runnr/LokiJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runnr/LokiJS/teams","hooks_url":"https://api.github.com/repos/runnr/LokiJS/hooks","issue_events_url":"https://api.github.com/repos/runnr/LokiJS/issues/events{/number}","events_url":"https://api.github.com/repos/runnr/LokiJS/events","assignees_url":"https://api.github.com/repos/runnr/LokiJS/assignees{/user}","branches_url":"https://api.github.com/repos/runnr/LokiJS/branches{/branch}","tags_url":"https://api.github.com/repos/runnr/LokiJS/tags","blobs_url":"https://api.github.com/repos/runnr/LokiJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runnr/LokiJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runnr/LokiJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/runnr/LokiJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runnr/LokiJS/statuses/{sha}","languages_url":"https://api.github.com/repos/runnr/LokiJS/languages","stargazers_url":"https://api.github.com/repos/runnr/LokiJS/stargazers","contributors_url":"https://api.github.com/repos/runnr/LokiJS/contributors","subscribers_url":"https://api.github.com/repos/runnr/LokiJS/subscribers","subscription_url":"https://api.github.com/repos/runnr/LokiJS/subscription","commits_url":"https://api.github.com/repos/runnr/LokiJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/runnr/LokiJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/runnr/LokiJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/runnr/LokiJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/runnr/LokiJS/contents/{+path}","compare_url":"https://api.github.com/repos/runnr/LokiJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runnr/LokiJS/merges","archive_url":"https://api.github.com/repos/runnr/LokiJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runnr/LokiJS/downloads","issues_url":"https://api.github.com/repos/runnr/LokiJS/issues{/number}","pulls_url":"https://api.github.com/repos/runnr/LokiJS/pulls{/number}","milestones_url":"https://api.github.com/repos/runnr/LokiJS/milestones{/number}","notifications_url":"https://api.github.com/repos/runnr/LokiJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runnr/LokiJS/labels{/name}","releases_url":"https://api.github.com/repos/runnr/LokiJS/releases{/id}","created_at":"2015-09-18T21:46:58Z","updated_at":"2015-09-18T21:46:58Z","pushed_at":"2015-11-06T23:34:35Z","git_url":"git://github.com/runnr/LokiJS.git","ssh_url":"git@github.com:runnr/LokiJS.git","clone_url":"https://github.com/runnr/LokiJS.git","svn_url":"https://github.com/runnr/LokiJS","homepage":"http://lokijs.org","size":6020,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"techfort:master","ref":"master","sha":"1d57f1fd30b1b92c6eb74a35f0301c3806b23de4","user":{"login":"techfort","id":4130173,"avatar_url":"https://avatars.githubusercontent.com/u/4130173?v=3","gravatar_id":"","url":"https://api.github.com/users/techfort","html_url":"https://github.com/techfort","followers_url":"https://api.github.com/users/techfort/followers","following_url":"https://api.github.com/users/techfort/following{/other_user}","gists_url":"https://api.github.com/users/techfort/gists{/gist_id}","starred_url":"https://api.github.com/users/techfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techfort/subscriptions","organizations_url":"https://api.github.com/users/techfort/orgs","repos_url":"https://api.github.com/users/techfort/repos","events_url":"https://api.github.com/users/techfort/events{/privacy}","received_events_url":"https://api.github.com/users/techfort/received_events","type":"User","site_admin":false},"repo":{"id":11654790,"name":"LokiJS","full_name":"techfort/LokiJS","owner":{"login":"techfort","id":4130173,"avatar_url":"https://avatars.githubusercontent.com/u/4130173?v=3","gravatar_id":"","url":"https://api.github.com/users/techfort","html_url":"https://github.com/techfort","followers_url":"https://api.github.com/users/techfort/followers","following_url":"https://api.github.com/users/techfort/following{/other_user}","gists_url":"https://api.github.com/users/techfort/gists{/gist_id}","starred_url":"https://api.github.com/users/techfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techfort/subscriptions","organizations_url":"https://api.github.com/users/techfort/orgs","repos_url":"https://api.github.com/users/techfort/repos","events_url":"https://api.github.com/users/techfort/events{/privacy}","received_events_url":"https://api.github.com/users/techfort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/techfort/LokiJS","description":"javascript embeddable / in-memory database","fork":false,"url":"https://api.github.com/repos/techfort/LokiJS","forks_url":"https://api.github.com/repos/techfort/LokiJS/forks","keys_url":"https://api.github.com/repos/techfort/LokiJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/techfort/LokiJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/techfort/LokiJS/teams","hooks_url":"https://api.github.com/repos/techfort/LokiJS/hooks","issue_events_url":"https://api.github.com/repos/techfort/LokiJS/issues/events{/number}","events_url":"https://api.github.com/repos/techfort/LokiJS/events","assignees_url":"https://api.github.com/repos/techfort/LokiJS/assignees{/user}","branches_url":"https://api.github.com/repos/techfort/LokiJS/branches{/branch}","tags_url":"https://api.github.com/repos/techfort/LokiJS/tags","blobs_url":"https://api.github.com/repos/techfort/LokiJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/techfort/LokiJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/techfort/LokiJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/techfort/LokiJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/techfort/LokiJS/statuses/{sha}","languages_url":"https://api.github.com/repos/techfort/LokiJS/languages","stargazers_url":"https://api.github.com/repos/techfort/LokiJS/stargazers","contributors_url":"https://api.github.com/repos/techfort/LokiJS/contributors","subscribers_url":"https://api.github.com/repos/techfort/LokiJS/subscribers","subscription_url":"https://api.github.com/repos/techfort/LokiJS/subscription","commits_url":"https://api.github.com/repos/techfort/LokiJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/techfort/LokiJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/techfort/LokiJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/techfort/LokiJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/techfort/LokiJS/contents/{+path}","compare_url":"https://api.github.com/repos/techfort/LokiJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/techfort/LokiJS/merges","archive_url":"https://api.github.com/repos/techfort/LokiJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/techfort/LokiJS/downloads","issues_url":"https://api.github.com/repos/techfort/LokiJS/issues{/number}","pulls_url":"https://api.github.com/repos/techfort/LokiJS/pulls{/number}","milestones_url":"https://api.github.com/repos/techfort/LokiJS/milestones{/number}","notifications_url":"https://api.github.com/repos/techfort/LokiJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/techfort/LokiJS/labels{/name}","releases_url":"https://api.github.com/repos/techfort/LokiJS/releases{/id}","created_at":"2013-07-25T07:39:20Z","updated_at":"2015-11-06T18:26:45Z","pushed_at":"2015-11-07T01:55:30Z","git_url":"git://github.com/techfort/LokiJS.git","ssh_url":"git@github.com:techfort/LokiJS.git","clone_url":"https://github.com/techfort/LokiJS.git","svn_url":"https://github.com/techfort/LokiJS","homepage":"http://lokijs.org","size":8226,"stargazers_count":1598,"watchers_count":1598,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":36,"forks":152,"open_issues":36,"watchers":1598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/270"},"html":{"href":"https://github.com/techfort/LokiJS/pull/270"},"issue":{"href":"https://api.github.com/repos/techfort/LokiJS/issues/270"},"comments":{"href":"https://api.github.com/repos/techfort/LokiJS/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/techfort/LokiJS/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/techfort/LokiJS/statuses/6c61c37df0c4451c4df08f3a8f5df68c1e27e80c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obeliskos","id":7353046,"avatar_url":"https://avatars.githubusercontent.com/u/7353046?v=3","gravatar_id":"","url":"https://api.github.com/users/obeliskos","html_url":"https://github.com/obeliskos","followers_url":"https://api.github.com/users/obeliskos/followers","following_url":"https://api.github.com/users/obeliskos/following{/other_user}","gists_url":"https://api.github.com/users/obeliskos/gists{/gist_id}","starred_url":"https://api.github.com/users/obeliskos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obeliskos/subscriptions","organizations_url":"https://api.github.com/users/obeliskos/orgs","repos_url":"https://api.github.com/users/obeliskos/repos","events_url":"https://api.github.com/users/obeliskos/events{/privacy}","received_events_url":"https://api.github.com/users/obeliskos/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":5,"additions":71,"deletions":57,"changed_files":2}}