{"action":"created","issue":{"url":"https://api.github.com/repos/mitsuhiko/flask/issues/1291","labels_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1291/labels{/name}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1291/comments","events_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1291/events","html_url":"https://github.com/mitsuhiko/flask/pull/1291","id":52762702,"number":1291,"title":"Fixed and intuitivized exception handling","user":{"login":"flying-sheep","id":291575,"avatar_url":"https://avatars.githubusercontent.com/u/291575?v=3","gravatar_id":"","url":"https://api.github.com/users/flying-sheep","html_url":"https://github.com/flying-sheep","followers_url":"https://api.github.com/users/flying-sheep/followers","following_url":"https://api.github.com/users/flying-sheep/following{/other_user}","gists_url":"https://api.github.com/users/flying-sheep/gists{/gist_id}","starred_url":"https://api.github.com/users/flying-sheep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flying-sheep/subscriptions","organizations_url":"https://api.github.com/users/flying-sheep/orgs","repos_url":"https://api.github.com/users/flying-sheep/repos","events_url":"https://api.github.com/users/flying-sheep/events{/privacy}","received_events_url":"https://api.github.com/users/flying-sheep/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mitsuhiko/flask/labels/needs%20review","name":"needs review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mitsuhiko/flask/milestones/2","html_url":"https://github.com/mitsuhiko/flask/milestones/1.0","labels_url":"https://api.github.com/repos/mitsuhiko/flask/milestones/2/labels","id":795954,"number":2,"title":"1.0","description":"","creator":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2014-09-19T15:47:20Z","updated_at":"2015-04-11T11:29:39Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2014-12-23T18:18:53Z","updated_at":"2015-04-11T13:07:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1291","html_url":"https://github.com/mitsuhiko/flask/pull/1291","diff_url":"https://github.com/mitsuhiko/flask/pull/1291.diff","patch_url":"https://github.com/mitsuhiko/flask/pull/1291.patch"},"body":"abandoning pull request #1281 for this.\r\n\r\nthe rationale for this is to\r\n\r\n1. fix some logic flaws\r\n2. make errorhandlers more intuitive by making them rely on exception hierarchy instead of registration order\r\n3. Enable 500 handlers on blueprint level\r\n\r\nand all this while without breaking compatibility in not-already-broken usecases (which rely on the logic flaws i fixed)\r\n\r\nTODO:\r\n\r\n1. bake this into some tests as well\r\n2. one error says\r\n\r\n    > It is currently not possible to register a 500 internal server error on a per-blueprint level.\r\n\r\n    why is this?"},"comment":{"url":"https://api.github.com/repos/mitsuhiko/flask/issues/comments/91842383","html_url":"https://github.com/mitsuhiko/flask/pull/1291#issuecomment-91842383","issue_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1291","id":91842383,"user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T13:07:24Z","updated_at":"2015-04-11T13:07:24Z","body":"OK, so the current PR is excellent as-is.\r\n\r\nThe only thing missing now are docs. From a quick glance at `errorhandling.rst` there doesn't seem to be anything contradictory in there, but we should definetly clarify the current behavior.\r\n\r\nWe also need something in `upgrading.rst`, and a changelog entry."}}