{"action":"closed","number":1251,"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1251","id":26983728,"html_url":"https://github.com/sunpy/sunpy/pull/1251","diff_url":"https://github.com/sunpy/sunpy/pull/1251.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1251.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1251","number":1251,"state":"closed","locked":false,"title":"Silence warnings for any fixable FITS violations","user":{"login":"ayshih","id":991759,"avatar_url":"https://avatars.githubusercontent.com/u/991759?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshih","html_url":"https://github.com/ayshih","followers_url":"https://api.github.com/users/ayshih/followers","following_url":"https://api.github.com/users/ayshih/following{/other_user}","gists_url":"https://api.github.com/users/ayshih/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshih/subscriptions","organizations_url":"https://api.github.com/users/ayshih/orgs","repos_url":"https://api.github.com/users/ayshih/repos","events_url":"https://api.github.com/users/ayshih/events{/privacy}","received_events_url":"https://api.github.com/users/ayshih/received_events","type":"User","site_admin":false},"body":"Because `fix` is used instead of `silentfix` when verifying a FITS file, all of the fixable FITS violations in a typical solar FITS file produce a whole bunch of warnings, even though these \"violations\" are not relevant (e.g., tags that we don't use are not present).  This behavior can give users the impression that that something is fundamentally broken.  This proposed change silences those warnings for fixable violations, while unfixable violations will still produce warnings.\r\n\r\nNote that `get_header()` already uses `silentfix`.","created_at":"2015-01-07T20:07:22Z","updated_at":"2015-01-07T20:25:23Z","closed_at":"2015-01-07T20:25:23Z","merged_at":"2015-01-07T20:25:23Z","merge_commit_sha":"3fefaeec5fa1f3fff8dbfedaa08504811ad2465b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1251/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/49e0b6af8b8164c332e47bcbd98ed5a9d2b137bd","head":{"label":"ayshih:verify","ref":"verify","sha":"49e0b6af8b8164c332e47bcbd98ed5a9d2b137bd","user":{"login":"ayshih","id":991759,"avatar_url":"https://avatars.githubusercontent.com/u/991759?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshih","html_url":"https://github.com/ayshih","followers_url":"https://api.github.com/users/ayshih/followers","following_url":"https://api.github.com/users/ayshih/following{/other_user}","gists_url":"https://api.github.com/users/ayshih/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshih/subscriptions","organizations_url":"https://api.github.com/users/ayshih/orgs","repos_url":"https://api.github.com/users/ayshih/repos","events_url":"https://api.github.com/users/ayshih/events{/privacy}","received_events_url":"https://api.github.com/users/ayshih/received_events","type":"User","site_admin":false},"repo":{"id":2332127,"name":"sunpy","full_name":"ayshih/sunpy","owner":{"login":"ayshih","id":991759,"avatar_url":"https://avatars.githubusercontent.com/u/991759?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshih","html_url":"https://github.com/ayshih","followers_url":"https://api.github.com/users/ayshih/followers","following_url":"https://api.github.com/users/ayshih/following{/other_user}","gists_url":"https://api.github.com/users/ayshih/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshih/subscriptions","organizations_url":"https://api.github.com/users/ayshih/orgs","repos_url":"https://api.github.com/users/ayshih/repos","events_url":"https://api.github.com/users/ayshih/events{/privacy}","received_events_url":"https://api.github.com/users/ayshih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayshih/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/ayshih/sunpy","forks_url":"https://api.github.com/repos/ayshih/sunpy/forks","keys_url":"https://api.github.com/repos/ayshih/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayshih/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayshih/sunpy/teams","hooks_url":"https://api.github.com/repos/ayshih/sunpy/hooks","issue_events_url":"https://api.github.com/repos/ayshih/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/ayshih/sunpy/events","assignees_url":"https://api.github.com/repos/ayshih/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/ayshih/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/ayshih/sunpy/tags","blobs_url":"https://api.github.com/repos/ayshih/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayshih/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayshih/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayshih/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayshih/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/ayshih/sunpy/languages","stargazers_url":"https://api.github.com/repos/ayshih/sunpy/stargazers","contributors_url":"https://api.github.com/repos/ayshih/sunpy/contributors","subscribers_url":"https://api.github.com/repos/ayshih/sunpy/subscribers","subscription_url":"https://api.github.com/repos/ayshih/sunpy/subscription","commits_url":"https://api.github.com/repos/ayshih/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayshih/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayshih/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayshih/sunpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/ayshih/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/ayshih/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayshih/sunpy/merges","archive_url":"https://api.github.com/repos/ayshih/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayshih/sunpy/downloads","issues_url":"https://api.github.com/repos/ayshih/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/ayshih/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/ayshih/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/ayshih/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayshih/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/ayshih/sunpy/releases{/id}","created_at":"2011-09-06T02:52:50Z","updated_at":"2015-01-06T14:51:48Z","pushed_at":"2015-01-07T19:57:17Z","git_url":"git://github.com/ayshih/sunpy.git","ssh_url":"git@github.com:ayshih/sunpy.git","clone_url":"https://github.com/ayshih/sunpy.git","svn_url":"https://github.com/ayshih/sunpy","homepage":"http://www.sunpy.org","size":30627,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"d78cd4b8a370cf101bd99bcc645e5d0caec143b2","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for solar physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","created_at":"2011-08-06T15:34:08Z","updated_at":"2015-01-05T18:24:50Z","pushed_at":"2015-01-07T20:25:24Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":141568,"stargazers_count":150,"watchers_count":150,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":174,"forks":105,"open_issues":174,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1251"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1251"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1251"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/49e0b6af8b8164c332e47bcbd98ed5a9d2b137bd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}