{"push_id":828785667,"size":1,"distinct_size":1,"ref":"refs/heads/efischer/temp","head":"9ab4c67a327ba8e23b9085e13fc8105b9024e585","before":"231bcc523dbfed1320bac417b70ed5e6e6c50323","commits":[{"sha":"9ab4c67a327ba8e23b9085e13fc8105b9024e585","author":{"email":"e84cce00b45172cb54f7ee32f14917caf5929de3@edx.org","name":"Eric Fischer"},"message":"Teams Tests event filtering\n\nAttempting to narrow the filter used for events emitted during tests\nrun as part of the teams feature. This is not fully functional as of\nthe end of Hackathon October 2015.\n\nNotes for future development:\n\n* Originally, the filter being used was too broad, and running tests simultaneously led to wires getting crossed and tests failing when they got events from other, unrelated tests.\n* The fix for this was to make the filter more specific. Commit https://github.com/edx/edx-platform/commit/a7b294f514a5a955c1288a4bf7b40caa25f1e143 did this for test_teams.py, by making the filter be the exact event we're trying to match.\n  *  This allowed @benpatterson's earlier fix (not resetting the events database between tests) to persist, and seemed to work in most cases.\n* The latest problem, unearthed just before the end of the hackathon, is the realization that the filtering logic does *not* allow for lenient matching, whereas the matching logic *does*\n  * Compare https://github.com/edx/edx-platform/blob/master/common/test/acceptance/tests/helpers.py#L438 (filter codepath) to https://github.com/edx/edx-platform/blob/master/common/test/acceptance/tests/helpers.py#L510 (matching codepath)\n  * example, note that using the entire event *would* match, if it could get through the filter, but it doesn't exactly match so it gets stopped by the filter instead:\n```\nBrokenPromise: Promise not satisfied: Waiting for 1 events to match the filter:\n--------------------\n{'event': {'remove_method': 'self_removal'},\n'event_type': 'edx.team.learner_removed'}\n--------------------\n\nEvents:\n{<truncated, there's a lot more stuff here>\nu'event': {u'remove_method': u'self_removal',\nu'team_id': u'team-0-23b4755824284dd581dc057b28512ec4',\nu'user_id': 123L},\nu'event_type': u'edx.team.learner_removed',\n<truncated, there's more stuff here>}\n```\n\nNote written during hackathon presentation setup:\nI've modified the default behavior of fintering to be more lenient, that may solve our problems.\n*crosses fingers and hopes for tests to pass*","distinct":true,"url":"https://api.github.com/repos/edx/edx-platform/commits/9ab4c67a327ba8e23b9085e13fc8105b9024e585"}]}