{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/38970634","id":38970634,"diff_hunk":"@@ -56,7 +56,7 @@\n       expect(page).to have_text('Successful creation.')\n       expect(page).to have_text(file_name)\n \n-      click_link file_name\n+      find('.work-package--attachments--files', text: file_name).click","path":"spec/features/attachments/attachments_spec.rb","position":5,"original_position":5,"commit_id":"6e0366ddb4fefb6694f5b5507b5bd495f40729ea","original_commit_id":"6e0366ddb4fefb6694f5b5507b5bd495f40729ea","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-09-08T19:46:05Z","updated_at":"2015-09-08T19:46:05Z","html_url":"https://github.com/opf/openproject/pull/3366#discussion_r38970634","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3366","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/38970634"},"html":{"href":"https://github.com/opf/openproject/pull/3366#discussion_r38970634"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3366","id":42540230,"html_url":"https://github.com/opf/openproject/pull/3366","diff_url":"https://github.com/opf/openproject/pull/3366.diff","patch_url":"https://github.com/opf/openproject/pull/3366.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3366","number":3366,"state":"open","locked":false,"title":"[16364] Switch WorkPackage show view over to AngularJS (aka fullscreen view)","user":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"body":"https://community.openproject.org/work_packages/16364\r\n\r\n- [ ] fix specs\r\n- [ ] clean up directives/code duplication\r\n\r\n#### Review Feedback \r\n\r\nFeedback von @lindenthal und @basiszwo\r\n\r\n- [x] Inline editing of WP title missing\r\n- [x] project context is being lost when switching to fullscreen view `/project/seeded_project/work_packages/1` vs `/work_packages/1`\r\n- [x] \"more\" Button with actions in dropdown is missing [1]\r\n- [x] \"Edit\" Button should link to old edit view (same as in split view) [1]\r\n- [x] cog icon on top right does not make sense in fullscreen view as it provides list settings\r\n  * replace with \"more\" Button?\r\n- [x] missing full screen icon (already included in icon set)\r\n- [x] scrollbar should not be visible when there's nothing to scroll (@rebellium)\r\n- [x] Validate/Fix the actions which should still work (e.g. watching a work package); see OpenProject's work package\r\n- [x] Title should be \"Bug #123: WP TITLE\" where \"WP title is editable\" and \"Bug\" is not a link\r\n- [x] carry query path of url to fullscreen view url so we are properly being redirected when switching back to list or split view\r\n- [x] dropdown actions in \"new work package\" button are missing so it is not possible to create work packages from the full screen view. (should redirect to create mode in split view)\r\n\r\n[1] we initially place the buttons in the top right area. Later @rebellium needs to move them to a bottom bar.\r\n\r\n#### Questions\r\n\r\n- [ ] is it possible to provide a full edit view? how much work would this cause? maybe also in split view mode?\r\n- [ ] what happens if someone has no right to view the work package?\r\n\r\n#### Out of scope\r\n\r\nCreate new pull requests for these bugs\r\n\r\n- [x] Confirm when deleting an image (#3437)\r\n- [x] Upload image then try to edit the description => error 'conflicting modifications' (#3436)\r\n\r\n#### Won't apply\r\n\r\n- [x] \"new work package\" Link in sidebar is linked to the old new view. We should relink it to the new create view (see https://github.com/opf/openproject/pull/3366#issuecomment-135332990)","created_at":"2015-08-16T17:54:06Z","updated_at":"2015-09-08T19:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"226225b03efbd4102205c79d0f4d92c10594b304","assignee":null,"milestone":{"url":"https://api.github.com/repos/opf/openproject/milestones/3","html_url":"https://github.com/opf/openproject/milestones/5.0","labels_url":"https://api.github.com/repos/opf/openproject/milestones/3/labels","id":1104474,"number":3,"title":"5.0","description":"","creator":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":60,"state":"open","created_at":"2015-05-11T10:04:28Z","updated_at":"2015-09-08T13:29:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3366/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3366/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3366/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/6e0366ddb4fefb6694f5b5507b5bd495f40729ea","head":{"label":"timhabermaas:16364-fullscreen-work-package-view","ref":"16364-fullscreen-work-package-view","sha":"6e0366ddb4fefb6694f5b5507b5bd495f40729ea","user":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"repo":{"id":40676414,"name":"openproject","full_name":"timhabermaas/openproject","owner":{"login":"timhabermaas","id":96054,"avatar_url":"https://avatars.githubusercontent.com/u/96054?v=3","gravatar_id":"","url":"https://api.github.com/users/timhabermaas","html_url":"https://github.com/timhabermaas","followers_url":"https://api.github.com/users/timhabermaas/followers","following_url":"https://api.github.com/users/timhabermaas/following{/other_user}","gists_url":"https://api.github.com/users/timhabermaas/gists{/gist_id}","starred_url":"https://api.github.com/users/timhabermaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhabermaas/subscriptions","organizations_url":"https://api.github.com/users/timhabermaas/orgs","repos_url":"https://api.github.com/users/timhabermaas/repos","events_url":"https://api.github.com/users/timhabermaas/events{/privacy}","received_events_url":"https://api.github.com/users/timhabermaas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timhabermaas/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/timhabermaas/openproject","forks_url":"https://api.github.com/repos/timhabermaas/openproject/forks","keys_url":"https://api.github.com/repos/timhabermaas/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timhabermaas/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timhabermaas/openproject/teams","hooks_url":"https://api.github.com/repos/timhabermaas/openproject/hooks","issue_events_url":"https://api.github.com/repos/timhabermaas/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/timhabermaas/openproject/events","assignees_url":"https://api.github.com/repos/timhabermaas/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/timhabermaas/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/timhabermaas/openproject/tags","blobs_url":"https://api.github.com/repos/timhabermaas/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timhabermaas/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timhabermaas/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/timhabermaas/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timhabermaas/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/timhabermaas/openproject/languages","stargazers_url":"https://api.github.com/repos/timhabermaas/openproject/stargazers","contributors_url":"https://api.github.com/repos/timhabermaas/openproject/contributors","subscribers_url":"https://api.github.com/repos/timhabermaas/openproject/subscribers","subscription_url":"https://api.github.com/repos/timhabermaas/openproject/subscription","commits_url":"https://api.github.com/repos/timhabermaas/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/timhabermaas/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/timhabermaas/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/timhabermaas/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/timhabermaas/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/timhabermaas/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timhabermaas/openproject/merges","archive_url":"https://api.github.com/repos/timhabermaas/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timhabermaas/openproject/downloads","issues_url":"https://api.github.com/repos/timhabermaas/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/timhabermaas/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/timhabermaas/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/timhabermaas/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timhabermaas/openproject/labels{/name}","releases_url":"https://api.github.com/repos/timhabermaas/openproject/releases{/id}","created_at":"2015-08-13T18:57:09Z","updated_at":"2015-08-13T18:57:19Z","pushed_at":"2015-09-08T19:45:42Z","git_url":"git://github.com/timhabermaas/openproject.git","ssh_url":"git@github.com:timhabermaas/openproject.git","clone_url":"https://github.com/timhabermaas/openproject.git","svn_url":"https://github.com/timhabermaas/openproject","homepage":"https://www.openproject.org","size":68822,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"99a3635cd81d4284112ec4bb93875ef784b5aacf","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-09-08T19:21:21Z","pushed_at":"2015-09-08T19:45:44Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":212616,"stargazers_count":734,"watchers_count":734,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":24,"forks":300,"open_issues":24,"watchers":734,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366"},"html":{"href":"https://github.com/opf/openproject/pull/3366"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3366"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3366/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3366/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/6e0366ddb4fefb6694f5b5507b5bd495f40729ea"}}}}