{"action":"closed","number":1933,"pull_request":{"url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933","id":27052723,"html_url":"https://github.com/KoffeinFlummi/AGM/pull/1933","diff_url":"https://github.com/KoffeinFlummi/AGM/pull/1933.diff","patch_url":"https://github.com/KoffeinFlummi/AGM/pull/1933.patch","issue_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/1933","number":1933,"state":"closed","locked":false,"title":"AGM_Parameters rewrite","user":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"body":"On the old implementation there was no way of knowing what variable type should be used for a parameter, so they all were treated like numbers, which lead to things like: \r\n\r\n`if (AGM_Explosives_RequireSpecialist > 0) then ...`\r\n\r\nNow the class `AGM_Parameters` is replaced by `AGM_Parameters_Numeric` and `AGM_Parameters_Boolean`, so every parameter has a clearly identified type.\r\n\r\nBooleans params are now loaded into proper boolean variables, so the above becomes:\r\n\r\n`if (AGM_Explosives_RequireSpecialist) then ...`\r\n\r\nThe system is meant to be backward compatible, so `AGM_Parameters` entries are still supported. The nice thing is there's a hack that automatically converts description.ext entries if they are on the legacy format.","created_at":"2015-01-08T19:26:51Z","updated_at":"2015-01-09T01:43:12Z","closed_at":"2015-01-09T01:43:12Z","merged_at":"2015-01-09T01:43:12Z","merge_commit_sha":"88f829ab5ef40665432790a7fd7de9df1d89fe73","assignee":null,"milestone":{"url":"https://api.github.com/repos/KoffeinFlummi/AGM/milestones/12","labels_url":"https://api.github.com/repos/KoffeinFlummi/AGM/milestones/12/labels","id":915094,"number":12,"title":"Version 0.95.1","description":"","creator":{"login":"commy2","id":6576312,"avatar_url":"https://avatars.githubusercontent.com/u/6576312?v=3","gravatar_id":"","url":"https://api.github.com/users/commy2","html_url":"https://github.com/commy2","followers_url":"https://api.github.com/users/commy2/followers","following_url":"https://api.github.com/users/commy2/following{/other_user}","gists_url":"https://api.github.com/users/commy2/gists{/gist_id}","starred_url":"https://api.github.com/users/commy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commy2/subscriptions","organizations_url":"https://api.github.com/users/commy2/orgs","repos_url":"https://api.github.com/users/commy2/repos","events_url":"https://api.github.com/users/commy2/events{/privacy}","received_events_url":"https://api.github.com/users/commy2/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":37,"state":"open","created_at":"2014-12-26T10:24:22Z","updated_at":"2015-01-09T01:43:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933/commits","review_comments_url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933/comments","review_comment_url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/1933/comments","statuses_url":"https://api.github.com/repos/KoffeinFlummi/AGM/statuses/b404b1b589df35eb999a7731d437866e2a359df0","head":{"label":"KoffeinFlummi:agmParametersRewrite","ref":"agmParametersRewrite","sha":"b404b1b589df35eb999a7731d437866e2a359df0","user":{"login":"KoffeinFlummi","id":2438809,"avatar_url":"https://avatars.githubusercontent.com/u/2438809?v=3","gravatar_id":"","url":"https://api.github.com/users/KoffeinFlummi","html_url":"https://github.com/KoffeinFlummi","followers_url":"https://api.github.com/users/KoffeinFlummi/followers","following_url":"https://api.github.com/users/KoffeinFlummi/following{/other_user}","gists_url":"https://api.github.com/users/KoffeinFlummi/gists{/gist_id}","starred_url":"https://api.github.com/users/KoffeinFlummi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoffeinFlummi/subscriptions","organizations_url":"https://api.github.com/users/KoffeinFlummi/orgs","repos_url":"https://api.github.com/users/KoffeinFlummi/repos","events_url":"https://api.github.com/users/KoffeinFlummi/events{/privacy}","received_events_url":"https://api.github.com/users/KoffeinFlummi/received_events","type":"User","site_admin":false},"repo":{"id":16466069,"name":"AGM","full_name":"KoffeinFlummi/AGM","owner":{"login":"KoffeinFlummi","id":2438809,"avatar_url":"https://avatars.githubusercontent.com/u/2438809?v=3","gravatar_id":"","url":"https://api.github.com/users/KoffeinFlummi","html_url":"https://github.com/KoffeinFlummi","followers_url":"https://api.github.com/users/KoffeinFlummi/followers","following_url":"https://api.github.com/users/KoffeinFlummi/following{/other_user}","gists_url":"https://api.github.com/users/KoffeinFlummi/gists{/gist_id}","starred_url":"https://api.github.com/users/KoffeinFlummi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoffeinFlummi/subscriptions","organizations_url":"https://api.github.com/users/KoffeinFlummi/orgs","repos_url":"https://api.github.com/users/KoffeinFlummi/repos","events_url":"https://api.github.com/users/KoffeinFlummi/events{/privacy}","received_events_url":"https://api.github.com/users/KoffeinFlummi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KoffeinFlummi/AGM","description":"Authentic Gameplay Modification for Arma 3","fork":false,"url":"https://api.github.com/repos/KoffeinFlummi/AGM","forks_url":"https://api.github.com/repos/KoffeinFlummi/AGM/forks","keys_url":"https://api.github.com/repos/KoffeinFlummi/AGM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KoffeinFlummi/AGM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KoffeinFlummi/AGM/teams","hooks_url":"https://api.github.com/repos/KoffeinFlummi/AGM/hooks","issue_events_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/events{/number}","events_url":"https://api.github.com/repos/KoffeinFlummi/AGM/events","assignees_url":"https://api.github.com/repos/KoffeinFlummi/AGM/assignees{/user}","branches_url":"https://api.github.com/repos/KoffeinFlummi/AGM/branches{/branch}","tags_url":"https://api.github.com/repos/KoffeinFlummi/AGM/tags","blobs_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/refs{/sha}","trees_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KoffeinFlummi/AGM/statuses/{sha}","languages_url":"https://api.github.com/repos/KoffeinFlummi/AGM/languages","stargazers_url":"https://api.github.com/repos/KoffeinFlummi/AGM/stargazers","contributors_url":"https://api.github.com/repos/KoffeinFlummi/AGM/contributors","subscribers_url":"https://api.github.com/repos/KoffeinFlummi/AGM/subscribers","subscription_url":"https://api.github.com/repos/KoffeinFlummi/AGM/subscription","commits_url":"https://api.github.com/repos/KoffeinFlummi/AGM/commits{/sha}","git_commits_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/commits{/sha}","comments_url":"https://api.github.com/repos/KoffeinFlummi/AGM/comments{/number}","issue_comment_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/comments/{number}","contents_url":"https://api.github.com/repos/KoffeinFlummi/AGM/contents/{+path}","compare_url":"https://api.github.com/repos/KoffeinFlummi/AGM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KoffeinFlummi/AGM/merges","archive_url":"https://api.github.com/repos/KoffeinFlummi/AGM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KoffeinFlummi/AGM/downloads","issues_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues{/number}","pulls_url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls{/number}","milestones_url":"https://api.github.com/repos/KoffeinFlummi/AGM/milestones{/number}","notifications_url":"https://api.github.com/repos/KoffeinFlummi/AGM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KoffeinFlummi/AGM/labels{/name}","releases_url":"https://api.github.com/repos/KoffeinFlummi/AGM/releases{/id}","created_at":"2014-02-02T23:32:42Z","updated_at":"2015-01-08T23:33:45Z","pushed_at":"2015-01-09T01:43:12Z","git_url":"git://github.com/KoffeinFlummi/AGM.git","ssh_url":"git@github.com:KoffeinFlummi/AGM.git","clone_url":"https://github.com/KoffeinFlummi/AGM.git","svn_url":"https://github.com/KoffeinFlummi/AGM","homepage":"","size":99096,"stargazers_count":128,"watchers_count":128,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":141,"forks":105,"open_issues":141,"watchers":128,"default_branch":"master"}},"base":{"label":"KoffeinFlummi:master","ref":"master","sha":"b9cca946910443a4556d34dba125944e87892a51","user":{"login":"KoffeinFlummi","id":2438809,"avatar_url":"https://avatars.githubusercontent.com/u/2438809?v=3","gravatar_id":"","url":"https://api.github.com/users/KoffeinFlummi","html_url":"https://github.com/KoffeinFlummi","followers_url":"https://api.github.com/users/KoffeinFlummi/followers","following_url":"https://api.github.com/users/KoffeinFlummi/following{/other_user}","gists_url":"https://api.github.com/users/KoffeinFlummi/gists{/gist_id}","starred_url":"https://api.github.com/users/KoffeinFlummi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoffeinFlummi/subscriptions","organizations_url":"https://api.github.com/users/KoffeinFlummi/orgs","repos_url":"https://api.github.com/users/KoffeinFlummi/repos","events_url":"https://api.github.com/users/KoffeinFlummi/events{/privacy}","received_events_url":"https://api.github.com/users/KoffeinFlummi/received_events","type":"User","site_admin":false},"repo":{"id":16466069,"name":"AGM","full_name":"KoffeinFlummi/AGM","owner":{"login":"KoffeinFlummi","id":2438809,"avatar_url":"https://avatars.githubusercontent.com/u/2438809?v=3","gravatar_id":"","url":"https://api.github.com/users/KoffeinFlummi","html_url":"https://github.com/KoffeinFlummi","followers_url":"https://api.github.com/users/KoffeinFlummi/followers","following_url":"https://api.github.com/users/KoffeinFlummi/following{/other_user}","gists_url":"https://api.github.com/users/KoffeinFlummi/gists{/gist_id}","starred_url":"https://api.github.com/users/KoffeinFlummi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoffeinFlummi/subscriptions","organizations_url":"https://api.github.com/users/KoffeinFlummi/orgs","repos_url":"https://api.github.com/users/KoffeinFlummi/repos","events_url":"https://api.github.com/users/KoffeinFlummi/events{/privacy}","received_events_url":"https://api.github.com/users/KoffeinFlummi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KoffeinFlummi/AGM","description":"Authentic Gameplay Modification for Arma 3","fork":false,"url":"https://api.github.com/repos/KoffeinFlummi/AGM","forks_url":"https://api.github.com/repos/KoffeinFlummi/AGM/forks","keys_url":"https://api.github.com/repos/KoffeinFlummi/AGM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KoffeinFlummi/AGM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KoffeinFlummi/AGM/teams","hooks_url":"https://api.github.com/repos/KoffeinFlummi/AGM/hooks","issue_events_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/events{/number}","events_url":"https://api.github.com/repos/KoffeinFlummi/AGM/events","assignees_url":"https://api.github.com/repos/KoffeinFlummi/AGM/assignees{/user}","branches_url":"https://api.github.com/repos/KoffeinFlummi/AGM/branches{/branch}","tags_url":"https://api.github.com/repos/KoffeinFlummi/AGM/tags","blobs_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/refs{/sha}","trees_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KoffeinFlummi/AGM/statuses/{sha}","languages_url":"https://api.github.com/repos/KoffeinFlummi/AGM/languages","stargazers_url":"https://api.github.com/repos/KoffeinFlummi/AGM/stargazers","contributors_url":"https://api.github.com/repos/KoffeinFlummi/AGM/contributors","subscribers_url":"https://api.github.com/repos/KoffeinFlummi/AGM/subscribers","subscription_url":"https://api.github.com/repos/KoffeinFlummi/AGM/subscription","commits_url":"https://api.github.com/repos/KoffeinFlummi/AGM/commits{/sha}","git_commits_url":"https://api.github.com/repos/KoffeinFlummi/AGM/git/commits{/sha}","comments_url":"https://api.github.com/repos/KoffeinFlummi/AGM/comments{/number}","issue_comment_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/comments/{number}","contents_url":"https://api.github.com/repos/KoffeinFlummi/AGM/contents/{+path}","compare_url":"https://api.github.com/repos/KoffeinFlummi/AGM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KoffeinFlummi/AGM/merges","archive_url":"https://api.github.com/repos/KoffeinFlummi/AGM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KoffeinFlummi/AGM/downloads","issues_url":"https://api.github.com/repos/KoffeinFlummi/AGM/issues{/number}","pulls_url":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls{/number}","milestones_url":"https://api.github.com/repos/KoffeinFlummi/AGM/milestones{/number}","notifications_url":"https://api.github.com/repos/KoffeinFlummi/AGM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KoffeinFlummi/AGM/labels{/name}","releases_url":"https://api.github.com/repos/KoffeinFlummi/AGM/releases{/id}","created_at":"2014-02-02T23:32:42Z","updated_at":"2015-01-08T23:33:45Z","pushed_at":"2015-01-09T01:43:12Z","git_url":"git://github.com/KoffeinFlummi/AGM.git","ssh_url":"git@github.com:KoffeinFlummi/AGM.git","clone_url":"https://github.com/KoffeinFlummi/AGM.git","svn_url":"https://github.com/KoffeinFlummi/AGM","homepage":"","size":99096,"stargazers_count":128,"watchers_count":128,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":141,"forks":105,"open_issues":141,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933"},"html":{"href":"https://github.com/KoffeinFlummi/AGM/pull/1933"},"issue":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/1933"},"comments":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/issues/1933/comments"},"review_comments":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933/comments"},"review_comment":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/pulls/1933/commits"},"statuses":{"href":"https://api.github.com/repos/KoffeinFlummi/AGM/statuses/b404b1b589df35eb999a7731d437866e2a359df0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":7,"additions":141,"deletions":88,"changed_files":37}}