{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/46936208","id":46936208,"diff_hunk":"@@ -22,11 +22,11 @@ GET            /crosswords/search\n GET            /crosswords/lookup                                                                                                controllers.CrosswordSearchController.lookup()\n \n # Email paths\n-GET        /email                                                               controllers.EmailController.renderPage()\n-GET        /email/form                                                          controllers.EmailController.renderForm()\n-GET        /email/:result                                                       controllers.EmailController.subscriptionResult(result: String)\n-POST       /email                                                               controllers.EmailController.submit()\n-OPTIONS    /email                                                               controllers.EmailController.options()\n+GET            /email                                                           controllers.EmailController.renderPage()\n+GET            /email/form/$formType<footer|article>                            controllers.EmailController.renderForm(formType: String)\n+GET            /email/:result                                                   controllers.EmailController.subscriptionResult(result: String)\n+POST           /email                                                           controllers.EmailController.submit()\n+OPTIONS        /email                                                           controllers.EmailController.options()\n ","path":"applications/conf/routes","position":14,"original_position":14,"commit_id":"d5b52acfe26f9dc97bed44657dd82f4ff1fe18aa","original_commit_id":"d5b52acfe26f9dc97bed44657dd82f4ff1fe18aa","user":{"login":"NathanielBennett","id":986155,"avatar_url":"https://avatars.githubusercontent.com/u/986155?v=3","gravatar_id":"","url":"https://api.github.com/users/NathanielBennett","html_url":"https://github.com/NathanielBennett","followers_url":"https://api.github.com/users/NathanielBennett/followers","following_url":"https://api.github.com/users/NathanielBennett/following{/other_user}","gists_url":"https://api.github.com/users/NathanielBennett/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanielBennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanielBennett/subscriptions","organizations_url":"https://api.github.com/users/NathanielBennett/orgs","repos_url":"https://api.github.com/users/NathanielBennett/repos","events_url":"https://api.github.com/users/NathanielBennett/events{/privacy}","received_events_url":"https://api.github.com/users/NathanielBennett/received_events","type":"User","site_admin":false},"body":"Mebbe get this so the whitespace changes don't get picked up at changes\r\n","created_at":"2015-12-08T10:23:58Z","updated_at":"2015-12-08T10:23:58Z","html_url":"https://github.com/guardian/frontend/pull/11303#discussion_r46936208","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/11303","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/46936208"},"html":{"href":"https://github.com/guardian/frontend/pull/11303#discussion_r46936208"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/11303"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/11303","id":52878951,"html_url":"https://github.com/guardian/frontend/pull/11303","diff_url":"https://github.com/guardian/frontend/pull/11303.diff","patch_url":"https://github.com/guardian/frontend/pull/11303.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/11303","number":11303,"state":"open","locked":false,"title":"Rtrt email in article","user":{"login":"gtrufitt","id":638051,"avatar_url":"https://avatars.githubusercontent.com/u/638051?v=3","gravatar_id":"","url":"https://api.github.com/users/gtrufitt","html_url":"https://github.com/gtrufitt","followers_url":"https://api.github.com/users/gtrufitt/followers","following_url":"https://api.github.com/users/gtrufitt/following{/other_user}","gists_url":"https://api.github.com/users/gtrufitt/gists{/gist_id}","starred_url":"https://api.github.com/users/gtrufitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtrufitt/subscriptions","organizations_url":"https://api.github.com/users/gtrufitt/orgs","repos_url":"https://api.github.com/users/gtrufitt/repos","events_url":"https://api.github.com/users/gtrufitt/events{/privacy}","received_events_url":"https://api.github.com/users/gtrufitt/received_events","type":"User","site_admin":false},"body":"Allow embedding of the inline email into composer articles. Embed code looks like:\r\n\r\n```<iframe src=\"/email/form/article\" data-form-title=\"Want stories like this in your inbox?\" data-form-description=\"Subscribe to the Guardian Today and get the biggest headlines delivered to you each morning\" scrolling=\"no\" seamless frameborder=\"0\" class=\"iframed--overflow-hidden email-sub__iframe js-email-sub__iframe--article\"></iframe>```\r\n\r\n![image](https://cloud.githubusercontent.com/assets/638051/11634985/b04d816e-9d0b-11e5-8635-92c928581c69.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/638051/11635006/cbc12482-9d0b-11e5-9c52-28eeddab71ab.png)\r\n\r\nI have update the email routes to allow a form type, restricted initially to `footer` and `article`. Passing options/settings from the embedded iframe to the form below is done with data attributes.","created_at":"2015-12-07T18:02:03Z","updated_at":"2015-12-08T10:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2cd28b2db7fc1b28be077dbdae842640edd9e56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/11303/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/11303/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/11303/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/d5b52acfe26f9dc97bed44657dd82f4ff1fe18aa","head":{"label":"guardian:RTRT_Email-in-article","ref":"RTRT_Email-in-article","sha":"d5b52acfe26f9dc97bed44657dd82f4ff1fe18aa","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-12-08T08:20:49Z","pushed_at":"2015-12-08T10:10:20Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":371151,"stargazers_count":3046,"watchers_count":3046,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":50,"forks":304,"open_issues":50,"watchers":3046,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"f8a535c4f500a7b3ed3edf3cbc7382eb21f260f4","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","created_at":"2012-05-18T15:39:15Z","updated_at":"2015-12-08T08:20:49Z","pushed_at":"2015-12-08T10:10:20Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":371151,"stargazers_count":3046,"watchers_count":3046,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":50,"forks":304,"open_issues":50,"watchers":3046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/11303"},"html":{"href":"https://github.com/guardian/frontend/pull/11303"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/11303"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/11303/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/11303/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/11303/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/d5b52acfe26f9dc97bed44657dd82f4ff1fe18aa"}}}}