{"action":"created","issue":{"url":"https://api.github.com/repos/gulpjs/glob-stream/issues/56","labels_url":"https://api.github.com/repos/gulpjs/glob-stream/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/gulpjs/glob-stream/issues/56/comments","events_url":"https://api.github.com/repos/gulpjs/glob-stream/issues/56/events","html_url":"https://github.com/gulpjs/glob-stream/pull/56","id":115988148,"number":56,"title":"Use micromatch & glob-parent instead of minimatch & glob2base","user":{"login":"es128","id":1740641,"avatar_url":"https://avatars.githubusercontent.com/u/1740641?v=3","gravatar_id":"","url":"https://api.github.com/users/es128","html_url":"https://github.com/es128","followers_url":"https://api.github.com/users/es128/followers","following_url":"https://api.github.com/users/es128/following{/other_user}","gists_url":"https://api.github.com/users/es128/gists{/gist_id}","starred_url":"https://api.github.com/users/es128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es128/subscriptions","organizations_url":"https://api.github.com/users/es128/orgs","repos_url":"https://api.github.com/users/es128/repos","events_url":"https://api.github.com/users/es128/events{/privacy}","received_events_url":"https://api.github.com/users/es128/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-09T23:06:14Z","updated_at":"2015-11-17T00:19:37Z","closed_at":"2015-11-17T00:19:17Z","pull_request":{"url":"https://api.github.com/repos/gulpjs/glob-stream/pulls/56","html_url":"https://github.com/gulpjs/glob-stream/pull/56","diff_url":"https://github.com/gulpjs/glob-stream/pull/56.diff","patch_url":"https://github.com/gulpjs/glob-stream/pull/56.patch"},"body":"Resolves #44\r\n\r\nLet me know if you'd prefer I split this into two separate PRs\r\n\r\nglob-parent v2 achieves parity with glob2base's handling of non-glob paths (stripping the filename) with a simpler algorithm and better performance. The only difference between them now is the trailing slash in the result, resolved simply enough here. I also added the patterns from the glob2base tests to the glob-parent repo to provide some extra assurance.\r\n\r\nThe caveat to swapping micromatch for minimatch here is that it only applies to negative globs. Positive globs are still just passed to node-glob, which of course continues to use micromatch. This does introduce an increased chance of new edge cases and inconsistencies which should be taken into consideration. But chokidar has been living with a similar inconsistency for a quite a while now (minimatch via readdirp for file tree walking and micromatch within chokidar for event filtering) and it hasn't been the source of any notable problems. (I also do have something in the works that will be able to replace node-glob and readdirp to resolve this, but that isn't an available solution for today)"},"comment":{"url":"https://api.github.com/repos/gulpjs/glob-stream/issues/comments/157218030","html_url":"https://github.com/gulpjs/glob-stream/pull/56#issuecomment-157218030","issue_url":"https://api.github.com/repos/gulpjs/glob-stream/issues/56","id":157218030,"user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T00:19:37Z","updated_at":"2015-11-17T00:19:37Z","body":"@es128 thanks!"}}