{"action":"created","issue":{"url":"https://api.github.com/repos/bebraw/grunt-umd/issues/27","labels_url":"https://api.github.com/repos/bebraw/grunt-umd/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/bebraw/grunt-umd/issues/27/comments","events_url":"https://api.github.com/repos/bebraw/grunt-umd/issues/27/events","html_url":"https://github.com/bebraw/grunt-umd/issues/27","id":56844236,"number":27,"title":"Version 2.0.0-beta1 and upwards to inject dependencies anymore","user":{"login":"cburgmer","id":101613,"avatar_url":"https://avatars.githubusercontent.com/u/101613?v=3","gravatar_id":"","url":"https://api.github.com/users/cburgmer","html_url":"https://github.com/cburgmer","followers_url":"https://api.github.com/users/cburgmer/followers","following_url":"https://api.github.com/users/cburgmer/following{/other_user}","gists_url":"https://api.github.com/users/cburgmer/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgmer/subscriptions","organizations_url":"https://api.github.com/users/cburgmer/orgs","repos_url":"https://api.github.com/users/cburgmer/repos","events_url":"https://api.github.com/users/cburgmer/events{/privacy}","received_events_url":"https://api.github.com/users/cburgmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-06T17:49:35Z","updated_at":"2015-02-06T19:50:31Z","closed_at":null,"body":"I have the following Gruntfile config:\r\n```\r\n        umd: {\r\n            all: {\r\n                src: 'build/rasterizeHTML.concat.js',\r\n                dest: 'build/rasterizeHTML.umd.js',\r\n                objectToExport: 'rasterizeHTML',\r\n                indent: '    ',\r\n                deps: {\r\n                    'default': ['url', 'xmlserializer', 'ayepromise', 'inlineresources']\r\n                }\r\n            }\r\n        }\r\n```\r\n\r\nThis used to provide the appropriate header with the dependencies injected as needed:\r\n\r\n```\r\n(function(root, factory) {\r\n    if(typeof exports === 'object') {\r\n        module.exports = factory(require('url'), require('xmlserializer'), require('ayepromise'), require('inlineresources'));\r\n    }\r\n    else if(typeof define === 'function' && define.amd) {\r\n        define(['url', 'xmlserializer', 'ayepromise', 'inlineresources'], factory);\r\n    }\r\n    else {\r\n        root['rasterizeHTML'] = factory(root.url, root.xmlserializer, root.ayepromise, root.inlineresources);\r\n    }\r\n}(this, function(url, xmlserializer, ayepromise, inlineresources) {\r\n```\r\n\r\nFollowing this commit https://github.com/bebraw/grunt-umd/commit/5e742d8fc2fd272e8a74ff7ee2375a5539ba8fe3 my dependencies are now not injected anymore and are thus undefined. The header I receive is\r\n\r\n```\r\n(function (root, factory) {\r\n  if (typeof define === 'function' && define.amd) {\r\n    // AMD. Register as an anonymous module.\r\n    define([], function (url, xmlserializer, ayepromise, inlineresources) {\r\n      return (root.returnExportsGlobal = factory(url, xmlserializer, ayepromise, inlineresources));\r\n    });\r\n  } else if (typeof exports === 'object') {\r\n    // Node. Does not work with strict CommonJS, but\r\n    // only CommonJS-like enviroments that support module.exports,\r\n    // like Node.\r\n    module.exports = factory();\r\n  } else {\r\n    root['rasterizeHTML'] = factory();\r\n  }\r\n}(this, function (url, xmlserializer, ayepromise, inlineresources) {\r\n```\r\n\r\nIf this is the desired behaviour, then I am missing the announcement in the release notes."},"comment":{"url":"https://api.github.com/repos/bebraw/grunt-umd/issues/comments/73301034","html_url":"https://github.com/bebraw/grunt-umd/issues/27#issuecomment-73301034","issue_url":"https://api.github.com/repos/bebraw/grunt-umd/issues/27","id":73301034,"user":{"login":"bebraw","id":166921,"avatar_url":"https://avatars.githubusercontent.com/u/166921?v=3","gravatar_id":"","url":"https://api.github.com/users/bebraw","html_url":"https://github.com/bebraw","followers_url":"https://api.github.com/users/bebraw/followers","following_url":"https://api.github.com/users/bebraw/following{/other_user}","gists_url":"https://api.github.com/users/bebraw/gists{/gist_id}","starred_url":"https://api.github.com/users/bebraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebraw/subscriptions","organizations_url":"https://api.github.com/users/bebraw/orgs","repos_url":"https://api.github.com/users/bebraw/repos","events_url":"https://api.github.com/users/bebraw/events{/privacy}","received_events_url":"https://api.github.com/users/bebraw/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T19:50:31Z","updated_at":"2015-02-06T19:50:31Z","body":"> Not sure what the default is intended to express.\r\n>\r\n> For me using the default keeps the definition small and avoids code duplication.\r\n\r\nOk. Fair point. I'll change it to match the earlier behavior in 2.3.0. That version will also add initial support for globbing."}}