{"action":"created","comment":{"url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/comments/43574363","id":43574363,"diff_hunk":"@@ -159,7 +177,30 @@ public boolean onNavigationItemSelected(MenuItem menuItem) {\n     public void selectDrawerItem(MenuItem menuItem) {\n         switch (menuItem.getItemId()) {\n             case R.id.login_fragment:\n-                new LoginFragment().show(getSupportFragmentManager(), \"Login_with_Facebook\");\n+                // new LoginFragment().show(getSupportFragmentManager(), \"Login_with_Facebook\");\n+                // Login status also available in shared preference, but doing it using listener here.\n+                // This is useful for later comparison.\n+                LoginFragment.newInstance(new LoginFragment.OnLoginLogoutListener() {","path":"app/src/main/java/com/travelguide/activities/TravelGuideActivity.java","position":87,"original_position":87,"commit_id":"06eafa3abc570c74ec1b7ff7574d9a67c3e4cc60","original_commit_id":"06eafa3abc570c74ec1b7ff7574d9a67c3e4cc60","user":{"login":"rafagcamargo","id":497047,"avatar_url":"https://avatars.githubusercontent.com/u/497047?v=3","gravatar_id":"","url":"https://api.github.com/users/rafagcamargo","html_url":"https://github.com/rafagcamargo","followers_url":"https://api.github.com/users/rafagcamargo/followers","following_url":"https://api.github.com/users/rafagcamargo/following{/other_user}","gists_url":"https://api.github.com/users/rafagcamargo/gists{/gist_id}","starred_url":"https://api.github.com/users/rafagcamargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafagcamargo/subscriptions","organizations_url":"https://api.github.com/users/rafagcamargo/orgs","repos_url":"https://api.github.com/users/rafagcamargo/repos","events_url":"https://api.github.com/users/rafagcamargo/events{/privacy}","received_events_url":"https://api.github.com/users/rafagcamargo/received_events","type":"User","site_admin":false},"body":"This is not right, take a look and see how was implemented on `TripListFragment`, you have to make `TravelGuideActivity` implement `OnLoginLogoutListener` and inside `LoginFragment` use attach and detach method properly, that way you don't need make it `Parcelable`.","created_at":"2015-10-31T18:02:41Z","updated_at":"2015-10-31T18:02:41Z","html_url":"https://github.com/TravelGuide/TravelGuide/pull/80#discussion_r43574363","pull_request_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/comments/43574363"},"html":{"href":"https://github.com/TravelGuide/TravelGuide/pull/80#discussion_r43574363"},"pull_request":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80","id":49343733,"html_url":"https://github.com/TravelGuide/TravelGuide/pull/80","diff_url":"https://github.com/TravelGuide/TravelGuide/pull/80.diff","patch_url":"https://github.com/TravelGuide/TravelGuide/pull/80.patch","issue_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/80","number":80,"state":"open","locked":false,"title":"Logout from Parse","user":{"login":"kprav","id":4088082,"avatar_url":"https://avatars.githubusercontent.com/u/4088082?v=3","gravatar_id":"","url":"https://api.github.com/users/kprav","html_url":"https://github.com/kprav","followers_url":"https://api.github.com/users/kprav/followers","following_url":"https://api.github.com/users/kprav/following{/other_user}","gists_url":"https://api.github.com/users/kprav/gists{/gist_id}","starred_url":"https://api.github.com/users/kprav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kprav/subscriptions","organizations_url":"https://api.github.com/users/kprav/orgs","repos_url":"https://api.github.com/users/kprav/repos","events_url":"https://api.github.com/users/kprav/events{/privacy}","received_events_url":"https://api.github.com/users/kprav/received_events","type":"User","site_admin":false},"body":"@rafagcamargo @SharedMocha Please review and merge. \r\n\r\nFollowing are implemented:\r\n1. Logout functionality from parse. \r\n2. Attached a listener to LoginFragment and is hooked up in TravelGuideActivity.\r\n3. The navDrawer will no longer refresh everytime on toggle.\r\n4. Login/Logout label will automatically toggle in the navDrawer depending on current user state.\r\n\r\nTo test, uninstall the App from your device and then reinstall.","created_at":"2015-10-31T07:10:44Z","updated_at":"2015-10-31T18:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4739fe70e0c4cb22f3214d2b95829440947ae8ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80/commits","review_comments_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80/comments","review_comment_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/80/comments","statuses_url":"https://api.github.com/repos/TravelGuide/TravelGuide/statuses/06eafa3abc570c74ec1b7ff7574d9a67c3e4cc60","head":{"label":"TravelGuide:Praveen","ref":"Praveen","sha":"06eafa3abc570c74ec1b7ff7574d9a67c3e4cc60","user":{"login":"TravelGuide","id":15025786,"avatar_url":"https://avatars.githubusercontent.com/u/15025786?v=3","gravatar_id":"","url":"https://api.github.com/users/TravelGuide","html_url":"https://github.com/TravelGuide","followers_url":"https://api.github.com/users/TravelGuide/followers","following_url":"https://api.github.com/users/TravelGuide/following{/other_user}","gists_url":"https://api.github.com/users/TravelGuide/gists{/gist_id}","starred_url":"https://api.github.com/users/TravelGuide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravelGuide/subscriptions","organizations_url":"https://api.github.com/users/TravelGuide/orgs","repos_url":"https://api.github.com/users/TravelGuide/repos","events_url":"https://api.github.com/users/TravelGuide/events{/privacy}","received_events_url":"https://api.github.com/users/TravelGuide/received_events","type":"Organization","site_admin":false},"repo":{"id":43860560,"name":"TravelGuide","full_name":"TravelGuide/TravelGuide","owner":{"login":"TravelGuide","id":15025786,"avatar_url":"https://avatars.githubusercontent.com/u/15025786?v=3","gravatar_id":"","url":"https://api.github.com/users/TravelGuide","html_url":"https://github.com/TravelGuide","followers_url":"https://api.github.com/users/TravelGuide/followers","following_url":"https://api.github.com/users/TravelGuide/following{/other_user}","gists_url":"https://api.github.com/users/TravelGuide/gists{/gist_id}","starred_url":"https://api.github.com/users/TravelGuide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravelGuide/subscriptions","organizations_url":"https://api.github.com/users/TravelGuide/orgs","repos_url":"https://api.github.com/users/TravelGuide/repos","events_url":"https://api.github.com/users/TravelGuide/events{/privacy}","received_events_url":"https://api.github.com/users/TravelGuide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TravelGuide/TravelGuide","description":"Travel Details ","fork":false,"url":"https://api.github.com/repos/TravelGuide/TravelGuide","forks_url":"https://api.github.com/repos/TravelGuide/TravelGuide/forks","keys_url":"https://api.github.com/repos/TravelGuide/TravelGuide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TravelGuide/TravelGuide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TravelGuide/TravelGuide/teams","hooks_url":"https://api.github.com/repos/TravelGuide/TravelGuide/hooks","issue_events_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/events{/number}","events_url":"https://api.github.com/repos/TravelGuide/TravelGuide/events","assignees_url":"https://api.github.com/repos/TravelGuide/TravelGuide/assignees{/user}","branches_url":"https://api.github.com/repos/TravelGuide/TravelGuide/branches{/branch}","tags_url":"https://api.github.com/repos/TravelGuide/TravelGuide/tags","blobs_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/refs{/sha}","trees_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TravelGuide/TravelGuide/statuses/{sha}","languages_url":"https://api.github.com/repos/TravelGuide/TravelGuide/languages","stargazers_url":"https://api.github.com/repos/TravelGuide/TravelGuide/stargazers","contributors_url":"https://api.github.com/repos/TravelGuide/TravelGuide/contributors","subscribers_url":"https://api.github.com/repos/TravelGuide/TravelGuide/subscribers","subscription_url":"https://api.github.com/repos/TravelGuide/TravelGuide/subscription","commits_url":"https://api.github.com/repos/TravelGuide/TravelGuide/commits{/sha}","git_commits_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/commits{/sha}","comments_url":"https://api.github.com/repos/TravelGuide/TravelGuide/comments{/number}","issue_comment_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/comments{/number}","contents_url":"https://api.github.com/repos/TravelGuide/TravelGuide/contents/{+path}","compare_url":"https://api.github.com/repos/TravelGuide/TravelGuide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TravelGuide/TravelGuide/merges","archive_url":"https://api.github.com/repos/TravelGuide/TravelGuide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TravelGuide/TravelGuide/downloads","issues_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues{/number}","pulls_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls{/number}","milestones_url":"https://api.github.com/repos/TravelGuide/TravelGuide/milestones{/number}","notifications_url":"https://api.github.com/repos/TravelGuide/TravelGuide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TravelGuide/TravelGuide/labels{/name}","releases_url":"https://api.github.com/repos/TravelGuide/TravelGuide/releases{/id}","created_at":"2015-10-08T03:36:58Z","updated_at":"2015-10-15T03:22:10Z","pushed_at":"2015-10-31T08:37:18Z","git_url":"git://github.com/TravelGuide/TravelGuide.git","ssh_url":"git@github.com:TravelGuide/TravelGuide.git","clone_url":"https://github.com/TravelGuide/TravelGuide.git","svn_url":"https://github.com/TravelGuide/TravelGuide","homepage":null,"size":32252,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":0,"default_branch":"master"}},"base":{"label":"TravelGuide:master","ref":"master","sha":"002aa9613e35e85443bd2d63a012155432be1429","user":{"login":"TravelGuide","id":15025786,"avatar_url":"https://avatars.githubusercontent.com/u/15025786?v=3","gravatar_id":"","url":"https://api.github.com/users/TravelGuide","html_url":"https://github.com/TravelGuide","followers_url":"https://api.github.com/users/TravelGuide/followers","following_url":"https://api.github.com/users/TravelGuide/following{/other_user}","gists_url":"https://api.github.com/users/TravelGuide/gists{/gist_id}","starred_url":"https://api.github.com/users/TravelGuide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravelGuide/subscriptions","organizations_url":"https://api.github.com/users/TravelGuide/orgs","repos_url":"https://api.github.com/users/TravelGuide/repos","events_url":"https://api.github.com/users/TravelGuide/events{/privacy}","received_events_url":"https://api.github.com/users/TravelGuide/received_events","type":"Organization","site_admin":false},"repo":{"id":43860560,"name":"TravelGuide","full_name":"TravelGuide/TravelGuide","owner":{"login":"TravelGuide","id":15025786,"avatar_url":"https://avatars.githubusercontent.com/u/15025786?v=3","gravatar_id":"","url":"https://api.github.com/users/TravelGuide","html_url":"https://github.com/TravelGuide","followers_url":"https://api.github.com/users/TravelGuide/followers","following_url":"https://api.github.com/users/TravelGuide/following{/other_user}","gists_url":"https://api.github.com/users/TravelGuide/gists{/gist_id}","starred_url":"https://api.github.com/users/TravelGuide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravelGuide/subscriptions","organizations_url":"https://api.github.com/users/TravelGuide/orgs","repos_url":"https://api.github.com/users/TravelGuide/repos","events_url":"https://api.github.com/users/TravelGuide/events{/privacy}","received_events_url":"https://api.github.com/users/TravelGuide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TravelGuide/TravelGuide","description":"Travel Details ","fork":false,"url":"https://api.github.com/repos/TravelGuide/TravelGuide","forks_url":"https://api.github.com/repos/TravelGuide/TravelGuide/forks","keys_url":"https://api.github.com/repos/TravelGuide/TravelGuide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TravelGuide/TravelGuide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TravelGuide/TravelGuide/teams","hooks_url":"https://api.github.com/repos/TravelGuide/TravelGuide/hooks","issue_events_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/events{/number}","events_url":"https://api.github.com/repos/TravelGuide/TravelGuide/events","assignees_url":"https://api.github.com/repos/TravelGuide/TravelGuide/assignees{/user}","branches_url":"https://api.github.com/repos/TravelGuide/TravelGuide/branches{/branch}","tags_url":"https://api.github.com/repos/TravelGuide/TravelGuide/tags","blobs_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/refs{/sha}","trees_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TravelGuide/TravelGuide/statuses/{sha}","languages_url":"https://api.github.com/repos/TravelGuide/TravelGuide/languages","stargazers_url":"https://api.github.com/repos/TravelGuide/TravelGuide/stargazers","contributors_url":"https://api.github.com/repos/TravelGuide/TravelGuide/contributors","subscribers_url":"https://api.github.com/repos/TravelGuide/TravelGuide/subscribers","subscription_url":"https://api.github.com/repos/TravelGuide/TravelGuide/subscription","commits_url":"https://api.github.com/repos/TravelGuide/TravelGuide/commits{/sha}","git_commits_url":"https://api.github.com/repos/TravelGuide/TravelGuide/git/commits{/sha}","comments_url":"https://api.github.com/repos/TravelGuide/TravelGuide/comments{/number}","issue_comment_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/comments{/number}","contents_url":"https://api.github.com/repos/TravelGuide/TravelGuide/contents/{+path}","compare_url":"https://api.github.com/repos/TravelGuide/TravelGuide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TravelGuide/TravelGuide/merges","archive_url":"https://api.github.com/repos/TravelGuide/TravelGuide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TravelGuide/TravelGuide/downloads","issues_url":"https://api.github.com/repos/TravelGuide/TravelGuide/issues{/number}","pulls_url":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls{/number}","milestones_url":"https://api.github.com/repos/TravelGuide/TravelGuide/milestones{/number}","notifications_url":"https://api.github.com/repos/TravelGuide/TravelGuide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TravelGuide/TravelGuide/labels{/name}","releases_url":"https://api.github.com/repos/TravelGuide/TravelGuide/releases{/id}","created_at":"2015-10-08T03:36:58Z","updated_at":"2015-10-15T03:22:10Z","pushed_at":"2015-10-31T08:37:18Z","git_url":"git://github.com/TravelGuide/TravelGuide.git","ssh_url":"git@github.com:TravelGuide/TravelGuide.git","clone_url":"https://github.com/TravelGuide/TravelGuide.git","svn_url":"https://github.com/TravelGuide/TravelGuide","homepage":null,"size":32252,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":26,"forks":0,"open_issues":26,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80"},"html":{"href":"https://github.com/TravelGuide/TravelGuide/pull/80"},"issue":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/80"},"comments":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/TravelGuide/TravelGuide/statuses/06eafa3abc570c74ec1b7ff7574d9a67c3e4cc60"}}}}