{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/33358467","id":33358467,"diff_hunk":"@@ -167,6 +167,23 @@ Service Naming Conventions\n \n * A group name uses the underscore notation.\n \n+.. _contributing-code-standards-comparisons:\n+\n+Comparisons\n+-----------\n+\n+Always use `identical comparison`_ unless you need type juggling::","path":"contributing/code/standards.rst","position":9,"original_position":9,"commit_id":"b648da8b0b2afd34268982ccb484a6a2a455a4cb","original_commit_id":"b648da8b0b2afd34268982ccb484a6a2a455a4cb","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"I think we should put this in the list of standards as well, instead of a custom section","created_at":"2015-06-26T14:06:59Z","updated_at":"2015-06-26T14:06:59Z","html_url":"https://github.com/symfony/symfony-docs/pull/5403#discussion_r33358467","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/33358467"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/5403#discussion_r33358467"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403","id":37705578,"html_url":"https://github.com/symfony/symfony-docs/pull/5403","diff_url":"https://github.com/symfony/symfony-docs/pull/5403.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/5403.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/5403","number":5403,"state":"open","locked":false,"title":"[Contributing] [Standards] Added entry for identical comparison","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | 2.8+\r\n| Fixed tickets |","created_at":"2015-06-15T15:44:09Z","updated_at":"2015-06-26T14:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b73403fb2dd267b30a98d376155d7640a05fd5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/5403/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/b648da8b0b2afd34268982ccb484a6a2a455a4cb","head":{"label":"phansys:conventions_strict_comparison","ref":"conventions_strict_comparison","sha":"b648da8b0b2afd34268982ccb484a6a2a455a4cb","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"repo":{"id":20787289,"name":"symfony-docs","full_name":"phansys/symfony-docs","owner":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phansys/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/phansys/symfony-docs","forks_url":"https://api.github.com/repos/phansys/symfony-docs/forks","keys_url":"https://api.github.com/repos/phansys/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phansys/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phansys/symfony-docs/teams","hooks_url":"https://api.github.com/repos/phansys/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/phansys/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/phansys/symfony-docs/events","assignees_url":"https://api.github.com/repos/phansys/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/phansys/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/phansys/symfony-docs/tags","blobs_url":"https://api.github.com/repos/phansys/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phansys/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phansys/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/phansys/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phansys/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/phansys/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/phansys/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/phansys/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/phansys/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/phansys/symfony-docs/subscription","commits_url":"https://api.github.com/repos/phansys/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/phansys/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/phansys/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/phansys/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/phansys/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/phansys/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phansys/symfony-docs/merges","archive_url":"https://api.github.com/repos/phansys/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phansys/symfony-docs/downloads","issues_url":"https://api.github.com/repos/phansys/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/phansys/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/phansys/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/phansys/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phansys/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/phansys/symfony-docs/releases{/id}","created_at":"2014-06-13T00:32:46Z","updated_at":"2014-06-13T01:06:59Z","pushed_at":"2015-06-26T14:00:29Z","git_url":"git://github.com/phansys/symfony-docs.git","ssh_url":"git@github.com:phansys/symfony-docs.git","clone_url":"https://github.com/phansys/symfony-docs.git","svn_url":"https://github.com/phansys/symfony-docs","homepage":"http://symfony.com/doc/current/","size":29470,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"59569c09f370bc4f335bd5df2451872f20ce2ae6","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2015-06-26T02:12:56Z","pushed_at":"2015-06-26T14:05:18Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc","size":60203,"stargazers_count":995,"watchers_count":995,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1911,"mirror_url":null,"open_issues_count":292,"forks":1911,"open_issues":292,"watchers":995,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/5403"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/5403"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/5403/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/5403/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/b648da8b0b2afd34268982ccb484a6a2a455a4cb"}}}}