{"action":"created","comment":{"url":"https://api.github.com/repos/firebreath/FireBreath/pulls/comments/33179132","id":33179132,"diff_hunk":"@@ -404,9 +411,10 @@ namespace FB { namespace ActiveX {\n                     return E_INVALIDARG;\n \n                 // TODO: Create a promise from the DOM, return it tied to the Deferred returned here\n-                //FB::variant rVal = api->GetProperty(wsName);\n+                FB::variantPromise rVal = api->GetProperty(wsName);\n+//                host->getComVariant(pvarRes, rVal);\n \n-                //host->getComVariant(pvarRes, rVal);\n+\t\t\t\tsetPromise(rVal, pvarRes);\n ","path":"src/ActiveXCore/JSAPI_IDispatchEx.h","position":40,"original_position":40,"commit_id":"34b5377ba337d223c8e8a71d5ee5744695452f91","original_commit_id":"34b5377ba337d223c8e8a71d5ee5744695452f91","user":{"login":"AndyTather","id":6072772,"avatar_url":"https://avatars.githubusercontent.com/u/6072772?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyTather","html_url":"https://github.com/AndyTather","followers_url":"https://api.github.com/users/AndyTather/followers","following_url":"https://api.github.com/users/AndyTather/following{/other_user}","gists_url":"https://api.github.com/users/AndyTather/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyTather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyTather/subscriptions","organizations_url":"https://api.github.com/users/AndyTather/orgs","repos_url":"https://api.github.com/users/AndyTather/repos","events_url":"https://api.github.com/users/AndyTather/events{/privacy}","received_events_url":"https://api.github.com/users/AndyTather/received_events","type":"User","site_admin":false},"body":"Trying to reuse setPromise pattern/call as in npapi","created_at":"2015-06-24T18:23:45Z","updated_at":"2015-06-24T18:23:45Z","html_url":"https://github.com/firebreath/FireBreath/pull/154#discussion_r33179132","pull_request_url":"https://api.github.com/repos/firebreath/FireBreath/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/comments/33179132"},"html":{"href":"https://github.com/firebreath/FireBreath/pull/154#discussion_r33179132"},"pull_request":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/firebreath/FireBreath/pulls/154","id":34260965,"html_url":"https://github.com/firebreath/FireBreath/pull/154","diff_url":"https://github.com/firebreath/FireBreath/pull/154.diff","patch_url":"https://github.com/firebreath/FireBreath/pull/154.patch","issue_url":"https://api.github.com/repos/firebreath/FireBreath/issues/154","number":154,"state":"open","locked":false,"title":"Fix windows Wix creation / json file + signing/cab file paths + configurable NativeMessageHost filename","user":{"login":"AndyTather","id":6072772,"avatar_url":"https://avatars.githubusercontent.com/u/6072772?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyTather","html_url":"https://github.com/AndyTather","followers_url":"https://api.github.com/users/AndyTather/followers","following_url":"https://api.github.com/users/AndyTather/following{/other_user}","gists_url":"https://api.github.com/users/AndyTather/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyTather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyTather/subscriptions","organizations_url":"https://api.github.com/users/AndyTather/orgs","repos_url":"https://api.github.com/users/AndyTather/repos","events_url":"https://api.github.com/users/AndyTather/events{/privacy}","received_events_url":"https://api.github.com/users/AndyTather/received_events","type":"User","site_admin":false},"body":"Just a few little tweaks to get a new windows sample up and compiling.\r\nMake NativeMessageHost name configurable","created_at":"2015-04-28T12:24:10Z","updated_at":"2015-06-24T18:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c2692b5120c470f6d827cb6eea3bd4adc19beb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firebreath/FireBreath/pulls/154/commits","review_comments_url":"https://api.github.com/repos/firebreath/FireBreath/pulls/154/comments","review_comment_url":"https://api.github.com/repos/firebreath/FireBreath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebreath/FireBreath/issues/154/comments","statuses_url":"https://api.github.com/repos/firebreath/FireBreath/statuses/34b5377ba337d223c8e8a71d5ee5744695452f91","head":{"label":"AndyTather:refactor","ref":"refactor","sha":"34b5377ba337d223c8e8a71d5ee5744695452f91","user":{"login":"AndyTather","id":6072772,"avatar_url":"https://avatars.githubusercontent.com/u/6072772?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyTather","html_url":"https://github.com/AndyTather","followers_url":"https://api.github.com/users/AndyTather/followers","following_url":"https://api.github.com/users/AndyTather/following{/other_user}","gists_url":"https://api.github.com/users/AndyTather/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyTather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyTather/subscriptions","organizations_url":"https://api.github.com/users/AndyTather/orgs","repos_url":"https://api.github.com/users/AndyTather/repos","events_url":"https://api.github.com/users/AndyTather/events{/privacy}","received_events_url":"https://api.github.com/users/AndyTather/received_events","type":"User","site_admin":false},"repo":{"id":34679137,"name":"FireBreath","full_name":"AndyTather/FireBreath","owner":{"login":"AndyTather","id":6072772,"avatar_url":"https://avatars.githubusercontent.com/u/6072772?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyTather","html_url":"https://github.com/AndyTather","followers_url":"https://api.github.com/users/AndyTather/followers","following_url":"https://api.github.com/users/AndyTather/following{/other_user}","gists_url":"https://api.github.com/users/AndyTather/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyTather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyTather/subscriptions","organizations_url":"https://api.github.com/users/AndyTather/orgs","repos_url":"https://api.github.com/users/AndyTather/repos","events_url":"https://api.github.com/users/AndyTather/events{/privacy}","received_events_url":"https://api.github.com/users/AndyTather/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndyTather/FireBreath","description":"Browser Plugin framework (NPAPI and ActiveX on Windows, Mac, and Linux)","fork":true,"url":"https://api.github.com/repos/AndyTather/FireBreath","forks_url":"https://api.github.com/repos/AndyTather/FireBreath/forks","keys_url":"https://api.github.com/repos/AndyTather/FireBreath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndyTather/FireBreath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndyTather/FireBreath/teams","hooks_url":"https://api.github.com/repos/AndyTather/FireBreath/hooks","issue_events_url":"https://api.github.com/repos/AndyTather/FireBreath/issues/events{/number}","events_url":"https://api.github.com/repos/AndyTather/FireBreath/events","assignees_url":"https://api.github.com/repos/AndyTather/FireBreath/assignees{/user}","branches_url":"https://api.github.com/repos/AndyTather/FireBreath/branches{/branch}","tags_url":"https://api.github.com/repos/AndyTather/FireBreath/tags","blobs_url":"https://api.github.com/repos/AndyTather/FireBreath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndyTather/FireBreath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndyTather/FireBreath/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndyTather/FireBreath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndyTather/FireBreath/statuses/{sha}","languages_url":"https://api.github.com/repos/AndyTather/FireBreath/languages","stargazers_url":"https://api.github.com/repos/AndyTather/FireBreath/stargazers","contributors_url":"https://api.github.com/repos/AndyTather/FireBreath/contributors","subscribers_url":"https://api.github.com/repos/AndyTather/FireBreath/subscribers","subscription_url":"https://api.github.com/repos/AndyTather/FireBreath/subscription","commits_url":"https://api.github.com/repos/AndyTather/FireBreath/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndyTather/FireBreath/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndyTather/FireBreath/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndyTather/FireBreath/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndyTather/FireBreath/contents/{+path}","compare_url":"https://api.github.com/repos/AndyTather/FireBreath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndyTather/FireBreath/merges","archive_url":"https://api.github.com/repos/AndyTather/FireBreath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndyTather/FireBreath/downloads","issues_url":"https://api.github.com/repos/AndyTather/FireBreath/issues{/number}","pulls_url":"https://api.github.com/repos/AndyTather/FireBreath/pulls{/number}","milestones_url":"https://api.github.com/repos/AndyTather/FireBreath/milestones{/number}","notifications_url":"https://api.github.com/repos/AndyTather/FireBreath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndyTather/FireBreath/labels{/name}","releases_url":"https://api.github.com/repos/AndyTather/FireBreath/releases{/id}","created_at":"2015-04-27T16:54:49Z","updated_at":"2015-05-04T20:50:28Z","pushed_at":"2015-06-24T18:11:19Z","git_url":"git://github.com/AndyTather/FireBreath.git","ssh_url":"git@github.com:AndyTather/FireBreath.git","clone_url":"https://github.com/AndyTather/FireBreath.git","svn_url":"https://github.com/AndyTather/FireBreath","homepage":"http://www.firebreath.org","size":14105,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"refactor"}},"base":{"label":"firebreath:refactor","ref":"refactor","sha":"dcb5352bc922c259bf84a62255115bc332a2c0c2","user":{"login":"firebreath","id":498252,"avatar_url":"https://avatars.githubusercontent.com/u/498252?v=3","gravatar_id":"","url":"https://api.github.com/users/firebreath","html_url":"https://github.com/firebreath","followers_url":"https://api.github.com/users/firebreath/followers","following_url":"https://api.github.com/users/firebreath/following{/other_user}","gists_url":"https://api.github.com/users/firebreath/gists{/gist_id}","starred_url":"https://api.github.com/users/firebreath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebreath/subscriptions","organizations_url":"https://api.github.com/users/firebreath/orgs","repos_url":"https://api.github.com/users/firebreath/repos","events_url":"https://api.github.com/users/firebreath/events{/privacy}","received_events_url":"https://api.github.com/users/firebreath/received_events","type":"Organization","site_admin":false},"repo":{"id":1115370,"name":"FireBreath","full_name":"firebreath/FireBreath","owner":{"login":"firebreath","id":498252,"avatar_url":"https://avatars.githubusercontent.com/u/498252?v=3","gravatar_id":"","url":"https://api.github.com/users/firebreath","html_url":"https://github.com/firebreath","followers_url":"https://api.github.com/users/firebreath/followers","following_url":"https://api.github.com/users/firebreath/following{/other_user}","gists_url":"https://api.github.com/users/firebreath/gists{/gist_id}","starred_url":"https://api.github.com/users/firebreath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebreath/subscriptions","organizations_url":"https://api.github.com/users/firebreath/orgs","repos_url":"https://api.github.com/users/firebreath/repos","events_url":"https://api.github.com/users/firebreath/events{/privacy}","received_events_url":"https://api.github.com/users/firebreath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebreath/FireBreath","description":"Browser Plugin framework (NPAPI and ActiveX on Windows, Mac, and Linux)","fork":false,"url":"https://api.github.com/repos/firebreath/FireBreath","forks_url":"https://api.github.com/repos/firebreath/FireBreath/forks","keys_url":"https://api.github.com/repos/firebreath/FireBreath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebreath/FireBreath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebreath/FireBreath/teams","hooks_url":"https://api.github.com/repos/firebreath/FireBreath/hooks","issue_events_url":"https://api.github.com/repos/firebreath/FireBreath/issues/events{/number}","events_url":"https://api.github.com/repos/firebreath/FireBreath/events","assignees_url":"https://api.github.com/repos/firebreath/FireBreath/assignees{/user}","branches_url":"https://api.github.com/repos/firebreath/FireBreath/branches{/branch}","tags_url":"https://api.github.com/repos/firebreath/FireBreath/tags","blobs_url":"https://api.github.com/repos/firebreath/FireBreath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebreath/FireBreath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebreath/FireBreath/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebreath/FireBreath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebreath/FireBreath/statuses/{sha}","languages_url":"https://api.github.com/repos/firebreath/FireBreath/languages","stargazers_url":"https://api.github.com/repos/firebreath/FireBreath/stargazers","contributors_url":"https://api.github.com/repos/firebreath/FireBreath/contributors","subscribers_url":"https://api.github.com/repos/firebreath/FireBreath/subscribers","subscription_url":"https://api.github.com/repos/firebreath/FireBreath/subscription","commits_url":"https://api.github.com/repos/firebreath/FireBreath/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebreath/FireBreath/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebreath/FireBreath/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebreath/FireBreath/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebreath/FireBreath/contents/{+path}","compare_url":"https://api.github.com/repos/firebreath/FireBreath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebreath/FireBreath/merges","archive_url":"https://api.github.com/repos/firebreath/FireBreath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebreath/FireBreath/downloads","issues_url":"https://api.github.com/repos/firebreath/FireBreath/issues{/number}","pulls_url":"https://api.github.com/repos/firebreath/FireBreath/pulls{/number}","milestones_url":"https://api.github.com/repos/firebreath/FireBreath/milestones{/number}","notifications_url":"https://api.github.com/repos/firebreath/FireBreath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebreath/FireBreath/labels{/name}","releases_url":"https://api.github.com/repos/firebreath/FireBreath/releases{/id}","created_at":"2010-11-26T19:20:45Z","updated_at":"2015-06-24T16:21:18Z","pushed_at":"2015-06-24T18:11:20Z","git_url":"git://github.com/firebreath/FireBreath.git","ssh_url":"git@github.com:firebreath/FireBreath.git","clone_url":"https://github.com/firebreath/FireBreath.git","svn_url":"https://github.com/firebreath/FireBreath","homepage":"http://www.firebreath.org","size":16554,"stargazers_count":389,"watchers_count":389,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":6,"forks":227,"open_issues":6,"watchers":389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/154"},"html":{"href":"https://github.com/firebreath/FireBreath/pull/154"},"issue":{"href":"https://api.github.com/repos/firebreath/FireBreath/issues/154"},"comments":{"href":"https://api.github.com/repos/firebreath/FireBreath/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebreath/FireBreath/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/firebreath/FireBreath/statuses/34b5377ba337d223c8e8a71d5ee5744695452f91"}}}}