{"action":"created","comment":{"url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/comments/33168186","id":33168186,"diff_hunk":"@@ -111,6 +114,19 @@ var LazyRender = React.createClass({\n     });\n   },\n \n+  componentDidUpdate: function() {\n+    //important to update the child height in the case that the children change(example: ajax call for data)\n+    if(this.state.childHeight !== this.getChildHeight())\n+      this.setState({childHeight: this.getChildHeight()});","path":"src/LazyRender.jsx","position":39,"original_position":39,"commit_id":"e30e8ec0097482d64913769aed6f8ee0118ab1bd","original_commit_id":"e30e8ec0097482d64913769aed6f8ee0118ab1bd","user":{"login":"jkimbo","id":691952,"avatar_url":"https://avatars.githubusercontent.com/u/691952?v=3","gravatar_id":"","url":"https://api.github.com/users/jkimbo","html_url":"https://github.com/jkimbo","followers_url":"https://api.github.com/users/jkimbo/followers","following_url":"https://api.github.com/users/jkimbo/following{/other_user}","gists_url":"https://api.github.com/users/jkimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jkimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkimbo/subscriptions","organizations_url":"https://api.github.com/users/jkimbo/orgs","repos_url":"https://api.github.com/users/jkimbo/repos","events_url":"https://api.github.com/users/jkimbo/events{/privacy}","received_events_url":"https://api.github.com/users/jkimbo/received_events","type":"User","site_admin":false},"body":"Hmm guess there is no other way of doing it","created_at":"2015-06-24T16:42:47Z","updated_at":"2015-06-24T16:42:47Z","html_url":"https://github.com/onefinestay/react-lazy-render/pull/6#discussion_r33168186","pull_request_url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/comments/33168186"},"html":{"href":"https://github.com/onefinestay/react-lazy-render/pull/6#discussion_r33168186"},"pull_request":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6","id":37157847,"html_url":"https://github.com/onefinestay/react-lazy-render/pull/6","diff_url":"https://github.com/onefinestay/react-lazy-render/pull/6.diff","patch_url":"https://github.com/onefinestay/react-lazy-render/pull/6.patch","issue_url":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/6","number":6,"state":"open","locked":false,"title":"Fix Jitter","user":{"login":"tehandyb","id":1136863,"avatar_url":"https://avatars.githubusercontent.com/u/1136863?v=3","gravatar_id":"","url":"https://api.github.com/users/tehandyb","html_url":"https://github.com/tehandyb","followers_url":"https://api.github.com/users/tehandyb/followers","following_url":"https://api.github.com/users/tehandyb/following{/other_user}","gists_url":"https://api.github.com/users/tehandyb/gists{/gist_id}","starred_url":"https://api.github.com/users/tehandyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehandyb/subscriptions","organizations_url":"https://api.github.com/users/tehandyb/orgs","repos_url":"https://api.github.com/users/tehandyb/repos","events_url":"https://api.github.com/users/tehandyb/events{/privacy}","received_events_url":"https://api.github.com/users/tehandyb/received_events","type":"User","site_admin":false},"body":"The height calculation now includes margin. Also added a check to see if the children height changes so scroll calculations are good for the new children. ","created_at":"2015-06-08T14:19:35Z","updated_at":"2015-06-24T16:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59ab087a03b8d4d342382fd8c84a6ecef4cd8fc7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6/commits","review_comments_url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6/comments","review_comment_url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/6/comments","statuses_url":"https://api.github.com/repos/onefinestay/react-lazy-render/statuses/e30e8ec0097482d64913769aed6f8ee0118ab1bd","head":{"label":"BI:master","ref":"master","sha":"e30e8ec0097482d64913769aed6f8ee0118ab1bd","user":{"login":"BI","id":339060,"avatar_url":"https://avatars.githubusercontent.com/u/339060?v=3","gravatar_id":"","url":"https://api.github.com/users/BI","html_url":"https://github.com/BI","followers_url":"https://api.github.com/users/BI/followers","following_url":"https://api.github.com/users/BI/following{/other_user}","gists_url":"https://api.github.com/users/BI/gists{/gist_id}","starred_url":"https://api.github.com/users/BI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BI/subscriptions","organizations_url":"https://api.github.com/users/BI/orgs","repos_url":"https://api.github.com/users/BI/repos","events_url":"https://api.github.com/users/BI/events{/privacy}","received_events_url":"https://api.github.com/users/BI/received_events","type":"Organization","site_admin":false},"repo":{"id":36464902,"name":"react-lazy-render","full_name":"BI/react-lazy-render","owner":{"login":"BI","id":339060,"avatar_url":"https://avatars.githubusercontent.com/u/339060?v=3","gravatar_id":"","url":"https://api.github.com/users/BI","html_url":"https://github.com/BI","followers_url":"https://api.github.com/users/BI/followers","following_url":"https://api.github.com/users/BI/following{/other_user}","gists_url":"https://api.github.com/users/BI/gists{/gist_id}","starred_url":"https://api.github.com/users/BI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BI/subscriptions","organizations_url":"https://api.github.com/users/BI/orgs","repos_url":"https://api.github.com/users/BI/repos","events_url":"https://api.github.com/users/BI/events{/privacy}","received_events_url":"https://api.github.com/users/BI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BI/react-lazy-render","description":"Lazy render for (very) large lists of data","fork":true,"url":"https://api.github.com/repos/BI/react-lazy-render","forks_url":"https://api.github.com/repos/BI/react-lazy-render/forks","keys_url":"https://api.github.com/repos/BI/react-lazy-render/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BI/react-lazy-render/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BI/react-lazy-render/teams","hooks_url":"https://api.github.com/repos/BI/react-lazy-render/hooks","issue_events_url":"https://api.github.com/repos/BI/react-lazy-render/issues/events{/number}","events_url":"https://api.github.com/repos/BI/react-lazy-render/events","assignees_url":"https://api.github.com/repos/BI/react-lazy-render/assignees{/user}","branches_url":"https://api.github.com/repos/BI/react-lazy-render/branches{/branch}","tags_url":"https://api.github.com/repos/BI/react-lazy-render/tags","blobs_url":"https://api.github.com/repos/BI/react-lazy-render/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BI/react-lazy-render/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BI/react-lazy-render/git/refs{/sha}","trees_url":"https://api.github.com/repos/BI/react-lazy-render/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BI/react-lazy-render/statuses/{sha}","languages_url":"https://api.github.com/repos/BI/react-lazy-render/languages","stargazers_url":"https://api.github.com/repos/BI/react-lazy-render/stargazers","contributors_url":"https://api.github.com/repos/BI/react-lazy-render/contributors","subscribers_url":"https://api.github.com/repos/BI/react-lazy-render/subscribers","subscription_url":"https://api.github.com/repos/BI/react-lazy-render/subscription","commits_url":"https://api.github.com/repos/BI/react-lazy-render/commits{/sha}","git_commits_url":"https://api.github.com/repos/BI/react-lazy-render/git/commits{/sha}","comments_url":"https://api.github.com/repos/BI/react-lazy-render/comments{/number}","issue_comment_url":"https://api.github.com/repos/BI/react-lazy-render/issues/comments{/number}","contents_url":"https://api.github.com/repos/BI/react-lazy-render/contents/{+path}","compare_url":"https://api.github.com/repos/BI/react-lazy-render/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BI/react-lazy-render/merges","archive_url":"https://api.github.com/repos/BI/react-lazy-render/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BI/react-lazy-render/downloads","issues_url":"https://api.github.com/repos/BI/react-lazy-render/issues{/number}","pulls_url":"https://api.github.com/repos/BI/react-lazy-render/pulls{/number}","milestones_url":"https://api.github.com/repos/BI/react-lazy-render/milestones{/number}","notifications_url":"https://api.github.com/repos/BI/react-lazy-render/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BI/react-lazy-render/labels{/name}","releases_url":"https://api.github.com/repos/BI/react-lazy-render/releases{/id}","created_at":"2015-05-28T20:41:23Z","updated_at":"2015-05-28T20:41:24Z","pushed_at":"2015-06-02T17:20:55Z","git_url":"git://github.com/BI/react-lazy-render.git","ssh_url":"git@github.com:BI/react-lazy-render.git","clone_url":"https://github.com/BI/react-lazy-render.git","svn_url":"https://github.com/BI/react-lazy-render","homepage":null,"size":409,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onefinestay:master","ref":"master","sha":"390cdd4942f9f57dc26801275d4c9a5479787c74","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":27235689,"name":"react-lazy-render","full_name":"onefinestay/react-lazy-render","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/react-lazy-render","description":"Lazy render for (very) large lists of data","fork":false,"url":"https://api.github.com/repos/onefinestay/react-lazy-render","forks_url":"https://api.github.com/repos/onefinestay/react-lazy-render/forks","keys_url":"https://api.github.com/repos/onefinestay/react-lazy-render/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/react-lazy-render/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/react-lazy-render/teams","hooks_url":"https://api.github.com/repos/onefinestay/react-lazy-render/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/react-lazy-render/events","assignees_url":"https://api.github.com/repos/onefinestay/react-lazy-render/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/react-lazy-render/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/react-lazy-render/tags","blobs_url":"https://api.github.com/repos/onefinestay/react-lazy-render/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/react-lazy-render/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/react-lazy-render/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/react-lazy-render/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/react-lazy-render/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/react-lazy-render/languages","stargazers_url":"https://api.github.com/repos/onefinestay/react-lazy-render/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/react-lazy-render/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/react-lazy-render/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/react-lazy-render/subscription","commits_url":"https://api.github.com/repos/onefinestay/react-lazy-render/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/react-lazy-render/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/react-lazy-render/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/comments{/number}","contents_url":"https://api.github.com/repos/onefinestay/react-lazy-render/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/react-lazy-render/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/react-lazy-render/merges","archive_url":"https://api.github.com/repos/onefinestay/react-lazy-render/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/react-lazy-render/downloads","issues_url":"https://api.github.com/repos/onefinestay/react-lazy-render/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/react-lazy-render/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/react-lazy-render/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/react-lazy-render/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/react-lazy-render/releases{/id}","created_at":"2014-11-27T17:38:32Z","updated_at":"2015-06-24T03:15:52Z","pushed_at":"2015-06-08T14:19:37Z","git_url":"git://github.com/onefinestay/react-lazy-render.git","ssh_url":"git@github.com:onefinestay/react-lazy-render.git","clone_url":"https://github.com/onefinestay/react-lazy-render.git","svn_url":"https://github.com/onefinestay/react-lazy-render","homepage":null,"size":536,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6"},"html":{"href":"https://github.com/onefinestay/react-lazy-render/pull/6"},"issue":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/6"},"comments":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/onefinestay/react-lazy-render/statuses/e30e8ec0097482d64913769aed6f8ee0118ab1bd"}}}}