{"action":"created","comment":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/29411325","id":29411325,"diff_hunk":"@@ -0,0 +1,18 @@\n+define rjil::jiocloud::logrotate(\n+  $service,\n+  $logfile,\n+  $rotate_every = 'daily',\n+  $rotate = 60,\n+  $compress = true,\n+  $delaycompress = true,\n+  $ifempty = false,\n+) {\n+  logrotate::rule{$service:","path":"manifests/jiocloud/logrotate.pp","position":null,"original_position":10,"commit_id":"093ffde378c496b2a3dfac81715c678e91076395","original_commit_id":"45aaef88770ef7fe812fb517809a7a0c3f120128","user":{"login":"anshprat","id":333902,"avatar_url":"https://avatars.githubusercontent.com/u/333902?v=3","gravatar_id":"","url":"https://api.github.com/users/anshprat","html_url":"https://github.com/anshprat","followers_url":"https://api.github.com/users/anshprat/followers","following_url":"https://api.github.com/users/anshprat/following{/other_user}","gists_url":"https://api.github.com/users/anshprat/gists{/gist_id}","starred_url":"https://api.github.com/users/anshprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshprat/subscriptions","organizations_url":"https://api.github.com/users/anshprat/orgs","repos_url":"https://api.github.com/users/anshprat/repos","events_url":"https://api.github.com/users/anshprat/events{/privacy}","received_events_url":"https://api.github.com/users/anshprat/received_events","type":"User","site_admin":false},"body":"https://github.com/rodjek/puppet-logrotate/blob/master/manifests/rule.pp#L404  - including base with rule would be redundant ","created_at":"2015-04-30T08:30:13Z","updated_at":"2015-04-30T08:30:13Z","html_url":"https://github.com/JioCloud/puppet-rjil/pull/574#discussion_r29411325","pull_request_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574","_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/29411325"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/574#discussion_r29411325"},"pull_request":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574"}}},"pull_request":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574","id":34246094,"html_url":"https://github.com/JioCloud/puppet-rjil/pull/574","diff_url":"https://github.com/JioCloud/puppet-rjil/pull/574.diff","patch_url":"https://github.com/JioCloud/puppet-rjil/pull/574.patch","issue_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/574","number":574,"state":"open","locked":false,"title":"Logrotate cinder","user":{"login":"anshprat","id":333902,"avatar_url":"https://avatars.githubusercontent.com/u/333902?v=3","gravatar_id":"","url":"https://api.github.com/users/anshprat","html_url":"https://github.com/anshprat","followers_url":"https://api.github.com/users/anshprat/followers","following_url":"https://api.github.com/users/anshprat/following{/other_user}","gists_url":"https://api.github.com/users/anshprat/gists{/gist_id}","starred_url":"https://api.github.com/users/anshprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshprat/subscriptions","organizations_url":"https://api.github.com/users/anshprat/orgs","repos_url":"https://api.github.com/users/anshprat/repos","events_url":"https://api.github.com/users/anshprat/events{/privacy}","received_events_url":"https://api.github.com/users/anshprat/received_events","type":"User","site_admin":false},"body":"specimen for logrotate inclusion code review","created_at":"2015-04-28T09:00:14Z","updated_at":"2015-04-30T08:30:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd43e0559021214186777d255b0272d24c0c60bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574/commits","review_comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574/comments","review_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/574/comments","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/093ffde378c496b2a3dfac81715c678e91076395","head":{"label":"anshprat:logrotate_cinder","ref":"logrotate_cinder","sha":"093ffde378c496b2a3dfac81715c678e91076395","user":{"login":"anshprat","id":333902,"avatar_url":"https://avatars.githubusercontent.com/u/333902?v=3","gravatar_id":"","url":"https://api.github.com/users/anshprat","html_url":"https://github.com/anshprat","followers_url":"https://api.github.com/users/anshprat/followers","following_url":"https://api.github.com/users/anshprat/following{/other_user}","gists_url":"https://api.github.com/users/anshprat/gists{/gist_id}","starred_url":"https://api.github.com/users/anshprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshprat/subscriptions","organizations_url":"https://api.github.com/users/anshprat/orgs","repos_url":"https://api.github.com/users/anshprat/repos","events_url":"https://api.github.com/users/anshprat/events{/privacy}","received_events_url":"https://api.github.com/users/anshprat/received_events","type":"User","site_admin":false},"repo":{"id":33595371,"name":"puppet-rjil","full_name":"anshprat/puppet-rjil","owner":{"login":"anshprat","id":333902,"avatar_url":"https://avatars.githubusercontent.com/u/333902?v=3","gravatar_id":"","url":"https://api.github.com/users/anshprat","html_url":"https://github.com/anshprat","followers_url":"https://api.github.com/users/anshprat/followers","following_url":"https://api.github.com/users/anshprat/following{/other_user}","gists_url":"https://api.github.com/users/anshprat/gists{/gist_id}","starred_url":"https://api.github.com/users/anshprat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshprat/subscriptions","organizations_url":"https://api.github.com/users/anshprat/orgs","repos_url":"https://api.github.com/users/anshprat/repos","events_url":"https://api.github.com/users/anshprat/events{/privacy}","received_events_url":"https://api.github.com/users/anshprat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anshprat/puppet-rjil","description":"Puppet scripts for managing JioCloud","fork":true,"url":"https://api.github.com/repos/anshprat/puppet-rjil","forks_url":"https://api.github.com/repos/anshprat/puppet-rjil/forks","keys_url":"https://api.github.com/repos/anshprat/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anshprat/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anshprat/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/anshprat/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/anshprat/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/anshprat/puppet-rjil/events","assignees_url":"https://api.github.com/repos/anshprat/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/anshprat/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/anshprat/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/anshprat/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anshprat/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anshprat/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/anshprat/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anshprat/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/anshprat/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/anshprat/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/anshprat/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/anshprat/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/anshprat/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/anshprat/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/anshprat/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/anshprat/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/anshprat/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/anshprat/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/anshprat/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anshprat/puppet-rjil/merges","archive_url":"https://api.github.com/repos/anshprat/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anshprat/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/anshprat/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/anshprat/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/anshprat/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/anshprat/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anshprat/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/anshprat/puppet-rjil/releases{/id}","created_at":"2015-04-08T08:47:39Z","updated_at":"2015-04-27T07:29:43Z","pushed_at":"2015-04-29T09:27:36Z","git_url":"git://github.com/anshprat/puppet-rjil.git","ssh_url":"git@github.com:anshprat/puppet-rjil.git","clone_url":"https://github.com/anshprat/puppet-rjil.git","svn_url":"https://github.com/anshprat/puppet-rjil","homepage":"","size":1162,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JioCloud:master","ref":"master","sha":"1b538f672b5c208b769991bac01b20e9e1fed274","user":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16161513,"name":"puppet-rjil","full_name":"JioCloud/puppet-rjil","owner":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JioCloud/puppet-rjil","description":"Puppet scripts for managing JioCloud","fork":false,"url":"https://api.github.com/repos/JioCloud/puppet-rjil","forks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/forks","keys_url":"https://api.github.com/repos/JioCloud/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JioCloud/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JioCloud/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/events","assignees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/JioCloud/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/JioCloud/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/JioCloud/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JioCloud/puppet-rjil/merges","archive_url":"https://api.github.com/repos/JioCloud/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JioCloud/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/JioCloud/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/JioCloud/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JioCloud/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/JioCloud/puppet-rjil/releases{/id}","created_at":"2014-01-23T03:45:55Z","updated_at":"2015-04-23T18:05:04Z","pushed_at":"2015-04-30T07:15:34Z","git_url":"git://github.com/JioCloud/puppet-rjil.git","ssh_url":"git@github.com:JioCloud/puppet-rjil.git","clone_url":"https://github.com/JioCloud/puppet-rjil.git","svn_url":"https://github.com/JioCloud/puppet-rjil","homepage":"","size":8018,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":126,"forks":30,"open_issues":126,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/574"},"issue":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/574"},"comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/093ffde378c496b2a3dfac81715c678e91076395"}}}}