{"action":"created","issue":{"url":"https://api.github.com/repos/robconery/massive-js/issues/56","labels_url":"https://api.github.com/repos/robconery/massive-js/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/robconery/massive-js/issues/56/comments","events_url":"https://api.github.com/repos/robconery/massive-js/issues/56/events","html_url":"https://github.com/robconery/massive-js/issues/56","id":71580256,"number":56,"title":"path.parse is only available in node 0.12","user":{"login":"paulovieira","id":2184309,"avatar_url":"https://avatars.githubusercontent.com/u/2184309?v=3","gravatar_id":"","url":"https://api.github.com/users/paulovieira","html_url":"https://github.com/paulovieira","followers_url":"https://api.github.com/users/paulovieira/followers","following_url":"https://api.github.com/users/paulovieira/following{/other_user}","gists_url":"https://api.github.com/users/paulovieira/gists{/gist_id}","starred_url":"https://api.github.com/users/paulovieira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulovieira/subscriptions","organizations_url":"https://api.github.com/users/paulovieira/orgs","repos_url":"https://api.github.com/users/paulovieira/repos","events_url":"https://api.github.com/users/paulovieira/events{/privacy}","received_events_url":"https://api.github.com/users/paulovieira/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-28T12:46:43Z","updated_at":"2015-04-29T08:00:15Z","closed_at":null,"body":"Massive uses `path.parse` in the `walkSqlFiles` helper function. However this method is only available in node 0.12 (and not in 0.10). \r\n\r\nThis means that the users can't use the \"SQL Files as Functions\" functionality. If I place a .sql file in the \"db\" directory, massive will crash immediately with:\r\n\r\n```\r\nTypeError: Object #<Object> has no method 'parse'\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/robconery/massive-js/issues/comments/97339005","html_url":"https://github.com/robconery/massive-js/issues/56#issuecomment-97339005","issue_url":"https://api.github.com/repos/robconery/massive-js/issues/56","id":97339005,"user":{"login":"robconery","id":78586,"avatar_url":"https://avatars.githubusercontent.com/u/78586?v=3","gravatar_id":"","url":"https://api.github.com/users/robconery","html_url":"https://github.com/robconery","followers_url":"https://api.github.com/users/robconery/followers","following_url":"https://api.github.com/users/robconery/following{/other_user}","gists_url":"https://api.github.com/users/robconery/gists{/gist_id}","starred_url":"https://api.github.com/users/robconery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robconery/subscriptions","organizations_url":"https://api.github.com/users/robconery/orgs","repos_url":"https://api.github.com/users/robconery/repos","events_url":"https://api.github.com/users/robconery/events{/privacy}","received_events_url":"https://api.github.com/users/robconery/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T08:00:15Z","updated_at":"2015-04-29T08:00:15Z","body":"Thank you :) and yes, that would be lovely (a PR)\n\n\n\n> On Apr 29, 2015, at 03:42, Paulo Vieira <notifications@github.com> wrote:\n> \n> I note a bit of irony in your reply, which is probably justified given the lack of clarity in my message.\n> \n> Obviously this is only a \"problem\" for those who don't want (or can't) upgrade from 0.10 to 0.12. But given that 0.12 is only a few weeks old and people have had apps in production using 0.10 for a long time, I would say the percentage of developers who would like to try massive and are using 0.10 is quite large.\n> \n> I would suggest at least adding the \"engines\" property to package.json (or simply adding the 0.12 requirement to the readme). If that information is not present, I would assume the module works with 0.10.\n> \n> By the way, the parse-filepath module seems to be a good substitute for path.parse:\n> https://www.npmjs.com/package/parse-filepath\n> \n> If there's interest, I'm happy to submit a PR with this change, thus making massive compatible with 0.10 (hopefully).\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}