{"action":"opened","issue":{"url":"https://api.github.com/repos/bmeaut/grainautline/issues/99","labels_url":"https://api.github.com/repos/bmeaut/grainautline/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/bmeaut/grainautline/issues/99/comments","events_url":"https://api.github.com/repos/bmeaut/grainautline/issues/99/events","html_url":"https://github.com/bmeaut/grainautline/issues/99","id":115676529,"number":99,"title":"ActiveContours C++ warnings","user":{"login":"szotsaki","id":4254450,"avatar_url":"https://avatars.githubusercontent.com/u/4254450?v=3","gravatar_id":"","url":"https://api.github.com/users/szotsaki","html_url":"https://github.com/szotsaki","followers_url":"https://api.github.com/users/szotsaki/followers","following_url":"https://api.github.com/users/szotsaki/following{/other_user}","gists_url":"https://api.github.com/users/szotsaki/gists{/gist_id}","starred_url":"https://api.github.com/users/szotsaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szotsaki/subscriptions","organizations_url":"https://api.github.com/users/szotsaki/orgs","repos_url":"https://api.github.com/users/szotsaki/repos","events_url":"https://api.github.com/users/szotsaki/events{/privacy}","received_events_url":"https://api.github.com/users/szotsaki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ollosg","id":7388004,"avatar_url":"https://avatars.githubusercontent.com/u/7388004?v=3","gravatar_id":"","url":"https://api.github.com/users/ollosg","html_url":"https://github.com/ollosg","followers_url":"https://api.github.com/users/ollosg/followers","following_url":"https://api.github.com/users/ollosg/following{/other_user}","gists_url":"https://api.github.com/users/ollosg/gists{/gist_id}","starred_url":"https://api.github.com/users/ollosg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollosg/subscriptions","organizations_url":"https://api.github.com/users/ollosg/orgs","repos_url":"https://api.github.com/users/ollosg/repos","events_url":"https://api.github.com/users/ollosg/events{/privacy}","received_events_url":"https://api.github.com/users/ollosg/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-11-07T16:39:52Z","updated_at":"2015-11-07T16:39:52Z","closed_at":null,"body":"Please, fix the following C++ warnings generated by `cppcheck`:\r\n\r\n```\r\n[MarbleCommon/ActiveContours/BalloonForce.cpp:19]: (performance) Prefer prefix ++/-- operators for non-primitive types.\r\n[MarbleCommon/ActiveContours/DarknessForce.cpp:28]: (style) Clarify calculation precedence for '%' and '?'.\r\n[MarbleCommon/ActiveContours/EdgeForce.cpp:50]: (style) Clarify calculation precedence for '%' and '?'.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::mu' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::deltaTFactor' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::edgeMapType' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::deltaT' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::r' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::maxIter' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (warning) Member variable 'GVFForce::iterThreshold' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/snake.cpp:30]: (performance) Variable 'snakePoints' is assigned in constructor body. Consider performing initialization in initialization list.\r\n[MarbleCommon/ActiveContours/GVFForce.h:35]: (style) Class 'GVFForce' has a constructor with 1 argument that is not explicit.\r\n[MarbleCommon/ActiveContours/GVFForce.cpp:182]: (style) Clarify calculation precedence for '%' and '?'.\r\n[MarbleCommon/ActiveContours/GVFForce.cpp:205]: (style) Clarify calculation precedence for '%' and '?'.\r\n[MarbleCommon/ActiveContours/NetworkSnake.h:86]: (warning) Member variable 'NetworkSnakeIterationDescriptor::junctionPointIndex' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/NetworkSnake.h:86]: (warning) Member variable 'NetworkSnakeIterationDescriptor::segmentIndex' is not initialized in the constructor.\r\n[MarbleCommon/ActiveContours/NetworkSnake.h:86]: (warning) Member variable 'NetworkSnakeIterationDescriptor::segmentPointIndex' is not initialized in the constructor.\r\n[MarbleCommon/Processors/ActiveContoursDynamic.cpp:39]: (performance) Prefer prefix ++/-- operators for non-primitive types.\r\n[MarbleCommon/Processors/ActiveContoursNormalizedInnerForces.cpp:38]: (style) The scope of the variable 'diffX' can be reduced.\r\n[MarbleCommon/Processors/ActiveContoursNormalizedInnerForces.cpp:39]: (style) The scope of the variable 'diffY' can be reduced.\r\n[MarbleCommon/Processors/ActiveContoursNormalizedInnerForces.cpp:40]: (style) The scope of the variable 'length' can be reduced.\r\n[MarbleCommon/Processors/ActiveContoursNetworkSnake.cpp:26]: (style) Variable 'secondNeighbors' is assigned a value that is never used.\r\n```\r\n\r\nAdditionally, the following C++ warnings exist generated by GCC:\r\n\r\n```\r\n../../MarbleCommon/ActiveContours/GVFForce.cpp: In member function 'void GVFForce::calculateEdgeMap()':\r\n../../MarbleCommon/ActiveContours/GVFForce.cpp:124:12: warning: switch missing default case [-Wswitch-default]\r\n     switch (edgeMapType)\r\n            ^\r\n\r\n../../MarbleCommon/Processors/ActiveContoursProcessor.cpp:261:63: warning: unused parameter 'psd' [-Wunused-parameter]\r\n bool ActiveContoursProcessor::Step(ProcessingStateDescriptor &psd)\r\n                                                               ^\r\n```"}}