{"action":"created","issue":{"url":"https://api.github.com/repos/contextproject/discover/issues/41","labels_url":"https://api.github.com/repos/contextproject/discover/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/contextproject/discover/issues/41/comments","events_url":"https://api.github.com/repos/contextproject/discover/issues/41/events","html_url":"https://github.com/contextproject/discover/pull/41","id":85087468,"number":41,"title":"Number of splits","user":{"login":"Tomas2h","id":5990879,"avatar_url":"https://avatars.githubusercontent.com/u/5990879?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomas2h","html_url":"https://github.com/Tomas2h","followers_url":"https://api.github.com/users/Tomas2h/followers","following_url":"https://api.github.com/users/Tomas2h/following{/other_user}","gists_url":"https://api.github.com/users/Tomas2h/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomas2h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomas2h/subscriptions","organizations_url":"https://api.github.com/users/Tomas2h/orgs","repos_url":"https://api.github.com/users/Tomas2h/repos","events_url":"https://api.github.com/users/Tomas2h/events{/privacy}","received_events_url":"https://api.github.com/users/Tomas2h/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-04T12:56:05Z","updated_at":"2015-06-04T18:02:17Z","closed_at":"2015-06-04T18:02:17Z","pull_request":{"url":"https://api.github.com/repos/contextproject/discover/pulls/41","html_url":"https://github.com/contextproject/discover/pull/41","diff_url":"https://github.com/contextproject/discover/pull/41.diff","patch_url":"https://github.com/contextproject/discover/pull/41.patch"},"body":"This is a extra feature to choose the amount of mix splits that you want when pressing mixsplitter"},"comment":{"url":"https://api.github.com/repos/contextproject/discover/issues/comments/108992987","html_url":"https://github.com/contextproject/discover/pull/41#issuecomment-108992987","issue_url":"https://api.github.com/repos/contextproject/discover/issues/41","id":108992987,"user":{"login":"StefanBoodt","id":5946814,"avatar_url":"https://avatars.githubusercontent.com/u/5946814?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanBoodt","html_url":"https://github.com/StefanBoodt","followers_url":"https://api.github.com/users/StefanBoodt/followers","following_url":"https://api.github.com/users/StefanBoodt/following{/other_user}","gists_url":"https://api.github.com/users/StefanBoodt/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanBoodt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanBoodt/subscriptions","organizations_url":"https://api.github.com/users/StefanBoodt/orgs","repos_url":"https://api.github.com/users/StefanBoodt/repos","events_url":"https://api.github.com/users/StefanBoodt/events{/privacy}","received_events_url":"https://api.github.com/users/StefanBoodt/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T18:02:17Z","updated_at":"2015-06-04T18:02:17Z","body":"I honestly disagree with Daan. I do not think that duplication is good. Please put the following in a method\r\n\r\n+            Map<String, List<Integer>> map = new TreeMap<String, List<Integer>>();\r\n+            map.put(\"response\", list);\r\n+            JsonNode response = mapper.valueToTree(map);\r\n+            return ok(response);\r\n\r\nand call it from two different methods. The split should be different for both methods but that is for later.\r\n\r\nSecond the message of \"Keep the box empty for the default amount of splits\" is incorrect. If the box is empty we should run the version without limit.\r\n\r\nThird I highly disagree on merging an incomplete branch. You altered the GUI for a function that does not yet exist. This is confusing for us and any user that uses the System. Please alter the Splitter Interface and include a splitter(int n) method. Fixing this method is not your job it is mine, but I suggest you do not include new functions in the GUI that result in nothing new. Even a default implementation of the method would do, such as one that checks if the number is smaller than the size and does sublist when it is. Then test this method and you have written more code and your GUI function does something new. This is also good for your personal report.\r\n\r\nFor now I reject this request."}}