{"action":"created","issue":{"url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2876","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2876/labels{/name}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2876/comments","events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2876/events","html_url":"https://github.com/inveniosoftware/invenio/issues/2876","id":60787335,"number":2876,"title":"RFC simplification of git signatures","user":{"login":"lnielsen","id":1698163,"avatar_url":"https://avatars.githubusercontent.com/u/1698163?v=3","gravatar_id":"","url":"https://api.github.com/users/lnielsen","html_url":"https://github.com/lnielsen","followers_url":"https://api.github.com/users/lnielsen/followers","following_url":"https://api.github.com/users/lnielsen/following{/other_user}","gists_url":"https://api.github.com/users/lnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnielsen/subscriptions","organizations_url":"https://api.github.com/users/lnielsen/orgs","repos_url":"https://api.github.com/users/lnielsen/repos","events_url":"https://api.github.com/users/lnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/lnielsen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/inveniosoftware/invenio/labels/c_general","name":"c_general","color":"ededed"},{"url":"https://api.github.com/repos/inveniosoftware/invenio/labels/RFC","name":"RFC","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-12T08:48:13Z","updated_at":"2015-03-12T10:47:19Z","closed_at":null,"body":"# Problem\r\n\r\nRelated to RFC #2856.\r\n\r\nCurrently we have the following commit message directives (see [here](http://invenio.readthedocs.org/en/latest/developers/git-workflow.html#r2b-commit-message-qa-review-directives)):\r\n\r\n```\r\nSigned-off-by\r\nReported-by\r\nCo-authored-by\r\nImproved-by\r\nAcked-by\r\nTested-by\r\nReviewed-by\r\n```\r\n\r\nYou can broadly categorise them in two types:\r\n* directives related to giving credit (co-authored-by, reported-by)\r\n* directives related to quality stamping (reviewed-by, signed-off-by)\r\n\r\nFor new contributors it's not easy to know which to use when, and additionally it's not clear if the differences in signatures is actually used.\r\n\r\n# Proposal\r\n\r\nSimplify the possible commit directives to:\r\n\r\n* ``Signed-off-by`` - (Related to quality) Used by authors, testers and reviewers to sign that a given commit adheres to Invenio's quality standards and to the best of their knowledge is ready to be merged. \r\n* ``Co-authored-by`` - (Related to credit) Used to acknowledge significant co-authorship including when a person significantly improves the code after the original author left.\r\n\r\nand exceptionally:\r\n\r\n* ``Reported-by`` - Use only in exceptional circumstances, when there's no GitHub issue (could happen when an external user reports a bug report via email, and not issue was created).\r\n\r\nNote: Tester/reviewers should only sign commits they can fully confirm the quality off. Blanco signing of commits may negatively impact their merit and credibility. For commits to be **considered** for integration a minimum of two ``Signed-off-by`` signatures are needed. That a commit is considered for integration, does not mean the commit actually will be integrated. "},"comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments/78457951","html_url":"https://github.com/inveniosoftware/invenio/issues/2876#issuecomment-78457951","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2876","id":78457951,"user":{"login":"lnielsen","id":1698163,"avatar_url":"https://avatars.githubusercontent.com/u/1698163?v=3","gravatar_id":"","url":"https://api.github.com/users/lnielsen","html_url":"https://github.com/lnielsen","followers_url":"https://api.github.com/users/lnielsen/followers","following_url":"https://api.github.com/users/lnielsen/following{/other_user}","gists_url":"https://api.github.com/users/lnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnielsen/subscriptions","organizations_url":"https://api.github.com/users/lnielsen/orgs","repos_url":"https://api.github.com/users/lnielsen/repos","events_url":"https://api.github.com/users/lnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/lnielsen/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T10:47:19Z","updated_at":"2015-03-12T10:47:19Z","body":"> > additionally it's not clear if the differences in signatures is actually used.\r\n\r\n> This is the core of the RFC to me. \r\n\r\nI agree this is the core of the RFC. Do we actually use it. In my opinion I don't think we use it, or if we ever used it, the added value is so little that it does not justify the added complexity. \r\n\r\n> > For new contributors it's not easy to know which to use when\r\n\r\n> This is not a problem in my eyes due to three reasons.\r\n\r\nWhile I agree that signature are documented, that we use standard signatures and development tools can easily be customised to add, I don't agree that it is not an issue to be considered (e.g. signature documentation is linked from CONTRIBUTING.rst, but otherwise hidden towards the bottom of a 19-page document). \r\n\r\nI believe we need to lower the friction for contributing to Invenio, and any complexity that can be removed from the process contributes overall to lower the entry barrier. I'm not saying that regular contributors (e.g. CERN developers) should not learn to do things properly, just that as a first-time contributor you should feel encouraged to continue contributing  (and this independently of if you are a super programmer or a newbie)."}}