{"action":"closed","number":8431,"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431","id":37110132,"html_url":"https://github.com/OpenRA/OpenRA/pull/8431","diff_url":"https://github.com/OpenRA/OpenRA/pull/8431.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/8431.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8431","number":8431,"state":"closed","locked":false,"title":"A few minor portability fixes","user":{"login":"jbeich","id":11153579,"avatar_url":"https://avatars.githubusercontent.com/u/11153579?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeich","html_url":"https://github.com/jbeich","followers_url":"https://api.github.com/users/jbeich/followers","following_url":"https://api.github.com/users/jbeich/following{/other_user}","gists_url":"https://api.github.com/users/jbeich/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeich/subscriptions","organizations_url":"https://api.github.com/users/jbeich/orgs","repos_url":"https://api.github.com/users/jbeich/repos","events_url":"https://api.github.com/users/jbeich/events{/privacy}","received_events_url":"https://api.github.com/users/jbeich/received_events","type":"User","site_admin":false},"body":"An attempt to eliminate some local changes in FreeBSD port. Unix desktop includes the following systems. Adding ifdefs for them all is kinda overkill, so let's simplify instead.\r\n- Linux except Android\r\n- Bitrig, DragonFly, FreeBSD, MirBSD, NetBSD, OpenBSD\r\n- Solaris-based systems\r\n- GNU/kFreeBSD\r\n- GNU/Hurd (not sure if it can do OpenGL 2.0)\r\n\r\nTested with `gmake dependencies` and\r\n```diff\r\nIndex: games/openra/Makefile\r\n===================================================================\r\n--- games/openra/Makefile\t(revision 387370)\r\n+++ games/openra/Makefile\t(working copy)\r\n@@ -82,10 +82,8 @@ post-patch:\r\n \t\t${MV} -v ${WRKDIR}/$${f#*/} ${WRKSRC}/thirdparty; \\\r\n \tdone\r\n \r\n-\t${REINPLACE_CMD} -e 's/Linux/${OPSYS}/' \\\r\n-\t\t-e '/CP_R/s,hicolor/,hicolor,' \\\r\n+\t${REINPLACE_CMD} \\\r\n \t\t-e '/fetch-thirdparty-deps/d' \\\r\n-\t\t-e 's/crashdialog/gamemonitor/' \\\r\n \t\t-e '/echo/!s/\t@/\t/' \\\r\n \t\t-e '/^mods:/s/$$/ version/' \\\r\n \t\t-e '/^docs:/s/$$/ all/' \\\r\n@@ -96,9 +94,6 @@ post-patch:\r\n \t${SED} 's/@LIBLUA51@/liblua-${LUA_VER}.so/' \\\r\n \t\t${WRKSRC}/thirdparty/Eluant.dll.config.in \\\r\n \t\t>${WRKSRC}/Eluant.dll.config\r\n-# DragonFly lacks BSD suffix\r\n-\t${REINPLACE_CMD} -e 's/\"BSD\"/\"${OPSYS}\"/' \\\r\n-\t\t${WRKSRC}/OpenRA.Game/Platform.cs\r\n \r\n post-build:\r\n .if ${PORT_OPTIONS:MDOCS}\r\n```","created_at":"2015-06-07T17:29:30Z","updated_at":"2015-06-09T20:53:52Z","closed_at":"2015-06-09T20:53:52Z","merged_at":"2015-06-09T20:53:52Z","merge_commit_sha":"be2345fe8bf1e49f5b58fc044bcde0a7085f419d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8431/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/fc7edb536da10cf7cfa1b0c2ed80cc01d44b24df","head":{"label":"jbeich:unix_quirks","ref":"unix_quirks","sha":"fc7edb536da10cf7cfa1b0c2ed80cc01d44b24df","user":{"login":"jbeich","id":11153579,"avatar_url":"https://avatars.githubusercontent.com/u/11153579?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeich","html_url":"https://github.com/jbeich","followers_url":"https://api.github.com/users/jbeich/followers","following_url":"https://api.github.com/users/jbeich/following{/other_user}","gists_url":"https://api.github.com/users/jbeich/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeich/subscriptions","organizations_url":"https://api.github.com/users/jbeich/orgs","repos_url":"https://api.github.com/users/jbeich/repos","events_url":"https://api.github.com/users/jbeich/events{/privacy}","received_events_url":"https://api.github.com/users/jbeich/received_events","type":"User","site_admin":false},"repo":{"id":37023001,"name":"OpenRA","full_name":"jbeich/OpenRA","owner":{"login":"jbeich","id":11153579,"avatar_url":"https://avatars.githubusercontent.com/u/11153579?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeich","html_url":"https://github.com/jbeich","followers_url":"https://api.github.com/users/jbeich/followers","following_url":"https://api.github.com/users/jbeich/following{/other_user}","gists_url":"https://api.github.com/users/jbeich/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeich/subscriptions","organizations_url":"https://api.github.com/users/jbeich/orgs","repos_url":"https://api.github.com/users/jbeich/repos","events_url":"https://api.github.com/users/jbeich/events{/privacy}","received_events_url":"https://api.github.com/users/jbeich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbeich/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/jbeich/OpenRA","forks_url":"https://api.github.com/repos/jbeich/OpenRA/forks","keys_url":"https://api.github.com/repos/jbeich/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbeich/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbeich/OpenRA/teams","hooks_url":"https://api.github.com/repos/jbeich/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/jbeich/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/jbeich/OpenRA/events","assignees_url":"https://api.github.com/repos/jbeich/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/jbeich/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/jbeich/OpenRA/tags","blobs_url":"https://api.github.com/repos/jbeich/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbeich/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbeich/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbeich/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbeich/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/jbeich/OpenRA/languages","stargazers_url":"https://api.github.com/repos/jbeich/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/jbeich/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/jbeich/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/jbeich/OpenRA/subscription","commits_url":"https://api.github.com/repos/jbeich/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbeich/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbeich/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbeich/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbeich/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/jbeich/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbeich/OpenRA/merges","archive_url":"https://api.github.com/repos/jbeich/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbeich/OpenRA/downloads","issues_url":"https://api.github.com/repos/jbeich/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/jbeich/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/jbeich/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/jbeich/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbeich/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/jbeich/OpenRA/releases{/id}","created_at":"2015-06-07T16:15:08Z","updated_at":"2015-06-07T16:15:14Z","pushed_at":"2015-06-07T17:05:13Z","git_url":"git://github.com/jbeich/OpenRA.git","ssh_url":"git@github.com:jbeich/OpenRA.git","clone_url":"https://github.com/jbeich/OpenRA.git","svn_url":"https://github.com/jbeich/OpenRA","homepage":"http://www.openra.net","size":88175,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"dbc3d28c1ababb80b475059d81715a7aa43a3702","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-06-09T11:59:52Z","pushed_at":"2015-06-09T20:53:52Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":175407,"stargazers_count":1952,"watchers_count":1952,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"open_issues_count":825,"forks":700,"open_issues":825,"watchers":1952,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8431"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8431"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8431/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8431/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/fc7edb536da10cf7cfa1b0c2ed80cc01d44b24df"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obrakmann","id":4331210,"avatar_url":"https://avatars.githubusercontent.com/u/4331210?v=3","gravatar_id":"","url":"https://api.github.com/users/obrakmann","html_url":"https://github.com/obrakmann","followers_url":"https://api.github.com/users/obrakmann/followers","following_url":"https://api.github.com/users/obrakmann/following{/other_user}","gists_url":"https://api.github.com/users/obrakmann/gists{/gist_id}","starred_url":"https://api.github.com/users/obrakmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrakmann/subscriptions","organizations_url":"https://api.github.com/users/obrakmann/orgs","repos_url":"https://api.github.com/users/obrakmann/repos","events_url":"https://api.github.com/users/obrakmann/events{/privacy}","received_events_url":"https://api.github.com/users/obrakmann/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":8,"deletions":15,"changed_files":2}}