{"action":"created","comment":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/26902901","id":26902901,"diff_hunk":"@@ -60,6 +64,10 @@ where:\n - ``$user_guid`` Is the user you want to retrieve these for (defaults to the currently logged in user)\n - ``$plugin_name`` Is the name of the plugin (detected if run from within a plugin)\n \n+.. note::\n+\n+   Settings stored as an array will be returned as the serialized value.  Developers are expected to unserialize such settings on retrieval.","path":"docs/guides/settings.rst","position":17,"original_position":17,"commit_id":"1a26d72d59bf7ad2523cfaa7744a07088aab9e15","original_commit_id":"1a26d72d59bf7ad2523cfaa7744a07088aab9e15","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"body":"Devs shouldn't have to guess which strings are serialized data structures. JSON seems less bad for this.\r\n\r\nBad for security: This lets the client dictate the storage model and doesn't validate the value before serialization.","created_at":"2015-03-22T13:12:30Z","updated_at":"2015-03-22T13:12:30Z","html_url":"https://github.com/Elgg/Elgg/pull/8094#discussion_r26902901","pull_request_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8094","_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments/26902901"},"html":{"href":"https://github.com/Elgg/Elgg/pull/8094#discussion_r26902901"},"pull_request":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8094"}}},"pull_request":{"url":"https://api.github.com/repos/Elgg/Elgg/pulls/8094","id":31682919,"html_url":"https://github.com/Elgg/Elgg/pull/8094","diff_url":"https://github.com/Elgg/Elgg/pull/8094.diff","patch_url":"https://github.com/Elgg/Elgg/pull/8094.patch","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8094","number":8094,"state":"open","locked":false,"title":"feature(settings): serialize arrays passed as plugin/user settings by de...","user":{"login":"beck24","id":738363,"avatar_url":"https://avatars.githubusercontent.com/u/738363?v=3","gravatar_id":"","url":"https://api.github.com/users/beck24","html_url":"https://github.com/beck24","followers_url":"https://api.github.com/users/beck24/followers","following_url":"https://api.github.com/users/beck24/following{/other_user}","gists_url":"https://api.github.com/users/beck24/gists{/gist_id}","starred_url":"https://api.github.com/users/beck24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beck24/subscriptions","organizations_url":"https://api.github.com/users/beck24/orgs","repos_url":"https://api.github.com/users/beck24/repos","events_url":"https://api.github.com/users/beck24/events{/privacy}","received_events_url":"https://api.github.com/users/beck24/received_events","type":"User","site_admin":false},"body":"...fault\r\n\r\nAllows developers to use arrays in plugin settings/user settings with the magic $params system and have it stored as a serialized string\r\n\r\nFixes #8081","created_at":"2015-03-22T04:34:57Z","updated_at":"2015-03-22T13:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a56e83fb21840de19a8e740ca156411af25b7f07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8094/commits","review_comments_url":"https://api.github.com/repos/Elgg/Elgg/pulls/8094/comments","review_comment_url":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8094/comments","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/1a26d72d59bf7ad2523cfaa7744a07088aab9e15","head":{"label":"beck24:8081-plugin-settings","ref":"8081-plugin-settings","sha":"1a26d72d59bf7ad2523cfaa7744a07088aab9e15","user":{"login":"beck24","id":738363,"avatar_url":"https://avatars.githubusercontent.com/u/738363?v=3","gravatar_id":"","url":"https://api.github.com/users/beck24","html_url":"https://github.com/beck24","followers_url":"https://api.github.com/users/beck24/followers","following_url":"https://api.github.com/users/beck24/following{/other_user}","gists_url":"https://api.github.com/users/beck24/gists{/gist_id}","starred_url":"https://api.github.com/users/beck24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beck24/subscriptions","organizations_url":"https://api.github.com/users/beck24/orgs","repos_url":"https://api.github.com/users/beck24/repos","events_url":"https://api.github.com/users/beck24/events{/privacy}","received_events_url":"https://api.github.com/users/beck24/received_events","type":"User","site_admin":false},"repo":{"id":9264122,"name":"Elgg","full_name":"beck24/Elgg","owner":{"login":"beck24","id":738363,"avatar_url":"https://avatars.githubusercontent.com/u/738363?v=3","gravatar_id":"","url":"https://api.github.com/users/beck24","html_url":"https://github.com/beck24","followers_url":"https://api.github.com/users/beck24/followers","following_url":"https://api.github.com/users/beck24/following{/other_user}","gists_url":"https://api.github.com/users/beck24/gists{/gist_id}","starred_url":"https://api.github.com/users/beck24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beck24/subscriptions","organizations_url":"https://api.github.com/users/beck24/orgs","repos_url":"https://api.github.com/users/beck24/repos","events_url":"https://api.github.com/users/beck24/events{/privacy}","received_events_url":"https://api.github.com/users/beck24/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beck24/Elgg","description":"A social networking engine","fork":true,"url":"https://api.github.com/repos/beck24/Elgg","forks_url":"https://api.github.com/repos/beck24/Elgg/forks","keys_url":"https://api.github.com/repos/beck24/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beck24/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beck24/Elgg/teams","hooks_url":"https://api.github.com/repos/beck24/Elgg/hooks","issue_events_url":"https://api.github.com/repos/beck24/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/beck24/Elgg/events","assignees_url":"https://api.github.com/repos/beck24/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/beck24/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/beck24/Elgg/tags","blobs_url":"https://api.github.com/repos/beck24/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beck24/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beck24/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/beck24/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beck24/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/beck24/Elgg/languages","stargazers_url":"https://api.github.com/repos/beck24/Elgg/stargazers","contributors_url":"https://api.github.com/repos/beck24/Elgg/contributors","subscribers_url":"https://api.github.com/repos/beck24/Elgg/subscribers","subscription_url":"https://api.github.com/repos/beck24/Elgg/subscription","commits_url":"https://api.github.com/repos/beck24/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/beck24/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/beck24/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/beck24/Elgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/beck24/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/beck24/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beck24/Elgg/merges","archive_url":"https://api.github.com/repos/beck24/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beck24/Elgg/downloads","issues_url":"https://api.github.com/repos/beck24/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/beck24/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/beck24/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/beck24/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beck24/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/beck24/Elgg/releases{/id}","created_at":"2013-04-06T17:56:50Z","updated_at":"2014-06-22T23:53:09Z","pushed_at":"2015-03-22T09:47:43Z","git_url":"git://github.com/beck24/Elgg.git","ssh_url":"git@github.com:beck24/Elgg.git","clone_url":"https://github.com/beck24/Elgg.git","svn_url":"https://github.com/beck24/Elgg","homepage":"http://elgg.org","size":38417,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Elgg:1.x","ref":"1.x","sha":"8655e4a105a8b456813e8f6d66252ca7ec330fc5","user":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"repo":{"id":299271,"name":"Elgg","full_name":"Elgg/Elgg","owner":{"login":"Elgg","id":79167,"avatar_url":"https://avatars.githubusercontent.com/u/79167?v=3","gravatar_id":"","url":"https://api.github.com/users/Elgg","html_url":"https://github.com/Elgg","followers_url":"https://api.github.com/users/Elgg/followers","following_url":"https://api.github.com/users/Elgg/following{/other_user}","gists_url":"https://api.github.com/users/Elgg/gists{/gist_id}","starred_url":"https://api.github.com/users/Elgg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elgg/subscriptions","organizations_url":"https://api.github.com/users/Elgg/orgs","repos_url":"https://api.github.com/users/Elgg/repos","events_url":"https://api.github.com/users/Elgg/events{/privacy}","received_events_url":"https://api.github.com/users/Elgg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elgg/Elgg","description":"A social networking engine","fork":false,"url":"https://api.github.com/repos/Elgg/Elgg","forks_url":"https://api.github.com/repos/Elgg/Elgg/forks","keys_url":"https://api.github.com/repos/Elgg/Elgg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elgg/Elgg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elgg/Elgg/teams","hooks_url":"https://api.github.com/repos/Elgg/Elgg/hooks","issue_events_url":"https://api.github.com/repos/Elgg/Elgg/issues/events{/number}","events_url":"https://api.github.com/repos/Elgg/Elgg/events","assignees_url":"https://api.github.com/repos/Elgg/Elgg/assignees{/user}","branches_url":"https://api.github.com/repos/Elgg/Elgg/branches{/branch}","tags_url":"https://api.github.com/repos/Elgg/Elgg/tags","blobs_url":"https://api.github.com/repos/Elgg/Elgg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elgg/Elgg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elgg/Elgg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elgg/Elgg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elgg/Elgg/statuses/{sha}","languages_url":"https://api.github.com/repos/Elgg/Elgg/languages","stargazers_url":"https://api.github.com/repos/Elgg/Elgg/stargazers","contributors_url":"https://api.github.com/repos/Elgg/Elgg/contributors","subscribers_url":"https://api.github.com/repos/Elgg/Elgg/subscribers","subscription_url":"https://api.github.com/repos/Elgg/Elgg/subscription","commits_url":"https://api.github.com/repos/Elgg/Elgg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elgg/Elgg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elgg/Elgg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elgg/Elgg/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elgg/Elgg/contents/{+path}","compare_url":"https://api.github.com/repos/Elgg/Elgg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elgg/Elgg/merges","archive_url":"https://api.github.com/repos/Elgg/Elgg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elgg/Elgg/downloads","issues_url":"https://api.github.com/repos/Elgg/Elgg/issues{/number}","pulls_url":"https://api.github.com/repos/Elgg/Elgg/pulls{/number}","milestones_url":"https://api.github.com/repos/Elgg/Elgg/milestones{/number}","notifications_url":"https://api.github.com/repos/Elgg/Elgg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elgg/Elgg/labels{/name}","releases_url":"https://api.github.com/repos/Elgg/Elgg/releases{/id}","created_at":"2009-09-06T17:10:11Z","updated_at":"2015-03-19T10:32:48Z","pushed_at":"2015-03-22T09:47:44Z","git_url":"git://github.com/Elgg/Elgg.git","ssh_url":"git@github.com:Elgg/Elgg.git","clone_url":"https://github.com/Elgg/Elgg.git","svn_url":"https://github.com/Elgg/Elgg","homepage":"http://elgg.org","size":73754,"stargazers_count":688,"watchers_count":688,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":421,"mirror_url":null,"open_issues_count":747,"forks":421,"open_issues":747,"watchers":688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8094"},"html":{"href":"https://github.com/Elgg/Elgg/pull/8094"},"issue":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8094"},"comments":{"href":"https://api.github.com/repos/Elgg/Elgg/issues/8094/comments"},"review_comments":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8094/comments"},"review_comment":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elgg/Elgg/pulls/8094/commits"},"statuses":{"href":"https://api.github.com/repos/Elgg/Elgg/statuses/1a26d72d59bf7ad2523cfaa7744a07088aab9e15"}}}}