{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/23332964","id":23332964,"diff_hunk":"@@ -9,6 +9,20 @@\n       apiService.util.setTitle('Roster Photos');\n     }\n \n+    $scope.studentInSectionFilter = function(student) {\n+      if (!$scope.searchSection) {\n+        return true;\n+      }\n+      var response = false;\n+      for (var i = 0; i < student.sections.length; i++) {","path":"app/assets/javascripts/angular/controllers/pages/rosterController.js","position":9,"original_position":9,"commit_id":"64f08b4b2179bb5f5a87d2f0ab1cd0b1de25aed4","original_commit_id":"64f08b4b2179bb5f5a87d2f0ab1cd0b1de25aed4","user":{"login":"christianv","id":127199,"avatar_url":"https://avatars.githubusercontent.com/u/127199?v=3","gravatar_id":"","url":"https://api.github.com/users/christianv","html_url":"https://github.com/christianv","followers_url":"https://api.github.com/users/christianv/followers","following_url":"https://api.github.com/users/christianv/following{/other_user}","gists_url":"https://api.github.com/users/christianv/gists{/gist_id}","starred_url":"https://api.github.com/users/christianv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianv/subscriptions","organizations_url":"https://api.github.com/users/christianv/orgs","repos_url":"https://api.github.com/users/christianv/repos","events_url":"https://api.github.com/users/christianv/events{/privacy}","received_events_url":"https://api.github.com/users/christianv/received_events","type":"User","site_admin":false},"body":"@paulkerschen this code seems pretty inefficient, would it be possible to return a `sectionsIds` array from the back-end and run `indexOf` on it to compare?","created_at":"2015-01-21T20:47:25Z","updated_at":"2015-01-21T20:47:25Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3279#discussion_r23332964","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/23332964"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/3279#discussion_r23332964"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279","id":27788275,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3279","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3279.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/3279.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3279","number":3279,"state":"open","locked":false,"title":"CLC-4745 - Roster Photos: filtering by section removes all photos","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"body":"https://jira.ets.berkeley.edu/jira/browse/CLC-4745","created_at":"2015-01-21T19:40:21Z","updated_at":"2015-01-21T20:47:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8cf07484b3cd89fbfcefa955399ae23f0e100d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3279/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/64f08b4b2179bb5f5a87d2f0ab1cd0b1de25aed4","head":{"label":"paulkerschen:clc-4745","ref":"clc-4745","sha":"64f08b4b2179bb5f5a87d2f0ab1cd0b1de25aed4","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"repo":{"id":26028641,"name":"calcentral","full_name":"paulkerschen/calcentral","owner":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulkerschen/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/paulkerschen/calcentral","forks_url":"https://api.github.com/repos/paulkerschen/calcentral/forks","keys_url":"https://api.github.com/repos/paulkerschen/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulkerschen/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulkerschen/calcentral/teams","hooks_url":"https://api.github.com/repos/paulkerschen/calcentral/hooks","issue_events_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/paulkerschen/calcentral/events","assignees_url":"https://api.github.com/repos/paulkerschen/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/paulkerschen/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/paulkerschen/calcentral/tags","blobs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulkerschen/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulkerschen/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulkerschen/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/paulkerschen/calcentral/languages","stargazers_url":"https://api.github.com/repos/paulkerschen/calcentral/stargazers","contributors_url":"https://api.github.com/repos/paulkerschen/calcentral/contributors","subscribers_url":"https://api.github.com/repos/paulkerschen/calcentral/subscribers","subscription_url":"https://api.github.com/repos/paulkerschen/calcentral/subscription","commits_url":"https://api.github.com/repos/paulkerschen/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulkerschen/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulkerschen/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/comments/{number}","contents_url":"https://api.github.com/repos/paulkerschen/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/paulkerschen/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulkerschen/calcentral/merges","archive_url":"https://api.github.com/repos/paulkerschen/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulkerschen/calcentral/downloads","issues_url":"https://api.github.com/repos/paulkerschen/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/paulkerschen/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/paulkerschen/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/paulkerschen/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulkerschen/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/paulkerschen/calcentral/releases{/id}","created_at":"2014-10-31T18:41:02Z","updated_at":"2015-01-12T23:23:58Z","pushed_at":"2015-01-21T19:45:35Z","git_url":"git://github.com/paulkerschen/calcentral.git","ssh_url":"git@github.com:paulkerschen/calcentral.git","clone_url":"https://github.com/paulkerschen/calcentral.git","svn_url":"https://github.com/paulkerschen/calcentral","homepage":"https://calcentral.berkeley.edu","size":16289,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"65acf7857c7ab219f85f7c0a9430d5ada483477a","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments/{number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","created_at":"2012-08-20T16:45:39Z","updated_at":"2015-01-21T19:55:45Z","pushed_at":"2015-01-21T19:55:45Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":29150,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":1,"forks":42,"open_issues":1,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/3279"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3279"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/3279/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/3279/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/64f08b4b2179bb5f5a87d2f0ab1cd0b1de25aed4"}}}}