{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/25359710","id":25359710,"diff_hunk":"@@ -529,6 +529,34 @@ public static void StringFunctionsTest2436()\n \n         /// <summary>\n         /// Verify result.\n+        /// normalize-space(\"\") = \"\"\n+        /// </summary>\n+        [Fact]\n+        public static void StringFunctionsTest2473()","path":"src/Common/tests/System.Xml.XPath/CoreFunctionLibrary/StringFunctionsTests.cs","position":7,"original_position":7,"commit_id":"cc2243cc58a4f3c154d1d16f74e9e0eb4172807c","original_commit_id":"cc2243cc58a4f3c154d1d16f74e9e0eb4172807c","user":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"Sounds good, whatever test that proves that we don't change the existing behavior is fine.","created_at":"2015-02-25T17:29:26Z","updated_at":"2015-02-25T17:29:26Z","html_url":"https://github.com/dotnet/corefx/pull/581#discussion_r25359710","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/25359710"},"html":{"href":"https://github.com/dotnet/corefx/pull/581#discussion_r25359710"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/581","id":28407596,"html_url":"https://github.com/dotnet/corefx/pull/581","diff_url":"https://github.com/dotnet/corefx/pull/581.diff","patch_url":"https://github.com/dotnet/corefx/pull/581.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/581","number":581,"state":"open","locked":false,"title":"Improve performance and allocations of xpath string functions","user":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"body":"Improve Translate perf by ~20% and allocations by around 50% (dependant on string)\r\nImprove Normalize perf by ~30% and allocations by around 55% (dependant on string)\r\n\r\nGeneral:\r\nWe are always iterating through every char so we can get them all in one go and use that as our temporary buffer instead of the StringBuilder.\r\nBecause these functions can remove chars there is a read point in the buffer and an update point. The update point is always the same place or less than the read point.\r\n\r\nNormalize:\r\nNo need for XmlConvertEx.TrimString as we can start \"firstSpace\" as false to trim the start and all trailing whitespace at the end is combined into one space. We can just check that at the end which avoids a trim string creation.","created_at":"2015-01-31T02:07:03Z","updated_at":"2015-02-25T17:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ae0b5c6fe6c4403f19e2d3d7a290256e588999b","assignee":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/581/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/581/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/581/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/cc2243cc58a4f3c154d1d16f74e9e0eb4172807c","head":{"label":"bbowyersmyth:xpathfunctions-perf","ref":"xpathfunctions-perf","sha":"cc2243cc58a4f3c154d1d16f74e9e0eb4172807c","user":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"repo":{"id":28426101,"name":"corefx","full_name":"bbowyersmyth/corefx","owner":{"login":"bbowyersmyth","id":2482209,"avatar_url":"https://avatars.githubusercontent.com/u/2482209?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowyersmyth","html_url":"https://github.com/bbowyersmyth","followers_url":"https://api.github.com/users/bbowyersmyth/followers","following_url":"https://api.github.com/users/bbowyersmyth/following{/other_user}","gists_url":"https://api.github.com/users/bbowyersmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowyersmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowyersmyth/subscriptions","organizations_url":"https://api.github.com/users/bbowyersmyth/orgs","repos_url":"https://api.github.com/users/bbowyersmyth/repos","events_url":"https://api.github.com/users/bbowyersmyth/events{/privacy}","received_events_url":"https://api.github.com/users/bbowyersmyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbowyersmyth/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/bbowyersmyth/corefx","forks_url":"https://api.github.com/repos/bbowyersmyth/corefx/forks","keys_url":"https://api.github.com/repos/bbowyersmyth/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbowyersmyth/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbowyersmyth/corefx/teams","hooks_url":"https://api.github.com/repos/bbowyersmyth/corefx/hooks","issue_events_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/bbowyersmyth/corefx/events","assignees_url":"https://api.github.com/repos/bbowyersmyth/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/bbowyersmyth/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/bbowyersmyth/corefx/tags","blobs_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbowyersmyth/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/bbowyersmyth/corefx/languages","stargazers_url":"https://api.github.com/repos/bbowyersmyth/corefx/stargazers","contributors_url":"https://api.github.com/repos/bbowyersmyth/corefx/contributors","subscribers_url":"https://api.github.com/repos/bbowyersmyth/corefx/subscribers","subscription_url":"https://api.github.com/repos/bbowyersmyth/corefx/subscription","commits_url":"https://api.github.com/repos/bbowyersmyth/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbowyersmyth/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbowyersmyth/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbowyersmyth/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/bbowyersmyth/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbowyersmyth/corefx/merges","archive_url":"https://api.github.com/repos/bbowyersmyth/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbowyersmyth/corefx/downloads","issues_url":"https://api.github.com/repos/bbowyersmyth/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/bbowyersmyth/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/bbowyersmyth/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/bbowyersmyth/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbowyersmyth/corefx/labels{/name}","releases_url":"https://api.github.com/repos/bbowyersmyth/corefx/releases{/id}","created_at":"2014-12-24T00:19:56Z","updated_at":"2015-02-24T07:29:15Z","pushed_at":"2015-02-24T07:29:07Z","git_url":"git://github.com/bbowyersmyth/corefx.git","ssh_url":"git@github.com:bbowyersmyth/corefx.git","clone_url":"https://github.com/bbowyersmyth/corefx.git","svn_url":"https://github.com/bbowyersmyth/corefx","homepage":"","size":11023,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3203415188a03592028795f3e559bad861cf39fa","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-02-25T16:03:13Z","pushed_at":"2015-02-25T12:34:09Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":23005,"stargazers_count":7041,"watchers_count":7041,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1286,"mirror_url":null,"open_issues_count":278,"forks":1286,"open_issues":278,"watchers":7041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/581"},"html":{"href":"https://github.com/dotnet/corefx/pull/581"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/581"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/cc2243cc58a4f3c154d1d16f74e9e0eb4172807c"}}}}