{"action":"closed","number":4194,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4194","id":32043717,"html_url":"https://github.com/ceph/ceph/pull/4194","diff_url":"https://github.com/ceph/ceph/pull/4194.diff","patch_url":"https://github.com/ceph/ceph/pull/4194.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4194","number":4194,"state":"closed","locked":false,"title":"ReplicatedPG: trim backfill intervals based on peer's last_backfill_star...","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"...ted\r\n\r\nOtherwise, we fail to trim the peer's last_backfill_started and get bug 11199.\r\n\r\n1) osd 4 backfills up to 31bccdb2/mira01213209-286/head (henceforth: foo)\r\n\r\n2) Interval change happens\r\n\r\n3) osd 0 now finds itself backfilling to 4 (lb=foo) and osd.5\r\n(lb=b6670ba2/mira01213209-160/snapdir//1, henceforth: bar)\r\n\r\n4) recover_backfill causes both 4 and 5 to scan forward, so 4 has an interval\r\nstarting at foo, 5 has an interval starting at bar.\r\n\r\n5) Once those have come back, recover_backfill attempts to trim off the\r\nlast_backfill_started, but 4's interval starts after that, so foo remains in\r\nosd 4's interval (this is the bug)\r\n\r\n7) We serve a copyfrom on foo (sent to 4 as well).\r\n\r\n8) We eventually get to foo in the backfilling. Normally, they would have the\r\nsame version, but of course we don't update osd.4's interval from the log since\r\nit should not have received writes in that interval. Thus, we end up trying to\r\nrecover foo on osd.4 anyway.\r\n\r\n9) But, an interval change happens between removing foo from osd.4 and\r\ncompleting the recovery, leaving osd.4 without foo, but with lb >= foo\r\n\r\nFixes: #11199\r\nBackport: firefly\r\nSigned-off-by: Samuel Just <sjust@redhat.com>","created_at":"2015-03-26T17:58:01Z","updated_at":"2015-03-27T15:15:29Z","closed_at":"2015-03-27T15:15:29Z","merged_at":"2015-03-27T15:15:29Z","merge_commit_sha":"96e45926f592c86b2361731ea70e6cb01b9a5d57","assignee":null,"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/5","html_url":"https://github.com/ceph/ceph/milestones/hammer","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/5/labels","id":862053,"number":5,"title":"hammer","description":"","creator":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":166,"state":"open","created_at":"2014-11-11T16:32:01Z","updated_at":"2015-03-27T15:15:29Z","due_on":"2015-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/4194/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/4194/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4194/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/1388d6bd949a18e8ac0aecb0eb79ffb93d316879","head":{"label":"athanatos:wip-11199","ref":"wip-11199","sha":"1388d6bd949a18e8ac0aecb0eb79ffb93d316879","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"repo":{"id":2424229,"name":"ceph","full_name":"athanatos/ceph","owner":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/athanatos/ceph","description":"Ceph distributed file system","fork":true,"url":"https://api.github.com/repos/athanatos/ceph","forks_url":"https://api.github.com/repos/athanatos/ceph/forks","keys_url":"https://api.github.com/repos/athanatos/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/athanatos/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/athanatos/ceph/teams","hooks_url":"https://api.github.com/repos/athanatos/ceph/hooks","issue_events_url":"https://api.github.com/repos/athanatos/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/athanatos/ceph/events","assignees_url":"https://api.github.com/repos/athanatos/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/athanatos/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/athanatos/ceph/tags","blobs_url":"https://api.github.com/repos/athanatos/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/athanatos/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/athanatos/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/athanatos/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/athanatos/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/athanatos/ceph/languages","stargazers_url":"https://api.github.com/repos/athanatos/ceph/stargazers","contributors_url":"https://api.github.com/repos/athanatos/ceph/contributors","subscribers_url":"https://api.github.com/repos/athanatos/ceph/subscribers","subscription_url":"https://api.github.com/repos/athanatos/ceph/subscription","commits_url":"https://api.github.com/repos/athanatos/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/athanatos/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/athanatos/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/athanatos/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/athanatos/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/athanatos/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/athanatos/ceph/merges","archive_url":"https://api.github.com/repos/athanatos/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/athanatos/ceph/downloads","issues_url":"https://api.github.com/repos/athanatos/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/athanatos/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/athanatos/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/athanatos/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/athanatos/ceph/labels{/name}","releases_url":"https://api.github.com/repos/athanatos/ceph/releases{/id}","created_at":"2011-09-20T17:52:49Z","updated_at":"2014-06-23T20:06:08Z","pushed_at":"2015-03-26T18:02:50Z","git_url":"git://github.com/athanatos/ceph.git","ssh_url":"git@github.com:athanatos/ceph.git","clone_url":"https://github.com/athanatos/ceph.git","svn_url":"https://github.com/athanatos/ceph","homepage":"http://ceph.newdream.net/","size":116951,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:hammer","ref":"hammer","sha":"6994648bc443429dc2edfbb38fbaaa9a19e2bdd1","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-03-27T11:33:09Z","pushed_at":"2015-03-27T15:15:29Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":385383,"stargazers_count":1199,"watchers_count":1199,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":650,"mirror_url":null,"open_issues_count":108,"forks":650,"open_issues":108,"watchers":1199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4194"},"html":{"href":"https://github.com/ceph/ceph/pull/4194"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/4194"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/4194/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4194/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4194/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/1388d6bd949a18e8ac0aecb0eb79ffb93d316879"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}