{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/10619","labels_url":"https://api.github.com/repos/angular/angular.js/issues/10619/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/10619/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/10619/events","html_url":"https://github.com/angular/angular.js/pull/10619","id":53249905,"number":10619,"title":"fix(jqLite): Adding more support for custom element tagnames","user":{"login":"richardaday","id":52923,"avatar_url":"https://avatars.githubusercontent.com/u/52923?v=3","gravatar_id":"","url":"https://api.github.com/users/richardaday","html_url":"https://github.com/richardaday","followers_url":"https://api.github.com/users/richardaday/followers","following_url":"https://api.github.com/users/richardaday/following{/other_user}","gists_url":"https://api.github.com/users/richardaday/gists{/gist_id}","starred_url":"https://api.github.com/users/richardaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardaday/subscriptions","organizations_url":"https://api.github.com/users/richardaday/orgs","repos_url":"https://api.github.com/users/richardaday/repos","events_url":"https://api.github.com/users/richardaday/events{/privacy}","received_events_url":"https://api.github.com/users/richardaday/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/branch:%201.3.x","name":"branch: 1.3.x","color":"f7c6c7"},{"url":"https://api.github.com/repos/angular/angular.js/labels/branch:%201.4.x","name":"branch: 1.4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20no","name":"cla: no","color":"f7c6c7"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20jqLite","name":"component: jqLite","color":"fbca04"},{"url":"https://api.github.com/repos/angular/angular.js/labels/severity:%20broken%20expected%20use","name":"severity: broken expected use","color":"fbda00"},{"url":"https://api.github.com/repos/angular/angular.js/labels/type:%20bug","name":"type: bug","color":"000000"}],"state":"open","locked":false,"assignee":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/90","html_url":"https://github.com/angular/angular.js/milestones/1.5.x%20-%20migration-facilitation","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/90/labels","id":1025270,"number":90,"title":"1.5.x - migration-facilitation","description":"","creator":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":0,"state":"open","created_at":"2015-03-17T12:15:49Z","updated_at":"2015-04-29T09:21:00Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2015-01-02T12:17:57Z","updated_at":"2015-05-03T13:03:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/10619","html_url":"https://github.com/angular/angular.js/pull/10619","diff_url":"https://github.com/angular/angular.js/pull/10619.diff","patch_url":"https://github.com/angular/angular.js/pull/10619.patch"},"body":"Before this change, jqLite would allow you to create elements such as\r\n\"my-foo\" and \"div-foo\" but would not allow you to create certain\r\nelements such as \"tr-foo\" and  \"td-foo\".  This is incorrect as well as\r\nundocumented and unexpected."},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/98478038","html_url":"https://github.com/angular/angular.js/pull/10619#issuecomment-98478038","issue_url":"https://api.github.com/repos/angular/angular.js/issues/10619","id":98478038,"user":{"login":"mzgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mzgol","html_url":"https://github.com/mzgol","followers_url":"https://api.github.com/users/mzgol/followers","following_url":"https://api.github.com/users/mzgol/following{/other_user}","gists_url":"https://api.github.com/users/mzgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mzgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzgol/subscriptions","organizations_url":"https://api.github.com/users/mzgol/orgs","repos_url":"https://api.github.com/users/mzgol/repos","events_url":"https://api.github.com/users/mzgol/events{/privacy}","received_events_url":"https://api.github.com/users/mzgol/received_events","type":"User","site_admin":false},"created_at":"2015-05-03T13:03:57Z","updated_at":"2015-05-03T13:03:57Z","body":"> @mzgol, what is the best option for verifying the jQuery version used in tests?\r\n\r\nIf you just want to check if it's 3.0.0 or newer, the easiest would be to:\r\n```js\r\nif (window.jQuery && Number(window.jQuery.fn.jquery.split('.')[0]) >= 3) { /* code */ }\r\n```\r\nas `jQuery.fn.jquery` contains the version. Some files have the `jQuery` global set to `undefined` in jqLite mode (no idea where's the code causing that) so some tests check for `jQuery` instead of `window.jQuery`, you may try it.\r\n\r\nIf we wanted more fine-grained version comparisons (the above code is ugly and doesn't scale behind major checks), it'd be best to use the [semver](https://www.npmjs.com/package/semver) module:\r\n ```js\r\nif (window.jQuery && semver.satisfies(window.jQuery.fn.jquery, '>=3.0.0')) { /* code */ }\r\n```\r\n\r\nI know @IgorMinar has been recently trying to reduce used dependencies instead of adding new ones, though. :-)"}}