{"action":"created","comment":{"url":"https://api.github.com/repos/apache/phoenix/pulls/comments/23720737","id":23720737,"diff_hunk":"@@ -2051,7 +2087,7 @@ public MutationState addColumn(AddColumnStatement statement) throws SQLException\n                     }\n                 }\n \n-                boolean isAddingPKColumn = false;\n+                int numPkColumnsAdded = 0;","path":"phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java","position":217,"original_position":217,"commit_id":"086198b0cf3624a715baf92afdd2e692f8fa9e24","original_commit_id":"086198b0cf3624a715baf92afdd2e692f8fa9e24","user":{"login":"JamesRTaylor","id":6176299,"avatar_url":"https://avatars.githubusercontent.com/u/6176299?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesRTaylor","html_url":"https://github.com/JamesRTaylor","followers_url":"https://api.github.com/users/JamesRTaylor/followers","following_url":"https://api.github.com/users/JamesRTaylor/following{/other_user}","gists_url":"https://api.github.com/users/JamesRTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesRTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesRTaylor/subscriptions","organizations_url":"https://api.github.com/users/JamesRTaylor/orgs","repos_url":"https://api.github.com/users/JamesRTaylor/repos","events_url":"https://api.github.com/users/JamesRTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/JamesRTaylor/received_events","type":"User","site_admin":false},"body":"Ah, my bad. I like the way you've done it.","created_at":"2015-01-28T20:31:40Z","updated_at":"2015-01-28T20:31:40Z","html_url":"https://github.com/apache/phoenix/pull/34#discussion_r23720737","pull_request_url":"https://api.github.com/repos/apache/phoenix/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments/23720737"},"html":{"href":"https://github.com/apache/phoenix/pull/34#discussion_r23720737"},"pull_request":{"href":"https://api.github.com/repos/apache/phoenix/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/apache/phoenix/pulls/34","id":27403047,"html_url":"https://github.com/apache/phoenix/pull/34","diff_url":"https://github.com/apache/phoenix/pull/34.diff","patch_url":"https://github.com/apache/phoenix/pull/34.patch","issue_url":"https://api.github.com/repos/apache/phoenix/issues/34","number":34,"state":"open","locked":false,"title":"PHOENIX-514 Support functional indexes","user":{"login":"twdsilva","id":5653678,"avatar_url":"https://avatars.githubusercontent.com/u/5653678?v=3","gravatar_id":"","url":"https://api.github.com/users/twdsilva","html_url":"https://github.com/twdsilva","followers_url":"https://api.github.com/users/twdsilva/followers","following_url":"https://api.github.com/users/twdsilva/following{/other_user}","gists_url":"https://api.github.com/users/twdsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/twdsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twdsilva/subscriptions","organizations_url":"https://api.github.com/users/twdsilva/orgs","repos_url":"https://api.github.com/users/twdsilva/repos","events_url":"https://api.github.com/users/twdsilva/events{/privacy}","received_events_url":"https://api.github.com/users/twdsilva/received_events","type":"User","site_admin":false},"body":"This is my first cut at function based indexes. \r\nI need to add more tests and validate the expression that is supplied in the create index statement.\r\nAlso In MetaDataEndpointImpl, I still have to set a default value for the expression string so that we don't need a script to update existing index definitions.\r\n\r\nI created a new visitor IndexColumnExpressionCompiler that checks if a parse node matches an expression in an index table and if there is a match evaluates the parse node as a column parse node.  I modified SelectClauseVisitor, TrackOrderPreservingExpressionCompiler and WhereExpressionCompiler to extend IndexColumnExpressionCompiler. \r\nI have a test that tests using an expression in the SELECT, WHERE, ORDER BY and GROUP clauses and it seems to work correctly (the explain plan says the index is used). \r\n\r\n \r\n","created_at":"2015-01-15T03:01:18Z","updated_at":"2015-01-28T20:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8448be6db8d0aae17af609aa58e889e004bf70ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/phoenix/pulls/34/commits","review_comments_url":"https://api.github.com/repos/apache/phoenix/pulls/34/comments","review_comment_url":"https://api.github.com/repos/apache/phoenix/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/phoenix/issues/34/comments","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/086198b0cf3624a715baf92afdd2e692f8fa9e24","head":{"label":"twdsilva:function-idx","ref":"function-idx","sha":"086198b0cf3624a715baf92afdd2e692f8fa9e24","user":{"login":"twdsilva","id":5653678,"avatar_url":"https://avatars.githubusercontent.com/u/5653678?v=3","gravatar_id":"","url":"https://api.github.com/users/twdsilva","html_url":"https://github.com/twdsilva","followers_url":"https://api.github.com/users/twdsilva/followers","following_url":"https://api.github.com/users/twdsilva/following{/other_user}","gists_url":"https://api.github.com/users/twdsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/twdsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twdsilva/subscriptions","organizations_url":"https://api.github.com/users/twdsilva/orgs","repos_url":"https://api.github.com/users/twdsilva/repos","events_url":"https://api.github.com/users/twdsilva/events{/privacy}","received_events_url":"https://api.github.com/users/twdsilva/received_events","type":"User","site_admin":false},"repo":{"id":28112898,"name":"phoenix","full_name":"twdsilva/phoenix","owner":{"login":"twdsilva","id":5653678,"avatar_url":"https://avatars.githubusercontent.com/u/5653678?v=3","gravatar_id":"","url":"https://api.github.com/users/twdsilva","html_url":"https://github.com/twdsilva","followers_url":"https://api.github.com/users/twdsilva/followers","following_url":"https://api.github.com/users/twdsilva/following{/other_user}","gists_url":"https://api.github.com/users/twdsilva/gists{/gist_id}","starred_url":"https://api.github.com/users/twdsilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twdsilva/subscriptions","organizations_url":"https://api.github.com/users/twdsilva/orgs","repos_url":"https://api.github.com/users/twdsilva/repos","events_url":"https://api.github.com/users/twdsilva/events{/privacy}","received_events_url":"https://api.github.com/users/twdsilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twdsilva/phoenix","description":"Mirror of Apache Phoenix","fork":true,"url":"https://api.github.com/repos/twdsilva/phoenix","forks_url":"https://api.github.com/repos/twdsilva/phoenix/forks","keys_url":"https://api.github.com/repos/twdsilva/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twdsilva/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twdsilva/phoenix/teams","hooks_url":"https://api.github.com/repos/twdsilva/phoenix/hooks","issue_events_url":"https://api.github.com/repos/twdsilva/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/twdsilva/phoenix/events","assignees_url":"https://api.github.com/repos/twdsilva/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/twdsilva/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/twdsilva/phoenix/tags","blobs_url":"https://api.github.com/repos/twdsilva/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twdsilva/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twdsilva/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/twdsilva/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twdsilva/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/twdsilva/phoenix/languages","stargazers_url":"https://api.github.com/repos/twdsilva/phoenix/stargazers","contributors_url":"https://api.github.com/repos/twdsilva/phoenix/contributors","subscribers_url":"https://api.github.com/repos/twdsilva/phoenix/subscribers","subscription_url":"https://api.github.com/repos/twdsilva/phoenix/subscription","commits_url":"https://api.github.com/repos/twdsilva/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/twdsilva/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/twdsilva/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/twdsilva/phoenix/issues/comments/{number}","contents_url":"https://api.github.com/repos/twdsilva/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/twdsilva/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twdsilva/phoenix/merges","archive_url":"https://api.github.com/repos/twdsilva/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twdsilva/phoenix/downloads","issues_url":"https://api.github.com/repos/twdsilva/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/twdsilva/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/twdsilva/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/twdsilva/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twdsilva/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/twdsilva/phoenix/releases{/id}","created_at":"2014-12-17T00:09:33Z","updated_at":"2015-01-23T21:44:39Z","pushed_at":"2015-01-28T03:39:09Z","git_url":"git://github.com/twdsilva/phoenix.git","ssh_url":"git@github.com:twdsilva/phoenix.git","clone_url":"https://github.com/twdsilva/phoenix.git","svn_url":"https://github.com/twdsilva/phoenix","homepage":null,"size":11400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b12ddfa3f2d7c8c60b17c3f56edc7605264b0e4b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20473418,"name":"phoenix","full_name":"apache/phoenix","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/phoenix","description":"Mirror of Apache Phoenix","fork":false,"url":"https://api.github.com/repos/apache/phoenix","forks_url":"https://api.github.com/repos/apache/phoenix/forks","keys_url":"https://api.github.com/repos/apache/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/phoenix/teams","hooks_url":"https://api.github.com/repos/apache/phoenix/hooks","issue_events_url":"https://api.github.com/repos/apache/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/apache/phoenix/events","assignees_url":"https://api.github.com/repos/apache/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/apache/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/apache/phoenix/tags","blobs_url":"https://api.github.com/repos/apache/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/phoenix/languages","stargazers_url":"https://api.github.com/repos/apache/phoenix/stargazers","contributors_url":"https://api.github.com/repos/apache/phoenix/contributors","subscribers_url":"https://api.github.com/repos/apache/phoenix/subscribers","subscription_url":"https://api.github.com/repos/apache/phoenix/subscription","commits_url":"https://api.github.com/repos/apache/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/phoenix/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/apache/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/phoenix/merges","archive_url":"https://api.github.com/repos/apache/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/phoenix/downloads","issues_url":"https://api.github.com/repos/apache/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/apache/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/apache/phoenix/releases{/id}","created_at":"2014-06-04T07:00:08Z","updated_at":"2015-01-25T02:00:07Z","pushed_at":"2015-01-27T18:20:34Z","git_url":"git://github.com/apache/phoenix.git","ssh_url":"git@github.com:apache/phoenix.git","clone_url":"https://github.com/apache/phoenix.git","svn_url":"https://github.com/apache/phoenix","homepage":null,"size":20437,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":"git://git.apache.org/phoenix.git","open_issues_count":23,"forks":57,"open_issues":23,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/34"},"html":{"href":"https://github.com/apache/phoenix/pull/34"},"issue":{"href":"https://api.github.com/repos/apache/phoenix/issues/34"},"comments":{"href":"https://api.github.com/repos/apache/phoenix/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/phoenix/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/phoenix/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/apache/phoenix/statuses/086198b0cf3624a715baf92afdd2e692f8fa9e24"}}}}