{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/3264","labels_url":"https://api.github.com/repos/phpbb/phpbb/issues/3264/labels{/name}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3264/comments","events_url":"https://api.github.com/repos/phpbb/phpbb/issues/3264/events","html_url":"https://github.com/phpbb/phpbb/pull/3264","id":53455878,"number":3264,"title":"[ticket/13471] Add core.viewforum_assign_template_vars_before","user":{"login":"omniError","id":1885212,"avatar_url":"https://avatars.githubusercontent.com/u/1885212?v=3","gravatar_id":"","url":"https://api.github.com/users/omniError","html_url":"https://github.com/omniError","followers_url":"https://api.github.com/users/omniError/followers","following_url":"https://api.github.com/users/omniError/following{/other_user}","gists_url":"https://api.github.com/users/omniError/gists{/gist_id}","starred_url":"https://api.github.com/users/omniError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omniError/subscriptions","organizations_url":"https://api.github.com/users/omniError/orgs","repos_url":"https://api.github.com/users/omniError/repos","events_url":"https://api.github.com/users/omniError/events{/privacy}","received_events_url":"https://api.github.com/users/omniError/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phpbb/phpbb/labels/Event","name":"Event","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/5","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/5/labels","id":915045,"number":5,"title":"3.1.4","description":null,"creator":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2014-12-26T08:23:11Z","updated_at":"2015-01-06T20:46:37Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-01-05T22:23:34Z","updated_at":"2015-01-06T20:54:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3264","html_url":"https://github.com/phpbb/phpbb/pull/3264","diff_url":"https://github.com/phpbb/phpbb/pull/3264.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3264.patch"},"body":"https://tracker.phpbb.com/browse/PHPBB3-13471\r\n\r\nPHPBB3-13471"},"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/68931871","html_url":"https://github.com/phpbb/phpbb/pull/3264#issuecomment-68931871","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3264","id":68931871,"user":{"login":"omniError","id":1885212,"avatar_url":"https://avatars.githubusercontent.com/u/1885212?v=3","gravatar_id":"","url":"https://api.github.com/users/omniError","html_url":"https://github.com/omniError","followers_url":"https://api.github.com/users/omniError/followers","following_url":"https://api.github.com/users/omniError/following{/other_user}","gists_url":"https://api.github.com/users/omniError/gists{/gist_id}","starred_url":"https://api.github.com/users/omniError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omniError/subscriptions","organizations_url":"https://api.github.com/users/omniError/orgs","repos_url":"https://api.github.com/users/omniError/repos","events_url":"https://api.github.com/users/omniError/events{/privacy}","received_events_url":"https://api.github.com/users/omniError/received_events","type":"User","site_admin":false},"created_at":"2015-01-06T20:54:43Z","updated_at":"2015-01-06T20:54:43Z","body":"I disagree with merging them for a few reasons, the first being that it would put unexpected logic into that event (an event previously described to handle a single SQL query for topic data is now also changing unrelated template variables). Changing the event itself to be more consistent with what it would do breaks BC. Reassigning after that event would create a bunch of duplicate code since the values are determined inline in the array. This seemed like the least bad approach."}}