{"push_id":644828651,"size":19,"distinct_size":12,"ref":"refs/heads/next","head":"e03088ebe24cd8c12d4389687318c954953291a7","before":"45374b598fe2917eb678a8f18418ef940b47f825","commits":[{"sha":"d1c9f791d870d88ec4f02e31b29600e1afbaa58a","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"doc: describe the \"new\" options to the \"configure\" script\n\nAs there are many options, they have been split into 5 sections; added\ndocumentation for all the legacy Window Maker options that were missing and\nfor the new ones; added documentation for a few of the \"autotools\" standard\noptions that can be considered interesting.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/d1c9f791d870d88ec4f02e31b29600e1afbaa58a"},{"sha":"30fe0fb05f6fd0030155c2643a93a562c8278711","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"check-doc: add an option to ignore some explicit options from the command's help\n\nThere are a few rare cases where some options listed in the program's\nbuilt-in help page may not be documented for a valid reason. This patch\nprovides an option to the checking script to not complain about them, but:\n\n - the listed options must include a comment about why, to ensure that the\nuser thinks twice about it and because it is better for maintainability;\n\n - the listed option must be part of the options listed by the application\nto ensure the command line invocation of the script will remain up to date.\n\nThis new option is then used for the check of the \"configure\" options\nbecause for a few of them the right place to document them is in the\nINSTALL file provided by Autoconf and not in our Window Maker specific doc.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/30fe0fb05f6fd0030155c2643a93a562c8278711"},{"sha":"1cef020eb322f1bc2978d49ec2d846dd9d1cc15d","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"Code refactoring: replaced macro 'MWM_HINTS' by 'USE_MWM_HINTS' for consistency\n\nThe usual way to define a macro in is to name macro with 'USE_xxx' when\nthey are used to enable a feature 'xxx'.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/1cef020eb322f1bc2978d49ec2d846dd9d1cc15d"},{"sha":"2ebfcd9c5c9350d89f2346304ed8c02883020785","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"configure: Added option to disable Motif WM Hints support\n\nThe old behaviour was to expect the user to go modify manually a source\nfile which is not a great idea because that's typically the kind of things\nin charge of the configure script.\n\nAs a side effect, we can now use an automake conditional to avoid compiling\nthe source file in charge of the feature when not used, instead of trying\nto compile an empty-looking file.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/2ebfcd9c5c9350d89f2346304ed8c02883020785"},{"sha":"b4cf94aacd0f9fcffd802b0a8e47e0d162ca1f20","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency\n\nThe usual way to define a macro in is to name macro with 'USE_xxx' when\nthey are used to enable a feature 'xxx'.\n\nAs the feature concerns the Dock and not DnD in general (WINGs support is\nnot disabled), make it a bit more clear in the macro name and document the\nconfigure flag in the Installation Manual.\n\nTook opportunity to compile the corresponding file only when the feature is\nnot disabled.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/b4cf94aacd0f9fcffd802b0a8e47e0d162ca1f20"},{"sha":"842e145e0aeef633b7d0f938f57098469fee7cfe","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"doc: re-generate the top directory documentation when \"make dist\" is invoked\n\nAs pointed by Douglas Torrance, there are some case where the 2 docs\nINSTALL-WMAKER and README.i18n are not re-generated properly, one of the\ncases being if the user grabs the sources from Git to make a source package\nonly (ie, without compiling anything).\n\nThis patch adds a hook to \"make dist\" so it will re-generate the docs if\nneeded. Because the \"dist-hook\" is run after Automake has copied the files\nto the temporary directory (distdir) then we also include an explicit copy\nof the files there to have the latest version.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/842e145e0aeef633b7d0f938f57098469fee7cfe"},{"sha":"2086eefb7e5c658bf0f99feb2aa4b118b188e2b1","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"texi2txt: add workaround for a known bug in \"mawk\"\n\nAs reported by Douglas Torrance, the script that generates the plain text\ndocumentation from the texinfo source would crash due to the cross-\nreferences when the version of awk used is \"mawk\".\n\nThis is actually a known bug in mawk:\nhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=172774\n\nIt looks like the bug have been fixed in mawk, but Debian is still\nproviding a broken version. To avoid problems, this patch is introducing a\nworkaround in the matching pattern that causes the issue every time it is\nbeing used.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":false,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/2086eefb7e5c658bf0f99feb2aa4b118b188e2b1"},{"sha":"8d09af51b831bb3ae7ddc3d4599e82739d41d2ca","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: check return value for XGetWindowAttributes (Coverity #50032)\n\nAs reported by Coverity, the return value for XGetWindowAttributes is\nusually checked in many places, because it is a good practice to ensure\nthat it did work, but it was not checked when called in the function\n'wClientCheckProperty'.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/8d09af51b831bb3ae7ddc3d4599e82739d41d2ca"},{"sha":"ba8cd2abe47e30344cbeb99dcc7cf22d9730f4d3","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"Handle NULL pointer as good as possible (Coverity #50099)\n\nAs pointed by Coverity, in the \"Configuration\" panel of WPrefs there are\nsome images loaded, but if the images cannot be loaded correctly then the\nreturned NULL pointer can crash the application as it is dereferenced in\nfurther function calls.\n\nTo solve this case, this patch is adding a NULL pointer check in the\nfunctions RScaleImage (wrlib) and WMCreatePixmapFromRImage (WINGs), so both\ncan accept that NULL pointer to also return NULL, which means the existing\ncheck for \"icon == NULL\" in the WPrefs code will be useful.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/ba8cd2abe47e30344cbeb99dcc7cf22d9730f4d3"},{"sha":"15db368291419e523d6787d5c968e312b1211b55","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"WINGs: fix memory leak in WMSubtractPLDictionaries (Coverity #50128)\n\nAs pointed by Coverity, a temporary proplist is created with the list of\nkeys to be removed from the source proplist, but this temporary proplist\nwas not released at the end, leaking memory.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/15db368291419e523d6787d5c968e312b1211b55"},{"sha":"ae078991221b32367f98754e632021d3975827aa","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: fix incorrect size for memory allocation (Coverity #50207)\n\nAs pointed by Coverity, when increasing the size of the array allocated to\nstore the pointers to menus in a cascaded menu, the incorrect value was\nused in argument to the sizeof which lead to over-allocating memory.\n\nThis patch replaces the name of the structure (which should have been the\npointer type) by the variable actually being used, fixing the size issue\nand making maintainability easier by tracking the type of the variable\nwhich is less prone to bugs in case of change.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/ae078991221b32367f98754e632021d3975827aa"},{"sha":"04404bf47c4eed536dde614333eb83b923b3ae59","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: fix memory leak in the Workspace Map if there is no workspace (Coverity #109608)\n\nAs pointed by Coverity, there is a safety check on the number of workspace\nwhich aborts the function, but the storage memory have already been\nallocated so it would leak this buffer.\n\nThe case where the number of workspace is 0 is probably not supposed to\nhappen (there should always be at least 1 workspace, the current one), but\nit is better to keep safety checks, so this patch is moving the check at\nthe beginning so no leak will occur.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/04404bf47c4eed536dde614333eb83b923b3ae59"},{"sha":"d72e6d415a78972e9085841545f5de58e931b4f3","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: remove non-necessary allocation (Coverity #109609)\n\nAs pointed by Coverity, there was a memory leak because the buffer used to\ncreate the wmsetbg command is allocated twice.\n\nBecause it is not really necessary to call 'wmalloc' for such a small case\n(it is not efficient and participates to memory fragmentation), this patch\nreplaces the dynamic memory allocation by a buffer on the stack, which also\nsolves to de-allocation issue.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/d72e6d415a78972e9085841545f5de58e931b4f3"},{"sha":"a93570e5be7c6a2493bc8555da4a31e889de9210","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: remove useless null pointer check (Coverity #109612)\n\nAs pointed by Coverity, the pointer in wwin->frame have already been\ndereferenced many times in the function, so it is useless to include a\ncheck later; removing it makes the code smaller thus easier to maintain.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/a93570e5be7c6a2493bc8555da4a31e889de9210"},{"sha":"032f6587d9fba057744209bc5b3b819b5bfd6b08","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"WINGs: remove useless function call in WColorPanel (Coverity #109617)\n\nAs reported by Coverity, the function 'customSetPalette' is making a call\nto 'WMGetPopUpButtonSelectedItem', but this function does nothing to the\nwidget but only return a value, which is not used at all, so this patch\nremoves the call to the function.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/032f6587d9fba057744209bc5b3b819b5bfd6b08"},{"sha":"6ef343ed8795532c8936889a42873735157f0bae","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"WUtil: fix improper use of de-allocated variable (Coverity #109618)\n\nAs pointed by Coverity, the variable 'path_dst' was first free'd, then it\nwas used in the 'unlink' function.\n\nThis patch fixes the call order to de-allocate the string only when it is\nno more needed.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/6ef343ed8795532c8936889a42873735157f0bae"},{"sha":"c8ea949b1aad9e019141d67092304cbb7db5bf1a","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: converted macro 'SAME' into a static function\n\nThere are some risks associated with the way arguments are used in macros,\nand using a function also allows check on the type of arguments and leaves\nmore room to the compiler for making the best optimisation choice; it also\nallows writing easier to read code (and thus, to maintain).\n\nAs a side effect, this should also help Coverity in avoiding false positive\nbug reports (like #109605 and #109607).\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/c8ea949b1aad9e019141d67092304cbb7db5bf1a"},{"sha":"bc4f3352b65aa2ffd96b26d8a41ae19f2584882e","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: fix crash when switching workspace with \"Affiche.app\"\n\nAs reported by Martin Dietze, when switching workspace (mainly with\nkeyboard shortcut) while the focus was set on a sticky note from the\nGNUstep application \"Affiche.app\" would cause Window Maker to crash.\n\nThis crash was due to the application creating its menu with an Omnipresent\nstate; Window Maker tried to be smart by smartly setting the focus to this\nwindow after the workspace change, unfortunately when removing the window\nof the note from the screen the application would decide to remove also the\nomnipresent menu (because it is not necessary anymore).\n\nBecause we kept a pointer to an outdated WWindow, we would silently corrupt\nmemory, which would later cause a crash in an unrelated place (fortunately\nin this case it happened quite soon).\n\nThis patch adds a check to make sure the window we want to focus is still\na valid one, and if it is not we just ignore it to fall back on another\nmechanism already in place for picking the window to focus.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/bc4f3352b65aa2ffd96b26d8a41ae19f2584882e"},{"sha":"e03088ebe24cd8c12d4389687318c954953291a7","author":{"email":"5cdb077d9450aebad836d06fc0b94e46e51ec4a0@free.fr","name":"Christophe CURIS"},"message":"wmaker: fix non-portable int argument for printf in error message\n\nThe original code assumed that the sizeof returns a long int type, which is\ntrue on 64 bits platform but not on 32 bits platforms, as pointed by gcc.\n\nThe new code does an explicit conversions to 'int' (which should be enough\nfor that case) so the format specifier in printf will always be ok,\nwhatever platform Window Maker is compiled for.\n\nSigned-off-by: Christophe CURIS <christophe.curis@free.fr>","distinct":true,"url":"https://api.github.com/repos/d-torrance/wmaker/commits/e03088ebe24cd8c12d4389687318c954953291a7"}]}