{"action":"created","comment":{"url":"https://api.github.com/repos/geany/geany/pulls/comments/37425974","id":37425974,"diff_hunk":"@@ -35,29 +35,19 @@\n #include \"geanyplugin.h\"\t/* plugin API, always comes first */\n #include \"Scintilla.h\"\t/* for the SCNotification struct */\n \n-\n-/* These items are set by Geany before plugin_init() is called. */\n-GeanyPlugin\t\t*geany_plugin;\n-GeanyData\t\t*geany_data;\n-\n-\n-/* Check that the running Geany supports the plugin API version used below, and check\n- * for binary compatibility. */\n-PLUGIN_VERSION_CHECK(147)\n-\n-/* All plugins must set name, description, version and author. */\n-PLUGIN_SET_INFO(_(\"Demo\"), _(\"Example plugin.\"), \"0.1\" , _(\"The Geany developer team\"))\n-\n-\n static GtkWidget *main_menu_item = NULL;\n /* text to be shown in the plugin dialog */\n static gchar *welcome_text = NULL;\n \n \n-\n static gboolean on_editor_notify(GObject *object, GeanyEditor *editor,\n \t\t\t\t\t\t\t\t SCNotification *nt, gpointer data)\n {\n+\t/* Geany passes the plugin's GeanyPlugin pointer as user_data if it did not set\n+\t * it explicitely. This is specific to PluginCallbacks. */","path":"plugins/demoplugin.c","position":28,"original_position":28,"commit_id":"099583f1a4e52febc18cfa1b368137e5f6d3623f","original_commit_id":"099583f1a4e52febc18cfa1b368137e5f6d3623f","user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"body":"wouldn't it make more sense to pass the plugin data by default, like for `init`/`cleanup`/etc?","created_at":"2015-08-19T15:11:11Z","updated_at":"2015-08-19T15:11:11Z","html_url":"https://github.com/geany/geany/pull/469#discussion_r37425974","pull_request_url":"https://api.github.com/repos/geany/geany/pulls/469","_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/comments/37425974"},"html":{"href":"https://github.com/geany/geany/pull/469#discussion_r37425974"},"pull_request":{"href":"https://api.github.com/repos/geany/geany/pulls/469"}}},"pull_request":{"url":"https://api.github.com/repos/geany/geany/pulls/469","id":33302675,"html_url":"https://github.com/geany/geany/pull/469","diff_url":"https://github.com/geany/geany/pull/469.diff","patch_url":"https://github.com/geany/geany/pull/469.patch","issue_url":"https://api.github.com/repos/geany/geany/issues/469","number":469,"state":"open","locked":false,"title":"New hooks","user":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"body":"This is the new plugin loader mechanism we discussed on the mailing lists. Please review and comment. The initial commit explains a lot of details.","created_at":"2015-04-14T21:38:26Z","updated_at":"2015-08-19T15:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d205d76d8dcab593be64746cf213bf9ee987768e","assignee":null,"milestone":{"url":"https://api.github.com/repos/geany/geany/milestones/3","html_url":"https://github.com/geany/geany/milestones/1.26","labels_url":"https://api.github.com/repos/geany/geany/milestones/3/labels","id":1173856,"number":3,"title":"1.26","description":"","creator":{"login":"codebrainz","id":181177,"avatar_url":"https://avatars.githubusercontent.com/u/181177?v=3","gravatar_id":"","url":"https://api.github.com/users/codebrainz","html_url":"https://github.com/codebrainz","followers_url":"https://api.github.com/users/codebrainz/followers","following_url":"https://api.github.com/users/codebrainz/following{/other_user}","gists_url":"https://api.github.com/users/codebrainz/gists{/gist_id}","starred_url":"https://api.github.com/users/codebrainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebrainz/subscriptions","organizations_url":"https://api.github.com/users/codebrainz/orgs","repos_url":"https://api.github.com/users/codebrainz/repos","events_url":"https://api.github.com/users/codebrainz/events{/privacy}","received_events_url":"https://api.github.com/users/codebrainz/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":2,"state":"open","created_at":"2015-06-21T08:04:50Z","updated_at":"2015-08-04T00:06:24Z","due_on":"2015-11-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/geany/geany/pulls/469/commits","review_comments_url":"https://api.github.com/repos/geany/geany/pulls/469/comments","review_comment_url":"https://api.github.com/repos/geany/geany/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geany/geany/issues/469/comments","statuses_url":"https://api.github.com/repos/geany/geany/statuses/099583f1a4e52febc18cfa1b368137e5f6d3623f","head":{"label":"kugel-:new_hooks","ref":"new_hooks","sha":"099583f1a4e52febc18cfa1b368137e5f6d3623f","user":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"repo":{"id":2544402,"name":"geany","full_name":"kugel-/geany","owner":{"login":"kugel-","id":564520,"avatar_url":"https://avatars.githubusercontent.com/u/564520?v=3","gravatar_id":"","url":"https://api.github.com/users/kugel-","html_url":"https://github.com/kugel-","followers_url":"https://api.github.com/users/kugel-/followers","following_url":"https://api.github.com/users/kugel-/following{/other_user}","gists_url":"https://api.github.com/users/kugel-/gists{/gist_id}","starred_url":"https://api.github.com/users/kugel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kugel-/subscriptions","organizations_url":"https://api.github.com/users/kugel-/orgs","repos_url":"https://api.github.com/users/kugel-/repos","events_url":"https://api.github.com/users/kugel-/events{/privacy}","received_events_url":"https://api.github.com/users/kugel-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kugel-/geany","description":"A fast and lightweight IDE","fork":true,"url":"https://api.github.com/repos/kugel-/geany","forks_url":"https://api.github.com/repos/kugel-/geany/forks","keys_url":"https://api.github.com/repos/kugel-/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kugel-/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kugel-/geany/teams","hooks_url":"https://api.github.com/repos/kugel-/geany/hooks","issue_events_url":"https://api.github.com/repos/kugel-/geany/issues/events{/number}","events_url":"https://api.github.com/repos/kugel-/geany/events","assignees_url":"https://api.github.com/repos/kugel-/geany/assignees{/user}","branches_url":"https://api.github.com/repos/kugel-/geany/branches{/branch}","tags_url":"https://api.github.com/repos/kugel-/geany/tags","blobs_url":"https://api.github.com/repos/kugel-/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kugel-/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kugel-/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/kugel-/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kugel-/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/kugel-/geany/languages","stargazers_url":"https://api.github.com/repos/kugel-/geany/stargazers","contributors_url":"https://api.github.com/repos/kugel-/geany/contributors","subscribers_url":"https://api.github.com/repos/kugel-/geany/subscribers","subscription_url":"https://api.github.com/repos/kugel-/geany/subscription","commits_url":"https://api.github.com/repos/kugel-/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/kugel-/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/kugel-/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/kugel-/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/kugel-/geany/contents/{+path}","compare_url":"https://api.github.com/repos/kugel-/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kugel-/geany/merges","archive_url":"https://api.github.com/repos/kugel-/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kugel-/geany/downloads","issues_url":"https://api.github.com/repos/kugel-/geany/issues{/number}","pulls_url":"https://api.github.com/repos/kugel-/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/kugel-/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/kugel-/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kugel-/geany/labels{/name}","releases_url":"https://api.github.com/repos/kugel-/geany/releases{/id}","created_at":"2011-10-09T20:46:57Z","updated_at":"2015-07-28T08:28:33Z","pushed_at":"2015-08-19T14:32:26Z","git_url":"git://github.com/kugel-/geany.git","ssh_url":"git@github.com:kugel-/geany.git","clone_url":"https://github.com/kugel-/geany.git","svn_url":"https://github.com/kugel-/geany","homepage":"http://www.geany.org","size":41781,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"geany:master","ref":"master","sha":"c0898618f9a162913dfdddc74e2526019dcfb9ea","user":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"repo":{"id":2532922,"name":"geany","full_name":"geany/geany","owner":{"login":"geany","id":1108795,"avatar_url":"https://avatars.githubusercontent.com/u/1108795?v=3","gravatar_id":"","url":"https://api.github.com/users/geany","html_url":"https://github.com/geany","followers_url":"https://api.github.com/users/geany/followers","following_url":"https://api.github.com/users/geany/following{/other_user}","gists_url":"https://api.github.com/users/geany/gists{/gist_id}","starred_url":"https://api.github.com/users/geany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geany/subscriptions","organizations_url":"https://api.github.com/users/geany/orgs","repos_url":"https://api.github.com/users/geany/repos","events_url":"https://api.github.com/users/geany/events{/privacy}","received_events_url":"https://api.github.com/users/geany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geany/geany","description":"A fast and lightweight IDE","fork":false,"url":"https://api.github.com/repos/geany/geany","forks_url":"https://api.github.com/repos/geany/geany/forks","keys_url":"https://api.github.com/repos/geany/geany/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geany/geany/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geany/geany/teams","hooks_url":"https://api.github.com/repos/geany/geany/hooks","issue_events_url":"https://api.github.com/repos/geany/geany/issues/events{/number}","events_url":"https://api.github.com/repos/geany/geany/events","assignees_url":"https://api.github.com/repos/geany/geany/assignees{/user}","branches_url":"https://api.github.com/repos/geany/geany/branches{/branch}","tags_url":"https://api.github.com/repos/geany/geany/tags","blobs_url":"https://api.github.com/repos/geany/geany/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geany/geany/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geany/geany/git/refs{/sha}","trees_url":"https://api.github.com/repos/geany/geany/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geany/geany/statuses/{sha}","languages_url":"https://api.github.com/repos/geany/geany/languages","stargazers_url":"https://api.github.com/repos/geany/geany/stargazers","contributors_url":"https://api.github.com/repos/geany/geany/contributors","subscribers_url":"https://api.github.com/repos/geany/geany/subscribers","subscription_url":"https://api.github.com/repos/geany/geany/subscription","commits_url":"https://api.github.com/repos/geany/geany/commits{/sha}","git_commits_url":"https://api.github.com/repos/geany/geany/git/commits{/sha}","comments_url":"https://api.github.com/repos/geany/geany/comments{/number}","issue_comment_url":"https://api.github.com/repos/geany/geany/issues/comments{/number}","contents_url":"https://api.github.com/repos/geany/geany/contents/{+path}","compare_url":"https://api.github.com/repos/geany/geany/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geany/geany/merges","archive_url":"https://api.github.com/repos/geany/geany/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geany/geany/downloads","issues_url":"https://api.github.com/repos/geany/geany/issues{/number}","pulls_url":"https://api.github.com/repos/geany/geany/pulls{/number}","milestones_url":"https://api.github.com/repos/geany/geany/milestones{/number}","notifications_url":"https://api.github.com/repos/geany/geany/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geany/geany/labels{/name}","releases_url":"https://api.github.com/repos/geany/geany/releases{/id}","created_at":"2011-10-07T14:25:32Z","updated_at":"2015-08-19T12:26:33Z","pushed_at":"2015-08-19T14:32:27Z","git_url":"git://github.com/geany/geany.git","ssh_url":"git@github.com:geany/geany.git","clone_url":"https://github.com/geany/geany.git","svn_url":"https://github.com/geany/geany","homepage":"http://www.geany.org","size":50563,"stargazers_count":637,"watchers_count":637,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":161,"forks":234,"open_issues":161,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geany/geany/pulls/469"},"html":{"href":"https://github.com/geany/geany/pull/469"},"issue":{"href":"https://api.github.com/repos/geany/geany/issues/469"},"comments":{"href":"https://api.github.com/repos/geany/geany/issues/469/comments"},"review_comments":{"href":"https://api.github.com/repos/geany/geany/pulls/469/comments"},"review_comment":{"href":"https://api.github.com/repos/geany/geany/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geany/geany/pulls/469/commits"},"statuses":{"href":"https://api.github.com/repos/geany/geany/statuses/099583f1a4e52febc18cfa1b368137e5f6d3623f"}}}}