{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/35828898","id":35828898,"diff_hunk":"@@ -2485,6 +2496,34 @@ module FourSlash {\n         };\r\n     }\r\n \r\n+    function containTSConfigJson(files: FourSlashFile[]): boolean {\r\n+        for (let i = 0; i < files.length; ++i) {\r\n+            if (files[i].fileOptions['Filename'] === 'tsconfig.json') {\r\n+                return true;\r\n+            }\r\n+        }\r\n+        return false;\r\n+    }\r\n+\r\n+    function getNonFileNameOptionInFileList(files: FourSlashFile[]): string {\r\n+        for (let i = 0; i < files.length; ++i) {\r\n+            let option = getNonFileNameOptionInObject(files[i].fileOptions);\r\n+            if (option !== null) {\r\n+                return option;\r\n+            }\r\n+        }\r\n+        return null;\r","path":"src/harness/fourslash.ts","position":38,"original_position":38,"commit_id":"90e31adea85e12d0e6c2004d29c2dbfd31f898fa","original_commit_id":"90e31adea85e12d0e6c2004d29c2dbfd31f898fa","user":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars.githubusercontent.com/u/8000722?v=3","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"body":"do not use `null` use `undefined`.","created_at":"2015-07-30T00:47:57Z","updated_at":"2015-07-30T00:47:57Z","html_url":"https://github.com/Microsoft/TypeScript/pull/3904#discussion_r35828898","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/35828898"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/3904#discussion_r35828898"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904","id":40205052,"html_url":"https://github.com/Microsoft/TypeScript/pull/3904","diff_url":"https://github.com/Microsoft/TypeScript/pull/3904.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/3904.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/3904","number":3904,"state":"open","locked":false,"title":"Fix bug: fourslash test does not recognize tsconfig.json.","user":{"login":"hoanhtien","id":1707813,"avatar_url":"https://avatars.githubusercontent.com/u/1707813?v=3","gravatar_id":"","url":"https://api.github.com/users/hoanhtien","html_url":"https://github.com/hoanhtien","followers_url":"https://api.github.com/users/hoanhtien/followers","following_url":"https://api.github.com/users/hoanhtien/following{/other_user}","gists_url":"https://api.github.com/users/hoanhtien/gists{/gist_id}","starred_url":"https://api.github.com/users/hoanhtien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoanhtien/subscriptions","organizations_url":"https://api.github.com/users/hoanhtien/orgs","repos_url":"https://api.github.com/users/hoanhtien/repos","events_url":"https://api.github.com/users/hoanhtien/events{/privacy}","received_events_url":"https://api.github.com/users/hoanhtien/received_events","type":"User","site_admin":false},"body":"Adding `// @Filename: tsconfig.json` to a fourslash test makes no effect. The reason is we are using `ts.readConfigFile()` which reads the config file from disk. Change to `this.host.readFile()` instead.","created_at":"2015-07-17T07:01:32Z","updated_at":"2015-07-30T00:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074f5e3a273c6c98e21d7e2103fa2f08575261e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/3904/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/90e31adea85e12d0e6c2004d29c2dbfd31f898fa","head":{"label":"hoanhtien:tsconfigTest","ref":"tsconfigTest","sha":"90e31adea85e12d0e6c2004d29c2dbfd31f898fa","user":{"login":"hoanhtien","id":1707813,"avatar_url":"https://avatars.githubusercontent.com/u/1707813?v=3","gravatar_id":"","url":"https://api.github.com/users/hoanhtien","html_url":"https://github.com/hoanhtien","followers_url":"https://api.github.com/users/hoanhtien/followers","following_url":"https://api.github.com/users/hoanhtien/following{/other_user}","gists_url":"https://api.github.com/users/hoanhtien/gists{/gist_id}","starred_url":"https://api.github.com/users/hoanhtien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoanhtien/subscriptions","organizations_url":"https://api.github.com/users/hoanhtien/orgs","repos_url":"https://api.github.com/users/hoanhtien/repos","events_url":"https://api.github.com/users/hoanhtien/events{/privacy}","received_events_url":"https://api.github.com/users/hoanhtien/received_events","type":"User","site_admin":false},"repo":{"id":39095405,"name":"TypeScript","full_name":"hoanhtien/TypeScript","owner":{"login":"hoanhtien","id":1707813,"avatar_url":"https://avatars.githubusercontent.com/u/1707813?v=3","gravatar_id":"","url":"https://api.github.com/users/hoanhtien","html_url":"https://github.com/hoanhtien","followers_url":"https://api.github.com/users/hoanhtien/followers","following_url":"https://api.github.com/users/hoanhtien/following{/other_user}","gists_url":"https://api.github.com/users/hoanhtien/gists{/gist_id}","starred_url":"https://api.github.com/users/hoanhtien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoanhtien/subscriptions","organizations_url":"https://api.github.com/users/hoanhtien/orgs","repos_url":"https://api.github.com/users/hoanhtien/repos","events_url":"https://api.github.com/users/hoanhtien/events{/privacy}","received_events_url":"https://api.github.com/users/hoanhtien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoanhtien/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/hoanhtien/TypeScript","forks_url":"https://api.github.com/repos/hoanhtien/TypeScript/forks","keys_url":"https://api.github.com/repos/hoanhtien/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoanhtien/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoanhtien/TypeScript/teams","hooks_url":"https://api.github.com/repos/hoanhtien/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/hoanhtien/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/hoanhtien/TypeScript/events","assignees_url":"https://api.github.com/repos/hoanhtien/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/hoanhtien/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/hoanhtien/TypeScript/tags","blobs_url":"https://api.github.com/repos/hoanhtien/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoanhtien/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoanhtien/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoanhtien/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoanhtien/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/hoanhtien/TypeScript/languages","stargazers_url":"https://api.github.com/repos/hoanhtien/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/hoanhtien/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/hoanhtien/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/hoanhtien/TypeScript/subscription","commits_url":"https://api.github.com/repos/hoanhtien/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoanhtien/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoanhtien/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoanhtien/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoanhtien/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/hoanhtien/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoanhtien/TypeScript/merges","archive_url":"https://api.github.com/repos/hoanhtien/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoanhtien/TypeScript/downloads","issues_url":"https://api.github.com/repos/hoanhtien/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/hoanhtien/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/hoanhtien/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/hoanhtien/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoanhtien/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/hoanhtien/TypeScript/releases{/id}","created_at":"2015-07-14T19:15:22Z","updated_at":"2015-07-14T19:15:57Z","pushed_at":"2015-07-28T04:03:56Z","git_url":"git://github.com/hoanhtien/TypeScript.git","ssh_url":"git@github.com:hoanhtien/TypeScript.git","clone_url":"https://github.com/hoanhtien/TypeScript.git","svn_url":"https://github.com/hoanhtien/TypeScript","homepage":"http://www.typescriptlang.org","size":186526,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d0bc070fb8bcd90947f3f2005647c074736ec356","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","created_at":"2014-06-17T15:28:39Z","updated_at":"2015-07-29T23:29:39Z","pushed_at":"2015-07-30T00:17:49Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":952276,"stargazers_count":6101,"watchers_count":6101,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":670,"mirror_url":null,"open_issues_count":729,"forks":670,"open_issues":729,"watchers":6101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/3904"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/3904"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/3904/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/3904/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/90e31adea85e12d0e6c2004d29c2dbfd31f898fa"}}}}