{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/41837427","id":41837427,"diff_hunk":"@@ -33,14 +33,15 @@\n export interface PipeTransform { transform(value: any, args: any[]): any; }\n \n /**\n- * To create a stateful Pipe, you should implement this interface.\n+ * To create a stateful Pipe, you should implement this interface and set the `pure`\n+ * parameter to `false` in the {@link PipeMetadata}.\n  *\n  * A stateful pipe may produce different output, given the same input. It is\n  * likely that a stateful pipe may contain state that should be cleaned up when\n  * a binding is destroyed. For example, a subscription to a stream of data may need to\n  * be disposed, or an interval may need to be cleared.\n  *\n- * ### Example ([live demo](http://plnkr.co/edit/hlaejwQAmWayxwc5YXQE?p=preview))\n+ * ### Example ([live demo](http://plnkr.co/edit/i8pm5brO4sPaLxBx56MR?p=preview))","path":"modules/angular2/src/core/change_detection/pipe_transform.ts","position":14,"original_position":14,"commit_id":"8ff78b92d44858958978a6f39371c4b298375999","original_commit_id":"8ff78b92d44858958978a6f39371c4b298375999","user":{"login":"mgechev","id":455023,"avatar_url":"https://avatars.githubusercontent.com/u/455023?v=3","gravatar_id":"","url":"https://api.github.com/users/mgechev","html_url":"https://github.com/mgechev","followers_url":"https://api.github.com/users/mgechev/followers","following_url":"https://api.github.com/users/mgechev/following{/other_user}","gists_url":"https://api.github.com/users/mgechev/gists{/gist_id}","starred_url":"https://api.github.com/users/mgechev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgechev/subscriptions","organizations_url":"https://api.github.com/users/mgechev/orgs","repos_url":"https://api.github.com/users/mgechev/repos","events_url":"https://api.github.com/users/mgechev/events{/privacy}","received_events_url":"https://api.github.com/users/mgechev/received_events","type":"User","site_admin":false},"body":"I cant help here // cc @jeffbcross","created_at":"2015-10-13T08:09:17Z","updated_at":"2015-10-13T08:09:17Z","html_url":"https://github.com/angular/angular/pull/4667#discussion_r41837427","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/4667","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/41837427"},"html":{"href":"https://github.com/angular/angular/pull/4667#discussion_r41837427"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/4667"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/4667","id":47368917,"html_url":"https://github.com/angular/angular/pull/4667","diff_url":"https://github.com/angular/angular/pull/4667.diff","patch_url":"https://github.com/angular/angular/pull/4667.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/4667","number":4667,"state":"open","locked":false,"title":"docs(PipeTransform): added pure parameter","user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars.githubusercontent.com/u/265378?v=3","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"body":"The documentation was outdated since alpha 38 when the `pure` parameter was added to the `PipeMetadata`.","created_at":"2015-10-11T15:18:40Z","updated_at":"2015-10-13T08:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032be6a7e0c013384811cfd540fe3cef60a0617e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/4667/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/4667/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/4667/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/8ff78b92d44858958978a6f39371c4b298375999","head":{"label":"ocombe:patch-2","ref":"patch-2","sha":"8ff78b92d44858958978a6f39371c4b298375999","user":{"login":"ocombe","id":265378,"avatar_url":"https://avatars.githubusercontent.com/u/265378?v=3","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"repo":{"id":42118382,"name":"angular","full_name":"ocombe/angular","owner":{"login":"ocombe","id":265378,"avatar_url":"https://avatars.githubusercontent.com/u/265378?v=3","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ocombe/angular","description":"","fork":true,"url":"https://api.github.com/repos/ocombe/angular","forks_url":"https://api.github.com/repos/ocombe/angular/forks","keys_url":"https://api.github.com/repos/ocombe/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocombe/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocombe/angular/teams","hooks_url":"https://api.github.com/repos/ocombe/angular/hooks","issue_events_url":"https://api.github.com/repos/ocombe/angular/issues/events{/number}","events_url":"https://api.github.com/repos/ocombe/angular/events","assignees_url":"https://api.github.com/repos/ocombe/angular/assignees{/user}","branches_url":"https://api.github.com/repos/ocombe/angular/branches{/branch}","tags_url":"https://api.github.com/repos/ocombe/angular/tags","blobs_url":"https://api.github.com/repos/ocombe/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocombe/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocombe/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocombe/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocombe/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ocombe/angular/languages","stargazers_url":"https://api.github.com/repos/ocombe/angular/stargazers","contributors_url":"https://api.github.com/repos/ocombe/angular/contributors","subscribers_url":"https://api.github.com/repos/ocombe/angular/subscribers","subscription_url":"https://api.github.com/repos/ocombe/angular/subscription","commits_url":"https://api.github.com/repos/ocombe/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocombe/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocombe/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocombe/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocombe/angular/contents/{+path}","compare_url":"https://api.github.com/repos/ocombe/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocombe/angular/merges","archive_url":"https://api.github.com/repos/ocombe/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocombe/angular/downloads","issues_url":"https://api.github.com/repos/ocombe/angular/issues{/number}","pulls_url":"https://api.github.com/repos/ocombe/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ocombe/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ocombe/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocombe/angular/labels{/name}","releases_url":"https://api.github.com/repos/ocombe/angular/releases{/id}","created_at":"2015-09-08T14:42:15Z","updated_at":"2015-09-08T14:42:18Z","pushed_at":"2015-10-11T16:26:58Z","git_url":"git://github.com/ocombe/angular.git","ssh_url":"git@github.com:ocombe/angular.git","clone_url":"https://github.com/ocombe/angular.git","svn_url":"https://github.com/ocombe/angular","homepage":"https://angular.io","size":16571,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"0c1f9dab548d7298e440ada9718bf9bbace15744","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-10-13T08:06:52Z","pushed_at":"2015-10-13T07:59:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":62199,"stargazers_count":5772,"watchers_count":5772,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1570,"mirror_url":null,"open_issues_count":531,"forks":1570,"open_issues":531,"watchers":5772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/4667"},"html":{"href":"https://github.com/angular/angular/pull/4667"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/4667"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/4667/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/4667/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/4667/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/8ff78b92d44858958978a6f39371c4b298375999"}}}}