{"action":"created","issue":{"url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/65","labels_url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/65/comments","events_url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/65/events","html_url":"https://github.com/wmde/WikibaseInternalSerialization/pull/65","id":73013269,"number":65,"title":"Fix minor Scrutinizer issues","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-04T12:56:46Z","updated_at":"2015-05-04T14:25:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/pulls/65","html_url":"https://github.com/wmde/WikibaseInternalSerialization/pull/65","diff_url":"https://github.com/wmde/WikibaseInternalSerialization/pull/65.diff","patch_url":"https://github.com/wmde/WikibaseInternalSerialization/pull/65.patch"},"body":"* Two empty catch blocks (this also reverts #62),\r\n* an unused parameter\r\n* and an unused import."},"comment":{"url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/comments/98726050","html_url":"https://github.com/wmde/WikibaseInternalSerialization/pull/65#issuecomment-98726050","issue_url":"https://api.github.com/repos/wmde/WikibaseInternalSerialization/issues/65","id":98726050,"user":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T14:25:06Z","updated_at":"2015-05-04T14:25:06Z","body":"Good catch - that was indeed odd. With this change the later exception might be seen by the caller. Which is odd, since this will be a specific failure of the second deserializer. We probably ought to either throw a general error \"not a valid old serialization and not a valid new serialization\" or provide the details of both failures."}}