{"action":"created","comment":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/comments/29600233","id":29600233,"diff_hunk":"@@ -29,7 +29,7 @@ public Object create(String type, ApiRequest request, ResourceManager next) {\n         }\n \n         Environment existingEnv = objectManager.findOne(Environment.class, ENVIRONMENT.NAME, env.getName(),","path":"code/iaas/service-discovery/api/src/main/java/io/cattle/platform/servicediscovery/api/filter/EnvironmentCreateValidationFilter.java","position":3,"original_position":3,"commit_id":"554039c6aefe453e3aafd263c0dadb49c94b304b","original_commit_id":"554039c6aefe453e3aafd263c0dadb49c94b304b","user":{"login":"ibuildthecloud","id":1754002,"avatar_url":"https://avatars.githubusercontent.com/u/1754002?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuildthecloud","html_url":"https://github.com/ibuildthecloud","followers_url":"https://api.github.com/users/ibuildthecloud/followers","following_url":"https://api.github.com/users/ibuildthecloud/following{/other_user}","gists_url":"https://api.github.com/users/ibuildthecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuildthecloud/subscriptions","organizations_url":"https://api.github.com/users/ibuildthecloud/orgs","repos_url":"https://api.github.com/users/ibuildthecloud/repos","events_url":"https://api.github.com/users/ibuildthecloud/events{/privacy}","received_events_url":"https://api.github.com/users/ibuildthecloud/received_events","type":"User","site_admin":false},"body":"You get a resource manager by injecting `io.github.ibuildthecloud.gdapi.request.resource.ResourceManagerLocator` and then use list()","created_at":"2015-05-04T16:45:38Z","updated_at":"2015-05-04T16:45:38Z","html_url":"https://github.com/rancherio/cattle/pull/392#discussion_r29600233","pull_request_url":"https://api.github.com/repos/rancherio/cattle/pulls/392","_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments/29600233"},"html":{"href":"https://github.com/rancherio/cattle/pull/392#discussion_r29600233"},"pull_request":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/392","id":34564445,"html_url":"https://github.com/rancherio/cattle/pull/392","diff_url":"https://github.com/rancherio/cattle/pull/392.diff","patch_url":"https://github.com/rancherio/cattle/pull/392.patch","issue_url":"https://api.github.com/repos/rancherio/cattle/issues/392","number":392,"state":"open","locked":false,"title":"Service discovery bug fixes","user":{"login":"alena1108","id":1562176,"avatar_url":"https://avatars.githubusercontent.com/u/1562176?v=3","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"body":"1) Missing state transitions are added; that would fix:\r\n\r\nhttps://github.com/rancherio/rancher/issues/678\r\nhttps://github.com/rancherio/rancher/issues/676\r\n\r\n2) Environment name is unique within the account, not globally\r\n\r\nhttps://github.com/rancherio/rancher/issues/659\r\n\r\n3) Disallow to remove the lb that was created as a part of LB service. This type of lb can be removed only when its service is removed","created_at":"2015-05-01T20:23:11Z","updated_at":"2015-05-04T16:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c75fe1afaaec3bc90599ee013f9c240f4c52e2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancherio/cattle/pulls/392/commits","review_comments_url":"https://api.github.com/repos/rancherio/cattle/pulls/392/comments","review_comment_url":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancherio/cattle/issues/392/comments","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/554039c6aefe453e3aafd263c0dadb49c94b304b","head":{"label":"alena1108:requested","ref":"requested","sha":"554039c6aefe453e3aafd263c0dadb49c94b304b","user":{"login":"alena1108","id":1562176,"avatar_url":"https://avatars.githubusercontent.com/u/1562176?v=3","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"repo":{"id":28929339,"name":"cattle","full_name":"alena1108/cattle","owner":{"login":"alena1108","id":1562176,"avatar_url":"https://avatars.githubusercontent.com/u/1562176?v=3","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alena1108/cattle","description":"Infrastructure orchestration platform","fork":true,"url":"https://api.github.com/repos/alena1108/cattle","forks_url":"https://api.github.com/repos/alena1108/cattle/forks","keys_url":"https://api.github.com/repos/alena1108/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alena1108/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alena1108/cattle/teams","hooks_url":"https://api.github.com/repos/alena1108/cattle/hooks","issue_events_url":"https://api.github.com/repos/alena1108/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/alena1108/cattle/events","assignees_url":"https://api.github.com/repos/alena1108/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/alena1108/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/alena1108/cattle/tags","blobs_url":"https://api.github.com/repos/alena1108/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alena1108/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alena1108/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alena1108/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alena1108/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/alena1108/cattle/languages","stargazers_url":"https://api.github.com/repos/alena1108/cattle/stargazers","contributors_url":"https://api.github.com/repos/alena1108/cattle/contributors","subscribers_url":"https://api.github.com/repos/alena1108/cattle/subscribers","subscription_url":"https://api.github.com/repos/alena1108/cattle/subscription","commits_url":"https://api.github.com/repos/alena1108/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alena1108/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alena1108/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alena1108/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/alena1108/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/alena1108/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alena1108/cattle/merges","archive_url":"https://api.github.com/repos/alena1108/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alena1108/cattle/downloads","issues_url":"https://api.github.com/repos/alena1108/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/alena1108/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/alena1108/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/alena1108/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alena1108/cattle/labels{/name}","releases_url":"https://api.github.com/repos/alena1108/cattle/releases{/id}","created_at":"2015-01-07T19:10:53Z","updated_at":"2015-01-12T17:27:50Z","pushed_at":"2015-05-03T07:01:08Z","git_url":"git://github.com/alena1108/cattle.git","ssh_url":"git@github.com:alena1108/cattle.git","clone_url":"https://github.com/alena1108/cattle.git","svn_url":"https://github.com/alena1108/cattle","homepage":"","size":18495,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancherio:master","ref":"master","sha":"4bf0588983f91ce9ef14064fa177b713baa0f321","user":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"repo":{"id":18023059,"name":"cattle","full_name":"rancherio/cattle","owner":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancherio/cattle","description":"Infrastructure orchestration platform","fork":false,"url":"https://api.github.com/repos/rancherio/cattle","forks_url":"https://api.github.com/repos/rancherio/cattle/forks","keys_url":"https://api.github.com/repos/rancherio/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancherio/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancherio/cattle/teams","hooks_url":"https://api.github.com/repos/rancherio/cattle/hooks","issue_events_url":"https://api.github.com/repos/rancherio/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/rancherio/cattle/events","assignees_url":"https://api.github.com/repos/rancherio/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/rancherio/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/rancherio/cattle/tags","blobs_url":"https://api.github.com/repos/rancherio/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancherio/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancherio/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancherio/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/rancherio/cattle/languages","stargazers_url":"https://api.github.com/repos/rancherio/cattle/stargazers","contributors_url":"https://api.github.com/repos/rancherio/cattle/contributors","subscribers_url":"https://api.github.com/repos/rancherio/cattle/subscribers","subscription_url":"https://api.github.com/repos/rancherio/cattle/subscription","commits_url":"https://api.github.com/repos/rancherio/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancherio/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancherio/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancherio/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancherio/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/rancherio/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancherio/cattle/merges","archive_url":"https://api.github.com/repos/rancherio/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancherio/cattle/downloads","issues_url":"https://api.github.com/repos/rancherio/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/rancherio/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/rancherio/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/rancherio/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancherio/cattle/labels{/name}","releases_url":"https://api.github.com/repos/rancherio/cattle/releases{/id}","created_at":"2014-03-23T00:19:52Z","updated_at":"2015-05-04T15:52:45Z","pushed_at":"2015-05-04T16:25:38Z","git_url":"git://github.com/rancherio/cattle.git","ssh_url":"git@github.com:rancherio/cattle.git","clone_url":"https://github.com/rancherio/cattle.git","svn_url":"https://github.com/rancherio/cattle","homepage":"","size":23264,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":88,"forks":31,"open_issues":88,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/392"},"html":{"href":"https://github.com/rancherio/cattle/pull/392"},"issue":{"href":"https://api.github.com/repos/rancherio/cattle/issues/392"},"comments":{"href":"https://api.github.com/repos/rancherio/cattle/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/rancherio/cattle/statuses/554039c6aefe453e3aafd263c0dadb49c94b304b"}}}}