{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55","id":44643037,"html_url":"https://github.com/tylerwalts/puppet-jdk_oracle/pull/55","diff_url":"https://github.com/tylerwalts/puppet-jdk_oracle/pull/55.diff","patch_url":"https://github.com/tylerwalts/puppet-jdk_oracle/pull/55.patch","issue_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/55","number":55,"state":"closed","locked":false,"title":"make sure to configure the specified java to be the \"best\" version","user":{"login":"fraenki","id":909706,"avatar_url":"https://avatars.githubusercontent.com/u/909706?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"body":"On Ubuntu 14.04 I've updated from Oracle JDK 1.8.0_51-b16 to JDK 1.8.0_60-b27. I had `$default_java=true` set and thus was expecting the module would change the default Java to the new version. \r\n\r\nApparently the module installed the new Java, but it failed to configure `update-alternatives` accordingly:\r\n\r\n```\r\n# update-alternatives --display java\r\njava - manual mode\r\n  link currently points to /data/jdk1.8.0_51/bin/java\r\n/data/jdk1.8.0_51/bin/java - priority 20000\r\n/data/jdk1.8.0_60/bin/java - priority 20000\r\nCurrent 'best' version is '/data/jdk1.8.0_51/bin/java'.\r\n```\r\nAs you can see, the \"best\" (and therefore symlinked) version is still 1.8.0_51-b16.\r\n\r\nThis PR addresses this and executes a `updates-alternatives --set` to actually activate the specified version.","created_at":"2015-09-10T09:01:58Z","updated_at":"2015-09-10T19:39:42Z","closed_at":"2015-09-10T19:39:42Z","merged_at":"2015-09-10T19:39:42Z","merge_commit_sha":"5b6166f7cd107ae05d461acee39a88e42e9a0763","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55/commits","review_comments_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55/comments","review_comment_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/55/comments","statuses_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/statuses/707414d11c4f748ba8b99b4a74ba3ec13895a498","head":{"label":"fraenki:fix_ubuntu_alternatives","ref":"fix_ubuntu_alternatives","sha":"707414d11c4f748ba8b99b4a74ba3ec13895a498","user":{"login":"fraenki","id":909706,"avatar_url":"https://avatars.githubusercontent.com/u/909706?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"repo":{"id":42232981,"name":"puppet-jdk_oracle","full_name":"fraenki/puppet-jdk_oracle","owner":{"login":"fraenki","id":909706,"avatar_url":"https://avatars.githubusercontent.com/u/909706?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenki","html_url":"https://github.com/fraenki","followers_url":"https://api.github.com/users/fraenki/followers","following_url":"https://api.github.com/users/fraenki/following{/other_user}","gists_url":"https://api.github.com/users/fraenki/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenki/subscriptions","organizations_url":"https://api.github.com/users/fraenki/orgs","repos_url":"https://api.github.com/users/fraenki/repos","events_url":"https://api.github.com/users/fraenki/events{/privacy}","received_events_url":"https://api.github.com/users/fraenki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fraenki/puppet-jdk_oracle","description":"Puppet module to install JDK from oracle using wget","fork":true,"url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle","forks_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/forks","keys_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/teams","hooks_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/hooks","issue_events_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/issues/events{/number}","events_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/events","assignees_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/assignees{/user}","branches_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/branches{/branch}","tags_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/tags","blobs_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/git/refs{/sha}","trees_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/statuses/{sha}","languages_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/languages","stargazers_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/stargazers","contributors_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/contributors","subscribers_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/subscribers","subscription_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/subscription","commits_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/commits{/sha}","git_commits_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/git/commits{/sha}","comments_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/comments{/number}","issue_comment_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/issues/comments{/number}","contents_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/contents/{+path}","compare_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/merges","archive_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/downloads","issues_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/issues{/number}","pulls_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/pulls{/number}","milestones_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/milestones{/number}","notifications_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/labels{/name}","releases_url":"https://api.github.com/repos/fraenki/puppet-jdk_oracle/releases{/id}","created_at":"2015-09-10T08:42:33Z","updated_at":"2015-09-10T08:42:34Z","pushed_at":"2015-09-10T09:06:36Z","git_url":"git://github.com/fraenki/puppet-jdk_oracle.git","ssh_url":"git@github.com:fraenki/puppet-jdk_oracle.git","clone_url":"https://github.com/fraenki/puppet-jdk_oracle.git","svn_url":"https://github.com/fraenki/puppet-jdk_oracle","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tylerwalts:master","ref":"master","sha":"8b2fd4906716f185fa745372ce65ac533c613ba3","user":{"login":"tylerwalts","id":346433,"avatar_url":"https://avatars.githubusercontent.com/u/346433?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerwalts","html_url":"https://github.com/tylerwalts","followers_url":"https://api.github.com/users/tylerwalts/followers","following_url":"https://api.github.com/users/tylerwalts/following{/other_user}","gists_url":"https://api.github.com/users/tylerwalts/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerwalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerwalts/subscriptions","organizations_url":"https://api.github.com/users/tylerwalts/orgs","repos_url":"https://api.github.com/users/tylerwalts/repos","events_url":"https://api.github.com/users/tylerwalts/events{/privacy}","received_events_url":"https://api.github.com/users/tylerwalts/received_events","type":"User","site_admin":false},"repo":{"id":12024956,"name":"puppet-jdk_oracle","full_name":"tylerwalts/puppet-jdk_oracle","owner":{"login":"tylerwalts","id":346433,"avatar_url":"https://avatars.githubusercontent.com/u/346433?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerwalts","html_url":"https://github.com/tylerwalts","followers_url":"https://api.github.com/users/tylerwalts/followers","following_url":"https://api.github.com/users/tylerwalts/following{/other_user}","gists_url":"https://api.github.com/users/tylerwalts/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerwalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerwalts/subscriptions","organizations_url":"https://api.github.com/users/tylerwalts/orgs","repos_url":"https://api.github.com/users/tylerwalts/repos","events_url":"https://api.github.com/users/tylerwalts/events{/privacy}","received_events_url":"https://api.github.com/users/tylerwalts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylerwalts/puppet-jdk_oracle","description":"Puppet module to install JDK from oracle using wget","fork":false,"url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle","forks_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/forks","keys_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/teams","hooks_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/hooks","issue_events_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/events{/number}","events_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/events","assignees_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/assignees{/user}","branches_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/branches{/branch}","tags_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/tags","blobs_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/languages","stargazers_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/stargazers","contributors_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/contributors","subscribers_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/subscribers","subscription_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/subscription","commits_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/contents/{+path}","compare_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/merges","archive_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/downloads","issues_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues{/number}","pulls_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/labels{/name}","releases_url":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/releases{/id}","created_at":"2013-08-10T18:26:11Z","updated_at":"2015-08-28T15:04:58Z","pushed_at":"2015-09-10T19:39:42Z","git_url":"git://github.com/tylerwalts/puppet-jdk_oracle.git","ssh_url":"git@github.com:tylerwalts/puppet-jdk_oracle.git","clone_url":"https://github.com/tylerwalts/puppet-jdk_oracle.git","svn_url":"https://github.com/tylerwalts/puppet-jdk_oracle","homepage":null,"size":685,"stargazers_count":5,"watchers_count":5,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":7,"forks":36,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55"},"html":{"href":"https://github.com/tylerwalts/puppet-jdk_oracle/pull/55"},"issue":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/55"},"comments":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/tylerwalts/puppet-jdk_oracle/statuses/707414d11c4f748ba8b99b4a74ba3ec13895a498"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tylerwalts","id":346433,"avatar_url":"https://avatars.githubusercontent.com/u/346433?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerwalts","html_url":"https://github.com/tylerwalts","followers_url":"https://api.github.com/users/tylerwalts/followers","following_url":"https://api.github.com/users/tylerwalts/following{/other_user}","gists_url":"https://api.github.com/users/tylerwalts/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerwalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerwalts/subscriptions","organizations_url":"https://api.github.com/users/tylerwalts/orgs","repos_url":"https://api.github.com/users/tylerwalts/repos","events_url":"https://api.github.com/users/tylerwalts/events{/privacy}","received_events_url":"https://api.github.com/users/tylerwalts/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":22,"deletions":0,"changed_files":1}}