{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/46583243","id":46583243,"diff_hunk":"@@ -34,7 +35,7 @@ std::string HelpMessageCli()\n     strUsage += HelpMessageOpt(\"-datadir=<dir>\", _(\"Specify data directory\"));\n     AppendParamsHelpMessages(strUsage);\n     strUsage += HelpMessageOpt(\"-rpcconnect=<ip>\", strprintf(_(\"Send commands to node running on <ip> (default: %s)\"), DEFAULT_RPCCONNECT));\n-    strUsage += HelpMessageOpt(\"-rpcport=<port>\", strprintf(_(\"Connect to JSON-RPC on <port> (default: %u or testnet: %u)\"), BaseParams(CBaseChainParams::MAIN).RPCPort(), BaseParams(CBaseChainParams::TESTNET).RPCPort()));\n+    strUsage += HelpMessageOpt(\"-rpcport=<port>\", strprintf(_(\"Connect to JSON-RPC on <port> (default: %u)\"), defaultBaseParams->RPCPort()));","path":"src/bitcoin-cli.cpp","position":13,"original_position":13,"commit_id":"dd3547118df166704061fdce3aabb198236c8fca","original_commit_id":"d4bb7a8a7d587ff8b911f9fc752e51f915c84058","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"body":"well, 2 more.","created_at":"2015-12-03T17:31:48Z","updated_at":"2015-12-03T17:31:48Z","html_url":"https://github.com/bitcoin/bitcoin/pull/6907#discussion_r46583243","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/46583243"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6907#discussion_r46583243"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907","id":49200498,"html_url":"https://github.com/bitcoin/bitcoin/pull/6907","diff_url":"https://github.com/bitcoin/bitcoin/pull/6907.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6907.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907","number":6907,"state":"open","locked":false,"title":"Chainparams: Use a regular factory for creating chainparams","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"body":"This makes it simpler for people to create new testchains in their own branches by removing the need to create a new static global variable for the new chains.\r\n\r\nIt also prepares chainparams and chainparamsbase to be cleaned out of globals by moving the globals and related functions (```Params(), SelectParams()```, etc) outside, maybe to globals/server.o and globals/common.o respectively.\r\n\r\nBut that would need another PR after this, something @theuni has been wanting to do for some time.\r\nI would prefer to do this first to be able to leave the 2 factories (which don't need to depend on any global) where they are. \r\nPart of #6382","created_at":"2015-10-29T21:11:00Z","updated_at":"2015-12-03T17:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d178033de029e911218af2a2f2040bc30fc831e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/dd3547118df166704061fdce3aabb198236c8fca","head":{"label":"jtimon:chainparams-factory-0.12.99","ref":"chainparams-factory-0.12.99","sha":"dd3547118df166704061fdce3aabb198236c8fca","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"repo":{"id":17504501,"name":"bitcoin","full_name":"jtimon/bitcoin","owner":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtimon/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jtimon/bitcoin","forks_url":"https://api.github.com/repos/jtimon/bitcoin/forks","keys_url":"https://api.github.com/repos/jtimon/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtimon/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtimon/bitcoin/teams","hooks_url":"https://api.github.com/repos/jtimon/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jtimon/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jtimon/bitcoin/events","assignees_url":"https://api.github.com/repos/jtimon/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jtimon/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jtimon/bitcoin/tags","blobs_url":"https://api.github.com/repos/jtimon/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtimon/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtimon/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtimon/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtimon/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jtimon/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jtimon/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jtimon/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jtimon/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jtimon/bitcoin/subscription","commits_url":"https://api.github.com/repos/jtimon/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtimon/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtimon/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtimon/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtimon/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jtimon/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtimon/bitcoin/merges","archive_url":"https://api.github.com/repos/jtimon/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtimon/bitcoin/downloads","issues_url":"https://api.github.com/repos/jtimon/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jtimon/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jtimon/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jtimon/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtimon/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jtimon/bitcoin/releases{/id}","created_at":"2014-03-07T06:02:15Z","updated_at":"2014-07-27T14:54:19Z","pushed_at":"2015-12-03T15:30:16Z","git_url":"git://github.com/jtimon/bitcoin.git","ssh_url":"git@github.com:jtimon/bitcoin.git","clone_url":"https://github.com/jtimon/bitcoin.git","svn_url":"https://github.com/jtimon/bitcoin","homepage":"https://bitcoin.org/en/download","size":61795,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"c12ff995f7d70aafb12f34887fb64aa7482bbc85","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-12-03T16:14:37Z","pushed_at":"2015-12-03T16:39:51Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":100403,"stargazers_count":7912,"watchers_count":7912,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5435,"mirror_url":null,"open_issues_count":400,"forks":5435,"open_issues":400,"watchers":7912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6907"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6907/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6907/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/dd3547118df166704061fdce3aabb198236c8fca"}}}}