{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/33254167","id":33254167,"diff_hunk":"@@ -5,52 +5,50 @@\n \n // Error details dialog styles\n $w: 560px;\n-$c: #649DD0;\n \n-.TwitterImportDetails {}\n-.TwitterImportDetails-header .Dialog-headerIcon {\n-  border-color: $c;\n-  color: $c;\n-}\n-.TwitterImportDetails-body {\n+.BackgroundPollingDetails {}\n+.BackgroundPollingDetails-body {\n   @include display-flex();\n   @include justify-content(flex-start);\n   @include align-items(center);\n   min-width: initial;\n   width: $w;\n }\n-.TwitterImportDetails-body {\n+.Dialog-body.BackgroundPollingDetails-body {\n   min-width: initial;\n   width: $w;\n+  border-bottom: 1px solid #ddd;\n }\n-.TwitterImportDetails-icon {\n+.Dialog-body.BackgroundPollingDetails-body--noBorderTop { border-top: 0 }\n+.BackgroundPollingDetails-icon {\n   font-size: 28px;\n   margin-right: $sMargin-element;\n }\n-.TwitterImportDetails-icon .iconFont-Dollar { margin-bottom: 8px; /* :( */ }\n-.TwitterImportDetails-icon.is-nonFree {\n+.BackgroundPollingDetails-icon .iconFont-Dollar { margin-bottom: 8px; /* :( */ }\n+.BackgroundPollingDetails-icon.is-nonFree {\n   color: #D4BD7F;\n   border-color: #D4BD7F;\n   box-shadow: rgba(#D4BD7F, 0.1) 0 0 2px 2px;\n }\n-.TwitterImportDetails-icon.is-free {\n+.BackgroundPollingDetails-icon.is-free {\n   color: $cHighlight-positive;\n   border-color: $cHighlight-positive;\n   box-shadow: rgba($cHighlight-positive, 0.2) 0 0 2px 2px;\n }\n-.TwitterImportDetails-infoTitle {\n+.BackgroundPollingDetails-infoTitle {\n   font-size: $sFontSize-larger;\n   font-weight: normal;\n   color: $cTypography-paragraphs;\n }\n-.TwitterImportDetails-infoText {\n+.BackgroundPollingDetails-infoText {\n   margin-top: 3px;\n   font-size: $sFontSize-normal;\n }\n-.TwitterImportDetails-footer {\n+.Dialog-footer.BackgroundPollingDetails-footer {\n   width: $w;\n   margin: 0 auto;\n   text-align: center;\n+  border-top: 0;\n }\n-.TwitterImportDetails-footerButton { display: inline-block }\n-.TwitterImportDetails-footerButton span { line-height: 42px }\n\\ No newline at end of file\n+.Dialog-footer .Button.BackgroundPollingDetails-footerButton { display: inline-block }\n+.Dialog-footer .Button.BackgroundPollingDetails-footerButton span { line-height: 42px }","path":"app/assets/stylesheets/common/background-polling/background-polling-result-details-dialog.css.scss","position":68,"original_position":68,"commit_id":"1849c99e61d5f840a77685733192453c0347e8e8","original_commit_id":"1849c99e61d5f840a77685733192453c0347e8e8","user":{"login":"viddo","id":978461,"avatar_url":"https://avatars.githubusercontent.com/u/978461?v=3","gravatar_id":"","url":"https://api.github.com/users/viddo","html_url":"https://github.com/viddo","followers_url":"https://api.github.com/users/viddo/followers","following_url":"https://api.github.com/users/viddo/following{/other_user}","gists_url":"https://api.github.com/users/viddo/gists{/gist_id}","starred_url":"https://api.github.com/users/viddo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viddo/subscriptions","organizations_url":"https://api.github.com/users/viddo/orgs","repos_url":"https://api.github.com/users/viddo/repos","events_url":"https://api.github.com/users/viddo/events{/privacy}","received_events_url":"https://api.github.com/users/viddo/received_events","type":"User","site_admin":false},"body":"As I commented in earlier PRs, IMHO, `.Dialog-x.Something-else` would be better to have defined in the as `.Dialog-xxx--modifier` than to have them spread out in various places. Or as an alternative, define the (new?) component that is independent of `.Dialog-x` rules.","created_at":"2015-06-25T13:29:35Z","updated_at":"2015-06-25T13:29:35Z","html_url":"https://github.com/CartoDB/cartodb/pull/4159#discussion_r33254167","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/33254167"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/4159#discussion_r33254167"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159","id":38312968,"html_url":"https://github.com/CartoDB/cartodb/pull/4159","diff_url":"https://github.com/CartoDB/cartodb/pull/4159.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/4159.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4159","number":4159,"state":"open","locked":false,"title":"Geocoding background importer","user":{"login":"xavijam","id":132146,"avatar_url":"https://avatars.githubusercontent.com/u/132146?v=3","gravatar_id":"","url":"https://api.github.com/users/xavijam","html_url":"https://github.com/xavijam","followers_url":"https://api.github.com/users/xavijam/followers","following_url":"https://api.github.com/users/xavijam/following{/other_user}","gists_url":"https://api.github.com/users/xavijam/gists{/gist_id}","starred_url":"https://api.github.com/users/xavijam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavijam/subscriptions","organizations_url":"https://api.github.com/users/xavijam/orgs","repos_url":"https://api.github.com/users/xavijam/repos","events_url":"https://api.github.com/users/xavijam/events{/privacy}","received_events_url":"https://api.github.com/users/xavijam/received_events","type":"User","site_admin":false},"body":"![geocoding](https://cloud.githubusercontent.com/assets/132146/8350889/938c3ce6-1b29-11e5-8b06-e813df9d6c09.gif)\r\n\r\nNew background geocoding polling available :dancer:.\r\n\r\nMain features:\r\n- Join import and geocoding proccesses in the same context, sharing 'background-polling' view.\r\n- Geocoding jobs will be visible in the dashboard page. In dataset/map view, only datasets those belong to the visualization will be shown in the background-polling-view.\r\n- Geocoding result dialogs included: success, error, no results,... etc.\r\n- Geocoding already working dialog included.\r\n\r\n---\r\n![background-geocoder](https://cloud.githubusercontent.com/assets/132146/8350172/60a3214c-1b23-11e5-9565-5f808ab97610.png)\r\n---\r\nA silly diagram about new background polling view:\r\n![untitled drawing](https://cloud.githubusercontent.com/assets/132146/8350730/5386425a-1b28-11e5-87e0-8f088c2dfd33.jpg)\r\n\r\nBasically 'background-polling-view' listens what happens in the 'background-polling-model'. It any item is added, that view will create and add a new import/geocoding item in the list.\r\n","created_at":"2015-06-23T08:40:56Z","updated_at":"2015-06-25T13:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ae2bee0e54035b772fe0e1ee9cda235bb28c05d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/4159/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/1849c99e61d5f840a77685733192453c0347e8e8","head":{"label":"CartoDB:geocoding-background-importer","ref":"geocoding-background-importer","sha":"1849c99e61d5f840a77685733192453c0347e8e8","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Geospatial database for the cloud","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","created_at":"2012-07-05T15:23:45Z","updated_at":"2015-06-23T09:59:35Z","pushed_at":"2015-06-25T13:29:19Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"www.cartodb.com","size":479821,"stargazers_count":833,"watchers_count":833,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":626,"forks":199,"open_issues":626,"watchers":833,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"565fb465346771fb7821b56970f2c75271abe02d","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Geospatial database for the cloud","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","created_at":"2012-07-05T15:23:45Z","updated_at":"2015-06-23T09:59:35Z","pushed_at":"2015-06-25T13:29:19Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"www.cartodb.com","size":479821,"stargazers_count":833,"watchers_count":833,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":626,"forks":199,"open_issues":626,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/4159"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/4159"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/4159/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/4159/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/1849c99e61d5f840a77685733192453c0347e8e8"}}}}