{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/14645","labels_url":"https://api.github.com/repos/owncloud/core/issues/14645/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/14645/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/14645/events","html_url":"https://github.com/owncloud/core/pull/14645","id":59490192,"number":14645,"title":"Enable unit tests for files_external for autotest.sh","user":{"login":"Xenopathic","id":2016878,"avatar_url":"https://avatars.githubusercontent.com/u/2016878?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenopathic","html_url":"https://github.com/Xenopathic","followers_url":"https://api.github.com/users/Xenopathic/followers","following_url":"https://api.github.com/users/Xenopathic/following{/other_user}","gists_url":"https://api.github.com/users/Xenopathic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenopathic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenopathic/subscriptions","organizations_url":"https://api.github.com/users/Xenopathic/orgs","repos_url":"https://api.github.com/users/Xenopathic/repos","events_url":"https://api.github.com/users/Xenopathic/events{/privacy}","received_events_url":"https://api.github.com/users/Xenopathic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/app:files_external","name":"app:files_external","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-03-02T14:47:19Z","updated_at":"2015-03-04T15:44:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/14645","html_url":"https://github.com/owncloud/core/pull/14645","diff_url":"https://github.com/owncloud/core/pull/14645.diff","patch_url":"https://github.com/owncloud/core/pull/14645.patch"},"body":"I've enabled the common unit tests for files_external in autotest.sh. This means we test the core functionality of files_external in CI. To accomplish this, I've augmented the way we gather test files, by checking for the suffix '.noauto' on a directory or '.noauto.php' on a test file, and not including the test/directory if it contains that. This way, we can exclude parts of a test suite, like the backend tests for files_external, which are otherwise unavailable on CI. Running them manually is always available, of course.\r\n\r\nIn addition, I've noticed a partial regression in the files_external unit tests. Since #10673, simply creating an SMB storage backend attempts to create a connection to the server. As some unit tests used the SMB backend as a reference storage, this meant that the unit tests attempted to create connections to a (non-existent) SMB server, slowing everything down and printing unnecessary logs. I've replaced all references to real storage backends with the dummy ones available in the `mountconfig.php` test file (which now extends \\OC\\Files\\Storage\\Common). I suppose we'd have noticed this if CI was testing files_external... :speak_no_evil: \r\n\r\n@MorrisJobke Please give your `autotest-external.sh` a good test to make sure I haven't broken anything :smile:\r\n\r\ncc @icewind1991 @LukasReschke @DeepDiver1975 @MorrisJobke @PVince81 "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/77181912","html_url":"https://github.com/owncloud/core/pull/14645#issuecomment-77181912","issue_url":"https://api.github.com/repos/owncloud/core/issues/14645","id":77181912,"user":{"login":"owncloud-bot","id":2709266,"avatar_url":"https://avatars.githubusercontent.com/u/2709266?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud-bot","html_url":"https://github.com/owncloud-bot","followers_url":"https://api.github.com/users/owncloud-bot/followers","following_url":"https://api.github.com/users/owncloud-bot/following{/other_user}","gists_url":"https://api.github.com/users/owncloud-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud-bot/subscriptions","organizations_url":"https://api.github.com/users/owncloud-bot/orgs","repos_url":"https://api.github.com/users/owncloud-bot/repos","events_url":"https://api.github.com/users/owncloud-bot/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud-bot/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T15:44:47Z","updated_at":"2015-03-04T15:44:47Z","body":"\nRefer to this link for build results (access rights to CI server needed): \nhttps://ci.owncloud.org//job/pull-request-analyser-ng-simple/10213/\nTest PASSed."}}