{"action":"created","comment":{"url":"https://api.github.com/repos/atom/text-transform/pulls/comments/25693771","id":25693771,"diff_hunk":"@@ -1,5 +1,12 @@\n require 'coffee-cache'\n+Point = require '../src/point'\n \n exports.expectValues = (actual, expected) ->\n   for expectedKey, expectedValue of expected\n     expect(actual[expectedKey]).toEqual expectedValue\n+\n+exports.expectMappings = (mappings, {fromLayer, toLayer}) ->","path":"spec/spec-helper.coffee","position":8,"original_position":8,"commit_id":"ced90c3089eaccebe11af15d3aa9409da6331524","original_commit_id":"ced90c3089eaccebe11af15d3aa9409da6331524","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"body":"Nice point you bring up. To be honest, my Ruby (+ RSpec) background made me do this automatically, but it shouldn't probably behave that way.\r\n\r\nEven though it's working for some reason, I will simply require `spec-helper` where needed until we understand what's going on there.\r\n\r\nThanks.","created_at":"2015-03-03T15:06:40Z","updated_at":"2015-03-03T15:06:40Z","html_url":"https://github.com/atom/text-transform/pull/2#discussion_r25693771","pull_request_url":"https://api.github.com/repos/atom/text-transform/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/atom/text-transform/pulls/comments/25693771"},"html":{"href":"https://github.com/atom/text-transform/pull/2#discussion_r25693771"},"pull_request":{"href":"https://api.github.com/repos/atom/text-transform/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/atom/text-transform/pulls/2","id":30288718,"html_url":"https://github.com/atom/text-transform/pull/2","diff_url":"https://github.com/atom/text-transform/pull/2.diff","patch_url":"https://github.com/atom/text-transform/pull/2.patch","issue_url":"https://api.github.com/repos/atom/text-transform/issues/2","number":2,"state":"open","locked":false,"title":"Soft tabs","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"body":"Finally, my first PR on this project! :sparkles: \r\n\r\nFirst off, I'd like to express my appreciation for decomposing the *text buffering problem* in transformations; this layer may get very tangled and therefore having a [ChainOfResponsibility](http://c2.com/cgi/wiki?ChainOfResponsibilityPattern) helps to cleanly separate concerns quite well, in my opinion: individuating what should change, adding a new transformation or finding out what's causing a unexpected behavior should be much easier with this design :clap: :clap: :clap: \r\n\r\nBack to this first, tiny, contribution :smile: \r\n\r\nI see some coupling between `SoftTabsLayer` and `TabsLayer` (which I renamed to `HardTabsLayer` for consistency), but I think it can wait to be removed: we're still experimenting :microscope:  and it may do more harm than good right now. Moreover, this was a way for me to get my hands dirty and to verify what I understood and what I completely missed.\r\n\r\nWhen it came time to write the specs, I tried to be slightly more verbose in order to be clearer and to keep moving. Hopefully, this will help also new people to understand what's going on there (even though I understand that this repo is in continuous evolution and things might change dramatically).\r\n\r\n@nathansobo: it would be great if you could have a look and point out any issue with these changes. Thank you! :pray: \r\n\r\n/cc: @maxbrunsfeld (as I have seen you have signed off some commits on this repo, and I thought this may have been relevant to you as well :blush:)","created_at":"2015-03-02T14:50:39Z","updated_at":"2015-03-03T15:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d07c2b1f75e38c4a9685d61d912f81c89bbf85bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/text-transform/pulls/2/commits","review_comments_url":"https://api.github.com/repos/atom/text-transform/pulls/2/comments","review_comment_url":"https://api.github.com/repos/atom/text-transform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/text-transform/issues/2/comments","statuses_url":"https://api.github.com/repos/atom/text-transform/statuses/ced90c3089eaccebe11af15d3aa9409da6331524","head":{"label":"atom:soft-tabs","ref":"soft-tabs","sha":"ced90c3089eaccebe11af15d3aa9409da6331524","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":30893336,"name":"text-transform","full_name":"atom/text-transform","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/text-transform","description":null,"fork":false,"url":"https://api.github.com/repos/atom/text-transform","forks_url":"https://api.github.com/repos/atom/text-transform/forks","keys_url":"https://api.github.com/repos/atom/text-transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/text-transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/text-transform/teams","hooks_url":"https://api.github.com/repos/atom/text-transform/hooks","issue_events_url":"https://api.github.com/repos/atom/text-transform/issues/events{/number}","events_url":"https://api.github.com/repos/atom/text-transform/events","assignees_url":"https://api.github.com/repos/atom/text-transform/assignees{/user}","branches_url":"https://api.github.com/repos/atom/text-transform/branches{/branch}","tags_url":"https://api.github.com/repos/atom/text-transform/tags","blobs_url":"https://api.github.com/repos/atom/text-transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/text-transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/text-transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/text-transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/text-transform/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/text-transform/languages","stargazers_url":"https://api.github.com/repos/atom/text-transform/stargazers","contributors_url":"https://api.github.com/repos/atom/text-transform/contributors","subscribers_url":"https://api.github.com/repos/atom/text-transform/subscribers","subscription_url":"https://api.github.com/repos/atom/text-transform/subscription","commits_url":"https://api.github.com/repos/atom/text-transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/text-transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/text-transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/text-transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/text-transform/contents/{+path}","compare_url":"https://api.github.com/repos/atom/text-transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/text-transform/merges","archive_url":"https://api.github.com/repos/atom/text-transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/text-transform/downloads","issues_url":"https://api.github.com/repos/atom/text-transform/issues{/number}","pulls_url":"https://api.github.com/repos/atom/text-transform/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/text-transform/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/text-transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/text-transform/labels{/name}","releases_url":"https://api.github.com/repos/atom/text-transform/releases{/id}","created_at":"2015-02-16T23:12:43Z","updated_at":"2015-02-28T17:31:25Z","pushed_at":"2015-03-03T14:07:54Z","git_url":"git://github.com/atom/text-transform.git","ssh_url":"git@github.com:atom/text-transform.git","clone_url":"https://github.com/atom/text-transform.git","svn_url":"https://github.com/atom/text-transform","homepage":null,"size":244,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b155b1add921fb02120b0655d4c37204b72592e8","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":30893336,"name":"text-transform","full_name":"atom/text-transform","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/text-transform","description":null,"fork":false,"url":"https://api.github.com/repos/atom/text-transform","forks_url":"https://api.github.com/repos/atom/text-transform/forks","keys_url":"https://api.github.com/repos/atom/text-transform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/text-transform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/text-transform/teams","hooks_url":"https://api.github.com/repos/atom/text-transform/hooks","issue_events_url":"https://api.github.com/repos/atom/text-transform/issues/events{/number}","events_url":"https://api.github.com/repos/atom/text-transform/events","assignees_url":"https://api.github.com/repos/atom/text-transform/assignees{/user}","branches_url":"https://api.github.com/repos/atom/text-transform/branches{/branch}","tags_url":"https://api.github.com/repos/atom/text-transform/tags","blobs_url":"https://api.github.com/repos/atom/text-transform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/text-transform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/text-transform/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/text-transform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/text-transform/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/text-transform/languages","stargazers_url":"https://api.github.com/repos/atom/text-transform/stargazers","contributors_url":"https://api.github.com/repos/atom/text-transform/contributors","subscribers_url":"https://api.github.com/repos/atom/text-transform/subscribers","subscription_url":"https://api.github.com/repos/atom/text-transform/subscription","commits_url":"https://api.github.com/repos/atom/text-transform/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/text-transform/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/text-transform/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/text-transform/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/text-transform/contents/{+path}","compare_url":"https://api.github.com/repos/atom/text-transform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/text-transform/merges","archive_url":"https://api.github.com/repos/atom/text-transform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/text-transform/downloads","issues_url":"https://api.github.com/repos/atom/text-transform/issues{/number}","pulls_url":"https://api.github.com/repos/atom/text-transform/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/text-transform/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/text-transform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/text-transform/labels{/name}","releases_url":"https://api.github.com/repos/atom/text-transform/releases{/id}","created_at":"2015-02-16T23:12:43Z","updated_at":"2015-02-28T17:31:25Z","pushed_at":"2015-03-03T14:07:54Z","git_url":"git://github.com/atom/text-transform.git","ssh_url":"git@github.com:atom/text-transform.git","clone_url":"https://github.com/atom/text-transform.git","svn_url":"https://github.com/atom/text-transform","homepage":null,"size":244,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/text-transform/pulls/2"},"html":{"href":"https://github.com/atom/text-transform/pull/2"},"issue":{"href":"https://api.github.com/repos/atom/text-transform/issues/2"},"comments":{"href":"https://api.github.com/repos/atom/text-transform/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/text-transform/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/text-transform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/text-transform/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/atom/text-transform/statuses/ced90c3089eaccebe11af15d3aa9409da6331524"}}}}