{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/22983357","id":22983357,"diff_hunk":"@@ -110,9 +115,14 @@ namespace aspect\n               // for each of the quadrature points, evaluate the\n               // stress and compute the component in direction of the\n               // gravity vector\n+              \n+              double dynamic_topography_x_volume = 0;\n+              double volume = 0;\n+              Point<dim> location = fe_values.quadrature_point(0);","path":"source/postprocess/dynamic_topography.cc","position":26,"original_position":26,"commit_id":"14d2520ee88e7521c7a84a734faa78fc48291b07","original_commit_id":"14d2520ee88e7521c7a84a734faa78fc48291b07","user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"Why are you assigning something to the point here? Seems unnecessary.","created_at":"2015-01-15T00:42:51Z","updated_at":"2015-01-15T00:42:51Z","html_url":"https://github.com/geodynamics/aspect/pull/248#discussion_r22983357","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/22983357"},"html":{"href":"https://github.com/geodynamics/aspect/pull/248#discussion_r22983357"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/248","id":27396169,"html_url":"https://github.com/geodynamics/aspect/pull/248","diff_url":"https://github.com/geodynamics/aspect/pull/248.diff","patch_url":"https://github.com/geodynamics/aspect/pull/248.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/248","number":248,"state":"open","locked":false,"title":"Change averaging in dynamic topography postprocessor from volume weighte...","user":{"login":"jaustermann","id":7633875,"avatar_url":"https://avatars.githubusercontent.com/u/7633875?v=3","gravatar_id":"","url":"https://api.github.com/users/jaustermann","html_url":"https://github.com/jaustermann","followers_url":"https://api.github.com/users/jaustermann/followers","following_url":"https://api.github.com/users/jaustermann/following{/other_user}","gists_url":"https://api.github.com/users/jaustermann/gists{/gist_id}","starred_url":"https://api.github.com/users/jaustermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaustermann/subscriptions","organizations_url":"https://api.github.com/users/jaustermann/orgs","repos_url":"https://api.github.com/users/jaustermann/repos","events_url":"https://api.github.com/users/jaustermann/events{/privacy}","received_events_url":"https://api.github.com/users/jaustermann/received_events","type":"User","site_admin":false},"body":"...d to surface area weighted so that in the end the average of dynamic topography over the domain's surface area is zero (if Subtract mean of dynamic topography is set to true).","created_at":"2015-01-15T00:17:26Z","updated_at":"2015-01-15T00:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc0aef6ffe689b84c9b0f62c418e3187a8146a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/248/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/248/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/248/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/14d2520ee88e7521c7a84a734faa78fc48291b07","head":{"label":"jaustermann:DT_average","ref":"DT_average","sha":"14d2520ee88e7521c7a84a734faa78fc48291b07","user":{"login":"jaustermann","id":7633875,"avatar_url":"https://avatars.githubusercontent.com/u/7633875?v=3","gravatar_id":"","url":"https://api.github.com/users/jaustermann","html_url":"https://github.com/jaustermann","followers_url":"https://api.github.com/users/jaustermann/followers","following_url":"https://api.github.com/users/jaustermann/following{/other_user}","gists_url":"https://api.github.com/users/jaustermann/gists{/gist_id}","starred_url":"https://api.github.com/users/jaustermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaustermann/subscriptions","organizations_url":"https://api.github.com/users/jaustermann/orgs","repos_url":"https://api.github.com/users/jaustermann/repos","events_url":"https://api.github.com/users/jaustermann/events{/privacy}","received_events_url":"https://api.github.com/users/jaustermann/received_events","type":"User","site_admin":false},"repo":{"id":19953904,"name":"aspect","full_name":"jaustermann/aspect","owner":{"login":"jaustermann","id":7633875,"avatar_url":"https://avatars.githubusercontent.com/u/7633875?v=3","gravatar_id":"","url":"https://api.github.com/users/jaustermann","html_url":"https://github.com/jaustermann","followers_url":"https://api.github.com/users/jaustermann/followers","following_url":"https://api.github.com/users/jaustermann/following{/other_user}","gists_url":"https://api.github.com/users/jaustermann/gists{/gist_id}","starred_url":"https://api.github.com/users/jaustermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaustermann/subscriptions","organizations_url":"https://api.github.com/users/jaustermann/orgs","repos_url":"https://api.github.com/users/jaustermann/repos","events_url":"https://api.github.com/users/jaustermann/events{/privacy}","received_events_url":"https://api.github.com/users/jaustermann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaustermann/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/jaustermann/aspect","forks_url":"https://api.github.com/repos/jaustermann/aspect/forks","keys_url":"https://api.github.com/repos/jaustermann/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaustermann/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaustermann/aspect/teams","hooks_url":"https://api.github.com/repos/jaustermann/aspect/hooks","issue_events_url":"https://api.github.com/repos/jaustermann/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/jaustermann/aspect/events","assignees_url":"https://api.github.com/repos/jaustermann/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/jaustermann/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/jaustermann/aspect/tags","blobs_url":"https://api.github.com/repos/jaustermann/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaustermann/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaustermann/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaustermann/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaustermann/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/jaustermann/aspect/languages","stargazers_url":"https://api.github.com/repos/jaustermann/aspect/stargazers","contributors_url":"https://api.github.com/repos/jaustermann/aspect/contributors","subscribers_url":"https://api.github.com/repos/jaustermann/aspect/subscribers","subscription_url":"https://api.github.com/repos/jaustermann/aspect/subscription","commits_url":"https://api.github.com/repos/jaustermann/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaustermann/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaustermann/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaustermann/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/jaustermann/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/jaustermann/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaustermann/aspect/merges","archive_url":"https://api.github.com/repos/jaustermann/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaustermann/aspect/downloads","issues_url":"https://api.github.com/repos/jaustermann/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/jaustermann/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/jaustermann/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/jaustermann/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaustermann/aspect/labels{/name}","releases_url":"https://api.github.com/repos/jaustermann/aspect/releases{/id}","created_at":"2014-05-19T19:01:22Z","updated_at":"2014-06-06T20:54:23Z","pushed_at":"2015-01-15T00:35:20Z","git_url":"git://github.com/jaustermann/aspect.git","ssh_url":"git@github.com:jaustermann/aspect.git","clone_url":"https://github.com/jaustermann/aspect.git","svn_url":"https://github.com/jaustermann/aspect","homepage":null,"size":90831,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"s40rts"}},"base":{"label":"geodynamics:master","ref":"master","sha":"01f19ef36177d8c77f84b59ece4918ba5f3e7661","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/{number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","created_at":"2014-05-06T16:47:18Z","updated_at":"2015-01-13T19:48:27Z","pushed_at":"2015-01-13T19:48:26Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":106550,"stargazers_count":8,"watchers_count":8,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":26,"forks":25,"open_issues":26,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/248"},"html":{"href":"https://github.com/geodynamics/aspect/pull/248"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/248"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/14d2520ee88e7521c7a84a734faa78fc48291b07"}}}}