{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/931","labels_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/931/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/931/comments","events_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/931/events","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/931","id":92803446,"number":931,"title":"Simplify javascript code for wallets","user":{"login":"saivann","id":3578089,"avatar_url":"https://avatars.githubusercontent.com/u/3578089?v=3","gravatar_id":"","url":"https://api.github.com/users/saivann","html_url":"https://github.com/saivann","followers_url":"https://api.github.com/users/saivann/followers","following_url":"https://api.github.com/users/saivann/following{/other_user}","gists_url":"https://api.github.com/users/saivann/gists{/gist_id}","starred_url":"https://api.github.com/users/saivann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saivann/subscriptions","organizations_url":"https://api.github.com/users/saivann/orgs","repos_url":"https://api.github.com/users/saivann/repos","events_url":"https://api.github.com/users/saivann/events{/privacy}","received_events_url":"https://api.github.com/users/saivann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/labels/Merge%20scheduled","name":"Merge scheduled","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-03T06:25:50Z","updated_at":"2015-07-07T19:43:02Z","closed_at":"2015-07-07T19:43:02Z","pull_request":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/pulls/931","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/931","diff_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/931.diff","patch_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/931.patch"},"body":"Sorry in advance for these large changes. A lot of code isn't really modified, only reorganized.\r\n\r\nLive preview: http://bitcointest1.us.to/en/choose-your-wallet\r\n\r\nIt appeared to me that the javascript code for wallets was a bit unreadable with confusing function names, so I bundled many functions dedicated for events on the page into two single functions (walletMenuListener and walletListener) with subfunctions (closures) and tried to shorten / improve syntax a bit elsewhere.\r\n\r\nThis pull request also fixes a bug where the bubble of a wallet would show if the mouse is hovering over the icon after the user clicked within the bubble, as well as fixing a few unintended use of global variables through the code.\r\n\r\nI have tested these changes against IE 8-9, FF, SA, CH, OP, Android 2.3.6\r\n\r\nIn the absence of critical feedback, this pull request will be merged on July 6th."},"comment":{"url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/comments/119314806","html_url":"https://github.com/bitcoin-dot-org/bitcoin.org/pull/931#issuecomment-119314806","issue_url":"https://api.github.com/repos/bitcoin-dot-org/bitcoin.org/issues/931","id":119314806,"user":{"login":"saivann","id":3578089,"avatar_url":"https://avatars.githubusercontent.com/u/3578089?v=3","gravatar_id":"","url":"https://api.github.com/users/saivann","html_url":"https://github.com/saivann","followers_url":"https://api.github.com/users/saivann/followers","following_url":"https://api.github.com/users/saivann/following{/other_user}","gists_url":"https://api.github.com/users/saivann/gists{/gist_id}","starred_url":"https://api.github.com/users/saivann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saivann/subscriptions","organizations_url":"https://api.github.com/users/saivann/orgs","repos_url":"https://api.github.com/users/saivann/repos","events_url":"https://api.github.com/users/saivann/events{/privacy}","received_events_url":"https://api.github.com/users/saivann/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T19:43:02Z","updated_at":"2015-07-07T19:43:02Z","body":"This pull request has been replaced by #950"}}