{"action":"created","comment":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments/39613021","id":39613021,"diff_hunk":"@@ -249,7 +249,7 @@ def get_output_for(self, input, input_shape=None, **kwargs):\n                                       filter_shape=self.get_W_shape(),\n                                       border_mode='full')\n             shift = (self.filter_size[0] - 1) // 2\n-            conved = conved[:, :, shift:input.shape[2] + shift]\n+            conved = conved[:, :, shift:-shift]","path":"lasagne/layers/conv.py","position":5,"original_position":5,"commit_id":"1fb06fc7caf76f8f22224f21df6e9dc066c96958","original_commit_id":"1fb06fc7caf76f8f22224f21df6e9dc066c96958","user":{"login":"ebenolson","id":544718,"avatar_url":"https://avatars.githubusercontent.com/u/544718?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenolson","html_url":"https://github.com/ebenolson","followers_url":"https://api.github.com/users/ebenolson/followers","following_url":"https://api.github.com/users/ebenolson/following{/other_user}","gists_url":"https://api.github.com/users/ebenolson/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenolson/subscriptions","organizations_url":"https://api.github.com/users/ebenolson/orgs","repos_url":"https://api.github.com/users/ebenolson/repos","events_url":"https://api.github.com/users/ebenolson/events{/privacy}","received_events_url":"https://api.github.com/users/ebenolson/received_events","type":"User","site_admin":false},"body":"It won't work for even kernel sizes, but I don't think we were trying to support 'same' for those anyway.\r\n\r\nThe original way makes more sense to me, but it seems to really confuse Theano.","created_at":"2015-09-16T10:09:39Z","updated_at":"2015-09-16T10:09:39Z","html_url":"https://github.com/Lasagne/Lasagne/pull/415#discussion_r39613021","pull_request_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments/39613021"},"html":{"href":"https://github.com/Lasagne/Lasagne/pull/415#discussion_r39613021"},"pull_request":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415","id":45121227,"html_url":"https://github.com/Lasagne/Lasagne/pull/415","diff_url":"https://github.com/Lasagne/Lasagne/pull/415.diff","patch_url":"https://github.com/Lasagne/Lasagne/pull/415.patch","issue_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/415","number":415,"state":"open","locked":false,"title":"Conv1d slow compilation fix","user":{"login":"ebenolson","id":544718,"avatar_url":"https://avatars.githubusercontent.com/u/544718?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenolson","html_url":"https://github.com/ebenolson","followers_url":"https://api.github.com/users/ebenolson/followers","following_url":"https://api.github.com/users/ebenolson/following{/other_user}","gists_url":"https://api.github.com/users/ebenolson/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenolson/subscriptions","organizations_url":"https://api.github.com/users/ebenolson/orgs","repos_url":"https://api.github.com/users/ebenolson/repos","events_url":"https://api.github.com/users/ebenolson/events{/privacy}","received_events_url":"https://api.github.com/users/ebenolson/received_events","type":"User","site_admin":false},"body":"Attempts to address the bug discussed [here](https://groups.google.com/forum/#!topic/lasagne-users/XR-jmU1pMWc). \r\n\r\nThe changes to `theano_extensions.conv` improved the optimization speed dramatically, but I think it's still triggering some underlying problem in Theano, as the compilation time increases nonlinearly with each additional layer.\r\n\r\nThe change to `Conv1DLayer` seems to be an effective workaround, but I need to profile and see how the execution speed compares.","created_at":"2015-09-16T01:13:10Z","updated_at":"2015-09-16T10:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"388afa5b9105a3fbdfaff59b2683f875707c703c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415/commits","review_comments_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415/comments","review_comment_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/415/comments","statuses_url":"https://api.github.com/repos/Lasagne/Lasagne/statuses/1fb06fc7caf76f8f22224f21df6e9dc066c96958","head":{"label":"ebenolson:conv1d_fix","ref":"conv1d_fix","sha":"1fb06fc7caf76f8f22224f21df6e9dc066c96958","user":{"login":"ebenolson","id":544718,"avatar_url":"https://avatars.githubusercontent.com/u/544718?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenolson","html_url":"https://github.com/ebenolson","followers_url":"https://api.github.com/users/ebenolson/followers","following_url":"https://api.github.com/users/ebenolson/following{/other_user}","gists_url":"https://api.github.com/users/ebenolson/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenolson/subscriptions","organizations_url":"https://api.github.com/users/ebenolson/orgs","repos_url":"https://api.github.com/users/ebenolson/repos","events_url":"https://api.github.com/users/ebenolson/events{/privacy}","received_events_url":"https://api.github.com/users/ebenolson/received_events","type":"User","site_admin":false},"repo":{"id":30893210,"name":"Lasagne","full_name":"ebenolson/Lasagne","owner":{"login":"ebenolson","id":544718,"avatar_url":"https://avatars.githubusercontent.com/u/544718?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenolson","html_url":"https://github.com/ebenolson","followers_url":"https://api.github.com/users/ebenolson/followers","following_url":"https://api.github.com/users/ebenolson/following{/other_user}","gists_url":"https://api.github.com/users/ebenolson/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenolson/subscriptions","organizations_url":"https://api.github.com/users/ebenolson/orgs","repos_url":"https://api.github.com/users/ebenolson/repos","events_url":"https://api.github.com/users/ebenolson/events{/privacy}","received_events_url":"https://api.github.com/users/ebenolson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebenolson/Lasagne","description":"neural network tools for Theano","fork":true,"url":"https://api.github.com/repos/ebenolson/Lasagne","forks_url":"https://api.github.com/repos/ebenolson/Lasagne/forks","keys_url":"https://api.github.com/repos/ebenolson/Lasagne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebenolson/Lasagne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebenolson/Lasagne/teams","hooks_url":"https://api.github.com/repos/ebenolson/Lasagne/hooks","issue_events_url":"https://api.github.com/repos/ebenolson/Lasagne/issues/events{/number}","events_url":"https://api.github.com/repos/ebenolson/Lasagne/events","assignees_url":"https://api.github.com/repos/ebenolson/Lasagne/assignees{/user}","branches_url":"https://api.github.com/repos/ebenolson/Lasagne/branches{/branch}","tags_url":"https://api.github.com/repos/ebenolson/Lasagne/tags","blobs_url":"https://api.github.com/repos/ebenolson/Lasagne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebenolson/Lasagne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebenolson/Lasagne/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebenolson/Lasagne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebenolson/Lasagne/statuses/{sha}","languages_url":"https://api.github.com/repos/ebenolson/Lasagne/languages","stargazers_url":"https://api.github.com/repos/ebenolson/Lasagne/stargazers","contributors_url":"https://api.github.com/repos/ebenolson/Lasagne/contributors","subscribers_url":"https://api.github.com/repos/ebenolson/Lasagne/subscribers","subscription_url":"https://api.github.com/repos/ebenolson/Lasagne/subscription","commits_url":"https://api.github.com/repos/ebenolson/Lasagne/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebenolson/Lasagne/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebenolson/Lasagne/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebenolson/Lasagne/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebenolson/Lasagne/contents/{+path}","compare_url":"https://api.github.com/repos/ebenolson/Lasagne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebenolson/Lasagne/merges","archive_url":"https://api.github.com/repos/ebenolson/Lasagne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebenolson/Lasagne/downloads","issues_url":"https://api.github.com/repos/ebenolson/Lasagne/issues{/number}","pulls_url":"https://api.github.com/repos/ebenolson/Lasagne/pulls{/number}","milestones_url":"https://api.github.com/repos/ebenolson/Lasagne/milestones{/number}","notifications_url":"https://api.github.com/repos/ebenolson/Lasagne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebenolson/Lasagne/labels{/name}","releases_url":"https://api.github.com/repos/ebenolson/Lasagne/releases{/id}","created_at":"2015-02-16T23:09:11Z","updated_at":"2015-03-21T16:45:08Z","pushed_at":"2015-09-16T01:02:50Z","git_url":"git://github.com/ebenolson/Lasagne.git","ssh_url":"git@github.com:ebenolson/Lasagne.git","clone_url":"https://github.com/ebenolson/Lasagne.git","svn_url":"https://github.com/ebenolson/Lasagne","homepage":"http://lasagne.readthedocs.org/","size":1094,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Lasagne:master","ref":"master","sha":"3a09ef61fd57638c65d909a9f77ee897306ddbb7","user":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"repo":{"id":23924195,"name":"Lasagne","full_name":"Lasagne/Lasagne","owner":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lasagne/Lasagne","description":"Lightweight library to build and train neural networks in Theano","fork":false,"url":"https://api.github.com/repos/Lasagne/Lasagne","forks_url":"https://api.github.com/repos/Lasagne/Lasagne/forks","keys_url":"https://api.github.com/repos/Lasagne/Lasagne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lasagne/Lasagne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lasagne/Lasagne/teams","hooks_url":"https://api.github.com/repos/Lasagne/Lasagne/hooks","issue_events_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/events{/number}","events_url":"https://api.github.com/repos/Lasagne/Lasagne/events","assignees_url":"https://api.github.com/repos/Lasagne/Lasagne/assignees{/user}","branches_url":"https://api.github.com/repos/Lasagne/Lasagne/branches{/branch}","tags_url":"https://api.github.com/repos/Lasagne/Lasagne/tags","blobs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lasagne/Lasagne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lasagne/Lasagne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lasagne/Lasagne/statuses/{sha}","languages_url":"https://api.github.com/repos/Lasagne/Lasagne/languages","stargazers_url":"https://api.github.com/repos/Lasagne/Lasagne/stargazers","contributors_url":"https://api.github.com/repos/Lasagne/Lasagne/contributors","subscribers_url":"https://api.github.com/repos/Lasagne/Lasagne/subscribers","subscription_url":"https://api.github.com/repos/Lasagne/Lasagne/subscription","commits_url":"https://api.github.com/repos/Lasagne/Lasagne/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lasagne/Lasagne/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lasagne/Lasagne/contents/{+path}","compare_url":"https://api.github.com/repos/Lasagne/Lasagne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lasagne/Lasagne/merges","archive_url":"https://api.github.com/repos/Lasagne/Lasagne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lasagne/Lasagne/downloads","issues_url":"https://api.github.com/repos/Lasagne/Lasagne/issues{/number}","pulls_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls{/number}","milestones_url":"https://api.github.com/repos/Lasagne/Lasagne/milestones{/number}","notifications_url":"https://api.github.com/repos/Lasagne/Lasagne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/labels{/name}","releases_url":"https://api.github.com/repos/Lasagne/Lasagne/releases{/id}","created_at":"2014-09-11T15:31:41Z","updated_at":"2015-09-16T03:47:03Z","pushed_at":"2015-09-16T01:13:10Z","git_url":"git://github.com/Lasagne/Lasagne.git","ssh_url":"git@github.com:Lasagne/Lasagne.git","clone_url":"https://github.com/Lasagne/Lasagne.git","svn_url":"https://github.com/Lasagne/Lasagne","homepage":"http://lasagne.readthedocs.org/","size":4339,"stargazers_count":1029,"watchers_count":1029,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":53,"forks":247,"open_issues":53,"watchers":1029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415"},"html":{"href":"https://github.com/Lasagne/Lasagne/pull/415"},"issue":{"href":"https://api.github.com/repos/Lasagne/Lasagne/issues/415"},"comments":{"href":"https://api.github.com/repos/Lasagne/Lasagne/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/Lasagne/Lasagne/statuses/1fb06fc7caf76f8f22224f21df6e9dc066c96958"}}}}