{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/670","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/670/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/670/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/670/events","html_url":"https://github.com/facebook/rocksdb/pull/670","id":96821408,"number":670,"title":"Fix shared library names on OSX","user":{"login":"dch","id":284368,"avatar_url":"https://avatars.githubusercontent.com/u/284368?v=3","gravatar_id":"","url":"https://api.github.com/users/dch","html_url":"https://github.com/dch","followers_url":"https://api.github.com/users/dch/followers","following_url":"https://api.github.com/users/dch/following{/other_user}","gists_url":"https://api.github.com/users/dch/gists{/gist_id}","starred_url":"https://api.github.com/users/dch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dch/subscriptions","organizations_url":"https://api.github.com/users/dch/orgs","repos_url":"https://api.github.com/users/dch/repos","events_url":"https://api.github.com/users/dch/events{/privacy}","received_events_url":"https://api.github.com/users/dch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-23T13:55:42Z","updated_at":"2015-08-05T00:33:37Z","closed_at":"2015-08-05T00:33:35Z","pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/670","html_url":"https://github.com/facebook/rocksdb/pull/670","diff_url":"https://github.com/facebook/rocksdb/pull/670.diff","patch_url":"https://github.com/facebook/rocksdb/pull/670.patch"},"body":"- correct OSX format is `libname.major.minor.patch.dylib` and not `libname.dylib.major.minor.patch`\r\n- closes #666\r\n\r\n```\r\n$ make shared_lib\r\n... -DOS_MACOSX -DSNAPPY -DGFLAGS=gflags -DZLIB -DBZIP2 -DLZ4 -Wshorten-64-to-32 ... util/vectorrep.cc util/xfunc.cc util/xxhash.cc  \\\r\n\t\t -lsnappy -lgflags -lz -lbz2 -llz4 -o librocksdb.3.13.0.dylib\r\nln -fs librocksdb.3.13.0.dylib librocksdb.dylib\r\nln -fs librocksdb.3.13.0.dylib librocksdb.3.dylib\r\nln -fs librocksdb.3.13.0.dylib librocksdb.3.13.dylib\r\n```\r\nLGTM at least on OSX."},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/127803551","html_url":"https://github.com/facebook/rocksdb/pull/670#issuecomment-127803551","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/670","id":127803551,"user":{"login":"yhchiang","id":6447975,"avatar_url":"https://avatars.githubusercontent.com/u/6447975?v=3","gravatar_id":"","url":"https://api.github.com/users/yhchiang","html_url":"https://github.com/yhchiang","followers_url":"https://api.github.com/users/yhchiang/followers","following_url":"https://api.github.com/users/yhchiang/following{/other_user}","gists_url":"https://api.github.com/users/yhchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yhchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhchiang/subscriptions","organizations_url":"https://api.github.com/users/yhchiang/orgs","repos_url":"https://api.github.com/users/yhchiang/repos","events_url":"https://api.github.com/users/yhchiang/events{/privacy}","received_events_url":"https://api.github.com/users/yhchiang/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T00:33:37Z","updated_at":"2015-08-05T00:33:37Z","body":"LGTM.  Thanks for the fix!"}}