{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/36547821","id":36547821,"diff_hunk":"@@ -68,8 +76,17 @@ func (h ConsulHealthChecker) WatchNodeService(nodename string, serviceID string,\n \t\t\t\t\tcatalogResults = append(catalogResults, outResult)\n \t\t\t\t}\n \t\t\t\tkvCheckResult := consulWatchToResult(kvCheck)\n-\t\t\t\tcatalogCheckResult := findWorstResult(catalogResults)\n-\t\t\t\tresultCh <- findBestResult([]Result{kvCheckResult, catalogCheckResult})\n+\t\t\t\tcatalogCheckResult, HEErr := findWorstResult(catalogResults)\n+\t\t\t\tif HEErr != nil {\n+\t\t\t\t\tresultCh <- kvCheckResult","path":"pkg/health/health.go","position":23,"original_position":23,"commit_id":"3d2e69695d0707d4ef5638e319b8f47480311016","original_commit_id":"3d2e69695d0707d4ef5638e319b8f47480311016","user":{"login":"anthonybishopric","id":540783,"avatar_url":"https://avatars.githubusercontent.com/u/540783?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonybishopric","html_url":"https://github.com/anthonybishopric","followers_url":"https://api.github.com/users/anthonybishopric/followers","following_url":"https://api.github.com/users/anthonybishopric/following{/other_user}","gists_url":"https://api.github.com/users/anthonybishopric/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonybishopric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonybishopric/subscriptions","organizations_url":"https://api.github.com/users/anthonybishopric/orgs","repos_url":"https://api.github.com/users/anthonybishopric/repos","events_url":"https://api.github.com/users/anthonybishopric/events{/privacy}","received_events_url":"https://api.github.com/users/anthonybishopric/received_events","type":"User","site_admin":false},"body":"You need to check if `kvCheckResult` is actually present since it could be empty, right?","created_at":"2015-08-07T18:36:07Z","updated_at":"2015-08-07T18:36:07Z","html_url":"https://github.com/square/p2/pull/217#discussion_r36547821","pull_request_url":"https://api.github.com/repos/square/p2/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/36547821"},"html":{"href":"https://github.com/square/p2/pull/217#discussion_r36547821"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/217","id":41847889,"html_url":"https://github.com/square/p2/pull/217","diff_url":"https://github.com/square/p2/pull/217.diff","patch_url":"https://github.com/square/p2/pull/217.patch","issue_url":"https://api.github.com/repos/square/p2/issues/217","number":217,"state":"open","locked":false,"title":"find*Result in health package handles empty slice inputs","user":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"body":"In some cases findWorstResult and findBestResult were being\r\npassed empty result slices. This was cause panics. Now when\r\nthey are passed an empty slice they return a HealthEmptyError.\r\nHealthEmptyError wraps an error and allows callers to handle\r\nit as they see fit.\r\n\r\nUpdates health_test to reflect these changes and includes a\r\ntest for empty slices passed to the aformentioned methods.","created_at":"2015-08-06T23:57:21Z","updated_at":"2015-08-07T18:36:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb65a69106ce4a8494b9c7f14f61c84a5e166040","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/217/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/217/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/217/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/3d2e69695d0707d4ef5638e319b8f47480311016","head":{"label":"robertabbott:abbott/fixPanicsInHealth","ref":"abbott/fixPanicsInHealth","sha":"3d2e69695d0707d4ef5638e319b8f47480311016","user":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"repo":{"id":38002902,"name":"p2","full_name":"robertabbott/p2","owner":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertabbott/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/robertabbott/p2","forks_url":"https://api.github.com/repos/robertabbott/p2/forks","keys_url":"https://api.github.com/repos/robertabbott/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertabbott/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertabbott/p2/teams","hooks_url":"https://api.github.com/repos/robertabbott/p2/hooks","issue_events_url":"https://api.github.com/repos/robertabbott/p2/issues/events{/number}","events_url":"https://api.github.com/repos/robertabbott/p2/events","assignees_url":"https://api.github.com/repos/robertabbott/p2/assignees{/user}","branches_url":"https://api.github.com/repos/robertabbott/p2/branches{/branch}","tags_url":"https://api.github.com/repos/robertabbott/p2/tags","blobs_url":"https://api.github.com/repos/robertabbott/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertabbott/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertabbott/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertabbott/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertabbott/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/robertabbott/p2/languages","stargazers_url":"https://api.github.com/repos/robertabbott/p2/stargazers","contributors_url":"https://api.github.com/repos/robertabbott/p2/contributors","subscribers_url":"https://api.github.com/repos/robertabbott/p2/subscribers","subscription_url":"https://api.github.com/repos/robertabbott/p2/subscription","commits_url":"https://api.github.com/repos/robertabbott/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertabbott/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertabbott/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertabbott/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertabbott/p2/contents/{+path}","compare_url":"https://api.github.com/repos/robertabbott/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertabbott/p2/merges","archive_url":"https://api.github.com/repos/robertabbott/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertabbott/p2/downloads","issues_url":"https://api.github.com/repos/robertabbott/p2/issues{/number}","pulls_url":"https://api.github.com/repos/robertabbott/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/robertabbott/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/robertabbott/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertabbott/p2/labels{/name}","releases_url":"https://api.github.com/repos/robertabbott/p2/releases{/id}","created_at":"2015-06-24T18:21:15Z","updated_at":"2015-06-24T18:21:16Z","pushed_at":"2015-08-07T17:25:36Z","git_url":"git://github.com/robertabbott/p2.git","ssh_url":"git@github.com:robertabbott/p2.git","clone_url":"https://github.com/robertabbott/p2.git","svn_url":"https://github.com/robertabbott/p2","homepage":"","size":24354,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"fd92d5b462fc1af5d7c7d9d35cf214c584005b07","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","created_at":"2014-10-16T20:31:12Z","updated_at":"2015-07-26T19:10:25Z","pushed_at":"2015-08-07T18:12:37Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":30171,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/217"},"html":{"href":"https://github.com/square/p2/pull/217"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/217"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/3d2e69695d0707d4ef5638e319b8f47480311016"}}}}