{"action":"closed","number":364,"pull_request":{"url":"https://api.github.com/repos/alphagov/signonotron2/pulls/364","id":37801204,"html_url":"https://github.com/alphagov/signonotron2/pull/364","diff_url":"https://github.com/alphagov/signonotron2/pull/364.diff","patch_url":"https://github.com/alphagov/signonotron2/pull/364.patch","issue_url":"https://api.github.com/repos/alphagov/signonotron2/issues/364","number":364,"state":"closed","locked":false,"title":"Explicitly mark session cookies as \"Secure\"","user":{"login":"jamiecobbett","id":93739,"avatar_url":"https://avatars.githubusercontent.com/u/93739?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiecobbett","html_url":"https://github.com/jamiecobbett","followers_url":"https://api.github.com/users/jamiecobbett/followers","following_url":"https://api.github.com/users/jamiecobbett/following{/other_user}","gists_url":"https://api.github.com/users/jamiecobbett/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiecobbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiecobbett/subscriptions","organizations_url":"https://api.github.com/users/jamiecobbett/orgs","repos_url":"https://api.github.com/users/jamiecobbett/repos","events_url":"https://api.github.com/users/jamiecobbett/events{/privacy}","received_events_url":"https://api.github.com/users/jamiecobbett/received_events","type":"User","site_admin":false},"body":"This means that cookies will only be sent over encrypted connections, thus\r\nmaking it harder for an attacker to read/replay someone else's session.\r\n\r\nThe secure option was accidentally removed in 0ad105f.","created_at":"2015-06-16T14:32:46Z","updated_at":"2015-06-16T14:51:25Z","closed_at":"2015-06-16T14:51:25Z","merged_at":"2015-06-16T14:51:25Z","merge_commit_sha":"55b5c957a456a31ae025f5ef5976414fa262dbc6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/364/commits","review_comments_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/364/comments","review_comment_url":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/issues/364/comments","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/37214ffc4570637c2a54da4e95557859bd034b78","head":{"label":"alphagov:set_secure_session_cookies","ref":"set_secure_session_cookies","sha":"37214ffc4570637c2a54da4e95557859bd034b78","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":3928902,"name":"signonotron2","full_name":"alphagov/signonotron2","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/signonotron2","description":"Single sign-on service for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/signonotron2","forks_url":"https://api.github.com/repos/alphagov/signonotron2/forks","keys_url":"https://api.github.com/repos/alphagov/signonotron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/signonotron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/signonotron2/teams","hooks_url":"https://api.github.com/repos/alphagov/signonotron2/hooks","issue_events_url":"https://api.github.com/repos/alphagov/signonotron2/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/signonotron2/events","assignees_url":"https://api.github.com/repos/alphagov/signonotron2/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/signonotron2/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/signonotron2/tags","blobs_url":"https://api.github.com/repos/alphagov/signonotron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/signonotron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/signonotron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/signonotron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/signonotron2/languages","stargazers_url":"https://api.github.com/repos/alphagov/signonotron2/stargazers","contributors_url":"https://api.github.com/repos/alphagov/signonotron2/contributors","subscribers_url":"https://api.github.com/repos/alphagov/signonotron2/subscribers","subscription_url":"https://api.github.com/repos/alphagov/signonotron2/subscription","commits_url":"https://api.github.com/repos/alphagov/signonotron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/signonotron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/signonotron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/signonotron2/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/signonotron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/signonotron2/merges","archive_url":"https://api.github.com/repos/alphagov/signonotron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/signonotron2/downloads","issues_url":"https://api.github.com/repos/alphagov/signonotron2/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/signonotron2/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/signonotron2/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/signonotron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/signonotron2/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/signonotron2/releases{/id}","created_at":"2012-04-04T13:23:55Z","updated_at":"2015-05-10T07:11:13Z","pushed_at":"2015-06-16T14:51:25Z","git_url":"git://github.com/alphagov/signonotron2.git","ssh_url":"git@github.com:alphagov/signonotron2.git","clone_url":"https://github.com/alphagov/signonotron2.git","svn_url":"https://github.com/alphagov/signonotron2","homepage":"","size":7709,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":36,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"ee0e80a77f98bd92513ea72d505daefa79e2930e","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":3928902,"name":"signonotron2","full_name":"alphagov/signonotron2","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/signonotron2","description":"Single sign-on service for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/signonotron2","forks_url":"https://api.github.com/repos/alphagov/signonotron2/forks","keys_url":"https://api.github.com/repos/alphagov/signonotron2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/signonotron2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/signonotron2/teams","hooks_url":"https://api.github.com/repos/alphagov/signonotron2/hooks","issue_events_url":"https://api.github.com/repos/alphagov/signonotron2/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/signonotron2/events","assignees_url":"https://api.github.com/repos/alphagov/signonotron2/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/signonotron2/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/signonotron2/tags","blobs_url":"https://api.github.com/repos/alphagov/signonotron2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/signonotron2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/signonotron2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/signonotron2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/signonotron2/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/signonotron2/languages","stargazers_url":"https://api.github.com/repos/alphagov/signonotron2/stargazers","contributors_url":"https://api.github.com/repos/alphagov/signonotron2/contributors","subscribers_url":"https://api.github.com/repos/alphagov/signonotron2/subscribers","subscription_url":"https://api.github.com/repos/alphagov/signonotron2/subscription","commits_url":"https://api.github.com/repos/alphagov/signonotron2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/signonotron2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/signonotron2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/signonotron2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/signonotron2/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/signonotron2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/signonotron2/merges","archive_url":"https://api.github.com/repos/alphagov/signonotron2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/signonotron2/downloads","issues_url":"https://api.github.com/repos/alphagov/signonotron2/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/signonotron2/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/signonotron2/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/signonotron2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/signonotron2/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/signonotron2/releases{/id}","created_at":"2012-04-04T13:23:55Z","updated_at":"2015-05-10T07:11:13Z","pushed_at":"2015-06-16T14:51:25Z","git_url":"git://github.com/alphagov/signonotron2.git","ssh_url":"git@github.com:alphagov/signonotron2.git","clone_url":"https://github.com/alphagov/signonotron2.git","svn_url":"https://github.com/alphagov/signonotron2","homepage":"","size":7709,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/364"},"html":{"href":"https://github.com/alphagov/signonotron2/pull/364"},"issue":{"href":"https://api.github.com/repos/alphagov/signonotron2/issues/364"},"comments":{"href":"https://api.github.com/repos/alphagov/signonotron2/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/signonotron2/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/signonotron2/statuses/37214ffc4570637c2a54da4e95557859bd034b78"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bishboria","id":184071,"avatar_url":"https://avatars.githubusercontent.com/u/184071?v=3","gravatar_id":"","url":"https://api.github.com/users/bishboria","html_url":"https://github.com/bishboria","followers_url":"https://api.github.com/users/bishboria/followers","following_url":"https://api.github.com/users/bishboria/following{/other_user}","gists_url":"https://api.github.com/users/bishboria/gists{/gist_id}","starred_url":"https://api.github.com/users/bishboria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bishboria/subscriptions","organizations_url":"https://api.github.com/users/bishboria/orgs","repos_url":"https://api.github.com/users/bishboria/repos","events_url":"https://api.github.com/users/bishboria/events{/privacy}","received_events_url":"https://api.github.com/users/bishboria/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}