{"action":"created","comment":{"url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/comments/45555741","id":45555741,"diff_hunk":"@@ -13,25 +13,114 @@\n \n * Not human readable - Binary format makes it harder to read/grep\n * More complex - More logic = more work = more time/resources?\n-\n \"\"\"\n \n+import os\n+import sqlite3\n+\n+import boltons","path":"espymetrics/dal/sqlite_dal.py","position":10,"original_position":10,"commit_id":"274fa2163e481b6d5569be2b893a8ae6af953406","original_commit_id":"274fa2163e481b6d5569be2b893a8ae6af953406","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"body":"Another unused import, but this one is more concerning. Because it's a third-party package, this can really harm the reader's impression of the following code's reusability.\r\n\r\nYou should add [PyLint](http://www.pylint.org/) to your editor. PyLint will tell you about unused imports.","created_at":"2015-11-22T08:12:38Z","updated_at":"2015-11-22T08:12:38Z","html_url":"https://github.com/mahmoud/espymetrics/pull/2#discussion_r45555741","pull_request_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/comments/45555741"},"html":{"href":"https://github.com/mahmoud/espymetrics/pull/2#discussion_r45555741"},"pull_request":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2","id":51460107,"html_url":"https://github.com/mahmoud/espymetrics/pull/2","diff_url":"https://github.com/mahmoud/espymetrics/pull/2.diff","patch_url":"https://github.com/mahmoud/espymetrics/pull/2.patch","issue_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/2","number":2,"state":"open","locked":false,"title":"A proposed SQLite DAL","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"body":"**NB**: *This is a staged pull request, full of bad code (hence the branch name), so that we can see how some Python antipatterns manifest. I'll be playing the part of both the submitter and the reviewer, but the submitter (starting with the message following the italics) will write in quotes.*\r\n\r\n\"I really like the LineDAL's JSONLines approach, and saw there was a stubbed out version of a SQLite implementation, so I am submitting this proposed implementation. I'm new to Python, so please let me know what you think.\"","created_at":"2015-11-22T08:07:07Z","updated_at":"2015-11-22T08:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe4ae6af41a8c3dc12efc2c5a1f9814d9cb73d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/2/comments","statuses_url":"https://api.github.com/repos/mahmoud/espymetrics/statuses/274fa2163e481b6d5569be2b893a8ae6af953406","head":{"label":"mahmoud:bad_sql_dal","ref":"bad_sql_dal","sha":"274fa2163e481b6d5569be2b893a8ae6af953406","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"repo":{"id":46608170,"name":"espymetrics","full_name":"mahmoud/espymetrics","owner":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mahmoud/espymetrics","description":"","fork":false,"url":"https://api.github.com/repos/mahmoud/espymetrics","forks_url":"https://api.github.com/repos/mahmoud/espymetrics/forks","keys_url":"https://api.github.com/repos/mahmoud/espymetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mahmoud/espymetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mahmoud/espymetrics/teams","hooks_url":"https://api.github.com/repos/mahmoud/espymetrics/hooks","issue_events_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/events{/number}","events_url":"https://api.github.com/repos/mahmoud/espymetrics/events","assignees_url":"https://api.github.com/repos/mahmoud/espymetrics/assignees{/user}","branches_url":"https://api.github.com/repos/mahmoud/espymetrics/branches{/branch}","tags_url":"https://api.github.com/repos/mahmoud/espymetrics/tags","blobs_url":"https://api.github.com/repos/mahmoud/espymetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mahmoud/espymetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mahmoud/espymetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/mahmoud/espymetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mahmoud/espymetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/mahmoud/espymetrics/languages","stargazers_url":"https://api.github.com/repos/mahmoud/espymetrics/stargazers","contributors_url":"https://api.github.com/repos/mahmoud/espymetrics/contributors","subscribers_url":"https://api.github.com/repos/mahmoud/espymetrics/subscribers","subscription_url":"https://api.github.com/repos/mahmoud/espymetrics/subscription","commits_url":"https://api.github.com/repos/mahmoud/espymetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/mahmoud/espymetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/mahmoud/espymetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/mahmoud/espymetrics/contents/{+path}","compare_url":"https://api.github.com/repos/mahmoud/espymetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mahmoud/espymetrics/merges","archive_url":"https://api.github.com/repos/mahmoud/espymetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mahmoud/espymetrics/downloads","issues_url":"https://api.github.com/repos/mahmoud/espymetrics/issues{/number}","pulls_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/mahmoud/espymetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/mahmoud/espymetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mahmoud/espymetrics/labels{/name}","releases_url":"https://api.github.com/repos/mahmoud/espymetrics/releases{/id}","created_at":"2015-11-21T08:54:55Z","updated_at":"2015-11-21T09:51:13Z","pushed_at":"2015-11-22T08:07:07Z","git_url":"git://github.com/mahmoud/espymetrics.git","ssh_url":"git@github.com:mahmoud/espymetrics.git","clone_url":"https://github.com/mahmoud/espymetrics.git","svn_url":"https://github.com/mahmoud/espymetrics","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mahmoud:master","ref":"master","sha":"b16f022cafcd961ee5a0330af595549a69366e0e","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"repo":{"id":46608170,"name":"espymetrics","full_name":"mahmoud/espymetrics","owner":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mahmoud/espymetrics","description":"","fork":false,"url":"https://api.github.com/repos/mahmoud/espymetrics","forks_url":"https://api.github.com/repos/mahmoud/espymetrics/forks","keys_url":"https://api.github.com/repos/mahmoud/espymetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mahmoud/espymetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mahmoud/espymetrics/teams","hooks_url":"https://api.github.com/repos/mahmoud/espymetrics/hooks","issue_events_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/events{/number}","events_url":"https://api.github.com/repos/mahmoud/espymetrics/events","assignees_url":"https://api.github.com/repos/mahmoud/espymetrics/assignees{/user}","branches_url":"https://api.github.com/repos/mahmoud/espymetrics/branches{/branch}","tags_url":"https://api.github.com/repos/mahmoud/espymetrics/tags","blobs_url":"https://api.github.com/repos/mahmoud/espymetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mahmoud/espymetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mahmoud/espymetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/mahmoud/espymetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mahmoud/espymetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/mahmoud/espymetrics/languages","stargazers_url":"https://api.github.com/repos/mahmoud/espymetrics/stargazers","contributors_url":"https://api.github.com/repos/mahmoud/espymetrics/contributors","subscribers_url":"https://api.github.com/repos/mahmoud/espymetrics/subscribers","subscription_url":"https://api.github.com/repos/mahmoud/espymetrics/subscription","commits_url":"https://api.github.com/repos/mahmoud/espymetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/mahmoud/espymetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/mahmoud/espymetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/mahmoud/espymetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/mahmoud/espymetrics/contents/{+path}","compare_url":"https://api.github.com/repos/mahmoud/espymetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mahmoud/espymetrics/merges","archive_url":"https://api.github.com/repos/mahmoud/espymetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mahmoud/espymetrics/downloads","issues_url":"https://api.github.com/repos/mahmoud/espymetrics/issues{/number}","pulls_url":"https://api.github.com/repos/mahmoud/espymetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/mahmoud/espymetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/mahmoud/espymetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mahmoud/espymetrics/labels{/name}","releases_url":"https://api.github.com/repos/mahmoud/espymetrics/releases{/id}","created_at":"2015-11-21T08:54:55Z","updated_at":"2015-11-21T09:51:13Z","pushed_at":"2015-11-22T08:07:07Z","git_url":"git://github.com/mahmoud/espymetrics.git","ssh_url":"git@github.com:mahmoud/espymetrics.git","clone_url":"https://github.com/mahmoud/espymetrics.git","svn_url":"https://github.com/mahmoud/espymetrics","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2"},"html":{"href":"https://github.com/mahmoud/espymetrics/pull/2"},"issue":{"href":"https://api.github.com/repos/mahmoud/espymetrics/issues/2"},"comments":{"href":"https://api.github.com/repos/mahmoud/espymetrics/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mahmoud/espymetrics/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mahmoud/espymetrics/statuses/274fa2163e481b6d5569be2b893a8ae6af953406"}}}}