{"action":"created","issue":{"url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/7","labels_url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/7/comments","events_url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/7/events","html_url":"https://github.com/digitalinteraction/openmovement/issues/7","id":63894555,"number":7,"title":"cwa-convert Java - CwaBlock copy constructor misses fields","user":{"login":"Woodz","id":966157,"avatar_url":"https://avatars.githubusercontent.com/u/966157?v=3","gravatar_id":"","url":"https://api.github.com/users/Woodz","html_url":"https://github.com/Woodz","followers_url":"https://api.github.com/users/Woodz/followers","following_url":"https://api.github.com/users/Woodz/following{/other_user}","gists_url":"https://api.github.com/users/Woodz/gists{/gist_id}","starred_url":"https://api.github.com/users/Woodz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Woodz/subscriptions","organizations_url":"https://api.github.com/users/Woodz/orgs","repos_url":"https://api.github.com/users/Woodz/repos","events_url":"https://api.github.com/users/Woodz/events{/privacy}","received_events_url":"https://api.github.com/users/Woodz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-24T03:25:22Z","updated_at":"2015-03-24T11:34:42Z","closed_at":"2015-03-24T11:34:42Z","body":"The copy constructor at https://github.com/digitalinteraction/openmovement/blob/master/Software/AX3/cwa-convert/java/src/newcastle/cwa/CwaBlock.java#L130 is incorrect as it only copies some of the fields. The temperature, battery, light, events and number of samples are left as the default 0 value. This causes issues particularly in the method `CwaReader.readBlock` at https://github.com/digitalinteraction/openmovement/blob/master/Software/AX3/cwa-convert/java/src/newcastle/cwa/CwaReader.java#L116 that uses the copy constructor to return a copy of the current block. Due to this bug, the block returned is missing key fields so cannot be used."},"comment":{"url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/comments/85458045","html_url":"https://github.com/digitalinteraction/openmovement/issues/7#issuecomment-85458045","issue_url":"https://api.github.com/repos/digitalinteraction/openmovement/issues/7","id":85458045,"user":{"login":"danielgjackson","id":3837249,"avatar_url":"https://avatars.githubusercontent.com/u/3837249?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgjackson","html_url":"https://github.com/danielgjackson","followers_url":"https://api.github.com/users/danielgjackson/followers","following_url":"https://api.github.com/users/danielgjackson/following{/other_user}","gists_url":"https://api.github.com/users/danielgjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgjackson/subscriptions","organizations_url":"https://api.github.com/users/danielgjackson/orgs","repos_url":"https://api.github.com/users/danielgjackson/repos","events_url":"https://api.github.com/users/danielgjackson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgjackson/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T11:34:42Z","updated_at":"2015-03-24T11:34:42Z","body":"Thanks for the bug report -- the copy constructor has now been fixed. The Java code has not been used very heavily before, so this issue had gone unnoticed."}}