{"action":"created","comment":{"url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/comments/31564045","id":31564045,"diff_hunk":"@@ -283,22 +288,48 @@ module FacetLegacy {\n           break;\n         case \"is\":\n           attributeMeta = this.getAttributeMeta(filter.attribute);\n-          return {\n-            type: \"selector\",\n-            dimension: filter.attribute,\n-            value: attributeMeta.serialize((<IsFilter>filter).value)\n-          };\n+          if (extractionFn) {\n+            return {\n+              type: \"extraction\",\n+              dimension: filter.attribute,\n+              value: attributeMeta.serialize((<IsFilter>filter).value),\n+              extractionFn: extractionFn\n+            };\n+          } else {\n+            return {\n+              type: \"selector\",\n+              dimension: filter.attribute,\n+              value: attributeMeta.serialize((<IsFilter>filter).value),\n+            };\n+          }\n         case \"in\":\n           attributeMeta = this.getAttributeMeta(filter.attribute);\n           return {\n             type: \"or\",\n-            fields: (<InFilter>filter).values.map(((value: any) => ({ // ToDo: Do we need the any?\n-              type: \"selector\",\n-              dimension: filter.attribute,\n-              value: attributeMeta.serialize(value)\n-            })), this)\n+            fields: (<InFilter>filter).values.map(\n+              ((value) => {\n+                if (extractionFn) {","path":"src/driver/druidDriver.ts","position":67,"original_position":67,"commit_id":"6e5f034e4d5abcd33d0d5595a63484b368a34612","original_commit_id":"6e5f034e4d5abcd33d0d5595a63484b368a34612","user":{"login":"aprilrd","id":855813,"avatar_url":"https://avatars.githubusercontent.com/u/855813?v=3","gravatar_id":"","url":"https://api.github.com/users/aprilrd","html_url":"https://github.com/aprilrd","followers_url":"https://api.github.com/users/aprilrd/followers","following_url":"https://api.github.com/users/aprilrd/following{/other_user}","gists_url":"https://api.github.com/users/aprilrd/gists{/gist_id}","starred_url":"https://api.github.com/users/aprilrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprilrd/subscriptions","organizations_url":"https://api.github.com/users/aprilrd/orgs","repos_url":"https://api.github.com/users/aprilrd/repos","events_url":"https://api.github.com/users/aprilrd/events{/privacy}","received_events_url":"https://api.github.com/users/aprilrd/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2015-06-02T19:57:37Z","updated_at":"2015-06-02T19:57:37Z","html_url":"https://github.com/facetjs/facetjs-legacy/pull/2#discussion_r31564045","pull_request_url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/comments/31564045"},"html":{"href":"https://github.com/facetjs/facetjs-legacy/pull/2#discussion_r31564045"},"pull_request":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2","id":36651704,"html_url":"https://github.com/facetjs/facetjs-legacy/pull/2","diff_url":"https://github.com/facetjs/facetjs-legacy/pull/2.diff","patch_url":"https://github.com/facetjs/facetjs-legacy/pull/2.patch","issue_url":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/2","number":2,"state":"open","locked":false,"title":"Query time lookups","user":{"login":"epistemancer","id":10035733,"avatar_url":"https://avatars.githubusercontent.com/u/10035733?v=3","gravatar_id":"","url":"https://api.github.com/users/epistemancer","html_url":"https://github.com/epistemancer","followers_url":"https://api.github.com/users/epistemancer/followers","following_url":"https://api.github.com/users/epistemancer/following{/other_user}","gists_url":"https://api.github.com/users/epistemancer/gists{/gist_id}","starred_url":"https://api.github.com/users/epistemancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epistemancer/subscriptions","organizations_url":"https://api.github.com/users/epistemancer/orgs","repos_url":"https://api.github.com/users/epistemancer/repos","events_url":"https://api.github.com/users/epistemancer/events{/privacy}","received_events_url":"https://api.github.com/users/epistemancer/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-01T17:36:33Z","updated_at":"2015-06-02T19:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f402db1c922811f0412087cbcb2f195295ec8de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/2/comments","statuses_url":"https://api.github.com/repos/facetjs/facetjs-legacy/statuses/6e5f034e4d5abcd33d0d5595a63484b368a34612","head":{"label":"epistemancer:query_time_lookups","ref":"query_time_lookups","sha":"6e5f034e4d5abcd33d0d5595a63484b368a34612","user":{"login":"epistemancer","id":10035733,"avatar_url":"https://avatars.githubusercontent.com/u/10035733?v=3","gravatar_id":"","url":"https://api.github.com/users/epistemancer","html_url":"https://github.com/epistemancer","followers_url":"https://api.github.com/users/epistemancer/followers","following_url":"https://api.github.com/users/epistemancer/following{/other_user}","gists_url":"https://api.github.com/users/epistemancer/gists{/gist_id}","starred_url":"https://api.github.com/users/epistemancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epistemancer/subscriptions","organizations_url":"https://api.github.com/users/epistemancer/orgs","repos_url":"https://api.github.com/users/epistemancer/repos","events_url":"https://api.github.com/users/epistemancer/events{/privacy}","received_events_url":"https://api.github.com/users/epistemancer/received_events","type":"User","site_admin":false},"repo":{"id":34535028,"name":"facetjs-legacy","full_name":"epistemancer/facetjs-legacy","owner":{"login":"epistemancer","id":10035733,"avatar_url":"https://avatars.githubusercontent.com/u/10035733?v=3","gravatar_id":"","url":"https://api.github.com/users/epistemancer","html_url":"https://github.com/epistemancer","followers_url":"https://api.github.com/users/epistemancer/followers","following_url":"https://api.github.com/users/epistemancer/following{/other_user}","gists_url":"https://api.github.com/users/epistemancer/gists{/gist_id}","starred_url":"https://api.github.com/users/epistemancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epistemancer/subscriptions","organizations_url":"https://api.github.com/users/epistemancer/orgs","repos_url":"https://api.github.com/users/epistemancer/repos","events_url":"https://api.github.com/users/epistemancer/events{/privacy}","received_events_url":"https://api.github.com/users/epistemancer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epistemancer/facetjs-legacy","description":"The legacy part of facetjs","fork":true,"url":"https://api.github.com/repos/epistemancer/facetjs-legacy","forks_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/forks","keys_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/teams","hooks_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/hooks","issue_events_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/events","assignees_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/tags","blobs_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/languages","stargazers_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/stargazers","contributors_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/contributors","subscribers_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/subscribers","subscription_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/subscription","commits_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/merges","archive_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/downloads","issues_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/labels{/name}","releases_url":"https://api.github.com/repos/epistemancer/facetjs-legacy/releases{/id}","created_at":"2015-04-24T18:32:09Z","updated_at":"2015-04-24T18:32:10Z","pushed_at":"2015-06-02T18:21:09Z","git_url":"git://github.com/epistemancer/facetjs-legacy.git","ssh_url":"git@github.com:epistemancer/facetjs-legacy.git","clone_url":"https://github.com/epistemancer/facetjs-legacy.git","svn_url":"https://github.com/epistemancer/facetjs-legacy","homepage":null,"size":13965,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facetjs:master","ref":"master","sha":"6ad6905fdb513faf60971da57690e95d340e6fe5","user":{"login":"facetjs","id":10750714,"avatar_url":"https://avatars.githubusercontent.com/u/10750714?v=3","gravatar_id":"","url":"https://api.github.com/users/facetjs","html_url":"https://github.com/facetjs","followers_url":"https://api.github.com/users/facetjs/followers","following_url":"https://api.github.com/users/facetjs/following{/other_user}","gists_url":"https://api.github.com/users/facetjs/gists{/gist_id}","starred_url":"https://api.github.com/users/facetjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facetjs/subscriptions","organizations_url":"https://api.github.com/users/facetjs/orgs","repos_url":"https://api.github.com/users/facetjs/repos","events_url":"https://api.github.com/users/facetjs/events{/privacy}","received_events_url":"https://api.github.com/users/facetjs/received_events","type":"Organization","site_admin":false},"repo":{"id":34491453,"name":"facetjs-legacy","full_name":"facetjs/facetjs-legacy","owner":{"login":"facetjs","id":10750714,"avatar_url":"https://avatars.githubusercontent.com/u/10750714?v=3","gravatar_id":"","url":"https://api.github.com/users/facetjs","html_url":"https://github.com/facetjs","followers_url":"https://api.github.com/users/facetjs/followers","following_url":"https://api.github.com/users/facetjs/following{/other_user}","gists_url":"https://api.github.com/users/facetjs/gists{/gist_id}","starred_url":"https://api.github.com/users/facetjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facetjs/subscriptions","organizations_url":"https://api.github.com/users/facetjs/orgs","repos_url":"https://api.github.com/users/facetjs/repos","events_url":"https://api.github.com/users/facetjs/events{/privacy}","received_events_url":"https://api.github.com/users/facetjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facetjs/facetjs-legacy","description":"The legacy part of facetjs","fork":false,"url":"https://api.github.com/repos/facetjs/facetjs-legacy","forks_url":"https://api.github.com/repos/facetjs/facetjs-legacy/forks","keys_url":"https://api.github.com/repos/facetjs/facetjs-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facetjs/facetjs-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facetjs/facetjs-legacy/teams","hooks_url":"https://api.github.com/repos/facetjs/facetjs-legacy/hooks","issue_events_url":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/facetjs/facetjs-legacy/events","assignees_url":"https://api.github.com/repos/facetjs/facetjs-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/facetjs/facetjs-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/facetjs/facetjs-legacy/tags","blobs_url":"https://api.github.com/repos/facetjs/facetjs-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facetjs/facetjs-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facetjs/facetjs-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/facetjs/facetjs-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facetjs/facetjs-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/facetjs/facetjs-legacy/languages","stargazers_url":"https://api.github.com/repos/facetjs/facetjs-legacy/stargazers","contributors_url":"https://api.github.com/repos/facetjs/facetjs-legacy/contributors","subscribers_url":"https://api.github.com/repos/facetjs/facetjs-legacy/subscribers","subscription_url":"https://api.github.com/repos/facetjs/facetjs-legacy/subscription","commits_url":"https://api.github.com/repos/facetjs/facetjs-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/facetjs/facetjs-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/facetjs/facetjs-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/facetjs/facetjs-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/facetjs/facetjs-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facetjs/facetjs-legacy/merges","archive_url":"https://api.github.com/repos/facetjs/facetjs-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facetjs/facetjs-legacy/downloads","issues_url":"https://api.github.com/repos/facetjs/facetjs-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/facetjs/facetjs-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/facetjs/facetjs-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facetjs/facetjs-legacy/labels{/name}","releases_url":"https://api.github.com/repos/facetjs/facetjs-legacy/releases{/id}","created_at":"2015-04-24T01:37:20Z","updated_at":"2015-04-27T17:55:51Z","pushed_at":"2015-06-02T18:21:09Z","git_url":"git://github.com/facetjs/facetjs-legacy.git","ssh_url":"git@github.com:facetjs/facetjs-legacy.git","clone_url":"https://github.com/facetjs/facetjs-legacy.git","svn_url":"https://github.com/facetjs/facetjs-legacy","homepage":null,"size":13994,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2"},"html":{"href":"https://github.com/facetjs/facetjs-legacy/pull/2"},"issue":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/2"},"comments":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/facetjs/facetjs-legacy/statuses/6e5f034e4d5abcd33d0d5595a63484b368a34612"}}}}