{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/2892","labels_url":"https://api.github.com/repos/openshift/origin/issues/2892/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2892/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/2892/events","html_url":"https://github.com/openshift/origin/pull/2892","id":85635572,"number":2892,"title":"WIP: Deployment canary","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":49,"created_at":"2015-06-05T21:20:34Z","updated_at":"2015-06-09T22:05:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2892","html_url":"https://github.com/openshift/origin/pull/2892","diff_url":"https://github.com/openshift/origin/pull/2892.diff","patch_url":"https://github.com/openshift/origin/pull/2892.patch"},"body":"# DO NOT MERGE\r\n\r\nThis is a WIP to get early feedback on deployment canary functionality for #2637.\r\n\r\nNotes to self:\r\n* Multiple pods are matching the replica selector when going from version 1 to version 2, not sure why yet.\r\n* Canary failure is correctly aborting the deployment; the reason the canary's failing in a manual test I performed is because either a.) the store isn't getting populated correctly with the pod, or b.) the pod used for the store Get call isn't matching the pod in the store."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/110518598","html_url":"https://github.com/openshift/origin/pull/2892#issuecomment-110518598","issue_url":"https://api.github.com/repos/openshift/origin/issues/2892","id":110518598,"user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T22:05:43Z","updated_at":"2015-06-09T22:05:43Z","body":"@csrwng @abhgupta @smarterclayton I've pushed code which implements our new rules, and things are looking much better. [Here's a gist](https://gist.github.com/ironcladlou/e5274d55836770348248) with logs/context from the complete/fail/complete scenario. Any manual testing or review would be appreciated while I work to get the unit tests solvent (there's a ton to redo- but the deployment code is now much simpler with our rules)."}}