{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/xjavascript/issues/106","labels_url":"https://api.github.com/repos/exercism/xjavascript/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/exercism/xjavascript/issues/106/comments","events_url":"https://api.github.com/repos/exercism/xjavascript/issues/106/events","html_url":"https://github.com/exercism/xjavascript/pull/106","id":103933665,"number":106,"title":"Improve test specs on \"Leap\" exercise","user":{"login":"rchavarria","id":612688,"avatar_url":"https://avatars.githubusercontent.com/u/612688?v=3","gravatar_id":"","url":"https://api.github.com/users/rchavarria","html_url":"https://github.com/rchavarria","followers_url":"https://api.github.com/users/rchavarria/followers","following_url":"https://api.github.com/users/rchavarria/following{/other_user}","gists_url":"https://api.github.com/users/rchavarria/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavarria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavarria/subscriptions","organizations_url":"https://api.github.com/users/rchavarria/orgs","repos_url":"https://api.github.com/users/rchavarria/repos","events_url":"https://api.github.com/users/rchavarria/events{/privacy}","received_events_url":"https://api.github.com/users/rchavarria/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-30T16:43:10Z","updated_at":"2015-09-01T14:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/exercism/xjavascript/pulls/106","html_url":"https://github.com/exercism/xjavascript/pull/106","diff_url":"https://github.com/exercism/xjavascript/pull/106.diff","patch_url":"https://github.com/exercism/xjavascript/pull/106.patch"},"body":"While solving this exercise for exercism.io I thought test specs could be improved (from my point of view, so I might be wrong). This PR tries to clarify the specs and provides some more examples of leap and non-leap years.\r\n\r\nSpecs haven't changed, but I hope texts describing them are clearer now.\r\n"},"comment":{"url":"https://api.github.com/repos/exercism/xjavascript/issues/comments/136735222","html_url":"https://github.com/exercism/xjavascript/pull/106#issuecomment-136735222","issue_url":"https://api.github.com/repos/exercism/xjavascript/issues/106","id":136735222,"user":{"login":"rchavarria","id":612688,"avatar_url":"https://avatars.githubusercontent.com/u/612688?v=3","gravatar_id":"","url":"https://api.github.com/users/rchavarria","html_url":"https://github.com/rchavarria","followers_url":"https://api.github.com/users/rchavarria/followers","following_url":"https://api.github.com/users/rchavarria/following{/other_user}","gists_url":"https://api.github.com/users/rchavarria/gists{/gist_id}","starred_url":"https://api.github.com/users/rchavarria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchavarria/subscriptions","organizations_url":"https://api.github.com/users/rchavarria/orgs","repos_url":"https://api.github.com/users/rchavarria/repos","events_url":"https://api.github.com/users/rchavarria/events{/privacy}","received_events_url":"https://api.github.com/users/rchavarria/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T14:14:30Z","updated_at":"2015-09-01T14:14:30Z","body":"Ooops. My apologies. It wasn't my intention to test such corner cases. Yep, I'm aware of some *interruptions* or particularities in the Gregorian calendar, but I didn't take them into account here. I was thinking of years just as integers, as @verdammelt said: test should mean just integer division and modularization. I understand that using years below 1800 can lead to confusion.\r\n\r\nWow, I didn't think adding a couple of examples would create such a great discussion. Thanks everybody.\r\n\r\nI will write a main `describe` block, with just one assertion for each existing test case. And an additional `xdescribe` block with another example for each test case. I'll take care of corner cases due to the Gregorian calendar (maybe, just using future years)."}}