{"action":"created","issue":{"url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/313","labels_url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/313/comments","events_url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/313/events","html_url":"https://github.com/mdhiggins/sickbeard_mp4_automator/issues/313","id":104320081,"number":313,"title":"Adding subs increase video length / bad sub found","user":{"login":"thezoggy","id":500882,"avatar_url":"https://avatars.githubusercontent.com/u/500882?v=3","gravatar_id":"","url":"https://api.github.com/users/thezoggy","html_url":"https://github.com/thezoggy","followers_url":"https://api.github.com/users/thezoggy/followers","following_url":"https://api.github.com/users/thezoggy/following{/other_user}","gists_url":"https://api.github.com/users/thezoggy/gists{/gist_id}","starred_url":"https://api.github.com/users/thezoggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezoggy/subscriptions","organizations_url":"https://api.github.com/users/thezoggy/orgs","repos_url":"https://api.github.com/users/thezoggy/repos","events_url":"https://api.github.com/users/thezoggy/events{/privacy}","received_events_url":"https://api.github.com/users/thezoggy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-01T17:48:30Z","updated_at":"2015-09-04T14:03:53Z","closed_at":null,"body":"source video file is 42m33s, auotmator found sub... when it adds the sub the video is now 43m16s.\r\nplaying the video the sub is not in sync with the video.. so that told me to look closer at the srt file...\r\nlooking at the .srt found, the last entry is `00:43:14,999 --> 00:43:16,999`.\r\nconfirmed that the actual video file jumps from 42m33->43m16s at the end during playback.\r\n\r\nif i strip the sub off `ffmpeg -i video.mkv -vcodec copy -acodec copy -sn video-no-subs.mkv` then the time goes back to what it should.\r\n\r\nthus, it would be nice to have subliminal/automator check if the sub is actually valid for the file.. if theres time code marks thats longer than the media file.. pretty clear sign the sub is going to be bad.\r\n\r\n> source: Shark.Tank.S01E09.720p.HDTV.x264-NTb.mkv"},"comment":{"url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/comments/137745736","html_url":"https://github.com/mdhiggins/sickbeard_mp4_automator/issues/313#issuecomment-137745736","issue_url":"https://api.github.com/repos/mdhiggins/sickbeard_mp4_automator/issues/313","id":137745736,"user":{"login":"mdhiggins","id":3608298,"avatar_url":"https://avatars.githubusercontent.com/u/3608298?v=3","gravatar_id":"","url":"https://api.github.com/users/mdhiggins","html_url":"https://github.com/mdhiggins","followers_url":"https://api.github.com/users/mdhiggins/followers","following_url":"https://api.github.com/users/mdhiggins/following{/other_user}","gists_url":"https://api.github.com/users/mdhiggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mdhiggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdhiggins/subscriptions","organizations_url":"https://api.github.com/users/mdhiggins/orgs","repos_url":"https://api.github.com/users/mdhiggins/repos","events_url":"https://api.github.com/users/mdhiggins/events{/privacy}","received_events_url":"https://api.github.com/users/mdhiggins/received_events","type":"User","site_admin":false},"created_at":"2015-09-04T14:03:53Z","updated_at":"2015-09-04T14:03:53Z","body":"This would be a nice feature to be built into subliminal.\r\n\r\nOne of the ways that I had attempted to minimize this previously was that I modified subliminal to accept an additional 'original filename' parameter. In some scenarios by the time subliminial is analyzing the file to attempt to find subs, the file has been renamed by Sickbeard/CP/etc and has lost most of the important identifying release information that lets it correctly identify properly timed subs. This feature seemed to work fairly well but at the same time made it a huge pain to install and keep subliminal up to date. I'll look into adding some further analysis that can maybe minimize this problem but it would definitely be something that would be better suited to incorporate into a future subliminal release. I would maybe open this issue up on their github and see what they think."}}