{"action":"closed","issue":{"url":"https://api.github.com/repos/domokit/mojo/issues/367","labels_url":"https://api.github.com/repos/domokit/mojo/issues/367/labels{/name}","comments_url":"https://api.github.com/repos/domokit/mojo/issues/367/comments","events_url":"https://api.github.com/repos/domokit/mojo/issues/367/events","html_url":"https://github.com/domokit/mojo/issues/367","id":99743034,"number":367,"title":"Consider deleting ApplicationDelegate::ConfigureOutgoingConnection","user":{"login":"j9brown","id":102276,"avatar_url":"https://avatars.githubusercontent.com/u/102276?v=3","gravatar_id":"","url":"https://api.github.com/users/j9brown","html_url":"https://github.com/j9brown","followers_url":"https://api.github.com/users/j9brown/followers","following_url":"https://api.github.com/users/j9brown/following{/other_user}","gists_url":"https://api.github.com/users/j9brown/gists{/gist_id}","starred_url":"https://api.github.com/users/j9brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j9brown/subscriptions","organizations_url":"https://api.github.com/users/j9brown/orgs","repos_url":"https://api.github.com/users/j9brown/repos","events_url":"https://api.github.com/users/j9brown/events{/privacy}","received_events_url":"https://api.github.com/users/j9brown/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"j9brown","id":102276,"avatar_url":"https://avatars.githubusercontent.com/u/102276?v=3","gravatar_id":"","url":"https://api.github.com/users/j9brown","html_url":"https://github.com/j9brown","followers_url":"https://api.github.com/users/j9brown/followers","following_url":"https://api.github.com/users/j9brown/following{/other_user}","gists_url":"https://api.github.com/users/j9brown/gists{/gist_id}","starred_url":"https://api.github.com/users/j9brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j9brown/subscriptions","organizations_url":"https://api.github.com/users/j9brown/orgs","repos_url":"https://api.github.com/users/j9brown/repos","events_url":"https://api.github.com/users/j9brown/events{/privacy}","received_events_url":"https://api.github.com/users/j9brown/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-08-07T22:48:57Z","updated_at":"2015-09-30T19:45:33Z","closed_at":"2015-09-30T19:45:33Z","body":"This method is invoked as part of each outgoing connection to deny the connection and/or provide services.  Nobody is using it other than a test case.\r\n\r\nAlthough the filtering might still be useful for implementing certain kinds of security policies one wonders why an application would deny its own outbound connection attempt (since it could easily bypass that policy in other ways).  That said, being able to observe all outgoing connections may be useful for tracing and debugging but still not terribly useful.\r\n\r\nAs for providing services, a much safer pattern is to call AddService on the returned ApplicationConnection instance from ConnectToApplication since the caller of that method is more likely to have information about what services should be offered than the ApplicationDelegate.  Moreover, ConfigureOutgoingConnection makes it far too easy to accidentally expose services to all outgoing connections including some that could be security sensitive.\r\n\r\nAll told, I think we should delete this method.\r\n\r\nThoughts?"}}