{"action":"closed","number":309,"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/309","id":42528484,"html_url":"https://github.com/cloudflare/cfssl/pull/309","diff_url":"https://github.com/cloudflare/cfssl/pull/309.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/309.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/309","number":309,"state":"closed","locked":false,"title":"Added ocspsign API endpoint. Support for ocspResponse in cfssljson","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"body":"This is only my second PR so I'm not very familiar with the codebase as a whole but this PR does:\r\n* Added `ocspsign` API endpoint to sign ocsp responses\r\n* Added support for `ocspResponse` in cfssljson\r\n* cfssljson can also now output to stdout using `-stdout`\r\n* `ocspserve` will not silently ignore trailing whitespace (or double spaces) in the responses file\r\n* Updated README with example for creating a OCSP responses file from `ocspsign` cli.\r\n\r\nI don't know if this is okay but I'm getting an error from openssl when parsing the OCSP responses from `ocspsign`:\r\n```\r\n# cfssl ocspsign -ca ca.crt -responder resp.crt -responder-key resp.key -cert test.crt | cfssljson -bare ocsp\r\n# openssl ocsp -text -respin ocsp-response.der\r\nOCSP Response Data:\r\n    OCSP Response Status: successful (0x0)\r\nError parsing response\r\n140127808935840:error:0D0680A8:asn1 encoding routines:ASN1_CHECK_TLEN:wrong tag:tasn_dec.c:1342:\r\n140127808935840:error:0D06C03A:asn1 encoding routines:ASN1_D2I_EX_PRIMITIVE:nested asn1 error:tasn_dec.c:854:\r\n140127808935840:error:0D08303A:asn1 encoding routines:ASN1_TEMPLATE_NOEXP_D2I:nested asn1 error:tasn_dec.c:774:Field=producedAt, Type=OCSP_RESPDATA\r\n140127808935840:error:0D08303A:asn1 encoding routines:ASN1_TEMPLATE_NOEXP_D2I:nested asn1 error:tasn_dec.c:774:Field=tbsResponseData, Type=OCSP_BASICRESP\r\n140127808935840:error:0D0C706E:asn1 encoding routines:ASN1_item_unpack:decode error:asn_pack.c:189:\r\n    Response Type: Basic OCSP Response\r\n```\r\nShould I file that as a new bug or is that expected?","created_at":"2015-08-16T00:45:44Z","updated_at":"2015-08-31T18:37:46Z","closed_at":"2015-08-31T18:37:46Z","merged_at":"2015-08-31T18:37:46Z","merge_commit_sha":"73c052f59a7dc76f9412d863def08e33150d7048","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/309/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/309/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/309/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/2f10430233c79e9556b9c14913a7991c02073616","head":{"label":"fastest963:master","ref":"master","sha":"2f10430233c79e9556b9c14913a7991c02073616","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"repo":{"id":40687145,"name":"cfssl","full_name":"fastest963/cfssl","owner":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fastest963/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":true,"url":"https://api.github.com/repos/fastest963/cfssl","forks_url":"https://api.github.com/repos/fastest963/cfssl/forks","keys_url":"https://api.github.com/repos/fastest963/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastest963/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastest963/cfssl/teams","hooks_url":"https://api.github.com/repos/fastest963/cfssl/hooks","issue_events_url":"https://api.github.com/repos/fastest963/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/fastest963/cfssl/events","assignees_url":"https://api.github.com/repos/fastest963/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/fastest963/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/fastest963/cfssl/tags","blobs_url":"https://api.github.com/repos/fastest963/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastest963/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastest963/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastest963/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastest963/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/fastest963/cfssl/languages","stargazers_url":"https://api.github.com/repos/fastest963/cfssl/stargazers","contributors_url":"https://api.github.com/repos/fastest963/cfssl/contributors","subscribers_url":"https://api.github.com/repos/fastest963/cfssl/subscribers","subscription_url":"https://api.github.com/repos/fastest963/cfssl/subscription","commits_url":"https://api.github.com/repos/fastest963/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastest963/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastest963/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastest963/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastest963/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/fastest963/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastest963/cfssl/merges","archive_url":"https://api.github.com/repos/fastest963/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastest963/cfssl/downloads","issues_url":"https://api.github.com/repos/fastest963/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/fastest963/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/fastest963/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/fastest963/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastest963/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/fastest963/cfssl/releases{/id}","created_at":"2015-08-14T00:01:06Z","updated_at":"2015-08-14T00:01:07Z","pushed_at":"2015-08-16T17:13:17Z","git_url":"git://github.com/fastest963/cfssl.git","ssh_url":"git@github.com:fastest963/cfssl.git","clone_url":"https://github.com/fastest963/cfssl.git","svn_url":"https://github.com/fastest963/cfssl","homepage":"https://blog.cloudflare.com/introducing-cfssl","size":1794,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"f19974edc8d246e364cb5e8e458679670a2bba1b","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","created_at":"2014-07-07T23:49:12Z","updated_at":"2015-08-31T16:56:15Z","pushed_at":"2015-08-31T18:37:47Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://blog.cloudflare.com/introducing-cfssl","size":6769,"stargazers_count":811,"watchers_count":811,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":38,"forks":74,"open_issues":38,"watchers":811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/309"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/309"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/309"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/2f10430233c79e9556b9c14913a7991c02073616"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kisom","id":175578,"avatar_url":"https://avatars.githubusercontent.com/u/175578?v=3","gravatar_id":"","url":"https://api.github.com/users/kisom","html_url":"https://github.com/kisom","followers_url":"https://api.github.com/users/kisom/followers","following_url":"https://api.github.com/users/kisom/following{/other_user}","gists_url":"https://api.github.com/users/kisom/gists{/gist_id}","starred_url":"https://api.github.com/users/kisom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisom/subscriptions","organizations_url":"https://api.github.com/users/kisom/orgs","repos_url":"https://api.github.com/users/kisom/repos","events_url":"https://api.github.com/users/kisom/events{/privacy}","received_events_url":"https://api.github.com/users/kisom/received_events","type":"User","site_admin":false},"comments":4,"review_comments":13,"commits":1,"additions":472,"deletions":27,"changed_files":11}}