{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/503","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503/events","html_url":"https://github.com/openzipkin/zipkin/pull/503","id":97020569,"number":503,"title":"Gradle.","user":{"login":"abesto","id":59982,"avatar_url":"https://avatars.githubusercontent.com/u/59982?v=3","gravatar_id":"","url":"https://api.github.com/users/abesto","html_url":"https://github.com/abesto","followers_url":"https://api.github.com/users/abesto/followers","following_url":"https://api.github.com/users/abesto/following{/other_user}","gists_url":"https://api.github.com/users/abesto/gists{/gist_id}","starred_url":"https://api.github.com/users/abesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abesto/subscriptions","organizations_url":"https://api.github.com/users/abesto/orgs","repos_url":"https://api.github.com/users/abesto/repos","events_url":"https://api.github.com/users/abesto/events{/privacy}","received_events_url":"https://api.github.com/users/abesto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openzipkin/zipkin/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/openzipkin/zipkin/labels/releng","name":"releng","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-24T10:20:11Z","updated_at":"2015-07-26T12:54:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/503","html_url":"https://github.com/openzipkin/zipkin/pull/503","diff_url":"https://github.com/openzipkin/zipkin/pull/503.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/503.patch"},"body":"### Why?\r\n\r\nBecause the SBT build is a pain.\r\n\r\n### What works\r\n * `./gradlew check` runs tests using [maiflai/gradle-scalatest](https://github.com/maiflai/gradle-scalatest) and they pass.\r\n * `./gradlew build` builds normal jars, and an IDL jar for `zipkin-thrift`.\r\n * `./gradlew distTar` builds a tar distribution for the stand-alone services\r\n * `./gradlew installDist` generates a runnable version of the services (basically the contents of the output of `distTar`)\r\n\r\n### What doesn't work\r\nI'd appreciate thoughts on how important these are.\r\n\r\n * The `doc` project isn't ported yet. I can take a stab at it, but if someone knows what actually happens there, they'll probably have an easier time.\r\n * `BuildProperties` is not ported. Do we need it?\r\n\r\n### What might not work\r\nI'd appreciate experienced eyes on these\r\n\r\n * Maybe some tests are not picked up by Gradle\r\n * Maybe some artifacts don't look like they should (especially IDL and standalone service stuff)\r\n\r\n### Integration test\r\n\r\nI used https://github.com/openzipkin/docker-zipkin/tree/gradle to bring up Zipkin, and sent traces to it using\r\n\r\n```sh\r\n./zipkin-tracegen/build/install/zipkin-tracegen/bin/zipkin-tracegen -scribeDest=$(docker-machine ip):9410\r\n```\r\n\r\nAnd I saw traces :smile: \r\n\r\n### Notes\r\n * The SBT build system is still in place to make comparison easy. Check out the code, play with it locally, try to break it however you can.\r\n * Will squash before merging\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/124979358","html_url":"https://github.com/openzipkin/zipkin/pull/503#issuecomment-124979358","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/503","id":124979358,"user":{"login":"abesto","id":59982,"avatar_url":"https://avatars.githubusercontent.com/u/59982?v=3","gravatar_id":"","url":"https://api.github.com/users/abesto","html_url":"https://github.com/abesto","followers_url":"https://api.github.com/users/abesto/followers","following_url":"https://api.github.com/users/abesto/following{/other_user}","gists_url":"https://api.github.com/users/abesto/gists{/gist_id}","starred_url":"https://api.github.com/users/abesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abesto/subscriptions","organizations_url":"https://api.github.com/users/abesto/orgs","repos_url":"https://api.github.com/users/abesto/repos","events_url":"https://api.github.com/users/abesto/events{/privacy}","received_events_url":"https://api.github.com/users/abesto/received_events","type":"User","site_admin":false},"created_at":"2015-07-26T12:54:23Z","updated_at":"2015-07-26T12:54:23Z","body":"Tests are now run using maiflai/gradle-scalatest, and some manual tests suggest the whole thing working (see details in description)."}}