{"action":"created","comment":{"url":"https://api.github.com/repos/MediaMath/grim/pulls/comments/32249061","id":32249061,"diff_hunk":"@@ -161,22 +163,23 @@ func buildGlobalEffectiveConfig(global *config) effectiveConfig {\n \n func buildLocalEffectiveConfig(global effectiveConfig, local *config, owner, repo string) effectiveConfig {\n \treturn effectiveConfig{\n-\t\tgrimQueueName:   global.grimQueueName,\n-\t\tresultRoot:      global.resultRoot,\n-\t\tworkspaceRoot:   global.workspaceRoot,\n-\t\tawsRegion:       global.awsRegion,\n-\t\tawsKey:          global.awsKey,\n-\t\tawsSecret:       global.awsSecret,\n-\t\tgrimServerID:    global.grimServerID,\n-\t\tgitHubToken:     firstNonEmptyStringPtr(local.GitHubToken, &global.gitHubToken),\n-\t\thipChatRoom:     firstNonEmptyStringPtr(local.HipChatRoom, &global.hipChatRoom),\n-\t\thipChatToken:    firstNonEmptyStringPtr(local.HipChatToken, &global.hipChatToken),\n-\t\tpendingTemplate: firstNonEmptyStringPtr(local.PendingTemplate, &global.pendingTemplate),\n-\t\tsuccessTemplate: firstNonEmptyStringPtr(local.SuccessTemplate, &global.successTemplate),\n-\t\terrorTemplate:   firstNonEmptyStringPtr(local.ErrorTemplate, &global.errorTemplate),\n-\t\tfailureTemplate: firstNonEmptyStringPtr(local.FailureTemplate, &global.failureTemplate),\n-\t\tpathToCloneIn:   firstNonEmptyStringPtr(local.PathToCloneIn),\n-\t\tsnsTopicName:    firstNonEmptyStringPtr(local.SnsTopicName, defaultTopicName(owner, repo)),\n+\t\tgrimQueueName:     global.grimQueueName,\n+\t\tresultRoot:        global.resultRoot,\n+\t\tworkspaceRoot:     global.workspaceRoot,\n+\t\tawsRegion:         global.awsRegion,\n+\t\tawsKey:            global.awsKey,\n+\t\tawsSecret:         global.awsSecret,\n+\t\tgrimServerID:      global.grimServerID,\n+\t\tgitHubToken:       firstNonEmptyStringPtr(local.GitHubToken, &global.gitHubToken),\n+\t\thipChatRoom:       firstNonEmptyStringPtr(local.HipChatRoom, &global.hipChatRoom),\n+\t\thipChatToken:      firstNonEmptyStringPtr(local.HipChatToken, &global.hipChatToken),\n+\t\tpendingTemplate:   firstNonEmptyStringPtr(local.PendingTemplate, &global.pendingTemplate),\n+\t\tsuccessTemplate:   firstNonEmptyStringPtr(local.SuccessTemplate, &global.successTemplate),\n+\t\terrorTemplate:     firstNonEmptyStringPtr(local.ErrorTemplate, &global.errorTemplate),\n+\t\tfailureTemplate:   firstNonEmptyStringPtr(local.FailureTemplate, &global.failureTemplate),\n+\t\tpathToCloneIn:     firstNonEmptyStringPtr(local.PathToCloneIn),\n+\t\tsnsTopicName:      firstNonEmptyStringPtr(local.SnsTopicName, defaultTopicName(owner, repo)),\n+\t\tusernameWhitelist: local.UsernameWhitelist,","path":"config.go","position":112,"original_position":112,"commit_id":"019f872f15abbb6e60ca16b121c7a1ca0bbc1ad0","original_commit_id":"019f872f15abbb6e60ca16b121c7a1ca0bbc1ad0","user":{"login":"bhand-mm","id":5913552,"avatar_url":"https://avatars.githubusercontent.com/u/5913552?v=3","gravatar_id":"","url":"https://api.github.com/users/bhand-mm","html_url":"https://github.com/bhand-mm","followers_url":"https://api.github.com/users/bhand-mm/followers","following_url":"https://api.github.com/users/bhand-mm/following{/other_user}","gists_url":"https://api.github.com/users/bhand-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/bhand-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhand-mm/subscriptions","organizations_url":"https://api.github.com/users/bhand-mm/orgs","repos_url":"https://api.github.com/users/bhand-mm/repos","events_url":"https://api.github.com/users/bhand-mm/events{/privacy}","received_events_url":"https://api.github.com/users/bhand-mm/received_events","type":"User","site_admin":false},"body":"Seems messy.  Would specifying both result in merge or local override?","created_at":"2015-06-11T17:57:48Z","updated_at":"2015-06-11T17:57:48Z","html_url":"https://github.com/MediaMath/grim/pull/66#discussion_r32249061","pull_request_url":"https://api.github.com/repos/MediaMath/grim/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/comments/32249061"},"html":{"href":"https://github.com/MediaMath/grim/pull/66#discussion_r32249061"},"pull_request":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/MediaMath/grim/pulls/66","id":37490538,"html_url":"https://github.com/MediaMath/grim/pull/66","diff_url":"https://github.com/MediaMath/grim/pull/66.diff","patch_url":"https://github.com/MediaMath/grim/pull/66.patch","issue_url":"https://api.github.com/repos/MediaMath/grim/issues/66","number":66,"state":"open","locked":false,"title":"username whitelist","user":{"login":"bhand-mm","id":5913552,"avatar_url":"https://avatars.githubusercontent.com/u/5913552?v=3","gravatar_id":"","url":"https://api.github.com/users/bhand-mm","html_url":"https://github.com/bhand-mm","followers_url":"https://api.github.com/users/bhand-mm/followers","following_url":"https://api.github.com/users/bhand-mm/following{/other_user}","gists_url":"https://api.github.com/users/bhand-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/bhand-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhand-mm/subscriptions","organizations_url":"https://api.github.com/users/bhand-mm/orgs","repos_url":"https://api.github.com/users/bhand-mm/repos","events_url":"https://api.github.com/users/bhand-mm/events{/privacy}","received_events_url":"https://api.github.com/users/bhand-mm/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-11T17:54:44Z","updated_at":"2015-06-11T17:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa20a88e92ab73b8163bbca9cdd51feee4041abb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MediaMath/grim/pulls/66/commits","review_comments_url":"https://api.github.com/repos/MediaMath/grim/pulls/66/comments","review_comment_url":"https://api.github.com/repos/MediaMath/grim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MediaMath/grim/issues/66/comments","statuses_url":"https://api.github.com/repos/MediaMath/grim/statuses/019f872f15abbb6e60ca16b121c7a1ca0bbc1ad0","head":{"label":"bhand-mm:username-whitelist","ref":"username-whitelist","sha":"019f872f15abbb6e60ca16b121c7a1ca0bbc1ad0","user":{"login":"bhand-mm","id":5913552,"avatar_url":"https://avatars.githubusercontent.com/u/5913552?v=3","gravatar_id":"","url":"https://api.github.com/users/bhand-mm","html_url":"https://github.com/bhand-mm","followers_url":"https://api.github.com/users/bhand-mm/followers","following_url":"https://api.github.com/users/bhand-mm/following{/other_user}","gists_url":"https://api.github.com/users/bhand-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/bhand-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhand-mm/subscriptions","organizations_url":"https://api.github.com/users/bhand-mm/orgs","repos_url":"https://api.github.com/users/bhand-mm/repos","events_url":"https://api.github.com/users/bhand-mm/events{/privacy}","received_events_url":"https://api.github.com/users/bhand-mm/received_events","type":"User","site_admin":false},"repo":{"id":36530132,"name":"grim","full_name":"bhand-mm/grim","owner":{"login":"bhand-mm","id":5913552,"avatar_url":"https://avatars.githubusercontent.com/u/5913552?v=3","gravatar_id":"","url":"https://api.github.com/users/bhand-mm","html_url":"https://github.com/bhand-mm","followers_url":"https://api.github.com/users/bhand-mm/followers","following_url":"https://api.github.com/users/bhand-mm/following{/other_user}","gists_url":"https://api.github.com/users/bhand-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/bhand-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhand-mm/subscriptions","organizations_url":"https://api.github.com/users/bhand-mm/orgs","repos_url":"https://api.github.com/users/bhand-mm/repos","events_url":"https://api.github.com/users/bhand-mm/events{/privacy}","received_events_url":"https://api.github.com/users/bhand-mm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhand-mm/grim","description":"a dead simple build server","fork":true,"url":"https://api.github.com/repos/bhand-mm/grim","forks_url":"https://api.github.com/repos/bhand-mm/grim/forks","keys_url":"https://api.github.com/repos/bhand-mm/grim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhand-mm/grim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhand-mm/grim/teams","hooks_url":"https://api.github.com/repos/bhand-mm/grim/hooks","issue_events_url":"https://api.github.com/repos/bhand-mm/grim/issues/events{/number}","events_url":"https://api.github.com/repos/bhand-mm/grim/events","assignees_url":"https://api.github.com/repos/bhand-mm/grim/assignees{/user}","branches_url":"https://api.github.com/repos/bhand-mm/grim/branches{/branch}","tags_url":"https://api.github.com/repos/bhand-mm/grim/tags","blobs_url":"https://api.github.com/repos/bhand-mm/grim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhand-mm/grim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhand-mm/grim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhand-mm/grim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhand-mm/grim/statuses/{sha}","languages_url":"https://api.github.com/repos/bhand-mm/grim/languages","stargazers_url":"https://api.github.com/repos/bhand-mm/grim/stargazers","contributors_url":"https://api.github.com/repos/bhand-mm/grim/contributors","subscribers_url":"https://api.github.com/repos/bhand-mm/grim/subscribers","subscription_url":"https://api.github.com/repos/bhand-mm/grim/subscription","commits_url":"https://api.github.com/repos/bhand-mm/grim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhand-mm/grim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhand-mm/grim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhand-mm/grim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhand-mm/grim/contents/{+path}","compare_url":"https://api.github.com/repos/bhand-mm/grim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhand-mm/grim/merges","archive_url":"https://api.github.com/repos/bhand-mm/grim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhand-mm/grim/downloads","issues_url":"https://api.github.com/repos/bhand-mm/grim/issues{/number}","pulls_url":"https://api.github.com/repos/bhand-mm/grim/pulls{/number}","milestones_url":"https://api.github.com/repos/bhand-mm/grim/milestones{/number}","notifications_url":"https://api.github.com/repos/bhand-mm/grim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhand-mm/grim/labels{/name}","releases_url":"https://api.github.com/repos/bhand-mm/grim/releases{/id}","created_at":"2015-05-29T21:29:37Z","updated_at":"2015-05-29T21:29:37Z","pushed_at":"2015-06-11T17:54:40Z","git_url":"git://github.com/bhand-mm/grim.git","ssh_url":"git@github.com:bhand-mm/grim.git","clone_url":"https://github.com/bhand-mm/grim.git","svn_url":"https://github.com/bhand-mm/grim","homepage":"","size":205,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MediaMath:master","ref":"master","sha":"4fbf648185356ebeabc47425e61463bb58a3b823","user":{"login":"MediaMath","id":2982134,"avatar_url":"https://avatars.githubusercontent.com/u/2982134?v=3","gravatar_id":"","url":"https://api.github.com/users/MediaMath","html_url":"https://github.com/MediaMath","followers_url":"https://api.github.com/users/MediaMath/followers","following_url":"https://api.github.com/users/MediaMath/following{/other_user}","gists_url":"https://api.github.com/users/MediaMath/gists{/gist_id}","starred_url":"https://api.github.com/users/MediaMath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MediaMath/subscriptions","organizations_url":"https://api.github.com/users/MediaMath/orgs","repos_url":"https://api.github.com/users/MediaMath/repos","events_url":"https://api.github.com/users/MediaMath/events{/privacy}","received_events_url":"https://api.github.com/users/MediaMath/received_events","type":"Organization","site_admin":false},"repo":{"id":35443467,"name":"grim","full_name":"MediaMath/grim","owner":{"login":"MediaMath","id":2982134,"avatar_url":"https://avatars.githubusercontent.com/u/2982134?v=3","gravatar_id":"","url":"https://api.github.com/users/MediaMath","html_url":"https://github.com/MediaMath","followers_url":"https://api.github.com/users/MediaMath/followers","following_url":"https://api.github.com/users/MediaMath/following{/other_user}","gists_url":"https://api.github.com/users/MediaMath/gists{/gist_id}","starred_url":"https://api.github.com/users/MediaMath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MediaMath/subscriptions","organizations_url":"https://api.github.com/users/MediaMath/orgs","repos_url":"https://api.github.com/users/MediaMath/repos","events_url":"https://api.github.com/users/MediaMath/events{/privacy}","received_events_url":"https://api.github.com/users/MediaMath/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MediaMath/grim","description":"a dead simple build server","fork":false,"url":"https://api.github.com/repos/MediaMath/grim","forks_url":"https://api.github.com/repos/MediaMath/grim/forks","keys_url":"https://api.github.com/repos/MediaMath/grim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MediaMath/grim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MediaMath/grim/teams","hooks_url":"https://api.github.com/repos/MediaMath/grim/hooks","issue_events_url":"https://api.github.com/repos/MediaMath/grim/issues/events{/number}","events_url":"https://api.github.com/repos/MediaMath/grim/events","assignees_url":"https://api.github.com/repos/MediaMath/grim/assignees{/user}","branches_url":"https://api.github.com/repos/MediaMath/grim/branches{/branch}","tags_url":"https://api.github.com/repos/MediaMath/grim/tags","blobs_url":"https://api.github.com/repos/MediaMath/grim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MediaMath/grim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MediaMath/grim/git/refs{/sha}","trees_url":"https://api.github.com/repos/MediaMath/grim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MediaMath/grim/statuses/{sha}","languages_url":"https://api.github.com/repos/MediaMath/grim/languages","stargazers_url":"https://api.github.com/repos/MediaMath/grim/stargazers","contributors_url":"https://api.github.com/repos/MediaMath/grim/contributors","subscribers_url":"https://api.github.com/repos/MediaMath/grim/subscribers","subscription_url":"https://api.github.com/repos/MediaMath/grim/subscription","commits_url":"https://api.github.com/repos/MediaMath/grim/commits{/sha}","git_commits_url":"https://api.github.com/repos/MediaMath/grim/git/commits{/sha}","comments_url":"https://api.github.com/repos/MediaMath/grim/comments{/number}","issue_comment_url":"https://api.github.com/repos/MediaMath/grim/issues/comments{/number}","contents_url":"https://api.github.com/repos/MediaMath/grim/contents/{+path}","compare_url":"https://api.github.com/repos/MediaMath/grim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MediaMath/grim/merges","archive_url":"https://api.github.com/repos/MediaMath/grim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MediaMath/grim/downloads","issues_url":"https://api.github.com/repos/MediaMath/grim/issues{/number}","pulls_url":"https://api.github.com/repos/MediaMath/grim/pulls{/number}","milestones_url":"https://api.github.com/repos/MediaMath/grim/milestones{/number}","notifications_url":"https://api.github.com/repos/MediaMath/grim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MediaMath/grim/labels{/name}","releases_url":"https://api.github.com/repos/MediaMath/grim/releases{/id}","created_at":"2015-05-11T18:55:15Z","updated_at":"2015-06-11T16:07:04Z","pushed_at":"2015-06-11T17:54:45Z","git_url":"git://github.com/MediaMath/grim.git","ssh_url":"git@github.com:MediaMath/grim.git","clone_url":"https://github.com/MediaMath/grim.git","svn_url":"https://github.com/MediaMath/grim","homepage":"","size":645,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/66"},"html":{"href":"https://github.com/MediaMath/grim/pull/66"},"issue":{"href":"https://api.github.com/repos/MediaMath/grim/issues/66"},"comments":{"href":"https://api.github.com/repos/MediaMath/grim/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MediaMath/grim/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/MediaMath/grim/statuses/019f872f15abbb6e60ca16b121c7a1ca0bbc1ad0"}}}}