{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/steeplechase/pulls/comments/36262729","id":36262729,"diff_hunk":"@@ -76,24 +101,69 @@ function wait_for_message() {\n }\n \n /*\n+ * Return a promise for the next available message\n+ * to come in on |socket|. If there is a queued\n+ * message, resolves the promise immediately, otherwise\n+ * waits for socket_message to receive one.\n+ */\n+function wait_for_admin_message() {\n+  return wait_for_message(socket_messages_admin,socket_message_promises_admin);\n+}\n+\n+/*\n+ * Return a promise for the next available message\n+ * to come in on |socket|. If there is a queued\n+ * message, resolves the promise immediately, otherwise\n+ * waits for socket_message to receive one.\n+ */\n+function wait_for_test_message() {\n+  return wait_for_message(socket_messages_test,socket_message_promises_test);\n+}\n+\n+/*\n  * Send an object as a message on |socket|.\n  */\n-function send_message(data) {\n-  socket.send(JSON.stringify(data));\n+function send_message(room_to_send,data) {\n+  socket.emit('message', {room: room_to_send, msg: JSON.stringify(data)});\n }\n \n-function connect_socket() {\n+/*\n+* Send an object as a message on |socket|.\n+*/\n+function send_admin_message(data) {\n+  send_message(adminroom,data);\n+}\n+\n+/*\n+* Send an object as a message on |socket|.\n+*/\n+function send_test_message(data) {\n+  send_message(testroom,data);\n+}\n+\n+\n+function connect_socket(type) {\n   var server = SpecialPowers.getCharPref(\"steeplechase.signalling_server\");\n   if (server.substr(server.length - 1) != \"/\") {\n     server += \"/\";\n   }\n-  var room = SpecialPowers.getCharPref(\"steeplechase.signalling_room\");\n+  var adminroom = SpecialPowers.getCharPref(\"steeplechase.signalling_room\");","path":"webharness/harness.js","position":139,"original_position":139,"commit_id":"b0ca1e8ae04d69aef3dcf7888bdbc6fb72554ef7","original_commit_id":"b0ca1e8ae04d69aef3dcf7888bdbc6fb72554ef7","user":{"login":"nils-ohlmeier","id":6109500,"avatar_url":"https://avatars.githubusercontent.com/u/6109500?v=3","gravatar_id":"","url":"https://api.github.com/users/nils-ohlmeier","html_url":"https://github.com/nils-ohlmeier","followers_url":"https://api.github.com/users/nils-ohlmeier/followers","following_url":"https://api.github.com/users/nils-ohlmeier/following{/other_user}","gists_url":"https://api.github.com/users/nils-ohlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/nils-ohlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nils-ohlmeier/subscriptions","organizations_url":"https://api.github.com/users/nils-ohlmeier/orgs","repos_url":"https://api.github.com/users/nils-ohlmeier/repos","events_url":"https://api.github.com/users/nils-ohlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/nils-ohlmeier/received_events","type":"User","site_admin":false},"body":"This variable over-writes the global var 'adminroom'. Not sure if that is a good idea.","created_at":"2015-08-05T01:43:49Z","updated_at":"2015-08-05T01:43:49Z","html_url":"https://github.com/mozilla/steeplechase/pull/18#discussion_r36262729","pull_request_url":"https://api.github.com/repos/mozilla/steeplechase/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/comments/36262729"},"html":{"href":"https://github.com/mozilla/steeplechase/pull/18#discussion_r36262729"},"pull_request":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/steeplechase/pulls/18","id":41626323,"html_url":"https://github.com/mozilla/steeplechase/pull/18","diff_url":"https://github.com/mozilla/steeplechase/pull/18.diff","patch_url":"https://github.com/mozilla/steeplechase/pull/18.patch","issue_url":"https://api.github.com/repos/mozilla/steeplechase/issues/18","number":18,"state":"open","locked":false,"title":"Added ability to restrict each test to a different room","user":{"login":"RitheshShenthar","id":9885324,"avatar_url":"https://avatars.githubusercontent.com/u/9885324?v=3","gravatar_id":"","url":"https://api.github.com/users/RitheshShenthar","html_url":"https://github.com/RitheshShenthar","followers_url":"https://api.github.com/users/RitheshShenthar/followers","following_url":"https://api.github.com/users/RitheshShenthar/following{/other_user}","gists_url":"https://api.github.com/users/RitheshShenthar/gists{/gist_id}","starred_url":"https://api.github.com/users/RitheshShenthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RitheshShenthar/subscriptions","organizations_url":"https://api.github.com/users/RitheshShenthar/orgs","repos_url":"https://api.github.com/users/RitheshShenthar/repos","events_url":"https://api.github.com/users/RitheshShenthar/events{/privacy}","received_events_url":"https://api.github.com/users/RitheshShenthar/received_events","type":"User","site_admin":false},"body":"The changes made to steeplechase allow tests to run in individual rooms using the same socket by restricting the messaging to specific rooms and exiting those rooms after each test.","created_at":"2015-08-04T22:43:12Z","updated_at":"2015-08-05T01:43:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4ff252cdae83a9014919bc33931e3e4148fa673","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/steeplechase/pulls/18/commits","review_comments_url":"https://api.github.com/repos/mozilla/steeplechase/pulls/18/comments","review_comment_url":"https://api.github.com/repos/mozilla/steeplechase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/steeplechase/issues/18/comments","statuses_url":"https://api.github.com/repos/mozilla/steeplechase/statuses/b0ca1e8ae04d69aef3dcf7888bdbc6fb72554ef7","head":{"label":"RitheshShenthar:MultipleRooms","ref":"MultipleRooms","sha":"b0ca1e8ae04d69aef3dcf7888bdbc6fb72554ef7","user":{"login":"RitheshShenthar","id":9885324,"avatar_url":"https://avatars.githubusercontent.com/u/9885324?v=3","gravatar_id":"","url":"https://api.github.com/users/RitheshShenthar","html_url":"https://github.com/RitheshShenthar","followers_url":"https://api.github.com/users/RitheshShenthar/followers","following_url":"https://api.github.com/users/RitheshShenthar/following{/other_user}","gists_url":"https://api.github.com/users/RitheshShenthar/gists{/gist_id}","starred_url":"https://api.github.com/users/RitheshShenthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RitheshShenthar/subscriptions","organizations_url":"https://api.github.com/users/RitheshShenthar/orgs","repos_url":"https://api.github.com/users/RitheshShenthar/repos","events_url":"https://api.github.com/users/RitheshShenthar/events{/privacy}","received_events_url":"https://api.github.com/users/RitheshShenthar/received_events","type":"User","site_admin":false},"repo":{"id":40144122,"name":"steeplechase","full_name":"RitheshShenthar/steeplechase","owner":{"login":"RitheshShenthar","id":9885324,"avatar_url":"https://avatars.githubusercontent.com/u/9885324?v=3","gravatar_id":"","url":"https://api.github.com/users/RitheshShenthar","html_url":"https://github.com/RitheshShenthar","followers_url":"https://api.github.com/users/RitheshShenthar/followers","following_url":"https://api.github.com/users/RitheshShenthar/following{/other_user}","gists_url":"https://api.github.com/users/RitheshShenthar/gists{/gist_id}","starred_url":"https://api.github.com/users/RitheshShenthar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RitheshShenthar/subscriptions","organizations_url":"https://api.github.com/users/RitheshShenthar/orgs","repos_url":"https://api.github.com/users/RitheshShenthar/repos","events_url":"https://api.github.com/users/RitheshShenthar/events{/privacy}","received_events_url":"https://api.github.com/users/RitheshShenthar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RitheshShenthar/steeplechase","description":"WebRTC automation for testing NAT traversal","fork":true,"url":"https://api.github.com/repos/RitheshShenthar/steeplechase","forks_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/forks","keys_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/teams","hooks_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/hooks","issue_events_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/issues/events{/number}","events_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/events","assignees_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/assignees{/user}","branches_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/branches{/branch}","tags_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/tags","blobs_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/git/refs{/sha}","trees_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/statuses/{sha}","languages_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/languages","stargazers_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/stargazers","contributors_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/contributors","subscribers_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/subscribers","subscription_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/subscription","commits_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/commits{/sha}","git_commits_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/git/commits{/sha}","comments_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/comments{/number}","issue_comment_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/issues/comments{/number}","contents_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/contents/{+path}","compare_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/merges","archive_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/downloads","issues_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/issues{/number}","pulls_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/pulls{/number}","milestones_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/milestones{/number}","notifications_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/labels{/name}","releases_url":"https://api.github.com/repos/RitheshShenthar/steeplechase/releases{/id}","created_at":"2015-08-03T19:34:21Z","updated_at":"2015-08-03T19:34:21Z","pushed_at":"2015-08-04T22:41:57Z","git_url":"git://github.com/RitheshShenthar/steeplechase.git","ssh_url":"git@github.com:RitheshShenthar/steeplechase.git","clone_url":"https://github.com/RitheshShenthar/steeplechase.git","svn_url":"https://github.com/RitheshShenthar/steeplechase","homepage":null,"size":453,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"559c1284a7f57e6c8da9f3269035eb7ea522fceb","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":19992574,"name":"steeplechase","full_name":"mozilla/steeplechase","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/steeplechase","description":"WebRTC automation for testing NAT traversal","fork":true,"url":"https://api.github.com/repos/mozilla/steeplechase","forks_url":"https://api.github.com/repos/mozilla/steeplechase/forks","keys_url":"https://api.github.com/repos/mozilla/steeplechase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/steeplechase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/steeplechase/teams","hooks_url":"https://api.github.com/repos/mozilla/steeplechase/hooks","issue_events_url":"https://api.github.com/repos/mozilla/steeplechase/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/steeplechase/events","assignees_url":"https://api.github.com/repos/mozilla/steeplechase/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/steeplechase/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/steeplechase/tags","blobs_url":"https://api.github.com/repos/mozilla/steeplechase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/steeplechase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/steeplechase/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/steeplechase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/steeplechase/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/steeplechase/languages","stargazers_url":"https://api.github.com/repos/mozilla/steeplechase/stargazers","contributors_url":"https://api.github.com/repos/mozilla/steeplechase/contributors","subscribers_url":"https://api.github.com/repos/mozilla/steeplechase/subscribers","subscription_url":"https://api.github.com/repos/mozilla/steeplechase/subscription","commits_url":"https://api.github.com/repos/mozilla/steeplechase/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/steeplechase/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/steeplechase/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/steeplechase/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/steeplechase/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/steeplechase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/steeplechase/merges","archive_url":"https://api.github.com/repos/mozilla/steeplechase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/steeplechase/downloads","issues_url":"https://api.github.com/repos/mozilla/steeplechase/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/steeplechase/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/steeplechase/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/steeplechase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/steeplechase/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/steeplechase/releases{/id}","created_at":"2014-05-20T18:32:25Z","updated_at":"2015-06-26T21:14:05Z","pushed_at":"2015-08-04T22:43:12Z","git_url":"git://github.com/mozilla/steeplechase.git","ssh_url":"git@github.com:mozilla/steeplechase.git","clone_url":"https://github.com/mozilla/steeplechase.git","svn_url":"https://github.com/mozilla/steeplechase","homepage":null,"size":453,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/18"},"html":{"href":"https://github.com/mozilla/steeplechase/pull/18"},"issue":{"href":"https://api.github.com/repos/mozilla/steeplechase/issues/18"},"comments":{"href":"https://api.github.com/repos/mozilla/steeplechase/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/steeplechase/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/steeplechase/statuses/b0ca1e8ae04d69aef3dcf7888bdbc6fb72554ef7"}}}}