{"push_id":580964792,"size":51,"distinct_size":1,"ref":"refs/heads/dev","head":"a1c36348d9f180c135bc8522719da52331e0cffa","before":"dcb913decf0d6c1230f6243bcbba0a0af3ee9da7","commits":[{"sha":"5bd59ca7314f3dbd2386ae03cf4a3aee6ee5bdd5","author":{"email":"4f5fe8f64e5adf12e65822b8958d7b4f54e8da60@gmail.com","name":"Sergey Martynov"},"message":"fix issue with mount('*') when doing transclusion\n\nI have following markup on the page\r\n```jade\r\ntabs\r\n  tab(title=\"First\")\r\n    p First tab content\r\n  tab(title=\"Second\")\r\n    p Second tab content\r\n  tab(title=\"Third\")\r\n    p Third tab content\r\n```\r\nand tags\r\n```jade\r\ntabs\r\n  ul.nav.nav-tabs\r\n    li(class='{active:tab.isActive}' each='{tab in tabs}')\r\n      a(href='#' onclick='{parent.selectTab}') {tab.title}\r\n\r\n  .tabs-wrapper(name='wrapper')\r\n\r\n  script.\r\n    //- transclude\r\n    while (this.root.firstChild) {\r\n      this.wrapper.appendChild(this.root.firstChild)\r\n    }\r\n    this.on('mount', function() {\r\n      this.tabs = this.children.slice()\r\n      var active = this.tabs.filter(function(tab) { return tab.isActive })\r\n      if (this.tabs.length && !active.length) {\r\n        this.tabs[0].isActive = true\r\n      }\r\n      this.update()\r\n    })\r\n    this.selectTab = function(event) {\r\n      this.tabs.forEach(function(tab) { tab.isActive = false })\r\n      event.item.tab.isActive = true\r\n      this.update()\r\n    }.bind(this)\r\n\r\n\r\ntab\r\n  .tab-content(name='content' show='{isActive}')\r\n\r\n  script.\r\n    //- transclude\r\n    while (this.root.firstChild) {\r\n      this.content.appendChild(this.root.firstChild)\r\n    }\r\n    this.on('mount', function() {\r\n      this.title = this.root.getAttribute('title')\r\n    })\r\n```\r\n\r\nThere is an issues with riot.mount('*') in WIP, 2.0.8 doing fine.\r\n\r\nmy example in WIP working this way:\r\n1. mount call querySelectorAll which collects all tags from page dom and then mountTo all of it \r\n2. during creation of <tabs> it's inner dom from page transcluded to template\r\n3. parseLayout create tags for all <tab> transcluded to <tabs> template\r\n4. <tabs> fires 'mount' event and configure it's <tab>s\r\n5. mount get <tab> collected on step 1, tag for it is already created on step 3, but mountTo force creation of new one\r\n\r\nForcing creation of already mounted tag is this case have following issues:\r\n1. inner dom of <tab> is already transcluded to template and configured template moved to page dom, when force creation of it again transclude will get already configured template from page dom instead of original dom, so <tab> get wrapped in another <tab>\r\n2. on step 4 <tabs> configure it's 3 <tab>s, but when mountTo create new tags for <tab> it's not removing original one, so <tags> will have 6 child <tab>s instead of 3, last 3 <tab>s are not configured during 'mount' event, so they all will be hidden with original <tab>s wrapped in it, <tabs> didn't get any notification of new children so there is no way to configure it","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/5bd59ca7314f3dbd2386ae03cf4a3aee6ee5bdd5"},{"sha":"784fde30a93aeddf9ba1071ce7f31e6ff26c7119","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Contributing guidelines","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/784fde30a93aeddf9ba1071ce7f31e6ff26c7119"},{"sha":"89dd9f793753c8bb0a2bea5e9c4bfc334a8d80e7","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"indentation fixes on the memory test file","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/89dd9f793753c8bb0a2bea5e9c4bfc334a8d80e7"},{"sha":"7f31de55b61e8dfcd411d93e8c0e3132cba6e15b","author":{"email":"b6d00115765422ee3f74567d4afcbf0a8c6a4825@gmail.com","name":"Tianxiang Chen"},"message":"Add one more example, hackernews reader\n\nWith 2.0.9, the blocking bugs are resolved, so the example is ready to ship:)\r\nThis one is using browserify to pack all the js into single one, just to show another style to build app with riotjs.","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/7f31de55b61e8dfcd411d93e8c0e3132cba6e15b"},{"sha":"15d3f2ed5f3d4e1973ef51a05c1a5ae13a10f292","author":{"email":"63afe4f8461ecca94cb27e44ee1ae980cf91d3a1@users.noreply.github.com","name":"Alexis THOMAS"},"message":"Update direct download links","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/15d3f2ed5f3d4e1973ef51a05c1a5ae13a10f292"},{"sha":"d1803c9fbf72a8e1a49c6af33e290d49ec0dc706","author":{"email":"b6d00115765422ee3f74567d4afcbf0a8c6a4825@gmail.com","name":"Tianxiang Chen"},"message":"Add todomvc example link","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/d1803c9fbf72a8e1a49c6af33e290d49ec0dc706"},{"sha":"7076702dc97295ca85934f598f2b18c341c05188","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Merge pull request #365 from txchen/master\n\nAdd two more examples, hackernews reader and todomvc","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/7076702dc97295ca85934f598f2b18c341c05188"},{"sha":"a754f7c71957c0e80767deff10e1ec65d890e16a","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Merge pull request #369 from ath0mas/patch-1\n\nUpdate direct download links","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/a754f7c71957c0e80767deff10e1ec65d890e16a"},{"sha":"cb03a05e1f3e214a7da4425ecdd4bdf45bb2ea79","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Merge pull request #364 from GianlucaGuarini/master\n\nindentation fixes on the memory test file","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/cb03a05e1f3e214a7da4425ecdd4bdf45bb2ea79"},{"sha":"a87f24efcbcb4709e496066190e4ecdaca784aa6","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Merge pull request #355 from martynovs/patch-1\n\nfix issue with mount('*') when doing transclusion","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/a87f24efcbcb4709e496066190e4ecdaca784aa6"},{"sha":"c2601734d7db31c796888d89cb60667c280d74e4","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"fix again the indentation issues","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/c2601734d7db31c796888d89cb60667c280d74e4"},{"sha":"9c4f40da278bfe930b64d183b0e8e1ce0f4356f6","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"added first mocha tests","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/9c4f40da278bfe930b64d183b0e8e1ce0f4356f6"},{"sha":"6de2b85ad5eea5a5d2b7343911e7438915af98f6","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"small fix to the make file","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/6de2b85ad5eea5a5d2b7343911e7438915af98f6"},{"sha":"01ce14d373ecd3f7feb247c14cde654df5443840","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"code coverage","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/01ce14d373ecd3f7feb247c14cde654df5443840"},{"sha":"63fc213fe45ffbc1c01d57dbca4d559da6b972da","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"travis file removed","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/63fc213fe45ffbc1c01d57dbca4d559da6b972da"},{"sha":"9d2f136619e6dcdcde9c7cec498945d6d2a2259e","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"compile -> compiles","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/9d2f136619e6dcdcde9c7cec498945d6d2a2259e"},{"sha":"cd9ef4955f3c06288ab3a84fa7b31831c7093d7e","author":{"email":"47684e40844c4ad2686ce7181b5ed771c49b1ff0@qq.com","name":"TZ | 天猪"},"message":"Riot Snake Game","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/cd9ef4955f3c06288ab3a84fa7b31831c7093d7e"},{"sha":"2508a1dd61e891142be0907b202ed1790307f9da","author":{"email":"23e3dc27a89090583f1c6fce2a787e14c537d7e7@gmail.com","name":"Tero Piirainen"},"message":"Merge pull request #396 from atian25/master\n\nRiot Snake Game","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/2508a1dd61e891142be0907b202ed1790307f9da"},{"sha":"c4172bfcce7639be62c010e1d3b60e14b5234582","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"merging the dev branch","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/c4172bfcce7639be62c010e1d3b60e14b5234582"},{"sha":"4df6b941a069693ac8a3ea13982f54d7e1502a29","author":{"email":"958c1ccaa2e087e512b9a9bb2e118cb110ae9ce1@gmail.com","name":"Gianluca Guarini"},"message":"fix small indentation issues","distinct":false,"url":"https://api.github.com/repos/muut/riotjs/commits/4df6b941a069693ac8a3ea13982f54d7e1502a29"}]}