{"action":"closed","number":15305,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/15305","id":41613239,"html_url":"https://github.com/docker/docker/pull/15305","diff_url":"https://github.com/docker/docker/pull/15305.diff","patch_url":"https://github.com/docker/docker/pull/15305.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/15305","number":15305,"state":"closed","locked":false,"title":"Update some contributions documentations","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Even though #14756 is not closed yet — but we're getting closed 🐧 — I think we should mention somewhere in the contributing docs that the modified file should pass the ``golint`` door :stuck_out_tongue_closed_eyes:.\r\n\r\nThis currently adds a golint entry to ``coding-style.md`` but I was wondering something : we do not talk about ``make validate`` on the contributing docs although it does most of the thing we're asking for a PR (validate-dco, validate-gofmt, validate-lint, validate-toml, validate-vet).\r\n\r\nTo explain this further, one of the *workflow* I use when working on docker is the following (if it's a code one, not a doc one :yum:) :\r\n\r\n- create my branch, doing my changes\r\n- ``make test`` : well ``make test-unit`` or ``make test-integration-cli`` depending on where it's needed but in the end, ``make test``.\r\n- ``make validate`` so I'm sure everything is all right (``gofmt``, ``golint``, etc..)\r\n- and then I can push and PR\r\n\r\nI'm not sure where to put it though — maybe in ``docs/project/work-issue.md`` (updating it to use ``make`` commands) or maybe in ``docs/project/test-and-docs.md`` (but feels a little out of context there). 🐸\r\n\r\n/cc @thaJeztah @moxiegirl wdyt ?\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>","created_at":"2015-08-04T20:25:01Z","updated_at":"2015-08-05T15:46:53Z","closed_at":"2015-08-05T15:46:53Z","merged_at":"2015-08-05T15:46:53Z","merge_commit_sha":"054573d2d7ad35fdb93190e49365c99949272adb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/15305/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/15305/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/15305/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/b30492002172a525513a2c411ebae22149dd4476","head":{"label":"vdemeester:contribution-docs-updates","ref":"contribution-docs-updates","sha":"b30492002172a525513a2c411ebae22149dd4476","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":32953007,"name":"docker","full_name":"vdemeester/docker","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vdemeester/docker","forks_url":"https://api.github.com/repos/vdemeester/docker/forks","keys_url":"https://api.github.com/repos/vdemeester/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/docker/teams","hooks_url":"https://api.github.com/repos/vdemeester/docker/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/docker/events","assignees_url":"https://api.github.com/repos/vdemeester/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/docker/tags","blobs_url":"https://api.github.com/repos/vdemeester/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/docker/languages","stargazers_url":"https://api.github.com/repos/vdemeester/docker/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/docker/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/docker/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/docker/subscription","commits_url":"https://api.github.com/repos/vdemeester/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/docker/merges","archive_url":"https://api.github.com/repos/vdemeester/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/docker/downloads","issues_url":"https://api.github.com/repos/vdemeester/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/docker/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/docker/releases{/id}","created_at":"2015-03-26T21:32:15Z","updated_at":"2015-05-08T12:20:26Z","pushed_at":"2015-08-05T06:25:37Z","git_url":"git://github.com/vdemeester/docker.git","ssh_url":"git@github.com:vdemeester/docker.git","clone_url":"https://github.com/vdemeester/docker.git","svn_url":"https://github.com/vdemeester/docker","homepage":"http://www.docker.com","size":65339,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"d4d3504122211812401456e69cf4852365977a32","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-08-05T15:43:12Z","pushed_at":"2015-08-05T15:46:53Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":234289,"stargazers_count":23763,"watchers_count":23763,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5999,"mirror_url":null,"open_issues_count":1044,"forks":5999,"open_issues":1044,"watchers":23763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/15305"},"html":{"href":"https://github.com/docker/docker/pull/15305"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/15305"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/15305/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/15305/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/15305/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/b30492002172a525513a2c411ebae22149dd4476"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"moxiegirl","id":1347209,"avatar_url":"https://avatars.githubusercontent.com/u/1347209?v=3","gravatar_id":"","url":"https://api.github.com/users/moxiegirl","html_url":"https://github.com/moxiegirl","followers_url":"https://api.github.com/users/moxiegirl/followers","following_url":"https://api.github.com/users/moxiegirl/following{/other_user}","gists_url":"https://api.github.com/users/moxiegirl/gists{/gist_id}","starred_url":"https://api.github.com/users/moxiegirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxiegirl/subscriptions","organizations_url":"https://api.github.com/users/moxiegirl/orgs","repos_url":"https://api.github.com/users/moxiegirl/repos","events_url":"https://api.github.com/users/moxiegirl/events{/privacy}","received_events_url":"https://api.github.com/users/moxiegirl/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}