{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/coding-standards/issues/109","labels_url":"https://api.github.com/repos/joomla/coding-standards/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/joomla/coding-standards/issues/109/comments","events_url":"https://api.github.com/repos/joomla/coding-standards/issues/109/events","html_url":"https://github.com/joomla/coding-standards/pull/109","id":70937933,"number":109,"title":"update for 2.x series and add warning during development","user":{"login":"photodude","id":10253980,"avatar_url":"https://avatars.githubusercontent.com/u/10253980?v=3","gravatar_id":"","url":"https://api.github.com/users/photodude","html_url":"https://github.com/photodude","followers_url":"https://api.github.com/users/photodude/followers","following_url":"https://api.github.com/users/photodude/following{/other_user}","gists_url":"https://api.github.com/users/photodude/gists{/gist_id}","starred_url":"https://api.github.com/users/photodude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/photodude/subscriptions","organizations_url":"https://api.github.com/users/photodude/orgs","repos_url":"https://api.github.com/users/photodude/repos","events_url":"https://api.github.com/users/photodude/events{/privacy}","received_events_url":"https://api.github.com/users/photodude/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-04-25T17:09:03Z","updated_at":"2015-07-27T16:23:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/coding-standards/pulls/109","html_url":"https://github.com/joomla/coding-standards/pull/109","diff_url":"https://github.com/joomla/coding-standards/pull/109.diff","patch_url":"https://github.com/joomla/coding-standards/pull/109.patch"},"body":"Reference issue #53\r\nReference issue #104\r\n\r\nReorder ruleset.xml to better match the Squiz/ruleset.xml\r\nThis improves readability when migrating versions\r\nAlso increased the max line the comment to 150 chars long since it was that way in the code\r\n\r\nThe T_DOC_COMMENT token has also been removed, replaced instead by T_DOC_COMMENT_OPEN_TAG\r\n\r\nrebuild from source with modifications\r\n- add T_FUNCTION, and T_CLASS, to array of tokens\r\n- remove parenthesis_opener checks (as was done previously)\r\n- add T_COMMENT and T_WHILE to the $tokens[$trailingContent] checks (as was done previously)\r\n- This is now a Joomla class sniff\r\n- add comment about the removed section \"parenthesis_opener\"\r\n-- by adding a comment about what was intentionally removed we will help the coding standard be able to make changes quicker when the source standard changes or has bug fixes applied.\r\n\r\nUpdate rules to use source standards to eliminate unnecessary duplication\r\nadd Squiz.WhiteSpace.CastSpacingSniff rule so duplication can be eliminated.\r\n- Since we are not making any specific changes here, this file should likely be eliminated and just include the Squiz standard\r\nadd Generic.WhiteSpace.DisallowSpaceIndentSniff rule\r\nnothing special here, replace with generic rule\r\n- add Generic.PHP.LowerCaseConstantSniff rule\r\nnothing special here, replace with Squiz rule\r\nnothing special here, replace with Squiz rule\r\nnothing special here, replace with PEAR rule\r\nAdd PSR2.ControlStructures.ElseIfDeclaration rule\r\nnote: Sniff is not part of the rule names just the file names\r\n\r\ncopy PR #106 Better documentation of differences from core standards"},"comment":{"url":"https://api.github.com/repos/joomla/coding-standards/issues/comments/125262476","html_url":"https://github.com/joomla/coding-standards/pull/109#issuecomment-125262476","issue_url":"https://api.github.com/repos/joomla/coding-standards/issues/109","id":125262476,"user":{"login":"photodude","id":10253980,"avatar_url":"https://avatars.githubusercontent.com/u/10253980?v=3","gravatar_id":"","url":"https://api.github.com/users/photodude","html_url":"https://github.com/photodude","followers_url":"https://api.github.com/users/photodude/followers","following_url":"https://api.github.com/users/photodude/following{/other_user}","gists_url":"https://api.github.com/users/photodude/gists{/gist_id}","starred_url":"https://api.github.com/users/photodude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/photodude/subscriptions","organizations_url":"https://api.github.com/users/photodude/orgs","repos_url":"https://api.github.com/users/photodude/repos","events_url":"https://api.github.com/users/photodude/events{/privacy}","received_events_url":"https://api.github.com/users/photodude/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T16:23:19Z","updated_at":"2015-07-27T16:23:19Z","body":"I believe this is where we are at currently on the the path to a beta state\r\n- [x] Multi-line wrapping around operators (added some `<property name=\"ignoreNewlines\" value=\"true\" />` statements to the ruleset to resolve\r\n- [x] Multi-line comments (use Squiz.Commenting.BlockComment to resolve)\r\n- [ ] Expecting a blank line before the first class member var\r\n- [ ] Expecting a new line at the start of multi-line control statements `if (\\n ...\\n ...\\n ...)` should be `if (...\\n ...\\n ...\\n ...)` (Issues with PSR2.ControlStructures.ElseIfDeclaration)\r\n- [ ] Commented out code is not recognized properly (Issues with Squiz.PHP.CommentedOutCode)\r\n"}}