{"action":"created","comment":{"url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/comments/24507650","id":24507650,"diff_hunk":"@@ -16,35 +16,42 @@\n  * <p>\n  * A holder extended to support having a selectable mode with a different\n  * background and state list animator.</p>\n- *\n+ * <p/>\n  * <p>When {@link #setSelectable(boolean)} is set to true, itemView's\n  * background is set to the value of selectionModeBackgroundDrawable,\n  * and its StateListAnimator is set to selectionModeStateListAnimator.\n  * When it is set to false, the defaultModeBackgroundDrawable and\n  * defaultModeStateListAnimator are used.</p>\n- *\n+ * <p/>\n  * <p>defaultModeBackgroundDrawable and defaultModeStateListAnimator\n  * default to the values on itemView at the time the holder was constructed.</p>\n- *\n+ * <p/>\n  * <p>selectionModeBackgroundDrawable defaults to a StateListDrawable that displays\n  * your colorAccent theme color when state_activated=true, and nothing otherwise.\n  * selectionModeStateListAnimator defaults to a raise animation that animates selection\n  * items to a 12dp translationZ.</p>\n- *\n+ * <p/>\n  * <p>(Thanks to <a href=\"https://github.com/kurtisnelson/\">Kurt Nelson</a> for examples and discussion on approaches here.)</p>\n  */\n-public class SwappingHolder extends MultiSelectorBindingHolder implements SelectableHolder {\n+public abstract class SwappingHolder extends MultiSelectorBindingHolder implements SelectableHolder {","path":"recyclerview-multiselect/src/main/java/com/bignerdranch/android/multiselector/SwappingHolder.java","position":26,"original_position":26,"commit_id":"cd199b58d171b514117a63c311356c16113c161c","original_commit_id":"cd199b58d171b514117a63c311356c16113c161c","user":{"login":"jingibus","id":1508949,"avatar_url":"https://avatars.githubusercontent.com/u/1508949?v=3","gravatar_id":"","url":"https://api.github.com/users/jingibus","html_url":"https://github.com/jingibus","followers_url":"https://api.github.com/users/jingibus/followers","following_url":"https://api.github.com/users/jingibus/following{/other_user}","gists_url":"https://api.github.com/users/jingibus/gists{/gist_id}","starred_url":"https://api.github.com/users/jingibus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingibus/subscriptions","organizations_url":"https://api.github.com/users/jingibus/orgs","repos_url":"https://api.github.com/users/jingibus/repos","events_url":"https://api.github.com/users/jingibus/events{/privacy}","received_events_url":"https://api.github.com/users/jingibus/received_events","type":"User","site_admin":false},"body":"This class should not be abstract.\r\n\r\nApart from that change, I am fine with merging this as-is. \r\n\r\nI'll make a similar remark here as I made above about SelectableHolder: there are a lot of changes to this class that I just read through, but after taking the time to understand them it looks like no code actually changed. Kind of confusing for me when this PR is supposed to be about saving out selection state.","created_at":"2015-02-11T16:18:15Z","updated_at":"2015-02-11T16:18:15Z","html_url":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2#discussion_r24507650","pull_request_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/comments/24507650"},"html":{"href":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2#discussion_r24507650"},"pull_request":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2","id":28270731,"html_url":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2","diff_url":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2.diff","patch_url":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2.patch","issue_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/2","number":2,"state":"open","locked":false,"title":"Rotation State Management","user":{"login":"geniusgeek","id":8592918,"avatar_url":"https://avatars.githubusercontent.com/u/8592918?v=3","gravatar_id":"","url":"https://api.github.com/users/geniusgeek","html_url":"https://github.com/geniusgeek","followers_url":"https://api.github.com/users/geniusgeek/followers","following_url":"https://api.github.com/users/geniusgeek/following{/other_user}","gists_url":"https://api.github.com/users/geniusgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/geniusgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geniusgeek/subscriptions","organizations_url":"https://api.github.com/users/geniusgeek/orgs","repos_url":"https://api.github.com/users/geniusgeek/repos","events_url":"https://api.github.com/users/geniusgeek/events{/privacy}","received_events_url":"https://api.github.com/users/geniusgeek/received_events","type":"User","site_admin":false},"body":"The project have been modified to Handle Rotation Issues For recyclerview-multiselect","created_at":"2015-01-29T11:16:11Z","updated_at":"2015-02-11T16:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1450e1e499ba48a6e71c828649a22e6c339ad5a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2/commits","review_comments_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2/comments","review_comment_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/2/comments","statuses_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/statuses/cd199b58d171b514117a63c311356c16113c161c","head":{"label":"geniusgeek:master","ref":"master","sha":"cd199b58d171b514117a63c311356c16113c161c","user":{"login":"geniusgeek","id":8592918,"avatar_url":"https://avatars.githubusercontent.com/u/8592918?v=3","gravatar_id":"","url":"https://api.github.com/users/geniusgeek","html_url":"https://github.com/geniusgeek","followers_url":"https://api.github.com/users/geniusgeek/followers","following_url":"https://api.github.com/users/geniusgeek/following{/other_user}","gists_url":"https://api.github.com/users/geniusgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/geniusgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geniusgeek/subscriptions","organizations_url":"https://api.github.com/users/geniusgeek/orgs","repos_url":"https://api.github.com/users/geniusgeek/repos","events_url":"https://api.github.com/users/geniusgeek/events{/privacy}","received_events_url":"https://api.github.com/users/geniusgeek/received_events","type":"User","site_admin":false},"repo":{"id":28868688,"name":"recyclerview-multiselect","full_name":"geniusgeek/recyclerview-multiselect","owner":{"login":"geniusgeek","id":8592918,"avatar_url":"https://avatars.githubusercontent.com/u/8592918?v=3","gravatar_id":"","url":"https://api.github.com/users/geniusgeek","html_url":"https://github.com/geniusgeek","followers_url":"https://api.github.com/users/geniusgeek/followers","following_url":"https://api.github.com/users/geniusgeek/following{/other_user}","gists_url":"https://api.github.com/users/geniusgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/geniusgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geniusgeek/subscriptions","organizations_url":"https://api.github.com/users/geniusgeek/orgs","repos_url":"https://api.github.com/users/geniusgeek/repos","events_url":"https://api.github.com/users/geniusgeek/events{/privacy}","received_events_url":"https://api.github.com/users/geniusgeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geniusgeek/recyclerview-multiselect","description":"","fork":true,"url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect","forks_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/forks","keys_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/teams","hooks_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/hooks","issue_events_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/issues/events{/number}","events_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/events","assignees_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/assignees{/user}","branches_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/branches{/branch}","tags_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/tags","blobs_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/statuses/{sha}","languages_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/languages","stargazers_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/stargazers","contributors_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/contributors","subscribers_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/subscribers","subscription_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/subscription","commits_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/issues/comments/{number}","contents_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/contents/{+path}","compare_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/merges","archive_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/downloads","issues_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/issues{/number}","pulls_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/pulls{/number}","milestones_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/milestones{/number}","notifications_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/labels{/name}","releases_url":"https://api.github.com/repos/geniusgeek/recyclerview-multiselect/releases{/id}","created_at":"2015-01-06T15:12:15Z","updated_at":"2015-02-10T01:47:06Z","pushed_at":"2015-02-10T01:47:06Z","git_url":"git://github.com/geniusgeek/recyclerview-multiselect.git","ssh_url":"git@github.com:geniusgeek/recyclerview-multiselect.git","clone_url":"https://github.com/geniusgeek/recyclerview-multiselect.git","svn_url":"https://github.com/geniusgeek/recyclerview-multiselect","homepage":null,"size":4610,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bignerdranch:master","ref":"master","sha":"a6f55369af74522fb8842ee9460e6d5117cff5d2","user":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"repo":{"id":27885985,"name":"recyclerview-multiselect","full_name":"bignerdranch/recyclerview-multiselect","owner":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bignerdranch/recyclerview-multiselect","description":"","fork":true,"url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect","forks_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/forks","keys_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/teams","hooks_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/hooks","issue_events_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/events{/number}","events_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/events","assignees_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/assignees{/user}","branches_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/branches{/branch}","tags_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/tags","blobs_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/git/refs{/sha}","trees_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/statuses/{sha}","languages_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/languages","stargazers_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/stargazers","contributors_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/contributors","subscribers_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/subscribers","subscription_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/subscription","commits_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/commits{/sha}","git_commits_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/git/commits{/sha}","comments_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/comments{/number}","issue_comment_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/comments/{number}","contents_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/contents/{+path}","compare_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/merges","archive_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/downloads","issues_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues{/number}","pulls_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls{/number}","milestones_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/milestones{/number}","notifications_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/labels{/name}","releases_url":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/releases{/id}","created_at":"2014-12-11T18:41:31Z","updated_at":"2015-02-10T07:11:18Z","pushed_at":"2015-01-29T16:07:24Z","git_url":"git://github.com/bignerdranch/recyclerview-multiselect.git","ssh_url":"git@github.com:bignerdranch/recyclerview-multiselect.git","clone_url":"https://github.com/bignerdranch/recyclerview-multiselect.git","svn_url":"https://github.com/bignerdranch/recyclerview-multiselect","homepage":null,"size":4815,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2"},"html":{"href":"https://github.com/bignerdranch/recyclerview-multiselect/pull/2"},"issue":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/2"},"comments":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/bignerdranch/recyclerview-multiselect/statuses/cd199b58d171b514117a63c311356c16113c161c"}}}}