{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/comments/29832035","id":29832035,"diff_hunk":"@@ -61,6 +61,7 @@ public function updateContentTypeAction(Request $request, $contentTypeId, $langu\n         foreach ($contentTypeDraft->fieldDefinitions as $fieldDef) {\n             $formData->addFieldDefinitionData(new FieldDefinitionData([\n                 'fieldDefinition' => $fieldDef,\n+                'contentTypeData' => $formData,","path":"bundle/Controller/TestController.php","position":4,"original_position":4,"commit_id":"0e807b6a221d14b607f68f830ecb8bfa1207b32e","original_commit_id":"0e807b6a221d14b607f68f830ecb8bfa1207b32e","user":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars.githubusercontent.com/u/235928?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"body":"why `$formData` data and not `$contentTypeData` ?","created_at":"2015-05-07T08:11:16Z","updated_at":"2015-05-07T08:11:16Z","html_url":"https://github.com/ezsystems/repository-forms/pull/3#discussion_r29832035","pull_request_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/comments/29832035"},"html":{"href":"https://github.com/ezsystems/repository-forms/pull/3#discussion_r29832035"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3","id":34855035,"html_url":"https://github.com/ezsystems/repository-forms/pull/3","diff_url":"https://github.com/ezsystems/repository-forms/pull/3.diff","patch_url":"https://github.com/ezsystems/repository-forms/pull/3.patch","issue_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/3","number":3,"state":"open","locked":false,"title":"[WIP] Fix EZP-24309: Implement validation for ContentType forms","user":{"login":"lolautruche","id":313528,"avatar_url":"https://avatars.githubusercontent.com/u/313528?v=3","gravatar_id":"","url":"https://api.github.com/users/lolautruche","html_url":"https://github.com/lolautruche","followers_url":"https://api.github.com/users/lolautruche/followers","following_url":"https://api.github.com/users/lolautruche/following{/other_user}","gists_url":"https://api.github.com/users/lolautruche/gists{/gist_id}","starred_url":"https://api.github.com/users/lolautruche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolautruche/subscriptions","organizations_url":"https://api.github.com/users/lolautruche/orgs","repos_url":"https://api.github.com/users/lolautruche/repos","events_url":"https://api.github.com/users/lolautruche/events{/privacy}","received_events_url":"https://api.github.com/users/lolautruche/received_events","type":"User","site_admin":false},"body":"> https://jira.ez.no/browse/EZP-24309\r\n\r\nAdds validation for ContentTypeData and FieldDefinitionData.\r\n\r\n* [x] Add validation for ContentTypeData fields\r\n* [x] Add validation for common FieldDefinitionData fields\r\n* [x] Translate custom validation messages\r\n* [x] Ensure inner FieldDefinitionData fields are validated in cascade when validating ContentTypeData\r\n* [ ] Add validation for FieldDefinitionData validator configuration\r\n* [ ] Add validation for FieldDefinitionData field settings configuration\r\n* [ ] Add validation for FieldDefinitionData default value when needed\r\n","created_at":"2015-05-06T20:11:43Z","updated_at":"2015-05-07T08:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4644ed125a6614485901f1214e3b3e895de39f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/3/comments","statuses_url":"https://api.github.com/repos/ezsystems/repository-forms/statuses/0e807b6a221d14b607f68f830ecb8bfa1207b32e","head":{"label":"ezsystems:validation","ref":"validation","sha":"0e807b6a221d14b607f68f830ecb8bfa1207b32e","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":34457958,"name":"repository-forms","full_name":"ezsystems/repository-forms","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/repository-forms","description":"","fork":false,"url":"https://api.github.com/repos/ezsystems/repository-forms","forks_url":"https://api.github.com/repos/ezsystems/repository-forms/forks","keys_url":"https://api.github.com/repos/ezsystems/repository-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/repository-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/repository-forms/teams","hooks_url":"https://api.github.com/repos/ezsystems/repository-forms/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/repository-forms/events","assignees_url":"https://api.github.com/repos/ezsystems/repository-forms/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/repository-forms/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/repository-forms/tags","blobs_url":"https://api.github.com/repos/ezsystems/repository-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/repository-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/repository-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/repository-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/repository-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/repository-forms/languages","stargazers_url":"https://api.github.com/repos/ezsystems/repository-forms/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/repository-forms/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/repository-forms/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/repository-forms/subscription","commits_url":"https://api.github.com/repos/ezsystems/repository-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/repository-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/repository-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/repository-forms/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/repository-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/repository-forms/merges","archive_url":"https://api.github.com/repos/ezsystems/repository-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/repository-forms/downloads","issues_url":"https://api.github.com/repos/ezsystems/repository-forms/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/repository-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/repository-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/repository-forms/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/repository-forms/releases{/id}","created_at":"2015-04-23T13:30:07Z","updated_at":"2015-05-07T07:32:17Z","pushed_at":"2015-05-07T07:56:05Z","git_url":"git://github.com/ezsystems/repository-forms.git","ssh_url":"git@github.com:ezsystems/repository-forms.git","clone_url":"https://github.com/ezsystems/repository-forms.git","svn_url":"https://github.com/ezsystems/repository-forms","homepage":null,"size":212,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"57a6f7f6ccb2cd1b25d54d22a776f007a02a8759","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":34457958,"name":"repository-forms","full_name":"ezsystems/repository-forms","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/repository-forms","description":"","fork":false,"url":"https://api.github.com/repos/ezsystems/repository-forms","forks_url":"https://api.github.com/repos/ezsystems/repository-forms/forks","keys_url":"https://api.github.com/repos/ezsystems/repository-forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/repository-forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/repository-forms/teams","hooks_url":"https://api.github.com/repos/ezsystems/repository-forms/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/repository-forms/events","assignees_url":"https://api.github.com/repos/ezsystems/repository-forms/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/repository-forms/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/repository-forms/tags","blobs_url":"https://api.github.com/repos/ezsystems/repository-forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/repository-forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/repository-forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/repository-forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/repository-forms/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/repository-forms/languages","stargazers_url":"https://api.github.com/repos/ezsystems/repository-forms/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/repository-forms/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/repository-forms/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/repository-forms/subscription","commits_url":"https://api.github.com/repos/ezsystems/repository-forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/repository-forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/repository-forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/repository-forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/repository-forms/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/repository-forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/repository-forms/merges","archive_url":"https://api.github.com/repos/ezsystems/repository-forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/repository-forms/downloads","issues_url":"https://api.github.com/repos/ezsystems/repository-forms/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/repository-forms/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/repository-forms/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/repository-forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/repository-forms/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/repository-forms/releases{/id}","created_at":"2015-04-23T13:30:07Z","updated_at":"2015-05-07T07:32:17Z","pushed_at":"2015-05-07T07:56:05Z","git_url":"git://github.com/ezsystems/repository-forms.git","ssh_url":"git@github.com:ezsystems/repository-forms.git","clone_url":"https://github.com/ezsystems/repository-forms.git","svn_url":"https://github.com/ezsystems/repository-forms","homepage":null,"size":212,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3"},"html":{"href":"https://github.com/ezsystems/repository-forms/pull/3"},"issue":{"href":"https://api.github.com/repos/ezsystems/repository-forms/issues/3"},"comments":{"href":"https://api.github.com/repos/ezsystems/repository-forms/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/repository-forms/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/repository-forms/statuses/0e807b6a221d14b607f68f830ecb8bfa1207b32e"}}}}