{"action":"closed","number":4217,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217","id":35996415,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4217","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4217.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4217.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4217","number":4217,"state":"closed","locked":false,"title":"BUG Fix DirectorTest failing when run with sake","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"The tests run fine with phpunit cli, but when run with sake dev/tests/all the `$_SERVER['REQUEST_URI']` ends up with the dev/tests/all in the url, which actually breaks some assumptions made in testAlternativeBaseURL about how absoluteURL works.\r\n\r\nI've also added yet another note on absoluteURL behaving weird in 3.1, where url-segments such as parent/child are treated as absolute urls.","created_at":"2015-05-22T02:50:50Z","updated_at":"2015-06-01T05:34:26Z","closed_at":"2015-06-01T05:34:26Z","merged_at":"2015-06-01T05:34:26Z","merge_commit_sha":"d65b17a49d7b9f89c1fdd8c31f3af23a6baea55b","assignee":null,"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/18","html_url":"https://github.com/silverstripe/silverstripe-framework/milestones/3.1.14","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/18/labels","id":1109519,"number":18,"title":"3.1.14","description":"","creator":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2015-05-14T01:55:28Z","updated_at":"2015-06-01T05:34:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4217/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/e0710ae4e4a03c191b841cc45a6c103a0e21ec7f","head":{"label":"tractorcow:pulls/3.1/fix-directortest","ref":"pulls/3.1/fix-directortest","sha":"e0710ae4e4a03c191b841cc45a6c103a0e21ec7f","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"repo":{"id":5337017,"name":"sapphire","full_name":"tractorcow/sapphire","owner":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tractorcow/sapphire","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/tractorcow/sapphire","forks_url":"https://api.github.com/repos/tractorcow/sapphire/forks","keys_url":"https://api.github.com/repos/tractorcow/sapphire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tractorcow/sapphire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tractorcow/sapphire/teams","hooks_url":"https://api.github.com/repos/tractorcow/sapphire/hooks","issue_events_url":"https://api.github.com/repos/tractorcow/sapphire/issues/events{/number}","events_url":"https://api.github.com/repos/tractorcow/sapphire/events","assignees_url":"https://api.github.com/repos/tractorcow/sapphire/assignees{/user}","branches_url":"https://api.github.com/repos/tractorcow/sapphire/branches{/branch}","tags_url":"https://api.github.com/repos/tractorcow/sapphire/tags","blobs_url":"https://api.github.com/repos/tractorcow/sapphire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tractorcow/sapphire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tractorcow/sapphire/git/refs{/sha}","trees_url":"https://api.github.com/repos/tractorcow/sapphire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tractorcow/sapphire/statuses/{sha}","languages_url":"https://api.github.com/repos/tractorcow/sapphire/languages","stargazers_url":"https://api.github.com/repos/tractorcow/sapphire/stargazers","contributors_url":"https://api.github.com/repos/tractorcow/sapphire/contributors","subscribers_url":"https://api.github.com/repos/tractorcow/sapphire/subscribers","subscription_url":"https://api.github.com/repos/tractorcow/sapphire/subscription","commits_url":"https://api.github.com/repos/tractorcow/sapphire/commits{/sha}","git_commits_url":"https://api.github.com/repos/tractorcow/sapphire/git/commits{/sha}","comments_url":"https://api.github.com/repos/tractorcow/sapphire/comments{/number}","issue_comment_url":"https://api.github.com/repos/tractorcow/sapphire/issues/comments{/number}","contents_url":"https://api.github.com/repos/tractorcow/sapphire/contents/{+path}","compare_url":"https://api.github.com/repos/tractorcow/sapphire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tractorcow/sapphire/merges","archive_url":"https://api.github.com/repos/tractorcow/sapphire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tractorcow/sapphire/downloads","issues_url":"https://api.github.com/repos/tractorcow/sapphire/issues{/number}","pulls_url":"https://api.github.com/repos/tractorcow/sapphire/pulls{/number}","milestones_url":"https://api.github.com/repos/tractorcow/sapphire/milestones{/number}","notifications_url":"https://api.github.com/repos/tractorcow/sapphire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tractorcow/sapphire/labels{/name}","releases_url":"https://api.github.com/repos/tractorcow/sapphire/releases{/id}","created_at":"2012-08-08T04:07:21Z","updated_at":"2015-04-16T21:02:36Z","pushed_at":"2015-05-28T23:49:52Z","git_url":"git://github.com/tractorcow/sapphire.git","ssh_url":"git@github.com:tractorcow/sapphire.git","clone_url":"https://github.com/tractorcow/sapphire.git","svn_url":"https://github.com/tractorcow/sapphire","homepage":"http://silverstripe.org/","size":55099,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"3.1"}},"base":{"label":"silverstripe:3.1","ref":"3.1","sha":"85cff0ad8f51ed26d5c7b6162e244d5232e1fff2","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-05-31T22:00:07Z","pushed_at":"2015-06-01T05:34:28Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":106258,"stargazers_count":448,"watchers_count":448,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":495,"mirror_url":null,"open_issues_count":628,"forks":495,"open_issues":628,"watchers":448,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4217"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4217"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4217/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4217/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/e0710ae4e4a03c191b841cc45a6c103a0e21ec7f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chillu","id":111025,"avatar_url":"https://avatars.githubusercontent.com/u/111025?v=3","gravatar_id":"","url":"https://api.github.com/users/chillu","html_url":"https://github.com/chillu","followers_url":"https://api.github.com/users/chillu/followers","following_url":"https://api.github.com/users/chillu/following{/other_user}","gists_url":"https://api.github.com/users/chillu/gists{/gist_id}","starred_url":"https://api.github.com/users/chillu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chillu/subscriptions","organizations_url":"https://api.github.com/users/chillu/orgs","repos_url":"https://api.github.com/users/chillu/repos","events_url":"https://api.github.com/users/chillu/events{/privacy}","received_events_url":"https://api.github.com/users/chillu/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":31,"deletions":8,"changed_files":1}}