{"action":"created","issue":{"url":"https://api.github.com/repos/chenglou/react-motion/issues/238","labels_url":"https://api.github.com/repos/chenglou/react-motion/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/chenglou/react-motion/issues/238/comments","events_url":"https://api.github.com/repos/chenglou/react-motion/issues/238/events","html_url":"https://github.com/chenglou/react-motion/pull/238","id":116075586,"number":238,"title":"Switch to compare x with rest on errorMargin check","user":{"login":"istarkov","id":5077042,"avatar_url":"https://avatars.githubusercontent.com/u/5077042?v=3","gravatar_id":"","url":"https://api.github.com/users/istarkov","html_url":"https://github.com/istarkov","followers_url":"https://api.github.com/users/istarkov/followers","following_url":"https://api.github.com/users/istarkov/following{/other_user}","gists_url":"https://api.github.com/users/istarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/istarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istarkov/subscriptions","organizations_url":"https://api.github.com/users/istarkov/orgs","repos_url":"https://api.github.com/users/istarkov/repos","events_url":"https://api.github.com/users/istarkov/events{/privacy}","received_events_url":"https://api.github.com/users/istarkov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-10T10:10:37Z","updated_at":"2015-11-18T23:40:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chenglou/react-motion/pulls/238","html_url":"https://github.com/chenglou/react-motion/pull/238","diff_url":"https://github.com/chenglou/react-motion/pull/238.diff","patch_url":"https://github.com/chenglou/react-motion/pull/238.patch"},"body":"Looks like it's better to check x with rest value, not previous.\r\nFor example if errorMargin becomes a user parameter, there will situations with small velocity and small dx values but x is far from the rest."},"comment":{"url":"https://api.github.com/repos/chenglou/react-motion/issues/comments/157899752","html_url":"https://github.com/chenglou/react-motion/pull/238#issuecomment-157899752","issue_url":"https://api.github.com/repos/chenglou/react-motion/issues/238","id":157899752,"user":{"login":"chenglou","id":1909539,"avatar_url":"https://avatars.githubusercontent.com/u/1909539?v=3","gravatar_id":"","url":"https://api.github.com/users/chenglou","html_url":"https://github.com/chenglou","followers_url":"https://api.github.com/users/chenglou/followers","following_url":"https://api.github.com/users/chenglou/following{/other_user}","gists_url":"https://api.github.com/users/chenglou/gists{/gist_id}","starred_url":"https://api.github.com/users/chenglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenglou/subscriptions","organizations_url":"https://api.github.com/users/chenglou/orgs","repos_url":"https://api.github.com/users/chenglou/repos","events_url":"https://api.github.com/users/chenglou/events{/privacy}","received_events_url":"https://api.github.com/users/chenglou/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T23:40:09Z","updated_at":"2015-11-18T23:40:09Z","body":"You know what, this is probably right. If TransitionMotion screws up after this then we should fix that instead.\r\n\r\nSorry for the delay! Thanks =)."}}