{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35","id":29273394,"html_url":"https://github.com/datacentred/datacentred-ldap/pull/35","diff_url":"https://github.com/datacentred/datacentred-ldap/pull/35.diff","patch_url":"https://github.com/datacentred/datacentred-ldap/pull/35.patch","issue_url":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/35","number":35,"state":"closed","locked":false,"title":"Functional enhancements and cleanups","user":{"login":"michaelweiser","id":1473703,"avatar_url":"https://avatars.githubusercontent.com/u/1473703?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelweiser","html_url":"https://github.com/michaelweiser","followers_url":"https://api.github.com/users/michaelweiser/followers","following_url":"https://api.github.com/users/michaelweiser/following{/other_user}","gists_url":"https://api.github.com/users/michaelweiser/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelweiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelweiser/subscriptions","organizations_url":"https://api.github.com/users/michaelweiser/orgs","repos_url":"https://api.github.com/users/michaelweiser/repos","events_url":"https://api.github.com/users/michaelweiser/events{/privacy}","received_events_url":"https://api.github.com/users/michaelweiser/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI've added a few enhancements to the module and did some what seems to me like cleanups. Would you be interested in including them?\r\n\r\nI've dumped them all in this rather large commit. Please let me know if you'd prefer a series of smaller patches.\r\n\r\nThanks!\r\nMichael\r\n\r\nThe changes:\r\n\r\nMake timelimit and sizelimit on client configurable. Remove default\r\nsizelimit of 12 entries. Do not require SSL cert and key on the client.\r\n\r\nSupport syncrepl replication on the server. Provide flexible way to\r\nconfigure ACLs. Account for different needs on provider (master) and\r\nconsumer (slave) in access rights.\r\n\r\nSupport import of additional schema files from puppet master and provide\r\none for RFC2307bis and groupOfEntries proposal.\r\n\r\nAllow configuration of SSL and Kerberos authentication at the server.\r\n\r\nAllow use of backends other than bdb. Only include dbconfig if back_bdb\r\nis in use - mdb does not need it. Only import DB_CONFIG if bdb or hdb\r\nare used. Fix setting of server user in Debian defaults file. Add option\r\nto make sure slapd.d directory is purged. Secure permissions of\r\nslapd.conf.","created_at":"2015-02-13T15:36:45Z","updated_at":"2015-02-13T19:42:25Z","closed_at":"2015-02-13T19:42:25Z","merged_at":null,"merge_commit_sha":"d77a8684aef0d157b88204c2208169aac77fac92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35/commits","review_comments_url":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35/comments","review_comment_url":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/comments/{number}","comments_url":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/35/comments","statuses_url":"https://api.github.com/repos/datacentred/datacentred-ldap/statuses/4a3337ee07a46e385424eb6ff5b347df051a1209","head":{"label":"michaelweiser:master","ref":"master","sha":"4a3337ee07a46e385424eb6ff5b347df051a1209","user":{"login":"michaelweiser","id":1473703,"avatar_url":"https://avatars.githubusercontent.com/u/1473703?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelweiser","html_url":"https://github.com/michaelweiser","followers_url":"https://api.github.com/users/michaelweiser/followers","following_url":"https://api.github.com/users/michaelweiser/following{/other_user}","gists_url":"https://api.github.com/users/michaelweiser/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelweiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelweiser/subscriptions","organizations_url":"https://api.github.com/users/michaelweiser/orgs","repos_url":"https://api.github.com/users/michaelweiser/repos","events_url":"https://api.github.com/users/michaelweiser/events{/privacy}","received_events_url":"https://api.github.com/users/michaelweiser/received_events","type":"User","site_admin":false},"repo":{"id":30760688,"name":"datacentred-ldap","full_name":"michaelweiser/datacentred-ldap","owner":{"login":"michaelweiser","id":1473703,"avatar_url":"https://avatars.githubusercontent.com/u/1473703?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelweiser","html_url":"https://github.com/michaelweiser","followers_url":"https://api.github.com/users/michaelweiser/followers","following_url":"https://api.github.com/users/michaelweiser/following{/other_user}","gists_url":"https://api.github.com/users/michaelweiser/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelweiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelweiser/subscriptions","organizations_url":"https://api.github.com/users/michaelweiser/orgs","repos_url":"https://api.github.com/users/michaelweiser/repos","events_url":"https://api.github.com/users/michaelweiser/events{/privacy}","received_events_url":"https://api.github.com/users/michaelweiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelweiser/datacentred-ldap","description":"OpenLDAP module for Puppet","fork":true,"url":"https://api.github.com/repos/michaelweiser/datacentred-ldap","forks_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/forks","keys_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/teams","hooks_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/hooks","issue_events_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/events","assignees_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/tags","blobs_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/languages","stargazers_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/stargazers","contributors_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/contributors","subscribers_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/subscribers","subscription_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/subscription","commits_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/issues/comments/{number}","contents_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/merges","archive_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/downloads","issues_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/labels{/name}","releases_url":"https://api.github.com/repos/michaelweiser/datacentred-ldap/releases{/id}","created_at":"2015-02-13T14:53:34Z","updated_at":"2015-02-13T15:12:16Z","pushed_at":"2015-02-13T15:12:16Z","git_url":"git://github.com/michaelweiser/datacentred-ldap.git","ssh_url":"git@github.com:michaelweiser/datacentred-ldap.git","clone_url":"https://github.com/michaelweiser/datacentred-ldap.git","svn_url":"https://github.com/michaelweiser/datacentred-ldap","homepage":"https://forge.puppetlabs.com/datacentred/ldap","size":170,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datacentred:master","ref":"master","sha":"ab424530ba6c9b1d7323edc187ed7a49f1b5e43b","user":{"login":"datacentred","id":4599530,"avatar_url":"https://avatars.githubusercontent.com/u/4599530?v=3","gravatar_id":"","url":"https://api.github.com/users/datacentred","html_url":"https://github.com/datacentred","followers_url":"https://api.github.com/users/datacentred/followers","following_url":"https://api.github.com/users/datacentred/following{/other_user}","gists_url":"https://api.github.com/users/datacentred/gists{/gist_id}","starred_url":"https://api.github.com/users/datacentred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacentred/subscriptions","organizations_url":"https://api.github.com/users/datacentred/orgs","repos_url":"https://api.github.com/users/datacentred/repos","events_url":"https://api.github.com/users/datacentred/events{/privacy}","received_events_url":"https://api.github.com/users/datacentred/received_events","type":"Organization","site_admin":false},"repo":{"id":18666602,"name":"datacentred-ldap","full_name":"datacentred/datacentred-ldap","owner":{"login":"datacentred","id":4599530,"avatar_url":"https://avatars.githubusercontent.com/u/4599530?v=3","gravatar_id":"","url":"https://api.github.com/users/datacentred","html_url":"https://github.com/datacentred","followers_url":"https://api.github.com/users/datacentred/followers","following_url":"https://api.github.com/users/datacentred/following{/other_user}","gists_url":"https://api.github.com/users/datacentred/gists{/gist_id}","starred_url":"https://api.github.com/users/datacentred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacentred/subscriptions","organizations_url":"https://api.github.com/users/datacentred/orgs","repos_url":"https://api.github.com/users/datacentred/repos","events_url":"https://api.github.com/users/datacentred/events{/privacy}","received_events_url":"https://api.github.com/users/datacentred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacentred/datacentred-ldap","description":"OpenLDAP module for Puppet","fork":false,"url":"https://api.github.com/repos/datacentred/datacentred-ldap","forks_url":"https://api.github.com/repos/datacentred/datacentred-ldap/forks","keys_url":"https://api.github.com/repos/datacentred/datacentred-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacentred/datacentred-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacentred/datacentred-ldap/teams","hooks_url":"https://api.github.com/repos/datacentred/datacentred-ldap/hooks","issue_events_url":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/datacentred/datacentred-ldap/events","assignees_url":"https://api.github.com/repos/datacentred/datacentred-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/datacentred/datacentred-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/datacentred/datacentred-ldap/tags","blobs_url":"https://api.github.com/repos/datacentred/datacentred-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacentred/datacentred-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacentred/datacentred-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacentred/datacentred-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacentred/datacentred-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/datacentred/datacentred-ldap/languages","stargazers_url":"https://api.github.com/repos/datacentred/datacentred-ldap/stargazers","contributors_url":"https://api.github.com/repos/datacentred/datacentred-ldap/contributors","subscribers_url":"https://api.github.com/repos/datacentred/datacentred-ldap/subscribers","subscription_url":"https://api.github.com/repos/datacentred/datacentred-ldap/subscription","commits_url":"https://api.github.com/repos/datacentred/datacentred-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacentred/datacentred-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacentred/datacentred-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/comments/{number}","contents_url":"https://api.github.com/repos/datacentred/datacentred-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/datacentred/datacentred-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacentred/datacentred-ldap/merges","archive_url":"https://api.github.com/repos/datacentred/datacentred-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacentred/datacentred-ldap/downloads","issues_url":"https://api.github.com/repos/datacentred/datacentred-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/datacentred/datacentred-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/datacentred/datacentred-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacentred/datacentred-ldap/labels{/name}","releases_url":"https://api.github.com/repos/datacentred/datacentred-ldap/releases{/id}","created_at":"2014-04-11T07:53:01Z","updated_at":"2015-02-05T19:29:18Z","pushed_at":"2014-10-15T12:19:38Z","git_url":"git://github.com/datacentred/datacentred-ldap.git","ssh_url":"git@github.com:datacentred/datacentred-ldap.git","clone_url":"https://github.com/datacentred/datacentred-ldap.git","svn_url":"https://github.com/datacentred/datacentred-ldap","homepage":"https://forge.puppetlabs.com/datacentred/ldap","size":1329,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35"},"html":{"href":"https://github.com/datacentred/datacentred-ldap/pull/35"},"issue":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/35"},"comments":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/datacentred/datacentred-ldap/statuses/4a3337ee07a46e385424eb6ff5b347df051a1209"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":717,"deletions":32,"changed_files":10}}