{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14946","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14946/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14946/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14946/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14946","id":109397865,"number":14946,"title":"Adds new tests to improve coverage and removes unused params passed to proxy server.","user":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-01T22:33:11Z","updated_at":"2015-10-02T00:01:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14946","html_url":"https://github.com/kubernetes/kubernetes/pull/14946","diff_url":"https://github.com/kubernetes/kubernetes/pull/14946.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14946.patch"},"body":"This patch:\r\n1. Removes unused params passed to proxy server.\r\n2. Adds tests cases and increases code coverage from around 15% to\r\naround 75%.\r\n\r\nWithout Patch:\r\n\r\n```\r\nRunning tests for APIVersion: v1,experimental/v1alpha1 with etcdPrefix: registry\r\n+++ [1001 18:26:14] Saving coverage output in '/tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-182614'\r\nok  \tk8s.io/kubernetes/cmd/kube-proxy/app\t0.006s\tcoverage: 15.0% of statements\r\n+++ [1001 18:26:21] Combined coverage report: /tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-182614/combined-coverage.html\r\nRunning tests for APIVersion: v1,experimental/v1alpha1 with etcdPrefix: kubernetes.io/registry\r\n+++ [1001 18:26:21] Saving coverage output in '/tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-182621'\r\nok  \tk8s.io/kubernetes/cmd/kube-proxy/app\t0.006s\tcoverage: 15.0% of statements\r\n+++ [1001 18:26:27] Combined coverage report: /tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-182621/combined-coverage.html\r\n```\r\nWith Patch:\r\n\r\n```\r\nRunning tests for APIVersion: v1,experimental/v1alpha1 with etcdPrefix: registry\r\n+++ [1001 12:34:19] Saving coverage output in '/tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-123419'\r\nok  \tk8s.io/kubernetes/cmd/kube-proxy/app\t0.161s\tcoverage: 75.8% of statements\r\n+++ [1001 12:34:26] Combined coverage report: /tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-123419/combined-coverage.html\r\nRunning tests for APIVersion: v1,experimental/v1alpha1 with etcdPrefix: kubernetes.io/registry\r\n+++ [1001 12:34:26] Saving coverage output in '/tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-123426'\r\nok  \tk8s.io/kubernetes/cmd/kube-proxy/app\t0.181s\tcoverage: 75.8% of statements\r\n+++ [1001 12:34:32] Combined coverage report: /tmp/k8s_coverage/v1,experimental/v1alpha1/20151001-123426/combined-coverage.html\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/144881007","html_url":"https://github.com/kubernetes/kubernetes/pull/14946#issuecomment-144881007","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14946","id":144881007,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T00:01:58Z","updated_at":"2015-10-02T00:01:58Z","body":"Labelling this PR as size/L"}}