{"action":"created","issue":{"url":"https://api.github.com/repos/brigade/scss-lint/issues/569","labels_url":"https://api.github.com/repos/brigade/scss-lint/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/brigade/scss-lint/issues/569/comments","events_url":"https://api.github.com/repos/brigade/scss-lint/issues/569/events","html_url":"https://github.com/brigade/scss-lint/pull/569","id":103721784,"number":569,"title":"Improve ColorVariable to flag uses of rgb/rgba/hsl/hsla","user":{"login":"cih","id":762443,"avatar_url":"https://avatars.githubusercontent.com/u/762443?v=3","gravatar_id":"","url":"https://api.github.com/users/cih","html_url":"https://github.com/cih","followers_url":"https://api.github.com/users/cih/followers","following_url":"https://api.github.com/users/cih/following{/other_user}","gists_url":"https://api.github.com/users/cih/gists{/gist_id}","starred_url":"https://api.github.com/users/cih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cih/subscriptions","organizations_url":"https://api.github.com/users/cih/orgs","repos_url":"https://api.github.com/users/cih/repos","events_url":"https://api.github.com/users/cih/events{/privacy}","received_events_url":"https://api.github.com/users/cih/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brigade/scss-lint/labels/enhancement","name":"enhancement","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-28T13:47:31Z","updated_at":"2015-08-31T17:26:55Z","closed_at":"2015-08-31T17:26:11Z","pull_request":{"url":"https://api.github.com/repos/brigade/scss-lint/pulls/569","html_url":"https://github.com/brigade/scss-lint/pull/569","diff_url":"https://github.com/brigade/scss-lint/pull/569.diff","patch_url":"https://github.com/brigade/scss-lint/pull/569.patch"},"body":"Hey Folks, \r\n\r\nI've started working on https://github.com/brigade/scss-lint/issues/488 and I was hoping to get some feedback before completing this. I've added some specs based on the examples in the matrix and these are now passing. There are a couple of things to note, as we're simply checking all of the color function arguments are literals then we won't raise a lint in the case where we have a mixture of variables and literals, so the example below won't raise a lint, would my implementation need to handle this too?\r\n\r\n```css\r\n  a {\r\n    color: rgb($some-var, 50%, 80%);\r\n  }\r\n```\r\n\r\nAlso I've changed this [spec](https://github.com/cih/scss-lint/blob/1759e748bc4b0017c94154561c56baf773e04202/spec/scss_lint/linter/color_variable_spec.rb#L123-L131) to expect a lint to be reported, this was previously expected to not report, what would we want to happen in this case. Any feedback would be appreciated.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/brigade/scss-lint/issues/comments/136435160","html_url":"https://github.com/brigade/scss-lint/pull/569#issuecomment-136435160","issue_url":"https://api.github.com/repos/brigade/scss-lint/issues/569","id":136435160,"user":{"login":"sds","id":677877,"avatar_url":"https://avatars.githubusercontent.com/u/677877?v=3","gravatar_id":"","url":"https://api.github.com/users/sds","html_url":"https://github.com/sds","followers_url":"https://api.github.com/users/sds/followers","following_url":"https://api.github.com/users/sds/following{/other_user}","gists_url":"https://api.github.com/users/sds/gists{/gist_id}","starred_url":"https://api.github.com/users/sds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sds/subscriptions","organizations_url":"https://api.github.com/users/sds/orgs","repos_url":"https://api.github.com/users/sds/repos","events_url":"https://api.github.com/users/sds/events{/privacy}","received_events_url":"https://api.github.com/users/sds/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T17:26:55Z","updated_at":"2015-08-31T17:26:55Z","body":"This looks good to me, @cih. Thanks for the PR!"}}