{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/28055824","id":28055824,"diff_hunk":"@@ -331,19 +331,22 @@ private[streaming]\n object FileInputDStream {\n \n   /**\n-   * Minimum duration of remembering the information of selected files. Files with mod times\n-   * older than this \"window\" of remembering will be ignored. So if new files are visible\n-   * within this window, then the file will get selected in the next batch.\n+   * Minimum duration of remembering the information of selected files. Defaults to 1 minute.\n+   *\n+   * Files with mod times older than this \"window\" of remembering will be ignored. So if new\n+   * files are visible within this window, then the file will get selected in the next batch.\n    */\n-  private val MIN_REMEMBER_DURATION = Minutes(1)\n+  private val minRememberDurationMin = Minutes(new SparkConf()","path":"streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala","position":31,"original_position":31,"commit_id":"daccc827a79862f47aaf4d5083754fa47033caab","original_commit_id":"daccc827a79862f47aaf4d5083754fa47033caab","user":{"login":"emres","id":150102,"avatar_url":"https://avatars.githubusercontent.com/u/150102?v=3","gravatar_id":"","url":"https://api.github.com/users/emres","html_url":"https://github.com/emres","followers_url":"https://api.github.com/users/emres/followers","following_url":"https://api.github.com/users/emres/following{/other_user}","gists_url":"https://api.github.com/users/emres/gists{/gist_id}","starred_url":"https://api.github.com/users/emres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emres/subscriptions","organizations_url":"https://api.github.com/users/emres/orgs","repos_url":"https://api.github.com/users/emres/repos","events_url":"https://api.github.com/users/emres/events{/privacy}","received_events_url":"https://api.github.com/users/emres/received_events","type":"User","site_admin":false},"body":"@srowen I'm a little confused. Do you mean something like: \"inside ``private[streaming] class FileInputDStream[K, V, F <: NewInputFormat[K,V]]`` class create a ``private val conf = new SparkConf()`` and then use that ``conf`` inside ``private[streaming] object FileInputDStream``\"?\r\n\r\nOr something totally different?","created_at":"2015-04-09T12:08:19Z","updated_at":"2015-04-09T12:08:19Z","html_url":"https://github.com/apache/spark/pull/5438#discussion_r28055824","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5438","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/28055824"},"html":{"href":"https://github.com/apache/spark/pull/5438#discussion_r28055824"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5438"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5438","id":32941653,"html_url":"https://github.com/apache/spark/pull/5438","diff_url":"https://github.com/apache/spark/pull/5438.diff","patch_url":"https://github.com/apache/spark/pull/5438.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5438","number":5438,"state":"open","locked":false,"title":"SPARK-3276 Added a new configuration spark.streaming.minRememberDuration","user":{"login":"emres","id":150102,"avatar_url":"https://avatars.githubusercontent.com/u/150102?v=3","gravatar_id":"","url":"https://api.github.com/users/emres","html_url":"https://github.com/emres","followers_url":"https://api.github.com/users/emres/followers","following_url":"https://api.github.com/users/emres/following{/other_user}","gists_url":"https://api.github.com/users/emres/gists{/gist_id}","starred_url":"https://api.github.com/users/emres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emres/subscriptions","organizations_url":"https://api.github.com/users/emres/orgs","repos_url":"https://api.github.com/users/emres/repos","events_url":"https://api.github.com/users/emres/events{/privacy}","received_events_url":"https://api.github.com/users/emres/received_events","type":"User","site_admin":false},"body":"SPARK-3276 Added a new configuration parameter ``spark.streaming.minRememberDuration``, with a default value of 1 minute.\r\n\r\nSo that when a Spark Streaming application is started, an arbitrary number of minutes can be taken as threshold for remembering.","created_at":"2015-04-09T10:07:53Z","updated_at":"2015-04-09T12:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412a13e78a600f6177b4c3213ce45f42e77e350a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5438/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5438/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5438/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/daccc827a79862f47aaf4d5083754fa47033caab","head":{"label":"emres:SPARK-3276","ref":"SPARK-3276","sha":"daccc827a79862f47aaf4d5083754fa47033caab","user":{"login":"emres","id":150102,"avatar_url":"https://avatars.githubusercontent.com/u/150102?v=3","gravatar_id":"","url":"https://api.github.com/users/emres","html_url":"https://github.com/emres","followers_url":"https://api.github.com/users/emres/followers","following_url":"https://api.github.com/users/emres/following{/other_user}","gists_url":"https://api.github.com/users/emres/gists{/gist_id}","starred_url":"https://api.github.com/users/emres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emres/subscriptions","organizations_url":"https://api.github.com/users/emres/orgs","repos_url":"https://api.github.com/users/emres/repos","events_url":"https://api.github.com/users/emres/events{/privacy}","received_events_url":"https://api.github.com/users/emres/received_events","type":"User","site_admin":false},"repo":{"id":30773230,"name":"spark","full_name":"emres/spark","owner":{"login":"emres","id":150102,"avatar_url":"https://avatars.githubusercontent.com/u/150102?v=3","gravatar_id":"","url":"https://api.github.com/users/emres","html_url":"https://github.com/emres","followers_url":"https://api.github.com/users/emres/followers","following_url":"https://api.github.com/users/emres/following{/other_user}","gists_url":"https://api.github.com/users/emres/gists{/gist_id}","starred_url":"https://api.github.com/users/emres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emres/subscriptions","organizations_url":"https://api.github.com/users/emres/orgs","repos_url":"https://api.github.com/users/emres/repos","events_url":"https://api.github.com/users/emres/events{/privacy}","received_events_url":"https://api.github.com/users/emres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emres/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/emres/spark","forks_url":"https://api.github.com/repos/emres/spark/forks","keys_url":"https://api.github.com/repos/emres/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emres/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emres/spark/teams","hooks_url":"https://api.github.com/repos/emres/spark/hooks","issue_events_url":"https://api.github.com/repos/emres/spark/issues/events{/number}","events_url":"https://api.github.com/repos/emres/spark/events","assignees_url":"https://api.github.com/repos/emres/spark/assignees{/user}","branches_url":"https://api.github.com/repos/emres/spark/branches{/branch}","tags_url":"https://api.github.com/repos/emres/spark/tags","blobs_url":"https://api.github.com/repos/emres/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emres/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emres/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/emres/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emres/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/emres/spark/languages","stargazers_url":"https://api.github.com/repos/emres/spark/stargazers","contributors_url":"https://api.github.com/repos/emres/spark/contributors","subscribers_url":"https://api.github.com/repos/emres/spark/subscribers","subscription_url":"https://api.github.com/repos/emres/spark/subscription","commits_url":"https://api.github.com/repos/emres/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/emres/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/emres/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/emres/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/emres/spark/contents/{+path}","compare_url":"https://api.github.com/repos/emres/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emres/spark/merges","archive_url":"https://api.github.com/repos/emres/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emres/spark/downloads","issues_url":"https://api.github.com/repos/emres/spark/issues{/number}","pulls_url":"https://api.github.com/repos/emres/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/emres/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/emres/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emres/spark/labels{/name}","releases_url":"https://api.github.com/repos/emres/spark/releases{/id}","created_at":"2015-02-13T19:53:22Z","updated_at":"2015-04-09T11:43:25Z","pushed_at":"2015-04-09T11:43:37Z","git_url":"git://github.com/emres/spark.git","ssh_url":"git@github.com:emres/spark.git","clone_url":"https://github.com/emres/spark.git","svn_url":"https://github.com/emres/spark","homepage":null,"size":98082,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1b2aab8d5b9cc2ff702506038bd71aa8debe7ca0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-04-09T11:48:52Z","pushed_at":"2015-04-09T11:43:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1472290,"stargazers_count":3538,"watchers_count":3538,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3058,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":326,"forks":3058,"open_issues":326,"watchers":3538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5438"},"html":{"href":"https://github.com/apache/spark/pull/5438"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5438"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5438/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5438/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5438/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/daccc827a79862f47aaf4d5083754fa47033caab"}}}}