{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1390","labels_url":"https://api.github.com/repos/philc/vimium/issues/1390/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1390/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1390/events","html_url":"https://github.com/philc/vimium/pull/1390","id":53065554,"number":1390,"title":"Set up Vomnibar iframe as a UIComponent","user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2014-12-29T19:35:08Z","updated_at":"2015-01-10T16:41:30Z","closed_at":"2014-12-30T06:20:46Z","pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1390","html_url":"https://github.com/philc/vimium/pull/1390","diff_url":"https://github.com/philc/vimium/pull/1390.diff","patch_url":"https://github.com/philc/vimium/pull/1390.patch"},"body":"This PR uses the `UIComponent` framework set up in #1388 and #1385 to manage the Vomnibar iframe, and removes some unused code from the Vomnibar scripts.\r\n\r\n@smblott-github can you take a look at this?"},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/69462030","html_url":"https://github.com/philc/vimium/pull/1390#issuecomment-69462030","issue_url":"https://api.github.com/repos/philc/vimium/issues/1390","id":69462030,"user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"created_at":"2015-01-10T16:41:30Z","updated_at":"2015-01-10T16:41:30Z","body":"@mrmr1993.  We're catching a trailing `keyup` on `Escape` from the vomnibar:\r\n- Go [here](http://unixpapa.com/js/testkey.html).\r\n- `o`, `Esc`, `o`, `Esc`\r\n\r\nYou'll see the misplaced `keyup`.  This affects Google Inbox in practice.\r\n\r\nAny idea how we might suppress it?"}}