{"action":"created","issue":{"url":"https://api.github.com/repos/seomoz/qless/issues/239","labels_url":"https://api.github.com/repos/seomoz/qless/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/seomoz/qless/issues/239/comments","events_url":"https://api.github.com/repos/seomoz/qless/issues/239/events","html_url":"https://github.com/seomoz/qless/pull/239","id":87529509,"number":239,"title":"add check for in_signal_handler condition","user":{"login":"vadim-moz","id":9726922,"avatar_url":"https://avatars.githubusercontent.com/u/9726922?v=3","gravatar_id":"","url":"https://api.github.com/users/vadim-moz","html_url":"https://github.com/vadim-moz","followers_url":"https://api.github.com/users/vadim-moz/followers","following_url":"https://api.github.com/users/vadim-moz/following{/other_user}","gists_url":"https://api.github.com/users/vadim-moz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadim-moz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadim-moz/subscriptions","organizations_url":"https://api.github.com/users/vadim-moz/orgs","repos_url":"https://api.github.com/users/vadim-moz/repos","events_url":"https://api.github.com/users/vadim-moz/events{/privacy}","received_events_url":"https://api.github.com/users/vadim-moz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-11T22:59:12Z","updated_at":"2015-06-11T23:03:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/seomoz/qless/pulls/239","html_url":"https://github.com/seomoz/qless/pull/239","diff_url":"https://github.com/seomoz/qless/pull/239.diff","patch_url":"https://github.com/seomoz/qless/pull/239.patch"},"body":"Some design considerations:\r\n* there is no clean way to check whether we are in signal handling context, so it needs to be passed as parameter.\r\n* the right way (and, hopefully, one day available) is to pass it as a keyword parameter. Except that we are still supporting 1.9.x Ruby\r\n* when switching to keyword would occur, the defaults would disappear from method definitions (and ugly `in_signal_handler=in_signal_handler` as well."},"comment":{"url":"https://api.github.com/repos/seomoz/qless/issues/comments/111301909","html_url":"https://github.com/seomoz/qless/pull/239#issuecomment-111301909","issue_url":"https://api.github.com/repos/seomoz/qless/issues/239","id":111301909,"user":{"login":"myronmarston","id":49391,"avatar_url":"https://avatars.githubusercontent.com/u/49391?v=3","gravatar_id":"","url":"https://api.github.com/users/myronmarston","html_url":"https://github.com/myronmarston","followers_url":"https://api.github.com/users/myronmarston/followers","following_url":"https://api.github.com/users/myronmarston/following{/other_user}","gists_url":"https://api.github.com/users/myronmarston/gists{/gist_id}","starred_url":"https://api.github.com/users/myronmarston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myronmarston/subscriptions","organizations_url":"https://api.github.com/users/myronmarston/orgs","repos_url":"https://api.github.com/users/myronmarston/repos","events_url":"https://api.github.com/users/myronmarston/events{/privacy}","received_events_url":"https://api.github.com/users/myronmarston/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T23:03:25Z","updated_at":"2015-06-11T23:03:25Z","body":"LGTM"}}