{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments/26091010","id":26091010,"diff_hunk":"@@ -29,8 +29,7 @@ function log() {\n }\n \n function get_instance_id() {\n-  # Do not retry to get the metadata value on failures.\n-  MDS_TRIES=1 ${PREFIX}/usr/share/google/get_metadata_value id 2>/dev/null\n+  ${PREFIX}/usr/share/google/get_metadata_value id 2>/dev/null","path":"google-startup-scripts/usr/share/google/first-boot","position":6,"original_position":6,"commit_id":"c8330220c4bda9d7c076e9d29ab43e1e416ee43e","original_commit_id":"c8330220c4bda9d7c076e9d29ab43e1e416ee43e","user":{"login":"illfelder","id":1766378,"avatar_url":"https://avatars.githubusercontent.com/u/1766378?v=3","gravatar_id":"","url":"https://api.github.com/users/illfelder","html_url":"https://github.com/illfelder","followers_url":"https://api.github.com/users/illfelder/followers","following_url":"https://api.github.com/users/illfelder/following{/other_user}","gists_url":"https://api.github.com/users/illfelder/gists{/gist_id}","starred_url":"https://api.github.com/users/illfelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illfelder/subscriptions","organizations_url":"https://api.github.com/users/illfelder/orgs","repos_url":"https://api.github.com/users/illfelder/repos","events_url":"https://api.github.com/users/illfelder/events{/privacy}","received_events_url":"https://api.github.com/users/illfelder/received_events","type":"User","site_admin":false},"body":"Please comment on what is happening here.","created_at":"2015-03-10T00:41:26Z","updated_at":"2015-03-10T00:41:26Z","html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152#discussion_r26091010","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments/26091010"},"html":{"href":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152#discussion_r26091010"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152","id":30695243,"html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152","diff_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152.diff","patch_url":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/152","number":152,"state":"open","locked":false,"title":"Check for a connection to the metadata server before starting Google startup scripts for Linux .","user":{"login":"zmarano","id":4564273,"avatar_url":"https://avatars.githubusercontent.com/u/4564273?v=3","gravatar_id":"","url":"https://api.github.com/users/zmarano","html_url":"https://github.com/zmarano","followers_url":"https://api.github.com/users/zmarano/followers","following_url":"https://api.github.com/users/zmarano/following{/other_user}","gists_url":"https://api.github.com/users/zmarano/gists{/gist_id}","starred_url":"https://api.github.com/users/zmarano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmarano/subscriptions","organizations_url":"https://api.github.com/users/zmarano/orgs","repos_url":"https://api.github.com/users/zmarano/repos","events_url":"https://api.github.com/users/zmarano/events{/privacy}","received_events_url":"https://api.github.com/users/zmarano/received_events","type":"User","site_admin":false},"body":"If a VM starts without an active network or DHCP takes too long to return an address, Google boot scripts would fail to complete.\r\n\r\nAdd a check at the very beginning of the onboot script to check for a connection to the metadata server indefinitely until it is reachable and print messages to the console when a connection cannot be obtained.\r\n\r\nChange retry logic in get_metadata_values in cases where there are connection failures or host lookup failures and default to a 30 second retry in both cases (if for instance the metadata server is not reachable for a short period of time).\r\n\r\nChange start on stanza's in upstart scripts to wait for started networking which should circumvent such problems on upstart based distros. The systemd scripts already do this.","created_at":"2015-03-07T02:16:37Z","updated_at":"2015-03-10T00:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38e5f2745adf08b5913dd4adf2d5be0a2fbf277c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/152/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/c8330220c4bda9d7c076e9d29ab43e1e416ee43e","head":{"label":"zmarano:master","ref":"master","sha":"c8330220c4bda9d7c076e9d29ab43e1e416ee43e","user":{"login":"zmarano","id":4564273,"avatar_url":"https://avatars.githubusercontent.com/u/4564273?v=3","gravatar_id":"","url":"https://api.github.com/users/zmarano","html_url":"https://github.com/zmarano","followers_url":"https://api.github.com/users/zmarano/followers","following_url":"https://api.github.com/users/zmarano/following{/other_user}","gists_url":"https://api.github.com/users/zmarano/gists{/gist_id}","starred_url":"https://api.github.com/users/zmarano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmarano/subscriptions","organizations_url":"https://api.github.com/users/zmarano/orgs","repos_url":"https://api.github.com/users/zmarano/repos","events_url":"https://api.github.com/users/zmarano/events{/privacy}","received_events_url":"https://api.github.com/users/zmarano/received_events","type":"User","site_admin":false},"repo":{"id":31735689,"name":"compute-image-packages","full_name":"zmarano/compute-image-packages","owner":{"login":"zmarano","id":4564273,"avatar_url":"https://avatars.githubusercontent.com/u/4564273?v=3","gravatar_id":"","url":"https://api.github.com/users/zmarano","html_url":"https://github.com/zmarano","followers_url":"https://api.github.com/users/zmarano/followers","following_url":"https://api.github.com/users/zmarano/following{/other_user}","gists_url":"https://api.github.com/users/zmarano/gists{/gist_id}","starred_url":"https://api.github.com/users/zmarano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmarano/subscriptions","organizations_url":"https://api.github.com/users/zmarano/orgs","repos_url":"https://api.github.com/users/zmarano/repos","events_url":"https://api.github.com/users/zmarano/events{/privacy}","received_events_url":"https://api.github.com/users/zmarano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmarano/compute-image-packages","description":"Scripts and tools for Google Compute Engine images.","fork":true,"url":"https://api.github.com/repos/zmarano/compute-image-packages","forks_url":"https://api.github.com/repos/zmarano/compute-image-packages/forks","keys_url":"https://api.github.com/repos/zmarano/compute-image-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmarano/compute-image-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmarano/compute-image-packages/teams","hooks_url":"https://api.github.com/repos/zmarano/compute-image-packages/hooks","issue_events_url":"https://api.github.com/repos/zmarano/compute-image-packages/issues/events{/number}","events_url":"https://api.github.com/repos/zmarano/compute-image-packages/events","assignees_url":"https://api.github.com/repos/zmarano/compute-image-packages/assignees{/user}","branches_url":"https://api.github.com/repos/zmarano/compute-image-packages/branches{/branch}","tags_url":"https://api.github.com/repos/zmarano/compute-image-packages/tags","blobs_url":"https://api.github.com/repos/zmarano/compute-image-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmarano/compute-image-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmarano/compute-image-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmarano/compute-image-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmarano/compute-image-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/zmarano/compute-image-packages/languages","stargazers_url":"https://api.github.com/repos/zmarano/compute-image-packages/stargazers","contributors_url":"https://api.github.com/repos/zmarano/compute-image-packages/contributors","subscribers_url":"https://api.github.com/repos/zmarano/compute-image-packages/subscribers","subscription_url":"https://api.github.com/repos/zmarano/compute-image-packages/subscription","commits_url":"https://api.github.com/repos/zmarano/compute-image-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmarano/compute-image-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmarano/compute-image-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmarano/compute-image-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmarano/compute-image-packages/contents/{+path}","compare_url":"https://api.github.com/repos/zmarano/compute-image-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmarano/compute-image-packages/merges","archive_url":"https://api.github.com/repos/zmarano/compute-image-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmarano/compute-image-packages/downloads","issues_url":"https://api.github.com/repos/zmarano/compute-image-packages/issues{/number}","pulls_url":"https://api.github.com/repos/zmarano/compute-image-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/zmarano/compute-image-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/zmarano/compute-image-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmarano/compute-image-packages/labels{/name}","releases_url":"https://api.github.com/repos/zmarano/compute-image-packages/releases{/id}","created_at":"2015-03-05T20:50:42Z","updated_at":"2015-03-09T21:15:23Z","pushed_at":"2015-03-09T21:15:23Z","git_url":"git://github.com/zmarano/compute-image-packages.git","ssh_url":"git@github.com:zmarano/compute-image-packages.git","clone_url":"https://github.com/zmarano/compute-image-packages.git","svn_url":"https://github.com/zmarano/compute-image-packages","homepage":null,"size":1417,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"de97955a5b42575c32c65358dc0fbbebb2aca771","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":11852493,"name":"compute-image-packages","full_name":"GoogleCloudPlatform/compute-image-packages","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/compute-image-packages","description":"Scripts and tools for Google Compute Engine images.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/releases{/id}","created_at":"2013-08-02T20:52:04Z","updated_at":"2015-03-10T00:15:42Z","pushed_at":"2015-03-04T18:16:53Z","git_url":"git://github.com/GoogleCloudPlatform/compute-image-packages.git","ssh_url":"git@github.com:GoogleCloudPlatform/compute-image-packages.git","clone_url":"https://github.com/GoogleCloudPlatform/compute-image-packages.git","svn_url":"https://github.com/GoogleCloudPlatform/compute-image-packages","homepage":null,"size":1417,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":20,"forks":73,"open_issues":20,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152"},"html":{"href":"https://github.com/GoogleCloudPlatform/compute-image-packages/pull/152"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/152"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/compute-image-packages/statuses/c8330220c4bda9d7c076e9d29ab43e1e416ee43e"}}}}