{"action":"closed","number":245,"pull_request":{"url":"https://api.github.com/repos/cSploit/android/pulls/245","id":45165748,"html_url":"https://github.com/cSploit/android/pull/245","diff_url":"https://github.com/cSploit/android/pull/245.diff","patch_url":"https://github.com/cSploit/android/pull/245.patch","issue_url":"https://api.github.com/repos/cSploit/android/issues/245","number":245,"state":"closed","locked":false,"title":"allow to use any configured network interface with a valid IP","user":{"login":"gainan","id":2742953,"avatar_url":"https://avatars.githubusercontent.com/u/2742953?v=3","gravatar_id":"","url":"https://api.github.com/users/gainan","html_url":"https://github.com/gainan","followers_url":"https://api.github.com/users/gainan/followers","following_url":"https://api.github.com/users/gainan/following{/other_user}","gists_url":"https://api.github.com/users/gainan/gists{/gist_id}","starred_url":"https://api.github.com/users/gainan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainan/subscriptions","organizations_url":"https://api.github.com/users/gainan/orgs","repos_url":"https://api.github.com/users/gainan/repos","events_url":"https://api.github.com/users/gainan/events{/privacy}","received_events_url":"https://api.github.com/users/gainan/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nThis is a patch for the suggestion #240 .\r\n\r\nIt works as follow:\r\n- initialize the system and configure the network.\r\n   - initialize the network, by default using the wireless information available.\r\n      * if it´s not available (no wifi interface configured), get all the ifaces configured on the system (any net device with a valid IP).\r\n        - if there's only one interface configured, use that, and add the default net devices to the layout (subnet + target gw + target ip).\r\n        - if there're more than one interface configured, display a dialog with the list of available net interfaces. \r\n        - re/load the network items list, configure the layouts and start the network radar.\r\n      \r\n        * when a valid net interface is selected, register the plugins, launch the network radar and launch the update checker.\r\n      * if there´s no network interface available, display an information message, and launch the update checker.\r\n\r\nIf the user press the option menu to select a device:\r\n - Display always the dialog, even with only one interface.\r\n   - reload the network items list, configure the layouts and start the network radar.\r\n\r\nThis has been my check list:\r\n- Install the app\r\n- start the app and check that core tools are:\r\n  * checked.\r\n  * downloaded (if not installed or outdated)\r\n  * verified and extracted.\r\n- start the app with no interfaces available (airplane mode), 1, 2 and 3 interfaces available.\r\n- start the app with wifi interface available, and with gsm interface available.\r\n- show the net interfaces dialog from the menu with no interfaces available, with 1, 2 and 3 interfaces available.\r\n- start the app with wifi interface available and wait until get all the network hosts. Then disable wifi, get gsm connectivity, and select that interface from the menu. Ensure that the network hosts list is refreshed with the new found hosts.\r\n\r\nIf someone wants to try it out would be great, since it's quite intrusive and it will need to be tested well.\r\n\r\nRegards.","created_at":"2015-09-16T12:37:05Z","updated_at":"2015-10-07T13:08:05Z","closed_at":"2015-10-07T13:08:05Z","merged_at":null,"merge_commit_sha":"ecb749fc08703e63d4e61179685a3c44161bd07b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cSploit/android/pulls/245/commits","review_comments_url":"https://api.github.com/repos/cSploit/android/pulls/245/comments","review_comment_url":"https://api.github.com/repos/cSploit/android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cSploit/android/issues/245/comments","statuses_url":"https://api.github.com/repos/cSploit/android/statuses/b470506ace528a7ba146f5b6b736e38e96578837","head":{"label":"gainan:multi_interfaces","ref":"multi_interfaces","sha":"b470506ace528a7ba146f5b6b736e38e96578837","user":{"login":"gainan","id":2742953,"avatar_url":"https://avatars.githubusercontent.com/u/2742953?v=3","gravatar_id":"","url":"https://api.github.com/users/gainan","html_url":"https://github.com/gainan","followers_url":"https://api.github.com/users/gainan/followers","following_url":"https://api.github.com/users/gainan/following{/other_user}","gists_url":"https://api.github.com/users/gainan/gists{/gist_id}","starred_url":"https://api.github.com/users/gainan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainan/subscriptions","organizations_url":"https://api.github.com/users/gainan/orgs","repos_url":"https://api.github.com/users/gainan/repos","events_url":"https://api.github.com/users/gainan/events{/privacy}","received_events_url":"https://api.github.com/users/gainan/received_events","type":"User","site_admin":false},"repo":{"id":42070431,"name":"android","full_name":"gainan/android","owner":{"login":"gainan","id":2742953,"avatar_url":"https://avatars.githubusercontent.com/u/2742953?v=3","gravatar_id":"","url":"https://api.github.com/users/gainan","html_url":"https://github.com/gainan","followers_url":"https://api.github.com/users/gainan/followers","following_url":"https://api.github.com/users/gainan/following{/other_user}","gists_url":"https://api.github.com/users/gainan/gists{/gist_id}","starred_url":"https://api.github.com/users/gainan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gainan/subscriptions","organizations_url":"https://api.github.com/users/gainan/orgs","repos_url":"https://api.github.com/users/gainan/repos","events_url":"https://api.github.com/users/gainan/events{/privacy}","received_events_url":"https://api.github.com/users/gainan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gainan/android","description":"cSploit - The most complete and advanced IT security professional toolkit on Android.","fork":true,"url":"https://api.github.com/repos/gainan/android","forks_url":"https://api.github.com/repos/gainan/android/forks","keys_url":"https://api.github.com/repos/gainan/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gainan/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gainan/android/teams","hooks_url":"https://api.github.com/repos/gainan/android/hooks","issue_events_url":"https://api.github.com/repos/gainan/android/issues/events{/number}","events_url":"https://api.github.com/repos/gainan/android/events","assignees_url":"https://api.github.com/repos/gainan/android/assignees{/user}","branches_url":"https://api.github.com/repos/gainan/android/branches{/branch}","tags_url":"https://api.github.com/repos/gainan/android/tags","blobs_url":"https://api.github.com/repos/gainan/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gainan/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gainan/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/gainan/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gainan/android/statuses/{sha}","languages_url":"https://api.github.com/repos/gainan/android/languages","stargazers_url":"https://api.github.com/repos/gainan/android/stargazers","contributors_url":"https://api.github.com/repos/gainan/android/contributors","subscribers_url":"https://api.github.com/repos/gainan/android/subscribers","subscription_url":"https://api.github.com/repos/gainan/android/subscription","commits_url":"https://api.github.com/repos/gainan/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/gainan/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/gainan/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/gainan/android/issues/comments{/number}","contents_url":"https://api.github.com/repos/gainan/android/contents/{+path}","compare_url":"https://api.github.com/repos/gainan/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gainan/android/merges","archive_url":"https://api.github.com/repos/gainan/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gainan/android/downloads","issues_url":"https://api.github.com/repos/gainan/android/issues{/number}","pulls_url":"https://api.github.com/repos/gainan/android/pulls{/number}","milestones_url":"https://api.github.com/repos/gainan/android/milestones{/number}","notifications_url":"https://api.github.com/repos/gainan/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gainan/android/labels{/name}","releases_url":"https://api.github.com/repos/gainan/android/releases{/id}","created_at":"2015-09-07T19:20:18Z","updated_at":"2015-10-04T23:01:27Z","pushed_at":"2015-10-07T11:54:05Z","git_url":"git://github.com/gainan/android.git","ssh_url":"git@github.com:gainan/android.git","clone_url":"https://github.com/gainan/android.git","svn_url":"https://github.com/gainan/android","homepage":"http://www.csploit.org/","size":38767,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cSploit:master","ref":"master","sha":"59c8b8460249aea1fd649791d076e65de9a22f79","user":{"login":"cSploit","id":9015721,"avatar_url":"https://avatars.githubusercontent.com/u/9015721?v=3","gravatar_id":"","url":"https://api.github.com/users/cSploit","html_url":"https://github.com/cSploit","followers_url":"https://api.github.com/users/cSploit/followers","following_url":"https://api.github.com/users/cSploit/following{/other_user}","gists_url":"https://api.github.com/users/cSploit/gists{/gist_id}","starred_url":"https://api.github.com/users/cSploit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cSploit/subscriptions","organizations_url":"https://api.github.com/users/cSploit/orgs","repos_url":"https://api.github.com/users/cSploit/repos","events_url":"https://api.github.com/users/cSploit/events{/privacy}","received_events_url":"https://api.github.com/users/cSploit/received_events","type":"Organization","site_admin":false},"repo":{"id":24782902,"name":"android","full_name":"cSploit/android","owner":{"login":"cSploit","id":9015721,"avatar_url":"https://avatars.githubusercontent.com/u/9015721?v=3","gravatar_id":"","url":"https://api.github.com/users/cSploit","html_url":"https://github.com/cSploit","followers_url":"https://api.github.com/users/cSploit/followers","following_url":"https://api.github.com/users/cSploit/following{/other_user}","gists_url":"https://api.github.com/users/cSploit/gists{/gist_id}","starred_url":"https://api.github.com/users/cSploit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cSploit/subscriptions","organizations_url":"https://api.github.com/users/cSploit/orgs","repos_url":"https://api.github.com/users/cSploit/repos","events_url":"https://api.github.com/users/cSploit/events{/privacy}","received_events_url":"https://api.github.com/users/cSploit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cSploit/android","description":"cSploit - The most complete and advanced IT security professional toolkit on Android.","fork":true,"url":"https://api.github.com/repos/cSploit/android","forks_url":"https://api.github.com/repos/cSploit/android/forks","keys_url":"https://api.github.com/repos/cSploit/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cSploit/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cSploit/android/teams","hooks_url":"https://api.github.com/repos/cSploit/android/hooks","issue_events_url":"https://api.github.com/repos/cSploit/android/issues/events{/number}","events_url":"https://api.github.com/repos/cSploit/android/events","assignees_url":"https://api.github.com/repos/cSploit/android/assignees{/user}","branches_url":"https://api.github.com/repos/cSploit/android/branches{/branch}","tags_url":"https://api.github.com/repos/cSploit/android/tags","blobs_url":"https://api.github.com/repos/cSploit/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cSploit/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cSploit/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/cSploit/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cSploit/android/statuses/{sha}","languages_url":"https://api.github.com/repos/cSploit/android/languages","stargazers_url":"https://api.github.com/repos/cSploit/android/stargazers","contributors_url":"https://api.github.com/repos/cSploit/android/contributors","subscribers_url":"https://api.github.com/repos/cSploit/android/subscribers","subscription_url":"https://api.github.com/repos/cSploit/android/subscription","commits_url":"https://api.github.com/repos/cSploit/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/cSploit/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/cSploit/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/cSploit/android/issues/comments{/number}","contents_url":"https://api.github.com/repos/cSploit/android/contents/{+path}","compare_url":"https://api.github.com/repos/cSploit/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cSploit/android/merges","archive_url":"https://api.github.com/repos/cSploit/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cSploit/android/downloads","issues_url":"https://api.github.com/repos/cSploit/android/issues{/number}","pulls_url":"https://api.github.com/repos/cSploit/android/pulls{/number}","milestones_url":"https://api.github.com/repos/cSploit/android/milestones{/number}","notifications_url":"https://api.github.com/repos/cSploit/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cSploit/android/labels{/name}","releases_url":"https://api.github.com/repos/cSploit/android/releases{/id}","created_at":"2014-10-04T05:53:29Z","updated_at":"2015-10-06T17:28:01Z","pushed_at":"2015-10-07T11:23:36Z","git_url":"git://github.com/cSploit/android.git","ssh_url":"git@github.com:cSploit/android.git","clone_url":"https://github.com/cSploit/android.git","svn_url":"https://github.com/cSploit/android","homepage":"http://www.csploit.org/","size":42770,"stargazers_count":378,"watchers_count":378,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":62,"forks":93,"open_issues":62,"watchers":378,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cSploit/android/pulls/245"},"html":{"href":"https://github.com/cSploit/android/pull/245"},"issue":{"href":"https://api.github.com/repos/cSploit/android/issues/245"},"comments":{"href":"https://api.github.com/repos/cSploit/android/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/cSploit/android/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/cSploit/android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cSploit/android/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/cSploit/android/statuses/b470506ace528a7ba146f5b6b736e38e96578837"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":27,"review_comments":8,"commits":3,"additions":460,"deletions":154,"changed_files":6}}