{"action":"created","comment":{"url":"https://api.github.com/repos/composer/composer/pulls/comments/38502830","id":38502830,"diff_hunk":"@@ -349,9 +349,10 @@ private function findFileWithExtension($class, $ext)\n         $first = $class[0];\n         if (isset($this->prefixLengthsPsr4[$first])) {\n             foreach ($this->prefixLengthsPsr4[$first] as $prefix => $length) {\n+                $logicalPath=substr($logicalPathPsr4, $length);","path":"src/Composer/Autoload/ClassLoader.php","position":null,"original_position":4,"commit_id":"4c3fa83d46dfce2e48a628f56cca6c8bb91167c9","original_commit_id":"231a25f6cc1c0afcc134b3058da50d7db209913e","user":{"login":"individual-it","id":2425577,"avatar_url":"https://avatars.githubusercontent.com/u/2425577?v=3","gravatar_id":"","url":"https://api.github.com/users/individual-it","html_url":"https://github.com/individual-it","followers_url":"https://api.github.com/users/individual-it/followers","following_url":"https://api.github.com/users/individual-it/following{/other_user}","gists_url":"https://api.github.com/users/individual-it/gists{/gist_id}","starred_url":"https://api.github.com/users/individual-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/individual-it/subscriptions","organizations_url":"https://api.github.com/users/individual-it/orgs","repos_url":"https://api.github.com/users/individual-it/repos","events_url":"https://api.github.com/users/individual-it/events{/privacy}","received_events_url":"https://api.github.com/users/individual-it/received_events","type":"User","site_admin":false},"body":"you are right, I've changed it","created_at":"2015-09-02T06:45:18Z","updated_at":"2015-09-02T06:45:18Z","html_url":"https://github.com/composer/composer/pull/4391#discussion_r38502830","pull_request_url":"https://api.github.com/repos/composer/composer/pulls/4391","_links":{"self":{"href":"https://api.github.com/repos/composer/composer/pulls/comments/38502830"},"html":{"href":"https://github.com/composer/composer/pull/4391#discussion_r38502830"},"pull_request":{"href":"https://api.github.com/repos/composer/composer/pulls/4391"}}},"pull_request":{"url":"https://api.github.com/repos/composer/composer/pulls/4391","id":43890424,"html_url":"https://github.com/composer/composer/pull/4391","diff_url":"https://github.com/composer/composer/pull/4391.diff","patch_url":"https://github.com/composer/composer/pull/4391.patch","issue_url":"https://api.github.com/repos/composer/composer/issues/4391","number":4391,"state":"open","locked":false,"title":"less runs of substr in findFileWithExtension()","user":{"login":"individual-it","id":2425577,"avatar_url":"https://avatars.githubusercontent.com/u/2425577?v=3","gravatar_id":"","url":"https://api.github.com/users/individual-it","html_url":"https://github.com/individual-it","followers_url":"https://api.github.com/users/individual-it/followers","following_url":"https://api.github.com/users/individual-it/following{/other_user}","gists_url":"https://api.github.com/users/individual-it/gists{/gist_id}","starred_url":"https://api.github.com/users/individual-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/individual-it/subscriptions","organizations_url":"https://api.github.com/users/individual-it/orgs","repos_url":"https://api.github.com/users/individual-it/repos","events_url":"https://api.github.com/users/individual-it/events{/privacy}","received_events_url":"https://api.github.com/users/individual-it/received_events","type":"User","site_admin":false},"body":"putting the substr outside of the foreach loop should save some substr runs","created_at":"2015-09-01T15:33:31Z","updated_at":"2015-09-02T06:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"274cf54fa98459afc6102a26324fb4f9ecd255c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/composer/composer/pulls/4391/commits","review_comments_url":"https://api.github.com/repos/composer/composer/pulls/4391/comments","review_comment_url":"https://api.github.com/repos/composer/composer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/composer/composer/issues/4391/comments","statuses_url":"https://api.github.com/repos/composer/composer/statuses/4c3fa83d46dfce2e48a628f56cca6c8bb91167c9","head":{"label":"individual-it:patch-1","ref":"patch-1","sha":"4c3fa83d46dfce2e48a628f56cca6c8bb91167c9","user":{"login":"individual-it","id":2425577,"avatar_url":"https://avatars.githubusercontent.com/u/2425577?v=3","gravatar_id":"","url":"https://api.github.com/users/individual-it","html_url":"https://github.com/individual-it","followers_url":"https://api.github.com/users/individual-it/followers","following_url":"https://api.github.com/users/individual-it/following{/other_user}","gists_url":"https://api.github.com/users/individual-it/gists{/gist_id}","starred_url":"https://api.github.com/users/individual-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/individual-it/subscriptions","organizations_url":"https://api.github.com/users/individual-it/orgs","repos_url":"https://api.github.com/users/individual-it/repos","events_url":"https://api.github.com/users/individual-it/events{/privacy}","received_events_url":"https://api.github.com/users/individual-it/received_events","type":"User","site_admin":false},"repo":{"id":41724097,"name":"composer","full_name":"individual-it/composer","owner":{"login":"individual-it","id":2425577,"avatar_url":"https://avatars.githubusercontent.com/u/2425577?v=3","gravatar_id":"","url":"https://api.github.com/users/individual-it","html_url":"https://github.com/individual-it","followers_url":"https://api.github.com/users/individual-it/followers","following_url":"https://api.github.com/users/individual-it/following{/other_user}","gists_url":"https://api.github.com/users/individual-it/gists{/gist_id}","starred_url":"https://api.github.com/users/individual-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/individual-it/subscriptions","organizations_url":"https://api.github.com/users/individual-it/orgs","repos_url":"https://api.github.com/users/individual-it/repos","events_url":"https://api.github.com/users/individual-it/events{/privacy}","received_events_url":"https://api.github.com/users/individual-it/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/individual-it/composer","description":"Dependency Manager for PHP","fork":true,"url":"https://api.github.com/repos/individual-it/composer","forks_url":"https://api.github.com/repos/individual-it/composer/forks","keys_url":"https://api.github.com/repos/individual-it/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/individual-it/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/individual-it/composer/teams","hooks_url":"https://api.github.com/repos/individual-it/composer/hooks","issue_events_url":"https://api.github.com/repos/individual-it/composer/issues/events{/number}","events_url":"https://api.github.com/repos/individual-it/composer/events","assignees_url":"https://api.github.com/repos/individual-it/composer/assignees{/user}","branches_url":"https://api.github.com/repos/individual-it/composer/branches{/branch}","tags_url":"https://api.github.com/repos/individual-it/composer/tags","blobs_url":"https://api.github.com/repos/individual-it/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/individual-it/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/individual-it/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/individual-it/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/individual-it/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/individual-it/composer/languages","stargazers_url":"https://api.github.com/repos/individual-it/composer/stargazers","contributors_url":"https://api.github.com/repos/individual-it/composer/contributors","subscribers_url":"https://api.github.com/repos/individual-it/composer/subscribers","subscription_url":"https://api.github.com/repos/individual-it/composer/subscription","commits_url":"https://api.github.com/repos/individual-it/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/individual-it/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/individual-it/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/individual-it/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/individual-it/composer/contents/{+path}","compare_url":"https://api.github.com/repos/individual-it/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/individual-it/composer/merges","archive_url":"https://api.github.com/repos/individual-it/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/individual-it/composer/downloads","issues_url":"https://api.github.com/repos/individual-it/composer/issues{/number}","pulls_url":"https://api.github.com/repos/individual-it/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/individual-it/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/individual-it/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/individual-it/composer/labels{/name}","releases_url":"https://api.github.com/repos/individual-it/composer/releases{/id}","created_at":"2015-09-01T07:35:08Z","updated_at":"2015-09-01T07:35:10Z","pushed_at":"2015-09-02T06:43:56Z","git_url":"git://github.com/individual-it/composer.git","ssh_url":"git@github.com:individual-it/composer.git","clone_url":"https://github.com/individual-it/composer.git","svn_url":"https://github.com/individual-it/composer","homepage":"http://getcomposer.org/","size":28364,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"composer:master","ref":"master","sha":"afd98b74f13b9def1b2447f16fd0bfd4d96dff94","user":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"repo":{"id":1864363,"name":"composer","full_name":"composer/composer","owner":{"login":"composer","id":837015,"avatar_url":"https://avatars.githubusercontent.com/u/837015?v=3","gravatar_id":"","url":"https://api.github.com/users/composer","html_url":"https://github.com/composer","followers_url":"https://api.github.com/users/composer/followers","following_url":"https://api.github.com/users/composer/following{/other_user}","gists_url":"https://api.github.com/users/composer/gists{/gist_id}","starred_url":"https://api.github.com/users/composer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/composer/subscriptions","organizations_url":"https://api.github.com/users/composer/orgs","repos_url":"https://api.github.com/users/composer/repos","events_url":"https://api.github.com/users/composer/events{/privacy}","received_events_url":"https://api.github.com/users/composer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/composer/composer","description":"Dependency Manager for PHP","fork":false,"url":"https://api.github.com/repos/composer/composer","forks_url":"https://api.github.com/repos/composer/composer/forks","keys_url":"https://api.github.com/repos/composer/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/composer/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/composer/composer/teams","hooks_url":"https://api.github.com/repos/composer/composer/hooks","issue_events_url":"https://api.github.com/repos/composer/composer/issues/events{/number}","events_url":"https://api.github.com/repos/composer/composer/events","assignees_url":"https://api.github.com/repos/composer/composer/assignees{/user}","branches_url":"https://api.github.com/repos/composer/composer/branches{/branch}","tags_url":"https://api.github.com/repos/composer/composer/tags","blobs_url":"https://api.github.com/repos/composer/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/composer/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/composer/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/composer/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/composer/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/composer/composer/languages","stargazers_url":"https://api.github.com/repos/composer/composer/stargazers","contributors_url":"https://api.github.com/repos/composer/composer/contributors","subscribers_url":"https://api.github.com/repos/composer/composer/subscribers","subscription_url":"https://api.github.com/repos/composer/composer/subscription","commits_url":"https://api.github.com/repos/composer/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/composer/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/composer/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/composer/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/composer/composer/contents/{+path}","compare_url":"https://api.github.com/repos/composer/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/composer/composer/merges","archive_url":"https://api.github.com/repos/composer/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/composer/composer/downloads","issues_url":"https://api.github.com/repos/composer/composer/issues{/number}","pulls_url":"https://api.github.com/repos/composer/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/composer/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/composer/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/composer/composer/labels{/name}","releases_url":"https://api.github.com/repos/composer/composer/releases{/id}","created_at":"2011-06-08T08:53:00Z","updated_at":"2015-09-02T03:13:42Z","pushed_at":"2015-09-02T06:43:57Z","git_url":"git://github.com/composer/composer.git","ssh_url":"git@github.com:composer/composer.git","clone_url":"https://github.com/composer/composer.git","svn_url":"https://github.com/composer/composer","homepage":"http://getcomposer.org/","size":28364,"stargazers_count":6195,"watchers_count":6195,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1713,"mirror_url":null,"open_issues_count":584,"forks":1713,"open_issues":584,"watchers":6195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/composer/composer/pulls/4391"},"html":{"href":"https://github.com/composer/composer/pull/4391"},"issue":{"href":"https://api.github.com/repos/composer/composer/issues/4391"},"comments":{"href":"https://api.github.com/repos/composer/composer/issues/4391/comments"},"review_comments":{"href":"https://api.github.com/repos/composer/composer/pulls/4391/comments"},"review_comment":{"href":"https://api.github.com/repos/composer/composer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/composer/composer/pulls/4391/commits"},"statuses":{"href":"https://api.github.com/repos/composer/composer/statuses/4c3fa83d46dfce2e48a628f56cca6c8bb91167c9"}}}}