{"action":"created","comment":{"url":"https://api.github.com/repos/yola/demands/pulls/comments/45324891","id":45324891,"diff_hunk":"@@ -148,17 +148,15 @@ def test_post_sends_no_exception_in_case_of_expected_response_code(self):\n         self.service.request(\n             'METHOD', 'http://notfound/', expected_response_codes=(404,))\n \n-    @patch('demands.log')\n-    def test_post_send_logs_errors(self, mock_log):\n+    def test_post_send_logs_errors(self):","path":"tests/test_demands.py","position":6,"original_position":6,"commit_id":"483925cf583a01a96083614a9823ac6c5fb3a84e","original_commit_id":"483925cf583a01a96083614a9823ac6c5fb3a84e","user":{"login":"RayeN","id":712948,"avatar_url":"https://avatars.githubusercontent.com/u/712948?v=3","gravatar_id":"","url":"https://api.github.com/users/RayeN","html_url":"https://github.com/RayeN","followers_url":"https://api.github.com/users/RayeN/followers","following_url":"https://api.github.com/users/RayeN/following{/other_user}","gists_url":"https://api.github.com/users/RayeN/gists{/gist_id}","starred_url":"https://api.github.com/users/RayeN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RayeN/subscriptions","organizations_url":"https://api.github.com/users/RayeN/orgs","repos_url":"https://api.github.com/users/RayeN/repos","events_url":"https://api.github.com/users/RayeN/events{/privacy}","received_events_url":"https://api.github.com/users/RayeN/received_events","type":"User","site_admin":false},"body":"we should either rename this test or remove it.  Because we don't log errors anymore.","created_at":"2015-11-19T10:40:51Z","updated_at":"2015-11-19T10:40:51Z","html_url":"https://github.com/yola/demands/pull/44#discussion_r45324891","pull_request_url":"https://api.github.com/repos/yola/demands/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/yola/demands/pulls/comments/45324891"},"html":{"href":"https://github.com/yola/demands/pull/44#discussion_r45324891"},"pull_request":{"href":"https://api.github.com/repos/yola/demands/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/yola/demands/pulls/44","id":51109277,"html_url":"https://github.com/yola/demands/pull/44","diff_url":"https://github.com/yola/demands/pull/44.diff","patch_url":"https://github.com/yola/demands/pull/44.patch","issue_url":"https://api.github.com/repos/yola/demands/issues/44","number":44,"state":"open","locked":false,"title":"Refactor error handling to allow use by custom post_send","user":{"login":"alexmojaki","id":3627481,"avatar_url":"https://avatars.githubusercontent.com/u/3627481?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmojaki","html_url":"https://github.com/alexmojaki","followers_url":"https://api.github.com/users/alexmojaki/followers","following_url":"https://api.github.com/users/alexmojaki/following{/other_user}","gists_url":"https://api.github.com/users/alexmojaki/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmojaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmojaki/subscriptions","organizations_url":"https://api.github.com/users/alexmojaki/orgs","repos_url":"https://api.github.com/users/alexmojaki/repos","events_url":"https://api.github.com/users/alexmojaki/events{/privacy}","received_events_url":"https://api.github.com/users/alexmojaki/received_events","type":"User","site_admin":false},"body":"Alternative to https://github.com/yola/demands/pull/43\r\n\r\nNow this can be done instead:\r\n\r\n    class SlackService(HTTPServiceClient):\r\n    \r\n        def post_send(self, response, **kwargs):\r\n            if not response.json()['ok']:\r\n                self.log_and_raise_error(response)\r\n            return response\r\n","created_at":"2015-11-18T16:45:09Z","updated_at":"2015-11-19T10:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa1c744db33020976e6c0d669efc59a769294c14","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yola/demands/pulls/44/commits","review_comments_url":"https://api.github.com/repos/yola/demands/pulls/44/comments","review_comment_url":"https://api.github.com/repos/yola/demands/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yola/demands/issues/44/comments","statuses_url":"https://api.github.com/repos/yola/demands/statuses/483925cf583a01a96083614a9823ac6c5fb3a84e","head":{"label":"yola:error-utility-methd","ref":"error-utility-methd","sha":"483925cf583a01a96083614a9823ac6c5fb3a84e","user":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=3","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":9327086,"name":"demands","full_name":"yola/demands","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=3","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/demands","description":"Base class for building service clients on top of requests","fork":false,"url":"https://api.github.com/repos/yola/demands","forks_url":"https://api.github.com/repos/yola/demands/forks","keys_url":"https://api.github.com/repos/yola/demands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/demands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/demands/teams","hooks_url":"https://api.github.com/repos/yola/demands/hooks","issue_events_url":"https://api.github.com/repos/yola/demands/issues/events{/number}","events_url":"https://api.github.com/repos/yola/demands/events","assignees_url":"https://api.github.com/repos/yola/demands/assignees{/user}","branches_url":"https://api.github.com/repos/yola/demands/branches{/branch}","tags_url":"https://api.github.com/repos/yola/demands/tags","blobs_url":"https://api.github.com/repos/yola/demands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/demands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/demands/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/demands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/demands/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/demands/languages","stargazers_url":"https://api.github.com/repos/yola/demands/stargazers","contributors_url":"https://api.github.com/repos/yola/demands/contributors","subscribers_url":"https://api.github.com/repos/yola/demands/subscribers","subscription_url":"https://api.github.com/repos/yola/demands/subscription","commits_url":"https://api.github.com/repos/yola/demands/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/demands/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/demands/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/demands/issues/comments{/number}","contents_url":"https://api.github.com/repos/yola/demands/contents/{+path}","compare_url":"https://api.github.com/repos/yola/demands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/demands/merges","archive_url":"https://api.github.com/repos/yola/demands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/demands/downloads","issues_url":"https://api.github.com/repos/yola/demands/issues{/number}","pulls_url":"https://api.github.com/repos/yola/demands/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/demands/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/demands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/demands/labels{/name}","releases_url":"https://api.github.com/repos/yola/demands/releases{/id}","created_at":"2013-04-09T17:25:57Z","updated_at":"2015-11-18T13:59:56Z","pushed_at":"2015-11-19T09:48:05Z","git_url":"git://github.com/yola/demands.git","ssh_url":"git@github.com:yola/demands.git","clone_url":"https://github.com/yola/demands.git","svn_url":"https://github.com/yola/demands","homepage":"","size":111,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"yola:master","ref":"master","sha":"fdaf270d68929dd88b42d0755d3e48d6a0331571","user":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=3","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"repo":{"id":9327086,"name":"demands","full_name":"yola/demands","owner":{"login":"yola","id":861497,"avatar_url":"https://avatars.githubusercontent.com/u/861497?v=3","gravatar_id":"","url":"https://api.github.com/users/yola","html_url":"https://github.com/yola","followers_url":"https://api.github.com/users/yola/followers","following_url":"https://api.github.com/users/yola/following{/other_user}","gists_url":"https://api.github.com/users/yola/gists{/gist_id}","starred_url":"https://api.github.com/users/yola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yola/subscriptions","organizations_url":"https://api.github.com/users/yola/orgs","repos_url":"https://api.github.com/users/yola/repos","events_url":"https://api.github.com/users/yola/events{/privacy}","received_events_url":"https://api.github.com/users/yola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yola/demands","description":"Base class for building service clients on top of requests","fork":false,"url":"https://api.github.com/repos/yola/demands","forks_url":"https://api.github.com/repos/yola/demands/forks","keys_url":"https://api.github.com/repos/yola/demands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yola/demands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yola/demands/teams","hooks_url":"https://api.github.com/repos/yola/demands/hooks","issue_events_url":"https://api.github.com/repos/yola/demands/issues/events{/number}","events_url":"https://api.github.com/repos/yola/demands/events","assignees_url":"https://api.github.com/repos/yola/demands/assignees{/user}","branches_url":"https://api.github.com/repos/yola/demands/branches{/branch}","tags_url":"https://api.github.com/repos/yola/demands/tags","blobs_url":"https://api.github.com/repos/yola/demands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yola/demands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yola/demands/git/refs{/sha}","trees_url":"https://api.github.com/repos/yola/demands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yola/demands/statuses/{sha}","languages_url":"https://api.github.com/repos/yola/demands/languages","stargazers_url":"https://api.github.com/repos/yola/demands/stargazers","contributors_url":"https://api.github.com/repos/yola/demands/contributors","subscribers_url":"https://api.github.com/repos/yola/demands/subscribers","subscription_url":"https://api.github.com/repos/yola/demands/subscription","commits_url":"https://api.github.com/repos/yola/demands/commits{/sha}","git_commits_url":"https://api.github.com/repos/yola/demands/git/commits{/sha}","comments_url":"https://api.github.com/repos/yola/demands/comments{/number}","issue_comment_url":"https://api.github.com/repos/yola/demands/issues/comments{/number}","contents_url":"https://api.github.com/repos/yola/demands/contents/{+path}","compare_url":"https://api.github.com/repos/yola/demands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yola/demands/merges","archive_url":"https://api.github.com/repos/yola/demands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yola/demands/downloads","issues_url":"https://api.github.com/repos/yola/demands/issues{/number}","pulls_url":"https://api.github.com/repos/yola/demands/pulls{/number}","milestones_url":"https://api.github.com/repos/yola/demands/milestones{/number}","notifications_url":"https://api.github.com/repos/yola/demands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yola/demands/labels{/name}","releases_url":"https://api.github.com/repos/yola/demands/releases{/id}","created_at":"2013-04-09T17:25:57Z","updated_at":"2015-11-18T13:59:56Z","pushed_at":"2015-11-19T09:48:05Z","git_url":"git://github.com/yola/demands.git","ssh_url":"git@github.com:yola/demands.git","clone_url":"https://github.com/yola/demands.git","svn_url":"https://github.com/yola/demands","homepage":"","size":111,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yola/demands/pulls/44"},"html":{"href":"https://github.com/yola/demands/pull/44"},"issue":{"href":"https://api.github.com/repos/yola/demands/issues/44"},"comments":{"href":"https://api.github.com/repos/yola/demands/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/yola/demands/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/yola/demands/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yola/demands/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/yola/demands/statuses/483925cf583a01a96083614a9823ac6c5fb3a84e"}}}}