{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/3","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/3/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/3/events","html_url":"https://github.com/logstash-plugins/logstash-input-lumberjack/pull/3","id":55220569,"number":3,"title":"Add the client IP address to each message if requested in the configuration","user":{"login":"stanhu","id":963826,"avatar_url":"https://avatars.githubusercontent.com/u/963826?v=3","gravatar_id":"","url":"https://api.github.com/users/stanhu","html_url":"https://github.com/stanhu","followers_url":"https://api.github.com/users/stanhu/followers","following_url":"https://api.github.com/users/stanhu/following{/other_user}","gists_url":"https://api.github.com/users/stanhu/gists{/gist_id}","starred_url":"https://api.github.com/users/stanhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanhu/subscriptions","organizations_url":"https://api.github.com/users/stanhu/orgs","repos_url":"https://api.github.com/users/stanhu/repos","events_url":"https://api.github.com/users/stanhu/events{/privacy}","received_events_url":"https://api.github.com/users/stanhu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-01-22T22:48:59Z","updated_at":"2015-01-23T01:02:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/pulls/3","html_url":"https://github.com/logstash-plugins/logstash-input-lumberjack/pull/3","diff_url":"https://github.com/logstash-plugins/logstash-input-lumberjack/pull/3.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-lumberjack/pull/3.patch"},"body":"Requires an update to the Lumberjack server (see https://github.com/stanhu/logstash-forwarder/tree/add-client-address) to pass along the address. I'm not quite sure how to tie the server version to the input filter version.\r\n\r\nI considered putting this functionality in the Lumberjack server itself, but it seems like the input filter should decide this here, just as the TCP input filter does. "},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/comments/71130621","html_url":"https://github.com/logstash-plugins/logstash-input-lumberjack/pull/3#issuecomment-71130621","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-lumberjack/issues/3","id":71130621,"user":{"login":"stanhu","id":963826,"avatar_url":"https://avatars.githubusercontent.com/u/963826?v=3","gravatar_id":"","url":"https://api.github.com/users/stanhu","html_url":"https://github.com/stanhu","followers_url":"https://api.github.com/users/stanhu/followers","following_url":"https://api.github.com/users/stanhu/following{/other_user}","gists_url":"https://api.github.com/users/stanhu/gists{/gist_id}","starred_url":"https://api.github.com/users/stanhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanhu/subscriptions","organizations_url":"https://api.github.com/users/stanhu/orgs","repos_url":"https://api.github.com/users/stanhu/repos","events_url":"https://api.github.com/users/stanhu/events{/privacy}","received_events_url":"https://api.github.com/users/stanhu/received_events","type":"User","site_admin":false},"created_at":"2015-01-23T01:02:09Z","updated_at":"2015-01-23T01:02:09Z","body":":) I like that idea. Another alternative I considered was to have the callback use the SSLSocket instance, but that potentially gives the input filter the ability to close/open a new connection.\r\n\r\nWe could whittle down the callback to a map of client data. Looking at the SSLSocket interface, I see a number of things that could be sent:\r\n\r\n1. Address family (e.g. INET/INET6/UNIX)\r\n2. Source IP\r\n3. Cipher\r\n4. List of client CAs\r\n5. Peer cert\r\n6. Peer certificate chain\r\n\r\nAnything I missed?\r\n\r\n "}}