{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/stripe-node/issues/180","labels_url":"https://api.github.com/repos/stripe/stripe-node/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/stripe/stripe-node/issues/180/comments","events_url":"https://api.github.com/repos/stripe/stripe-node/issues/180/events","html_url":"https://github.com/stripe/stripe-node/pull/180","id":86858569,"number":180,"title":"Allow an options hash to be passed in to Upcoming Invoice API","user":{"login":"matthewarkin","id":1103529,"avatar_url":"https://avatars.githubusercontent.com/u/1103529?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewarkin","html_url":"https://github.com/matthewarkin","followers_url":"https://api.github.com/users/matthewarkin/followers","following_url":"https://api.github.com/users/matthewarkin/following{/other_user}","gists_url":"https://api.github.com/users/matthewarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewarkin/subscriptions","organizations_url":"https://api.github.com/users/matthewarkin/orgs","repos_url":"https://api.github.com/users/matthewarkin/repos","events_url":"https://api.github.com/users/matthewarkin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewarkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-10T06:27:27Z","updated_at":"2015-06-12T04:58:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stripe/stripe-node/pulls/180","html_url":"https://github.com/stripe/stripe-node/pull/180","diff_url":"https://github.com/stripe/stripe-node/pull/180.diff","patch_url":"https://github.com/stripe/stripe-node/pull/180.patch"},"body":"The Upcoming Invoice API now supports a ton of cool optional params\r\nto help calculate prorations.\r\n\r\nSince the customer ID is still required, and the subscription id is\r\noptional, the second parameter to the retrieveUpcoming endpoint\r\ncan be an options object or a string (string must be the subscription\r\nid for legacy compatibility).\r\n\r\nFixes #176"},"comment":{"url":"https://api.github.com/repos/stripe/stripe-node/issues/comments/111359176","html_url":"https://github.com/stripe/stripe-node/pull/180#issuecomment-111359176","issue_url":"https://api.github.com/repos/stripe/stripe-node/issues/180","id":111359176,"user":{"login":"michelle","id":928757,"avatar_url":"https://avatars.githubusercontent.com/u/928757?v=3","gravatar_id":"","url":"https://api.github.com/users/michelle","html_url":"https://github.com/michelle","followers_url":"https://api.github.com/users/michelle/followers","following_url":"https://api.github.com/users/michelle/following{/other_user}","gists_url":"https://api.github.com/users/michelle/gists{/gist_id}","starred_url":"https://api.github.com/users/michelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelle/subscriptions","organizations_url":"https://api.github.com/users/michelle/orgs","repos_url":"https://api.github.com/users/michelle/repos","events_url":"https://api.github.com/users/michelle/events{/privacy}","received_events_url":"https://api.github.com/users/michelle/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T04:58:34Z","updated_at":"2015-06-12T04:58:34Z","body":"Thanks for the PR!\r\n\r\n> I do hate the forking on typeOf but its necessary for backwards compatibility.\r\n\r\nYeah, I'm actually pretty conflicted about this, given we've never documented this optional second parameter, and I'd love for us to be more aggressive with deprecating functionality. Doesn't seem worth a major version bump just deprecate this undocumented feature though, so I'll file an issue to deprecate the subscription ID second parameter for the next major version bump.\r\n\r\n\r\n> I went with the separate one since customer id is required and all the other options are optional.\r\n\r\nYes, agreed that this is correct. Options has should only include optional parameters.\r\n\r\n"}}