{"comment":{"url":"https://api.github.com/repos/LostItem/roundware-server/comments/13903335","html_url":"https://github.com/LostItem/roundware-server/commit/bbc76c9f1ef545cc119854b821d2befe3ae765b4#commitcomment-13903335","id":13903335,"user":{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false},"position":105,"line":633,"path":"roundware/rw/models.py","commit_id":"bbc76c9f1ef545cc119854b821d2befe3ae765b4","created_at":"2015-10-21T14:44:57Z","updated_at":"2015-10-21T14:44:57Z","body":"This is fine for now to do a pure linear attenuation, but I'm guessing that this isn't going to sound smooth and good overall. I'll do some testing when it's ready. Oddly, the current volume attenuation code https://github.com/roundware/roundware-server/blob/develop/roundwared/gpsmixer.py#L111 states in the comment that it is linear with need of fixing, yet the actual calculation involves logs and powers which suggests otherwise.\r\n\r\nI can do some research on how best to mimic reality with volume attenuation over distance, but like I say, for now this is totally fine. Ultimately, perhaps we have a few different calculation methods that can be options for each speaker, but that's in the future."}}