{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments/42395395","id":42395395,"diff_hunk":"@@ -15,7 +15,7 @@ include_once 'dosomething_user.theme.inc';\n  */\n function dosomething_user_preprocess_page(&$vars) {\n   $school_api_endpoint = variable_get('dosomething_user_school_api_endpoint', 'http://lofischools.herokuapp.com/search');\n-  $date_format = (dosomething_settings_get_geo_country_code() === 'US') ? 'MM/DD/YYYY' : 'DD/MM/YYYY';","path":"lib/modules/dosomething/dosomething_user/dosomething_user.module","position":4,"original_position":4,"commit_id":"2f8708e13f5640e074d088a325f1f994c8f3d5d2","original_commit_id":"2f8708e13f5640e074d088a325f1f994c8f3d5d2","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"body":"Yeah, this is used to toggle [how client-side validation validates](https://github.com/DoSomething/phoenix/blob/1798036e74112e05af06cf67f71568e8e2707fde/lib/themes/dosomething/paraneue_dosomething/js/validators/auth.js#L87). Should probably keep as is!","created_at":"2015-10-19T16:47:27Z","updated_at":"2015-10-19T16:47:27Z","html_url":"https://github.com/DoSomething/phoenix/pull/5543#discussion_r42395395","pull_request_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments/42395395"},"html":{"href":"https://github.com/DoSomething/phoenix/pull/5543#discussion_r42395395"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543","id":48094133,"html_url":"https://github.com/DoSomething/phoenix/pull/5543","diff_url":"https://github.com/DoSomething/phoenix/pull/5543.diff","patch_url":"https://github.com/DoSomething/phoenix/pull/5543.patch","issue_url":"https://api.github.com/repos/DoSomething/phoenix/issues/5543","number":5543,"state":"open","locked":false,"title":"Updating account creation module to translating missing strings.","user":{"login":"weerd","id":105849,"avatar_url":"https://avatars.githubusercontent.com/u/105849?v=3","gravatar_id":"","url":"https://api.github.com/users/weerd","html_url":"https://github.com/weerd","followers_url":"https://api.github.com/users/weerd/followers","following_url":"https://api.github.com/users/weerd/following{/other_user}","gists_url":"https://api.github.com/users/weerd/gists{/gist_id}","starred_url":"https://api.github.com/users/weerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weerd/subscriptions","organizations_url":"https://api.github.com/users/weerd/orgs","repos_url":"https://api.github.com/users/weerd/repos","events_url":"https://api.github.com/users/weerd/events{/privacy}","received_events_url":"https://api.github.com/users/weerd/received_events","type":"User","site_admin":false},"body":"Refs #5527\r\nRefs #5517\r\n\r\n#### What's this PR do?\r\nThe First Name (and Last Name) fields did not have their labels translated, so that has now been added. Also the format for the date in the placeholder needed to be updated to be wrapped in  as well. \r\n\r\n#### Where should the reviewer start?\r\nDe files boss?! De FILES!\r\n\r\n#### How should this be manually tested?\r\nI will be testing on Thor once this is merged to make sure it is working correctly.\r\n\r\n#### What are the relevant tickets?\r\n#5527\r\n#5517\r\n\r\n---\r\n@angaither \r\n\r\ncc: @sbsmith86 @mikefantini ","created_at":"2015-10-19T16:24:13Z","updated_at":"2015-10-19T16:47:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18bda315a08c1891e7aa0803979cfbb51b663c40","assignee":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543/commits","review_comments_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543/comments","review_comment_url":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/issues/5543/comments","statuses_url":"https://api.github.com/repos/DoSomething/phoenix/statuses/2f8708e13f5640e074d088a325f1f994c8f3d5d2","head":{"label":"weerd:bug-fixing-translateable-strings-01-olé","ref":"bug-fixing-translateable-strings-01-olé","sha":"2f8708e13f5640e074d088a325f1f994c8f3d5d2","user":{"login":"weerd","id":105849,"avatar_url":"https://avatars.githubusercontent.com/u/105849?v=3","gravatar_id":"","url":"https://api.github.com/users/weerd","html_url":"https://github.com/weerd","followers_url":"https://api.github.com/users/weerd/followers","following_url":"https://api.github.com/users/weerd/following{/other_user}","gists_url":"https://api.github.com/users/weerd/gists{/gist_id}","starred_url":"https://api.github.com/users/weerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weerd/subscriptions","organizations_url":"https://api.github.com/users/weerd/orgs","repos_url":"https://api.github.com/users/weerd/repos","events_url":"https://api.github.com/users/weerd/events{/privacy}","received_events_url":"https://api.github.com/users/weerd/received_events","type":"User","site_admin":false},"repo":{"id":26650134,"name":"dosomething","full_name":"weerd/dosomething","owner":{"login":"weerd","id":105849,"avatar_url":"https://avatars.githubusercontent.com/u/105849?v=3","gravatar_id":"","url":"https://api.github.com/users/weerd","html_url":"https://github.com/weerd","followers_url":"https://api.github.com/users/weerd/followers","following_url":"https://api.github.com/users/weerd/following{/other_user}","gists_url":"https://api.github.com/users/weerd/gists{/gist_id}","starred_url":"https://api.github.com/users/weerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weerd/subscriptions","organizations_url":"https://api.github.com/users/weerd/orgs","repos_url":"https://api.github.com/users/weerd/repos","events_url":"https://api.github.com/users/weerd/events{/privacy}","received_events_url":"https://api.github.com/users/weerd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weerd/dosomething","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":true,"url":"https://api.github.com/repos/weerd/dosomething","forks_url":"https://api.github.com/repos/weerd/dosomething/forks","keys_url":"https://api.github.com/repos/weerd/dosomething/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weerd/dosomething/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weerd/dosomething/teams","hooks_url":"https://api.github.com/repos/weerd/dosomething/hooks","issue_events_url":"https://api.github.com/repos/weerd/dosomething/issues/events{/number}","events_url":"https://api.github.com/repos/weerd/dosomething/events","assignees_url":"https://api.github.com/repos/weerd/dosomething/assignees{/user}","branches_url":"https://api.github.com/repos/weerd/dosomething/branches{/branch}","tags_url":"https://api.github.com/repos/weerd/dosomething/tags","blobs_url":"https://api.github.com/repos/weerd/dosomething/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weerd/dosomething/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weerd/dosomething/git/refs{/sha}","trees_url":"https://api.github.com/repos/weerd/dosomething/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weerd/dosomething/statuses/{sha}","languages_url":"https://api.github.com/repos/weerd/dosomething/languages","stargazers_url":"https://api.github.com/repos/weerd/dosomething/stargazers","contributors_url":"https://api.github.com/repos/weerd/dosomething/contributors","subscribers_url":"https://api.github.com/repos/weerd/dosomething/subscribers","subscription_url":"https://api.github.com/repos/weerd/dosomething/subscription","commits_url":"https://api.github.com/repos/weerd/dosomething/commits{/sha}","git_commits_url":"https://api.github.com/repos/weerd/dosomething/git/commits{/sha}","comments_url":"https://api.github.com/repos/weerd/dosomething/comments{/number}","issue_comment_url":"https://api.github.com/repos/weerd/dosomething/issues/comments{/number}","contents_url":"https://api.github.com/repos/weerd/dosomething/contents/{+path}","compare_url":"https://api.github.com/repos/weerd/dosomething/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weerd/dosomething/merges","archive_url":"https://api.github.com/repos/weerd/dosomething/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weerd/dosomething/downloads","issues_url":"https://api.github.com/repos/weerd/dosomething/issues{/number}","pulls_url":"https://api.github.com/repos/weerd/dosomething/pulls{/number}","milestones_url":"https://api.github.com/repos/weerd/dosomething/milestones{/number}","notifications_url":"https://api.github.com/repos/weerd/dosomething/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weerd/dosomething/labels{/name}","releases_url":"https://api.github.com/repos/weerd/dosomething/releases{/id}","created_at":"2014-11-14T17:42:44Z","updated_at":"2015-04-15T20:46:23Z","pushed_at":"2015-10-19T16:17:50Z","git_url":"git://github.com/weerd/dosomething.git","ssh_url":"git@github.com:weerd/dosomething.git","clone_url":"https://github.com/weerd/dosomething.git","svn_url":"https://github.com/weerd/dosomething","homepage":"http://www.dosomething.org/","size":15240,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"3b0e81c833866a287f42671a6eb2bbb9b29b3f3d","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":13592927,"name":"phoenix","full_name":"DoSomething/phoenix","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/phoenix","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":false,"url":"https://api.github.com/repos/DoSomething/phoenix","forks_url":"https://api.github.com/repos/DoSomething/phoenix/forks","keys_url":"https://api.github.com/repos/DoSomething/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/phoenix/teams","hooks_url":"https://api.github.com/repos/DoSomething/phoenix/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/phoenix/events","assignees_url":"https://api.github.com/repos/DoSomething/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/phoenix/tags","blobs_url":"https://api.github.com/repos/DoSomething/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/phoenix/languages","stargazers_url":"https://api.github.com/repos/DoSomething/phoenix/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/phoenix/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/phoenix/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/phoenix/subscription","commits_url":"https://api.github.com/repos/DoSomething/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/phoenix/merges","archive_url":"https://api.github.com/repos/DoSomething/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/phoenix/downloads","issues_url":"https://api.github.com/repos/DoSomething/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/phoenix/releases{/id}","created_at":"2013-10-15T14:50:48Z","updated_at":"2015-07-23T19:32:25Z","pushed_at":"2015-10-19T16:44:33Z","git_url":"git://github.com/DoSomething/phoenix.git","ssh_url":"git@github.com:DoSomething/phoenix.git","clone_url":"https://github.com/DoSomething/phoenix.git","svn_url":"https://github.com/DoSomething/phoenix","homepage":"http://www.dosomething.org/","size":28539,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":308,"forks":19,"open_issues":308,"watchers":25,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543"},"html":{"href":"https://github.com/DoSomething/phoenix/pull/5543"},"issue":{"href":"https://api.github.com/repos/DoSomething/phoenix/issues/5543"},"comments":{"href":"https://api.github.com/repos/DoSomething/phoenix/issues/5543/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/phoenix/pulls/5543/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/phoenix/statuses/2f8708e13f5640e074d088a325f1f994c8f3d5d2"}}}}