{"action":"closed","number":318,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318","id":30143672,"html_url":"https://github.com/puppetlabs/cfacter/pull/318","diff_url":"https://github.com/puppetlabs/cfacter/pull/318.diff","patch_url":"https://github.com/puppetlabs/cfacter/pull/318.patch","issue_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/318","number":318,"state":"closed","locked":false,"title":"(CFACT-231) Resolve processors.isa and hardwareisa in Windows","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"body":"Prior to this commit, the processors.isa and hardwareisa facts were\r\nnot being populated in Windows.\r\n\r\nThis commit adds the necessary logic to query WMI for \"Architecture\"\r\nand transform the returned numerical ID into a string representing the\r\nprocessor type.\r\n\r\nDetails on the translation from ID to processor type can be found here:\r\nhttps://msdn.microsoft.com/en-us/library/aa394373%28v=vs.85%29.aspx","created_at":"2015-02-27T06:01:47Z","updated_at":"2015-02-27T21:22:40Z","closed_at":"2015-02-27T21:22:40Z","merged_at":"2015-02-27T21:22:40Z","merge_commit_sha":"77fd5c4d13c9ab608cee36c315ce07ede1f7058f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/318/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/e7512100a7d6b58349a415e8d482d33843afdcb5","head":{"label":"whopper:CFACT-231/windows-isa","ref":"CFACT-231/windows-isa","sha":"e7512100a7d6b58349a415e8d482d33843afdcb5","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"repo":{"id":21986815,"name":"cfacter","full_name":"whopper/cfacter","owner":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whopper/cfacter","description":"Collect and display system facts from a C++ library.","fork":true,"url":"https://api.github.com/repos/whopper/cfacter","forks_url":"https://api.github.com/repos/whopper/cfacter/forks","keys_url":"https://api.github.com/repos/whopper/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whopper/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whopper/cfacter/teams","hooks_url":"https://api.github.com/repos/whopper/cfacter/hooks","issue_events_url":"https://api.github.com/repos/whopper/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/whopper/cfacter/events","assignees_url":"https://api.github.com/repos/whopper/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/whopper/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/whopper/cfacter/tags","blobs_url":"https://api.github.com/repos/whopper/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whopper/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whopper/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/whopper/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whopper/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/whopper/cfacter/languages","stargazers_url":"https://api.github.com/repos/whopper/cfacter/stargazers","contributors_url":"https://api.github.com/repos/whopper/cfacter/contributors","subscribers_url":"https://api.github.com/repos/whopper/cfacter/subscribers","subscription_url":"https://api.github.com/repos/whopper/cfacter/subscription","commits_url":"https://api.github.com/repos/whopper/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/whopper/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/whopper/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/whopper/cfacter/issues/comments{/number}","contents_url":"https://api.github.com/repos/whopper/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/whopper/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whopper/cfacter/merges","archive_url":"https://api.github.com/repos/whopper/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whopper/cfacter/downloads","issues_url":"https://api.github.com/repos/whopper/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/whopper/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/whopper/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/whopper/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whopper/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/whopper/cfacter/releases{/id}","created_at":"2014-07-18T16:28:05Z","updated_at":"2014-12-29T18:19:18Z","pushed_at":"2015-02-27T07:59:20Z","git_url":"git://github.com/whopper/cfacter.git","ssh_url":"git@github.com:whopper/cfacter.git","clone_url":"https://github.com/whopper/cfacter.git","svn_url":"https://github.com/whopper/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":5899,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"aad82c9f9aa7320edc5e3ec598b6a42cf7195179","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17602228,"name":"cfacter","full_name":"puppetlabs/cfacter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/cfacter","description":"Collect and display system facts from a C++ library.","fork":false,"url":"https://api.github.com/repos/puppetlabs/cfacter","forks_url":"https://api.github.com/repos/puppetlabs/cfacter/forks","keys_url":"https://api.github.com/repos/puppetlabs/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cfacter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cfacter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cfacter/events","assignees_url":"https://api.github.com/repos/puppetlabs/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cfacter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cfacter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cfacter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cfacter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cfacter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cfacter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cfacter/merges","archive_url":"https://api.github.com/repos/puppetlabs/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cfacter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cfacter/releases{/id}","created_at":"2014-03-10T17:48:17Z","updated_at":"2015-02-26T03:19:33Z","pushed_at":"2015-02-27T21:22:40Z","git_url":"git://github.com/puppetlabs/cfacter.git","ssh_url":"git@github.com:puppetlabs/cfacter.git","clone_url":"https://github.com/puppetlabs/cfacter.git","svn_url":"https://github.com/puppetlabs/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":80559,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":3,"forks":31,"open_issues":3,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/318"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/318"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cfacter/statuses/e7512100a7d6b58349a415e8d482d33843afdcb5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"comments":5,"review_comments":3,"commits":1,"additions":50,"deletions":4,"changed_files":2}}