{"action":"created","issue":{"url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/21","labels_url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/21/comments","events_url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/21/events","html_url":"https://github.com/osgi/osgi.enroute.site/pull/21","id":55394473,"number":21,"title":"various corrections, clarifications","user":{"login":"GrantPax","id":5502828,"avatar_url":"https://avatars.githubusercontent.com/u/5502828?v=3","gravatar_id":"","url":"https://api.github.com/users/GrantPax","html_url":"https://github.com/GrantPax","followers_url":"https://api.github.com/users/GrantPax/followers","following_url":"https://api.github.com/users/GrantPax/following{/other_user}","gists_url":"https://api.github.com/users/GrantPax/gists{/gist_id}","starred_url":"https://api.github.com/users/GrantPax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrantPax/subscriptions","organizations_url":"https://api.github.com/users/GrantPax/orgs","repos_url":"https://api.github.com/users/GrantPax/repos","events_url":"https://api.github.com/users/GrantPax/events{/privacy}","received_events_url":"https://api.github.com/users/GrantPax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-25T03:19:05Z","updated_at":"2015-01-26T21:12:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/osgi/osgi.enroute.site/pulls/21","html_url":"https://github.com/osgi/osgi.enroute.site/pull/21","diff_url":"https://github.com/osgi/osgi.enroute.site/pull/21.diff","patch_url":"https://github.com/osgi/osgi.enroute.site/pull/21.patch"},"body":"I tried to keep the commits atomic. I messed up the signatures until the end. If I need to sign something, I will. If this helps to cover everything: Signed-off-by: Grant Pax <grant@fwep.twostewards.com> for all commits in this pull request. As I mention in one commit, I have a feature request into the GitHub for Mac folks."},"comment":{"url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/comments/71539313","html_url":"https://github.com/osgi/osgi.enroute.site/pull/21#issuecomment-71539313","issue_url":"https://api.github.com/repos/osgi/osgi.enroute.site/issues/21","id":71539313,"user":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars.githubusercontent.com/u/277682?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"created_at":"2015-01-26T21:12:51Z","updated_at":"2015-01-26T21:12:51Z","body":"Some problems here. There is a merge commit which should not be here. You should just have your commits ideally rebased on the tip of master in the main repo but the rebasing is not necessary unless the PR wont merge cleanly.\r\n\r\nAlso not all of the commits contain the necessary Signed-off-by comments. Each individual commit message must include it. Putting it in the PR comments is not sufficient as the PR comments are not in the repo as a permanent part of the work.\r\n\r\nPlease amend your commit comments and remove the merge commit."}}