{"action":"created","comment":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/comments/35714742","id":35714742,"diff_hunk":"@@ -35,6 +35,7 @@\n import logging\n import sys\n \n+import rosgraph","path":"tools/rostest/src/rostest/rostest_parent.py","position":4,"original_position":4,"commit_id":"6b67ce940c75866759d86c4f9fc74a9a0f8a36cf","original_commit_id":"6b67ce940c75866759d86c4f9fc74a9a0f8a36cf","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Should this translate to an explicit dependency on `rosgraph`? It doesn't currently depend directly on it:\r\n\r\nhttps://github.com/ros/ros_comm/blob/indigo-devel/tools/rostest/package.xml","created_at":"2015-07-28T23:38:09Z","updated_at":"2015-07-28T23:38:09Z","html_url":"https://github.com/ros/ros_comm/pull/637#discussion_r35714742","pull_request_url":"https://api.github.com/repos/ros/ros_comm/pulls/637","_links":{"self":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/comments/35714742"},"html":{"href":"https://github.com/ros/ros_comm/pull/637#discussion_r35714742"},"pull_request":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/637"}}},"pull_request":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/637","id":39894972,"html_url":"https://github.com/ros/ros_comm/pull/637","diff_url":"https://github.com/ros/ros_comm/pull/637.diff","patch_url":"https://github.com/ros/ros_comm/pull/637.patch","issue_url":"https://api.github.com/repos/ros/ros_comm/issues/637","number":637,"state":"open","locked":false,"title":"Add --local option to rostest. Implements #137","user":{"login":"trainman419","id":103991,"avatar_url":"https://avatars.githubusercontent.com/u/103991?v=3","gravatar_id":"","url":"https://api.github.com/users/trainman419","html_url":"https://github.com/trainman419","followers_url":"https://api.github.com/users/trainman419/followers","following_url":"https://api.github.com/users/trainman419/following{/other_user}","gists_url":"https://api.github.com/users/trainman419/gists{/gist_id}","starred_url":"https://api.github.com/users/trainman419/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainman419/subscriptions","organizations_url":"https://api.github.com/users/trainman419/orgs","repos_url":"https://api.github.com/users/trainman419/repos","events_url":"https://api.github.com/users/trainman419/events{/privacy}","received_events_url":"https://api.github.com/users/trainman419/received_events","type":"User","site_admin":false},"body":"Add an option to rostest which suppresses the behavior of spawning a ROS\r\nmaster, and instead uses the default roslaunch behavior of connecting to\r\nthe ROS master specified in ROS_MASTER_URI, or creating a new ROS\r\nmaster.\r\n\r\nThere is one final question here: with the --local option, the rostest environment is polluted by any parameters that already exist on the running ROS master.\r\n\r\nI think it is reasonable to have an option for rostest to delete all of the existing parameters, so that the test can run with a clean parameter space. Should this option default to being on or off?","created_at":"2015-07-14T08:59:20Z","updated_at":"2015-07-28T23:38:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9bf9f8b7b6b8bab707fd8aa382025cbc4e4e1ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/ros_comm/pulls/637/commits","review_comments_url":"https://api.github.com/repos/ros/ros_comm/pulls/637/comments","review_comment_url":"https://api.github.com/repos/ros/ros_comm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/ros_comm/issues/637/comments","statuses_url":"https://api.github.com/repos/ros/ros_comm/statuses/6b67ce940c75866759d86c4f9fc74a9a0f8a36cf","head":{"label":"trainman419:rostest_local","ref":"rostest_local","sha":"6b67ce940c75866759d86c4f9fc74a9a0f8a36cf","user":{"login":"trainman419","id":103991,"avatar_url":"https://avatars.githubusercontent.com/u/103991?v=3","gravatar_id":"","url":"https://api.github.com/users/trainman419","html_url":"https://github.com/trainman419","followers_url":"https://api.github.com/users/trainman419/followers","following_url":"https://api.github.com/users/trainman419/following{/other_user}","gists_url":"https://api.github.com/users/trainman419/gists{/gist_id}","starred_url":"https://api.github.com/users/trainman419/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainman419/subscriptions","organizations_url":"https://api.github.com/users/trainman419/orgs","repos_url":"https://api.github.com/users/trainman419/repos","events_url":"https://api.github.com/users/trainman419/events{/privacy}","received_events_url":"https://api.github.com/users/trainman419/received_events","type":"User","site_admin":false},"repo":{"id":14135515,"name":"ros_comm","full_name":"trainman419/ros_comm","owner":{"login":"trainman419","id":103991,"avatar_url":"https://avatars.githubusercontent.com/u/103991?v=3","gravatar_id":"","url":"https://api.github.com/users/trainman419","html_url":"https://github.com/trainman419","followers_url":"https://api.github.com/users/trainman419/followers","following_url":"https://api.github.com/users/trainman419/following{/other_user}","gists_url":"https://api.github.com/users/trainman419/gists{/gist_id}","starred_url":"https://api.github.com/users/trainman419/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainman419/subscriptions","organizations_url":"https://api.github.com/users/trainman419/orgs","repos_url":"https://api.github.com/users/trainman419/repos","events_url":"https://api.github.com/users/trainman419/events{/privacy}","received_events_url":"https://api.github.com/users/trainman419/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trainman419/ros_comm","description":"ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).","fork":true,"url":"https://api.github.com/repos/trainman419/ros_comm","forks_url":"https://api.github.com/repos/trainman419/ros_comm/forks","keys_url":"https://api.github.com/repos/trainman419/ros_comm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trainman419/ros_comm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trainman419/ros_comm/teams","hooks_url":"https://api.github.com/repos/trainman419/ros_comm/hooks","issue_events_url":"https://api.github.com/repos/trainman419/ros_comm/issues/events{/number}","events_url":"https://api.github.com/repos/trainman419/ros_comm/events","assignees_url":"https://api.github.com/repos/trainman419/ros_comm/assignees{/user}","branches_url":"https://api.github.com/repos/trainman419/ros_comm/branches{/branch}","tags_url":"https://api.github.com/repos/trainman419/ros_comm/tags","blobs_url":"https://api.github.com/repos/trainman419/ros_comm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trainman419/ros_comm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trainman419/ros_comm/git/refs{/sha}","trees_url":"https://api.github.com/repos/trainman419/ros_comm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trainman419/ros_comm/statuses/{sha}","languages_url":"https://api.github.com/repos/trainman419/ros_comm/languages","stargazers_url":"https://api.github.com/repos/trainman419/ros_comm/stargazers","contributors_url":"https://api.github.com/repos/trainman419/ros_comm/contributors","subscribers_url":"https://api.github.com/repos/trainman419/ros_comm/subscribers","subscription_url":"https://api.github.com/repos/trainman419/ros_comm/subscription","commits_url":"https://api.github.com/repos/trainman419/ros_comm/commits{/sha}","git_commits_url":"https://api.github.com/repos/trainman419/ros_comm/git/commits{/sha}","comments_url":"https://api.github.com/repos/trainman419/ros_comm/comments{/number}","issue_comment_url":"https://api.github.com/repos/trainman419/ros_comm/issues/comments{/number}","contents_url":"https://api.github.com/repos/trainman419/ros_comm/contents/{+path}","compare_url":"https://api.github.com/repos/trainman419/ros_comm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trainman419/ros_comm/merges","archive_url":"https://api.github.com/repos/trainman419/ros_comm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trainman419/ros_comm/downloads","issues_url":"https://api.github.com/repos/trainman419/ros_comm/issues{/number}","pulls_url":"https://api.github.com/repos/trainman419/ros_comm/pulls{/number}","milestones_url":"https://api.github.com/repos/trainman419/ros_comm/milestones{/number}","notifications_url":"https://api.github.com/repos/trainman419/ros_comm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trainman419/ros_comm/labels{/name}","releases_url":"https://api.github.com/repos/trainman419/ros_comm/releases{/id}","created_at":"2013-11-05T08:03:10Z","updated_at":"2014-02-26T02:33:29Z","pushed_at":"2015-07-14T10:01:25Z","git_url":"git://github.com/trainman419/ros_comm.git","ssh_url":"git@github.com:trainman419/ros_comm.git","clone_url":"https://github.com/trainman419/ros_comm.git","svn_url":"https://github.com/trainman419/ros_comm","homepage":"http://www.ros.org/wiki/ros_comm","size":6907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hydro-devel-arm"}},"base":{"label":"ros:indigo-devel","ref":"indigo-devel","sha":"4fadf3188313d5fc1aade7fd071710d6ac2dd675","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":5474834,"name":"ros_comm","full_name":"ros/ros_comm","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/ros_comm","description":"ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).","fork":false,"url":"https://api.github.com/repos/ros/ros_comm","forks_url":"https://api.github.com/repos/ros/ros_comm/forks","keys_url":"https://api.github.com/repos/ros/ros_comm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/ros_comm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/ros_comm/teams","hooks_url":"https://api.github.com/repos/ros/ros_comm/hooks","issue_events_url":"https://api.github.com/repos/ros/ros_comm/issues/events{/number}","events_url":"https://api.github.com/repos/ros/ros_comm/events","assignees_url":"https://api.github.com/repos/ros/ros_comm/assignees{/user}","branches_url":"https://api.github.com/repos/ros/ros_comm/branches{/branch}","tags_url":"https://api.github.com/repos/ros/ros_comm/tags","blobs_url":"https://api.github.com/repos/ros/ros_comm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/ros_comm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/ros_comm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/ros_comm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/ros_comm/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/ros_comm/languages","stargazers_url":"https://api.github.com/repos/ros/ros_comm/stargazers","contributors_url":"https://api.github.com/repos/ros/ros_comm/contributors","subscribers_url":"https://api.github.com/repos/ros/ros_comm/subscribers","subscription_url":"https://api.github.com/repos/ros/ros_comm/subscription","commits_url":"https://api.github.com/repos/ros/ros_comm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/ros_comm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/ros_comm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/ros_comm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/ros_comm/contents/{+path}","compare_url":"https://api.github.com/repos/ros/ros_comm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/ros_comm/merges","archive_url":"https://api.github.com/repos/ros/ros_comm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/ros_comm/downloads","issues_url":"https://api.github.com/repos/ros/ros_comm/issues{/number}","pulls_url":"https://api.github.com/repos/ros/ros_comm/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/ros_comm/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/ros_comm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/ros_comm/labels{/name}","releases_url":"https://api.github.com/repos/ros/ros_comm/releases{/id}","created_at":"2012-08-19T22:26:34Z","updated_at":"2015-07-28T00:09:38Z","pushed_at":"2015-07-24T14:55:11Z","git_url":"git://github.com/ros/ros_comm.git","ssh_url":"git@github.com:ros/ros_comm.git","clone_url":"https://github.com/ros/ros_comm.git","svn_url":"https://github.com/ros/ros_comm","homepage":"http://wiki.ros.org/ros_comm","size":29226,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":153,"forks":163,"open_issues":153,"watchers":58,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/637"},"html":{"href":"https://github.com/ros/ros_comm/pull/637"},"issue":{"href":"https://api.github.com/repos/ros/ros_comm/issues/637"},"comments":{"href":"https://api.github.com/repos/ros/ros_comm/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/ros_comm/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/ros/ros_comm/statuses/6b67ce940c75866759d86c4f9fc74a9a0f8a36cf"}}}}