{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/6273","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/6273/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6273/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/6273/events","html_url":"https://github.com/xbmc/xbmc/pull/6273","id":55459960,"number":6273,"title":"cmake: two fixes for dependencies","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":37,"created_at":"2015-01-26T09:10:08Z","updated_at":"2015-02-01T15:43:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6273","html_url":"https://github.com/xbmc/xbmc/pull/6273","diff_url":"https://github.com/xbmc/xbmc/pull/6273.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6273.patch"},"body":"These two commits are extracted from #6227 and I ran into them while trying to get the PVR addons built as binary addons for android.\r\n\r\nThe first commit re-adds the definition of `DEPENDS_PATH` on all depends-based builds. It was already set for darwin-based builds but not for any others. The whole logic there could probably do with a refactor as all platforms with `$(PREFIX)` set use it for `DEPENDS_PATH` but right now it's split between darwin and the rest. The re-added line has been lost in 61b712b63673f5c54d787aa5d2f92d2f3b21396c which moved this logic to a new file.\r\n\r\nThe second commit adds `${BUILD_ARGS} ` to the arguments passed to cmake for the configuration step of addon dependencies. Without this the buildsystem of the dependencies is missing all kinds of important information but mainly `CMAKE_TOOLCHAIN_FILE` which points to a file containing all the target platform specific information (like which toolchain / compiler to use and where to look for include/library files).\r\n\r\n@wsnipex for review please."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/72369699","html_url":"https://github.com/xbmc/xbmc/pull/6273#issuecomment-72369699","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6273","id":72369699,"user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?v=3","gravatar_id":"","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"created_at":"2015-02-01T15:43:02Z","updated_at":"2015-02-01T15:43:02Z","body":"thats what I was referring to. Seems to fix it."}}