{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16229","labels_url":"https://api.github.com/repos/docker/docker/issues/16229/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16229/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16229/events","html_url":"https://github.com/docker/docker/pull/16229","id":105918426,"number":16229,"title":"Add builtin nodes discovery","user":{"login":"icecrime","id":1564054,"avatar_url":"https://avatars.githubusercontent.com/u/1564054?v=3","gravatar_id":"","url":"https://api.github.com/users/icecrime","html_url":"https://github.com/icecrime","followers_url":"https://api.github.com/users/icecrime/followers","following_url":"https://api.github.com/users/icecrime/following{/other_user}","gists_url":"https://api.github.com/users/icecrime/gists{/gist_id}","starred_url":"https://api.github.com/users/icecrime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icecrime/subscriptions","organizations_url":"https://api.github.com/users/icecrime/orgs","repos_url":"https://api.github.com/users/icecrime/repos","events_url":"https://api.github.com/users/icecrime/events{/privacy}","received_events_url":"https://api.github.com/users/icecrime/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/41","html_url":"https://github.com/docker/docker/milestones/1.9.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/41/labels","id":1211905,"number":41,"title":"1.9.0","description":"","creator":{"login":"dmp42","id":332946,"avatar_url":"https://avatars.githubusercontent.com/u/332946?v=3","gravatar_id":"","url":"https://api.github.com/users/dmp42","html_url":"https://github.com/dmp42","followers_url":"https://api.github.com/users/dmp42/followers","following_url":"https://api.github.com/users/dmp42/following{/other_user}","gists_url":"https://api.github.com/users/dmp42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmp42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmp42/subscriptions","organizations_url":"https://api.github.com/users/dmp42/orgs","repos_url":"https://api.github.com/users/dmp42/repos","events_url":"https://api.github.com/users/dmp42/events{/privacy}","received_events_url":"https://api.github.com/users/dmp42/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":28,"state":"open","created_at":"2015-07-16T20:50:09Z","updated_at":"2015-09-18T21:50:26Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2015-09-10T23:26:14Z","updated_at":"2015-09-19T01:27:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16229","html_url":"https://github.com/docker/docker/pull/16229","diff_url":"https://github.com/docker/docker/pull/16229.diff","patch_url":"https://github.com/docker/docker/pull/16229.patch"},"body":"Use `pkg/discovery` to provide nodes discovery between daemon instances.\r\n\r\nThe functionality is driven by two different command-line flags:\r\n`--discovery-backend` and `--discovery-address`. It can be used in two\r\nways by interested components:\r\n\r\n1. Externally by calling the `/info` API and examining the discovery\r\n   backend. The `pkg/discovery` package can then be used to hit the same\r\n   endpoint and watch for appearing or disappearing nodes. That is the\r\n   method that will for example be used by Swarm.\r\n2. Internally by using the `Daemon.discoveryWatcher` instance. That is\r\n   the method that will for example be used by libnetwork.\r\n\r\nPing @abronan @mavenugo @vieux."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/141606557","html_url":"https://github.com/docker/docker/pull/16229#issuecomment-141606557","issue_url":"https://api.github.com/repos/docker/docker/issues/16229","id":141606557,"user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"created_at":"2015-09-19T01:27:00Z","updated_at":"2015-09-19T01:27:00Z","body":"@ibuildthecloud @calavera shall we take this discussion to another proposal / issue ?\r\nMulti-host networking depends on this PR & I like to unblock this PR to make progress.\r\n\r\n@icecrime libnetwork integration with this PR is done and it works as expected.\r\n\r\nSince this is mostly a package move from swarm discovery to docker and is being used by swarm for some time, I would request to merge this soon.\r\n\r\nLGTM"}}