{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/comments/32579801","id":32579801,"diff_hunk":"@@ -99,6 +103,27 @@ func (c SqlDatabaseClient) CreateDatabase(server string, params DatabaseCreatePa\n \treturn err\n }\n \n+// WaitForDatabaseCreation is a helper method which waits\n+// for the creation of the database on the given server.\n+func (c SqlDatabaseClient) WaitForDatabaseCreation(\n+\tserver, database string,\n+\tcancel chan struct{}) error {\n+\tfor {\n+\t\tselect {\n+\t\tcase <-cancel:\n+\t\t\treturn management.ErrOperationCancelled\n+\t\tcase <-time.After(management.DefaultOperationPollInterval):","path":"management/sql/client.go","position":34,"original_position":34,"commit_id":"b339f3e2104a68f6210020be39b16ea8f52aba14","original_commit_id":"b339f3e2104a68f6210020be39b16ea8f52aba14","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"Now you introduced a delay (30sec) even though maybe the operation was already completed ok the first try :-) Please try to stick to the reference implementation I sent in this case. ","created_at":"2015-06-16T22:44:48Z","updated_at":"2015-06-16T22:44:48Z","html_url":"https://github.com/Azure/azure-sdk-for-go/pull/174#discussion_r32579801","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/comments/32579801"},"html":{"href":"https://github.com/Azure/azure-sdk-for-go/pull/174#discussion_r32579801"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174","id":37844134,"html_url":"https://github.com/Azure/azure-sdk-for-go/pull/174","diff_url":"https://github.com/Azure/azure-sdk-for-go/pull/174.diff","patch_url":"https://github.com/Azure/azure-sdk-for-go/pull/174.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/174","number":174,"state":"open","locked":false,"title":"Added Database Update operation and waiting features.","user":{"login":"aznashwan","id":6192535,"avatar_url":"https://avatars.githubusercontent.com/u/6192535?v=3","gravatar_id":"","url":"https://api.github.com/users/aznashwan","html_url":"https://github.com/aznashwan","followers_url":"https://api.github.com/users/aznashwan/followers","following_url":"https://api.github.com/users/aznashwan/following{/other_user}","gists_url":"https://api.github.com/users/aznashwan/gists{/gist_id}","starred_url":"https://api.github.com/users/aznashwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aznashwan/subscriptions","organizations_url":"https://api.github.com/users/aznashwan/orgs","repos_url":"https://api.github.com/users/aznashwan/repos","events_url":"https://api.github.com/users/aznashwan/events{/privacy}","received_events_url":"https://api.github.com/users/aznashwan/received_events","type":"User","site_admin":false},"body":"Added database update operation.\r\n\r\nAlso added some waiting features on more time-consuming operations, as well as a wait for database creation function.","created_at":"2015-06-16T21:33:21Z","updated_at":"2015-06-16T22:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"044adbfcf18b73789e5f9be4cd318053309a6213","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/174/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/statuses/b339f3e2104a68f6210020be39b16ea8f52aba14","head":{"label":"aznashwan:db-update","ref":"db-update","sha":"b339f3e2104a68f6210020be39b16ea8f52aba14","user":{"login":"aznashwan","id":6192535,"avatar_url":"https://avatars.githubusercontent.com/u/6192535?v=3","gravatar_id":"","url":"https://api.github.com/users/aznashwan","html_url":"https://github.com/aznashwan","followers_url":"https://api.github.com/users/aznashwan/followers","following_url":"https://api.github.com/users/aznashwan/following{/other_user}","gists_url":"https://api.github.com/users/aznashwan/gists{/gist_id}","starred_url":"https://api.github.com/users/aznashwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aznashwan/subscriptions","organizations_url":"https://api.github.com/users/aznashwan/orgs","repos_url":"https://api.github.com/users/aznashwan/repos","events_url":"https://api.github.com/users/aznashwan/events{/privacy}","received_events_url":"https://api.github.com/users/aznashwan/received_events","type":"User","site_admin":false},"repo":{"id":34524599,"name":"azure-sdk-for-go","full_name":"aznashwan/azure-sdk-for-go","owner":{"login":"aznashwan","id":6192535,"avatar_url":"https://avatars.githubusercontent.com/u/6192535?v=3","gravatar_id":"","url":"https://api.github.com/users/aznashwan","html_url":"https://github.com/aznashwan","followers_url":"https://api.github.com/users/aznashwan/followers","following_url":"https://api.github.com/users/aznashwan/following{/other_user}","gists_url":"https://api.github.com/users/aznashwan/gists{/gist_id}","starred_url":"https://api.github.com/users/aznashwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aznashwan/subscriptions","organizations_url":"https://api.github.com/users/aznashwan/orgs","repos_url":"https://api.github.com/users/aznashwan/repos","events_url":"https://api.github.com/users/aznashwan/events{/privacy}","received_events_url":"https://api.github.com/users/aznashwan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aznashwan/azure-sdk-for-go","description":"azure-sdk-for-go","fork":true,"url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go","forks_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/forks","keys_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/teams","hooks_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/hooks","issue_events_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/issues/events{/number}","events_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/events","assignees_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/assignees{/user}","branches_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/branches{/branch}","tags_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/tags","blobs_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/statuses/{sha}","languages_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/languages","stargazers_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/stargazers","contributors_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/contributors","subscribers_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/subscribers","subscription_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/subscription","commits_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/contents/{+path}","compare_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/merges","archive_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/downloads","issues_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/issues{/number}","pulls_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/pulls{/number}","milestones_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/milestones{/number}","notifications_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/labels{/name}","releases_url":"https://api.github.com/repos/aznashwan/azure-sdk-for-go/releases{/id}","created_at":"2015-04-24T14:53:31Z","updated_at":"2015-05-07T20:43:29Z","pushed_at":"2015-06-16T22:39:44Z","git_url":"git://github.com/aznashwan/azure-sdk-for-go.git","ssh_url":"git@github.com:aznashwan/azure-sdk-for-go.git","clone_url":"https://github.com/aznashwan/azure-sdk-for-go.git","svn_url":"https://github.com/aznashwan/azure-sdk-for-go","homepage":null,"size":854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"5c4cfe21137c7f97142dcbbb64d52bb865abfb29","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":22855240,"name":"azure-sdk-for-go","full_name":"Azure/azure-sdk-for-go","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-sdk-for-go","description":"Microsoft Azure SDK for Go","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-go","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/releases{/id}","created_at":"2014-08-11T21:18:43Z","updated_at":"2015-06-05T12:17:53Z","pushed_at":"2015-06-16T22:39:45Z","git_url":"git://github.com/Azure/azure-sdk-for-go.git","ssh_url":"git@github.com:Azure/azure-sdk-for-go.git","clone_url":"https://github.com/Azure/azure-sdk-for-go.git","svn_url":"https://github.com/Azure/azure-sdk-for-go","homepage":"","size":1936,"stargazers_count":58,"watchers_count":58,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":11,"forks":30,"open_issues":11,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174"},"html":{"href":"https://github.com/Azure/azure-sdk-for-go/pull/174"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/174"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-go/statuses/b339f3e2104a68f6210020be39b16ea8f52aba14"}}}}