{"action":"closed","number":553,"pull_request":{"url":"https://api.github.com/repos/remind101/empire/pulls/553","id":38618026,"html_url":"https://github.com/remind101/empire/pull/553","diff_url":"https://github.com/remind101/empire/pull/553.diff","patch_url":"https://github.com/remind101/empire/pull/553.patch","issue_url":"https://api.github.com/repos/remind101/empire/issues/553","number":553,"state":"closed","locked":false,"title":"Runner","user":{"login":"ejholmes","id":95166,"avatar_url":"https://avatars.githubusercontent.com/u/95166?v=3","gravatar_id":"","url":"https://api.github.com/users/ejholmes","html_url":"https://github.com/ejholmes","followers_url":"https://api.github.com/users/ejholmes/followers","following_url":"https://api.github.com/users/ejholmes/following{/other_user}","gists_url":"https://api.github.com/users/ejholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/ejholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejholmes/subscriptions","organizations_url":"https://api.github.com/users/ejholmes/orgs","repos_url":"https://api.github.com/users/ejholmes/repos","events_url":"https://api.github.com/users/ejholmes/events{/privacy}","received_events_url":"https://api.github.com/users/ejholmes/received_events","type":"User","site_admin":false},"body":"This is WIP for https://github.com/remind101/empire/issues/550. Opening it up now for a round of feedback.\r\n\r\nThere are lot of little details that I want to refactor and cleanup, but for the most part, this actually works pretty nicely:\r\n\r\n**Non-Interactive**\r\nhttps://asciinema.org/a/d38flqwpw36aqxep4ltollc8s\r\n\r\n**Interactive**\r\nhttps://asciinema.org/a/5amhjeznqg1fxhl85hliuf6of\r\n\r\n* [x] Refactor to set `EMPIRE_*` environment variables inside the run.\r\n* [x] Return error if `-d` flag is provided (we should consider these as potentially long running and hand them off to ECS to run. Eventually, we should add a Runner implementation for detached runs).\r\n* [x] Handle signals sent by the client.\r\n* [x] Fix occasional bug where stdout doesn't appear.\r\n* [x] Replace \"\\n\" with \"\\r\\n\" in pull output.","created_at":"2015-06-26T05:15:40Z","updated_at":"2015-07-01T00:58:04Z","closed_at":"2015-07-01T00:58:04Z","merged_at":null,"merge_commit_sha":"7bca40f0839ba13315791f42bb333697c2ba6065","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/remind101/empire/pulls/553/commits","review_comments_url":"https://api.github.com/repos/remind101/empire/pulls/553/comments","review_comment_url":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/empire/issues/553/comments","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/34fff7e3fc9bac608b9c601fccb8cb51a272e504","head":{"label":"remind101:runner","ref":"runner","sha":"34fff7e3fc9bac608b9c601fccb8cb51a272e504","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":30091667,"name":"empire","full_name":"remind101/empire","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/remind101/empire","forks_url":"https://api.github.com/repos/remind101/empire/forks","keys_url":"https://api.github.com/repos/remind101/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/empire/teams","hooks_url":"https://api.github.com/repos/remind101/empire/hooks","issue_events_url":"https://api.github.com/repos/remind101/empire/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/empire/events","assignees_url":"https://api.github.com/repos/remind101/empire/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/empire/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/empire/tags","blobs_url":"https://api.github.com/repos/remind101/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/empire/languages","stargazers_url":"https://api.github.com/repos/remind101/empire/stargazers","contributors_url":"https://api.github.com/repos/remind101/empire/contributors","subscribers_url":"https://api.github.com/repos/remind101/empire/subscribers","subscription_url":"https://api.github.com/repos/remind101/empire/subscription","commits_url":"https://api.github.com/repos/remind101/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/empire/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/empire/merges","archive_url":"https://api.github.com/repos/remind101/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/empire/downloads","issues_url":"https://api.github.com/repos/remind101/empire/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/empire/labels{/name}","releases_url":"https://api.github.com/repos/remind101/empire/releases{/id}","created_at":"2015-01-30T21:32:09Z","updated_at":"2015-07-01T00:35:41Z","pushed_at":"2015-07-01T00:56:25Z","git_url":"git://github.com/remind101/empire.git","ssh_url":"git@github.com:remind101/empire.git","clone_url":"https://github.com/remind101/empire.git","svn_url":"https://github.com/remind101/empire","homepage":"","size":17587,"stargazers_count":983,"watchers_count":983,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":983,"default_branch":"master"}},"base":{"label":"remind101:docker-refactor","ref":"docker-refactor","sha":"51fb1f038dcf744b1a219e1fcddd23b53f1c3560","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":30091667,"name":"empire","full_name":"remind101/empire","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/remind101/empire","forks_url":"https://api.github.com/repos/remind101/empire/forks","keys_url":"https://api.github.com/repos/remind101/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/empire/teams","hooks_url":"https://api.github.com/repos/remind101/empire/hooks","issue_events_url":"https://api.github.com/repos/remind101/empire/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/empire/events","assignees_url":"https://api.github.com/repos/remind101/empire/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/empire/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/empire/tags","blobs_url":"https://api.github.com/repos/remind101/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/empire/languages","stargazers_url":"https://api.github.com/repos/remind101/empire/stargazers","contributors_url":"https://api.github.com/repos/remind101/empire/contributors","subscribers_url":"https://api.github.com/repos/remind101/empire/subscribers","subscription_url":"https://api.github.com/repos/remind101/empire/subscription","commits_url":"https://api.github.com/repos/remind101/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/empire/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/empire/merges","archive_url":"https://api.github.com/repos/remind101/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/empire/downloads","issues_url":"https://api.github.com/repos/remind101/empire/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/empire/labels{/name}","releases_url":"https://api.github.com/repos/remind101/empire/releases{/id}","created_at":"2015-01-30T21:32:09Z","updated_at":"2015-07-01T00:35:41Z","pushed_at":"2015-07-01T00:56:25Z","git_url":"git://github.com/remind101/empire.git","ssh_url":"git@github.com:remind101/empire.git","clone_url":"https://github.com/remind101/empire.git","svn_url":"https://github.com/remind101/empire","homepage":"","size":17587,"stargazers_count":983,"watchers_count":983,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/empire/pulls/553"},"html":{"href":"https://github.com/remind101/empire/pull/553"},"issue":{"href":"https://api.github.com/repos/remind101/empire/issues/553"},"comments":{"href":"https://api.github.com/repos/remind101/empire/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/empire/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/empire/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/empire/statuses/34fff7e3fc9bac608b9c601fccb8cb51a272e504"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":16,"commits":26,"additions":586,"deletions":240,"changed_files":32}}