{"action":"created","comment":{"url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/comments/30296346","id":30296346,"diff_hunk":"@@ -0,0 +1,58 @@\n+package org.apache.gearpump.experiments.yarn.master\n+\n+import java.io.File\n+\n+import org.apache.gearpump.experiments.yarn.AppConfig\n+import org.apache.gearpump.experiments.yarn.Constants._\n+import org.apache.gearpump.transport.HostPort\n+import org.apache.gearpump.util.Constants\n+import org.apache.hadoop.yarn.api.ApplicationConstants\n+\n+\n+abstract class ContainerCommand {\n+  val appConfig: AppConfig\n+  val version = appConfig.getEnv(\"version\")","path":"experiments/yarn/src/main/scala/org/apache/gearpump/experiments/yarn/master/ContainerCommand.scala","position":14,"original_position":14,"commit_id":"ebf859e6f3dfd438a6ee868d5326ef0e58fb5434","original_commit_id":"ebf859e6f3dfd438a6ee868d5326ef0e58fb5434","user":{"login":"clockfly","id":2595532,"avatar_url":"https://avatars.githubusercontent.com/u/2595532?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfly","html_url":"https://github.com/clockfly","followers_url":"https://api.github.com/users/clockfly/followers","following_url":"https://api.github.com/users/clockfly/following{/other_user}","gists_url":"https://api.github.com/users/clockfly/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfly/subscriptions","organizations_url":"https://api.github.com/users/clockfly/orgs","repos_url":"https://api.github.com/users/clockfly/repos","events_url":"https://api.github.com/users/clockfly/events{/privacy}","received_events_url":"https://api.github.com/users/clockfly/received_events","type":"User","site_admin":false},"body":"What is the version here represents? Gearpump's version? YARN's version?","created_at":"2015-05-14T03:52:19Z","updated_at":"2015-05-14T03:52:19Z","html_url":"https://github.com/intel-hadoop/gearpump/pull/911#discussion_r30296346","pull_request_url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911","_links":{"self":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/comments/30296346"},"html":{"href":"https://github.com/intel-hadoop/gearpump/pull/911#discussion_r30296346"},"pull_request":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911"}}},"pull_request":{"url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911","id":35092227,"html_url":"https://github.com/intel-hadoop/gearpump/pull/911","diff_url":"https://github.com/intel-hadoop/gearpump/pull/911.diff","patch_url":"https://github.com/intel-hadoop/gearpump/pull/911.patch","issue_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/911","number":911,"state":"open","locked":false,"title":"FIx #661, specs and refactoring. ","user":{"login":"TomaszT","id":9038908,"avatar_url":"https://avatars.githubusercontent.com/u/9038908?v=3","gravatar_id":"","url":"https://api.github.com/users/TomaszT","html_url":"https://github.com/TomaszT","followers_url":"https://api.github.com/users/TomaszT/followers","following_url":"https://api.github.com/users/TomaszT/following{/other_user}","gists_url":"https://api.github.com/users/TomaszT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaszT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaszT/subscriptions","organizations_url":"https://api.github.com/users/TomaszT/orgs","repos_url":"https://api.github.com/users/TomaszT/repos","events_url":"https://api.github.com/users/TomaszT/events{/privacy}","received_events_url":"https://api.github.com/users/TomaszT/received_events","type":"User","site_admin":false},"body":"Hi,\r\nthese are the specs for all but 3 classes from org.apache.gearpump.experiments.yarn package. Classes that are currently missing specs are : \r\n  * org.apache.gearpump.experiments.yarn.client.Client -> Kam is working on that one\r\n  * org.apache.gearpump.experiments.yarn.master.ServiceLauncherActor -> this will be added with #710, because it will be heavily refactored\r\n  * org.apache.gearpump.experiments.yarn.master.ResourceManagerCallbackHandler -> this one is work in progress and also will be influenced by #710.\r\n\r\nRefactoring part is related to adding some factories. There was a few places in AmActor where objects were created and there was no way to do DI.\r\n","created_at":"2015-05-11T01:08:39Z","updated_at":"2015-05-14T03:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e51098c11263e44c43c163bdcdd1e92c4e31c4bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911/commits","review_comments_url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911/comments","review_comment_url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/911/comments","statuses_url":"https://api.github.com/repos/intel-hadoop/gearpump/statuses/ebf859e6f3dfd438a6ee868d5326ef0e58fb5434","head":{"label":"TomaszT:issue_#661","ref":"issue_#661","sha":"ebf859e6f3dfd438a6ee868d5326ef0e58fb5434","user":{"login":"TomaszT","id":9038908,"avatar_url":"https://avatars.githubusercontent.com/u/9038908?v=3","gravatar_id":"","url":"https://api.github.com/users/TomaszT","html_url":"https://github.com/TomaszT","followers_url":"https://api.github.com/users/TomaszT/followers","following_url":"https://api.github.com/users/TomaszT/following{/other_user}","gists_url":"https://api.github.com/users/TomaszT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaszT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaszT/subscriptions","organizations_url":"https://api.github.com/users/TomaszT/orgs","repos_url":"https://api.github.com/users/TomaszT/repos","events_url":"https://api.github.com/users/TomaszT/events{/privacy}","received_events_url":"https://api.github.com/users/TomaszT/received_events","type":"User","site_admin":false},"repo":{"id":31427861,"name":"gearpump","full_name":"TomaszT/gearpump","owner":{"login":"TomaszT","id":9038908,"avatar_url":"https://avatars.githubusercontent.com/u/9038908?v=3","gravatar_id":"","url":"https://api.github.com/users/TomaszT","html_url":"https://github.com/TomaszT","followers_url":"https://api.github.com/users/TomaszT/followers","following_url":"https://api.github.com/users/TomaszT/following{/other_user}","gists_url":"https://api.github.com/users/TomaszT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaszT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaszT/subscriptions","organizations_url":"https://api.github.com/users/TomaszT/orgs","repos_url":"https://api.github.com/users/TomaszT/repos","events_url":"https://api.github.com/users/TomaszT/events{/privacy}","received_events_url":"https://api.github.com/users/TomaszT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomaszT/gearpump","description":"gearpump","fork":true,"url":"https://api.github.com/repos/TomaszT/gearpump","forks_url":"https://api.github.com/repos/TomaszT/gearpump/forks","keys_url":"https://api.github.com/repos/TomaszT/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomaszT/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomaszT/gearpump/teams","hooks_url":"https://api.github.com/repos/TomaszT/gearpump/hooks","issue_events_url":"https://api.github.com/repos/TomaszT/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/TomaszT/gearpump/events","assignees_url":"https://api.github.com/repos/TomaszT/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/TomaszT/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/TomaszT/gearpump/tags","blobs_url":"https://api.github.com/repos/TomaszT/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomaszT/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomaszT/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomaszT/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomaszT/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/TomaszT/gearpump/languages","stargazers_url":"https://api.github.com/repos/TomaszT/gearpump/stargazers","contributors_url":"https://api.github.com/repos/TomaszT/gearpump/contributors","subscribers_url":"https://api.github.com/repos/TomaszT/gearpump/subscribers","subscription_url":"https://api.github.com/repos/TomaszT/gearpump/subscription","commits_url":"https://api.github.com/repos/TomaszT/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomaszT/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomaszT/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomaszT/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomaszT/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/TomaszT/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomaszT/gearpump/merges","archive_url":"https://api.github.com/repos/TomaszT/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomaszT/gearpump/downloads","issues_url":"https://api.github.com/repos/TomaszT/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/TomaszT/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/TomaszT/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/TomaszT/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomaszT/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/TomaszT/gearpump/releases{/id}","created_at":"2015-02-27T16:18:52Z","updated_at":"2015-05-06T17:06:40Z","pushed_at":"2015-05-13T22:34:54Z","git_url":"git://github.com/TomaszT/gearpump.git","ssh_url":"git@github.com:TomaszT/gearpump.git","clone_url":"https://github.com/TomaszT/gearpump.git","svn_url":"https://github.com/TomaszT/gearpump","homepage":"http://gearpump.io","size":8144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"intel-hadoop:master","ref":"master","sha":"16f72591aac9d36a8719324933e69e769de51d1a","user":{"login":"intel-hadoop","id":1839373,"avatar_url":"https://avatars.githubusercontent.com/u/1839373?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-hadoop","html_url":"https://github.com/intel-hadoop","followers_url":"https://api.github.com/users/intel-hadoop/followers","following_url":"https://api.github.com/users/intel-hadoop/following{/other_user}","gists_url":"https://api.github.com/users/intel-hadoop/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-hadoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-hadoop/subscriptions","organizations_url":"https://api.github.com/users/intel-hadoop/orgs","repos_url":"https://api.github.com/users/intel-hadoop/repos","events_url":"https://api.github.com/users/intel-hadoop/events{/privacy}","received_events_url":"https://api.github.com/users/intel-hadoop/received_events","type":"Organization","site_admin":false},"repo":{"id":22139167,"name":"gearpump","full_name":"intel-hadoop/gearpump","owner":{"login":"intel-hadoop","id":1839373,"avatar_url":"https://avatars.githubusercontent.com/u/1839373?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-hadoop","html_url":"https://github.com/intel-hadoop","followers_url":"https://api.github.com/users/intel-hadoop/followers","following_url":"https://api.github.com/users/intel-hadoop/following{/other_user}","gists_url":"https://api.github.com/users/intel-hadoop/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-hadoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-hadoop/subscriptions","organizations_url":"https://api.github.com/users/intel-hadoop/orgs","repos_url":"https://api.github.com/users/intel-hadoop/repos","events_url":"https://api.github.com/users/intel-hadoop/events{/privacy}","received_events_url":"https://api.github.com/users/intel-hadoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-hadoop/gearpump","description":"Lightweight real-time big data streaming engine","fork":false,"url":"https://api.github.com/repos/intel-hadoop/gearpump","forks_url":"https://api.github.com/repos/intel-hadoop/gearpump/forks","keys_url":"https://api.github.com/repos/intel-hadoop/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-hadoop/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-hadoop/gearpump/teams","hooks_url":"https://api.github.com/repos/intel-hadoop/gearpump/hooks","issue_events_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/intel-hadoop/gearpump/events","assignees_url":"https://api.github.com/repos/intel-hadoop/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/intel-hadoop/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/intel-hadoop/gearpump/tags","blobs_url":"https://api.github.com/repos/intel-hadoop/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-hadoop/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-hadoop/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-hadoop/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-hadoop/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-hadoop/gearpump/languages","stargazers_url":"https://api.github.com/repos/intel-hadoop/gearpump/stargazers","contributors_url":"https://api.github.com/repos/intel-hadoop/gearpump/contributors","subscribers_url":"https://api.github.com/repos/intel-hadoop/gearpump/subscribers","subscription_url":"https://api.github.com/repos/intel-hadoop/gearpump/subscription","commits_url":"https://api.github.com/repos/intel-hadoop/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-hadoop/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-hadoop/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-hadoop/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/intel-hadoop/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-hadoop/gearpump/merges","archive_url":"https://api.github.com/repos/intel-hadoop/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-hadoop/gearpump/downloads","issues_url":"https://api.github.com/repos/intel-hadoop/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/intel-hadoop/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-hadoop/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-hadoop/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-hadoop/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/intel-hadoop/gearpump/releases{/id}","created_at":"2014-07-23T08:55:26Z","updated_at":"2015-05-09T10:25:58Z","pushed_at":"2015-05-14T03:26:06Z","git_url":"git://github.com/intel-hadoop/gearpump.git","ssh_url":"git@github.com:intel-hadoop/gearpump.git","clone_url":"https://github.com/intel-hadoop/gearpump.git","svn_url":"https://github.com/intel-hadoop/gearpump","homepage":"http://gearpump.io","size":17362,"stargazers_count":260,"watchers_count":260,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":76,"forks":51,"open_issues":76,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911"},"html":{"href":"https://github.com/intel-hadoop/gearpump/pull/911"},"issue":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/issues/911"},"comments":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/intel-hadoop/gearpump/statuses/ebf859e6f3dfd438a6ee868d5326ef0e58fb5434"}}}}