{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/36465901","id":36465901,"diff_hunk":"@@ -52,13 +52,27 @@\n       $(TargetsTriggeredByCompilation);FindPartialFacadeContractReference;FillPartialFacade\n     </TargetsTriggeredByCompilation>\n   </PropertyGroup>\n+  \n+  <!-- If a reference assembly project exists for the partial facade, prefer that over the package  -->\n+  <Target Name=\"FindPartialFacadeProjectReference\" Condition=\"'$(IsPartialFacadeAssembly)' == 'true'\" BeforeTargets=\"AssignProjectConfiguration\">\n+    <PropertyGroup>\n+      <_referenceAssemblyProjectRelativeToRoot>$([System.IO.Path]::Combine('ref', '$(APIVersion)', '$(AssemblyName).csproj'))</_referenceAssemblyProjectRelativeToRoot>\n+      <_referenceAssemblyProject>$([System.IO.Path]::Combine($([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), $(_referenceAssemblyProjectRelativeToRoot))), $(_referenceAssemblyProjectRelativeToRoot)))</_referenceAssemblyProject>\n+    </PropertyGroup>\n+    <ItemGroup>\n+      <ProjectReference Include=\"$(_referenceAssemblyProject)\" Condition=\"'$(_referenceAssemblyProject)' != ''\">","path":"src/Microsoft.DotNet.Build.Tasks/Targets/partialfacades.targets","position":12,"original_position":12,"commit_id":"04727841dd2e235eedbe6c2aa096df262cef2a49","original_commit_id":"04727841dd2e235eedbe6c2aa096df262cef2a49","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Should the condition be \"Exists\"","created_at":"2015-08-06T21:08:16Z","updated_at":"2015-08-06T21:08:16Z","html_url":"https://github.com/dotnet/buildtools/pull/224#discussion_r36465901","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/36465901"},"html":{"href":"https://github.com/dotnet/buildtools/pull/224#discussion_r36465901"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/224","id":41820421,"html_url":"https://github.com/dotnet/buildtools/pull/224","diff_url":"https://github.com/dotnet/buildtools/pull/224.diff","patch_url":"https://github.com/dotnet/buildtools/pull/224.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/224","number":224,"state":"open","locked":false,"title":"Add support for reference assemblies","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"body":"This change adds support to the targets for building reference assemblies.\r\nReference asseblies shall be located in ref\\<major>.<minor>\\AssemblyName.csproj\r\nas a convention.\r\nPartial facade targets will now prefer reference assemblies over packages, if they exist.\r\nReference assemblies will be built to a ref\\<major>.<minor> folder under the\r\nassembly's output directory.\r\n\r\n/cc @weshaggard @mellinoe ","created_at":"2015-08-06T18:40:57Z","updated_at":"2015-08-06T21:08:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"688a0d94bb91380620ff7ce7d42973b39e51c13e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/224/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/224/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/224/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/04727841dd2e235eedbe6c2aa096df262cef2a49","head":{"label":"ericstj:ericstj/refAssm","ref":"ericstj/refAssm","sha":"04727841dd2e235eedbe6c2aa096df262cef2a49","user":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"repo":{"id":32707044,"name":"buildtools","full_name":"ericstj/buildtools","owner":{"login":"ericstj","id":8918108,"avatar_url":"https://avatars.githubusercontent.com/u/8918108?v=3","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericstj/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/ericstj/buildtools","forks_url":"https://api.github.com/repos/ericstj/buildtools/forks","keys_url":"https://api.github.com/repos/ericstj/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericstj/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericstj/buildtools/teams","hooks_url":"https://api.github.com/repos/ericstj/buildtools/hooks","issue_events_url":"https://api.github.com/repos/ericstj/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/ericstj/buildtools/events","assignees_url":"https://api.github.com/repos/ericstj/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/ericstj/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/ericstj/buildtools/tags","blobs_url":"https://api.github.com/repos/ericstj/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericstj/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericstj/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericstj/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericstj/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/ericstj/buildtools/languages","stargazers_url":"https://api.github.com/repos/ericstj/buildtools/stargazers","contributors_url":"https://api.github.com/repos/ericstj/buildtools/contributors","subscribers_url":"https://api.github.com/repos/ericstj/buildtools/subscribers","subscription_url":"https://api.github.com/repos/ericstj/buildtools/subscription","commits_url":"https://api.github.com/repos/ericstj/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericstj/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericstj/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericstj/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericstj/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/ericstj/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericstj/buildtools/merges","archive_url":"https://api.github.com/repos/ericstj/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericstj/buildtools/downloads","issues_url":"https://api.github.com/repos/ericstj/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/ericstj/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/ericstj/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/ericstj/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericstj/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/ericstj/buildtools/releases{/id}","created_at":"2015-03-23T02:32:50Z","updated_at":"2015-05-04T20:40:50Z","pushed_at":"2015-08-06T18:39:53Z","git_url":"git://github.com/ericstj/buildtools.git","ssh_url":"git@github.com:ericstj/buildtools.git","clone_url":"https://github.com/ericstj/buildtools.git","svn_url":"https://github.com/ericstj/buildtools","homepage":"","size":870,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"47b8dadff7a43bf1f9026824b2c8c211c465ca3b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","created_at":"2014-11-06T23:43:05Z","updated_at":"2015-08-01T19:59:03Z","pushed_at":"2015-08-06T20:43:40Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":2466,"stargazers_count":363,"watchers_count":363,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":18,"forks":155,"open_issues":18,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/224"},"html":{"href":"https://github.com/dotnet/buildtools/pull/224"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/224"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/04727841dd2e235eedbe6c2aa096df262cef2a49"}}}}