{"action":"created","comment":{"url":"https://api.github.com/repos/dominictarr/split/pulls/comments/23891893","id":23891893,"diff_hunk":"@@ -77,9 +80,58 @@ exports ['split() takes mapper function'] = function (test) {\n       })\n   }\n   a.writable = true\n-  \n+\n   fs.createReadStream(readme, {flags: 'r'}).pipe(cs)\n-  cs.pipe(a) \n-  \n+  cs.pipe(a)\n+\n }\n ","path":"test/split.asynct.js","position":55,"original_position":55,"commit_id":"cefd735750212988960cb9b56210fcfabae020b7","original_commit_id":"cefd735750212988960cb9b56210fcfabae020b7","user":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars.githubusercontent.com/u/640279?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"body":"my changes start here (above is just whitespace trim)","created_at":"2015-01-31T20:48:22Z","updated_at":"2015-01-31T20:48:22Z","html_url":"https://github.com/dominictarr/split/pull/14#discussion_r23891893","pull_request_url":"https://api.github.com/repos/dominictarr/split/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/dominictarr/split/pulls/comments/23891893"},"html":{"href":"https://github.com/dominictarr/split/pull/14#discussion_r23891893"},"pull_request":{"href":"https://api.github.com/repos/dominictarr/split/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/dominictarr/split/pulls/14","id":28420459,"html_url":"https://github.com/dominictarr/split/pull/14","diff_url":"https://github.com/dominictarr/split/pull/14.diff","patch_url":"https://github.com/dominictarr/split/pull/14.patch","issue_url":"https://api.github.com/repos/dominictarr/split/issues/14","number":14,"state":"open","locked":false,"title":"Fix splitting empty string chunks","user":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars.githubusercontent.com/u/640279?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"body":"I noticed when using `es.replace` to remove whitespace using multiple RegExps, that if a split resulted in empty string chunks 'undefined' was being inserted into the stream.\r\nI will PR a test case and split-version-bump in event-stream for `es.replace` shortly.","created_at":"2015-01-31T20:35:04Z","updated_at":"2015-01-31T20:48:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"987e18c19ffb4c01713030ae6b73eb5d8645ae5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dominictarr/split/pulls/14/commits","review_comments_url":"https://api.github.com/repos/dominictarr/split/pulls/14/comments","review_comment_url":"https://api.github.com/repos/dominictarr/split/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dominictarr/split/issues/14/comments","statuses_url":"https://api.github.com/repos/dominictarr/split/statuses/cefd735750212988960cb9b56210fcfabae020b7","head":{"label":"tjmehta:fix-split-empty-strink-chunks","ref":"fix-split-empty-strink-chunks","sha":"cefd735750212988960cb9b56210fcfabae020b7","user":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars.githubusercontent.com/u/640279?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"repo":{"id":30102936,"name":"split","full_name":"tjmehta/split","owner":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars.githubusercontent.com/u/640279?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjmehta/split","description":null,"fork":true,"url":"https://api.github.com/repos/tjmehta/split","forks_url":"https://api.github.com/repos/tjmehta/split/forks","keys_url":"https://api.github.com/repos/tjmehta/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjmehta/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjmehta/split/teams","hooks_url":"https://api.github.com/repos/tjmehta/split/hooks","issue_events_url":"https://api.github.com/repos/tjmehta/split/issues/events{/number}","events_url":"https://api.github.com/repos/tjmehta/split/events","assignees_url":"https://api.github.com/repos/tjmehta/split/assignees{/user}","branches_url":"https://api.github.com/repos/tjmehta/split/branches{/branch}","tags_url":"https://api.github.com/repos/tjmehta/split/tags","blobs_url":"https://api.github.com/repos/tjmehta/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjmehta/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjmehta/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjmehta/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjmehta/split/statuses/{sha}","languages_url":"https://api.github.com/repos/tjmehta/split/languages","stargazers_url":"https://api.github.com/repos/tjmehta/split/stargazers","contributors_url":"https://api.github.com/repos/tjmehta/split/contributors","subscribers_url":"https://api.github.com/repos/tjmehta/split/subscribers","subscription_url":"https://api.github.com/repos/tjmehta/split/subscription","commits_url":"https://api.github.com/repos/tjmehta/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjmehta/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjmehta/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjmehta/split/issues/comments/{number}","contents_url":"https://api.github.com/repos/tjmehta/split/contents/{+path}","compare_url":"https://api.github.com/repos/tjmehta/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjmehta/split/merges","archive_url":"https://api.github.com/repos/tjmehta/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjmehta/split/downloads","issues_url":"https://api.github.com/repos/tjmehta/split/issues{/number}","pulls_url":"https://api.github.com/repos/tjmehta/split/pulls{/number}","milestones_url":"https://api.github.com/repos/tjmehta/split/milestones{/number}","notifications_url":"https://api.github.com/repos/tjmehta/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjmehta/split/labels{/name}","releases_url":"https://api.github.com/repos/tjmehta/split/releases{/id}","created_at":"2015-01-31T05:08:24Z","updated_at":"2015-01-31T05:08:24Z","pushed_at":"2015-01-31T20:47:44Z","git_url":"git://github.com/tjmehta/split.git","ssh_url":"git@github.com:tjmehta/split.git","clone_url":"https://github.com/tjmehta/split.git","svn_url":"https://github.com/tjmehta/split","homepage":null,"size":193,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dominictarr:master","ref":"master","sha":"d2ae5e25453c89181c7e53527f08eef416c5fdba","user":{"login":"dominictarr","id":259374,"avatar_url":"https://avatars.githubusercontent.com/u/259374?v=3","gravatar_id":"","url":"https://api.github.com/users/dominictarr","html_url":"https://github.com/dominictarr","followers_url":"https://api.github.com/users/dominictarr/followers","following_url":"https://api.github.com/users/dominictarr/following{/other_user}","gists_url":"https://api.github.com/users/dominictarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dominictarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominictarr/subscriptions","organizations_url":"https://api.github.com/users/dominictarr/orgs","repos_url":"https://api.github.com/users/dominictarr/repos","events_url":"https://api.github.com/users/dominictarr/events{/privacy}","received_events_url":"https://api.github.com/users/dominictarr/received_events","type":"User","site_admin":false},"repo":{"id":5615862,"name":"split","full_name":"dominictarr/split","owner":{"login":"dominictarr","id":259374,"avatar_url":"https://avatars.githubusercontent.com/u/259374?v=3","gravatar_id":"","url":"https://api.github.com/users/dominictarr","html_url":"https://github.com/dominictarr","followers_url":"https://api.github.com/users/dominictarr/followers","following_url":"https://api.github.com/users/dominictarr/following{/other_user}","gists_url":"https://api.github.com/users/dominictarr/gists{/gist_id}","starred_url":"https://api.github.com/users/dominictarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominictarr/subscriptions","organizations_url":"https://api.github.com/users/dominictarr/orgs","repos_url":"https://api.github.com/users/dominictarr/repos","events_url":"https://api.github.com/users/dominictarr/events{/privacy}","received_events_url":"https://api.github.com/users/dominictarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dominictarr/split","description":null,"fork":false,"url":"https://api.github.com/repos/dominictarr/split","forks_url":"https://api.github.com/repos/dominictarr/split/forks","keys_url":"https://api.github.com/repos/dominictarr/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dominictarr/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dominictarr/split/teams","hooks_url":"https://api.github.com/repos/dominictarr/split/hooks","issue_events_url":"https://api.github.com/repos/dominictarr/split/issues/events{/number}","events_url":"https://api.github.com/repos/dominictarr/split/events","assignees_url":"https://api.github.com/repos/dominictarr/split/assignees{/user}","branches_url":"https://api.github.com/repos/dominictarr/split/branches{/branch}","tags_url":"https://api.github.com/repos/dominictarr/split/tags","blobs_url":"https://api.github.com/repos/dominictarr/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dominictarr/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dominictarr/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/dominictarr/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dominictarr/split/statuses/{sha}","languages_url":"https://api.github.com/repos/dominictarr/split/languages","stargazers_url":"https://api.github.com/repos/dominictarr/split/stargazers","contributors_url":"https://api.github.com/repos/dominictarr/split/contributors","subscribers_url":"https://api.github.com/repos/dominictarr/split/subscribers","subscription_url":"https://api.github.com/repos/dominictarr/split/subscription","commits_url":"https://api.github.com/repos/dominictarr/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/dominictarr/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/dominictarr/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/dominictarr/split/issues/comments/{number}","contents_url":"https://api.github.com/repos/dominictarr/split/contents/{+path}","compare_url":"https://api.github.com/repos/dominictarr/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dominictarr/split/merges","archive_url":"https://api.github.com/repos/dominictarr/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dominictarr/split/downloads","issues_url":"https://api.github.com/repos/dominictarr/split/issues{/number}","pulls_url":"https://api.github.com/repos/dominictarr/split/pulls{/number}","milestones_url":"https://api.github.com/repos/dominictarr/split/milestones{/number}","notifications_url":"https://api.github.com/repos/dominictarr/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dominictarr/split/labels{/name}","releases_url":"https://api.github.com/repos/dominictarr/split/releases{/id}","created_at":"2012-08-30T14:20:09Z","updated_at":"2015-01-31T05:00:55Z","pushed_at":"2014-12-02T14:05:48Z","git_url":"git://github.com/dominictarr/split.git","ssh_url":"git@github.com:dominictarr/split.git","clone_url":"https://github.com/dominictarr/split.git","svn_url":"https://github.com/dominictarr/split","homepage":null,"size":345,"stargazers_count":144,"watchers_count":144,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dominictarr/split/pulls/14"},"html":{"href":"https://github.com/dominictarr/split/pull/14"},"issue":{"href":"https://api.github.com/repos/dominictarr/split/issues/14"},"comments":{"href":"https://api.github.com/repos/dominictarr/split/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/dominictarr/split/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/dominictarr/split/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dominictarr/split/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/dominictarr/split/statuses/cefd735750212988960cb9b56210fcfabae020b7"}}}}