{"action":"created","comment":{"url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/comments/45980065","id":45980065,"diff_hunk":"@@ -0,0 +1,20 @@\n+import channels from '../constants'\n+\n+export default function authenticated(observable) {","path":"src/status/authenticated.js","position":3,"original_position":3,"commit_id":"4faab6ee3a951e6e24b026a6ced5da3f8838b7d5","original_commit_id":"4faab6ee3a951e6e24b026a6ced5da3f8838b7d5","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"body":"authenticated is a bit of a stretch since this is a plaintext protocol :wink:\r\n\r\nThis is more like connected or some other synonym.","created_at":"2015-11-26T13:53:37Z","updated_at":"2015-11-26T13:53:37Z","html_url":"https://github.com/rgbkrk/pipboylib/pull/31#discussion_r45980065","pull_request_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/comments/45980065"},"html":{"href":"https://github.com/rgbkrk/pipboylib/pull/31#discussion_r45980065"},"pull_request":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31","id":51903957,"html_url":"https://github.com/rgbkrk/pipboylib/pull/31","diff_url":"https://github.com/rgbkrk/pipboylib/pull/31.diff","patch_url":"https://github.com/rgbkrk/pipboylib/pull/31.patch","issue_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/31","number":31,"state":"open","locked":false,"title":"Refactor project to be divided into pure helper functions","user":{"login":"philplckthun","id":2041385,"avatar_url":"https://avatars.githubusercontent.com/u/2041385?v=3","gravatar_id":"","url":"https://api.github.com/users/philplckthun","html_url":"https://github.com/philplckthun","followers_url":"https://api.github.com/users/philplckthun/followers","following_url":"https://api.github.com/users/philplckthun/following{/other_user}","gists_url":"https://api.github.com/users/philplckthun/gists{/gist_id}","starred_url":"https://api.github.com/users/philplckthun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philplckthun/subscriptions","organizations_url":"https://api.github.com/users/philplckthun/orgs","repos_url":"https://api.github.com/users/philplckthun/repos","events_url":"https://api.github.com/users/philplckthun/events{/privacy}","received_events_url":"https://api.github.com/users/philplckthun/received_events","type":"User","site_admin":false},"body":"This is an extreme measurement, I guess, so some explanation:\r\n\r\nAs it is the library is trying to solve a lot of problems at the same time, e.g.: parsing the msgpack-like binary data, parsing the packet structure, storing the database, establishing a connection, etc.\r\n\r\nThese operations are at the moment non-atomically mixed in multiple exports. I think we should split them to separately working pure functions, which are easily testable and quickly explained.\r\n\r\nThis PR proposes the pure function structure, but doesn't yet add documentation and examples.","created_at":"2015-11-26T11:55:20Z","updated_at":"2015-11-26T13:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fe3db17d8d417d2397b24e88c7a1ff4562a2234","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31/commits","review_comments_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31/comments","review_comment_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/31/comments","statuses_url":"https://api.github.com/repos/rgbkrk/pipboylib/statuses/4faab6ee3a951e6e24b026a6ced5da3f8838b7d5","head":{"label":"rgbkrk:pure","ref":"pure","sha":"4faab6ee3a951e6e24b026a6ced5da3f8838b7d5","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"repo":{"id":46424129,"name":"pipboylib","full_name":"rgbkrk/pipboylib","owner":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgbkrk/pipboylib","description":":thumbsup: Companion pip boy library for Fallout 4","fork":false,"url":"https://api.github.com/repos/rgbkrk/pipboylib","forks_url":"https://api.github.com/repos/rgbkrk/pipboylib/forks","keys_url":"https://api.github.com/repos/rgbkrk/pipboylib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgbkrk/pipboylib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgbkrk/pipboylib/teams","hooks_url":"https://api.github.com/repos/rgbkrk/pipboylib/hooks","issue_events_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/events{/number}","events_url":"https://api.github.com/repos/rgbkrk/pipboylib/events","assignees_url":"https://api.github.com/repos/rgbkrk/pipboylib/assignees{/user}","branches_url":"https://api.github.com/repos/rgbkrk/pipboylib/branches{/branch}","tags_url":"https://api.github.com/repos/rgbkrk/pipboylib/tags","blobs_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgbkrk/pipboylib/statuses/{sha}","languages_url":"https://api.github.com/repos/rgbkrk/pipboylib/languages","stargazers_url":"https://api.github.com/repos/rgbkrk/pipboylib/stargazers","contributors_url":"https://api.github.com/repos/rgbkrk/pipboylib/contributors","subscribers_url":"https://api.github.com/repos/rgbkrk/pipboylib/subscribers","subscription_url":"https://api.github.com/repos/rgbkrk/pipboylib/subscription","commits_url":"https://api.github.com/repos/rgbkrk/pipboylib/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgbkrk/pipboylib/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgbkrk/pipboylib/contents/{+path}","compare_url":"https://api.github.com/repos/rgbkrk/pipboylib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgbkrk/pipboylib/merges","archive_url":"https://api.github.com/repos/rgbkrk/pipboylib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgbkrk/pipboylib/downloads","issues_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues{/number}","pulls_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls{/number}","milestones_url":"https://api.github.com/repos/rgbkrk/pipboylib/milestones{/number}","notifications_url":"https://api.github.com/repos/rgbkrk/pipboylib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgbkrk/pipboylib/labels{/name}","releases_url":"https://api.github.com/repos/rgbkrk/pipboylib/releases{/id}","created_at":"2015-11-18T14:30:53Z","updated_at":"2015-11-26T05:14:47Z","pushed_at":"2015-11-26T11:55:20Z","git_url":"git://github.com/rgbkrk/pipboylib.git","ssh_url":"git@github.com:rgbkrk/pipboylib.git","clone_url":"https://github.com/rgbkrk/pipboylib.git","svn_url":"https://github.com/rgbkrk/pipboylib","homepage":"","size":85,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":83,"default_branch":"master"}},"base":{"label":"rgbkrk:master","ref":"master","sha":"d04bbedd415c8634012807b818e6ae3e2f4a5424","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"repo":{"id":46424129,"name":"pipboylib","full_name":"rgbkrk/pipboylib","owner":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgbkrk/pipboylib","description":":thumbsup: Companion pip boy library for Fallout 4","fork":false,"url":"https://api.github.com/repos/rgbkrk/pipboylib","forks_url":"https://api.github.com/repos/rgbkrk/pipboylib/forks","keys_url":"https://api.github.com/repos/rgbkrk/pipboylib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgbkrk/pipboylib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgbkrk/pipboylib/teams","hooks_url":"https://api.github.com/repos/rgbkrk/pipboylib/hooks","issue_events_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/events{/number}","events_url":"https://api.github.com/repos/rgbkrk/pipboylib/events","assignees_url":"https://api.github.com/repos/rgbkrk/pipboylib/assignees{/user}","branches_url":"https://api.github.com/repos/rgbkrk/pipboylib/branches{/branch}","tags_url":"https://api.github.com/repos/rgbkrk/pipboylib/tags","blobs_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgbkrk/pipboylib/statuses/{sha}","languages_url":"https://api.github.com/repos/rgbkrk/pipboylib/languages","stargazers_url":"https://api.github.com/repos/rgbkrk/pipboylib/stargazers","contributors_url":"https://api.github.com/repos/rgbkrk/pipboylib/contributors","subscribers_url":"https://api.github.com/repos/rgbkrk/pipboylib/subscribers","subscription_url":"https://api.github.com/repos/rgbkrk/pipboylib/subscription","commits_url":"https://api.github.com/repos/rgbkrk/pipboylib/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgbkrk/pipboylib/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgbkrk/pipboylib/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgbkrk/pipboylib/contents/{+path}","compare_url":"https://api.github.com/repos/rgbkrk/pipboylib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgbkrk/pipboylib/merges","archive_url":"https://api.github.com/repos/rgbkrk/pipboylib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgbkrk/pipboylib/downloads","issues_url":"https://api.github.com/repos/rgbkrk/pipboylib/issues{/number}","pulls_url":"https://api.github.com/repos/rgbkrk/pipboylib/pulls{/number}","milestones_url":"https://api.github.com/repos/rgbkrk/pipboylib/milestones{/number}","notifications_url":"https://api.github.com/repos/rgbkrk/pipboylib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgbkrk/pipboylib/labels{/name}","releases_url":"https://api.github.com/repos/rgbkrk/pipboylib/releases{/id}","created_at":"2015-11-18T14:30:53Z","updated_at":"2015-11-26T05:14:47Z","pushed_at":"2015-11-26T11:55:20Z","git_url":"git://github.com/rgbkrk/pipboylib.git","ssh_url":"git@github.com:rgbkrk/pipboylib.git","clone_url":"https://github.com/rgbkrk/pipboylib.git","svn_url":"https://github.com/rgbkrk/pipboylib","homepage":"","size":85,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31"},"html":{"href":"https://github.com/rgbkrk/pipboylib/pull/31"},"issue":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/issues/31"},"comments":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/rgbkrk/pipboylib/statuses/4faab6ee3a951e6e24b026a6ced5da3f8838b7d5"}}}}