{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1600","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1600/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1600/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1600/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1600","id":61129821,"number":1600,"title":"JKN Advance algorithm implementation","user":{"login":"alexborro","id":5216531,"avatar_url":"https://avatars.githubusercontent.com/u/5216531?v=3","gravatar_id":"","url":"https://api.github.com/users/alexborro","html_url":"https://github.com/alexborro","followers_url":"https://api.github.com/users/alexborro/followers","following_url":"https://api.github.com/users/alexborro/following{/other_user}","gists_url":"https://api.github.com/users/alexborro/gists{/gist_id}","starred_url":"https://api.github.com/users/alexborro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexborro/subscriptions","organizations_url":"https://api.github.com/users/alexborro/orgs","repos_url":"https://api.github.com/users/alexborro/repos","events_url":"https://api.github.com/users/alexborro/events{/privacy}","received_events_url":"https://api.github.com/users/alexborro/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs%20more%20work","name":"Needs more work","color":"fbca04"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/On%20Hold%20During%20Bugfix","name":"On Hold During Bugfix","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-03-13T16:42:52Z","updated_at":"2015-07-03T22:40:39Z","closed_at":"2015-06-29T11:11:23Z","body":"I think we need to fix the JKN Advance implementation.\r\nI'm following the sailfish forum and folks over there says it has a huge impact on print quality.\r\n\r\n@bkubicek , are you able to help us on that??\r\n\r\nCheers.\r\n\r\nAlex."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/118435471","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1600#issuecomment-118435471","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1600","id":118435471,"user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T22:40:39Z","updated_at":"2015-07-03T22:40:39Z","body":"Here are some highlights of Sailfish's implementation…\r\n\r\n\r\nhttps://github.com/jetty840/Sailfish-MightyBoardFirmware/blob/1852182effceadf9ded8c59c4ff4da0e1c94c64e/firmware/src/MightyBoard/Motherboard/Steppers.cc\r\n\r\n- advanceK and advanceK2 defined and used in plan_init()\r\n\r\n\r\nhttps://github.com/jetty840/Sailfish-MightyBoardFirmware/blob/1852182effceadf9ded8c59c4ff4da0e1c94c64e/firmware/src/MightyBoard/Motherboard/StepperAccel.cc\r\n\r\n- Define enum and vars needed for JKN\r\n- Define st_extruder_interrupt()\r\n- Setup the st_extruder_interrupt rate in st_init()\r\n- In st_deprime_enable(bool) set lastAdvanceDeprime[e] = 0 if LEAD_DE_PRIME is being used\r\n- Handle deprime behavior in setup_next_block()\r\n- Set advance_state = ADVANCE_STATE_ACCEL in setup_next_block()\r\n- Also test e_steps before calling stepperAxisSetHardwareEnabledToMatch(axesEnabled) in st_interrupt()\r\n- Handle advance for accelerated blocks in the steps loop in st_interrupt()\r\n- Handle deceleration phase in st_interrupt(), updating advance_pressure_relax_accumulator and advance_state\r\n- Handle nominal phase in st_interrupt(), updating advance_state\r\n\r\n\r\nhttps://github.com/jetty840/Sailfish-MightyBoardFirmware/blob/1852182effceadf9ded8c59c4ff4da0e1c94c64e/firmware/src/MightyBoard/Motherboard/StepperAccelPlanner.cc\r\n\r\n- Define final_speed_step_rate\r\n- Do extra processing in calculate_trapezoid_for_block(), set extra fields in current block instance\r\n- Set k, k2 in plan_init()\r\n- Test whether to use advance_lead in plan_buffer_line(), set true or false\r\n"}}