{"action":"created","comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/25595944","id":25595944,"diff_hunk":"@@ -37,23 +50,29 @@ public ModuleManager getModuleManager() {\n \tabstract public void init();\n \n \t/**\n-\t * Called by the modulemanager to run the module. This is runned in an own\n-\t * Thread.\n-\t */\n-\tabstract public void run();\n-\n-\t/**\n \t * stops the background thread. Overwrite this if you want to do cleanup work.\n \t * Don't forget to call super.\n \t * This should NOT be called from the background thread itself!\n \t */\n \tpublic synchronized void stopModule() {\n-\t\tinterrupt();\n-\t\twhile(this.isAlive()) {\n-\t\t\ttry {\n-\t\t\t\twait();\n-\t\t\t} catch (InterruptedException e) { }\n-\t\t}\n+\t\tthis.stop();\n \t\tgetModuleManager().getModules().remove(this);\n \t}\n+\n+\tprotected void registerModelObject(Class<? extends ModelObject> cls) {\n+\t\tmodelObjects.add(cls);\n+\t}\n+\n+\t@Override\n+\tpublic void onEvent(String event, MessageInfo info, Object... data) {","path":"src/main/java/de/qabel/core/module/Module.java","position":62,"original_position":62,"commit_id":"381403c5f53f08fc134916d3f9599c4363582f43","original_commit_id":"381403c5f53f08fc134916d3f9599c4363582f43","user":{"login":"Gottox","id":1056976,"avatar_url":"https://avatars.githubusercontent.com/u/1056976?v=3","gravatar_id":"","url":"https://api.github.com/users/Gottox","html_url":"https://github.com/Gottox","followers_url":"https://api.github.com/users/Gottox/followers","following_url":"https://api.github.com/users/Gottox/following{/other_user}","gists_url":"https://api.github.com/users/Gottox/gists{/gist_id}","starred_url":"https://api.github.com/users/Gottox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gottox/subscriptions","organizations_url":"https://api.github.com/users/Gottox/orgs","repos_url":"https://api.github.com/users/Gottox/repos","events_url":"https://api.github.com/users/Gottox/events{/privacy}","received_events_url":"https://api.github.com/users/Gottox/received_events","type":"User","site_admin":false},"body":"these arguments are dropped. the send method only takes one argument.","created_at":"2015-03-02T12:53:20Z","updated_at":"2015-03-02T12:53:20Z","html_url":"https://github.com/Qabel/qabel-core/pull/272#discussion_r25595944","pull_request_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/25595944"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/272#discussion_r25595944"},"pull_request":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/272","id":28469935,"html_url":"https://github.com/Qabel/qabel-core/pull/272","diff_url":"https://github.com/Qabel/qabel-core/pull/272.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/272.patch","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/272","number":272,"state":"open","locked":false,"title":"Replace DropController by DropActor, an implementation of the Ackack EventActor.","user":{"login":"Gottox","id":1056976,"avatar_url":"https://avatars.githubusercontent.com/u/1056976?v=3","gravatar_id":"","url":"https://api.github.com/users/Gottox","html_url":"https://github.com/Gottox","followers_url":"https://api.github.com/users/Gottox/followers","following_url":"https://api.github.com/users/Gottox/following{/other_user}","gists_url":"https://api.github.com/users/Gottox/gists{/gist_id}","starred_url":"https://api.github.com/users/Gottox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gottox/subscriptions","organizations_url":"https://api.github.com/users/Gottox/orgs","repos_url":"https://api.github.com/users/Gottox/repos","events_url":"https://api.github.com/users/Gottox/events{/privacy}","received_events_url":"https://api.github.com/users/Gottox/received_events","type":"User","site_admin":false},"body":"Open ToDos:\r\n\r\n* [x] Tests\r\n* [x] Updating Javadoc see https://github.com/Qabel/qabel-core/pull/272/files#r24000488\r\n* [x] Adapt changes to other Repositories (qabel-desktop, qabel-helloworld-module)\r\n* [ ] Update Javadoc see https://github.com/Qabel/qabel-core/pull/272/files#r25595552","created_at":"2015-02-02T14:02:25Z","updated_at":"2015-03-02T12:53:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/272/commits","review_comments_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/272/comments","review_comment_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/272/comments","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/381403c5f53f08fc134916d3f9599c4363582f43","head":{"label":"Gottox:ackack","ref":"ackack","sha":"381403c5f53f08fc134916d3f9599c4363582f43","user":{"login":"Gottox","id":1056976,"avatar_url":"https://avatars.githubusercontent.com/u/1056976?v=3","gravatar_id":"","url":"https://api.github.com/users/Gottox","html_url":"https://github.com/Gottox","followers_url":"https://api.github.com/users/Gottox/followers","following_url":"https://api.github.com/users/Gottox/following{/other_user}","gists_url":"https://api.github.com/users/Gottox/gists{/gist_id}","starred_url":"https://api.github.com/users/Gottox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gottox/subscriptions","organizations_url":"https://api.github.com/users/Gottox/orgs","repos_url":"https://api.github.com/users/Gottox/repos","events_url":"https://api.github.com/users/Gottox/events{/privacy}","received_events_url":"https://api.github.com/users/Gottox/received_events","type":"User","site_admin":false},"repo":{"id":24884150,"name":"qabel-core","full_name":"Gottox/qabel-core","owner":{"login":"Gottox","id":1056976,"avatar_url":"https://avatars.githubusercontent.com/u/1056976?v=3","gravatar_id":"","url":"https://api.github.com/users/Gottox","html_url":"https://github.com/Gottox","followers_url":"https://api.github.com/users/Gottox/followers","following_url":"https://api.github.com/users/Gottox/following{/other_user}","gists_url":"https://api.github.com/users/Gottox/gists{/gist_id}","starred_url":"https://api.github.com/users/Gottox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gottox/subscriptions","organizations_url":"https://api.github.com/users/Gottox/orgs","repos_url":"https://api.github.com/users/Gottox/repos","events_url":"https://api.github.com/users/Gottox/events{/privacy}","received_events_url":"https://api.github.com/users/Gottox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gottox/qabel-core","description":"Implementation of Qabel-Core in Java","fork":true,"url":"https://api.github.com/repos/Gottox/qabel-core","forks_url":"https://api.github.com/repos/Gottox/qabel-core/forks","keys_url":"https://api.github.com/repos/Gottox/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gottox/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gottox/qabel-core/teams","hooks_url":"https://api.github.com/repos/Gottox/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/Gottox/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/Gottox/qabel-core/events","assignees_url":"https://api.github.com/repos/Gottox/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/Gottox/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/Gottox/qabel-core/tags","blobs_url":"https://api.github.com/repos/Gottox/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gottox/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gottox/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gottox/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gottox/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Gottox/qabel-core/languages","stargazers_url":"https://api.github.com/repos/Gottox/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/Gottox/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/Gottox/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/Gottox/qabel-core/subscription","commits_url":"https://api.github.com/repos/Gottox/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gottox/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gottox/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gottox/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gottox/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/Gottox/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gottox/qabel-core/merges","archive_url":"https://api.github.com/repos/Gottox/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gottox/qabel-core/downloads","issues_url":"https://api.github.com/repos/Gottox/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/Gottox/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Gottox/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Gottox/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gottox/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/Gottox/qabel-core/releases{/id}","created_at":"2014-10-07T09:26:04Z","updated_at":"2014-10-08T06:55:29Z","pushed_at":"2015-03-02T11:00:25Z","git_url":"git://github.com/Gottox/qabel-core.git","ssh_url":"git@github.com:Gottox/qabel-core.git","clone_url":"https://github.com/Gottox/qabel-core.git","svn_url":"https://github.com/Gottox/qabel-core","homepage":null,"size":3406,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qabel:master","ref":"master","sha":"7c59084ed1919580bf4d7fa4475e8ada44c268e3","user":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"repo":{"id":22873447,"name":"qabel-core","full_name":"Qabel/qabel-core","owner":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qabel/qabel-core","description":"Implementation of Qabel-Core in Java","fork":false,"url":"https://api.github.com/repos/Qabel/qabel-core","forks_url":"https://api.github.com/repos/Qabel/qabel-core/forks","keys_url":"https://api.github.com/repos/Qabel/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qabel/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qabel/qabel-core/teams","hooks_url":"https://api.github.com/repos/Qabel/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/Qabel/qabel-core/events","assignees_url":"https://api.github.com/repos/Qabel/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/Qabel/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/Qabel/qabel-core/tags","blobs_url":"https://api.github.com/repos/Qabel/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qabel/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qabel/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qabel/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Qabel/qabel-core/languages","stargazers_url":"https://api.github.com/repos/Qabel/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/Qabel/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/Qabel/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/Qabel/qabel-core/subscription","commits_url":"https://api.github.com/repos/Qabel/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qabel/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qabel/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/Qabel/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qabel/qabel-core/merges","archive_url":"https://api.github.com/repos/Qabel/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qabel/qabel-core/downloads","issues_url":"https://api.github.com/repos/Qabel/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/Qabel/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Qabel/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Qabel/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qabel/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/Qabel/qabel-core/releases{/id}","created_at":"2014-08-12T10:25:10Z","updated_at":"2015-03-02T11:44:41Z","pushed_at":"2015-03-02T11:44:41Z","git_url":"git://github.com/Qabel/qabel-core.git","ssh_url":"git@github.com:Qabel/qabel-core.git","clone_url":"https://github.com/Qabel/qabel-core.git","svn_url":"https://github.com/Qabel/qabel-core","homepage":null,"size":6206,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/272"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/272"},"issue":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/272"},"comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/Qabel/qabel-core/statuses/381403c5f53f08fc134916d3f9599c4363582f43"}}}}