{"action":"created","comment":{"url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/comments/26752938","id":26752938,"diff_hunk":"@@ -118,163 +192,230 @@ def test_should_one_date_for_each_month(self, low, high, expected_results):\n                                 datetime(2014, 12, 31, 23, 59, 59, 0)]),\n     ])\n     def test_periods(self, low, high, period, expected_results):\n-        results = list(date.get_intersecting_periods(low, high, period=period))\n-        self.assertEquals(expected_results, results)\n+        self.given_period_low(low)\n+        self.given_period_high(high)\n+        self.given_period(period)\n+        self.given_expected_results(expected_results)\n+        self.when_intersecting_period_calculated()\n+        self.then_should_one_date_for_each_month()\n+\n+    def test_should_reject_easily_mistaken_dateutil_arguments(self):\n+        periods = [\n+            'years',\n+            'months',\n+            'days',\n+            'hours',\n+            'minutes',\n+            'seconds',\n+            'microseconds',\n+            'some_period',\n+        ]\n+        self.given_period_low(datetime(2014, 6, 15))\n+        self.given_period(datetime(2014, 6, 25))","path":"tests/test_date.py","position":213,"original_position":213,"commit_id":"6c14fe7732932560c1b2740baf41ab14b6f590f9","original_commit_id":"6c14fe7732932560c1b2740baf41ab14b6f590f9","user":{"login":"Allactaga","id":2597566,"avatar_url":"https://avatars.githubusercontent.com/u/2597566?v=3","gravatar_id":"","url":"https://api.github.com/users/Allactaga","html_url":"https://github.com/Allactaga","followers_url":"https://api.github.com/users/Allactaga/followers","following_url":"https://api.github.com/users/Allactaga/following{/other_user}","gists_url":"https://api.github.com/users/Allactaga/gists{/gist_id}","starred_url":"https://api.github.com/users/Allactaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Allactaga/subscriptions","organizations_url":"https://api.github.com/users/Allactaga/orgs","repos_url":"https://api.github.com/users/Allactaga/repos","events_url":"https://api.github.com/users/Allactaga/events{/privacy}","received_events_url":"https://api.github.com/users/Allactaga/received_events","type":"User","site_admin":false},"body":"No you are not. Please take another look at parameters' names for `get_intersecting_periods` function.","created_at":"2015-03-19T13:30:28Z","updated_at":"2015-03-19T13:30:28Z","html_url":"https://github.com/scrapinghub/dateparser/pull/56#discussion_r26752938","pull_request_url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/comments/26752938"},"html":{"href":"https://github.com/scrapinghub/dateparser/pull/56#discussion_r26752938"},"pull_request":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56","id":29283182,"html_url":"https://github.com/scrapinghub/dateparser/pull/56","diff_url":"https://github.com/scrapinghub/dateparser/pull/56.diff","patch_url":"https://github.com/scrapinghub/dateparser/pull/56.patch","issue_url":"https://api.github.com/repos/scrapinghub/dateparser/issues/56","number":56,"state":"open","locked":false,"title":"Implements issue #31","user":{"login":"tsrdatatech","id":4684832,"avatar_url":"https://avatars.githubusercontent.com/u/4684832?v=3","gravatar_id":"","url":"https://api.github.com/users/tsrdatatech","html_url":"https://github.com/tsrdatatech","followers_url":"https://api.github.com/users/tsrdatatech/followers","following_url":"https://api.github.com/users/tsrdatatech/following{/other_user}","gists_url":"https://api.github.com/users/tsrdatatech/gists{/gist_id}","starred_url":"https://api.github.com/users/tsrdatatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsrdatatech/subscriptions","organizations_url":"https://api.github.com/users/tsrdatatech/orgs","repos_url":"https://api.github.com/users/tsrdatatech/repos","events_url":"https://api.github.com/users/tsrdatatech/events{/privacy}","received_events_url":"https://api.github.com/users/tsrdatatech/received_events","type":"User","site_admin":false},"body":"Transformed code to a given-when-then approach.","created_at":"2015-02-13T17:33:39Z","updated_at":"2015-03-19T13:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae862691c0851a37d2ea0990e44ba00dea7565c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/dateparser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/dateparser/issues/56/comments","statuses_url":"https://api.github.com/repos/scrapinghub/dateparser/statuses/6c14fe7732932560c1b2740baf41ab14b6f590f9","head":{"label":"tsrdatatech:uniform_unit_tests","ref":"uniform_unit_tests","sha":"6c14fe7732932560c1b2740baf41ab14b6f590f9","user":{"login":"tsrdatatech","id":4684832,"avatar_url":"https://avatars.githubusercontent.com/u/4684832?v=3","gravatar_id":"","url":"https://api.github.com/users/tsrdatatech","html_url":"https://github.com/tsrdatatech","followers_url":"https://api.github.com/users/tsrdatatech/followers","following_url":"https://api.github.com/users/tsrdatatech/following{/other_user}","gists_url":"https://api.github.com/users/tsrdatatech/gists{/gist_id}","starred_url":"https://api.github.com/users/tsrdatatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsrdatatech/subscriptions","organizations_url":"https://api.github.com/users/tsrdatatech/orgs","repos_url":"https://api.github.com/users/tsrdatatech/repos","events_url":"https://api.github.com/users/tsrdatatech/events{/privacy}","received_events_url":"https://api.github.com/users/tsrdatatech/received_events","type":"User","site_admin":false},"repo":{"id":30245365,"name":"dateparser","full_name":"tsrdatatech/dateparser","owner":{"login":"tsrdatatech","id":4684832,"avatar_url":"https://avatars.githubusercontent.com/u/4684832?v=3","gravatar_id":"","url":"https://api.github.com/users/tsrdatatech","html_url":"https://github.com/tsrdatatech","followers_url":"https://api.github.com/users/tsrdatatech/followers","following_url":"https://api.github.com/users/tsrdatatech/following{/other_user}","gists_url":"https://api.github.com/users/tsrdatatech/gists{/gist_id}","starred_url":"https://api.github.com/users/tsrdatatech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsrdatatech/subscriptions","organizations_url":"https://api.github.com/users/tsrdatatech/orgs","repos_url":"https://api.github.com/users/tsrdatatech/repos","events_url":"https://api.github.com/users/tsrdatatech/events{/privacy}","received_events_url":"https://api.github.com/users/tsrdatatech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsrdatatech/dateparser","description":"python parser for human readable dates","fork":true,"url":"https://api.github.com/repos/tsrdatatech/dateparser","forks_url":"https://api.github.com/repos/tsrdatatech/dateparser/forks","keys_url":"https://api.github.com/repos/tsrdatatech/dateparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsrdatatech/dateparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsrdatatech/dateparser/teams","hooks_url":"https://api.github.com/repos/tsrdatatech/dateparser/hooks","issue_events_url":"https://api.github.com/repos/tsrdatatech/dateparser/issues/events{/number}","events_url":"https://api.github.com/repos/tsrdatatech/dateparser/events","assignees_url":"https://api.github.com/repos/tsrdatatech/dateparser/assignees{/user}","branches_url":"https://api.github.com/repos/tsrdatatech/dateparser/branches{/branch}","tags_url":"https://api.github.com/repos/tsrdatatech/dateparser/tags","blobs_url":"https://api.github.com/repos/tsrdatatech/dateparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsrdatatech/dateparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsrdatatech/dateparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsrdatatech/dateparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsrdatatech/dateparser/statuses/{sha}","languages_url":"https://api.github.com/repos/tsrdatatech/dateparser/languages","stargazers_url":"https://api.github.com/repos/tsrdatatech/dateparser/stargazers","contributors_url":"https://api.github.com/repos/tsrdatatech/dateparser/contributors","subscribers_url":"https://api.github.com/repos/tsrdatatech/dateparser/subscribers","subscription_url":"https://api.github.com/repos/tsrdatatech/dateparser/subscription","commits_url":"https://api.github.com/repos/tsrdatatech/dateparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsrdatatech/dateparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsrdatatech/dateparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsrdatatech/dateparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsrdatatech/dateparser/contents/{+path}","compare_url":"https://api.github.com/repos/tsrdatatech/dateparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsrdatatech/dateparser/merges","archive_url":"https://api.github.com/repos/tsrdatatech/dateparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsrdatatech/dateparser/downloads","issues_url":"https://api.github.com/repos/tsrdatatech/dateparser/issues{/number}","pulls_url":"https://api.github.com/repos/tsrdatatech/dateparser/pulls{/number}","milestones_url":"https://api.github.com/repos/tsrdatatech/dateparser/milestones{/number}","notifications_url":"https://api.github.com/repos/tsrdatatech/dateparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsrdatatech/dateparser/labels{/name}","releases_url":"https://api.github.com/repos/tsrdatatech/dateparser/releases{/id}","created_at":"2015-02-03T14:00:45Z","updated_at":"2015-02-03T14:00:46Z","pushed_at":"2015-03-17T14:20:33Z","git_url":"git://github.com/tsrdatatech/dateparser.git","ssh_url":"git@github.com:tsrdatatech/dateparser.git","clone_url":"https://github.com/tsrdatatech/dateparser.git","svn_url":"https://github.com/tsrdatatech/dateparser","homepage":"","size":429,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"7f60e017eaa99dea7c96f82a118ec4716c4c04d8","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":27086567,"name":"dateparser","full_name":"scrapinghub/dateparser","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/dateparser","description":"python parser for human readable dates","fork":false,"url":"https://api.github.com/repos/scrapinghub/dateparser","forks_url":"https://api.github.com/repos/scrapinghub/dateparser/forks","keys_url":"https://api.github.com/repos/scrapinghub/dateparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/dateparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/dateparser/teams","hooks_url":"https://api.github.com/repos/scrapinghub/dateparser/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/dateparser/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/dateparser/events","assignees_url":"https://api.github.com/repos/scrapinghub/dateparser/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/dateparser/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/dateparser/tags","blobs_url":"https://api.github.com/repos/scrapinghub/dateparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/dateparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/dateparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/dateparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/dateparser/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/dateparser/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/dateparser/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/dateparser/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/dateparser/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/dateparser/subscription","commits_url":"https://api.github.com/repos/scrapinghub/dateparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/dateparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/dateparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/dateparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/dateparser/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/dateparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/dateparser/merges","archive_url":"https://api.github.com/repos/scrapinghub/dateparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/dateparser/downloads","issues_url":"https://api.github.com/repos/scrapinghub/dateparser/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/dateparser/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/dateparser/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/dateparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/dateparser/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/dateparser/releases{/id}","created_at":"2014-11-24T17:30:12Z","updated_at":"2015-03-17T08:50:38Z","pushed_at":"2015-03-11T21:15:29Z","git_url":"git://github.com/scrapinghub/dateparser.git","ssh_url":"git@github.com:scrapinghub/dateparser.git","clone_url":"https://github.com/scrapinghub/dateparser.git","svn_url":"https://github.com/scrapinghub/dateparser","homepage":"","size":1582,"stargazers_count":340,"watchers_count":340,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":16,"forks":27,"open_issues":16,"watchers":340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56"},"html":{"href":"https://github.com/scrapinghub/dateparser/pull/56"},"issue":{"href":"https://api.github.com/repos/scrapinghub/dateparser/issues/56"},"comments":{"href":"https://api.github.com/repos/scrapinghub/dateparser/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/dateparser/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/dateparser/statuses/6c14fe7732932560c1b2740baf41ab14b6f590f9"}}}}