{"action":"created","comment":{"url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/comments/36786101","id":36786101,"diff_hunk":"@@ -41,6 +41,19 @@\n  * Test case for {@link MulticolorLayout}.\n  * @author Yegor Bugayenko (yegor@teamed.io)\n  * @version $Id$\n+ * @todo #54:30min Create an integration test for testing if MulticolorLayout\n+ *  will disable text coloring when an application is run with\n+ *  `-Dcom.jcabi.log.coloring=false`.\n+ *  ...\n+ *  Intergration testing is required because this can't be done in a unit test:\n+ *  ...\n+ *  - We can't just pass a parameter to `MulticolorLayout` that determines if\n+ *  the layout should color its output, because Log4J requires\n+ *  EnhancedPatternLayout to have a 0-arguments constructor.\n+ *  - We can't disable coloring with something like\n+ *  `MulticolorLayout#setColoring(boolean)`, too, (that would be unit-testable)\n+ *  because Log4J won't know how to call that.\n+ *  - `System.getProperty(String)` is not mockable for obvious reasons.","path":"src/test/java/com/jcabi/log/MulticolorLayoutTest.java","position":16,"original_position":16,"commit_id":"287f16e44c00cb62a004d7d295169bd80b4c8641","original_commit_id":"287f16e44c00cb62a004d7d295169bd80b4c8641","user":{"login":"dmzaytsev","id":9972909,"avatar_url":"https://avatars.githubusercontent.com/u/9972909?v=3","gravatar_id":"","url":"https://api.github.com/users/dmzaytsev","html_url":"https://github.com/dmzaytsev","followers_url":"https://api.github.com/users/dmzaytsev/followers","following_url":"https://api.github.com/users/dmzaytsev/following{/other_user}","gists_url":"https://api.github.com/users/dmzaytsev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmzaytsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmzaytsev/subscriptions","organizations_url":"https://api.github.com/users/dmzaytsev/orgs","repos_url":"https://api.github.com/users/dmzaytsev/repos","events_url":"https://api.github.com/users/dmzaytsev/events{/privacy}","received_events_url":"https://api.github.com/users/dmzaytsev/received_events","type":"User","site_admin":false},"body":"@Suseika are you sure? we are really run tests multithreaded?\r\n","created_at":"2015-08-11T19:13:31Z","updated_at":"2015-08-11T19:13:31Z","html_url":"https://github.com/jcabi/jcabi-log/pull/61#discussion_r36786101","pull_request_url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/comments/36786101"},"html":{"href":"https://github.com/jcabi/jcabi-log/pull/61#discussion_r36786101"},"pull_request":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61","id":42124162,"html_url":"https://github.com/jcabi/jcabi-log/pull/61","diff_url":"https://github.com/jcabi/jcabi-log/pull/61.diff","patch_url":"https://github.com/jcabi/jcabi-log/pull/61.patch","issue_url":"https://api.github.com/repos/jcabi/jcabi-log/issues/61","number":61,"state":"open","locked":false,"title":"Implement disabling text coloring","user":{"login":"Suseika","id":4467948,"avatar_url":"https://avatars.githubusercontent.com/u/4467948?v=3","gravatar_id":"","url":"https://api.github.com/users/Suseika","html_url":"https://github.com/Suseika","followers_url":"https://api.github.com/users/Suseika/followers","following_url":"https://api.github.com/users/Suseika/following{/other_user}","gists_url":"https://api.github.com/users/Suseika/gists{/gist_id}","starred_url":"https://api.github.com/users/Suseika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Suseika/subscriptions","organizations_url":"https://api.github.com/users/Suseika/orgs","repos_url":"https://api.github.com/users/Suseika/repos","events_url":"https://api.github.com/users/Suseika/events{/privacy}","received_events_url":"https://api.github.com/users/Suseika/received_events","type":"User","site_admin":false},"body":"When logs are required not for a terminal, coloring gets in the way:\r\n\r\n    [0;37mINFOm] ...\r\n\r\nbecause color coding makes sense only in a terminal's output.\r\n\r\nThis is alleviated in this PR with the introduction of `-Dcom.jcabi.log.coloring` system property. When it is set to `\"false\"`, `MulticolorLayout` won't insert color coding to the text it outputs.\r\n\r\nUnfortunately, I couldn't unit test it (details are in a `@todo`) for `MulticolorLayoutTest`, I suggest integration testing for this feature.\r\n\r\nFor #54 ","created_at":"2015-08-11T12:41:57Z","updated_at":"2015-08-11T19:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dbac83074079839bb652049995573fe229be6b8","assignee":{"login":"dmzaytsev","id":9972909,"avatar_url":"https://avatars.githubusercontent.com/u/9972909?v=3","gravatar_id":"","url":"https://api.github.com/users/dmzaytsev","html_url":"https://github.com/dmzaytsev","followers_url":"https://api.github.com/users/dmzaytsev/followers","following_url":"https://api.github.com/users/dmzaytsev/following{/other_user}","gists_url":"https://api.github.com/users/dmzaytsev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmzaytsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmzaytsev/subscriptions","organizations_url":"https://api.github.com/users/dmzaytsev/orgs","repos_url":"https://api.github.com/users/dmzaytsev/repos","events_url":"https://api.github.com/users/dmzaytsev/events{/privacy}","received_events_url":"https://api.github.com/users/dmzaytsev/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61/commits","review_comments_url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61/comments","review_comment_url":"https://api.github.com/repos/jcabi/jcabi-log/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcabi/jcabi-log/issues/61/comments","statuses_url":"https://api.github.com/repos/jcabi/jcabi-log/statuses/287f16e44c00cb62a004d7d295169bd80b4c8641","head":{"label":"Suseika:54","ref":"54","sha":"287f16e44c00cb62a004d7d295169bd80b4c8641","user":{"login":"Suseika","id":4467948,"avatar_url":"https://avatars.githubusercontent.com/u/4467948?v=3","gravatar_id":"","url":"https://api.github.com/users/Suseika","html_url":"https://github.com/Suseika","followers_url":"https://api.github.com/users/Suseika/followers","following_url":"https://api.github.com/users/Suseika/following{/other_user}","gists_url":"https://api.github.com/users/Suseika/gists{/gist_id}","starred_url":"https://api.github.com/users/Suseika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Suseika/subscriptions","organizations_url":"https://api.github.com/users/Suseika/orgs","repos_url":"https://api.github.com/users/Suseika/repos","events_url":"https://api.github.com/users/Suseika/events{/privacy}","received_events_url":"https://api.github.com/users/Suseika/received_events","type":"User","site_admin":false},"repo":{"id":37721689,"name":"jcabi-log","full_name":"Suseika/jcabi-log","owner":{"login":"Suseika","id":4467948,"avatar_url":"https://avatars.githubusercontent.com/u/4467948?v=3","gravatar_id":"","url":"https://api.github.com/users/Suseika","html_url":"https://github.com/Suseika","followers_url":"https://api.github.com/users/Suseika/followers","following_url":"https://api.github.com/users/Suseika/following{/other_user}","gists_url":"https://api.github.com/users/Suseika/gists{/gist_id}","starred_url":"https://api.github.com/users/Suseika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Suseika/subscriptions","organizations_url":"https://api.github.com/users/Suseika/orgs","repos_url":"https://api.github.com/users/Suseika/repos","events_url":"https://api.github.com/users/Suseika/events{/privacy}","received_events_url":"https://api.github.com/users/Suseika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Suseika/jcabi-log","description":"Static Wrapper of SLF4J","fork":true,"url":"https://api.github.com/repos/Suseika/jcabi-log","forks_url":"https://api.github.com/repos/Suseika/jcabi-log/forks","keys_url":"https://api.github.com/repos/Suseika/jcabi-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Suseika/jcabi-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Suseika/jcabi-log/teams","hooks_url":"https://api.github.com/repos/Suseika/jcabi-log/hooks","issue_events_url":"https://api.github.com/repos/Suseika/jcabi-log/issues/events{/number}","events_url":"https://api.github.com/repos/Suseika/jcabi-log/events","assignees_url":"https://api.github.com/repos/Suseika/jcabi-log/assignees{/user}","branches_url":"https://api.github.com/repos/Suseika/jcabi-log/branches{/branch}","tags_url":"https://api.github.com/repos/Suseika/jcabi-log/tags","blobs_url":"https://api.github.com/repos/Suseika/jcabi-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Suseika/jcabi-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Suseika/jcabi-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/Suseika/jcabi-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Suseika/jcabi-log/statuses/{sha}","languages_url":"https://api.github.com/repos/Suseika/jcabi-log/languages","stargazers_url":"https://api.github.com/repos/Suseika/jcabi-log/stargazers","contributors_url":"https://api.github.com/repos/Suseika/jcabi-log/contributors","subscribers_url":"https://api.github.com/repos/Suseika/jcabi-log/subscribers","subscription_url":"https://api.github.com/repos/Suseika/jcabi-log/subscription","commits_url":"https://api.github.com/repos/Suseika/jcabi-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/Suseika/jcabi-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/Suseika/jcabi-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/Suseika/jcabi-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/Suseika/jcabi-log/contents/{+path}","compare_url":"https://api.github.com/repos/Suseika/jcabi-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Suseika/jcabi-log/merges","archive_url":"https://api.github.com/repos/Suseika/jcabi-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Suseika/jcabi-log/downloads","issues_url":"https://api.github.com/repos/Suseika/jcabi-log/issues{/number}","pulls_url":"https://api.github.com/repos/Suseika/jcabi-log/pulls{/number}","milestones_url":"https://api.github.com/repos/Suseika/jcabi-log/milestones{/number}","notifications_url":"https://api.github.com/repos/Suseika/jcabi-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Suseika/jcabi-log/labels{/name}","releases_url":"https://api.github.com/repos/Suseika/jcabi-log/releases{/id}","created_at":"2015-06-19T12:56:41Z","updated_at":"2015-06-19T12:56:42Z","pushed_at":"2015-08-11T12:36:42Z","git_url":"git://github.com/Suseika/jcabi-log.git","ssh_url":"git@github.com:Suseika/jcabi-log.git","clone_url":"https://github.com/Suseika/jcabi-log.git","svn_url":"https://github.com/Suseika/jcabi-log","homepage":"log.jcabi.com","size":2784,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jcabi:master","ref":"master","sha":"d4adbdb9378e2cc5e9b01d8e4e759f79c24b8891","user":{"login":"jcabi","id":5272640,"avatar_url":"https://avatars.githubusercontent.com/u/5272640?v=3","gravatar_id":"","url":"https://api.github.com/users/jcabi","html_url":"https://github.com/jcabi","followers_url":"https://api.github.com/users/jcabi/followers","following_url":"https://api.github.com/users/jcabi/following{/other_user}","gists_url":"https://api.github.com/users/jcabi/gists{/gist_id}","starred_url":"https://api.github.com/users/jcabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcabi/subscriptions","organizations_url":"https://api.github.com/users/jcabi/orgs","repos_url":"https://api.github.com/users/jcabi/repos","events_url":"https://api.github.com/users/jcabi/events{/privacy}","received_events_url":"https://api.github.com/users/jcabi/received_events","type":"Organization","site_admin":false},"repo":{"id":12262782,"name":"jcabi-log","full_name":"jcabi/jcabi-log","owner":{"login":"jcabi","id":5272640,"avatar_url":"https://avatars.githubusercontent.com/u/5272640?v=3","gravatar_id":"","url":"https://api.github.com/users/jcabi","html_url":"https://github.com/jcabi","followers_url":"https://api.github.com/users/jcabi/followers","following_url":"https://api.github.com/users/jcabi/following{/other_user}","gists_url":"https://api.github.com/users/jcabi/gists{/gist_id}","starred_url":"https://api.github.com/users/jcabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcabi/subscriptions","organizations_url":"https://api.github.com/users/jcabi/orgs","repos_url":"https://api.github.com/users/jcabi/repos","events_url":"https://api.github.com/users/jcabi/events{/privacy}","received_events_url":"https://api.github.com/users/jcabi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jcabi/jcabi-log","description":"Static Wrapper of SLF4J","fork":false,"url":"https://api.github.com/repos/jcabi/jcabi-log","forks_url":"https://api.github.com/repos/jcabi/jcabi-log/forks","keys_url":"https://api.github.com/repos/jcabi/jcabi-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcabi/jcabi-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcabi/jcabi-log/teams","hooks_url":"https://api.github.com/repos/jcabi/jcabi-log/hooks","issue_events_url":"https://api.github.com/repos/jcabi/jcabi-log/issues/events{/number}","events_url":"https://api.github.com/repos/jcabi/jcabi-log/events","assignees_url":"https://api.github.com/repos/jcabi/jcabi-log/assignees{/user}","branches_url":"https://api.github.com/repos/jcabi/jcabi-log/branches{/branch}","tags_url":"https://api.github.com/repos/jcabi/jcabi-log/tags","blobs_url":"https://api.github.com/repos/jcabi/jcabi-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcabi/jcabi-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcabi/jcabi-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcabi/jcabi-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcabi/jcabi-log/statuses/{sha}","languages_url":"https://api.github.com/repos/jcabi/jcabi-log/languages","stargazers_url":"https://api.github.com/repos/jcabi/jcabi-log/stargazers","contributors_url":"https://api.github.com/repos/jcabi/jcabi-log/contributors","subscribers_url":"https://api.github.com/repos/jcabi/jcabi-log/subscribers","subscription_url":"https://api.github.com/repos/jcabi/jcabi-log/subscription","commits_url":"https://api.github.com/repos/jcabi/jcabi-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcabi/jcabi-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcabi/jcabi-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcabi/jcabi-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcabi/jcabi-log/contents/{+path}","compare_url":"https://api.github.com/repos/jcabi/jcabi-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcabi/jcabi-log/merges","archive_url":"https://api.github.com/repos/jcabi/jcabi-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcabi/jcabi-log/downloads","issues_url":"https://api.github.com/repos/jcabi/jcabi-log/issues{/number}","pulls_url":"https://api.github.com/repos/jcabi/jcabi-log/pulls{/number}","milestones_url":"https://api.github.com/repos/jcabi/jcabi-log/milestones{/number}","notifications_url":"https://api.github.com/repos/jcabi/jcabi-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcabi/jcabi-log/labels{/name}","releases_url":"https://api.github.com/repos/jcabi/jcabi-log/releases{/id}","created_at":"2013-08-21T06:17:47Z","updated_at":"2015-08-11T08:28:24Z","pushed_at":"2015-08-11T12:41:58Z","git_url":"git://github.com/jcabi/jcabi-log.git","ssh_url":"git@github.com:jcabi/jcabi-log.git","clone_url":"https://github.com/jcabi/jcabi-log.git","svn_url":"https://github.com/jcabi/jcabi-log","homepage":"log.jcabi.com","size":3295,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61"},"html":{"href":"https://github.com/jcabi/jcabi-log/pull/61"},"issue":{"href":"https://api.github.com/repos/jcabi/jcabi-log/issues/61"},"comments":{"href":"https://api.github.com/repos/jcabi/jcabi-log/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcabi/jcabi-log/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/jcabi/jcabi-log/statuses/287f16e44c00cb62a004d7d295169bd80b4c8641"}}}}