{"action":"created","comment":{"url":"https://api.github.com/repos/FRED-2/Fred2/pulls/comments/41133352","id":41133352,"diff_hunk":"@@ -77,7 +78,7 @@ def __load_allele_model(allele,length):\n                 ##here is the prediction and result object missing##\n                 for p in peps:\n                     score = sum(pssm[i].get(p[i], 0.0) for i in xrange(length))+pssm.get(-1,{}).get(\"con\", 0)\n-                    result[allales_string[a]][pep_seqs[p]] = score\n+                    result[allales_string[a]][pep_seqs[p]] = (100.0 / float(max_score) * float(score)) / 100.0 #report percent of max for this allele matrix","path":"Fred2/EpitopePrediction/PSSM.py","position":13,"original_position":13,"commit_id":"15616b00aaa7ac59873cdb338bcd4a0e4ab2de57","original_commit_id":"15616b00aaa7ac59873cdb338bcd4a0e4ab2de57","user":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"body":"min-max definitely a good idea","created_at":"2015-10-05T11:26:08Z","updated_at":"2015-10-05T11:26:08Z","html_url":"https://github.com/FRED-2/Fred2/pull/55#discussion_r41133352","pull_request_url":"https://api.github.com/repos/FRED-2/Fred2/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/comments/41133352"},"html":{"href":"https://github.com/FRED-2/Fred2/pull/55#discussion_r41133352"},"pull_request":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/FRED-2/Fred2/pulls/55","id":46629074,"html_url":"https://github.com/FRED-2/Fred2/pull/55","diff_url":"https://github.com/FRED-2/Fred2/pull/55.diff","patch_url":"https://github.com/FRED-2/Fred2/pull/55.patch","issue_url":"https://api.github.com/repos/FRED-2/Fred2/issues/55","number":55,"state":"open","locked":false,"title":"Suggestion: reporting the scores of a PSSM peptide prediction as …","user":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"body":"… the percentage/100 (i.e. 0.0-1.0) of the maximum achievable score for that allele-length-matrix\r\n\r\nReporting does imho not make that much sense, as you always have to back-refer to the matrix to put that score into a relative and valuing view.\r\nHence, reporting as percentage/100??","created_at":"2015-10-02T12:14:53Z","updated_at":"2015-10-05T11:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dc90f041752290a3eece4b76a31f858c1c86155","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FRED-2/Fred2/pulls/55/commits","review_comments_url":"https://api.github.com/repos/FRED-2/Fred2/pulls/55/comments","review_comment_url":"https://api.github.com/repos/FRED-2/Fred2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRED-2/Fred2/issues/55/comments","statuses_url":"https://api.github.com/repos/FRED-2/Fred2/statuses/15616b00aaa7ac59873cdb338bcd4a0e4ab2de57","head":{"label":"mwalzer:feature/PSSM-percent-max-score","ref":"feature/PSSM-percent-max-score","sha":"15616b00aaa7ac59873cdb338bcd4a0e4ab2de57","user":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"repo":{"id":39641622,"name":"Fred2","full_name":"mwalzer/Fred2","owner":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwalzer/Fred2","description":"","fork":true,"url":"https://api.github.com/repos/mwalzer/Fred2","forks_url":"https://api.github.com/repos/mwalzer/Fred2/forks","keys_url":"https://api.github.com/repos/mwalzer/Fred2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwalzer/Fred2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwalzer/Fred2/teams","hooks_url":"https://api.github.com/repos/mwalzer/Fred2/hooks","issue_events_url":"https://api.github.com/repos/mwalzer/Fred2/issues/events{/number}","events_url":"https://api.github.com/repos/mwalzer/Fred2/events","assignees_url":"https://api.github.com/repos/mwalzer/Fred2/assignees{/user}","branches_url":"https://api.github.com/repos/mwalzer/Fred2/branches{/branch}","tags_url":"https://api.github.com/repos/mwalzer/Fred2/tags","blobs_url":"https://api.github.com/repos/mwalzer/Fred2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwalzer/Fred2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwalzer/Fred2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwalzer/Fred2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwalzer/Fred2/statuses/{sha}","languages_url":"https://api.github.com/repos/mwalzer/Fred2/languages","stargazers_url":"https://api.github.com/repos/mwalzer/Fred2/stargazers","contributors_url":"https://api.github.com/repos/mwalzer/Fred2/contributors","subscribers_url":"https://api.github.com/repos/mwalzer/Fred2/subscribers","subscription_url":"https://api.github.com/repos/mwalzer/Fred2/subscription","commits_url":"https://api.github.com/repos/mwalzer/Fred2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwalzer/Fred2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwalzer/Fred2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwalzer/Fred2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwalzer/Fred2/contents/{+path}","compare_url":"https://api.github.com/repos/mwalzer/Fred2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwalzer/Fred2/merges","archive_url":"https://api.github.com/repos/mwalzer/Fred2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwalzer/Fred2/downloads","issues_url":"https://api.github.com/repos/mwalzer/Fred2/issues{/number}","pulls_url":"https://api.github.com/repos/mwalzer/Fred2/pulls{/number}","milestones_url":"https://api.github.com/repos/mwalzer/Fred2/milestones{/number}","notifications_url":"https://api.github.com/repos/mwalzer/Fred2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwalzer/Fred2/labels{/name}","releases_url":"https://api.github.com/repos/mwalzer/Fred2/releases{/id}","created_at":"2015-07-24T15:24:24Z","updated_at":"2015-07-24T15:24:24Z","pushed_at":"2015-10-02T12:06:26Z","git_url":"git://github.com/mwalzer/Fred2.git","ssh_url":"git@github.com:mwalzer/Fred2.git","clone_url":"https://github.com/mwalzer/Fred2.git","svn_url":"https://github.com/mwalzer/Fred2","homepage":null,"size":3001,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRED-2:master","ref":"master","sha":"3f743503fb8c7f24bb212aa7826b7d50a2a82e0e","user":{"login":"FRED-2","id":7511864,"avatar_url":"https://avatars.githubusercontent.com/u/7511864?v=3","gravatar_id":"","url":"https://api.github.com/users/FRED-2","html_url":"https://github.com/FRED-2","followers_url":"https://api.github.com/users/FRED-2/followers","following_url":"https://api.github.com/users/FRED-2/following{/other_user}","gists_url":"https://api.github.com/users/FRED-2/gists{/gist_id}","starred_url":"https://api.github.com/users/FRED-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRED-2/subscriptions","organizations_url":"https://api.github.com/users/FRED-2/orgs","repos_url":"https://api.github.com/users/FRED-2/repos","events_url":"https://api.github.com/users/FRED-2/events{/privacy}","received_events_url":"https://api.github.com/users/FRED-2/received_events","type":"Organization","site_admin":false},"repo":{"id":16275425,"name":"Fred2","full_name":"FRED-2/Fred2","owner":{"login":"FRED-2","id":7511864,"avatar_url":"https://avatars.githubusercontent.com/u/7511864?v=3","gravatar_id":"","url":"https://api.github.com/users/FRED-2","html_url":"https://github.com/FRED-2","followers_url":"https://api.github.com/users/FRED-2/followers","following_url":"https://api.github.com/users/FRED-2/following{/other_user}","gists_url":"https://api.github.com/users/FRED-2/gists{/gist_id}","starred_url":"https://api.github.com/users/FRED-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRED-2/subscriptions","organizations_url":"https://api.github.com/users/FRED-2/orgs","repos_url":"https://api.github.com/users/FRED-2/repos","events_url":"https://api.github.com/users/FRED-2/events{/privacy}","received_events_url":"https://api.github.com/users/FRED-2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRED-2/Fred2","description":"","fork":false,"url":"https://api.github.com/repos/FRED-2/Fred2","forks_url":"https://api.github.com/repos/FRED-2/Fred2/forks","keys_url":"https://api.github.com/repos/FRED-2/Fred2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRED-2/Fred2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRED-2/Fred2/teams","hooks_url":"https://api.github.com/repos/FRED-2/Fred2/hooks","issue_events_url":"https://api.github.com/repos/FRED-2/Fred2/issues/events{/number}","events_url":"https://api.github.com/repos/FRED-2/Fred2/events","assignees_url":"https://api.github.com/repos/FRED-2/Fred2/assignees{/user}","branches_url":"https://api.github.com/repos/FRED-2/Fred2/branches{/branch}","tags_url":"https://api.github.com/repos/FRED-2/Fred2/tags","blobs_url":"https://api.github.com/repos/FRED-2/Fred2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRED-2/Fred2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRED-2/Fred2/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRED-2/Fred2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRED-2/Fred2/statuses/{sha}","languages_url":"https://api.github.com/repos/FRED-2/Fred2/languages","stargazers_url":"https://api.github.com/repos/FRED-2/Fred2/stargazers","contributors_url":"https://api.github.com/repos/FRED-2/Fred2/contributors","subscribers_url":"https://api.github.com/repos/FRED-2/Fred2/subscribers","subscription_url":"https://api.github.com/repos/FRED-2/Fred2/subscription","commits_url":"https://api.github.com/repos/FRED-2/Fred2/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRED-2/Fred2/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRED-2/Fred2/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRED-2/Fred2/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRED-2/Fred2/contents/{+path}","compare_url":"https://api.github.com/repos/FRED-2/Fred2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRED-2/Fred2/merges","archive_url":"https://api.github.com/repos/FRED-2/Fred2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRED-2/Fred2/downloads","issues_url":"https://api.github.com/repos/FRED-2/Fred2/issues{/number}","pulls_url":"https://api.github.com/repos/FRED-2/Fred2/pulls{/number}","milestones_url":"https://api.github.com/repos/FRED-2/Fred2/milestones{/number}","notifications_url":"https://api.github.com/repos/FRED-2/Fred2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRED-2/Fred2/labels{/name}","releases_url":"https://api.github.com/repos/FRED-2/Fred2/releases{/id}","created_at":"2014-01-27T10:08:11Z","updated_at":"2015-05-27T14:38:24Z","pushed_at":"2015-10-02T12:14:53Z","git_url":"git://github.com/FRED-2/Fred2.git","ssh_url":"git@github.com:FRED-2/Fred2.git","clone_url":"https://github.com/FRED-2/Fred2.git","svn_url":"https://github.com/FRED-2/Fred2","homepage":null,"size":3838,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/55"},"html":{"href":"https://github.com/FRED-2/Fred2/pull/55"},"issue":{"href":"https://api.github.com/repos/FRED-2/Fred2/issues/55"},"comments":{"href":"https://api.github.com/repos/FRED-2/Fred2/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRED-2/Fred2/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/FRED-2/Fred2/statuses/15616b00aaa7ac59873cdb338bcd4a0e4ab2de57"}}}}