{"action":"opened","issue":{"url":"https://api.github.com/repos/elazarl/goproxy/issues/92","labels_url":"https://api.github.com/repos/elazarl/goproxy/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/elazarl/goproxy/issues/92/comments","events_url":"https://api.github.com/repos/elazarl/goproxy/issues/92/events","html_url":"https://github.com/elazarl/goproxy/issues/92","id":59578736,"number":92,"title":"TestNoProxyHeaders and TestNoProxyHeadersHttps tests failing","user":{"login":"glycerine","id":445247,"avatar_url":"https://avatars.githubusercontent.com/u/445247?v=3","gravatar_id":"","url":"https://api.github.com/users/glycerine","html_url":"https://github.com/glycerine","followers_url":"https://api.github.com/users/glycerine/followers","following_url":"https://api.github.com/users/glycerine/following{/other_user}","gists_url":"https://api.github.com/users/glycerine/gists{/gist_id}","starred_url":"https://api.github.com/users/glycerine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glycerine/subscriptions","organizations_url":"https://api.github.com/users/glycerine/orgs","repos_url":"https://api.github.com/users/glycerine/repos","events_url":"https://api.github.com/users/glycerine/events{/privacy}","received_events_url":"https://api.github.com/users/glycerine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-03-03T00:57:06Z","updated_at":"2015-03-03T00:57:06Z","closed_at":null,"body":"I pulled the latest goproxy (99a857cc920470279e92a925f082a73fd4cf8dee), and the test suite exhibits two broken tests.\r\n\r\nThe broken tests are TestNoProxyHeaders and TestNoProxyHeadersHttps.\r\n\r\ngo1.4 darwin/amd64 on OSX 10.9.4\r\n\r\n~~~\r\nJasons-MacBook-Pro:goproxy jasona$ go build\r\nJasons-MacBook-Pro:goproxy jasona$ go install\r\nJasons-MacBook-Pro:goproxy jasona$ go test -v\r\n=== RUN TestSingerTls\r\n--- PASS: TestSingerTls (0.17s)\r\n=== RUN TestSingerX509\r\n--- PASS: TestSingerX509 (0.15s)\r\n=== RUN TestCounterEncDifferentConsecutive\r\n--- PASS: TestCounterEncDifferentConsecutive (0.03s)\r\n=== RUN TestCounterEncIdenticalStreams\r\n--- PASS: TestCounterEncIdenticalStreams (0.00s)\r\n=== RUN TestCounterEncStreamHistogram\r\n--- PASS: TestCounterEncStreamHistogram (0.00s)\r\n    counterecryptor_test.go:95: ref:20.09936102779116 - act:19.32792351627511 = 0.7714375115160514\r\n=== RUN TestSimpleHttpReqWithProxy\r\n2015/03/02 16:51:18 [003] WARN: Error copying to client: read tcp 127.0.0.1:52459: use of closed network connectio\\\r\nn\r\n--- PASS: TestSimpleHttpReqWithProxy (0.01s)\r\n=== RUN TestSimpleHook\r\n--- PASS: TestSimpleHook (0.00s)\r\n=== RUN TestAlwaysHook\r\n--- PASS: TestAlwaysHook (0.00s)\r\n=== RUN TestReplaceResponse\r\n--- PASS: TestReplaceResponse (0.00s)\r\n=== RUN TestReplaceReponseForUrl\r\n--- PASS: TestReplaceReponseForUrl (0.00s)\r\n=== RUN TestOneShotFileServer\r\n--- PASS: TestOneShotFileServer (0.01s)\r\n=== RUN TestContentType\r\n--- PASS: TestContentType (0.00s)\r\n=== RUN TestConstantImageHandler\r\n--- PASS: TestConstantImageHandler (0.01s)\r\n=== RUN TestImageHandler\r\n--- PASS: TestImageHandler (0.01s)\r\n=== RUN TestChangeResp\r\n--- PASS: TestChangeResp (0.00s)\r\n=== RUN TestReplaceImage\r\n--- PASS: TestReplaceImage (0.01s)\r\n=== RUN TestSimpleMitm\r\n--- PASS: TestSimpleMitm (0.17s)\r\n=== RUN TestConnectHandler\r\n2015/03/02 16:51:18 [001] WARN: Error copying to client: read tcp 127.0.0.1:52502: use of closed network connectio\\\r\nn\r\n--- PASS: TestConnectHandler (0.02s)\r\n=== RUN TestMitmIsFiltered\r\n--- PASS: TestMitmIsFiltered (0.09s)\r\n=== RUN TestFirstHandlerMatches\r\n--- PASS: TestFirstHandlerMatches (0.00s)\r\n=== RUN TestIcyResponse\r\n--- PASS: TestIcyResponse (0.00s)\r\n=== RUN TestNoProxyHeaders\r\n--- FAIL: TestNoProxyHeaders (0.00s)\r\n    proxy_test.go:534: Got Connection header from goproxy map[Connection:[close] Accept-Encoding:[gzip] User-Agent\\\r\n:[Go 1.1 package http]]\r\n=== RUN TestNoProxyHeadersHttps\r\n--- FAIL: TestNoProxyHeadersHttps (0.09s)\r\n    proxy_test.go:534: Got Connection header from goproxy map[User-Agent:[Go 1.1 package http] Connection:[close] \\\r\nAccept-Encoding:[gzip]]\r\n=== RUN TestHeadReqHasContentLength\r\n--- PASS: TestHeadReqHasContentLength (0.00s)\r\n=== RUN TestChunkedResponse\r\n--- PASS: TestChunkedResponse (0.00s)\r\n=== RUN TestGoproxyThroughProxy\r\n2015/03/02 16:51:18 [001] WARN: Error copying to client: read tcp 127.0.0.1:52526: use of closed network connectio\\\r\nn\r\n--- PASS: TestGoproxyThroughProxy (0.09s)\r\n=== RUN TestGoproxyHijackConnect\r\n2015/03/02 16:51:18 [002] WARN: Error copying to client: read tcp 127.0.0.1:52532: use of closed network connectio\\\r\nn\r\n--- PASS: TestGoproxyHijackConnect (0.01s)\r\n    proxy_test.go:666: URL &url.URL{Scheme:\"\", Opaque:\"\", User:(*url.Userinfo)(nil), Host:\"127.0.0.1:52452\", Path:\\\r\n\"\", RawQuery:\"\", Fragment:\"\"}\r\n        STR //127.0.0.1:52452\r\n=== RUN TestCurlMinusP\r\n--- PASS: TestCurlMinusP (0.01s)\r\n=== RUN TestSelfRequest\r\n--- PASS: TestSelfRequest (0.00s)\r\n=== RUN TestHasGoproxyCA\r\n--- PASS: TestHasGoproxyCA (0.08s)\r\nFAIL\r\nexit status 1\r\nFAIL    github.com/elazarl/goproxy  1.006s\r\nJasons-MacBook-Pro:goproxy jasona$ \r\nJasons-MacBook-Pro:goproxy jasona$ git log |head\r\ncommit 99a857cc920470279e92a925f082a73fd4cf8dee\r\nMerge: 102ffa3 d58254a\r\nAuthor: Elazar Leibovich <elazarl@gmail.com>\r\nDate:   Sun Feb 22 11:32:38 2015 +0200\r\n\r\n    Merge pull request #91 from pmezard/rename-examples\r\n\r\n    Add gproxy- prefix to examples, so go get github.com/elazarl/goproxy... won't pollute $GOPATH/bin\r\n\r\ncommit d58254a50e2061f93daaee23112b9f2e5c86df71\r\nJasons-MacBook-Pro:goproxy jasona$ \r\n~~~"}}