{"action":"created","issue":{"url":"https://api.github.com/repos/colobot/colobot/issues/676","labels_url":"https://api.github.com/repos/colobot/colobot/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/colobot/colobot/issues/676/comments","events_url":"https://api.github.com/repos/colobot/colobot/issues/676/events","html_url":"https://github.com/colobot/colobot/pull/676","id":114481704,"number":676,"title":"Add unit tests for class CBotString.","user":{"login":"Grunaka","id":13179285,"avatar_url":"https://avatars.githubusercontent.com/u/13179285?v=3","gravatar_id":"","url":"https://api.github.com/users/Grunaka","html_url":"https://github.com/Grunaka","followers_url":"https://api.github.com/users/Grunaka/followers","following_url":"https://api.github.com/users/Grunaka/following{/other_user}","gists_url":"https://api.github.com/users/Grunaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Grunaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grunaka/subscriptions","organizations_url":"https://api.github.com/users/Grunaka/orgs","repos_url":"https://api.github.com/users/Grunaka/repos","events_url":"https://api.github.com/users/Grunaka/events{/privacy}","received_events_url":"https://api.github.com/users/Grunaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"piotrdz","id":1151708,"avatar_url":"https://avatars.githubusercontent.com/u/1151708?v=3","gravatar_id":"","url":"https://api.github.com/users/piotrdz","html_url":"https://github.com/piotrdz","followers_url":"https://api.github.com/users/piotrdz/followers","following_url":"https://api.github.com/users/piotrdz/following{/other_user}","gists_url":"https://api.github.com/users/piotrdz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrdz/subscriptions","organizations_url":"https://api.github.com/users/piotrdz/orgs","repos_url":"https://api.github.com/users/piotrdz/repos","events_url":"https://api.github.com/users/piotrdz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrdz/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-11-01T17:22:21Z","updated_at":"2015-11-02T20:24:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/colobot/colobot/pulls/676","html_url":"https://github.com/colobot/colobot/pull/676","diff_url":"https://github.com/colobot/colobot/pull/676.diff","patch_url":"https://github.com/colobot/colobot/pull/676.patch"},"body":"Add comments in class CBotString.\r\nChange existing comments in class CBotString to be compliant with doxygen.\r\nAdd function \"const char* CBotString::CStr() const\".\r\nAdd null pointer check in function \"const CBotString& CBotString::operator+=(const CBotString& str)\"\r\nRemove functions \"CBotString CBotString::Mid(int nFirst, int nCount) const\" and \"CBotString CBotString::Mid(int nFirst) const\" because they were doublons of function \"CBotString CBotString::Mid(int nFirst, int lg) const\""},"comment":{"url":"https://api.github.com/repos/colobot/colobot/issues/comments/153146246","html_url":"https://github.com/colobot/colobot/pull/676#issuecomment-153146246","issue_url":"https://api.github.com/repos/colobot/colobot/issues/676","id":153146246,"user":{"login":"piotrdz","id":1151708,"avatar_url":"https://avatars.githubusercontent.com/u/1151708?v=3","gravatar_id":"","url":"https://api.github.com/users/piotrdz","html_url":"https://github.com/piotrdz","followers_url":"https://api.github.com/users/piotrdz/followers","following_url":"https://api.github.com/users/piotrdz/following{/other_user}","gists_url":"https://api.github.com/users/piotrdz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrdz/subscriptions","organizations_url":"https://api.github.com/users/piotrdz/orgs","repos_url":"https://api.github.com/users/piotrdz/repos","events_url":"https://api.github.com/users/piotrdz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrdz/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T20:24:00Z","updated_at":"2015-11-02T20:24:00Z","body":"Tests are not exactly pointless, as they will help verify that rewritten code works the same as old implementation. That said, we would like to rewrite CBOT at more fundamental level, so we would need acceptance tests at the interpreter level, running sample CBOT code and expecting some meaningful results.\r\n@Grunaka: the tasks I wrote about on forum are still relevant. I'll give you more information on IRC.\r\nI'll accept this pull request, as any tests are better than no tests for CBOT, but I'd expect further tests to be written at higher level."}}