{"action":"created","issue":{"url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/26","labels_url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/26/comments","events_url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/26/events","html_url":"https://github.com/ibm-js/requirejs-dplugins/pull/26","id":111389041,"number":26,"title":"added icon plugin","user":{"login":"tkrugg","id":2982512,"avatar_url":"https://avatars.githubusercontent.com/u/2982512?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrugg","html_url":"https://github.com/tkrugg","followers_url":"https://api.github.com/users/tkrugg/followers","following_url":"https://api.github.com/users/tkrugg/following{/other_user}","gists_url":"https://api.github.com/users/tkrugg/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrugg/subscriptions","organizations_url":"https://api.github.com/users/tkrugg/orgs","repos_url":"https://api.github.com/users/tkrugg/repos","events_url":"https://api.github.com/users/tkrugg/events{/privacy}","received_events_url":"https://api.github.com/users/tkrugg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-10-14T12:38:13Z","updated_at":"2015-10-22T21:22:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/pulls/26","html_url":"https://github.com/ibm-js/requirejs-dplugins/pull/26","diff_url":"https://github.com/ibm-js/requirejs-dplugins/pull/26.diff","patch_url":"https://github.com/ibm-js/requirejs-dplugins/pull/26.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/comments/150360024","html_url":"https://github.com/ibm-js/requirejs-dplugins/pull/26#issuecomment-150360024","issue_url":"https://api.github.com/repos/ibm-js/requirejs-dplugins/issues/26","id":150360024,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T21:22:09Z","updated_at":"2015-10-22T21:22:09Z","body":"(copying my comments from the other PR...)\r\n\r\nThanks for the simplifications. The definitely makes it easier to compare approaches, and I like how it's sharing more code than before.\r\n\r\nOne thing though: at runtime, it makes sense to call `extractGraphic()` and `createSymbol()` on raw icon files, but IIUC you are also calling those functions on pre-built sprites, which already contain `<symbol>` tags. That seems strange.\r\n\r\nRelatedly, I'm unclear what happens when you load (for example) two pre-built sprites (each containing 10 icons) and two stand-alone icon files. What DOM do you end up with? A single `<svg style=display:none>` node that contains all 22 icons?  Do you end up with `<symbol>` tags nested inside other `<symbol>` tags or something weird like that?\r\n\r\nMinor note: Might want to combine `extractGraphic()` and `createSymbol()`, since they are always called one right after the other. Relatedly, the comment describing `extractGraphic()` isn't quite right."}}