{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/atomic/issues/182","labels_url":"https://api.github.com/repos/projectatomic/atomic/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/atomic/issues/182/comments","events_url":"https://api.github.com/repos/projectatomic/atomic/issues/182/events","html_url":"https://github.com/projectatomic/atomic/pull/182","id":110073527,"number":182,"title":"Makefile: remove atomic target","user":{"login":"jlebon","id":11934099,"avatar_url":"https://avatars.githubusercontent.com/u/11934099?v=3","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-06T18:42:21Z","updated_at":"2015-10-06T19:13:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/projectatomic/atomic/pulls/182","html_url":"https://github.com/projectatomic/atomic/pull/182","diff_url":"https://github.com/projectatomic/atomic/pull/182.diff","patch_url":"https://github.com/projectatomic/atomic/pull/182.patch"},"body":"The `python-build` target lists `atomic` as a prerequisite target.\r\nHowever, there is no explicit target named 'atomic', so `make` tries to\r\nfind any implicit rules that apply. One of the rules that it tries is\r\nwhether the unprocessed file is called `atomic.sh`. Since that file\r\nexists, it proceeds by copying `atomic.sh` to `atomic` if e.g.\r\n`atomic.sh` is newer than `atomic`:\r\n\r\n      Considering target file 'python-build'.\r\n       File 'python-build' does not exist.\r\n        Considering target file 'atomic'.\r\n         <snip>\r\n         Found an implicit rule for 'atomic'.\r\n          Considering target file 'atomic.sh'.\r\n           <snip>\r\n           Finished prerequisites of target file 'atomic.sh'.\r\n          No need to remake target 'atomic.sh'.\r\n         Finished prerequisites of target file 'atomic'.\r\n         Prerequisite 'atomic.sh' is newer than target 'atomic'.\r\n        Must remake target 'atomic'.\r\n    cat atomic.sh >atomic\r\n\r\nThis patch removes the `atomic` target which does not exist, and also\r\nexplicitly makes all the other non-file targets phonies to make sure no\r\nname collisions will happen again (and as a plus, improve performance)."},"comment":{"url":"https://api.github.com/repos/projectatomic/atomic/issues/comments/145969138","html_url":"https://github.com/projectatomic/atomic/pull/182#issuecomment-145969138","issue_url":"https://api.github.com/repos/projectatomic/atomic/issues/182","id":145969138,"user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T19:13:13Z","updated_at":"2015-10-06T19:13:13Z","body":"LGTM"}}