{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36","id":28509755,"html_url":"https://github.com/planetlabs/planet-view-chrome-ext/pull/36","diff_url":"https://github.com/planetlabs/planet-view-chrome-ext/pull/36.diff","patch_url":"https://github.com/planetlabs/planet-view-chrome-ext/pull/36.patch","issue_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/36","number":36,"state":"open","locked":false,"title":"Remove Player logic that edits history.","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=3","gravatar_id":"","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"body":"When the `Player.prototype.new` function pushes to history, an unfortunate situation occurs...\r\n\r\n- I open a new tab\r\n- I browse in that tab for some time.\r\n- I try to go back to some part of that tab's history, a page that I had open early in that tab's lifetime.\r\n- Oops, I went too far, ended up hitting back all the way up to the 'new tab' screen, which is now another one of PlanetLab's beautiful images.\r\n- I'd like to just hit forward and keep browsing for the page I'm looking for...but suddenly the entire history for that tab is gone.\r\n(This has happened to me more than 20 times by now).\r\n\r\nThis PR is not without cost: the edits to the history was in service to of a feature where, if you click the lower righthand globe, and get a new image, you were previously able to hit the browser back button to view the previous images. If this feature is a must-have, it could probably be coded in such a way that it doesn't destroy the user's history when they have navigated off of the new tab screen. I'd be open for suggestions to modifications of this PR if that's a feature that needs to be kept.\r\n\r\nFixes #33 ","created_at":"2015-02-02T22:41:53Z","updated_at":"2015-02-02T22:41:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36/commits","review_comments_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36/comments","review_comment_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/comments/{number}","comments_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/36/comments","statuses_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/statuses/f24974f9f5552985527deba08622f79b045f13b5","head":{"label":"lossyrob:fix-forward-issue","ref":"fix-forward-issue","sha":"f24974f9f5552985527deba08622f79b045f13b5","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=3","gravatar_id":"","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"repo":{"id":30210414,"name":"planet-view-chrome-ext","full_name":"lossyrob/planet-view-chrome-ext","owner":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=3","gravatar_id":"","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lossyrob/planet-view-chrome-ext","description":"Extension for Google Chrome displaying Planet Labs imagery","fork":true,"url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext","forks_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/forks","keys_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/teams","hooks_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/hooks","issue_events_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/issues/events{/number}","events_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/events","assignees_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/assignees{/user}","branches_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/branches{/branch}","tags_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/tags","blobs_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/languages","stargazers_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/stargazers","contributors_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/contributors","subscribers_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/subscribers","subscription_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/subscription","commits_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/issues/comments/{number}","contents_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/contents/{+path}","compare_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/merges","archive_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/downloads","issues_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/issues{/number}","pulls_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/labels{/name}","releases_url":"https://api.github.com/repos/lossyrob/planet-view-chrome-ext/releases{/id}","created_at":"2015-02-02T21:47:38Z","updated_at":"2015-02-02T21:47:39Z","pushed_at":"2015-02-02T22:34:49Z","git_url":"git://github.com/lossyrob/planet-view-chrome-ext.git","ssh_url":"git@github.com:lossyrob/planet-view-chrome-ext.git","clone_url":"https://github.com/lossyrob/planet-view-chrome-ext.git","svn_url":"https://github.com/lossyrob/planet-view-chrome-ext","homepage":"https://chrome.google.com/webstore/detail/planet-view/hhhgdbldiopbpblfcohjaeinjjciplho","size":958,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"planetlabs:master","ref":"master","sha":"4201f2f098f57af6a8752982a963a278b1e5dad5","user":{"login":"planetlabs","id":5247016,"avatar_url":"https://avatars.githubusercontent.com/u/5247016?v=3","gravatar_id":"","url":"https://api.github.com/users/planetlabs","html_url":"https://github.com/planetlabs","followers_url":"https://api.github.com/users/planetlabs/followers","following_url":"https://api.github.com/users/planetlabs/following{/other_user}","gists_url":"https://api.github.com/users/planetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/planetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetlabs/subscriptions","organizations_url":"https://api.github.com/users/planetlabs/orgs","repos_url":"https://api.github.com/users/planetlabs/repos","events_url":"https://api.github.com/users/planetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/planetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26655815,"name":"planet-view-chrome-ext","full_name":"planetlabs/planet-view-chrome-ext","owner":{"login":"planetlabs","id":5247016,"avatar_url":"https://avatars.githubusercontent.com/u/5247016?v=3","gravatar_id":"","url":"https://api.github.com/users/planetlabs","html_url":"https://github.com/planetlabs","followers_url":"https://api.github.com/users/planetlabs/followers","following_url":"https://api.github.com/users/planetlabs/following{/other_user}","gists_url":"https://api.github.com/users/planetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/planetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetlabs/subscriptions","organizations_url":"https://api.github.com/users/planetlabs/orgs","repos_url":"https://api.github.com/users/planetlabs/repos","events_url":"https://api.github.com/users/planetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/planetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/planetlabs/planet-view-chrome-ext","description":"Extension for Google Chrome displaying Planet Labs imagery","fork":false,"url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext","forks_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/forks","keys_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/teams","hooks_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/hooks","issue_events_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/events{/number}","events_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/events","assignees_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/assignees{/user}","branches_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/branches{/branch}","tags_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/tags","blobs_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/languages","stargazers_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/stargazers","contributors_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/contributors","subscribers_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/subscribers","subscription_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/subscription","commits_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/comments/{number}","contents_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/contents/{+path}","compare_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/merges","archive_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/downloads","issues_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues{/number}","pulls_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/labels{/name}","releases_url":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/releases{/id}","created_at":"2014-11-14T20:18:30Z","updated_at":"2014-12-29T04:04:33Z","pushed_at":"2014-12-29T04:04:32Z","git_url":"git://github.com/planetlabs/planet-view-chrome-ext.git","ssh_url":"git@github.com:planetlabs/planet-view-chrome-ext.git","clone_url":"https://github.com/planetlabs/planet-view-chrome-ext.git","svn_url":"https://github.com/planetlabs/planet-view-chrome-ext","homepage":"https://chrome.google.com/webstore/detail/planet-view/hhhgdbldiopbpblfcohjaeinjjciplho","size":1318,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36"},"html":{"href":"https://github.com/planetlabs/planet-view-chrome-ext/pull/36"},"issue":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/36"},"comments":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/planetlabs/planet-view-chrome-ext/statuses/f24974f9f5552985527deba08622f79b045f13b5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":12,"changed_files":1}}