{"action":"created","comment":{"url":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments/31565205","id":31565205,"diff_hunk":"@@ -2118,6 +2125,19 @@ func maxValue(f64s []float64, absent []bool) float64 {\n \treturn m\n }\n \n+func minValue(f64s []float64, absent []bool) float64 {","path":"expr.go","position":61,"original_position":61,"commit_id":"8c1e29f8d4a4ef80d06d9f9f180124ea5b37938f","original_commit_id":"8c1e29f8d4a4ef80d06d9f9f180124ea5b37938f","user":{"login":"dgryski","id":970862,"avatar_url":"https://avatars.githubusercontent.com/u/970862?v=3","gravatar_id":"","url":"https://api.github.com/users/dgryski","html_url":"https://github.com/dgryski","followers_url":"https://api.github.com/users/dgryski/followers","following_url":"https://api.github.com/users/dgryski/following{/other_user}","gists_url":"https://api.github.com/users/dgryski/gists{/gist_id}","starred_url":"https://api.github.com/users/dgryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgryski/subscriptions","organizations_url":"https://api.github.com/users/dgryski/orgs","repos_url":"https://api.github.com/users/dgryski/repos","events_url":"https://api.github.com/users/dgryski/events{/privacy}","received_events_url":"https://api.github.com/users/dgryski/received_events","type":"User","site_admin":false},"body":"As `maxValue` is just above, it appears the code is wrong.  Perhaps add a test to catch this sort of bug too.","created_at":"2015-06-02T20:09:57Z","updated_at":"2015-06-02T20:09:57Z","html_url":"https://github.com/dgryski/carbonapi/pull/58#discussion_r31565205","pull_request_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments/31565205"},"html":{"href":"https://github.com/dgryski/carbonapi/pull/58#discussion_r31565205"},"pull_request":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/dgryski/carbonapi/pulls/58","id":36720360,"html_url":"https://github.com/dgryski/carbonapi/pull/58","diff_url":"https://github.com/dgryski/carbonapi/pull/58.diff","patch_url":"https://github.com/dgryski/carbonapi/pull/58.patch","issue_url":"https://api.github.com/repos/dgryski/carbonapi/issues/58","number":58,"state":"open","locked":false,"title":"Added maximumAbove, maximumBelow, minimumAbove, minimumBelow functions","user":{"login":"JaderDias","id":52470,"avatar_url":"https://avatars.githubusercontent.com/u/52470?v=3","gravatar_id":"","url":"https://api.github.com/users/JaderDias","html_url":"https://github.com/JaderDias","followers_url":"https://api.github.com/users/JaderDias/followers","following_url":"https://api.github.com/users/JaderDias/following{/other_user}","gists_url":"https://api.github.com/users/JaderDias/gists{/gist_id}","starred_url":"https://api.github.com/users/JaderDias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaderDias/subscriptions","organizations_url":"https://api.github.com/users/JaderDias/orgs","repos_url":"https://api.github.com/users/JaderDias/repos","events_url":"https://api.github.com/users/JaderDias/events{/privacy}","received_events_url":"https://api.github.com/users/JaderDias/received_events","type":"User","site_admin":false},"body":"functions already present in graphite","created_at":"2015-06-02T11:55:28Z","updated_at":"2015-06-02T20:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a850704d86e5cc1b3544f8e143313ab7a437e18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/58/commits","review_comments_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/58/comments","review_comment_url":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgryski/carbonapi/issues/58/comments","statuses_url":"https://api.github.com/repos/dgryski/carbonapi/statuses/8c1e29f8d4a4ef80d06d9f9f180124ea5b37938f","head":{"label":"JaderDias:master","ref":"master","sha":"8c1e29f8d4a4ef80d06d9f9f180124ea5b37938f","user":{"login":"JaderDias","id":52470,"avatar_url":"https://avatars.githubusercontent.com/u/52470?v=3","gravatar_id":"","url":"https://api.github.com/users/JaderDias","html_url":"https://github.com/JaderDias","followers_url":"https://api.github.com/users/JaderDias/followers","following_url":"https://api.github.com/users/JaderDias/following{/other_user}","gists_url":"https://api.github.com/users/JaderDias/gists{/gist_id}","starred_url":"https://api.github.com/users/JaderDias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaderDias/subscriptions","organizations_url":"https://api.github.com/users/JaderDias/orgs","repos_url":"https://api.github.com/users/JaderDias/repos","events_url":"https://api.github.com/users/JaderDias/events{/privacy}","received_events_url":"https://api.github.com/users/JaderDias/received_events","type":"User","site_admin":false},"repo":{"id":36327615,"name":"carbonapi","full_name":"JaderDias/carbonapi","owner":{"login":"JaderDias","id":52470,"avatar_url":"https://avatars.githubusercontent.com/u/52470?v=3","gravatar_id":"","url":"https://api.github.com/users/JaderDias","html_url":"https://github.com/JaderDias","followers_url":"https://api.github.com/users/JaderDias/followers","following_url":"https://api.github.com/users/JaderDias/following{/other_user}","gists_url":"https://api.github.com/users/JaderDias/gists{/gist_id}","starred_url":"https://api.github.com/users/JaderDias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaderDias/subscriptions","organizations_url":"https://api.github.com/users/JaderDias/orgs","repos_url":"https://api.github.com/users/JaderDias/repos","events_url":"https://api.github.com/users/JaderDias/events{/privacy}","received_events_url":"https://api.github.com/users/JaderDias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JaderDias/carbonapi","description":"API server for github.com/dgryski/carbonzipper","fork":true,"url":"https://api.github.com/repos/JaderDias/carbonapi","forks_url":"https://api.github.com/repos/JaderDias/carbonapi/forks","keys_url":"https://api.github.com/repos/JaderDias/carbonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JaderDias/carbonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JaderDias/carbonapi/teams","hooks_url":"https://api.github.com/repos/JaderDias/carbonapi/hooks","issue_events_url":"https://api.github.com/repos/JaderDias/carbonapi/issues/events{/number}","events_url":"https://api.github.com/repos/JaderDias/carbonapi/events","assignees_url":"https://api.github.com/repos/JaderDias/carbonapi/assignees{/user}","branches_url":"https://api.github.com/repos/JaderDias/carbonapi/branches{/branch}","tags_url":"https://api.github.com/repos/JaderDias/carbonapi/tags","blobs_url":"https://api.github.com/repos/JaderDias/carbonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JaderDias/carbonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JaderDias/carbonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/JaderDias/carbonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JaderDias/carbonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/JaderDias/carbonapi/languages","stargazers_url":"https://api.github.com/repos/JaderDias/carbonapi/stargazers","contributors_url":"https://api.github.com/repos/JaderDias/carbonapi/contributors","subscribers_url":"https://api.github.com/repos/JaderDias/carbonapi/subscribers","subscription_url":"https://api.github.com/repos/JaderDias/carbonapi/subscription","commits_url":"https://api.github.com/repos/JaderDias/carbonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/JaderDias/carbonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/JaderDias/carbonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/JaderDias/carbonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/JaderDias/carbonapi/contents/{+path}","compare_url":"https://api.github.com/repos/JaderDias/carbonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JaderDias/carbonapi/merges","archive_url":"https://api.github.com/repos/JaderDias/carbonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JaderDias/carbonapi/downloads","issues_url":"https://api.github.com/repos/JaderDias/carbonapi/issues{/number}","pulls_url":"https://api.github.com/repos/JaderDias/carbonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/JaderDias/carbonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/JaderDias/carbonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JaderDias/carbonapi/labels{/name}","releases_url":"https://api.github.com/repos/JaderDias/carbonapi/releases{/id}","created_at":"2015-05-26T22:32:13Z","updated_at":"2015-05-26T22:32:14Z","pushed_at":"2015-06-02T11:54:48Z","git_url":"git://github.com/JaderDias/carbonapi.git","ssh_url":"git@github.com:JaderDias/carbonapi.git","clone_url":"https://github.com/JaderDias/carbonapi.git","svn_url":"https://github.com/JaderDias/carbonapi","homepage":"","size":405,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dgryski:master","ref":"master","sha":"fabd96448b6f177b1a6b21b450288e21ddfcf5e4","user":{"login":"dgryski","id":970862,"avatar_url":"https://avatars.githubusercontent.com/u/970862?v=3","gravatar_id":"","url":"https://api.github.com/users/dgryski","html_url":"https://github.com/dgryski","followers_url":"https://api.github.com/users/dgryski/followers","following_url":"https://api.github.com/users/dgryski/following{/other_user}","gists_url":"https://api.github.com/users/dgryski/gists{/gist_id}","starred_url":"https://api.github.com/users/dgryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgryski/subscriptions","organizations_url":"https://api.github.com/users/dgryski/orgs","repos_url":"https://api.github.com/users/dgryski/repos","events_url":"https://api.github.com/users/dgryski/events{/privacy}","received_events_url":"https://api.github.com/users/dgryski/received_events","type":"User","site_admin":false},"repo":{"id":22234992,"name":"carbonapi","full_name":"dgryski/carbonapi","owner":{"login":"dgryski","id":970862,"avatar_url":"https://avatars.githubusercontent.com/u/970862?v=3","gravatar_id":"","url":"https://api.github.com/users/dgryski","html_url":"https://github.com/dgryski","followers_url":"https://api.github.com/users/dgryski/followers","following_url":"https://api.github.com/users/dgryski/following{/other_user}","gists_url":"https://api.github.com/users/dgryski/gists{/gist_id}","starred_url":"https://api.github.com/users/dgryski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgryski/subscriptions","organizations_url":"https://api.github.com/users/dgryski/orgs","repos_url":"https://api.github.com/users/dgryski/repos","events_url":"https://api.github.com/users/dgryski/events{/privacy}","received_events_url":"https://api.github.com/users/dgryski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgryski/carbonapi","description":"API server for github.com/dgryski/carbonzipper","fork":false,"url":"https://api.github.com/repos/dgryski/carbonapi","forks_url":"https://api.github.com/repos/dgryski/carbonapi/forks","keys_url":"https://api.github.com/repos/dgryski/carbonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgryski/carbonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgryski/carbonapi/teams","hooks_url":"https://api.github.com/repos/dgryski/carbonapi/hooks","issue_events_url":"https://api.github.com/repos/dgryski/carbonapi/issues/events{/number}","events_url":"https://api.github.com/repos/dgryski/carbonapi/events","assignees_url":"https://api.github.com/repos/dgryski/carbonapi/assignees{/user}","branches_url":"https://api.github.com/repos/dgryski/carbonapi/branches{/branch}","tags_url":"https://api.github.com/repos/dgryski/carbonapi/tags","blobs_url":"https://api.github.com/repos/dgryski/carbonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgryski/carbonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgryski/carbonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgryski/carbonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgryski/carbonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/dgryski/carbonapi/languages","stargazers_url":"https://api.github.com/repos/dgryski/carbonapi/stargazers","contributors_url":"https://api.github.com/repos/dgryski/carbonapi/contributors","subscribers_url":"https://api.github.com/repos/dgryski/carbonapi/subscribers","subscription_url":"https://api.github.com/repos/dgryski/carbonapi/subscription","commits_url":"https://api.github.com/repos/dgryski/carbonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgryski/carbonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgryski/carbonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgryski/carbonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgryski/carbonapi/contents/{+path}","compare_url":"https://api.github.com/repos/dgryski/carbonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgryski/carbonapi/merges","archive_url":"https://api.github.com/repos/dgryski/carbonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgryski/carbonapi/downloads","issues_url":"https://api.github.com/repos/dgryski/carbonapi/issues{/number}","pulls_url":"https://api.github.com/repos/dgryski/carbonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/dgryski/carbonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/dgryski/carbonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgryski/carbonapi/labels{/name}","releases_url":"https://api.github.com/repos/dgryski/carbonapi/releases{/id}","created_at":"2014-07-24T22:46:07Z","updated_at":"2015-06-02T08:48:17Z","pushed_at":"2015-06-02T11:55:29Z","git_url":"git://github.com/dgryski/carbonapi.git","ssh_url":"git@github.com:dgryski/carbonapi.git","clone_url":"https://github.com/dgryski/carbonapi.git","svn_url":"https://github.com/dgryski/carbonapi","homepage":"","size":1482,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":12,"forks":16,"open_issues":12,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/58"},"html":{"href":"https://github.com/dgryski/carbonapi/pull/58"},"issue":{"href":"https://api.github.com/repos/dgryski/carbonapi/issues/58"},"comments":{"href":"https://api.github.com/repos/dgryski/carbonapi/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgryski/carbonapi/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/dgryski/carbonapi/statuses/8c1e29f8d4a4ef80d06d9f9f180124ea5b37938f"}}}}