{"action":"created","issue":{"url":"https://api.github.com/repos/geany/geany-plugins/issues/203","labels_url":"https://api.github.com/repos/geany/geany-plugins/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/geany/geany-plugins/issues/203/comments","events_url":"https://api.github.com/repos/geany/geany-plugins/issues/203/events","html_url":"https://github.com/geany/geany-plugins/pull/203","id":63376576,"number":203,"title":"webhelper: replace depricated glib (>=2.32) functions","user":{"login":"vogon-poetic","id":11541292,"avatar_url":"https://avatars.githubusercontent.com/u/11541292?v=3","gravatar_id":"","url":"https://api.github.com/users/vogon-poetic","html_url":"https://github.com/vogon-poetic","followers_url":"https://api.github.com/users/vogon-poetic/followers","following_url":"https://api.github.com/users/vogon-poetic/following{/other_user}","gists_url":"https://api.github.com/users/vogon-poetic/gists{/gist_id}","starred_url":"https://api.github.com/users/vogon-poetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogon-poetic/subscriptions","organizations_url":"https://api.github.com/users/vogon-poetic/orgs","repos_url":"https://api.github.com/users/vogon-poetic/repos","events_url":"https://api.github.com/users/vogon-poetic/events{/privacy}","received_events_url":"https://api.github.com/users/vogon-poetic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-21T08:21:23Z","updated_at":"2015-03-21T13:38:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geany/geany-plugins/pulls/203","html_url":"https://github.com/geany/geany-plugins/pull/203","diff_url":"https://github.com/geany/geany-plugins/pull/203.diff","patch_url":"https://github.com/geany/geany-plugins/pull/203.patch"},"body":"The glib functions `g_value_set_char` and `g_thread_init`\r\nare depricated, throwing a GCC warning on their compilation.\r\nThis commit fixes the GCC warnings by removing the old\r\nfunction (`g_thread_init`), and changes a block in gwh-plugin.c \r\nto use the newer (`g_value_set_schar`)."},"comment":{"url":"https://api.github.com/repos/geany/geany-plugins/issues/comments/84336738","html_url":"https://github.com/geany/geany-plugins/pull/203#issuecomment-84336738","issue_url":"https://api.github.com/repos/geany/geany-plugins/issues/203","id":84336738,"user":{"login":"b4n","id":793526,"avatar_url":"https://avatars.githubusercontent.com/u/793526?v=3","gravatar_id":"","url":"https://api.github.com/users/b4n","html_url":"https://github.com/b4n","followers_url":"https://api.github.com/users/b4n/followers","following_url":"https://api.github.com/users/b4n/following{/other_user}","gists_url":"https://api.github.com/users/b4n/gists{/gist_id}","starred_url":"https://api.github.com/users/b4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b4n/subscriptions","organizations_url":"https://api.github.com/users/b4n/orgs","repos_url":"https://api.github.com/users/b4n/repos","events_url":"https://api.github.com/users/b4n/events{/privacy}","received_events_url":"https://api.github.com/users/b4n/received_events","type":"User","site_admin":false},"created_at":"2015-03-21T13:38:09Z","updated_at":"2015-03-21T13:38:09Z","body":"No.  I won't drop support for GLib < 2.32 for no good reason, and I don't think these are good reasons.  If you really mind the deprecation warnings, I see two acceptable (IMO) approaches:\r\n\r\n1. don't mind deprecation warnings, possibly using `-Wno-deprecated-declarations`.  If you build the GTK3 version of GP you'll see a *lot* of deprecation warnings, and most are just not really reasonably fixable without a *lot* of code addition just for this.\r\n\r\n2. I could accept a patch that switch to the non-deprecated variants on 2.32 onwards (e.g. guard with `#if GLIB_CHECK_VERSION`).  I don't really think it matters, but if you really care, well, okay."}}