{"action":"created","issue":{"url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/33","labels_url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/33/comments","events_url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/33/events","html_url":"https://github.com/f2prateek/rx-preferences/pull/33","id":106174133,"number":33,"title":"Convert Preference to an interface to allow easy mocking for unit tests","user":{"login":"dalewking","id":346062,"avatar_url":"https://avatars.githubusercontent.com/u/346062?v=3","gravatar_id":"","url":"https://api.github.com/users/dalewking","html_url":"https://github.com/dalewking","followers_url":"https://api.github.com/users/dalewking/followers","following_url":"https://api.github.com/users/dalewking/following{/other_user}","gists_url":"https://api.github.com/users/dalewking/gists{/gist_id}","starred_url":"https://api.github.com/users/dalewking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalewking/subscriptions","organizations_url":"https://api.github.com/users/dalewking/orgs","repos_url":"https://api.github.com/users/dalewking/repos","events_url":"https://api.github.com/users/dalewking/events{/privacy}","received_events_url":"https://api.github.com/users/dalewking/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-12T17:45:29Z","updated_at":"2015-09-12T19:19:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/f2prateek/rx-preferences/pulls/33","html_url":"https://github.com/f2prateek/rx-preferences/pull/33","diff_url":"https://github.com/f2prateek/rx-preferences/pull/33.diff","patch_url":"https://github.com/f2prateek/rx-preferences/pull/33.patch"},"body":"resolves #32"},"comment":{"url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/comments/139810867","html_url":"https://github.com/f2prateek/rx-preferences/pull/33#issuecomment-139810867","issue_url":"https://api.github.com/repos/f2prateek/rx-preferences/issues/33","id":139810867,"user":{"login":"JakeWharton","id":66577,"avatar_url":"https://avatars.githubusercontent.com/u/66577?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeWharton","html_url":"https://github.com/JakeWharton","followers_url":"https://api.github.com/users/JakeWharton/followers","following_url":"https://api.github.com/users/JakeWharton/following{/other_user}","gists_url":"https://api.github.com/users/JakeWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeWharton/subscriptions","organizations_url":"https://api.github.com/users/JakeWharton/orgs","repos_url":"https://api.github.com/users/JakeWharton/repos","events_url":"https://api.github.com/users/JakeWharton/events{/privacy}","received_events_url":"https://api.github.com/users/JakeWharton/received_events","type":"User","site_admin":false},"created_at":"2015-09-12T19:19:19Z","updated_at":"2015-09-12T19:19:19Z","body":"This is already a binary-incompatible change as is so it is breaking. And\nof course the implementation shouldn't be public.\n\nOn Sat, Sep 12, 2015, 1:50 PM Boycot Github <notifications@github.com>\nwrote:\n\n> You might want to rename the PreferenceImpl class to suit your taste and\n> you could actually make it non-public.\n>\n> In reality the Adapter interface makes a lot more sense in\n> RxSharedPreferences class rather than the Preference interface, but that\n> would be a breaking change to users of the library so I left it in\n> Preference interface.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/f2prateek/rx-preferences/pull/33#issuecomment-139799985>\n> .\n>\n"}}