{"action":"created","comment":{"url":"https://api.github.com/repos/conduit/conduit-rails/pulls/comments/28776545","id":28776545,"diff_hunk":"@@ -106,11 +142,9 @@ def generate_storage_path\n       #\n       def notify_subscribers\n         return unless last_response = responses.last\n-        subscribers.each do |subscriber|\n-          next unless subscriber.respond_to?(:after_conduit_update)\n-\n-          subscriber.after_conduit_update(action,\n-            last_response.parsed_content)\n+        subscriptions.each do |subscription|\n+          subscription.handle_conduit_response(action, last_response)\n+          # What to do if one of them fail? Keep going? Cry about it?","path":"app/models/conduit/request.rb","position":67,"original_position":67,"commit_id":"2853a9b4e4adc8c31766e79020b8c278c1213929","original_commit_id":"2853a9b4e4adc8c31766e79020b8c278c1213929","user":{"login":"pedromartinez","id":228088,"avatar_url":"https://avatars.githubusercontent.com/u/228088?v=3","gravatar_id":"","url":"https://api.github.com/users/pedromartinez","html_url":"https://github.com/pedromartinez","followers_url":"https://api.github.com/users/pedromartinez/followers","following_url":"https://api.github.com/users/pedromartinez/following{/other_user}","gists_url":"https://api.github.com/users/pedromartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/pedromartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedromartinez/subscriptions","organizations_url":"https://api.github.com/users/pedromartinez/orgs","repos_url":"https://api.github.com/users/pedromartinez/repos","events_url":"https://api.github.com/users/pedromartinez/events{/privacy}","received_events_url":"https://api.github.com/users/pedromartinez/received_events","type":"User","site_admin":false},"body":":sob: ","created_at":"2015-04-21T13:24:20Z","updated_at":"2015-04-21T13:24:20Z","html_url":"https://github.com/conduit/conduit-rails/pull/8#discussion_r28776545","pull_request_url":"https://api.github.com/repos/conduit/conduit-rails/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/comments/28776545"},"html":{"href":"https://github.com/conduit/conduit-rails/pull/8#discussion_r28776545"},"pull_request":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/conduit/conduit-rails/pulls/8","id":33685821,"html_url":"https://github.com/conduit/conduit-rails/pull/8","diff_url":"https://github.com/conduit/conduit-rails/pull/8.diff","patch_url":"https://github.com/conduit/conduit-rails/pull/8.patch","issue_url":"https://api.github.com/repos/conduit/conduit-rails/issues/8","number":8,"state":"open","locked":false,"title":"Revise request subscriptions to make them more flexible","user":{"login":"captainbeardo","id":834135,"avatar_url":"https://avatars.githubusercontent.com/u/834135?v=3","gravatar_id":"","url":"https://api.github.com/users/captainbeardo","html_url":"https://github.com/captainbeardo","followers_url":"https://api.github.com/users/captainbeardo/followers","following_url":"https://api.github.com/users/captainbeardo/following{/other_user}","gists_url":"https://api.github.com/users/captainbeardo/gists{/gist_id}","starred_url":"https://api.github.com/users/captainbeardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainbeardo/subscriptions","organizations_url":"https://api.github.com/users/captainbeardo/orgs","repos_url":"https://api.github.com/users/captainbeardo/repos","events_url":"https://api.github.com/users/captainbeardo/events{/privacy}","received_events_url":"https://api.github.com/users/captainbeardo/received_events","type":"User","site_admin":false},"body":"This allows subscriptions to not require an ActiveRecord object, but instead take class and options. The change was made so that a response could be handled from a separate object that was not the object that initiated the request.","created_at":"2015-04-20T17:08:56Z","updated_at":"2015-04-21T13:24:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1067553e0add38160a930f540f72811e3a708a64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/conduit/conduit-rails/pulls/8/commits","review_comments_url":"https://api.github.com/repos/conduit/conduit-rails/pulls/8/comments","review_comment_url":"https://api.github.com/repos/conduit/conduit-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conduit/conduit-rails/issues/8/comments","statuses_url":"https://api.github.com/repos/conduit/conduit-rails/statuses/2853a9b4e4adc8c31766e79020b8c278c1213929","head":{"label":"conduit:AR-154-Refactor_request_subscriptions","ref":"AR-154-Refactor_request_subscriptions","sha":"2853a9b4e4adc8c31766e79020b8c278c1213929","user":{"login":"conduit","id":7139444,"avatar_url":"https://avatars.githubusercontent.com/u/7139444?v=3","gravatar_id":"","url":"https://api.github.com/users/conduit","html_url":"https://github.com/conduit","followers_url":"https://api.github.com/users/conduit/followers","following_url":"https://api.github.com/users/conduit/following{/other_user}","gists_url":"https://api.github.com/users/conduit/gists{/gist_id}","starred_url":"https://api.github.com/users/conduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conduit/subscriptions","organizations_url":"https://api.github.com/users/conduit/orgs","repos_url":"https://api.github.com/users/conduit/repos","events_url":"https://api.github.com/users/conduit/events{/privacy}","received_events_url":"https://api.github.com/users/conduit/received_events","type":"Organization","site_admin":false},"repo":{"id":20575087,"name":"conduit-rails","full_name":"conduit/conduit-rails","owner":{"login":"conduit","id":7139444,"avatar_url":"https://avatars.githubusercontent.com/u/7139444?v=3","gravatar_id":"","url":"https://api.github.com/users/conduit","html_url":"https://github.com/conduit","followers_url":"https://api.github.com/users/conduit/followers","following_url":"https://api.github.com/users/conduit/following{/other_user}","gists_url":"https://api.github.com/users/conduit/gists{/gist_id}","starred_url":"https://api.github.com/users/conduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conduit/subscriptions","organizations_url":"https://api.github.com/users/conduit/orgs","repos_url":"https://api.github.com/users/conduit/repos","events_url":"https://api.github.com/users/conduit/events{/privacy}","received_events_url":"https://api.github.com/users/conduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conduit/conduit-rails","description":"","fork":false,"url":"https://api.github.com/repos/conduit/conduit-rails","forks_url":"https://api.github.com/repos/conduit/conduit-rails/forks","keys_url":"https://api.github.com/repos/conduit/conduit-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conduit/conduit-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conduit/conduit-rails/teams","hooks_url":"https://api.github.com/repos/conduit/conduit-rails/hooks","issue_events_url":"https://api.github.com/repos/conduit/conduit-rails/issues/events{/number}","events_url":"https://api.github.com/repos/conduit/conduit-rails/events","assignees_url":"https://api.github.com/repos/conduit/conduit-rails/assignees{/user}","branches_url":"https://api.github.com/repos/conduit/conduit-rails/branches{/branch}","tags_url":"https://api.github.com/repos/conduit/conduit-rails/tags","blobs_url":"https://api.github.com/repos/conduit/conduit-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conduit/conduit-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conduit/conduit-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/conduit/conduit-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conduit/conduit-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/conduit/conduit-rails/languages","stargazers_url":"https://api.github.com/repos/conduit/conduit-rails/stargazers","contributors_url":"https://api.github.com/repos/conduit/conduit-rails/contributors","subscribers_url":"https://api.github.com/repos/conduit/conduit-rails/subscribers","subscription_url":"https://api.github.com/repos/conduit/conduit-rails/subscription","commits_url":"https://api.github.com/repos/conduit/conduit-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/conduit/conduit-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/conduit/conduit-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/conduit/conduit-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/conduit/conduit-rails/contents/{+path}","compare_url":"https://api.github.com/repos/conduit/conduit-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conduit/conduit-rails/merges","archive_url":"https://api.github.com/repos/conduit/conduit-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conduit/conduit-rails/downloads","issues_url":"https://api.github.com/repos/conduit/conduit-rails/issues{/number}","pulls_url":"https://api.github.com/repos/conduit/conduit-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/conduit/conduit-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/conduit/conduit-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conduit/conduit-rails/labels{/name}","releases_url":"https://api.github.com/repos/conduit/conduit-rails/releases{/id}","created_at":"2014-06-06T19:13:14Z","updated_at":"2014-09-05T20:49:46Z","pushed_at":"2015-04-20T21:19:07Z","git_url":"git://github.com/conduit/conduit-rails.git","ssh_url":"git@github.com:conduit/conduit-rails.git","clone_url":"https://github.com/conduit/conduit-rails.git","svn_url":"https://github.com/conduit/conduit-rails","homepage":null,"size":276,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"conduit:master","ref":"master","sha":"0426432ce6b7e1e217ade5085516d6cdebf2eada","user":{"login":"conduit","id":7139444,"avatar_url":"https://avatars.githubusercontent.com/u/7139444?v=3","gravatar_id":"","url":"https://api.github.com/users/conduit","html_url":"https://github.com/conduit","followers_url":"https://api.github.com/users/conduit/followers","following_url":"https://api.github.com/users/conduit/following{/other_user}","gists_url":"https://api.github.com/users/conduit/gists{/gist_id}","starred_url":"https://api.github.com/users/conduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conduit/subscriptions","organizations_url":"https://api.github.com/users/conduit/orgs","repos_url":"https://api.github.com/users/conduit/repos","events_url":"https://api.github.com/users/conduit/events{/privacy}","received_events_url":"https://api.github.com/users/conduit/received_events","type":"Organization","site_admin":false},"repo":{"id":20575087,"name":"conduit-rails","full_name":"conduit/conduit-rails","owner":{"login":"conduit","id":7139444,"avatar_url":"https://avatars.githubusercontent.com/u/7139444?v=3","gravatar_id":"","url":"https://api.github.com/users/conduit","html_url":"https://github.com/conduit","followers_url":"https://api.github.com/users/conduit/followers","following_url":"https://api.github.com/users/conduit/following{/other_user}","gists_url":"https://api.github.com/users/conduit/gists{/gist_id}","starred_url":"https://api.github.com/users/conduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conduit/subscriptions","organizations_url":"https://api.github.com/users/conduit/orgs","repos_url":"https://api.github.com/users/conduit/repos","events_url":"https://api.github.com/users/conduit/events{/privacy}","received_events_url":"https://api.github.com/users/conduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conduit/conduit-rails","description":"","fork":false,"url":"https://api.github.com/repos/conduit/conduit-rails","forks_url":"https://api.github.com/repos/conduit/conduit-rails/forks","keys_url":"https://api.github.com/repos/conduit/conduit-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conduit/conduit-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conduit/conduit-rails/teams","hooks_url":"https://api.github.com/repos/conduit/conduit-rails/hooks","issue_events_url":"https://api.github.com/repos/conduit/conduit-rails/issues/events{/number}","events_url":"https://api.github.com/repos/conduit/conduit-rails/events","assignees_url":"https://api.github.com/repos/conduit/conduit-rails/assignees{/user}","branches_url":"https://api.github.com/repos/conduit/conduit-rails/branches{/branch}","tags_url":"https://api.github.com/repos/conduit/conduit-rails/tags","blobs_url":"https://api.github.com/repos/conduit/conduit-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conduit/conduit-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conduit/conduit-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/conduit/conduit-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conduit/conduit-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/conduit/conduit-rails/languages","stargazers_url":"https://api.github.com/repos/conduit/conduit-rails/stargazers","contributors_url":"https://api.github.com/repos/conduit/conduit-rails/contributors","subscribers_url":"https://api.github.com/repos/conduit/conduit-rails/subscribers","subscription_url":"https://api.github.com/repos/conduit/conduit-rails/subscription","commits_url":"https://api.github.com/repos/conduit/conduit-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/conduit/conduit-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/conduit/conduit-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/conduit/conduit-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/conduit/conduit-rails/contents/{+path}","compare_url":"https://api.github.com/repos/conduit/conduit-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conduit/conduit-rails/merges","archive_url":"https://api.github.com/repos/conduit/conduit-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conduit/conduit-rails/downloads","issues_url":"https://api.github.com/repos/conduit/conduit-rails/issues{/number}","pulls_url":"https://api.github.com/repos/conduit/conduit-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/conduit/conduit-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/conduit/conduit-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conduit/conduit-rails/labels{/name}","releases_url":"https://api.github.com/repos/conduit/conduit-rails/releases{/id}","created_at":"2014-06-06T19:13:14Z","updated_at":"2014-09-05T20:49:46Z","pushed_at":"2015-04-20T21:19:07Z","git_url":"git://github.com/conduit/conduit-rails.git","ssh_url":"git@github.com:conduit/conduit-rails.git","clone_url":"https://github.com/conduit/conduit-rails.git","svn_url":"https://github.com/conduit/conduit-rails","homepage":null,"size":276,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/8"},"html":{"href":"https://github.com/conduit/conduit-rails/pull/8"},"issue":{"href":"https://api.github.com/repos/conduit/conduit-rails/issues/8"},"comments":{"href":"https://api.github.com/repos/conduit/conduit-rails/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conduit/conduit-rails/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/conduit/conduit-rails/statuses/2853a9b4e4adc8c31766e79020b8c278c1213929"}}}}