{"action":"created","issue":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/59","labels_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/59/comments","events_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/59/events","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/59","id":122652859,"number":59,"title":"Minor updates to ENOutputWrapper.py; Adding OutDiff.py","user":{"login":"bemcdonnell","id":6105134,"avatar_url":"https://avatars.githubusercontent.com/u/6105134?v=3","gravatar_id":"","url":"https://api.github.com/users/bemcdonnell","html_url":"https://github.com/bemcdonnell","followers_url":"https://api.github.com/users/bemcdonnell/followers","following_url":"https://api.github.com/users/bemcdonnell/following{/other_user}","gists_url":"https://api.github.com/users/bemcdonnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bemcdonnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemcdonnell/subscriptions","organizations_url":"https://api.github.com/users/bemcdonnell/orgs","repos_url":"https://api.github.com/users/bemcdonnell/repos","events_url":"https://api.github.com/users/bemcdonnell/events{/privacy}","received_events_url":"https://api.github.com/users/bemcdonnell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-17T03:20:53Z","updated_at":"2015-12-17T15:06:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/59","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/59","diff_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/59.diff","patch_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/59.patch"},"body":"#16 @samhatchett, I pulled together a very simple function to compare the output files.  This is command line ready and returns a True/False for pass/fail. @michaeltryby suggested that I keep this more simple instead of taking the min(-log (abs (v1-v2)) as @jamesuber suggested.  Once you get this into the testing process, we can make changes as needed.\r\n\r\nThe function loops through the attributes for all nodes at time t (currently the fastest way to parse the output file using the @michaeltryby's API).  The absolute difference of each value is compared against the allowable threshold.  If value passes the allowable threshold, the function wastes no time to return False.  \r\n\r\nPlease feel free to make any changes to this! I will be out for a few days and I wanted to give you all a starting point. "},"comment":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/comments/165478099","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/59#issuecomment-165478099","issue_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/59","id":165478099,"user":{"login":"michaeltryby","id":6942309,"avatar_url":"https://avatars.githubusercontent.com/u/6942309?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeltryby","html_url":"https://github.com/michaeltryby","followers_url":"https://api.github.com/users/michaeltryby/followers","following_url":"https://api.github.com/users/michaeltryby/following{/other_user}","gists_url":"https://api.github.com/users/michaeltryby/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltryby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltryby/subscriptions","organizations_url":"https://api.github.com/users/michaeltryby/orgs","repos_url":"https://api.github.com/users/michaeltryby/repos","events_url":"https://api.github.com/users/michaeltryby/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltryby/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T15:06:24Z","updated_at":"2015-12-17T15:06:24Z","body":"The idea here is to create something quickly to cover the Travis CI testing use case - compare two binary files as efficiently as possible and return True or False. This script is not meant to provide detailed information about the differences present or their significance. Thus, the min(-log(abs(v1-v2))) was omitted for the sake of efficiency. \r\n\r\nObviously, it would be straight forward to expand the script to provide more detailed information if this is where we want to cover the more detailed testing use case. \r\n"}}