{"action":"created","issue":{"url":"https://api.github.com/repos/bartvm/blocks/issues/567","labels_url":"https://api.github.com/repos/bartvm/blocks/issues/567/labels{/name}","comments_url":"https://api.github.com/repos/bartvm/blocks/issues/567/comments","events_url":"https://api.github.com/repos/bartvm/blocks/issues/567/events","html_url":"https://github.com/bartvm/blocks/pull/567","id":65243390,"number":567,"title":"Create default Fork in BaseSequenceGenerator","user":{"login":"rizar","id":654434,"avatar_url":"https://avatars.githubusercontent.com/u/654434?v=3","gravatar_id":"","url":"https://api.github.com/users/rizar","html_url":"https://github.com/rizar","followers_url":"https://api.github.com/users/rizar/followers","following_url":"https://api.github.com/users/rizar/following{/other_user}","gists_url":"https://api.github.com/users/rizar/gists{/gist_id}","starred_url":"https://api.github.com/users/rizar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizar/subscriptions","organizations_url":"https://api.github.com/users/rizar/orgs","repos_url":"https://api.github.com/users/rizar/repos","events_url":"https://api.github.com/users/rizar/events{/privacy}","received_events_url":"https://api.github.com/users/rizar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-30T15:53:34Z","updated_at":"2015-03-31T13:26:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bartvm/blocks/pulls/567","html_url":"https://github.com/bartvm/blocks/pull/567","diff_url":"https://github.com/bartvm/blocks/pull/567.diff","patch_url":"https://github.com/bartvm/blocks/pull/567.patch"},"body":"A better way to implement functionality from #566"},"comment":{"url":"https://api.github.com/repos/bartvm/blocks/issues/comments/88084010","html_url":"https://github.com/bartvm/blocks/pull/567#issuecomment-88084010","issue_url":"https://api.github.com/repos/bartvm/blocks/issues/567","id":88084010,"user":{"login":"bartvm","id":2299595,"avatar_url":"https://avatars.githubusercontent.com/u/2299595?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvm","html_url":"https://github.com/bartvm","followers_url":"https://api.github.com/users/bartvm/followers","following_url":"https://api.github.com/users/bartvm/following{/other_user}","gists_url":"https://api.github.com/users/bartvm/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvm/subscriptions","organizations_url":"https://api.github.com/users/bartvm/orgs","repos_url":"https://api.github.com/users/bartvm/repos","events_url":"https://api.github.com/users/bartvm/events{/privacy}","received_events_url":"https://api.github.com/users/bartvm/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T13:26:58Z","updated_at":"2015-03-31T13:26:58Z","body":"> Because fork is a keyword argument of the superclass, BaseSequenceGenerator. One typically does not repeat keyword argument of the superclass in the constructor signature.\r\n\r\nWhy not? I don't repeat the keyword argument if it's not used in the child class (e.g. `name` for bricks), but if the keyword argument is used in the child class, and a default is set in the child class, then the keyword argument should be repeated IMHO. I find `fork=None` followed by `if fork is None` is much clearer than `kwargs.setdefault('fork', ...)`."}}