{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2581","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2581/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2581/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2581/events","html_url":"https://github.com/aspnet/EntityFramework/issues/2581","id":93962342,"number":2581,"title":"NotNull vs NotEmpty","user":{"login":"ErikEJ","id":4169187,"avatar_url":"https://avatars.githubusercontent.com/u/4169187?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikEJ","html_url":"https://github.com/ErikEJ","followers_url":"https://api.github.com/users/ErikEJ/followers","following_url":"https://api.github.com/users/ErikEJ/following{/other_user}","gists_url":"https://api.github.com/users/ErikEJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikEJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikEJ/subscriptions","organizations_url":"https://api.github.com/users/ErikEJ/orgs","repos_url":"https://api.github.com/users/ErikEJ/repos","events_url":"https://api.github.com/users/ErikEJ/events{/privacy}","received_events_url":"https://api.github.com/users/ErikEJ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-09T05:49:38Z","updated_at":"2015-07-09T16:03:17Z","closed_at":null,"body":"     public virtual Task<IReadOnlyList<string>> ReverseEngineerAsync(\r\n            [NotNull] string runtimeProviderAssemblyName,\r\n            [NotNull] string connectionString,\r\n            [NotNull] string rootNamespace,\r\n            [NotNull] string projectDir,\r\n            CancellationToken cancellationToken = default(CancellationToken))\r\n        {\r\n            *Check.NotNull(runtimeProviderAssemblyName, nameof(runtimeProviderAssemblyName));*\r\n            Check.NotEmpty(connectionString, nameof(connectionString));\r\n            Check.NotEmpty(rootNamespace, nameof(rootNamespace));\r\n            Check.NotEmpty(projectDir, nameof(projectDir));\r\n\r\nWhy check.NotNull here, and not Check.NotEmpty?"},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments/120049845","html_url":"https://github.com/aspnet/EntityFramework/issues/2581#issuecomment-120049845","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2581","id":120049845,"user":{"login":"lajones","id":1915927,"avatar_url":"https://avatars.githubusercontent.com/u/1915927?v=3","gravatar_id":"","url":"https://api.github.com/users/lajones","html_url":"https://github.com/lajones","followers_url":"https://api.github.com/users/lajones/followers","following_url":"https://api.github.com/users/lajones/following{/other_user}","gists_url":"https://api.github.com/users/lajones/gists{/gist_id}","starred_url":"https://api.github.com/users/lajones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lajones/subscriptions","organizations_url":"https://api.github.com/users/lajones/orgs","repos_url":"https://api.github.com/users/lajones/repos","events_url":"https://api.github.com/users/lajones/events{/privacy}","received_events_url":"https://api.github.com/users/lajones/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T16:03:17Z","updated_at":"2015-07-09T16:03:17Z","body":"Correct. Should be NotEmpty. Maybe a leftover from when we passed around the actual assembly rather than it's name."}}