{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/44856308","id":44856308,"diff_hunk":"@@ -4975,14 +4974,6 @@ olx.source.ImageStaticOptions.prototype.imageExtent;\n \n \n /**\n- * Size of the image in pixels.\n- * @type {ol.Size|undefined}\n- * @api stable\n- */\n-olx.source.ImageStaticOptions.prototype.imageSize;","path":"externs/olx.js","position":25,"original_position":25,"commit_id":"6280b35035976048aca697c3641508940da22e7b","original_commit_id":"6280b35035976048aca697c3641508940da22e7b","user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"body":"Looks like it makes sense then to bring the imageSize property back. Will incorporate all of @tschaub's suggestions in the follow up pull request.","created_at":"2015-11-14T07:55:06Z","updated_at":"2015-11-14T07:55:06Z","html_url":"https://github.com/openlayers/ol3/pull/4415#discussion_r44856308","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/4415","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/44856308"},"html":{"href":"https://github.com/openlayers/ol3/pull/4415#discussion_r44856308"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4415"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/4415","id":50629746,"html_url":"https://github.com/openlayers/ol3/pull/4415","diff_url":"https://github.com/openlayers/ol3/pull/4415.diff","patch_url":"https://github.com/openlayers/ol3/pull/4415.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/4415","number":4415,"state":"closed","locked":false,"title":"Scale StaticImage image to imageExtent","user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"body":"The imageSize property was only used to determine the scale. It's usage was never documented nor tested nor shown in an example, so I removed it because I considered its presence a bug.\r\n\r\nFixes #2844.","created_at":"2015-11-13T11:16:28Z","updated_at":"2015-11-14T07:55:06Z","closed_at":"2015-11-13T12:15:46Z","merged_at":"2015-11-13T12:15:46Z","merge_commit_sha":"874e18cacaa9c7b9fcb46970e1126c9875658f04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/4415/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/4415/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/4415/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/6280b35035976048aca697c3641508940da22e7b","head":{"label":"ahocevar:fix-imagesize","ref":"fix-imagesize","sha":"6280b35035976048aca697c3641508940da22e7b","user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"repo":{"id":4974939,"name":"ol3","full_name":"ahocevar/ol3","owner":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars.githubusercontent.com/u/211514?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahocevar/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/ahocevar/ol3","forks_url":"https://api.github.com/repos/ahocevar/ol3/forks","keys_url":"https://api.github.com/repos/ahocevar/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahocevar/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahocevar/ol3/teams","hooks_url":"https://api.github.com/repos/ahocevar/ol3/hooks","issue_events_url":"https://api.github.com/repos/ahocevar/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/ahocevar/ol3/events","assignees_url":"https://api.github.com/repos/ahocevar/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/ahocevar/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/ahocevar/ol3/tags","blobs_url":"https://api.github.com/repos/ahocevar/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahocevar/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahocevar/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahocevar/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahocevar/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/ahocevar/ol3/languages","stargazers_url":"https://api.github.com/repos/ahocevar/ol3/stargazers","contributors_url":"https://api.github.com/repos/ahocevar/ol3/contributors","subscribers_url":"https://api.github.com/repos/ahocevar/ol3/subscribers","subscription_url":"https://api.github.com/repos/ahocevar/ol3/subscription","commits_url":"https://api.github.com/repos/ahocevar/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahocevar/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahocevar/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahocevar/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahocevar/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/ahocevar/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahocevar/ol3/merges","archive_url":"https://api.github.com/repos/ahocevar/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahocevar/ol3/downloads","issues_url":"https://api.github.com/repos/ahocevar/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/ahocevar/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/ahocevar/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/ahocevar/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahocevar/ol3/labels{/name}","releases_url":"https://api.github.com/repos/ahocevar/ol3/releases{/id}","created_at":"2012-07-10T14:11:39Z","updated_at":"2015-04-21T14:20:28Z","pushed_at":"2015-11-13T12:15:54Z","git_url":"git://github.com/ahocevar/ol3.git","ssh_url":"git@github.com:ahocevar/ol3.git","clone_url":"https://github.com/ahocevar/ol3.git","svn_url":"https://github.com/ahocevar/ol3","homepage":null,"size":57654,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dist-css"}},"base":{"label":"openlayers:master","ref":"master","sha":"4a97e26bd99a9a4a6ee1567f72131ac1ce6b8e03","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","created_at":"2012-06-20T06:53:59Z","updated_at":"2015-11-13T17:26:37Z","pushed_at":"2015-11-13T16:22:56Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"http://openlayers.org","size":103338,"stargazers_count":1492,"watchers_count":1492,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":845,"mirror_url":null,"open_issues_count":363,"forks":845,"open_issues":363,"watchers":1492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4415"},"html":{"href":"https://github.com/openlayers/ol3/pull/4415"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4415"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/4415/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4415/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/4415/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/6280b35035976048aca697c3641508940da22e7b"}}}}