{"action":"closed","number":30310,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/30310","id":53311534,"html_url":"https://github.com/rust-lang/rust/pull/30310","diff_url":"https://github.com/rust-lang/rust/pull/30310.diff","patch_url":"https://github.com/rust-lang/rust/pull/30310.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/30310","number":30310,"state":"closed","locked":false,"title":"Document bounds checking in the book","user":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"body":"r? @steveklabnik\n\nCurrently neither the API docs nor the book clearly explain that out-of-bounds array indexing causes a panic.  Since this is fairly important and seems to surprise a number of new Rust programmers, I think it's worth adding to both places.  (But if you think it would be better to put this info in the API docs only, that's fine too.)\n\nSome specific things I'd like feedback on:\n\n* The new text here talks about panicking, which hasn't been formally introduced at this point in chapter 5 (though it has been mentioned in previous sections too).\n* Similarly the `Vec::get` example uses `Option<T>` which hasn't been fully introduced yet.  Should we leave out this example?","created_at":"2015-12-10T20:24:08Z","updated_at":"2015-12-13T05:18:25Z","closed_at":"2015-12-13T05:18:25Z","merged_at":"2015-12-13T05:18:25Z","merge_commit_sha":"40ddeed34f11d66b1bf047ba696db61b8c83e940","assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/30310/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/30310/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/30310/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/5b9dd6a016adb5ed67e150643fb7e21dcc916845","head":{"label":"mbrubeck:doc-vec-bounds","ref":"doc-vec-bounds","sha":"5b9dd6a016adb5ed67e150643fb7e21dcc916845","user":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"repo":{"id":763569,"name":"rust","full_name":"mbrubeck/rust","owner":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbrubeck/rust","description":"A new application/system programming language being developed at Mozilla","fork":true,"url":"https://api.github.com/repos/mbrubeck/rust","forks_url":"https://api.github.com/repos/mbrubeck/rust/forks","keys_url":"https://api.github.com/repos/mbrubeck/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbrubeck/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbrubeck/rust/teams","hooks_url":"https://api.github.com/repos/mbrubeck/rust/hooks","issue_events_url":"https://api.github.com/repos/mbrubeck/rust/issues/events{/number}","events_url":"https://api.github.com/repos/mbrubeck/rust/events","assignees_url":"https://api.github.com/repos/mbrubeck/rust/assignees{/user}","branches_url":"https://api.github.com/repos/mbrubeck/rust/branches{/branch}","tags_url":"https://api.github.com/repos/mbrubeck/rust/tags","blobs_url":"https://api.github.com/repos/mbrubeck/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbrubeck/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbrubeck/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbrubeck/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbrubeck/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/mbrubeck/rust/languages","stargazers_url":"https://api.github.com/repos/mbrubeck/rust/stargazers","contributors_url":"https://api.github.com/repos/mbrubeck/rust/contributors","subscribers_url":"https://api.github.com/repos/mbrubeck/rust/subscribers","subscription_url":"https://api.github.com/repos/mbrubeck/rust/subscription","commits_url":"https://api.github.com/repos/mbrubeck/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbrubeck/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbrubeck/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbrubeck/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbrubeck/rust/contents/{+path}","compare_url":"https://api.github.com/repos/mbrubeck/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbrubeck/rust/merges","archive_url":"https://api.github.com/repos/mbrubeck/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbrubeck/rust/downloads","issues_url":"https://api.github.com/repos/mbrubeck/rust/issues{/number}","pulls_url":"https://api.github.com/repos/mbrubeck/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/mbrubeck/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/mbrubeck/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbrubeck/rust/labels{/name}","releases_url":"https://api.github.com/repos/mbrubeck/rust/releases{/id}","created_at":"2010-07-08T09:27:52Z","updated_at":"2015-04-06T15:41:47Z","pushed_at":"2015-12-11T14:18:24Z","git_url":"git://github.com/mbrubeck/rust.git","ssh_url":"git@github.com:mbrubeck/rust.git","clone_url":"https://github.com/mbrubeck/rust.git","svn_url":"https://github.com/mbrubeck/rust","homepage":"http://www.rust-lang.org","size":331171,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"81dd3824ff4f4f85db2a092dab78e5e6c05f96cc","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-12-13T02:34:44Z","pushed_at":"2015-12-13T05:18:20Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":393433,"stargazers_count":14549,"watchers_count":14549,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2831,"mirror_url":null,"open_issues_count":2362,"forks":2831,"open_issues":2362,"watchers":14549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30310"},"html":{"href":"https://github.com/rust-lang/rust/pull/30310"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/30310"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/30310/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30310/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/30310/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/5b9dd6a016adb5ed67e150643fb7e21dcc916845"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":10,"review_comments":1,"commits":1,"additions":30,"deletions":0,"changed_files":1}}