{"action":"created","issue":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/252","labels_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/252/comments","events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/252/events","html_url":"https://github.com/KnpLabs/KnpMenuBundle/issues/252","id":53549631,"number":252,"title":"Suggest making the trans filter standard instead of having to extend the knp_menu.html.twig","user":{"login":"jenswegar","id":647808,"avatar_url":"https://avatars.githubusercontent.com/u/647808?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswegar","html_url":"https://github.com/jenswegar","followers_url":"https://api.github.com/users/jenswegar/followers","following_url":"https://api.github.com/users/jenswegar/following{/other_user}","gists_url":"https://api.github.com/users/jenswegar/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswegar/subscriptions","organizations_url":"https://api.github.com/users/jenswegar/orgs","repos_url":"https://api.github.com/users/jenswegar/repos","events_url":"https://api.github.com/users/jenswegar/events{/privacy}","received_events_url":"https://api.github.com/users/jenswegar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-06T19:01:03Z","updated_at":"2015-08-28T10:03:26Z","closed_at":null,"body":"Given that all apps these days should be prepared for translation from the get go, I'm wondering if it would be any idea to simplify the translation process of menu items by adding the trans filter to the default knp_menu.html.twig instead of the developer having to extend the default template just to add translation support? Or is there a technical/design reason it's not part of the default template? Afaik there really is no performance penalty since the menu is cached in production anyway?"},"comment":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/comments/135725622","html_url":"https://github.com/KnpLabs/KnpMenuBundle/issues/252#issuecomment-135725622","issue_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/252","id":135725622,"user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T10:03:26Z","updated_at":"2015-08-28T10:03:26Z","body":"I think we should include this. This would mean creating a template in this bundle and doing:\r\n```jinja\r\n{% extends 'knp_menu.html.twig' %}\r\n\r\n{% block label %}{{ parent()|trans(...) }}{% endblock %}\r\n```\r\n\r\n/cc @dbu @stof"}}