{"action":"opened","number":819,"pull_request":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/819","id":38941998,"html_url":"https://github.com/slamdata/slamengine/pull/819","diff_url":"https://github.com/slamdata/slamengine/pull/819.diff","patch_url":"https://github.com/slamdata/slamengine/pull/819.patch","issue_url":"https://api.github.com/repos/slamdata/slamengine/issues/819","number":819,"state":"open","locked":false,"title":"consistently return errors in JSON (fixes #757)","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Every error case now has a test that asserts that the response:\n\n1. is in JSON format (with the right content type) 2. contains a field `error` \n3. with the expected error message\n\nThis uncovered *many* cases where errors were in plain text, or did not have a\nproperly formatted `error` message, or were being trapped in the wrong place,\nor had an unnecessary stack trace.\n\nAlso fixed handling of parse errors in the API and the REPL (a recent\nregression).\n\nEliminated curly quotes in responses, because they don't render right in\nspecs2 output.","created_at":"2015-07-01T01:57:14Z","updated_at":"2015-07-01T01:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamengine/pulls/819/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamengine/pulls/819/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/slamengine/issues/819/comments","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/463f1a123569ecd227cb7a0eb8ec557126ac7e3c","head":{"label":"mossprescott:ready/757","ref":"ready/757","sha":"463f1a123569ecd227cb7a0eb8ec557126ac7e3c","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"slamengine","full_name":"mossprescott/slamengine","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/slamengine","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/slamengine","forks_url":"https://api.github.com/repos/mossprescott/slamengine/forks","keys_url":"https://api.github.com/repos/mossprescott/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/slamengine/teams","hooks_url":"https://api.github.com/repos/mossprescott/slamengine/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/slamengine/events","assignees_url":"https://api.github.com/repos/mossprescott/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/slamengine/tags","blobs_url":"https://api.github.com/repos/mossprescott/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/slamengine/languages","stargazers_url":"https://api.github.com/repos/mossprescott/slamengine/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/slamengine/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/slamengine/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/slamengine/subscription","commits_url":"https://api.github.com/repos/mossprescott/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/slamengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/mossprescott/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/slamengine/merges","archive_url":"https://api.github.com/repos/mossprescott/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/slamengine/downloads","issues_url":"https://api.github.com/repos/mossprescott/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/slamengine/releases{/id}","created_at":"2014-06-24T19:43:22Z","updated_at":"2015-01-08T17:19:20Z","pushed_at":"2015-07-01T01:53:56Z","git_url":"git://github.com/mossprescott/slamengine.git","ssh_url":"git@github.com:mossprescott/slamengine.git","clone_url":"https://github.com/mossprescott/slamengine.git","svn_url":"https://github.com/mossprescott/slamengine","homepage":null,"size":7009,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"slamdata:master","ref":"master","sha":"9169ad2e634687d9153e8687f304285069146944","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"slamengine","full_name":"slamdata/slamengine","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamengine","description":"The engine for SlamData","fork":false,"url":"https://api.github.com/repos/slamdata/slamengine","forks_url":"https://api.github.com/repos/slamdata/slamengine/forks","keys_url":"https://api.github.com/repos/slamdata/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamengine/teams","hooks_url":"https://api.github.com/repos/slamdata/slamengine/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamengine/events","assignees_url":"https://api.github.com/repos/slamdata/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamengine/tags","blobs_url":"https://api.github.com/repos/slamdata/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamengine/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamengine/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamengine/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamengine/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamengine/subscription","commits_url":"https://api.github.com/repos/slamdata/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamengine/merges","archive_url":"https://api.github.com/repos/slamdata/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamengine/downloads","issues_url":"https://api.github.com/repos/slamdata/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamengine/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2015-06-12T16:43:09Z","pushed_at":"2015-06-30T15:05:36Z","git_url":"git://github.com/slamdata/slamengine.git","ssh_url":"git@github.com:slamdata/slamengine.git","clone_url":"https://github.com/slamdata/slamengine.git","svn_url":"https://github.com/slamdata/slamengine","homepage":null,"size":8861,"stargazers_count":122,"watchers_count":122,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":153,"forks":28,"open_issues":153,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/819"},"html":{"href":"https://github.com/slamdata/slamengine/pull/819"},"issue":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/819"},"comments":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/819/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/819/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/819/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamengine/statuses/463f1a123569ecd227cb7a0eb8ec557126ac7e3c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":328,"deletions":172,"changed_files":6}}