{"action":"opened","issue":{"url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/114","labels_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/114/comments","events_url":"https://api.github.com/repos/TresAmigosSD/SMV/issues/114/events","html_url":"https://github.com/TresAmigosSD/SMV/issues/114","id":59195430,"number":114,"title":"Clean up getModulePackages in SmvApp","user":{"login":"ninjapapa","id":8062822,"avatar_url":"https://avatars.githubusercontent.com/u/8062822?v=3","gravatar_id":"","url":"https://api.github.com/users/ninjapapa","html_url":"https://github.com/ninjapapa","followers_url":"https://api.github.com/users/ninjapapa/followers","following_url":"https://api.github.com/users/ninjapapa/following{/other_user}","gists_url":"https://api.github.com/users/ninjapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjapapa/subscriptions","organizations_url":"https://api.github.com/users/ninjapapa/orgs","repos_url":"https://api.github.com/users/ninjapapa/repos","events_url":"https://api.github.com/users/ninjapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ninjapapa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-02-27T06:08:25Z","updated_at":"2015-02-27T06:08:25Z","closed_at":null,"body":"Other than figure out the common string of all the modules in an dependency graph, ```getModulePackages``` is not necessary.  \r\n\r\nThe dependency graph itself doesn't depend on it. For figuring out the common string of all modules, it could be more natural to specify it in the concrete class directly.\r\n\r\npackages should rather be a parameter to ```genJSON``` to define the scope of the graph. \r\n\r\nClient code should look like\r\n```scala\r\nclass MyCoolApp(...){\r\n  ...\r\n  override def packagePrefix() = \"org.tresamigos.mvd\"\r\n}\r\n```\r\n\r\nAnd the genJSON call from app should be \r\n```scala\r\napp.genJSON(Seq[\"phase1\", \"phase2\", \"adhoc\"])\r\n``` "}}