{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/Taeir/fish-io/pulls/124","id":47043172,"html_url":"https://github.com/Taeir/fish-io/pull/124","diff_url":"https://github.com/Taeir/fish-io/pull/124.diff","patch_url":"https://github.com/Taeir/fish-io/pull/124.patch","issue_url":"https://api.github.com/repos/Taeir/fish-io/issues/124","number":124,"state":"closed","locked":false,"title":"Feature achievements","user":{"login":"jessearens","id":14070792,"avatar_url":"https://avatars.githubusercontent.com/u/14070792?v=3","gravatar_id":"","url":"https://api.github.com/users/jessearens","html_url":"https://github.com/jessearens","followers_url":"https://api.github.com/users/jessearens/followers","following_url":"https://api.github.com/users/jessearens/following{/other_user}","gists_url":"https://api.github.com/users/jessearens/gists{/gist_id}","starred_url":"https://api.github.com/users/jessearens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessearens/subscriptions","organizations_url":"https://api.github.com/users/jessearens/orgs","repos_url":"https://api.github.com/users/jessearens/repos","events_url":"https://api.github.com/users/jessearens/events{/privacy}","received_events_url":"https://api.github.com/users/jessearens/received_events","type":"User","site_admin":false},"body":"This pull request performs two things:\r\n1. It somewhat improves the code readability of the AchievementScreenController by removing some unnecessary duplicate code. Some checkstyle errors were also found and fixed. Next up would be to redesign this part of the controller to support the bigger and smaller achievement sprites and to code this so that it is even better (probably going to use gridpanes). \r\n2. It fixes the bug of issue #123. The bug was caused by an incorrect placement of the colorAdjust object within the AchievementScreenController.\r\n\r\nFixes #123\r\n\r\n<feature,bug","created_at":"2015-10-07T15:33:01Z","updated_at":"2015-10-08T15:42:13Z","closed_at":"2015-10-08T15:42:13Z","merged_at":"2015-10-08T15:42:13Z","merge_commit_sha":"5c820fb85237974d787d1c41114cda820195ab0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Taeir/fish-io/pulls/124/commits","review_comments_url":"https://api.github.com/repos/Taeir/fish-io/pulls/124/comments","review_comment_url":"https://api.github.com/repos/Taeir/fish-io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Taeir/fish-io/issues/124/comments","statuses_url":"https://api.github.com/repos/Taeir/fish-io/statuses/a871f6153713e0d899389f9db4f9d21066bed780","head":{"label":"Taeir:feature_achievements","ref":"feature_achievements","sha":"a871f6153713e0d899389f9db4f9d21066bed780","user":{"login":"Taeir","id":668952,"avatar_url":"https://avatars.githubusercontent.com/u/668952?v=3","gravatar_id":"","url":"https://api.github.com/users/Taeir","html_url":"https://github.com/Taeir","followers_url":"https://api.github.com/users/Taeir/followers","following_url":"https://api.github.com/users/Taeir/following{/other_user}","gists_url":"https://api.github.com/users/Taeir/gists{/gist_id}","starred_url":"https://api.github.com/users/Taeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taeir/subscriptions","organizations_url":"https://api.github.com/users/Taeir/orgs","repos_url":"https://api.github.com/users/Taeir/repos","events_url":"https://api.github.com/users/Taeir/events{/privacy}","received_events_url":"https://api.github.com/users/Taeir/received_events","type":"User","site_admin":false},"repo":{"id":41729860,"name":"fish-io","full_name":"Taeir/fish-io","owner":{"login":"Taeir","id":668952,"avatar_url":"https://avatars.githubusercontent.com/u/668952?v=3","gravatar_id":"","url":"https://api.github.com/users/Taeir","html_url":"https://github.com/Taeir","followers_url":"https://api.github.com/users/Taeir/followers","following_url":"https://api.github.com/users/Taeir/following{/other_user}","gists_url":"https://api.github.com/users/Taeir/gists{/gist_id}","starred_url":"https://api.github.com/users/Taeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taeir/subscriptions","organizations_url":"https://api.github.com/users/Taeir/orgs","repos_url":"https://api.github.com/users/Taeir/repos","events_url":"https://api.github.com/users/Taeir/events{/privacy}","received_events_url":"https://api.github.com/users/Taeir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taeir/fish-io","description":"","fork":false,"url":"https://api.github.com/repos/Taeir/fish-io","forks_url":"https://api.github.com/repos/Taeir/fish-io/forks","keys_url":"https://api.github.com/repos/Taeir/fish-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taeir/fish-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taeir/fish-io/teams","hooks_url":"https://api.github.com/repos/Taeir/fish-io/hooks","issue_events_url":"https://api.github.com/repos/Taeir/fish-io/issues/events{/number}","events_url":"https://api.github.com/repos/Taeir/fish-io/events","assignees_url":"https://api.github.com/repos/Taeir/fish-io/assignees{/user}","branches_url":"https://api.github.com/repos/Taeir/fish-io/branches{/branch}","tags_url":"https://api.github.com/repos/Taeir/fish-io/tags","blobs_url":"https://api.github.com/repos/Taeir/fish-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taeir/fish-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taeir/fish-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taeir/fish-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taeir/fish-io/statuses/{sha}","languages_url":"https://api.github.com/repos/Taeir/fish-io/languages","stargazers_url":"https://api.github.com/repos/Taeir/fish-io/stargazers","contributors_url":"https://api.github.com/repos/Taeir/fish-io/contributors","subscribers_url":"https://api.github.com/repos/Taeir/fish-io/subscribers","subscription_url":"https://api.github.com/repos/Taeir/fish-io/subscription","commits_url":"https://api.github.com/repos/Taeir/fish-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taeir/fish-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taeir/fish-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taeir/fish-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taeir/fish-io/contents/{+path}","compare_url":"https://api.github.com/repos/Taeir/fish-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taeir/fish-io/merges","archive_url":"https://api.github.com/repos/Taeir/fish-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taeir/fish-io/downloads","issues_url":"https://api.github.com/repos/Taeir/fish-io/issues{/number}","pulls_url":"https://api.github.com/repos/Taeir/fish-io/pulls{/number}","milestones_url":"https://api.github.com/repos/Taeir/fish-io/milestones{/number}","notifications_url":"https://api.github.com/repos/Taeir/fish-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taeir/fish-io/labels{/name}","releases_url":"https://api.github.com/repos/Taeir/fish-io/releases{/id}","created_at":"2015-09-01T09:35:23Z","updated_at":"2015-10-05T11:28:22Z","pushed_at":"2015-10-08T15:42:14Z","git_url":"git://github.com/Taeir/fish-io.git","ssh_url":"git@github.com:Taeir/fish-io.git","clone_url":"https://github.com/Taeir/fish-io.git","svn_url":"https://github.com/Taeir/fish-io","homepage":null,"size":44340,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Taeir:master","ref":"master","sha":"c84c6c90c8532915f58523dc723109ddc76a38c3","user":{"login":"Taeir","id":668952,"avatar_url":"https://avatars.githubusercontent.com/u/668952?v=3","gravatar_id":"","url":"https://api.github.com/users/Taeir","html_url":"https://github.com/Taeir","followers_url":"https://api.github.com/users/Taeir/followers","following_url":"https://api.github.com/users/Taeir/following{/other_user}","gists_url":"https://api.github.com/users/Taeir/gists{/gist_id}","starred_url":"https://api.github.com/users/Taeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taeir/subscriptions","organizations_url":"https://api.github.com/users/Taeir/orgs","repos_url":"https://api.github.com/users/Taeir/repos","events_url":"https://api.github.com/users/Taeir/events{/privacy}","received_events_url":"https://api.github.com/users/Taeir/received_events","type":"User","site_admin":false},"repo":{"id":41729860,"name":"fish-io","full_name":"Taeir/fish-io","owner":{"login":"Taeir","id":668952,"avatar_url":"https://avatars.githubusercontent.com/u/668952?v=3","gravatar_id":"","url":"https://api.github.com/users/Taeir","html_url":"https://github.com/Taeir","followers_url":"https://api.github.com/users/Taeir/followers","following_url":"https://api.github.com/users/Taeir/following{/other_user}","gists_url":"https://api.github.com/users/Taeir/gists{/gist_id}","starred_url":"https://api.github.com/users/Taeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taeir/subscriptions","organizations_url":"https://api.github.com/users/Taeir/orgs","repos_url":"https://api.github.com/users/Taeir/repos","events_url":"https://api.github.com/users/Taeir/events{/privacy}","received_events_url":"https://api.github.com/users/Taeir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taeir/fish-io","description":"","fork":false,"url":"https://api.github.com/repos/Taeir/fish-io","forks_url":"https://api.github.com/repos/Taeir/fish-io/forks","keys_url":"https://api.github.com/repos/Taeir/fish-io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taeir/fish-io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taeir/fish-io/teams","hooks_url":"https://api.github.com/repos/Taeir/fish-io/hooks","issue_events_url":"https://api.github.com/repos/Taeir/fish-io/issues/events{/number}","events_url":"https://api.github.com/repos/Taeir/fish-io/events","assignees_url":"https://api.github.com/repos/Taeir/fish-io/assignees{/user}","branches_url":"https://api.github.com/repos/Taeir/fish-io/branches{/branch}","tags_url":"https://api.github.com/repos/Taeir/fish-io/tags","blobs_url":"https://api.github.com/repos/Taeir/fish-io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taeir/fish-io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taeir/fish-io/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taeir/fish-io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taeir/fish-io/statuses/{sha}","languages_url":"https://api.github.com/repos/Taeir/fish-io/languages","stargazers_url":"https://api.github.com/repos/Taeir/fish-io/stargazers","contributors_url":"https://api.github.com/repos/Taeir/fish-io/contributors","subscribers_url":"https://api.github.com/repos/Taeir/fish-io/subscribers","subscription_url":"https://api.github.com/repos/Taeir/fish-io/subscription","commits_url":"https://api.github.com/repos/Taeir/fish-io/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taeir/fish-io/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taeir/fish-io/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taeir/fish-io/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taeir/fish-io/contents/{+path}","compare_url":"https://api.github.com/repos/Taeir/fish-io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taeir/fish-io/merges","archive_url":"https://api.github.com/repos/Taeir/fish-io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taeir/fish-io/downloads","issues_url":"https://api.github.com/repos/Taeir/fish-io/issues{/number}","pulls_url":"https://api.github.com/repos/Taeir/fish-io/pulls{/number}","milestones_url":"https://api.github.com/repos/Taeir/fish-io/milestones{/number}","notifications_url":"https://api.github.com/repos/Taeir/fish-io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taeir/fish-io/labels{/name}","releases_url":"https://api.github.com/repos/Taeir/fish-io/releases{/id}","created_at":"2015-09-01T09:35:23Z","updated_at":"2015-10-05T11:28:22Z","pushed_at":"2015-10-08T15:42:14Z","git_url":"git://github.com/Taeir/fish-io.git","ssh_url":"git@github.com:Taeir/fish-io.git","clone_url":"https://github.com/Taeir/fish-io.git","svn_url":"https://github.com/Taeir/fish-io","homepage":null,"size":44340,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Taeir/fish-io/pulls/124"},"html":{"href":"https://github.com/Taeir/fish-io/pull/124"},"issue":{"href":"https://api.github.com/repos/Taeir/fish-io/issues/124"},"comments":{"href":"https://api.github.com/repos/Taeir/fish-io/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/Taeir/fish-io/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/Taeir/fish-io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Taeir/fish-io/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/Taeir/fish-io/statuses/a871f6153713e0d899389f9db4f9d21066bed780"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Taeir","id":668952,"avatar_url":"https://avatars.githubusercontent.com/u/668952?v=3","gravatar_id":"","url":"https://api.github.com/users/Taeir","html_url":"https://github.com/Taeir","followers_url":"https://api.github.com/users/Taeir/followers","following_url":"https://api.github.com/users/Taeir/following{/other_user}","gists_url":"https://api.github.com/users/Taeir/gists{/gist_id}","starred_url":"https://api.github.com/users/Taeir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taeir/subscriptions","organizations_url":"https://api.github.com/users/Taeir/orgs","repos_url":"https://api.github.com/users/Taeir/repos","events_url":"https://api.github.com/users/Taeir/events{/privacy}","received_events_url":"https://api.github.com/users/Taeir/received_events","type":"User","site_admin":false},"comments":8,"review_comments":3,"commits":11,"additions":1479,"deletions":949,"changed_files":2}}