{"action":"created","comment":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/comments/38742659","id":38742659,"diff_hunk":"@@ -4910,7 +4918,30 @@ function warnFacetedInterp(m2t)\n %\n % Example of usage:\n %              join(m2t, cellstr, ',')\n-    newstr = m2tstrjoin(cellstr, delimiter, m2t.ff);\n+    if isempty(cellstr)\n+        newstr = '';\n+        return\n+    end\n+\n+    % convert all values to strings first\n+    nElem = numel(cellstr);\n+    for k = 1:nElem\n+        if isnumeric(cellstr{k})\n+            cellstr{k} = sprintf(m2t.ff, cellstr{k});\n+        elseif iscell(cellstr{k})\n+            cellstr{k} = join(m2t, cellstr{k}, delimiter);\n+            % this will fail for heavily nested cells\n+        elseif ~ischar(cellstr{k})\n+            error('matlab2tikz:join:NotCellstrOrNumeric',...\n+                'Expected cellstr or numeric.');\n+        end\n+    end\n+\n+    % inspired by strjoin of recent versions of MATLAB\n+    newstr = cell(2,nElem);\n+    newstr(1,:)         = reshape(cellstr, 1, nElem);\n+    newstr(2,1:nElem-1) = {delimiter}; % put delimiters in-between the elements\n+    newstr = [newstr{:}];","path":"src/matlab2tikz.m","position":77,"original_position":77,"commit_id":"0bc74c092e38b8dd78bbab09b00b71feacc229ca","original_commit_id":"0bc74c092e38b8dd78bbab09b00b71feacc229ca","user":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"body":"Absolutely true. This happened during rebasing (I must have thought: more code = more likely right).\r\nThank you for double-checking my mess :+1:","created_at":"2015-09-04T11:29:38Z","updated_at":"2015-09-04T11:29:38Z","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/759#discussion_r38742659","pull_request_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/comments/38742659"},"html":{"href":"https://github.com/matlab2tikz/matlab2tikz/pull/759#discussion_r38742659"},"pull_request":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759","id":44206307,"html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/759","diff_url":"https://github.com/matlab2tikz/matlab2tikz/pull/759.diff","patch_url":"https://github.com/matlab2tikz/matlab2tikz/pull/759.patch","issue_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/759","number":759,"state":"open","locked":false,"title":"Fix octave4 rebased","user":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"body":"**This is a rebase of #695.**\r\n\r\n## TODO (shamelessly copied)\r\n\r\nOctave is not able to run the testsuite without changes. This PR is trying to get things into shape.\r\n\r\n* [x] `getEnvironment()` would not properly detect Octave 4\r\n* [x] `fileOpenForWrite()` is now deferring from passing the third argument as empty\r\n* [x] `generateColorDefinitions()` doesn't choke on names anymore\r\n* [x] add comments to touched functions\r\n* [x] get rid of `warning: implicit conversion from numeric to char` (near line `newstr(2,1:nElem-1) = {delimiter};`)\r\n* [x] fix check for installed toolboxes in `ACID.m`\r\n* [ ] get rid of `warning: implicit conversion from numeric to char` for `ACID(74)`\r\n* [ ] `ACID(87)`: plot fails -- should be fixed by #669\r\n* [x] `testGraphical` results in `Segmentation fault` :see_no_evil: \r\n\r\n### New octave\r\n* supports some annotations --> ACID(88), ACID(89), ACID(90)\r\n* contains penny dataset --> ACID(9)\r\n* ...","created_at":"2015-09-04T11:07:41Z","updated_at":"2015-09-04T11:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d19509b22a4b82de5e2f90b79e5e47f7ea778da1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759/commits","review_comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759/comments","review_comment_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/759/comments","statuses_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/statuses/0bc74c092e38b8dd78bbab09b00b71feacc229ca","head":{"label":"egeerardyn:fix-Octave4-rebased","ref":"fix-Octave4-rebased","sha":"0bc74c092e38b8dd78bbab09b00b71feacc229ca","user":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"repo":{"id":27400367,"name":"matlab2tikz","full_name":"egeerardyn/matlab2tikz","owner":{"login":"egeerardyn","id":177360,"avatar_url":"https://avatars.githubusercontent.com/u/177360?v=3","gravatar_id":"","url":"https://api.github.com/users/egeerardyn","html_url":"https://github.com/egeerardyn","followers_url":"https://api.github.com/users/egeerardyn/followers","following_url":"https://api.github.com/users/egeerardyn/following{/other_user}","gists_url":"https://api.github.com/users/egeerardyn/gists{/gist_id}","starred_url":"https://api.github.com/users/egeerardyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egeerardyn/subscriptions","organizations_url":"https://api.github.com/users/egeerardyn/orgs","repos_url":"https://api.github.com/users/egeerardyn/repos","events_url":"https://api.github.com/users/egeerardyn/events{/privacy}","received_events_url":"https://api.github.com/users/egeerardyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egeerardyn/matlab2tikz","description":"A converter that takes a MATLAB(R) figure and spits out a TikZ (Pgfplots) figure for smooth integration into LaTeX. ","fork":true,"url":"https://api.github.com/repos/egeerardyn/matlab2tikz","forks_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/forks","keys_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/teams","hooks_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/hooks","issue_events_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/issues/events{/number}","events_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/events","assignees_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/assignees{/user}","branches_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/branches{/branch}","tags_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/tags","blobs_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/git/refs{/sha}","trees_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/statuses/{sha}","languages_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/languages","stargazers_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/stargazers","contributors_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/contributors","subscribers_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/subscribers","subscription_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/subscription","commits_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/commits{/sha}","git_commits_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/git/commits{/sha}","comments_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/comments{/number}","issue_comment_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/issues/comments{/number}","contents_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/contents/{+path}","compare_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/merges","archive_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/downloads","issues_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/issues{/number}","pulls_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/pulls{/number}","milestones_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/milestones{/number}","notifications_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/labels{/name}","releases_url":"https://api.github.com/repos/egeerardyn/matlab2tikz/releases{/id}","created_at":"2014-12-01T21:18:54Z","updated_at":"2014-12-02T15:10:41Z","pushed_at":"2015-09-04T11:05:39Z","git_url":"git://github.com/egeerardyn/matlab2tikz.git","ssh_url":"git@github.com:egeerardyn/matlab2tikz.git","clone_url":"https://github.com/egeerardyn/matlab2tikz.git","svn_url":"https://github.com/egeerardyn/matlab2tikz","homepage":"http://www.mathworks.com/matlabcentral/fileexchange/22022-matlab2tikz","size":7240,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matlab2tikz:develop","ref":"develop","sha":"a6640617f533d57faddaa8da90952ac38e2186eb","user":{"login":"matlab2tikz","id":10036397,"avatar_url":"https://avatars.githubusercontent.com/u/10036397?v=3","gravatar_id":"","url":"https://api.github.com/users/matlab2tikz","html_url":"https://github.com/matlab2tikz","followers_url":"https://api.github.com/users/matlab2tikz/followers","following_url":"https://api.github.com/users/matlab2tikz/following{/other_user}","gists_url":"https://api.github.com/users/matlab2tikz/gists{/gist_id}","starred_url":"https://api.github.com/users/matlab2tikz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlab2tikz/subscriptions","organizations_url":"https://api.github.com/users/matlab2tikz/orgs","repos_url":"https://api.github.com/users/matlab2tikz/repos","events_url":"https://api.github.com/users/matlab2tikz/events{/privacy}","received_events_url":"https://api.github.com/users/matlab2tikz/received_events","type":"Organization","site_admin":false},"repo":{"id":579842,"name":"matlab2tikz","full_name":"matlab2tikz/matlab2tikz","owner":{"login":"matlab2tikz","id":10036397,"avatar_url":"https://avatars.githubusercontent.com/u/10036397?v=3","gravatar_id":"","url":"https://api.github.com/users/matlab2tikz","html_url":"https://github.com/matlab2tikz","followers_url":"https://api.github.com/users/matlab2tikz/followers","following_url":"https://api.github.com/users/matlab2tikz/following{/other_user}","gists_url":"https://api.github.com/users/matlab2tikz/gists{/gist_id}","starred_url":"https://api.github.com/users/matlab2tikz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matlab2tikz/subscriptions","organizations_url":"https://api.github.com/users/matlab2tikz/orgs","repos_url":"https://api.github.com/users/matlab2tikz/repos","events_url":"https://api.github.com/users/matlab2tikz/events{/privacy}","received_events_url":"https://api.github.com/users/matlab2tikz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matlab2tikz/matlab2tikz","description":"This program converts MATLAB®/Octave figures to TikZ/pgfplots figures for smooth integration into LaTeX.","fork":false,"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz","forks_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/forks","keys_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/teams","hooks_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/hooks","issue_events_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/events{/number}","events_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/events","assignees_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/assignees{/user}","branches_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/branches{/branch}","tags_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/tags","blobs_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/git/refs{/sha}","trees_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/statuses/{sha}","languages_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/languages","stargazers_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/stargazers","contributors_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/contributors","subscribers_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/subscribers","subscription_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/subscription","commits_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/commits{/sha}","git_commits_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/git/commits{/sha}","comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/comments{/number}","issue_comment_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/comments{/number}","contents_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/contents/{+path}","compare_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/merges","archive_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/downloads","issues_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues{/number}","pulls_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls{/number}","milestones_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/milestones{/number}","notifications_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/labels{/name}","releases_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/releases{/id}","created_at":"2010-03-25T22:52:27Z","updated_at":"2015-09-04T10:01:04Z","pushed_at":"2015-09-04T11:07:42Z","git_url":"git://github.com/matlab2tikz/matlab2tikz.git","ssh_url":"git@github.com:matlab2tikz/matlab2tikz.git","clone_url":"https://github.com/matlab2tikz/matlab2tikz.git","svn_url":"https://github.com/matlab2tikz/matlab2tikz","homepage":"http://www.mathworks.com/matlabcentral/fileexchange/22022-matlab2tikz","size":10885,"stargazers_count":305,"watchers_count":305,"language":"Matlab","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":96,"forks":91,"open_issues":96,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759"},"html":{"href":"https://github.com/matlab2tikz/matlab2tikz/pull/759"},"issue":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/759"},"comments":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/matlab2tikz/matlab2tikz/statuses/0bc74c092e38b8dd78bbab09b00b71feacc229ca"}}}}