{"action":"closed","number":655,"pull_request":{"url":"https://api.github.com/repos/google/j2objc/pulls/655","id":49152289,"html_url":"https://github.com/google/j2objc/pull/655","diff_url":"https://github.com/google/j2objc/pull/655.diff","patch_url":"https://github.com/google/j2objc/pull/655.patch","issue_url":"https://api.github.com/repos/google/j2objc/issues/655","number":655,"state":"closed","locked":false,"title":"Eliminate inner class constructors correctly when ProGuard explicitly instructs so","user":{"login":"lukhnos","id":25210,"avatar_url":"https://avatars.githubusercontent.com/u/25210?v=3","gravatar_id":"","url":"https://api.github.com/users/lukhnos","html_url":"https://github.com/lukhnos","followers_url":"https://api.github.com/users/lukhnos/followers","following_url":"https://api.github.com/users/lukhnos/following{/other_user}","gists_url":"https://api.github.com/users/lukhnos/gists{/gist_id}","starred_url":"https://api.github.com/users/lukhnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukhnos/subscriptions","organizations_url":"https://api.github.com/users/lukhnos/orgs","repos_url":"https://api.github.com/users/lukhnos/repos","events_url":"https://api.github.com/users/lukhnos/events{/privacy}","received_events_url":"https://api.github.com/users/lukhnos/received_events","type":"User","site_admin":false},"body":"This fixes #654 by adding a new `getProGuardSignature` method to `BindingUtil` so that the dead code eliminator can use the correct signature to match against the dead code report. As mentioned in #654, the signature was not correct because dead code elimination is the first pass in the translation processor, before inner class methods are furnished with outer types in a later pass.\r\n\r\nSince `InitializationNormalizer` needs the dead code map to work correctly, I wonder if dead code elimination should be done after `InnerClassExtractor` is finished, but I'm not sure if the pass will still work after the nodes have been modified by the other passes. The downside of the approach here is one more special case in `BindingUtil`, though I believe it's straightforward enough for the job.\r\n\r\nThis also fixes [a previous test case](https://github.com/lukhnos/j2objc/commit/0024184c7ea56c399149974c2f732b5a2641557f), as I don't think ProGuard produces the same signature.\r\n","created_at":"2015-10-29T15:09:08Z","updated_at":"2015-10-29T20:28:56Z","closed_at":"2015-10-29T20:28:56Z","merged_at":"2015-10-29T20:28:56Z","merge_commit_sha":"c151de13dceaa7b89e1b06ddb07e16bca654d087","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/j2objc/pulls/655/commits","review_comments_url":"https://api.github.com/repos/google/j2objc/pulls/655/comments","review_comment_url":"https://api.github.com/repos/google/j2objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/j2objc/issues/655/comments","statuses_url":"https://api.github.com/repos/google/j2objc/statuses/da6ce7e963fe2593e60c301437c3acc036efed0c","head":{"label":"lukhnos:deadcode-elim-edge-case","ref":"deadcode-elim-edge-case","sha":"da6ce7e963fe2593e60c301437c3acc036efed0c","user":{"login":"lukhnos","id":25210,"avatar_url":"https://avatars.githubusercontent.com/u/25210?v=3","gravatar_id":"","url":"https://api.github.com/users/lukhnos","html_url":"https://github.com/lukhnos","followers_url":"https://api.github.com/users/lukhnos/followers","following_url":"https://api.github.com/users/lukhnos/following{/other_user}","gists_url":"https://api.github.com/users/lukhnos/gists{/gist_id}","starred_url":"https://api.github.com/users/lukhnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukhnos/subscriptions","organizations_url":"https://api.github.com/users/lukhnos/orgs","repos_url":"https://api.github.com/users/lukhnos/repos","events_url":"https://api.github.com/users/lukhnos/events{/privacy}","received_events_url":"https://api.github.com/users/lukhnos/received_events","type":"User","site_admin":false},"repo":{"id":37963896,"name":"j2objc","full_name":"lukhnos/j2objc","owner":{"login":"lukhnos","id":25210,"avatar_url":"https://avatars.githubusercontent.com/u/25210?v=3","gravatar_id":"","url":"https://api.github.com/users/lukhnos","html_url":"https://github.com/lukhnos","followers_url":"https://api.github.com/users/lukhnos/followers","following_url":"https://api.github.com/users/lukhnos/following{/other_user}","gists_url":"https://api.github.com/users/lukhnos/gists{/gist_id}","starred_url":"https://api.github.com/users/lukhnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukhnos/subscriptions","organizations_url":"https://api.github.com/users/lukhnos/orgs","repos_url":"https://api.github.com/users/lukhnos/repos","events_url":"https://api.github.com/users/lukhnos/events{/privacy}","received_events_url":"https://api.github.com/users/lukhnos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukhnos/j2objc","description":"A Java to iOS Objective-C translation tool and runtime.","fork":true,"url":"https://api.github.com/repos/lukhnos/j2objc","forks_url":"https://api.github.com/repos/lukhnos/j2objc/forks","keys_url":"https://api.github.com/repos/lukhnos/j2objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukhnos/j2objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukhnos/j2objc/teams","hooks_url":"https://api.github.com/repos/lukhnos/j2objc/hooks","issue_events_url":"https://api.github.com/repos/lukhnos/j2objc/issues/events{/number}","events_url":"https://api.github.com/repos/lukhnos/j2objc/events","assignees_url":"https://api.github.com/repos/lukhnos/j2objc/assignees{/user}","branches_url":"https://api.github.com/repos/lukhnos/j2objc/branches{/branch}","tags_url":"https://api.github.com/repos/lukhnos/j2objc/tags","blobs_url":"https://api.github.com/repos/lukhnos/j2objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukhnos/j2objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukhnos/j2objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukhnos/j2objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukhnos/j2objc/statuses/{sha}","languages_url":"https://api.github.com/repos/lukhnos/j2objc/languages","stargazers_url":"https://api.github.com/repos/lukhnos/j2objc/stargazers","contributors_url":"https://api.github.com/repos/lukhnos/j2objc/contributors","subscribers_url":"https://api.github.com/repos/lukhnos/j2objc/subscribers","subscription_url":"https://api.github.com/repos/lukhnos/j2objc/subscription","commits_url":"https://api.github.com/repos/lukhnos/j2objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukhnos/j2objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukhnos/j2objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukhnos/j2objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukhnos/j2objc/contents/{+path}","compare_url":"https://api.github.com/repos/lukhnos/j2objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukhnos/j2objc/merges","archive_url":"https://api.github.com/repos/lukhnos/j2objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukhnos/j2objc/downloads","issues_url":"https://api.github.com/repos/lukhnos/j2objc/issues{/number}","pulls_url":"https://api.github.com/repos/lukhnos/j2objc/pulls{/number}","milestones_url":"https://api.github.com/repos/lukhnos/j2objc/milestones{/number}","notifications_url":"https://api.github.com/repos/lukhnos/j2objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukhnos/j2objc/labels{/name}","releases_url":"https://api.github.com/repos/lukhnos/j2objc/releases{/id}","created_at":"2015-06-24T05:15:47Z","updated_at":"2015-06-24T05:15:56Z","pushed_at":"2015-10-29T15:58:43Z","git_url":"git://github.com/lukhnos/j2objc.git","ssh_url":"git@github.com:lukhnos/j2objc.git","clone_url":"https://github.com/lukhnos/j2objc.git","svn_url":"https://github.com/lukhnos/j2objc","homepage":"http://j2objc.org","size":17879,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"de3f04612bc968ee38d2fd76aef6469c213f4f5c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":16389681,"name":"j2objc","full_name":"google/j2objc","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/j2objc","description":"A Java to iOS Objective-C translation tool and runtime.","fork":false,"url":"https://api.github.com/repos/google/j2objc","forks_url":"https://api.github.com/repos/google/j2objc/forks","keys_url":"https://api.github.com/repos/google/j2objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/j2objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/j2objc/teams","hooks_url":"https://api.github.com/repos/google/j2objc/hooks","issue_events_url":"https://api.github.com/repos/google/j2objc/issues/events{/number}","events_url":"https://api.github.com/repos/google/j2objc/events","assignees_url":"https://api.github.com/repos/google/j2objc/assignees{/user}","branches_url":"https://api.github.com/repos/google/j2objc/branches{/branch}","tags_url":"https://api.github.com/repos/google/j2objc/tags","blobs_url":"https://api.github.com/repos/google/j2objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/j2objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/j2objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/j2objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/j2objc/statuses/{sha}","languages_url":"https://api.github.com/repos/google/j2objc/languages","stargazers_url":"https://api.github.com/repos/google/j2objc/stargazers","contributors_url":"https://api.github.com/repos/google/j2objc/contributors","subscribers_url":"https://api.github.com/repos/google/j2objc/subscribers","subscription_url":"https://api.github.com/repos/google/j2objc/subscription","commits_url":"https://api.github.com/repos/google/j2objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/j2objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/j2objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/j2objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/j2objc/contents/{+path}","compare_url":"https://api.github.com/repos/google/j2objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/j2objc/merges","archive_url":"https://api.github.com/repos/google/j2objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/j2objc/downloads","issues_url":"https://api.github.com/repos/google/j2objc/issues{/number}","pulls_url":"https://api.github.com/repos/google/j2objc/pulls{/number}","milestones_url":"https://api.github.com/repos/google/j2objc/milestones{/number}","notifications_url":"https://api.github.com/repos/google/j2objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/j2objc/labels{/name}","releases_url":"https://api.github.com/repos/google/j2objc/releases{/id}","created_at":"2014-01-30T20:19:56Z","updated_at":"2015-10-29T20:14:12Z","pushed_at":"2015-10-29T20:28:56Z","git_url":"git://github.com/google/j2objc.git","ssh_url":"git@github.com:google/j2objc.git","clone_url":"https://github.com/google/j2objc.git","svn_url":"https://github.com/google/j2objc","homepage":"http://j2objc.org","size":31259,"stargazers_count":3299,"watchers_count":3299,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":401,"mirror_url":null,"open_issues_count":46,"forks":401,"open_issues":46,"watchers":3299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/j2objc/pulls/655"},"html":{"href":"https://github.com/google/j2objc/pull/655"},"issue":{"href":"https://api.github.com/repos/google/j2objc/issues/655"},"comments":{"href":"https://api.github.com/repos/google/j2objc/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/google/j2objc/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/google/j2objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/j2objc/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/google/j2objc/statuses/da6ce7e963fe2593e60c301437c3acc036efed0c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomball","id":2991279,"avatar_url":"https://avatars.githubusercontent.com/u/2991279?v=3","gravatar_id":"","url":"https://api.github.com/users/tomball","html_url":"https://github.com/tomball","followers_url":"https://api.github.com/users/tomball/followers","following_url":"https://api.github.com/users/tomball/following{/other_user}","gists_url":"https://api.github.com/users/tomball/gists{/gist_id}","starred_url":"https://api.github.com/users/tomball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomball/subscriptions","organizations_url":"https://api.github.com/users/tomball/orgs","repos_url":"https://api.github.com/users/tomball/repos","events_url":"https://api.github.com/users/tomball/events{/privacy}","received_events_url":"https://api.github.com/users/tomball/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":66,"deletions":5,"changed_files":3}}