{"action":"created","comment":{"url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/comments/32076930","id":32076930,"diff_hunk":"@@ -1,5 +1,15 @@\n {CompositeDisposable, Emitter} = require 'atom'\n \n+validateResults = (results) ->","path":"lib/editor-linter.coffee","position":3,"original_position":3,"commit_id":"7ad90446f6f9012c0df0e630f0f73f7f2fcc116e","original_commit_id":"7ad90446f6f9012c0df0e630f0f73f7f2fcc116e","user":{"login":"AsaAyers","id":324999,"avatar_url":"https://avatars.githubusercontent.com/u/324999?v=3","gravatar_id":"","url":"https://api.github.com/users/AsaAyers","html_url":"https://github.com/AsaAyers","followers_url":"https://api.github.com/users/AsaAyers/followers","following_url":"https://api.github.com/users/AsaAyers/following{/other_user}","gists_url":"https://api.github.com/users/AsaAyers/gists{/gist_id}","starred_url":"https://api.github.com/users/AsaAyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsaAyers/subscriptions","organizations_url":"https://api.github.com/users/AsaAyers/orgs","repos_url":"https://api.github.com/users/AsaAyers/repos","events_url":"https://api.github.com/users/AsaAyers/events{/privacy}","received_events_url":"https://api.github.com/users/AsaAyers/received_events","type":"User","site_admin":false},"body":"I'm not going to keep having these stupid arguments with you. This kind of\ncrap is why I was planning to leave this morning\nOn Jun 9, 2015 7:36 PM, \"Steel Brain\" <notifications@github.com> wrote:\n\n> In lib/editor-linter.coffee\n> <https://github.com/AtomLinter/linter-plus/pull/38#discussion_r32076481>:\n>\n> > @@ -1,5 +1,15 @@\n> >  {CompositeDisposable, Emitter} = require 'atom'\n> >\n> > +validateResults = (results) ->\n>\n>  seriously. how much Javascript experience do you have?\n>\n> Can you please stop treating me like a child? I have enough experience\n> with javascript to write my own javascript engine in it.\n>\n> There's nothing wrong with this, it's just not the one style you're\n> familiar with.\n>\n> I know there's nothing wrong with this, but I am showing you a better way.\n> Option 1: put a method at the start of the file and put a class in the\n> rest of it\n> Option 2: Add that method to the class\n>\n> Option 2 is much cleaner and preferable.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/AtomLinter/linter-plus/pull/38/files#r32076481>.\n>\n","created_at":"2015-06-09T23:44:24Z","updated_at":"2015-06-09T23:44:24Z","html_url":"https://github.com/AtomLinter/linter-plus/pull/38#discussion_r32076930","pull_request_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/comments/32076930"},"html":{"href":"https://github.com/AtomLinter/linter-plus/pull/38#discussion_r32076930"},"pull_request":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38","id":37281898,"html_url":"https://github.com/AtomLinter/linter-plus/pull/38","diff_url":"https://github.com/AtomLinter/linter-plus/pull/38.diff","patch_url":"https://github.com/AtomLinter/linter-plus/pull/38.patch","issue_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/38","number":38,"state":"closed","locked":false,"title":"Validate linter results and refactor EditorLinter::lintResults","user":{"login":"AsaAyers","id":324999,"avatar_url":"https://avatars.githubusercontent.com/u/324999?v=3","gravatar_id":"","url":"https://api.github.com/users/AsaAyers","html_url":"https://github.com/AsaAyers","followers_url":"https://api.github.com/users/AsaAyers/followers","following_url":"https://api.github.com/users/AsaAyers/following{/other_user}","gists_url":"https://api.github.com/users/AsaAyers/gists{/gist_id}","starred_url":"https://api.github.com/users/AsaAyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsaAyers/subscriptions","organizations_url":"https://api.github.com/users/AsaAyers/orgs","repos_url":"https://api.github.com/users/AsaAyers/repos","events_url":"https://api.github.com/users/AsaAyers/events{/privacy}","received_events_url":"https://api.github.com/users/AsaAyers/received_events","type":"User","site_admin":false},"body":"Fixes #36","created_at":"2015-06-09T18:06:43Z","updated_at":"2015-06-09T23:44:24Z","closed_at":"2015-06-09T19:16:57Z","merged_at":"2015-06-09T19:16:57Z","merge_commit_sha":"de1afb99ff481fd0d66ae75e53201c13fc356d8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/38/comments","statuses_url":"https://api.github.com/repos/AtomLinter/linter-plus/statuses/7ad90446f6f9012c0df0e630f0f73f7f2fcc116e","head":{"label":"AtomLinter:validate-results","ref":"validate-results","sha":"7ad90446f6f9012c0df0e630f0f73f7f2fcc116e","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":36250031,"name":"linter-plus","full_name":"AtomLinter/linter-plus","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-plus","description":"","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-plus","forks_url":"https://api.github.com/repos/AtomLinter/linter-plus/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-plus/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-plus/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-plus/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-plus/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-plus/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-plus/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-plus/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-plus/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-plus/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-plus/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-plus/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-plus/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-plus/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-plus/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-plus/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-plus/releases{/id}","created_at":"2015-05-25T19:23:15Z","updated_at":"2015-06-09T17:44:55Z","pushed_at":"2015-06-09T21:18:49Z","git_url":"git://github.com/AtomLinter/linter-plus.git","ssh_url":"git@github.com:AtomLinter/linter-plus.git","clone_url":"https://github.com/AtomLinter/linter-plus.git","svn_url":"https://github.com/AtomLinter/linter-plus","homepage":null,"size":700,"stargazers_count":7,"watchers_count":7,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"89d4fbdc6b3596bca4a242eadb7fdbdcaa58d394","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":36250031,"name":"linter-plus","full_name":"AtomLinter/linter-plus","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-plus","description":"","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-plus","forks_url":"https://api.github.com/repos/AtomLinter/linter-plus/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-plus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-plus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-plus/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-plus/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-plus/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-plus/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-plus/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-plus/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-plus/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-plus/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-plus/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-plus/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-plus/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-plus/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-plus/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-plus/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-plus/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-plus/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-plus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-plus/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-plus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-plus/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-plus/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-plus/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-plus/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-plus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-plus/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-plus/releases{/id}","created_at":"2015-05-25T19:23:15Z","updated_at":"2015-06-09T17:44:55Z","pushed_at":"2015-06-09T21:18:49Z","git_url":"git://github.com/AtomLinter/linter-plus.git","ssh_url":"git@github.com:AtomLinter/linter-plus.git","clone_url":"https://github.com/AtomLinter/linter-plus.git","svn_url":"https://github.com/AtomLinter/linter-plus","homepage":null,"size":700,"stargazers_count":7,"watchers_count":7,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38"},"html":{"href":"https://github.com/AtomLinter/linter-plus/pull/38"},"issue":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/issues/38"},"comments":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/linter-plus/statuses/7ad90446f6f9012c0df0e630f0f73f7f2fcc116e"}}}}