{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/comments/38008619","id":38008619,"diff_hunk":"@@ -60,7 +60,7 @@\n \n section = Word(string.digits).setResultsName(\"section\")\n \n-appendix = Regex(r\"[A-Z]+[0-9]*\\b\").setResultsName(\"appendix\")\n+appendix = Regex(r\"[A-Z]+-?[0-9]*\\b\").setResultsName(\"appendix\")","path":"regparser/grammar/atomic.py","position":5,"original_position":5,"commit_id":"3076169144426c95669bc1eeff7db8a1c42bf9b3","original_commit_id":"3076169144426c95669bc1eeff7db8a1c42bf9b3","user":{"login":"willbarton","id":10562538,"avatar_url":"https://avatars.githubusercontent.com/u/10562538?v=3","gravatar_id":"","url":"https://api.github.com/users/willbarton","html_url":"https://github.com/willbarton","followers_url":"https://api.github.com/users/willbarton/followers","following_url":"https://api.github.com/users/willbarton/following{/other_user}","gists_url":"https://api.github.com/users/willbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/willbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willbarton/subscriptions","organizations_url":"https://api.github.com/users/willbarton/orgs","repos_url":"https://api.github.com/users/willbarton/repos","events_url":"https://api.github.com/users/willbarton/events{/privacy}","received_events_url":"https://api.github.com/users/willbarton/received_events","type":"User","site_admin":false},"body":"I don't think this should be needed anymore — the dash in Appendix MS is taken care of in the change in regparser/grammar/interpretation_headers.py now.","created_at":"2015-08-26T17:18:02Z","updated_at":"2015-08-26T17:18:02Z","html_url":"https://github.com/cfpb/regulations-parser/pull/295#discussion_r38008619","pull_request_url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/comments/38008619"},"html":{"href":"https://github.com/cfpb/regulations-parser/pull/295#discussion_r38008619"},"pull_request":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295","id":43332248,"html_url":"https://github.com/cfpb/regulations-parser/pull/295","diff_url":"https://github.com/cfpb/regulations-parser/pull/295.diff","patch_url":"https://github.com/cfpb/regulations-parser/pull/295.patch","issue_url":"https://api.github.com/repos/cfpb/regulations-parser/issues/295","number":295,"state":"open","locked":false,"title":"incorporates changes from will, keeps parser from crashing when parsing X","user":{"login":"grapesmoker","id":1723233,"avatar_url":"https://avatars.githubusercontent.com/u/1723233?v=3","gravatar_id":"","url":"https://api.github.com/users/grapesmoker","html_url":"https://github.com/grapesmoker","followers_url":"https://api.github.com/users/grapesmoker/followers","following_url":"https://api.github.com/users/grapesmoker/following{/other_user}","gists_url":"https://api.github.com/users/grapesmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/grapesmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grapesmoker/subscriptions","organizations_url":"https://api.github.com/users/grapesmoker/orgs","repos_url":"https://api.github.com/users/grapesmoker/repos","events_url":"https://api.github.com/users/grapesmoker/events{/privacy}","received_events_url":"https://api.github.com/users/grapesmoker/received_events","type":"User","site_admin":false},"body":"This PR merges a bunch of useful changes from Will and also checks for a depth solution in the appendix parser. If there is no solution, just tack the node on rather than crashing.\r\n\r\n**WARNING** This PR does not yet produce the correct paragraph hierarchy for Reg X, Appendix C, notice 2013-28210.","created_at":"2015-08-25T20:26:38Z","updated_at":"2015-08-26T17:18:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"241531e3d48355cc85199cdc17f3285e0956115a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295/commits","review_comments_url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295/comments","review_comment_url":"https://api.github.com/repos/cfpb/regulations-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/regulations-parser/issues/295/comments","statuses_url":"https://api.github.com/repos/cfpb/regulations-parser/statuses/3076169144426c95669bc1eeff7db8a1c42bf9b3","head":{"label":"grapesmoker:master","ref":"master","sha":"3076169144426c95669bc1eeff7db8a1c42bf9b3","user":{"login":"grapesmoker","id":1723233,"avatar_url":"https://avatars.githubusercontent.com/u/1723233?v=3","gravatar_id":"","url":"https://api.github.com/users/grapesmoker","html_url":"https://github.com/grapesmoker","followers_url":"https://api.github.com/users/grapesmoker/followers","following_url":"https://api.github.com/users/grapesmoker/following{/other_user}","gists_url":"https://api.github.com/users/grapesmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/grapesmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grapesmoker/subscriptions","organizations_url":"https://api.github.com/users/grapesmoker/orgs","repos_url":"https://api.github.com/users/grapesmoker/repos","events_url":"https://api.github.com/users/grapesmoker/events{/privacy}","received_events_url":"https://api.github.com/users/grapesmoker/received_events","type":"User","site_admin":false},"repo":{"id":29974239,"name":"regulations-parser","full_name":"grapesmoker/regulations-parser","owner":{"login":"grapesmoker","id":1723233,"avatar_url":"https://avatars.githubusercontent.com/u/1723233?v=3","gravatar_id":"","url":"https://api.github.com/users/grapesmoker","html_url":"https://github.com/grapesmoker","followers_url":"https://api.github.com/users/grapesmoker/followers","following_url":"https://api.github.com/users/grapesmoker/following{/other_user}","gists_url":"https://api.github.com/users/grapesmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/grapesmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grapesmoker/subscriptions","organizations_url":"https://api.github.com/users/grapesmoker/orgs","repos_url":"https://api.github.com/users/grapesmoker/repos","events_url":"https://api.github.com/users/grapesmoker/events{/privacy}","received_events_url":"https://api.github.com/users/grapesmoker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grapesmoker/regulations-parser","description":"All the code to parse a regulation. ","fork":true,"url":"https://api.github.com/repos/grapesmoker/regulations-parser","forks_url":"https://api.github.com/repos/grapesmoker/regulations-parser/forks","keys_url":"https://api.github.com/repos/grapesmoker/regulations-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grapesmoker/regulations-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grapesmoker/regulations-parser/teams","hooks_url":"https://api.github.com/repos/grapesmoker/regulations-parser/hooks","issue_events_url":"https://api.github.com/repos/grapesmoker/regulations-parser/issues/events{/number}","events_url":"https://api.github.com/repos/grapesmoker/regulations-parser/events","assignees_url":"https://api.github.com/repos/grapesmoker/regulations-parser/assignees{/user}","branches_url":"https://api.github.com/repos/grapesmoker/regulations-parser/branches{/branch}","tags_url":"https://api.github.com/repos/grapesmoker/regulations-parser/tags","blobs_url":"https://api.github.com/repos/grapesmoker/regulations-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grapesmoker/regulations-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grapesmoker/regulations-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/grapesmoker/regulations-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grapesmoker/regulations-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/grapesmoker/regulations-parser/languages","stargazers_url":"https://api.github.com/repos/grapesmoker/regulations-parser/stargazers","contributors_url":"https://api.github.com/repos/grapesmoker/regulations-parser/contributors","subscribers_url":"https://api.github.com/repos/grapesmoker/regulations-parser/subscribers","subscription_url":"https://api.github.com/repos/grapesmoker/regulations-parser/subscription","commits_url":"https://api.github.com/repos/grapesmoker/regulations-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/grapesmoker/regulations-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/grapesmoker/regulations-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/grapesmoker/regulations-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/grapesmoker/regulations-parser/contents/{+path}","compare_url":"https://api.github.com/repos/grapesmoker/regulations-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grapesmoker/regulations-parser/merges","archive_url":"https://api.github.com/repos/grapesmoker/regulations-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grapesmoker/regulations-parser/downloads","issues_url":"https://api.github.com/repos/grapesmoker/regulations-parser/issues{/number}","pulls_url":"https://api.github.com/repos/grapesmoker/regulations-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/grapesmoker/regulations-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/grapesmoker/regulations-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grapesmoker/regulations-parser/labels{/name}","releases_url":"https://api.github.com/repos/grapesmoker/regulations-parser/releases{/id}","created_at":"2015-01-28T15:34:17Z","updated_at":"2015-04-30T17:56:31Z","pushed_at":"2015-08-25T20:23:08Z","git_url":"git://github.com/grapesmoker/regulations-parser.git","ssh_url":"git@github.com:grapesmoker/regulations-parser.git","clone_url":"https://github.com/grapesmoker/regulations-parser.git","svn_url":"https://github.com/grapesmoker/regulations-parser","homepage":null,"size":2997,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"9d13ed14c16b76a0a8cdbf5c1874330ca57c2e6d","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":9153617,"name":"regulations-parser","full_name":"cfpb/regulations-parser","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/regulations-parser","description":"All the code to parse a regulation. ","fork":false,"url":"https://api.github.com/repos/cfpb/regulations-parser","forks_url":"https://api.github.com/repos/cfpb/regulations-parser/forks","keys_url":"https://api.github.com/repos/cfpb/regulations-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/regulations-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/regulations-parser/teams","hooks_url":"https://api.github.com/repos/cfpb/regulations-parser/hooks","issue_events_url":"https://api.github.com/repos/cfpb/regulations-parser/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/regulations-parser/events","assignees_url":"https://api.github.com/repos/cfpb/regulations-parser/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/regulations-parser/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/regulations-parser/tags","blobs_url":"https://api.github.com/repos/cfpb/regulations-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/regulations-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/regulations-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/regulations-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/regulations-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/regulations-parser/languages","stargazers_url":"https://api.github.com/repos/cfpb/regulations-parser/stargazers","contributors_url":"https://api.github.com/repos/cfpb/regulations-parser/contributors","subscribers_url":"https://api.github.com/repos/cfpb/regulations-parser/subscribers","subscription_url":"https://api.github.com/repos/cfpb/regulations-parser/subscription","commits_url":"https://api.github.com/repos/cfpb/regulations-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/regulations-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/regulations-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/regulations-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/regulations-parser/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/regulations-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/regulations-parser/merges","archive_url":"https://api.github.com/repos/cfpb/regulations-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/regulations-parser/downloads","issues_url":"https://api.github.com/repos/cfpb/regulations-parser/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/regulations-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/regulations-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/regulations-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/regulations-parser/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/regulations-parser/releases{/id}","created_at":"2013-04-01T18:55:42Z","updated_at":"2015-07-11T17:52:02Z","pushed_at":"2015-08-25T20:26:38Z","git_url":"git://github.com/cfpb/regulations-parser.git","ssh_url":"git@github.com:cfpb/regulations-parser.git","clone_url":"https://github.com/cfpb/regulations-parser.git","svn_url":"https://github.com/cfpb/regulations-parser","homepage":null,"size":4238,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":14,"forks":30,"open_issues":14,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295"},"html":{"href":"https://github.com/cfpb/regulations-parser/pull/295"},"issue":{"href":"https://api.github.com/repos/cfpb/regulations-parser/issues/295"},"comments":{"href":"https://api.github.com/repos/cfpb/regulations-parser/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/regulations-parser/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/regulations-parser/statuses/3076169144426c95669bc1eeff7db8a1c42bf9b3"}}}}