{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/43325863","id":43325863,"diff_hunk":"@@ -19,6 +19,7 @@\n         \"php\": \">=5.3.9\",\n         \"symfony/polyfill-php55\": \"~1.0\",\n         \"symfony/polyfill-php56\": \"~1.0\",\n+        \"symfony/polyfill-php70\": \"~1.0\",","path":"src/Symfony/Component/Security/Core/composer.json","position":4,"original_position":4,"commit_id":"8ab8ca02eb73f96560bf99522f84f7bab566b4d3","original_commit_id":"8ab8ca02eb73f96560bf99522f84f7bab566b4d3","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"this one needs to be removed in 3.0 as its only there for the deprecated SecureRandom class","created_at":"2015-10-28T22:14:52Z","updated_at":"2015-10-28T22:14:52Z","html_url":"https://github.com/symfony/symfony/pull/16365#discussion_r43325863","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/16365","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/43325863"},"html":{"href":"https://github.com/symfony/symfony/pull/16365#discussion_r43325863"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16365"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/16365","id":48986974,"html_url":"https://github.com/symfony/symfony/pull/16365","diff_url":"https://github.com/symfony/symfony/pull/16365.diff","patch_url":"https://github.com/symfony/symfony/pull/16365.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/16365","number":16365,"state":"open","locked":false,"title":"Add the PHP 7 polyfill for the random_bytes function","user":{"login":"pierredup","id":144858,"avatar_url":"https://avatars.githubusercontent.com/u/144858?v=3","gravatar_id":"","url":"https://api.github.com/users/pierredup","html_url":"https://github.com/pierredup","followers_url":"https://api.github.com/users/pierredup/followers","following_url":"https://api.github.com/users/pierredup/following{/other_user}","gists_url":"https://api.github.com/users/pierredup/gists{/gist_id}","starred_url":"https://api.github.com/users/pierredup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierredup/subscriptions","organizations_url":"https://api.github.com/users/pierredup/orgs","repos_url":"https://api.github.com/users/pierredup/repos","events_url":"https://api.github.com/users/pierredup/events{/privacy}","received_events_url":"https://api.github.com/users/pierredup/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nSome classes (like the `SecureRandom` class) currently depends on the `random_bytes` function, which is only available in the PHP 7 polyfill","created_at":"2015-10-28T10:25:11Z","updated_at":"2015-10-28T22:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f15f1b2420970c623c1949f0c0c5e63541261650","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/16365/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/16365/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/16365/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/8ab8ca02eb73f96560bf99522f84f7bab566b4d3","head":{"label":"pierredup:patch-1","ref":"patch-1","sha":"8ab8ca02eb73f96560bf99522f84f7bab566b4d3","user":{"login":"pierredup","id":144858,"avatar_url":"https://avatars.githubusercontent.com/u/144858?v=3","gravatar_id":"","url":"https://api.github.com/users/pierredup","html_url":"https://github.com/pierredup","followers_url":"https://api.github.com/users/pierredup/followers","following_url":"https://api.github.com/users/pierredup/following{/other_user}","gists_url":"https://api.github.com/users/pierredup/gists{/gist_id}","starred_url":"https://api.github.com/users/pierredup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierredup/subscriptions","organizations_url":"https://api.github.com/users/pierredup/orgs","repos_url":"https://api.github.com/users/pierredup/repos","events_url":"https://api.github.com/users/pierredup/events{/privacy}","received_events_url":"https://api.github.com/users/pierredup/received_events","type":"User","site_admin":false},"repo":{"id":4283536,"name":"symfony","full_name":"pierredup/symfony","owner":{"login":"pierredup","id":144858,"avatar_url":"https://avatars.githubusercontent.com/u/144858?v=3","gravatar_id":"","url":"https://api.github.com/users/pierredup","html_url":"https://github.com/pierredup","followers_url":"https://api.github.com/users/pierredup/followers","following_url":"https://api.github.com/users/pierredup/following{/other_user}","gists_url":"https://api.github.com/users/pierredup/gists{/gist_id}","starred_url":"https://api.github.com/users/pierredup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierredup/subscriptions","organizations_url":"https://api.github.com/users/pierredup/orgs","repos_url":"https://api.github.com/users/pierredup/repos","events_url":"https://api.github.com/users/pierredup/events{/privacy}","received_events_url":"https://api.github.com/users/pierredup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierredup/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/pierredup/symfony","forks_url":"https://api.github.com/repos/pierredup/symfony/forks","keys_url":"https://api.github.com/repos/pierredup/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierredup/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierredup/symfony/teams","hooks_url":"https://api.github.com/repos/pierredup/symfony/hooks","issue_events_url":"https://api.github.com/repos/pierredup/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/pierredup/symfony/events","assignees_url":"https://api.github.com/repos/pierredup/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/pierredup/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/pierredup/symfony/tags","blobs_url":"https://api.github.com/repos/pierredup/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierredup/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierredup/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierredup/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierredup/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/pierredup/symfony/languages","stargazers_url":"https://api.github.com/repos/pierredup/symfony/stargazers","contributors_url":"https://api.github.com/repos/pierredup/symfony/contributors","subscribers_url":"https://api.github.com/repos/pierredup/symfony/subscribers","subscription_url":"https://api.github.com/repos/pierredup/symfony/subscription","commits_url":"https://api.github.com/repos/pierredup/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierredup/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierredup/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierredup/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierredup/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/pierredup/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierredup/symfony/merges","archive_url":"https://api.github.com/repos/pierredup/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierredup/symfony/downloads","issues_url":"https://api.github.com/repos/pierredup/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/pierredup/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/pierredup/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/pierredup/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierredup/symfony/labels{/name}","releases_url":"https://api.github.com/repos/pierredup/symfony/releases{/id}","created_at":"2012-05-10T11:18:20Z","updated_at":"2014-06-29T17:14:43Z","pushed_at":"2015-10-28T10:33:38Z","git_url":"git://github.com/pierredup/symfony.git","ssh_url":"git@github.com:pierredup/symfony.git","clone_url":"https://github.com/pierredup/symfony.git","svn_url":"https://github.com/pierredup/symfony","homepage":"symfony.com","size":63517,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"44b3f63f3016ce16c6d5ca6c7929ea669d80acf5","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-10-28T20:56:43Z","pushed_at":"2015-10-28T21:59:42Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":260000,"stargazers_count":11035,"watchers_count":11035,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4338,"mirror_url":null,"open_issues_count":774,"forks":4338,"open_issues":774,"watchers":11035,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16365"},"html":{"href":"https://github.com/symfony/symfony/pull/16365"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/16365"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/16365/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16365/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/16365/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/8ab8ca02eb73f96560bf99522f84f7bab566b4d3"}}}}