{"action":"closed","number":141,"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/141","id":52280357,"html_url":"https://github.com/Addepar/ember-charts/pull/141","diff_url":"https://github.com/Addepar/ember-charts/pull/141.diff","patch_url":"https://github.com/Addepar/ember-charts/pull/141.patch","issue_url":"https://api.github.com/repos/Addepar/ember-charts/issues/141","number":141,"state":"closed","locked":false,"title":"Fix showing other slices in pie chart legend","user":{"login":"philpee2","id":2244653,"avatar_url":"https://avatars.githubusercontent.com/u/2244653?v=3","gravatar_id":"","url":"https://api.github.com/users/philpee2","html_url":"https://github.com/philpee2","followers_url":"https://api.github.com/users/philpee2/followers","following_url":"https://api.github.com/users/philpee2/following{/other_user}","gists_url":"https://api.github.com/users/philpee2/gists{/gist_id}","starred_url":"https://api.github.com/users/philpee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philpee2/subscriptions","organizations_url":"https://api.github.com/users/philpee2/orgs","repos_url":"https://api.github.com/users/philpee2/repos","events_url":"https://api.github.com/users/philpee2/events{/privacy}","received_events_url":"https://api.github.com/users/philpee2/received_events","type":"User","site_admin":false},"body":"The `for` loop was using the wrong index, resulting in only the first\r\nitem of the \"Other\" slice appearing in the legend. Replaced it with an ES6\r\n`for of` loop so that all slices appear.\r\n\r\nBefore:\r\n![image](https://cloud.githubusercontent.com/assets/2244653/11506597/118a2bb4-9805-11e5-98de-bd99e7782210.png)\r\n\r\nAfter: \r\n![image](https://cloud.githubusercontent.com/assets/2244653/11506579/f94b1496-9804-11e5-8aae-322f0a2073f0.png)\r\n\r\nTests incoming \r\n@Addepar/fire ","created_at":"2015-12-01T16:27:46Z","updated_at":"2015-12-01T17:40:57Z","closed_at":"2015-12-01T17:40:57Z","merged_at":"2015-12-01T17:40:57Z","merge_commit_sha":"699894f173b2922954ff77d8c844cc9476fc32bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/141/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/141/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/issues/141/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/8be0232cb476f1dca6e700333d56b1ff1c0b81f7","head":{"label":"Addepar:philn/fix-pie-legends","ref":"philn/fix-pie-legends","sha":"8be0232cb476f1dca6e700333d56b1ff1c0b81f7","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-27T11:29:23Z","pushed_at":"2015-12-01T17:40:57Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8946,"stargazers_count":670,"watchers_count":670,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":18,"forks":101,"open_issues":18,"watchers":670,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"bb7efabd764a30661aed5810c7e1ac494264df8a","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-27T11:29:23Z","pushed_at":"2015-12-01T17:40:57Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8946,"stargazers_count":670,"watchers_count":670,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":18,"forks":101,"open_issues":18,"watchers":670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/141"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/141"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/141"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-charts/statuses/8be0232cb476f1dca6e700333d56b1ff1c0b81f7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"philpee2","id":2244653,"avatar_url":"https://avatars.githubusercontent.com/u/2244653?v=3","gravatar_id":"","url":"https://api.github.com/users/philpee2","html_url":"https://github.com/philpee2","followers_url":"https://api.github.com/users/philpee2/followers","following_url":"https://api.github.com/users/philpee2/following{/other_user}","gists_url":"https://api.github.com/users/philpee2/gists{/gist_id}","starred_url":"https://api.github.com/users/philpee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philpee2/subscriptions","organizations_url":"https://api.github.com/users/philpee2/orgs","repos_url":"https://api.github.com/users/philpee2/repos","events_url":"https://api.github.com/users/philpee2/events{/privacy}","received_events_url":"https://api.github.com/users/philpee2/received_events","type":"User","site_admin":false},"comments":3,"review_comments":7,"commits":1,"additions":63,"deletions":50,"changed_files":4}}