{"action":"created","comment":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments/22768917","id":22768917,"diff_hunk":"@@ -173,12 +173,6 @@ def get_cache_key(self, request, view):\n         if request.user.is_authenticated():\n             return None  # Only throttle unauthenticated requests.\n \n-        ident = request.META.get('HTTP_X_FORWARDED_FOR')\n-        if ident is None:\n-            ident = request.META.get('REMOTE_ADDR')\n-        else:\n-            ident = ''.join(ident.split())\n-\n         return self.cache_format % {\n             'scope': self.scope,\n             'ident': self.get_ident(request)","path":"rest_framework/throttling.py","position":21,"original_position":21,"commit_id":"d6d08db0dd16f4a4a93b69ecf1c5948f375335b0","original_commit_id":"d6d08db0dd16f4a4a93b69ecf1c5948f375335b0","user":{"login":"jpadilla","id":83319,"avatar_url":"https://avatars.githubusercontent.com/u/83319?v=3","gravatar_id":"","url":"https://api.github.com/users/jpadilla","html_url":"https://github.com/jpadilla","followers_url":"https://api.github.com/users/jpadilla/followers","following_url":"https://api.github.com/users/jpadilla/following{/other_user}","gists_url":"https://api.github.com/users/jpadilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jpadilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpadilla/subscriptions","organizations_url":"https://api.github.com/users/jpadilla/orgs","repos_url":"https://api.github.com/users/jpadilla/repos","events_url":"https://api.github.com/users/jpadilla/events{/privacy}","received_events_url":"https://api.github.com/users/jpadilla/received_events","type":"User","site_admin":false},"body":"@xordoquy note here we weren't using the ident variable","created_at":"2015-01-11T18:56:51Z","updated_at":"2015-01-11T18:56:51Z","html_url":"https://github.com/tomchristie/django-rest-framework/pull/2401#discussion_r22768917","pull_request_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401","_links":{"self":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments/22768917"},"html":{"href":"https://github.com/tomchristie/django-rest-framework/pull/2401#discussion_r22768917"},"pull_request":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401"}}},"pull_request":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401","id":27164486,"html_url":"https://github.com/tomchristie/django-rest-framework/pull/2401","diff_url":"https://github.com/tomchristie/django-rest-framework/pull/2401.diff","patch_url":"https://github.com/tomchristie/django-rest-framework/pull/2401.patch","issue_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2401","number":2401,"state":"open","locked":false,"title":"Fix ident format when using HTTP_X_FORWARDED_FOR","user":{"login":"jpadilla","id":83319,"avatar_url":"https://avatars.githubusercontent.com/u/83319?v=3","gravatar_id":"","url":"https://api.github.com/users/jpadilla","html_url":"https://github.com/jpadilla","followers_url":"https://api.github.com/users/jpadilla/followers","following_url":"https://api.github.com/users/jpadilla/following{/other_user}","gists_url":"https://api.github.com/users/jpadilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jpadilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpadilla/subscriptions","organizations_url":"https://api.github.com/users/jpadilla/orgs","repos_url":"https://api.github.com/users/jpadilla/repos","events_url":"https://api.github.com/users/jpadilla/events{/privacy}","received_events_url":"https://api.github.com/users/jpadilla/received_events","type":"User","site_admin":false},"body":"If `NUM_PROXIES` setting is set to None, `HTTP_X_FORWARDED_FOR` might be used as is, which\r\nmight contain spaces and cause errors on cache backends like memcached. Ref #2400","created_at":"2015-01-11T16:07:26Z","updated_at":"2015-01-11T18:56:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f33dee55a1d1695557ad653e4b5dc7beea050e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401/commits","review_comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401/comments","review_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2401/comments","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/d6d08db0dd16f4a4a93b69ecf1c5948f375335b0","head":{"label":"jpadilla:master","ref":"master","sha":"d6d08db0dd16f4a4a93b69ecf1c5948f375335b0","user":{"login":"jpadilla","id":83319,"avatar_url":"https://avatars.githubusercontent.com/u/83319?v=3","gravatar_id":"","url":"https://api.github.com/users/jpadilla","html_url":"https://github.com/jpadilla","followers_url":"https://api.github.com/users/jpadilla/followers","following_url":"https://api.github.com/users/jpadilla/following{/other_user}","gists_url":"https://api.github.com/users/jpadilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jpadilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpadilla/subscriptions","organizations_url":"https://api.github.com/users/jpadilla/orgs","repos_url":"https://api.github.com/users/jpadilla/repos","events_url":"https://api.github.com/users/jpadilla/events{/privacy}","received_events_url":"https://api.github.com/users/jpadilla/received_events","type":"User","site_admin":false},"repo":{"id":27225339,"name":"django-rest-framework","full_name":"jpadilla/django-rest-framework","owner":{"login":"jpadilla","id":83319,"avatar_url":"https://avatars.githubusercontent.com/u/83319?v=3","gravatar_id":"","url":"https://api.github.com/users/jpadilla","html_url":"https://github.com/jpadilla","followers_url":"https://api.github.com/users/jpadilla/followers","following_url":"https://api.github.com/users/jpadilla/following{/other_user}","gists_url":"https://api.github.com/users/jpadilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jpadilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpadilla/subscriptions","organizations_url":"https://api.github.com/users/jpadilla/orgs","repos_url":"https://api.github.com/users/jpadilla/repos","events_url":"https://api.github.com/users/jpadilla/events{/privacy}","received_events_url":"https://api.github.com/users/jpadilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpadilla/django-rest-framework","description":"Web APIs for Django.","fork":true,"url":"https://api.github.com/repos/jpadilla/django-rest-framework","forks_url":"https://api.github.com/repos/jpadilla/django-rest-framework/forks","keys_url":"https://api.github.com/repos/jpadilla/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpadilla/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpadilla/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/jpadilla/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/jpadilla/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/jpadilla/django-rest-framework/events","assignees_url":"https://api.github.com/repos/jpadilla/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/jpadilla/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/jpadilla/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/jpadilla/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpadilla/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpadilla/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpadilla/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpadilla/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/jpadilla/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/jpadilla/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/jpadilla/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/jpadilla/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/jpadilla/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/jpadilla/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpadilla/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpadilla/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpadilla/django-rest-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/jpadilla/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/jpadilla/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpadilla/django-rest-framework/merges","archive_url":"https://api.github.com/repos/jpadilla/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpadilla/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/jpadilla/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/jpadilla/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/jpadilla/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/jpadilla/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpadilla/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/jpadilla/django-rest-framework/releases{/id}","created_at":"2014-11-27T12:55:14Z","updated_at":"2015-01-11T14:58:24Z","pushed_at":"2015-01-11T14:58:24Z","git_url":"git://github.com/jpadilla/django-rest-framework.git","ssh_url":"git@github.com:jpadilla/django-rest-framework.git","clone_url":"https://github.com/jpadilla/django-rest-framework.git","svn_url":"https://github.com/jpadilla/django-rest-framework","homepage":"www.django-rest-framework.org","size":12518,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomchristie:master","ref":"master","sha":"e9ac1bb78add68635e7f0881c16d2a3ddda2f1b5","user":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"repo":{"id":1431547,"name":"django-rest-framework","full_name":"tomchristie/django-rest-framework","owner":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomchristie/django-rest-framework","description":"Web APIs for Django.","fork":false,"url":"https://api.github.com/repos/tomchristie/django-rest-framework","forks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/forks","keys_url":"https://api.github.com/repos/tomchristie/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomchristie/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomchristie/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/events","assignees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/tomchristie/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tomchristie/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/tomchristie/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomchristie/django-rest-framework/merges","archive_url":"https://api.github.com/repos/tomchristie/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomchristie/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tomchristie/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tomchristie/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomchristie/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/tomchristie/django-rest-framework/releases{/id}","created_at":"2011-03-02T17:13:56Z","updated_at":"2015-01-10T17:46:12Z","pushed_at":"2015-01-10T17:46:11Z","git_url":"git://github.com/tomchristie/django-rest-framework.git","ssh_url":"git@github.com:tomchristie/django-rest-framework.git","clone_url":"https://github.com/tomchristie/django-rest-framework.git","svn_url":"https://github.com/tomchristie/django-rest-framework","homepage":"www.django-rest-framework.org","size":29046,"stargazers_count":3411,"watchers_count":3411,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1040,"mirror_url":null,"open_issues_count":68,"forks":1040,"open_issues":68,"watchers":3411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401"},"html":{"href":"https://github.com/tomchristie/django-rest-framework/pull/2401"},"issue":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2401"},"comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/2401/comments"},"review_comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401/comments"},"review_comment":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/2401/commits"},"statuses":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/d6d08db0dd16f4a4a93b69ecf1c5948f375335b0"}}}}