{"action":"opened","issue":{"url":"https://api.github.com/repos/ethereum/pyethapp/issues/57","labels_url":"https://api.github.com/repos/ethereum/pyethapp/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/pyethapp/issues/57/comments","events_url":"https://api.github.com/repos/ethereum/pyethapp/issues/57/events","html_url":"https://github.com/ethereum/pyethapp/issues/57","id":105049288,"number":57,"title":"Account import parameter mismatch","user":{"login":"holiman","id":142290,"avatar_url":"https://avatars.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-09-05T21:15:05Z","updated_at":"2015-09-05T21:15:05Z","closed_at":null,"body":"When trying to import a key:\r\n\r\n\tubuntu@ubuntu-VirtualBox:~/tools/pyethapp$ pyethapp account import ../pyethereum/zkey.hex\r\n\tNo handlers could be found for logger \"eth.pow\"\r\n\tINFO:app\tusing data in path=/home/ubuntu/.config/pyethapp\r\n\tINFO:config\tloading config path=/home/ubuntu/.config/pyethapp\r\n\tCRITICAL:app\tMove to EthApp.default_config \r\n\tWARNING:accounts\tkeystore directory does not exist directory=/home/ubuntu/.config/pyethapp/keystore\r\n\tWARNING:accounts\tno accounts found \r\n\tINFO:app\tregistering service service=accounts\r\n\tPassword to encrypt private key: \r\n\tRepeat for confirmation: \r\n\tTraceback (most recent call last):\r\n\t  File \"/usr/local/bin/pyethapp\", line 9, in <module>\r\n\t    load_entry_point('pyethapp==1.0.1', 'console_scripts', 'pyethapp')()\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 700, in __call__\r\n\t    return self.main(*args, **kwargs)\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 680, in main\r\n\t    rv = self.invoke(ctx)\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 1027, in invoke\r\n\t    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 1027, in invoke\r\n\t    return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 873, in invoke\r\n\t    return ctx.invoke(self.callback, **ctx.params)\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/core.py\", line 508, in invoke\r\n\t    return callback(*args, **kwargs)\r\n\t  File \"/usr/local/lib/python2.7/dist-packages/click/decorators.py\", line 16, in new_func\r\n\t    return f(get_current_context(), *args, **kwargs)\r\n\t  File \"/home/ubuntu/tools/pyethapp/pyethapp/app.py\", line 500, in import_account\r\n\t    app.services.accounts.add_account(account, path=account.address.encode('hex'))\r\n\tTypeError: add_account() got an unexpected keyword argument 'path'\r\n\r\nI already have a PR from my account, so I'll just paste the fix here : \r\n\r\n\tubuntu@ubuntu-VirtualBox:~/tools/pyethapp$ git diff\r\n\tdiff --git a/pyethapp/app.py b/pyethapp/app.py\r\n\tindex 4542583..b8cbc1f 100644\r\n\t--- a/pyethapp/app.py\r\n\t+++ b/pyethapp/app.py\r\n\t@@ -496,8 +496,11 @@ def import_account(ctx, f, uuid):\r\n\t         password = click.prompt('Password to encrypt private key', default='', hide_input=True,\r\n\t                                 confirmation_prompt=True, show_default=False)\r\n\t     account = Account.new(password, privkey, uuid=id_)\r\n\t+    account.path = os.path.join(os.path.abspath(ctx.obj['config']['data_dir']),\r\n\t+                                ctx.obj['config']['accounts']['keystore_dir'],\r\n\t+                                account.address.encode('hex'))\r\n\t     try:\r\n\t-        app.services.accounts.add_account(account, path=account.address.encode('hex'))\r\n\t+        app.services.accounts.add_account(account)\r\n\t     except IOError:\r\n\t         click.echo('Could not write keystore file. Make sure you have write permission in the '\r\n\t                    'configured directory and check the log for further information.')"}}