{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/32207385","id":32207385,"diff_hunk":"@@ -246,7 +246,10 @@ inline unsigned __int32 low(__int64 n)\n \n //MORE - We really should restructure this file.  Also would this be better with a class interface?\n //Handle ^C/break from a console program.\n-typedef bool (*AbortHandler)();                                                 // return true to exit program\n+\n+enum ahType { aht_terminate, aht_interrupt};","path":"system/jlib/jmisc.hpp","position":6,"original_position":6,"commit_id":"ef5bddc505198e7727c1fd17997d46012063cabe","original_commit_id":"ef5bddc505198e7727c1fd17997d46012063cabe","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"minor: I think this is an abortType rather than an abortHandlerType.  Similar comments about underscores.","created_at":"2015-06-11T10:20:27Z","updated_at":"2015-06-11T10:20:27Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360#discussion_r32207385","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/32207385"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360#discussion_r32207385"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360","id":36302898,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7360","number":7360,"state":"open","locked":false,"title":"HPCC-13156 Modification of jlib and thor signal handling","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"body":"This change allows us to differentiate between a normal shutdown and an abnormal shutdown within components.  We map os specific signals to a generic type (ahType) from within the default abort handlers (WindowsAbortHandler and UnixAbortHandler within jmisc.cpp.)  This then allows us to modify our components signal handlers so that we can test for which generic signal was sent and act accordingly.  I have modified thor so that it does not through an exception to it's logs if a normal shutdown is handled.\r\n\r\nSigned-off-by: Michael Gardner <Michael.Gardner@lexisnexis.com>","created_at":"2015-05-27T13:24:20Z","updated_at":"2015-06-11T10:20:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c9ee9b029f8c78ddbbc6ae7e2b109ff736c62c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7360/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ef5bddc505198e7727c1fd17997d46012063cabe","head":{"label":"Michael-Gardner:HPCC-13156","ref":"HPCC-13156","sha":"ef5bddc505198e7727c1fd17997d46012063cabe","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"repo":{"id":24113512,"name":"HPCC-Platform","full_name":"Michael-Gardner/HPCC-Platform","owner":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Michael-Gardner/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform","forks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/releases{/id}","created_at":"2014-09-16T19:06:46Z","updated_at":"2015-03-30T15:05:42Z","pushed_at":"2015-06-10T19:31:12Z","git_url":"git://github.com/Michael-Gardner/HPCC-Platform.git","ssh_url":"git@github.com:Michael-Gardner/HPCC-Platform.git","clone_url":"https://github.com/Michael-Gardner/HPCC-Platform.git","svn_url":"https://github.com/Michael-Gardner/HPCC-Platform","homepage":"track.hpccsystems.com","size":149353,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"candidate-5.2.0"}},"base":{"label":"hpcc-systems:candidate-5.4.0","ref":"candidate-5.4.0","sha":"6cc574ced0c3a723b2ecee63626382f019faddac","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-05-23T08:18:36Z","pushed_at":"2015-06-11T10:12:27Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":335343,"stargazers_count":252,"watchers_count":252,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":433,"forks":113,"open_issues":433,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7360"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7360"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7360/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7360/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/ef5bddc505198e7727c1fd17997d46012063cabe"}}}}