{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/Kore/issues/138","labels_url":"https://api.github.com/repos/xbmc/Kore/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/Kore/issues/138/comments","events_url":"https://api.github.com/repos/xbmc/Kore/issues/138/events","html_url":"https://github.com/xbmc/Kore/pull/138","id":118044510,"number":138,"title":"Implemented shared element transition for movie posters","user":{"login":"poisdeux","id":4527626,"avatar_url":"https://avatars.githubusercontent.com/u/4527626?v=3","gravatar_id":"","url":"https://api.github.com/users/poisdeux","html_url":"https://github.com/poisdeux","followers_url":"https://api.github.com/users/poisdeux/followers","following_url":"https://api.github.com/users/poisdeux/following{/other_user}","gists_url":"https://api.github.com/users/poisdeux/gists{/gist_id}","starred_url":"https://api.github.com/users/poisdeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poisdeux/subscriptions","organizations_url":"https://api.github.com/users/poisdeux/orgs","repos_url":"https://api.github.com/users/poisdeux/repos","events_url":"https://api.github.com/users/poisdeux/events{/privacy}","received_events_url":"https://api.github.com/users/poisdeux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-20T13:40:39Z","updated_at":"2015-11-23T16:08:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/Kore/pulls/138","html_url":"https://github.com/xbmc/Kore/pull/138","diff_url":"https://github.com/xbmc/Kore/pull/138.diff","patch_url":"https://github.com/xbmc/Kore/pull/138.patch"},"body":"* Refactored OnMovieSelectedListener interface to keep argument list small.\r\n* Changed fragment transition animation to make shared element transition\r\n  smooth and nicely integrated with the whole scene animation."},"comment":{"url":"https://api.github.com/repos/xbmc/Kore/issues/comments/158981445","html_url":"https://github.com/xbmc/Kore/pull/138#issuecomment-158981445","issue_url":"https://api.github.com/repos/xbmc/Kore/issues/138","id":158981445,"user":{"login":"poisdeux","id":4527626,"avatar_url":"https://avatars.githubusercontent.com/u/4527626?v=3","gravatar_id":"","url":"https://api.github.com/users/poisdeux","html_url":"https://github.com/poisdeux","followers_url":"https://api.github.com/users/poisdeux/followers","following_url":"https://api.github.com/users/poisdeux/following{/other_user}","gists_url":"https://api.github.com/users/poisdeux/gists{/gist_id}","starred_url":"https://api.github.com/users/poisdeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poisdeux/subscriptions","organizations_url":"https://api.github.com/users/poisdeux/orgs","repos_url":"https://api.github.com/users/poisdeux/repos","events_url":"https://api.github.com/users/poisdeux/events{/privacy}","received_events_url":"https://api.github.com/users/poisdeux/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T16:08:16Z","updated_at":"2015-11-23T16:08:16Z","body":"I also noticed the ugly update effect after the animation ended. But I wanted to know what you thought of shared element transitions before I put in more effort to fix it. It seems to run smooth now :). But I am not sure if I tested all cases.\r\n\r\nI believe the problem was that, when android measures the layout for the animation, the textviews are empty. When the loader finishes, the textviews are updated and the layout is revalidated. \r\nI could have postponed the transition to the point when the loader finishes and we have all needed info. But this may cause unacceptable lag. Instead, I fixed this by passing all info we already have in the MovieListFragment to the MovieDetailsFragment. Thus, allowing us to fill the textviews in the onCreateView after which android measures the layout.\r\n"}}