{"action":"created","issue":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3304","labels_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3304/labels{/name}","comments_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3304/comments","events_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3304/events","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3304","id":118729598,"number":3304,"title":"First itertation of HUD for vector mask tool","user":{"login":"pineapplespatula","id":1008531,"avatar_url":"https://avatars.githubusercontent.com/u/1008531?v=3","gravatar_id":"","url":"https://api.github.com/users/pineapplespatula","html_url":"https://github.com/pineapplespatula","followers_url":"https://api.github.com/users/pineapplespatula/followers","following_url":"https://api.github.com/users/pineapplespatula/following{/other_user}","gists_url":"https://api.github.com/users/pineapplespatula/gists{/gist_id}","starred_url":"https://api.github.com/users/pineapplespatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineapplespatula/subscriptions","organizations_url":"https://api.github.com/users/pineapplespatula/orgs","repos_url":"https://api.github.com/users/pineapplespatula/repos","events_url":"https://api.github.com/users/pineapplespatula/events{/privacy}","received_events_url":"https://api.github.com/users/pineapplespatula/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"volfied","id":386714,"avatar_url":"https://avatars.githubusercontent.com/u/386714?v=3","gravatar_id":"","url":"https://api.github.com/users/volfied","html_url":"https://github.com/volfied","followers_url":"https://api.github.com/users/volfied/followers","following_url":"https://api.github.com/users/volfied/following{/other_user}","gists_url":"https://api.github.com/users/volfied/gists{/gist_id}","starred_url":"https://api.github.com/users/volfied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volfied/subscriptions","organizations_url":"https://api.github.com/users/volfied/orgs","repos_url":"https://api.github.com/users/volfied/repos","events_url":"https://api.github.com/users/volfied/events{/privacy}","received_events_url":"https://api.github.com/users/volfied/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-11-24T23:58:46Z","updated_at":"2015-11-25T17:59:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/pulls/3304","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3304","diff_url":"https://github.com/adobe-photoshop/spaces-design/pull/3304.diff","patch_url":"https://github.com/adobe-photoshop/spaces-design/pull/3304.patch"},"body":"Create a HUD for the vector mask tool \r\nWhen you select the super select tool and enter mask mode on a layer without a mask. the hud pops up to help you create one. \r\n![screen shot 2015-11-24 at 3 55 46 pm](https://cloud.githubusercontent.com/assets/1008531/11384329/a7955ce2-92c3-11e5-91d6-21cfde563ab0.png)\r\nallowing you to easily create a circular vector mask, \r\n![screen shot 2015-11-24 at 3 56 16 pm](https://cloud.githubusercontent.com/assets/1008531/11384340/b7191cd0-92c3-11e5-8972-e23e2ada4ef1.png)\r\n\r\ncreate a vector mask over the whole rect, or to drop into the pen tool directly. \r\n\r\nSeth also added some very nice overlay drawings on mouse over. \r\n\r\n@ktaki or @chadrolfs should take a look at this one before it is merged. currently there is a behavior very similar to issue #3303 where the overlays look incorrect if you zoom or pan the canvas after entering the HUD\r\n"},"comment":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/comments/159688221","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3304#issuecomment-159688221","issue_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3304","id":159688221,"user":{"login":"volfied","id":386714,"avatar_url":"https://avatars.githubusercontent.com/u/386714?v=3","gravatar_id":"","url":"https://api.github.com/users/volfied","html_url":"https://github.com/volfied","followers_url":"https://api.github.com/users/volfied/followers","following_url":"https://api.github.com/users/volfied/following{/other_user}","gists_url":"https://api.github.com/users/volfied/gists{/gist_id}","starred_url":"https://api.github.com/users/volfied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volfied/subscriptions","organizations_url":"https://api.github.com/users/volfied/orgs","repos_url":"https://api.github.com/users/volfied/repos","events_url":"https://api.github.com/users/volfied/events{/privacy}","received_events_url":"https://api.github.com/users/volfied/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T17:59:11Z","updated_at":"2015-11-25T17:59:11Z","body":"Code itself on micro level looks good. But there are a lot of typos and jsdoc errors. \r\n \r\nThe vector mask HUD code should be in it's own overlay.jsx file. We're bundling superselectOverlay with vectorMask work and it's going to make it a big pain down the road to separate them (and trust me, we will have to). Can you break that into it's own file? "}}