{"action":"closed","issue":{"url":"https://api.github.com/repos/o2project/start-dash-of-site-making/issues/79","labels_url":"https://api.github.com/repos/o2project/start-dash-of-site-making/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/o2project/start-dash-of-site-making/issues/79/comments","events_url":"https://api.github.com/repos/o2project/start-dash-of-site-making/issues/79/events","html_url":"https://github.com/o2project/start-dash-of-site-making/issues/79","id":121024216,"number":79,"title":"ch03.md フロントエンド面レビュー","user":{"login":"yoshiko-pg","id":6822923,"avatar_url":"https://avatars.githubusercontent.com/u/6822923?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshiko-pg","html_url":"https://github.com/yoshiko-pg","followers_url":"https://api.github.com/users/yoshiko-pg/followers","following_url":"https://api.github.com/users/yoshiko-pg/following{/other_user}","gists_url":"https://api.github.com/users/yoshiko-pg/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshiko-pg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshiko-pg/subscriptions","organizations_url":"https://api.github.com/users/yoshiko-pg/orgs","repos_url":"https://api.github.com/users/yoshiko-pg/repos","events_url":"https://api.github.com/users/yoshiko-pg/events{/privacy}","received_events_url":"https://api.github.com/users/yoshiko-pg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/o2project/start-dash-of-site-making/labels/writing","name":"writing","color":"fbca04"}],"state":"closed","locked":false,"assignee":{"login":"kubosho","id":430267,"avatar_url":"https://avatars.githubusercontent.com/u/430267?v=3","gravatar_id":"","url":"https://api.github.com/users/kubosho","html_url":"https://github.com/kubosho","followers_url":"https://api.github.com/users/kubosho/followers","following_url":"https://api.github.com/users/kubosho/following{/other_user}","gists_url":"https://api.github.com/users/kubosho/gists{/gist_id}","starred_url":"https://api.github.com/users/kubosho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubosho/subscriptions","organizations_url":"https://api.github.com/users/kubosho/orgs","repos_url":"https://api.github.com/users/kubosho/repos","events_url":"https://api.github.com/users/kubosho/events{/privacy}","received_events_url":"https://api.github.com/users/kubosho/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/o2project/start-dash-of-site-making/milestones/5","html_url":"https://github.com/o2project/start-dash-of-site-making/milestones/%E6%8E%A8%E6%95%B2","labels_url":"https://api.github.com/repos/o2project/start-dash-of-site-making/milestones/5/labels","id":1184263,"number":5,"title":"推敲","description":"戻しも含めた日数","creator":{"login":"kubosho","id":430267,"avatar_url":"https://avatars.githubusercontent.com/u/430267?v=3","gravatar_id":"","url":"https://api.github.com/users/kubosho","html_url":"https://github.com/kubosho","followers_url":"https://api.github.com/users/kubosho/followers","following_url":"https://api.github.com/users/kubosho/following{/other_user}","gists_url":"https://api.github.com/users/kubosho/gists{/gist_id}","starred_url":"https://api.github.com/users/kubosho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubosho/subscriptions","organizations_url":"https://api.github.com/users/kubosho/orgs","repos_url":"https://api.github.com/users/kubosho/repos","events_url":"https://api.github.com/users/kubosho/events{/privacy}","received_events_url":"https://api.github.com/users/kubosho/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":10,"state":"open","created_at":"2015-06-28T15:27:31Z","updated_at":"2015-12-14T05:21:17Z","due_on":"2015-12-14T15:00:00Z","closed_at":null},"comments":2,"created_at":"2015-12-08T14:57:11Z","updated_at":"2015-12-14T05:21:17Z","closed_at":"2015-12-14T05:21:17Z","body":"# ch03.md\r\n\r\n## ファイル構成\r\nindex.htmlがないなと思いました。\r\nあと、ライブラリのディレクトリがcomponentsって初めて見たので新鮮でした。\r\n\r\n## グローバルナビゲーションのマークアップ\r\n\r\n>  activeに関しては、クラス名に接頭辞を付けなくて大丈夫です。\r\n\r\nこれはbootstrapのクラスだからですよね？上の書き方だと、オリジナルのクラスだけど例外的にプレフィックスをつけないように読み取れたので・・・\r\n\r\nと思ったら、下の方でactiveにスタイルあててますね。\r\nここではll-使わないのはなぜでしょうか？\r\n\r\n## HTMLのまとめ\r\n\r\nHTMLは問題ないように見えました。\r\n念の為にW3Cバリデータに通してみたんですが、header要素とfooter要素にはrole属性が不要のようです。\r\nhttps://validator.w3.org/#validate_by_input\r\n\r\nあとこれは単純に質問なんですが、navってheaderの外にだすのがベターなんですかね？私いつもheaderの中に書いてました。。\r\n\r\n## ヘッダーの見た目をよくする\r\n\r\nidとクラスの使い分けの意図が知りたいなーと思いました。\r\n大きめの枠がidなのだとは思うのですが。\r\n\r\n`pointer: default;` → `cursor: default;` ですかね。\r\n\r\nあと、\r\n\r\n```css\r\n#ll-nav .active > a:after,\r\n#ll-nav .active > a:focus:after,\r\n#ll-nav .active > a:hover:after {\r\n```\r\n\r\nこれって一番上のa:afterだけじゃだめなんですかね？\r\nあと:afterはIE8対象外なら::afterのほうが推奨になっているのでベターかなと思います！\r\n\r\n## CSSのまとめ\r\n\r\n/* 横幅が768px以上のときの設定 */　の上だけ空行がないのが気になりました！\r\n\r\n\r\n"}}