{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/5190","labels_url":"https://api.github.com/repos/facebook/react/issues/5190/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/5190/comments","events_url":"https://api.github.com/repos/facebook/react/issues/5190/events","html_url":"https://github.com/facebook/react/pull/5190","id":111726344,"number":5190,"title":"ReactDOMComponentTree","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-15T23:13:09Z","updated_at":"2015-10-16T08:30:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/5190","html_url":"https://github.com/facebook/react/pull/5190","diff_url":"https://github.com/facebook/react/pull/5190.diff","patch_url":"https://github.com/facebook/react/pull/5190.patch"},"body":"New module! With this, we have a new module that uses the component tree to store DOM nodes. Most of the logic in this file relates to markup adoption -- if we were to drop that (along with server rendering) this file could just be a `return inst._nativeNode;`.\r\n\r\nThis works with useCreateElement only because we need to reference each node as it's created.\r\n\r\nEvents is now the only thing using hierarchical IDs and `ReactMount.getNode` -- I'll use `ReactDOMComponentTree.getInstanceFromNode` to make that work."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/148652234","html_url":"https://github.com/facebook/react/pull/5190#issuecomment-148652234","issue_url":"https://api.github.com/repos/facebook/react/issues/5190","id":148652234,"user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T08:30:55Z","updated_at":"2015-10-16T08:30:55Z","body":"Getting rid of hierarchical IDs (replacing them with numbers, probably) and the giant hash map we have in ReactMount. We can probably kill data-reactid entirely when not using server-side rendering."}}