{"action":"opened","number":168,"pull_request":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/168","id":29878281,"html_url":"https://github.com/camptocamp/ngeo/pull/168","diff_url":"https://github.com/camptocamp/ngeo/pull/168.diff","patch_url":"https://github.com/camptocamp/ngeo/pull/168.patch","issue_url":"https://api.github.com/repos/camptocamp/ngeo/issues/168","number":168,"state":"open","locked":false,"title":"Changes to the popup service","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"This PR makes a number of changes to the ngeo popup service:\r\n\r\n* Use an isolate scope\r\n* Replace the `show` method by `setOpen` (making it possible to hide the popup using `setOpen(false)`)\r\n* Add a `getOpen` method to know whether the popup is currently open\r\n\r\nPlease review.","created_at":"2015-02-24T08:21:15Z","updated_at":"2015-02-24T08:21:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/168/commits","review_comments_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/168/comments","review_comment_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/issues/168/comments","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/63106f0366d9b68554eb455b916e6597231baafc","head":{"label":"elemoine:popup","ref":"popup","sha":"63106f0366d9b68554eb455b916e6597231baafc","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"repo":{"id":20214698,"name":"ngeo","full_name":"elemoine/ngeo","owner":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elemoine/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":true,"url":"https://api.github.com/repos/elemoine/ngeo","forks_url":"https://api.github.com/repos/elemoine/ngeo/forks","keys_url":"https://api.github.com/repos/elemoine/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elemoine/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elemoine/ngeo/teams","hooks_url":"https://api.github.com/repos/elemoine/ngeo/hooks","issue_events_url":"https://api.github.com/repos/elemoine/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/elemoine/ngeo/events","assignees_url":"https://api.github.com/repos/elemoine/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/elemoine/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/elemoine/ngeo/tags","blobs_url":"https://api.github.com/repos/elemoine/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elemoine/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elemoine/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/elemoine/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elemoine/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/elemoine/ngeo/languages","stargazers_url":"https://api.github.com/repos/elemoine/ngeo/stargazers","contributors_url":"https://api.github.com/repos/elemoine/ngeo/contributors","subscribers_url":"https://api.github.com/repos/elemoine/ngeo/subscribers","subscription_url":"https://api.github.com/repos/elemoine/ngeo/subscription","commits_url":"https://api.github.com/repos/elemoine/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/elemoine/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/elemoine/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/elemoine/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/elemoine/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/elemoine/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elemoine/ngeo/merges","archive_url":"https://api.github.com/repos/elemoine/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elemoine/ngeo/downloads","issues_url":"https://api.github.com/repos/elemoine/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/elemoine/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/elemoine/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/elemoine/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elemoine/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/elemoine/ngeo/releases{/id}","created_at":"2014-05-27T09:38:07Z","updated_at":"2014-12-10T11:16:09Z","pushed_at":"2015-02-24T08:01:45Z","git_url":"git://github.com/elemoine/ngeo.git","ssh_url":"git@github.com:elemoine/ngeo.git","clone_url":"https://github.com/elemoine/ngeo.git","svn_url":"https://github.com/elemoine/ngeo","homepage":null,"size":3757,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"7ab89a07745ec34504ae7b9b94c5ea1abff5a771","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":20212761,"name":"ngeo","full_name":"camptocamp/ngeo","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":false,"url":"https://api.github.com/repos/camptocamp/ngeo","forks_url":"https://api.github.com/repos/camptocamp/ngeo/forks","keys_url":"https://api.github.com/repos/camptocamp/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/ngeo/teams","hooks_url":"https://api.github.com/repos/camptocamp/ngeo/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/ngeo/events","assignees_url":"https://api.github.com/repos/camptocamp/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/ngeo/tags","blobs_url":"https://api.github.com/repos/camptocamp/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/ngeo/languages","stargazers_url":"https://api.github.com/repos/camptocamp/ngeo/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/ngeo/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/ngeo/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/ngeo/subscription","commits_url":"https://api.github.com/repos/camptocamp/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/ngeo/merges","archive_url":"https://api.github.com/repos/camptocamp/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/ngeo/downloads","issues_url":"https://api.github.com/repos/camptocamp/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/ngeo/releases{/id}","created_at":"2014-05-27T08:34:54Z","updated_at":"2015-02-23T08:33:27Z","pushed_at":"2015-02-23T08:33:26Z","git_url":"git://github.com/camptocamp/ngeo.git","ssh_url":"git@github.com:camptocamp/ngeo.git","clone_url":"https://github.com/camptocamp/ngeo.git","svn_url":"https://github.com/camptocamp/ngeo","homepage":null,"size":3451,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/168"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/168"},"issue":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/168"},"comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/ngeo/statuses/63106f0366d9b68554eb455b916e6597231baafc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":27,"deletions":11,"changed_files":3}}