{"action":"opened","issue":{"url":"https://api.github.com/repos/Metaswitch/sprout/issues/1194","labels_url":"https://api.github.com/repos/Metaswitch/sprout/issues/1194/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/issues/1194/comments","events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/1194/events","html_url":"https://github.com/Metaswitch/sprout/issues/1194","id":107954613,"number":1194,"title":"Sprout's implementation `Session-expires` and `Min-SE` headers does not match RFC 4028","user":{"login":"AlexHockey","id":4903205,"avatar_url":"https://avatars.githubusercontent.com/u/4903205?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexHockey","html_url":"https://github.com/AlexHockey","followers_url":"https://api.github.com/users/AlexHockey/followers","following_url":"https://api.github.com/users/AlexHockey/following{/other_user}","gists_url":"https://api.github.com/users/AlexHockey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexHockey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexHockey/subscriptions","organizations_url":"https://api.github.com/users/AlexHockey/orgs","repos_url":"https://api.github.com/users/AlexHockey/repos","events_url":"https://api.github.com/users/AlexHockey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexHockey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-09-23T16:11:41Z","updated_at":"2015-09-23T16:11:41Z","closed_at":null,"body":"Sprout's current handling of session expires is doesn't match RFC4028 very closely, which has a variety of consequences. For example:\r\n\r\n* Sprout never does any session-expires processing on the response, which means if the UAS does not support RFC 4028 we never ask the UAC to handle session refresh. \r\n* Sprout refuses to reduce a session-expires (even though it allowed to) and rejects the request instead.\r\n* When sprout sees a request with both session-expires and min-se, it slams the session-expires down to equal the min-se, for no discernible reason whatsoever.\r\n* When sprout realizes it cannot set the session-expires it wants, it rejects the request. This is not allowed if the UAC does not support session timers. Even if session-timers are supported, sprout uses the wrong error code which means the UAC does not know that it might be able to submit a different request that is acceptable. \r\n\r\nRaising this as one issue since I'd imagine we'd fix all of these problems at once. "}}