{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/46443887","id":46443887,"diff_hunk":"@@ -101,49 +101,64 @@ func NewPersistentVolumeClaimBinder(kubeClient client.Interface, syncPeriod time\n func (binder *PersistentVolumeClaimBinder) addVolume(obj interface{}) {\n \tbinder.lock.Lock()\n \tdefer binder.lock.Unlock()\n-\tvolume := obj.(*api.PersistentVolume)","path":"Godeps/_workspace/src/k8s.io/kubernetes/pkg/controller/persistentvolume/persistentvolume_claim_binder_controller.go","position":4,"original_position":4,"commit_id":"7d723e47b9d47ac99120c332392eb2e3f5de2931","original_commit_id":"7d723e47b9d47ac99120c332392eb2e3f5de2931","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"body":"Yeah, that's better. Less indentation.","created_at":"2015-12-02T17:15:57Z","updated_at":"2015-12-02T17:15:57Z","html_url":"https://github.com/openshift/origin/pull/6170#discussion_r46443887","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6170","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/46443887"},"html":{"href":"https://github.com/openshift/origin/pull/6170#discussion_r46443887"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6170"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6170","id":52424400,"html_url":"https://github.com/openshift/origin/pull/6170","diff_url":"https://github.com/openshift/origin/pull/6170.diff","patch_url":"https://github.com/openshift/origin/pull/6170.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6170","number":6170,"state":"open","locked":false,"title":"UPSTREAM: 18042: added cast checks to controllers to prevent nil panics","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"body":"Probable resolution of #6005, pending further feedback from the user.\r\n\r\nThe nil pointer was due to insufficient error checking when casting from `obj` to a PV (was passed DeletedFinalStateUnknown)\r\n\r\n@liggitt @pweil- ","created_at":"2015-12-02T17:06:27Z","updated_at":"2015-12-02T17:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1798f40534efe30a62cc8bad3a9f2e32cc9b57a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6170/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6170/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6170/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/7d723e47b9d47ac99120c332392eb2e3f5de2931","head":{"label":"markturansky:patch_nil_pointer_fix","ref":"patch_nil_pointer_fix","sha":"7d723e47b9d47ac99120c332392eb2e3f5de2931","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"repo":{"id":24418520,"name":"origin","full_name":"markturansky/origin","owner":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markturansky/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/markturansky/origin","forks_url":"https://api.github.com/repos/markturansky/origin/forks","keys_url":"https://api.github.com/repos/markturansky/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markturansky/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markturansky/origin/teams","hooks_url":"https://api.github.com/repos/markturansky/origin/hooks","issue_events_url":"https://api.github.com/repos/markturansky/origin/issues/events{/number}","events_url":"https://api.github.com/repos/markturansky/origin/events","assignees_url":"https://api.github.com/repos/markturansky/origin/assignees{/user}","branches_url":"https://api.github.com/repos/markturansky/origin/branches{/branch}","tags_url":"https://api.github.com/repos/markturansky/origin/tags","blobs_url":"https://api.github.com/repos/markturansky/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markturansky/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markturansky/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/markturansky/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markturansky/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/markturansky/origin/languages","stargazers_url":"https://api.github.com/repos/markturansky/origin/stargazers","contributors_url":"https://api.github.com/repos/markturansky/origin/contributors","subscribers_url":"https://api.github.com/repos/markturansky/origin/subscribers","subscription_url":"https://api.github.com/repos/markturansky/origin/subscription","commits_url":"https://api.github.com/repos/markturansky/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/markturansky/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/markturansky/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/markturansky/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/markturansky/origin/contents/{+path}","compare_url":"https://api.github.com/repos/markturansky/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markturansky/origin/merges","archive_url":"https://api.github.com/repos/markturansky/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markturansky/origin/downloads","issues_url":"https://api.github.com/repos/markturansky/origin/issues{/number}","pulls_url":"https://api.github.com/repos/markturansky/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/markturansky/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/markturansky/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markturansky/origin/labels{/name}","releases_url":"https://api.github.com/repos/markturansky/origin/releases{/id}","created_at":"2014-09-24T14:35:37Z","updated_at":"2015-01-22T17:00:08Z","pushed_at":"2015-12-02T17:02:07Z","git_url":"git://github.com/markturansky/origin.git","ssh_url":"git@github.com:markturansky/origin.git","clone_url":"https://github.com/markturansky/origin.git","svn_url":"https://github.com/markturansky/origin","homepage":"https://openshift.github.io","size":178489,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c3617a420565a7ffa61a3d7081933e6c86477bbd","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-12-01T07:08:50Z","pushed_at":"2015-12-02T17:12:23Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":227058,"stargazers_count":843,"watchers_count":843,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":530,"mirror_url":null,"open_issues_count":716,"forks":530,"open_issues":716,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6170"},"html":{"href":"https://github.com/openshift/origin/pull/6170"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6170"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6170/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6170/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6170/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/7d723e47b9d47ac99120c332392eb2e3f5de2931"}}}}