{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/pygit2/issues/513","labels_url":"https://api.github.com/repos/libgit2/pygit2/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/pygit2/issues/513/comments","events_url":"https://api.github.com/repos/libgit2/pygit2/issues/513/events","html_url":"https://github.com/libgit2/pygit2/pull/513","id":68064659,"number":513,"title":"Submodule.open() fix, URL write support","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-13T10:34:51Z","updated_at":"2015-04-16T09:11:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgit2/pygit2/pulls/513","html_url":"https://github.com/libgit2/pygit2/pull/513","diff_url":"https://github.com/libgit2/pygit2/pull/513.diff","patch_url":"https://github.com/libgit2/pygit2/pull/513.patch"},"body":"Well. As has been initially proposed by @jdavid this PR rewrites the submodule feature I've been implementing in Python with CFFI. Reason has been a problem that I overlooked with the previous implementation, where the repository returned by submodule.open() was not a pygit2.Submodule but of the C SubmoduleType, thus missing some properties/methods. As I found no easy way to properly instantiate the pygit2.Submodule type instead of the C type from C code I just reimplemented that in Python. If there is any obvious way of doing it I may as well do that, if requested.\r\n\r\nSome additional functions have been implemented, as well, thus providing URL write support for submodules, their repos and gitmodule entries."},"comment":{"url":"https://api.github.com/repos/libgit2/pygit2/issues/comments/93686721","html_url":"https://github.com/libgit2/pygit2/pull/513#issuecomment-93686721","issue_url":"https://api.github.com/repos/libgit2/pygit2/issues/513","id":93686721,"user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T09:11:55Z","updated_at":"2015-04-16T09:11:55Z","body":"Ah, I get what's happening here. The build is tripping over an error in libgit2 which I've already been fixing upstream. As we're not using the newest build the error is obviously still happening. I'll split up the pull request, as the type-fix is applicable without my libgit2 fixes."}}