{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484","id":118777667,"number":484,"title":"Validation Against SAS Calculator Nov Updates ","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-11-25T07:19:23Z","updated_at":"2015-12-08T19:36:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/484","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484.patch"},"body":"There are a couple commits that I'm not very sure about and need to double check later. The `py.test` won't pass at this moment, primarily because a new variable `AGERANGE` being added. This issue will be fixed very soon. \r\n@MattHJensen @martinholmer Please feel free to start looking at these changes, and let me know if any places look suspicious."},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/162991720","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/484#issuecomment-162991720","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/484","id":162991720,"user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T19:36:43Z","updated_at":"2015-12-08T19:36:43Z","body":"@MattHJensen said:\r\n> I would also recommend summarizing output changes by pasting the 'diagnostic table' for both master and this branch into the comments section. You can generate the diagnostic table by setting up a calculator object and then running calc.diagnostic_table().\r\n\r\nSean @GoFroggyRun, I agree with Matt: two summaries are better than one.  They will provided different  perspectives, which is always good when trying to assess the large number of tax logic changes included in this pull request."}}