{"action":"created","issue":{"url":"https://api.github.com/repos/rvagg/nan/issues/254","labels_url":"https://api.github.com/repos/rvagg/nan/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/rvagg/nan/issues/254/comments","events_url":"https://api.github.com/repos/rvagg/nan/issues/254/events","html_url":"https://github.com/rvagg/nan/pull/254","id":54809977,"number":254,"title":"windows: Circumvent warning C4800","user":{"login":"kkoopa","id":4103081,"avatar_url":"https://avatars.githubusercontent.com/u/4103081?v=3","gravatar_id":"","url":"https://api.github.com/users/kkoopa","html_url":"https://github.com/kkoopa","followers_url":"https://api.github.com/users/kkoopa/followers","following_url":"https://api.github.com/users/kkoopa/following{/other_user}","gists_url":"https://api.github.com/users/kkoopa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoopa/subscriptions","organizations_url":"https://api.github.com/users/kkoopa/orgs","repos_url":"https://api.github.com/users/kkoopa/repos","events_url":"https://api.github.com/users/kkoopa/events{/privacy}","received_events_url":"https://api.github.com/users/kkoopa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-19T20:43:30Z","updated_at":"2015-01-19T21:34:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rvagg/nan/pulls/254","html_url":"https://github.com/rvagg/nan/pull/254","diff_url":"https://github.com/rvagg/nan/pull/254.diff","patch_url":"https://github.com/rvagg/nan/pull/254.patch"},"body":"msvc does not like imlpicit boolean conversion\r\n\r\nIs this the right way to fix it?\r\nWhat if I use an unsigned int?\r\n\r\nWould it be better to do this?\r\n```c++\r\ntemplate<>\r\ninline typename NanIntern::Factory<v8::Boolean>::return_t\r\nNanNew<v8::Boolean, A0>(A0 arg0) {\r\n  return NanIntern::Factory<v8::Boolean>::New(arg0 != 0);\r\n}\r\n```\r\nShould the above then be complemented with this?\r\n```c++\r\ntemplate<>\r\ninline typename NanIntern::Factory<v8::Boolean>::return_t\r\nNanNew<v8::Boolean, bool>(A0 arg0) {\r\n  return NanIntern::Factory<v8::Boolean>::New(arg0);\r\n}\r\n```\r\n\r\nR=@agnat"},"comment":{"url":"https://api.github.com/repos/rvagg/nan/issues/comments/70565082","html_url":"https://github.com/rvagg/nan/pull/254#issuecomment-70565082","issue_url":"https://api.github.com/repos/rvagg/nan/issues/254","id":70565082,"user":{"login":"kkoopa","id":4103081,"avatar_url":"https://avatars.githubusercontent.com/u/4103081?v=3","gravatar_id":"","url":"https://api.github.com/users/kkoopa","html_url":"https://github.com/kkoopa","followers_url":"https://api.github.com/users/kkoopa/followers","following_url":"https://api.github.com/users/kkoopa/following{/other_user}","gists_url":"https://api.github.com/users/kkoopa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoopa/subscriptions","organizations_url":"https://api.github.com/users/kkoopa/orgs","repos_url":"https://api.github.com/users/kkoopa/repos","events_url":"https://api.github.com/users/kkoopa/events{/privacy}","received_events_url":"https://api.github.com/users/kkoopa/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T21:34:57Z","updated_at":"2015-01-19T21:34:57Z","body":"This ought to do."}}