{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/46839022","id":46839022,"diff_hunk":"@@ -343,7 +359,12 @@ const DropDownMenu = React.createClass({\n   },\n \n   _onMenuRequestClose() {\n-    this.setState({open:false});\n+    setTimeout(() => {","path":"src/drop-down-menu.jsx","position":252,"original_position":252,"commit_id":"2c75c20d2d880fb73535ab86d6d24ec787d78bc2","original_commit_id":"2c75c20d2d880fb73535ab86d6d24ec787d78bc2","user":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"body":"Without it, when you `requestClose('offScreen')` from the popover, the setState triggers some infinite loop type re-rendering issue which hangs the browser.  I only noticed it today - I think the core issue might be with the popover, but haven't been able to locate it.","created_at":"2015-12-07T16:10:34Z","updated_at":"2015-12-07T16:10:34Z","html_url":"https://github.com/callemall/material-ui/pull/2150#discussion_r46839022","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/2150","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/46839022"},"html":{"href":"https://github.com/callemall/material-ui/pull/2150#discussion_r46839022"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2150"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/2150","id":50541009,"html_url":"https://github.com/callemall/material-ui/pull/2150","diff_url":"https://github.com/callemall/material-ui/pull/2150.diff","patch_url":"https://github.com/callemall/material-ui/pull/2150.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/2150","number":2150,"state":"open","locked":false,"title":"dropdown menu using popover","user":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"body":"This one has 1 issue.\r\n\r\nBecause the menu-items aren't rendered or on the DOM until the popover is open, the autoWidth can't work the same way.  Please have a look and make sure you're happy with how it's behaving before merging.  Open to suggestions for fixes.","created_at":"2015-11-12T17:26:45Z","updated_at":"2015-12-07T16:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e7fcf02f00f9f2fe35f5d4581d6dea33ce4761","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/2150/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/2150/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/2150/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/2c75c20d2d880fb73535ab86d6d24ec787d78bc2","head":{"label":"chrismcv:dropdown-popover-menu","ref":"dropdown-popover-menu","sha":"2c75c20d2d880fb73535ab86d6d24ec787d78bc2","user":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"repo":{"id":36790524,"name":"material-ui","full_name":"chrismcv/material-ui","owner":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrismcv/material-ui","description":"A Set of React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/chrismcv/material-ui","forks_url":"https://api.github.com/repos/chrismcv/material-ui/forks","keys_url":"https://api.github.com/repos/chrismcv/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrismcv/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrismcv/material-ui/teams","hooks_url":"https://api.github.com/repos/chrismcv/material-ui/hooks","issue_events_url":"https://api.github.com/repos/chrismcv/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/chrismcv/material-ui/events","assignees_url":"https://api.github.com/repos/chrismcv/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/chrismcv/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/chrismcv/material-ui/tags","blobs_url":"https://api.github.com/repos/chrismcv/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrismcv/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrismcv/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrismcv/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrismcv/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/chrismcv/material-ui/languages","stargazers_url":"https://api.github.com/repos/chrismcv/material-ui/stargazers","contributors_url":"https://api.github.com/repos/chrismcv/material-ui/contributors","subscribers_url":"https://api.github.com/repos/chrismcv/material-ui/subscribers","subscription_url":"https://api.github.com/repos/chrismcv/material-ui/subscription","commits_url":"https://api.github.com/repos/chrismcv/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrismcv/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrismcv/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrismcv/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrismcv/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/chrismcv/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrismcv/material-ui/merges","archive_url":"https://api.github.com/repos/chrismcv/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrismcv/material-ui/downloads","issues_url":"https://api.github.com/repos/chrismcv/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/chrismcv/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/chrismcv/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/chrismcv/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrismcv/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/chrismcv/material-ui/releases{/id}","created_at":"2015-06-03T08:32:01Z","updated_at":"2015-06-03T08:32:02Z","pushed_at":"2015-12-07T13:42:18Z","git_url":"git://github.com/chrismcv/material-ui.git","ssh_url":"git@github.com:chrismcv/material-ui.git","clone_url":"https://github.com/chrismcv/material-ui.git","svn_url":"https://github.com/chrismcv/material-ui","homepage":"http://material-ui.com","size":25900,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"3a11da2e6b61bb22e031bade970bf06c30ffccc0","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","created_at":"2014-08-18T19:11:54Z","updated_at":"2015-12-07T13:34:43Z","pushed_at":"2015-12-07T15:58:39Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":38999,"stargazers_count":12296,"watchers_count":12296,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1975,"mirror_url":null,"open_issues_count":464,"forks":1975,"open_issues":464,"watchers":12296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2150"},"html":{"href":"https://github.com/callemall/material-ui/pull/2150"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2150"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2150/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2150/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2150/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/2c75c20d2d880fb73535ab86d6d24ec787d78bc2"}}}}