{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/bourbon/issues/592","labels_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/592/comments","events_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/592/events","html_url":"https://github.com/thoughtbot/bourbon/pull/592","id":51232331,"number":592,"title":"Bourbon family lint!","user":{"login":"mmwtsn","id":1479130,"avatar_url":"https://avatars.githubusercontent.com/u/1479130?v=3","gravatar_id":"","url":"https://api.github.com/users/mmwtsn","html_url":"https://github.com/mmwtsn","followers_url":"https://api.github.com/users/mmwtsn/followers","following_url":"https://api.github.com/users/mmwtsn/following{/other_user}","gists_url":"https://api.github.com/users/mmwtsn/gists{/gist_id}","starred_url":"https://api.github.com/users/mmwtsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmwtsn/subscriptions","organizations_url":"https://api.github.com/users/mmwtsn/orgs","repos_url":"https://api.github.com/users/mmwtsn/repos","events_url":"https://api.github.com/users/mmwtsn/events{/privacy}","received_events_url":"https://api.github.com/users/mmwtsn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thoughtbot/bourbon/labels/refactor","name":"refactor","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2014-12-07T21:30:57Z","updated_at":"2015-01-01T23:16:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/592","html_url":"https://github.com/thoughtbot/bourbon/pull/592","diff_url":"https://github.com/thoughtbot/bourbon/pull/592.diff","patch_url":"https://github.com/thoughtbot/bourbon/pull/592.patch"},"body":"## Description\r\nI inadvertently linted my entire vendor directory last week while setting up Gulp on a project. Bourbon threw quite a few errors! This is the result of running SCSS-Lint over Bourbon.\r\n\r\nThis pull request intentionally violates the contributing guidelines for the time being. I thought this format would make it easier to review changes relative to their respective SCSS-Lint rules. It should make reversions easier as well if we decide a different setting is preferable. I'm happy to squash these down to a single commit if you decide to merge it in.\r\n\r\n## SCSS Config\r\nI tried to keep things in line with the [Thoughtbot style guide](https://github.com/thoughtbot/guides/tree/master/style#sass) as much as possible and came up with the following [SCSS-Lint config](https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md) as a base:\r\n\r\n```yaml\r\nlinters:\r\n  ElsePlacement:\r\n    style: new_line\r\n  LeadingZero:\r\n    style: include_zero\r\n  SelectorDepth:\r\n    max_depth: 6\r\n  StringQuotes:\r\n    style: double_quotes\r\n  TrailingZero:\r\n    enabled: false\r\n  UnnecessaryMantissa:\r\n    enabled: false\r\n```\r\n\r\nI also disabled `VendorPrefixes` and the `Space*` family as the former was not applicable here and the latter was largely noise due to white space alignment across multiple files. If a SCSS-Lint config can be agreed upon (and you find this useful) I'll open pull requests for Neat and Bitters.\r\n\r\n## Ignored Warnings\r\nThere were a few warnings that I ignored:\r\n\r\n### Comment\r\nC-style comment header seemed harmless enough at `_bourbon.scss:0`.\r\n\r\n### DuplicateProperty\r\nDuplication intentional at `css3/_background.scss:54` and `css3/_background-image.scss:41`.\r\n\r\n### ElsePlacement\r\nIgnored one line `@if` and `@else if` on `addons/_directional-values.scss:[35, 36, 37, 88]`. \r\n\r\n### Indentation\r\nThis is a tricky one as so many lines are indented with readability in mind.\r\n\r\nGiven that, the folowing were ignored:\r\n\r\n- `css3/_background-image.scss:20`\r\n- `css3/_background.scss:[23, 40, 46]`\r\n- `css3/_border-image.scss:[18, 35, 41, 49, 50]`\r\n- `css3/_transition.scss:[31, 32, 45, 46, 61, 62, 63]`\r\n\r\n### NameFormat\r\nShould the preference for lowercase variable names be ignored for single letter\r\nvariables?\r\n\r\nPrivate function names were ignored. This feature should land in the next release of SCSS-Lint.\r\n\r\n### PropertySortOrder\r\nThis one could probably use a patch back up at SCSS-Lint. Ignored a warning requesting that vendor-prefixed be alphabetized along with non-vendor-prefixed properties in `css3/_image-rendering.scss:4`. Also ignored a warning to alphabetize in `css3/_transition.scss:44` in preference for visual alignment here due to lack of properties.\r\n\r\n### StringQuotes\r\nAre they necessary in `css3/_radial-gradient.scss`?\r\n\r\n### TrailingSemicolon\r\nIgnored warnings for `addons/_directional-values.scss:[29, 30, 31, 32, 34, 35, 36, 37]` because the parser seemed a bit confused by this file."},"comment":{"url":"https://api.github.com/repos/thoughtbot/bourbon/issues/comments/68501837","html_url":"https://github.com/thoughtbot/bourbon/pull/592#issuecomment-68501837","issue_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/592","id":68501837,"user":{"login":"tysongach","id":903327,"avatar_url":"https://avatars.githubusercontent.com/u/903327?v=3","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"created_at":"2015-01-01T23:16:56Z","updated_at":"2015-01-01T23:16:56Z","body":"@mmwtsn Can you add the SCSS-Lint config file to the PR (the one from Neat)?"}}