{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/comments/25773806","id":25773806,"diff_hunk":"@@ -220,70 +220,43 @@ def start_depth\n \n   def ignore_list(description)\n     ignore_list = [\n-      \"tmp\",\n-      \"var/tmp\",\n-      \"lost+found\",\n-      \"var/run\",\n-      \"var/lib/rpm\",\n-      \".snapshots\",\n-      description.store.base_path.sub(/^\\//, \"\"),\n-      \"proc\",\n-      \"boot\"\n+      \"/tmp\",\n+      \"/var/tmp\",\n+      \"/lost+found\",\n+      \"/var/run\",\n+      \"/var/lib/rpm\",\n+      \"/.snapshots\",\n+      description.store.base_path,\n+      \"/proc\",\n+      \"/boot\"\n     ]\n \n     # Information about users and groups are extracted by the according inspector\n     ignore_list += [\n-      \"etc/passwd\",\n-      \"etc/shadow\",\n-      \"etc/group\"\n+      \"/etc/passwd\",\n+      \"/etc/shadow\",\n+      \"/etc/group\"\n     ]\n \n     # Information about services is extracted by the ServicesInspector, so\n     # we ignore the links representing the same information when inspecting\n     # unmanaged files.\n     ignore_list += [\n-      \"etc/init.d/boot.d\",\n-      \"etc/init.d/rc0.d\",\n-      \"etc/init.d/rc1.d\",\n-      \"etc/init.d/rc2.d\",\n-      \"etc/init.d/rc3.d\",\n-      \"etc/init.d/rc4.d\",\n-      \"etc/init.d/rc5.d\",\n-      \"etc/init.d/rc6.d\",\n-      \"etc/init.d/rcS.d\"\n-    ]\n-  end\n-\n-  def ignore_list_dirs(description)\n-    list = [\n-      \"/tmp/*\",\n-      \"/var/tmp/*\",\n-      \"/lost+found/*\",\n-      \"/var/run/*\",\n-      \"/var/lib/rpm/*\",\n-      \"/.snapshots/*\",\n-      description.store.base_path + \"/*\",\n-      \"/proc/*\",\n-      \"/boot/*\"\n+      \"/etc/init.d/boot.d\",\n+      \"/etc/init.d/rc0.d\",\n+      \"/etc/init.d/rc1.d\",\n+      \"/etc/init.d/rc2.d\",\n+      \"/etc/init.d/rc3.d\",\n+      \"/etc/init.d/rc4.d\",\n+      \"/etc/init.d/rc5.d\",\n+      \"/etc/init.d/rc6.d\",\n+      \"/etc/init.d/rcS.d\"\n     ]\n \n-    # Information about services is extracted by the ServicesInspector, so\n-    # we ignore the links representing the same information when inspecting\n-    # unmanaged files.\n-    list += [\n-      \"/etc/init.d/boot.d/*\",\n-      \"/etc/init.d/rc0.d/*\",\n-      \"/etc/init.d/rc1.d/*\",\n-      \"/etc/init.d/rc2.d/*\",\n-      \"/etc/init.d/rc3.d/*\",\n-      \"/etc/init.d/rc4.d/*\",\n-      \"/etc/init.d/rc5.d/*\",\n-      \"/etc/init.d/rc6.d/*\",\n-      \"/etc/init.d/rcS.d/*\"\n-    ]\n+    ignore_list\n   end\n \n-  def inspect(system, description, options = nil)\n+  def inspect(system, description, filter, options = {})","path":"plugins/inspect/unmanaged_files_inspector.rb","position":90,"original_position":90,"commit_id":"c7275a99f7740943ea16eeba989de850c8ce5d7d","original_commit_id":"c7275a99f7740943ea16eeba989de850c8ce5d7d","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Assignment Branch Condition size for inspect is too high. [151/15]","created_at":"2015-03-04T13:30:05Z","updated_at":"2015-03-04T13:30:05Z","html_url":"https://github.com/SUSE/machinery/pull/659#discussion_r25773806","pull_request_url":"https://api.github.com/repos/SUSE/machinery/pulls/659","_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments/25773806"},"html":{"href":"https://github.com/SUSE/machinery/pull/659#discussion_r25773806"},"pull_request":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/659"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/659","id":30446878,"html_url":"https://github.com/SUSE/machinery/pull/659","diff_url":"https://github.com/SUSE/machinery/pull/659.diff","patch_url":"https://github.com/SUSE/machinery/pull/659.patch","issue_url":"https://api.github.com/repos/SUSE/machinery/issues/659","number":659,"state":"open","locked":false,"title":"[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_150303_implement_skip_files_option'","user":{"login":"aduffeck","id":203813,"avatar_url":"https://avatars.githubusercontent.com/u/203813?v=3","gravatar_id":"","url":"https://api.github.com/users/aduffeck","html_url":"https://github.com/aduffeck","followers_url":"https://api.github.com/users/aduffeck/followers","following_url":"https://api.github.com/users/aduffeck/following{/other_user}","gists_url":"https://api.github.com/users/aduffeck/gists{/gist_id}","starred_url":"https://api.github.com/users/aduffeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduffeck/subscriptions","organizations_url":"https://api.github.com/users/aduffeck/orgs","repos_url":"https://api.github.com/users/aduffeck/repos","events_url":"https://api.github.com/users/aduffeck/events{/privacy}","received_events_url":"https://api.github.com/users/aduffeck/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\n  * 6c4e4f0 Add changelog entry for the --skip-files option\n  * 9c9f52d Document --skip-files option in man page\n  * 5b68305 Test \"--skip-files\" option in the unmanaged files integration test\n  * f0d9fdc Show warning when filtering with a scope which doesn't support it yet\n  * 403d231 Implement \"--skip-files\" option for \"machinery inspect\"\n  * 2dac6d1 Make UnmanagedFilesInspector adhere to given filters","created_at":"2015-03-04T08:41:53Z","updated_at":"2015-03-04T13:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b562318bb4b1618cbe8b749fa93982c7b36d6358","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/machinery/pulls/659/commits","review_comments_url":"https://api.github.com/repos/SUSE/machinery/pulls/659/comments","review_comment_url":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/machinery/issues/659/comments","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/c7275a99f7740943ea16eeba989de850c8ce5d7d","head":{"label":"SUSE:review_150303_implement_skip_files_option","ref":"review_150303_implement_skip_files_option","sha":"c7275a99f7740943ea16eeba989de850c8ce5d7d","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-03-04T09:35:53Z","pushed_at":"2015-03-04T13:29:50Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":14235,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":31,"forks":6,"open_issues":31,"watchers":41,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"b3d13922a15b0a85c0bc587803f10b54bb2eff6e","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-03-04T09:35:53Z","pushed_at":"2015-03-04T13:29:50Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":14235,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":31,"forks":6,"open_issues":31,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/659"},"html":{"href":"https://github.com/SUSE/machinery/pull/659"},"issue":{"href":"https://api.github.com/repos/SUSE/machinery/issues/659"},"comments":{"href":"https://api.github.com/repos/SUSE/machinery/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/machinery/statuses/c7275a99f7740943ea16eeba989de850c8ce5d7d"}}}}