{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/39374175","id":39374175,"diff_hunk":"@@ -166,6 +172,13 @@ void ensureInputParameters()\n     if (!fps)\n         fps = 30;\n \n+    if (ipbMode == 0)","path":"tests/encodehelp.h","position":38,"original_position":38,"commit_id":"9688b9a9eb96206a13c50069b9b665e1337212d7","original_commit_id":"9688b9a9eb96206a13c50069b9b665e1337212d7","user":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"body":"Aactually, my origial idea same as you, but finally I changed my mind because: 1. ipb_mode is more easy to know what it means. 2. ipb_mode is similar to avcenc's mode, it will be easier to compare yamienc and avcenc. 3. As our dirver and yami implemetaion, if user set a lager ipPerid, it will bring very obvious quality decline than IP mode, so ipPeriod eqaul to 3 is my recommend. User may refer our setting (IBBPBBP) after he read our test case. On the other hand, he can set ipPeriod to other values because we provide ipPeriod not ipbMode as yami interface.","created_at":"2015-09-14T09:20:05Z","updated_at":"2015-09-14T09:20:05Z","html_url":"https://github.com/01org/libyami/pull/310#discussion_r39374175","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/39374175"},"html":{"href":"https://github.com/01org/libyami/pull/310#discussion_r39374175"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/310","id":44405095,"html_url":"https://github.com/01org/libyami/pull/310","diff_url":"https://github.com/01org/libyami/pull/310.diff","patch_url":"https://github.com/01org/libyami/pull/310.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/310","number":310,"state":"open","locked":false,"title":"Add hevc encoding support and ipb mode setting","user":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-08T08:32:16Z","updated_at":"2015-09-14T09:20:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31571907210ad0b05c889ff9e1f18fc2e01816b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/310/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/310/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/310/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/9688b9a9eb96206a13c50069b9b665e1337212d7","head":{"label":"lizhong1008:hevc-rebased","ref":"hevc-rebased","sha":"9688b9a9eb96206a13c50069b9b665e1337212d7","user":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"repo":{"id":37236061,"name":"libyami","full_name":"lizhong1008/libyami","owner":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lizhong1008/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/lizhong1008/libyami","forks_url":"https://api.github.com/repos/lizhong1008/libyami/forks","keys_url":"https://api.github.com/repos/lizhong1008/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizhong1008/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizhong1008/libyami/teams","hooks_url":"https://api.github.com/repos/lizhong1008/libyami/hooks","issue_events_url":"https://api.github.com/repos/lizhong1008/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/lizhong1008/libyami/events","assignees_url":"https://api.github.com/repos/lizhong1008/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/lizhong1008/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/lizhong1008/libyami/tags","blobs_url":"https://api.github.com/repos/lizhong1008/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizhong1008/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizhong1008/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizhong1008/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizhong1008/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/lizhong1008/libyami/languages","stargazers_url":"https://api.github.com/repos/lizhong1008/libyami/stargazers","contributors_url":"https://api.github.com/repos/lizhong1008/libyami/contributors","subscribers_url":"https://api.github.com/repos/lizhong1008/libyami/subscribers","subscription_url":"https://api.github.com/repos/lizhong1008/libyami/subscription","commits_url":"https://api.github.com/repos/lizhong1008/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizhong1008/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizhong1008/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizhong1008/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizhong1008/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/lizhong1008/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizhong1008/libyami/merges","archive_url":"https://api.github.com/repos/lizhong1008/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizhong1008/libyami/downloads","issues_url":"https://api.github.com/repos/lizhong1008/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/lizhong1008/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/lizhong1008/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/lizhong1008/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizhong1008/libyami/labels{/name}","releases_url":"https://api.github.com/repos/lizhong1008/libyami/releases{/id}","created_at":"2015-06-11T02:59:58Z","updated_at":"2015-07-17T07:27:18Z","pushed_at":"2015-09-10T02:27:50Z","git_url":"git://github.com/lizhong1008/libyami.git","ssh_url":"git@github.com:lizhong1008/libyami.git","clone_url":"https://github.com/lizhong1008/libyami.git","svn_url":"https://github.com/lizhong1008/libyami","homepage":null,"size":2236,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"a4cb390bec76d260e5af24b3ff6a5feeaf022938","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","created_at":"2014-04-01T06:44:19Z","updated_at":"2015-09-11T11:18:09Z","pushed_at":"2015-09-14T08:47:25Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":4973,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/310"},"html":{"href":"https://github.com/01org/libyami/pull/310"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/310"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/9688b9a9eb96206a13c50069b9b665e1337212d7"}}}}