{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/39479470","id":39479470,"diff_hunk":"@@ -22,7 +22,8 @@ module.exports = {\n     }\n   },\n   app: {\n-    title: defaultEnvConfig.app.title + ' - Development Environment'\n+    title: defaultEnvConfig.app.title + ' - Development Environment',\n+    domain: 'localhost:3000'","path":"config/env/development.js","position":6,"original_position":6,"commit_id":"7ed319461853b888aaa3158d697a729b7f4410ae","original_commit_id":"7ed319461853b888aaa3158d697a729b7f4410ae","user":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"body":"indeed, let's not hardcode the port there with the domain.","created_at":"2015-09-15T06:57:29Z","updated_at":"2015-09-15T06:57:29Z","html_url":"https://github.com/meanjs/mean/pull/871#discussion_r39479470","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/871","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/39479470"},"html":{"href":"https://github.com/meanjs/mean/pull/871#discussion_r39479470"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/871"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/871","id":43966382,"html_url":"https://github.com/meanjs/mean/pull/871","diff_url":"https://github.com/meanjs/mean/pull/871.diff","patch_url":"https://github.com/meanjs/mean/pull/871.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/871","number":871,"state":"open","locked":false,"title":"Add config options 'domain'","user":{"login":"Koblaid","id":941889,"avatar_url":"https://avatars.githubusercontent.com/u/941889?v=3","gravatar_id":"","url":"https://api.github.com/users/Koblaid","html_url":"https://github.com/Koblaid","followers_url":"https://api.github.com/users/Koblaid/followers","following_url":"https://api.github.com/users/Koblaid/following{/other_user}","gists_url":"https://api.github.com/users/Koblaid/gists{/gist_id}","starred_url":"https://api.github.com/users/Koblaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koblaid/subscriptions","organizations_url":"https://api.github.com/users/Koblaid/orgs","repos_url":"https://api.github.com/users/Koblaid/repos","events_url":"https://api.github.com/users/Koblaid/events{/privacy}","received_events_url":"https://api.github.com/users/Koblaid/received_events","type":"User","site_admin":false},"body":"The value will be used when the backend has to generate urls which\r\npoint to the app. Using the hostname sent in the HTTP header is\r\ndangerous since an attacker could send a request with a spoofed\r\nHTTP header (HTTP Host header attack).\r\n\r\nIf the config is not set a loud warning is printed on startup and\r\nthe hostname of the HTTP header is used nevertheless.","created_at":"2015-09-02T08:38:02Z","updated_at":"2015-09-15T06:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a8926807b889c2753a4f0bbb2b93d557d1baf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/871/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/871/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/871/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/7ed319461853b888aaa3158d697a729b7f4410ae","head":{"label":"Koblaid:dont-use-host-from-http-header","ref":"dont-use-host-from-http-header","sha":"7ed319461853b888aaa3158d697a729b7f4410ae","user":{"login":"Koblaid","id":941889,"avatar_url":"https://avatars.githubusercontent.com/u/941889?v=3","gravatar_id":"","url":"https://api.github.com/users/Koblaid","html_url":"https://github.com/Koblaid","followers_url":"https://api.github.com/users/Koblaid/followers","following_url":"https://api.github.com/users/Koblaid/following{/other_user}","gists_url":"https://api.github.com/users/Koblaid/gists{/gist_id}","starred_url":"https://api.github.com/users/Koblaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koblaid/subscriptions","organizations_url":"https://api.github.com/users/Koblaid/orgs","repos_url":"https://api.github.com/users/Koblaid/repos","events_url":"https://api.github.com/users/Koblaid/events{/privacy}","received_events_url":"https://api.github.com/users/Koblaid/received_events","type":"User","site_admin":false},"repo":{"id":41787156,"name":"mean","full_name":"Koblaid/mean","owner":{"login":"Koblaid","id":941889,"avatar_url":"https://avatars.githubusercontent.com/u/941889?v=3","gravatar_id":"","url":"https://api.github.com/users/Koblaid","html_url":"https://github.com/Koblaid","followers_url":"https://api.github.com/users/Koblaid/followers","following_url":"https://api.github.com/users/Koblaid/following{/other_user}","gists_url":"https://api.github.com/users/Koblaid/gists{/gist_id}","starred_url":"https://api.github.com/users/Koblaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koblaid/subscriptions","organizations_url":"https://api.github.com/users/Koblaid/orgs","repos_url":"https://api.github.com/users/Koblaid/repos","events_url":"https://api.github.com/users/Koblaid/events{/privacy}","received_events_url":"https://api.github.com/users/Koblaid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Koblaid/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":true,"url":"https://api.github.com/repos/Koblaid/mean","forks_url":"https://api.github.com/repos/Koblaid/mean/forks","keys_url":"https://api.github.com/repos/Koblaid/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Koblaid/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Koblaid/mean/teams","hooks_url":"https://api.github.com/repos/Koblaid/mean/hooks","issue_events_url":"https://api.github.com/repos/Koblaid/mean/issues/events{/number}","events_url":"https://api.github.com/repos/Koblaid/mean/events","assignees_url":"https://api.github.com/repos/Koblaid/mean/assignees{/user}","branches_url":"https://api.github.com/repos/Koblaid/mean/branches{/branch}","tags_url":"https://api.github.com/repos/Koblaid/mean/tags","blobs_url":"https://api.github.com/repos/Koblaid/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Koblaid/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Koblaid/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/Koblaid/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Koblaid/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/Koblaid/mean/languages","stargazers_url":"https://api.github.com/repos/Koblaid/mean/stargazers","contributors_url":"https://api.github.com/repos/Koblaid/mean/contributors","subscribers_url":"https://api.github.com/repos/Koblaid/mean/subscribers","subscription_url":"https://api.github.com/repos/Koblaid/mean/subscription","commits_url":"https://api.github.com/repos/Koblaid/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/Koblaid/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/Koblaid/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/Koblaid/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/Koblaid/mean/contents/{+path}","compare_url":"https://api.github.com/repos/Koblaid/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Koblaid/mean/merges","archive_url":"https://api.github.com/repos/Koblaid/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Koblaid/mean/downloads","issues_url":"https://api.github.com/repos/Koblaid/mean/issues{/number}","pulls_url":"https://api.github.com/repos/Koblaid/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/Koblaid/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/Koblaid/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Koblaid/mean/labels{/name}","releases_url":"https://api.github.com/repos/Koblaid/mean/releases{/id}","created_at":"2015-09-02T07:39:29Z","updated_at":"2015-09-02T07:39:30Z","pushed_at":"2015-09-02T08:37:33Z","git_url":"git://github.com/Koblaid/mean.git","ssh_url":"git@github.com:Koblaid/mean.git","clone_url":"https://github.com/Koblaid/mean.git","svn_url":"https://github.com/Koblaid/mean","homepage":"http://meanjs.org","size":2890,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:master","ref":"master","sha":"320826bde8190ac470d5854df4e68c7dfe6b0aac","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","created_at":"2013-12-29T13:01:15Z","updated_at":"2015-09-15T00:18:02Z","pushed_at":"2015-09-15T01:33:14Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":7042,"stargazers_count":2562,"watchers_count":2562,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":930,"mirror_url":null,"open_issues_count":73,"forks":930,"open_issues":73,"watchers":2562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/871"},"html":{"href":"https://github.com/meanjs/mean/pull/871"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/871"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/7ed319461853b888aaa3158d697a729b7f4410ae"}}}}