{"action":"opened","number":327,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327","id":30376312,"html_url":"https://github.com/OPM/opm-autodiff/pull/327","diff_url":"https://github.com/OPM/opm-autodiff/pull/327.diff","patch_url":"https://github.com/OPM/opm-autodiff/pull/327.patch","issue_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/327","number":327,"state":"open","locked":false,"title":"Simplify properties","user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"body":"This PR simplifies the viscosity and formation volume factor interfaces: only a single function for each phase remains, the one that takes AD objects. This results in a massive reduction of copy-and-pasted almost-identical functions, making it much easier to get a grip on the property classes and their interface.\r\n\r\nThe downsides are:\r\n - Potential for a slight performance degradation in places where no derivatives are needed, see the commit message of fbf06c0, If a problem, this can be handled by making the bOil(), muGas() etc. functions explicitly use a simpler treatment for input with no derivatives, this has so far only been done in BlackoilPropsAdFromDeck::muWat().\r\n - Slight increase in code complexity in those same few places. One way to deal with this is to make convenience functions in BlackoilPropsAdInterface taking non-AD variables that forward the call to the AD-taking ones. Only the AD-taking ones are virtual and required by subclasses.\r\n\r\nI hope that @dr-robertk or @totto82 can see if they get performance degradation on the Norne case with this PR, I do not have existing timing data for comparison on my system.","created_at":"2015-03-03T14:12:58Z","updated_at":"2015-03-03T14:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-autodiff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/327/comments","statuses_url":"https://api.github.com/repos/OPM/opm-autodiff/statuses/fbf06c06e79f99251ad2f89a43fba6596e1fb54e","head":{"label":"atgeirr:simplify-props","ref":"simplify-props","sha":"fbf06c06e79f99251ad2f89a43fba6596e1fb54e","user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"repo":{"id":10097592,"name":"opm-autodiff","full_name":"atgeirr/opm-autodiff","owner":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atgeirr/opm-autodiff","description":"Utilities for automatic differentiation and simulators based on AD.","fork":true,"url":"https://api.github.com/repos/atgeirr/opm-autodiff","forks_url":"https://api.github.com/repos/atgeirr/opm-autodiff/forks","keys_url":"https://api.github.com/repos/atgeirr/opm-autodiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atgeirr/opm-autodiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atgeirr/opm-autodiff/teams","hooks_url":"https://api.github.com/repos/atgeirr/opm-autodiff/hooks","issue_events_url":"https://api.github.com/repos/atgeirr/opm-autodiff/issues/events{/number}","events_url":"https://api.github.com/repos/atgeirr/opm-autodiff/events","assignees_url":"https://api.github.com/repos/atgeirr/opm-autodiff/assignees{/user}","branches_url":"https://api.github.com/repos/atgeirr/opm-autodiff/branches{/branch}","tags_url":"https://api.github.com/repos/atgeirr/opm-autodiff/tags","blobs_url":"https://api.github.com/repos/atgeirr/opm-autodiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atgeirr/opm-autodiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atgeirr/opm-autodiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/atgeirr/opm-autodiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atgeirr/opm-autodiff/statuses/{sha}","languages_url":"https://api.github.com/repos/atgeirr/opm-autodiff/languages","stargazers_url":"https://api.github.com/repos/atgeirr/opm-autodiff/stargazers","contributors_url":"https://api.github.com/repos/atgeirr/opm-autodiff/contributors","subscribers_url":"https://api.github.com/repos/atgeirr/opm-autodiff/subscribers","subscription_url":"https://api.github.com/repos/atgeirr/opm-autodiff/subscription","commits_url":"https://api.github.com/repos/atgeirr/opm-autodiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/atgeirr/opm-autodiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/atgeirr/opm-autodiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/atgeirr/opm-autodiff/issues/comments{/number}","contents_url":"https://api.github.com/repos/atgeirr/opm-autodiff/contents/{+path}","compare_url":"https://api.github.com/repos/atgeirr/opm-autodiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atgeirr/opm-autodiff/merges","archive_url":"https://api.github.com/repos/atgeirr/opm-autodiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atgeirr/opm-autodiff/downloads","issues_url":"https://api.github.com/repos/atgeirr/opm-autodiff/issues{/number}","pulls_url":"https://api.github.com/repos/atgeirr/opm-autodiff/pulls{/number}","milestones_url":"https://api.github.com/repos/atgeirr/opm-autodiff/milestones{/number}","notifications_url":"https://api.github.com/repos/atgeirr/opm-autodiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atgeirr/opm-autodiff/labels{/name}","releases_url":"https://api.github.com/repos/atgeirr/opm-autodiff/releases{/id}","created_at":"2013-05-16T09:01:36Z","updated_at":"2015-03-02T09:36:41Z","pushed_at":"2015-03-03T14:00:32Z","git_url":"git://github.com/atgeirr/opm-autodiff.git","ssh_url":"git@github.com:atgeirr/opm-autodiff.git","clone_url":"https://github.com/atgeirr/opm-autodiff.git","svn_url":"https://github.com/atgeirr/opm-autodiff","homepage":null,"size":3001,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"4be1671b4fd77444949c730f686b36af3caa1bac","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":10097543,"name":"opm-autodiff","full_name":"OPM/opm-autodiff","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-autodiff","description":"Utilities for automatic differentiation and simulators based on AD.","fork":false,"url":"https://api.github.com/repos/OPM/opm-autodiff","forks_url":"https://api.github.com/repos/OPM/opm-autodiff/forks","keys_url":"https://api.github.com/repos/OPM/opm-autodiff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-autodiff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-autodiff/teams","hooks_url":"https://api.github.com/repos/OPM/opm-autodiff/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-autodiff/events","assignees_url":"https://api.github.com/repos/OPM/opm-autodiff/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-autodiff/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-autodiff/tags","blobs_url":"https://api.github.com/repos/OPM/opm-autodiff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-autodiff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-autodiff/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-autodiff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-autodiff/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-autodiff/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-autodiff/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-autodiff/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-autodiff/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-autodiff/subscription","commits_url":"https://api.github.com/repos/OPM/opm-autodiff/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-autodiff/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-autodiff/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-autodiff/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-autodiff/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-autodiff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-autodiff/merges","archive_url":"https://api.github.com/repos/OPM/opm-autodiff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-autodiff/downloads","issues_url":"https://api.github.com/repos/OPM/opm-autodiff/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-autodiff/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-autodiff/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-autodiff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-autodiff/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-autodiff/releases{/id}","created_at":"2013-05-16T08:59:22Z","updated_at":"2015-03-03T13:39:08Z","pushed_at":"2015-03-03T13:39:08Z","git_url":"git://github.com/OPM/opm-autodiff.git","ssh_url":"git@github.com:OPM/opm-autodiff.git","clone_url":"https://github.com/OPM/opm-autodiff.git","svn_url":"https://github.com/OPM/opm-autodiff","homepage":null,"size":4372,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":26,"forks":19,"open_issues":26,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327"},"html":{"href":"https://github.com/OPM/opm-autodiff/pull/327"},"issue":{"href":"https://api.github.com/repos/OPM/opm-autodiff/issues/327"},"comments":{"href":"https://api.github.com/repos/OPM/opm-autodiff/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-autodiff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-autodiff/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-autodiff/statuses/fbf06c06e79f99251ad2f89a43fba6596e1fb54e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":51,"deletions":565,"changed_files":7}}