{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3385","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3385/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3385/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3385/events","html_url":"https://github.com/zfsonlinux/zfs/pull/3385","id":74001619,"number":3385,"title":"Sanitize temporary pool name in spa_create","user":{"login":"ryao","id":1386373,"avatar_url":"https://avatars.githubusercontent.com/u/1386373?v=3","gravatar_id":"","url":"https://api.github.com/users/ryao","html_url":"https://github.com/ryao","followers_url":"https://api.github.com/users/ryao/followers","following_url":"https://api.github.com/users/ryao/following{/other_user}","gists_url":"https://api.github.com/users/ryao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryao/subscriptions","organizations_url":"https://api.github.com/users/ryao/orgs","repos_url":"https://api.github.com/users/ryao/repos","events_url":"https://api.github.com/users/ryao/events{/privacy}","received_events_url":"https://api.github.com/users/ryao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T14:14:09Z","updated_at":"2015-05-07T18:36:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3385","html_url":"https://github.com/zfsonlinux/zfs/pull/3385","diff_url":"https://github.com/zfsonlinux/zfs/pull/3385.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3385.patch"},"body":"The code that implemented temporary pool name creation did not sanitize\r\nthe pool name. This is normally done in the ioctl code, but the\r\ntemporary pool name is passed as a property, such that sanitization\r\nshould be done in spa_create() itself. Use of illegal names can cause\r\nruntime failures. Naturally, they do not persist after a reboot.\r\n\r\nSigned-off-by: Richard Yao <ryao@gentoo.org>"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/99971837","html_url":"https://github.com/zfsonlinux/zfs/pull/3385#issuecomment-99971837","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3385","id":99971837,"user":{"login":"ryao","id":1386373,"avatar_url":"https://avatars.githubusercontent.com/u/1386373?v=3","gravatar_id":"","url":"https://api.github.com/users/ryao","html_url":"https://github.com/ryao","followers_url":"https://api.github.com/users/ryao/followers","following_url":"https://api.github.com/users/ryao/following{/other_user}","gists_url":"https://api.github.com/users/ryao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryao/subscriptions","organizations_url":"https://api.github.com/users/ryao/orgs","repos_url":"https://api.github.com/users/ryao/repos","events_url":"https://api.github.com/users/ryao/events{/privacy}","received_events_url":"https://api.github.com/users/ryao/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T18:36:20Z","updated_at":"2015-05-07T18:36:20Z","body":"I ported this to Illumos as part of a larger port of the temporary pool name work to Illumos:\r\n\r\nhttps://reviews.csiden.org/r/216\r\n\r\nIt is meant as a practice run for porting more important things, like /dev/zfs ABI stabilization work, so that it can be properly reviewed."}}