{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/367","labels_url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/367/labels{/name}","comments_url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/367/comments","events_url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/367/events","html_url":"https://github.com/OpenSourcePolicyCenter/Tax-Calculator/pull/367","id":108710535,"number":367,"title":"[WIP] move behavioral assumptions to params.json","user":{"login":"MattHJensen","id":8301092,"avatar_url":"https://avatars.githubusercontent.com/u/8301092?v=3","gravatar_id":"","url":"https://api.github.com/users/MattHJensen","html_url":"https://github.com/MattHJensen","followers_url":"https://api.github.com/users/MattHJensen/followers","following_url":"https://api.github.com/users/MattHJensen/following{/other_user}","gists_url":"https://api.github.com/users/MattHJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/MattHJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattHJensen/subscriptions","organizations_url":"https://api.github.com/users/MattHJensen/orgs","repos_url":"https://api.github.com/users/MattHJensen/repos","events_url":"https://api.github.com/users/MattHJensen/events{/privacy}","received_events_url":"https://api.github.com/users/MattHJensen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-28T17:49:34Z","updated_at":"2015-10-02T17:44:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/pulls/367","html_url":"https://github.com/OpenSourcePolicyCenter/Tax-Calculator/pull/367","diff_url":"https://github.com/OpenSourcePolicyCenter/Tax-Calculator/pull/367.diff","patch_url":"https://github.com/OpenSourcePolicyCenter/Tax-Calculator/pull/367.patch"},"body":"This PR places behavioral assumptions, such as income and substitution effects, in `params.json` and uses them in `behavior().` \r\n\r\nThis is probably not a good long-term solution because everything else about our Parameters class has to do with \"tax law parameters\" rather than \"economic parameters.\"  In fact, I suggested a component of a different solution on Feb 21 in #138. @martinholmer, @talumbau and I have also very briefly discussed other options on a phone call at some point. \r\n\r\nThat said, @PeterDSteinberg and I want to place these economic assumptions in params.json for now while we think of a better long-term home because our Parameters class provides all the functionality necessary to make these economic assumptions available to webapp users.\r\n\r\n@martinholmer, I hope you have a chance to look at this. "},"comment":{"url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/comments/145095834","html_url":"https://github.com/OpenSourcePolicyCenter/Tax-Calculator/pull/367#issuecomment-145095834","issue_url":"https://api.github.com/repos/OpenSourcePolicyCenter/Tax-Calculator/issues/367","id":145095834,"user":{"login":"MattHJensen","id":8301092,"avatar_url":"https://avatars.githubusercontent.com/u/8301092?v=3","gravatar_id":"","url":"https://api.github.com/users/MattHJensen","html_url":"https://github.com/MattHJensen","followers_url":"https://api.github.com/users/MattHJensen/followers","following_url":"https://api.github.com/users/MattHJensen/following{/other_user}","gists_url":"https://api.github.com/users/MattHJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/MattHJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattHJensen/subscriptions","organizations_url":"https://api.github.com/users/MattHJensen/orgs","repos_url":"https://api.github.com/users/MattHJensen/repos","events_url":"https://api.github.com/users/MattHJensen/events{/privacy}","received_events_url":"https://api.github.com/users/MattHJensen/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T17:44:38Z","updated_at":"2015-10-02T17:44:38Z","body":"@PeterDSteinberg  I just renamed the `Behavior` method `implement_reform()` to `update_behavior()`. \r\n\r\nI also think that we should have one dictionary of `reforms` to pass to `params.implement_reform()` and a separate dictionary of `new_behavior` to pass to `behavior.update_behavior()`, and I went ahead and made this throughout `tests_behavior.py`."}}