{"action":"created","issue":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/146","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/146/comments","events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/146/events","html_url":"https://github.com/pyinstaller/pyinstaller/pull/146","id":37783076,"number":146,"title":"trying to work with signature offset","user":{"login":"gburanov","id":2969603,"avatar_url":"https://avatars.githubusercontent.com/u/2969603?v=3","gravatar_id":"","url":"https://api.github.com/users/gburanov","html_url":"https://github.com/gburanov","followers_url":"https://api.github.com/users/gburanov/followers","following_url":"https://api.github.com/users/gburanov/following{/other_user}","gists_url":"https://api.github.com/users/gburanov/gists{/gist_id}","starred_url":"https://api.github.com/users/gburanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gburanov/subscriptions","organizations_url":"https://api.github.com/users/gburanov/orgs","repos_url":"https://api.github.com/users/gburanov/repos","events_url":"https://api.github.com/users/gburanov/events{/privacy}","received_events_url":"https://api.github.com/users/gburanov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels/duplicate","name":"duplicate","color":"ffffff"},{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels/OS+X","name":"OS X","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-07-14T12:47:18Z","updated_at":"2015-01-14T09:53:18Z","closed_at":"2015-01-14T09:53:18Z","pull_request":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/146","html_url":"https://github.com/pyinstaller/pyinstaller/pull/146","diff_url":"https://github.com/pyinstaller/pyinstaller/pull/146.diff","patch_url":"https://github.com/pyinstaller/pyinstaller/pull/146.patch"},"body":"Hi everybody.\r\n\r\nWe decided to use python instead of C++ in some parts of our project to speed up the development (and pyinstaller to build binaries)\r\n\r\nEverything worked just great until we decided to add signature to the file.\r\n\r\nSignature is applied to the end of the file, and pyinstaller searches for the magic number only at the end of the file.\r\n\r\nFix is very simple: look for the magic number not only at the end of the file, but also at various offsets from the end of the file.\r\n\r\nI understand that this solution is not ideal for many reasons:\r\n- time consuming (if magic number is not there it will take a lot of time to run throughout file)\r\n- not error prone - this magic number can be a normal combination of bytes inside file\r\n\r\nBut still this patch is working - and as for me, it adds quite important feature to the pyinstaller.\r\n\r\nSo, if you are interested, we can ingrate this solution together"},"comment":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/comments/69892716","html_url":"https://github.com/pyinstaller/pyinstaller/pull/146#issuecomment-69892716","issue_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/146","id":69892716,"user":{"login":"matysek","id":527280,"avatar_url":"https://avatars.githubusercontent.com/u/527280?v=3","gravatar_id":"","url":"https://api.github.com/users/matysek","html_url":"https://github.com/matysek","followers_url":"https://api.github.com/users/matysek/followers","following_url":"https://api.github.com/users/matysek/following{/other_user}","gists_url":"https://api.github.com/users/matysek/gists{/gist_id}","starred_url":"https://api.github.com/users/matysek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matysek/subscriptions","organizations_url":"https://api.github.com/users/matysek/orgs","repos_url":"https://api.github.com/users/matysek/repos","events_url":"https://api.github.com/users/matysek/events{/privacy}","received_events_url":"https://api.github.com/users/matysek/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T09:53:18Z","updated_at":"2015-01-14T09:53:18Z","body":"Code signing on OSX is already implemented. Closing. See #812 for details."}}