{"comment":{"url":"https://api.github.com/repos/bogdanteleaga/juju/comments/13362520","html_url":"https://github.com/bogdanteleaga/juju/commit/33668c25a5c4328af2ececa6739dc33d1aadc496#commitcomment-13362520","id":13362520,"user":{"login":"bogdanteleaga","id":6207800,"avatar_url":"https://avatars.githubusercontent.com/u/6207800?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanteleaga","html_url":"https://github.com/bogdanteleaga","followers_url":"https://api.github.com/users/bogdanteleaga/followers","following_url":"https://api.github.com/users/bogdanteleaga/following{/other_user}","gists_url":"https://api.github.com/users/bogdanteleaga/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanteleaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanteleaga/subscriptions","organizations_url":"https://api.github.com/users/bogdanteleaga/orgs","repos_url":"https://api.github.com/users/bogdanteleaga/repos","events_url":"https://api.github.com/users/bogdanteleaga/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanteleaga/received_events","type":"User","site_admin":false},"position":4,"line":857,"path":"state/unit.go","commit_id":"33668c25a5c4328af2ececa6739dc33d1aadc496","created_at":"2015-09-22T09:34:08Z","updated_at":"2015-09-22T09:34:08Z","body":"> The race is still there, but you have reduced the window of opportunity. To remove the race altogether, it needs to be part of the same transaction.\r\n\r\nI thought this will work, but that does make sense. It still reduces the window considerably.\r\nIt makes sense to me if we can only set resolved in case the unit is in error, to clear resolved when it comes out of error.\r\n\r\n> Do we need ClearResolved at all then?\r\n\r\nFirst thought would be that no, not really, but I'd have to go through the usecases"}}