{"action":"opened","number":30,"pull_request":{"url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30","id":50616455,"html_url":"https://github.com/sbt/incrementalcompiler/pull/30","diff_url":"https://github.com/sbt/incrementalcompiler/pull/30.diff","patch_url":"https://github.com/sbt/incrementalcompiler/pull/30.patch","issue_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/30","number":30,"state":"open","locked":false,"title":"Refactor incrementalcompiler API","user":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars.githubusercontent.com/u/184683?v=3","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"sbt always had incrementalcompiler API in xsbti (Java interface) called\r\n[`IncrementalCompiler<Analysis,\r\nScalaCompiler>`](https://github.com/sbt/incrementalcompiler/blob/c99b2e0\r\na395ad6be551704e6ff2f9c22c4a2278f/internal/compiler-interface/src/main/j\r\nava/xsbti/compile/IncrementalCompiler.java) used together with [`\r\nInputs<Analysis,ScalaCompiler>`](https://github.com/sbt/incrementalcompi\r\nler/blob/c99b2e0a395ad6be551704e6ff2f9c22c4a2278f/internal/compiler-inte\r\nrface/src/main/java/xsbti/compile/Inputs.java), etc.\r\nOver the course of time, the Java API became out of sync with the\r\nincremental compiler implementation in `IC` object as features were\r\nadded such as:\r\n\r\n- name hashing\r\n- new Java compiler (sbt/sbt#1702)\r\n- bytecode enhancement support (sbt/sbt#1714)\r\n\r\nThis change is intended to fold these changes back into natural places,\r\nlike making `previousResult` part of the `Inputs`.\r\nsbt-datatype is used to generate Java datatypes, which should help us\r\nmaintain bincompat going forward.\r\nThe centerpiece of this API is:\r\n\r\n    def compile(in: Inputs, log: Logger): CompileResult\r\n\r\nThe intent is to set up incremental compilation using only the publicly\r\nexposed datatypes.\r\nOne of the glaring exception is the setup of `AnalyzingCompiler`, which\r\ntakes 50+ lines of acrobatics to create.\r\nThis is demonstrated in the newly added\r\nincrementalcompiler/src/test/scala/sbt/inc/IncrementalCompilerSpec.scala.\r\n\r\n/review @Duhemm, @dwijnand, @jsuereth \r\n","created_at":"2015-11-13T08:43:53Z","updated_at":"2015-11-13T08:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30/commits","review_comments_url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30/comments","review_comment_url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/30/comments","statuses_url":"https://api.github.com/repos/sbt/incrementalcompiler/statuses/9c75003b3129400b1ee3b8a16d1792132f776594","head":{"label":"sbt:topic/api_point","ref":"topic/api_point","sha":"9c75003b3129400b1ee3b8a16d1792132f776594","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"incrementalcompiler","full_name":"sbt/incrementalcompiler","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/incrementalcompiler","description":"incrementalcompiler module for sbt","fork":false,"url":"https://api.github.com/repos/sbt/incrementalcompiler","forks_url":"https://api.github.com/repos/sbt/incrementalcompiler/forks","keys_url":"https://api.github.com/repos/sbt/incrementalcompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/incrementalcompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/incrementalcompiler/teams","hooks_url":"https://api.github.com/repos/sbt/incrementalcompiler/hooks","issue_events_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/incrementalcompiler/events","assignees_url":"https://api.github.com/repos/sbt/incrementalcompiler/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/incrementalcompiler/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/incrementalcompiler/tags","blobs_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/incrementalcompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/incrementalcompiler/languages","stargazers_url":"https://api.github.com/repos/sbt/incrementalcompiler/stargazers","contributors_url":"https://api.github.com/repos/sbt/incrementalcompiler/contributors","subscribers_url":"https://api.github.com/repos/sbt/incrementalcompiler/subscribers","subscription_url":"https://api.github.com/repos/sbt/incrementalcompiler/subscription","commits_url":"https://api.github.com/repos/sbt/incrementalcompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/incrementalcompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/incrementalcompiler/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/incrementalcompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/incrementalcompiler/merges","archive_url":"https://api.github.com/repos/sbt/incrementalcompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/incrementalcompiler/downloads","issues_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/incrementalcompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/incrementalcompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/incrementalcompiler/labels{/name}","releases_url":"https://api.github.com/repos/sbt/incrementalcompiler/releases{/id}","created_at":"2015-08-04T21:32:58Z","updated_at":"2015-08-11T22:28:32Z","pushed_at":"2015-11-13T08:41:43Z","git_url":"git://github.com/sbt/incrementalcompiler.git","ssh_url":"git@github.com:sbt/incrementalcompiler.git","clone_url":"https://github.com/sbt/incrementalcompiler.git","svn_url":"https://github.com/sbt/incrementalcompiler","homepage":"","size":1695,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":2,"default_branch":"1.0"}},"base":{"label":"sbt:1.0","ref":"1.0","sha":"c99b2e0a395ad6be551704e6ff2f9c22c4a2278f","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"incrementalcompiler","full_name":"sbt/incrementalcompiler","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/incrementalcompiler","description":"incrementalcompiler module for sbt","fork":false,"url":"https://api.github.com/repos/sbt/incrementalcompiler","forks_url":"https://api.github.com/repos/sbt/incrementalcompiler/forks","keys_url":"https://api.github.com/repos/sbt/incrementalcompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/incrementalcompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/incrementalcompiler/teams","hooks_url":"https://api.github.com/repos/sbt/incrementalcompiler/hooks","issue_events_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/incrementalcompiler/events","assignees_url":"https://api.github.com/repos/sbt/incrementalcompiler/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/incrementalcompiler/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/incrementalcompiler/tags","blobs_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/incrementalcompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/incrementalcompiler/languages","stargazers_url":"https://api.github.com/repos/sbt/incrementalcompiler/stargazers","contributors_url":"https://api.github.com/repos/sbt/incrementalcompiler/contributors","subscribers_url":"https://api.github.com/repos/sbt/incrementalcompiler/subscribers","subscription_url":"https://api.github.com/repos/sbt/incrementalcompiler/subscription","commits_url":"https://api.github.com/repos/sbt/incrementalcompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/incrementalcompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/incrementalcompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/incrementalcompiler/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/incrementalcompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/incrementalcompiler/merges","archive_url":"https://api.github.com/repos/sbt/incrementalcompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/incrementalcompiler/downloads","issues_url":"https://api.github.com/repos/sbt/incrementalcompiler/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/incrementalcompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/incrementalcompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/incrementalcompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/incrementalcompiler/labels{/name}","releases_url":"https://api.github.com/repos/sbt/incrementalcompiler/releases{/id}","created_at":"2015-08-04T21:32:58Z","updated_at":"2015-08-11T22:28:32Z","pushed_at":"2015-11-13T08:41:43Z","git_url":"git://github.com/sbt/incrementalcompiler.git","ssh_url":"git@github.com:sbt/incrementalcompiler.git","clone_url":"https://github.com/sbt/incrementalcompiler.git","svn_url":"https://github.com/sbt/incrementalcompiler","homepage":"","size":1695,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":2,"default_branch":"1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30"},"html":{"href":"https://github.com/sbt/incrementalcompiler/pull/30"},"issue":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/issues/30"},"comments":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/incrementalcompiler/statuses/9c75003b3129400b1ee3b8a16d1792132f776594"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":626,"deletions":389,"changed_files":33}}