{"action":"created","issue":{"url":"https://api.github.com/repos/paf31/psc-pages/issues/18","labels_url":"https://api.github.com/repos/paf31/psc-pages/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/paf31/psc-pages/issues/18/comments","events_url":"https://api.github.com/repos/paf31/psc-pages/issues/18/events","html_url":"https://github.com/paf31/psc-pages/pull/18","id":66986158,"number":18,"title":"Source links / per-package mode","user":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-04-07T20:44:34Z","updated_at":"2015-04-10T20:33:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paf31/psc-pages/pulls/18","html_url":"https://github.com/paf31/psc-pages/pull/18","diff_url":"https://github.com/paf31/psc-pages/pull/18.diff","patch_url":"https://github.com/paf31/psc-pages/pull/18.patch"},"body":"Fixes #2 \r\n\r\nThis seems to work, but some of the source spans seem a bit off. For example, I got this one for `Data.Maybe.functorMaybe`: https://github.com/purescript/purescript-maybe/blob/master/src/Data/Maybe.purs#L57-L92\r\n\r\nAt the moment I'm not quite sure whether this is something that should be addressed in the compiler or just that I'm using it incorrectly. Investigating...\r\n\r\nStill to do:\r\n\r\n* [x] Fix docs links\r\n* ~~Fix docs links for Prelude types~~ Can we just wait until the prelude is separated?\r\n* [x] Fix source links\r\n* [x] Change \"Core Libraries\"\r\n* [x] Index should only contain things from the current package\r\n* [ ] Some of this code is becoming a bit horrible. Try to refactor?\r\n\r\nPotential future improvements:\r\n\r\n* Better errors if you forget to `bower install` first\r\n* Create a module overview page, with rendered readme, every version of a package, and dependencies\r\n* Ensure only exported values appear on index pages"},"comment":{"url":"https://api.github.com/repos/paf31/psc-pages/issues/comments/91678852","html_url":"https://github.com/paf31/psc-pages/pull/18#issuecomment-91678852","issue_url":"https://api.github.com/repos/paf31/psc-pages/issues/18","id":91678852,"user":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T20:33:34Z","updated_at":"2015-04-10T20:33:34Z","body":"Yes, I'd like to do that soon. But, I'm more worried about situations like:\r\n\r\n* Package A links to the docs of package B, but B either has no docs at all uploaded, or none uploaded for the particular version that A is using.\r\n* someone wants to look at the docs for the latest available version of a package\r\n\r\nWe don't currently have any way of handling these; just ugly 404s."}}