{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/48325577","id":48325577,"diff_hunk":"@@ -103,12 +130,18 @@ def do_migration(delay, vm, dest_uri, options, extra):\n     options = params.get(\"virsh_migrate_options\")\n     extra = params.get(\"virsh_migrate_extra\")\n     delay = int(params.get(\"virsh_migrate_delay\", 10))\n+    ping_count = int(params.get(\"ping_count\", 5))\n+    ping_timeout = int(params.get(\"ping_timeout\", 10))\n     status_error = params.get(\"status_error\", 'no')\n     libvirtd_state = params.get(\"virsh_migrate_libvirtd_state\", 'on')\n     src_state = params.get(\"virsh_migrate_src_state\", \"running\")\n     migrate_uri = params.get(\"virsh_migrate_migrateuri\", None)\n     shared_storage = params.get(\"virsh_migrate_shared_storage\", None)\n     dest_xmlfile = \"\"\n+    src_xmlfile = \"\"\n+    REMOTE_VIEWER = \"\"\n+    REMOTE_VIEWER_PID = \"\"","path":"libvirt/tests/src/virsh_cmd/domain/virsh_migrate.py","position":81,"original_position":81,"commit_id":"c31c4dc28d86b7621b1d07afc443d76dcd26f91f","original_commit_id":"c31c4dc28d86b7621b1d07afc443d76dcd26f91f","user":{"login":"will-Do","id":1916899,"avatar_url":"https://avatars.githubusercontent.com/u/1916899?v=3","gravatar_id":"","url":"https://api.github.com/users/will-Do","html_url":"https://github.com/will-Do","followers_url":"https://api.github.com/users/will-Do/followers","following_url":"https://api.github.com/users/will-Do/following{/other_user}","gists_url":"https://api.github.com/users/will-Do/gists{/gist_id}","starred_url":"https://api.github.com/users/will-Do/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-Do/subscriptions","organizations_url":"https://api.github.com/users/will-Do/orgs","repos_url":"https://api.github.com/users/will-Do/repos","events_url":"https://api.github.com/users/will-Do/events{/privacy}","received_events_url":"https://api.github.com/users/will-Do/received_events","type":"User","site_admin":false},"body":"Well, I can understand you  use capital for a exec command, but for REMOTE_VIEWER_PID, it not make sense.\r\nAnd it's better to declare and set REMOTE_VIEWER at the beginning of the test, then decide if we should skip this case.","created_at":"2015-12-23T07:14:28Z","updated_at":"2015-12-23T07:14:28Z","html_url":"https://github.com/autotest/tp-libvirt/pull/681#discussion_r48325577","pull_request_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/48325577"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/681#discussion_r48325577"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681","id":54235271,"html_url":"https://github.com/autotest/tp-libvirt/pull/681","diff_url":"https://github.com/autotest/tp-libvirt/pull/681.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/681.patch","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/681","number":681,"state":"open","locked":false,"title":"Update basic migration test","user":{"login":"dzhengfy","id":16040311,"avatar_url":"https://avatars.githubusercontent.com/u/16040311?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhengfy","html_url":"https://github.com/dzhengfy","followers_url":"https://api.github.com/users/dzhengfy/followers","following_url":"https://api.github.com/users/dzhengfy/following{/other_user}","gists_url":"https://api.github.com/users/dzhengfy/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhengfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhengfy/subscriptions","organizations_url":"https://api.github.com/users/dzhengfy/orgs","repos_url":"https://api.github.com/users/dzhengfy/repos","events_url":"https://api.github.com/users/dzhengfy/events{/privacy}","received_events_url":"https://api.github.com/users/dzhengfy/received_events","type":"User","site_admin":false},"body":"The current existing migration cases can't be ran automitically, you need manually setup sharing storage and enable virt_use_nfs seboolean if you're using a NFS storage to share VM image, in addition, if the migration URI transport is SSH, you also need to configure SSH passwordless manually, this patch is used for solving these question and let tester run migartion testing automitically with simple test configuration. Meanwhile, to add new test scenarios for migration testing.\r\n\r\n  1. Automitically setup NFS sharing ENV and enable virt_use_nfs seboolean\r\n\r\n  2. Delete complex testing scenarios, such as ping-pong migration, it needs we setup passwordless access\r\n    from local/remote to remote/local firstly, we may put these scenarios into ping-pong migration testing.\r\n\r\n  3. Add some new testing scenarios to cover migration options or options combination, such as \"--graphicsuri\", \"--live --suspend --undefinesource\",.\r\n\r\n  4. Enhance VM network connectivity check after migariton\r\n\r\n    use local URI qemu:///system to instead of qemu+ssh://${migrate_source_host}/system, it's not necessary to use qemu+ssh://${migrate_source_host}/system URI for the local connecting, if you do this, you also need to setup passwordless access local URI firstly.\r\n\r\n  5. Add parameters setting for migration test\r\n  6. Change the nfs env setting order","created_at":"2015-12-21T09:24:12Z","updated_at":"2015-12-23T07:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ea8987cd80ff6197ffc5c2e8860077c655719f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/681/comments","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/c31c4dc28d86b7621b1d07afc443d76dcd26f91f","head":{"label":"dzhengfy:chuanchang-update_basic_migration_test","ref":"chuanchang-update_basic_migration_test","sha":"c31c4dc28d86b7621b1d07afc443d76dcd26f91f","user":{"login":"dzhengfy","id":16040311,"avatar_url":"https://avatars.githubusercontent.com/u/16040311?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhengfy","html_url":"https://github.com/dzhengfy","followers_url":"https://api.github.com/users/dzhengfy/followers","following_url":"https://api.github.com/users/dzhengfy/following{/other_user}","gists_url":"https://api.github.com/users/dzhengfy/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhengfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhengfy/subscriptions","organizations_url":"https://api.github.com/users/dzhengfy/orgs","repos_url":"https://api.github.com/users/dzhengfy/repos","events_url":"https://api.github.com/users/dzhengfy/events{/privacy}","received_events_url":"https://api.github.com/users/dzhengfy/received_events","type":"User","site_admin":false},"repo":{"id":48014313,"name":"tp-libvirt","full_name":"dzhengfy/tp-libvirt","owner":{"login":"dzhengfy","id":16040311,"avatar_url":"https://avatars.githubusercontent.com/u/16040311?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhengfy","html_url":"https://github.com/dzhengfy","followers_url":"https://api.github.com/users/dzhengfy/followers","following_url":"https://api.github.com/users/dzhengfy/following{/other_user}","gists_url":"https://api.github.com/users/dzhengfy/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhengfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhengfy/subscriptions","organizations_url":"https://api.github.com/users/dzhengfy/orgs","repos_url":"https://api.github.com/users/dzhengfy/repos","events_url":"https://api.github.com/users/dzhengfy/events{/privacy}","received_events_url":"https://api.github.com/users/dzhengfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzhengfy/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":true,"url":"https://api.github.com/repos/dzhengfy/tp-libvirt","forks_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/forks","keys_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/events","assignees_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/merges","archive_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/dzhengfy/tp-libvirt/releases{/id}","created_at":"2015-12-15T02:23:20Z","updated_at":"2015-12-15T02:23:22Z","pushed_at":"2015-12-22T09:10:27Z","git_url":"git://github.com/dzhengfy/tp-libvirt.git","ssh_url":"git@github.com:dzhengfy/tp-libvirt.git","clone_url":"https://github.com/dzhengfy/tp-libvirt.git","svn_url":"https://github.com/dzhengfy/tp-libvirt","homepage":null,"size":10167,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"1cc80fbdc7571acbc705cfa6141b001914e94b30","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180517,"name":"tp-libvirt","full_name":"autotest/tp-libvirt","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-libvirt","forks_url":"https://api.github.com/repos/autotest/tp-libvirt/forks","keys_url":"https://api.github.com/repos/autotest/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/autotest/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-libvirt/events","assignees_url":"https://api.github.com/repos/autotest/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/autotest/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-libvirt/merges","archive_url":"https://api.github.com/repos/autotest/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/autotest/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-libvirt/releases{/id}","created_at":"2014-01-23T17:58:18Z","updated_at":"2015-07-30T04:48:35Z","pushed_at":"2015-12-22T09:10:28Z","git_url":"git://github.com/autotest/tp-libvirt.git","ssh_url":"git@github.com:autotest/tp-libvirt.git","clone_url":"https://github.com/autotest/tp-libvirt.git","svn_url":"https://github.com/autotest/tp-libvirt","homepage":null,"size":10915,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":43,"forks":51,"open_issues":43,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/681"},"issue":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/681"},"comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-libvirt/statuses/c31c4dc28d86b7621b1d07afc443d76dcd26f91f"}}}}