{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/1782","labels_url":"https://api.github.com/repos/hypothesis/h/issues/1782/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/1782/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/1782/events","html_url":"https://github.com/hypothesis/h/issues/1782","id":51438212,"number":1782,"title":"Firefox Add-on fixes post 0.2.2 submission","user":{"login":"BigBlueHat","id":43209,"avatar_url":"https://avatars.githubusercontent.com/u/43209?v=3","gravatar_id":"","url":"https://api.github.com/users/BigBlueHat","html_url":"https://github.com/BigBlueHat","followers_url":"https://api.github.com/users/BigBlueHat/followers","following_url":"https://api.github.com/users/BigBlueHat/following{/other_user}","gists_url":"https://api.github.com/users/BigBlueHat/gists{/gist_id}","starred_url":"https://api.github.com/users/BigBlueHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigBlueHat/subscriptions","organizations_url":"https://api.github.com/users/BigBlueHat/orgs","repos_url":"https://api.github.com/users/BigBlueHat/repos","events_url":"https://api.github.com/users/BigBlueHat/events{/privacy}","received_events_url":"https://api.github.com/users/BigBlueHat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hypothesis/h/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/hypothesis/h/labels/Blocker","name":"Blocker","color":"e10c02"},{"url":"https://api.github.com/repos/hypothesis/h/labels/Firefox","name":"Firefox","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"aron","id":47144,"avatar_url":"https://avatars.githubusercontent.com/u/47144?v=3","gravatar_id":"","url":"https://api.github.com/users/aron","html_url":"https://github.com/aron","followers_url":"https://api.github.com/users/aron/followers","following_url":"https://api.github.com/users/aron/following{/other_user}","gists_url":"https://api.github.com/users/aron/gists{/gist_id}","starred_url":"https://api.github.com/users/aron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aron/subscriptions","organizations_url":"https://api.github.com/users/aron/orgs","repos_url":"https://api.github.com/users/aron/repos","events_url":"https://api.github.com/users/aron/events{/privacy}","received_events_url":"https://api.github.com/users/aron/received_events","type":"User","site_admin":false},"milestone":null,"comments":14,"created_at":"2014-12-09T15:10:28Z","updated_at":"2015-02-11T17:40:07Z","closed_at":null,"body":"Here's the feedback I got from the Mozilla Add-on (AMO) editors:\r\n\r\n```\r\nYour version was rejected because of the following problems:\r\n\r\nNote: Addon contain 87 JS/JSM files.\r\n\r\n1) Add-on contains duplicate/hidden/unused/unnecessary files or folders. These\r\ncomplicate the review process and may contain sensitive information about the\r\nsystem you created the XPI on. Please correct your packaging process so that\r\nthese files aren't included.\r\n\r\n2) Please do not include both minified and non-minified versions of the same\r\nlibraries.\r\n\r\n3) When including libraries, please only include the files that are needed and\r\nused by the addon, instead of including the entire library package.\r\n\r\nExamples:\r\n\r\nresources/hypothesis/data/.sass-cache/ ... and its content\r\n\r\nresources/hypothesis/data/scripts/vendor/Markdown.Converter.js\r\nresources/hypothesis/data/scripts/vendor/Markdown.Converter.min.js\r\nresources/hypothesis/data/scripts/vendor/angular-animate.js\r\nresources/hypothesis/data/scripts/vendor/angular-animate.min.js\r\nresources/hypothesis/data/scripts/vendor/angular-bootstrap.js\r\nresources/hypothesis/data/scripts/vendor/angular-bootstrap.min.js\r\nresources/hypothesis/data/scripts/vendor/angular-resource.js\r\nresources/hypothesis/data/scripts/vendor/angular-resource.min.js\r\nresources/hypothesis/data/scripts/vendor/angular-route.js\r\nresources/hypothesis/data/scripts/vendor/angular-route.min.js\r\nresources/hypothesis/data/scripts/vendor/angular-sanitize.js\r\nresources/hypothesis/data/scripts/vendor/angular-sanitize.min.js\r\nresources/hypothesis/data/scripts/vendor/angular.js\r\nresources/hypothesis/data/scripts/vendor/angular.min.js\r\nresources/hypothesis/data/scripts/vendor/annotator.auth.js\r\nresources/hypothesis/data/scripts/vendor/annotator.auth.min.js\r\nresources/hypothesis/data/scripts/vendor/annotator.document.js\r\nresources/hypothesis/data/scripts/vendor/annotator.document.min.js\r\nresources/hypothesis/data/scripts/vendor/annotator.domtextmapper.js\r\nresources/hypothesis/data/scripts/vendor/annotator.fuzzytextanchors.js\r\nresources/hypothesis/data/scripts/vendor/annotator.js\r\nresources/hypothesis/data/scripts/vendor/annotator.min.js\r\nresources/hypothesis/data/scripts/vendor/annotator.permissions.js\r\nresources/hypothesis/data/scripts/vendor/annotator.permissions.min.js\r\nresources/hypothesis/data/scripts/vendor/annotator.store.js\r\nresources/hypothesis/data/scripts/vendor/annotator.store.min.js\r\nresources/hypothesis/data/scripts/vendor/gettext.js\r\nresources/hypothesis/data/scripts/vendor/gettext.min.js\r\nresources/hypothesis/data/scripts/vendor/jquery-1.10.2.js\r\nresources/hypothesis/data/scripts/vendor/jquery.min.js\r\nresources/hypothesis/data/scripts/vendor/jschannel.js\r\nresources/hypothesis/data/scripts/vendor/jschannel.min.js\r\nresources/hypothesis/data/scripts/vendor/jstz.js\r\nresources/hypothesis/data/scripts/vendor/jstz.min.js\r\nresources/hypothesis/data/scripts/vendor/jwz.js\r\nresources/hypothesis/data/scripts/vendor/jwz.min.js\r\nresources/hypothesis/data/scripts/vendor/moment-timezone-data.js\r\nresources/hypothesis/data/scripts/vendor/moment-timezone-data.min.js\r\nresources/hypothesis/data/scripts/vendor/moment-timezone.js\r\nresources/hypothesis/data/scripts/vendor/moment-timezone.min.js\r\nresources/hypothesis/data/scripts/vendor/moment-with-langs.js\r\nresources/hypothesis/data/scripts/vendor/moment.min.js\r\nresources/hypothesis/data/scripts/vendor/ng-tags-input.js\r\nresources/hypothesis/data/scripts/vendor/ng-tags-input.min.js\r\nresources/hypothesis/data/scripts/vendor/polyfills/autofill-event.js\r\nresources/hypothesis/data/scripts/vendor/polyfills/autofill-event.min.js\r\nresources/hypothesis/data/scripts/vendor/polyfills/wgxpath.install.js\r\nresources/hypothesis/data/scripts/vendor/polyfills/wgxpath.install.min.js\r\nresources/hypothesis/data/scripts/vendor/sockjs-0.3.4.js\r\nresources/hypothesis/data/scripts/vendor/sockjs.min.js\r\nresources/hypothesis/data/scripts/vendor/uuid.js\r\nresources/hypothesis/data/scripts/vendor/uuid.min.js\r\n\r\nPlease fix them and submit again. Thank you.\r\n```\r\n\r\nMostly looks like some pruning of the assets.yml for this scenario.\r\n\r\nLots of `.min.` files we can ignore and instead ship the full copy (which they require), example: `uuid.js` vs. `uuid.min.js`\r\n\r\n/cc @dwhly \r\n\r\n<!---\r\n@huboard:{\"order\":13.249461175873876,\"milestone_order\":1782}\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/73926265","html_url":"https://github.com/hypothesis/h/issues/1782#issuecomment-73926265","issue_url":"https://api.github.com/repos/hypothesis/h/issues/1782","id":73926265,"user":{"login":"pguth","id":85259,"avatar_url":"https://avatars.githubusercontent.com/u/85259?v=3","gravatar_id":"","url":"https://api.github.com/users/pguth","html_url":"https://github.com/pguth","followers_url":"https://api.github.com/users/pguth/followers","following_url":"https://api.github.com/users/pguth/following{/other_user}","gists_url":"https://api.github.com/users/pguth/gists{/gist_id}","starred_url":"https://api.github.com/users/pguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguth/subscriptions","organizations_url":"https://api.github.com/users/pguth/orgs","repos_url":"https://api.github.com/users/pguth/repos","events_url":"https://api.github.com/users/pguth/events{/privacy}","received_events_url":"https://api.github.com/users/pguth/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T17:40:06Z","updated_at":"2015-02-11T17:40:06Z","body":"@BigBlueHat Ah, it is actually not working with the latest [Firefox Developer Edition](https://www.mozilla.org/en-US/firefox/developer/) :-(\r\nButtons appear but do not work at all. After a restart of Firefox I can not login anymore ('Session is invalid. Please try again. '). I also tried deleting my hypothesis cookies."}}