{"action":"created","issue":{"url":"https://api.github.com/repos/imbo/imbo/issues/423","labels_url":"https://api.github.com/repos/imbo/imbo/issues/423/labels{/name}","comments_url":"https://api.github.com/repos/imbo/imbo/issues/423/comments","events_url":"https://api.github.com/repos/imbo/imbo/issues/423/events","html_url":"https://github.com/imbo/imbo/pull/423","id":121576201,"number":423,"title":"Make storage drivers throw exceptions as expected in StorageOperations","user":{"login":"matslindh","id":101525,"avatar_url":"https://avatars.githubusercontent.com/u/101525?v=3","gravatar_id":"","url":"https://api.github.com/users/matslindh","html_url":"https://github.com/matslindh","followers_url":"https://api.github.com/users/matslindh/followers","following_url":"https://api.github.com/users/matslindh/following{/other_user}","gists_url":"https://api.github.com/users/matslindh/gists{/gist_id}","starred_url":"https://api.github.com/users/matslindh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matslindh/subscriptions","organizations_url":"https://api.github.com/users/matslindh/orgs","repos_url":"https://api.github.com/users/matslindh/repos","events_url":"https://api.github.com/users/matslindh/events{/privacy}","received_events_url":"https://api.github.com/users/matslindh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-10T21:00:21Z","updated_at":"2015-12-10T23:04:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/imbo/imbo/pulls/423","html_url":"https://github.com/imbo/imbo/pull/423","diff_url":"https://github.com/imbo/imbo/pull/423.diff","patch_url":"https://github.com/imbo/imbo/pull/423.patch"},"body":"The StorageOperations manager expects an exception to be thrown if saving image data fails. The Doctrine and Filesystem drivers instead returned a boolean, which meant that we failed quietly on write failure. \r\n\r\nThis introduces the 507 HTTP Error Code (`507 Insufficient Storage`) for writes that fail on the filesystem storage driver, while using the regular 500 error for Doctrine fails (which can be caused by other issues than insufficient storage).\r\n\r\n9c691e0changes the StorageTest abstract class so implementing classes can retrieve the user configuration and the active driver (as a new call to `getDriver` would create a different driver object than the one being used for the running tests). This makes it easier to create local tests for each driver."},"comment":{"url":"https://api.github.com/repos/imbo/imbo/issues/comments/163781184","html_url":"https://github.com/imbo/imbo/pull/423#issuecomment-163781184","issue_url":"https://api.github.com/repos/imbo/imbo/issues/423","id":163781184,"user":{"login":"rexxars","id":48200,"avatar_url":"https://avatars.githubusercontent.com/u/48200?v=3","gravatar_id":"","url":"https://api.github.com/users/rexxars","html_url":"https://github.com/rexxars","followers_url":"https://api.github.com/users/rexxars/followers","following_url":"https://api.github.com/users/rexxars/following{/other_user}","gists_url":"https://api.github.com/users/rexxars/gists{/gist_id}","starred_url":"https://api.github.com/users/rexxars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexxars/subscriptions","organizations_url":"https://api.github.com/users/rexxars/orgs","repos_url":"https://api.github.com/users/rexxars/repos","events_url":"https://api.github.com/users/rexxars/events{/privacy}","received_events_url":"https://api.github.com/users/rexxars/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T23:04:39Z","updated_at":"2015-12-10T23:04:39Z","body":"This is great! Thanks! "}}