{"action":"closed","number":60,"pull_request":{"url":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60","id":41124344,"html_url":"https://github.com/rock-core/tools-syskit/pull/60","diff_url":"https://github.com/rock-core/tools-syskit/pull/60.diff","patch_url":"https://github.com/rock-core/tools-syskit/pull/60.patch","issue_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/60","number":60,"state":"closed","locked":false,"title":"Polish tests and dynamic service behaviour","user":{"login":"doudou","id":292,"avatar_url":"https://avatars.githubusercontent.com/u/292?v=3","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"body":"This is a collection of polishing, clean up and the occasional bugfix\r\n\r\nIt changes the test stub API to finally have something that (1) works and (2) has consistent naming. The old API was so horrible that I just got rid of it. I know it's backward incompatible, but I personally doubt that anyone is actually using this API so far.\r\n\r\nIt improves the handling of dynamic services tremendously:\r\n - properly handles the fact that dynamic ports are deleted by component cleanup\r\n - allows tasks to add new dynamic services at runtime without requiring reconfiguration. This is done by (1) specifying the dynamic: true parameter when defining the service and (2) defining an added_dynamic_service hook which will be called if the task is already configured with the new bound service.\r\n\r\nIt properly logs ActualDataFlow","created_at":"2015-07-29T13:43:37Z","updated_at":"2015-08-13T14:35:07Z","closed_at":"2015-08-13T14:35:07Z","merged_at":"2015-08-13T14:35:07Z","merge_commit_sha":"b90d89548684f2638c52f08a93ece30399041ade","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60/commits","review_comments_url":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60/comments","review_comment_url":"https://api.github.com/repos/rock-core/tools-syskit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/60/comments","statuses_url":"https://api.github.com/repos/rock-core/tools-syskit/statuses/3e4f9516b1be39c2abec899c05f21a4874847ab7","head":{"label":"rock-core:polish_tests_and_dynamic_service_behaviour","ref":"polish_tests_and_dynamic_service_behaviour","sha":"3e4f9516b1be39c2abec899c05f21a4874847ab7","user":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"repo":{"id":19861024,"name":"tools-syskit","full_name":"rock-core/tools-syskit","owner":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rock-core/tools-syskit","description":"Rock's model-based component management layer","fork":false,"url":"https://api.github.com/repos/rock-core/tools-syskit","forks_url":"https://api.github.com/repos/rock-core/tools-syskit/forks","keys_url":"https://api.github.com/repos/rock-core/tools-syskit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rock-core/tools-syskit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rock-core/tools-syskit/teams","hooks_url":"https://api.github.com/repos/rock-core/tools-syskit/hooks","issue_events_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/events{/number}","events_url":"https://api.github.com/repos/rock-core/tools-syskit/events","assignees_url":"https://api.github.com/repos/rock-core/tools-syskit/assignees{/user}","branches_url":"https://api.github.com/repos/rock-core/tools-syskit/branches{/branch}","tags_url":"https://api.github.com/repos/rock-core/tools-syskit/tags","blobs_url":"https://api.github.com/repos/rock-core/tools-syskit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rock-core/tools-syskit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rock-core/tools-syskit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rock-core/tools-syskit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rock-core/tools-syskit/statuses/{sha}","languages_url":"https://api.github.com/repos/rock-core/tools-syskit/languages","stargazers_url":"https://api.github.com/repos/rock-core/tools-syskit/stargazers","contributors_url":"https://api.github.com/repos/rock-core/tools-syskit/contributors","subscribers_url":"https://api.github.com/repos/rock-core/tools-syskit/subscribers","subscription_url":"https://api.github.com/repos/rock-core/tools-syskit/subscription","commits_url":"https://api.github.com/repos/rock-core/tools-syskit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rock-core/tools-syskit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rock-core/tools-syskit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rock-core/tools-syskit/contents/{+path}","compare_url":"https://api.github.com/repos/rock-core/tools-syskit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rock-core/tools-syskit/merges","archive_url":"https://api.github.com/repos/rock-core/tools-syskit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rock-core/tools-syskit/downloads","issues_url":"https://api.github.com/repos/rock-core/tools-syskit/issues{/number}","pulls_url":"https://api.github.com/repos/rock-core/tools-syskit/pulls{/number}","milestones_url":"https://api.github.com/repos/rock-core/tools-syskit/milestones{/number}","notifications_url":"https://api.github.com/repos/rock-core/tools-syskit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rock-core/tools-syskit/labels{/name}","releases_url":"https://api.github.com/repos/rock-core/tools-syskit/releases{/id}","created_at":"2014-05-16T15:18:30Z","updated_at":"2015-04-29T19:12:41Z","pushed_at":"2015-08-13T14:35:07Z","git_url":"git://github.com/rock-core/tools-syskit.git","ssh_url":"git@github.com:rock-core/tools-syskit.git","clone_url":"https://github.com/rock-core/tools-syskit.git","svn_url":"https://github.com/rock-core/tools-syskit","homepage":null,"size":4724,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":27,"forks":6,"open_issues":27,"watchers":0,"default_branch":"master"}},"base":{"label":"rock-core:master","ref":"master","sha":"608ddd4d3222a4947c11e330b2d6ce1d0870f5b6","user":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"repo":{"id":19861024,"name":"tools-syskit","full_name":"rock-core/tools-syskit","owner":{"login":"rock-core","id":6654878,"avatar_url":"https://avatars.githubusercontent.com/u/6654878?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-core","html_url":"https://github.com/rock-core","followers_url":"https://api.github.com/users/rock-core/followers","following_url":"https://api.github.com/users/rock-core/following{/other_user}","gists_url":"https://api.github.com/users/rock-core/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-core/subscriptions","organizations_url":"https://api.github.com/users/rock-core/orgs","repos_url":"https://api.github.com/users/rock-core/repos","events_url":"https://api.github.com/users/rock-core/events{/privacy}","received_events_url":"https://api.github.com/users/rock-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rock-core/tools-syskit","description":"Rock's model-based component management layer","fork":false,"url":"https://api.github.com/repos/rock-core/tools-syskit","forks_url":"https://api.github.com/repos/rock-core/tools-syskit/forks","keys_url":"https://api.github.com/repos/rock-core/tools-syskit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rock-core/tools-syskit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rock-core/tools-syskit/teams","hooks_url":"https://api.github.com/repos/rock-core/tools-syskit/hooks","issue_events_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/events{/number}","events_url":"https://api.github.com/repos/rock-core/tools-syskit/events","assignees_url":"https://api.github.com/repos/rock-core/tools-syskit/assignees{/user}","branches_url":"https://api.github.com/repos/rock-core/tools-syskit/branches{/branch}","tags_url":"https://api.github.com/repos/rock-core/tools-syskit/tags","blobs_url":"https://api.github.com/repos/rock-core/tools-syskit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rock-core/tools-syskit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rock-core/tools-syskit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rock-core/tools-syskit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rock-core/tools-syskit/statuses/{sha}","languages_url":"https://api.github.com/repos/rock-core/tools-syskit/languages","stargazers_url":"https://api.github.com/repos/rock-core/tools-syskit/stargazers","contributors_url":"https://api.github.com/repos/rock-core/tools-syskit/contributors","subscribers_url":"https://api.github.com/repos/rock-core/tools-syskit/subscribers","subscription_url":"https://api.github.com/repos/rock-core/tools-syskit/subscription","commits_url":"https://api.github.com/repos/rock-core/tools-syskit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rock-core/tools-syskit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rock-core/tools-syskit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rock-core/tools-syskit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rock-core/tools-syskit/contents/{+path}","compare_url":"https://api.github.com/repos/rock-core/tools-syskit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rock-core/tools-syskit/merges","archive_url":"https://api.github.com/repos/rock-core/tools-syskit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rock-core/tools-syskit/downloads","issues_url":"https://api.github.com/repos/rock-core/tools-syskit/issues{/number}","pulls_url":"https://api.github.com/repos/rock-core/tools-syskit/pulls{/number}","milestones_url":"https://api.github.com/repos/rock-core/tools-syskit/milestones{/number}","notifications_url":"https://api.github.com/repos/rock-core/tools-syskit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rock-core/tools-syskit/labels{/name}","releases_url":"https://api.github.com/repos/rock-core/tools-syskit/releases{/id}","created_at":"2014-05-16T15:18:30Z","updated_at":"2015-04-29T19:12:41Z","pushed_at":"2015-08-13T14:35:07Z","git_url":"git://github.com/rock-core/tools-syskit.git","ssh_url":"git@github.com:rock-core/tools-syskit.git","clone_url":"https://github.com/rock-core/tools-syskit.git","svn_url":"https://github.com/rock-core/tools-syskit","homepage":null,"size":4724,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":27,"forks":6,"open_issues":27,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60"},"html":{"href":"https://github.com/rock-core/tools-syskit/pull/60"},"issue":{"href":"https://api.github.com/repos/rock-core/tools-syskit/issues/60"},"comments":{"href":"https://api.github.com/repos/rock-core/tools-syskit/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/rock-core/tools-syskit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rock-core/tools-syskit/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/rock-core/tools-syskit/statuses/3e4f9516b1be39c2abec899c05f21a4874847ab7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"doudou","id":292,"avatar_url":"https://avatars.githubusercontent.com/u/292?v=3","gravatar_id":"","url":"https://api.github.com/users/doudou","html_url":"https://github.com/doudou","followers_url":"https://api.github.com/users/doudou/followers","following_url":"https://api.github.com/users/doudou/following{/other_user}","gists_url":"https://api.github.com/users/doudou/gists{/gist_id}","starred_url":"https://api.github.com/users/doudou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doudou/subscriptions","organizations_url":"https://api.github.com/users/doudou/orgs","repos_url":"https://api.github.com/users/doudou/repos","events_url":"https://api.github.com/users/doudou/events{/privacy}","received_events_url":"https://api.github.com/users/doudou/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":104,"additions":3878,"deletions":2346,"changed_files":110}}