{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/21254","labels_url":"https://api.github.com/repos/rails/rails/issues/21254/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/21254/comments","events_url":"https://api.github.com/repos/rails/rails/issues/21254/events","html_url":"https://github.com/rails/rails/pull/21254","id":101223471,"number":21254,"title":"Add Rails commands for existing rake tasks","user":{"login":"ccallebs","id":397982,"avatar_url":"https://avatars.githubusercontent.com/u/397982?v=3","gravatar_id":"","url":"https://api.github.com/users/ccallebs","html_url":"https://github.com/ccallebs","followers_url":"https://api.github.com/users/ccallebs/followers","following_url":"https://api.github.com/users/ccallebs/following{/other_user}","gists_url":"https://api.github.com/users/ccallebs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccallebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccallebs/subscriptions","organizations_url":"https://api.github.com/users/ccallebs/orgs","repos_url":"https://api.github.com/users/ccallebs/repos","events_url":"https://api.github.com/users/ccallebs/events{/privacy}","received_events_url":"https://api.github.com/users/ccallebs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-16T01:24:30Z","updated_at":"2015-08-30T12:17:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/21254","html_url":"https://github.com/rails/rails/pull/21254","diff_url":"https://github.com/rails/rails/pull/21254.diff","patch_url":"https://github.com/rails/rails/pull/21254.patch"},"body":"Aims to implement #18878.\r\n\r\nThis is a proof of concept branch. The code is a bit messy and I've left comments where I plan to clean it up. I'm also not sure what dependencies will end up being shared among tasks, so a lot of functionality is in the Base class at the moment.\r\n\r\nPlacing each set of rake tasks inside of a wrapper class allows some flexibility for the future in terms of providing contextual documentation. For example, `rails test --help` could provide a custom help message for only test commands (and encapsulate those messages inside of each class).\r\n\r\nCurrently working:\r\n- Original commands\r\n- `rails test:db`\r\n\r\nBefore I go any further moving more rake tasks to this architecture, I wanted to get feedback on the implementation. I think this approach is sensible and I can knock out the rest of them quickly."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/136131848","html_url":"https://github.com/rails/rails/pull/21254#issuecomment-136131848","issue_url":"https://api.github.com/repos/rails/rails/issues/21254","id":136131848,"user":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"created_at":"2015-08-30T12:17:11Z","updated_at":"2015-08-30T12:17:11Z","body":"@kaspth I haven't followed the entire discussion so I'm not sure, tbh."}}