{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/35491152","id":35491152,"diff_hunk":"@@ -58,4 +58,44 @@ class TestFSMRefSpec extends AkkaSpec {\n       fsm.isTimerActive(\"test\") should ===(false)\n     }\n   }\n+\n+  \"A TestFSMRef Companion Object\" must {\n+\n+    val guardian = system.asInstanceOf[ActorSystemImpl].guardian\n+\n+    val parent = system.actorOf(Props(new Actor { def receive = { case _ ⇒ } }))\n+\n+    class TestFSMActor extends Actor with FSM[Int, Null] {\n+      startWith(1, null)\n+      when(1) {\n+        case x ⇒ stay\n+      }\n+      val supervisor = context.parent\n+      val name = context.self.path.name\n+    }\n+\n+    def fsmActorFactory = new TestFSMActor\n+\n+    \"allow creation of a TestFSMRef with a default supervisor\" in {\n+      val fsm = TestFSMRef(fsmActorFactory)\n+      fsm.underlyingActor.supervisor should be(guardian)\n+    }","path":"akka-testkit/src/test/scala/akka/testkit/TestFSMRefSpec.scala","position":25,"original_position":25,"commit_id":"5cd9d483b4aebbd26eb6d0126737220c9393b5b9","original_commit_id":"5cd9d483b4aebbd26eb6d0126737220c9393b5b9","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Thanks for adding those tests, :+1: ","created_at":"2015-07-26T10:07:08Z","updated_at":"2015-07-26T10:07:08Z","html_url":"https://github.com/akka/akka/pull/18078#discussion_r35491152","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/18078","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/35491152"},"html":{"href":"https://github.com/akka/akka/pull/18078#discussion_r35491152"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/18078"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/18078","id":40850023,"html_url":"https://github.com/akka/akka/pull/18078","diff_url":"https://github.com/akka/akka/pull/18078.diff","patch_url":"https://github.com/akka/akka/pull/18078.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/18078","number":18078,"state":"open","locked":false,"title":"Additional apply() methods for TestActorRef and TestFSMRef","user":{"login":"mattinbits","id":3765307,"avatar_url":"https://avatars.githubusercontent.com/u/3765307?v=3","gravatar_id":"","url":"https://api.github.com/users/mattinbits","html_url":"https://github.com/mattinbits","followers_url":"https://api.github.com/users/mattinbits/followers","following_url":"https://api.github.com/users/mattinbits/following{/other_user}","gists_url":"https://api.github.com/users/mattinbits/gists{/gist_id}","starred_url":"https://api.github.com/users/mattinbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattinbits/subscriptions","organizations_url":"https://api.github.com/users/mattinbits/orgs","repos_url":"https://api.github.com/users/mattinbits/repos","events_url":"https://api.github.com/users/mattinbits/events{/privacy}","received_events_url":"https://api.github.com/users/mattinbits/received_events","type":"User","site_admin":false},"body":"Fixes for\r\n\r\nhttps://github.com/akka/akka/issues/13980\r\nhttps://github.com/akka/akka/issues/17276\r\nhttps://github.com/akka/akka/issues/18077\r\n\r\nThere were no existing Unit tests for the `apply()` methods in place,\r\nwasn't comfortable committing with no tests so have added simple\r\ntests for the `apply()` methods both new and existing, but if\r\nthese are overkill, happy to remove them.","created_at":"2015-07-26T08:31:47Z","updated_at":"2015-07-26T10:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6958c1815df6770683b678f9476d64adb48a4fd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/18078/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/18078/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/18078/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/5cd9d483b4aebbd26eb6d0126737220c9393b5b9","head":{"label":"mattinbits:TestActorRef-TestFSMRef-mattinbits","ref":"TestActorRef-TestFSMRef-mattinbits","sha":"5cd9d483b4aebbd26eb6d0126737220c9393b5b9","user":{"login":"mattinbits","id":3765307,"avatar_url":"https://avatars.githubusercontent.com/u/3765307?v=3","gravatar_id":"","url":"https://api.github.com/users/mattinbits","html_url":"https://github.com/mattinbits","followers_url":"https://api.github.com/users/mattinbits/followers","following_url":"https://api.github.com/users/mattinbits/following{/other_user}","gists_url":"https://api.github.com/users/mattinbits/gists{/gist_id}","starred_url":"https://api.github.com/users/mattinbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattinbits/subscriptions","organizations_url":"https://api.github.com/users/mattinbits/orgs","repos_url":"https://api.github.com/users/mattinbits/repos","events_url":"https://api.github.com/users/mattinbits/events{/privacy}","received_events_url":"https://api.github.com/users/mattinbits/received_events","type":"User","site_admin":false},"repo":{"id":39654116,"name":"akka","full_name":"mattinbits/akka","owner":{"login":"mattinbits","id":3765307,"avatar_url":"https://avatars.githubusercontent.com/u/3765307?v=3","gravatar_id":"","url":"https://api.github.com/users/mattinbits","html_url":"https://github.com/mattinbits","followers_url":"https://api.github.com/users/mattinbits/followers","following_url":"https://api.github.com/users/mattinbits/following{/other_user}","gists_url":"https://api.github.com/users/mattinbits/gists{/gist_id}","starred_url":"https://api.github.com/users/mattinbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattinbits/subscriptions","organizations_url":"https://api.github.com/users/mattinbits/orgs","repos_url":"https://api.github.com/users/mattinbits/repos","events_url":"https://api.github.com/users/mattinbits/events{/privacy}","received_events_url":"https://api.github.com/users/mattinbits/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattinbits/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/mattinbits/akka","forks_url":"https://api.github.com/repos/mattinbits/akka/forks","keys_url":"https://api.github.com/repos/mattinbits/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattinbits/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattinbits/akka/teams","hooks_url":"https://api.github.com/repos/mattinbits/akka/hooks","issue_events_url":"https://api.github.com/repos/mattinbits/akka/issues/events{/number}","events_url":"https://api.github.com/repos/mattinbits/akka/events","assignees_url":"https://api.github.com/repos/mattinbits/akka/assignees{/user}","branches_url":"https://api.github.com/repos/mattinbits/akka/branches{/branch}","tags_url":"https://api.github.com/repos/mattinbits/akka/tags","blobs_url":"https://api.github.com/repos/mattinbits/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattinbits/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattinbits/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattinbits/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattinbits/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/mattinbits/akka/languages","stargazers_url":"https://api.github.com/repos/mattinbits/akka/stargazers","contributors_url":"https://api.github.com/repos/mattinbits/akka/contributors","subscribers_url":"https://api.github.com/repos/mattinbits/akka/subscribers","subscription_url":"https://api.github.com/repos/mattinbits/akka/subscription","commits_url":"https://api.github.com/repos/mattinbits/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattinbits/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattinbits/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattinbits/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattinbits/akka/contents/{+path}","compare_url":"https://api.github.com/repos/mattinbits/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattinbits/akka/merges","archive_url":"https://api.github.com/repos/mattinbits/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattinbits/akka/downloads","issues_url":"https://api.github.com/repos/mattinbits/akka/issues{/number}","pulls_url":"https://api.github.com/repos/mattinbits/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/mattinbits/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/mattinbits/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattinbits/akka/labels{/name}","releases_url":"https://api.github.com/repos/mattinbits/akka/releases{/id}","created_at":"2015-07-24T19:53:11Z","updated_at":"2015-07-24T19:53:18Z","pushed_at":"2015-07-26T08:29:17Z","git_url":"git://github.com/mattinbits/akka.git","ssh_url":"git@github.com:mattinbits/akka.git","clone_url":"https://github.com/mattinbits/akka.git","svn_url":"https://github.com/mattinbits/akka","homepage":"http://akka.io","size":264028,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"8648b88be4d0e17bbb279c322b6bf616a2c80e0a","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-07-26T07:47:24Z","pushed_at":"2015-07-26T08:31:47Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":264028,"stargazers_count":4243,"watchers_count":4243,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1243,"mirror_url":null,"open_issues_count":696,"forks":1243,"open_issues":696,"watchers":4243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/18078"},"html":{"href":"https://github.com/akka/akka/pull/18078"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/18078"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/18078/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/18078/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/18078/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/5cd9d483b4aebbd26eb6d0126737220c9393b5b9"}}}}