{"action":"created","issue":{"url":"https://api.github.com/repos/spree/spree/issues/5904","labels_url":"https://api.github.com/repos/spree/spree/issues/5904/labels{/name}","comments_url":"https://api.github.com/repos/spree/spree/issues/5904/comments","events_url":"https://api.github.com/repos/spree/spree/issues/5904/events","html_url":"https://github.com/spree/spree/pull/5904","id":54802507,"number":5904,"title":"Remove credit card expiry validation.","user":{"login":"gmacdougall","id":764390,"avatar_url":"https://avatars.githubusercontent.com/u/764390?v=3","gravatar_id":"","url":"https://api.github.com/users/gmacdougall","html_url":"https://github.com/gmacdougall","followers_url":"https://api.github.com/users/gmacdougall/followers","following_url":"https://api.github.com/users/gmacdougall/following{/other_user}","gists_url":"https://api.github.com/users/gmacdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/gmacdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmacdougall/subscriptions","organizations_url":"https://api.github.com/users/gmacdougall/orgs","repos_url":"https://api.github.com/users/gmacdougall/repos","events_url":"https://api.github.com/users/gmacdougall/events{/privacy}","received_events_url":"https://api.github.com/users/gmacdougall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-19T19:24:49Z","updated_at":"2015-01-19T19:28:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/5904","html_url":"https://github.com/spree/spree/pull/5904","diff_url":"https://github.com/spree/spree/pull/5904.diff","patch_url":"https://github.com/spree/spree/pull/5904.patch"},"body":"This validation causes issues when attempting to create refunds for a\r\npayment where the credit card has expired.\r\n\r\nAn example that I experienced was someone who had a credit card that expired on 12 / 2014, who made a purchase late in the month. We attempted to credit the user with a partial refund due to a return in January, 2015. Our payment gateway allowed us to refund the credit card, however, the refund payment was not created in Spree as it was associated with a credit card that had expired.\r\n\r\nI feel this logic is best left up to the payment gateway. They decide\r\nwhether a credit card is expired or not."},"comment":{"url":"https://api.github.com/repos/spree/spree/issues/comments/70547142","html_url":"https://github.com/spree/spree/pull/5904#issuecomment-70547142","issue_url":"https://api.github.com/repos/spree/spree/issues/5904","id":70547142,"user":{"login":"Senjai","id":1831235,"avatar_url":"https://avatars.githubusercontent.com/u/1831235?v=3","gravatar_id":"","url":"https://api.github.com/users/Senjai","html_url":"https://github.com/Senjai","followers_url":"https://api.github.com/users/Senjai/followers","following_url":"https://api.github.com/users/Senjai/following{/other_user}","gists_url":"https://api.github.com/users/Senjai/gists{/gist_id}","starred_url":"https://api.github.com/users/Senjai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Senjai/subscriptions","organizations_url":"https://api.github.com/users/Senjai/orgs","repos_url":"https://api.github.com/users/Senjai/repos","events_url":"https://api.github.com/users/Senjai/events{/privacy}","received_events_url":"https://api.github.com/users/Senjai/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T19:28:26Z","updated_at":"2015-01-19T19:28:26Z","body":":+1: No need to validate credit cards in the application when we can make decisions based on the payment methods response."}}