{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/43547168","id":43547168,"diff_hunk":"@@ -88,7 +134,26 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker {\n     }\n \n     public visitNamespaceImport(node: ts.NamespaceImport) {\n-        this.validateReferencesForVariable(node.name.text, node.name.getStart());\n+        let importDecl = <ts.ImportDeclaration>node.parent.parent;","path":"src/rules/noUnusedVariableRule.ts","position":80,"original_position":80,"commit_id":"9ca3eaade66c1592a6ba0747aa9a8f8180a7c015","original_commit_id":"9ca3eaade66c1592a6ba0747aa9a8f8180a7c015","user":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars.githubusercontent.com/u/723999?v=3","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"body":"avoid abbreviation, call this `importDeclaration`","created_at":"2015-10-30T20:13:32Z","updated_at":"2015-10-30T20:13:32Z","html_url":"https://github.com/palantir/tslint/pull/725#discussion_r43547168","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/725","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/43547168"},"html":{"href":"https://github.com/palantir/tslint/pull/725#discussion_r43547168"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/725","id":47344458,"html_url":"https://github.com/palantir/tslint/pull/725","diff_url":"https://github.com/palantir/tslint/pull/725.diff","patch_url":"https://github.com/palantir/tslint/pull/725.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/725","number":725,"state":"open","locked":false,"title":"Implement a \"react\" option for the no-unused-variable rule","user":{"login":"myitcv","id":3374574,"avatar_url":"https://avatars.githubusercontent.com/u/3374574?v=3","gravatar_id":"","url":"https://api.github.com/users/myitcv","html_url":"https://github.com/myitcv","followers_url":"https://api.github.com/users/myitcv/followers","following_url":"https://api.github.com/users/myitcv/following{/other_user}","gists_url":"https://api.github.com/users/myitcv/gists{/gist_id}","starred_url":"https://api.github.com/users/myitcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myitcv/subscriptions","organizations_url":"https://api.github.com/users/myitcv/orgs","repos_url":"https://api.github.com/users/myitcv/repos","events_url":"https://api.github.com/users/myitcv/events{/privacy}","received_events_url":"https://api.github.com/users/myitcv/received_events","type":"User","site_admin":false},"body":"Addresses #698 \r\n\r\n```\r\n\"no-unused-variable\", [true, \"react\"],\r\n```\r\n\r\nWith such a valid option, the following is __not__ an error:\r\n\r\n```typescript\r\nimport * as React from \"react\";\r\n\r\nlet x = <span></span>;\r\nconsole.log(x);\r\n```\r\n\r\nThoughts/comments?","created_at":"2015-10-10T12:11:22Z","updated_at":"2015-10-30T20:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef727220be23a7da6672c7636456a76416289d7","assignee":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars.githubusercontent.com/u/723999?v=3","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/palantir/tslint/milestones/9","html_url":"https://github.com/palantir/tslint/milestones/ASAP","labels_url":"https://api.github.com/repos/palantir/tslint/milestones/9/labels","id":1366477,"number":9,"title":"ASAP","description":null,"creator":{"login":"JKillian","id":1400151,"avatar_url":"https://avatars.githubusercontent.com/u/1400151?v=3","gravatar_id":"","url":"https://api.github.com/users/JKillian","html_url":"https://github.com/JKillian","followers_url":"https://api.github.com/users/JKillian/followers","following_url":"https://api.github.com/users/JKillian/following{/other_user}","gists_url":"https://api.github.com/users/JKillian/gists{/gist_id}","starred_url":"https://api.github.com/users/JKillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKillian/subscriptions","organizations_url":"https://api.github.com/users/JKillian/orgs","repos_url":"https://api.github.com/users/JKillian/repos","events_url":"https://api.github.com/users/JKillian/events{/privacy}","received_events_url":"https://api.github.com/users/JKillian/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2015-10-20T15:23:40Z","updated_at":"2015-10-30T19:18:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/725/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/725/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/725/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/9ca3eaade66c1592a6ba0747aa9a8f8180a7c015","head":{"label":"myitcv:react_unused_option","ref":"react_unused_option","sha":"9ca3eaade66c1592a6ba0747aa9a8f8180a7c015","user":{"login":"myitcv","id":3374574,"avatar_url":"https://avatars.githubusercontent.com/u/3374574?v=3","gravatar_id":"","url":"https://api.github.com/users/myitcv","html_url":"https://github.com/myitcv","followers_url":"https://api.github.com/users/myitcv/followers","following_url":"https://api.github.com/users/myitcv/following{/other_user}","gists_url":"https://api.github.com/users/myitcv/gists{/gist_id}","starred_url":"https://api.github.com/users/myitcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myitcv/subscriptions","organizations_url":"https://api.github.com/users/myitcv/orgs","repos_url":"https://api.github.com/users/myitcv/repos","events_url":"https://api.github.com/users/myitcv/events{/privacy}","received_events_url":"https://api.github.com/users/myitcv/received_events","type":"User","site_admin":false},"repo":{"id":40204638,"name":"tslint","full_name":"myitcv/tslint","owner":{"login":"myitcv","id":3374574,"avatar_url":"https://avatars.githubusercontent.com/u/3374574?v=3","gravatar_id":"","url":"https://api.github.com/users/myitcv","html_url":"https://github.com/myitcv","followers_url":"https://api.github.com/users/myitcv/followers","following_url":"https://api.github.com/users/myitcv/following{/other_user}","gists_url":"https://api.github.com/users/myitcv/gists{/gist_id}","starred_url":"https://api.github.com/users/myitcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myitcv/subscriptions","organizations_url":"https://api.github.com/users/myitcv/orgs","repos_url":"https://api.github.com/users/myitcv/repos","events_url":"https://api.github.com/users/myitcv/events{/privacy}","received_events_url":"https://api.github.com/users/myitcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myitcv/tslint","description":"A linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/myitcv/tslint","forks_url":"https://api.github.com/repos/myitcv/tslint/forks","keys_url":"https://api.github.com/repos/myitcv/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myitcv/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myitcv/tslint/teams","hooks_url":"https://api.github.com/repos/myitcv/tslint/hooks","issue_events_url":"https://api.github.com/repos/myitcv/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/myitcv/tslint/events","assignees_url":"https://api.github.com/repos/myitcv/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/myitcv/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/myitcv/tslint/tags","blobs_url":"https://api.github.com/repos/myitcv/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myitcv/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myitcv/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/myitcv/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myitcv/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/myitcv/tslint/languages","stargazers_url":"https://api.github.com/repos/myitcv/tslint/stargazers","contributors_url":"https://api.github.com/repos/myitcv/tslint/contributors","subscribers_url":"https://api.github.com/repos/myitcv/tslint/subscribers","subscription_url":"https://api.github.com/repos/myitcv/tslint/subscription","commits_url":"https://api.github.com/repos/myitcv/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/myitcv/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/myitcv/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/myitcv/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/myitcv/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/myitcv/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myitcv/tslint/merges","archive_url":"https://api.github.com/repos/myitcv/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myitcv/tslint/downloads","issues_url":"https://api.github.com/repos/myitcv/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/myitcv/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/myitcv/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/myitcv/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myitcv/tslint/labels{/name}","releases_url":"https://api.github.com/repos/myitcv/tslint/releases{/id}","created_at":"2015-08-04T19:22:30Z","updated_at":"2015-08-04T19:22:31Z","pushed_at":"2015-10-30T09:01:53Z","git_url":"git://github.com/myitcv/tslint.git","ssh_url":"git@github.com:myitcv/tslint.git","clone_url":"https://github.com/myitcv/tslint.git","svn_url":"https://github.com/myitcv/tslint","homepage":null,"size":8909,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"ec62e8c41931173560b399afa7bf94cc5061779c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":"A linter for the TypeScript language.","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","created_at":"2013-07-25T22:19:18Z","updated_at":"2015-10-30T16:18:08Z","pushed_at":"2015-10-30T19:18:30Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":null,"size":13337,"stargazers_count":413,"watchers_count":413,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":104,"mirror_url":null,"open_issues_count":146,"forks":104,"open_issues":146,"watchers":413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/725"},"html":{"href":"https://github.com/palantir/tslint/pull/725"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/725"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/9ca3eaade66c1592a6ba0747aa9a8f8180a7c015"}}}}