{"action":"created","comment":{"url":"https://api.github.com/repos/freenet/java_installer/pulls/comments/28297315","id":28297315,"diff_hunk":"@@ -0,0 +1,59 @@\n+/* \n+    Copyright (C) 2015 Stephen Oliver <steve@infincia.com>\n+    \n+    This code is distributed under the GNU General Public License, version 2.\n+    \n+    3rd party libraries may be distributed under an alternate Open Source license.\n+    \n+    See the LICENSE file included with this code for details.\n+    \n+*/\n+\n+\n+#import \"FNAppDelegate.h\"\n+\n+#import \"FNNodeController.h\"\n+#import \"FNDropdownMenuController.h\"\n+\n+#import \"NSBundle+LoginItem.h\"\n+\n+@interface FNAppDelegate ()\n+    \n+@end\n+\n+@implementation FNAppDelegate\n+\n+- (void)applicationDidFinishLaunching:(NSNotification *)aNotification {\n+    \n+\t// load factory defaults for node location variables, sourced from defaults.plist\n+\tNSString *defaultsPlist = [[NSBundle mainBundle] pathForResource:@\"defaults\" ofType:@\"plist\"];\n+\tNSDictionary *defaultsPlistDict = [NSDictionary dictionaryWithContentsOfFile:defaultsPlist];\n+\n+\tNSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];    \n+    [defaults registerDefaults:defaultsPlistDict];\n+ \n+    \n+    nodeController = [[FNNodeController alloc] init];\n+\n+\t/* \n+        Check for first launch key, if it isn't there this is first launch and \n+        we need to setup autostart/loginitem\n+    */","path":"res/mac/FreenetTray/src/FNAppDelegate.m","position":41,"original_position":41,"commit_id":"8bd5c0a7628a0d6de02661516efa6765c563fd0b","original_commit_id":"8bd5c0a7628a0d6de02661516efa6765c563fd0b","user":{"login":"Thynix","id":199917,"avatar_url":"https://avatars.githubusercontent.com/u/199917?v=3","gravatar_id":"","url":"https://api.github.com/users/Thynix","html_url":"https://github.com/Thynix","followers_url":"https://api.github.com/users/Thynix/followers","following_url":"https://api.github.com/users/Thynix/following{/other_user}","gists_url":"https://api.github.com/users/Thynix/gists{/gist_id}","starred_url":"https://api.github.com/users/Thynix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thynix/subscriptions","organizations_url":"https://api.github.com/users/Thynix/orgs","repos_url":"https://api.github.com/users/Thynix/repos","events_url":"https://api.github.com/users/Thynix/events{/privacy}","received_events_url":"https://api.github.com/users/Thynix/received_events","type":"User","site_admin":false},"body":"The whitespace looks inconsistent here. Is that intended? Do you want to establish coding standards for this codebase?","created_at":"2015-04-14T02:45:21Z","updated_at":"2015-04-14T02:45:21Z","html_url":"https://github.com/freenet/java_installer/pull/7#discussion_r28297315","pull_request_url":"https://api.github.com/repos/freenet/java_installer/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/comments/28297315"},"html":{"href":"https://github.com/freenet/java_installer/pull/7#discussion_r28297315"},"pull_request":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/freenet/java_installer/pulls/7","id":32927544,"html_url":"https://github.com/freenet/java_installer/pull/7","diff_url":"https://github.com/freenet/java_installer/pull/7.diff","patch_url":"https://github.com/freenet/java_installer/pull/7.patch","issue_url":"https://api.github.com/repos/freenet/java_installer/issues/7","number":7,"state":"open","locked":false,"title":"Mac tray refactoring, fix start/stop bug, add retina tray icon, FCP support","user":{"login":"steveatinfincia","id":84317,"avatar_url":"https://avatars.githubusercontent.com/u/84317?v=3","gravatar_id":"","url":"https://api.github.com/users/steveatinfincia","html_url":"https://github.com/steveatinfincia","followers_url":"https://api.github.com/users/steveatinfincia/followers","following_url":"https://api.github.com/users/steveatinfincia/following{/other_user}","gists_url":"https://api.github.com/users/steveatinfincia/gists{/gist_id}","starred_url":"https://api.github.com/users/steveatinfincia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveatinfincia/subscriptions","organizations_url":"https://api.github.com/users/steveatinfincia/orgs","repos_url":"https://api.github.com/users/steveatinfincia/repos","events_url":"https://api.github.com/users/steveatinfincia/events{/privacy}","received_events_url":"https://api.github.com/users/steveatinfincia/received_events","type":"User","site_admin":false},"body":"* Refactor Mac tray to substantially improve code quality, make it more maintainable\r\n* Fix start/stop bug on newer versions of OS X\r\n* Add vector/Retina tray icons (draw in code with PaintCode, not rendered images)\r\n* Add basic FCP support\r\n* Remove Apple library code that no longer compiles, use CocoaPods for 3rd party libraries\r\n* Add explicit authorship/copyright (needs additions if anyone else contributed!)\r\n* Set license to exactly GPL version 2 (GPLv3 may pose a problem for FPI if code signing this app)\r\n* Drops PPC and 32-bit x86 support (for very good reasons)\r\n    * Some major language and compiler features (ARC, for example) don't work on 32-bit x86\r\n    * There is no 32-bit x86 or PPC Java 7 for OS X\r\n        * Nodes required to run Java 7 very soon anyway\r\n    * Xcode can't even compile for PPC anymore\r\n    * There were only a few 32-bit x86 Macs and they were all discontinued ~10 years ago","created_at":"2015-04-09T06:07:36Z","updated_at":"2015-04-14T02:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26f2d15f8071ab64c67f1a8d136192967735bcfb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freenet/java_installer/pulls/7/commits","review_comments_url":"https://api.github.com/repos/freenet/java_installer/pulls/7/comments","review_comment_url":"https://api.github.com/repos/freenet/java_installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenet/java_installer/issues/7/comments","statuses_url":"https://api.github.com/repos/freenet/java_installer/statuses/8bd5c0a7628a0d6de02661516efa6765c563fd0b","head":{"label":"steveatinfincia:mactray","ref":"mactray","sha":"8bd5c0a7628a0d6de02661516efa6765c563fd0b","user":{"login":"steveatinfincia","id":84317,"avatar_url":"https://avatars.githubusercontent.com/u/84317?v=3","gravatar_id":"","url":"https://api.github.com/users/steveatinfincia","html_url":"https://github.com/steveatinfincia","followers_url":"https://api.github.com/users/steveatinfincia/followers","following_url":"https://api.github.com/users/steveatinfincia/following{/other_user}","gists_url":"https://api.github.com/users/steveatinfincia/gists{/gist_id}","starred_url":"https://api.github.com/users/steveatinfincia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveatinfincia/subscriptions","organizations_url":"https://api.github.com/users/steveatinfincia/orgs","repos_url":"https://api.github.com/users/steveatinfincia/repos","events_url":"https://api.github.com/users/steveatinfincia/events{/privacy}","received_events_url":"https://api.github.com/users/steveatinfincia/received_events","type":"User","site_admin":false},"repo":{"id":33650236,"name":"java_installer","full_name":"steveatinfincia/java_installer","owner":{"login":"steveatinfincia","id":84317,"avatar_url":"https://avatars.githubusercontent.com/u/84317?v=3","gravatar_id":"","url":"https://api.github.com/users/steveatinfincia","html_url":"https://github.com/steveatinfincia","followers_url":"https://api.github.com/users/steveatinfincia/followers","following_url":"https://api.github.com/users/steveatinfincia/following{/other_user}","gists_url":"https://api.github.com/users/steveatinfincia/gists{/gist_id}","starred_url":"https://api.github.com/users/steveatinfincia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveatinfincia/subscriptions","organizations_url":"https://api.github.com/users/steveatinfincia/orgs","repos_url":"https://api.github.com/users/steveatinfincia/repos","events_url":"https://api.github.com/users/steveatinfincia/events{/privacy}","received_events_url":"https://api.github.com/users/steveatinfincia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveatinfincia/java_installer","description":"The java-based installer (staging area, writable by any developer)","fork":true,"url":"https://api.github.com/repos/steveatinfincia/java_installer","forks_url":"https://api.github.com/repos/steveatinfincia/java_installer/forks","keys_url":"https://api.github.com/repos/steveatinfincia/java_installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveatinfincia/java_installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveatinfincia/java_installer/teams","hooks_url":"https://api.github.com/repos/steveatinfincia/java_installer/hooks","issue_events_url":"https://api.github.com/repos/steveatinfincia/java_installer/issues/events{/number}","events_url":"https://api.github.com/repos/steveatinfincia/java_installer/events","assignees_url":"https://api.github.com/repos/steveatinfincia/java_installer/assignees{/user}","branches_url":"https://api.github.com/repos/steveatinfincia/java_installer/branches{/branch}","tags_url":"https://api.github.com/repos/steveatinfincia/java_installer/tags","blobs_url":"https://api.github.com/repos/steveatinfincia/java_installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveatinfincia/java_installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveatinfincia/java_installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveatinfincia/java_installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveatinfincia/java_installer/statuses/{sha}","languages_url":"https://api.github.com/repos/steveatinfincia/java_installer/languages","stargazers_url":"https://api.github.com/repos/steveatinfincia/java_installer/stargazers","contributors_url":"https://api.github.com/repos/steveatinfincia/java_installer/contributors","subscribers_url":"https://api.github.com/repos/steveatinfincia/java_installer/subscribers","subscription_url":"https://api.github.com/repos/steveatinfincia/java_installer/subscription","commits_url":"https://api.github.com/repos/steveatinfincia/java_installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveatinfincia/java_installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveatinfincia/java_installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveatinfincia/java_installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveatinfincia/java_installer/contents/{+path}","compare_url":"https://api.github.com/repos/steveatinfincia/java_installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveatinfincia/java_installer/merges","archive_url":"https://api.github.com/repos/steveatinfincia/java_installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveatinfincia/java_installer/downloads","issues_url":"https://api.github.com/repos/steveatinfincia/java_installer/issues{/number}","pulls_url":"https://api.github.com/repos/steveatinfincia/java_installer/pulls{/number}","milestones_url":"https://api.github.com/repos/steveatinfincia/java_installer/milestones{/number}","notifications_url":"https://api.github.com/repos/steveatinfincia/java_installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveatinfincia/java_installer/labels{/name}","releases_url":"https://api.github.com/repos/steveatinfincia/java_installer/releases{/id}","created_at":"2015-04-09T05:29:06Z","updated_at":"2015-04-09T05:29:09Z","pushed_at":"2015-04-10T00:40:42Z","git_url":"git://github.com/steveatinfincia/java_installer.git","ssh_url":"git@github.com:steveatinfincia/java_installer.git","clone_url":"https://github.com/steveatinfincia/java_installer.git","svn_url":"https://github.com/steveatinfincia/java_installer","homepage":"http://freenetproject.org/","size":8369,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"freenet:next","ref":"next","sha":"366e746709fc1bbaab5aa6c736fb7fd11968ca40","user":{"login":"freenet","id":77513,"avatar_url":"https://avatars.githubusercontent.com/u/77513?v=3","gravatar_id":"","url":"https://api.github.com/users/freenet","html_url":"https://github.com/freenet","followers_url":"https://api.github.com/users/freenet/followers","following_url":"https://api.github.com/users/freenet/following{/other_user}","gists_url":"https://api.github.com/users/freenet/gists{/gist_id}","starred_url":"https://api.github.com/users/freenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenet/subscriptions","organizations_url":"https://api.github.com/users/freenet/orgs","repos_url":"https://api.github.com/users/freenet/repos","events_url":"https://api.github.com/users/freenet/events{/privacy}","received_events_url":"https://api.github.com/users/freenet/received_events","type":"Organization","site_admin":false},"repo":{"id":185065,"name":"java_installer","full_name":"freenet/java_installer","owner":{"login":"freenet","id":77513,"avatar_url":"https://avatars.githubusercontent.com/u/77513?v=3","gravatar_id":"","url":"https://api.github.com/users/freenet","html_url":"https://github.com/freenet","followers_url":"https://api.github.com/users/freenet/followers","following_url":"https://api.github.com/users/freenet/following{/other_user}","gists_url":"https://api.github.com/users/freenet/gists{/gist_id}","starred_url":"https://api.github.com/users/freenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenet/subscriptions","organizations_url":"https://api.github.com/users/freenet/orgs","repos_url":"https://api.github.com/users/freenet/repos","events_url":"https://api.github.com/users/freenet/events{/privacy}","received_events_url":"https://api.github.com/users/freenet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freenet/java_installer","description":"The java-based installer (staging area, writable by any developer)","fork":false,"url":"https://api.github.com/repos/freenet/java_installer","forks_url":"https://api.github.com/repos/freenet/java_installer/forks","keys_url":"https://api.github.com/repos/freenet/java_installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenet/java_installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenet/java_installer/teams","hooks_url":"https://api.github.com/repos/freenet/java_installer/hooks","issue_events_url":"https://api.github.com/repos/freenet/java_installer/issues/events{/number}","events_url":"https://api.github.com/repos/freenet/java_installer/events","assignees_url":"https://api.github.com/repos/freenet/java_installer/assignees{/user}","branches_url":"https://api.github.com/repos/freenet/java_installer/branches{/branch}","tags_url":"https://api.github.com/repos/freenet/java_installer/tags","blobs_url":"https://api.github.com/repos/freenet/java_installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenet/java_installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenet/java_installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenet/java_installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenet/java_installer/statuses/{sha}","languages_url":"https://api.github.com/repos/freenet/java_installer/languages","stargazers_url":"https://api.github.com/repos/freenet/java_installer/stargazers","contributors_url":"https://api.github.com/repos/freenet/java_installer/contributors","subscribers_url":"https://api.github.com/repos/freenet/java_installer/subscribers","subscription_url":"https://api.github.com/repos/freenet/java_installer/subscription","commits_url":"https://api.github.com/repos/freenet/java_installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenet/java_installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenet/java_installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenet/java_installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenet/java_installer/contents/{+path}","compare_url":"https://api.github.com/repos/freenet/java_installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenet/java_installer/merges","archive_url":"https://api.github.com/repos/freenet/java_installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenet/java_installer/downloads","issues_url":"https://api.github.com/repos/freenet/java_installer/issues{/number}","pulls_url":"https://api.github.com/repos/freenet/java_installer/pulls{/number}","milestones_url":"https://api.github.com/repos/freenet/java_installer/milestones{/number}","notifications_url":"https://api.github.com/repos/freenet/java_installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenet/java_installer/labels{/name}","releases_url":"https://api.github.com/repos/freenet/java_installer/releases{/id}","created_at":"2009-04-25T02:44:02Z","updated_at":"2015-04-12T10:09:22Z","pushed_at":"2015-04-10T00:32:10Z","git_url":"git://github.com/freenet/java_installer.git","ssh_url":"git@github.com:freenet/java_installer.git","clone_url":"https://github.com/freenet/java_installer.git","svn_url":"https://github.com/freenet/java_installer","homepage":"http://freenetproject.org/","size":8710,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":9,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/7"},"html":{"href":"https://github.com/freenet/java_installer/pull/7"},"issue":{"href":"https://api.github.com/repos/freenet/java_installer/issues/7"},"comments":{"href":"https://api.github.com/repos/freenet/java_installer/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenet/java_installer/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/freenet/java_installer/statuses/8bd5c0a7628a0d6de02661516efa6765c563fd0b"}}}}