{"action":"created","comment":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/25054363","id":25054363,"diff_hunk":"@@ -317,7 +317,7 @@ private function parse()\n             $this->tpl->assign('fields', $this->fieldsHTML);\n \n             // parse form\n-            $this->frm->parse($this->tpl);\n+            $this->frm->render($this->tpl);","path":"src/Frontend/Modules/FormBuilder/Widgets/Form.php","position":14,"original_position":14,"commit_id":"e506e0e15856576ed7d1aabd48ec73a6cf6d2223","original_commit_id":"e506e0e15856576ed7d1aabd48ec73a6cf6d2223","user":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"body":"Similar to src/Frontend/Core/Engine/Base/Widget.php\r\nFollow the cookie trail extension tpl comes from the object class.\r\n\r\nIn short  Spoon template files where compiled piece by piece with new instance of template. \r\nBut twig doesn't work like that, so I get my Template Class already instantiated in the Object class.","created_at":"2015-02-20T08:21:22Z","updated_at":"2015-02-20T08:21:22Z","html_url":"https://github.com/forkcms/forkcms/pull/1076#discussion_r25054363","pull_request_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1076","_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/25054363"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1076#discussion_r25054363"},"pull_request":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1076"}}},"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/1076","id":29659386,"html_url":"https://github.com/forkcms/forkcms/pull/1076","diff_url":"https://github.com/forkcms/forkcms/pull/1076.diff","patch_url":"https://github.com/forkcms/forkcms/pull/1076.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076","number":1076,"state":"open","locked":false,"title":"Feature twig","user":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"body":"Okay still a work in progress but I think I'm getting really close to a working solution.\r\nAdded the bootstrap theme with a couple of core example twig files as example.\r\n\r\n* Theme object still has no notion of twig files so if the file tpl and twig is not in the theme folder it will not load.\r\n* no modifiers yet so the navigation is a forced one, I hear @dubgeiser has some work on the modifiers,\r\n* no filters yet it's not required actually but some filters could be handy\r\n* I haven't tested form errors yet\r\n\r\nSome plus sides\r\n\r\n* It's quicker\r\n* it's twig\r\n* less boilerplate\r\n\r\nThis is a large pull request so please mind that not everything is commented yet.\r\n","created_at":"2015-02-19T23:21:57Z","updated_at":"2015-02-20T08:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5e669496c2c811be0d08de77b3d53285bd92504","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1076/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1076/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/e506e0e15856576ed7d1aabd48ec73a6cf6d2223","head":{"label":"Thijzer:feature-twig","ref":"feature-twig","sha":"e506e0e15856576ed7d1aabd48ec73a6cf6d2223","user":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"repo":{"id":23698232,"name":"forkcms","full_name":"Thijzer/forkcms","owner":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thijzer/forkcms","description":"Fork is an open source CMS.","fork":true,"url":"https://api.github.com/repos/Thijzer/forkcms","forks_url":"https://api.github.com/repos/Thijzer/forkcms/forks","keys_url":"https://api.github.com/repos/Thijzer/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thijzer/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thijzer/forkcms/teams","hooks_url":"https://api.github.com/repos/Thijzer/forkcms/hooks","issue_events_url":"https://api.github.com/repos/Thijzer/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/Thijzer/forkcms/events","assignees_url":"https://api.github.com/repos/Thijzer/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/Thijzer/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/Thijzer/forkcms/tags","blobs_url":"https://api.github.com/repos/Thijzer/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thijzer/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thijzer/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thijzer/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thijzer/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/Thijzer/forkcms/languages","stargazers_url":"https://api.github.com/repos/Thijzer/forkcms/stargazers","contributors_url":"https://api.github.com/repos/Thijzer/forkcms/contributors","subscribers_url":"https://api.github.com/repos/Thijzer/forkcms/subscribers","subscription_url":"https://api.github.com/repos/Thijzer/forkcms/subscription","commits_url":"https://api.github.com/repos/Thijzer/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thijzer/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thijzer/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thijzer/forkcms/issues/comments/{number}","contents_url":"https://api.github.com/repos/Thijzer/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/Thijzer/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thijzer/forkcms/merges","archive_url":"https://api.github.com/repos/Thijzer/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thijzer/forkcms/downloads","issues_url":"https://api.github.com/repos/Thijzer/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/Thijzer/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/Thijzer/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/Thijzer/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thijzer/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/Thijzer/forkcms/releases{/id}","created_at":"2014-09-05T09:52:35Z","updated_at":"2015-02-17T20:29:45Z","pushed_at":"2015-02-19T23:32:48Z","git_url":"git://github.com/Thijzer/forkcms.git","ssh_url":"git@github.com:Thijzer/forkcms.git","clone_url":"https://github.com/Thijzer/forkcms.git","svn_url":"https://github.com/Thijzer/forkcms","homepage":"http://www.fork-cms.com","size":33120,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"e6625ae0ede83aa50a9de1630197ac94f4734e2f","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an open source CMS.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments/{number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","created_at":"2010-12-04T18:06:15Z","updated_at":"2015-02-17T13:40:16Z","pushed_at":"2015-02-18T14:10:12Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":60966,"stargazers_count":830,"watchers_count":830,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":78,"forks":233,"open_issues":78,"watchers":830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1076"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1076"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1076"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1076/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1076/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1076/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/e506e0e15856576ed7d1aabd48ec73a6cf6d2223"}}}}