{"action":"opened","number":894,"pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/894","id":48611185,"html_url":"https://github.com/sinonjs/sinon/pull/894","diff_url":"https://github.com/sinonjs/sinon/pull/894.diff","patch_url":"https://github.com/sinonjs/sinon/pull/894.patch","issue_url":"https://api.github.com/repos/sinonjs/sinon/issues/894","number":894,"state":"open","locked":false,"title":"Allow requestBody in FakeXDomainRequest for GET requests","user":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"body":"It looks like you're explicitly stopping both GET and HEAD requests from allowing the request body to have a body. \r\n\r\nWhy not GET? It's in the spec that GETs should be allowed a body, which makes sense for APIs that take in large amounts of data for GET requests.\r\n\r\nReference quoted from http://bugs.jquery.com/ticket/8961:\r\n\r\n> This is all explained in the  HTTP 1.1 Spec, RFC 2616...\r\n> \r\n> Essentially it breaks down to the fact that the message body should be allowed unless specified otherwise in the request type specifications, as in HEAD. The GET request does not mention the message body at all, so by default **should be able to use a message body**. This is useful if you want to query the server with structured (e.g. JSON) data.","created_at":"2015-10-23T18:07:23Z","updated_at":"2015-10-23T18:07:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/sinon/pulls/894/commits","review_comments_url":"https://api.github.com/repos/sinonjs/sinon/pulls/894/comments","review_comment_url":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/sinon/issues/894/comments","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/6c7866e4621862767d64278e2eb7ce6ac17aaf98","head":{"label":"JoshuaKGoldberg:patch-1","ref":"patch-1","sha":"6c7866e4621862767d64278e2eb7ce6ac17aaf98","user":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"repo":{"id":44829775,"name":"sinon","full_name":"JoshuaKGoldberg/sinon","owner":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoshuaKGoldberg/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/JoshuaKGoldberg/sinon","forks_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/forks","keys_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/teams","hooks_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/hooks","issue_events_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/events","assignees_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/tags","blobs_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/languages","stargazers_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/stargazers","contributors_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/contributors","subscribers_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/subscribers","subscription_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/subscription","commits_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/merges","archive_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/downloads","issues_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/labels{/name}","releases_url":"https://api.github.com/repos/JoshuaKGoldberg/sinon/releases{/id}","created_at":"2015-10-23T18:02:30Z","updated_at":"2015-10-23T18:02:31Z","pushed_at":"2015-10-23T18:06:48Z","git_url":"git://github.com/JoshuaKGoldberg/sinon.git","ssh_url":"git@github.com:JoshuaKGoldberg/sinon.git","clone_url":"https://github.com/JoshuaKGoldberg/sinon.git","svn_url":"https://github.com/JoshuaKGoldberg/sinon","homepage":"http://sinonjs.org/","size":4946,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"d931ca69383e23a56b863fd519d9f4617f323148","user":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars.githubusercontent.com/u/6570253?v=3","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":747698,"name":"sinon","full_name":"sinonjs/sinon","owner":{"login":"sinonjs","id":6570253,"avatar_url":"https://avatars.githubusercontent.com/u/6570253?v=3","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinonjs/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/sinonjs/sinon","forks_url":"https://api.github.com/repos/sinonjs/sinon/forks","keys_url":"https://api.github.com/repos/sinonjs/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/sinon/teams","hooks_url":"https://api.github.com/repos/sinonjs/sinon/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/sinon/events","assignees_url":"https://api.github.com/repos/sinonjs/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/sinon/tags","blobs_url":"https://api.github.com/repos/sinonjs/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/sinon/languages","stargazers_url":"https://api.github.com/repos/sinonjs/sinon/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/sinon/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/sinon/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/sinon/subscription","commits_url":"https://api.github.com/repos/sinonjs/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/sinon/merges","archive_url":"https://api.github.com/repos/sinonjs/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/sinon/downloads","issues_url":"https://api.github.com/repos/sinonjs/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/sinon/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/sinon/releases{/id}","created_at":"2010-06-29T21:15:32Z","updated_at":"2015-10-23T17:50:09Z","pushed_at":"2015-10-22T06:58:53Z","git_url":"git://github.com/sinonjs/sinon.git","ssh_url":"git@github.com:sinonjs/sinon.git","clone_url":"https://github.com/sinonjs/sinon.git","svn_url":"https://github.com/sinonjs/sinon","homepage":"http://sinonjs.org/","size":4946,"stargazers_count":2393,"watchers_count":2393,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"open_issues_count":115,"forks":366,"open_issues":115,"watchers":2393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/894"},"html":{"href":"https://github.com/sinonjs/sinon/pull/894"},"issue":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/894"},"comments":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/sinon/statuses/6c7866e4621862767d64278e2eb7ce6ac17aaf98"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}