{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12290","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12290/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12290/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12290/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12290","id":72898537,"number":12290,"title":"[READY] Light attenuation based system for FoV and dynamic lighting.","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"milestone":null,"comments":85,"created_at":"2015-05-04T01:58:26Z","updated_at":"2015-06-07T06:45:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12290","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12290","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12290.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12290.patch"},"body":"This gets rid of a bunch of heuristics for determining sight range, replacing them with one system, which is that each square on the map absorbs a fraction of the light passing through it.  This applies both to vision and to light.  The sole exception is that all \"outside\" squares are lit by whatever amount is called for by the weather.\r\n\r\n\r\n- [x] Fix Night vision traits.\r\n- [x] Fix Night vision and infravision CBMs.\r\n- [x] Adjust light level at night to allow for short-ranged sight. (leave total darkness in for underground)\r\n- [x] Light level fixes\r\n - [x] Fix light level of Shocker brutes (and similar low-luminosity monsters).\r\n - [x] Make Sparks from electricity glow properly.\r\n - [x] Reduce illumination from small fires and make sure they taper off.\r\n - [x] Flashlights and turrets give tons of light. Single tile of raging fire is basically as bright as daylight.\r\n - [x] Moonlight provides tons of light to the point where by day 8 of spring it's about 80% of the strength of a flashlight.\r\n- [x] Make sure lighting is uniform across x and y.\r\n- [x] Make sure tiles marked as seen or unseen are treated consistently by everything.\r\n- [x] Investigate slowdown from large fires.\r\n- [x] Fix issue where distant illumination lights up a line between the illumination and the player.\r\n- [x] Fix issue where walls are invisible to nightvision.\r\n- [ ] Only illuminate walls if the light source is on the same side of the wall as the player. (possibly another PR if the fix isn't simple enough)\r\n- [x] Fix reading being allowed at night with no illumination.\r\n- [x] Fix illumination from fields being persistent after the field disappears.\r\n- [x] More performance work.\r\n- [x] Make sources of illumination visible from much further away with sm.\r\n- [x] Fix illuminated monsters illuminating just their squares but not themselves.\r\n- [ ] \"jagged\" light borders?\r\n- [x] Reintroduce restricted vision from weather by adding global lowered transparency in various weather conditions.\r\n- [x] Update crafting menu to reflect new brightness values.\r\n- [x] Weather effects don't show up in nighvision-visible areas\r\n- [x] Near areas with flickering light such as fires, nightvision constantly flickers on and off\r\n- [x] Getting boomer bile'd doesn't prevent redrawing of tiles due to weather effects (and presumably SCT)"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/109705297","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12290#issuecomment-109705297","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12290","id":109705297,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2015-06-07T06:45:43Z","updated_at":"2015-06-07T06:45:43Z","body":"I'd say it would be OK to merge if the fire issue was the only one left.\r\nIt seems only to happen when the light sources are on very low transparency tiles. I'll test it with smoke to make sure, but even if it affected both walls and smoke, it's still rather small.\r\n\r\nI'd suspect the whole \"don't lit up walls from the other side\" may be causing it, but I didn't actually review the code enough to say if it is the case."}}