{"action":"created","comment":{"url":"https://api.github.com/repos/LionsAd/service_container/pulls/comments/47484062","id":47484062,"diff_hunk":"@@ -467,16 +438,18 @@ protected function getMockContainerDefinition() {\n       'class' => '\\Drupal\\Tests\\service_container\\DependencyInjection\\MockService',\n       'arguments' => array(\n         (object) array(\n-          'type' => 'service',\n+          'type' => 'private_service',\n           'value' => $private_service,\n           'id' => 'private__' . $private_hash,\n         ),\n         '%some_config%'\n       ),\n     );\n+    /*","path":"tests/src/DependencyInjection/ContainerTest.php","position":196,"original_position":196,"commit_id":"59e38a812f5d0a80b6d4e6ec080c27e902795d0b","original_commit_id":"55798447229590d7089958b560c9936f09700bf5","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"body":"commented out code found!","created_at":"2015-12-14T10:56:53Z","updated_at":"2015-12-14T10:56:53Z","html_url":"https://github.com/LionsAd/service_container/pull/97#discussion_r47484062","pull_request_url":"https://api.github.com/repos/LionsAd/service_container/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/comments/47484062"},"html":{"href":"https://github.com/LionsAd/service_container/pull/97#discussion_r47484062"},"pull_request":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/LionsAd/service_container/pulls/97","id":53505812,"html_url":"https://github.com/LionsAd/service_container/pull/97","diff_url":"https://github.com/LionsAd/service_container/pull/97.diff","patch_url":"https://github.com/LionsAd/service_container/pull/97.patch","issue_url":"https://api.github.com/repos/LionsAd/service_container/issues/97","number":97,"state":"open","locked":false,"title":"Use Drupal 8 container via extension","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"body":"This fixes #89.\r\n\r\nBC breaks:\r\n\r\n#### Before:\r\n\r\n```php\r\n$definition['services']['foo'] = array('alias' => 'bar');\r\n$factory_service = array('factory_service' => 'x', 'factory_method' => 'get');\r\n$factory_class = array('factory_class' => 'SomeClass', 'factory_method' => 'get');\r\n```\r\n\r\n#### After:\r\n\r\n```php\r\n$definition['aliases']['foo'] = 'bar';\r\n$factory_service = array('factory' => array('@x', 'get'));\r\n$factory_service = array('factory' => 'SomeClass::get');\r\n```","created_at":"2015-12-13T18:22:53Z","updated_at":"2015-12-14T10:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed9323d54af219409fa84fe7c83605ab6c6ac798","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LionsAd/service_container/pulls/97/commits","review_comments_url":"https://api.github.com/repos/LionsAd/service_container/pulls/97/comments","review_comment_url":"https://api.github.com/repos/LionsAd/service_container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LionsAd/service_container/issues/97/comments","statuses_url":"https://api.github.com/repos/LionsAd/service_container/statuses/59e38a812f5d0a80b6d4e6ec080c27e902795d0b","head":{"label":"LionsAd:use-d8-container","ref":"use-d8-container","sha":"59e38a812f5d0a80b6d4e6ec080c27e902795d0b","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"repo":{"id":27236055,"name":"service_container","full_name":"LionsAd/service_container","owner":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LionsAd/service_container","description":"Service Container Module on drupal.org - used for development and automated testing via travis","fork":false,"url":"https://api.github.com/repos/LionsAd/service_container","forks_url":"https://api.github.com/repos/LionsAd/service_container/forks","keys_url":"https://api.github.com/repos/LionsAd/service_container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LionsAd/service_container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LionsAd/service_container/teams","hooks_url":"https://api.github.com/repos/LionsAd/service_container/hooks","issue_events_url":"https://api.github.com/repos/LionsAd/service_container/issues/events{/number}","events_url":"https://api.github.com/repos/LionsAd/service_container/events","assignees_url":"https://api.github.com/repos/LionsAd/service_container/assignees{/user}","branches_url":"https://api.github.com/repos/LionsAd/service_container/branches{/branch}","tags_url":"https://api.github.com/repos/LionsAd/service_container/tags","blobs_url":"https://api.github.com/repos/LionsAd/service_container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LionsAd/service_container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LionsAd/service_container/git/refs{/sha}","trees_url":"https://api.github.com/repos/LionsAd/service_container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LionsAd/service_container/statuses/{sha}","languages_url":"https://api.github.com/repos/LionsAd/service_container/languages","stargazers_url":"https://api.github.com/repos/LionsAd/service_container/stargazers","contributors_url":"https://api.github.com/repos/LionsAd/service_container/contributors","subscribers_url":"https://api.github.com/repos/LionsAd/service_container/subscribers","subscription_url":"https://api.github.com/repos/LionsAd/service_container/subscription","commits_url":"https://api.github.com/repos/LionsAd/service_container/commits{/sha}","git_commits_url":"https://api.github.com/repos/LionsAd/service_container/git/commits{/sha}","comments_url":"https://api.github.com/repos/LionsAd/service_container/comments{/number}","issue_comment_url":"https://api.github.com/repos/LionsAd/service_container/issues/comments{/number}","contents_url":"https://api.github.com/repos/LionsAd/service_container/contents/{+path}","compare_url":"https://api.github.com/repos/LionsAd/service_container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LionsAd/service_container/merges","archive_url":"https://api.github.com/repos/LionsAd/service_container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LionsAd/service_container/downloads","issues_url":"https://api.github.com/repos/LionsAd/service_container/issues{/number}","pulls_url":"https://api.github.com/repos/LionsAd/service_container/pulls{/number}","milestones_url":"https://api.github.com/repos/LionsAd/service_container/milestones{/number}","notifications_url":"https://api.github.com/repos/LionsAd/service_container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LionsAd/service_container/labels{/name}","releases_url":"https://api.github.com/repos/LionsAd/service_container/releases{/id}","created_at":"2014-11-27T17:50:29Z","updated_at":"2015-09-23T20:00:55Z","pushed_at":"2015-12-14T10:56:04Z","git_url":"git://github.com/LionsAd/service_container.git","ssh_url":"git@github.com:LionsAd/service_container.git","clone_url":"https://github.com/LionsAd/service_container.git","svn_url":"https://github.com/LionsAd/service_container","homepage":null,"size":1300,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"7.x-1.x"}},"base":{"label":"LionsAd:7.x-1.x","ref":"7.x-1.x","sha":"64022a7e4215902d4ed3b8ed1540bfa4f804c900","user":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"repo":{"id":27236055,"name":"service_container","full_name":"LionsAd/service_container","owner":{"login":"LionsAd","id":354804,"avatar_url":"https://avatars.githubusercontent.com/u/354804?v=3","gravatar_id":"","url":"https://api.github.com/users/LionsAd","html_url":"https://github.com/LionsAd","followers_url":"https://api.github.com/users/LionsAd/followers","following_url":"https://api.github.com/users/LionsAd/following{/other_user}","gists_url":"https://api.github.com/users/LionsAd/gists{/gist_id}","starred_url":"https://api.github.com/users/LionsAd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LionsAd/subscriptions","organizations_url":"https://api.github.com/users/LionsAd/orgs","repos_url":"https://api.github.com/users/LionsAd/repos","events_url":"https://api.github.com/users/LionsAd/events{/privacy}","received_events_url":"https://api.github.com/users/LionsAd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LionsAd/service_container","description":"Service Container Module on drupal.org - used for development and automated testing via travis","fork":false,"url":"https://api.github.com/repos/LionsAd/service_container","forks_url":"https://api.github.com/repos/LionsAd/service_container/forks","keys_url":"https://api.github.com/repos/LionsAd/service_container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LionsAd/service_container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LionsAd/service_container/teams","hooks_url":"https://api.github.com/repos/LionsAd/service_container/hooks","issue_events_url":"https://api.github.com/repos/LionsAd/service_container/issues/events{/number}","events_url":"https://api.github.com/repos/LionsAd/service_container/events","assignees_url":"https://api.github.com/repos/LionsAd/service_container/assignees{/user}","branches_url":"https://api.github.com/repos/LionsAd/service_container/branches{/branch}","tags_url":"https://api.github.com/repos/LionsAd/service_container/tags","blobs_url":"https://api.github.com/repos/LionsAd/service_container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LionsAd/service_container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LionsAd/service_container/git/refs{/sha}","trees_url":"https://api.github.com/repos/LionsAd/service_container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LionsAd/service_container/statuses/{sha}","languages_url":"https://api.github.com/repos/LionsAd/service_container/languages","stargazers_url":"https://api.github.com/repos/LionsAd/service_container/stargazers","contributors_url":"https://api.github.com/repos/LionsAd/service_container/contributors","subscribers_url":"https://api.github.com/repos/LionsAd/service_container/subscribers","subscription_url":"https://api.github.com/repos/LionsAd/service_container/subscription","commits_url":"https://api.github.com/repos/LionsAd/service_container/commits{/sha}","git_commits_url":"https://api.github.com/repos/LionsAd/service_container/git/commits{/sha}","comments_url":"https://api.github.com/repos/LionsAd/service_container/comments{/number}","issue_comment_url":"https://api.github.com/repos/LionsAd/service_container/issues/comments{/number}","contents_url":"https://api.github.com/repos/LionsAd/service_container/contents/{+path}","compare_url":"https://api.github.com/repos/LionsAd/service_container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LionsAd/service_container/merges","archive_url":"https://api.github.com/repos/LionsAd/service_container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LionsAd/service_container/downloads","issues_url":"https://api.github.com/repos/LionsAd/service_container/issues{/number}","pulls_url":"https://api.github.com/repos/LionsAd/service_container/pulls{/number}","milestones_url":"https://api.github.com/repos/LionsAd/service_container/milestones{/number}","notifications_url":"https://api.github.com/repos/LionsAd/service_container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LionsAd/service_container/labels{/name}","releases_url":"https://api.github.com/repos/LionsAd/service_container/releases{/id}","created_at":"2014-11-27T17:50:29Z","updated_at":"2015-09-23T20:00:55Z","pushed_at":"2015-12-14T10:56:04Z","git_url":"git://github.com/LionsAd/service_container.git","ssh_url":"git@github.com:LionsAd/service_container.git","clone_url":"https://github.com/LionsAd/service_container.git","svn_url":"https://github.com/LionsAd/service_container","homepage":null,"size":1300,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/97"},"html":{"href":"https://github.com/LionsAd/service_container/pull/97"},"issue":{"href":"https://api.github.com/repos/LionsAd/service_container/issues/97"},"comments":{"href":"https://api.github.com/repos/LionsAd/service_container/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LionsAd/service_container/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/LionsAd/service_container/statuses/59e38a812f5d0a80b6d4e6ec080c27e902795d0b"}}}}