{"action":"created","comment":{"url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/comments/26281641","id":26281641,"diff_hunk":"@@ -2,6 +2,8 @@\n <!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" \"http://www.apple.com/DTDs/PropertyList-1.0.dtd\">\n <plist version=\"1.0\">\n <dict>\n+\t<key>NSLocationWhenInUseUsageDescription</key>\n+\t<string>We use your location in order to find awesome Instagram photos taken around you.</string>","path":"Mapstagram/Info.plist","position":5,"original_position":5,"commit_id":"0c29d1ffdba20a69ddc3fea6674900bebed205ff","original_commit_id":"0c29d1ffdba20a69ddc3fea6674900bebed205ff","user":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"body":"We should review all of our copy as part of our polish phase.  I just put something here for now.","created_at":"2015-03-12T06:47:18Z","updated_at":"2015-03-12T06:47:18Z","html_url":"https://github.com/jamietsao/codepath-mapstagram/pull/35#discussion_r26281641","pull_request_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/comments/26281641"},"html":{"href":"https://github.com/jamietsao/codepath-mapstagram/pull/35#discussion_r26281641"},"pull_request":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35","id":31011853,"html_url":"https://github.com/jamietsao/codepath-mapstagram/pull/35","diff_url":"https://github.com/jamietsao/codepath-mapstagram/pull/35.diff","patch_url":"https://github.com/jamietsao/codepath-mapstagram/pull/35.patch","issue_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/35","number":35,"state":"open","locked":false,"title":"Core Location","user":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"body":"Things to note:\r\n\r\n1) Created a LocationService that is a singleton wrapper around the Core Location framework.\r\n2) If user disabled access in the past, added a UIAlert view popup to allow them to easily navigate to Settings page to renable\r\n3) Currently storing the latest current location in LocationService.  I'm open to changing that - depends on how we want to manage \"session state\" (similar to mediaArray)\r\n4) There are still some edge cases around core location that I'd like to discuss with you guys.","created_at":"2015-03-12T06:46:17Z","updated_at":"2015-03-12T06:47:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bab48324d77f551948d0f421a38928a261754190","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35/commits","review_comments_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35/comments","review_comment_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/35/comments","statuses_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/statuses/0c29d1ffdba20a69ddc3fea6674900bebed205ff","head":{"label":"jamietsao:core-location","ref":"core-location","sha":"0c29d1ffdba20a69ddc3fea6674900bebed205ff","user":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"repo":{"id":31630297,"name":"codepath-mapstagram","full_name":"jamietsao/codepath-mapstagram","owner":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamietsao/codepath-mapstagram","description":"","fork":false,"url":"https://api.github.com/repos/jamietsao/codepath-mapstagram","forks_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/forks","keys_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/teams","hooks_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/hooks","issue_events_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/events{/number}","events_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/events","assignees_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/assignees{/user}","branches_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/branches{/branch}","tags_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/tags","blobs_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/statuses/{sha}","languages_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/languages","stargazers_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/stargazers","contributors_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/contributors","subscribers_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/subscribers","subscription_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/subscription","commits_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/contents/{+path}","compare_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/merges","archive_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/downloads","issues_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues{/number}","pulls_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls{/number}","milestones_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/milestones{/number}","notifications_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/labels{/name}","releases_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/releases{/id}","created_at":"2015-03-04T01:01:44Z","updated_at":"2015-03-12T02:02:02Z","pushed_at":"2015-03-12T06:42:16Z","git_url":"git://github.com/jamietsao/codepath-mapstagram.git","ssh_url":"git@github.com:jamietsao/codepath-mapstagram.git","clone_url":"https://github.com/jamietsao/codepath-mapstagram.git","svn_url":"https://github.com/jamietsao/codepath-mapstagram","homepage":null,"size":514,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":15,"forks":2,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"jamietsao:master","ref":"master","sha":"7ca7e2998370bb5170a4d2fde3be422753191fe8","user":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"repo":{"id":31630297,"name":"codepath-mapstagram","full_name":"jamietsao/codepath-mapstagram","owner":{"login":"jamietsao","id":253431,"avatar_url":"https://avatars.githubusercontent.com/u/253431?v=3","gravatar_id":"","url":"https://api.github.com/users/jamietsao","html_url":"https://github.com/jamietsao","followers_url":"https://api.github.com/users/jamietsao/followers","following_url":"https://api.github.com/users/jamietsao/following{/other_user}","gists_url":"https://api.github.com/users/jamietsao/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietsao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietsao/subscriptions","organizations_url":"https://api.github.com/users/jamietsao/orgs","repos_url":"https://api.github.com/users/jamietsao/repos","events_url":"https://api.github.com/users/jamietsao/events{/privacy}","received_events_url":"https://api.github.com/users/jamietsao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamietsao/codepath-mapstagram","description":"","fork":false,"url":"https://api.github.com/repos/jamietsao/codepath-mapstagram","forks_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/forks","keys_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/teams","hooks_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/hooks","issue_events_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/events{/number}","events_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/events","assignees_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/assignees{/user}","branches_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/branches{/branch}","tags_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/tags","blobs_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/statuses/{sha}","languages_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/languages","stargazers_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/stargazers","contributors_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/contributors","subscribers_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/subscribers","subscription_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/subscription","commits_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/contents/{+path}","compare_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/merges","archive_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/downloads","issues_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues{/number}","pulls_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls{/number}","milestones_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/milestones{/number}","notifications_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/labels{/name}","releases_url":"https://api.github.com/repos/jamietsao/codepath-mapstagram/releases{/id}","created_at":"2015-03-04T01:01:44Z","updated_at":"2015-03-12T02:02:02Z","pushed_at":"2015-03-12T06:42:16Z","git_url":"git://github.com/jamietsao/codepath-mapstagram.git","ssh_url":"git@github.com:jamietsao/codepath-mapstagram.git","clone_url":"https://github.com/jamietsao/codepath-mapstagram.git","svn_url":"https://github.com/jamietsao/codepath-mapstagram","homepage":null,"size":514,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":15,"forks":2,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35"},"html":{"href":"https://github.com/jamietsao/codepath-mapstagram/pull/35"},"issue":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/35"},"comments":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/jamietsao/codepath-mapstagram/statuses/0c29d1ffdba20a69ddc3fea6674900bebed205ff"}}}}