{"action":"created","issue":{"url":"https://api.github.com/repos/praekelt/vumi/issues/1002","labels_url":"https://api.github.com/repos/praekelt/vumi/issues/1002/labels{/name}","comments_url":"https://api.github.com/repos/praekelt/vumi/issues/1002/comments","events_url":"https://api.github.com/repos/praekelt/vumi/issues/1002/events","html_url":"https://github.com/praekelt/vumi/pull/1002","id":114769407,"number":1002,"title":"Separate fake AMQP channel from real AMQP client","user":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?v=3","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/praekelt/vumi/labels/please-review","name":"please-review","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"jerith","id":43731,"avatar_url":"https://avatars.githubusercontent.com/u/43731?v=3","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-03T08:44:44Z","updated_at":"2015-11-03T11:11:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/praekelt/vumi/pulls/1002","html_url":"https://github.com/praekelt/vumi/pull/1002","diff_url":"https://github.com/praekelt/vumi/pull/1002.diff","patch_url":"https://github.com/praekelt/vumi/pull/1002.patch"},"body":"We have a few tests that look for fake AQMP things on the channel objects belonging to clients. As part of the work in #1000, AMQP clients will get real channel objects instead fake ones and will have to look at `channel._fake_channel` to get at the fake stuff.\r\n\r\nTo make that transition easier, it seems sensible to wrap the current fake channel with a more realistic one and expose the underlying fake on `channel._fake_channel`.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/praekelt/vumi/1002)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/praekelt/vumi/issues/comments/153317985","html_url":"https://github.com/praekelt/vumi/pull/1002#issuecomment-153317985","issue_url":"https://api.github.com/repos/praekelt/vumi/issues/1002","id":153317985,"user":{"login":"smn","id":1065,"avatar_url":"https://avatars.githubusercontent.com/u/1065?v=3","gravatar_id":"","url":"https://api.github.com/users/smn","html_url":"https://github.com/smn","followers_url":"https://api.github.com/users/smn/followers","following_url":"https://api.github.com/users/smn/following{/other_user}","gists_url":"https://api.github.com/users/smn/gists{/gist_id}","starred_url":"https://api.github.com/users/smn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smn/subscriptions","organizations_url":"https://api.github.com/users/smn/orgs","repos_url":"https://api.github.com/users/smn/repos","events_url":"https://api.github.com/users/smn/events{/privacy}","received_events_url":"https://api.github.com/users/smn/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T11:11:43Z","updated_at":"2015-11-03T11:11:43Z","body":":+1:\n<!-- Reviewable comment -K2C1sUp-nbW-8Ds5G2e:-510466997 -->\n\n---\n\nReviewed 8 of 8 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/praekelt/vumi/1002)\n<!-- Sent from Reviewable.io -->\n"}}