{"action":"closed","number":797,"pull_request":{"url":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797","id":42933695,"html_url":"https://github.com/Deadrik/TFCraft/pull/797","diff_url":"https://github.com/Deadrik/TFCraft/pull/797.diff","patch_url":"https://github.com/Deadrik/TFCraft/pull/797.patch","issue_url":"https://api.github.com/repos/Deadrik/TFCraft/issues/797","number":797,"state":"closed","locked":false,"title":"Fixed the CaseInsensitiveHashMap compile errors on older Java versions","user":{"login":"dries007","id":1346725,"avatar_url":"https://avatars.githubusercontent.com/u/1346725?v=3","gravatar_id":"","url":"https://api.github.com/users/dries007","html_url":"https://github.com/dries007","followers_url":"https://api.github.com/users/dries007/followers","following_url":"https://api.github.com/users/dries007/following{/other_user}","gists_url":"https://api.github.com/users/dries007/gists{/gist_id}","starred_url":"https://api.github.com/users/dries007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dries007/subscriptions","organizations_url":"https://api.github.com/users/dries007/orgs","repos_url":"https://api.github.com/users/dries007/repos","events_url":"https://api.github.com/users/dries007/events{/privacy}","received_events_url":"https://api.github.com/users/dries007/received_events","type":"User","site_admin":false},"body":"A little explanation: The map interface has a (public) inner interface called Entry, used by the .entrySet() method.\r\nIn older JDK's the HashMap class defines a (package local) inner class called Entry, which, when you make a class that extends HashMap, can cause naming conflicts when you don't use Map.Entry. [Example: OpenJDK 6 and 7](http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/HashMap.java#HashMap.Entry)\r\nJava 8 JDK's don't have this issue as they use an inner class called Node. [Example: OpenJDK 8](http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8-b132/java/util/HashMap.java#HashMap.Node)\r\n\r\nUnfortunately, these types of issues can't be easily detected without actually using an (outdated) Java 7 JDK, as setting the targetCompatibility & sourceCompatibility options in gradle and the project language setting in IntelliJ didn't catch it.","created_at":"2015-08-20T14:12:55Z","updated_at":"2015-08-20T15:24:21Z","closed_at":"2015-08-20T15:24:21Z","merged_at":"2015-08-20T15:24:21Z","merge_commit_sha":"4f79bc951df6ca51388276591a0b031971c3f8cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797/commits","review_comments_url":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797/comments","review_comment_url":"https://api.github.com/repos/Deadrik/TFCraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Deadrik/TFCraft/issues/797/comments","statuses_url":"https://api.github.com/repos/Deadrik/TFCraft/statuses/f586c45b004c68e863dd431fa0abdd6aebd9e88d","head":{"label":"dries007:master_","ref":"master_","sha":"f586c45b004c68e863dd431fa0abdd6aebd9e88d","user":{"login":"dries007","id":1346725,"avatar_url":"https://avatars.githubusercontent.com/u/1346725?v=3","gravatar_id":"","url":"https://api.github.com/users/dries007","html_url":"https://github.com/dries007","followers_url":"https://api.github.com/users/dries007/followers","following_url":"https://api.github.com/users/dries007/following{/other_user}","gists_url":"https://api.github.com/users/dries007/gists{/gist_id}","starred_url":"https://api.github.com/users/dries007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dries007/subscriptions","organizations_url":"https://api.github.com/users/dries007/orgs","repos_url":"https://api.github.com/users/dries007/repos","events_url":"https://api.github.com/users/dries007/events{/privacy}","received_events_url":"https://api.github.com/users/dries007/received_events","type":"User","site_admin":false},"repo":{"id":24731639,"name":"TFCraft","full_name":"dries007/TFCraft","owner":{"login":"dries007","id":1346725,"avatar_url":"https://avatars.githubusercontent.com/u/1346725?v=3","gravatar_id":"","url":"https://api.github.com/users/dries007","html_url":"https://github.com/dries007","followers_url":"https://api.github.com/users/dries007/followers","following_url":"https://api.github.com/users/dries007/following{/other_user}","gists_url":"https://api.github.com/users/dries007/gists{/gist_id}","starred_url":"https://api.github.com/users/dries007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dries007/subscriptions","organizations_url":"https://api.github.com/users/dries007/orgs","repos_url":"https://api.github.com/users/dries007/repos","events_url":"https://api.github.com/users/dries007/events{/privacy}","received_events_url":"https://api.github.com/users/dries007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dries007/TFCraft","description":"TerraFirmaCraft","fork":true,"url":"https://api.github.com/repos/dries007/TFCraft","forks_url":"https://api.github.com/repos/dries007/TFCraft/forks","keys_url":"https://api.github.com/repos/dries007/TFCraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dries007/TFCraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dries007/TFCraft/teams","hooks_url":"https://api.github.com/repos/dries007/TFCraft/hooks","issue_events_url":"https://api.github.com/repos/dries007/TFCraft/issues/events{/number}","events_url":"https://api.github.com/repos/dries007/TFCraft/events","assignees_url":"https://api.github.com/repos/dries007/TFCraft/assignees{/user}","branches_url":"https://api.github.com/repos/dries007/TFCraft/branches{/branch}","tags_url":"https://api.github.com/repos/dries007/TFCraft/tags","blobs_url":"https://api.github.com/repos/dries007/TFCraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dries007/TFCraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dries007/TFCraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/dries007/TFCraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dries007/TFCraft/statuses/{sha}","languages_url":"https://api.github.com/repos/dries007/TFCraft/languages","stargazers_url":"https://api.github.com/repos/dries007/TFCraft/stargazers","contributors_url":"https://api.github.com/repos/dries007/TFCraft/contributors","subscribers_url":"https://api.github.com/repos/dries007/TFCraft/subscribers","subscription_url":"https://api.github.com/repos/dries007/TFCraft/subscription","commits_url":"https://api.github.com/repos/dries007/TFCraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/dries007/TFCraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/dries007/TFCraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/dries007/TFCraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/dries007/TFCraft/contents/{+path}","compare_url":"https://api.github.com/repos/dries007/TFCraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dries007/TFCraft/merges","archive_url":"https://api.github.com/repos/dries007/TFCraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dries007/TFCraft/downloads","issues_url":"https://api.github.com/repos/dries007/TFCraft/issues{/number}","pulls_url":"https://api.github.com/repos/dries007/TFCraft/pulls{/number}","milestones_url":"https://api.github.com/repos/dries007/TFCraft/milestones{/number}","notifications_url":"https://api.github.com/repos/dries007/TFCraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dries007/TFCraft/labels{/name}","releases_url":"https://api.github.com/repos/dries007/TFCraft/releases{/id}","created_at":"2014-10-02T18:42:01Z","updated_at":"2015-01-05T13:09:38Z","pushed_at":"2015-08-20T14:01:03Z","git_url":"git://github.com/dries007/TFCraft.git","ssh_url":"git@github.com:dries007/TFCraft.git","clone_url":"https://github.com/dries007/TFCraft.git","svn_url":"https://github.com/dries007/TFCraft","homepage":null,"size":40683,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master_"}},"base":{"label":"Deadrik:master","ref":"master","sha":"d8850cc0aebb875f88959194527af5b6d3c6889b","user":{"login":"Deadrik","id":1658324,"avatar_url":"https://avatars.githubusercontent.com/u/1658324?v=3","gravatar_id":"","url":"https://api.github.com/users/Deadrik","html_url":"https://github.com/Deadrik","followers_url":"https://api.github.com/users/Deadrik/followers","following_url":"https://api.github.com/users/Deadrik/following{/other_user}","gists_url":"https://api.github.com/users/Deadrik/gists{/gist_id}","starred_url":"https://api.github.com/users/Deadrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deadrik/subscriptions","organizations_url":"https://api.github.com/users/Deadrik/orgs","repos_url":"https://api.github.com/users/Deadrik/repos","events_url":"https://api.github.com/users/Deadrik/events{/privacy}","received_events_url":"https://api.github.com/users/Deadrik/received_events","type":"User","site_admin":false},"repo":{"id":4101095,"name":"TFCraft","full_name":"Deadrik/TFCraft","owner":{"login":"Deadrik","id":1658324,"avatar_url":"https://avatars.githubusercontent.com/u/1658324?v=3","gravatar_id":"","url":"https://api.github.com/users/Deadrik","html_url":"https://github.com/Deadrik","followers_url":"https://api.github.com/users/Deadrik/followers","following_url":"https://api.github.com/users/Deadrik/following{/other_user}","gists_url":"https://api.github.com/users/Deadrik/gists{/gist_id}","starred_url":"https://api.github.com/users/Deadrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deadrik/subscriptions","organizations_url":"https://api.github.com/users/Deadrik/orgs","repos_url":"https://api.github.com/users/Deadrik/repos","events_url":"https://api.github.com/users/Deadrik/events{/privacy}","received_events_url":"https://api.github.com/users/Deadrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Deadrik/TFCraft","description":"TerraFirmaCraft","fork":false,"url":"https://api.github.com/repos/Deadrik/TFCraft","forks_url":"https://api.github.com/repos/Deadrik/TFCraft/forks","keys_url":"https://api.github.com/repos/Deadrik/TFCraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Deadrik/TFCraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Deadrik/TFCraft/teams","hooks_url":"https://api.github.com/repos/Deadrik/TFCraft/hooks","issue_events_url":"https://api.github.com/repos/Deadrik/TFCraft/issues/events{/number}","events_url":"https://api.github.com/repos/Deadrik/TFCraft/events","assignees_url":"https://api.github.com/repos/Deadrik/TFCraft/assignees{/user}","branches_url":"https://api.github.com/repos/Deadrik/TFCraft/branches{/branch}","tags_url":"https://api.github.com/repos/Deadrik/TFCraft/tags","blobs_url":"https://api.github.com/repos/Deadrik/TFCraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Deadrik/TFCraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Deadrik/TFCraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/Deadrik/TFCraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Deadrik/TFCraft/statuses/{sha}","languages_url":"https://api.github.com/repos/Deadrik/TFCraft/languages","stargazers_url":"https://api.github.com/repos/Deadrik/TFCraft/stargazers","contributors_url":"https://api.github.com/repos/Deadrik/TFCraft/contributors","subscribers_url":"https://api.github.com/repos/Deadrik/TFCraft/subscribers","subscription_url":"https://api.github.com/repos/Deadrik/TFCraft/subscription","commits_url":"https://api.github.com/repos/Deadrik/TFCraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/Deadrik/TFCraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/Deadrik/TFCraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/Deadrik/TFCraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/Deadrik/TFCraft/contents/{+path}","compare_url":"https://api.github.com/repos/Deadrik/TFCraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Deadrik/TFCraft/merges","archive_url":"https://api.github.com/repos/Deadrik/TFCraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Deadrik/TFCraft/downloads","issues_url":"https://api.github.com/repos/Deadrik/TFCraft/issues{/number}","pulls_url":"https://api.github.com/repos/Deadrik/TFCraft/pulls{/number}","milestones_url":"https://api.github.com/repos/Deadrik/TFCraft/milestones{/number}","notifications_url":"https://api.github.com/repos/Deadrik/TFCraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Deadrik/TFCraft/labels{/name}","releases_url":"https://api.github.com/repos/Deadrik/TFCraft/releases{/id}","created_at":"2012-04-22T02:09:54Z","updated_at":"2015-08-19T12:05:24Z","pushed_at":"2015-08-20T15:24:21Z","git_url":"git://github.com/Deadrik/TFCraft.git","ssh_url":"git@github.com:Deadrik/TFCraft.git","clone_url":"https://github.com/Deadrik/TFCraft.git","svn_url":"https://github.com/Deadrik/TFCraft","homepage":null,"size":70571,"stargazers_count":147,"watchers_count":147,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":12,"forks":116,"open_issues":12,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797"},"html":{"href":"https://github.com/Deadrik/TFCraft/pull/797"},"issue":{"href":"https://api.github.com/repos/Deadrik/TFCraft/issues/797"},"comments":{"href":"https://api.github.com/repos/Deadrik/TFCraft/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/Deadrik/TFCraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Deadrik/TFCraft/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/Deadrik/TFCraft/statuses/f586c45b004c68e863dd431fa0abdd6aebd9e88d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Kittychanley","id":5161275,"avatar_url":"https://avatars.githubusercontent.com/u/5161275?v=3","gravatar_id":"","url":"https://api.github.com/users/Kittychanley","html_url":"https://github.com/Kittychanley","followers_url":"https://api.github.com/users/Kittychanley/followers","following_url":"https://api.github.com/users/Kittychanley/following{/other_user}","gists_url":"https://api.github.com/users/Kittychanley/gists{/gist_id}","starred_url":"https://api.github.com/users/Kittychanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kittychanley/subscriptions","organizations_url":"https://api.github.com/users/Kittychanley/orgs","repos_url":"https://api.github.com/users/Kittychanley/repos","events_url":"https://api.github.com/users/Kittychanley/events{/privacy}","received_events_url":"https://api.github.com/users/Kittychanley/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}