{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/35844418","id":35844418,"diff_hunk":"@@ -114,7 +114,7 @@ extern \"C\" {\n \n   const unsigned int PVR_TIMER_TYPE_SUPPORTS_ENABLE_DISABLE           = 0x00000010; /*!< @brief this type supports enabling/disabling of the timer (PVR_TIMER.state SCHEDULED|DISBALED) */\n   const unsigned int PVR_TIMER_TYPE_SUPPORTS_CHANNELS                 = 0x00000020; /*!< @brief this type supports channels (PVR_TIMER.iClientChannelUid) */\n-  const unsigned int PVR_TIMER_TYPE_SUPPORTS_START_END_TIME           = 0x00000040; /*!< @brief this type supports start and end time (PVR_TIMER.startTime, PVR_TIMER.endTime) */\n+  const unsigned int PVR_TIMER_TYPE_SUPPORTS_START_TIME               = 0x00000040; /*!< @brief this type supports a recording start time (PVR_TIMER.startTime) */","path":"xbmc/addons/include/xbmc_pvr_types.h","position":18,"original_position":18,"commit_id":"75a03ac5479f3c9ffb79f0cb8246121af434261f","original_commit_id":"75a03ac5479f3c9ffb79f0cb8246121af434261f","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"PVR_TIMER_TYPE_SUPPORTS_END_TIME | is missing here.","created_at":"2015-07-30T07:19:56Z","updated_at":"2015-07-30T07:19:56Z","html_url":"https://github.com/xbmc/xbmc/pull/7635#discussion_r35844418","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7635","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/35844418"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7635#discussion_r35844418"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7635"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7635","id":40908475,"html_url":"https://github.com/xbmc/xbmc/pull/7635","diff_url":"https://github.com/xbmc/xbmc/pull/7635.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7635.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7635","number":7635,"state":"open","locked":false,"title":"[PVR] Replace startTime=endTime=0 with bAnyTime boolean for Timers","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"body":"Allows startTime/endTime to be retained if AnyTime is turned on and back off again to see how this affects the shows a timer will record.\r\nAlso: Retains meaningfull 'startTime' based 'sort by date' order for timers with 'Any Time' selected.\r\n\r\n**PVR Client Changes Requried**\r\nIn places where an addon currently sets 'startTime=endTime=0' to indicate Any Time, this should be removed and replaced by setting bAnyTime = true.\r\nIn places where 'startTime=endTime=0' is used to control backend recording rule settings, this should be replaced with something based on the bAnyTime state.\r\n\r\n**Context**\r\nThis PR relies on the changes in PR https://github.com/xbmc/xbmc/pull/7626 which groups several API changes forming API 2.2.0.\r\n* This PR should not be merged unless PR  https://github.com/xbmc/xbmc/pull/7626 has also been merged.\r\n* The necessary supporting API change is contained in commit '[PVR] Add bAnyTime to API 2.2.0'. If this change is withdrawn from PR https://github.com/xbmc/xbmc/pull/7626 this PR will be closed.\r\n\r\n**Comments**\r\nPlease make comments regarding the bAnyTime change itself here.\r\nFor comments regarding any of the other 2.2.0 API changes, please use https://github.com/xbmc/xbmc/pull/7626 ","created_at":"2015-07-27T14:24:31Z","updated_at":"2015-07-30T07:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dd82f58c96b2d059f946360193d96b8960671e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7635/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7635/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7635/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/75a03ac5479f3c9ffb79f0cb8246121af434261f","head":{"label":"metaron-uk:anytime","ref":"anytime","sha":"75a03ac5479f3c9ffb79f0cb8246121af434261f","user":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"repo":{"id":37365331,"name":"xbmc","full_name":"metaron-uk/xbmc","owner":{"login":"metaron-uk","id":12870817,"avatar_url":"https://avatars.githubusercontent.com/u/12870817?v=3","gravatar_id":"","url":"https://api.github.com/users/metaron-uk","html_url":"https://github.com/metaron-uk","followers_url":"https://api.github.com/users/metaron-uk/followers","following_url":"https://api.github.com/users/metaron-uk/following{/other_user}","gists_url":"https://api.github.com/users/metaron-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/metaron-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metaron-uk/subscriptions","organizations_url":"https://api.github.com/users/metaron-uk/orgs","repos_url":"https://api.github.com/users/metaron-uk/repos","events_url":"https://api.github.com/users/metaron-uk/events{/privacy}","received_events_url":"https://api.github.com/users/metaron-uk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/metaron-uk/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/metaron-uk/xbmc","forks_url":"https://api.github.com/repos/metaron-uk/xbmc/forks","keys_url":"https://api.github.com/repos/metaron-uk/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metaron-uk/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metaron-uk/xbmc/teams","hooks_url":"https://api.github.com/repos/metaron-uk/xbmc/hooks","issue_events_url":"https://api.github.com/repos/metaron-uk/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/metaron-uk/xbmc/events","assignees_url":"https://api.github.com/repos/metaron-uk/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/metaron-uk/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/metaron-uk/xbmc/tags","blobs_url":"https://api.github.com/repos/metaron-uk/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metaron-uk/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metaron-uk/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/metaron-uk/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metaron-uk/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/metaron-uk/xbmc/languages","stargazers_url":"https://api.github.com/repos/metaron-uk/xbmc/stargazers","contributors_url":"https://api.github.com/repos/metaron-uk/xbmc/contributors","subscribers_url":"https://api.github.com/repos/metaron-uk/xbmc/subscribers","subscription_url":"https://api.github.com/repos/metaron-uk/xbmc/subscription","commits_url":"https://api.github.com/repos/metaron-uk/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/metaron-uk/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/metaron-uk/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/metaron-uk/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/metaron-uk/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/metaron-uk/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metaron-uk/xbmc/merges","archive_url":"https://api.github.com/repos/metaron-uk/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metaron-uk/xbmc/downloads","issues_url":"https://api.github.com/repos/metaron-uk/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/metaron-uk/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/metaron-uk/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/metaron-uk/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metaron-uk/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/metaron-uk/xbmc/releases{/id}","created_at":"2015-06-13T09:15:46Z","updated_at":"2015-06-13T09:16:18Z","pushed_at":"2015-07-29T21:51:01Z","git_url":"git://github.com/metaron-uk/xbmc.git","ssh_url":"git@github.com:metaron-uk/xbmc.git","clone_url":"https://github.com/metaron-uk/xbmc.git","svn_url":"https://github.com/metaron-uk/xbmc","homepage":"http://xbmc.org","size":520346,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"dcce393e394fecb784642f46098d9ae62b28baec","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-07-30T05:02:03Z","pushed_at":"2015-07-30T05:51:35Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1870313,"stargazers_count":4031,"watchers_count":4031,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2946,"mirror_url":null,"open_issues_count":206,"forks":2946,"open_issues":206,"watchers":4031,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7635"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7635"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7635"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7635/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7635/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7635/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/75a03ac5479f3c9ffb79f0cb8246121af434261f"}}}}