{"action":"created","comment":{"url":"https://api.github.com/repos/nevill/zongji/pulls/comments/39908017","id":39908017,"diff_hunk":"@@ -29,6 +29,7 @@ module.exports = function(options) {\n   };\n \n   Binlog.prototype['OkPacket'] = function(packet) {\n+    // TODO: Remove console statements to make module ready for widespread use\n     console.log('Received one OkPacket ...');","path":"lib/sequence/binlog.js","position":5,"original_position":5,"commit_id":"2422081d621ca23dcdcaba639e5fcb8d2fc6cbdc","original_commit_id":"1f219c3170b85c4eb5e1ae75402c5d5b7f20d964","user":{"login":"numtel","id":518698,"avatar_url":"https://avatars.githubusercontent.com/u/518698?v=3","gravatar_id":"","url":"https://api.github.com/users/numtel","html_url":"https://github.com/numtel","followers_url":"https://api.github.com/users/numtel/followers","following_url":"https://api.github.com/users/numtel/following{/other_user}","gists_url":"https://api.github.com/users/numtel/gists{/gist_id}","starred_url":"https://api.github.com/users/numtel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numtel/subscriptions","organizations_url":"https://api.github.com/users/numtel/orgs","repos_url":"https://api.github.com/users/numtel/repos","events_url":"https://api.github.com/users/numtel/events{/privacy}","received_events_url":"https://api.github.com/users/numtel/received_events","type":"User","site_admin":false},"body":"Looks like we don't do anything with `OkPacket`s in ZongJi. See the `switch` at line 21.\r\n\r\nHere's the definition in `node-mysql`: https://github.com/felixge/node-mysql/blob/master/lib/protocol/sequences/Sequence.js#L36\r\n\r\nI would be very surprised if you could figure out a way to get that console message to actually appear. Maybe @nevill has an idea?","created_at":"2015-09-18T22:38:22Z","updated_at":"2015-09-18T22:38:22Z","html_url":"https://github.com/nevill/zongji/pull/19#discussion_r39908017","pull_request_url":"https://api.github.com/repos/nevill/zongji/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/nevill/zongji/pulls/comments/39908017"},"html":{"href":"https://github.com/nevill/zongji/pull/19#discussion_r39908017"},"pull_request":{"href":"https://api.github.com/repos/nevill/zongji/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/nevill/zongji/pulls/19","id":45438840,"html_url":"https://github.com/nevill/zongji/pull/19","diff_url":"https://github.com/nevill/zongji/pull/19.diff","patch_url":"https://github.com/nevill/zongji/pull/19.patch","issue_url":"https://api.github.com/repos/nevill/zongji/issues/19","number":19,"state":"open","locked":false,"title":"14x Performance Improvement in Lookup Functions","user":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"body":"@nevill,\r\n\r\nFor your consideration:\r\n\r\nThis pull request improves performance by 14x for the following functions:\r\n* ``getEventClass()``\r\n* ``getEventName()``\r\n* ``convertToMysqlType()``\r\n\r\nIt fixes the following \"warnings\":\r\n* Unterminated Statements (missing semi-colons)\r\n* Trailing commas in arrays and objects\r\n\r\nI fixed several very minor typos in comments and the ``README.md``.\r\n\r\nI added ``TODO`` comments above all ``throw`` and ``console`` statements that need attention before this module is \"safe\".\r\n\r\nYou did a very good job providing the ``dump`` functions as there was only one ``console`` that needed to be addressed and very few ``throw`` statements overall.\r\n\r\nObviously removing those statements won't accomplish the greater goal of making the module safe. I don't know enough about your function and tests to know where we can recover and what errors should be exposed (and how) to the end-user.","created_at":"2015-09-18T18:41:40Z","updated_at":"2015-09-18T22:38:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b4528c06df1cb8315cd657f2e2b3728e08c1ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nevill/zongji/pulls/19/commits","review_comments_url":"https://api.github.com/repos/nevill/zongji/pulls/19/comments","review_comment_url":"https://api.github.com/repos/nevill/zongji/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nevill/zongji/issues/19/comments","statuses_url":"https://api.github.com/repos/nevill/zongji/statuses/2422081d621ca23dcdcaba639e5fcb8d2fc6cbdc","head":{"label":"jmealo:master","ref":"master","sha":"2422081d621ca23dcdcaba639e5fcb8d2fc6cbdc","user":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"repo":{"id":42602362,"name":"zongji","full_name":"jmealo/zongji","owner":{"login":"jmealo","id":1066536,"avatar_url":"https://avatars.githubusercontent.com/u/1066536?v=3","gravatar_id":"","url":"https://api.github.com/users/jmealo","html_url":"https://github.com/jmealo","followers_url":"https://api.github.com/users/jmealo/followers","following_url":"https://api.github.com/users/jmealo/following{/other_user}","gists_url":"https://api.github.com/users/jmealo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmealo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmealo/subscriptions","organizations_url":"https://api.github.com/users/jmealo/orgs","repos_url":"https://api.github.com/users/jmealo/repos","events_url":"https://api.github.com/users/jmealo/events{/privacy}","received_events_url":"https://api.github.com/users/jmealo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmealo/zongji","description":"A mysql binlog listener running on Node.js.","fork":true,"url":"https://api.github.com/repos/jmealo/zongji","forks_url":"https://api.github.com/repos/jmealo/zongji/forks","keys_url":"https://api.github.com/repos/jmealo/zongji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmealo/zongji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmealo/zongji/teams","hooks_url":"https://api.github.com/repos/jmealo/zongji/hooks","issue_events_url":"https://api.github.com/repos/jmealo/zongji/issues/events{/number}","events_url":"https://api.github.com/repos/jmealo/zongji/events","assignees_url":"https://api.github.com/repos/jmealo/zongji/assignees{/user}","branches_url":"https://api.github.com/repos/jmealo/zongji/branches{/branch}","tags_url":"https://api.github.com/repos/jmealo/zongji/tags","blobs_url":"https://api.github.com/repos/jmealo/zongji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmealo/zongji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmealo/zongji/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmealo/zongji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmealo/zongji/statuses/{sha}","languages_url":"https://api.github.com/repos/jmealo/zongji/languages","stargazers_url":"https://api.github.com/repos/jmealo/zongji/stargazers","contributors_url":"https://api.github.com/repos/jmealo/zongji/contributors","subscribers_url":"https://api.github.com/repos/jmealo/zongji/subscribers","subscription_url":"https://api.github.com/repos/jmealo/zongji/subscription","commits_url":"https://api.github.com/repos/jmealo/zongji/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmealo/zongji/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmealo/zongji/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmealo/zongji/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmealo/zongji/contents/{+path}","compare_url":"https://api.github.com/repos/jmealo/zongji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmealo/zongji/merges","archive_url":"https://api.github.com/repos/jmealo/zongji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmealo/zongji/downloads","issues_url":"https://api.github.com/repos/jmealo/zongji/issues{/number}","pulls_url":"https://api.github.com/repos/jmealo/zongji/pulls{/number}","milestones_url":"https://api.github.com/repos/jmealo/zongji/milestones{/number}","notifications_url":"https://api.github.com/repos/jmealo/zongji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmealo/zongji/labels{/name}","releases_url":"https://api.github.com/repos/jmealo/zongji/releases{/id}","created_at":"2015-09-16T17:22:35Z","updated_at":"2015-09-16T17:22:36Z","pushed_at":"2015-09-18T22:34:15Z","git_url":"git://github.com/jmealo/zongji.git","ssh_url":"git@github.com:jmealo/zongji.git","clone_url":"https://github.com/jmealo/zongji.git","svn_url":"https://github.com/jmealo/zongji","homepage":null,"size":237,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nevill:master","ref":"master","sha":"2d571dd74f1bdd3efa931fa971926d4aa560dd3e","user":{"login":"nevill","id":114409,"avatar_url":"https://avatars.githubusercontent.com/u/114409?v=3","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"repo":{"id":14673734,"name":"zongji","full_name":"nevill/zongji","owner":{"login":"nevill","id":114409,"avatar_url":"https://avatars.githubusercontent.com/u/114409?v=3","gravatar_id":"","url":"https://api.github.com/users/nevill","html_url":"https://github.com/nevill","followers_url":"https://api.github.com/users/nevill/followers","following_url":"https://api.github.com/users/nevill/following{/other_user}","gists_url":"https://api.github.com/users/nevill/gists{/gist_id}","starred_url":"https://api.github.com/users/nevill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevill/subscriptions","organizations_url":"https://api.github.com/users/nevill/orgs","repos_url":"https://api.github.com/users/nevill/repos","events_url":"https://api.github.com/users/nevill/events{/privacy}","received_events_url":"https://api.github.com/users/nevill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nevill/zongji","description":"A mysql binlog listener running on Node.js.","fork":false,"url":"https://api.github.com/repos/nevill/zongji","forks_url":"https://api.github.com/repos/nevill/zongji/forks","keys_url":"https://api.github.com/repos/nevill/zongji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nevill/zongji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nevill/zongji/teams","hooks_url":"https://api.github.com/repos/nevill/zongji/hooks","issue_events_url":"https://api.github.com/repos/nevill/zongji/issues/events{/number}","events_url":"https://api.github.com/repos/nevill/zongji/events","assignees_url":"https://api.github.com/repos/nevill/zongji/assignees{/user}","branches_url":"https://api.github.com/repos/nevill/zongji/branches{/branch}","tags_url":"https://api.github.com/repos/nevill/zongji/tags","blobs_url":"https://api.github.com/repos/nevill/zongji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nevill/zongji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nevill/zongji/git/refs{/sha}","trees_url":"https://api.github.com/repos/nevill/zongji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nevill/zongji/statuses/{sha}","languages_url":"https://api.github.com/repos/nevill/zongji/languages","stargazers_url":"https://api.github.com/repos/nevill/zongji/stargazers","contributors_url":"https://api.github.com/repos/nevill/zongji/contributors","subscribers_url":"https://api.github.com/repos/nevill/zongji/subscribers","subscription_url":"https://api.github.com/repos/nevill/zongji/subscription","commits_url":"https://api.github.com/repos/nevill/zongji/commits{/sha}","git_commits_url":"https://api.github.com/repos/nevill/zongji/git/commits{/sha}","comments_url":"https://api.github.com/repos/nevill/zongji/comments{/number}","issue_comment_url":"https://api.github.com/repos/nevill/zongji/issues/comments{/number}","contents_url":"https://api.github.com/repos/nevill/zongji/contents/{+path}","compare_url":"https://api.github.com/repos/nevill/zongji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nevill/zongji/merges","archive_url":"https://api.github.com/repos/nevill/zongji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nevill/zongji/downloads","issues_url":"https://api.github.com/repos/nevill/zongji/issues{/number}","pulls_url":"https://api.github.com/repos/nevill/zongji/pulls{/number}","milestones_url":"https://api.github.com/repos/nevill/zongji/milestones{/number}","notifications_url":"https://api.github.com/repos/nevill/zongji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nevill/zongji/labels{/name}","releases_url":"https://api.github.com/repos/nevill/zongji/releases{/id}","created_at":"2013-11-25T02:00:15Z","updated_at":"2015-09-16T10:17:14Z","pushed_at":"2015-09-18T22:34:16Z","git_url":"git://github.com/nevill/zongji.git","ssh_url":"git@github.com:nevill/zongji.git","clone_url":"https://github.com/nevill/zongji.git","svn_url":"https://github.com/nevill/zongji","homepage":null,"size":581,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nevill/zongji/pulls/19"},"html":{"href":"https://github.com/nevill/zongji/pull/19"},"issue":{"href":"https://api.github.com/repos/nevill/zongji/issues/19"},"comments":{"href":"https://api.github.com/repos/nevill/zongji/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/nevill/zongji/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/nevill/zongji/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nevill/zongji/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/nevill/zongji/statuses/2422081d621ca23dcdcaba639e5fcb8d2fc6cbdc"}}}}