{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/39829014","id":39829014,"diff_hunk":"@@ -316,6 +316,18 @@ class GroundwaterFlowProcess : public Process\n         delete _mesh_subset_all_nodes;\n     }\n \n+    /// Explicitly release memory of global vector, matrix and linear solvers\n+    /// for MPI based parallel computing\n+    void releaseEquationMemory()\n+    {\n+    // #ifdef USE_PETSC\n+    //     delete _A.release();","path":"ProcessLib/GroundwaterFlowProcess.h","position":9,"original_position":9,"commit_id":"2d4bac16459008d18b5d2d085c335a710ed814b9","original_commit_id":"2d4bac16459008d18b5d2d085c335a710ed814b9","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"If `releaseEquationMemory()` is called before the process is destroyed, then maybe these delete statements should stay, such that memory will really be released. Otherwise: why don't you remove these lines?","created_at":"2015-09-18T07:06:28Z","updated_at":"2015-09-18T07:06:28Z","html_url":"https://github.com/ufz/ogs/pull/837#discussion_r39829014","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/837","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/39829014"},"html":{"href":"https://github.com/ufz/ogs/pull/837#discussion_r39829014"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/837"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/837","id":45353066,"html_url":"https://github.com/ufz/ogs/pull/837","diff_url":"https://github.com/ufz/ogs/pull/837.diff","patch_url":"https://github.com/ufz/ogs/pull/837.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/837","number":837,"state":"open","locked":false,"title":"Fix PETSc compilation","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"Fixing three issues here:\r\n - The findPetsc.cmake could not find my petsc-3.6.1 on archlinux, so the first commit is fixing this for me. Does it work for you?\r\n - The code did not compile, because releaseEquationMemory() in the GWFProcess does not exist. There is a vivid discussion how to pack this into OO structure (like dtor), but the code is not yet available. Just adding a dummy here (based on https://github.com/ufz/ogs/pull/580)\r\n - The tests for GWF are missing (in OGS_USE_PETSC configuration); so simply add them. Of course  the mpi ctest will not succeed, but it takes some code out of the https://github.com/ufz/ogs/pull/580 PR.\r\n\r\n@wenqing Could you please upload the 94783db hash to our ogs6-data place?","created_at":"2015-09-17T23:08:34Z","updated_at":"2015-09-18T07:06:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aa5761cd604bf0489741bb5194f9aafab6db5e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/837/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/837/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/837/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/2d4bac16459008d18b5d2d085c335a710ed814b9","head":{"label":"endJunction:PetscReleaseEquationMemory","ref":"PetscReleaseEquationMemory","sha":"2d4bac16459008d18b5d2d085c335a710ed814b9","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"repo":{"id":6429859,"name":"ogs","full_name":"endJunction/ogs","owner":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endJunction/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/endJunction/ogs","forks_url":"https://api.github.com/repos/endJunction/ogs/forks","keys_url":"https://api.github.com/repos/endJunction/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endJunction/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endJunction/ogs/teams","hooks_url":"https://api.github.com/repos/endJunction/ogs/hooks","issue_events_url":"https://api.github.com/repos/endJunction/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/endJunction/ogs/events","assignees_url":"https://api.github.com/repos/endJunction/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/endJunction/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/endJunction/ogs/tags","blobs_url":"https://api.github.com/repos/endJunction/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endJunction/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endJunction/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/endJunction/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endJunction/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/endJunction/ogs/languages","stargazers_url":"https://api.github.com/repos/endJunction/ogs/stargazers","contributors_url":"https://api.github.com/repos/endJunction/ogs/contributors","subscribers_url":"https://api.github.com/repos/endJunction/ogs/subscribers","subscription_url":"https://api.github.com/repos/endJunction/ogs/subscription","commits_url":"https://api.github.com/repos/endJunction/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/endJunction/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/endJunction/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/endJunction/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/endJunction/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/endJunction/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endJunction/ogs/merges","archive_url":"https://api.github.com/repos/endJunction/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endJunction/ogs/downloads","issues_url":"https://api.github.com/repos/endJunction/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/endJunction/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/endJunction/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/endJunction/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endJunction/ogs/labels{/name}","releases_url":"https://api.github.com/repos/endJunction/ogs/releases{/id}","created_at":"2012-10-28T17:18:48Z","updated_at":"2015-05-08T12:09:05Z","pushed_at":"2015-09-17T22:52:33Z","git_url":"git://github.com/endJunction/ogs.git","ssh_url":"git@github.com:endJunction/ogs.git","clone_url":"https://github.com/endJunction/ogs.git","svn_url":"https://github.com/endJunction/ogs","homepage":"www.opengeosys.net","size":13380,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"a8b23d256c854b3ca5400d60e0ee3c8e02b33e1c","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-07-31T12:46:58Z","pushed_at":"2015-09-17T23:08:35Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":16772,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":57,"forks":36,"open_issues":57,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/837"},"html":{"href":"https://github.com/ufz/ogs/pull/837"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/837"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/2d4bac16459008d18b5d2d085c335a710ed814b9"}}}}