{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/2655","labels_url":"https://api.github.com/repos/minetest/minetest/issues/2655/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2655/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/2655/events","html_url":"https://github.com/minetest/minetest/pull/2655","id":71148529,"number":2655,"title":"Clean up mod profiler","user":{"login":"ShadowNinja","id":3399154,"avatar_url":"https://avatars.githubusercontent.com/u/3399154?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowNinja","html_url":"https://github.com/ShadowNinja","followers_url":"https://api.github.com/users/ShadowNinja/followers","following_url":"https://api.github.com/users/ShadowNinja/following{/other_user}","gists_url":"https://api.github.com/users/ShadowNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowNinja/subscriptions","organizations_url":"https://api.github.com/users/ShadowNinja/orgs","repos_url":"https://api.github.com/users/ShadowNinja/repos","events_url":"https://api.github.com/users/ShadowNinja/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowNinja/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Script%20API","name":"@ Script API","color":"009800"},{"url":"https://api.github.com/repos/minetest/minetest/labels/bug","name":"bug","color":"ff5050"},{"url":"https://api.github.com/repos/minetest/minetest/labels/Low%20priority","name":"Low priority","color":"fbca04"},{"url":"https://api.github.com/repos/minetest/minetest/labels/maintenance","name":"maintenance","color":"009870"},{"url":"https://api.github.com/repos/minetest/minetest/labels/won't%20add","name":"won't add","color":"bb88bb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-27T01:38:31Z","updated_at":"2015-10-15T05:23:35Z","closed_at":"2015-10-15T05:23:35Z","pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2655","html_url":"https://github.com/minetest/minetest/pull/2655","diff_url":"https://github.com/minetest/minetest/pull/2655.diff","patch_url":"https://github.com/minetest/minetest/pull/2655.patch"},"body":"  * Fix wrappers only supporting 10 return values (used to use `local r0, r1, r2, r3 [...] = callback()`).\r\n  * Fix looking up the same value in a hash table many, many, many times; cache it.\r\n    This should improve speed pretty substantially.\r\n  * Reduce duplication through local functions.\r\n  * Use closures instead of storing functions in global lookup tables.\r\n  * `total` and `builtin` are valid mod names, don't blow up if someone uses them.\r\n  * Improve table logging format (it's more precise now).\r\n  * Rename `save_mod_profile` to `dump_mod_profile` (it sends the data to the log, which isn't necessarily saved persistently).\r\n  * Fix code style.\r\n\r\nNote: This somewhat depends on #2628 (it uses the special `none` log level, which was `info` in previous versions).  It could be changed to use `minetest.debug` or similar though.\r\n"},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/148284894","html_url":"https://github.com/minetest/minetest/pull/2655#issuecomment-148284894","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2655","id":148284894,"user":{"login":"kwolekr","id":630595,"avatar_url":"https://avatars.githubusercontent.com/u/630595?v=3","gravatar_id":"","url":"https://api.github.com/users/kwolekr","html_url":"https://github.com/kwolekr","followers_url":"https://api.github.com/users/kwolekr/followers","following_url":"https://api.github.com/users/kwolekr/following{/other_user}","gists_url":"https://api.github.com/users/kwolekr/gists{/gist_id}","starred_url":"https://api.github.com/users/kwolekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwolekr/subscriptions","organizations_url":"https://api.github.com/users/kwolekr/orgs","repos_url":"https://api.github.com/users/kwolekr/repos","events_url":"https://api.github.com/users/kwolekr/events{/privacy}","received_events_url":"https://api.github.com/users/kwolekr/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T05:23:35Z","updated_at":"2015-10-15T05:23:35Z","body":"Closing this PR for now as we are proceeding with replacing the current profiler."}}