{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/36387005","id":36387005,"diff_hunk":"@@ -114,6 +115,69 @@ def test_xlint_fails(self):\n         err_cnt = perform_xlint(TEST_DATA_DIR, ['toy'])\n         self.assertGreater(err_cnt, 0)\n \n+    def test_invalid_asset_overwrite(self):\n+        \"\"\"\n+        Tests that an asset with invalid displayname can be overwritten if multiple assets have same displayname.\n+        It Verifies that:\n+            During import, '/' in displayname of an asset are replaced with underscores '_'.","path":"cms/djangoapps/contentstore/tests/test_contentstore.py","position":null,"original_position":16,"commit_id":"f3fe9a67bf3641155f4ef7d82d0670bfa2ad48e2","original_commit_id":"8eba5062602ab808c345e407386d9edda969ab56","user":{"login":"muzaffaryousaf","id":2994509,"avatar_url":"https://avatars.githubusercontent.com/u/2994509?v=3","gravatar_id":"","url":"https://api.github.com/users/muzaffaryousaf","html_url":"https://github.com/muzaffaryousaf","followers_url":"https://api.github.com/users/muzaffaryousaf/followers","following_url":"https://api.github.com/users/muzaffaryousaf/following{/other_user}","gists_url":"https://api.github.com/users/muzaffaryousaf/gists{/gist_id}","starred_url":"https://api.github.com/users/muzaffaryousaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muzaffaryousaf/subscriptions","organizations_url":"https://api.github.com/users/muzaffaryousaf/orgs","repos_url":"https://api.github.com/users/muzaffaryousaf/repos","events_url":"https://api.github.com/users/muzaffaryousaf/events{/privacy}","received_events_url":"https://api.github.com/users/muzaffaryousaf/received_events","type":"User","site_admin":false},"body":"Yup.","created_at":"2015-08-06T07:18:12Z","updated_at":"2015-08-06T07:18:12Z","html_url":"https://github.com/edx/edx-platform/pull/8871#discussion_r36387005","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/8871","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/36387005"},"html":{"href":"https://github.com/edx/edx-platform/pull/8871#discussion_r36387005"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8871"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8871","id":39658256,"html_url":"https://github.com/edx/edx-platform/pull/8871","diff_url":"https://github.com/edx/edx-platform/pull/8871.diff","patch_url":"https://github.com/edx/edx-platform/pull/8871.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8871","number":8871,"state":"open","locked":false,"title":"Slashes in Asset Displayname cause `export` to fail","user":{"login":"awaisdar001","id":4252738,"avatar_url":"https://avatars.githubusercontent.com/u/4252738?v=3","gravatar_id":"","url":"https://api.github.com/users/awaisdar001","html_url":"https://github.com/awaisdar001","followers_url":"https://api.github.com/users/awaisdar001/followers","following_url":"https://api.github.com/users/awaisdar001/following{/other_user}","gists_url":"https://api.github.com/users/awaisdar001/gists{/gist_id}","starred_url":"https://api.github.com/users/awaisdar001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awaisdar001/subscriptions","organizations_url":"https://api.github.com/users/awaisdar001/orgs","repos_url":"https://api.github.com/users/awaisdar001/repos","events_url":"https://api.github.com/users/awaisdar001/events{/privacy}","received_events_url":"https://api.github.com/users/awaisdar001/received_events","type":"User","site_admin":false},"body":"Assets which have `/` in the displayname i.e. `foo/foobar/foo.srt`, they cause export to fail, as `displayname` is used to create new files in export. \r\n\r\nReference\r\n-\r\n* [common/lib/xmodule/xmodule/modulestore/xml_importer.py#L116-L119](https://github.com/edx/edx-platform/blob/eb70f2303c9287e16f8a4b5e1be54ad88299ffc1/common/lib/xmodule/xmodule/modulestore/xml_importer.py#L116-L119)\r\n* [common/lib/xmodule/xmodule/contentstore/mongo.py#L119-L142](https://github.com/edx/edx-platform/blob/93faba006c627c921a9b12efe47d64f342cd5e06/common/lib/xmodule/xmodule/contentstore/mongo.py#L119-L142)\r\n\r\nFixed replacing the slashes `/` with underscores `_` . Also wrote a unit test to verify the behavior. \r\n\r\nTo Test\r\n-\r\n1. Go to https://studio.edx.org/export/UPValenciaX/TE201x/2T2015 \r\n2. Export course \r\n3. Error occurs\r\n\r\nJira\r\n-\r\n[Unable to export UPValenciaX course from studio.edx.org - TNL-2669](https://openedx.atlassian.net/browse/TNL-2669)","created_at":"2015-07-10T07:19:20Z","updated_at":"2015-08-06T07:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e57c3d9f7543a58f241a16f44a460271b5844477","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/8871/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/8871/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8871/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/f3fe9a67bf3641155f4ef7d82d0670bfa2ad48e2","head":{"label":"edx:aj/tnl2669-invalid-display-name-export-not-working","ref":"aj/tnl2669-invalid-display-name-export-not-working","sha":"f3fe9a67bf3641155f4ef7d82d0670bfa2ad48e2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-08-05T18:44:31Z","pushed_at":"2015-08-06T06:42:23Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2078584,"stargazers_count":2064,"watchers_count":2064,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1208,"mirror_url":null,"open_issues_count":148,"forks":1208,"open_issues":148,"watchers":2064,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"4c9b66376a6235f1a7dafbb03a8487e6b95df780","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-08-05T18:44:31Z","pushed_at":"2015-08-06T06:42:23Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2078584,"stargazers_count":2064,"watchers_count":2064,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1208,"mirror_url":null,"open_issues_count":148,"forks":1208,"open_issues":148,"watchers":2064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8871"},"html":{"href":"https://github.com/edx/edx-platform/pull/8871"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8871"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8871/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8871/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8871/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/f3fe9a67bf3641155f4ef7d82d0670bfa2ad48e2"}}}}