{"action":"created","comment":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/comments/33820894","id":33820894,"diff_hunk":"@@ -37,15 +36,17 @@\n import brooklyn.event.basic.BasicConfigKey;\n import brooklyn.event.basic.Sensors;\n import brooklyn.util.flags.SetFromFlag;\n-\n-import com.google.common.reflect.TypeToken;\n+import io.brooklyn.ambari.agent.AmbariAgent;\n+import io.brooklyn.ambari.server.AmbariServer;\n \n @Catalog(name = \"Ambari Cluster\", description = \"Ambari Cluster: Made up of one or more Ambari Server and One or more Ambari Agents\")\n @ImplementedBy(AmbariClusterImpl.class)\n public interface AmbariCluster extends Entity, Startable {\n \n     @SetFromFlag(\"initialSize\")\n-    ConfigKey<Integer> INITIAL_SIZE = ConfigKeys.newConfigKeyWithDefault(Cluster.INITIAL_SIZE, 5);\n+    ConfigKey<Integer> INITIAL_SIZE = ConfigKeys.newConfigKeyWithDefault(Cluster.INITIAL_SIZE, 0);\n+\n+    AttributeSensor<Integer> EXPECTED_AGENTS = Sensors.newIntegerSensor(\"ambaricluster.expectedservers\");","path":"ambari/src/main/java/io/brooklyn/ambari/AmbariCluster.java","position":31,"original_position":31,"commit_id":"07fe276f5a884a679be55b91081a120754983d09","original_commit_id":"07fe276f5a884a679be55b91081a120754983d09","user":{"login":"sjcorbett","id":837527,"avatar_url":"https://avatars.githubusercontent.com/u/837527?v=3","gravatar_id":"","url":"https://api.github.com/users/sjcorbett","html_url":"https://github.com/sjcorbett","followers_url":"https://api.github.com/users/sjcorbett/followers","following_url":"https://api.github.com/users/sjcorbett/following{/other_user}","gists_url":"https://api.github.com/users/sjcorbett/gists{/gist_id}","starred_url":"https://api.github.com/users/sjcorbett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjcorbett/subscriptions","organizations_url":"https://api.github.com/users/sjcorbett/orgs","repos_url":"https://api.github.com/users/sjcorbett/repos","events_url":"https://api.github.com/users/sjcorbett/events{/privacy}","received_events_url":"https://api.github.com/users/sjcorbett/received_events","type":"User","site_admin":false},"body":"Generally prefer to give these things descriptions, if only to make it easier to the next person to come along what its use it.","created_at":"2015-07-02T20:45:06Z","updated_at":"2015-07-02T20:45:06Z","html_url":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13#discussion_r33820894","pull_request_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/comments/33820894"},"html":{"href":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13#discussion_r33820894"},"pull_request":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13","id":39084973,"html_url":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13","diff_url":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13.diff","patch_url":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13.patch","issue_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/13","number":13,"state":"open","locked":false,"title":"Feature/customizable hdp stack","user":{"login":"duncangrant","id":770352,"avatar_url":"https://avatars.githubusercontent.com/u/770352?v=3","gravatar_id":"","url":"https://api.github.com/users/duncangrant","html_url":"https://github.com/duncangrant","followers_url":"https://api.github.com/users/duncangrant/followers","following_url":"https://api.github.com/users/duncangrant/following{/other_user}","gists_url":"https://api.github.com/users/duncangrant/gists{/gist_id}","starred_url":"https://api.github.com/users/duncangrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncangrant/subscriptions","organizations_url":"https://api.github.com/users/duncangrant/orgs","repos_url":"https://api.github.com/users/duncangrant/repos","events_url":"https://api.github.com/users/duncangrant/events{/privacy}","received_events_url":"https://api.github.com/users/duncangrant/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-02T13:56:00Z","updated_at":"2015-07-02T20:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82152c4a73c54711f2c82961b10402a709f6786b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13/commits","review_comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13/comments","review_comment_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/13/comments","statuses_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/statuses/07fe276f5a884a679be55b91081a120754983d09","head":{"label":"brooklyncentral:feature/customizable-hdp-stack","ref":"feature/customizable-hdp-stack","sha":"07fe276f5a884a679be55b91081a120754983d09","user":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?v=3","gravatar_id":"","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"repo":{"id":29964541,"name":"brooklyn-ambari","full_name":"brooklyncentral/brooklyn-ambari","owner":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?v=3","gravatar_id":"","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brooklyncentral/brooklyn-ambari","description":"Brooklyn integration for Apache Ambari","fork":false,"url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari","forks_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/forks","keys_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/teams","hooks_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/hooks","issue_events_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/events{/number}","events_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/events","assignees_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/assignees{/user}","branches_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/branches{/branch}","tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/tags","blobs_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/refs{/sha}","trees_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/statuses/{sha}","languages_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/languages","stargazers_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/stargazers","contributors_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/contributors","subscribers_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/subscribers","subscription_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/subscription","commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/commits{/sha}","git_commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/commits{/sha}","comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/comments{/number}","issue_comment_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/comments{/number}","contents_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/contents/{+path}","compare_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/merges","archive_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/downloads","issues_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues{/number}","pulls_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls{/number}","milestones_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/milestones{/number}","notifications_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/labels{/name}","releases_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/releases{/id}","created_at":"2015-01-28T11:28:48Z","updated_at":"2015-06-25T11:46:10Z","pushed_at":"2015-07-02T14:48:42Z","git_url":"git://github.com/brooklyncentral/brooklyn-ambari.git","ssh_url":"git@github.com:brooklyncentral/brooklyn-ambari.git","clone_url":"https://github.com/brooklyncentral/brooklyn-ambari.git","svn_url":"https://github.com/brooklyncentral/brooklyn-ambari","homepage":null,"size":10417,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"brooklyncentral:master","ref":"master","sha":"77a80c1e8b018da80f7c48f6d6f6bc463e57dc62","user":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?v=3","gravatar_id":"","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"repo":{"id":29964541,"name":"brooklyn-ambari","full_name":"brooklyncentral/brooklyn-ambari","owner":{"login":"brooklyncentral","id":1587357,"avatar_url":"https://avatars.githubusercontent.com/u/1587357?v=3","gravatar_id":"","url":"https://api.github.com/users/brooklyncentral","html_url":"https://github.com/brooklyncentral","followers_url":"https://api.github.com/users/brooklyncentral/followers","following_url":"https://api.github.com/users/brooklyncentral/following{/other_user}","gists_url":"https://api.github.com/users/brooklyncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/brooklyncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooklyncentral/subscriptions","organizations_url":"https://api.github.com/users/brooklyncentral/orgs","repos_url":"https://api.github.com/users/brooklyncentral/repos","events_url":"https://api.github.com/users/brooklyncentral/events{/privacy}","received_events_url":"https://api.github.com/users/brooklyncentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brooklyncentral/brooklyn-ambari","description":"Brooklyn integration for Apache Ambari","fork":false,"url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari","forks_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/forks","keys_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/teams","hooks_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/hooks","issue_events_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/events{/number}","events_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/events","assignees_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/assignees{/user}","branches_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/branches{/branch}","tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/tags","blobs_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/refs{/sha}","trees_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/statuses/{sha}","languages_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/languages","stargazers_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/stargazers","contributors_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/contributors","subscribers_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/subscribers","subscription_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/subscription","commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/commits{/sha}","git_commits_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/git/commits{/sha}","comments_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/comments{/number}","issue_comment_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/comments{/number}","contents_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/contents/{+path}","compare_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/merges","archive_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/downloads","issues_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues{/number}","pulls_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls{/number}","milestones_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/milestones{/number}","notifications_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/labels{/name}","releases_url":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/releases{/id}","created_at":"2015-01-28T11:28:48Z","updated_at":"2015-06-25T11:46:10Z","pushed_at":"2015-07-02T14:48:42Z","git_url":"git://github.com/brooklyncentral/brooklyn-ambari.git","ssh_url":"git@github.com:brooklyncentral/brooklyn-ambari.git","clone_url":"https://github.com/brooklyncentral/brooklyn-ambari.git","svn_url":"https://github.com/brooklyncentral/brooklyn-ambari","homepage":null,"size":10417,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13"},"html":{"href":"https://github.com/brooklyncentral/brooklyn-ambari/pull/13"},"issue":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/13"},"comments":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn-ambari/statuses/07fe276f5a884a679be55b91081a120754983d09"}}}}