{"action":"created","comment":{"url":"https://api.github.com/repos/jruby/jruby/pulls/comments/27354941","id":27354941,"diff_hunk":"@@ -423,29 +423,71 @@ public IndexSetNode(IndexSetNode prev) {\n             super(prev);\n             writeNode = prev.writeNode;\n             readSliceNode = prev.readSliceNode;\n-            concatNode = prev.concatNode;\n             popNode = prev.popNode;\n+            toIntNode = prev.toIntNode;\n         }\n \n         @Specialization\n         public Object set(VirtualFrame frame, RubyArray array, int index, Object value, UndefinedPlaceholder unused) {\n+            final int normalizedIndex = array.normalizeIndex(index);\n+            if (normalizedIndex < 0) {\n+                CompilerDirectives.transferToInterpreter();\n+                String errMessage = \"index \" + index + \" too small for array; minimum: \" + Integer.toString(-array.getSize());","path":"truffle/src/main/java/org/jruby/truffle/nodes/core/ArrayNodes.java","position":24,"original_position":24,"commit_id":"35add5a53adbfaeb202a8fc6b480fcebd85be4e2","original_commit_id":"35add5a53adbfaeb202a8fc6b480fcebd85be4e2","user":{"login":"chrisseaton","id":341094,"avatar_url":"https://avatars.githubusercontent.com/u/341094?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisseaton","html_url":"https://github.com/chrisseaton","followers_url":"https://api.github.com/users/chrisseaton/followers","following_url":"https://api.github.com/users/chrisseaton/following{/other_user}","gists_url":"https://api.github.com/users/chrisseaton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisseaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisseaton/subscriptions","organizations_url":"https://api.github.com/users/chrisseaton/orgs","repos_url":"https://api.github.com/users/chrisseaton/repos","events_url":"https://api.github.com/users/chrisseaton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisseaton/received_events","type":"User","site_admin":false},"body":"This is what MRI says, right?","created_at":"2015-03-29T14:41:59Z","updated_at":"2015-03-29T14:41:59Z","html_url":"https://github.com/jruby/jruby/pull/2775#discussion_r27354941","pull_request_url":"https://api.github.com/repos/jruby/jruby/pulls/2775","_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments/27354941"},"html":{"href":"https://github.com/jruby/jruby/pull/2775#discussion_r27354941"},"pull_request":{"href":"https://api.github.com/repos/jruby/jruby/pulls/2775"}}},"pull_request":{"url":"https://api.github.com/repos/jruby/jruby/pulls/2775","id":32182525,"html_url":"https://github.com/jruby/jruby/pull/2775","diff_url":"https://github.com/jruby/jruby/pull/2775.diff","patch_url":"https://github.com/jruby/jruby/pull/2775.patch","issue_url":"https://api.github.com/repos/jruby/jruby/issues/2775","number":2775,"state":"open","locked":false,"title":"[Truffle] Implementing more Array#[]=.","user":{"login":"bjfish","id":110023,"avatar_url":"https://avatars.githubusercontent.com/u/110023?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfish","html_url":"https://github.com/bjfish","followers_url":"https://api.github.com/users/bjfish/followers","following_url":"https://api.github.com/users/bjfish/following{/other_user}","gists_url":"https://api.github.com/users/bjfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfish/subscriptions","organizations_url":"https://api.github.com/users/bjfish/orgs","repos_url":"https://api.github.com/users/bjfish/repos","events_url":"https://api.github.com/users/bjfish/events{/privacy}","received_events_url":"https://api.github.com/users/bjfish/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-29T14:41:06Z","updated_at":"2015-03-29T14:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b6d0ffca546990db0b7030bcf5712295aa92bad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jruby/jruby/pulls/2775/commits","review_comments_url":"https://api.github.com/repos/jruby/jruby/pulls/2775/comments","review_comment_url":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/2775/comments","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/35add5a53adbfaeb202a8fc6b480fcebd85be4e2","head":{"label":"bjfish:truffle_array_element_set_v2","ref":"truffle_array_element_set_v2","sha":"35add5a53adbfaeb202a8fc6b480fcebd85be4e2","user":{"login":"bjfish","id":110023,"avatar_url":"https://avatars.githubusercontent.com/u/110023?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfish","html_url":"https://github.com/bjfish","followers_url":"https://api.github.com/users/bjfish/followers","following_url":"https://api.github.com/users/bjfish/following{/other_user}","gists_url":"https://api.github.com/users/bjfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfish/subscriptions","organizations_url":"https://api.github.com/users/bjfish/orgs","repos_url":"https://api.github.com/users/bjfish/repos","events_url":"https://api.github.com/users/bjfish/events{/privacy}","received_events_url":"https://api.github.com/users/bjfish/received_events","type":"User","site_admin":false},"repo":{"id":31230576,"name":"jruby","full_name":"bjfish/jruby","owner":{"login":"bjfish","id":110023,"avatar_url":"https://avatars.githubusercontent.com/u/110023?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfish","html_url":"https://github.com/bjfish","followers_url":"https://api.github.com/users/bjfish/followers","following_url":"https://api.github.com/users/bjfish/following{/other_user}","gists_url":"https://api.github.com/users/bjfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfish/subscriptions","organizations_url":"https://api.github.com/users/bjfish/orgs","repos_url":"https://api.github.com/users/bjfish/repos","events_url":"https://api.github.com/users/bjfish/events{/privacy}","received_events_url":"https://api.github.com/users/bjfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjfish/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":true,"url":"https://api.github.com/repos/bjfish/jruby","forks_url":"https://api.github.com/repos/bjfish/jruby/forks","keys_url":"https://api.github.com/repos/bjfish/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjfish/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjfish/jruby/teams","hooks_url":"https://api.github.com/repos/bjfish/jruby/hooks","issue_events_url":"https://api.github.com/repos/bjfish/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/bjfish/jruby/events","assignees_url":"https://api.github.com/repos/bjfish/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/bjfish/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/bjfish/jruby/tags","blobs_url":"https://api.github.com/repos/bjfish/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjfish/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjfish/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjfish/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjfish/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/bjfish/jruby/languages","stargazers_url":"https://api.github.com/repos/bjfish/jruby/stargazers","contributors_url":"https://api.github.com/repos/bjfish/jruby/contributors","subscribers_url":"https://api.github.com/repos/bjfish/jruby/subscribers","subscription_url":"https://api.github.com/repos/bjfish/jruby/subscription","commits_url":"https://api.github.com/repos/bjfish/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjfish/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjfish/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjfish/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjfish/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/bjfish/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjfish/jruby/merges","archive_url":"https://api.github.com/repos/bjfish/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjfish/jruby/downloads","issues_url":"https://api.github.com/repos/bjfish/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/bjfish/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/bjfish/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/bjfish/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjfish/jruby/labels{/name}","releases_url":"https://api.github.com/repos/bjfish/jruby/releases{/id}","created_at":"2015-02-23T21:23:47Z","updated_at":"2015-03-23T01:02:41Z","pushed_at":"2015-03-29T14:40:59Z","git_url":"git://github.com/bjfish/jruby.git","ssh_url":"git@github.com:bjfish/jruby.git","clone_url":"https://github.com/bjfish/jruby.git","svn_url":"https://github.com/bjfish/jruby","homepage":"http://www.jruby.org","size":165041,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jruby:master","ref":"master","sha":"2883be50530ad058377e524cb7115f27e559c40f","user":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"repo":{"id":168370,"name":"jruby","full_name":"jruby/jruby","owner":{"login":"jruby","id":55687,"avatar_url":"https://avatars.githubusercontent.com/u/55687?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby","html_url":"https://github.com/jruby","followers_url":"https://api.github.com/users/jruby/followers","following_url":"https://api.github.com/users/jruby/following{/other_user}","gists_url":"https://api.github.com/users/jruby/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby/subscriptions","organizations_url":"https://api.github.com/users/jruby/orgs","repos_url":"https://api.github.com/users/jruby/repos","events_url":"https://api.github.com/users/jruby/events{/privacy}","received_events_url":"https://api.github.com/users/jruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jruby/jruby","description":"JRuby, an implementation of Ruby on the JVM","fork":false,"url":"https://api.github.com/repos/jruby/jruby","forks_url":"https://api.github.com/repos/jruby/jruby/forks","keys_url":"https://api.github.com/repos/jruby/jruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby/jruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby/jruby/teams","hooks_url":"https://api.github.com/repos/jruby/jruby/hooks","issue_events_url":"https://api.github.com/repos/jruby/jruby/issues/events{/number}","events_url":"https://api.github.com/repos/jruby/jruby/events","assignees_url":"https://api.github.com/repos/jruby/jruby/assignees{/user}","branches_url":"https://api.github.com/repos/jruby/jruby/branches{/branch}","tags_url":"https://api.github.com/repos/jruby/jruby/tags","blobs_url":"https://api.github.com/repos/jruby/jruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby/jruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby/jruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby/jruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby/jruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby/jruby/languages","stargazers_url":"https://api.github.com/repos/jruby/jruby/stargazers","contributors_url":"https://api.github.com/repos/jruby/jruby/contributors","subscribers_url":"https://api.github.com/repos/jruby/jruby/subscribers","subscription_url":"https://api.github.com/repos/jruby/jruby/subscription","commits_url":"https://api.github.com/repos/jruby/jruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby/jruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby/jruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby/jruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby/jruby/contents/{+path}","compare_url":"https://api.github.com/repos/jruby/jruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby/jruby/merges","archive_url":"https://api.github.com/repos/jruby/jruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby/jruby/downloads","issues_url":"https://api.github.com/repos/jruby/jruby/issues{/number}","pulls_url":"https://api.github.com/repos/jruby/jruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby/jruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby/jruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby/jruby/labels{/name}","releases_url":"https://api.github.com/repos/jruby/jruby/releases{/id}","created_at":"2009-04-05T03:54:35Z","updated_at":"2015-03-28T22:02:54Z","pushed_at":"2015-03-29T14:41:06Z","git_url":"git://github.com/jruby/jruby.git","ssh_url":"git@github.com:jruby/jruby.git","clone_url":"https://github.com/jruby/jruby.git","svn_url":"https://github.com/jruby/jruby","homepage":"http://www.jruby.org","size":332816,"stargazers_count":2066,"watchers_count":2066,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"open_issues_count":743,"forks":561,"open_issues":743,"watchers":2066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby/jruby/pulls/2775"},"html":{"href":"https://github.com/jruby/jruby/pull/2775"},"issue":{"href":"https://api.github.com/repos/jruby/jruby/issues/2775"},"comments":{"href":"https://api.github.com/repos/jruby/jruby/issues/2775/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby/jruby/pulls/2775/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby/jruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jruby/jruby/pulls/2775/commits"},"statuses":{"href":"https://api.github.com/repos/jruby/jruby/statuses/35add5a53adbfaeb202a8fc6b480fcebd85be4e2"}}}}