{"action":"closed","number":2528,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2528","id":43224156,"html_url":"https://github.com/nodejs/node/pull/2528","diff_url":"https://github.com/nodejs/node/pull/2528.diff","patch_url":"https://github.com/nodejs/node/pull/2528.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/2528","number":2528,"state":"closed","locked":false,"title":"tty: Remove deprecated setRawMode wrapper","user":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"body":"This function should be removed, it was deprecated many years ago.  The documentation says its deprecated (https://nodejs.org/api/tty.html) as well as the code https://github.com/joyent/node/blob/v0.10.40-release/lib/tty.js#L35-L40\r\n\r\nhttps://github.com/joyent/node/blob/v0.8.19-release/lib/tty.js#L34-L40","created_at":"2015-08-24T21:28:53Z","updated_at":"2015-11-18T21:18:20Z","closed_at":"2015-11-18T21:18:20Z","merged_at":null,"merge_commit_sha":"06785a856851aa26589b96132695b5c67191c126","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/2528/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/2528/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2528/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b8c4bcd83597af3c64696edc4664a77f4086813d","head":{"label":"geek:deprecate","ref":"deprecate","sha":"b8c4bcd83597af3c64696edc4664a77f4086813d","user":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"repo":{"id":40854432,"name":"node","full_name":"geek/node","owner":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geek/node","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/geek/node","forks_url":"https://api.github.com/repos/geek/node/forks","keys_url":"https://api.github.com/repos/geek/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geek/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geek/node/teams","hooks_url":"https://api.github.com/repos/geek/node/hooks","issue_events_url":"https://api.github.com/repos/geek/node/issues/events{/number}","events_url":"https://api.github.com/repos/geek/node/events","assignees_url":"https://api.github.com/repos/geek/node/assignees{/user}","branches_url":"https://api.github.com/repos/geek/node/branches{/branch}","tags_url":"https://api.github.com/repos/geek/node/tags","blobs_url":"https://api.github.com/repos/geek/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geek/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geek/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/geek/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geek/node/statuses/{sha}","languages_url":"https://api.github.com/repos/geek/node/languages","stargazers_url":"https://api.github.com/repos/geek/node/stargazers","contributors_url":"https://api.github.com/repos/geek/node/contributors","subscribers_url":"https://api.github.com/repos/geek/node/subscribers","subscription_url":"https://api.github.com/repos/geek/node/subscription","commits_url":"https://api.github.com/repos/geek/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/geek/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/geek/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/geek/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/geek/node/contents/{+path}","compare_url":"https://api.github.com/repos/geek/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geek/node/merges","archive_url":"https://api.github.com/repos/geek/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geek/node/downloads","issues_url":"https://api.github.com/repos/geek/node/issues{/number}","pulls_url":"https://api.github.com/repos/geek/node/pulls{/number}","milestones_url":"https://api.github.com/repos/geek/node/milestones{/number}","notifications_url":"https://api.github.com/repos/geek/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geek/node/labels{/name}","releases_url":"https://api.github.com/repos/geek/node/releases{/id}","created_at":"2015-08-17T01:47:53Z","updated_at":"2015-08-17T01:47:59Z","pushed_at":"2015-08-24T21:53:59Z","git_url":"git://github.com/geek/node.git","ssh_url":"git@github.com:geek/node.git","clone_url":"https://github.com/geek/node.git","svn_url":"https://github.com/geek/node","homepage":"https://iojs.org","size":142084,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e4e5b13efd118346509b75c1f0d6a913981786f0","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-11-18T21:11:42Z","pushed_at":"2015-11-18T21:17:55Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":167552,"stargazers_count":17456,"watchers_count":17456,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1805,"mirror_url":null,"open_issues_count":557,"forks":1805,"open_issues":557,"watchers":17456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/2528"},"html":{"href":"https://github.com/nodejs/node/pull/2528"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/2528"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/2528/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/2528/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/2528/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b8c4bcd83597af3c64696edc4664a77f4086813d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"commits":1,"additions":0,"deletions":15,"changed_files":2}}