{"action":"closed","number":5369,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369","id":46126855,"html_url":"https://github.com/DynamoDS/Dynamo/pull/5369","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5369.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5369.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5369","number":5369,"state":"closed","locked":false,"title":"Port ds class test5","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nPorting/Rewriting DS defined classes to remove the DS class and only focus on the specific test.\r\nThis is submission 5/14\r\n\r\nRefer to this top level task:\r\nhttp://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8341\r\n\r\nSee the guidlines:\r\nA test that uses a DS defined class should be re-written such that the DS defined class is removed.\r\nThis means doing one or a combination of the following:\r\n1 Write an FFI class to replace the DS defined class\r\n2 Remove the DS class if it is not necessary\r\n3 Remove verification that is unncecessary\r\n4 Rename the test appropriately if needed\r\n5 If a test is ported, modify the category from DSDefinedClass to DSDefinedClass_Ported\r\n6 If a test is NOT ported, modify the category from DSDefinedClass to DSDefinedClass_Ignored_SomeDecriptionHere\r\n7 At the end of the class porting task, the only categories left should be DSDefinedClass_Ported and DSDefinedClass_Ignored. \r\n8 There should be no regressions is these tasks. Tests that must be removed completely will be done at the end of the porting /rewriting task\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] The level of testing this PR includes is appropriate\r\n\r\n### Reviewers\r\n\r\nThis has been reviewed by @lukechurch ","created_at":"2015-09-28T07:27:08Z","updated_at":"2015-09-28T07:37:02Z","closed_at":"2015-09-28T07:37:02Z","merged_at":"2015-09-28T07:37:02Z","merge_commit_sha":"8d90144d203c3b4f706ab3e5681b42712984db7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5369/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/9b6388c60e24ac8555b3951dccba8a3a42bc790d","head":{"label":"junmendoza:PortDSClassTest5","ref":"PortDSClassTest5","sha":"9b6388c60e24ac8555b3951dccba8a3a42bc790d","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"repo":{"id":11733064,"name":"Dynamo","full_name":"junmendoza/Dynamo","owner":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junmendoza/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/junmendoza/Dynamo","forks_url":"https://api.github.com/repos/junmendoza/Dynamo/forks","keys_url":"https://api.github.com/repos/junmendoza/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junmendoza/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junmendoza/Dynamo/teams","hooks_url":"https://api.github.com/repos/junmendoza/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/junmendoza/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/junmendoza/Dynamo/events","assignees_url":"https://api.github.com/repos/junmendoza/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/junmendoza/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/junmendoza/Dynamo/tags","blobs_url":"https://api.github.com/repos/junmendoza/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junmendoza/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junmendoza/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/junmendoza/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junmendoza/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/junmendoza/Dynamo/languages","stargazers_url":"https://api.github.com/repos/junmendoza/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/junmendoza/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/junmendoza/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/junmendoza/Dynamo/subscription","commits_url":"https://api.github.com/repos/junmendoza/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/junmendoza/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/junmendoza/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/junmendoza/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/junmendoza/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/junmendoza/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junmendoza/Dynamo/merges","archive_url":"https://api.github.com/repos/junmendoza/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junmendoza/Dynamo/downloads","issues_url":"https://api.github.com/repos/junmendoza/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/junmendoza/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/junmendoza/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/junmendoza/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junmendoza/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/junmendoza/Dynamo/releases{/id}","created_at":"2013-07-29T06:47:14Z","updated_at":"2015-03-04T08:56:05Z","pushed_at":"2015-09-28T07:26:19Z","git_url":"git://github.com/junmendoza/Dynamo.git","ssh_url":"git@github.com:junmendoza/Dynamo.git","clone_url":"https://github.com/junmendoza/Dynamo.git","svn_url":"https://github.com/junmendoza/Dynamo","homepage":"http://dynamobim.org","size":864174,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"31e84c5d7ad89dd1ee20b2aa2bb2904e2d7b5555","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-09-27T06:49:06Z","pushed_at":"2015-09-28T07:37:02Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1043681,"stargazers_count":266,"watchers_count":266,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":749,"forks":202,"open_issues":749,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5369"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5369"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5369/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5369/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/9b6388c60e24ac8555b3951dccba8a3a42bc790d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":7,"additions":3162,"deletions":3916,"changed_files":8}}