{"action":"created","comment":{"url":"https://api.github.com/repos/deis/deis/pulls/comments/35923787","id":35923787,"diff_hunk":"@@ -63,6 +63,56 @@ Finally, update ``deisctl`` to the new version and reinstall:\n     enable PROXY protocol for ports 80 and 443 on the ELB, add a ``TCP 443:443`` listener, and\n     change existing targets and health checks from HTTP to TCP.\n \n+\n+Graceful Upgrade","path":"docs/managing_deis/upgrading-deis.rst","position":5,"original_position":5,"commit_id":"82bbbf1a4617c630c8805bfb5356a5e68cb16d39","original_commit_id":"82bbbf1a4617c630c8805bfb5356a5e68cb16d39","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"Should it also be noted somewhere that this won't work across major versions either?","created_at":"2015-07-30T21:33:57Z","updated_at":"2015-07-30T21:33:57Z","html_url":"https://github.com/deis/deis/pull/4099#discussion_r35923787","pull_request_url":"https://api.github.com/repos/deis/deis/pulls/4099","_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/35923787"},"html":{"href":"https://github.com/deis/deis/pull/4099#discussion_r35923787"},"pull_request":{"href":"https://api.github.com/repos/deis/deis/pulls/4099"}}},"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/4099","id":40730125,"html_url":"https://github.com/deis/deis/pull/4099","diff_url":"https://github.com/deis/deis/pull/4099.diff","patch_url":"https://github.com/deis/deis/pull/4099.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/4099","number":4099,"state":"open","locked":false,"title":"feature(deisctl) allow for graceful in-place upgrades","user":{"login":"iancoffey","id":1152225,"avatar_url":"https://avatars.githubusercontent.com/u/1152225?v=3","gravatar_id":"","url":"https://api.github.com/users/iancoffey","html_url":"https://github.com/iancoffey","followers_url":"https://api.github.com/users/iancoffey/followers","following_url":"https://api.github.com/users/iancoffey/following{/other_user}","gists_url":"https://api.github.com/users/iancoffey/gists{/gist_id}","starred_url":"https://api.github.com/users/iancoffey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancoffey/subscriptions","organizations_url":"https://api.github.com/users/iancoffey/orgs","repos_url":"https://api.github.com/users/iancoffey/repos","events_url":"https://api.github.com/users/iancoffey/events{/privacy}","received_events_url":"https://api.github.com/users/iancoffey/received_events","type":"User","site_admin":false},"body":"First pass at adding upgrade functionality to deisctl.\r\n\r\nThe whole thing needs :eyes:, but the following things especially.\r\n- [ ] The service keys are persisted by a workaround which resets them with a 30 minute TTL. Is this the best way to keep the services up while the publishers cycle?\r\n- [x] TestUpgradeTakeover fails due to the etcd stuff. If we keep that stuff in there, how should it be tested, a mocked etcd endpoint?\r\n- [x] It would be nice if the command names were better, but its the best Ive come up with so far.\r\n- [x] The docs indicate a deisctl install command that does not yet work - https://github.com/deis/deis.io/pull/114","created_at":"2015-07-23T23:39:56Z","updated_at":"2015-07-30T21:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f40f23537e7617f7b49a42b9f855cdf863a701b2","assignee":{"login":"iancoffey","id":1152225,"avatar_url":"https://avatars.githubusercontent.com/u/1152225?v=3","gravatar_id":"","url":"https://api.github.com/users/iancoffey","html_url":"https://github.com/iancoffey","followers_url":"https://api.github.com/users/iancoffey/followers","following_url":"https://api.github.com/users/iancoffey/following{/other_user}","gists_url":"https://api.github.com/users/iancoffey/gists{/gist_id}","starred_url":"https://api.github.com/users/iancoffey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancoffey/subscriptions","organizations_url":"https://api.github.com/users/iancoffey/orgs","repos_url":"https://api.github.com/users/iancoffey/repos","events_url":"https://api.github.com/users/iancoffey/events{/privacy}","received_events_url":"https://api.github.com/users/iancoffey/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/4099/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/4099/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/deis/issues/4099/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/82bbbf1a4617c630c8805bfb5356a5e68cb16d39","head":{"label":"iancoffey:updating","ref":"updating","sha":"82bbbf1a4617c630c8805bfb5356a5e68cb16d39","user":{"login":"iancoffey","id":1152225,"avatar_url":"https://avatars.githubusercontent.com/u/1152225?v=3","gravatar_id":"","url":"https://api.github.com/users/iancoffey","html_url":"https://github.com/iancoffey","followers_url":"https://api.github.com/users/iancoffey/followers","following_url":"https://api.github.com/users/iancoffey/following{/other_user}","gists_url":"https://api.github.com/users/iancoffey/gists{/gist_id}","starred_url":"https://api.github.com/users/iancoffey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancoffey/subscriptions","organizations_url":"https://api.github.com/users/iancoffey/orgs","repos_url":"https://api.github.com/users/iancoffey/repos","events_url":"https://api.github.com/users/iancoffey/events{/privacy}","received_events_url":"https://api.github.com/users/iancoffey/received_events","type":"User","site_admin":false},"repo":{"id":34410735,"name":"deis","full_name":"iancoffey/deis","owner":{"login":"iancoffey","id":1152225,"avatar_url":"https://avatars.githubusercontent.com/u/1152225?v=3","gravatar_id":"","url":"https://api.github.com/users/iancoffey","html_url":"https://github.com/iancoffey","followers_url":"https://api.github.com/users/iancoffey/followers","following_url":"https://api.github.com/users/iancoffey/following{/other_user}","gists_url":"https://api.github.com/users/iancoffey/gists{/gist_id}","starred_url":"https://api.github.com/users/iancoffey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iancoffey/subscriptions","organizations_url":"https://api.github.com/users/iancoffey/orgs","repos_url":"https://api.github.com/users/iancoffey/repos","events_url":"https://api.github.com/users/iancoffey/events{/privacy}","received_events_url":"https://api.github.com/users/iancoffey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iancoffey/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/iancoffey/deis","forks_url":"https://api.github.com/repos/iancoffey/deis/forks","keys_url":"https://api.github.com/repos/iancoffey/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iancoffey/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iancoffey/deis/teams","hooks_url":"https://api.github.com/repos/iancoffey/deis/hooks","issue_events_url":"https://api.github.com/repos/iancoffey/deis/issues/events{/number}","events_url":"https://api.github.com/repos/iancoffey/deis/events","assignees_url":"https://api.github.com/repos/iancoffey/deis/assignees{/user}","branches_url":"https://api.github.com/repos/iancoffey/deis/branches{/branch}","tags_url":"https://api.github.com/repos/iancoffey/deis/tags","blobs_url":"https://api.github.com/repos/iancoffey/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iancoffey/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iancoffey/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/iancoffey/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iancoffey/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/iancoffey/deis/languages","stargazers_url":"https://api.github.com/repos/iancoffey/deis/stargazers","contributors_url":"https://api.github.com/repos/iancoffey/deis/contributors","subscribers_url":"https://api.github.com/repos/iancoffey/deis/subscribers","subscription_url":"https://api.github.com/repos/iancoffey/deis/subscription","commits_url":"https://api.github.com/repos/iancoffey/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/iancoffey/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/iancoffey/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/iancoffey/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/iancoffey/deis/contents/{+path}","compare_url":"https://api.github.com/repos/iancoffey/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iancoffey/deis/merges","archive_url":"https://api.github.com/repos/iancoffey/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iancoffey/deis/downloads","issues_url":"https://api.github.com/repos/iancoffey/deis/issues{/number}","pulls_url":"https://api.github.com/repos/iancoffey/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/iancoffey/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/iancoffey/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iancoffey/deis/labels{/name}","releases_url":"https://api.github.com/repos/iancoffey/deis/releases{/id}","created_at":"2015-04-22T19:19:43Z","updated_at":"2015-04-22T19:19:45Z","pushed_at":"2015-07-30T19:36:36Z","git_url":"git://github.com/iancoffey/deis.git","ssh_url":"git@github.com:iancoffey/deis.git","clone_url":"https://github.com/iancoffey/deis.git","svn_url":"https://github.com/iancoffey/deis","homepage":"http://deis.io","size":17896,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"7e3c3748ba84f776c976b8a0cbbc38c7386b8d23","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2015-07-30T18:20:16Z","pushed_at":"2015-07-30T21:29:10Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":42596,"stargazers_count":4537,"watchers_count":4537,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":701,"mirror_url":null,"open_issues_count":218,"forks":701,"open_issues":218,"watchers":4537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/4099"},"html":{"href":"https://github.com/deis/deis/pull/4099"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/4099"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/4099/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/4099/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/4099/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/82bbbf1a4617c630c8805bfb5356a5e68cb16d39"}}}}