{"push_id":655516090,"size":394,"distinct_size":394,"ref":"refs/heads/master","head":"71c1a7ea7f28a4e4bf3412af228524a28226ebeb","before":"6f82613ded38eb39025aebfbc1d6846c087474e5","commits":[{"sha":"8ce42baaef314a75bb6726891774393d540e9d06","author":{"email":"dc73d0991b982a8303e713ef531a313af77e242a@gmail.com","name":"Brian Goff"},"message":"Make `docker cp` bind-mount volumes\n\nAllows `docker cp` to work seamlessly, and a lot more cleanly.\n\nSigned-off-by: Brian Goff <cpuguy83@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/8ce42baaef314a75bb6726891774393d540e9d06"},{"sha":"6f812a4ec18453dd0f46e138f7c05b1ade13f007","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"hack/make.sh: use bash internal $PWD\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/6f812a4ec18453dd0f46e138f7c05b1ade13f007"},{"sha":"23afce5f7fb575ea5fad1afc5f60b38e3e17d8b3","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"hack/make.sh: use SCRIPTDIR wherever possible\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/23afce5f7fb575ea5fad1afc5f60b38e3e17d8b3"},{"sha":"ac20568b0a62c794c0f1190703f051bd1cfac341","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"hack: quote all parameters with variable interpolation\n\nbetter safe then sorry. especially for rm\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/ac20568b0a62c794c0f1190703f051bd1cfac341"},{"sha":"4d53a1952865a3610cf2007f7075b360c5aafbef","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"hack: useless use of cat\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/4d53a1952865a3610cf2007f7075b360c5aafbef"},{"sha":"6533cb973f6bab672018148fd6a67644580cc61f","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"hack/make/test-integration-cli: introduce MAKEDIR variable\n\n- every execution of dirname costs time\n- less repeating\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/6533cb973f6bab672018148fd6a67644580cc61f"},{"sha":"d1855c6cc0cb28fed7426ee3024f147e74ac828e","author":{"email":"45b48fe41a624d9e1cc7295494b094f633d9072c@me.com","name":"Steven Taylor"},"message":"What if authConfig or factory is Null?\n\nSigned-off-by: Steven Taylor <steven.taylor@me.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/d1855c6cc0cb28fed7426ee3024f147e74ac828e"},{"sha":"73bf9b5c195170b3d71f86b285ac12e50d26ef51","author":{"email":"4511f16e942ad3568742865d09c9060c1d8bebb9@cn.fujitsu.com","name":"Ma Shimiao"},"message":"add err check before getting term\n\nSigned-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/73bf9b5c195170b3d71f86b285ac12e50d26ef51"},{"sha":"89df65be5d3ee72cd6e1b4aa53953a62f4b5d00a","author":{"email":"4071f4c772e571fcb873828579644955609c1986@gmail.com","name":"Jeff Nickoloff"},"message":"Update builder.md\n\nSingle value labels do not work in 1.6 and multi-label instructions only work when separated by non-EOL whitespace.\nI also added an example snip from the inspect output with the labels that are included in this guide.\n\nSigned-off-by: Jeff Nickoloff <jeff@allingeek.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/89df65be5d3ee72cd6e1b4aa53953a62f4b5d00a"},{"sha":"49be84842e41a612601ff9d0563ec30f138e95bc","author":{"email":"d51735f6fb3b158a0436903895ceec01381bfb9f@gmail.com","name":"Shijiang Wei"},"message":"Remove some unsupported instructions in the docs.\n\nSigned-off-by: Shijiang Wei <mountkin@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/49be84842e41a612601ff9d0563ec30f138e95bc"},{"sha":"8301dcc6d702a97feeb968ee79ae381fd8a4997a","author":{"email":"95f2b555067ad6bd31ad43ac30baaa30d97f0bea@redhat.com","name":"Jiri Popelka"},"message":"Support for Firewalld\n\nFirewalld [1] is a firewall managing daemon with D-Bus interface.\n\nWhat sort of problem are we trying to solve with this ?\n\nFirewalld internally also executes iptables/ip6tables to change firewall settings.\nIt might happen on systems where both docker and firewalld are running\nconcurrently, that both of them try to call iptables at the same time.\nThe result is that the second one fails because the first one is holding a xtables lock.\nOne workaround is to use --wait/-w option in both\ndocker & firewalld when calling iptables.\nIt's already been done in both upstreams:\nhttps://github.com/docker/docker/commit/b315c380f4acd65cc0428009702f99a266f96c59\nhttps://github.com/t-woerner/firewalld/commit/b3b451d6f8946986b8f50c8bcddeef50ed7a5f8f\nBut it'd still be better if docker used firewalld when it's running.\n\nOther problem the firewalld support would solve is that\niptables/firewalld service's restart flushes all firewall rules\npreviously added by docker.\nSee next patch for possible solution.\n\nThis patch utilizes firewalld's D-Bus interface.\nIf firewalld is running, we call direct.passthrough() [2] method instead\nof executing iptables directly.\ndirect.passthrough() takes the same arguments as iptables tool itself\nand passes them through to iptables tool.\nIt might be better to use other methods, like direct.addChain and\ndirect.addRule [3] so it'd be more intergrated with firewalld, but\nthat'd make the patch much bigger.\nIf firewalld is not running, everything works as before.\n\n[1] http://www.firewalld.org/\n[2] https://jpopelka.fedorapeople.org/firewalld/doc/firewalld.dbus.html#FirewallD1.direct.Methods.passthrough\n[3] https://jpopelka.fedorapeople.org/firewalld/doc/firewalld.dbus.html#FirewallD1.direct.Methods.addChain\n    https://jpopelka.fedorapeople.org/firewalld/doc/firewalld.dbus.html#FirewallD1.direct.Methods.addRule\n\nSigned-off-by: Jiri Popelka <jpopelka@redhat.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/8301dcc6d702a97feeb968ee79ae381fd8a4997a"},{"sha":"b052827e025267336f0d426df44ec536745821f8","author":{"email":"95f2b555067ad6bd31ad43ac30baaa30d97f0bea@redhat.com","name":"Jiri Popelka"},"message":"React to firewalld's reload/restart\n\nWhen firewalld (or iptables service) restarts/reloads,\nall previously added docker firewall rules are flushed.\n\nWith firewalld we can react to its Reloaded() [1]\nD-Bus signal and recreate the firewall rules.\nAlso when firewalld gets restarted (stopped & started)\nwe can catch the NameOwnerChanged signal [2].\nTo specify which signals we want to react to we use AddMatch [3].\n\nLibvirt has been doing this for quite a long time now.\n\nDocker changes firewall rules on basically 3 places.\n1) daemon/networkdriver/portmapper/mapper.go - port mappings\n   Portmapper fortunatelly keeps list of mapped ports,\n   so we can easily recreate firewall rules on firewalld restart/reload\n   New ReMapAll() function does that\n2) daemon/networkdriver/bridge/driver.go\n   When setting a bridge, basic firewall rules are created.\n   This is done at once during start, it's parametrized and nowhere\n   tracked so how can one know what and how to set it again when\n   there's been firewalld restart/reload ?\n   The only solution that came to my mind is using of closures [4],\n   i.e. I keep list of references to closures (anonymous functions\n   together with a referencing environment) and when there's firewalld\n   restart/reload I re-call them in the same order.\n3) links/links.go - linking containers\n   Link is added in Enable() and removed in Disable().\n   In Enable() we add a callback function, which creates the link,\n   that's OK so far.\n   It'd be ideal if we could remove the same function from\n   the list in Disable(). Unfortunatelly that's not possible AFAICT,\n   because we don't know the reference to that function\n   at that moment, so we can only add a reference to function,\n   which removes the link. That means that after creating and\n   removing a link there are 2 functions in the list,\n   one adding and one removing the link and after\n   firewalld restart/reload both are called.\n   It works, but it's far from ideal.\n\n[1] https://jpopelka.fedorapeople.org/firewalld/doc/firewalld.dbus.html#FirewallD1.Signals.Reloaded\n[2] http://dbus.freedesktop.org/doc/dbus-specification.html#bus-messages-name-owner-changed\n[3] http://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-routing-match-rules\n[4] https://en.wikipedia.org/wiki/Closure_%28computer_programming%29\n\nSigned-off-by: Jiri Popelka <jpopelka@redhat.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/b052827e025267336f0d426df44ec536745821f8"},{"sha":"379773905c7ff4db3c16e2235f831a9552b4e158","author":{"email":"95f2b555067ad6bd31ad43ac30baaa30d97f0bea@redhat.com","name":"Jiri Popelka"},"message":"Firewalld tests\n\nSigned-off-by: Jiri Popelka <jpopelka@redhat.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/379773905c7ff4db3c16e2235f831a9552b4e158"},{"sha":"9e50bf6270f426f6ef6649b1985036988b207407","author":{"email":"4efb7da3e38416208b41d8021a942884d8a9435c@docker.com","name":"Alexander Morozov"},"message":"Remove engine from trust\n\nSigned-off-by: Alexander Morozov <lk4d4@docker.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/9e50bf6270f426f6ef6649b1985036988b207407"},{"sha":"2ed4ed50be3a0379d83b9267f62c4c7f665b849f","author":{"email":"87e1f221a672a14a323e57bb65eaea19d3ed3804@sbr.pm","name":"Vincent Demeester"},"message":"Add some stdcopy_test (coverage)\n\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/2ed4ed50be3a0379d83b9267f62c4c7f665b849f"},{"sha":"29c5596176769fc99a22b1d0a78dd5ea279fec69","author":{"email":"6ccbf9d1088962d2e9c53dcfca376b2b70606669@us.ibm.com","name":"Srini Brahmaroutu"},"message":"moving integration tests to graph unit tests\nAddresses #12255\nSigned-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/29c5596176769fc99a22b1d0a78dd5ea279fec69"},{"sha":"f3d4c33213088ce3c381156760064f07da76de30","author":{"email":"775bb961b81da1ca49217a48e533c832c337154a@docker.com","name":"Jessica Frazelle"},"message":"actually depreciate -rm, -sig-proxy, -name, seriously its been forever\n\nSigned-off-by: Jessica Frazelle <princess@docker.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/f3d4c33213088ce3c381156760064f07da76de30"},{"sha":"f731b01483ed7010824c5951cc4a27db907c2d47","author":{"email":"f49f2a5e660787beb1d0033eaaa9f0d533955c60@higgsboson.tk","name":"Jörg Thalheim"},"message":"Dockerfile: download go libraries before copy vendor\n\nWhen ever something vendor/ changes the go dependencies have to downloaded again,\nwhich requires internet access and there for is potential slow. COPY and go install is much faster, while the git urls does not change not this often.\n\nSigned-off-by: Jörg Thalheim <joerg@higgsboson.tk>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/f731b01483ed7010824c5951cc4a27db907c2d47"},{"sha":"364287b74118de4f04d049426ef37fa9936d2065","author":{"email":"7800de746fd39599bc46177380ea6aede7e31e16@redhat.com","name":"Dan Walsh"},"message":"Add journald as a supported logger for containers\n\nDocker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/364287b74118de4f04d049426ef37fa9936d2065"},{"sha":"6dcdf832a3dddc8de17b7f8b1fb1ddb8b20f9077","author":{"email":"4efb7da3e38416208b41d8021a942884d8a9435c@docker.com","name":"Alexander Morozov"},"message":"Add gocheck to vendored deps\n\nSigned-off-by: Alexander Morozov <lk4d4@docker.com>","distinct":true,"url":"https://api.github.com/repos/gerchardon/docker/commits/6dcdf832a3dddc8de17b7f8b1fb1ddb8b20f9077"}]}