{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/content-store/pulls/comments/36961848","id":36961848,"diff_hunk":"@@ -9,6 +9,7 @@\n     update_type 'minor'\n     routes { [{ 'path' => base_path, 'type' => 'exact' }] }\n     phase nil\n+    analytics_identifier nil","path":"spec/factories/content_item.rb","position":null,"original_position":4,"commit_id":"2a3187ddf796fb4236938b3129fac71817e50743","original_commit_id":"4f0fb0c39d03ee0816870a47e0b09cf851e6596a","user":{"login":"edds","id":35035,"avatar_url":"https://avatars.githubusercontent.com/u/35035?v=3","gravatar_id":"","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following{/other_user}","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User","site_admin":false},"body":"removed both. Tests still pass.","created_at":"2015-08-13T10:50:00Z","updated_at":"2015-08-13T10:50:00Z","html_url":"https://github.com/alphagov/content-store/pull/143#discussion_r36961848","pull_request_url":"https://api.github.com/repos/alphagov/content-store/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/comments/36961848"},"html":{"href":"https://github.com/alphagov/content-store/pull/143#discussion_r36961848"},"pull_request":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/content-store/pulls/143","id":42336134,"html_url":"https://github.com/alphagov/content-store/pull/143","diff_url":"https://github.com/alphagov/content-store/pull/143.diff","patch_url":"https://github.com/alphagov/content-store/pull/143.patch","issue_url":"https://api.github.com/repos/alphagov/content-store/issues/143","number":143,"state":"open","locked":false,"title":"Add analytics identifier to root object","user":{"login":"edds","id":35035,"avatar_url":"https://avatars.githubusercontent.com/u/35035?v=3","gravatar_id":"","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following{/other_user}","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User","site_admin":false},"body":"Analytics identifiers are short codes which we can use to represent\r\nobjects in character restricted environments (like Google Analytics\r\ncustom dimensions). Having them on the root lets us easily pull them out\r\nto be part of the links hash so that content can be correctly marked\r\nwith all related dimensions.","created_at":"2015-08-13T10:37:20Z","updated_at":"2015-08-13T10:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95619dca7b5261600ae2a9dca426d565d3a18524","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/content-store/pulls/143/commits","review_comments_url":"https://api.github.com/repos/alphagov/content-store/pulls/143/comments","review_comment_url":"https://api.github.com/repos/alphagov/content-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/content-store/issues/143/comments","statuses_url":"https://api.github.com/repos/alphagov/content-store/statuses/2a3187ddf796fb4236938b3129fac71817e50743","head":{"label":"alphagov:analytics-itentifier-attr","ref":"analytics-itentifier-attr","sha":"2a3187ddf796fb4236938b3129fac71817e50743","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18069188,"name":"content-store","full_name":"alphagov/content-store","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-store","description":"The central storage of published content on GOV.UK.","fork":false,"url":"https://api.github.com/repos/alphagov/content-store","forks_url":"https://api.github.com/repos/alphagov/content-store/forks","keys_url":"https://api.github.com/repos/alphagov/content-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-store/teams","hooks_url":"https://api.github.com/repos/alphagov/content-store/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-store/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-store/events","assignees_url":"https://api.github.com/repos/alphagov/content-store/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-store/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-store/tags","blobs_url":"https://api.github.com/repos/alphagov/content-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-store/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-store/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-store/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-store/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-store/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-store/subscription","commits_url":"https://api.github.com/repos/alphagov/content-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-store/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-store/merges","archive_url":"https://api.github.com/repos/alphagov/content-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-store/downloads","issues_url":"https://api.github.com/repos/alphagov/content-store/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-store/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-store/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-store/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-store/releases{/id}","created_at":"2014-03-24T16:22:06Z","updated_at":"2015-05-02T06:26:50Z","pushed_at":"2015-08-13T10:47:24Z","git_url":"git://github.com/alphagov/content-store.git","ssh_url":"git@github.com:alphagov/content-store.git","clone_url":"https://github.com/alphagov/content-store.git","svn_url":"https://github.com/alphagov/content-store","homepage":"","size":2963,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"efa8519c9c7df1abae140688b3460a5c732f45c2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18069188,"name":"content-store","full_name":"alphagov/content-store","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-store","description":"The central storage of published content on GOV.UK.","fork":false,"url":"https://api.github.com/repos/alphagov/content-store","forks_url":"https://api.github.com/repos/alphagov/content-store/forks","keys_url":"https://api.github.com/repos/alphagov/content-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-store/teams","hooks_url":"https://api.github.com/repos/alphagov/content-store/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-store/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-store/events","assignees_url":"https://api.github.com/repos/alphagov/content-store/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-store/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-store/tags","blobs_url":"https://api.github.com/repos/alphagov/content-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-store/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-store/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-store/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-store/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-store/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-store/subscription","commits_url":"https://api.github.com/repos/alphagov/content-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-store/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-store/merges","archive_url":"https://api.github.com/repos/alphagov/content-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-store/downloads","issues_url":"https://api.github.com/repos/alphagov/content-store/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-store/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-store/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-store/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-store/releases{/id}","created_at":"2014-03-24T16:22:06Z","updated_at":"2015-05-02T06:26:50Z","pushed_at":"2015-08-13T10:47:24Z","git_url":"git://github.com/alphagov/content-store.git","ssh_url":"git@github.com:alphagov/content-store.git","clone_url":"https://github.com/alphagov/content-store.git","svn_url":"https://github.com/alphagov/content-store","homepage":"","size":2963,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/143"},"html":{"href":"https://github.com/alphagov/content-store/pull/143"},"issue":{"href":"https://api.github.com/repos/alphagov/content-store/issues/143"},"comments":{"href":"https://api.github.com/repos/alphagov/content-store/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/content-store/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/content-store/statuses/2a3187ddf796fb4236938b3129fac71817e50743"}}}}