{"action":"created","issue":{"url":"https://api.github.com/repos/samba-team/samba/issues/28","labels_url":"https://api.github.com/repos/samba-team/samba/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/samba-team/samba/issues/28/comments","events_url":"https://api.github.com/repos/samba-team/samba/issues/28/events","html_url":"https://github.com/samba-team/samba/pull/28","id":113145891,"number":28,"title":"build:wafsamba: Removed hard-coded class names in build scripts","user":{"login":"ita1024","id":508304,"avatar_url":"https://avatars.githubusercontent.com/u/508304?v=3","gravatar_id":"","url":"https://api.github.com/users/ita1024","html_url":"https://github.com/ita1024","followers_url":"https://api.github.com/users/ita1024/followers","following_url":"https://api.github.com/users/ita1024/following{/other_user}","gists_url":"https://api.github.com/users/ita1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ita1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ita1024/subscriptions","organizations_url":"https://api.github.com/users/ita1024/orgs","repos_url":"https://api.github.com/users/ita1024/repos","events_url":"https://api.github.com/users/ita1024/events{/privacy}","received_events_url":"https://api.github.com/users/ita1024/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-24T08:37:06Z","updated_at":"2015-10-28T19:37:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samba-team/samba/pulls/28","html_url":"https://github.com/samba-team/samba/pull/28","diff_url":"https://github.com/samba-team/samba/pull/28.diff","patch_url":"https://github.com/samba-team/samba/pull/28.patch"},"body":"Using hard-coded class names prevents subclassing and make it hard\r\nto reason about the workflow. The wscript files read during the build\r\nmust be read during the installation phase as well.\r\n\r\nSigned-off-by: Thomas Nagy <tnagy@waf.io>\r\nReviewed-by: <your name here>\r\nReviewed-by: <your name here>"},"comment":{"url":"https://api.github.com/repos/samba-team/samba/issues/comments/151967228","html_url":"https://github.com/samba-team/samba/pull/28#issuecomment-151967228","issue_url":"https://api.github.com/repos/samba-team/samba/issues/28","id":151967228,"user":{"login":"obnoxxx","id":8081179,"avatar_url":"https://avatars.githubusercontent.com/u/8081179?v=3","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T19:37:05Z","updated_at":"2015-10-28T19:37:05Z","body":"ddiss: I think the  \"Reviewed-by: \" lines were intended as placeholders for the needed team-reviewers and should be replaced by full review tags.... :-)"}}