{"action":"created","comment":{"url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/comments/30655829","id":30655829,"diff_hunk":"@@ -0,0 +1,177 @@\n+//\n+//  TealiumADBMobileTagBridge_Tests.m\n+//  Modules_UICatelog\n+//\n+//  Created by George Webster on 12/17/14.\n+//  Copyright (c) 2014 f. All rights reserved.\n+//\n+\n+#import <UIKit/UIKit.h>\n+#import <XCTest/XCTest.h>\n+#import \"TealiumADBMobileTagBridge.h\"\n+\n+@interface TealiumADBMobileTagBridge ()\n+- (TealiumADBMobileMethod)methodFromString:(NSString *)value;\n+@end\n+\n+@interface TealiumADBMobileTagBridge_Tests : XCTestCase\n+\n+@end\n+\n+@implementation TealiumADBMobileTagBridge_Tests\n+\n+- (void)setUp {\n+    [super setUp];\n+\n+}\n+\n+- (void)tearDown {\n+    [super tearDown];\n+}\n+\n+- (void)testMethodFromString {\n+\n+    TealiumADBMobileMethod methodType = TealiumADBMobileMethodNone;\n+    \n+    methodType = [[TealiumADBMobileTagBridge sharedInstance] methodFromString:@\"set_privacy_status\"];","path":"platforms/ios/sample app/tealium_adobe_sample/Modules_UICatelog_Full Tests/TealiumADBMobileTagBridge_Tests.m","position":36,"original_position":36,"commit_id":"c3343fc93e8e56f23f0e636537668bd3cab35027","original_commit_id":"c3343fc93e8e56f23f0e636537668bd3cab35027","user":{"login":"ethyreal","id":129717,"avatar_url":"https://avatars.githubusercontent.com/u/129717?v=3","gravatar_id":"","url":"https://api.github.com/users/ethyreal","html_url":"https://github.com/ethyreal","followers_url":"https://api.github.com/users/ethyreal/followers","following_url":"https://api.github.com/users/ethyreal/following{/other_user}","gists_url":"https://api.github.com/users/ethyreal/gists{/gist_id}","starred_url":"https://api.github.com/users/ethyreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethyreal/subscriptions","organizations_url":"https://api.github.com/users/ethyreal/orgs","repos_url":"https://api.github.com/users/ethyreal/repos","events_url":"https://api.github.com/users/ethyreal/events{/privacy}","received_events_url":"https://api.github.com/users/ethyreal/received_events","type":"User","site_admin":false},"body":"The the methodFromString: method was removed you should remove these tests.  I don't see any tests for the code it was replaced by.  If your going to use dictionaries for ```__VendorMethod``` then you need to use constants for keys and you should write tests for each result for proper key and value results.  Having them all being just loose \"magic\" strings is just waiting for bugs to happen.  Alternatively you can create a VendorMethod class with responseCode, respondBody properties.  ","created_at":"2015-05-19T22:41:52Z","updated_at":"2015-05-19T22:41:52Z","html_url":"https://github.com/Tealium/tagbridge-adobe/pull/1#discussion_r30655829","pull_request_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/comments/30655829"},"html":{"href":"https://github.com/Tealium/tagbridge-adobe/pull/1#discussion_r30655829"},"pull_request":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1","id":35778697,"html_url":"https://github.com/Tealium/tagbridge-adobe/pull/1","diff_url":"https://github.com/Tealium/tagbridge-adobe/pull/1.diff","patch_url":"https://github.com/Tealium/tagbridge-adobe/pull/1.patch","issue_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/1","number":1,"state":"open","locked":false,"title":"added iOS","user":{"login":"patrickmcwilliams","id":5140565,"avatar_url":"https://avatars.githubusercontent.com/u/5140565?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickmcwilliams","html_url":"https://github.com/patrickmcwilliams","followers_url":"https://api.github.com/users/patrickmcwilliams/followers","following_url":"https://api.github.com/users/patrickmcwilliams/following{/other_user}","gists_url":"https://api.github.com/users/patrickmcwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickmcwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickmcwilliams/subscriptions","organizations_url":"https://api.github.com/users/patrickmcwilliams/orgs","repos_url":"https://api.github.com/users/patrickmcwilliams/repos","events_url":"https://api.github.com/users/patrickmcwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/patrickmcwilliams/received_events","type":"User","site_admin":false},"body":"added iOS files","created_at":"2015-05-19T21:49:03Z","updated_at":"2015-05-19T22:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c10051202ed557a7081d251b53db7c15618bd16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/1/comments","statuses_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/statuses/c3343fc93e8e56f23f0e636537668bd3cab35027","head":{"label":"patrickmcwilliams:master","ref":"master","sha":"c3343fc93e8e56f23f0e636537668bd3cab35027","user":{"login":"patrickmcwilliams","id":5140565,"avatar_url":"https://avatars.githubusercontent.com/u/5140565?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickmcwilliams","html_url":"https://github.com/patrickmcwilliams","followers_url":"https://api.github.com/users/patrickmcwilliams/followers","following_url":"https://api.github.com/users/patrickmcwilliams/following{/other_user}","gists_url":"https://api.github.com/users/patrickmcwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickmcwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickmcwilliams/subscriptions","organizations_url":"https://api.github.com/users/patrickmcwilliams/orgs","repos_url":"https://api.github.com/users/patrickmcwilliams/repos","events_url":"https://api.github.com/users/patrickmcwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/patrickmcwilliams/received_events","type":"User","site_admin":false},"repo":{"id":35900029,"name":"tagbridge-adobe","full_name":"patrickmcwilliams/tagbridge-adobe","owner":{"login":"patrickmcwilliams","id":5140565,"avatar_url":"https://avatars.githubusercontent.com/u/5140565?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickmcwilliams","html_url":"https://github.com/patrickmcwilliams","followers_url":"https://api.github.com/users/patrickmcwilliams/followers","following_url":"https://api.github.com/users/patrickmcwilliams/following{/other_user}","gists_url":"https://api.github.com/users/patrickmcwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickmcwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickmcwilliams/subscriptions","organizations_url":"https://api.github.com/users/patrickmcwilliams/orgs","repos_url":"https://api.github.com/users/patrickmcwilliams/repos","events_url":"https://api.github.com/users/patrickmcwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/patrickmcwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickmcwilliams/tagbridge-adobe","description":"Tagbridge SDK for mobile Adobe Marketing Cloud library. Add this to your project to enable Tealium support of Adobe's library","fork":true,"url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe","forks_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/forks","keys_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/teams","hooks_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/hooks","issue_events_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/issues/events{/number}","events_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/events","assignees_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/assignees{/user}","branches_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/branches{/branch}","tags_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/tags","blobs_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/languages","stargazers_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/stargazers","contributors_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/contributors","subscribers_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/subscribers","subscription_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/subscription","commits_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/contents/{+path}","compare_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/merges","archive_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/downloads","issues_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/issues{/number}","pulls_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/labels{/name}","releases_url":"https://api.github.com/repos/patrickmcwilliams/tagbridge-adobe/releases{/id}","created_at":"2015-05-19T18:16:03Z","updated_at":"2015-05-19T21:49:02Z","pushed_at":"2015-05-19T21:49:00Z","git_url":"git://github.com/patrickmcwilliams/tagbridge-adobe.git","ssh_url":"git@github.com:patrickmcwilliams/tagbridge-adobe.git","clone_url":"https://github.com/patrickmcwilliams/tagbridge-adobe.git","svn_url":"https://github.com/patrickmcwilliams/tagbridge-adobe","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tealium:master","ref":"master","sha":"716819340211288fcb1657ec07558c11c99b9f82","user":{"login":"Tealium","id":1724745,"avatar_url":"https://avatars.githubusercontent.com/u/1724745?v=3","gravatar_id":"","url":"https://api.github.com/users/Tealium","html_url":"https://github.com/Tealium","followers_url":"https://api.github.com/users/Tealium/followers","following_url":"https://api.github.com/users/Tealium/following{/other_user}","gists_url":"https://api.github.com/users/Tealium/gists{/gist_id}","starred_url":"https://api.github.com/users/Tealium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tealium/subscriptions","organizations_url":"https://api.github.com/users/Tealium/orgs","repos_url":"https://api.github.com/users/Tealium/repos","events_url":"https://api.github.com/users/Tealium/events{/privacy}","received_events_url":"https://api.github.com/users/Tealium/received_events","type":"Organization","site_admin":false},"repo":{"id":35575338,"name":"tagbridge-adobe","full_name":"Tealium/tagbridge-adobe","owner":{"login":"Tealium","id":1724745,"avatar_url":"https://avatars.githubusercontent.com/u/1724745?v=3","gravatar_id":"","url":"https://api.github.com/users/Tealium","html_url":"https://github.com/Tealium","followers_url":"https://api.github.com/users/Tealium/followers","following_url":"https://api.github.com/users/Tealium/following{/other_user}","gists_url":"https://api.github.com/users/Tealium/gists{/gist_id}","starred_url":"https://api.github.com/users/Tealium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tealium/subscriptions","organizations_url":"https://api.github.com/users/Tealium/orgs","repos_url":"https://api.github.com/users/Tealium/repos","events_url":"https://api.github.com/users/Tealium/events{/privacy}","received_events_url":"https://api.github.com/users/Tealium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tealium/tagbridge-adobe","description":"Tagbridge SDK for mobile Adobe Marketing Cloud library. Add this to your project to enable Tealium support of Adobe's library","fork":false,"url":"https://api.github.com/repos/Tealium/tagbridge-adobe","forks_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/forks","keys_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/teams","hooks_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/hooks","issue_events_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/events{/number}","events_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/events","assignees_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/assignees{/user}","branches_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/branches{/branch}","tags_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/tags","blobs_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/statuses/{sha}","languages_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/languages","stargazers_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/stargazers","contributors_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/contributors","subscribers_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/subscribers","subscription_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/subscription","commits_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/contents/{+path}","compare_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/merges","archive_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/downloads","issues_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues{/number}","pulls_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls{/number}","milestones_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/milestones{/number}","notifications_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/labels{/name}","releases_url":"https://api.github.com/repos/Tealium/tagbridge-adobe/releases{/id}","created_at":"2015-05-13T21:34:25Z","updated_at":"2015-05-13T21:37:42Z","pushed_at":"2015-05-19T21:49:04Z","git_url":"git://github.com/Tealium/tagbridge-adobe.git","ssh_url":"git@github.com:Tealium/tagbridge-adobe.git","clone_url":"https://github.com/Tealium/tagbridge-adobe.git","svn_url":"https://github.com/Tealium/tagbridge-adobe","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1"},"html":{"href":"https://github.com/Tealium/tagbridge-adobe/pull/1"},"issue":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/1"},"comments":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Tealium/tagbridge-adobe/statuses/c3343fc93e8e56f23f0e636537668bd3cab35027"}}}}