{"action":"created","issue":{"url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/6","labels_url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/6/comments","events_url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/6/events","html_url":"https://github.com/josephjeganathan/Confluent.RestClient/pull/6","id":121525942,"number":6,"title":"Support for cancellation and explicit disregard of callback context","user":{"login":"bschmidtbauer","id":10816326,"avatar_url":"https://avatars.githubusercontent.com/u/10816326?v=3","gravatar_id":"","url":"https://api.github.com/users/bschmidtbauer","html_url":"https://github.com/bschmidtbauer","followers_url":"https://api.github.com/users/bschmidtbauer/followers","following_url":"https://api.github.com/users/bschmidtbauer/following{/other_user}","gists_url":"https://api.github.com/users/bschmidtbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/bschmidtbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschmidtbauer/subscriptions","organizations_url":"https://api.github.com/users/bschmidtbauer/orgs","repos_url":"https://api.github.com/users/bschmidtbauer/repos","events_url":"https://api.github.com/users/bschmidtbauer/events{/privacy}","received_events_url":"https://api.github.com/users/bschmidtbauer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-12-10T16:31:51Z","updated_at":"2015-12-15T18:17:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/pulls/6","html_url":"https://github.com/josephjeganathan/Confluent.RestClient/pull/6","diff_url":"https://github.com/josephjeganathan/Confluent.RestClient/pull/6.diff","patch_url":"https://github.com/josephjeganathan/Confluent.RestClient/pull/6.patch"},"body":"Added an overload to each async operation on ```IConfluentClient``` that now\r\ntakes a ```CancellationToken``` so that the caller can cancel any in progress\r\nrequests. *Note that the current behavior in the ```SendRequest``` method\r\nconverts the ```TaskCancelledException``` into a\r\n```ConfluentApiUnavailableException``` where it states (via the message) that\r\nit was due to timeout. I changed this to allow an explicit user\r\ninitiated cancel to propagate the ```TaskCanceledException``` and the timeout\r\nwill continue to convert to the confluent exception.\r\n\r\nAdded an explicit ```ConfigureAwait(false)``` call on all awaited calls - this\r\nwill help to ensure that the callback doesn't cause a deadlock if the\r\ncaller has requirements on callback context (e.g. GUI apps, ASP.NET)\r\nhttps://msdn.microsoft.com/en-us/magazine/jj991977.aspx"},"comment":{"url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/comments/164846273","html_url":"https://github.com/josephjeganathan/Confluent.RestClient/pull/6#issuecomment-164846273","issue_url":"https://api.github.com/repos/josephjeganathan/Confluent.RestClient/issues/6","id":164846273,"user":{"login":"bschmidtbauer","id":10816326,"avatar_url":"https://avatars.githubusercontent.com/u/10816326?v=3","gravatar_id":"","url":"https://api.github.com/users/bschmidtbauer","html_url":"https://github.com/bschmidtbauer","followers_url":"https://api.github.com/users/bschmidtbauer/followers","following_url":"https://api.github.com/users/bschmidtbauer/following{/other_user}","gists_url":"https://api.github.com/users/bschmidtbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/bschmidtbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschmidtbauer/subscriptions","organizations_url":"https://api.github.com/users/bschmidtbauer/orgs","repos_url":"https://api.github.com/users/bschmidtbauer/repos","events_url":"https://api.github.com/users/bschmidtbauer/events{/privacy}","received_events_url":"https://api.github.com/users/bschmidtbauer/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T18:17:18Z","updated_at":"2015-12-15T18:17:18Z","body":"You should be all set - let me know if you need anything further."}}