{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/2246","labels_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2246/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2246/comments","events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2246/events","html_url":"https://github.com/bbatsov/rubocop/pull/2246","id":106408121,"number":2246,"title":"Remove trailing named variables","user":{"login":"rrosenblum","id":1528852,"avatar_url":"https://avatars.githubusercontent.com/u/1528852?v=3","gravatar_id":"","url":"https://api.github.com/users/rrosenblum","html_url":"https://github.com/rrosenblum","followers_url":"https://api.github.com/users/rrosenblum/followers","following_url":"https://api.github.com/users/rrosenblum/following{/other_user}","gists_url":"https://api.github.com/users/rrosenblum/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosenblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosenblum/subscriptions","organizations_url":"https://api.github.com/users/rrosenblum/orgs","repos_url":"https://api.github.com/users/rrosenblum/repos","events_url":"https://api.github.com/users/rrosenblum/events{/privacy}","received_events_url":"https://api.github.com/users/rrosenblum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-14T19:06:20Z","updated_at":"2015-09-22T15:52:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2246","html_url":"https://github.com/bbatsov/rubocop/pull/2246","diff_url":"https://github.com/bbatsov/rubocop/pull/2246.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/2246.patch"},"body":"This turned into a larger commit than I originally thought it would be. \r\n\r\nThere are 3 modification to `Style/TrailingUnderscorevariable`.\r\n* Register an offense for trailing `*_`\r\n * this was never covered by the cop initially\r\n* Add a configuration to remove named trailing underscore variables.\r\n * I set this to be defaulted to true. Looking through RuboCop as an example, the vast majority of trailing named variables do not provide any useful information.\r\n* Do not register an offense for a trailing underscore variables that are preceeded by a splat variable\r\n * This has been a bug in the cop since it was first created.\r\n * `a, *b, = foo()` is a syntax error"},"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/142331295","html_url":"https://github.com/bbatsov/rubocop/pull/2246#issuecomment-142331295","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2246","id":142331295,"user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T15:52:43Z","updated_at":"2015-09-22T15:52:43Z","body":"> What do you think about leaving the configuration option in and defaulting it to not remove named underscore variables?\r\n\r\nThat'd be great."}}