{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/970","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/970/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/970/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/970/events","html_url":"https://github.com/prometheus/prometheus/pull/970","id":99660123,"number":970,"title":"Improve unique target group sources.","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-07T14:39:11Z","updated_at":"2015-08-10T11:42:33Z","closed_at":"2015-08-10T09:31:33Z","pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/970","html_url":"https://github.com/prometheus/prometheus/pull/970","diff_url":"https://github.com/prometheus/prometheus/pull/970.diff","patch_url":"https://github.com/prometheus/prometheus/pull/970.patch"},"body":"This includes the position of the SD mechanism into the unique source string. Logic for ensuring uniqueness was removed from the SD implementations (they now only have to ensure uniqueness within the target groups they expose themselves). It was also removed from the target manager which now assumes uniqueness across the target providers.\r\n\r\nThe behavior is now encapsulated in the `prefixedTargetProvider` and the `providersFromConfig`.\r\n\r\n@juliusv \r\n\r\nWill be rebased on top of #902 "},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/129417404","html_url":"https://github.com/prometheus/prometheus/pull/970#issuecomment-129417404","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/970","id":129417404,"user":{"login":"xperimental","id":125773,"avatar_url":"https://avatars.githubusercontent.com/u/125773?v=3","gravatar_id":"","url":"https://api.github.com/users/xperimental","html_url":"https://github.com/xperimental","followers_url":"https://api.github.com/users/xperimental/followers","following_url":"https://api.github.com/users/xperimental/following{/other_user}","gists_url":"https://api.github.com/users/xperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/xperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xperimental/subscriptions","organizations_url":"https://api.github.com/users/xperimental/orgs","repos_url":"https://api.github.com/users/xperimental/repos","events_url":"https://api.github.com/users/xperimental/events{/privacy}","received_events_url":"https://api.github.com/users/xperimental/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T11:42:33Z","updated_at":"2015-08-10T11:42:33Z","body":"Great!"}}