{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cf-tables/issues/3","labels_url":"https://api.github.com/repos/cfpb/cf-tables/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cf-tables/issues/3/comments","events_url":"https://api.github.com/repos/cfpb/cf-tables/issues/3/events","html_url":"https://github.com/cfpb/cf-tables/pull/3","id":108889631,"number":3,"title":"cf-tables is ready for a PR!","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-29T15:04:44Z","updated_at":"2015-10-01T19:25:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cf-tables/pulls/3","html_url":"https://github.com/cfpb/cf-tables/pull/3","diff_url":"https://github.com/cfpb/cf-tables/pull/3.diff","patch_url":"https://github.com/cfpb/cf-tables/pull/3.patch"},"body":"This adds the bulk of cf-tables, built according to the new specifications for the CFPB design manual.\r\n\r\n[Check out the auto-generated documentation!](http://mistergone.github.io/cf-tables/docs/)\r\n\r\n## Additions\r\n- `.table__small_stacked`, the base responsive table for small screens\r\n- `.table__small_entry-header`, a small screen variation\r\n- `.table-wrapper__scrolling`, a wrapper for another small screen variation\r\n- `.table__striped`, a class that adds striped rows\r\n- `.table__sortable`, a class that enables table sorting\r\n- `cf-tables.js`, the JavaScript that enables table sorting\r\n- Tests for `cf-tables.js`\r\n\r\n## Testing\r\n- `git clone` the repo\r\n- Run `npm install`\r\n- Run `bower install`\r\n- Run `grunt`\r\n- Check out `docs/index.html` for documentation\r\n- Run `grunt test` to run qunit tests\r\n\r\n## Review\r\n- @Scotchester @ascott1 @jimmynotjim @niqjohnson and anyone else who wants to take a look\r\n- __Feedback is appreciated!__ I do not claim to be the master of all this stuff, so even tiny nitpicks are helpful!\r\n\r\n## Todos\r\n- ~~`cf-tables.js` should handle tables with `sorted_up` or `sorted_down` classes in their TRs by sorting them on document load.~~ _[Added here](https://github.com/mistergone/cf-tables/commit/efcdcdb9221f33621f0ae4e43bc69081a2377f7c)_\r\n- `cf-tables.js` should be able to sort dates (I plan to add a `data-sort_type=\"date\"` handler)\r\n\r\n## Checklist\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices \r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Special Thanks\r\n@ascott1 and @Scotchester have been immensely helpful in teaching me Capital Framework development, so hooray to them both!\r\n\r\n## Animated GIF\r\nGenerating tables is like...\r\n![xbqozc4](https://cloud.githubusercontent.com/assets/1490703/10168199/cabcca8a-6699-11e5-825b-b5899796c9d8.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/cf-tables/issues/comments/144822925","html_url":"https://github.com/cfpb/cf-tables/pull/3#issuecomment-144822925","issue_url":"https://api.github.com/repos/cfpb/cf-tables/issues/3","id":144822925,"user":{"login":"Scotchester","id":1044670,"avatar_url":"https://avatars.githubusercontent.com/u/1044670?v=3","gravatar_id":"","url":"https://api.github.com/users/Scotchester","html_url":"https://github.com/Scotchester","followers_url":"https://api.github.com/users/Scotchester/followers","following_url":"https://api.github.com/users/Scotchester/following{/other_user}","gists_url":"https://api.github.com/users/Scotchester/gists{/gist_id}","starred_url":"https://api.github.com/users/Scotchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scotchester/subscriptions","organizations_url":"https://api.github.com/users/Scotchester/orgs","repos_url":"https://api.github.com/users/Scotchester/repos","events_url":"https://api.github.com/users/Scotchester/events{/privacy}","received_events_url":"https://api.github.com/users/Scotchester/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T19:25:23Z","updated_at":"2015-10-01T19:25:23Z","body":"This is looking great so far, Chuck!\r\n\r\n> @niqjohnson - __Fun fact!__ The styling you're seeing for the TH (centered, bolded) is coming from your browser, which assumes that's how you want to see your TH elements (for instance, [see this line in the webkit browser stylesheet](http://trac.webkit.org/browser/trunk/Source/WebCore/css/html.css#L256)). I'm going to ask @Scotchester what the preferred course of action is.\r\n\r\n> __EDIT:__ Also, in this case, those TH elements were outside the THEAD, which is something I normally avoid. I've revised that in the documentation, but the default style for a TH outside the THEAD should still be addressed.\r\n\r\nUnder the assumption that sometimes `th`s may be used for column headers without `thead` (though we should discourage this), and that any `th` inside `tbody` will be a row header, I think we want to handle this with a PR to cf-core to set the following:\r\n\r\n```less\r\nth {\r\n    ,webfont-demi();\r\n    text-align: left;\r\n}\r\n\r\ntbody th {\r\n    .webfont-regular();\r\n}\r\n```\r\n\r\nDoes that make sense?\r\n\r\nMore feedback to come."}}