{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments/30923801","id":30923801,"diff_hunk":"@@ -298,3 +298,21 @@ end\n \n # fma and muladd\n @test fma(3,4,5) == 3*4+5 == muladd(3,4,5)\n+\n+# is_valid_utf32\n+@test is_valid_utf32(UInt32[65,66,67,0])\n+@test !is_valid_utf32(UInt32[65,66,0x110000,0])\n+\n+# isvalid\n+let s = \"abcdef\", u8 = \"abcdef\\uff\", u16 = utf16(u8), u32 = utf32(u8)\n+@test !isvalid(UTF32String(UInt32[65,66,0x110000,0])\n+@test !isvalid(Char(0x110000))","path":"test/runtests.jl","position":12,"original_position":12,"commit_id":"d6a324688d84df458233cafcee627e00d01cb375","original_commit_id":"d6a324688d84df458233cafcee627e00d01cb375","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"this test needs to be something like `@test !isvalid(@compat Char(0x110000))` for 0.3","created_at":"2015-05-22T19:22:48Z","updated_at":"2015-05-22T19:22:48Z","html_url":"https://github.com/JuliaLang/Compat.jl/pull/90#discussion_r30923801","pull_request_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments/30923801"},"html":{"href":"https://github.com/JuliaLang/Compat.jl/pull/90#discussion_r30923801"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90","id":36045513,"html_url":"https://github.com/JuliaLang/Compat.jl/pull/90","diff_url":"https://github.com/JuliaLang/Compat.jl/pull/90.diff","patch_url":"https://github.com/JuliaLang/Compat.jl/pull/90.patch","issue_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/90","number":90,"state":"open","locked":false,"title":"Add Compat entries for #11140 & #11241","user":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"body":"This adds Compat entries for is_valid_utf32, and all of the isvalid changes.","created_at":"2015-05-22T16:07:12Z","updated_at":"2015-05-22T19:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c406859b7a6cdee44dc8a38fd6b3c206a3ef289c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/90/comments","statuses_url":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/d6a324688d84df458233cafcee627e00d01cb375","head":{"label":"ScottPJones:spj/addvalid","ref":"spj/addvalid","sha":"d6a324688d84df458233cafcee627e00d01cb375","user":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"repo":{"id":35553329,"name":"Compat.jl","full_name":"ScottPJones/Compat.jl","owner":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ScottPJones/Compat.jl","description":"cross-version compatibility","fork":true,"url":"https://api.github.com/repos/ScottPJones/Compat.jl","forks_url":"https://api.github.com/repos/ScottPJones/Compat.jl/forks","keys_url":"https://api.github.com/repos/ScottPJones/Compat.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottPJones/Compat.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottPJones/Compat.jl/teams","hooks_url":"https://api.github.com/repos/ScottPJones/Compat.jl/hooks","issue_events_url":"https://api.github.com/repos/ScottPJones/Compat.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ScottPJones/Compat.jl/events","assignees_url":"https://api.github.com/repos/ScottPJones/Compat.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ScottPJones/Compat.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ScottPJones/Compat.jl/tags","blobs_url":"https://api.github.com/repos/ScottPJones/Compat.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottPJones/Compat.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottPJones/Compat.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottPJones/Compat.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottPJones/Compat.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottPJones/Compat.jl/languages","stargazers_url":"https://api.github.com/repos/ScottPJones/Compat.jl/stargazers","contributors_url":"https://api.github.com/repos/ScottPJones/Compat.jl/contributors","subscribers_url":"https://api.github.com/repos/ScottPJones/Compat.jl/subscribers","subscription_url":"https://api.github.com/repos/ScottPJones/Compat.jl/subscription","commits_url":"https://api.github.com/repos/ScottPJones/Compat.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottPJones/Compat.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottPJones/Compat.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottPJones/Compat.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottPJones/Compat.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ScottPJones/Compat.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottPJones/Compat.jl/merges","archive_url":"https://api.github.com/repos/ScottPJones/Compat.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottPJones/Compat.jl/downloads","issues_url":"https://api.github.com/repos/ScottPJones/Compat.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ScottPJones/Compat.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottPJones/Compat.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottPJones/Compat.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottPJones/Compat.jl/labels{/name}","releases_url":"https://api.github.com/repos/ScottPJones/Compat.jl/releases{/id}","created_at":"2015-05-13T14:18:49Z","updated_at":"2015-05-13T14:18:49Z","pushed_at":"2015-05-22T16:04:01Z","git_url":"git://github.com/ScottPJones/Compat.jl.git","ssh_url":"git@github.com:ScottPJones/Compat.jl.git","clone_url":"https://github.com/ScottPJones/Compat.jl.git","svn_url":"https://github.com/ScottPJones/Compat.jl","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"2583c3827f938e3943eaeb0bacf404c8b2e3d55f","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":24995432,"name":"Compat.jl","full_name":"JuliaLang/Compat.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/Compat.jl","description":"cross-version compatibility","fork":false,"url":"https://api.github.com/repos/JuliaLang/Compat.jl","forks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/Compat.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/Compat.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/Compat.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/Compat.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/Compat.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/Compat.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/Compat.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/Compat.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/Compat.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/Compat.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/Compat.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/Compat.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/Compat.jl/releases{/id}","created_at":"2014-10-09T15:27:45Z","updated_at":"2015-05-02T21:33:29Z","pushed_at":"2015-05-22T16:07:12Z","git_url":"git://github.com/JuliaLang/Compat.jl.git","ssh_url":"git@github.com:JuliaLang/Compat.jl.git","clone_url":"https://github.com/JuliaLang/Compat.jl.git","svn_url":"https://github.com/JuliaLang/Compat.jl","homepage":null,"size":1337,"stargazers_count":10,"watchers_count":10,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":15,"forks":19,"open_issues":15,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90"},"html":{"href":"https://github.com/JuliaLang/Compat.jl/pull/90"},"issue":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/90"},"comments":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/d6a324688d84df458233cafcee627e00d01cb375"}}}}