{"action":"created","issue":{"url":"https://api.github.com/repos/BBC-News/wraith/issues/273","labels_url":"https://api.github.com/repos/BBC-News/wraith/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/BBC-News/wraith/issues/273/comments","events_url":"https://api.github.com/repos/BBC-News/wraith/issues/273/events","html_url":"https://github.com/BBC-News/wraith/pull/273","id":95409764,"number":273,"title":"Fix for file names with '-' in the final part","user":{"login":"adouglas","id":1300611,"avatar_url":"https://avatars.githubusercontent.com/u/1300611?v=3","gravatar_id":"","url":"https://api.github.com/users/adouglas","html_url":"https://github.com/adouglas","followers_url":"https://api.github.com/users/adouglas/followers","following_url":"https://api.github.com/users/adouglas/following{/other_user}","gists_url":"https://api.github.com/users/adouglas/gists{/gist_id}","starred_url":"https://api.github.com/users/adouglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adouglas/subscriptions","organizations_url":"https://api.github.com/users/adouglas/orgs","repos_url":"https://api.github.com/users/adouglas/repos","events_url":"https://api.github.com/users/adouglas/events{/privacy}","received_events_url":"https://api.github.com/users/adouglas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-16T11:07:11Z","updated_at":"2015-09-14T16:54:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BBC-News/wraith/pulls/273","html_url":"https://github.com/BBC-News/wraith/pull/273","diff_url":"https://github.com/BBC-News/wraith/pull/273.diff","patch_url":"https://github.com/BBC-News/wraith/pull/273.patch"},"body":"Sometimes captured shots are named with language or location ids at the end (e.g. 1280_phantomjs_english-diff.png). This breaks gallery generation.\r\n\r\nFix is to detect the '-' when looking for diff or data and remove all but the content after.\r\n\r\nFixes #272 "},"comment":{"url":"https://api.github.com/repos/BBC-News/wraith/issues/comments/140143157","html_url":"https://github.com/BBC-News/wraith/pull/273#issuecomment-140143157","issue_url":"https://api.github.com/repos/BBC-News/wraith/issues/273","id":140143157,"user":{"login":"ChrisBAshton","id":5111927,"avatar_url":"https://avatars.githubusercontent.com/u/5111927?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBAshton","html_url":"https://github.com/ChrisBAshton","followers_url":"https://api.github.com/users/ChrisBAshton/followers","following_url":"https://api.github.com/users/ChrisBAshton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBAshton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBAshton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBAshton/subscriptions","organizations_url":"https://api.github.com/users/ChrisBAshton/orgs","repos_url":"https://api.github.com/users/ChrisBAshton/repos","events_url":"https://api.github.com/users/ChrisBAshton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBAshton/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T16:54:51Z","updated_at":"2015-09-14T16:54:51Z","body":"Hi, thanks for the PR. I've manually verified that your fix appears to work - great stuff! Would you consider writing an automated test for this so that we're protected against future changes to the codebase?\r\n\r\n```ruby\r\n  describe \"Wraith gallery generator\" do\r\n    let(:gallery) { Wraith::GalleryGenerator.new(config_name, false) }\r\n\r\n    it \"should not break when there is a `-` in the filename\" do\r\n      dirs = gallery.parse_directories 'spec/thumbnails'\r\n      puts dirs.inspect\r\n      # hopefully this can get you started!\r\n    end\r\n  end\r\n```"}}