{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/35492536","id":35492536,"diff_hunk":"@@ -58,10 +84,76 @@ ucs_status_t uct_mm_ep_put_bcopy(uct_ep_h tl_ep, uct_pack_callback_t pack_cb,\n     return UCS_OK;\n }\n \n-ucs_status_t uct_mm_ep_am_short(uct_ep_h ep, uint8_t id, uint64_t header,\n+inline uint64_t uct_mm_ep_head_index_in_fifo(uct_mm_ep_t *ep)\n+{\n+\tuct_mm_iface_t *iface = ucs_derived_of(ep->super.super.iface, uct_mm_iface_t);\n+    return (ep->fifo_ctl->head & iface->fifo_mask);\n+}\n+\n+uct_mm_fifo_element_t* uct_mm_ep_get_remote_elem(uct_mm_ep_t *ep, uint64_t head)","path":"src/uct/sm/mm/mm_ep.c","position":52,"original_position":52,"commit_id":"f7a6abde53508d7d906358a8b1f709f68f741cac","original_commit_id":"f7a6abde53508d7d906358a8b1f709f68f741cac","user":{"login":"shamisp","id":2236120,"avatar_url":"https://avatars.githubusercontent.com/u/2236120?v=3","gravatar_id":"","url":"https://api.github.com/users/shamisp","html_url":"https://github.com/shamisp","followers_url":"https://api.github.com/users/shamisp/followers","following_url":"https://api.github.com/users/shamisp/following{/other_user}","gists_url":"https://api.github.com/users/shamisp/gists{/gist_id}","starred_url":"https://api.github.com/users/shamisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamisp/subscriptions","organizations_url":"https://api.github.com/users/shamisp/orgs","repos_url":"https://api.github.com/users/shamisp/repos","events_url":"https://api.github.com/users/shamisp/events{/privacy}","received_events_url":"https://api.github.com/users/shamisp/received_events","type":"User","site_admin":false},"body":"Do we want to inline this function. I'm asking since it is used in critical path","created_at":"2015-07-26T12:46:47Z","updated_at":"2015-07-26T12:46:47Z","html_url":"https://github.com/openucx/ucx/pull/324#discussion_r35492536","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/35492536"},"html":{"href":"https://github.com/openucx/ucx/pull/324#discussion_r35492536"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/324","id":40852278,"html_url":"https://github.com/openucx/ucx/pull/324","diff_url":"https://github.com/openucx/ucx/pull/324.diff","patch_url":"https://github.com/openucx/ucx/pull/324.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/324","number":324,"state":"open","locked":false,"title":"SM/MM: added support for active messaging for inline messages.","user":{"login":"alinask","id":2405183,"avatar_url":"https://avatars.githubusercontent.com/u/2405183?v=3","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-07-26T12:08:55Z","updated_at":"2015-07-26T12:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c5aedc51085b0dc06bd9609ae7428f27ec65707","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/324/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/324/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/324/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/f7a6abde53508d7d906358a8b1f709f68f741cac","head":{"label":"alinask:topic/uct-mm-am-inline","ref":"topic/uct-mm-am-inline","sha":"f7a6abde53508d7d906358a8b1f709f68f741cac","user":{"login":"alinask","id":2405183,"avatar_url":"https://avatars.githubusercontent.com/u/2405183?v=3","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"repo":{"id":39071172,"name":"ucx","full_name":"alinask/ucx","owner":{"login":"alinask","id":2405183,"avatar_url":"https://avatars.githubusercontent.com/u/2405183?v=3","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alinask/ucx","description":"Unified Communication X : ","fork":true,"url":"https://api.github.com/repos/alinask/ucx","forks_url":"https://api.github.com/repos/alinask/ucx/forks","keys_url":"https://api.github.com/repos/alinask/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alinask/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alinask/ucx/teams","hooks_url":"https://api.github.com/repos/alinask/ucx/hooks","issue_events_url":"https://api.github.com/repos/alinask/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/alinask/ucx/events","assignees_url":"https://api.github.com/repos/alinask/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/alinask/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/alinask/ucx/tags","blobs_url":"https://api.github.com/repos/alinask/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alinask/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alinask/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alinask/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alinask/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/alinask/ucx/languages","stargazers_url":"https://api.github.com/repos/alinask/ucx/stargazers","contributors_url":"https://api.github.com/repos/alinask/ucx/contributors","subscribers_url":"https://api.github.com/repos/alinask/ucx/subscribers","subscription_url":"https://api.github.com/repos/alinask/ucx/subscription","commits_url":"https://api.github.com/repos/alinask/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alinask/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alinask/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alinask/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/alinask/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/alinask/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alinask/ucx/merges","archive_url":"https://api.github.com/repos/alinask/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alinask/ucx/downloads","issues_url":"https://api.github.com/repos/alinask/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/alinask/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/alinask/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/alinask/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alinask/ucx/labels{/name}","releases_url":"https://api.github.com/repos/alinask/ucx/releases{/id}","created_at":"2015-07-14T11:34:14Z","updated_at":"2015-07-14T11:34:16Z","pushed_at":"2015-07-26T12:08:57Z","git_url":"git://github.com/alinask/ucx.git","ssh_url":"git@github.com:alinask/ucx.git","clone_url":"https://github.com/alinask/ucx.git","svn_url":"https://github.com/alinask/ucx","homepage":" http://www.openucx.org","size":1945,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"23bc4e4fa4e169d0048a981af3858dc732e6370b","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X : ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","created_at":"2014-10-17T22:17:24Z","updated_at":"2015-07-24T20:58:06Z","pushed_at":"2015-07-26T12:08:57Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":" http://www.openucx.org","size":4996,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":27,"forks":7,"open_issues":27,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/324"},"html":{"href":"https://github.com/openucx/ucx/pull/324"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/324"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/f7a6abde53508d7d906358a8b1f709f68f741cac"}}}}