{"action":"created","issue":{"url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1901","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1901/labels{/name}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1901/comments","events_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1901/events","html_url":"https://github.com/TauLabs/TauLabs/pull/1901","id":104618858,"number":1901,"title":"pipxtreme: force usb rx/tx buf to 256","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TauLabs/TauLabs/labels/blocker","name":"blocker","color":"e10c02"},{"url":"https://api.github.com/repos/TauLabs/TauLabs/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/TauLabs/TauLabs/labels/PR%20for%20merge","name":"PR for merge","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/TauLabs/TauLabs/milestones/1","html_url":"https://github.com/TauLabs/TauLabs/milestones/Endomorphism%20release","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/milestones/1/labels","id":1236348,"number":1,"title":"Endomorphism release","description":"https://github.com/TauLabs/TauLabs/wiki/Endomorphism-(September)-release","creator":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":66,"state":"open","created_at":"2015-08-01T19:01:06Z","updated_at":"2015-09-03T04:20:32Z","due_on":"2015-09-26T07:00:00Z","closed_at":null},"comments":13,"created_at":"2015-09-03T04:20:24Z","updated_at":"2015-09-03T23:58:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1901","html_url":"https://github.com/TauLabs/TauLabs/pull/1901","diff_url":"https://github.com/TauLabs/TauLabs/pull/1901.diff","patch_url":"https://github.com/TauLabs/TauLabs/pull/1901.patch"},"body":"Unknown why this is necessary-- exceeds the 65 of other targets.\r\n\r\nPresumably the radiocombridge module doesn't like buffering stuff itself.\r\n\r\nConfirmed to work and resolve #1897 between sparky2 & pipxtreme."},"comment":{"url":"https://api.github.com/repos/TauLabs/TauLabs/issues/comments/137604485","html_url":"https://github.com/TauLabs/TauLabs/pull/1901#issuecomment-137604485","issue_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1901","id":137604485,"user":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars.githubusercontent.com/u/9995998?v=3","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T23:58:08Z","updated_at":"2015-09-03T23:58:08Z","body":"Well this patch matches [the pre-HAL refactor buffer size](https://github.com/mlyle/TauLabs/blob/f42376dedb96de28d9e225aba51ebb3615927eea/flight/targets/pipxtreme/fw/pios_board.c#L40) for this target and is confirmed to fix the identified problem. It looks like we've also identified the reason why a larger buffer is required and raised an issue to rework the code and eliminate the need for this fix after the Endomorphism release. I think this is a clean enough solution until the code is reworked to use a smaller buffer? LGTM"}}