{"action":"created","issue":{"url":"https://api.github.com/repos/dockyard/ember-suave/issues/78","labels_url":"https://api.github.com/repos/dockyard/ember-suave/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/dockyard/ember-suave/issues/78/comments","events_url":"https://api.github.com/repos/dockyard/ember-suave/issues/78/events","html_url":"https://github.com/dockyard/ember-suave/issues/78","id":117025367,"number":78,"title":"Push custom rules upstream to `jscs-dev/node-jscs`","user":{"login":"seanpdoyle","id":2575027,"avatar_url":"https://avatars.githubusercontent.com/u/2575027?v=3","gravatar_id":"","url":"https://api.github.com/users/seanpdoyle","html_url":"https://github.com/seanpdoyle","followers_url":"https://api.github.com/users/seanpdoyle/followers","following_url":"https://api.github.com/users/seanpdoyle/following{/other_user}","gists_url":"https://api.github.com/users/seanpdoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpdoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpdoyle/subscriptions","organizations_url":"https://api.github.com/users/seanpdoyle/orgs","repos_url":"https://api.github.com/users/seanpdoyle/repos","events_url":"https://api.github.com/users/seanpdoyle/events{/privacy}","received_events_url":"https://api.github.com/users/seanpdoyle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-15T23:00:08Z","updated_at":"2015-11-17T13:42:36Z","closed_at":null,"body":"I've created PRs for a subset of `ember-suave`'s custom JSCS rules:\r\n\r\n* [disallowVar](https://github.com/jscs-dev/node-jscs/pull/1983)\r\n* [requireArrayDestructuring](https://github.com/jscs-dev/node-jscs/pull/1984)\r\n* [requireObjectDestructuring](https://github.com/jscs-dev/node-jscs/pull/1986)\r\n* [requireEnhancedObjectLiterals](https://github.com/jscs-dev/node-jscs/pull/1985)\r\n\r\nAs/if they get merged upstream, we should remove them from this package.\r\n\r\nAlso, how does `ember-suave`'s [requireTemplateStringsForConcatenation](https://github.com/dockyard/ember-suave/blob/master/lib/rules/require-template-strings-for-concatenation.js) from `node-jscs`'s [requireTemplateStrings](https://github.com/jscs-dev/node-jscs/blob/master/lib/rules/require-template-strings.js)?\r\n\r\nIf they're different, I'll gladly open a PR as well, I was just unsure if it was a duplicate rule."},"comment":{"url":"https://api.github.com/repos/dockyard/ember-suave/issues/comments/157373308","html_url":"https://github.com/dockyard/ember-suave/issues/78#issuecomment-157373308","issue_url":"https://api.github.com/repos/dockyard/ember-suave/issues/78","id":157373308,"user":{"login":"seanpdoyle","id":2575027,"avatar_url":"https://avatars.githubusercontent.com/u/2575027?v=3","gravatar_id":"","url":"https://api.github.com/users/seanpdoyle","html_url":"https://github.com/seanpdoyle","followers_url":"https://api.github.com/users/seanpdoyle/followers","following_url":"https://api.github.com/users/seanpdoyle/following{/other_user}","gists_url":"https://api.github.com/users/seanpdoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpdoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpdoyle/subscriptions","organizations_url":"https://api.github.com/users/seanpdoyle/orgs","repos_url":"https://api.github.com/users/seanpdoyle/repos","events_url":"https://api.github.com/users/seanpdoyle/events{/privacy}","received_events_url":"https://api.github.com/users/seanpdoyle/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T13:42:36Z","updated_at":"2015-11-17T13:42:36Z","body":"Merged:\r\n\r\n* `requireObjectDestructuring `: https://github.com/jscs-dev/node-jscs/commit/bc6f9608c78068c089e342b4b84c7fda98fa1552\r\n* `requireEnhancedObjectLiterals`: https://github.com/jscs-dev/node-jscs/commit/b8969d48584e169956422120d71be8f24e73f06b\r\n* `requireArrayDestructuring`: https://github.com/jscs-dev/node-jscs/commit/ecec961417f2b1aef17fe10d2a2231c7f3d50717\r\n* `disallowVar`: https://github.com/jscs-dev/node-jscs/commit/3c2dbf7eca2bf65b9985ff46d2c54317237c55d4\r\n\r\nLooks like they're in the `2.6.0` milestone"}}