{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/comments/32210505","id":32210505,"diff_hunk":"@@ -63,6 +89,7 @@ def test_412_on_collection_has_last_modified_timestamp(self):\n             self.resource.collection_get()\n         except httpexceptions.HTTPPreconditionFailed as e:\n             error = e\n+        self.assertIsNotNone(error.headers.get('ETag'))\n         self.assertIsNotNone(error.headers.get('Last-Modified'))","path":"cliquet/tests/resource/test_preconditions.py","position":76,"original_position":76,"commit_id":"f67165ca0ac6098216b87561a83cf89e182199dd","original_commit_id":"f67165ca0ac6098216b87561a83cf89e182199dd","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=3","gravatar_id":"","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":"Do we keep the Last-Modified header?","created_at":"2015-06-11T11:10:58Z","updated_at":"2015-06-11T11:10:58Z","html_url":"https://github.com/mozilla-services/cliquet/pull/275#discussion_r32210505","pull_request_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/comments/32210505"},"html":{"href":"https://github.com/mozilla-services/cliquet/pull/275#discussion_r32210505"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275","id":35939955,"html_url":"https://github.com/mozilla-services/cliquet/pull/275","diff_url":"https://github.com/mozilla-services/cliquet/pull/275.diff","patch_url":"https://github.com/mozilla-services/cliquet/pull/275.patch","issue_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/275","number":275,"state":"open","locked":false,"title":"Switch to cache/concurrency control to Etag (fixes #251)","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"* [x] Replaced IMS/IUMS by If-Match/If-None-Match\r\n* [x] Added ``ETag`` CORS exposed headers \r\n* [x] Updated resource endpoint docs\r\n* [x] Completed timestamps section docs\r\n* [x] Made sure the ETag returned with 412 is the one of record, not whole collection\r\n\r\n@Natim @ametaireau  r? \r\n\r\nQuestions:\r\n\r\n* Should we still support IMS and IUMS headers using HTTP date even if their equivalent timestamp value is rounded to second ?\r\n   * *I don't think so because there would be two ways to achieve the same goal*\r\n* Did I manage ``If-None-Match: *`` properly ?\r\n\r\n**note:**\r\nTests fails because of random CloudStorage backend ``BackendError: ConnectionError: ('Connection aborted.', error(104, 'Connection reset by peer'))``\r\n\r\n","created_at":"2015-05-21T14:35:51Z","updated_at":"2015-06-11T11:10:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e247f25c809da233b9ad521f0568f516a7505c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/275/comments","statuses_url":"https://api.github.com/repos/mozilla-services/cliquet/statuses/f67165ca0ac6098216b87561a83cf89e182199dd","head":{"label":"mozilla-services:251-switch-to-etags","ref":"251-switch-to-etags","sha":"f67165ca0ac6098216b87561a83cf89e182199dd","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":30921526,"name":"cliquet","full_name":"mozilla-services/cliquet","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/cliquet","description":"Cloud services API toolkit","fork":false,"url":"https://api.github.com/repos/mozilla-services/cliquet","forks_url":"https://api.github.com/repos/mozilla-services/cliquet/forks","keys_url":"https://api.github.com/repos/mozilla-services/cliquet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/cliquet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/cliquet/teams","hooks_url":"https://api.github.com/repos/mozilla-services/cliquet/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/cliquet/events","assignees_url":"https://api.github.com/repos/mozilla-services/cliquet/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/cliquet/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/cliquet/tags","blobs_url":"https://api.github.com/repos/mozilla-services/cliquet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/cliquet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/cliquet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/cliquet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/cliquet/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/cliquet/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/cliquet/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/cliquet/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/cliquet/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/cliquet/subscription","commits_url":"https://api.github.com/repos/mozilla-services/cliquet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/cliquet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/cliquet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/cliquet/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/cliquet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/cliquet/merges","archive_url":"https://api.github.com/repos/mozilla-services/cliquet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/cliquet/downloads","issues_url":"https://api.github.com/repos/mozilla-services/cliquet/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/cliquet/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/cliquet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/cliquet/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/cliquet/releases{/id}","created_at":"2015-02-17T14:53:58Z","updated_at":"2015-05-08T16:52:59Z","pushed_at":"2015-06-11T11:10:10Z","git_url":"git://github.com/mozilla-services/cliquet.git","ssh_url":"git@github.com:mozilla-services/cliquet.git","clone_url":"https://github.com/mozilla-services/cliquet.git","svn_url":"https://github.com/mozilla-services/cliquet","homepage":"http://cliquet.readthedocs.org","size":5124,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":49,"forks":4,"open_issues":49,"watchers":7,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"f2df64d8ffe61c70e5b13b57929001b05eb8ffd3","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":30921526,"name":"cliquet","full_name":"mozilla-services/cliquet","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/cliquet","description":"Cloud services API toolkit","fork":false,"url":"https://api.github.com/repos/mozilla-services/cliquet","forks_url":"https://api.github.com/repos/mozilla-services/cliquet/forks","keys_url":"https://api.github.com/repos/mozilla-services/cliquet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/cliquet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/cliquet/teams","hooks_url":"https://api.github.com/repos/mozilla-services/cliquet/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/cliquet/events","assignees_url":"https://api.github.com/repos/mozilla-services/cliquet/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/cliquet/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/cliquet/tags","blobs_url":"https://api.github.com/repos/mozilla-services/cliquet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/cliquet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/cliquet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/cliquet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/cliquet/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/cliquet/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/cliquet/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/cliquet/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/cliquet/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/cliquet/subscription","commits_url":"https://api.github.com/repos/mozilla-services/cliquet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/cliquet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/cliquet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/cliquet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/cliquet/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/cliquet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/cliquet/merges","archive_url":"https://api.github.com/repos/mozilla-services/cliquet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/cliquet/downloads","issues_url":"https://api.github.com/repos/mozilla-services/cliquet/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/cliquet/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/cliquet/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/cliquet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/cliquet/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/cliquet/releases{/id}","created_at":"2015-02-17T14:53:58Z","updated_at":"2015-05-08T16:52:59Z","pushed_at":"2015-06-11T11:10:10Z","git_url":"git://github.com/mozilla-services/cliquet.git","ssh_url":"git@github.com:mozilla-services/cliquet.git","clone_url":"https://github.com/mozilla-services/cliquet.git","svn_url":"https://github.com/mozilla-services/cliquet","homepage":"http://cliquet.readthedocs.org","size":5124,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":49,"forks":4,"open_issues":49,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275"},"html":{"href":"https://github.com/mozilla-services/cliquet/pull/275"},"issue":{"href":"https://api.github.com/repos/mozilla-services/cliquet/issues/275"},"comments":{"href":"https://api.github.com/repos/mozilla-services/cliquet/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/cliquet/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/cliquet/statuses/f67165ca0ac6098216b87561a83cf89e182199dd"}}}}