{"action":"closed","issue":{"url":"https://api.github.com/repos/mailwatch/1.2.0/issues/155","labels_url":"https://api.github.com/repos/mailwatch/1.2.0/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/mailwatch/1.2.0/issues/155/comments","events_url":"https://api.github.com/repos/mailwatch/1.2.0/issues/155/events","html_url":"https://github.com/mailwatch/1.2.0/issues/155","id":85223301,"number":155,"title":"Header information doesn't display if GeoIP files are zero byte","user":{"login":"atftb","id":6208697,"avatar_url":"https://avatars.githubusercontent.com/u/6208697?v=3","gravatar_id":"","url":"https://api.github.com/users/atftb","html_url":"https://github.com/atftb","followers_url":"https://api.github.com/users/atftb/followers","following_url":"https://api.github.com/users/atftb/following{/other_user}","gists_url":"https://api.github.com/users/atftb/gists{/gist_id}","starred_url":"https://api.github.com/users/atftb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atftb/subscriptions","organizations_url":"https://api.github.com/users/atftb/orgs","repos_url":"https://api.github.com/users/atftb/repos","events_url":"https://api.github.com/users/atftb/events{/privacy}","received_events_url":"https://api.github.com/users/atftb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mailwatch/1.2.0/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/mailwatch/1.2.0/labels/duplicate","name":"duplicate","color":"cccccc"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mailwatch/1.2.0/milestones/1","html_url":"https://github.com/mailwatch/1.2.0/milestones/v1.2.0","labels_url":"https://api.github.com/repos/mailwatch/1.2.0/milestones/1/labels","id":533753,"number":1,"title":"v1.2.0","description":"","creator":{"login":"endelwar","id":28512,"avatar_url":"https://avatars.githubusercontent.com/u/28512?v=3","gravatar_id":"","url":"https://api.github.com/users/endelwar","html_url":"https://github.com/endelwar","followers_url":"https://api.github.com/users/endelwar/followers","following_url":"https://api.github.com/users/endelwar/following{/other_user}","gists_url":"https://api.github.com/users/endelwar/gists{/gist_id}","starred_url":"https://api.github.com/users/endelwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endelwar/subscriptions","organizations_url":"https://api.github.com/users/endelwar/orgs","repos_url":"https://api.github.com/users/endelwar/repos","events_url":"https://api.github.com/users/endelwar/events{/privacy}","received_events_url":"https://api.github.com/users/endelwar/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":57,"state":"open","created_at":"2014-01-12T09:40:02Z","updated_at":"2015-09-17T17:46:12Z","due_on":"2015-07-30T22:00:00Z","closed_at":null},"comments":0,"created_at":"2015-06-04T18:43:02Z","updated_at":"2015-09-17T17:46:12Z","closed_at":"2015-09-17T17:46:12Z","body":"If the process to update the GeoIP process doesn't complete properly and leaves behind zero length files in the temp directory, the header information doesn't display on the detail.php page.  If the sparse files are removed, the message header is displayed properly.\r\n\r\nThe sparse files are left behind when the geoip_update.php process is run and php-curl isn't installed.  No warning is given that the download failed.  I suspect that is because the script exams the return code from curl, but since curl isn't called the rc isn't set, so appears to succeed.  But that's just a SWAG, as I'm not a php programmer.  \r\n\r\nThe simplest fix to me, seems to be to test that the  GeoIPv6.dat.gz and GeoIP.dat.gz files aren't zero length after download. If they are, they should be deleted so they don't interfere with the header display.  It may be prudent to also look a the status.php code to so it displays regardless of the existence of the zero byte files, as there may be other actions which cause a zero byte file to be created.\r\n\r\nAlso, php-curl should be noted as a requirement in the docs.\r\n\r\nThanks much.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/20465665-header-information-doesn-t-display-if-geoip-files-are-zero-byte?utm_campaign=plugin&utm_content=tracker%2F585686&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F585686&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"}}