{"action":"created","issue":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/179","labels_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/179/comments","events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/179/events","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/179","id":94620390,"number":179,"title":"SKELETON for electron trigger matching","user":{"login":"mmilesi","id":12515122,"avatar_url":"https://avatars.githubusercontent.com/u/12515122?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilesi","html_url":"https://github.com/mmilesi","followers_url":"https://api.github.com/users/mmilesi/followers","following_url":"https://api.github.com/users/mmilesi/following{/other_user}","gists_url":"https://api.github.com/users/mmilesi/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilesi/subscriptions","organizations_url":"https://api.github.com/users/mmilesi/orgs","repos_url":"https://api.github.com/users/mmilesi/repos","events_url":"https://api.github.com/users/mmilesi/events{/privacy}","received_events_url":"https://api.github.com/users/mmilesi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-13T02:03:37Z","updated_at":"2015-07-15T09:34:01Z","closed_at":"2015-07-15T00:52:46Z","pull_request":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/pulls/179","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/179","diff_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/179.diff","patch_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/179.patch"},"body":"Hi @kratsg, @johnda102, @jdandoy, @gfacini ,\r\n\r\nthis PR contains mostly the code to perform the electron trigger matching and to conveniently store the matching info on the final tree.\r\n\r\nPlease, have a detailed look at the commit message and at the code to get an idea of what I have added. In the config file for the ElectronSelection.cxx module you can find some detailed explanations on how to configure the matching.\r\n\r\nSadly, at this stage the ASG TrigEgammaMatchingTool - which is included in the release and is supposed to perform the matching - does **not** work outside Athena due to some not-well-defined issues with parts of the TrigDecisionTool which are used by the tool internally.\r\n\r\nThis does not mean however that the code will crash: simply, we do not see any trigger-matched electron whatsoever.\r\n\r\nUlla confirmed however that a working version of the tool will be available (hopefully) soon for RootCore based analyses too, and I do believe the interface won't be much different to the one we have atm. \r\nAlso, my additions do not cause any problem with the rest of the code, so should be safe to incorporate them.\r\n\r\n**CAVEAT**\r\n\r\nI have added a pointer to  xAOD::TStore (in addition to the one to xAOD::Event, that was already in place) as an additional parameter to HelpTreeBase constructor:\r\n\r\nhttps://github.com/UCATLAS/xAODAnaHelpers/blob/EgammaTrigMatching/xAODAnaHelpers/HelpTreeBase.h#L49\r\n\r\nI did this because I needed it in a temporary implementation of the matching. If people are not happy with it, I can edit the PR and go back to the previous implementation, but I still believe it could be useful to have access to TStore in the tree in the future.\r\n\r\nSorry for the super long message\r\n"},"comment":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/comments/121549290","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/pull/179#issuecomment-121549290","issue_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/179","id":121549290,"user":{"login":"gfacini","id":10064627,"avatar_url":"https://avatars.githubusercontent.com/u/10064627?v=3","gravatar_id":"","url":"https://api.github.com/users/gfacini","html_url":"https://github.com/gfacini","followers_url":"https://api.github.com/users/gfacini/followers","following_url":"https://api.github.com/users/gfacini/following{/other_user}","gists_url":"https://api.github.com/users/gfacini/gists{/gist_id}","starred_url":"https://api.github.com/users/gfacini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfacini/subscriptions","organizations_url":"https://api.github.com/users/gfacini/orgs","repos_url":"https://api.github.com/users/gfacini/repos","events_url":"https://api.github.com/users/gfacini/events{/privacy}","received_events_url":"https://api.github.com/users/gfacini/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T09:34:01Z","updated_at":"2015-07-15T09:34:01Z","body":"Bottom line....we need to communicate better about rush\nperiods so that we avoid snafus in the future.  No fingers\nto point here - we just do it better the next time.\n\nMarco, I appreciate you flexibility and patience!\n\nI promise, as soon as I can, Ill go through your changes\nand try to get us adjusted to them so you are not in\na further delay.\n\nThanks again for the help and patience!\n\nCheers,\nGabriel\n\n\n\nOn Wed, Jul 15, 2015 at 11:26 AM, jdandoy <notifications@github.com> wrote:\n\n> Sorry I had assumed you were aware about EPS!! Right now most every\n> analysis that is using this package is rushing to freeze results (by\n> friday) on brand new data we're actively collecting in time for EPS next\n> week.\n>\n> I didn't know the README was a place for technical development\n> requirements, I don't think we've listed any rules for this sort of\n> situation as it hasn't come up before, maybe we should. So there's no\n> blame to go here, just miscommunication. But neither myself, John, or\n> Gabriel noticed this would happen. The email subject should say something\n> about breaking packages, and if you don't get any response maybe it would\n> be best to message us. Again this is literally the busiest time of my\n> entire life.\n>\n> I'm not as proficient in git as you and Giordon so I'm going to try to just\n> make a reverted branch for our EPS analysis now with my recent additions.\n>\n> Jeff\n>\n>\n>\n> On Wed, Jul 15, 2015 at 11:13 AM, Marco Milesi <notifications@github.com>\n> wrote:\n>\n> > Hi @jdandoy <https://github.com/jdandoy>\n> >\n> > I have waited 2 days before merging this. I am sorry but having\n> explicitly\n> > tagged all the people that might be involved by the changes I was\n> expecting\n> > them to pay attention, at least at the careful description I gave in the\n> > PR.\n> >\n> > If you want to make a statement in the README to freeze the PRs, for me\n> > it's just fine.\n> >\n> > Also, please bear in mind that maybe not everyone knows what others are\n> up\n> > to at anytime, so if there are some delicate things ongoing please make\n> an\n> > announcement so that everyone knows. Perhaps the good old mailing list is\n> > the best place to go.\n> >\n> > And of course you can go ahead and revert this PR if it's causing issues.\n> >\n> > Cheers\n> > Marco\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <\n> https://github.com/UCATLAS/xAODAnaHelpers/pull/179#issuecomment-121540548>\n>\n> > .\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/UCATLAS/xAODAnaHelpers/pull/179#issuecomment-121547136>\n> .\n>\n"}}