{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/408","labels_url":"https://api.github.com/repos/apache/flink/issues/408/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/408/comments","events_url":"https://api.github.com/repos/apache/flink/issues/408/events","html_url":"https://github.com/apache/flink/pull/408","id":57829597,"number":408,"title":"[FLINK-1514][Gelly] Add a Gather-Sum-Apply iteration method","user":{"login":"balidani","id":1805302,"avatar_url":"https://avatars.githubusercontent.com/u/1805302?v=3","gravatar_id":"","url":"https://api.github.com/users/balidani","html_url":"https://github.com/balidani","followers_url":"https://api.github.com/users/balidani/followers","following_url":"https://api.github.com/users/balidani/following{/other_user}","gists_url":"https://api.github.com/users/balidani/gists{/gist_id}","starred_url":"https://api.github.com/users/balidani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balidani/subscriptions","organizations_url":"https://api.github.com/users/balidani/orgs","repos_url":"https://api.github.com/users/balidani/repos","events_url":"https://api.github.com/users/balidani/events{/privacy}","received_events_url":"https://api.github.com/users/balidani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-16T17:12:18Z","updated_at":"2015-02-20T14:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/408","html_url":"https://github.com/apache/flink/pull/408","diff_url":"https://github.com/apache/flink/pull/408.diff","patch_url":"https://github.com/apache/flink/pull/408.patch"},"body":"Hi!\r\n\r\nI implemented the Gather-Sum-Apply iteration method, it is much nicer now than the previous (`flink-graph`) version. I also added a SSSP test case to the already existing graph coloring one."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/75249793","html_url":"https://github.com/apache/flink/pull/408#issuecomment-75249793","issue_url":"https://api.github.com/repos/apache/flink/issues/408","id":75249793,"user":{"login":"vasia","id":498957,"avatar_url":"https://avatars.githubusercontent.com/u/498957?v=3","gravatar_id":"","url":"https://api.github.com/users/vasia","html_url":"https://github.com/vasia","followers_url":"https://api.github.com/users/vasia/followers","following_url":"https://api.github.com/users/vasia/following{/other_user}","gists_url":"https://api.github.com/users/vasia/gists{/gist_id}","starred_url":"https://api.github.com/users/vasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasia/subscriptions","organizations_url":"https://api.github.com/users/vasia/orgs","repos_url":"https://api.github.com/users/vasia/repos","events_url":"https://api.github.com/users/vasia/events{/privacy}","received_events_url":"https://api.github.com/users/vasia/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T14:52:11Z","updated_at":"2015-02-20T14:52:11Z","body":"Hi @balidani! Thanks a lot for this PR! Gather-Sum-Apply will be an awesome addition to Gelly ^^\r\nHere come my comments:\r\n\r\n- There's no need for Gather, Sum and Apply functions to implement MapFunction, FlatJoinFunction, etc., since they are wrapped inside those in GatherSumApplyIteration class. Actually, I would use the Rich* versions instead, so that we can have access to open() and close() methods. You can look at how `VertexCentricIteration` wraps the `VertexUpdateFunction` inside a `RichCoGroupFunction`.\r\n\r\n- With this small change above, we could also allow access to aggregators and broadcast sets. This must be straight-forward to add (again look at `VertexCentricIteration` for hints). We should also add `getName()`, `setName()`, `getParallelism()`, `setParallelism()` methods to `GatherSumApplyIteration`.\r\n\r\n- Finally, it'd be great if you could add the tests you have as examples, i.e. one for Greedy Graph Coloring and one for GSAShortestPaths.\r\n\r\nLet me know if you have any doubts!\r\n\r\nThanks again :sunny:"}}