{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18568","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18568/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18568/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18568/events","html_url":"https://github.com/kubernetes/kubernetes/issues/18568","id":121673963,"number":18568,"title":"Rolling updates should fail early if a pod fails to start","user":{"login":"jsravn","id":522123,"avatar_url":"https://avatars.githubusercontent.com/u/522123?v=3","gravatar_id":"","url":"https://api.github.com/users/jsravn","html_url":"https://github.com/jsravn","followers_url":"https://api.github.com/users/jsravn/followers","following_url":"https://api.github.com/users/jsravn/following{/other_user}","gists_url":"https://api.github.com/users/jsravn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsravn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsravn/subscriptions","organizations_url":"https://api.github.com/users/jsravn/orgs","repos_url":"https://api.github.com/users/jsravn/repos","events_url":"https://api.github.com/users/jsravn/events{/privacy}","received_events_url":"https://api.github.com/users/jsravn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/CSI","name":"team/CSI","color":"d2b48c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-11T09:50:13Z","updated_at":"2015-12-14T16:56:12Z","closed_at":null,"body":"In 1.0.x, rolling update didn't block, so we could check things like a failed pod while waiting for the update to complete.\r\n\r\nIn 1.1.x, rolling update does block up to the timeout amount. This is great since we had to script it externally before. However it waits the entire timeout even if the update fails immediately. For instance, if you specify a non-existent image the pod will report a `PullImageError`. At that point the rolling update could abort immediately. Instead it blocks for the 5 minute timeout. When frequently developing and deploying this 5 minute timeout becomes painful.\r\n\r\nI suggest rolling-update fails immediately if any of the new pods are not in a 'Pending' or 'Running' state. Not sure if there is a set of non-error states we can use.\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/164493493","html_url":"https://github.com/kubernetes/kubernetes/issues/18568#issuecomment-164493493","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18568","id":164493493,"user":{"login":"jsravn","id":522123,"avatar_url":"https://avatars.githubusercontent.com/u/522123?v=3","gravatar_id":"","url":"https://api.github.com/users/jsravn","html_url":"https://github.com/jsravn","followers_url":"https://api.github.com/users/jsravn/followers","following_url":"https://api.github.com/users/jsravn/following{/other_user}","gists_url":"https://api.github.com/users/jsravn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsravn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsravn/subscriptions","organizations_url":"https://api.github.com/users/jsravn/orgs","repos_url":"https://api.github.com/users/jsravn/repos","events_url":"https://api.github.com/users/jsravn/events{/privacy}","received_events_url":"https://api.github.com/users/jsravn/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T16:56:11Z","updated_at":"2015-12-14T16:56:11Z","body":"The more I think about it, the more I think it's a bug in kubelet with docker. I think it should report the pod as `Failed` if the image pull fails. Then we can have some sensible policies to deal with the failure (whether it's to abort the rolling update, or to try pulling the image again)."}}