{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/30044112","id":30044112,"diff_hunk":"@@ -0,0 +1,218 @@\n+package aws\n+\n+import (\n+\t\"fmt\"\n+\t\"testing\"\n+\n+\t\"github.com/hashicorp/terraform/helper/resource\"\n+\t\"github.com/hashicorp/terraform/helper/schema\"\n+\t\"github.com/hashicorp/terraform/terraform\"\n+\n+\t\"github.com/awslabs/aws-sdk-go/aws\"\n+\t\"github.com/awslabs/aws-sdk-go/service/route53\"\n+)\n+\n+func TestAccRoute53ZoneAssociation(t *testing.T) {\n+\tvar zone route53.HostedZone\n+\n+\tresource.Test(t, resource.TestCase{\n+\t\tPreCheck:     func() { testAccPreCheck(t) },\n+\t\tProviders:    testAccProviders,\n+\t\tCheckDestroy: testAccCheckRoute53ZoneAssociationDestroy,\n+\t\tSteps: []resource.TestStep{\n+\t\t\tresource.TestStep{\n+\t\t\t\tConfig: testAccRoute53ZoneAssociationConfig,\n+\t\t\t\tCheck: resource.ComposeTestCheckFunc(\n+\t\t\t\t\ttestAccCheckRoute53ZoneAssociationExists(\"aws_route53_zone_association.foobar\", &zone),\n+\t\t\t\t),\n+\t\t\t},\n+\t\t},\n+\t})\n+}\n+\n+func TestAccRoute53ZoneAssociationWithRegion(t *testing.T) {\n+\tvar zone route53.HostedZone","path":"builtin/providers/aws/resource_aws_route53_zone_association_test.go","position":34,"original_position":34,"commit_id":"ba3a4483ccd2539bf2431dce0d8493ac0a3606fe","original_commit_id":"ba3a4483ccd2539bf2431dce0d8493ac0a3606fe","user":{"login":"catsby","id":61721,"avatar_url":"https://avatars.githubusercontent.com/u/61721?v=3","gravatar_id":"","url":"https://api.github.com/users/catsby","html_url":"https://github.com/catsby","followers_url":"https://api.github.com/users/catsby/followers","following_url":"https://api.github.com/users/catsby/following{/other_user}","gists_url":"https://api.github.com/users/catsby/gists{/gist_id}","starred_url":"https://api.github.com/users/catsby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catsby/subscriptions","organizations_url":"https://api.github.com/users/catsby/orgs","repos_url":"https://api.github.com/users/catsby/repos","events_url":"https://api.github.com/users/catsby/events{/privacy}","received_events_url":"https://api.github.com/users/catsby/received_events","type":"User","site_admin":false},"body":"We pass this `zone` var around through almost all the functions below, but beyond setting it `*zone = *resp.HostedZone` I don't see it's actually used. Should we be checking a value on it? Otherwise, it seems to be baggage. ","created_at":"2015-05-11T14:42:15Z","updated_at":"2015-05-11T14:42:15Z","html_url":"https://github.com/hashicorp/terraform/pull/1526#discussion_r30044112","pull_request_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1526","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/30044112"},"html":{"href":"https://github.com/hashicorp/terraform/pull/1526#discussion_r30044112"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1526"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/1526","id":33293147,"html_url":"https://github.com/hashicorp/terraform/pull/1526","diff_url":"https://github.com/hashicorp/terraform/pull/1526.diff","patch_url":"https://github.com/hashicorp/terraform/pull/1526.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/1526","number":1526,"state":"open","locked":false,"title":"AWS/Route53Zone - create private hosted zone associated with VPC.","user":{"login":"johnrengelman","id":1012772,"avatar_url":"https://avatars.githubusercontent.com/u/1012772?v=3","gravatar_id":"","url":"https://api.github.com/users/johnrengelman","html_url":"https://github.com/johnrengelman","followers_url":"https://api.github.com/users/johnrengelman/followers","following_url":"https://api.github.com/users/johnrengelman/following{/other_user}","gists_url":"https://api.github.com/users/johnrengelman/gists{/gist_id}","starred_url":"https://api.github.com/users/johnrengelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnrengelman/subscriptions","organizations_url":"https://api.github.com/users/johnrengelman/orgs","repos_url":"https://api.github.com/users/johnrengelman/repos","events_url":"https://api.github.com/users/johnrengelman/events{/privacy}","received_events_url":"https://api.github.com/users/johnrengelman/received_events","type":"User","site_admin":false},"body":"Add ability to create a private Hosted Zone that is associated to a VPC. \r\nCurrently only supports a single VPC at creation time. \r\n\r\nFuture question is how to support multiple VPCs. Amazon uses a Associate/Disassociate request, however this is problematic since you must specify one (and only one) VPC during creation.\r\n\r\nAlternatively, we could model it as a VPC Set and and use the first entry as the entry for creating and then associate the others.","created_at":"2015-04-14T19:50:33Z","updated_at":"2015-05-11T14:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d2f72c0ddac95fe30d0065ab63b8ace063502d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1526/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/1526/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/1526/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/ba3a4483ccd2539bf2431dce0d8493ac0a3606fe","head":{"label":"PeopleNet:route53_private_hosted_zone","ref":"route53_private_hosted_zone","sha":"ba3a4483ccd2539bf2431dce0d8493ac0a3606fe","user":{"login":"PeopleNet","id":6352710,"avatar_url":"https://avatars.githubusercontent.com/u/6352710?v=3","gravatar_id":"","url":"https://api.github.com/users/PeopleNet","html_url":"https://github.com/PeopleNet","followers_url":"https://api.github.com/users/PeopleNet/followers","following_url":"https://api.github.com/users/PeopleNet/following{/other_user}","gists_url":"https://api.github.com/users/PeopleNet/gists{/gist_id}","starred_url":"https://api.github.com/users/PeopleNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeopleNet/subscriptions","organizations_url":"https://api.github.com/users/PeopleNet/orgs","repos_url":"https://api.github.com/users/PeopleNet/repos","events_url":"https://api.github.com/users/PeopleNet/events{/privacy}","received_events_url":"https://api.github.com/users/PeopleNet/received_events","type":"Organization","site_admin":false},"repo":{"id":33672020,"name":"terraform","full_name":"PeopleNet/terraform","owner":{"login":"PeopleNet","id":6352710,"avatar_url":"https://avatars.githubusercontent.com/u/6352710?v=3","gravatar_id":"","url":"https://api.github.com/users/PeopleNet","html_url":"https://github.com/PeopleNet","followers_url":"https://api.github.com/users/PeopleNet/followers","following_url":"https://api.github.com/users/PeopleNet/following{/other_user}","gists_url":"https://api.github.com/users/PeopleNet/gists{/gist_id}","starred_url":"https://api.github.com/users/PeopleNet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeopleNet/subscriptions","organizations_url":"https://api.github.com/users/PeopleNet/orgs","repos_url":"https://api.github.com/users/PeopleNet/repos","events_url":"https://api.github.com/users/PeopleNet/events{/privacy}","received_events_url":"https://api.github.com/users/PeopleNet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PeopleNet/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/PeopleNet/terraform","forks_url":"https://api.github.com/repos/PeopleNet/terraform/forks","keys_url":"https://api.github.com/repos/PeopleNet/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeopleNet/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeopleNet/terraform/teams","hooks_url":"https://api.github.com/repos/PeopleNet/terraform/hooks","issue_events_url":"https://api.github.com/repos/PeopleNet/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/PeopleNet/terraform/events","assignees_url":"https://api.github.com/repos/PeopleNet/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/PeopleNet/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/PeopleNet/terraform/tags","blobs_url":"https://api.github.com/repos/PeopleNet/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeopleNet/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeopleNet/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeopleNet/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeopleNet/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/PeopleNet/terraform/languages","stargazers_url":"https://api.github.com/repos/PeopleNet/terraform/stargazers","contributors_url":"https://api.github.com/repos/PeopleNet/terraform/contributors","subscribers_url":"https://api.github.com/repos/PeopleNet/terraform/subscribers","subscription_url":"https://api.github.com/repos/PeopleNet/terraform/subscription","commits_url":"https://api.github.com/repos/PeopleNet/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeopleNet/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeopleNet/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeopleNet/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeopleNet/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/PeopleNet/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeopleNet/terraform/merges","archive_url":"https://api.github.com/repos/PeopleNet/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeopleNet/terraform/downloads","issues_url":"https://api.github.com/repos/PeopleNet/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/PeopleNet/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/PeopleNet/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/PeopleNet/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeopleNet/terraform/labels{/name}","releases_url":"https://api.github.com/repos/PeopleNet/terraform/releases{/id}","created_at":"2015-04-09T13:58:51Z","updated_at":"2015-04-09T13:58:54Z","pushed_at":"2015-05-11T14:12:24Z","git_url":"git://github.com/PeopleNet/terraform.git","ssh_url":"git@github.com:PeopleNet/terraform.git","clone_url":"https://github.com/PeopleNet/terraform.git","svn_url":"https://github.com/PeopleNet/terraform","homepage":"http://www.terraform.io","size":22416,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"d08ba05d2c554db349954aa98bafb5896fccac31","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","created_at":"2014-03-13T22:25:48Z","updated_at":"2015-05-11T14:04:09Z","pushed_at":"2015-05-11T14:12:45Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"http://www.terraform.io","size":48167,"stargazers_count":2375,"watchers_count":2375,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":267,"forks":419,"open_issues":267,"watchers":2375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1526"},"html":{"href":"https://github.com/hashicorp/terraform/pull/1526"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/1526"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/1526/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1526/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/1526/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/ba3a4483ccd2539bf2431dce0d8493ac0a3606fe"}}}}