{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/crust/issues/358","labels_url":"https://api.github.com/repos/maidsafe/crust/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/358/comments","events_url":"https://api.github.com/repos/maidsafe/crust/issues/358/events","html_url":"https://github.com/maidsafe/crust/pull/358","id":111393378,"number":358,"title":"fix API breakage introduced in temp_utp 0.6.12","user":{"login":"vinipsmaker","id":865914,"avatar_url":"https://avatars.githubusercontent.com/u/865914?v=3","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker","html_url":"https://github.com/vinipsmaker","followers_url":"https://api.github.com/users/vinipsmaker/followers","following_url":"https://api.github.com/users/vinipsmaker/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker/orgs","repos_url":"https://api.github.com/users/vinipsmaker/repos","events_url":"https://api.github.com/users/vinipsmaker/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/maidsafe/crust/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"inetic","id":40127,"avatar_url":"https://avatars.githubusercontent.com/u/40127?v=3","gravatar_id":"","url":"https://api.github.com/users/inetic","html_url":"https://github.com/inetic","followers_url":"https://api.github.com/users/inetic/followers","following_url":"https://api.github.com/users/inetic/following{/other_user}","gists_url":"https://api.github.com/users/inetic/gists{/gist_id}","starred_url":"https://api.github.com/users/inetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inetic/subscriptions","organizations_url":"https://api.github.com/users/inetic/orgs","repos_url":"https://api.github.com/users/inetic/repos","events_url":"https://api.github.com/users/inetic/events{/privacy}","received_events_url":"https://api.github.com/users/inetic/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-14T13:03:01Z","updated_at":"2015-10-14T13:03:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/358","html_url":"https://github.com/maidsafe/crust/pull/358","diff_url":"https://github.com/maidsafe/crust/pull/358.diff","patch_url":"https://github.com/maidsafe/crust/pull/358.patch"},"body":"Crust depends on UtpSocket::peer_fn, which was introduced earlier in our\r\ntemporary fork.\r\n\r\nWhen adopted upstream, this function used a different API, returning\r\n`Result<T>` instead `T`.\r\n\r\ntemp_utp 0.6.12 was released to match upstream API and our API broke.\r\nThis commit fixes that.\r\n\r\nMore information on the API change reason:\r\n\r\n> I disagree that peer_addr should return SocketAddr directly for two\r\n> reasons: a socket's connected_to may be incorrect when the socket is\r\n> in a state other than Connected or FinSent, and I wish to keep the\r\n> library's API as closes as reasonable to TcpStream's.\r\n  -- https://github.com/meqif/rust-utp/pull/13#issuecomment-148024294\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/358)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/crust/issues/comments/148042899","html_url":"https://github.com/maidsafe/crust/pull/358#issuecomment-148042899","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/358","id":148042899,"user":{"login":"maidsafe-highfive","id":12443540,"avatar_url":"https://avatars.githubusercontent.com/u/12443540?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe-highfive","html_url":"https://github.com/maidsafe-highfive","followers_url":"https://api.github.com/users/maidsafe-highfive/followers","following_url":"https://api.github.com/users/maidsafe-highfive/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe-highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe-highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe-highfive/subscriptions","organizations_url":"https://api.github.com/users/maidsafe-highfive/orgs","repos_url":"https://api.github.com/users/maidsafe-highfive/repos","events_url":"https://api.github.com/users/maidsafe-highfive/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe-highfive/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T13:03:08Z","updated_at":"2015-10-14T13:03:08Z","body":"r? @inetic\n\n(maidsafe_highfive has picked a reviewer for you, use r? to override)"}}