{"action":"created","issue":{"url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/159","labels_url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/159/comments","events_url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/159/events","html_url":"https://github.com/Adaptv/adapt-strap/pull/159","id":56085546,"number":159,"title":"Add column filters, table fixed height and other minor changes","user":{"login":"brianchance","id":1154287,"avatar_url":"https://avatars.githubusercontent.com/u/1154287?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchance","html_url":"https://github.com/brianchance","followers_url":"https://api.github.com/users/brianchance/followers","following_url":"https://api.github.com/users/brianchance/following{/other_user}","gists_url":"https://api.github.com/users/brianchance/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchance/subscriptions","organizations_url":"https://api.github.com/users/brianchance/orgs","repos_url":"https://api.github.com/users/brianchance/repos","events_url":"https://api.github.com/users/brianchance/events{/privacy}","received_events_url":"https://api.github.com/users/brianchance/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-30T21:14:16Z","updated_at":"2015-02-02T18:32:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Adaptv/adapt-strap/pulls/159","html_url":"https://github.com/Adaptv/adapt-strap/pull/159","diff_url":"https://github.com/Adaptv/adapt-strap/pull/159.diff","patch_url":"https://github.com/Adaptv/adapt-strap/pull/159.patch"},"body":"First off, table lite is great. Hard to find, but works awesome. I made a few additions to meet our needs I thought I might pass along in the hope others could use them. I made individual commits so you could cherry pick you want.\r\n\r\nChanges\r\n- Added default pageSize/pageSizes to $adConfig.paging so they can be set once across all views\r\n- Removed an extra \"next page\" button from pagination.html\r\n- Added a check to see if searchText had a value before calling filter\r\n- Changed the search to always go to page 1. If you are on a page that is less than the results, no rows show up and all the paging controls go away\r\n  - You can see this on the demo page, go to page 2, then search for S8\r\n- Added a css class to the paging container for styling\r\n- Added table-fixed-height as an option, like table-max-height, it causes the table to scroll, but keeps it at a constant size. This helps if you have 2 or 3 tables stacked and they all stay in the same place.\r\n- Emit an event whenever a page changes 'adTableLite:pageChanged'. We wanted to clear the selected items when the page changes.\r\n- Added filters per column that work in addition to the gobal searchText. Usage...\r\n  - set enable-filtering=\"true\"\r\n  - optionally set filter-debounce=\"400\" to change the default debounce of 400\r\n  - each column will output a text box unless you specify enableFiltering: false on the column definition\r\n    - Another option here would be to specify a filterKey on each column definition to opt in, which would be more like sortKey\r\n  - when filter is enabled, the selection checkbox is moved down to the filter row\r\n\r\nscreen shot of filters\r\n\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1154287/5983391/71bdb478-a892-11e4-9073-530b10513960.png)\r\n\r\n\r\nLet me know if you have any questions. \r\n\r\nBrian"},"comment":{"url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/comments/72510685","html_url":"https://github.com/Adaptv/adapt-strap/pull/159#issuecomment-72510685","issue_url":"https://api.github.com/repos/Adaptv/adapt-strap/issues/159","id":72510685,"user":{"login":"kashjs","id":3316756,"avatar_url":"https://avatars.githubusercontent.com/u/3316756?v=3","gravatar_id":"","url":"https://api.github.com/users/kashjs","html_url":"https://github.com/kashjs","followers_url":"https://api.github.com/users/kashjs/followers","following_url":"https://api.github.com/users/kashjs/following{/other_user}","gists_url":"https://api.github.com/users/kashjs/gists{/gist_id}","starred_url":"https://api.github.com/users/kashjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashjs/subscriptions","organizations_url":"https://api.github.com/users/kashjs/orgs","repos_url":"https://api.github.com/users/kashjs/repos","events_url":"https://api.github.com/users/kashjs/events{/privacy}","received_events_url":"https://api.github.com/users/kashjs/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T18:32:44Z","updated_at":"2015-02-02T18:32:44Z","body":"Hey Brian,\r\n\r\nI think we should leverage the column definition for filters. On the column definition, we should allow an optional property called `columnSearchProperty`. Whatever that property is, the column search will search by that column.  \r\n\r\nWhat do you think?"}}