{"action":"created","comment":{"url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/comments/47982178","id":47982178,"diff_hunk":"@@ -7,6 +7,12 @@\n     sequence(:email) { |n| \"person#{n}@example.com\" }\n     sequence(:phone) { |n| PhonyRails.normalize_number(\"555555#{n.to_s.rjust(4,'0')}\", default_country_code: 'US')}\n \n+    skip_nb_update true","path":"spec/factories.rb","position":4,"original_position":4,"commit_id":"55b08bc53dc49c754fa8892dd7355da99510e835","original_commit_id":"55b08bc53dc49c754fa8892dd7355da99510e835","user":{"login":"turino","id":9420188,"avatar_url":"https://avatars.githubusercontent.com/u/9420188?v=3","gravatar_id":"","url":"https://api.github.com/users/turino","html_url":"https://github.com/turino","followers_url":"https://api.github.com/users/turino/followers","following_url":"https://api.github.com/users/turino/following{/other_user}","gists_url":"https://api.github.com/users/turino/gists{/gist_id}","starred_url":"https://api.github.com/users/turino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turino/subscriptions","organizations_url":"https://api.github.com/users/turino/orgs","repos_url":"https://api.github.com/users/turino/repos","events_url":"https://api.github.com/users/turino/events{/privacy}","received_events_url":"https://api.github.com/users/turino/received_events","type":"User","site_admin":false},"body":"by default `person` factory no longer calls `update_nation_builder` after save","created_at":"2015-12-18T00:41:49Z","updated_at":"2015-12-18T00:41:49Z","html_url":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66#discussion_r47982178","pull_request_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/comments/47982178"},"html":{"href":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66#discussion_r47982178"},"pull_request":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66","id":54042989,"html_url":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66","diff_url":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66.diff","patch_url":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66.patch","issue_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/66","number":66,"state":"open","locked":false,"title":"Non-recurring stripe payments","user":{"login":"turino","id":9420188,"avatar_url":"https://avatars.githubusercontent.com/u/9420188?v=3","gravatar_id":"","url":"https://api.github.com/users/turino","html_url":"https://github.com/turino","followers_url":"https://api.github.com/users/turino/followers","following_url":"https://api.github.com/users/turino/following{/other_user}","gists_url":"https://api.github.com/users/turino/gists{/gist_id}","starred_url":"https://api.github.com/users/turino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turino/subscriptions","organizations_url":"https://api.github.com/users/turino/orgs","repos_url":"https://api.github.com/users/turino/repos","events_url":"https://api.github.com/users/turino/events{/privacy}","received_events_url":"https://api.github.com/users/turino/received_events","type":"User","site_admin":false},"body":"It seems I can't generate single-use tokens without Stripe.js, so I haven't actually been able to see this work end-to-end, but I'm pretty sure it is working. \r\n\r\nI found it hard to get around the `Person` `after_save` callback, so I just loaded more responsibilities into `NbPersonPushJob`. I'm not feeling good about that decision. I think that `after_save` callback has got to go. (That was my mistake, creating that callback.) I would like to do a big refactor and remove that callback, but I think that should happen on a different branch once this is merged.\r\n\r\nIt looks like the build failed when I pushed my last commit, though -- not sure what that's about.\r\n\r\nEdit: looks like Travis CI is complaining about pending migrations? Shouldn't Travis run migrations automatically?","created_at":"2015-12-17T22:50:19Z","updated_at":"2015-12-18T00:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cac3ab9a2a94bbb9990b68f7cc271082b6d881e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66/commits","review_comments_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66/comments","review_comment_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/66/comments","statuses_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/statuses/55b08bc53dc49c754fa8892dd7355da99510e835","head":{"label":"MayOneUS:jt-stripe","ref":"jt-stripe","sha":"55b08bc53dc49c754fa8892dd7355da99510e835","user":{"login":"MayOneUS","id":7469720,"avatar_url":"https://avatars.githubusercontent.com/u/7469720?v=3","gravatar_id":"","url":"https://api.github.com/users/MayOneUS","html_url":"https://github.com/MayOneUS","followers_url":"https://api.github.com/users/MayOneUS/followers","following_url":"https://api.github.com/users/MayOneUS/following{/other_user}","gists_url":"https://api.github.com/users/MayOneUS/gists{/gist_id}","starred_url":"https://api.github.com/users/MayOneUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MayOneUS/subscriptions","organizations_url":"https://api.github.com/users/MayOneUS/orgs","repos_url":"https://api.github.com/users/MayOneUS/repos","events_url":"https://api.github.com/users/MayOneUS/events{/privacy}","received_events_url":"https://api.github.com/users/MayOneUS/received_events","type":"Organization","site_admin":false},"repo":{"id":29715441,"name":"mayday-2.0-backend","full_name":"MayOneUS/mayday-2.0-backend","owner":{"login":"MayOneUS","id":7469720,"avatar_url":"https://avatars.githubusercontent.com/u/7469720?v=3","gravatar_id":"","url":"https://api.github.com/users/MayOneUS","html_url":"https://github.com/MayOneUS","followers_url":"https://api.github.com/users/MayOneUS/followers","following_url":"https://api.github.com/users/MayOneUS/following{/other_user}","gists_url":"https://api.github.com/users/MayOneUS/gists{/gist_id}","starred_url":"https://api.github.com/users/MayOneUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MayOneUS/subscriptions","organizations_url":"https://api.github.com/users/MayOneUS/orgs","repos_url":"https://api.github.com/users/MayOneUS/repos","events_url":"https://api.github.com/users/MayOneUS/events{/privacy}","received_events_url":"https://api.github.com/users/MayOneUS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MayOneUS/mayday-2.0-backend","description":"2015  backend services","fork":false,"url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend","forks_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/forks","keys_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/teams","hooks_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/hooks","issue_events_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/events{/number}","events_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/events","assignees_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/assignees{/user}","branches_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/branches{/branch}","tags_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/tags","blobs_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/languages","stargazers_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/stargazers","contributors_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/contributors","subscribers_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/subscribers","subscription_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/subscription","commits_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/contents/{+path}","compare_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/merges","archive_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/downloads","issues_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues{/number}","pulls_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/labels{/name}","releases_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/releases{/id}","created_at":"2015-01-23T03:50:45Z","updated_at":"2015-06-26T21:19:52Z","pushed_at":"2015-12-18T00:05:45Z","git_url":"git://github.com/MayOneUS/mayday-2.0-backend.git","ssh_url":"git@github.com:MayOneUS/mayday-2.0-backend.git","clone_url":"https://github.com/MayOneUS/mayday-2.0-backend.git","svn_url":"https://github.com/MayOneUS/mayday-2.0-backend","homepage":"https://services.mayday.us/","size":2117,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"MayOneUS:master","ref":"master","sha":"7142598d76307a889b271b6d762bff35b194f229","user":{"login":"MayOneUS","id":7469720,"avatar_url":"https://avatars.githubusercontent.com/u/7469720?v=3","gravatar_id":"","url":"https://api.github.com/users/MayOneUS","html_url":"https://github.com/MayOneUS","followers_url":"https://api.github.com/users/MayOneUS/followers","following_url":"https://api.github.com/users/MayOneUS/following{/other_user}","gists_url":"https://api.github.com/users/MayOneUS/gists{/gist_id}","starred_url":"https://api.github.com/users/MayOneUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MayOneUS/subscriptions","organizations_url":"https://api.github.com/users/MayOneUS/orgs","repos_url":"https://api.github.com/users/MayOneUS/repos","events_url":"https://api.github.com/users/MayOneUS/events{/privacy}","received_events_url":"https://api.github.com/users/MayOneUS/received_events","type":"Organization","site_admin":false},"repo":{"id":29715441,"name":"mayday-2.0-backend","full_name":"MayOneUS/mayday-2.0-backend","owner":{"login":"MayOneUS","id":7469720,"avatar_url":"https://avatars.githubusercontent.com/u/7469720?v=3","gravatar_id":"","url":"https://api.github.com/users/MayOneUS","html_url":"https://github.com/MayOneUS","followers_url":"https://api.github.com/users/MayOneUS/followers","following_url":"https://api.github.com/users/MayOneUS/following{/other_user}","gists_url":"https://api.github.com/users/MayOneUS/gists{/gist_id}","starred_url":"https://api.github.com/users/MayOneUS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MayOneUS/subscriptions","organizations_url":"https://api.github.com/users/MayOneUS/orgs","repos_url":"https://api.github.com/users/MayOneUS/repos","events_url":"https://api.github.com/users/MayOneUS/events{/privacy}","received_events_url":"https://api.github.com/users/MayOneUS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MayOneUS/mayday-2.0-backend","description":"2015  backend services","fork":false,"url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend","forks_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/forks","keys_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/teams","hooks_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/hooks","issue_events_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/events{/number}","events_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/events","assignees_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/assignees{/user}","branches_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/branches{/branch}","tags_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/tags","blobs_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/languages","stargazers_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/stargazers","contributors_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/contributors","subscribers_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/subscribers","subscription_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/subscription","commits_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/contents/{+path}","compare_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/merges","archive_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/downloads","issues_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues{/number}","pulls_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/labels{/name}","releases_url":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/releases{/id}","created_at":"2015-01-23T03:50:45Z","updated_at":"2015-06-26T21:19:52Z","pushed_at":"2015-12-18T00:05:45Z","git_url":"git://github.com/MayOneUS/mayday-2.0-backend.git","ssh_url":"git@github.com:MayOneUS/mayday-2.0-backend.git","clone_url":"https://github.com/MayOneUS/mayday-2.0-backend.git","svn_url":"https://github.com/MayOneUS/mayday-2.0-backend","homepage":"https://services.mayday.us/","size":2117,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66"},"html":{"href":"https://github.com/MayOneUS/mayday-2.0-backend/pull/66"},"issue":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/66"},"comments":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/MayOneUS/mayday-2.0-backend/statuses/55b08bc53dc49c754fa8892dd7355da99510e835"}}}}