{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/34967370","id":34967370,"diff_hunk":"@@ -418,51 +418,508 @@ case class Cast(child: Expression, dataType: DataType)\n   protected override def nullSafeEval(input: Any): Any = cast(input)\n \n   override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode): String = {\n-    // TODO: Add support for more data types.\n-    (child.dataType, dataType) match {\n+    val nullSafeCast = nullSafeCastFunction(child.dataType, dataType, ctx)\n+    if (nullSafeCast != null) {\n+      val eval = child.gen(ctx)\n+      eval.code +\n+        castCode(ctx, eval.primitive, eval.isNull, ev.primitive, ev.isNull, dataType, nullSafeCast)\n+    } else {\n+      super.genCode(ctx, ev)\n+    }\n+  }\n+\n+  // three function arguments are: child.primitive, result.primitive and result.isNull\n+  // it returns the code snippets to be put in null safe evaluation region\n+  private[this] type CastFunction = (String, String, String) => String\n+\n+  private[this] def nullSafeCastFunction(\n+      from: DataType,\n+      to: DataType,\n+      ctx: CodeGenContext): CastFunction = to match {\n+\n+    case _ if from == NullType => (c, evPrim, evNull) => s\"$evNull = true;\"\n+    case _ if to == from => (c, evPrim, evNull) => s\"$evPrim = $c;\"\n+    case StringType => castToStringCode(from, ctx)\n+    case BinaryType => castToBinaryCode(from)\n+    case DateType => castToDateCode(from)\n+    case decimal: DecimalType => castToDecimalCode(from, decimal)\n+    case TimestampType => castToTimestampCode(from)\n+    case IntervalType => castToIntervalCode(from)\n+    case BooleanType => castToBooleanCode(from)\n+    case ByteType => castToByteCode(from)\n+    case ShortType => castToShortCode(from)\n+    case IntegerType => castToIntCode(from)\n+    case FloatType => castToFloatCode(from)\n+    case LongType => castToLongCode(from)\n+    case DoubleType => castToDoubleCode(from)\n+\n+    case array: ArrayType => castArrayCode(from.asInstanceOf[ArrayType], array, ctx)\n+    case map: MapType => castMapCode(from.asInstanceOf[MapType], map, ctx)\n+    case struct: StructType => castStructCode(from.asInstanceOf[StructType], struct, ctx)\n+    case other => null\n+  }\n+\n+  private[this] def castCode(ctx: CodeGenContext, childPrim: String, childNull: String,\n+    resultPrim: String, resultNull: String, resultType: DataType, cast: CastFunction): String = {\n+    s\"\"\"\n+      boolean $resultNull = $childNull;\n+      ${ctx.javaType(resultType)} $resultPrim = ${ctx.defaultValue(resultType)};\n+      if (!${childNull}) {\n+        ${cast(childPrim, resultPrim, resultNull)}\n+      }\n+    \"\"\"\n+  }\n+\n+  private[this] def castToStringCode(from: DataType, ctx: CodeGenContext): CastFunction = {\n+    from match {\n+      case BinaryType =>\n+        (c, evPrim, evNull) => s\"$evPrim = UTF8String.fromBytes($c);\"\n+      case DateType =>\n+        (c, evPrim, evNull) => s\"\"\"$evPrim = UTF8String.fromString(\n+          org.apache.spark.sql.catalyst.util.DateTimeUtils.dateToString($c));\"\"\"\n+      case TimestampType =>\n+        (c, evPrim, evNull) => s\"\"\"$evPrim = UTF8String.fromString(\n+          org.apache.spark.sql.catalyst.util.DateTimeUtils.timestampToString($c));\"\"\"\n+      case _ =>\n+        (c, evPrim, evNull) => s\"$evPrim = UTF8String.fromString(String.valueOf($c));\"\n+    }\n+  }\n+\n+  private[this] def castToBinaryCode(from: DataType): CastFunction = from match {\n+    case StringType =>\n+      (c, evPrim, evNull) => s\"$evPrim = $c.getBytes();\"\n+  }\n+\n+  private[this] def castToDateCode(from: DataType): CastFunction = from match {\n+    case StringType =>\n+      (c, evPrim, evNull) => s\"\"\"\n+        try {\n+          $evPrim = org.apache.spark.sql.catalyst.util.DateTimeUtils.stringToDateTE($c);\n+        } catch (java.lang.IllegalArgumentException e) {\n+          $evNull = true;\n+        }\n+       \"\"\"\n+    case TimestampType =>\n+      (c, evPrim, evNull) =>\n+        s\"$evPrim = org.apache.spark.sql.catalyst.util.DateTimeUtils.millisToDays($c / 1000L);\";\n+    case _ =>\n+      (c, evPrim, evNull) => s\"$evNull = true;\"\n+  }\n+\n+  private[this] def changePrecision(d: String, decimalType: DecimalType,\n+      evPrim: String, evNull: String): String = {\n+    decimalType match {\n+      case DecimalType.Unlimited =>\n+        s\"$evPrim = $d;\"\n+      case DecimalType.Fixed(precision, scale) =>\n+        s\"\"\"\n+          if ($d.changePrecision($precision, $scale)) {\n+            $evPrim = $d;\n+          } else {\n+            $evNull = true;\n+          }\n+        \"\"\"\n+    }\n+  }\n+\n+  private[this] def castToDecimalCode(from: DataType, target: DecimalType): CastFunction = {\n+    from match {\n+      case StringType =>\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            try {\n+              org.apache.spark.sql.types.Decimal tmpDecimal =\n+                new org.apache.spark.sql.types.Decimal().set(\n+                  new scala.math.BigDecimal(\n+                    new java.math.BigDecimal($c.toString())));\n+              ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+            } catch (java.lang.NumberFormatException e) {\n+              $evNull = true;\n+            }\n+          \"\"\"\n+      case BooleanType =>\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            org.apache.spark.sql.types.Decimal tmpDecimal = null;\n+            if ($c) {\n+              tmpDecimal = new org.apache.spark.sql.types.Decimal().set(1);\n+            } else {\n+              tmpDecimal = new org.apache.spark.sql.types.Decimal().set(0);\n+            }\n+            ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+          \"\"\"\n+      case DateType =>\n+        // date can't cast to decimal in Hive\n+        (c, evPrim, evNull) => s\"$evNull = true;\"\n+      case TimestampType =>\n+        // Note that we lose precision here.\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            org.apache.spark.sql.types.Decimal tmpDecimal =\n+              new org.apache.spark.sql.types.Decimal().set(\n+                scala.math.BigDecimal.valueOf(${timestampToDoubleCode(c)}));\n+            ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+          \"\"\"\n+      case DecimalType() =>\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            org.apache.spark.sql.types.Decimal tmpDecimal = $c.clone();\n+            ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+          \"\"\"\n+      case LongType =>\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            org.apache.spark.sql.types.Decimal tmpDecimal =\n+              new org.apache.spark.sql.types.Decimal().set($c);\n+            ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+          \"\"\"\n+      case x: NumericType =>\n+        // All other numeric types can be represented precisely as Doubles\n+        (c, evPrim, evNull) =>\n+          s\"\"\"\n+            try {\n+              org.apache.spark.sql.types.Decimal tmpDecimal =\n+                new org.apache.spark.sql.types.Decimal().set(\n+                  scala.math.BigDecimal.valueOf((double) $c));\n+              ${changePrecision(\"tmpDecimal\", target, evPrim, evNull)}\n+            } catch (java.lang.NumberFormatException e) {\n+              $evNull = true;\n+            }\n+          \"\"\"\n+    }\n+  }\n+\n+  private[this] def castToTimestampCode(from: DataType): CastFunction = from match {\n+    case StringType =>\n+      (c, evPrim, evNull) =>\n+        s\"\"\"\n+          try {\n+            $evPrim = org.apache.spark.sql.catalyst.util.DateTimeUtils.stringToTimestampTE($c);\n+          } catch (java.lang.IllegalArgumentException e) {\n+            $evNull = true;\n+          }","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala","position":185,"original_position":185,"commit_id":"80378a59bde82859a25099a650e7fd6f81491e45","original_commit_id":"80378a59bde82859a25099a650e7fd6f81491e45","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"this is code gen right? in that case try/catch should be ok.\r\n","created_at":"2015-07-20T03:51:04Z","updated_at":"2015-07-20T03:51:04Z","html_url":"https://github.com/apache/spark/pull/7365#discussion_r34967370","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7365","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/34967370"},"html":{"href":"https://github.com/apache/spark/pull/7365#discussion_r34967370"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7365"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7365","id":39783863,"html_url":"https://github.com/apache/spark/pull/7365","diff_url":"https://github.com/apache/spark/pull/7365.diff","patch_url":"https://github.com/apache/spark/pull/7365.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7365","number":7365,"state":"open","locked":false,"title":"[SPARK-8935][SQL] Implement code generation for all casts","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.apache.org/jira/browse/SPARK-8935","created_at":"2015-07-13T07:02:35Z","updated_at":"2015-07-20T03:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf04ffe0a2cd52eaf2e70690f8fb09543da8bd74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7365/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7365/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7365/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/80378a59bde82859a25099a650e7fd6f81491e45","head":{"label":"yjshen:cast_codegen","ref":"cast_codegen","sha":"80378a59bde82859a25099a650e7fd6f81491e45","user":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"repo":{"id":32433144,"name":"spark","full_name":"yjshen/spark","owner":{"login":"yjshen","id":1387718,"avatar_url":"https://avatars.githubusercontent.com/u/1387718?v=3","gravatar_id":"","url":"https://api.github.com/users/yjshen","html_url":"https://github.com/yjshen","followers_url":"https://api.github.com/users/yjshen/followers","following_url":"https://api.github.com/users/yjshen/following{/other_user}","gists_url":"https://api.github.com/users/yjshen/gists{/gist_id}","starred_url":"https://api.github.com/users/yjshen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjshen/subscriptions","organizations_url":"https://api.github.com/users/yjshen/orgs","repos_url":"https://api.github.com/users/yjshen/repos","events_url":"https://api.github.com/users/yjshen/events{/privacy}","received_events_url":"https://api.github.com/users/yjshen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yjshen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yjshen/spark","forks_url":"https://api.github.com/repos/yjshen/spark/forks","keys_url":"https://api.github.com/repos/yjshen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yjshen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yjshen/spark/teams","hooks_url":"https://api.github.com/repos/yjshen/spark/hooks","issue_events_url":"https://api.github.com/repos/yjshen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yjshen/spark/events","assignees_url":"https://api.github.com/repos/yjshen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yjshen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yjshen/spark/tags","blobs_url":"https://api.github.com/repos/yjshen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yjshen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yjshen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yjshen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yjshen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yjshen/spark/languages","stargazers_url":"https://api.github.com/repos/yjshen/spark/stargazers","contributors_url":"https://api.github.com/repos/yjshen/spark/contributors","subscribers_url":"https://api.github.com/repos/yjshen/spark/subscribers","subscription_url":"https://api.github.com/repos/yjshen/spark/subscription","commits_url":"https://api.github.com/repos/yjshen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yjshen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yjshen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yjshen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yjshen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yjshen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yjshen/spark/merges","archive_url":"https://api.github.com/repos/yjshen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yjshen/spark/downloads","issues_url":"https://api.github.com/repos/yjshen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yjshen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yjshen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yjshen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yjshen/spark/labels{/name}","releases_url":"https://api.github.com/repos/yjshen/spark/releases{/id}","created_at":"2015-03-18T02:27:58Z","updated_at":"2015-05-02T04:50:02Z","pushed_at":"2015-07-20T02:42:02Z","git_url":"git://github.com/yjshen/spark.git","ssh_url":"git@github.com:yjshen/spark.git","clone_url":"https://github.com/yjshen/spark.git","svn_url":"https://github.com/yjshen/spark","homepage":null,"size":113634,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"163e3f1df94f6b7d3dadb46a87dbb3a2bade3f95","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-20T03:13:55Z","pushed_at":"2015-07-20T03:47:11Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1558621,"stargazers_count":4795,"watchers_count":4795,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4293,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":335,"forks":4293,"open_issues":335,"watchers":4795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7365"},"html":{"href":"https://github.com/apache/spark/pull/7365"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7365"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7365/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7365/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7365/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/80378a59bde82859a25099a650e7fd6f81491e45"}}}}