{"action":"closed","issue":{"url":"https://api.github.com/repos/GRIFFINCollaboration/GRSISort/issues/508","labels_url":"https://api.github.com/repos/GRIFFINCollaboration/GRSISort/issues/508/labels{/name}","comments_url":"https://api.github.com/repos/GRIFFINCollaboration/GRSISort/issues/508/comments","events_url":"https://api.github.com/repos/GRIFFINCollaboration/GRSISort/issues/508/events","html_url":"https://github.com/GRIFFINCollaboration/GRSISort/issues/508","id":107607871,"number":508,"title":"TGRSIDetectorHit::GetTime in scripts","user":{"login":"r3dunlop","id":5428160,"avatar_url":"https://avatars.githubusercontent.com/u/5428160?v=3","gravatar_id":"","url":"https://api.github.com/users/r3dunlop","html_url":"https://github.com/r3dunlop","followers_url":"https://api.github.com/users/r3dunlop/followers","following_url":"https://api.github.com/users/r3dunlop/following{/other_user}","gists_url":"https://api.github.com/users/r3dunlop/gists{/gist_id}","starred_url":"https://api.github.com/users/r3dunlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r3dunlop/subscriptions","organizations_url":"https://api.github.com/users/r3dunlop/orgs","repos_url":"https://api.github.com/users/r3dunlop/repos","events_url":"https://api.github.com/users/r3dunlop/events{/privacy}","received_events_url":"https://api.github.com/users/r3dunlop/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GRIFFINCollaboration/GRSISort/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-21T22:02:46Z","updated_at":"2015-11-03T17:22:36Z","closed_at":"2015-11-03T17:22:36Z","body":"The GetTime function recalculates the time of the hit every time the GetTime function is used. This is not correct because it means that a Hit near the limits of a gate has the potential of passing a gate, OR failing a gate purely on the outcome of the generated random number. This can lead to inconsistencies in plots generated during the same script run. To fix this, I am putting a time-set flag (just like energy, channel etc.) and only allowing the time to be set once. This should be up soon, but I am posting this for as an FYI. To be clear, this is an effect on the 0.06% level, so it shouldn't be a large issue in already sorted data. It was just generating inconsistencies in my bremsstrahlung suppressed data where I was not suppressing 0.06% of the data and I could not figure out why. \r\nCC: @GRIFFINCollaboration/analysis_users "}}