{"action":"created","comment":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/30008998","id":30008998,"diff_hunk":"@@ -45,6 +45,15 @@ describe('modules/string-checker', function() {\n             });\n         });\n \n+        it('should not check empty string (#1354)', function() {\n+            var spy = sinon.spy(StringChecker.prototype, '_checkJsFile');","path":"test/specs/string-checker.js","position":5,"original_position":5,"commit_id":"a54231b72e2649a95b33297985c834151c5fbd3f","original_commit_id":"a54231b72e2649a95b33297985c834151c5fbd3f","user":{"login":"mrjoelkemp","id":865203,"avatar_url":"https://avatars.githubusercontent.com/u/865203?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjoelkemp","html_url":"https://github.com/mrjoelkemp","followers_url":"https://api.github.com/users/mrjoelkemp/followers","following_url":"https://api.github.com/users/mrjoelkemp/following{/other_user}","gists_url":"https://api.github.com/users/mrjoelkemp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjoelkemp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjoelkemp/subscriptions","organizations_url":"https://api.github.com/users/mrjoelkemp/orgs","repos_url":"https://api.github.com/users/mrjoelkemp/repos","events_url":"https://api.github.com/users/mrjoelkemp/events{/privacy}","received_events_url":"https://api.github.com/users/mrjoelkemp/received_events","type":"User","site_admin":false},"body":"Another not great solution is to assert that none of the rules are called. \r\n\r\nI'm fine with this if you make it protected (we don't have the notion of friend functions) for testing (jsdoc tag change should suffice, comment is a bonus). ","created_at":"2015-05-11T01:13:24Z","updated_at":"2015-05-11T01:13:24Z","html_url":"https://github.com/jscs-dev/node-jscs/pull/1356#discussion_r30008998","pull_request_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356","_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/30008998"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1356#discussion_r30008998"},"pull_request":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356"}}},"pull_request":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356","id":35091923,"html_url":"https://github.com/jscs-dev/node-jscs/pull/1356","diff_url":"https://github.com/jscs-dev/node-jscs/pull/1356.diff","patch_url":"https://github.com/jscs-dev/node-jscs/pull/1356.patch","issue_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1356","number":1356,"state":"open","locked":false,"title":"Do not check empty strings","user":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"body":"Fixes #1354","created_at":"2015-05-11T00:52:35Z","updated_at":"2015-05-11T01:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0754424a7a34827941752a8823cdf22e0471d542","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356/commits","review_comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356/comments","review_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1356/comments","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/a54231b72e2649a95b33297985c834151c5fbd3f","head":{"label":"markelog:1354","ref":"1354","sha":"a54231b72e2649a95b33297985c834151c5fbd3f","user":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"repo":{"id":12747346,"name":"node-jscs","full_name":"markelog/node-jscs","owner":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markelog/node-jscs","description":"JavaScript Code Style checker","fork":true,"url":"https://api.github.com/repos/markelog/node-jscs","forks_url":"https://api.github.com/repos/markelog/node-jscs/forks","keys_url":"https://api.github.com/repos/markelog/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markelog/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markelog/node-jscs/teams","hooks_url":"https://api.github.com/repos/markelog/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/markelog/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/markelog/node-jscs/events","assignees_url":"https://api.github.com/repos/markelog/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/markelog/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/markelog/node-jscs/tags","blobs_url":"https://api.github.com/repos/markelog/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markelog/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markelog/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/markelog/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markelog/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/markelog/node-jscs/languages","stargazers_url":"https://api.github.com/repos/markelog/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/markelog/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/markelog/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/markelog/node-jscs/subscription","commits_url":"https://api.github.com/repos/markelog/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/markelog/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/markelog/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/markelog/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/markelog/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/markelog/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markelog/node-jscs/merges","archive_url":"https://api.github.com/repos/markelog/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markelog/node-jscs/downloads","issues_url":"https://api.github.com/repos/markelog/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/markelog/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/markelog/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/markelog/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markelog/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/markelog/node-jscs/releases{/id}","created_at":"2013-09-11T04:16:47Z","updated_at":"2015-01-15T04:59:22Z","pushed_at":"2015-05-11T01:05:07Z","git_url":"git://github.com/markelog/node-jscs.git","ssh_url":"git@github.com:markelog/node-jscs.git","clone_url":"https://github.com/markelog/node-jscs.git","svn_url":"https://github.com/markelog/node-jscs","homepage":"","size":3532,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jscs-dev:master","ref":"master","sha":"e6baf257d4b9a315f2dd08419633c6f3dd0e8188","user":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":10697582,"name":"node-jscs","full_name":"jscs-dev/node-jscs","owner":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jscs-dev/node-jscs","description":"JavaScript Code Style checker","fork":false,"url":"https://api.github.com/repos/jscs-dev/node-jscs","forks_url":"https://api.github.com/repos/jscs-dev/node-jscs/forks","keys_url":"https://api.github.com/repos/jscs-dev/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jscs-dev/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jscs-dev/node-jscs/teams","hooks_url":"https://api.github.com/repos/jscs-dev/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/jscs-dev/node-jscs/events","assignees_url":"https://api.github.com/repos/jscs-dev/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/jscs-dev/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/tags","blobs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/jscs-dev/node-jscs/languages","stargazers_url":"https://api.github.com/repos/jscs-dev/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/jscs-dev/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscription","commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jscs-dev/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/jscs-dev/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jscs-dev/node-jscs/merges","archive_url":"https://api.github.com/repos/jscs-dev/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jscs-dev/node-jscs/downloads","issues_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/jscs-dev/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/jscs-dev/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jscs-dev/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/jscs-dev/node-jscs/releases{/id}","created_at":"2013-06-14T20:53:48Z","updated_at":"2015-05-10T18:46:00Z","pushed_at":"2015-05-11T01:05:07Z","git_url":"git://github.com/jscs-dev/node-jscs.git","ssh_url":"git@github.com:jscs-dev/node-jscs.git","clone_url":"https://github.com/jscs-dev/node-jscs.git","svn_url":"https://github.com/jscs-dev/node-jscs","homepage":"http://jscs.info/","size":12248,"stargazers_count":3194,"watchers_count":3194,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":181,"forks":310,"open_issues":181,"watchers":3194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/1356"},"issue":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1356"},"comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1356/comments"},"review_comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356/comments"},"review_comment":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1356/commits"},"statuses":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/a54231b72e2649a95b33297985c834151c5fbd3f"}}}}