{"action":"closed","issue":{"url":"https://api.github.com/repos/JenniferBuehler/jb-ros-packs/issues/1","labels_url":"https://api.github.com/repos/JenniferBuehler/jb-ros-packs/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/JenniferBuehler/jb-ros-packs/issues/1/comments","events_url":"https://api.github.com/repos/JenniferBuehler/jb-ros-packs/issues/1/events","html_url":"https://github.com/JenniferBuehler/jb-ros-packs/issues/1","id":114173585,"number":1,"title":"Style","user":{"login":"jacquelinekay","id":495933,"avatar_url":"https://avatars.githubusercontent.com/u/495933?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquelinekay","html_url":"https://github.com/jacquelinekay","followers_url":"https://api.github.com/users/jacquelinekay/followers","following_url":"https://api.github.com/users/jacquelinekay/following{/other_user}","gists_url":"https://api.github.com/users/jacquelinekay/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquelinekay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquelinekay/subscriptions","organizations_url":"https://api.github.com/users/jacquelinekay/orgs","repos_url":"https://api.github.com/users/jacquelinekay/repos","events_url":"https://api.github.com/users/jacquelinekay/events{/privacy}","received_events_url":"https://api.github.com/users/jacquelinekay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-30T00:20:56Z","updated_at":"2015-10-30T16:10:24Z","closed_at":"2015-10-30T16:10:24Z","body":"This is a purely aesthetic comment: consider using roslint or another automated style checker for following a consistent code style.\r\n\r\nThere are some places where you have two function names that are essentially the same but have the different style, e.g. scaleModel vs. scale_model, and one is a helper function of the other. I think it would be preferred to have consistent style and slightly more descriptive names, like scaleModel and scaleModelRecursive.\r\n\r\nI noticed that some lines run particularly long, often because there's a comment inline, e.g.\r\n\r\n```\r\nint dof_index; ///< index of this dh-parameter in the list of DOF specifications of graspit! (or can be used otherwise if used for another package)\r\n```\r\n\r\nAlso, remove extraneous commented lines of code and dead code that is blocked off with `#if 0`."}}