{"action":"created","comment":{"url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/comments/23243117","id":23243117,"diff_hunk":"@@ -43,10 +35,9 @@ EXECUTE_PROCESS(\n #FILE(WRITE \"wsrep_config\" \"Debug: WSREP_API_VERSION result: ${RESULT}\\n\")\n STRING(REGEX REPLACE \"(\\r?\\n)+$\" \"\" WSREP_API_VERSION \"${WSREP_API_VERSION}\")\n \n-SET(WSREP_PACKAGE_VERSION \"${WSREP_API_VERSION}.${WSREP_PATCH_VERSION}\")\n-SET(WSREP_VERSION\n-    \"${WSREP_API_VERSION}.${WSREP_PATCH_VERSION}.r${WSREP_PATCH_REVNO}\"\n-)\n+SET(WSREP_VERSION \"${WSREP_API_VERSION}.${WSREP_PATCH_VERSION}\"","path":"cmake/wsrep.cmake","position":37,"original_position":37,"commit_id":"c16b11a4cd50220ea547304ad13c687236a145b4","original_commit_id":"c16b11a4cd50220ea547304ad13c687236a145b4","user":{"login":"ayurchen","id":1644111,"avatar_url":"https://avatars.githubusercontent.com/u/1644111?v=3","gravatar_id":"","url":"https://api.github.com/users/ayurchen","html_url":"https://github.com/ayurchen","followers_url":"https://api.github.com/users/ayurchen/followers","following_url":"https://api.github.com/users/ayurchen/following{/other_user}","gists_url":"https://api.github.com/users/ayurchen/gists{/gist_id}","starred_url":"https://api.github.com/users/ayurchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayurchen/subscriptions","organizations_url":"https://api.github.com/users/ayurchen/orgs","repos_url":"https://api.github.com/users/ayurchen/repos","events_url":"https://api.github.com/users/ayurchen/events{/privacy}","received_events_url":"https://api.github.com/users/ayurchen/received_events","type":"User","site_admin":false},"body":"Yes, why would we need two variables that have the same value? And I think a closing parenthesis is missing on line 38.","created_at":"2015-01-20T18:28:30Z","updated_at":"2015-01-20T18:28:30Z","html_url":"https://github.com/codership/mysql-wsrep/pull/43#discussion_r23243117","pull_request_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/comments/23243117"},"html":{"href":"https://github.com/codership/mysql-wsrep/pull/43#discussion_r23243117"},"pull_request":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43","id":27696841,"html_url":"https://github.com/codership/mysql-wsrep/pull/43","diff_url":"https://github.com/codership/mysql-wsrep/pull/43.diff","patch_url":"https://github.com/codership/mysql-wsrep/pull/43.patch","issue_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/43","number":43,"state":"open","locked":false,"title":"5.6 rpm packaging","user":{"login":"temeo","id":6009633,"avatar_url":"https://avatars.githubusercontent.com/u/6009633?v=3","gravatar_id":"","url":"https://api.github.com/users/temeo","html_url":"https://github.com/temeo","followers_url":"https://api.github.com/users/temeo/followers","following_url":"https://api.github.com/users/temeo/following{/other_user}","gists_url":"https://api.github.com/users/temeo/gists{/gist_id}","starred_url":"https://api.github.com/users/temeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/temeo/subscriptions","organizations_url":"https://api.github.com/users/temeo/orgs","repos_url":"https://api.github.com/users/temeo/repos","events_url":"https://api.github.com/users/temeo/events{/privacy}","received_events_url":"https://api.github.com/users/temeo/received_events","type":"User","site_admin":false},"body":"* Added Docs/ChangeLog placeholder and manpages to allow OBS builds directly from git checkouts\r\n* Reworked and simplified mysql.spec.sh to build exclusively wsrep patched binaries, OBS compatibility\r\n* Some minor changes to get things working with jenkins scripts","created_at":"2015-01-20T17:41:23Z","updated_at":"2015-01-20T18:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b534a6914b579c8bb37fda9fb98be7b3cc6321b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43/commits","review_comments_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43/comments","review_comment_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls/comments/{number}","comments_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/43/comments","statuses_url":"https://api.github.com/repos/codership/mysql-wsrep/statuses/c16b11a4cd50220ea547304ad13c687236a145b4","head":{"label":"codership:5.6-rpm","ref":"5.6-rpm","sha":"c16b11a4cd50220ea547304ad13c687236a145b4","user":{"login":"codership","id":1644626,"avatar_url":"https://avatars.githubusercontent.com/u/1644626?v=3","gravatar_id":"","url":"https://api.github.com/users/codership","html_url":"https://github.com/codership","followers_url":"https://api.github.com/users/codership/followers","following_url":"https://api.github.com/users/codership/following{/other_user}","gists_url":"https://api.github.com/users/codership/gists{/gist_id}","starred_url":"https://api.github.com/users/codership/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codership/subscriptions","organizations_url":"https://api.github.com/users/codership/orgs","repos_url":"https://api.github.com/users/codership/repos","events_url":"https://api.github.com/users/codership/events{/privacy}","received_events_url":"https://api.github.com/users/codership/received_events","type":"Organization","site_admin":false},"repo":{"id":25269235,"name":"mysql-wsrep","full_name":"codership/mysql-wsrep","owner":{"login":"codership","id":1644626,"avatar_url":"https://avatars.githubusercontent.com/u/1644626?v=3","gravatar_id":"","url":"https://api.github.com/users/codership","html_url":"https://github.com/codership","followers_url":"https://api.github.com/users/codership/followers","following_url":"https://api.github.com/users/codership/following{/other_user}","gists_url":"https://api.github.com/users/codership/gists{/gist_id}","starred_url":"https://api.github.com/users/codership/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codership/subscriptions","organizations_url":"https://api.github.com/users/codership/orgs","repos_url":"https://api.github.com/users/codership/repos","events_url":"https://api.github.com/users/codership/events{/privacy}","received_events_url":"https://api.github.com/users/codership/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codership/mysql-wsrep","description":"wsrep API patch for MySQL server","fork":false,"url":"https://api.github.com/repos/codership/mysql-wsrep","forks_url":"https://api.github.com/repos/codership/mysql-wsrep/forks","keys_url":"https://api.github.com/repos/codership/mysql-wsrep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codership/mysql-wsrep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codership/mysql-wsrep/teams","hooks_url":"https://api.github.com/repos/codership/mysql-wsrep/hooks","issue_events_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/events{/number}","events_url":"https://api.github.com/repos/codership/mysql-wsrep/events","assignees_url":"https://api.github.com/repos/codership/mysql-wsrep/assignees{/user}","branches_url":"https://api.github.com/repos/codership/mysql-wsrep/branches{/branch}","tags_url":"https://api.github.com/repos/codership/mysql-wsrep/tags","blobs_url":"https://api.github.com/repos/codership/mysql-wsrep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codership/mysql-wsrep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codership/mysql-wsrep/git/refs{/sha}","trees_url":"https://api.github.com/repos/codership/mysql-wsrep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codership/mysql-wsrep/statuses/{sha}","languages_url":"https://api.github.com/repos/codership/mysql-wsrep/languages","stargazers_url":"https://api.github.com/repos/codership/mysql-wsrep/stargazers","contributors_url":"https://api.github.com/repos/codership/mysql-wsrep/contributors","subscribers_url":"https://api.github.com/repos/codership/mysql-wsrep/subscribers","subscription_url":"https://api.github.com/repos/codership/mysql-wsrep/subscription","commits_url":"https://api.github.com/repos/codership/mysql-wsrep/commits{/sha}","git_commits_url":"https://api.github.com/repos/codership/mysql-wsrep/git/commits{/sha}","comments_url":"https://api.github.com/repos/codership/mysql-wsrep/comments{/number}","issue_comment_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/comments/{number}","contents_url":"https://api.github.com/repos/codership/mysql-wsrep/contents/{+path}","compare_url":"https://api.github.com/repos/codership/mysql-wsrep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codership/mysql-wsrep/merges","archive_url":"https://api.github.com/repos/codership/mysql-wsrep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codership/mysql-wsrep/downloads","issues_url":"https://api.github.com/repos/codership/mysql-wsrep/issues{/number}","pulls_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls{/number}","milestones_url":"https://api.github.com/repos/codership/mysql-wsrep/milestones{/number}","notifications_url":"https://api.github.com/repos/codership/mysql-wsrep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codership/mysql-wsrep/labels{/name}","releases_url":"https://api.github.com/repos/codership/mysql-wsrep/releases{/id}","created_at":"2014-10-15T19:08:19Z","updated_at":"2015-01-20T10:11:38Z","pushed_at":"2015-01-20T17:36:06Z","git_url":"git://github.com/codership/mysql-wsrep.git","ssh_url":"git@github.com:codership/mysql-wsrep.git","clone_url":"https://github.com/codership/mysql-wsrep.git","svn_url":"https://github.com/codership/mysql-wsrep","homepage":null,"size":450792,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":37,"forks":2,"open_issues":37,"watchers":2,"default_branch":"5.6"}},"base":{"label":"codership:5.6","ref":"5.6","sha":"a2bbf7c1de736c63ef49bc43b5f6c7156a208c33","user":{"login":"codership","id":1644626,"avatar_url":"https://avatars.githubusercontent.com/u/1644626?v=3","gravatar_id":"","url":"https://api.github.com/users/codership","html_url":"https://github.com/codership","followers_url":"https://api.github.com/users/codership/followers","following_url":"https://api.github.com/users/codership/following{/other_user}","gists_url":"https://api.github.com/users/codership/gists{/gist_id}","starred_url":"https://api.github.com/users/codership/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codership/subscriptions","organizations_url":"https://api.github.com/users/codership/orgs","repos_url":"https://api.github.com/users/codership/repos","events_url":"https://api.github.com/users/codership/events{/privacy}","received_events_url":"https://api.github.com/users/codership/received_events","type":"Organization","site_admin":false},"repo":{"id":25269235,"name":"mysql-wsrep","full_name":"codership/mysql-wsrep","owner":{"login":"codership","id":1644626,"avatar_url":"https://avatars.githubusercontent.com/u/1644626?v=3","gravatar_id":"","url":"https://api.github.com/users/codership","html_url":"https://github.com/codership","followers_url":"https://api.github.com/users/codership/followers","following_url":"https://api.github.com/users/codership/following{/other_user}","gists_url":"https://api.github.com/users/codership/gists{/gist_id}","starred_url":"https://api.github.com/users/codership/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codership/subscriptions","organizations_url":"https://api.github.com/users/codership/orgs","repos_url":"https://api.github.com/users/codership/repos","events_url":"https://api.github.com/users/codership/events{/privacy}","received_events_url":"https://api.github.com/users/codership/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codership/mysql-wsrep","description":"wsrep API patch for MySQL server","fork":false,"url":"https://api.github.com/repos/codership/mysql-wsrep","forks_url":"https://api.github.com/repos/codership/mysql-wsrep/forks","keys_url":"https://api.github.com/repos/codership/mysql-wsrep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codership/mysql-wsrep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codership/mysql-wsrep/teams","hooks_url":"https://api.github.com/repos/codership/mysql-wsrep/hooks","issue_events_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/events{/number}","events_url":"https://api.github.com/repos/codership/mysql-wsrep/events","assignees_url":"https://api.github.com/repos/codership/mysql-wsrep/assignees{/user}","branches_url":"https://api.github.com/repos/codership/mysql-wsrep/branches{/branch}","tags_url":"https://api.github.com/repos/codership/mysql-wsrep/tags","blobs_url":"https://api.github.com/repos/codership/mysql-wsrep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codership/mysql-wsrep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codership/mysql-wsrep/git/refs{/sha}","trees_url":"https://api.github.com/repos/codership/mysql-wsrep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codership/mysql-wsrep/statuses/{sha}","languages_url":"https://api.github.com/repos/codership/mysql-wsrep/languages","stargazers_url":"https://api.github.com/repos/codership/mysql-wsrep/stargazers","contributors_url":"https://api.github.com/repos/codership/mysql-wsrep/contributors","subscribers_url":"https://api.github.com/repos/codership/mysql-wsrep/subscribers","subscription_url":"https://api.github.com/repos/codership/mysql-wsrep/subscription","commits_url":"https://api.github.com/repos/codership/mysql-wsrep/commits{/sha}","git_commits_url":"https://api.github.com/repos/codership/mysql-wsrep/git/commits{/sha}","comments_url":"https://api.github.com/repos/codership/mysql-wsrep/comments{/number}","issue_comment_url":"https://api.github.com/repos/codership/mysql-wsrep/issues/comments/{number}","contents_url":"https://api.github.com/repos/codership/mysql-wsrep/contents/{+path}","compare_url":"https://api.github.com/repos/codership/mysql-wsrep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codership/mysql-wsrep/merges","archive_url":"https://api.github.com/repos/codership/mysql-wsrep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codership/mysql-wsrep/downloads","issues_url":"https://api.github.com/repos/codership/mysql-wsrep/issues{/number}","pulls_url":"https://api.github.com/repos/codership/mysql-wsrep/pulls{/number}","milestones_url":"https://api.github.com/repos/codership/mysql-wsrep/milestones{/number}","notifications_url":"https://api.github.com/repos/codership/mysql-wsrep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codership/mysql-wsrep/labels{/name}","releases_url":"https://api.github.com/repos/codership/mysql-wsrep/releases{/id}","created_at":"2014-10-15T19:08:19Z","updated_at":"2015-01-20T10:11:38Z","pushed_at":"2015-01-20T17:36:06Z","git_url":"git://github.com/codership/mysql-wsrep.git","ssh_url":"git@github.com:codership/mysql-wsrep.git","clone_url":"https://github.com/codership/mysql-wsrep.git","svn_url":"https://github.com/codership/mysql-wsrep","homepage":null,"size":450792,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":37,"forks":2,"open_issues":37,"watchers":2,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43"},"html":{"href":"https://github.com/codership/mysql-wsrep/pull/43"},"issue":{"href":"https://api.github.com/repos/codership/mysql-wsrep/issues/43"},"comments":{"href":"https://api.github.com/repos/codership/mysql-wsrep/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/codership/mysql-wsrep/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/codership/mysql-wsrep/statuses/c16b11a4cd50220ea547304ad13c687236a145b4"}}}}