{"action":"created","comment":{"url":"https://api.github.com/repos/weberr13/QueueNado/pulls/comments/40104789","id":40104789,"diff_hunk":"@@ -8,17 +8,19 @@\n #include <mutex>\n #include <memory>\n #include <vector>\n-\n+#include <atomic>\n class Shotgun;\n class Vampire;\n \n class Notifier {\n  public:\n-   static std::unique_ptr<Notifier>  CreateNotifier(const std::string& notifierQueue, const std::string& handshakeQueue, const size_t handshakeCount);\n+   static std::unique_ptr<Notifier>  CreateNotifier(const std::string& notifierQueue, const std::string& handshakeQueue, const size_t handshakeCount, size_t maxTimeoutInSec = 60, unsigned int maxGetShotTimeoutInMs = 10);\n    size_t Notify(const std::vector<std::string>& messages);\n    size_t Notify(const std::string& message);\n    size_t Notify();\n    virtual ~Notifier();\n+   std::string ReceiveData();","path":"src/Notifier.h","position":17,"original_position":17,"commit_id":"f1b0bb4cf2c897fe71e9fa0b376c8e880fcbf8d6","original_commit_id":"f1b0bb4cf2c897fe71e9fa0b376c8e880fcbf8d6","user":{"login":"KjellKod","id":331742,"avatar_url":"https://avatars.githubusercontent.com/u/331742?v=3","gravatar_id":"","url":"https://api.github.com/users/KjellKod","html_url":"https://github.com/KjellKod","followers_url":"https://api.github.com/users/KjellKod/followers","following_url":"https://api.github.com/users/KjellKod/following{/other_user}","gists_url":"https://api.github.com/users/KjellKod/gists{/gist_id}","starred_url":"https://api.github.com/users/KjellKod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KjellKod/subscriptions","organizations_url":"https://api.github.com/users/KjellKod/orgs","repos_url":"https://api.github.com/users/KjellKod/repos","events_url":"https://api.github.com/users/KjellKod/events{/privacy}","received_events_url":"https://api.github.com/users/KjellKod/received_events","type":"User","site_admin":false},"body":"Please add unit tests to this repository for the new functions and any changed behavior ","created_at":"2015-09-22T15:57:58Z","updated_at":"2015-09-22T15:57:58Z","html_url":"https://github.com/weberr13/QueueNado/pull/21#discussion_r40104789","pull_request_url":"https://api.github.com/repos/weberr13/QueueNado/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/comments/40104789"},"html":{"href":"https://github.com/weberr13/QueueNado/pull/21#discussion_r40104789"},"pull_request":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/weberr13/QueueNado/pulls/21","id":45611770,"html_url":"https://github.com/weberr13/QueueNado/pull/21","diff_url":"https://github.com/weberr13/QueueNado/pull/21.diff","patch_url":"https://github.com/weberr13/QueueNado/pull/21.patch","issue_url":"https://api.github.com/repos/weberr13/QueueNado/issues/21","number":21,"state":"open","locked":false,"title":"Notifier: added code to allow receiving data without handshakes","user":{"login":"yannick-polius","id":14659345,"avatar_url":"https://avatars.githubusercontent.com/u/14659345?v=3","gravatar_id":"","url":"https://api.github.com/users/yannick-polius","html_url":"https://github.com/yannick-polius","followers_url":"https://api.github.com/users/yannick-polius/followers","following_url":"https://api.github.com/users/yannick-polius/following{/other_user}","gists_url":"https://api.github.com/users/yannick-polius/gists{/gist_id}","starred_url":"https://api.github.com/users/yannick-polius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannick-polius/subscriptions","organizations_url":"https://api.github.com/users/yannick-polius/orgs","repos_url":"https://api.github.com/users/yannick-polius/repos","events_url":"https://api.github.com/users/yannick-polius/events{/privacy}","received_events_url":"https://api.github.com/users/yannick-polius/received_events","type":"User","site_admin":false},"body":"(Comment by Kjell: **please put a description here**)","created_at":"2015-09-21T23:11:54Z","updated_at":"2015-09-22T15:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6917b8189044bb534874ba091a1b35dfe423724e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weberr13/QueueNado/pulls/21/commits","review_comments_url":"https://api.github.com/repos/weberr13/QueueNado/pulls/21/comments","review_comment_url":"https://api.github.com/repos/weberr13/QueueNado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weberr13/QueueNado/issues/21/comments","statuses_url":"https://api.github.com/repos/weberr13/QueueNado/statuses/f1b0bb4cf2c897fe71e9fa0b376c8e880fcbf8d6","head":{"label":"yannick-polius:update/notifier_add_nohandshake_receive","ref":"update/notifier_add_nohandshake_receive","sha":"f1b0bb4cf2c897fe71e9fa0b376c8e880fcbf8d6","user":{"login":"yannick-polius","id":14659345,"avatar_url":"https://avatars.githubusercontent.com/u/14659345?v=3","gravatar_id":"","url":"https://api.github.com/users/yannick-polius","html_url":"https://github.com/yannick-polius","followers_url":"https://api.github.com/users/yannick-polius/followers","following_url":"https://api.github.com/users/yannick-polius/following{/other_user}","gists_url":"https://api.github.com/users/yannick-polius/gists{/gist_id}","starred_url":"https://api.github.com/users/yannick-polius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannick-polius/subscriptions","organizations_url":"https://api.github.com/users/yannick-polius/orgs","repos_url":"https://api.github.com/users/yannick-polius/repos","events_url":"https://api.github.com/users/yannick-polius/events{/privacy}","received_events_url":"https://api.github.com/users/yannick-polius/received_events","type":"User","site_admin":false},"repo":{"id":42898619,"name":"QueueNado","full_name":"yannick-polius/QueueNado","owner":{"login":"yannick-polius","id":14659345,"avatar_url":"https://avatars.githubusercontent.com/u/14659345?v=3","gravatar_id":"","url":"https://api.github.com/users/yannick-polius","html_url":"https://github.com/yannick-polius","followers_url":"https://api.github.com/users/yannick-polius/followers","following_url":"https://api.github.com/users/yannick-polius/following{/other_user}","gists_url":"https://api.github.com/users/yannick-polius/gists{/gist_id}","starred_url":"https://api.github.com/users/yannick-polius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannick-polius/subscriptions","organizations_url":"https://api.github.com/users/yannick-polius/orgs","repos_url":"https://api.github.com/users/yannick-polius/repos","events_url":"https://api.github.com/users/yannick-polius/events{/privacy}","received_events_url":"https://api.github.com/users/yannick-polius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannick-polius/QueueNado","description":"Implementation of fast queue patterns (Push/Pull, request/reply, pub/sub, dealer/router) for C++","fork":true,"url":"https://api.github.com/repos/yannick-polius/QueueNado","forks_url":"https://api.github.com/repos/yannick-polius/QueueNado/forks","keys_url":"https://api.github.com/repos/yannick-polius/QueueNado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannick-polius/QueueNado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannick-polius/QueueNado/teams","hooks_url":"https://api.github.com/repos/yannick-polius/QueueNado/hooks","issue_events_url":"https://api.github.com/repos/yannick-polius/QueueNado/issues/events{/number}","events_url":"https://api.github.com/repos/yannick-polius/QueueNado/events","assignees_url":"https://api.github.com/repos/yannick-polius/QueueNado/assignees{/user}","branches_url":"https://api.github.com/repos/yannick-polius/QueueNado/branches{/branch}","tags_url":"https://api.github.com/repos/yannick-polius/QueueNado/tags","blobs_url":"https://api.github.com/repos/yannick-polius/QueueNado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannick-polius/QueueNado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannick-polius/QueueNado/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannick-polius/QueueNado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannick-polius/QueueNado/statuses/{sha}","languages_url":"https://api.github.com/repos/yannick-polius/QueueNado/languages","stargazers_url":"https://api.github.com/repos/yannick-polius/QueueNado/stargazers","contributors_url":"https://api.github.com/repos/yannick-polius/QueueNado/contributors","subscribers_url":"https://api.github.com/repos/yannick-polius/QueueNado/subscribers","subscription_url":"https://api.github.com/repos/yannick-polius/QueueNado/subscription","commits_url":"https://api.github.com/repos/yannick-polius/QueueNado/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannick-polius/QueueNado/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannick-polius/QueueNado/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannick-polius/QueueNado/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannick-polius/QueueNado/contents/{+path}","compare_url":"https://api.github.com/repos/yannick-polius/QueueNado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannick-polius/QueueNado/merges","archive_url":"https://api.github.com/repos/yannick-polius/QueueNado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannick-polius/QueueNado/downloads","issues_url":"https://api.github.com/repos/yannick-polius/QueueNado/issues{/number}","pulls_url":"https://api.github.com/repos/yannick-polius/QueueNado/pulls{/number}","milestones_url":"https://api.github.com/repos/yannick-polius/QueueNado/milestones{/number}","notifications_url":"https://api.github.com/repos/yannick-polius/QueueNado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannick-polius/QueueNado/labels{/name}","releases_url":"https://api.github.com/repos/yannick-polius/QueueNado/releases{/id}","created_at":"2015-09-21T23:07:53Z","updated_at":"2015-09-21T23:07:54Z","pushed_at":"2015-09-21T23:11:44Z","git_url":"git://github.com/yannick-polius/QueueNado.git","ssh_url":"git@github.com:yannick-polius/QueueNado.git","clone_url":"https://github.com/yannick-polius/QueueNado.git","svn_url":"https://github.com/yannick-polius/QueueNado","homepage":null,"size":3452,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weberr13:master","ref":"master","sha":"4ef824dcc2258b800dc074498dd272d89b2efbdd","user":{"login":"weberr13","id":4371459,"avatar_url":"https://avatars.githubusercontent.com/u/4371459?v=3","gravatar_id":"","url":"https://api.github.com/users/weberr13","html_url":"https://github.com/weberr13","followers_url":"https://api.github.com/users/weberr13/followers","following_url":"https://api.github.com/users/weberr13/following{/other_user}","gists_url":"https://api.github.com/users/weberr13/gists{/gist_id}","starred_url":"https://api.github.com/users/weberr13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weberr13/subscriptions","organizations_url":"https://api.github.com/users/weberr13/orgs","repos_url":"https://api.github.com/users/weberr13/repos","events_url":"https://api.github.com/users/weberr13/events{/privacy}","received_events_url":"https://api.github.com/users/weberr13/received_events","type":"User","site_admin":false},"repo":{"id":19793324,"name":"QueueNado","full_name":"weberr13/QueueNado","owner":{"login":"weberr13","id":4371459,"avatar_url":"https://avatars.githubusercontent.com/u/4371459?v=3","gravatar_id":"","url":"https://api.github.com/users/weberr13","html_url":"https://github.com/weberr13","followers_url":"https://api.github.com/users/weberr13/followers","following_url":"https://api.github.com/users/weberr13/following{/other_user}","gists_url":"https://api.github.com/users/weberr13/gists{/gist_id}","starred_url":"https://api.github.com/users/weberr13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weberr13/subscriptions","organizations_url":"https://api.github.com/users/weberr13/orgs","repos_url":"https://api.github.com/users/weberr13/repos","events_url":"https://api.github.com/users/weberr13/events{/privacy}","received_events_url":"https://api.github.com/users/weberr13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weberr13/QueueNado","description":"Implementation of fast queue patterns (Push/Pull, request/reply, pub/sub, dealer/router) for C++","fork":false,"url":"https://api.github.com/repos/weberr13/QueueNado","forks_url":"https://api.github.com/repos/weberr13/QueueNado/forks","keys_url":"https://api.github.com/repos/weberr13/QueueNado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weberr13/QueueNado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weberr13/QueueNado/teams","hooks_url":"https://api.github.com/repos/weberr13/QueueNado/hooks","issue_events_url":"https://api.github.com/repos/weberr13/QueueNado/issues/events{/number}","events_url":"https://api.github.com/repos/weberr13/QueueNado/events","assignees_url":"https://api.github.com/repos/weberr13/QueueNado/assignees{/user}","branches_url":"https://api.github.com/repos/weberr13/QueueNado/branches{/branch}","tags_url":"https://api.github.com/repos/weberr13/QueueNado/tags","blobs_url":"https://api.github.com/repos/weberr13/QueueNado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weberr13/QueueNado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weberr13/QueueNado/git/refs{/sha}","trees_url":"https://api.github.com/repos/weberr13/QueueNado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weberr13/QueueNado/statuses/{sha}","languages_url":"https://api.github.com/repos/weberr13/QueueNado/languages","stargazers_url":"https://api.github.com/repos/weberr13/QueueNado/stargazers","contributors_url":"https://api.github.com/repos/weberr13/QueueNado/contributors","subscribers_url":"https://api.github.com/repos/weberr13/QueueNado/subscribers","subscription_url":"https://api.github.com/repos/weberr13/QueueNado/subscription","commits_url":"https://api.github.com/repos/weberr13/QueueNado/commits{/sha}","git_commits_url":"https://api.github.com/repos/weberr13/QueueNado/git/commits{/sha}","comments_url":"https://api.github.com/repos/weberr13/QueueNado/comments{/number}","issue_comment_url":"https://api.github.com/repos/weberr13/QueueNado/issues/comments{/number}","contents_url":"https://api.github.com/repos/weberr13/QueueNado/contents/{+path}","compare_url":"https://api.github.com/repos/weberr13/QueueNado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weberr13/QueueNado/merges","archive_url":"https://api.github.com/repos/weberr13/QueueNado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weberr13/QueueNado/downloads","issues_url":"https://api.github.com/repos/weberr13/QueueNado/issues{/number}","pulls_url":"https://api.github.com/repos/weberr13/QueueNado/pulls{/number}","milestones_url":"https://api.github.com/repos/weberr13/QueueNado/milestones{/number}","notifications_url":"https://api.github.com/repos/weberr13/QueueNado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weberr13/QueueNado/labels{/name}","releases_url":"https://api.github.com/repos/weberr13/QueueNado/releases{/id}","created_at":"2014-05-14T19:34:03Z","updated_at":"2015-06-21T12:07:16Z","pushed_at":"2015-09-21T23:11:54Z","git_url":"git://github.com/weberr13/QueueNado.git","ssh_url":"git@github.com:weberr13/QueueNado.git","clone_url":"https://github.com/weberr13/QueueNado.git","svn_url":"https://github.com/weberr13/QueueNado","homepage":null,"size":3452,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/21"},"html":{"href":"https://github.com/weberr13/QueueNado/pull/21"},"issue":{"href":"https://api.github.com/repos/weberr13/QueueNado/issues/21"},"comments":{"href":"https://api.github.com/repos/weberr13/QueueNado/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weberr13/QueueNado/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/weberr13/QueueNado/statuses/f1b0bb4cf2c897fe71e9fa0b376c8e880fcbf8d6"}}}}