{"push_id":844826592,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"2e4dea52366c54b1345fb36dd6c8062782084d2e","before":"0523597ae52cce14c18f259d163cb39df959334c","commits":[{"sha":"393be6f8fc98dd953d221b88931c9846dc966d8a","author":{"email":"fc8e2e7ea6491d49e9cac18afe5daacaaf86a7ec@odin.com","name":"Evgenii Shatokhin"},"message":"kpatch-build: revisit checking for fentry calls\n\ncreate-diff-object now checks if the original functions have fentry calls.\nIf an original function to be affected by the patch does not have the\nfentry call, it cannot be patched. Error is reported in that case.\n\nkpatch_create_mcount_sections() now also takes into account if a changed\nor a new function has fentry call. If it does, mcount record is\ngenerated for it as before. If a changed or a new function has no fentry\ncall, it is not an error in this case.\n\nAll this fixes the following issues.\n\n1. If an original function has no fentry call (e.g. a \"notrace\" function)\nbut the patched function has it, the original function can not be\npatched, but it would only be detected when applying the patch.\n\n2. kpatch_create_mcount_sections() crashed if a patched function had no\nrelocation at all.\n\nI observed such crashes when experimenting with a modified version of\nthe patch \"tcp_cubic: better follow cubic curve after idle period\" in\nCentOS 7 x64.\n\nBesides that, for a function with the first instruction starting with\n0x0f, it would be incorrectly detemined that the function had fentry call.\nThe first bytes of the function would be overwritten in that case.\n\n3. create-diff-object output an error if a new (an added) function had\nno fentry call. This restriction is not necessary.\n\nv2:\n\n* Moved the check for fentry calls after the call to\nkpatch_compare_correlated_elements() and before info about the original\nELF file is destroyed. The original symbols are now checked there (via\nsym->twin) rather than the patched ones.\n\n* Removed an excessive error check.\n\nSigned-off-by: Evgenii Shatokhin <eshatokhin@odin.com>","distinct":true,"url":"https://api.github.com/repos/dynup/kpatch/commits/393be6f8fc98dd953d221b88931c9846dc966d8a"},{"sha":"2e4dea52366c54b1345fb36dd6c8062782084d2e","author":{"email":"ae6503612bae59406cddffbc668880379bd2c53d@gmail.com","name":"Seth Jennings"},"message":"Merge pull request #525 from euspectre/no-reloc-fix\n\nkpatch-build: revisit checking for fentry calls","distinct":true,"url":"https://api.github.com/repos/dynup/kpatch/commits/2e4dea52366c54b1345fb36dd6c8062782084d2e"}]}