{"action":"created","issue":{"url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/153","labels_url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/153/comments","events_url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/153/events","html_url":"https://github.com/balderdashy/sails-postgresql/issues/153","id":69585041,"number":153,"title":"Tests broken on timezone Netherlands","user":{"login":"dmarcelino","id":1280446,"avatar_url":"https://avatars.githubusercontent.com/u/1280446?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcelino","html_url":"https://github.com/dmarcelino","followers_url":"https://api.github.com/users/dmarcelino/followers","following_url":"https://api.github.com/users/dmarcelino/following{/other_user}","gists_url":"https://api.github.com/users/dmarcelino/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcelino/subscriptions","organizations_url":"https://api.github.com/users/dmarcelino/orgs","repos_url":"https://api.github.com/users/dmarcelino/repos","events_url":"https://api.github.com/users/dmarcelino/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcelino/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/balderdashy/sails-postgresql/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-20T13:19:40Z","updated_at":"2015-04-20T17:48:45Z","closed_at":null,"body":"As uncovered by @RWOverdijk, the adapter tests are broken when ran from the Netherlands timezone. We are not 100% sure if the issue lies in sails-postgresql or waterline-adapter-tests but it seems to be in the former since only sails-postgresql seems to be affected by it.\r\n\r\nTo expose this, I've created the timezone_bug  branch (https://github.com/balderdashy/sails-postgresql/commit/a5e42e2f4c973d6eb652d82b0a6d48c48b991e87) which changes travis timezone to NL and you can see the build breaks on 10 `date` related tests:\r\nhttps://travis-ci.org/balderdashy/sails-postgresql/jobs/59237954#L263\r\n\r\nI've also done a similar change to the waterline-adapter-tests (https://github.com/balderdashy/waterline-adapter-tests/commit/696178fc9db1e4857217f889a5b6bf6be836b34f) **integration** tests that run across all official adapters and **only sails-postgresql** broke these `date` tests: https://travis-ci.org/balderdashy/waterline-adapter-tests/jobs/59227210#L318"},"comment":{"url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/comments/94522540","html_url":"https://github.com/balderdashy/sails-postgresql/issues/153#issuecomment-94522540","issue_url":"https://api.github.com/repos/balderdashy/sails-postgresql/issues/153","id":94522540,"user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=3","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T17:48:44Z","updated_at":"2015-04-20T17:48:44Z","body":"I found that passing in a UTCString to .find() \"fixes\" the problem.\r\n\r\nI'm now looking into why this is a thing. It seems like there are two different methods of working with dates, and somewhere it's not doing something with the criteria (I was able to solve this but did so in a disgusting place. I'm looking for a nicer spot to put the fix."}}