{"action":"created","issue":{"url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/28","labels_url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/28/comments","events_url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/28/events","html_url":"https://github.com/hmngwy/weblog.sh/pull/28","id":118955551,"number":28,"title":"Refactor and add some tests for lib/file.js.","user":{"login":"pscollins","id":3996875,"avatar_url":"https://avatars.githubusercontent.com/u/3996875?v=3","gravatar_id":"","url":"https://api.github.com/users/pscollins","html_url":"https://github.com/pscollins","followers_url":"https://api.github.com/users/pscollins/followers","following_url":"https://api.github.com/users/pscollins/following{/other_user}","gists_url":"https://api.github.com/users/pscollins/gists{/gist_id}","starred_url":"https://api.github.com/users/pscollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pscollins/subscriptions","organizations_url":"https://api.github.com/users/pscollins/orgs","repos_url":"https://api.github.com/users/pscollins/repos","events_url":"https://api.github.com/users/pscollins/events{/privacy}","received_events_url":"https://api.github.com/users/pscollins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-26T01:50:04Z","updated_at":"2015-11-26T08:48:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hmngwy/weblog.sh/pulls/28","html_url":"https://github.com/hmngwy/weblog.sh/pull/28","diff_url":"https://github.com/hmngwy/weblog.sh/pull/28.diff","patch_url":"https://github.com/hmngwy/weblog.sh/pull/28.patch"},"body":"This starts to address #20. Two tests are failing --- file.parse and\r\nfile.parseMarkdownFile --- which may be related to #24."},"comment":{"url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/comments/159849923","html_url":"https://github.com/hmngwy/weblog.sh/pull/28#issuecomment-159849923","issue_url":"https://api.github.com/repos/hmngwy/weblog.sh/issues/28","id":159849923,"user":{"login":"hmngwy","id":1647347,"avatar_url":"https://avatars.githubusercontent.com/u/1647347?v=3","gravatar_id":"","url":"https://api.github.com/users/hmngwy","html_url":"https://github.com/hmngwy","followers_url":"https://api.github.com/users/hmngwy/followers","following_url":"https://api.github.com/users/hmngwy/following{/other_user}","gists_url":"https://api.github.com/users/hmngwy/gists{/gist_id}","starred_url":"https://api.github.com/users/hmngwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmngwy/subscriptions","organizations_url":"https://api.github.com/users/hmngwy/orgs","repos_url":"https://api.github.com/users/hmngwy/repos","events_url":"https://api.github.com/users/hmngwy/events{/privacy}","received_events_url":"https://api.github.com/users/hmngwy/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T08:48:43Z","updated_at":"2015-11-26T08:48:43Z","body":"> Probably should have made this a separate branch, whoops. My git-fu is not strong.\r\n\r\nSame. Our endeavors align anyway, this should be ok for now.\r\n\r\nI'm wondering why the # stuck around, the markdown library wouldn't miss that. Trying right now and here's how it behaves:\r\n\r\n```\r\n> md.render('# Hello\\n\\nWorld!');\r\n'<h1>Hello</h1>\\n<p>World!</p>\\n'\r\n```\r\n\r\nIn this case the expected `title` should be Hello, the dom parser simply finds the first H1 and uses `.text()`.\r\n\r\nI'm merging this, we can add a test for this and expect \"Hello\" for the `title` given the same input, and start fixing afterwards.\r\n\r\n"}}