{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/30476127","id":30476127,"diff_hunk":"@@ -86,9 +90,22 @@ bool ethash_file_size(FILE* f, size_t* ret_size)\n \n bool ethash_get_default_dirname(char* strbuf, size_t buffsize)\n {\n+#if defined(__APPLE__)\n+\tstatic const char dir_suffix[] = \"Ethash/\";","path":"libethash/io_posix.c","position":16,"original_position":16,"commit_id":"0ea5da18061aedc8000a694e0036e87857ba6006","original_commit_id":"0ea5da18061aedc8000a694e0036e87857ba6006","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"This is not following the [spec](https://github.com/ethereum/wiki/wiki/Ethash-DAG)","created_at":"2015-05-17T23:22:05Z","updated_at":"2015-05-17T23:22:05Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1948#discussion_r30476127","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/30476127"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1948#discussion_r30476127"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948","id":35586491,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1948","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1948.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1948.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1948","number":1948,"state":"open","locked":false,"title":"Fix DAG creation for GPU mining on windows.","user":{"login":"subtly","id":6557250,"avatar_url":"https://avatars.githubusercontent.com/u/6557250?v=3","gravatar_id":"","url":"https://api.github.com/users/subtly","html_url":"https://github.com/subtly","followers_url":"https://api.github.com/users/subtly/followers","following_url":"https://api.github.com/users/subtly/following{/other_user}","gists_url":"https://api.github.com/users/subtly/gists{/gist_id}","starred_url":"https://api.github.com/users/subtly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subtly/subscriptions","organizations_url":"https://api.github.com/users/subtly/orgs","repos_url":"https://api.github.com/users/subtly/repos","events_url":"https://api.github.com/users/subtly/events{/privacy}","received_events_url":"https://api.github.com/users/subtly/received_events","type":"User","site_admin":false},"body":"GetFolderPathW needs wchar_t and can otherwise fail (returning an invalid path) and use AppData path instead of users home directory. Use Local AppData instead of roaming to users on domain networks aren't uploading DAG files to servers.","created_at":"2015-05-17T12:40:21Z","updated_at":"2015-05-17T23:22:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57c62227ce7e68ac262658d9507581d91a1ce4f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1948/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0ea5da18061aedc8000a694e0036e87857ba6006","head":{"label":"subtly:wingpu","ref":"wingpu","sha":"0ea5da18061aedc8000a694e0036e87857ba6006","user":{"login":"subtly","id":6557250,"avatar_url":"https://avatars.githubusercontent.com/u/6557250?v=3","gravatar_id":"","url":"https://api.github.com/users/subtly","html_url":"https://github.com/subtly","followers_url":"https://api.github.com/users/subtly/followers","following_url":"https://api.github.com/users/subtly/following{/other_user}","gists_url":"https://api.github.com/users/subtly/gists{/gist_id}","starred_url":"https://api.github.com/users/subtly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subtly/subscriptions","organizations_url":"https://api.github.com/users/subtly/orgs","repos_url":"https://api.github.com/users/subtly/repos","events_url":"https://api.github.com/users/subtly/events{/privacy}","received_events_url":"https://api.github.com/users/subtly/received_events","type":"User","site_admin":false},"repo":{"id":16468067,"name":"cpp-ethereum-micro","full_name":"subtly/cpp-ethereum-micro","owner":{"login":"subtly","id":6557250,"avatar_url":"https://avatars.githubusercontent.com/u/6557250?v=3","gravatar_id":"","url":"https://api.github.com/users/subtly","html_url":"https://github.com/subtly","followers_url":"https://api.github.com/users/subtly/followers","following_url":"https://api.github.com/users/subtly/following{/other_user}","gists_url":"https://api.github.com/users/subtly/gists{/gist_id}","starred_url":"https://api.github.com/users/subtly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subtly/subscriptions","organizations_url":"https://api.github.com/users/subtly/orgs","repos_url":"https://api.github.com/users/subtly/repos","events_url":"https://api.github.com/users/subtly/events{/privacy}","received_events_url":"https://api.github.com/users/subtly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/subtly/cpp-ethereum-micro","description":"Just eth.","fork":true,"url":"https://api.github.com/repos/subtly/cpp-ethereum-micro","forks_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/forks","keys_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/teams","hooks_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/hooks","issue_events_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/issues/events{/number}","events_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/events","assignees_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/assignees{/user}","branches_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/branches{/branch}","tags_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/tags","blobs_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/git/refs{/sha}","trees_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/statuses/{sha}","languages_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/languages","stargazers_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/stargazers","contributors_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/contributors","subscribers_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/subscribers","subscription_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/subscription","commits_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/commits{/sha}","git_commits_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/git/commits{/sha}","comments_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/comments{/number}","issue_comment_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/issues/comments{/number}","contents_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/contents/{+path}","compare_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/merges","archive_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/downloads","issues_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/issues{/number}","pulls_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/pulls{/number}","milestones_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/milestones{/number}","notifications_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/labels{/name}","releases_url":"https://api.github.com/repos/subtly/cpp-ethereum-micro/releases{/id}","created_at":"2014-02-03T02:08:33Z","updated_at":"2015-04-14T07:42:14Z","pushed_at":"2015-05-17T21:21:29Z","git_url":"git://github.com/subtly/cpp-ethereum-micro.git","ssh_url":"git@github.com:subtly/cpp-ethereum-micro.git","clone_url":"https://github.com/subtly/cpp-ethereum-micro.git","svn_url":"https://github.com/subtly/cpp-ethereum-micro","homepage":"www.ethereum.org","size":23452,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"07817a558c9f9ba9a5fc5e259f15c160c2d9c20c","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-05-16T01:42:31Z","pushed_at":"2015-05-17T22:45:00Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":99027,"stargazers_count":469,"watchers_count":469,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":169,"forks":165,"open_issues":169,"watchers":469,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1948"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1948"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1948/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1948/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0ea5da18061aedc8000a694e0036e87857ba6006"}}}}