{"action":"created","comment":{"url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/comments/38150267","id":38150267,"diff_hunk":"@@ -80,16 +80,9 @@ function greet -a message -d \"Display a greeting message\"\n end\n ```\n \n-`fish` does not have private functions, so in order to avoid polluting the global namespace, use a prefix based in the scope of your code. For example, if you are writing a `ninja` plugin using `__ninja_function_name`.\n+In order to avoid name collision, name your functions using a prefix based in the name of your package. For example, if you are writing a `ninja` package use `ninja.function_name`.\n \n-If you are writing a function inside another function, prefix the inner one with the parent's name.\n-\n-```fish\n-function parent\n-  function parent_child\n-  end\n-end\n-```\n+`fish` does not have private functions, so in order to avoid polluting the global namespace, use double underscore before your function name. For example, if you are writing a `ninja` plugin using `__ninja.function_name`.","path":"CONTRIBUTING.md","position":24,"original_position":24,"commit_id":"0449feeb84883ab39013b3ea2d3501f4c0877c7e","original_commit_id":"edd41837ac77bc29b9e8473d5a191317a4ab6abe","user":{"login":"bobthecow","id":53660,"avatar_url":"https://avatars.githubusercontent.com/u/53660?v=3","gravatar_id":"","url":"https://api.github.com/users/bobthecow","html_url":"https://github.com/bobthecow","followers_url":"https://api.github.com/users/bobthecow/followers","following_url":"https://api.github.com/users/bobthecow/following{/other_user}","gists_url":"https://api.github.com/users/bobthecow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobthecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobthecow/subscriptions","organizations_url":"https://api.github.com/users/bobthecow/orgs","repos_url":"https://api.github.com/users/bobthecow/repos","events_url":"https://api.github.com/users/bobthecow/events{/privacy}","received_events_url":"https://api.github.com/users/bobthecow/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-08-27T21:47:02Z","updated_at":"2015-08-27T21:47:02Z","html_url":"https://github.com/fish-shell/oh-my-fish/pull/531#discussion_r38150267","pull_request_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531","_links":{"self":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/comments/38150267"},"html":{"href":"https://github.com/fish-shell/oh-my-fish/pull/531#discussion_r38150267"},"pull_request":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531"}}},"pull_request":{"url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531","id":43554835,"html_url":"https://github.com/fish-shell/oh-my-fish/pull/531","diff_url":"https://github.com/fish-shell/oh-my-fish/pull/531.diff","patch_url":"https://github.com/fish-shell/oh-my-fish/pull/531.patch","issue_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/531","number":531,"state":"open","locked":false,"title":"Naming functions with `omf.` namespace.","user":{"login":"bpinto","id":526122,"avatar_url":"https://avatars.githubusercontent.com/u/526122?v=3","gravatar_id":"","url":"https://api.github.com/users/bpinto","html_url":"https://github.com/bpinto","followers_url":"https://api.github.com/users/bpinto/followers","following_url":"https://api.github.com/users/bpinto/following{/other_user}","gists_url":"https://api.github.com/users/bpinto/gists{/gist_id}","starred_url":"https://api.github.com/users/bpinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpinto/subscriptions","organizations_url":"https://api.github.com/users/bpinto/orgs","repos_url":"https://api.github.com/users/bpinto/repos","events_url":"https://api.github.com/users/bpinto/events{/privacy}","received_events_url":"https://api.github.com/users/bpinto/received_events","type":"User","site_admin":false},"body":"Having a clear namespace `omf.` improves the readability of the code as\r\nwe clarify what is the function name and what is the namespace.","created_at":"2015-08-27T19:10:40Z","updated_at":"2015-08-27T21:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"444a45ed2397ab702935a1e3c71539027a9ae8d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531/commits","review_comments_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531/comments","review_comment_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/531/comments","statuses_url":"https://api.github.com/repos/fish-shell/oh-my-fish/statuses/0449feeb84883ab39013b3ea2d3501f4c0877c7e","head":{"label":"fish-shell:function-naming","ref":"function-naming","sha":"0449feeb84883ab39013b3ea2d3501f4c0877c7e","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":5152538,"name":"oh-my-fish","full_name":"fish-shell/oh-my-fish","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/oh-my-fish","description":"The Fishshell Framework","fork":false,"url":"https://api.github.com/repos/fish-shell/oh-my-fish","forks_url":"https://api.github.com/repos/fish-shell/oh-my-fish/forks","keys_url":"https://api.github.com/repos/fish-shell/oh-my-fish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/oh-my-fish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/oh-my-fish/teams","hooks_url":"https://api.github.com/repos/fish-shell/oh-my-fish/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/oh-my-fish/events","assignees_url":"https://api.github.com/repos/fish-shell/oh-my-fish/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/oh-my-fish/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/oh-my-fish/tags","blobs_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/oh-my-fish/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/oh-my-fish/languages","stargazers_url":"https://api.github.com/repos/fish-shell/oh-my-fish/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/oh-my-fish/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/oh-my-fish/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/oh-my-fish/subscription","commits_url":"https://api.github.com/repos/fish-shell/oh-my-fish/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/oh-my-fish/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/oh-my-fish/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/oh-my-fish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/oh-my-fish/merges","archive_url":"https://api.github.com/repos/fish-shell/oh-my-fish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/oh-my-fish/downloads","issues_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/oh-my-fish/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/oh-my-fish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/oh-my-fish/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/oh-my-fish/releases{/id}","created_at":"2012-07-23T14:03:47Z","updated_at":"2015-08-27T21:36:31Z","pushed_at":"2015-08-27T20:39:10Z","git_url":"git://github.com/fish-shell/oh-my-fish.git","ssh_url":"git@github.com:fish-shell/oh-my-fish.git","clone_url":"https://github.com/fish-shell/oh-my-fish.git","svn_url":"https://github.com/fish-shell/oh-my-fish","homepage":"https://git.io/oh-my-fish","size":5617,"stargazers_count":1629,"watchers_count":1629,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":324,"mirror_url":null,"open_issues_count":13,"forks":324,"open_issues":13,"watchers":1629,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"b4bdda5a447e5e75b67b145c04c796f2dbcf1473","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":5152538,"name":"oh-my-fish","full_name":"fish-shell/oh-my-fish","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/oh-my-fish","description":"The Fishshell Framework","fork":false,"url":"https://api.github.com/repos/fish-shell/oh-my-fish","forks_url":"https://api.github.com/repos/fish-shell/oh-my-fish/forks","keys_url":"https://api.github.com/repos/fish-shell/oh-my-fish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/oh-my-fish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/oh-my-fish/teams","hooks_url":"https://api.github.com/repos/fish-shell/oh-my-fish/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/oh-my-fish/events","assignees_url":"https://api.github.com/repos/fish-shell/oh-my-fish/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/oh-my-fish/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/oh-my-fish/tags","blobs_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/oh-my-fish/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/oh-my-fish/languages","stargazers_url":"https://api.github.com/repos/fish-shell/oh-my-fish/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/oh-my-fish/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/oh-my-fish/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/oh-my-fish/subscription","commits_url":"https://api.github.com/repos/fish-shell/oh-my-fish/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/oh-my-fish/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/oh-my-fish/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/oh-my-fish/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/oh-my-fish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/oh-my-fish/merges","archive_url":"https://api.github.com/repos/fish-shell/oh-my-fish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/oh-my-fish/downloads","issues_url":"https://api.github.com/repos/fish-shell/oh-my-fish/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/oh-my-fish/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/oh-my-fish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/oh-my-fish/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/oh-my-fish/releases{/id}","created_at":"2012-07-23T14:03:47Z","updated_at":"2015-08-27T21:36:31Z","pushed_at":"2015-08-27T20:39:10Z","git_url":"git://github.com/fish-shell/oh-my-fish.git","ssh_url":"git@github.com:fish-shell/oh-my-fish.git","clone_url":"https://github.com/fish-shell/oh-my-fish.git","svn_url":"https://github.com/fish-shell/oh-my-fish","homepage":"https://git.io/oh-my-fish","size":5617,"stargazers_count":1629,"watchers_count":1629,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":324,"mirror_url":null,"open_issues_count":13,"forks":324,"open_issues":13,"watchers":1629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531"},"html":{"href":"https://github.com/fish-shell/oh-my-fish/pull/531"},"issue":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/531"},"comments":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/issues/531/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/pulls/531/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/oh-my-fish/statuses/0449feeb84883ab39013b3ea2d3501f4c0877c7e"}}}}