{"action":"closed","number":184,"pull_request":{"url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184","id":54711667,"html_url":"https://github.com/Temasys/SkylinkJS/pull/184","diff_url":"https://github.com/Temasys/SkylinkJS/pull/184.diff","patch_url":"https://github.com/Temasys/SkylinkJS/pull/184.patch","issue_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/184","number":184,"state":"closed","locked":false,"title":"ESS-447: Fixes for connectivity with MCU #182","user":{"login":"letchoo","id":4675614,"avatar_url":"https://avatars.githubusercontent.com/u/4675614?v=3","gravatar_id":"","url":"https://api.github.com/users/letchoo","html_url":"https://github.com/letchoo","followers_url":"https://api.github.com/users/letchoo/followers","following_url":"https://api.github.com/users/letchoo/following{/other_user}","gists_url":"https://api.github.com/users/letchoo/gists{/gist_id}","starred_url":"https://api.github.com/users/letchoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letchoo/subscriptions","organizations_url":"https://api.github.com/users/letchoo/orgs","repos_url":"https://api.github.com/users/letchoo/repos","events_url":"https://api.github.com/users/letchoo/events{/privacy}","received_events_url":"https://api.github.com/users/letchoo/received_events","type":"User","site_admin":false},"body":"__Fixes should contain:__\r\n- [JIRA Ticket ESS-447](http://jira.temasys.com.sg/browse/ESS-447) - Fixes for connectivity with MCU\r\n\r\n__Possible cases tested:__\r\n- Joining the room and connecting with other peers with MCU\r\n- Restarting room and connecting with other peers with MCU\r\n- Joining the room and connecting with other peers with P2P\r\n- Restarting room and connecting with other peers with P2P\r\n\r\nNote that enableIceTrickle ON / OFF would not affect MCU use-case as enableIceTrickle is always true for MCU case.\r\n\r\nThis may fix tickets #181.","created_at":"2015-12-29T09:06:16Z","updated_at":"2015-12-29T09:07:12Z","closed_at":"2015-12-29T09:07:12Z","merged_at":"2015-12-29T09:07:12Z","merge_commit_sha":"831b80ae20195a09d9be3839772fe23f1a574b0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184/commits","review_comments_url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184/comments","review_comment_url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/184/comments","statuses_url":"https://api.github.com/repos/Temasys/SkylinkJS/statuses/90472d9faa15e273e078a365d66c5c7d985a8aeb","head":{"label":"Temasys:ESS-447-mcu-connect-bug","ref":"ESS-447-mcu-connect-bug","sha":"90472d9faa15e273e078a365d66c5c7d985a8aeb","user":{"login":"Temasys","id":6687728,"avatar_url":"https://avatars.githubusercontent.com/u/6687728?v=3","gravatar_id":"","url":"https://api.github.com/users/Temasys","html_url":"https://github.com/Temasys","followers_url":"https://api.github.com/users/Temasys/followers","following_url":"https://api.github.com/users/Temasys/following{/other_user}","gists_url":"https://api.github.com/users/Temasys/gists{/gist_id}","starred_url":"https://api.github.com/users/Temasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temasys/subscriptions","organizations_url":"https://api.github.com/users/Temasys/orgs","repos_url":"https://api.github.com/users/Temasys/repos","events_url":"https://api.github.com/users/Temasys/events{/privacy}","received_events_url":"https://api.github.com/users/Temasys/received_events","type":"Organization","site_admin":false},"repo":{"id":17198768,"name":"SkylinkJS","full_name":"Temasys/SkylinkJS","owner":{"login":"Temasys","id":6687728,"avatar_url":"https://avatars.githubusercontent.com/u/6687728?v=3","gravatar_id":"","url":"https://api.github.com/users/Temasys","html_url":"https://github.com/Temasys","followers_url":"https://api.github.com/users/Temasys/followers","following_url":"https://api.github.com/users/Temasys/following{/other_user}","gists_url":"https://api.github.com/users/Temasys/gists{/gist_id}","starred_url":"https://api.github.com/users/Temasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temasys/subscriptions","organizations_url":"https://api.github.com/users/Temasys/orgs","repos_url":"https://api.github.com/users/Temasys/repos","events_url":"https://api.github.com/users/Temasys/events{/privacy}","received_events_url":"https://api.github.com/users/Temasys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Temasys/SkylinkJS","description":"SkylinkJS Javascript WebRTC SDK","fork":false,"url":"https://api.github.com/repos/Temasys/SkylinkJS","forks_url":"https://api.github.com/repos/Temasys/SkylinkJS/forks","keys_url":"https://api.github.com/repos/Temasys/SkylinkJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Temasys/SkylinkJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Temasys/SkylinkJS/teams","hooks_url":"https://api.github.com/repos/Temasys/SkylinkJS/hooks","issue_events_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/events{/number}","events_url":"https://api.github.com/repos/Temasys/SkylinkJS/events","assignees_url":"https://api.github.com/repos/Temasys/SkylinkJS/assignees{/user}","branches_url":"https://api.github.com/repos/Temasys/SkylinkJS/branches{/branch}","tags_url":"https://api.github.com/repos/Temasys/SkylinkJS/tags","blobs_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Temasys/SkylinkJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Temasys/SkylinkJS/languages","stargazers_url":"https://api.github.com/repos/Temasys/SkylinkJS/stargazers","contributors_url":"https://api.github.com/repos/Temasys/SkylinkJS/contributors","subscribers_url":"https://api.github.com/repos/Temasys/SkylinkJS/subscribers","subscription_url":"https://api.github.com/repos/Temasys/SkylinkJS/subscription","commits_url":"https://api.github.com/repos/Temasys/SkylinkJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Temasys/SkylinkJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Temasys/SkylinkJS/contents/{+path}","compare_url":"https://api.github.com/repos/Temasys/SkylinkJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Temasys/SkylinkJS/merges","archive_url":"https://api.github.com/repos/Temasys/SkylinkJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Temasys/SkylinkJS/downloads","issues_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues{/number}","pulls_url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Temasys/SkylinkJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Temasys/SkylinkJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Temasys/SkylinkJS/labels{/name}","releases_url":"https://api.github.com/repos/Temasys/SkylinkJS/releases{/id}","created_at":"2014-02-26T04:29:36Z","updated_at":"2015-12-23T16:39:19Z","pushed_at":"2015-12-29T09:07:12Z","git_url":"git://github.com/Temasys/SkylinkJS.git","ssh_url":"git@github.com:Temasys/SkylinkJS.git","clone_url":"https://github.com/Temasys/SkylinkJS.git","svn_url":"https://github.com/Temasys/SkylinkJS","homepage":"http://skylink.io/web","size":30991,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":128,"default_branch":"master"}},"base":{"label":"Temasys:0.6.x-development","ref":"0.6.x-development","sha":"011af1631369310dbab045a997d9bcdad768d3fb","user":{"login":"Temasys","id":6687728,"avatar_url":"https://avatars.githubusercontent.com/u/6687728?v=3","gravatar_id":"","url":"https://api.github.com/users/Temasys","html_url":"https://github.com/Temasys","followers_url":"https://api.github.com/users/Temasys/followers","following_url":"https://api.github.com/users/Temasys/following{/other_user}","gists_url":"https://api.github.com/users/Temasys/gists{/gist_id}","starred_url":"https://api.github.com/users/Temasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temasys/subscriptions","organizations_url":"https://api.github.com/users/Temasys/orgs","repos_url":"https://api.github.com/users/Temasys/repos","events_url":"https://api.github.com/users/Temasys/events{/privacy}","received_events_url":"https://api.github.com/users/Temasys/received_events","type":"Organization","site_admin":false},"repo":{"id":17198768,"name":"SkylinkJS","full_name":"Temasys/SkylinkJS","owner":{"login":"Temasys","id":6687728,"avatar_url":"https://avatars.githubusercontent.com/u/6687728?v=3","gravatar_id":"","url":"https://api.github.com/users/Temasys","html_url":"https://github.com/Temasys","followers_url":"https://api.github.com/users/Temasys/followers","following_url":"https://api.github.com/users/Temasys/following{/other_user}","gists_url":"https://api.github.com/users/Temasys/gists{/gist_id}","starred_url":"https://api.github.com/users/Temasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Temasys/subscriptions","organizations_url":"https://api.github.com/users/Temasys/orgs","repos_url":"https://api.github.com/users/Temasys/repos","events_url":"https://api.github.com/users/Temasys/events{/privacy}","received_events_url":"https://api.github.com/users/Temasys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Temasys/SkylinkJS","description":"SkylinkJS Javascript WebRTC SDK","fork":false,"url":"https://api.github.com/repos/Temasys/SkylinkJS","forks_url":"https://api.github.com/repos/Temasys/SkylinkJS/forks","keys_url":"https://api.github.com/repos/Temasys/SkylinkJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Temasys/SkylinkJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Temasys/SkylinkJS/teams","hooks_url":"https://api.github.com/repos/Temasys/SkylinkJS/hooks","issue_events_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/events{/number}","events_url":"https://api.github.com/repos/Temasys/SkylinkJS/events","assignees_url":"https://api.github.com/repos/Temasys/SkylinkJS/assignees{/user}","branches_url":"https://api.github.com/repos/Temasys/SkylinkJS/branches{/branch}","tags_url":"https://api.github.com/repos/Temasys/SkylinkJS/tags","blobs_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Temasys/SkylinkJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Temasys/SkylinkJS/languages","stargazers_url":"https://api.github.com/repos/Temasys/SkylinkJS/stargazers","contributors_url":"https://api.github.com/repos/Temasys/SkylinkJS/contributors","subscribers_url":"https://api.github.com/repos/Temasys/SkylinkJS/subscribers","subscription_url":"https://api.github.com/repos/Temasys/SkylinkJS/subscription","commits_url":"https://api.github.com/repos/Temasys/SkylinkJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Temasys/SkylinkJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Temasys/SkylinkJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Temasys/SkylinkJS/contents/{+path}","compare_url":"https://api.github.com/repos/Temasys/SkylinkJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Temasys/SkylinkJS/merges","archive_url":"https://api.github.com/repos/Temasys/SkylinkJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Temasys/SkylinkJS/downloads","issues_url":"https://api.github.com/repos/Temasys/SkylinkJS/issues{/number}","pulls_url":"https://api.github.com/repos/Temasys/SkylinkJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Temasys/SkylinkJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Temasys/SkylinkJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Temasys/SkylinkJS/labels{/name}","releases_url":"https://api.github.com/repos/Temasys/SkylinkJS/releases{/id}","created_at":"2014-02-26T04:29:36Z","updated_at":"2015-12-23T16:39:19Z","pushed_at":"2015-12-29T09:07:12Z","git_url":"git://github.com/Temasys/SkylinkJS.git","ssh_url":"git@github.com:Temasys/SkylinkJS.git","clone_url":"https://github.com/Temasys/SkylinkJS.git","svn_url":"https://github.com/Temasys/SkylinkJS","homepage":"http://skylink.io/web","size":30991,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184"},"html":{"href":"https://github.com/Temasys/SkylinkJS/pull/184"},"issue":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/issues/184"},"comments":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/Temasys/SkylinkJS/statuses/90472d9faa15e273e078a365d66c5c7d985a8aeb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"letchoo","id":4675614,"avatar_url":"https://avatars.githubusercontent.com/u/4675614?v=3","gravatar_id":"","url":"https://api.github.com/users/letchoo","html_url":"https://github.com/letchoo","followers_url":"https://api.github.com/users/letchoo/followers","following_url":"https://api.github.com/users/letchoo/following{/other_user}","gists_url":"https://api.github.com/users/letchoo/gists{/gist_id}","starred_url":"https://api.github.com/users/letchoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letchoo/subscriptions","organizations_url":"https://api.github.com/users/letchoo/orgs","repos_url":"https://api.github.com/users/letchoo/repos","events_url":"https://api.github.com/users/letchoo/events{/privacy}","received_events_url":"https://api.github.com/users/letchoo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":10,"changed_files":5}}