{"action":"created","issue":{"url":"https://api.github.com/repos/Lasagne/Lasagne/issues/438","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/438/comments","events_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/438/events","html_url":"https://github.com/Lasagne/Lasagne/pull/438","id":108473616,"number":438,"title":"Remove conv same pad for even filter_size","user":{"login":"ebenolson","id":544718,"avatar_url":"https://avatars.githubusercontent.com/u/544718?v=3","gravatar_id":"","url":"https://api.github.com/users/ebenolson","html_url":"https://github.com/ebenolson","followers_url":"https://api.github.com/users/ebenolson/followers","following_url":"https://api.github.com/users/ebenolson/following{/other_user}","gists_url":"https://api.github.com/users/ebenolson/gists{/gist_id}","starred_url":"https://api.github.com/users/ebenolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebenolson/subscriptions","organizations_url":"https://api.github.com/users/ebenolson/orgs","repos_url":"https://api.github.com/users/ebenolson/repos","events_url":"https://api.github.com/users/ebenolson/events{/privacy}","received_events_url":"https://api.github.com/users/ebenolson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-26T14:58:10Z","updated_at":"2015-09-28T12:43:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/438","html_url":"https://github.com/Lasagne/Lasagne/pull/438","diff_url":"https://github.com/Lasagne/Lasagne/pull/438.diff","patch_url":"https://github.com/Lasagne/Lasagne/pull/438.patch"},"body":"Currently the docs say that `pad='same'` will work for both odd and even `filter_size`, but this is not tested and fails on all implementation except `Conv2DLayer`.\r\n\r\nI don't think this case is worth supporting:\r\n\r\n1. It's not possible to avoid asymmetric edge effects\r\n2. I think it's uncommon in practice\r\n3. It requires ugly and inefficient code to support\r\n\r\nTherefore, this PR raises `NotImplementedError` in all conv layers for this case. \r\n\r\nIt also changes how `Conv1DLayer` implements same padding to avoid the slow compilation bug. \r\nThis supersedes and will close https://github.com/Lasagne/Lasagne/pull/415 if merged.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Lasagne/Lasagne/issues/comments/143732178","html_url":"https://github.com/Lasagne/Lasagne/pull/438#issuecomment-143732178","issue_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/438","id":143732178,"user":{"login":"f0k","id":629706,"avatar_url":"https://avatars.githubusercontent.com/u/629706?v=3","gravatar_id":"","url":"https://api.github.com/users/f0k","html_url":"https://github.com/f0k","followers_url":"https://api.github.com/users/f0k/followers","following_url":"https://api.github.com/users/f0k/following{/other_user}","gists_url":"https://api.github.com/users/f0k/gists{/gist_id}","starred_url":"https://api.github.com/users/f0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0k/subscriptions","organizations_url":"https://api.github.com/users/f0k/orgs","repos_url":"https://api.github.com/users/f0k/repos","events_url":"https://api.github.com/users/f0k/events{/privacy}","received_events_url":"https://api.github.com/users/f0k/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T12:43:01Z","updated_at":"2015-09-28T12:43:01Z","body":"I'm fine as well except for a few comments. Thanks for tackling this!"}}