{"action":"created","comment":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/38873759","id":38873759,"diff_hunk":"@@ -61,6 +61,7 @@\n #define TASK_PRIORITY PIOS_THREAD_PRIO_HIGHEST\n #define FAILSAFE_TIMEOUT_MS 100\n #define MAX_MIX_ACTUATORS ACTUATORCOMMAND_CHANNEL_NUMELEM\n+#define MULTIROTOR_MIXER_UPPER_BOUND 128","path":"flight/Modules/Actuator/actuator.c","position":4,"original_position":4,"commit_id":"2956b8a2a06a5a1cc75b1b6780d2d7dabc8b3f0c","original_commit_id":"6662068d116e2bf283b0520683840f88ea3358ad","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"body":"OK.  The original value makes me a little nervous because 128 doesn't fit in an int8.","created_at":"2015-09-07T16:52:40Z","updated_at":"2015-09-07T16:52:40Z","html_url":"https://github.com/TauLabs/TauLabs/pull/1914#discussion_r38873759","pull_request_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914","_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/38873759"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/1914#discussion_r38873759"},"pull_request":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914"}}},"pull_request":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914","id":44205264,"html_url":"https://github.com/TauLabs/TauLabs/pull/1914","diff_url":"https://github.com/TauLabs/TauLabs/pull/1914.diff","patch_url":"https://github.com/TauLabs/TauLabs/pull/1914.patch","issue_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1914","number":1914,"state":"open","locked":false,"title":"Mixer maximum value abstraction","user":{"login":"kubark42","id":1118185,"avatar_url":"https://avatars.githubusercontent.com/u/1118185?v=3","gravatar_id":"","url":"https://api.github.com/users/kubark42","html_url":"https://github.com/kubark42","followers_url":"https://api.github.com/users/kubark42/followers","following_url":"https://api.github.com/users/kubark42/following{/other_user}","gists_url":"https://api.github.com/users/kubark42/gists{/gist_id}","starred_url":"https://api.github.com/users/kubark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubark42/subscriptions","organizations_url":"https://api.github.com/users/kubark42/orgs","repos_url":"https://api.github.com/users/kubark42/repos","events_url":"https://api.github.com/users/kubark42/events{/privacy}","received_events_url":"https://api.github.com/users/kubark42/received_events","type":"User","site_admin":false},"body":"Currently the maximum mixer value is assumed to be 127. This abstracts out the magic number so other values could be used. It also fixes a brittle dependency on the UAVObject autogenerated structure, which was previously an impediment to changing the maximum value type.\r\n\r\nThe GCS changes are pretty superficial, but the firmware changes are a little more in-depth and require more reviewer attention. (To be honest, I'm surprised that the firmware never broke before because of the dependency on the autogenerated MixerSettings struct.)\r\n\r\nNote that there is currently no way to deduce the maximum mixer value from any UAVObject. Thus, it needs to be manually set in vehicleconfig.h and actuator.c. Also note that in one the maximum was ```127``` and in the other ```128```. I have elected not to change this at this time.","created_at":"2015-09-04T10:53:37Z","updated_at":"2015-09-07T16:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2a478614df0f60462af8a5c22e2ad667838c391","assignee":null,"milestone":{"url":"https://api.github.com/repos/TauLabs/TauLabs/milestones/2","html_url":"https://github.com/TauLabs/TauLabs/milestones/Pyreneus%20release","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/milestones/2/labels","id":1280915,"number":2,"title":"Pyreneus release","description":"Placeholder for release after endomorphism.\r\n\r\nRelease named by @TracerNZ.  Hopefully it's not similarly futile. :)","creator":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":2,"state":"open","created_at":"2015-08-31T00:02:36Z","updated_at":"2015-09-06T03:31:13Z","due_on":"2015-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914/commits","review_comments_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914/comments","review_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/1914/comments","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/2956b8a2a06a5a1cc75b1b6780d2d7dabc8b3f0c","head":{"label":"cyphyworks:mixer_maximum_value_abstraction","ref":"mixer_maximum_value_abstraction","sha":"2956b8a2a06a5a1cc75b1b6780d2d7dabc8b3f0c","user":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":41383980,"name":"TauLabs","full_name":"cyphyworks/TauLabs","owner":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyphyworks/TauLabs","description":"","fork":true,"url":"https://api.github.com/repos/cyphyworks/TauLabs","forks_url":"https://api.github.com/repos/cyphyworks/TauLabs/forks","keys_url":"https://api.github.com/repos/cyphyworks/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphyworks/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphyworks/TauLabs/teams","hooks_url":"https://api.github.com/repos/cyphyworks/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/cyphyworks/TauLabs/events","assignees_url":"https://api.github.com/repos/cyphyworks/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/cyphyworks/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/tags","blobs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphyworks/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphyworks/TauLabs/languages","stargazers_url":"https://api.github.com/repos/cyphyworks/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/cyphyworks/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscription","commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphyworks/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphyworks/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/cyphyworks/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphyworks/TauLabs/merges","archive_url":"https://api.github.com/repos/cyphyworks/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphyworks/TauLabs/downloads","issues_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/cyphyworks/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphyworks/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphyworks/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphyworks/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/cyphyworks/TauLabs/releases{/id}","created_at":"2015-08-25T19:37:29Z","updated_at":"2015-08-25T20:03:35Z","pushed_at":"2015-09-07T16:28:21Z","git_url":"git://github.com/cyphyworks/TauLabs.git","ssh_url":"git@github.com:cyphyworks/TauLabs.git","clone_url":"https://github.com/cyphyworks/TauLabs.git","svn_url":"https://github.com/cyphyworks/TauLabs","homepage":"taulabs.org","size":206908,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TauLabs:next","ref":"next","sha":"e0d3d51304cd8cd81b120db809d1f544c746097f","user":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":6589168,"name":"TauLabs","full_name":"TauLabs/TauLabs","owner":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TauLabs/TauLabs","description":"","fork":false,"url":"https://api.github.com/repos/TauLabs/TauLabs","forks_url":"https://api.github.com/repos/TauLabs/TauLabs/forks","keys_url":"https://api.github.com/repos/TauLabs/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TauLabs/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TauLabs/TauLabs/teams","hooks_url":"https://api.github.com/repos/TauLabs/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/TauLabs/TauLabs/events","assignees_url":"https://api.github.com/repos/TauLabs/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/TauLabs/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/TauLabs/TauLabs/tags","blobs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TauLabs/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TauLabs/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/TauLabs/TauLabs/languages","stargazers_url":"https://api.github.com/repos/TauLabs/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/TauLabs/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/TauLabs/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/TauLabs/TauLabs/subscription","commits_url":"https://api.github.com/repos/TauLabs/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TauLabs/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TauLabs/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/TauLabs/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TauLabs/TauLabs/merges","archive_url":"https://api.github.com/repos/TauLabs/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TauLabs/TauLabs/downloads","issues_url":"https://api.github.com/repos/TauLabs/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/TauLabs/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/TauLabs/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/TauLabs/TauLabs/releases{/id}","created_at":"2012-11-08T01:01:18Z","updated_at":"2015-09-02T18:15:32Z","pushed_at":"2015-09-07T16:28:22Z","git_url":"git://github.com/TauLabs/TauLabs.git","ssh_url":"git@github.com:TauLabs/TauLabs.git","clone_url":"https://github.com/TauLabs/TauLabs.git","svn_url":"https://github.com/TauLabs/TauLabs","homepage":"taulabs.org","size":335330,"stargazers_count":258,"watchers_count":258,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"open_issues_count":259,"forks":302,"open_issues":259,"watchers":258,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/1914"},"issue":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/1914"},"comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/1914/comments"},"review_comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914/comments"},"review_comment":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/1914/commits"},"statuses":{"href":"https://api.github.com/repos/TauLabs/TauLabs/statuses/2956b8a2a06a5a1cc75b1b6780d2d7dabc8b3f0c"}}}}