{"action":"created","comment":{"url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/comments/42033076","id":42033076,"diff_hunk":"@@ -81,24 +85,47 @@\n     target => $log_path,\n   }\n \n-  wget::fetch { 'selenium-server-standalone':\n-    source             => $jar_url,\n-    destination        => \"${jar_path}/${jar_name}\",\n-    timeout            => $download_timeout,\n-    nocheckcertificate => $nocheckcertificate,\n-    execuser           => $user,\n-    require            => File[$jar_path],\n+  if $package != undef {\n+\n+    package {$package:\n+      ensure => installed,\n+    }\n+\n+  } else {\n+\n+    if (!defined(Package['wget'])) {\n+      package {'wget':\n+        ensure => installed,\n+      }","path":"manifests/init.pp","position":40,"original_position":40,"commit_id":"78c35cc41f1bb59ac0f2d7f55f82d8cade044817","original_commit_id":"78c35cc41f1bb59ac0f2d7f55f82d8cade044817","user":{"login":"jhoblitt","id":948901,"avatar_url":"https://avatars.githubusercontent.com/u/948901?v=3","gravatar_id":"","url":"https://api.github.com/users/jhoblitt","html_url":"https://github.com/jhoblitt","followers_url":"https://api.github.com/users/jhoblitt/followers","following_url":"https://api.github.com/users/jhoblitt/following{/other_user}","gists_url":"https://api.github.com/users/jhoblitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoblitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoblitt/subscriptions","organizations_url":"https://api.github.com/users/jhoblitt/orgs","repos_url":"https://api.github.com/users/jhoblitt/repos","events_url":"https://api.github.com/users/jhoblitt/events{/privacy}","received_events_url":"https://api.github.com/users/jhoblitt/received_events","type":"User","site_admin":false},"body":"What is the advantage of not using the standard `wget::` resources?","created_at":"2015-10-14T18:29:48Z","updated_at":"2015-10-14T18:29:48Z","html_url":"https://github.com/jhoblitt/puppet-selenium/pull/54#discussion_r42033076","pull_request_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/comments/42033076"},"html":{"href":"https://github.com/jhoblitt/puppet-selenium/pull/54#discussion_r42033076"},"pull_request":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54","id":47557872,"html_url":"https://github.com/jhoblitt/puppet-selenium/pull/54","diff_url":"https://github.com/jhoblitt/puppet-selenium/pull/54.diff","patch_url":"https://github.com/jhoblitt/puppet-selenium/pull/54.patch","issue_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/54","number":54,"state":"open","locked":false,"title":"Remove hard external module dependency and allow package installation","user":{"login":"carroarmato0","id":1828645,"avatar_url":"https://avatars.githubusercontent.com/u/1828645?v=3","gravatar_id":"","url":"https://api.github.com/users/carroarmato0","html_url":"https://github.com/carroarmato0","followers_url":"https://api.github.com/users/carroarmato0/followers","following_url":"https://api.github.com/users/carroarmato0/following{/other_user}","gists_url":"https://api.github.com/users/carroarmato0/gists{/gist_id}","starred_url":"https://api.github.com/users/carroarmato0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carroarmato0/subscriptions","organizations_url":"https://api.github.com/users/carroarmato0/orgs","repos_url":"https://api.github.com/users/carroarmato0/repos","events_url":"https://api.github.com/users/carroarmato0/events{/privacy}","received_events_url":"https://api.github.com/users/carroarmato0/received_events","type":"User","site_admin":false},"body":"- Make logrotation module dependency optional through a boolean as it might conflict with a different implementation. The user will need to use a wrapper module where they manage the logrotation there or rely on the upstream provided rotation file supplied by the package maintainer if present.\r\n\r\n- Remove dependency on wget. All we need is a controlled exec and make sure Package['wget'] isn't managed in some other module.\r\n\r\n- Allow installing selenium by package rather than through wget if the infrastructure has that capability and package available.\r\n\r\n","created_at":"2015-10-13T16:41:38Z","updated_at":"2015-10-14T18:29:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64a31417dc6c0459ab77f9223aa031be467ebdd3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54/commits","review_comments_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54/comments","review_comment_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/54/comments","statuses_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/statuses/78c35cc41f1bb59ac0f2d7f55f82d8cade044817","head":{"label":"carroarmato0:master","ref":"master","sha":"78c35cc41f1bb59ac0f2d7f55f82d8cade044817","user":{"login":"carroarmato0","id":1828645,"avatar_url":"https://avatars.githubusercontent.com/u/1828645?v=3","gravatar_id":"","url":"https://api.github.com/users/carroarmato0","html_url":"https://github.com/carroarmato0","followers_url":"https://api.github.com/users/carroarmato0/followers","following_url":"https://api.github.com/users/carroarmato0/following{/other_user}","gists_url":"https://api.github.com/users/carroarmato0/gists{/gist_id}","starred_url":"https://api.github.com/users/carroarmato0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carroarmato0/subscriptions","organizations_url":"https://api.github.com/users/carroarmato0/orgs","repos_url":"https://api.github.com/users/carroarmato0/repos","events_url":"https://api.github.com/users/carroarmato0/events{/privacy}","received_events_url":"https://api.github.com/users/carroarmato0/received_events","type":"User","site_admin":false},"repo":{"id":44182850,"name":"puppet-selenium","full_name":"carroarmato0/puppet-selenium","owner":{"login":"carroarmato0","id":1828645,"avatar_url":"https://avatars.githubusercontent.com/u/1828645?v=3","gravatar_id":"","url":"https://api.github.com/users/carroarmato0","html_url":"https://github.com/carroarmato0","followers_url":"https://api.github.com/users/carroarmato0/followers","following_url":"https://api.github.com/users/carroarmato0/following{/other_user}","gists_url":"https://api.github.com/users/carroarmato0/gists{/gist_id}","starred_url":"https://api.github.com/users/carroarmato0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carroarmato0/subscriptions","organizations_url":"https://api.github.com/users/carroarmato0/orgs","repos_url":"https://api.github.com/users/carroarmato0/repos","events_url":"https://api.github.com/users/carroarmato0/events{/privacy}","received_events_url":"https://api.github.com/users/carroarmato0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carroarmato0/puppet-selenium","description":"Manages Selenium Server 2 - Standalone and Grid","fork":true,"url":"https://api.github.com/repos/carroarmato0/puppet-selenium","forks_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/forks","keys_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/teams","hooks_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/hooks","issue_events_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/issues/events{/number}","events_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/events","assignees_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/assignees{/user}","branches_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/branches{/branch}","tags_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/tags","blobs_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/languages","stargazers_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/stargazers","contributors_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/contributors","subscribers_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/subscribers","subscription_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/subscription","commits_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/contents/{+path}","compare_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/merges","archive_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/downloads","issues_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/issues{/number}","pulls_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/labels{/name}","releases_url":"https://api.github.com/repos/carroarmato0/puppet-selenium/releases{/id}","created_at":"2015-10-13T14:42:23Z","updated_at":"2015-10-13T14:42:23Z","pushed_at":"2015-10-13T16:35:21Z","git_url":"git://github.com/carroarmato0/puppet-selenium.git","ssh_url":"git@github.com:carroarmato0/puppet-selenium.git","clone_url":"https://github.com/carroarmato0/puppet-selenium.git","svn_url":"https://github.com/carroarmato0/puppet-selenium","homepage":"","size":233,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhoblitt:master","ref":"master","sha":"f07508c91d64d4d5b8df126cb0e21a900d1c4640","user":{"login":"jhoblitt","id":948901,"avatar_url":"https://avatars.githubusercontent.com/u/948901?v=3","gravatar_id":"","url":"https://api.github.com/users/jhoblitt","html_url":"https://github.com/jhoblitt","followers_url":"https://api.github.com/users/jhoblitt/followers","following_url":"https://api.github.com/users/jhoblitt/following{/other_user}","gists_url":"https://api.github.com/users/jhoblitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoblitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoblitt/subscriptions","organizations_url":"https://api.github.com/users/jhoblitt/orgs","repos_url":"https://api.github.com/users/jhoblitt/repos","events_url":"https://api.github.com/users/jhoblitt/events{/privacy}","received_events_url":"https://api.github.com/users/jhoblitt/received_events","type":"User","site_admin":false},"repo":{"id":13230982,"name":"puppet-selenium","full_name":"jhoblitt/puppet-selenium","owner":{"login":"jhoblitt","id":948901,"avatar_url":"https://avatars.githubusercontent.com/u/948901?v=3","gravatar_id":"","url":"https://api.github.com/users/jhoblitt","html_url":"https://github.com/jhoblitt","followers_url":"https://api.github.com/users/jhoblitt/followers","following_url":"https://api.github.com/users/jhoblitt/following{/other_user}","gists_url":"https://api.github.com/users/jhoblitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoblitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoblitt/subscriptions","organizations_url":"https://api.github.com/users/jhoblitt/orgs","repos_url":"https://api.github.com/users/jhoblitt/repos","events_url":"https://api.github.com/users/jhoblitt/events{/privacy}","received_events_url":"https://api.github.com/users/jhoblitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhoblitt/puppet-selenium","description":"Manages Selenium Server 2 - Standalone and Grid","fork":false,"url":"https://api.github.com/repos/jhoblitt/puppet-selenium","forks_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/forks","keys_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/teams","hooks_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/hooks","issue_events_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/events{/number}","events_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/events","assignees_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/assignees{/user}","branches_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/branches{/branch}","tags_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/tags","blobs_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/languages","stargazers_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/stargazers","contributors_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/contributors","subscribers_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/subscribers","subscription_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/subscription","commits_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/contents/{+path}","compare_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/merges","archive_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/downloads","issues_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues{/number}","pulls_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/labels{/name}","releases_url":"https://api.github.com/repos/jhoblitt/puppet-selenium/releases{/id}","created_at":"2013-10-01T00:18:58Z","updated_at":"2015-09-18T15:56:40Z","pushed_at":"2015-10-13T16:41:38Z","git_url":"git://github.com/jhoblitt/puppet-selenium.git","ssh_url":"git@github.com:jhoblitt/puppet-selenium.git","clone_url":"https://github.com/jhoblitt/puppet-selenium.git","svn_url":"https://github.com/jhoblitt/puppet-selenium","homepage":"","size":833,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":6,"forks":40,"open_issues":6,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54"},"html":{"href":"https://github.com/jhoblitt/puppet-selenium/pull/54"},"issue":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/54"},"comments":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/jhoblitt/puppet-selenium/statuses/78c35cc41f1bb59ac0f2d7f55f82d8cade044817"}}}}