{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/8466","labels_url":"https://api.github.com/repos/servo/servo/issues/8466/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/8466/comments","events_url":"https://api.github.com/repos/servo/servo/issues/8466/events","html_url":"https://github.com/servo/servo/pull/8466","id":116336360,"number":8466,"title":"Simplify script::dom::node NodeValue implementations","user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-11-11T13:32:13Z","updated_at":"2015-11-11T13:36:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/8466","html_url":"https://github.com/servo/servo/pull/8466","diff_url":"https://github.com/servo/servo/pull/8466.diff","patch_url":"https://github.com/servo/servo/pull/8466.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/8466)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/155786595","html_url":"https://github.com/servo/servo/pull/8466#issuecomment-155786595","issue_url":"https://api.github.com/repos/servo/servo/issues/8466","id":155786595,"user":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T13:36:00Z","updated_at":"2015-11-11T13:36:00Z","body":"-S-awaiting-merge +S-needs-code-changes \n<!-- Reviewable comment -K2qkZh-a-KayRw5fwUs:389463087 -->\n\n---\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n<sup>**[components/script/dom/node.rs, line 1895 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/8466#-K2qkJNE506hYtbNN3-O)** ([raw file](https://github.com/servo/servo/blob/313ffc400970a88ec28297ae1dff40ed395b105a/components/script/dom/node.rs#L1895)):</sup>\nYou should rather use `Castable::is` here. But in fact you should even use `SetData` directly on the `CharacterData` value returned by `Castable::downcast`.\n<!-- Reviewable comment -K2qkJNE506hYtbNN3-P:793343534 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/8466)\n<!-- Sent from Reviewable.io -->\n"}}