{"action":"created","issue":{"url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/64","labels_url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/64/comments","events_url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/64/events","html_url":"https://github.com/sford/yet-another-commit-checker/pull/64","id":93446995,"number":64,"title":"Remove deprecated apis","user":{"login":"bbaetz","id":304030,"avatar_url":"https://avatars.githubusercontent.com/u/304030?v=3","gravatar_id":"","url":"https://api.github.com/users/bbaetz","html_url":"https://github.com/bbaetz","followers_url":"https://api.github.com/users/bbaetz/followers","following_url":"https://api.github.com/users/bbaetz/following{/other_user}","gists_url":"https://api.github.com/users/bbaetz/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaetz/subscriptions","organizations_url":"https://api.github.com/users/bbaetz/orgs","repos_url":"https://api.github.com/users/bbaetz/repos","events_url":"https://api.github.com/users/bbaetz/events{/privacy}","received_events_url":"https://api.github.com/users/bbaetz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-07T06:08:31Z","updated_at":"2015-09-14T01:09:39Z","closed_at":"2015-09-14T01:09:39Z","pull_request":{"url":"https://api.github.com/repos/sford/yet-another-commit-checker/pulls/64","html_url":"https://github.com/sford/yet-another-commit-checker/pull/64","diff_url":"https://github.com/sford/yet-another-commit-checker/pull/64.diff","patch_url":"https://github.com/sford/yet-another-commit-checker/pull/64.patch"},"body":"This PR removes all the deprecated APIs that will be removed in 4.0. This makes 3.7 the minimum supported version, but you may want to hold off until 4.0 comes out in case something else needs changing too (and bumping to JDK8)\r\n\r\nNote that this is a *lot* simpler than it looks, and even simpler if you review each commit separately - the first commit is the important one and its almost entirely renames, done with a combination of my IDE's refactoring/renaming support and 'find & replace'....\r\n\r\nThis has not really been tested, so treat this as an 'FYI' only (it took a couple of hours; would have been longer but I'd hit the mockito issue before...).\r\n\r\nI ran a quick check on a local instance but just the basics - eg I haven't tested any of the JIRA integration."},"comment":{"url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/comments/139934514","html_url":"https://github.com/sford/yet-another-commit-checker/pull/64#issuecomment-139934514","issue_url":"https://api.github.com/repos/sford/yet-another-commit-checker/issues/64","id":139934514,"user":{"login":"sford","id":1066452,"avatar_url":"https://avatars.githubusercontent.com/u/1066452?v=3","gravatar_id":"","url":"https://api.github.com/users/sford","html_url":"https://github.com/sford","followers_url":"https://api.github.com/users/sford/followers","following_url":"https://api.github.com/users/sford/following{/other_user}","gists_url":"https://api.github.com/users/sford/gists{/gist_id}","starred_url":"https://api.github.com/users/sford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sford/subscriptions","organizations_url":"https://api.github.com/users/sford/orgs","repos_url":"https://api.github.com/users/sford/repos","events_url":"https://api.github.com/users/sford/events{/privacy}","received_events_url":"https://api.github.com/users/sford/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T01:09:39Z","updated_at":"2015-09-14T01:09:39Z","body":"I cherry-picked the final commit here, 6f72bb4, into a new stash4 branch. There is more work I need to do to get things ready for Stash 4.0. 6f72bb4 helps a ton, thanks again for your help!\r\n\r\nThe only issue I had ran into is I was some Tomcat8 exceptions when using the settings pages. I removed the `tomcat8x` configs in `pom.xml` so it would use the default tomcat7 container and it seemed to fix it. I am not sure if it was an issue on my end or what... didn't spend too much time triaging. I will test with tomcat8 again once I start testing with Stash 4.0."}}