{"action":"created","comment":{"url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/comments/46758255","id":46758255,"diff_hunk":"@@ -27,56 +27,56 @@ const Static = Dispatcher.Static\n let server = null\n \n \n-  let getData = function(data,timeout) {\n-    return new Promise(function(resolve, reject) {\n-      if (!timeout) {\n+let getData = function(data, timeout) {\n+  return new Promise(function(resolve, reject) {\n+    if (!timeout) {\n+      resolve(data);\n+    } else {\n+      setTimeout(function() {\n         resolve(data);\n-      }else{\n-        setTimeout(function(){\n-          resolve(data);\n-        },timeout);\n-      }\n-    });\n-  }\n+      }, timeout);\n+    }\n+  });\n+}\n \n-  describe(\"Basic Http Server\", function() {\n+describe(\"Basic Http Server\", function() {\n \n-    before(function(done){\n+  before(function(done) {\n \n-      this.timeout(5000)\n+    this.timeout(5000)\n \n-      Helpers.load(path.join(__dirname,'./package.json'))\n-      let env = new Env(Helpers)\n-      let namespace = new Namespace(env,Helpers)\n+    Helpers.load(path.join(__dirname, './package.json'))","path":"test/integration/basic-server.spec.js","position":38,"original_position":38,"commit_id":"0f871e11169e2057f3787859cb0b3c9c983da652","original_commit_id":"0f871e11169e2057f3787859cb0b3c9c983da652","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2015-12-05T13:19:28Z","updated_at":"2015-12-05T13:19:28Z","html_url":"https://github.com/adonisjs/adonis-framework/pull/25#discussion_r46758255","pull_request_url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/comments/46758255"},"html":{"href":"https://github.com/adonisjs/adonis-framework/pull/25#discussion_r46758255"},"pull_request":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25","id":52754879,"html_url":"https://github.com/adonisjs/adonis-framework/pull/25","diff_url":"https://github.com/adonisjs/adonis-framework/pull/25.diff","patch_url":"https://github.com/adonisjs/adonis-framework/pull/25.patch","issue_url":"https://api.github.com/repos/adonisjs/adonis-framework/issues/25","number":25,"state":"open","locked":false,"title":"trim trailing whitespaces","user":{"login":"RomainLanz","id":2793951,"avatar_url":"https://avatars.githubusercontent.com/u/2793951?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainLanz","html_url":"https://github.com/RomainLanz","followers_url":"https://api.github.com/users/RomainLanz/followers","following_url":"https://api.github.com/users/RomainLanz/following{/other_user}","gists_url":"https://api.github.com/users/RomainLanz/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainLanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainLanz/subscriptions","organizations_url":"https://api.github.com/users/RomainLanz/orgs","repos_url":"https://api.github.com/users/RomainLanz/repos","events_url":"https://api.github.com/users/RomainLanz/events{/privacy}","received_events_url":"https://api.github.com/users/RomainLanz/received_events","type":"User","site_admin":false},"body":"Remove trailing whitespaces and correct some styling.","created_at":"2015-12-05T13:19:22Z","updated_at":"2015-12-05T13:19:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"988bfbe1daf6f91aceade94b1eb7fad1e6b47978","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25/commits","review_comments_url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25/comments","review_comment_url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adonisjs/adonis-framework/issues/25/comments","statuses_url":"https://api.github.com/repos/adonisjs/adonis-framework/statuses/0f871e11169e2057f3787859cb0b3c9c983da652","head":{"label":"RomainLanz:rstrip","ref":"rstrip","sha":"0f871e11169e2057f3787859cb0b3c9c983da652","user":{"login":"RomainLanz","id":2793951,"avatar_url":"https://avatars.githubusercontent.com/u/2793951?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainLanz","html_url":"https://github.com/RomainLanz","followers_url":"https://api.github.com/users/RomainLanz/followers","following_url":"https://api.github.com/users/RomainLanz/following{/other_user}","gists_url":"https://api.github.com/users/RomainLanz/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainLanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainLanz/subscriptions","organizations_url":"https://api.github.com/users/RomainLanz/orgs","repos_url":"https://api.github.com/users/RomainLanz/repos","events_url":"https://api.github.com/users/RomainLanz/events{/privacy}","received_events_url":"https://api.github.com/users/RomainLanz/received_events","type":"User","site_admin":false},"repo":{"id":47290058,"name":"adonis-framework","full_name":"RomainLanz/adonis-framework","owner":{"login":"RomainLanz","id":2793951,"avatar_url":"https://avatars.githubusercontent.com/u/2793951?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainLanz","html_url":"https://github.com/RomainLanz","followers_url":"https://api.github.com/users/RomainLanz/followers","following_url":"https://api.github.com/users/RomainLanz/following{/other_user}","gists_url":"https://api.github.com/users/RomainLanz/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainLanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainLanz/subscriptions","organizations_url":"https://api.github.com/users/RomainLanz/orgs","repos_url":"https://api.github.com/users/RomainLanz/repos","events_url":"https://api.github.com/users/RomainLanz/events{/privacy}","received_events_url":"https://api.github.com/users/RomainLanz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RomainLanz/adonis-framework","description":"Http dispatcher for node/iojs , it helps you bind routes and middlewares using es6 generators","fork":true,"url":"https://api.github.com/repos/RomainLanz/adonis-framework","forks_url":"https://api.github.com/repos/RomainLanz/adonis-framework/forks","keys_url":"https://api.github.com/repos/RomainLanz/adonis-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RomainLanz/adonis-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RomainLanz/adonis-framework/teams","hooks_url":"https://api.github.com/repos/RomainLanz/adonis-framework/hooks","issue_events_url":"https://api.github.com/repos/RomainLanz/adonis-framework/issues/events{/number}","events_url":"https://api.github.com/repos/RomainLanz/adonis-framework/events","assignees_url":"https://api.github.com/repos/RomainLanz/adonis-framework/assignees{/user}","branches_url":"https://api.github.com/repos/RomainLanz/adonis-framework/branches{/branch}","tags_url":"https://api.github.com/repos/RomainLanz/adonis-framework/tags","blobs_url":"https://api.github.com/repos/RomainLanz/adonis-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RomainLanz/adonis-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RomainLanz/adonis-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/RomainLanz/adonis-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RomainLanz/adonis-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/RomainLanz/adonis-framework/languages","stargazers_url":"https://api.github.com/repos/RomainLanz/adonis-framework/stargazers","contributors_url":"https://api.github.com/repos/RomainLanz/adonis-framework/contributors","subscribers_url":"https://api.github.com/repos/RomainLanz/adonis-framework/subscribers","subscription_url":"https://api.github.com/repos/RomainLanz/adonis-framework/subscription","commits_url":"https://api.github.com/repos/RomainLanz/adonis-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/RomainLanz/adonis-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/RomainLanz/adonis-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/RomainLanz/adonis-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/RomainLanz/adonis-framework/contents/{+path}","compare_url":"https://api.github.com/repos/RomainLanz/adonis-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RomainLanz/adonis-framework/merges","archive_url":"https://api.github.com/repos/RomainLanz/adonis-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RomainLanz/adonis-framework/downloads","issues_url":"https://api.github.com/repos/RomainLanz/adonis-framework/issues{/number}","pulls_url":"https://api.github.com/repos/RomainLanz/adonis-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/RomainLanz/adonis-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/RomainLanz/adonis-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RomainLanz/adonis-framework/labels{/name}","releases_url":"https://api.github.com/repos/RomainLanz/adonis-framework/releases{/id}","created_at":"2015-12-02T21:37:07Z","updated_at":"2015-12-02T21:37:08Z","pushed_at":"2015-12-05T13:18:02Z","git_url":"git://github.com/RomainLanz/adonis-framework.git","ssh_url":"git@github.com:RomainLanz/adonis-framework.git","clone_url":"https://github.com/RomainLanz/adonis-framework.git","svn_url":"https://github.com/RomainLanz/adonis-framework","homepage":null,"size":215,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adonisjs:development","ref":"development","sha":"66d960e7e0541d0815c0958bbf08f50964b66caf","user":{"login":"adonisjs","id":13810373,"avatar_url":"https://avatars.githubusercontent.com/u/13810373?v=3","gravatar_id":"","url":"https://api.github.com/users/adonisjs","html_url":"https://github.com/adonisjs","followers_url":"https://api.github.com/users/adonisjs/followers","following_url":"https://api.github.com/users/adonisjs/following{/other_user}","gists_url":"https://api.github.com/users/adonisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/adonisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonisjs/subscriptions","organizations_url":"https://api.github.com/users/adonisjs/orgs","repos_url":"https://api.github.com/users/adonisjs/repos","events_url":"https://api.github.com/users/adonisjs/events{/privacy}","received_events_url":"https://api.github.com/users/adonisjs/received_events","type":"Organization","site_admin":false},"repo":{"id":40772809,"name":"adonis-framework","full_name":"adonisjs/adonis-framework","owner":{"login":"adonisjs","id":13810373,"avatar_url":"https://avatars.githubusercontent.com/u/13810373?v=3","gravatar_id":"","url":"https://api.github.com/users/adonisjs","html_url":"https://github.com/adonisjs","followers_url":"https://api.github.com/users/adonisjs/followers","following_url":"https://api.github.com/users/adonisjs/following{/other_user}","gists_url":"https://api.github.com/users/adonisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/adonisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adonisjs/subscriptions","organizations_url":"https://api.github.com/users/adonisjs/orgs","repos_url":"https://api.github.com/users/adonisjs/repos","events_url":"https://api.github.com/users/adonisjs/events{/privacy}","received_events_url":"https://api.github.com/users/adonisjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adonisjs/adonis-framework","description":"Http dispatcher for node/iojs , it helps you bind routes and middlewares using es6 generators","fork":false,"url":"https://api.github.com/repos/adonisjs/adonis-framework","forks_url":"https://api.github.com/repos/adonisjs/adonis-framework/forks","keys_url":"https://api.github.com/repos/adonisjs/adonis-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adonisjs/adonis-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adonisjs/adonis-framework/teams","hooks_url":"https://api.github.com/repos/adonisjs/adonis-framework/hooks","issue_events_url":"https://api.github.com/repos/adonisjs/adonis-framework/issues/events{/number}","events_url":"https://api.github.com/repos/adonisjs/adonis-framework/events","assignees_url":"https://api.github.com/repos/adonisjs/adonis-framework/assignees{/user}","branches_url":"https://api.github.com/repos/adonisjs/adonis-framework/branches{/branch}","tags_url":"https://api.github.com/repos/adonisjs/adonis-framework/tags","blobs_url":"https://api.github.com/repos/adonisjs/adonis-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adonisjs/adonis-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adonisjs/adonis-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/adonisjs/adonis-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adonisjs/adonis-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/adonisjs/adonis-framework/languages","stargazers_url":"https://api.github.com/repos/adonisjs/adonis-framework/stargazers","contributors_url":"https://api.github.com/repos/adonisjs/adonis-framework/contributors","subscribers_url":"https://api.github.com/repos/adonisjs/adonis-framework/subscribers","subscription_url":"https://api.github.com/repos/adonisjs/adonis-framework/subscription","commits_url":"https://api.github.com/repos/adonisjs/adonis-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/adonisjs/adonis-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/adonisjs/adonis-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/adonisjs/adonis-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/adonisjs/adonis-framework/contents/{+path}","compare_url":"https://api.github.com/repos/adonisjs/adonis-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adonisjs/adonis-framework/merges","archive_url":"https://api.github.com/repos/adonisjs/adonis-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adonisjs/adonis-framework/downloads","issues_url":"https://api.github.com/repos/adonisjs/adonis-framework/issues{/number}","pulls_url":"https://api.github.com/repos/adonisjs/adonis-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/adonisjs/adonis-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/adonisjs/adonis-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adonisjs/adonis-framework/labels{/name}","releases_url":"https://api.github.com/repos/adonisjs/adonis-framework/releases{/id}","created_at":"2015-08-15T17:03:54Z","updated_at":"2015-12-04T16:36:09Z","pushed_at":"2015-12-05T13:19:22Z","git_url":"git://github.com/adonisjs/adonis-framework.git","ssh_url":"git@github.com:adonisjs/adonis-framework.git","clone_url":"https://github.com/adonisjs/adonis-framework.git","svn_url":"https://github.com/adonisjs/adonis-framework","homepage":null,"size":212,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25"},"html":{"href":"https://github.com/adonisjs/adonis-framework/pull/25"},"issue":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/issues/25"},"comments":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/adonisjs/adonis-framework/statuses/0f871e11169e2057f3787859cb0b3c9c983da652"}}}}