{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/39694642","id":39694642,"diff_hunk":"@@ -14,19 +14,25 @@\n \n namespace MathLib\n {\n+// A dummy vector as the default value of the third argument of\n+// the constructor.\n+static std::vector<std::size_t> dummy_non_ghost_local_ids;\n \n template <typename IDX_TYPE>\n struct RowColumnIndices\n {\n \ttypedef typename std::vector<IDX_TYPE> LineIndex;\n-\tRowColumnIndices(LineIndex const& rows_, LineIndex const& columns_)\n-\t\t: rows(rows_), columns(columns_)\n+\tRowColumnIndices(LineIndex const& rows_, LineIndex const& columns_,\n+\t                 const std::vector<std::size_t>& non_ghost_local_ids_\n+\t                 = dummy_non_ghost_local_ids)\n+\t\t: rows(rows_), columns(columns_), non_ghost_local_ids(non_ghost_local_ids_)\n \t{ }\n \n \tLineIndex const& rows;\n \tLineIndex const& columns;\n-};\n \n+\tstd::vector<std::size_t> const& non_ghost_local_ids;","path":"MathLib/LinAlg/RowColumnIndices.h","position":24,"original_position":24,"commit_id":"b14e7c661f7a15cb03ba8845493d74112108f870","original_commit_id":"b14e7c661f7a15cb03ba8845493d74112108f870","user":{"login":"endJunction","id":329493,"avatar_url":"https://avatars.githubusercontent.com/u/329493?v=3","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"Is it possible to avoid the non_ghost_local_ids here and move it entirely to AssemblerLib?\r\nI'm asking, because this member is used outside of AssemblerLib only once in the GroundwaterFlowFEM, which should become independent of any mpi related code.","created_at":"2015-09-16T22:43:16Z","updated_at":"2015-09-16T22:43:16Z","html_url":"https://github.com/ufz/ogs/pull/580#discussion_r39694642","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/580","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/39694642"},"html":{"href":"https://github.com/ufz/ogs/pull/580#discussion_r39694642"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/580"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/580","id":28546793,"html_url":"https://github.com/ufz/ogs/pull/580","diff_url":"https://github.com/ufz/ogs/pull/580.diff","patch_url":"https://github.com/ufz/ogs/pull/580.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/580","number":580,"state":"open","locked":false,"title":"Parallelization of the FEM by using PETSc","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"As the title, this PR presents an implementation of parallelization of assembly and linear solver for the existing process modeler: groundwater flow.  There are changes mainly in ``AssemblerLib``, and ``ProcessLib``. This PR is categorized as follows:\r\n\r\n1.  Changes in ``AssemblerLib``\r\n  * [ASLib] Modified mesh component related classes for DDC. \t5745e8c\r\n  * [ASLib] Added two new files. \t                                                f6b1a77\r\n  * [ASLib] Moved two local variables to the place close to where they ar… … 9ae7b42\r\n  * [ASLib] Updated some comments. \t26e0665\r\n  * [MathLib] Replaced one indentation of 4 white spaces with a tab. \t1509518\r\n\r\n2. Changes in ``ProcessLib``\r\n  * [PCS] Parallelized the process calculation. e5864f6\r\n  * [Mesh] Added a member to NodePartitionedMesh 3173e9d\r\n\r\n3. Changes in main function.\r\n  * [CLI] Added PETSc and MPI stuffs in main function of CLI. e136d4e\r\n  * [CLI] Removed one blank line. bc042e0\r\n  * [CLI] Added PETSc vector, matrix and solver specifications in Numeric… … \t0067366\r\n\r\n4. Changes in test.\r\n  * [CM] Disabled compiling SteadyDiffusion2DExample1 under USE_PETSC. \t38fb4db\r\n  * [CM] Excluded non-MPI tests from the test list under MPI. \t4bd70c8\r\n  * [TEST] Added a test for the parallel FEM and also its input data. \tabfee39","created_at":"2015-02-03T12:01:26Z","updated_at":"2015-09-16T22:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee5d0098ef504d2ffd36487b2883a9974daa5fa6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/580/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/580/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/580/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/b14e7c661f7a15cb03ba8845493d74112108f870","head":{"label":"wenqing:pFEM4","ref":"pFEM4","sha":"b14e7c661f7a15cb03ba8845493d74112108f870","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"repo":{"id":12785911,"name":"ogs","full_name":"wenqing/ogs","owner":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wenqing/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/wenqing/ogs","forks_url":"https://api.github.com/repos/wenqing/ogs/forks","keys_url":"https://api.github.com/repos/wenqing/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wenqing/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wenqing/ogs/teams","hooks_url":"https://api.github.com/repos/wenqing/ogs/hooks","issue_events_url":"https://api.github.com/repos/wenqing/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/wenqing/ogs/events","assignees_url":"https://api.github.com/repos/wenqing/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/wenqing/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/wenqing/ogs/tags","blobs_url":"https://api.github.com/repos/wenqing/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wenqing/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wenqing/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wenqing/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wenqing/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/wenqing/ogs/languages","stargazers_url":"https://api.github.com/repos/wenqing/ogs/stargazers","contributors_url":"https://api.github.com/repos/wenqing/ogs/contributors","subscribers_url":"https://api.github.com/repos/wenqing/ogs/subscribers","subscription_url":"https://api.github.com/repos/wenqing/ogs/subscription","commits_url":"https://api.github.com/repos/wenqing/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wenqing/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wenqing/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wenqing/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wenqing/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/wenqing/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wenqing/ogs/merges","archive_url":"https://api.github.com/repos/wenqing/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wenqing/ogs/downloads","issues_url":"https://api.github.com/repos/wenqing/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/wenqing/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/wenqing/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/wenqing/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wenqing/ogs/labels{/name}","releases_url":"https://api.github.com/repos/wenqing/ogs/releases{/id}","created_at":"2013-09-12T14:33:21Z","updated_at":"2015-02-25T13:44:13Z","pushed_at":"2015-09-16T13:37:08Z","git_url":"git://github.com/wenqing/ogs.git","ssh_url":"git@github.com:wenqing/ogs.git","clone_url":"https://github.com/wenqing/ogs.git","svn_url":"https://github.com/wenqing/ogs","homepage":"www.opengeosys.org","size":11307,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"ce2f1ed44df9160c5bdb526f2e3165dbb9211c35","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-07-31T12:46:58Z","pushed_at":"2015-09-16T13:37:09Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":16777,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":55,"forks":36,"open_issues":55,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/580"},"html":{"href":"https://github.com/ufz/ogs/pull/580"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/580"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/b14e7c661f7a15cb03ba8845493d74112108f870"}}}}