{"action":"opened","number":275,"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/275","id":42167967,"html_url":"https://github.com/apache/trafficserver/pull/275","diff_url":"https://github.com/apache/trafficserver/pull/275.diff","patch_url":"https://github.com/apache/trafficserver/pull/275.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/275","number":275,"state":"open","locked":false,"title":"TS-3797: Crashes due to cross-thread race conditions.","user":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"body":"We have been testing a version of this in production on a few machines for the past two weeks.  We are expanding the testing to more machines.  \r\n\r\nThis patch is slightly different than what we are running in production.  I've done a bit a clean up (removing asserts and unifying changed methods that didn't really need to be there).  The biggest difference from what we are running in production is moving the locking logic in HttpSessionManager::acquire_session to release the global pool lock sooner.  I'm running this version on a single test box in production at this point.   Will roll these changes back into broader production after the initial version passes muster (plus changes that get identified in this review).\r\n\r\nArticle describing the design of VC Migration https://cwiki.apache.org/confluence/display/TS/Threading+Issues+And+NetVC+Migration\r\n\r\nAlso a heads up that while I'm calling this VC migration, the only thing that is migrating is the socket and the SSL object.  The actual VC data structures are re-created on the new thread.","created_at":"2015-08-11T19:31:44Z","updated_at":"2015-08-11T19:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/275/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/275/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/275/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/fe7edce412a8d066a1207cefb421824b4a2ac0ce","head":{"label":"shinrich:ts-3797","ref":"ts-3797","sha":"fe7edce412a8d066a1207cefb421824b4a2ac0ce","user":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"repo":{"id":22690186,"name":"trafficserver","full_name":"shinrich/trafficserver","owner":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinrich/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/shinrich/trafficserver","forks_url":"https://api.github.com/repos/shinrich/trafficserver/forks","keys_url":"https://api.github.com/repos/shinrich/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinrich/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinrich/trafficserver/teams","hooks_url":"https://api.github.com/repos/shinrich/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/shinrich/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/shinrich/trafficserver/events","assignees_url":"https://api.github.com/repos/shinrich/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/shinrich/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/shinrich/trafficserver/tags","blobs_url":"https://api.github.com/repos/shinrich/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinrich/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinrich/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinrich/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinrich/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/shinrich/trafficserver/languages","stargazers_url":"https://api.github.com/repos/shinrich/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/shinrich/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/shinrich/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/shinrich/trafficserver/subscription","commits_url":"https://api.github.com/repos/shinrich/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinrich/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinrich/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinrich/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinrich/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/shinrich/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinrich/trafficserver/merges","archive_url":"https://api.github.com/repos/shinrich/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinrich/trafficserver/downloads","issues_url":"https://api.github.com/repos/shinrich/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/shinrich/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/shinrich/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/shinrich/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinrich/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/shinrich/trafficserver/releases{/id}","created_at":"2014-08-06T16:38:05Z","updated_at":"2015-05-01T19:57:32Z","pushed_at":"2015-08-11T19:21:24Z","git_url":"git://github.com/shinrich/trafficserver.git","ssh_url":"git@github.com:shinrich/trafficserver.git","clone_url":"https://github.com/shinrich/trafficserver.git","svn_url":"https://github.com/shinrich/trafficserver","homepage":null,"size":48011,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f65b867bd0741ec1d370e429ac774e5930a56dfa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","created_at":"2009-10-31T08:00:10Z","updated_at":"2015-08-10T09:12:18Z","pushed_at":"2015-08-11T16:03:05Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":70707,"stargazers_count":305,"watchers_count":305,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":212,"mirror_url":"git://git.apache.org/trafficserver.git","open_issues_count":22,"forks":212,"open_issues":22,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/275"},"html":{"href":"https://github.com/apache/trafficserver/pull/275"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/275"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/fe7edce412a8d066a1207cefb421824b4a2ac0ce"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":246,"deletions":45,"changed_files":11}}