{"push_id":758420795,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"be64491605f13de9d5dc3242f59350a67f287cb7","before":"74baa8c3d7de3e9e072a0e7f8c869372dc3db861","commits":[{"sha":"5be50a3d2fb8f4fda82a868811639254029c8faf","author":{"email":"2b6bbb4bffb950b0967cd3a1166c66cfcf859973@digital.cabinet-office.gov.uk","name":"Richard Boulton"},"message":"Handle messages with no title or description\n\nThis is in response to errors we've started getting with processing of\nredirect documents (which have neither title nor description), and\norganisation documents (which have no description).  These document\nformats didn't exist in content-store when the service was initially\ndesigned.  Further, until some recent changes in the publishing API,\neven when the fields were absent from the document sent to the\npublishing API, the message on the message queue had the fields present\nwith their values set to `nil`, so passed validation here.\n\n\"Content\" documents should always have a title, so ignoring documents\nwithout them is safe, and has the small benefit of ensuring that there's\nno risk of things like \"redirect\" documents triggering alerts.  Sending\nan alert for a document without a title would be uninformative anyway,\nsince the title is how we identify the document in the body of the\nmessage.\n\nIf a document has a missing description field, we can still send a\nuseful message - it will just be missing the description of the\ndocument.  Therefore, we allow messages to be sent in this case.\n\nThe code this touches could do with some refactoring, but I don't want\nto get people distracted by that right now - I just want to fix the\nimmediate problems.","distinct":false,"url":"https://api.github.com/repos/alphagov/email-alert-service/commits/5be50a3d2fb8f4fda82a868811639254029c8faf"},{"sha":"be64491605f13de9d5dc3242f59350a67f287cb7","author":{"email":"60c6d277a8bd81de7fdde19201bf9c58a3df08f4@tomlins.org.uk","name":"Alex Tomlins"},"message":"Merge pull request #38 from alphagov/looser-validation\n\nHandle messages with no title or description","distinct":true,"url":"https://api.github.com/repos/alphagov/email-alert-service/commits/be64491605f13de9d5dc3242f59350a67f287cb7"}]}