{"action":"created","issue":{"url":"https://api.github.com/repos/soundcloud/glimpse/issues/17","labels_url":"https://api.github.com/repos/soundcloud/glimpse/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/soundcloud/glimpse/issues/17/comments","events_url":"https://api.github.com/repos/soundcloud/glimpse/issues/17/events","html_url":"https://github.com/soundcloud/glimpse/pull/17","id":59526695,"number":17,"title":"Improve acceptance tests","user":{"login":"xla","id":1585,"avatar_url":"https://avatars.githubusercontent.com/u/1585?v=3","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-02T18:49:53Z","updated_at":"2015-03-03T13:05:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/soundcloud/glimpse/pulls/17","html_url":"https://github.com/soundcloud/glimpse/pull/17","diff_url":"https://github.com/soundcloud/glimpse/pull/17.diff","patch_url":"https://github.com/soundcloud/glimpse/pull/17.patch"},"body":"This PR addresses the unstable acceptance tests due to reliance on log output for the setup of the dependent binaries. Additionally it tests for the appropriate metrics per OS. More detail can be found in the corresponding commit messages.\r\n\r\n***\r\n@soundcloud/iss "},"comment":{"url":"https://api.github.com/repos/soundcloud/glimpse/issues/comments/76941442","html_url":"https://github.com/soundcloud/glimpse/pull/17#issuecomment-76941442","issue_url":"https://api.github.com/repos/soundcloud/glimpse/issues/17","id":76941442,"user":{"login":"peterbourgon","id":114509,"avatar_url":"https://avatars.githubusercontent.com/u/114509?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbourgon","html_url":"https://github.com/peterbourgon","followers_url":"https://api.github.com/users/peterbourgon/followers","following_url":"https://api.github.com/users/peterbourgon/following{/other_user}","gists_url":"https://api.github.com/users/peterbourgon/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbourgon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbourgon/subscriptions","organizations_url":"https://api.github.com/users/peterbourgon/orgs","repos_url":"https://api.github.com/users/peterbourgon/repos","events_url":"https://api.github.com/users/peterbourgon/events{/privacy}","received_events_url":"https://api.github.com/users/peterbourgon/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T13:05:07Z","updated_at":"2015-03-03T13:05:07Z","body":"You apparently can't `exec.Command.Wait()` in one goroutine, and `Read()` from its stdout/stderr in another. At least not how it's set up here. (I'm not sure it's worth fixing this.)\r\n\r\n```\r\n=== RUN TestAgentMissingConsul\r\n==================\r\nWARNING: DATA RACE\r\nWrite by goroutine 32:\r\n  os.(*file).close()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/file_unix.go:109 +0x1d7\r\n  os.(*File).Close()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/file_unix.go:98 +0x91\r\n  os/exec.(*Cmd).closeDescriptors()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/exec/exec.go:229 +0xa2\r\n  os/exec.(*Cmd).Wait()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/exec/exec.go:374 +0x4e1\r\n  github.com/soundcloud/glimpse/agent.func·011()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:477 +0x35\r\n\r\nPrevious read by goroutine 30:\r\n  os.(*File).read()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/file_unix.go:191 +0x9d\r\n  os.(*File).Read()\r\n      /Users/peter/src/go.googlesource.com/go/src/os/file.go:95 +0xc3\r\n  bufio.(*Reader).fill()\r\n      /Users/peter/src/go.googlesource.com/go/src/bufio/bufio.go:97 +0x381\r\n  bufio.(*Reader).ReadSlice()\r\n      /Users/peter/src/go.googlesource.com/go/src/bufio/bufio.go:295 +0x60b\r\n  bufio.(*Reader).ReadLine()\r\n      /Users/peter/src/go.googlesource.com/go/src/bufio/bufio.go:324 +0x7b\r\n  github.com/soundcloud/glimpse/agent.readLines()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:549 +0x8c\r\n\r\nGoroutine 32 (running) created at:\r\n  github.com/soundcloud/glimpse/agent.runCmd()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:478 +0x2ca\r\n  github.com/soundcloud/glimpse/agent.runAgent()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:363 +0x239\r\n  github.com/soundcloud/glimpse/agent.TestAgent()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:156 +0x2394\r\n  testing.tRunner()\r\n      /Users/peter/src/go.googlesource.com/go/src/testing/testing.go:447 +0x133\r\n\r\nGoroutine 30 (running) created at:\r\n  github.com/soundcloud/glimpse/agent.runCmd()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:468 +0x211\r\n  github.com/soundcloud/glimpse/agent.runAgent()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:363 +0x239\r\n  github.com/soundcloud/glimpse/agent.TestAgent()\r\n      /Users/peter/src/github.com/soundcloud/glimpse/agent/acceptance_test.go:156 +0x2394\r\n  testing.tRunner()\r\n      /Users/peter/src/go.googlesource.com/go/src/testing/testing.go:447 +0x133\r\n==================\r\n```"}}