{"action":"created","comment":{"url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/comments/26186487","id":26186487,"diff_hunk":"@@ -0,0 +1,44 @@\n+from os import environ\n+\n+import testtools\n+\n+from ecstest.common import client\n+from ecstest.common import matchers\n+\n+\n+ADMIN_USERNAME = environ.get('ADMIN_USERNAME', 'username')\n+ADMIN_PASSWORD = environ.get('ADMIN_PASSWORD', 'password')\n+TOKEN = environ.get('TOKEN', None)\n+ECS_CONTROL_ENDPOINT = environ.get('ECS_CONTROL_ENDPOINT',\n+                                   'https://172.29.62.40:4443')\n+ECS_TOKEN_ENDPOINT = environ.get('ECS_TOKEN_ENDPOINT',\n+                                 'https://172.29.62.40:4443/login')\n+VERIFY_SSL = bool(int(environ.get('VERIFY_SSL', 0)))\n+TOKEN_FILENAME = environ.get('TOKEN_FILENAME', '/tmp/ecstest.token')\n+REQUEST_TIMEOUT = float(environ.get('REQUEST_TIMEOUT', 15.0))\n+CACHE_TOKEN = bool(int(environ.get('CACHE_TOKEN', 1)))","path":"ecstest/common/testbase.py","position":19,"original_position":19,"commit_id":"8481fe361d91e4c53e2625b3d1dd144aa3e02085","original_commit_id":"8481fe361d91e4c53e2625b3d1dd144aa3e02085","user":{"login":"flei2000","id":8193789,"avatar_url":"https://avatars.githubusercontent.com/u/8193789?v=3","gravatar_id":"","url":"https://api.github.com/users/flei2000","html_url":"https://github.com/flei2000","followers_url":"https://api.github.com/users/flei2000/followers","following_url":"https://api.github.com/users/flei2000/following{/other_user}","gists_url":"https://api.github.com/users/flei2000/gists{/gist_id}","starred_url":"https://api.github.com/users/flei2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flei2000/subscriptions","organizations_url":"https://api.github.com/users/flei2000/orgs","repos_url":"https://api.github.com/users/flei2000/repos","events_url":"https://api.github.com/users/flei2000/events{/privacy}","received_events_url":"https://api.github.com/users/flei2000/received_events","type":"User","site_admin":false},"body":"I would suggest:\r\n- Config files under a separate 'config/' dir. Each file is a list of env variables in shell.\r\n- Each case can have some tags\r\n- The case runner needs  a config (or default), a tag (default all) or a single case to run","created_at":"2015-03-11T03:22:16Z","updated_at":"2015-03-11T03:22:16Z","html_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2#discussion_r26186487","pull_request_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/comments/26186487"},"html":{"href":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2#discussion_r26186487"},"pull_request":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2","id":30903281,"html_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2","diff_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2.diff","patch_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2.patch","issue_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/2","number":2,"state":"open","locked":false,"title":"Create test scaffolding and first TestCase for user login.","user":{"login":"stevendgonzales","id":3586503,"avatar_url":"https://avatars.githubusercontent.com/u/3586503?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendgonzales","html_url":"https://github.com/stevendgonzales","followers_url":"https://api.github.com/users/stevendgonzales/followers","following_url":"https://api.github.com/users/stevendgonzales/following{/other_user}","gists_url":"https://api.github.com/users/stevendgonzales/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendgonzales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendgonzales/subscriptions","organizations_url":"https://api.github.com/users/stevendgonzales/orgs","repos_url":"https://api.github.com/users/stevendgonzales/repos","events_url":"https://api.github.com/users/stevendgonzales/events{/privacy}","received_events_url":"https://api.github.com/users/stevendgonzales/received_events","type":"User","site_admin":false},"body":"Create stub of restful test client for ECS Control Plane.\r\nAdd custom testtools matcher for validating json against a schema.\r\nCreate a custom TestBase class for TesCases that provides access to\r\nthe test client and uses custom json matcher to implement\r\nself.assertJsonSchema(myschema, myjson)\r\nTestUserLogin TestCase that makes assertions on valid and invalid\r\nlogin attempts.","created_at":"2015-03-10T23:32:28Z","updated_at":"2015-03-11T03:22:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b012dd55db40fb66c6353665826add7f7cd9871","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2/commits","review_comments_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2/comments","review_comment_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/2/comments","statuses_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/statuses/8481fe361d91e4c53e2625b3d1dd144aa3e02085","head":{"label":"stevendgonzales:login_test_case","ref":"login_test_case","sha":"8481fe361d91e4c53e2625b3d1dd144aa3e02085","user":{"login":"stevendgonzales","id":3586503,"avatar_url":"https://avatars.githubusercontent.com/u/3586503?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendgonzales","html_url":"https://github.com/stevendgonzales","followers_url":"https://api.github.com/users/stevendgonzales/followers","following_url":"https://api.github.com/users/stevendgonzales/following{/other_user}","gists_url":"https://api.github.com/users/stevendgonzales/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendgonzales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendgonzales/subscriptions","organizations_url":"https://api.github.com/users/stevendgonzales/orgs","repos_url":"https://api.github.com/users/stevendgonzales/repos","events_url":"https://api.github.com/users/stevendgonzales/events{/privacy}","received_events_url":"https://api.github.com/users/stevendgonzales/received_events","type":"User","site_admin":false},"repo":{"id":31952481,"name":"ecstest","full_name":"stevendgonzales/ecstest","owner":{"login":"stevendgonzales","id":3586503,"avatar_url":"https://avatars.githubusercontent.com/u/3586503?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendgonzales","html_url":"https://github.com/stevendgonzales","followers_url":"https://api.github.com/users/stevendgonzales/followers","following_url":"https://api.github.com/users/stevendgonzales/following{/other_user}","gists_url":"https://api.github.com/users/stevendgonzales/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendgonzales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendgonzales/subscriptions","organizations_url":"https://api.github.com/users/stevendgonzales/orgs","repos_url":"https://api.github.com/users/stevendgonzales/repos","events_url":"https://api.github.com/users/stevendgonzales/events{/privacy}","received_events_url":"https://api.github.com/users/stevendgonzales/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevendgonzales/ecstest","description":"ECS Test Scripts","fork":true,"url":"https://api.github.com/repos/stevendgonzales/ecstest","forks_url":"https://api.github.com/repos/stevendgonzales/ecstest/forks","keys_url":"https://api.github.com/repos/stevendgonzales/ecstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevendgonzales/ecstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevendgonzales/ecstest/teams","hooks_url":"https://api.github.com/repos/stevendgonzales/ecstest/hooks","issue_events_url":"https://api.github.com/repos/stevendgonzales/ecstest/issues/events{/number}","events_url":"https://api.github.com/repos/stevendgonzales/ecstest/events","assignees_url":"https://api.github.com/repos/stevendgonzales/ecstest/assignees{/user}","branches_url":"https://api.github.com/repos/stevendgonzales/ecstest/branches{/branch}","tags_url":"https://api.github.com/repos/stevendgonzales/ecstest/tags","blobs_url":"https://api.github.com/repos/stevendgonzales/ecstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevendgonzales/ecstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevendgonzales/ecstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevendgonzales/ecstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevendgonzales/ecstest/statuses/{sha}","languages_url":"https://api.github.com/repos/stevendgonzales/ecstest/languages","stargazers_url":"https://api.github.com/repos/stevendgonzales/ecstest/stargazers","contributors_url":"https://api.github.com/repos/stevendgonzales/ecstest/contributors","subscribers_url":"https://api.github.com/repos/stevendgonzales/ecstest/subscribers","subscription_url":"https://api.github.com/repos/stevendgonzales/ecstest/subscription","commits_url":"https://api.github.com/repos/stevendgonzales/ecstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevendgonzales/ecstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevendgonzales/ecstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevendgonzales/ecstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevendgonzales/ecstest/contents/{+path}","compare_url":"https://api.github.com/repos/stevendgonzales/ecstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevendgonzales/ecstest/merges","archive_url":"https://api.github.com/repos/stevendgonzales/ecstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevendgonzales/ecstest/downloads","issues_url":"https://api.github.com/repos/stevendgonzales/ecstest/issues{/number}","pulls_url":"https://api.github.com/repos/stevendgonzales/ecstest/pulls{/number}","milestones_url":"https://api.github.com/repos/stevendgonzales/ecstest/milestones{/number}","notifications_url":"https://api.github.com/repos/stevendgonzales/ecstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevendgonzales/ecstest/labels{/name}","releases_url":"https://api.github.com/repos/stevendgonzales/ecstest/releases{/id}","created_at":"2015-03-10T10:56:43Z","updated_at":"2015-03-10T10:56:28Z","pushed_at":"2015-03-10T23:31:33Z","git_url":"git://github.com/stevendgonzales/ecstest.git","ssh_url":"git@github.com:stevendgonzales/ecstest.git","clone_url":"https://github.com/stevendgonzales/ecstest.git","svn_url":"https://github.com/stevendgonzales/ecstest","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EMC-Rubicon-Cloud-Svc-Pub:master","ref":"master","sha":"1d7837429e9d9c9b81c22febc3dd387e7372e7db","user":{"login":"EMC-Rubicon-Cloud-Svc-Pub","id":7444706,"avatar_url":"https://avatars.githubusercontent.com/u/7444706?v=3","gravatar_id":"","url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub","html_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub","followers_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/followers","following_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/following{/other_user}","gists_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/gists{/gist_id}","starred_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/subscriptions","organizations_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/orgs","repos_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/repos","events_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/events{/privacy}","received_events_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/received_events","type":"Organization","site_admin":false},"repo":{"id":31924123,"name":"ecstest","full_name":"EMC-Rubicon-Cloud-Svc-Pub/ecstest","owner":{"login":"EMC-Rubicon-Cloud-Svc-Pub","id":7444706,"avatar_url":"https://avatars.githubusercontent.com/u/7444706?v=3","gravatar_id":"","url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub","html_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub","followers_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/followers","following_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/following{/other_user}","gists_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/gists{/gist_id}","starred_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/subscriptions","organizations_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/orgs","repos_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/repos","events_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/events{/privacy}","received_events_url":"https://api.github.com/users/EMC-Rubicon-Cloud-Svc-Pub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest","description":"ECS Test Scripts","fork":false,"url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest","forks_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/forks","keys_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/teams","hooks_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/hooks","issue_events_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/events{/number}","events_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/events","assignees_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/assignees{/user}","branches_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/branches{/branch}","tags_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/tags","blobs_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/git/refs{/sha}","trees_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/statuses/{sha}","languages_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/languages","stargazers_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/stargazers","contributors_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/contributors","subscribers_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/subscribers","subscription_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/subscription","commits_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/commits{/sha}","git_commits_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/git/commits{/sha}","comments_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/comments{/number}","issue_comment_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/comments{/number}","contents_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/contents/{+path}","compare_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/merges","archive_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/downloads","issues_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues{/number}","pulls_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls{/number}","milestones_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/milestones{/number}","notifications_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/labels{/name}","releases_url":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/releases{/id}","created_at":"2015-03-09T21:38:00Z","updated_at":"2015-03-11T02:17:11Z","pushed_at":"2015-03-11T02:17:11Z","git_url":"git://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest.git","ssh_url":"git@github.com:EMC-Rubicon-Cloud-Svc-Pub/ecstest.git","clone_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest.git","svn_url":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2"},"html":{"href":"https://github.com/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pull/2"},"issue":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/2"},"comments":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/EMC-Rubicon-Cloud-Svc-Pub/ecstest/statuses/8481fe361d91e4c53e2625b3d1dd144aa3e02085"}}}}