{"action":"created","comment":{"url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/comments/36859452","id":36859452,"diff_hunk":"@@ -154,23 +154,98 @@ The function getMyObjectLoopingStartingFromZeroById finds the object in a privat\n - Only out of package helper classes that are only used by the main class can be found in the same file.\n - Class structure should follow the Step down method. Private, public properties – then methods in descending order of importance.\n \n+### Version Numbers\n+\n+Projects should be versioned, with version numbers incrementing automatically.\n+\n+For .NET projects:\n+\n+You can specify all the values or you can accept the default build number, revision number, or both by using an asterisk (*). For example, [assembly:AssemblyVersion(\"2.3.25.1\")] indicates 2 as the major version, 3 as the minor version, 25 as the build number, and 1 as the revision number. A version number such as [assembly:AssemblyVersion(\"1.2.*\")] specifies 1 as the major version, 2 as the minor version, and accepts the default build and revision numbers. A version number such as [assembly:AssemblyVersion(\"1.2.15.*\")] specifies 1 as the major version, 2 as the minor version, 15 as the build number, and accepts the default revision number. The default build number increments daily. The default revision number is random.\n+\n+Pasted from <http://msdn.microsoft.com/en-us/library/system.reflection.assemblyversionattribute.aspx> \n+\n+\n ### Fixing Bugs\n \n Fixed bug = test x N\n \n There must be at least one test to prove that the bug is fixed and that it will never happen again.  Unless you have a really good reason.\n \n-\n ### Source Control – commit as you get working code.\n \n-At an absolute minimum, you should check-in your code before you go home.\n+All projects should be source controlled using Git.\n+\n+Your code in each commit should compile and pass unit tests, no broken tests should be committed.","path":"CardinalRules.md","position":45,"original_position":27,"commit_id":"9cd1bbcc6af99691c5ad10395f7a449c3f0591bf","original_commit_id":"daaf711ed9e8cec9f8de29313931f25eb29211a0","user":{"login":"taharrison","id":3972267,"avatar_url":"https://avatars.githubusercontent.com/u/3972267?v=3","gravatar_id":"","url":"https://api.github.com/users/taharrison","html_url":"https://github.com/taharrison","followers_url":"https://api.github.com/users/taharrison/followers","following_url":"https://api.github.com/users/taharrison/following{/other_user}","gists_url":"https://api.github.com/users/taharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/taharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taharrison/subscriptions","organizations_url":"https://api.github.com/users/taharrison/orgs","repos_url":"https://api.github.com/users/taharrison/repos","events_url":"https://api.github.com/users/taharrison/events{/privacy}","received_events_url":"https://api.github.com/users/taharrison/received_events","type":"User","site_admin":false},"body":"Agreed.  If I want to write a failed test for a bug, I should be able to commit it before fixing the bug.\r\n\r\nHowever, this must be on a feature branch.  Green light on develop and master is too important to compromise with noise tests that fail for unimplemented features / bugs.\r\n\r\nI propose that \"Your code in each commit should compile and pass unit tests, no broken tests should be committed.\" should be amended to \"Your code in each commit **to develop and master branches** should compile and pass unit tests, no broken tests should be committed.\"","created_at":"2015-08-12T13:35:50Z","updated_at":"2015-08-12T13:35:50Z","html_url":"https://github.com/burrowsyr/Styleguide/pull/7#discussion_r36859452","pull_request_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/comments/36859452"},"html":{"href":"https://github.com/burrowsyr/Styleguide/pull/7#discussion_r36859452"},"pull_request":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7","id":41444625,"html_url":"https://github.com/burrowsyr/Styleguide/pull/7","diff_url":"https://github.com/burrowsyr/Styleguide/pull/7.diff","patch_url":"https://github.com/burrowsyr/Styleguide/pull/7.patch","issue_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/7","number":7,"state":"open","locked":false,"title":"Feature/cardinal rules updates","user":{"login":"westonized","id":6041352,"avatar_url":"https://avatars.githubusercontent.com/u/6041352?v=3","gravatar_id":"","url":"https://api.github.com/users/westonized","html_url":"https://github.com/westonized","followers_url":"https://api.github.com/users/westonized/followers","following_url":"https://api.github.com/users/westonized/following{/other_user}","gists_url":"https://api.github.com/users/westonized/gists{/gist_id}","starred_url":"https://api.github.com/users/westonized/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westonized/subscriptions","organizations_url":"https://api.github.com/users/westonized/orgs","repos_url":"https://api.github.com/users/westonized/repos","events_url":"https://api.github.com/users/westonized/events{/privacy}","received_events_url":"https://api.github.com/users/westonized/received_events","type":"User","site_admin":false},"body":"This is a pull request of just the recent changes. The original being in master now. The net result is the same as #4\r\n\r\nPlease review @rickyclegg @Gonzales @jasonjeffrey @petefitz @taharrison @Chess808 @richardorchardburrows @gopher504 @DominicFaraday @westonized @danielbanting","created_at":"2015-08-03T08:28:20Z","updated_at":"2015-08-12T13:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f9f913d543dc3922894985d0f859a0814d7ae5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7/commits","review_comments_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7/comments","review_comment_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/7/comments","statuses_url":"https://api.github.com/repos/burrowsyr/Styleguide/statuses/9cd1bbcc6af99691c5ad10395f7a449c3f0591bf","head":{"label":"burrowsyr:feature/cardinal-rules-updates","ref":"feature/cardinal-rules-updates","sha":"9cd1bbcc6af99691c5ad10395f7a449c3f0591bf","user":{"login":"burrowsyr","id":3775518,"avatar_url":"https://avatars.githubusercontent.com/u/3775518?v=3","gravatar_id":"","url":"https://api.github.com/users/burrowsyr","html_url":"https://github.com/burrowsyr","followers_url":"https://api.github.com/users/burrowsyr/followers","following_url":"https://api.github.com/users/burrowsyr/following{/other_user}","gists_url":"https://api.github.com/users/burrowsyr/gists{/gist_id}","starred_url":"https://api.github.com/users/burrowsyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burrowsyr/subscriptions","organizations_url":"https://api.github.com/users/burrowsyr/orgs","repos_url":"https://api.github.com/users/burrowsyr/repos","events_url":"https://api.github.com/users/burrowsyr/events{/privacy}","received_events_url":"https://api.github.com/users/burrowsyr/received_events","type":"Organization","site_admin":false},"repo":{"id":25196580,"name":"Styleguide","full_name":"burrowsyr/Styleguide","owner":{"login":"burrowsyr","id":3775518,"avatar_url":"https://avatars.githubusercontent.com/u/3775518?v=3","gravatar_id":"","url":"https://api.github.com/users/burrowsyr","html_url":"https://github.com/burrowsyr","followers_url":"https://api.github.com/users/burrowsyr/followers","following_url":"https://api.github.com/users/burrowsyr/following{/other_user}","gists_url":"https://api.github.com/users/burrowsyr/gists{/gist_id}","starred_url":"https://api.github.com/users/burrowsyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burrowsyr/subscriptions","organizations_url":"https://api.github.com/users/burrowsyr/orgs","repos_url":"https://api.github.com/users/burrowsyr/repos","events_url":"https://api.github.com/users/burrowsyr/events{/privacy}","received_events_url":"https://api.github.com/users/burrowsyr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/burrowsyr/Styleguide","description":"Styleguides for all languages used at Burrows.","fork":false,"url":"https://api.github.com/repos/burrowsyr/Styleguide","forks_url":"https://api.github.com/repos/burrowsyr/Styleguide/forks","keys_url":"https://api.github.com/repos/burrowsyr/Styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burrowsyr/Styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burrowsyr/Styleguide/teams","hooks_url":"https://api.github.com/repos/burrowsyr/Styleguide/hooks","issue_events_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/burrowsyr/Styleguide/events","assignees_url":"https://api.github.com/repos/burrowsyr/Styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/burrowsyr/Styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/burrowsyr/Styleguide/tags","blobs_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burrowsyr/Styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/burrowsyr/Styleguide/languages","stargazers_url":"https://api.github.com/repos/burrowsyr/Styleguide/stargazers","contributors_url":"https://api.github.com/repos/burrowsyr/Styleguide/contributors","subscribers_url":"https://api.github.com/repos/burrowsyr/Styleguide/subscribers","subscription_url":"https://api.github.com/repos/burrowsyr/Styleguide/subscription","commits_url":"https://api.github.com/repos/burrowsyr/Styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/burrowsyr/Styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/burrowsyr/Styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/burrowsyr/Styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burrowsyr/Styleguide/merges","archive_url":"https://api.github.com/repos/burrowsyr/Styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burrowsyr/Styleguide/downloads","issues_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/burrowsyr/Styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/burrowsyr/Styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burrowsyr/Styleguide/labels{/name}","releases_url":"https://api.github.com/repos/burrowsyr/Styleguide/releases{/id}","created_at":"2014-10-14T08:15:22Z","updated_at":"2015-07-07T13:11:21Z","pushed_at":"2015-08-04T11:48:54Z","git_url":"git://github.com/burrowsyr/Styleguide.git","ssh_url":"git@github.com:burrowsyr/Styleguide.git","clone_url":"https://github.com/burrowsyr/Styleguide.git","svn_url":"https://github.com/burrowsyr/Styleguide","homepage":null,"size":494,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"burrowsyr:master","ref":"master","sha":"65de6a20752db2c922c85f5d7583dc631026877b","user":{"login":"burrowsyr","id":3775518,"avatar_url":"https://avatars.githubusercontent.com/u/3775518?v=3","gravatar_id":"","url":"https://api.github.com/users/burrowsyr","html_url":"https://github.com/burrowsyr","followers_url":"https://api.github.com/users/burrowsyr/followers","following_url":"https://api.github.com/users/burrowsyr/following{/other_user}","gists_url":"https://api.github.com/users/burrowsyr/gists{/gist_id}","starred_url":"https://api.github.com/users/burrowsyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burrowsyr/subscriptions","organizations_url":"https://api.github.com/users/burrowsyr/orgs","repos_url":"https://api.github.com/users/burrowsyr/repos","events_url":"https://api.github.com/users/burrowsyr/events{/privacy}","received_events_url":"https://api.github.com/users/burrowsyr/received_events","type":"Organization","site_admin":false},"repo":{"id":25196580,"name":"Styleguide","full_name":"burrowsyr/Styleguide","owner":{"login":"burrowsyr","id":3775518,"avatar_url":"https://avatars.githubusercontent.com/u/3775518?v=3","gravatar_id":"","url":"https://api.github.com/users/burrowsyr","html_url":"https://github.com/burrowsyr","followers_url":"https://api.github.com/users/burrowsyr/followers","following_url":"https://api.github.com/users/burrowsyr/following{/other_user}","gists_url":"https://api.github.com/users/burrowsyr/gists{/gist_id}","starred_url":"https://api.github.com/users/burrowsyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burrowsyr/subscriptions","organizations_url":"https://api.github.com/users/burrowsyr/orgs","repos_url":"https://api.github.com/users/burrowsyr/repos","events_url":"https://api.github.com/users/burrowsyr/events{/privacy}","received_events_url":"https://api.github.com/users/burrowsyr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/burrowsyr/Styleguide","description":"Styleguides for all languages used at Burrows.","fork":false,"url":"https://api.github.com/repos/burrowsyr/Styleguide","forks_url":"https://api.github.com/repos/burrowsyr/Styleguide/forks","keys_url":"https://api.github.com/repos/burrowsyr/Styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burrowsyr/Styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burrowsyr/Styleguide/teams","hooks_url":"https://api.github.com/repos/burrowsyr/Styleguide/hooks","issue_events_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/burrowsyr/Styleguide/events","assignees_url":"https://api.github.com/repos/burrowsyr/Styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/burrowsyr/Styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/burrowsyr/Styleguide/tags","blobs_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burrowsyr/Styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/burrowsyr/Styleguide/languages","stargazers_url":"https://api.github.com/repos/burrowsyr/Styleguide/stargazers","contributors_url":"https://api.github.com/repos/burrowsyr/Styleguide/contributors","subscribers_url":"https://api.github.com/repos/burrowsyr/Styleguide/subscribers","subscription_url":"https://api.github.com/repos/burrowsyr/Styleguide/subscription","commits_url":"https://api.github.com/repos/burrowsyr/Styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/burrowsyr/Styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/burrowsyr/Styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/burrowsyr/Styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/burrowsyr/Styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burrowsyr/Styleguide/merges","archive_url":"https://api.github.com/repos/burrowsyr/Styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burrowsyr/Styleguide/downloads","issues_url":"https://api.github.com/repos/burrowsyr/Styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/burrowsyr/Styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/burrowsyr/Styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/burrowsyr/Styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burrowsyr/Styleguide/labels{/name}","releases_url":"https://api.github.com/repos/burrowsyr/Styleguide/releases{/id}","created_at":"2014-10-14T08:15:22Z","updated_at":"2015-07-07T13:11:21Z","pushed_at":"2015-08-04T11:48:54Z","git_url":"git://github.com/burrowsyr/Styleguide.git","ssh_url":"git@github.com:burrowsyr/Styleguide.git","clone_url":"https://github.com/burrowsyr/Styleguide.git","svn_url":"https://github.com/burrowsyr/Styleguide","homepage":null,"size":494,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7"},"html":{"href":"https://github.com/burrowsyr/Styleguide/pull/7"},"issue":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/issues/7"},"comments":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/burrowsyr/Styleguide/statuses/9cd1bbcc6af99691c5ad10395f7a449c3f0591bf"}}}}