{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/30328843","id":30328843,"diff_hunk":"@@ -83,82 +78,28 @@ internal AsyncStreamReader(Process process, Stream stream, Action<string> callba\n             _messageQueue = new Queue<string>();\n         }\n \n-        public void Close()\n-        {\n-            Dispose(true);\n-        }\n-\n-        void IDisposable.Dispose()\n-        {\n-            Dispose(true);\n-            GC.SuppressFinalize(this);\n-        }\n-\n-        private void Dispose(bool disposing)\n-        {\n-            if (disposing)\n-            {\n-                if (_stream != null)\n-                    _stream.Dispose();\n-            }\n-            if (_stream != null)\n-            {\n-                _stream = null;\n-                _encoding = null;\n-                _decoder = null;\n-                _byteBuffer = null;\n-                _charBuffer = null;\n-            }\n-\n-            if (_eofEvent != null)\n-            {\n-                _eofEvent.Dispose();\n-                _eofEvent = null;\n-            }\n-        }\n-\n-        public Encoding CurrentEncoding\n-        {\n-            get { return _encoding; }\n-        }\n-\n-        public Stream BaseStream\n-        {\n-            get { return _stream; }\n-        }\n-\n         // User calls BeginRead to start the asynchronous read\n-        internal void BeginReadLine()\n+        internal void BeginReadLine(CancellationToken token)\n         {\n-            if (_cancelOperation)\n-            {\n-                _cancelOperation = false;\n-            }\n-\n             if (_sb == null)\n             {\n                 _sb = new StringBuilder(DefaultBufferSize);\n-                _stream.ReadAsync(_byteBuffer, 0, _byteBuffer.Length).ContinueWith(ReadBuffer, CancellationToken.None, TaskContinuationOptions.None, TaskScheduler.Default);\n+                ReadBuffer(token);\n             }\n             else\n             {\n-                FlushMessageQueue();\n+                FlushMessageQueue(token);\n             }\n         }\n \n-        internal void CancelOperation()\n-        {\n-            _cancelOperation = true;\n-        }\n-\n         // This is the async callback function. Only one thread could/should call this.\n-        private void ReadBuffer(Task<int> t)\n+        private async void ReadBuffer(CancellationToken token)","path":"src/System.Diagnostics.Process/src/System/Diagnostics/AsyncStreamReader.cs","position":130,"original_position":130,"commit_id":"c37c602dfa1086a628cbab8c4d15fa95de7f017d","original_commit_id":"c37c602dfa1086a628cbab8c4d15fa95de7f017d","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"I think this function needs to main changes:\r\n- The body should be wrapped in a Task.Run(async delegate { ... }).  That's because this call to ReadBuffer could be happening on the caller's thread, and without the ContinueWith forcing subsequent reads to run asynchronously, it's theoretically possible that this could become a long-running synchronous call.  With that, you also don't need the _eofEvent at all... you just store the scheduled Task, and the WaitForExit method just waits on the Task.\r\n- The recursive call to ReadBuffer should be removed.  Instead, this function should just contain a loop: read, process, read, process, etc., and at some point either because 0 bytes were read or an exception occurred, the loop is exited and the ending code runs to flush the message queue.","created_at":"2015-05-14T15:11:11Z","updated_at":"2015-05-14T15:11:11Z","html_url":"https://github.com/dotnet/corefx/pull/1743#discussion_r30328843","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/1743","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/30328843"},"html":{"href":"https://github.com/dotnet/corefx/pull/1743#discussion_r30328843"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1743"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1743","id":35383614,"html_url":"https://github.com/dotnet/corefx/pull/1743","diff_url":"https://github.com/dotnet/corefx/pull/1743.diff","patch_url":"https://github.com/dotnet/corefx/pull/1743.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1743","number":1743,"state":"open","locked":false,"title":"Cleanup AsyncStreamReader","user":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"body":"fix #1734\r\nfirst attempt :smile: \r\nwill reword  commit messages in case if attempt is viable","created_at":"2015-05-14T00:12:35Z","updated_at":"2015-05-14T15:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a344e3ae45eb37634436d088bfb930fe8e4b5dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1743/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/c37c602dfa1086a628cbab8c4d15fa95de7f017d","head":{"label":"Maxwe11:cleanup-asyncstreamreader","ref":"cleanup-asyncstreamreader","sha":"c37c602dfa1086a628cbab8c4d15fa95de7f017d","user":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"repo":{"id":29371653,"name":"corefx","full_name":"Maxwe11/corefx","owner":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Maxwe11/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/Maxwe11/corefx","forks_url":"https://api.github.com/repos/Maxwe11/corefx/forks","keys_url":"https://api.github.com/repos/Maxwe11/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maxwe11/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maxwe11/corefx/teams","hooks_url":"https://api.github.com/repos/Maxwe11/corefx/hooks","issue_events_url":"https://api.github.com/repos/Maxwe11/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Maxwe11/corefx/events","assignees_url":"https://api.github.com/repos/Maxwe11/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Maxwe11/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Maxwe11/corefx/tags","blobs_url":"https://api.github.com/repos/Maxwe11/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maxwe11/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maxwe11/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maxwe11/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maxwe11/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Maxwe11/corefx/languages","stargazers_url":"https://api.github.com/repos/Maxwe11/corefx/stargazers","contributors_url":"https://api.github.com/repos/Maxwe11/corefx/contributors","subscribers_url":"https://api.github.com/repos/Maxwe11/corefx/subscribers","subscription_url":"https://api.github.com/repos/Maxwe11/corefx/subscription","commits_url":"https://api.github.com/repos/Maxwe11/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maxwe11/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maxwe11/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maxwe11/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Maxwe11/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Maxwe11/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maxwe11/corefx/merges","archive_url":"https://api.github.com/repos/Maxwe11/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maxwe11/corefx/downloads","issues_url":"https://api.github.com/repos/Maxwe11/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Maxwe11/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Maxwe11/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Maxwe11/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maxwe11/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Maxwe11/corefx/releases{/id}","created_at":"2015-01-16T22:56:30Z","updated_at":"2015-05-08T11:08:07Z","pushed_at":"2015-05-13T23:59:32Z","git_url":"git://github.com/Maxwe11/corefx.git","ssh_url":"git@github.com:Maxwe11/corefx.git","clone_url":"https://github.com/Maxwe11/corefx.git","svn_url":"https://github.com/Maxwe11/corefx","homepage":"","size":19224,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e73399319965db81d8e1a8bc1a1886eb4f290d8d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-05-14T13:59:54Z","pushed_at":"2015-05-14T14:56:11Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":43248,"stargazers_count":7762,"watchers_count":7762,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1558,"mirror_url":null,"open_issues_count":379,"forks":1558,"open_issues":379,"watchers":7762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1743"},"html":{"href":"https://github.com/dotnet/corefx/pull/1743"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1743"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/c37c602dfa1086a628cbab8c4d15fa95de7f017d"}}}}