{"action":"created","issue":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/950","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/950/labels{/name}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/950/comments","events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/950/events","html_url":"https://github.com/HerculesWS/Hercules/pull/950","id":122061042,"number":950,"title":"Script commands with optional parameter look for player will now ShowWarning","user":{"login":"AnnieRuru","id":6211477,"avatar_url":"https://avatars.githubusercontent.com/u/6211477?v=3","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:core:scriptengine","name":"component:core:scriptengine","color":"803050"},{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/status:ready","name":"status:ready","color":"bfe5bf"},{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/type:enhancement","name":"type:enhancement","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-14T15:08:08Z","updated_at":"2015-12-20T15:03:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/950","html_url":"https://github.com/HerculesWS/Hercules/pull/950","diff_url":"https://github.com/HerculesWS/Hercules/pull/950.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/950.patch"},"body":"@MishimaHaruna , I just finished bake your favorite chocolate pie :smile:\r\nnow script commands that optionally look for player char_id/account_id/name,\r\nwill ShowWarning on map-server if the player is not found\r\n\r\nno longer promote bad scripting habit, like it ?\r\n\r\nwell the ingredient was actually taken from rathena script engine ...\r\nhttps://github.com/rathena/rathena/blob/master/src/map/script.c#L120"},"comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments/166125809","html_url":"https://github.com/HerculesWS/Hercules/pull/950#issuecomment-166125809","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/950","id":166125809,"user":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars.githubusercontent.com/u/4590397?v=3","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"created_at":"2015-12-20T15:03:13Z","updated_at":"2015-12-20T15:03:13Z","body":"`ispartneron` should be exempted from this, shouldn't it? (it's meant to check if the partner of the currently attached character is online, and shouldn't show a warning when it isn't). I'll edit that one out while merging."}}