{"action":"closed","number":249,"pull_request":{"url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249","id":54572324,"html_url":"https://github.com/JasonLautzenheiser/trizbort/pull/249","diff_url":"https://github.com/JasonLautzenheiser/trizbort/pull/249.diff","patch_url":"https://github.com/JasonLautzenheiser/trizbort/pull/249.patch","issue_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/249","number":249,"state":"closed","locked":false,"title":"#246 initialize author/title/etc to empty string","user":{"login":"andrewschultz","id":6201356,"avatar_url":"https://avatars.githubusercontent.com/u/6201356?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschultz","html_url":"https://github.com/andrewschultz","followers_url":"https://api.github.com/users/andrewschultz/followers","following_url":"https://api.github.com/users/andrewschultz/following{/other_user}","gists_url":"https://api.github.com/users/andrewschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschultz/subscriptions","organizations_url":"https://api.github.com/users/andrewschultz/orgs","repos_url":"https://api.github.com/users/andrewschultz/repos","events_url":"https://api.github.com/users/andrewschultz/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschultz/received_events","type":"User","site_admin":false},"body":"For some reason project.current.author gets assigned by default to null but dialog.author does not.\r\n\r\nThe solution is just to assign the metadata to \"\" and thus when trizbort compares, it's the empty string vs the empty string instead of null vs the empty string.\r\n\r\nI checked where these strings were used. They are used in export and we always check for isNullOrWhiteSpace (and we should, in case the user mistakenly leaves a space in there.)\r\n\r\nFor testing i checked saving documents with various fields blank. They looked the same before and after the change.","created_at":"2015-12-25T03:19:32Z","updated_at":"2015-12-26T14:25:58Z","closed_at":"2015-12-26T14:25:58Z","merged_at":"2015-12-26T14:25:58Z","merge_commit_sha":"0168c6ca448f99371a888f66c3aa43426aa76efd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249/commits","review_comments_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249/comments","review_comment_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/249/comments","statuses_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/statuses/a878194254e77ae9f51d4ff8e6a654af4eff053a","head":{"label":"andrewschultz:246-map-settings-false-isdirty","ref":"246-map-settings-false-isdirty","sha":"a878194254e77ae9f51d4ff8e6a654af4eff053a","user":{"login":"andrewschultz","id":6201356,"avatar_url":"https://avatars.githubusercontent.com/u/6201356?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschultz","html_url":"https://github.com/andrewschultz","followers_url":"https://api.github.com/users/andrewschultz/followers","following_url":"https://api.github.com/users/andrewschultz/following{/other_user}","gists_url":"https://api.github.com/users/andrewschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschultz/subscriptions","organizations_url":"https://api.github.com/users/andrewschultz/orgs","repos_url":"https://api.github.com/users/andrewschultz/repos","events_url":"https://api.github.com/users/andrewschultz/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschultz/received_events","type":"User","site_admin":false},"repo":{"id":33842913,"name":"trizbort","full_name":"andrewschultz/trizbort","owner":{"login":"andrewschultz","id":6201356,"avatar_url":"https://avatars.githubusercontent.com/u/6201356?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschultz","html_url":"https://github.com/andrewschultz","followers_url":"https://api.github.com/users/andrewschultz/followers","following_url":"https://api.github.com/users/andrewschultz/following{/other_user}","gists_url":"https://api.github.com/users/andrewschultz/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschultz/subscriptions","organizations_url":"https://api.github.com/users/andrewschultz/orgs","repos_url":"https://api.github.com/users/andrewschultz/repos","events_url":"https://api.github.com/users/andrewschultz/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschultz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewschultz/trizbort","description":"Trizbort, the Interactive Fiction Mapper","fork":true,"url":"https://api.github.com/repos/andrewschultz/trizbort","forks_url":"https://api.github.com/repos/andrewschultz/trizbort/forks","keys_url":"https://api.github.com/repos/andrewschultz/trizbort/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewschultz/trizbort/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewschultz/trizbort/teams","hooks_url":"https://api.github.com/repos/andrewschultz/trizbort/hooks","issue_events_url":"https://api.github.com/repos/andrewschultz/trizbort/issues/events{/number}","events_url":"https://api.github.com/repos/andrewschultz/trizbort/events","assignees_url":"https://api.github.com/repos/andrewschultz/trizbort/assignees{/user}","branches_url":"https://api.github.com/repos/andrewschultz/trizbort/branches{/branch}","tags_url":"https://api.github.com/repos/andrewschultz/trizbort/tags","blobs_url":"https://api.github.com/repos/andrewschultz/trizbort/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewschultz/trizbort/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewschultz/trizbort/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewschultz/trizbort/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewschultz/trizbort/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewschultz/trizbort/languages","stargazers_url":"https://api.github.com/repos/andrewschultz/trizbort/stargazers","contributors_url":"https://api.github.com/repos/andrewschultz/trizbort/contributors","subscribers_url":"https://api.github.com/repos/andrewschultz/trizbort/subscribers","subscription_url":"https://api.github.com/repos/andrewschultz/trizbort/subscription","commits_url":"https://api.github.com/repos/andrewschultz/trizbort/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewschultz/trizbort/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewschultz/trizbort/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewschultz/trizbort/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewschultz/trizbort/contents/{+path}","compare_url":"https://api.github.com/repos/andrewschultz/trizbort/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewschultz/trizbort/merges","archive_url":"https://api.github.com/repos/andrewschultz/trizbort/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewschultz/trizbort/downloads","issues_url":"https://api.github.com/repos/andrewschultz/trizbort/issues{/number}","pulls_url":"https://api.github.com/repos/andrewschultz/trizbort/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewschultz/trizbort/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewschultz/trizbort/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewschultz/trizbort/labels{/name}","releases_url":"https://api.github.com/repos/andrewschultz/trizbort/releases{/id}","created_at":"2015-04-13T02:08:47Z","updated_at":"2015-05-06T04:32:28Z","pushed_at":"2015-12-26T05:55:25Z","git_url":"git://github.com/andrewschultz/trizbort.git","ssh_url":"git@github.com:andrewschultz/trizbort.git","clone_url":"https://github.com/andrewschultz/trizbort.git","svn_url":"https://github.com/andrewschultz/trizbort","homepage":null,"size":5824,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JasonLautzenheiser:master","ref":"master","sha":"f0cc37a00972dd90c65f109e3517f15735bdefb6","user":{"login":"JasonLautzenheiser","id":1239981,"avatar_url":"https://avatars.githubusercontent.com/u/1239981?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLautzenheiser","html_url":"https://github.com/JasonLautzenheiser","followers_url":"https://api.github.com/users/JasonLautzenheiser/followers","following_url":"https://api.github.com/users/JasonLautzenheiser/following{/other_user}","gists_url":"https://api.github.com/users/JasonLautzenheiser/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLautzenheiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLautzenheiser/subscriptions","organizations_url":"https://api.github.com/users/JasonLautzenheiser/orgs","repos_url":"https://api.github.com/users/JasonLautzenheiser/repos","events_url":"https://api.github.com/users/JasonLautzenheiser/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLautzenheiser/received_events","type":"User","site_admin":false},"repo":{"id":28676407,"name":"trizbort","full_name":"JasonLautzenheiser/trizbort","owner":{"login":"JasonLautzenheiser","id":1239981,"avatar_url":"https://avatars.githubusercontent.com/u/1239981?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLautzenheiser","html_url":"https://github.com/JasonLautzenheiser","followers_url":"https://api.github.com/users/JasonLautzenheiser/followers","following_url":"https://api.github.com/users/JasonLautzenheiser/following{/other_user}","gists_url":"https://api.github.com/users/JasonLautzenheiser/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLautzenheiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLautzenheiser/subscriptions","organizations_url":"https://api.github.com/users/JasonLautzenheiser/orgs","repos_url":"https://api.github.com/users/JasonLautzenheiser/repos","events_url":"https://api.github.com/users/JasonLautzenheiser/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLautzenheiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JasonLautzenheiser/trizbort","description":"Trizbort, the Interactive Fiction Mapper","fork":true,"url":"https://api.github.com/repos/JasonLautzenheiser/trizbort","forks_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/forks","keys_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/teams","hooks_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/hooks","issue_events_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/events{/number}","events_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/events","assignees_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/assignees{/user}","branches_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/branches{/branch}","tags_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/tags","blobs_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/git/refs{/sha}","trees_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/statuses/{sha}","languages_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/languages","stargazers_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/stargazers","contributors_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/contributors","subscribers_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/subscribers","subscription_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/subscription","commits_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/commits{/sha}","git_commits_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/git/commits{/sha}","comments_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/comments{/number}","issue_comment_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/comments{/number}","contents_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/contents/{+path}","compare_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/merges","archive_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/downloads","issues_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues{/number}","pulls_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls{/number}","milestones_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/milestones{/number}","notifications_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/labels{/name}","releases_url":"https://api.github.com/repos/JasonLautzenheiser/trizbort/releases{/id}","created_at":"2014-12-31T22:28:24Z","updated_at":"2015-09-17T10:45:05Z","pushed_at":"2015-12-26T14:26:01Z","git_url":"git://github.com/JasonLautzenheiser/trizbort.git","ssh_url":"git@github.com:JasonLautzenheiser/trizbort.git","clone_url":"https://github.com/JasonLautzenheiser/trizbort.git","svn_url":"https://github.com/JasonLautzenheiser/trizbort","homepage":"http://www.trizbort.com","size":5823,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":77,"forks":5,"open_issues":77,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249"},"html":{"href":"https://github.com/JasonLautzenheiser/trizbort/pull/249"},"issue":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/249"},"comments":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/JasonLautzenheiser/trizbort/statuses/a878194254e77ae9f51d4ff8e6a654af4eff053a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JasonLautzenheiser","id":1239981,"avatar_url":"https://avatars.githubusercontent.com/u/1239981?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonLautzenheiser","html_url":"https://github.com/JasonLautzenheiser","followers_url":"https://api.github.com/users/JasonLautzenheiser/followers","following_url":"https://api.github.com/users/JasonLautzenheiser/following{/other_user}","gists_url":"https://api.github.com/users/JasonLautzenheiser/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonLautzenheiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonLautzenheiser/subscriptions","organizations_url":"https://api.github.com/users/JasonLautzenheiser/orgs","repos_url":"https://api.github.com/users/JasonLautzenheiser/repos","events_url":"https://api.github.com/users/JasonLautzenheiser/events{/privacy}","received_events_url":"https://api.github.com/users/JasonLautzenheiser/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}