{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/7877","labels_url":"https://api.github.com/repos/atom/atom/issues/7877/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/7877/comments","events_url":"https://api.github.com/repos/atom/atom/issues/7877/events","html_url":"https://github.com/atom/atom/pull/7877","id":94811941,"number":7877,"title":"Upgrade to Electron v0.30.1","user":{"login":"thomasjo","id":3622,"avatar_url":"https://avatars.githubusercontent.com/u/3622?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasjo","html_url":"https://github.com/thomasjo","followers_url":"https://api.github.com/users/thomasjo/followers","following_url":"https://api.github.com/users/thomasjo/following{/other_user}","gists_url":"https://api.github.com/users/thomasjo/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjo/subscriptions","organizations_url":"https://api.github.com/users/thomasjo/orgs","repos_url":"https://api.github.com/users/thomasjo/repos","events_url":"https://api.github.com/users/thomasjo/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/atom/labels/work-in-progress","name":"work-in-progress","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"thomasjo","id":3622,"avatar_url":"https://avatars.githubusercontent.com/u/3622?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasjo","html_url":"https://github.com/thomasjo","followers_url":"https://api.github.com/users/thomasjo/followers","following_url":"https://api.github.com/users/thomasjo/following{/other_user}","gists_url":"https://api.github.com/users/thomasjo/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjo/subscriptions","organizations_url":"https://api.github.com/users/thomasjo/orgs","repos_url":"https://api.github.com/users/thomasjo/repos","events_url":"https://api.github.com/users/thomasjo/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjo/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-07-13T21:07:26Z","updated_at":"2015-07-29T10:45:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/7877","html_url":"https://github.com/atom/atom/pull/7877","diff_url":"https://github.com/atom/atom/pull/7877.diff","patch_url":"https://github.com/atom/atom/pull/7877.patch"},"body":"This is a continuation of #6877. There are currently several major issues preventing this PR from being merged.\r\n\r\n## Blocking issues\r\n - [ ] Building with io.js v2.x is not supported.\r\n - [ ] Crash caused by invalid memory access during exit/closing window.\r\n - [x] 8 failing spec assertions.\r\n - [ ] In OS X closing all windows exits the application.\r\n - [ ] Building on Linux (Ubuntu 12.04.5 LTS) is failing due to compilation errors.\r\n\r\n### Issue details\r\n#### Building with io.js v2.x is not supported\r\nAny attempt to execute `script/build` when using io.js v2.x fails with\r\n```\r\nInstalling build modules...\r\ngyp ERR! configure error\r\ngyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v2.4.0/node-v2.4.0.tar.gz\r\ngyp ERR! stack     at Request.<anonymous> (/Users/thomasjo/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:251:14)\r\ngyp ERR! stack     at emitOne (events.js:82:20)\r\ngyp ERR! stack     at Request.emit (events.js:169:7)\r\ngyp ERR! stack     at Request.onRequestResponse (/Users/thomasjo/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/request/request.js:985:10)\r\ngyp ERR! stack     at emitOne (events.js:77:13)\r\ngyp ERR! stack     at ClientRequest.emit (events.js:169:7)\r\ngyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)\r\ngyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)\r\ngyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:305:20)\r\ngyp ERR! stack     at emitOne (events.js:77:13)\r\ngyp ERR! System Darwin 14.4.0\r\ngyp ERR! command \"/Users/thomasjo/.nvm/versions/io.js/v2.4.0/bin/iojs\" \"/Users/thomasjo/.nvm/versions/io.js/v2.4.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /Users/thomasjo/Code/atom/atom-electron/build/node_modules/runas\r\ngyp ERR! node -v v2.4.0\r\ngyp ERR! node-gyp -v v2.0.2\r\ngyp ERR! not ok\r\n```\r\n\r\n#### Crash caused by invalid memory access during exit/closing window\r\n[Full crash log](https://gist.github.com/thomasjo/8080e027a291c9402292).\r\nThe problem is a bit tricky to reproduce, but when it occurs it happens when a window is closed or when exiting Atom, which leads me to believe the problem is related to storing state. Seems like the crash is caused by a `nullptr` reference.\r\n\r\n#### 8 failing spec assertions\r\n[Full output](https://gist.github.com/thomasjo/541278db1f5ac7675a87) from `apm test`. Summary of failing specs;\r\n\r\n##### command-registry-spec.coffee\r\n - [x] `Expected undefined to be HTMLNode` at command-registry-spec.coffee:212:16.  \r\n  *Caused by https://code.google.com/p/chromium/issues/detail?id=495437.*\r\n\r\n##### package-manager-spec.coffee\r\nAll failures originate from `it triggers the activation event on all handlers registered during activation`.\r\n - [x] `Expected 0 to be 1`.\r\n - [x] `Expected 0 to be 1`.\r\n - [x] `Expected 0 to be 1`.\r\n - [x] `Expected 0 to be 2`.\r\n - [x] `Expected 0 to be 2`.\r\n - [x] `Expected 0 to be 1`.\r\n\r\n##### pane-container-view-spec.coffee\r\n - [x] `Expected [ undefined ] to equal [ { 0 : HTMLNode, element : <getter>, activeItemModifiedChanged : Function, ...` at pane-container-view-spec.coffee:60:21.\r\n\r\n#### In OS X closing all windows exits the application\r\nWhen running against atom-shell v0.22.3 Atom behaves as expected and leaves the application running even after all application windows have been closed. When running against Electron v0.30.0 however, after all windows have been closed the application exits.\r\n\r\n#### Building on Linux (Ubuntu 12.04.5 LTS) is failing due to compilation errors\r\nAttempts to build on Ubuntu 12.04.5 LTS (64-bit) fails while compiling npm modules, throwing errors similar to\r\n```\r\ngyp ERR! cwd /home/travis/build/atom/atom/node_modules/oniguruma\r\ngyp ERR! node -v v0.10.35\r\ngyp ERR! node-gyp -v v1.0.2\r\ngyp ERR! not ok \r\nIn file included from /home/travis/.atom/.node-gyp/.node-gyp/0.30.1/src/node.h:42:0,\r\n                 from ../node_modules/nan/nan.h:24,\r\n                 from ../src/repository.h:29,\r\n                 from ../src/repository.cc:22:\r\n/home/travis/.atom/.node-gyp/.node-gyp/0.30.1/deps/v8/include/v8.h:543:1: error: expected unqualified-id before ‘using’\r\n/home/travis/.atom/.node-gyp/.node-gyp/0.30.1/deps/v8/include/v8.h:922:1: error: expected unqualified-id before ‘using’\r\n```\r\n\r\nThe compilation failure is caused by the fact that GCC 4.7 or newer is required due to V8 using the *template alias* feature in C++, and that is not supported in GCC 4.6.3 which is the newest GCC (officially) available in Ubuntu 12.04.5 LTS.\r\n\r\n**Solution**: Compile with Clang 3.4 on Ubuntu 12.04.5 LTS;\r\n```\r\n$ sudo apt-get install clang-3.4\r\n$ CXX=clang++ script/build\r\n```\r\n\r\nFor Travis CI support, we should specify `compiler: clang` in `.travis.yml`. (http://docs.travis-ci.com/user/languages/c/#Choosing-compilers-to-test-against)\r\n\r\n## Other potential problems\r\n 1. Currently it does not seem like it's possible to use this build of Atom as a Git editor; closing the spawned window does not result in the process exiting as expected it seems like, and thus leaves the Git terminal process waiting for the input sequence to end.  \r\n  This is possibly related to issue *In OS X closing all windows exits the application*.\r\n\r\n---\r\nFixes https://github.com/atom/atom/issues/6335\r\nFixes https://github.com/atom/atom/issues/3826\r\nFixes https://github.com/atom/atom/issues/7502\r\nFixes https://github.com/atom/atom/issues/3636\r\nFixes https://github.com/atom/atom/issues/6243\r\nFixes https://github.com/atom/atom/issues/6306\r\nFixes https://github.com/atom/atom/issues/6219"},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/125917351","html_url":"https://github.com/atom/atom/pull/7877#issuecomment-125917351","issue_url":"https://api.github.com/repos/atom/atom/issues/7877","id":125917351,"user":{"login":"paulcbetts","id":1396,"avatar_url":"https://avatars.githubusercontent.com/u/1396?v=3","gravatar_id":"","url":"https://api.github.com/users/paulcbetts","html_url":"https://github.com/paulcbetts","followers_url":"https://api.github.com/users/paulcbetts/followers","following_url":"https://api.github.com/users/paulcbetts/following{/other_user}","gists_url":"https://api.github.com/users/paulcbetts/gists{/gist_id}","starred_url":"https://api.github.com/users/paulcbetts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulcbetts/subscriptions","organizations_url":"https://api.github.com/users/paulcbetts/orgs","repos_url":"https://api.github.com/users/paulcbetts/repos","events_url":"https://api.github.com/users/paulcbetts/events{/privacy}","received_events_url":"https://api.github.com/users/paulcbetts/received_events","type":"User","site_admin":false},"created_at":"2015-07-29T10:45:16Z","updated_at":"2015-07-29T10:45:16Z","body":"Getting close!! :clap::clap::clap::clap::clap::clap::clap:"}}