{"action":"created","issue":{"url":"https://api.github.com/repos/ncw/rclone/issues/151","labels_url":"https://api.github.com/repos/ncw/rclone/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/ncw/rclone/issues/151/comments","events_url":"https://api.github.com/repos/ncw/rclone/issues/151/events","html_url":"https://github.com/ncw/rclone/pull/151","id":107857760,"number":151,"title":"Large files support for swift was added","user":{"login":"Tolsi","id":1512650,"avatar_url":"https://avatars.githubusercontent.com/u/1512650?v=3","gravatar_id":"","url":"https://api.github.com/users/Tolsi","html_url":"https://github.com/Tolsi","followers_url":"https://api.github.com/users/Tolsi/followers","following_url":"https://api.github.com/users/Tolsi/following{/other_user}","gists_url":"https://api.github.com/users/Tolsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Tolsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tolsi/subscriptions","organizations_url":"https://api.github.com/users/Tolsi/orgs","repos_url":"https://api.github.com/users/Tolsi/repos","events_url":"https://api.github.com/users/Tolsi/events{/privacy}","received_events_url":"https://api.github.com/users/Tolsi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ncw/rclone/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-09-23T06:21:59Z","updated_at":"2015-09-25T08:30:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ncw/rclone/pulls/151","html_url":"https://github.com/ncw/rclone/pull/151","diff_url":"https://github.com/ncw/rclone/pull/151.diff","patch_url":"https://github.com/ncw/rclone/pull/151.patch"},"body":"This must close #46 \r\nIt's a quick fix and this is my first experience with Go, so I ask for code review.\r\n\r\nFor make it works with large files you must add to your rclone.conf ```segment-size = 5368709120``` and start rclone operations with param ```--size-only=true``, because md5 hash of manifest file isn't equals md5 of original file.\r\n\r\nAlso in sync copy mode rclone removes segments files, I don't know how to fix this logic in app architecture level. May be we need to add some config flag and handle it in operations.go:409 or operations.go:460."},"comment":{"url":"https://api.github.com/repos/ncw/rclone/issues/comments/143160127","html_url":"https://github.com/ncw/rclone/pull/151#issuecomment-143160127","issue_url":"https://api.github.com/repos/ncw/rclone/issues/151","id":143160127,"user":{"login":"ncw","id":536803,"avatar_url":"https://avatars.githubusercontent.com/u/536803?v=3","gravatar_id":"","url":"https://api.github.com/users/ncw","html_url":"https://github.com/ncw","followers_url":"https://api.github.com/users/ncw/followers","following_url":"https://api.github.com/users/ncw/following{/other_user}","gists_url":"https://api.github.com/users/ncw/gists{/gist_id}","starred_url":"https://api.github.com/users/ncw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncw/subscriptions","organizations_url":"https://api.github.com/users/ncw/orgs","repos_url":"https://api.github.com/users/ncw/repos","events_url":"https://api.github.com/users/ncw/events{/privacy}","received_events_url":"https://api.github.com/users/ncw/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T08:30:01Z","updated_at":"2015-09-25T08:30:01Z","body":"@Tolsi push to your branch Tolsi:stolmachev-swift-large-files and it will update this pull request\r\n\r\n> We don't create segments containers manually, it creates automatically on first write.\r\n\r\nPerfect\r\n\r\n> For now remove method don't removes segments files for now on call Remove() on manifest file, I should fix it tomorrow.\r\n\r\nOK\r\n\r\n> Should we handle Ctrl+C cancellation of upload process and remove already uploaded segments of big file?\r\n\r\nThere isn't a framework for doing that within rclone at the moment - just leave it as a FIXME in the code for the moment."}}