{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/comments/26003504","id":26003504,"diff_hunk":"@@ -108,60 +112,23 @@ def AutoinstClass\n       nil\n     end\n \n-    # Merge Classes\n+    # Merge classes\n     #\n     def MergeClasses(configuration, base_profile, resultFileName)\n-      configuration = deep_copy(configuration)\n       dontmerge_str = \"\"\n-      i = 1\n-      Builtins.foreach(AutoinstConfig.dontmerge) do |dm|\n-        dontmerge_str = Ops.add(\n-          dontmerge_str,\n-          Builtins.sformat(\" --param dontmerge%1 \\\"'%2'\\\" \", i, dm)\n-        )\n-        i = Ops.add(i, 1)\n+      AutoinstConfig.dontmerge.each_with_index do |dm, i|\n+        dontmerge_str << \" --param dontmerge#{i+1} \\\"'#{dm}'\\\" \"\n       end\n-      tmpdir = AutoinstConfig.tmpDir\n-      _MergeCommand = Builtins.sformat(\n-        \"/usr/bin/xsltproc --novalid --param replace \\\"'false'\\\" %1 --param with \",\n-        dontmerge_str\n-      )\n-\n-      _MergeCommand = Ops.add(\n-        Ops.add(\n-          Ops.add(_MergeCommand, \"\\\"'\"),\n-          findPath(\n-            Ops.get_string(configuration, \"name\", \"\"),\n-            Ops.get_string(configuration, \"class\", \"\")\n-          )\n-        ),\n-        \"'\\\"  \"\n-      )\n-      _MergeCommand = Ops.add(\n-        Ops.add(\n-          Ops.add(Ops.add(Ops.add(_MergeCommand, \"--output \"), tmpdir), \"/\"),\n-          resultFileName\n-        ),\n-        \" \"\n-      )\n-      _MergeCommand = Ops.add(\n-        _MergeCommand,\n-        \" /usr/share/autoinstall/xslt/merge.xslt \"\n-      )\n-      _MergeCommand = Ops.add(Ops.add(_MergeCommand, base_profile), \" \")\n+      merge_command =\n+        \"/usr/bin/xsltproc --novalid --param replace \\\"'false'\\\" #{dontmerge_str} --param with \" \\\n+        \"\\\"'#{findPath(configuration[\"name\"], configuration[\"class\"])}'\\\"  \" \\\n+        \"--output #{File.join(AutoinstConfig.tmpDir, resultFileName)}  \" \\\n+        \"#{@merge_xslt_path} #{base_profile} \"\n \n-\n-      Builtins.y2milestone(\"Merge command: %1\", _MergeCommand)\n-\n-      out = Convert.to_map(\n-        SCR.Execute(path(\".target.bash_output\"), _MergeCommand, {})\n-      )\n-      Builtins.y2milestone(\n-        \"Merge stdout: %1, stderr: %2\",\n-        Ops.get_string(out, \"stdout\", \"\"),\n-        Ops.get_string(out, \"stderr\", \"\")\n-      )\n-      deep_copy(out)\n+      log.info \"Merge command: #{merge_command}\"\n+      out = SCR.Execute(path(\".target.bash_output\"), merge_command, {})\n+      log.info \"Merge stdout: #{out[\"stdout\"]}, stderr: #{out[\"stderr\"]}\"","path":"src/modules/AutoinstClass.rb","position":null,"original_position":118,"commit_id":"23ea60af9ac63b8cd98e63caeb028df55b579d95","original_commit_id":"a3e5c48bc09b2b2661a9162ef04700d389734214","user":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2015-03-08T08:55:54Z","updated_at":"2015-03-08T08:55:54Z","html_url":"https://github.com/yast/yast-autoinstallation/pull/103#discussion_r26003504","pull_request_url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/comments/26003504"},"html":{"href":"https://github.com/yast/yast-autoinstallation/pull/103#discussion_r26003504"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103","id":30664666,"html_url":"https://github.com/yast/yast-autoinstallation/pull/103","diff_url":"https://github.com/yast/yast-autoinstallation/pull/103.diff","patch_url":"https://github.com/yast/yast-autoinstallation/pull/103.patch","issue_url":"https://api.github.com/repos/yast/yast-autoinstallation/issues/103","number":103,"state":"open","locked":false,"title":"Refactor the rest of AutoinstClass","user":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis PR is the second part of #101 so it refactors the rest of the AutoinstClass class.\r\n\r\nThanks.","created_at":"2015-03-06T17:47:13Z","updated_at":"2015-03-08T08:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"216cb8736c3c5f1b799eff3b3964a84b561d57be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103/commits","review_comments_url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103/comments","review_comment_url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-autoinstallation/issues/103/comments","statuses_url":"https://api.github.com/repos/yast/yast-autoinstallation/statuses/23ea60af9ac63b8cd98e63caeb028df55b579d95","head":{"label":"imobach:refactor-remaining-autoinstclass","ref":"refactor-remaining-autoinstclass","sha":"23ea60af9ac63b8cd98e63caeb028df55b579d95","user":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"repo":{"id":30859129,"name":"yast-autoinstallation","full_name":"imobach/yast-autoinstallation","owner":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imobach/yast-autoinstallation","description":"YaST module autoinstallation","fork":true,"url":"https://api.github.com/repos/imobach/yast-autoinstallation","forks_url":"https://api.github.com/repos/imobach/yast-autoinstallation/forks","keys_url":"https://api.github.com/repos/imobach/yast-autoinstallation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imobach/yast-autoinstallation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imobach/yast-autoinstallation/teams","hooks_url":"https://api.github.com/repos/imobach/yast-autoinstallation/hooks","issue_events_url":"https://api.github.com/repos/imobach/yast-autoinstallation/issues/events{/number}","events_url":"https://api.github.com/repos/imobach/yast-autoinstallation/events","assignees_url":"https://api.github.com/repos/imobach/yast-autoinstallation/assignees{/user}","branches_url":"https://api.github.com/repos/imobach/yast-autoinstallation/branches{/branch}","tags_url":"https://api.github.com/repos/imobach/yast-autoinstallation/tags","blobs_url":"https://api.github.com/repos/imobach/yast-autoinstallation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imobach/yast-autoinstallation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imobach/yast-autoinstallation/git/refs{/sha}","trees_url":"https://api.github.com/repos/imobach/yast-autoinstallation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imobach/yast-autoinstallation/statuses/{sha}","languages_url":"https://api.github.com/repos/imobach/yast-autoinstallation/languages","stargazers_url":"https://api.github.com/repos/imobach/yast-autoinstallation/stargazers","contributors_url":"https://api.github.com/repos/imobach/yast-autoinstallation/contributors","subscribers_url":"https://api.github.com/repos/imobach/yast-autoinstallation/subscribers","subscription_url":"https://api.github.com/repos/imobach/yast-autoinstallation/subscription","commits_url":"https://api.github.com/repos/imobach/yast-autoinstallation/commits{/sha}","git_commits_url":"https://api.github.com/repos/imobach/yast-autoinstallation/git/commits{/sha}","comments_url":"https://api.github.com/repos/imobach/yast-autoinstallation/comments{/number}","issue_comment_url":"https://api.github.com/repos/imobach/yast-autoinstallation/issues/comments{/number}","contents_url":"https://api.github.com/repos/imobach/yast-autoinstallation/contents/{+path}","compare_url":"https://api.github.com/repos/imobach/yast-autoinstallation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imobach/yast-autoinstallation/merges","archive_url":"https://api.github.com/repos/imobach/yast-autoinstallation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imobach/yast-autoinstallation/downloads","issues_url":"https://api.github.com/repos/imobach/yast-autoinstallation/issues{/number}","pulls_url":"https://api.github.com/repos/imobach/yast-autoinstallation/pulls{/number}","milestones_url":"https://api.github.com/repos/imobach/yast-autoinstallation/milestones{/number}","notifications_url":"https://api.github.com/repos/imobach/yast-autoinstallation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imobach/yast-autoinstallation/labels{/name}","releases_url":"https://api.github.com/repos/imobach/yast-autoinstallation/releases{/id}","created_at":"2015-02-16T08:07:03Z","updated_at":"2015-03-01T09:30:58Z","pushed_at":"2015-03-08T08:55:28Z","git_url":"git://github.com/imobach/yast-autoinstallation.git","ssh_url":"git@github.com:imobach/yast-autoinstallation.git","clone_url":"https://github.com/imobach/yast-autoinstallation.git","svn_url":"https://github.com/imobach/yast-autoinstallation","homepage":"http://en.opensuse.org/Portal:YaST","size":23676,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"338a6a4a32bcaa8d1bf7ff6891ead775386ca397","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368072,"name":"yast-autoinstallation","full_name":"yast/yast-autoinstallation","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-autoinstallation","description":"YaST module autoinstallation","fork":false,"url":"https://api.github.com/repos/yast/yast-autoinstallation","forks_url":"https://api.github.com/repos/yast/yast-autoinstallation/forks","keys_url":"https://api.github.com/repos/yast/yast-autoinstallation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-autoinstallation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-autoinstallation/teams","hooks_url":"https://api.github.com/repos/yast/yast-autoinstallation/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-autoinstallation/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-autoinstallation/events","assignees_url":"https://api.github.com/repos/yast/yast-autoinstallation/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-autoinstallation/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-autoinstallation/tags","blobs_url":"https://api.github.com/repos/yast/yast-autoinstallation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-autoinstallation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-autoinstallation/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-autoinstallation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-autoinstallation/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-autoinstallation/languages","stargazers_url":"https://api.github.com/repos/yast/yast-autoinstallation/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-autoinstallation/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-autoinstallation/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-autoinstallation/subscription","commits_url":"https://api.github.com/repos/yast/yast-autoinstallation/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-autoinstallation/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-autoinstallation/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-autoinstallation/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-autoinstallation/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-autoinstallation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-autoinstallation/merges","archive_url":"https://api.github.com/repos/yast/yast-autoinstallation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-autoinstallation/downloads","issues_url":"https://api.github.com/repos/yast/yast-autoinstallation/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-autoinstallation/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-autoinstallation/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-autoinstallation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-autoinstallation/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-autoinstallation/releases{/id}","created_at":"2012-05-18T10:22:35Z","updated_at":"2015-02-18T13:30:16Z","pushed_at":"2015-02-18T13:30:15Z","git_url":"git://github.com/yast/yast-autoinstallation.git","ssh_url":"git@github.com:yast/yast-autoinstallation.git","clone_url":"https://github.com/yast/yast-autoinstallation.git","svn_url":"https://github.com/yast/yast-autoinstallation","homepage":"http://en.opensuse.org/Portal:YaST","size":25263,"stargazers_count":3,"watchers_count":3,"language":"XML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103"},"html":{"href":"https://github.com/yast/yast-autoinstallation/pull/103"},"issue":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/issues/103"},"comments":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-autoinstallation/statuses/23ea60af9ac63b8cd98e63caeb028df55b579d95"}}}}