{"action":"created","comment":{"url":"https://api.github.com/repos/uos/calvin_robot/pulls/comments/24985628","id":24985628,"diff_hunk":"@@ -4,7 +4,8 @@\n     <remap from=\"scan\" to=\"lms200\" />\n     <param name=\"port\" value=\"/dev/scanner\" />\n     <param name=\"baud\" value=\"500000\" />\n-    <param name=\"resolution\" value=\"1.0\" />\n+    <param name=\"angle\" value=\"180\" />\n+    <param name=\"resolution\" value=\"0.5\" />","path":"calvin_bringup/launch/sick_lms200.launch","position":null,"original_position":6,"commit_id":"ebb82d8d39b802a9e3256d10508902dee64ac502","original_commit_id":"4460f7befb41c4ba6126a13b5acc9f92f95a84eb","user":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"body":"On Wed, Feb 18, 2015 at 02:33:19PM -0800, Jochen Sprickerhof wrote:\n> I'm against the 0.5 degree option, as it's done by combining two scans.\n\nI removed the 0.5 resolution option and we'll fix this by adjusting the scanner firmware.\n","created_at":"2015-02-19T13:06:22Z","updated_at":"2015-02-19T13:06:22Z","html_url":"https://github.com/uos/calvin_robot/pull/9#discussion_r24985628","pull_request_url":"https://api.github.com/repos/uos/calvin_robot/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/comments/24985628"},"html":{"href":"https://github.com/uos/calvin_robot/pull/9#discussion_r24985628"},"pull_request":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/uos/calvin_robot/pulls/9","id":29269561,"html_url":"https://github.com/uos/calvin_robot/pull/9","diff_url":"https://github.com/uos/calvin_robot/pull/9.diff","patch_url":"https://github.com/uos/calvin_robot/pull/9.patch","issue_url":"https://api.github.com/repos/uos/calvin_robot/issues/9","number":9,"state":"open","locked":false,"title":"fix sick_lms200 parameters","user":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"body":"The driver produces warnings about an unusable angle value (default 0) and an\nunusable resolution value. It seems the driver always used .5 after it failed\nto set the specified value of 1 (maybe only starting with hydro/indigo?)","created_at":"2015-02-13T14:48:50Z","updated_at":"2015-02-19T13:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc739282eda1df089bdf8ad86207a694ec646b53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uos/calvin_robot/pulls/9/commits","review_comments_url":"https://api.github.com/repos/uos/calvin_robot/pulls/9/comments","review_comment_url":"https://api.github.com/repos/uos/calvin_robot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uos/calvin_robot/issues/9/comments","statuses_url":"https://api.github.com/repos/uos/calvin_robot/statuses/ebb82d8d39b802a9e3256d10508902dee64ac502","head":{"label":"v4hn:indigo-sick-params","ref":"indigo-sick-params","sha":"ebb82d8d39b802a9e3256d10508902dee64ac502","user":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"repo":{"id":23657018,"name":"calvin_robot","full_name":"v4hn/calvin_robot","owner":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/v4hn/calvin_robot","description":"","fork":true,"url":"https://api.github.com/repos/v4hn/calvin_robot","forks_url":"https://api.github.com/repos/v4hn/calvin_robot/forks","keys_url":"https://api.github.com/repos/v4hn/calvin_robot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v4hn/calvin_robot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v4hn/calvin_robot/teams","hooks_url":"https://api.github.com/repos/v4hn/calvin_robot/hooks","issue_events_url":"https://api.github.com/repos/v4hn/calvin_robot/issues/events{/number}","events_url":"https://api.github.com/repos/v4hn/calvin_robot/events","assignees_url":"https://api.github.com/repos/v4hn/calvin_robot/assignees{/user}","branches_url":"https://api.github.com/repos/v4hn/calvin_robot/branches{/branch}","tags_url":"https://api.github.com/repos/v4hn/calvin_robot/tags","blobs_url":"https://api.github.com/repos/v4hn/calvin_robot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v4hn/calvin_robot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v4hn/calvin_robot/git/refs{/sha}","trees_url":"https://api.github.com/repos/v4hn/calvin_robot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v4hn/calvin_robot/statuses/{sha}","languages_url":"https://api.github.com/repos/v4hn/calvin_robot/languages","stargazers_url":"https://api.github.com/repos/v4hn/calvin_robot/stargazers","contributors_url":"https://api.github.com/repos/v4hn/calvin_robot/contributors","subscribers_url":"https://api.github.com/repos/v4hn/calvin_robot/subscribers","subscription_url":"https://api.github.com/repos/v4hn/calvin_robot/subscription","commits_url":"https://api.github.com/repos/v4hn/calvin_robot/commits{/sha}","git_commits_url":"https://api.github.com/repos/v4hn/calvin_robot/git/commits{/sha}","comments_url":"https://api.github.com/repos/v4hn/calvin_robot/comments{/number}","issue_comment_url":"https://api.github.com/repos/v4hn/calvin_robot/issues/comments/{number}","contents_url":"https://api.github.com/repos/v4hn/calvin_robot/contents/{+path}","compare_url":"https://api.github.com/repos/v4hn/calvin_robot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v4hn/calvin_robot/merges","archive_url":"https://api.github.com/repos/v4hn/calvin_robot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v4hn/calvin_robot/downloads","issues_url":"https://api.github.com/repos/v4hn/calvin_robot/issues{/number}","pulls_url":"https://api.github.com/repos/v4hn/calvin_robot/pulls{/number}","milestones_url":"https://api.github.com/repos/v4hn/calvin_robot/milestones{/number}","notifications_url":"https://api.github.com/repos/v4hn/calvin_robot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v4hn/calvin_robot/labels{/name}","releases_url":"https://api.github.com/repos/v4hn/calvin_robot/releases{/id}","created_at":"2014-09-04T09:50:05Z","updated_at":"2014-07-16T02:06:34Z","pushed_at":"2015-02-19T13:03:16Z","git_url":"git://github.com/v4hn/calvin_robot.git","ssh_url":"git@github.com:v4hn/calvin_robot.git","clone_url":"https://github.com/v4hn/calvin_robot.git","svn_url":"https://github.com/v4hn/calvin_robot","homepage":null,"size":635,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hydro"}},"base":{"label":"uos:indigo","ref":"indigo","sha":"55b36a93877ba2221337e2fe420798630aec4769","user":{"login":"uos","id":2770980,"avatar_url":"https://avatars.githubusercontent.com/u/2770980?v=3","gravatar_id":"","url":"https://api.github.com/users/uos","html_url":"https://github.com/uos","followers_url":"https://api.github.com/users/uos/followers","following_url":"https://api.github.com/users/uos/following{/other_user}","gists_url":"https://api.github.com/users/uos/gists{/gist_id}","starred_url":"https://api.github.com/users/uos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uos/subscriptions","organizations_url":"https://api.github.com/users/uos/orgs","repos_url":"https://api.github.com/users/uos/repos","events_url":"https://api.github.com/users/uos/events{/privacy}","received_events_url":"https://api.github.com/users/uos/received_events","type":"Organization","site_admin":false},"repo":{"id":15281349,"name":"calvin_robot","full_name":"uos/calvin_robot","owner":{"login":"uos","id":2770980,"avatar_url":"https://avatars.githubusercontent.com/u/2770980?v=3","gravatar_id":"","url":"https://api.github.com/users/uos","html_url":"https://github.com/uos","followers_url":"https://api.github.com/users/uos/followers","following_url":"https://api.github.com/users/uos/following{/other_user}","gists_url":"https://api.github.com/users/uos/gists{/gist_id}","starred_url":"https://api.github.com/users/uos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uos/subscriptions","organizations_url":"https://api.github.com/users/uos/orgs","repos_url":"https://api.github.com/users/uos/repos","events_url":"https://api.github.com/users/uos/events{/privacy}","received_events_url":"https://api.github.com/users/uos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uos/calvin_robot","description":"","fork":false,"url":"https://api.github.com/repos/uos/calvin_robot","forks_url":"https://api.github.com/repos/uos/calvin_robot/forks","keys_url":"https://api.github.com/repos/uos/calvin_robot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uos/calvin_robot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uos/calvin_robot/teams","hooks_url":"https://api.github.com/repos/uos/calvin_robot/hooks","issue_events_url":"https://api.github.com/repos/uos/calvin_robot/issues/events{/number}","events_url":"https://api.github.com/repos/uos/calvin_robot/events","assignees_url":"https://api.github.com/repos/uos/calvin_robot/assignees{/user}","branches_url":"https://api.github.com/repos/uos/calvin_robot/branches{/branch}","tags_url":"https://api.github.com/repos/uos/calvin_robot/tags","blobs_url":"https://api.github.com/repos/uos/calvin_robot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uos/calvin_robot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uos/calvin_robot/git/refs{/sha}","trees_url":"https://api.github.com/repos/uos/calvin_robot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uos/calvin_robot/statuses/{sha}","languages_url":"https://api.github.com/repos/uos/calvin_robot/languages","stargazers_url":"https://api.github.com/repos/uos/calvin_robot/stargazers","contributors_url":"https://api.github.com/repos/uos/calvin_robot/contributors","subscribers_url":"https://api.github.com/repos/uos/calvin_robot/subscribers","subscription_url":"https://api.github.com/repos/uos/calvin_robot/subscription","commits_url":"https://api.github.com/repos/uos/calvin_robot/commits{/sha}","git_commits_url":"https://api.github.com/repos/uos/calvin_robot/git/commits{/sha}","comments_url":"https://api.github.com/repos/uos/calvin_robot/comments{/number}","issue_comment_url":"https://api.github.com/repos/uos/calvin_robot/issues/comments/{number}","contents_url":"https://api.github.com/repos/uos/calvin_robot/contents/{+path}","compare_url":"https://api.github.com/repos/uos/calvin_robot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uos/calvin_robot/merges","archive_url":"https://api.github.com/repos/uos/calvin_robot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uos/calvin_robot/downloads","issues_url":"https://api.github.com/repos/uos/calvin_robot/issues{/number}","pulls_url":"https://api.github.com/repos/uos/calvin_robot/pulls{/number}","milestones_url":"https://api.github.com/repos/uos/calvin_robot/milestones{/number}","notifications_url":"https://api.github.com/repos/uos/calvin_robot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uos/calvin_robot/labels{/name}","releases_url":"https://api.github.com/repos/uos/calvin_robot/releases{/id}","created_at":"2013-12-18T11:27:05Z","updated_at":"2015-02-03T15:48:15Z","pushed_at":"2015-02-18T22:33:38Z","git_url":"git://github.com/uos/calvin_robot.git","ssh_url":"git@github.com:uos/calvin_robot.git","clone_url":"https://github.com/uos/calvin_robot.git","svn_url":"https://github.com/uos/calvin_robot","homepage":null,"size":869,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"hydro"}},"_links":{"self":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/9"},"html":{"href":"https://github.com/uos/calvin_robot/pull/9"},"issue":{"href":"https://api.github.com/repos/uos/calvin_robot/issues/9"},"comments":{"href":"https://api.github.com/repos/uos/calvin_robot/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uos/calvin_robot/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/uos/calvin_robot/statuses/ebb82d8d39b802a9e3256d10508902dee64ac502"}}}}