{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30469548","id":30469548,"diff_hunk":"@@ -83,7 +83,8 @@ public ProposerState handle( ProposerContext context,\n                                     + \" rejected from \" + message.getHeader( Message.FROM ) + \" with ballot \"\n                                     + rejectPropose.getBallot() );\n \n-                            if ( instance.isState( PaxosInstance.State.p1_pending ) )\n+                            if ( instance.isState( PaxosInstance.State.p1_pending ) &&","path":"enterprise/cluster/src/main/java/org/neo4j/cluster/protocol/atomicbroadcast/multipaxos/ProposerState.java","position":5,"original_position":5,"commit_id":"10b8b020507697b677205030cc24a1973b63c951","original_commit_id":"10b8b020507697b677205030cc24a1973b63c951","user":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"body":"This if statement is quite opaque - some documentation would be nice","created_at":"2015-05-17T11:14:25Z","updated_at":"2015-05-17T11:14:25Z","html_url":"https://github.com/neo4j/neo4j/pull/4537#discussion_r30469548","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4537","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30469548"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4537#discussion_r30469548"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4537"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4537","id":34229936,"html_url":"https://github.com/neo4j/neo4j/pull/4537","diff_url":"https://github.com/neo4j/neo4j/pull/4537.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4537.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4537","number":4537,"state":"open","locked":false,"title":"Improve cluster failure testing","user":{"login":"rickardoberg","id":461300,"avatar_url":"https://avatars.githubusercontent.com/u/461300?v=3","gravatar_id":"","url":"https://api.github.com/users/rickardoberg","html_url":"https://github.com/rickardoberg","followers_url":"https://api.github.com/users/rickardoberg/followers","following_url":"https://api.github.com/users/rickardoberg/following{/other_user}","gists_url":"https://api.github.com/users/rickardoberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rickardoberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickardoberg/subscriptions","organizations_url":"https://api.github.com/users/rickardoberg/orgs","repos_url":"https://api.github.com/users/rickardoberg/repos","events_url":"https://api.github.com/users/rickardoberg/events{/privacy}","received_events_url":"https://api.github.com/users/rickardoberg/received_events","type":"User","site_admin":false},"body":"NetworkSender/NetworkReceiver now uses pausing instead of start/stop for fail testing.\r\nRefactored ClusterClient into factory+facade\r\nAlways use \"127.0.0.1\" for localhost in cluster testing, to avoid the 127.0.1.1 issue.\r\nPlus other minor code cleanups.\r\n","created_at":"2015-04-28T03:00:21Z","updated_at":"2015-05-17T11:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca6b8a6adfa2f36c64d968fef1414f9c0f6e92d","assignee":{"login":"digitalstain","id":408167,"avatar_url":"https://avatars.githubusercontent.com/u/408167?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalstain","html_url":"https://github.com/digitalstain","followers_url":"https://api.github.com/users/digitalstain/followers","following_url":"https://api.github.com/users/digitalstain/following{/other_user}","gists_url":"https://api.github.com/users/digitalstain/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalstain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalstain/subscriptions","organizations_url":"https://api.github.com/users/digitalstain/orgs","repos_url":"https://api.github.com/users/digitalstain/repos","events_url":"https://api.github.com/users/digitalstain/events{/privacy}","received_events_url":"https://api.github.com/users/digitalstain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4537/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4537/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4537/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/10b8b020507697b677205030cc24a1973b63c951","head":{"label":"rickardoberg:betterclusterfail","ref":"betterclusterfail","sha":"10b8b020507697b677205030cc24a1973b63c951","user":{"login":"rickardoberg","id":461300,"avatar_url":"https://avatars.githubusercontent.com/u/461300?v=3","gravatar_id":"","url":"https://api.github.com/users/rickardoberg","html_url":"https://github.com/rickardoberg","followers_url":"https://api.github.com/users/rickardoberg/followers","following_url":"https://api.github.com/users/rickardoberg/following{/other_user}","gists_url":"https://api.github.com/users/rickardoberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rickardoberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickardoberg/subscriptions","organizations_url":"https://api.github.com/users/rickardoberg/orgs","repos_url":"https://api.github.com/users/rickardoberg/repos","events_url":"https://api.github.com/users/rickardoberg/events{/privacy}","received_events_url":"https://api.github.com/users/rickardoberg/received_events","type":"User","site_admin":false},"repo":{"id":6666802,"name":"neo4j","full_name":"rickardoberg/neo4j","owner":{"login":"rickardoberg","id":461300,"avatar_url":"https://avatars.githubusercontent.com/u/461300?v=3","gravatar_id":"","url":"https://api.github.com/users/rickardoberg","html_url":"https://github.com/rickardoberg","followers_url":"https://api.github.com/users/rickardoberg/followers","following_url":"https://api.github.com/users/rickardoberg/following{/other_user}","gists_url":"https://api.github.com/users/rickardoberg/gists{/gist_id}","starred_url":"https://api.github.com/users/rickardoberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickardoberg/subscriptions","organizations_url":"https://api.github.com/users/rickardoberg/orgs","repos_url":"https://api.github.com/users/rickardoberg/repos","events_url":"https://api.github.com/users/rickardoberg/events{/privacy}","received_events_url":"https://api.github.com/users/rickardoberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rickardoberg/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/rickardoberg/neo4j","forks_url":"https://api.github.com/repos/rickardoberg/neo4j/forks","keys_url":"https://api.github.com/repos/rickardoberg/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rickardoberg/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rickardoberg/neo4j/teams","hooks_url":"https://api.github.com/repos/rickardoberg/neo4j/hooks","issue_events_url":"https://api.github.com/repos/rickardoberg/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/rickardoberg/neo4j/events","assignees_url":"https://api.github.com/repos/rickardoberg/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/rickardoberg/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/rickardoberg/neo4j/tags","blobs_url":"https://api.github.com/repos/rickardoberg/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rickardoberg/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rickardoberg/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/rickardoberg/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rickardoberg/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/rickardoberg/neo4j/languages","stargazers_url":"https://api.github.com/repos/rickardoberg/neo4j/stargazers","contributors_url":"https://api.github.com/repos/rickardoberg/neo4j/contributors","subscribers_url":"https://api.github.com/repos/rickardoberg/neo4j/subscribers","subscription_url":"https://api.github.com/repos/rickardoberg/neo4j/subscription","commits_url":"https://api.github.com/repos/rickardoberg/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/rickardoberg/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/rickardoberg/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/rickardoberg/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/rickardoberg/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/rickardoberg/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rickardoberg/neo4j/merges","archive_url":"https://api.github.com/repos/rickardoberg/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rickardoberg/neo4j/downloads","issues_url":"https://api.github.com/repos/rickardoberg/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/rickardoberg/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/rickardoberg/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/rickardoberg/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rickardoberg/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/rickardoberg/neo4j/releases{/id}","created_at":"2012-11-13T07:06:50Z","updated_at":"2014-08-26T07:45:07Z","pushed_at":"2015-05-12T11:05:00Z","git_url":"git://github.com/rickardoberg/neo4j.git","ssh_url":"git@github.com:rickardoberg/neo4j.git","clone_url":"https://github.com/rickardoberg/neo4j.git","svn_url":"https://github.com/rickardoberg/neo4j","homepage":null,"size":191246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"aa5367d556f98b115341ef2a367fd63157779130","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-05-17T07:35:16Z","pushed_at":"2015-05-17T08:18:37Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":466177,"stargazers_count":1672,"watchers_count":1672,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":677,"mirror_url":null,"open_issues_count":437,"forks":677,"open_issues":437,"watchers":1672,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4537"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4537"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4537"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4537/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4537/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4537/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/10b8b020507697b677205030cc24a1973b63c951"}}}}