{"push_id":634941618,"size":1,"distinct_size":1,"ref":"refs/heads/zfsdev_getminor","head":"cdb2aa67ca050779a82241b37850e89baab741bb","before":"331a160953c08c779c208beb3bd7ed4eb8f96509","commits":[{"sha":"cdb2aa67ca050779a82241b37850e89baab741bb","author":{"email":"0e6295540f566aad05a0dc0d8facf057c9f8e443@clusterhq.com","name":"Richard Yao"},"message":"zfsdev_getminor() should check for invalid file handles\n\nUnit testing at ClusterHQ found that passing an invalid file handle to\nzfs_ioc_hold results in a NULL pointer dereference on a system without\nassertions:\n\nIP: [<ffffffffa0218aa0>] zfsdev_getminor+0x10/0x20 [zfs]\nCall Trace:\n[<ffffffffa021b4b0>] zfs_onexit_fd_hold+0x20/0x40 [zfs]\n[<ffffffffa0214043>] zfs_ioc_hold+0x93/0xd0 [zfs]\n[<ffffffffa0215890>] zfsdev_ioctl+0x200/0x500 [zfs]\n\nAn assertion would have caught this had they been enabled, but this is\nsomething that the kernel module should handle without failing.  We\nresolve this by searching the linked list to ensure that the file\nhandle's private_data points to a valid zfsdev_state_t.\n\nSigned-off-by: Richard Yao <ryao@gentoo.org>\nSigned-off-by: Andriy Gapon <avg@FreeBSD.org>","distinct":true,"url":"https://api.github.com/repos/ryao/zfs/commits/cdb2aa67ca050779a82241b37850e89baab741bb"}]}