{"action":"created","issue":{"url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/68","labels_url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/68/comments","events_url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/68/events","html_url":"https://github.com/balderdashy/waterline-adapter-tests/pull/68","id":74227006,"number":68,"title":"Added a semantic/create test for auto inc attributes.","user":{"login":"marnusw","id":971499,"avatar_url":"https://avatars.githubusercontent.com/u/971499?v=3","gravatar_id":"","url":"https://api.github.com/users/marnusw","html_url":"https://github.com/marnusw","followers_url":"https://api.github.com/users/marnusw/followers","following_url":"https://api.github.com/users/marnusw/following{/other_user}","gists_url":"https://api.github.com/users/marnusw/gists{/gist_id}","starred_url":"https://api.github.com/users/marnusw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marnusw/subscriptions","organizations_url":"https://api.github.com/users/marnusw/orgs","repos_url":"https://api.github.com/users/marnusw/repos","events_url":"https://api.github.com/users/marnusw/events{/privacy}","received_events_url":"https://api.github.com/users/marnusw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-08T04:34:10Z","updated_at":"2015-05-08T12:50:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/pulls/68","html_url":"https://github.com/balderdashy/waterline-adapter-tests/pull/68","diff_url":"https://github.com/balderdashy/waterline-adapter-tests/pull/68.diff","patch_url":"https://github.com/balderdashy/waterline-adapter-tests/pull/68.patch"},"body":"This is a test for the auto-inc feature of attributes as suggested by @particlebanana [here](https://github.com/balderdashy/sails-memory/pull/20#issuecomment-99590001). When a record is inserted with a value specified and it is larger than the current auto-inc counter the counter should fast-forward to match the inserted value. This happens internally in real databases, but was not working in `sails-memory`.\r\n\r\nAt the moment this test fails the Travis build due to the bug in `sails-memory`, but it will pass once balderdashy/sails-memory#20 is merged."},"comment":{"url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/comments/100223102","html_url":"https://github.com/balderdashy/waterline-adapter-tests/pull/68#issuecomment-100223102","issue_url":"https://api.github.com/repos/balderdashy/waterline-adapter-tests/issues/68","id":100223102,"user":{"login":"marnusw","id":971499,"avatar_url":"https://avatars.githubusercontent.com/u/971499?v=3","gravatar_id":"","url":"https://api.github.com/users/marnusw","html_url":"https://github.com/marnusw","followers_url":"https://api.github.com/users/marnusw/followers","following_url":"https://api.github.com/users/marnusw/following{/other_user}","gists_url":"https://api.github.com/users/marnusw/gists{/gist_id}","starred_url":"https://api.github.com/users/marnusw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marnusw/subscriptions","organizations_url":"https://api.github.com/users/marnusw/orgs","repos_url":"https://api.github.com/users/marnusw/repos","events_url":"https://api.github.com/users/marnusw/events{/privacy}","received_events_url":"https://api.github.com/users/marnusw/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T12:50:20Z","updated_at":"2015-05-08T12:50:20Z","body":"@devinivy but even if the auto-increment function is implemented in the adapter level rather than the underlying persistence mechanism wouldn't it still make sense to expect the operation as tested here? It seems like the `autoIncrement` attribute property should specify one and only one type of behavior.\r\n\r\nThat said, PR #64 suggests specifying a list of \"features\" in the `package.json` of an adapter to indicate which specialized attribute properties it supports which should thus be tested. Adapters that don't support a feature (for example MongoDb in the case of auto inc) would then not specify `autoIncrement` skip the relevant test entirely.\r\n\r\n"}}