{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/46027293","id":46027293,"diff_hunk":"@@ -10,11 +11,21 @@ namespace NServiceBus.Routing\n     /// </summary>\n     public class UnicastRoutingTable\n     {\n-        List<Func<Type, ContextBag, IEnumerable<IUnicastRoute>>> rules = new List<Func<Type, ContextBag, IEnumerable<IUnicastRoute>>>();\n+        List<Func<Type, ContextBag, IUnicastRoute>> staticRules = new List<Func<Type, ContextBag, IUnicastRoute>>();\n+        List<Func<Type, ContextBag, Task<List<IUnicastRoute>>>> dynamicRules = new List<Func<Type, ContextBag, Task<List<IUnicastRoute>>>>();\n \n-        internal IEnumerable<IUnicastRoute> GetDestinationsFor(Type messageType, ContextBag contextBag)\n+        internal async Task<IEnumerable<IUnicastRoute>> GetDestinationsFor(Type messageType, ContextBag contextBag)\n         {\n-            return rules.SelectMany(r => r(messageType, contextBag)).Distinct();\n+            var dynamicRoutes = new List<IUnicastRoute>();\n+            foreach (var rule in dynamicRules)\n+            {\n+                dynamicRoutes.AddRange(await rule.Invoke(messageType, contextBag).ConfigureAwait(false));","path":"src/NServiceBus.Core/Routing/UnicastRoutingTable.cs","position":23,"original_position":23,"commit_id":"7d21113b2abf60b750d00d7f7de650b32a793582","original_commit_id":"7d21113b2abf60b750d00d7f7de650b32a793582","user":{"login":"janovesk","id":396480,"avatar_url":"https://avatars.githubusercontent.com/u/396480?v=3","gravatar_id":"","url":"https://api.github.com/users/janovesk","html_url":"https://github.com/janovesk","followers_url":"https://api.github.com/users/janovesk/followers","following_url":"https://api.github.com/users/janovesk/following{/other_user}","gists_url":"https://api.github.com/users/janovesk/gists{/gist_id}","starred_url":"https://api.github.com/users/janovesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janovesk/subscriptions","organizations_url":"https://api.github.com/users/janovesk/orgs","repos_url":"https://api.github.com/users/janovesk/repos","events_url":"https://api.github.com/users/janovesk/events{/privacy}","received_events_url":"https://api.github.com/users/janovesk/received_events","type":"User","site_admin":false},"body":"Don't think so. Can't see how we can avoid avoid calling each of them seperately as UnicastRoutingTable is not the owner of the different rules internals. Each rule might be doing separate IO.. or not.","created_at":"2015-11-27T08:55:59Z","updated_at":"2015-11-27T08:55:59Z","html_url":"https://github.com/Particular/NServiceBus/pull/3127#discussion_r46027293","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/46027293"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3127#discussion_r46027293"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127","id":51945872,"html_url":"https://github.com/Particular/NServiceBus/pull/3127","diff_url":"https://github.com/Particular/NServiceBus/pull/3127.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3127.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3127","number":3127,"state":"open","locked":false,"title":"Async all the way for dynamic route rules.","user":{"login":"janovesk","id":396480,"avatar_url":"https://avatars.githubusercontent.com/u/396480?v=3","gravatar_id":"","url":"https://api.github.com/users/janovesk","html_url":"https://github.com/janovesk","followers_url":"https://api.github.com/users/janovesk/followers","following_url":"https://api.github.com/users/janovesk/following{/other_user}","gists_url":"https://api.github.com/users/janovesk/gists{/gist_id}","starred_url":"https://api.github.com/users/janovesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janovesk/subscriptions","organizations_url":"https://api.github.com/users/janovesk/orgs","repos_url":"https://api.github.com/users/janovesk/repos","events_url":"https://api.github.com/users/janovesk/events{/privacy}","received_events_url":"https://api.github.com/users/janovesk/received_events","type":"User","site_admin":false},"body":"First go at https://github.com/Particular/NServiceBus/issues/3116","created_at":"2015-11-26T21:12:23Z","updated_at":"2015-11-27T08:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37987e4b9304c203ab1fd5248e9007a35e2efe18","assignee":{"login":"janovesk","id":396480,"avatar_url":"https://avatars.githubusercontent.com/u/396480?v=3","gravatar_id":"","url":"https://api.github.com/users/janovesk","html_url":"https://github.com/janovesk","followers_url":"https://api.github.com/users/janovesk/followers","following_url":"https://api.github.com/users/janovesk/following{/other_user}","gists_url":"https://api.github.com/users/janovesk/gists{/gist_id}","starred_url":"https://api.github.com/users/janovesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janovesk/subscriptions","organizations_url":"https://api.github.com/users/janovesk/orgs","repos_url":"https://api.github.com/users/janovesk/repos","events_url":"https://api.github.com/users/janovesk/events{/privacy}","received_events_url":"https://api.github.com/users/janovesk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3127/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/7d21113b2abf60b750d00d7f7de650b32a793582","head":{"label":"Particular:AsyncDynamicRoutes","ref":"AsyncDynamicRoutes","sha":"7d21113b2abf60b750d00d7f7de650b32a793582","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-11-25T15:53:41Z","pushed_at":"2015-11-27T08:36:05Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":157270,"stargazers_count":815,"watchers_count":815,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":451,"mirror_url":null,"open_issues_count":190,"forks":451,"open_issues":190,"watchers":815,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"30b0edca5c006f5fa5b9d9d0f3b4cca2e5ebcabd","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-11-25T15:53:41Z","pushed_at":"2015-11-27T08:36:05Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":157270,"stargazers_count":815,"watchers_count":815,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":451,"mirror_url":null,"open_issues_count":190,"forks":451,"open_issues":190,"watchers":815,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3127"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3127"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3127/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3127/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus/statuses/7d21113b2abf60b750d00d7f7de650b32a793582"}}}}