{"action":"created","issue":{"url":"https://api.github.com/repos/petecoop/generator-express/issues/127","labels_url":"https://api.github.com/repos/petecoop/generator-express/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/petecoop/generator-express/issues/127/comments","events_url":"https://api.github.com/repos/petecoop/generator-express/issues/127/events","html_url":"https://github.com/petecoop/generator-express/pull/127","id":85824391,"number":127,"title":"Add support for TypeScript.","user":{"login":"markogresak","id":6675751,"avatar_url":"https://avatars.githubusercontent.com/u/6675751?v=3","gravatar_id":"","url":"https://api.github.com/users/markogresak","html_url":"https://github.com/markogresak","followers_url":"https://api.github.com/users/markogresak/followers","following_url":"https://api.github.com/users/markogresak/following{/other_user}","gists_url":"https://api.github.com/users/markogresak/gists{/gist_id}","starred_url":"https://api.github.com/users/markogresak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markogresak/subscriptions","organizations_url":"https://api.github.com/users/markogresak/orgs","repos_url":"https://api.github.com/users/markogresak/repos","events_url":"https://api.github.com/users/markogresak/events{/privacy}","received_events_url":"https://api.github.com/users/markogresak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-06T23:53:47Z","updated_at":"2015-06-07T00:31:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/petecoop/generator-express/pulls/127","html_url":"https://github.com/petecoop/generator-express/pull/127","diff_url":"https://github.com/petecoop/generator-express/pull/127.diff","patch_url":"https://github.com/petecoop/generator-express/pull/127.patch"},"body":"*Note: This is a work in progress and generator currently generates failing project.*\r\n\r\nThis pull request adds TypeScript option to generator, as asked in #106.\r\n\r\nCurrent implementation:\r\n\r\n - [x] `--ts | --typescript` options\r\n - [x] generate working files (currently copied from js)\r\n - [ ] compile typescript files\r\n - [ ] ask if [tsd](https://github.com/DefinitelyTyped/tsd) should be added\r\n\r\nDiscuss:\r\n\r\n - [ ] Keep both `--ts | --typescript`, or just one of them?\r\n - [ ] Should compile `*.ts` > `*.js` or use [`tsconfig.json` project file](https://github.com/Microsoft/TypeScript/wiki/tsconfig.json)?\r\n\r\nAlso a question: When fixing/adding tests, I referred to coffee tests. There are some tests which tests working with coffee and ..., but when calling `runGenerationTest`, the `coffee` passed in is `false`. Why is that and should it be fixed? Example: [test-creation.js:159](https://github.com/petecoop/generator-express/blob/master/test/test-creation.js#L159)."},"comment":{"url":"https://api.github.com/repos/petecoop/generator-express/issues/comments/109661109","html_url":"https://github.com/petecoop/generator-express/pull/127#issuecomment-109661109","issue_url":"https://api.github.com/repos/petecoop/generator-express/issues/127","id":109661109,"user":{"login":"petecoop","id":1655361,"avatar_url":"https://avatars.githubusercontent.com/u/1655361?v=3","gravatar_id":"","url":"https://api.github.com/users/petecoop","html_url":"https://github.com/petecoop","followers_url":"https://api.github.com/users/petecoop/followers","following_url":"https://api.github.com/users/petecoop/following{/other_user}","gists_url":"https://api.github.com/users/petecoop/gists{/gist_id}","starred_url":"https://api.github.com/users/petecoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petecoop/subscriptions","organizations_url":"https://api.github.com/users/petecoop/orgs","repos_url":"https://api.github.com/users/petecoop/repos","events_url":"https://api.github.com/users/petecoop/events{/privacy}","received_events_url":"https://api.github.com/users/petecoop/received_events","type":"User","site_admin":false},"created_at":"2015-06-07T00:31:06Z","updated_at":"2015-06-07T00:31:06Z","body":"- Having both --ts and --typescript sounds good to me. \r\n- I'm not sure on standards of compiling .ts files, but the basic idea of this project is that you can just run grunt or gulp and everything will watch/compile for you. Coffeescript does it through `require('coffee-script/register');`\r\n- Yeah that looks like a problem with the tests, it'd probably be best to refactor the tests a bit so that you pass in a language var e.g. `coffee` or `typescript` instead of adding more true/false flags onto the function"}}