{"action":"created","comment":{"url":"https://api.github.com/repos/joyent/http-parser/pulls/comments/23524873","id":23524873,"diff_hunk":"@@ -2134,6 +2134,19 @@ http_parser_init (http_parser *parser, enum http_parser_type t)\n   parser->http_errno = HPE_OK;\n }\n \n+void\n+http_parser_settings_init(http_parser_settings *settings)","path":"http_parser.c","position":5,"original_position":5,"commit_id":"0deeafbf1574f9581aaf7894b48b0966df5476c2","original_commit_id":"d1191403778578b4eb9f43bae424fb9579bb43dc","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"Arrrgh, you are right! Nginx legacy, damn it.","created_at":"2015-01-26T11:46:44Z","updated_at":"2015-01-26T11:46:44Z","html_url":"https://github.com/joyent/http-parser/pull/215#discussion_r23524873","pull_request_url":"https://api.github.com/repos/joyent/http-parser/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/comments/23524873"},"html":{"href":"https://github.com/joyent/http-parser/pull/215#discussion_r23524873"},"pull_request":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/http-parser/pulls/215","id":27931536,"html_url":"https://github.com/joyent/http-parser/pull/215","diff_url":"https://github.com/joyent/http-parser/pull/215.diff","patch_url":"https://github.com/joyent/http-parser/pull/215.patch","issue_url":"https://api.github.com/repos/joyent/http-parser/issues/215","number":215,"state":"open","locked":false,"title":"Add function to initialize http_parser_settings","user":{"login":"RomainGiraud","id":357799,"avatar_url":"https://avatars.githubusercontent.com/u/357799?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainGiraud","html_url":"https://github.com/RomainGiraud","followers_url":"https://api.github.com/users/RomainGiraud/followers","following_url":"https://api.github.com/users/RomainGiraud/following{/other_user}","gists_url":"https://api.github.com/users/RomainGiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainGiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainGiraud/subscriptions","organizations_url":"https://api.github.com/users/RomainGiraud/orgs","repos_url":"https://api.github.com/users/RomainGiraud/repos","events_url":"https://api.github.com/users/RomainGiraud/events{/privacy}","received_events_url":"https://api.github.com/users/RomainGiraud/received_events","type":"User","site_admin":false},"body":"When http_parser_settings struct is defined in function or class scope, struct members are not initilized to 0.","created_at":"2015-01-23T15:31:47Z","updated_at":"2015-01-26T11:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33e359f3c6ece844f6c39fb60b9b2b517d03a8cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/http-parser/pulls/215/commits","review_comments_url":"https://api.github.com/repos/joyent/http-parser/pulls/215/comments","review_comment_url":"https://api.github.com/repos/joyent/http-parser/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/http-parser/issues/215/comments","statuses_url":"https://api.github.com/repos/joyent/http-parser/statuses/0deeafbf1574f9581aaf7894b48b0966df5476c2","head":{"label":"RomainGiraud:master","ref":"master","sha":"0deeafbf1574f9581aaf7894b48b0966df5476c2","user":{"login":"RomainGiraud","id":357799,"avatar_url":"https://avatars.githubusercontent.com/u/357799?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainGiraud","html_url":"https://github.com/RomainGiraud","followers_url":"https://api.github.com/users/RomainGiraud/followers","following_url":"https://api.github.com/users/RomainGiraud/following{/other_user}","gists_url":"https://api.github.com/users/RomainGiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainGiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainGiraud/subscriptions","organizations_url":"https://api.github.com/users/RomainGiraud/orgs","repos_url":"https://api.github.com/users/RomainGiraud/repos","events_url":"https://api.github.com/users/RomainGiraud/events{/privacy}","received_events_url":"https://api.github.com/users/RomainGiraud/received_events","type":"User","site_admin":false},"repo":{"id":29737121,"name":"http-parser","full_name":"RomainGiraud/http-parser","owner":{"login":"RomainGiraud","id":357799,"avatar_url":"https://avatars.githubusercontent.com/u/357799?v=3","gravatar_id":"","url":"https://api.github.com/users/RomainGiraud","html_url":"https://github.com/RomainGiraud","followers_url":"https://api.github.com/users/RomainGiraud/followers","following_url":"https://api.github.com/users/RomainGiraud/following{/other_user}","gists_url":"https://api.github.com/users/RomainGiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/RomainGiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomainGiraud/subscriptions","organizations_url":"https://api.github.com/users/RomainGiraud/orgs","repos_url":"https://api.github.com/users/RomainGiraud/repos","events_url":"https://api.github.com/users/RomainGiraud/events{/privacy}","received_events_url":"https://api.github.com/users/RomainGiraud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RomainGiraud/http-parser","description":"http request/response parser for c","fork":true,"url":"https://api.github.com/repos/RomainGiraud/http-parser","forks_url":"https://api.github.com/repos/RomainGiraud/http-parser/forks","keys_url":"https://api.github.com/repos/RomainGiraud/http-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RomainGiraud/http-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RomainGiraud/http-parser/teams","hooks_url":"https://api.github.com/repos/RomainGiraud/http-parser/hooks","issue_events_url":"https://api.github.com/repos/RomainGiraud/http-parser/issues/events{/number}","events_url":"https://api.github.com/repos/RomainGiraud/http-parser/events","assignees_url":"https://api.github.com/repos/RomainGiraud/http-parser/assignees{/user}","branches_url":"https://api.github.com/repos/RomainGiraud/http-parser/branches{/branch}","tags_url":"https://api.github.com/repos/RomainGiraud/http-parser/tags","blobs_url":"https://api.github.com/repos/RomainGiraud/http-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RomainGiraud/http-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RomainGiraud/http-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/RomainGiraud/http-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RomainGiraud/http-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/RomainGiraud/http-parser/languages","stargazers_url":"https://api.github.com/repos/RomainGiraud/http-parser/stargazers","contributors_url":"https://api.github.com/repos/RomainGiraud/http-parser/contributors","subscribers_url":"https://api.github.com/repos/RomainGiraud/http-parser/subscribers","subscription_url":"https://api.github.com/repos/RomainGiraud/http-parser/subscription","commits_url":"https://api.github.com/repos/RomainGiraud/http-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/RomainGiraud/http-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/RomainGiraud/http-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/RomainGiraud/http-parser/issues/comments/{number}","contents_url":"https://api.github.com/repos/RomainGiraud/http-parser/contents/{+path}","compare_url":"https://api.github.com/repos/RomainGiraud/http-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RomainGiraud/http-parser/merges","archive_url":"https://api.github.com/repos/RomainGiraud/http-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RomainGiraud/http-parser/downloads","issues_url":"https://api.github.com/repos/RomainGiraud/http-parser/issues{/number}","pulls_url":"https://api.github.com/repos/RomainGiraud/http-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/RomainGiraud/http-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/RomainGiraud/http-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RomainGiraud/http-parser/labels{/name}","releases_url":"https://api.github.com/repos/RomainGiraud/http-parser/releases{/id}","created_at":"2015-01-23T14:52:56Z","updated_at":"2015-01-26T08:35:24Z","pushed_at":"2015-01-26T08:35:23Z","git_url":"git://github.com/RomainGiraud/http-parser.git","ssh_url":"git@github.com:RomainGiraud/http-parser.git","clone_url":"https://github.com/RomainGiraud/http-parser.git","svn_url":"https://github.com/RomainGiraud/http-parser","homepage":"","size":1671,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"36f107fa2e62ca1f0fe7087e49f58624c45a24f1","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":186749,"name":"http-parser","full_name":"joyent/http-parser","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/http-parser","description":"http request/response parser for c","fork":false,"url":"https://api.github.com/repos/joyent/http-parser","forks_url":"https://api.github.com/repos/joyent/http-parser/forks","keys_url":"https://api.github.com/repos/joyent/http-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/http-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/http-parser/teams","hooks_url":"https://api.github.com/repos/joyent/http-parser/hooks","issue_events_url":"https://api.github.com/repos/joyent/http-parser/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/http-parser/events","assignees_url":"https://api.github.com/repos/joyent/http-parser/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/http-parser/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/http-parser/tags","blobs_url":"https://api.github.com/repos/joyent/http-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/http-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/http-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/http-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/http-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/http-parser/languages","stargazers_url":"https://api.github.com/repos/joyent/http-parser/stargazers","contributors_url":"https://api.github.com/repos/joyent/http-parser/contributors","subscribers_url":"https://api.github.com/repos/joyent/http-parser/subscribers","subscription_url":"https://api.github.com/repos/joyent/http-parser/subscription","commits_url":"https://api.github.com/repos/joyent/http-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/http-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/http-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/http-parser/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/http-parser/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/http-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/http-parser/merges","archive_url":"https://api.github.com/repos/joyent/http-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/http-parser/downloads","issues_url":"https://api.github.com/repos/joyent/http-parser/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/http-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/http-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/http-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/http-parser/labels{/name}","releases_url":"https://api.github.com/repos/joyent/http-parser/releases{/id}","created_at":"2009-04-27T15:09:51Z","updated_at":"2015-01-25T18:23:04Z","pushed_at":"2015-01-25T18:23:05Z","git_url":"git://github.com/joyent/http-parser.git","ssh_url":"git@github.com:joyent/http-parser.git","clone_url":"https://github.com/joyent/http-parser.git","svn_url":"https://github.com/joyent/http-parser","homepage":"","size":1671,"stargazers_count":1907,"watchers_count":1907,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":457,"mirror_url":null,"open_issues_count":19,"forks":457,"open_issues":19,"watchers":1907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/215"},"html":{"href":"https://github.com/joyent/http-parser/pull/215"},"issue":{"href":"https://api.github.com/repos/joyent/http-parser/issues/215"},"comments":{"href":"https://api.github.com/repos/joyent/http-parser/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/http-parser/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/http-parser/statuses/0deeafbf1574f9581aaf7894b48b0966df5476c2"}}}}