{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6","id":27830643,"html_url":"https://github.com/madhurjain/passport-local-sequelize/pull/6","diff_url":"https://github.com/madhurjain/passport-local-sequelize/pull/6.diff","patch_url":"https://github.com/madhurjain/passport-local-sequelize/pull/6.patch","issue_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/6","number":6,"state":"closed","locked":false,"title":"ensure that salt field is not null","user":{"login":"gibu","id":1145173,"avatar_url":"https://avatars.githubusercontent.com/u/1145173?v=3","gravatar_id":"","url":"https://api.github.com/users/gibu","html_url":"https://github.com/gibu","followers_url":"https://api.github.com/users/gibu/followers","following_url":"https://api.github.com/users/gibu/following{/other_user}","gists_url":"https://api.github.com/users/gibu/gists{/gist_id}","starred_url":"https://api.github.com/users/gibu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibu/subscriptions","organizations_url":"https://api.github.com/users/gibu/orgs","repos_url":"https://api.github.com/users/gibu/repos","events_url":"https://api.github.com/users/gibu/events{/privacy}","received_events_url":"https://api.github.com/users/gibu/received_events","type":"User","site_admin":false},"body":"If some cases, somebody can have custom definition DB, where the salt field can be null.\r\nThis cause throwing \r\nTypeError: Not a buffer\r\n  at pbkdf2 (crypto.js:570:20)\r\n  at Object.exports.pbkdf2 (crypto.js:556:10)\r\n\r\nfrom crypto library.","created_at":"2015-01-22T10:08:15Z","updated_at":"2015-11-20T04:22:07Z","closed_at":"2015-11-20T04:22:07Z","merged_at":"2015-11-20T04:22:07Z","merge_commit_sha":"26fc1bfcc10fe0ff557eee0ae0ec67ac21a7cda9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6/commits","review_comments_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6/comments","review_comment_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/6/comments","statuses_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/statuses/86151d3d17b8b7df4e7fc9abe5bffe0cbcf3a0ef","head":{"label":"gibu:master","ref":"master","sha":"86151d3d17b8b7df4e7fc9abe5bffe0cbcf3a0ef","user":{"login":"gibu","id":1145173,"avatar_url":"https://avatars.githubusercontent.com/u/1145173?v=3","gravatar_id":"","url":"https://api.github.com/users/gibu","html_url":"https://github.com/gibu","followers_url":"https://api.github.com/users/gibu/followers","following_url":"https://api.github.com/users/gibu/following{/other_user}","gists_url":"https://api.github.com/users/gibu/gists{/gist_id}","starred_url":"https://api.github.com/users/gibu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibu/subscriptions","organizations_url":"https://api.github.com/users/gibu/orgs","repos_url":"https://api.github.com/users/gibu/repos","events_url":"https://api.github.com/users/gibu/events{/privacy}","received_events_url":"https://api.github.com/users/gibu/received_events","type":"User","site_admin":false},"repo":{"id":29671281,"name":"passport-local-sequelize","full_name":"gibu/passport-local-sequelize","owner":{"login":"gibu","id":1145173,"avatar_url":"https://avatars.githubusercontent.com/u/1145173?v=3","gravatar_id":"","url":"https://api.github.com/users/gibu","html_url":"https://github.com/gibu","followers_url":"https://api.github.com/users/gibu/followers","following_url":"https://api.github.com/users/gibu/following{/other_user}","gists_url":"https://api.github.com/users/gibu/gists{/gist_id}","starred_url":"https://api.github.com/users/gibu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibu/subscriptions","organizations_url":"https://api.github.com/users/gibu/orgs","repos_url":"https://api.github.com/users/gibu/repos","events_url":"https://api.github.com/users/gibu/events{/privacy}","received_events_url":"https://api.github.com/users/gibu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gibu/passport-local-sequelize","description":"passport-local-sequelize is a sequelize plugin for building username and password login with passport","fork":true,"url":"https://api.github.com/repos/gibu/passport-local-sequelize","forks_url":"https://api.github.com/repos/gibu/passport-local-sequelize/forks","keys_url":"https://api.github.com/repos/gibu/passport-local-sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibu/passport-local-sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibu/passport-local-sequelize/teams","hooks_url":"https://api.github.com/repos/gibu/passport-local-sequelize/hooks","issue_events_url":"https://api.github.com/repos/gibu/passport-local-sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/gibu/passport-local-sequelize/events","assignees_url":"https://api.github.com/repos/gibu/passport-local-sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/gibu/passport-local-sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/gibu/passport-local-sequelize/tags","blobs_url":"https://api.github.com/repos/gibu/passport-local-sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibu/passport-local-sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibu/passport-local-sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibu/passport-local-sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibu/passport-local-sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/gibu/passport-local-sequelize/languages","stargazers_url":"https://api.github.com/repos/gibu/passport-local-sequelize/stargazers","contributors_url":"https://api.github.com/repos/gibu/passport-local-sequelize/contributors","subscribers_url":"https://api.github.com/repos/gibu/passport-local-sequelize/subscribers","subscription_url":"https://api.github.com/repos/gibu/passport-local-sequelize/subscription","commits_url":"https://api.github.com/repos/gibu/passport-local-sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibu/passport-local-sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibu/passport-local-sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibu/passport-local-sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibu/passport-local-sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/gibu/passport-local-sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibu/passport-local-sequelize/merges","archive_url":"https://api.github.com/repos/gibu/passport-local-sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibu/passport-local-sequelize/downloads","issues_url":"https://api.github.com/repos/gibu/passport-local-sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/gibu/passport-local-sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/gibu/passport-local-sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/gibu/passport-local-sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibu/passport-local-sequelize/labels{/name}","releases_url":"https://api.github.com/repos/gibu/passport-local-sequelize/releases{/id}","created_at":"2015-01-22T09:31:45Z","updated_at":"2015-01-22T09:49:12Z","pushed_at":"2015-01-22T09:49:12Z","git_url":"git://github.com/gibu/passport-local-sequelize.git","ssh_url":"git@github.com:gibu/passport-local-sequelize.git","clone_url":"https://github.com/gibu/passport-local-sequelize.git","svn_url":"https://github.com/gibu/passport-local-sequelize","homepage":"","size":120,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"madhurjain:master","ref":"master","sha":"6e1db6d6005ac98d3fdca93db7774ffa0371a4ca","user":{"login":"madhurjain","id":765100,"avatar_url":"https://avatars.githubusercontent.com/u/765100?v=3","gravatar_id":"","url":"https://api.github.com/users/madhurjain","html_url":"https://github.com/madhurjain","followers_url":"https://api.github.com/users/madhurjain/followers","following_url":"https://api.github.com/users/madhurjain/following{/other_user}","gists_url":"https://api.github.com/users/madhurjain/gists{/gist_id}","starred_url":"https://api.github.com/users/madhurjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhurjain/subscriptions","organizations_url":"https://api.github.com/users/madhurjain/orgs","repos_url":"https://api.github.com/users/madhurjain/repos","events_url":"https://api.github.com/users/madhurjain/events{/privacy}","received_events_url":"https://api.github.com/users/madhurjain/received_events","type":"User","site_admin":false},"repo":{"id":15208648,"name":"passport-local-sequelize","full_name":"madhurjain/passport-local-sequelize","owner":{"login":"madhurjain","id":765100,"avatar_url":"https://avatars.githubusercontent.com/u/765100?v=3","gravatar_id":"","url":"https://api.github.com/users/madhurjain","html_url":"https://github.com/madhurjain","followers_url":"https://api.github.com/users/madhurjain/followers","following_url":"https://api.github.com/users/madhurjain/following{/other_user}","gists_url":"https://api.github.com/users/madhurjain/gists{/gist_id}","starred_url":"https://api.github.com/users/madhurjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhurjain/subscriptions","organizations_url":"https://api.github.com/users/madhurjain/orgs","repos_url":"https://api.github.com/users/madhurjain/repos","events_url":"https://api.github.com/users/madhurjain/events{/privacy}","received_events_url":"https://api.github.com/users/madhurjain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhurjain/passport-local-sequelize","description":"passport-local-sequelize is a sequelize plugin for building username and password login with passport","fork":false,"url":"https://api.github.com/repos/madhurjain/passport-local-sequelize","forks_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/forks","keys_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/teams","hooks_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/hooks","issue_events_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/events","assignees_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/tags","blobs_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/languages","stargazers_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/stargazers","contributors_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/contributors","subscribers_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/subscribers","subscription_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/subscription","commits_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/merges","archive_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/downloads","issues_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/labels{/name}","releases_url":"https://api.github.com/repos/madhurjain/passport-local-sequelize/releases{/id}","created_at":"2013-12-15T18:43:15Z","updated_at":"2015-10-26T10:15:38Z","pushed_at":"2015-11-20T04:22:07Z","git_url":"git://github.com/madhurjain/passport-local-sequelize.git","ssh_url":"git@github.com:madhurjain/passport-local-sequelize.git","clone_url":"https://github.com/madhurjain/passport-local-sequelize.git","svn_url":"https://github.com/madhurjain/passport-local-sequelize","homepage":"","size":280,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6"},"html":{"href":"https://github.com/madhurjain/passport-local-sequelize/pull/6"},"issue":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/6"},"comments":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/madhurjain/passport-local-sequelize/statuses/86151d3d17b8b7df4e7fc9abe5bffe0cbcf3a0ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"madhurjain","id":765100,"avatar_url":"https://avatars.githubusercontent.com/u/765100?v=3","gravatar_id":"","url":"https://api.github.com/users/madhurjain","html_url":"https://github.com/madhurjain","followers_url":"https://api.github.com/users/madhurjain/followers","following_url":"https://api.github.com/users/madhurjain/following{/other_user}","gists_url":"https://api.github.com/users/madhurjain/gists{/gist_id}","starred_url":"https://api.github.com/users/madhurjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhurjain/subscriptions","organizations_url":"https://api.github.com/users/madhurjain/orgs","repos_url":"https://api.github.com/users/madhurjain/repos","events_url":"https://api.github.com/users/madhurjain/events{/privacy}","received_events_url":"https://api.github.com/users/madhurjain/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":1}}