{"action":"created","issue":{"url":"https://api.github.com/repos/floodlight/loxigen/issues/439","labels_url":"https://api.github.com/repos/floodlight/loxigen/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/floodlight/loxigen/issues/439/comments","events_url":"https://api.github.com/repos/floodlight/loxigen/issues/439/events","html_url":"https://github.com/floodlight/loxigen/pull/439","id":113471571,"number":439,"title":"java: generate setters for unwriteable fields","user":{"login":"rlane","id":28525,"avatar_url":"https://avatars.githubusercontent.com/u/28525?v=3","gravatar_id":"","url":"https://api.github.com/users/rlane","html_url":"https://github.com/rlane","followers_url":"https://api.github.com/users/rlane/followers","following_url":"https://api.github.com/users/rlane/following{/other_user}","gists_url":"https://api.github.com/users/rlane/gists{/gist_id}","starred_url":"https://api.github.com/users/rlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlane/subscriptions","organizations_url":"https://api.github.com/users/rlane/orgs","repos_url":"https://api.github.com/users/rlane/repos","events_url":"https://api.github.com/users/rlane/events{/privacy}","received_events_url":"https://api.github.com/users/rlane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-26T23:23:02Z","updated_at":"2015-11-24T23:07:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/floodlight/loxigen/pulls/439","html_url":"https://github.com/floodlight/loxigen/pull/439","diff_url":"https://github.com/floodlight/loxigen/pull/439.diff","patch_url":"https://github.com/floodlight/loxigen/pull/439.patch"},"body":"Reviewer: @andi-bigswitch\n\nhttps://github.com/floodlight/loxigen/pull/438 ran into a problem when we\ntried to use a field as a discriminator when it was a normal data member in\nthe superclass. The java compiler complained that we hadn't provided an \nimplementation of the setter in the concrete class.\n\nThis change fixes the problem by creating setters for unwriteable fields which \nthrow an exception, like we do when the field isn't available in the OpenFlow \nversion.\n\nThis obviously adds the setters in more places than necessary. We could \npossibly optimize this by checking each ancestor class to see if the field \nchanged writeability and only emit a setter in that special case."},"comment":{"url":"https://api.github.com/repos/floodlight/loxigen/issues/comments/159434698","html_url":"https://github.com/floodlight/loxigen/pull/439#issuecomment-159434698","issue_url":"https://api.github.com/repos/floodlight/loxigen/issues/439","id":159434698,"user":{"login":"andi-bigswitch","id":2481487,"avatar_url":"https://avatars.githubusercontent.com/u/2481487?v=3","gravatar_id":"","url":"https://api.github.com/users/andi-bigswitch","html_url":"https://github.com/andi-bigswitch","followers_url":"https://api.github.com/users/andi-bigswitch/followers","following_url":"https://api.github.com/users/andi-bigswitch/following{/other_user}","gists_url":"https://api.github.com/users/andi-bigswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/andi-bigswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andi-bigswitch/subscriptions","organizations_url":"https://api.github.com/users/andi-bigswitch/orgs","repos_url":"https://api.github.com/users/andi-bigswitch/repos","events_url":"https://api.github.com/users/andi-bigswitch/events{/privacy}","received_events_url":"https://api.github.com/users/andi-bigswitch/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T23:07:46Z","updated_at":"2015-11-24T23:07:46Z","body":"@rlane what's the next step for this PR? Would you like me to take it over to make those changes?"}}