{"action":"closed","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3266","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3266/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3266/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3266/events","html_url":"https://github.com/cockroachdb/cockroach/issues/3266","id":119788614,"number":3266,"title":"sql: comparison of float and int","user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-12-01T19:24:49Z","updated_at":"2015-12-03T20:07:40Z","closed_at":"2015-12-03T20:07:40Z","body":"The following sqllogictest fails with the error:\r\n\r\n```\r\nunsupported comparison operator: <float> < <int>\r\n```\r\n\r\nhttps://github.com/cockroachdb/sqllogictest/blob/a88396b84bb1fe62edf2e072e585d68c0b2ecdca/test/select1.test#L94\r\n\r\nWhich makes sense because `c` is an `INTEGER`, and the call to `avg` returns a `float`. This test is currently disabled for other reasons, but when enabled will fail here. We could decide to either\r\n\r\n1. Disable this test. This would involve coming up with a way to selectively disable portions of sqllogic tests, instead of just disabling entire files. It would also mean we are choosing to be more strict than other SQL implementations.\r\n2. Implement float and int comparisons."}}