{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/31058332","id":31058332,"diff_hunk":"@@ -19,6 +20,7 @@ var Server = {\n         var onRouteHandled = config.onRouteHandled;\n         var ServerAppToUse = config.ServerApp || ServerApp;\n         var appRoot = environmentConfig.appRoot;\n+        var proxyClientRequestsToApi = config.proxyClientRequestsToApi;","path":"lib/server/Server.js","position":12,"original_position":12,"commit_id":"bce20b470d234eae282611430f441084d537a8de","original_commit_id":"d57cf4aee7a0e235349034407884da7b727441f3","user":{"login":"ericherdzik","id":4305370,"avatar_url":"https://avatars.githubusercontent.com/u/4305370?v=3","gravatar_id":"","url":"https://api.github.com/users/ericherdzik","html_url":"https://github.com/ericherdzik","followers_url":"https://api.github.com/users/ericherdzik/followers","following_url":"https://api.github.com/users/ericherdzik/following{/other_user}","gists_url":"https://api.github.com/users/ericherdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/ericherdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericherdzik/subscriptions","organizations_url":"https://api.github.com/users/ericherdzik/orgs","repos_url":"https://api.github.com/users/ericherdzik/repos","events_url":"https://api.github.com/users/ericherdzik/events{/privacy}","received_events_url":"https://api.github.com/users/ericherdzik/received_events","type":"User","site_admin":false},"body":"My argument is just on the basis of confusion with the server sending requests to API_HOST and the client sending them to the app, not the API_HOST. Both should end up in the same location by default in my opinion.","created_at":"2015-05-26T17:31:08Z","updated_at":"2015-05-26T17:31:08Z","html_url":"https://github.com/bloomberg/brisket/pull/140#discussion_r31058332","pull_request_url":"https://api.github.com/repos/bloomberg/brisket/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments/31058332"},"html":{"href":"https://github.com/bloomberg/brisket/pull/140#discussion_r31058332"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/brisket/pulls/140","id":36097910,"html_url":"https://github.com/bloomberg/brisket/pull/140","diff_url":"https://github.com/bloomberg/brisket/pull/140.diff","patch_url":"https://github.com/bloomberg/brisket/pull/140.patch","issue_url":"https://api.github.com/repos/bloomberg/brisket/issues/140","number":140,"state":"open","locked":false,"title":"add way to proxy to apiHost","user":{"login":"claquesous","id":2617521,"avatar_url":"https://avatars.githubusercontent.com/u/2617521?v=3","gravatar_id":"","url":"https://api.github.com/users/claquesous","html_url":"https://github.com/claquesous","followers_url":"https://api.github.com/users/claquesous/followers","following_url":"https://api.github.com/users/claquesous/following{/other_user}","gists_url":"https://api.github.com/users/claquesous/gists{/gist_id}","starred_url":"https://api.github.com/users/claquesous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claquesous/subscriptions","organizations_url":"https://api.github.com/users/claquesous/orgs","repos_url":"https://api.github.com/users/claquesous/repos","events_url":"https://api.github.com/users/claquesous/events{/privacy}","received_events_url":"https://api.github.com/users/claquesous/received_events","type":"User","site_admin":false},"body":"This needs a little more polish, but just putting it out there.","created_at":"2015-05-24T04:21:16Z","updated_at":"2015-05-26T17:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"053e3cb6085ad331153c280251d361cfbde46be2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/brisket/pulls/140/commits","review_comments_url":"https://api.github.com/repos/bloomberg/brisket/pulls/140/comments","review_comment_url":"https://api.github.com/repos/bloomberg/brisket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/brisket/issues/140/comments","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/bce20b470d234eae282611430f441084d537a8de","head":{"label":"claquesous:proxy_to_apihost","ref":"proxy_to_apihost","sha":"bce20b470d234eae282611430f441084d537a8de","user":{"login":"claquesous","id":2617521,"avatar_url":"https://avatars.githubusercontent.com/u/2617521?v=3","gravatar_id":"","url":"https://api.github.com/users/claquesous","html_url":"https://github.com/claquesous","followers_url":"https://api.github.com/users/claquesous/followers","following_url":"https://api.github.com/users/claquesous/following{/other_user}","gists_url":"https://api.github.com/users/claquesous/gists{/gist_id}","starred_url":"https://api.github.com/users/claquesous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claquesous/subscriptions","organizations_url":"https://api.github.com/users/claquesous/orgs","repos_url":"https://api.github.com/users/claquesous/repos","events_url":"https://api.github.com/users/claquesous/events{/privacy}","received_events_url":"https://api.github.com/users/claquesous/received_events","type":"User","site_admin":false},"repo":{"id":36042695,"name":"brisket","full_name":"claquesous/brisket","owner":{"login":"claquesous","id":2617521,"avatar_url":"https://avatars.githubusercontent.com/u/2617521?v=3","gravatar_id":"","url":"https://api.github.com/users/claquesous","html_url":"https://github.com/claquesous","followers_url":"https://api.github.com/users/claquesous/followers","following_url":"https://api.github.com/users/claquesous/following{/other_user}","gists_url":"https://api.github.com/users/claquesous/gists{/gist_id}","starred_url":"https://api.github.com/users/claquesous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claquesous/subscriptions","organizations_url":"https://api.github.com/users/claquesous/orgs","repos_url":"https://api.github.com/users/claquesous/repos","events_url":"https://api.github.com/users/claquesous/events{/privacy}","received_events_url":"https://api.github.com/users/claquesous/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claquesous/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":true,"url":"https://api.github.com/repos/claquesous/brisket","forks_url":"https://api.github.com/repos/claquesous/brisket/forks","keys_url":"https://api.github.com/repos/claquesous/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claquesous/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claquesous/brisket/teams","hooks_url":"https://api.github.com/repos/claquesous/brisket/hooks","issue_events_url":"https://api.github.com/repos/claquesous/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/claquesous/brisket/events","assignees_url":"https://api.github.com/repos/claquesous/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/claquesous/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/claquesous/brisket/tags","blobs_url":"https://api.github.com/repos/claquesous/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claquesous/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claquesous/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/claquesous/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claquesous/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/claquesous/brisket/languages","stargazers_url":"https://api.github.com/repos/claquesous/brisket/stargazers","contributors_url":"https://api.github.com/repos/claquesous/brisket/contributors","subscribers_url":"https://api.github.com/repos/claquesous/brisket/subscribers","subscription_url":"https://api.github.com/repos/claquesous/brisket/subscription","commits_url":"https://api.github.com/repos/claquesous/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/claquesous/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/claquesous/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/claquesous/brisket/issues/comments{/number}","contents_url":"https://api.github.com/repos/claquesous/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/claquesous/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claquesous/brisket/merges","archive_url":"https://api.github.com/repos/claquesous/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claquesous/brisket/downloads","issues_url":"https://api.github.com/repos/claquesous/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/claquesous/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/claquesous/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/claquesous/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claquesous/brisket/labels{/name}","releases_url":"https://api.github.com/repos/claquesous/brisket/releases{/id}","created_at":"2015-05-21T23:45:14Z","updated_at":"2015-05-21T23:45:15Z","pushed_at":"2015-05-24T19:57:27Z","git_url":"git://github.com/claquesous/brisket.git","ssh_url":"git@github.com:claquesous/brisket.git","clone_url":"https://github.com/claquesous/brisket.git","svn_url":"https://github.com/claquesous/brisket","homepage":"","size":556,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"8167ccc436e77c4e7ae0dc75df4e1324ac613a16","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24653948,"name":"brisket","full_name":"bloomberg/brisket","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/brisket","description":"Bloomberg's Brisket JavaScript application framework","fork":false,"url":"https://api.github.com/repos/bloomberg/brisket","forks_url":"https://api.github.com/repos/bloomberg/brisket/forks","keys_url":"https://api.github.com/repos/bloomberg/brisket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/brisket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/brisket/teams","hooks_url":"https://api.github.com/repos/bloomberg/brisket/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/brisket/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/brisket/events","assignees_url":"https://api.github.com/repos/bloomberg/brisket/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/brisket/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/brisket/tags","blobs_url":"https://api.github.com/repos/bloomberg/brisket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/brisket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/brisket/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/brisket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/brisket/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/brisket/languages","stargazers_url":"https://api.github.com/repos/bloomberg/brisket/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/brisket/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/brisket/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/brisket/subscription","commits_url":"https://api.github.com/repos/bloomberg/brisket/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/brisket/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/brisket/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/brisket/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/brisket/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/brisket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/brisket/merges","archive_url":"https://api.github.com/repos/bloomberg/brisket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/brisket/downloads","issues_url":"https://api.github.com/repos/bloomberg/brisket/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/brisket/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/brisket/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/brisket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/brisket/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/brisket/releases{/id}","created_at":"2014-09-30T20:17:08Z","updated_at":"2015-05-24T14:12:50Z","pushed_at":"2015-05-24T19:57:28Z","git_url":"git://github.com/bloomberg/brisket.git","ssh_url":"git@github.com:bloomberg/brisket.git","clone_url":"https://github.com/bloomberg/brisket.git","svn_url":"https://github.com/bloomberg/brisket","homepage":"","size":2136,"stargazers_count":708,"watchers_count":708,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":14,"forks":48,"open_issues":14,"watchers":708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/140"},"html":{"href":"https://github.com/bloomberg/brisket/pull/140"},"issue":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/140"},"comments":{"href":"https://api.github.com/repos/bloomberg/brisket/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/brisket/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/brisket/statuses/bce20b470d234eae282611430f441084d537a8de"}}}}