{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments/39536100","id":39536100,"diff_hunk":"@@ -0,0 +1,122 @@\n+# Copyright (c) 2009-2015 Tim Serong <tserong@suse.com>\n+# See COPYING for license.\n+\n+class HbReport\n+  # Note: outfile, errfile are based off path passed to generate() -\n+  # don't use them prior to a generate run, or you'll get the wrong path.\n+  # Lastexit is global (this is freaky/dumb - everything should be based\n+  # off path, and callers need to be updated to understand this - this\n+  # will happen when we allow multiple hb_report runs, as\n+  # hb_reports_controller is what cares about lastexit)\n+  attr_reader :path, :outfile, :errfile, :lastexit\n+\n+  # Call with e.g.:\n+  #  (\"#{Rails.root}/tmp/pids/hb_report\", \"/tmp/hb_report-hawk\").\n+  # pidfile will be set based on 'tmpbase', hb_report will be generated\n+  # at 'path'.  If path is nil, generate won't work -- make sure you set\n+  # it ASAP, before calling generate or relying on outfile or errfile!\n+  def initialize(name = nil)\n+    tmpbase = Rails.root.join('tmp', 'pids')","path":"hawk/lib/hb_report.rb","position":19,"original_position":19,"commit_id":"a7ee87ac4b3165efbd97a240990f810fac3c60cf","original_commit_id":"a7ee87ac4b3165efbd97a240990f810fac3c60cf","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-09-15T17:02:13Z","updated_at":"2015-09-15T17:02:13Z","html_url":"https://github.com/ClusterLabs/hawk/pull/46#discussion_r39536100","pull_request_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments/39536100"},"html":{"href":"https://github.com/ClusterLabs/hawk/pull/46#discussion_r39536100"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46","id":45074474,"html_url":"https://github.com/ClusterLabs/hawk/pull/46","diff_url":"https://github.com/ClusterLabs/hawk/pull/46.diff","patch_url":"https://github.com/ClusterLabs/hawk/pull/46.patch","issue_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/46","number":46,"state":"open","locked":false,"title":"Reports: Reimplemented history explorer","user":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"body":"There are still some minor issues, but it basically works now.\r\n\r\nMissing functionality from the old UI:\r\n\r\n* Downloading PE files\r\n* Show graph XML (possibly via API, but does anyone want it?)\r\n\r\nCode TODOs:\r\n\r\n* Remove `lib/hb_report.rb`, merge with `models/report.rb`\r\n\r\nPossible added features:\r\n\r\n* `crm configure show` for each transition\r\n","created_at":"2015-09-15T16:53:58Z","updated_at":"2015-09-15T17:02:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c165d1d65f9fe9d3590b26a123e235d62f142e49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/46/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/hawk/statuses/a7ee87ac4b3165efbd97a240990f810fac3c60cf","head":{"label":"krig:feature/history-explorer","ref":"feature/history-explorer","sha":"a7ee87ac4b3165efbd97a240990f810fac3c60cf","user":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"repo":{"id":11468129,"name":"hawk","full_name":"krig/hawk","owner":{"login":"krig","id":25527,"avatar_url":"https://avatars.githubusercontent.com/u/25527?v=3","gravatar_id":"","url":"https://api.github.com/users/krig","html_url":"https://github.com/krig","followers_url":"https://api.github.com/users/krig/followers","following_url":"https://api.github.com/users/krig/following{/other_user}","gists_url":"https://api.github.com/users/krig/gists{/gist_id}","starred_url":"https://api.github.com/users/krig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krig/subscriptions","organizations_url":"https://api.github.com/users/krig/orgs","repos_url":"https://api.github.com/users/krig/repos","events_url":"https://api.github.com/users/krig/events{/privacy}","received_events_url":"https://api.github.com/users/krig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krig/hawk","description":"A web-based GUI for managing and monitoring the Pacemaker High-Availability cluster resource manager","fork":true,"url":"https://api.github.com/repos/krig/hawk","forks_url":"https://api.github.com/repos/krig/hawk/forks","keys_url":"https://api.github.com/repos/krig/hawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krig/hawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krig/hawk/teams","hooks_url":"https://api.github.com/repos/krig/hawk/hooks","issue_events_url":"https://api.github.com/repos/krig/hawk/issues/events{/number}","events_url":"https://api.github.com/repos/krig/hawk/events","assignees_url":"https://api.github.com/repos/krig/hawk/assignees{/user}","branches_url":"https://api.github.com/repos/krig/hawk/branches{/branch}","tags_url":"https://api.github.com/repos/krig/hawk/tags","blobs_url":"https://api.github.com/repos/krig/hawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krig/hawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krig/hawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/krig/hawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krig/hawk/statuses/{sha}","languages_url":"https://api.github.com/repos/krig/hawk/languages","stargazers_url":"https://api.github.com/repos/krig/hawk/stargazers","contributors_url":"https://api.github.com/repos/krig/hawk/contributors","subscribers_url":"https://api.github.com/repos/krig/hawk/subscribers","subscription_url":"https://api.github.com/repos/krig/hawk/subscription","commits_url":"https://api.github.com/repos/krig/hawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/krig/hawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/krig/hawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/krig/hawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/krig/hawk/contents/{+path}","compare_url":"https://api.github.com/repos/krig/hawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krig/hawk/merges","archive_url":"https://api.github.com/repos/krig/hawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krig/hawk/downloads","issues_url":"https://api.github.com/repos/krig/hawk/issues{/number}","pulls_url":"https://api.github.com/repos/krig/hawk/pulls{/number}","milestones_url":"https://api.github.com/repos/krig/hawk/milestones{/number}","notifications_url":"https://api.github.com/repos/krig/hawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krig/hawk/labels{/name}","releases_url":"https://api.github.com/repos/krig/hawk/releases{/id}","created_at":"2013-07-17T05:38:56Z","updated_at":"2015-06-29T13:43:57Z","pushed_at":"2015-09-15T17:02:00Z","git_url":"git://github.com/krig/hawk.git","ssh_url":"git@github.com:krig/hawk.git","clone_url":"https://github.com/krig/hawk.git","svn_url":"https://github.com/krig/hawk","homepage":null,"size":13983,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"6b81608ee351a48e3d1863e4daa9c5a81a131132","user":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":4154361,"name":"hawk","full_name":"ClusterLabs/hawk","owner":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/hawk","description":"A web-based GUI for managing and monitoring the Pacemaker High-Availability cluster resource manager","fork":false,"url":"https://api.github.com/repos/ClusterLabs/hawk","forks_url":"https://api.github.com/repos/ClusterLabs/hawk/forks","keys_url":"https://api.github.com/repos/ClusterLabs/hawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/hawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/hawk/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/hawk/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/hawk/events","assignees_url":"https://api.github.com/repos/ClusterLabs/hawk/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/hawk/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/hawk/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/hawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/hawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/hawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/hawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/hawk/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/hawk/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/hawk/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/hawk/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/hawk/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/hawk/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/hawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/hawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/hawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/hawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterLabs/hawk/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/hawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/hawk/merges","archive_url":"https://api.github.com/repos/ClusterLabs/hawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/hawk/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/hawk/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/hawk/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/hawk/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/hawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/hawk/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/hawk/releases{/id}","created_at":"2012-04-27T02:30:01Z","updated_at":"2015-07-08T03:42:19Z","pushed_at":"2015-09-15T17:02:01Z","git_url":"git://github.com/ClusterLabs/hawk.git","ssh_url":"git@github.com:ClusterLabs/hawk.git","clone_url":"https://github.com/ClusterLabs/hawk.git","svn_url":"https://github.com/ClusterLabs/hawk","homepage":null,"size":14722,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46"},"html":{"href":"https://github.com/ClusterLabs/hawk/pull/46"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/hawk/issues/46"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/hawk/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/hawk/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/hawk/statuses/a7ee87ac4b3165efbd97a240990f810fac3c60cf"}}}}