{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/46221298","id":46221298,"diff_hunk":"@@ -0,0 +1,14 @@\n+<network>\n+  <name>kubernetes</name>\n+  <uuid>dcbef342-16a3-4f3e-8307-84bff91076e1</uuid>\n+  <forward mode='nat'/>\n+  <bridge name='virbrk8s' stp='on' delay='0'/>\n+  <mac address='82:84:01:56:df:f3'/>\n+  <ip address='192.168.120.1' netmask='255.255.255.0'>\n+    <dhcp>\n+      <range start='192.168.120.2' end='192.168.120.254'/>\n+      <host mac='54:52:00:fe:b3:b0' name='kube-master' ip='192.168.120.10'/>\n+      <host mac='54:52:00:fe:b3:b1' name='kube-worker' ip='192.168.120.11'/>","path":"multi-node/libvirt/network-kubernetes.xml","position":11,"original_position":11,"commit_id":"7a66f27b9c81b2c368c92d2c767756545878af7c","original_commit_id":"7a66f27b9c81b2c368c92d2c767756545878af7c","user":{"login":"aaronlevy","id":374924,"avatar_url":"https://avatars.githubusercontent.com/u/374924?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlevy","html_url":"https://github.com/aaronlevy","followers_url":"https://api.github.com/users/aaronlevy/followers","following_url":"https://api.github.com/users/aaronlevy/following{/other_user}","gists_url":"https://api.github.com/users/aaronlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlevy/subscriptions","organizations_url":"https://api.github.com/users/aaronlevy/orgs","repos_url":"https://api.github.com/users/aaronlevy/repos","events_url":"https://api.github.com/users/aaronlevy/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlevy/received_events","type":"User","site_admin":false},"body":"really minor nit: maybe leave some ip span between masters/workers. In the case of multi-master / multi-worker clusters it makes it easier to immediately see the roles from a network perspective. But this may just be my laziness...","created_at":"2015-11-30T23:39:48Z","updated_at":"2015-11-30T23:39:48Z","html_url":"https://github.com/coreos/coreos-kubernetes/pull/173#discussion_r46221298","pull_request_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/46221298"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/173#discussion_r46221298"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173","id":52187095,"html_url":"https://github.com/coreos/coreos-kubernetes/pull/173","diff_url":"https://github.com/coreos/coreos-kubernetes/pull/173.diff","patch_url":"https://github.com/coreos/coreos-kubernetes/pull/173.patch","issue_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/173","number":173,"state":"open","locked":false,"title":"multi-node setup example using libvirt","user":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"body":"Demonstrates a basic multi-node Kubernetes setup on CoreOS using libvirt. Cluster consists of a master and a single worker node.","created_at":"2015-11-30T22:15:30Z","updated_at":"2015-11-30T23:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70f4e5386a252647fbea20537e3f9edc761c88ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/173/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/7a66f27b9c81b2c368c92d2c767756545878af7c","head":{"label":"gtank:libvirt","ref":"libvirt","sha":"7a66f27b9c81b2c368c92d2c767756545878af7c","user":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"repo":{"id":45578034,"name":"coreos-kubernetes","full_name":"gtank/coreos-kubernetes","owner":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtank/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":true,"url":"https://api.github.com/repos/gtank/coreos-kubernetes","forks_url":"https://api.github.com/repos/gtank/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/gtank/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtank/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtank/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/gtank/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gtank/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gtank/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/gtank/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gtank/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gtank/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/gtank/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtank/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtank/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtank/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtank/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gtank/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/gtank/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gtank/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gtank/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gtank/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/gtank/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtank/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtank/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtank/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtank/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gtank/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtank/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/gtank/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtank/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/gtank/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gtank/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gtank/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gtank/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtank/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gtank/coreos-kubernetes/releases{/id}","created_at":"2015-11-05T01:04:44Z","updated_at":"2015-11-05T01:04:44Z","pushed_at":"2015-11-30T22:10:19Z","git_url":"git://github.com/gtank/coreos-kubernetes.git","ssh_url":"git@github.com:gtank/coreos-kubernetes.git","clone_url":"https://github.com/gtank/coreos-kubernetes.git","svn_url":"https://github.com/gtank/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":701,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"4d400c5f3f9fd5a93ae19c7f7cc6b4345227b96e","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":41458519,"name":"coreos-kubernetes","full_name":"coreos/coreos-kubernetes","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":false,"url":"https://api.github.com/repos/coreos/coreos-kubernetes","forks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/coreos/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/coreos/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-kubernetes/releases{/id}","created_at":"2015-08-27T01:25:24Z","updated_at":"2015-11-30T20:25:32Z","pushed_at":"2015-11-30T22:15:30Z","git_url":"git://github.com/coreos/coreos-kubernetes.git","ssh_url":"git@github.com:coreos/coreos-kubernetes.git","clone_url":"https://github.com/coreos/coreos-kubernetes.git","svn_url":"https://github.com/coreos/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":750,"stargazers_count":143,"watchers_count":143,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":53,"forks":69,"open_issues":53,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/173"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/173"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/7a66f27b9c81b2c368c92d2c767756545878af7c"}}}}