{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/aurelia/http-client/pulls/42","id":34822442,"html_url":"https://github.com/aurelia/http-client/pull/42","diff_url":"https://github.com/aurelia/http-client/pull/42.diff","patch_url":"https://github.com/aurelia/http-client/pull/42.patch","issue_url":"https://api.github.com/repos/aurelia/http-client/issues/42","number":42,"state":"closed","locked":false,"title":"aurelia-http-client doesn't work in IE9","user":{"login":"Andreas-Hjortland","id":2162904,"avatar_url":"https://avatars.githubusercontent.com/u/2162904?v=3","gravatar_id":"","url":"https://api.github.com/users/Andreas-Hjortland","html_url":"https://github.com/Andreas-Hjortland","followers_url":"https://api.github.com/users/Andreas-Hjortland/followers","following_url":"https://api.github.com/users/Andreas-Hjortland/following{/other_user}","gists_url":"https://api.github.com/users/Andreas-Hjortland/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreas-Hjortland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreas-Hjortland/subscriptions","organizations_url":"https://api.github.com/users/Andreas-Hjortland/orgs","repos_url":"https://api.github.com/users/Andreas-Hjortland/repos","events_url":"https://api.github.com/users/Andreas-Hjortland/events{/privacy}","received_events_url":"https://api.github.com/users/Andreas-Hjortland/received_events","type":"User","site_admin":false},"body":"When you try to use the http-client to load some data in IE9 it will return undefined for response.content since the response.content property is based on XmlHttpRequest.response\r\n\r\nThis pull request will fix the issue by using the XmlHttpRequest.responseText if XmlHttpRequest.response is not available.\r\n\r\nI have checked out the skeleton navigation and made a changed the welcome controller to load the user from json instead of using the provided values. In IE9 the one which uses http-client from the current master branch will fail to load the welcome view.\r\n * Will not work in IE9: http://hjortland.org/files/test/aurelia/skeleton-navigation/#/\r\n * Works in IE9: http://hjortland.org/files/test/aurelia/skeleton-navigation2/#/\r\n\r\nUnfortunately I don't have any tests for this issue as I am not sure how we can test for this other than to add IE9 as a browser which we should run tests against.","created_at":"2015-05-06T14:30:53Z","updated_at":"2015-05-08T15:25:35Z","closed_at":"2015-05-08T15:25:35Z","merged_at":"2015-05-08T15:25:35Z","merge_commit_sha":"30e6435120467b7777c06c8dd883f0b2e680e1a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/http-client/pulls/42/commits","review_comments_url":"https://api.github.com/repos/aurelia/http-client/pulls/42/comments","review_comment_url":"https://api.github.com/repos/aurelia/http-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/http-client/issues/42/comments","statuses_url":"https://api.github.com/repos/aurelia/http-client/statuses/34f06048a3bbf075fd7fd213fae29e72eb30ce23","head":{"label":"Andreas-Hjortland:master","ref":"master","sha":"34f06048a3bbf075fd7fd213fae29e72eb30ce23","user":{"login":"Andreas-Hjortland","id":2162904,"avatar_url":"https://avatars.githubusercontent.com/u/2162904?v=3","gravatar_id":"","url":"https://api.github.com/users/Andreas-Hjortland","html_url":"https://github.com/Andreas-Hjortland","followers_url":"https://api.github.com/users/Andreas-Hjortland/followers","following_url":"https://api.github.com/users/Andreas-Hjortland/following{/other_user}","gists_url":"https://api.github.com/users/Andreas-Hjortland/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreas-Hjortland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreas-Hjortland/subscriptions","organizations_url":"https://api.github.com/users/Andreas-Hjortland/orgs","repos_url":"https://api.github.com/users/Andreas-Hjortland/repos","events_url":"https://api.github.com/users/Andreas-Hjortland/events{/privacy}","received_events_url":"https://api.github.com/users/Andreas-Hjortland/received_events","type":"User","site_admin":false},"repo":{"id":35160861,"name":"http-client","full_name":"Andreas-Hjortland/http-client","owner":{"login":"Andreas-Hjortland","id":2162904,"avatar_url":"https://avatars.githubusercontent.com/u/2162904?v=3","gravatar_id":"","url":"https://api.github.com/users/Andreas-Hjortland","html_url":"https://github.com/Andreas-Hjortland","followers_url":"https://api.github.com/users/Andreas-Hjortland/followers","following_url":"https://api.github.com/users/Andreas-Hjortland/following{/other_user}","gists_url":"https://api.github.com/users/Andreas-Hjortland/gists{/gist_id}","starred_url":"https://api.github.com/users/Andreas-Hjortland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andreas-Hjortland/subscriptions","organizations_url":"https://api.github.com/users/Andreas-Hjortland/orgs","repos_url":"https://api.github.com/users/Andreas-Hjortland/repos","events_url":"https://api.github.com/users/Andreas-Hjortland/events{/privacy}","received_events_url":"https://api.github.com/users/Andreas-Hjortland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andreas-Hjortland/http-client","description":"A simple, restful, message-based wrapper around XMLHttpRequest.","fork":true,"url":"https://api.github.com/repos/Andreas-Hjortland/http-client","forks_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/forks","keys_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/teams","hooks_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/hooks","issue_events_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/issues/events{/number}","events_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/events","assignees_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/assignees{/user}","branches_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/branches{/branch}","tags_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/tags","blobs_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/languages","stargazers_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/stargazers","contributors_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/contributors","subscribers_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/subscribers","subscription_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/subscription","commits_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/contents/{+path}","compare_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/merges","archive_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/downloads","issues_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/issues{/number}","pulls_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/labels{/name}","releases_url":"https://api.github.com/repos/Andreas-Hjortland/http-client/releases{/id}","created_at":"2015-05-06T13:42:12Z","updated_at":"2015-05-06T14:17:21Z","pushed_at":"2015-05-06T14:17:21Z","git_url":"git://github.com/Andreas-Hjortland/http-client.git","ssh_url":"git@github.com:Andreas-Hjortland/http-client.git","clone_url":"https://github.com/Andreas-Hjortland/http-client.git","svn_url":"https://github.com/Andreas-Hjortland/http-client","homepage":null,"size":780,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"eb81eb62c6282efbcea71cc537ba5284c5c94d45","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27786488,"name":"http-client","full_name":"aurelia/http-client","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/http-client","description":"A simple, restful, message-based wrapper around XMLHttpRequest.","fork":false,"url":"https://api.github.com/repos/aurelia/http-client","forks_url":"https://api.github.com/repos/aurelia/http-client/forks","keys_url":"https://api.github.com/repos/aurelia/http-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/http-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/http-client/teams","hooks_url":"https://api.github.com/repos/aurelia/http-client/hooks","issue_events_url":"https://api.github.com/repos/aurelia/http-client/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/http-client/events","assignees_url":"https://api.github.com/repos/aurelia/http-client/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/http-client/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/http-client/tags","blobs_url":"https://api.github.com/repos/aurelia/http-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/http-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/http-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/http-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/http-client/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/http-client/languages","stargazers_url":"https://api.github.com/repos/aurelia/http-client/stargazers","contributors_url":"https://api.github.com/repos/aurelia/http-client/contributors","subscribers_url":"https://api.github.com/repos/aurelia/http-client/subscribers","subscription_url":"https://api.github.com/repos/aurelia/http-client/subscription","commits_url":"https://api.github.com/repos/aurelia/http-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/http-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/http-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/http-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/http-client/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/http-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/http-client/merges","archive_url":"https://api.github.com/repos/aurelia/http-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/http-client/downloads","issues_url":"https://api.github.com/repos/aurelia/http-client/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/http-client/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/http-client/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/http-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/http-client/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/http-client/releases{/id}","created_at":"2014-12-09T20:51:59Z","updated_at":"2015-05-08T15:25:35Z","pushed_at":"2015-05-08T15:25:35Z","git_url":"git://github.com/aurelia/http-client.git","ssh_url":"git@github.com:aurelia/http-client.git","clone_url":"https://github.com/aurelia/http-client.git","svn_url":"https://github.com/aurelia/http-client","homepage":null,"size":780,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/http-client/pulls/42"},"html":{"href":"https://github.com/aurelia/http-client/pull/42"},"issue":{"href":"https://api.github.com/repos/aurelia/http-client/issues/42"},"comments":{"href":"https://api.github.com/repos/aurelia/http-client/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/http-client/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/http-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/http-client/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/http-client/statuses/34f06048a3bbf075fd7fd213fae29e72eb30ce23"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"EisenbergEffect","id":131485,"avatar_url":"https://avatars.githubusercontent.com/u/131485?v=3","gravatar_id":"","url":"https://api.github.com/users/EisenbergEffect","html_url":"https://github.com/EisenbergEffect","followers_url":"https://api.github.com/users/EisenbergEffect/followers","following_url":"https://api.github.com/users/EisenbergEffect/following{/other_user}","gists_url":"https://api.github.com/users/EisenbergEffect/gists{/gist_id}","starred_url":"https://api.github.com/users/EisenbergEffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EisenbergEffect/subscriptions","organizations_url":"https://api.github.com/users/EisenbergEffect/orgs","repos_url":"https://api.github.com/users/EisenbergEffect/repos","events_url":"https://api.github.com/users/EisenbergEffect/events{/privacy}","received_events_url":"https://api.github.com/users/EisenbergEffect/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":110,"deletions":110,"changed_files":24}}