{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/scalding/pulls/comments/31856999","id":31856999,"diff_hunk":"@@ -60,6 +60,7 @@ abstract class TimePathedLongThriftSequenceFile[V <: TBase[_, _]: Manifest](f: F\n   with WritableSequenceFileScheme\n   with Serializable\n   with Mappable[(Long, V)]\n+  with TypedSink[(Long, V)]","path":"scalding-commons/src/main/scala/com/twitter/scalding/commons/source/DailySources.scala","position":4,"original_position":4,"commit_id":"8d53ab23e76d109b3892e097ab542a005e15c7d4","original_commit_id":"8d53ab23e76d109b3892e097ab542a005e15c7d4","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"I think we need to override `override def sinkFields = f` and `override setter[...]` with the subsetter of `TupleSetter.of[(Long, V)]`\r\n\r\nAnd also below.\r\n\r\nMight be good to run a quick job (even using local HDFS), to see if it works.","created_at":"2015-06-05T22:27:08Z","updated_at":"2015-06-05T22:27:08Z","html_url":"https://github.com/twitter/scalding/pull/1313#discussion_r31856999","pull_request_url":"https://api.github.com/repos/twitter/scalding/pulls/1313","_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments/31856999"},"html":{"href":"https://github.com/twitter/scalding/pull/1313#discussion_r31856999"},"pull_request":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1313"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/scalding/pulls/1313","id":37075313,"html_url":"https://github.com/twitter/scalding/pull/1313","diff_url":"https://github.com/twitter/scalding/pull/1313.diff","patch_url":"https://github.com/twitter/scalding/pull/1313.patch","issue_url":"https://api.github.com/repos/twitter/scalding/issues/1313","number":1313,"state":"open","locked":false,"title":"make LongThrift sources TypedSink","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/twitter/scalding/issues/1312","created_at":"2015-06-05T22:21:21Z","updated_at":"2015-06-05T22:27:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be0fc2b5a079788b219a1bac93719a40c518397b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/scalding/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/twitter/scalding/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/scalding/issues/1313/comments","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/8d53ab23e76d109b3892e097ab542a005e15c7d4","head":{"label":"rubanm:commons_typedsink","ref":"commons_typedsink","sha":"8d53ab23e76d109b3892e097ab542a005e15c7d4","user":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"repo":{"id":12451817,"name":"scalding","full_name":"rubanm/scalding","owner":{"login":"rubanm","id":2401144,"avatar_url":"https://avatars.githubusercontent.com/u/2401144?v=3","gravatar_id":"","url":"https://api.github.com/users/rubanm","html_url":"https://github.com/rubanm","followers_url":"https://api.github.com/users/rubanm/followers","following_url":"https://api.github.com/users/rubanm/following{/other_user}","gists_url":"https://api.github.com/users/rubanm/gists{/gist_id}","starred_url":"https://api.github.com/users/rubanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubanm/subscriptions","organizations_url":"https://api.github.com/users/rubanm/orgs","repos_url":"https://api.github.com/users/rubanm/repos","events_url":"https://api.github.com/users/rubanm/events{/privacy}","received_events_url":"https://api.github.com/users/rubanm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubanm/scalding","description":"A Scala API for Cascading","fork":true,"url":"https://api.github.com/repos/rubanm/scalding","forks_url":"https://api.github.com/repos/rubanm/scalding/forks","keys_url":"https://api.github.com/repos/rubanm/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubanm/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubanm/scalding/teams","hooks_url":"https://api.github.com/repos/rubanm/scalding/hooks","issue_events_url":"https://api.github.com/repos/rubanm/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/rubanm/scalding/events","assignees_url":"https://api.github.com/repos/rubanm/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/rubanm/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/rubanm/scalding/tags","blobs_url":"https://api.github.com/repos/rubanm/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubanm/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubanm/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubanm/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubanm/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/rubanm/scalding/languages","stargazers_url":"https://api.github.com/repos/rubanm/scalding/stargazers","contributors_url":"https://api.github.com/repos/rubanm/scalding/contributors","subscribers_url":"https://api.github.com/repos/rubanm/scalding/subscribers","subscription_url":"https://api.github.com/repos/rubanm/scalding/subscription","commits_url":"https://api.github.com/repos/rubanm/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubanm/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubanm/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubanm/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubanm/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/rubanm/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubanm/scalding/merges","archive_url":"https://api.github.com/repos/rubanm/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubanm/scalding/downloads","issues_url":"https://api.github.com/repos/rubanm/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/rubanm/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/rubanm/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/rubanm/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubanm/scalding/labels{/name}","releases_url":"https://api.github.com/repos/rubanm/scalding/releases{/id}","created_at":"2013-08-29T04:56:06Z","updated_at":"2015-05-04T21:27:45Z","pushed_at":"2015-06-05T22:20:15Z","git_url":"git://github.com/rubanm/scalding.git","ssh_url":"git@github.com:rubanm/scalding.git","clone_url":"https://github.com/rubanm/scalding.git","svn_url":"https://github.com/rubanm/scalding","homepage":"http://twitter.com/scalding","size":8357,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"6d971bf24e78c28a12f457cd1b35d8341b7c3397","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3146558,"name":"scalding","full_name":"twitter/scalding","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scalding","description":"A Scala API for Cascading","fork":false,"url":"https://api.github.com/repos/twitter/scalding","forks_url":"https://api.github.com/repos/twitter/scalding/forks","keys_url":"https://api.github.com/repos/twitter/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scalding/teams","hooks_url":"https://api.github.com/repos/twitter/scalding/hooks","issue_events_url":"https://api.github.com/repos/twitter/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scalding/events","assignees_url":"https://api.github.com/repos/twitter/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scalding/tags","blobs_url":"https://api.github.com/repos/twitter/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scalding/languages","stargazers_url":"https://api.github.com/repos/twitter/scalding/stargazers","contributors_url":"https://api.github.com/repos/twitter/scalding/contributors","subscribers_url":"https://api.github.com/repos/twitter/scalding/subscribers","subscription_url":"https://api.github.com/repos/twitter/scalding/subscription","commits_url":"https://api.github.com/repos/twitter/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scalding/merges","archive_url":"https://api.github.com/repos/twitter/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scalding/downloads","issues_url":"https://api.github.com/repos/twitter/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scalding/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scalding/releases{/id}","created_at":"2012-01-10T16:22:08Z","updated_at":"2015-06-05T18:43:16Z","pushed_at":"2015-06-05T22:21:22Z","git_url":"git://github.com/twitter/scalding.git","ssh_url":"git@github.com:twitter/scalding.git","clone_url":"https://github.com/twitter/scalding.git","svn_url":"https://github.com/twitter/scalding","homepage":"http://twitter.com/scalding","size":23837,"stargazers_count":2102,"watchers_count":2102,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":476,"mirror_url":null,"open_issues_count":227,"forks":476,"open_issues":227,"watchers":2102,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1313"},"html":{"href":"https://github.com/twitter/scalding/pull/1313"},"issue":{"href":"https://api.github.com/repos/twitter/scalding/issues/1313"},"comments":{"href":"https://api.github.com/repos/twitter/scalding/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/scalding/statuses/8d53ab23e76d109b3892e097ab542a005e15c7d4"}}}}