{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/32882327","id":32882327,"diff_hunk":"@@ -442,12 +448,32 @@ def plot_flat_source_regions(geometry, gridsize=250, xlim=None, ylim=None):\n \n   if not is_integer(gridsize):\n     py_printf('ERROR', 'Unable to plot the flat source regions since ' + \\\n-              'since the gridsize %d is not an integer', gridsize)\n+              'the gridsize %d is not an integer', gridsize)\n \n   if gridsize <= 0:\n     py_printf('ERROR', 'Unable to plot the flat source regions ' + \\\n               'with a negative gridsize (%d)', gridsize)\n \n+  if not isinstance(centroids, bool):\n+    py_printf('ERROR', 'Unable to plot the flat source regions since ' + \\\n+              'centroids is not a boolean')\n+\n+  if not isinstance(marker_type, str):\n+    py_printf('ERROR', 'Unable to plot the flat source regions since ' + \\\n+              'marker_type is a string')\n+\n+  if marker_type not in matplotlib.markers.MarkerStyle().markers.keys():\n+    py_printf('ERROR', 'Unable to plot the flat source regions since ' + \\\n+              'marker_type is not a valid marker (%d)', marker_type)\n+\n+  if not is_float(marker_size) and not is_integer(marker_size):\n+    py_printf('ERROR', 'Unable to plot the flat source regions since ' + \\","path":"openmoc/plotter.py","position":46,"original_position":46,"commit_id":"f1a684bc7708ff16bcb0faaf8054464583e1f402","original_commit_id":"f1a684bc7708ff16bcb0faaf8054464583e1f402","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"The markersize in Matplotlib is a float, but I think the user should have the option to input it as an int since this is how I have most commonly seen it. ","created_at":"2015-06-20T05:15:50Z","updated_at":"2015-06-20T05:15:50Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/144#discussion_r32882327","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/32882327"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/144#discussion_r32882327"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144","id":34521077,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/144","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/144.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/144.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/144","number":144,"state":"open","locked":false,"title":"Generate FSR numerical centroids","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This PR implements the generation of the numerical centroids of the flat source regions. The numerical centroids will be useful in extending OpenMOC to accommodate linear source regions using the methodology implemented in CASMO 5 and published by Rodolfo Ferrer. The formula for computing the centroids was taken from Ferrer's 2012 PHYSOR paper \"Linear Source Approximation in CASMO 5\". Additionally, the centroids could be useful in implementing strategies to stabilize or accelerate the CMFD acceleration process.\r\n\r\nA plotting routine has been added to plot the centroids over the FSRs using the command:\r\n\r\n`plotter.plot_centroids(geometry)`\r\n\r\nBelow is an example of the centroids plot for `simple-lattice.py`:\r\n\r\n![centroids](https://cloud.githubusercontent.com/assets/1244537/7426534/4bd9ec14-ef95-11e4-925b-54fc6fc68696.png)\r\n\r\nThis PR builds on PR #134 and should not be merged until (at least) PR #134 has been merged.  ","created_at":"2015-05-01T04:38:43Z","updated_at":"2015-06-20T05:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b23e7e88675cc523dcabc545b282bf3d18bc13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/144/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/f1a684bc7708ff16bcb0faaf8054464583e1f402","head":{"label":"samuelshaner:centroid","ref":"centroid","sha":"f1a684bc7708ff16bcb0faaf8054464583e1f402","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":17918430,"name":"OpenMOC","full_name":"samuelshaner/OpenMOC","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/samuelshaner/OpenMOC","forks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/forks","keys_url":"https://api.github.com/repos/samuelshaner/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/OpenMOC/teams","hooks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/events","assignees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/tags","blobs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscription","commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/OpenMOC/merges","archive_url":"https://api.github.com/repos/samuelshaner/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/OpenMOC/downloads","issues_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/OpenMOC/releases{/id}","created_at":"2014-03-19T20:03:02Z","updated_at":"2014-03-19T20:03:02Z","pushed_at":"2015-06-18T19:59:17Z","git_url":"git://github.com/samuelshaner/OpenMOC.git","ssh_url":"git@github.com:samuelshaner/OpenMOC.git","clone_url":"https://github.com/samuelshaner/OpenMOC.git","svn_url":"https://github.com/samuelshaner/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":73724,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"118d5316125181a46bb9eee46d9e4207b7c82274","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","created_at":"2013-03-14T17:19:26Z","updated_at":"2015-06-03T01:42:03Z","pushed_at":"2015-06-19T16:07:53Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":111030,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":25,"forks":18,"open_issues":25,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/144"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/144"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/f1a684bc7708ff16bcb0faaf8054464583e1f402"}}}}