{"action":"closed","issue":{"url":"https://api.github.com/repos/Emergya/peer/issues/32","labels_url":"https://api.github.com/repos/Emergya/peer/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/Emergya/peer/issues/32/comments","events_url":"https://api.github.com/repos/Emergya/peer/issues/32/events","html_url":"https://github.com/Emergya/peer/issues/32","id":19494224,"number":32,"title":"endpoint-in-domain validation improvment","user":{"login":"rhoerbe","id":4348479,"avatar_url":"https://avatars.githubusercontent.com/u/4348479?v=3","gravatar_id":"","url":"https://api.github.com/users/rhoerbe","html_url":"https://github.com/rhoerbe","followers_url":"https://api.github.com/users/rhoerbe/followers","following_url":"https://api.github.com/users/rhoerbe/following{/other_user}","gists_url":"https://api.github.com/users/rhoerbe/gists{/gist_id}","starred_url":"https://api.github.com/users/rhoerbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhoerbe/subscriptions","organizations_url":"https://api.github.com/users/rhoerbe/orgs","repos_url":"https://api.github.com/users/rhoerbe/repos","events_url":"https://api.github.com/users/rhoerbe/events{/privacy}","received_events_url":"https://api.github.com/users/rhoerbe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Emergya/peer/labels/whishlist","name":"whishlist","color":"02d7e1"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2013-09-14T10:02:21Z","updated_at":"2015-10-07T10:34:49Z","closed_at":"2015-10-07T10:34:49Z","body":"Uploading and EntityDescriptor results in this error message:\r\n\r\n    The endpoint at https://testshib.portalverbund.at:8443/idp/profile/SAML2/SOAP/ArtifactResolution does not belong to the domain portalverbund.at\r\n\r\nbut it should read:\r\n\r\n    \"The FQHN of endpoint https://testshib.portalverbund.at:8443/idp/profile/SAML2/SOAP/ArtifactResolution is not equal to the domain portalverbund.at\"\r\n\r\nI think that it would make fore sense require the endpoint address to be part of the domain instead, so host.example.com must be in example.com. To achieve this, entity/validation.py from line 100 on should be changed to:\r\n\r\n            if not url.hostname.lower().endswith(domain.lower()):\r\n                errors.append(\r\n                    u'The FQHN of endpoint %s is not in the domain %s' %\r\n                    (endpoint['Location'], domain))\r\n\r\n"}}