{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/scalingdata/goavro/pulls/2","id":39396770,"html_url":"https://github.com/scalingdata/goavro/pull/2","diff_url":"https://github.com/scalingdata/goavro/pull/2.diff","patch_url":"https://github.com/scalingdata/goavro/pull/2.patch","issue_url":"https://api.github.com/repos/scalingdata/goavro/issues/2","number":2,"state":"closed","locked":false,"title":"ROCANA-2463 Upgrade Writer to StringWriter and ByteWriter","user":{"login":"alanctgardner","id":3100188,"avatar_url":"https://avatars.githubusercontent.com/u/3100188?v=3","gravatar_id":"","url":"https://api.github.com/users/alanctgardner","html_url":"https://github.com/alanctgardner","followers_url":"https://api.github.com/users/alanctgardner/followers","following_url":"https://api.github.com/users/alanctgardner/following{/other_user}","gists_url":"https://api.github.com/users/alanctgardner/gists{/gist_id}","starred_url":"https://api.github.com/users/alanctgardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanctgardner/subscriptions","organizations_url":"https://api.github.com/users/alanctgardner/orgs","repos_url":"https://api.github.com/users/alanctgardner/repos","events_url":"https://api.github.com/users/alanctgardner/events{/privacy}","received_events_url":"https://api.github.com/users/alanctgardner/received_events","type":"User","site_admin":false},"body":"Calling WriteByte() or WriteString() when possible avoids allocating an exra byte buffer and a memcpy for each assignment. \r\n\r\nThe PR is pretty big because we have to test both pathways: upgraded and using Write(). I've included a test Writer that can't be upgraded, and we run through every test case with both.","created_at":"2015-07-07T17:42:25Z","updated_at":"2015-07-09T16:20:18Z","closed_at":"2015-07-09T16:20:18Z","merged_at":"2015-07-09T16:20:18Z","merge_commit_sha":"42575f34c2221ffe69a6eacc92f5864a7b1182df","assignee":{"login":"bretthoerner","id":1752,"avatar_url":"https://avatars.githubusercontent.com/u/1752?v=3","gravatar_id":"","url":"https://api.github.com/users/bretthoerner","html_url":"https://github.com/bretthoerner","followers_url":"https://api.github.com/users/bretthoerner/followers","following_url":"https://api.github.com/users/bretthoerner/following{/other_user}","gists_url":"https://api.github.com/users/bretthoerner/gists{/gist_id}","starred_url":"https://api.github.com/users/bretthoerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretthoerner/subscriptions","organizations_url":"https://api.github.com/users/bretthoerner/orgs","repos_url":"https://api.github.com/users/bretthoerner/repos","events_url":"https://api.github.com/users/bretthoerner/events{/privacy}","received_events_url":"https://api.github.com/users/bretthoerner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/scalingdata/goavro/pulls/2/commits","review_comments_url":"https://api.github.com/repos/scalingdata/goavro/pulls/2/comments","review_comment_url":"https://api.github.com/repos/scalingdata/goavro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalingdata/goavro/issues/2/comments","statuses_url":"https://api.github.com/repos/scalingdata/goavro/statuses/1f8f1e4c97a7d33e994a78c930894130670ecc7a","head":{"label":"scalingdata:ROCANA-2463","ref":"ROCANA-2463","sha":"1f8f1e4c97a7d33e994a78c930894130670ecc7a","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":33267101,"name":"goavro","full_name":"scalingdata/goavro","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/goavro","description":"","fork":true,"url":"https://api.github.com/repos/scalingdata/goavro","forks_url":"https://api.github.com/repos/scalingdata/goavro/forks","keys_url":"https://api.github.com/repos/scalingdata/goavro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/goavro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/goavro/teams","hooks_url":"https://api.github.com/repos/scalingdata/goavro/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/goavro/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/goavro/events","assignees_url":"https://api.github.com/repos/scalingdata/goavro/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/goavro/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/goavro/tags","blobs_url":"https://api.github.com/repos/scalingdata/goavro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/goavro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/goavro/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/goavro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/goavro/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/goavro/languages","stargazers_url":"https://api.github.com/repos/scalingdata/goavro/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/goavro/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/goavro/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/goavro/subscription","commits_url":"https://api.github.com/repos/scalingdata/goavro/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/goavro/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/goavro/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/goavro/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/goavro/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/goavro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/goavro/merges","archive_url":"https://api.github.com/repos/scalingdata/goavro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/goavro/downloads","issues_url":"https://api.github.com/repos/scalingdata/goavro/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/goavro/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/goavro/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/goavro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/goavro/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/goavro/releases{/id}","created_at":"2015-04-01T19:09:31Z","updated_at":"2015-04-01T19:59:22Z","pushed_at":"2015-07-09T16:20:18Z","git_url":"git://github.com/scalingdata/goavro.git","ssh_url":"git@github.com:scalingdata/goavro.git","clone_url":"https://github.com/scalingdata/goavro.git","svn_url":"https://github.com/scalingdata/goavro","homepage":"","size":303,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalingdata:master","ref":"master","sha":"555dfb41e9ba89a4e6547ef43571b289dcead686","user":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"repo":{"id":33267101,"name":"goavro","full_name":"scalingdata/goavro","owner":{"login":"scalingdata","id":6448302,"avatar_url":"https://avatars.githubusercontent.com/u/6448302?v=3","gravatar_id":"","url":"https://api.github.com/users/scalingdata","html_url":"https://github.com/scalingdata","followers_url":"https://api.github.com/users/scalingdata/followers","following_url":"https://api.github.com/users/scalingdata/following{/other_user}","gists_url":"https://api.github.com/users/scalingdata/gists{/gist_id}","starred_url":"https://api.github.com/users/scalingdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalingdata/subscriptions","organizations_url":"https://api.github.com/users/scalingdata/orgs","repos_url":"https://api.github.com/users/scalingdata/repos","events_url":"https://api.github.com/users/scalingdata/events{/privacy}","received_events_url":"https://api.github.com/users/scalingdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalingdata/goavro","description":"","fork":true,"url":"https://api.github.com/repos/scalingdata/goavro","forks_url":"https://api.github.com/repos/scalingdata/goavro/forks","keys_url":"https://api.github.com/repos/scalingdata/goavro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalingdata/goavro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalingdata/goavro/teams","hooks_url":"https://api.github.com/repos/scalingdata/goavro/hooks","issue_events_url":"https://api.github.com/repos/scalingdata/goavro/issues/events{/number}","events_url":"https://api.github.com/repos/scalingdata/goavro/events","assignees_url":"https://api.github.com/repos/scalingdata/goavro/assignees{/user}","branches_url":"https://api.github.com/repos/scalingdata/goavro/branches{/branch}","tags_url":"https://api.github.com/repos/scalingdata/goavro/tags","blobs_url":"https://api.github.com/repos/scalingdata/goavro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalingdata/goavro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalingdata/goavro/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalingdata/goavro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalingdata/goavro/statuses/{sha}","languages_url":"https://api.github.com/repos/scalingdata/goavro/languages","stargazers_url":"https://api.github.com/repos/scalingdata/goavro/stargazers","contributors_url":"https://api.github.com/repos/scalingdata/goavro/contributors","subscribers_url":"https://api.github.com/repos/scalingdata/goavro/subscribers","subscription_url":"https://api.github.com/repos/scalingdata/goavro/subscription","commits_url":"https://api.github.com/repos/scalingdata/goavro/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalingdata/goavro/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalingdata/goavro/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalingdata/goavro/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalingdata/goavro/contents/{+path}","compare_url":"https://api.github.com/repos/scalingdata/goavro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalingdata/goavro/merges","archive_url":"https://api.github.com/repos/scalingdata/goavro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalingdata/goavro/downloads","issues_url":"https://api.github.com/repos/scalingdata/goavro/issues{/number}","pulls_url":"https://api.github.com/repos/scalingdata/goavro/pulls{/number}","milestones_url":"https://api.github.com/repos/scalingdata/goavro/milestones{/number}","notifications_url":"https://api.github.com/repos/scalingdata/goavro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalingdata/goavro/labels{/name}","releases_url":"https://api.github.com/repos/scalingdata/goavro/releases{/id}","created_at":"2015-04-01T19:09:31Z","updated_at":"2015-04-01T19:59:22Z","pushed_at":"2015-07-09T16:20:18Z","git_url":"git://github.com/scalingdata/goavro.git","ssh_url":"git@github.com:scalingdata/goavro.git","clone_url":"https://github.com/scalingdata/goavro.git","svn_url":"https://github.com/scalingdata/goavro","homepage":"","size":303,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalingdata/goavro/pulls/2"},"html":{"href":"https://github.com/scalingdata/goavro/pull/2"},"issue":{"href":"https://api.github.com/repos/scalingdata/goavro/issues/2"},"comments":{"href":"https://api.github.com/repos/scalingdata/goavro/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/scalingdata/goavro/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/scalingdata/goavro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalingdata/goavro/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/scalingdata/goavro/statuses/1f8f1e4c97a7d33e994a78c930894130670ecc7a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alanctgardner","id":3100188,"avatar_url":"https://avatars.githubusercontent.com/u/3100188?v=3","gravatar_id":"","url":"https://api.github.com/users/alanctgardner","html_url":"https://github.com/alanctgardner","followers_url":"https://api.github.com/users/alanctgardner/followers","following_url":"https://api.github.com/users/alanctgardner/following{/other_user}","gists_url":"https://api.github.com/users/alanctgardner/gists{/gist_id}","starred_url":"https://api.github.com/users/alanctgardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanctgardner/subscriptions","organizations_url":"https://api.github.com/users/alanctgardner/orgs","repos_url":"https://api.github.com/users/alanctgardner/repos","events_url":"https://api.github.com/users/alanctgardner/events{/privacy}","received_events_url":"https://api.github.com/users/alanctgardner/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":453,"deletions":160,"changed_files":3}}