{"action":"closed","issue":{"url":"https://api.github.com/repos/pineconellc/angular-foundation/issues/242","labels_url":"https://api.github.com/repos/pineconellc/angular-foundation/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/pineconellc/angular-foundation/issues/242/comments","events_url":"https://api.github.com/repos/pineconellc/angular-foundation/issues/242/events","html_url":"https://github.com/pineconellc/angular-foundation/issues/242","id":92498096,"number":242,"title":"alert always \"closeable\" due to angularjs change","user":{"login":"dbartholomae","id":3396992,"avatar_url":"https://avatars.githubusercontent.com/u/3396992?v=3","gravatar_id":"","url":"https://api.github.com/users/dbartholomae","html_url":"https://github.com/dbartholomae","followers_url":"https://api.github.com/users/dbartholomae/followers","following_url":"https://api.github.com/users/dbartholomae/following{/other_user}","gists_url":"https://api.github.com/users/dbartholomae/gists{/gist_id}","starred_url":"https://api.github.com/users/dbartholomae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbartholomae/subscriptions","organizations_url":"https://api.github.com/users/dbartholomae/orgs","repos_url":"https://api.github.com/users/dbartholomae/repos","events_url":"https://api.github.com/users/dbartholomae/events{/privacy}","received_events_url":"https://api.github.com/users/dbartholomae/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jbrowning","id":123726,"avatar_url":"https://avatars.githubusercontent.com/u/123726?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrowning","html_url":"https://github.com/jbrowning","followers_url":"https://api.github.com/users/jbrowning/followers","following_url":"https://api.github.com/users/jbrowning/following{/other_user}","gists_url":"https://api.github.com/users/jbrowning/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrowning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrowning/subscriptions","organizations_url":"https://api.github.com/users/jbrowning/orgs","repos_url":"https://api.github.com/users/jbrowning/repos","events_url":"https://api.github.com/users/jbrowning/events{/privacy}","received_events_url":"https://api.github.com/users/jbrowning/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-07-01T22:24:28Z","updated_at":"2015-09-24T18:51:04Z","closed_at":"2015-09-24T18:51:04Z","body":"Hi there,\r\n\r\nsince AngularJS 1.4.x alerts will always be closeable (with an x in the upper right corner) as seen in this Plunker:\r\nhttp://plnkr.co/edit/X3xA0WOYpfBWAjtNqnKF\r\n\r\nHere is the AngularJS commit that broke it:\r\nhttps://github.com/angular/angular.js/commit/6a38dbfd3c34c8f9efff503d17eb3cbeb666d422\r\n\r\nAnd this change to the AlertController will fix it and should not break any existing code:\r\n```\r\n.controller('AlertController', ['$scope', '$attrs', function ($scope, $attrs) {\r\n  $scope.closeable = 'close' in $attrs && typeof $attrs.close !== \"undefined\";\r\n}])\r\n```\r\n\r\nShould I create a pull request? :)"}}