{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/28258475","id":28258475,"diff_hunk":"@@ -77,9 +77,19 @@ protected virtual IEnumerable<ModificationCommand> CreateModificationCommands([N\n                     .AddEntry(e));\n         }\n \n-        public abstract IRelationalPropertyExtensions GetPropertyExtensions(IProperty property);\n+        public virtual IRelationalPropertyExtensions GetPropertyExtensions(IProperty property)\n+        {\n+            Check.NotNull(property, nameof(property));\n+\n+            return property.Relational();","path":"src/EntityFramework.Relational/Update/CommandBatchPreparer.cs","position":9,"original_position":9,"commit_id":"2df1f73dabf3542543f7559b7d37e65f7e240402","original_commit_id":"2df1f73dabf3542543f7559b7d37e65f7e240402","user":{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars.githubusercontent.com/u/1430078?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"body":"This seems like it will always result in using the relational annotations and not any provider-specific overrides, so it seems like this is never the correct implementation for any provider and hence should not be a default implemention in this base class.","created_at":"2015-04-13T17:24:02Z","updated_at":"2015-04-13T17:24:02Z","html_url":"https://github.com/aspnet/EntityFramework/pull/2006#discussion_r28258475","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/28258475"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/2006#discussion_r28258475"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006","id":32881460,"html_url":"https://github.com/aspnet/EntityFramework/pull/2006","diff_url":"https://github.com/aspnet/EntityFramework/pull/2006.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/2006.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2006","number":2006,"state":"open","locked":false,"title":"Bring back SQLite (Resolves #1953)","user":{"login":"bricelam","id":1226749,"avatar_url":"https://avatars.githubusercontent.com/u/1226749?v=3","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"body":"It's pretty crippled at the moment. Things like `.Count()` don't work because the provider returns a boxed `long` that we try to cast to an `int`. There also seems to be something wrong with the `LIKE` operator (possibly an encoding issue). Migrations isn't implemented (but `.EnsureCreated()` should more-or-less work). ...just to name a few.","created_at":"2015-04-08T17:11:24Z","updated_at":"2015-04-13T17:24:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1b1e0621095b47101e1268f4d32e3799203e6df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/2006/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/2df1f73dabf3542543f7559b7d37e65f7e240402","head":{"label":"bricelam:sqlite","ref":"sqlite","sha":"2df1f73dabf3542543f7559b7d37e65f7e240402","user":{"login":"bricelam","id":1226749,"avatar_url":"https://avatars.githubusercontent.com/u/1226749?v=3","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"repo":{"id":19745314,"name":"EntityFramework","full_name":"bricelam/EntityFramework","owner":{"login":"bricelam","id":1226749,"avatar_url":"https://avatars.githubusercontent.com/u/1226749?v=3","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bricelam/EntityFramework","description":"My fork for contributing to EntityFramework","fork":true,"url":"https://api.github.com/repos/bricelam/EntityFramework","forks_url":"https://api.github.com/repos/bricelam/EntityFramework/forks","keys_url":"https://api.github.com/repos/bricelam/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bricelam/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bricelam/EntityFramework/teams","hooks_url":"https://api.github.com/repos/bricelam/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/bricelam/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/bricelam/EntityFramework/events","assignees_url":"https://api.github.com/repos/bricelam/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/bricelam/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/bricelam/EntityFramework/tags","blobs_url":"https://api.github.com/repos/bricelam/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bricelam/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bricelam/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/bricelam/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bricelam/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/bricelam/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/bricelam/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/bricelam/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/bricelam/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/bricelam/EntityFramework/subscription","commits_url":"https://api.github.com/repos/bricelam/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/bricelam/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/bricelam/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/bricelam/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/bricelam/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/bricelam/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bricelam/EntityFramework/merges","archive_url":"https://api.github.com/repos/bricelam/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bricelam/EntityFramework/downloads","issues_url":"https://api.github.com/repos/bricelam/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/bricelam/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/bricelam/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/bricelam/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bricelam/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/bricelam/EntityFramework/releases{/id}","created_at":"2014-05-13T15:45:50Z","updated_at":"2015-04-03T18:16:43Z","pushed_at":"2015-04-08T17:00:52Z","git_url":"git://github.com/bricelam/EntityFramework.git","ssh_url":"git@github.com:bricelam/EntityFramework.git","clone_url":"https://github.com/bricelam/EntityFramework.git","svn_url":"https://github.com/bricelam/EntityFramework","homepage":"","size":16380,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"1fdd3b04ccf6aa71d1303eeb57220f122b533a85","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"Microsoft's recommended data access technology for new applications in .NET.","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","created_at":"2014-01-23T00:52:01Z","updated_at":"2015-04-13T16:40:02Z","pushed_at":"2015-04-13T16:40:01Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":"","size":58097,"stargazers_count":1514,"watchers_count":1514,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":406,"mirror_url":null,"open_issues_count":395,"forks":406,"open_issues":395,"watchers":1514,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/2006"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/2006"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/2006/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/2006/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFramework/statuses/2df1f73dabf3542543f7559b7d37e65f7e240402"}}}}