{"action":"created","issue":{"url":"https://api.github.com/repos/esdoc/esdoc/issues/105","labels_url":"https://api.github.com/repos/esdoc/esdoc/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/esdoc/esdoc/issues/105/comments","events_url":"https://api.github.com/repos/esdoc/esdoc/issues/105/events","html_url":"https://github.com/esdoc/esdoc/pull/105","id":109728656,"number":105,"title":"Parsing default params when the default is set to \"{}\"","user":{"login":"blindman","id":850522,"avatar_url":"https://avatars.githubusercontent.com/u/850522?v=3","gravatar_id":"","url":"https://api.github.com/users/blindman","html_url":"https://github.com/blindman","followers_url":"https://api.github.com/users/blindman/followers","following_url":"https://api.github.com/users/blindman/following{/other_user}","gists_url":"https://api.github.com/users/blindman/gists{/gist_id}","starred_url":"https://api.github.com/users/blindman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindman/subscriptions","organizations_url":"https://api.github.com/users/blindman/orgs","repos_url":"https://api.github.com/users/blindman/repos","events_url":"https://api.github.com/users/blindman/events{/privacy}","received_events_url":"https://api.github.com/users/blindman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/esdoc/esdoc/labels/Accept","name":"Accept","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T04:14:54Z","updated_at":"2015-10-15T13:39:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/esdoc/esdoc/pulls/105","html_url":"https://github.com/esdoc/esdoc/pull/105","diff_url":"https://github.com/esdoc/esdoc/pull/105.diff","patch_url":"https://github.com/esdoc/esdoc/pull/105.patch"},"body":"When setting a default parameter to an object (e.g. `funcName(argOne = {})`), the `@param` component is parsed incorrectly.\r\n\r\nI tracked down the issue to [ParamParser.js](https://github.com/blindman/esdoc/commit/f929cdac3f04524247abe920e46e85f8b82d38a4#diff-e444415be441b7d1fff0b4819049cd75) where the regex used in the `match` function assigning to `match` and the `replace` function assigning to `value` are not the same.  I am not sure if these are purposely different but I changed them to match and added tests to account for the changes made.\r\n\r\nExample:\r\n\r\n![code](http://i.imgur.com/Ez3edDw.png)\r\n\r\n![output](http://i.imgur.com/37e1NpE.png)"},"comment":{"url":"https://api.github.com/repos/esdoc/esdoc/issues/comments/148389335","html_url":"https://github.com/esdoc/esdoc/pull/105#issuecomment-148389335","issue_url":"https://api.github.com/repos/esdoc/esdoc/issues/105","id":148389335,"user":{"login":"blindman","id":850522,"avatar_url":"https://avatars.githubusercontent.com/u/850522?v=3","gravatar_id":"","url":"https://api.github.com/users/blindman","html_url":"https://github.com/blindman","followers_url":"https://api.github.com/users/blindman/followers","following_url":"https://api.github.com/users/blindman/following{/other_user}","gists_url":"https://api.github.com/users/blindman/gists{/gist_id}","starred_url":"https://api.github.com/users/blindman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindman/subscriptions","organizations_url":"https://api.github.com/users/blindman/orgs","repos_url":"https://api.github.com/users/blindman/repos","events_url":"https://api.github.com/users/blindman/events{/privacy}","received_events_url":"https://api.github.com/users/blindman/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T13:39:11Z","updated_at":"2015-10-15T13:39:11Z","body":"@h13i32maru Yes, totally understandable. You might want to add that to CONTRIBUTING.md though.  The main reason I wrote the tests is because I didn't want to submit the PR with failing tests caused by my code.  Would you like me to re-submit the PR without the tests?"}}