{"action":"created","comment":{"url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/comments/31878490","id":31878490,"diff_hunk":"@@ -36,6 +36,7 @@ import _root_.io.netty.handler.codec._\n \n private[netty] final class Client(limit: Int) {\n   // this isn't ugly or anything...\n+  @volatile","path":"src/main/scala/scalaz/netty/Client.scala","position":4,"original_position":4,"commit_id":"17c7914d019d12ec66abb7ebee489cb6a238edca","original_commit_id":"17c7914d019d12ec66abb7ebee489cb6a238edca","user":{"login":"djspiewak","id":752,"avatar_url":"https://avatars.githubusercontent.com/u/752?v=3","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"body":"Is this actually necessary?  I spent some time thinking about it, and I can't convince myself one way or another.  Given that this is a high contention reference, putting `@volatile` here probably has some appreciable performance impact.","created_at":"2015-06-07T16:59:57Z","updated_at":"2015-06-07T16:59:57Z","html_url":"https://github.com/RichRelevance/scalaz-netty/pull/10#discussion_r31878490","pull_request_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/comments/31878490"},"html":{"href":"https://github.com/RichRelevance/scalaz-netty/pull/10#discussion_r31878490"},"pull_request":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10","id":37084664,"html_url":"https://github.com/RichRelevance/scalaz-netty/pull/10","diff_url":"https://github.com/RichRelevance/scalaz-netty/pull/10.diff","patch_url":"https://github.com/RichRelevance/scalaz-netty/pull/10.patch","issue_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/10","number":10,"state":"open","locked":false,"title":"directly convert msg to bytevector instead of making a copy first","user":{"login":"ShengC","id":940628,"avatar_url":"https://avatars.githubusercontent.com/u/940628?v=3","gravatar_id":"","url":"https://api.github.com/users/ShengC","html_url":"https://github.com/ShengC","followers_url":"https://api.github.com/users/ShengC/followers","following_url":"https://api.github.com/users/ShengC/following{/other_user}","gists_url":"https://api.github.com/users/ShengC/gists{/gist_id}","starred_url":"https://api.github.com/users/ShengC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShengC/subscriptions","organizations_url":"https://api.github.com/users/ShengC/orgs","repos_url":"https://api.github.com/users/ShengC/repos","events_url":"https://api.github.com/users/ShengC/events{/privacy}","received_events_url":"https://api.github.com/users/ShengC/received_events","type":"User","site_admin":false},"body":"this is to address one of the future work in wiki that aims to convert msg to bytevector directly instead of making a copy first.","created_at":"2015-06-06T04:24:42Z","updated_at":"2015-06-07T16:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78833f853d0bc398299e1db12472c20d4bfee652","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10/commits","review_comments_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10/comments","review_comment_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/10/comments","statuses_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/statuses/17c7914d019d12ec66abb7ebee489cb6a238edca","head":{"label":"ShengC:master","ref":"master","sha":"17c7914d019d12ec66abb7ebee489cb6a238edca","user":{"login":"ShengC","id":940628,"avatar_url":"https://avatars.githubusercontent.com/u/940628?v=3","gravatar_id":"","url":"https://api.github.com/users/ShengC","html_url":"https://github.com/ShengC","followers_url":"https://api.github.com/users/ShengC/followers","following_url":"https://api.github.com/users/ShengC/following{/other_user}","gists_url":"https://api.github.com/users/ShengC/gists{/gist_id}","starred_url":"https://api.github.com/users/ShengC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShengC/subscriptions","organizations_url":"https://api.github.com/users/ShengC/orgs","repos_url":"https://api.github.com/users/ShengC/repos","events_url":"https://api.github.com/users/ShengC/events{/privacy}","received_events_url":"https://api.github.com/users/ShengC/received_events","type":"User","site_admin":false},"repo":{"id":36910455,"name":"scalaz-netty","full_name":"ShengC/scalaz-netty","owner":{"login":"ShengC","id":940628,"avatar_url":"https://avatars.githubusercontent.com/u/940628?v=3","gravatar_id":"","url":"https://api.github.com/users/ShengC","html_url":"https://github.com/ShengC","followers_url":"https://api.github.com/users/ShengC/followers","following_url":"https://api.github.com/users/ShengC/following{/other_user}","gists_url":"https://api.github.com/users/ShengC/gists{/gist_id}","starred_url":"https://api.github.com/users/ShengC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShengC/subscriptions","organizations_url":"https://api.github.com/users/ShengC/orgs","repos_url":"https://api.github.com/users/ShengC/repos","events_url":"https://api.github.com/users/ShengC/events{/privacy}","received_events_url":"https://api.github.com/users/ShengC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShengC/scalaz-netty","description":"A minimalist wrapper for Netty in terms of scalaz-stream","fork":true,"url":"https://api.github.com/repos/ShengC/scalaz-netty","forks_url":"https://api.github.com/repos/ShengC/scalaz-netty/forks","keys_url":"https://api.github.com/repos/ShengC/scalaz-netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShengC/scalaz-netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShengC/scalaz-netty/teams","hooks_url":"https://api.github.com/repos/ShengC/scalaz-netty/hooks","issue_events_url":"https://api.github.com/repos/ShengC/scalaz-netty/issues/events{/number}","events_url":"https://api.github.com/repos/ShengC/scalaz-netty/events","assignees_url":"https://api.github.com/repos/ShengC/scalaz-netty/assignees{/user}","branches_url":"https://api.github.com/repos/ShengC/scalaz-netty/branches{/branch}","tags_url":"https://api.github.com/repos/ShengC/scalaz-netty/tags","blobs_url":"https://api.github.com/repos/ShengC/scalaz-netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShengC/scalaz-netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShengC/scalaz-netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShengC/scalaz-netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShengC/scalaz-netty/statuses/{sha}","languages_url":"https://api.github.com/repos/ShengC/scalaz-netty/languages","stargazers_url":"https://api.github.com/repos/ShengC/scalaz-netty/stargazers","contributors_url":"https://api.github.com/repos/ShengC/scalaz-netty/contributors","subscribers_url":"https://api.github.com/repos/ShengC/scalaz-netty/subscribers","subscription_url":"https://api.github.com/repos/ShengC/scalaz-netty/subscription","commits_url":"https://api.github.com/repos/ShengC/scalaz-netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShengC/scalaz-netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShengC/scalaz-netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShengC/scalaz-netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShengC/scalaz-netty/contents/{+path}","compare_url":"https://api.github.com/repos/ShengC/scalaz-netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShengC/scalaz-netty/merges","archive_url":"https://api.github.com/repos/ShengC/scalaz-netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShengC/scalaz-netty/downloads","issues_url":"https://api.github.com/repos/ShengC/scalaz-netty/issues{/number}","pulls_url":"https://api.github.com/repos/ShengC/scalaz-netty/pulls{/number}","milestones_url":"https://api.github.com/repos/ShengC/scalaz-netty/milestones{/number}","notifications_url":"https://api.github.com/repos/ShengC/scalaz-netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShengC/scalaz-netty/labels{/name}","releases_url":"https://api.github.com/repos/ShengC/scalaz-netty/releases{/id}","created_at":"2015-06-05T03:46:28Z","updated_at":"2015-06-05T03:46:28Z","pushed_at":"2015-06-06T21:41:38Z","git_url":"git://github.com/ShengC/scalaz-netty.git","ssh_url":"git@github.com:ShengC/scalaz-netty.git","clone_url":"https://github.com/ShengC/scalaz-netty.git","svn_url":"https://github.com/ShengC/scalaz-netty","homepage":null,"size":235,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RichRelevance:master","ref":"master","sha":"49a79e0e39d45d574007845b832ccc7021923235","user":{"login":"RichRelevance","id":4031922,"avatar_url":"https://avatars.githubusercontent.com/u/4031922?v=3","gravatar_id":"","url":"https://api.github.com/users/RichRelevance","html_url":"https://github.com/RichRelevance","followers_url":"https://api.github.com/users/RichRelevance/followers","following_url":"https://api.github.com/users/RichRelevance/following{/other_user}","gists_url":"https://api.github.com/users/RichRelevance/gists{/gist_id}","starred_url":"https://api.github.com/users/RichRelevance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichRelevance/subscriptions","organizations_url":"https://api.github.com/users/RichRelevance/orgs","repos_url":"https://api.github.com/users/RichRelevance/repos","events_url":"https://api.github.com/users/RichRelevance/events{/privacy}","received_events_url":"https://api.github.com/users/RichRelevance/received_events","type":"Organization","site_admin":false},"repo":{"id":30436513,"name":"scalaz-netty","full_name":"RichRelevance/scalaz-netty","owner":{"login":"RichRelevance","id":4031922,"avatar_url":"https://avatars.githubusercontent.com/u/4031922?v=3","gravatar_id":"","url":"https://api.github.com/users/RichRelevance","html_url":"https://github.com/RichRelevance","followers_url":"https://api.github.com/users/RichRelevance/followers","following_url":"https://api.github.com/users/RichRelevance/following{/other_user}","gists_url":"https://api.github.com/users/RichRelevance/gists{/gist_id}","starred_url":"https://api.github.com/users/RichRelevance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichRelevance/subscriptions","organizations_url":"https://api.github.com/users/RichRelevance/orgs","repos_url":"https://api.github.com/users/RichRelevance/repos","events_url":"https://api.github.com/users/RichRelevance/events{/privacy}","received_events_url":"https://api.github.com/users/RichRelevance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RichRelevance/scalaz-netty","description":"A minimalist wrapper for Netty in terms of scalaz-stream","fork":false,"url":"https://api.github.com/repos/RichRelevance/scalaz-netty","forks_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/forks","keys_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/teams","hooks_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/hooks","issue_events_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/events{/number}","events_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/events","assignees_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/assignees{/user}","branches_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/branches{/branch}","tags_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/tags","blobs_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/statuses/{sha}","languages_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/languages","stargazers_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/stargazers","contributors_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/contributors","subscribers_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/subscribers","subscription_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/subscription","commits_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/contents/{+path}","compare_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/merges","archive_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/downloads","issues_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues{/number}","pulls_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls{/number}","milestones_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/milestones{/number}","notifications_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/labels{/name}","releases_url":"https://api.github.com/repos/RichRelevance/scalaz-netty/releases{/id}","created_at":"2015-02-06T22:45:09Z","updated_at":"2015-05-06T05:34:21Z","pushed_at":"2015-06-06T21:41:39Z","git_url":"git://github.com/RichRelevance/scalaz-netty.git","ssh_url":"git@github.com:RichRelevance/scalaz-netty.git","clone_url":"https://github.com/RichRelevance/scalaz-netty.git","svn_url":"https://github.com/RichRelevance/scalaz-netty","homepage":null,"size":235,"stargazers_count":37,"watchers_count":37,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10"},"html":{"href":"https://github.com/RichRelevance/scalaz-netty/pull/10"},"issue":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/10"},"comments":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/RichRelevance/scalaz-netty/statuses/17c7914d019d12ec66abb7ebee489cb6a238edca"}}}}