{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments/45375724","id":45375724,"diff_hunk":"@@ -135,18 +135,15 @@ def test_parse_icmp_rule(self):\n         # Assert on the result\n         assert_equal(parsed['action'], \"allow\")\n         assert_equal(parsed['protocol'], \"icmp\")\n-        assert_equal(parsed['icmp_type'], 8)\n+        assert_equal(parsed['icmp_type'], '8')\n         assert_equal(parsed['src_net'], IPNetwork(\"1.2.0.0/16\"))\n \n     @parameterized.expand([\n         (\"allow icmp type code 4\"),\n-        (\"allow icmp type ten code 4\"),","path":"calico_kubernetes/tests/policy_test.py","position":51,"original_position":51,"commit_id":"edfdf6d820e5e9b96271a3b2aedc54f768227c46","original_commit_id":"edfdf6d820e5e9b96271a3b2aedc54f768227c46","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"why remove these test cases?","created_at":"2015-11-19T17:57:22Z","updated_at":"2015-11-19T17:57:22Z","html_url":"https://github.com/projectcalico/calico-kubernetes/pull/103#discussion_r45375724","pull_request_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments/45375724"},"html":{"href":"https://github.com/projectcalico/calico-kubernetes/pull/103#discussion_r45375724"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103","id":51124196,"html_url":"https://github.com/projectcalico/calico-kubernetes/pull/103","diff_url":"https://github.com/projectcalico/calico-kubernetes/pull/103.diff","patch_url":"https://github.com/projectcalico/calico-kubernetes/pull/103.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/103","number":103,"state":"open","locked":false,"title":"Remove validation done in libcalico","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"body":"Wait for https://github.com/projectcalico/libcalico/pull/53 to get it","created_at":"2015-11-18T18:42:48Z","updated_at":"2015-11-19T17:57:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd82ecd75ac158aaccb875b73d7453dd5f365933","assignee":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/103/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/edfdf6d820e5e9b96271a3b2aedc54f768227c46","head":{"label":"L-MA:rule-validation","ref":"rule-validation","sha":"edfdf6d820e5e9b96271a3b2aedc54f768227c46","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"repo":{"id":40022933,"name":"calico-kubernetes","full_name":"L-MA/calico-kubernetes","owner":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/L-MA/calico-kubernetes","description":"","fork":true,"url":"https://api.github.com/repos/L-MA/calico-kubernetes","forks_url":"https://api.github.com/repos/L-MA/calico-kubernetes/forks","keys_url":"https://api.github.com/repos/L-MA/calico-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/L-MA/calico-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/L-MA/calico-kubernetes/teams","hooks_url":"https://api.github.com/repos/L-MA/calico-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/L-MA/calico-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/L-MA/calico-kubernetes/events","assignees_url":"https://api.github.com/repos/L-MA/calico-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/L-MA/calico-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/L-MA/calico-kubernetes/tags","blobs_url":"https://api.github.com/repos/L-MA/calico-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/L-MA/calico-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/L-MA/calico-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/L-MA/calico-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/L-MA/calico-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/L-MA/calico-kubernetes/languages","stargazers_url":"https://api.github.com/repos/L-MA/calico-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/L-MA/calico-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/L-MA/calico-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/L-MA/calico-kubernetes/subscription","commits_url":"https://api.github.com/repos/L-MA/calico-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/L-MA/calico-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/L-MA/calico-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/L-MA/calico-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/L-MA/calico-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/L-MA/calico-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/L-MA/calico-kubernetes/merges","archive_url":"https://api.github.com/repos/L-MA/calico-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/L-MA/calico-kubernetes/downloads","issues_url":"https://api.github.com/repos/L-MA/calico-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/L-MA/calico-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/L-MA/calico-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/L-MA/calico-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/L-MA/calico-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/L-MA/calico-kubernetes/releases{/id}","created_at":"2015-07-31T20:08:59Z","updated_at":"2015-07-29T20:04:46Z","pushed_at":"2015-11-19T00:52:14Z","git_url":"git://github.com/L-MA/calico-kubernetes.git","ssh_url":"git@github.com:L-MA/calico-kubernetes.git","clone_url":"https://github.com/L-MA/calico-kubernetes.git","svn_url":"https://github.com/L-MA/calico-kubernetes","homepage":null,"size":332,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"f7f88c2eb4655cea4cb9c845d87afec6862a80c4","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39913632,"name":"calico-kubernetes","full_name":"projectcalico/calico-kubernetes","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-kubernetes","description":"Calico Kubernetes Networking Plugin","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-kubernetes","forks_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/releases{/id}","created_at":"2015-07-29T20:04:46Z","updated_at":"2015-11-02T12:33:17Z","pushed_at":"2015-11-19T17:56:43Z","git_url":"git://github.com/projectcalico/calico-kubernetes.git","ssh_url":"git@github.com:projectcalico/calico-kubernetes.git","clone_url":"https://github.com/projectcalico/calico-kubernetes.git","svn_url":"https://github.com/projectcalico/calico-kubernetes","homepage":"","size":434,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":17,"forks":4,"open_issues":17,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103"},"html":{"href":"https://github.com/projectcalico/calico-kubernetes/pull/103"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/103"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/edfdf6d820e5e9b96271a3b2aedc54f768227c46"}}}}