{"action":"opened","number":379,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379","id":28514492,"html_url":"https://github.com/puppetlabs/puppet-server/pull/379","diff_url":"https://github.com/puppetlabs/puppet-server/pull/379.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/379.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379","number":379,"state":"open","locked":false,"title":"(SERVER-206) Close client on scripting container termination","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"body":"Add in a new `terminate` method to the master that closes the HTTP client and call it before terminating the JRuby scripting container.\r\n\r\nI'm definitely looking for some feedback on this one. In particular, I'm not sure about testing. I was having trouble figuring out how to test this. I did add a test to ensure that the master termination function works as intended, but wasn't sure how to write a test to ensure a client is closed before we destroy its scripting container, so any feedback or suggestions on that front are very much appreciated.","created_at":"2015-02-02T23:56:52Z","updated_at":"2015-02-02T23:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/96d3651b0e9fdc53e8dac306af294535b164dd32","head":{"label":"fpringvaldsen:SERVER-206-close-client","ref":"SERVER-206-close-client","sha":"96d3651b0e9fdc53e8dac306af294535b164dd32","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"repo":{"id":24656237,"name":"puppet-server","full_name":"fpringvaldsen/puppet-server","owner":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fpringvaldsen/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/fpringvaldsen/puppet-server","forks_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/forks","keys_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/teams","hooks_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/events","assignees_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/tags","blobs_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/languages","stargazers_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/subscription","commits_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/merges","archive_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/downloads","issues_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/fpringvaldsen/puppet-server/releases{/id}","created_at":"2014-09-30T21:24:08Z","updated_at":"2015-02-02T23:48:21Z","pushed_at":"2015-02-02T23:53:24Z","git_url":"git://github.com/fpringvaldsen/puppet-server.git","ssh_url":"git@github.com:fpringvaldsen/puppet-server.git","clone_url":"https://github.com/fpringvaldsen/puppet-server.git","svn_url":"https://github.com/fpringvaldsen/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":1934,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"87bd33431bdf424df1b331d54d7efbd54257b3cd","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-02-02T21:04:34Z","pushed_at":"2015-02-02T21:04:33Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":4350,"stargazers_count":80,"watchers_count":80,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":5,"forks":41,"open_issues":5,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/379"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/96d3651b0e9fdc53e8dac306af294535b164dd32"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":82,"deletions":24,"changed_files":6}}