{"action":"created","issue":{"url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/5","labels_url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/5/comments","events_url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/5/events","html_url":"https://github.com/gonzaloaune/GCMPushPlugin/pull/5","id":106833636,"number":5,"title":"use boolValue to set usesGCM and gcmSandbox","user":{"login":"maeldur","id":437016,"avatar_url":"https://avatars.githubusercontent.com/u/437016?v=3","gravatar_id":"","url":"https://api.github.com/users/maeldur","html_url":"https://github.com/maeldur","followers_url":"https://api.github.com/users/maeldur/followers","following_url":"https://api.github.com/users/maeldur/following{/other_user}","gists_url":"https://api.github.com/users/maeldur/gists{/gist_id}","starred_url":"https://api.github.com/users/maeldur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maeldur/subscriptions","organizations_url":"https://api.github.com/users/maeldur/orgs","repos_url":"https://api.github.com/users/maeldur/repos","events_url":"https://api.github.com/users/maeldur/events{/privacy}","received_events_url":"https://api.github.com/users/maeldur/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-16T18:30:07Z","updated_at":"2015-09-16T18:36:33Z","closed_at":"2015-09-16T18:36:19Z","pull_request":{"url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/pulls/5","html_url":"https://github.com/gonzaloaune/GCMPushPlugin/pull/5","diff_url":"https://github.com/gonzaloaune/GCMPushPlugin/pull/5.diff","patch_url":"https://github.com/gonzaloaune/GCMPushPlugin/pull/5.patch"},"body":"When testing push notifications in a production ad-hoc build on iOS, i noticed that the gcmSandbox option was being set to YES even though the javascript was passing false.  \r\n\r\nUpon debugging it looks like the return values were NSStrings @\"1\" or @\"0\" for true and false, both of which when casted directly to BOOL return YES (since they are both non-nil).   Using boolValue seems to set the value correctly.  \r\n\r\ni.e.\r\n   \r\n    (BOOL) @\"1\" = YES\r\n    (BOOL) @\"0\" = YES\r\n\r\n    [@\"1\" boolValue] = YES\r\n    [@\"0\" boolValue] = NO"},"comment":{"url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/comments/140836422","html_url":"https://github.com/gonzaloaune/GCMPushPlugin/pull/5#issuecomment-140836422","issue_url":"https://api.github.com/repos/gonzaloaune/GCMPushPlugin/issues/5","id":140836422,"user":{"login":"gonzaloaune","id":219565,"avatar_url":"https://avatars.githubusercontent.com/u/219565?v=3","gravatar_id":"","url":"https://api.github.com/users/gonzaloaune","html_url":"https://github.com/gonzaloaune","followers_url":"https://api.github.com/users/gonzaloaune/followers","following_url":"https://api.github.com/users/gonzaloaune/following{/other_user}","gists_url":"https://api.github.com/users/gonzaloaune/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzaloaune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzaloaune/subscriptions","organizations_url":"https://api.github.com/users/gonzaloaune/orgs","repos_url":"https://api.github.com/users/gonzaloaune/repos","events_url":"https://api.github.com/users/gonzaloaune/events{/privacy}","received_events_url":"https://api.github.com/users/gonzaloaune/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T18:36:33Z","updated_at":"2015-09-16T18:36:33Z","body":"That seems to be correct, good catch @maeldur. Thanks."}}