{"action":"opened","issue":{"url":"https://api.github.com/repos/aspnet/XRE/issues/1296","labels_url":"https://api.github.com/repos/aspnet/XRE/issues/1296/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/XRE/issues/1296/comments","events_url":"https://api.github.com/repos/aspnet/XRE/issues/1296/events","html_url":"https://github.com/aspnet/XRE/issues/1296","id":59266673,"number":1296,"title":"Possible parsing bug?","user":{"login":"jods4","id":3832820,"avatar_url":"https://avatars.githubusercontent.com/u/3832820?v=3","gravatar_id":"","url":"https://api.github.com/users/jods4","html_url":"https://github.com/jods4","followers_url":"https://api.github.com/users/jods4/followers","following_url":"https://api.github.com/users/jods4/following{/other_user}","gists_url":"https://api.github.com/users/jods4/gists{/gist_id}","starred_url":"https://api.github.com/users/jods4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jods4/subscriptions","organizations_url":"https://api.github.com/users/jods4/orgs","repos_url":"https://api.github.com/users/jods4/repos","events_url":"https://api.github.com/users/jods4/events{/privacy}","received_events_url":"https://api.github.com/users/jods4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-02-27T17:25:33Z","updated_at":"2015-02-27T17:25:33Z","closed_at":null,"body":"I was trying to answer a few questions by reading the sources today and noticed:\r\nhttps://github.com/aspnet/XRE/blob/069dfb964a86ab505dd6df5e5495434072346b6c/src/Microsoft.Framework.Runtime/NuGet/SemanticVersion.cs#L186\r\n\r\n`SemanticVersion.TryParseInternal`\r\nIt seems that the intent of line 186 is to remove the `\"-*\"` suffix, by dropping the last 2 chars of `version`. But this is inconsistent with the `if` above. It checks if the last two chars _after trimming_ are `\"-*\"`, whereas the code tries to remove the last two chars _before trimming_.\r\n\r\nIt is my understanding that with a version such as `\"1.0.0-* \"` (notice the space at the end), this method would fail."}}