{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/1468","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/1468/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/1468/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/1468/events","html_url":"https://github.com/stan-dev/stan/pull/1468","id":83662748,"number":1468,"title":"Bugfix/issue 1436 int max bounds","user":{"login":"bob-carpenter","id":3383807,"avatar_url":"https://avatars.githubusercontent.com/u/3383807?v=3","gravatar_id":"","url":"https://api.github.com/users/bob-carpenter","html_url":"https://github.com/bob-carpenter","followers_url":"https://api.github.com/users/bob-carpenter/followers","following_url":"https://api.github.com/users/bob-carpenter/following{/other_user}","gists_url":"https://api.github.com/users/bob-carpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/bob-carpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bob-carpenter/subscriptions","organizations_url":"https://api.github.com/users/bob-carpenter/orgs","repos_url":"https://api.github.com/users/bob-carpenter/repos","events_url":"https://api.github.com/users/bob-carpenter/events{/privacy}","received_events_url":"https://api.github.com/users/bob-carpenter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-01T19:47:22Z","updated_at":"2015-06-06T08:46:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/1468","html_url":"https://github.com/stan-dev/stan/pull/1468","diff_url":"https://github.com/stan-dev/stan/pull/1468.diff","patch_url":"https://github.com/stan-dev/stan/pull/1468.patch"},"body":"#### Summary:\r\n\r\nAdds `using std::max;` and `using std::min;` to generated model code.\r\n\r\n#### Intended Effect:\r\n\r\nFix issue that prevented `max(int,int)` being used in sizes for array and matrix variable declarations.\r\n\r\n#### How to Verify:\r\n\r\nThere is a new model in the test suite, `src/test/test-models/good/min-max-types.stan`, which fails in the current develop version and Stan 2.6.2, but now works.\r\n\r\n#### Side Effects:\r\n\r\nMore namespace leakage, but this is tested to not cause ambiguities in the test file.\r\n\r\n#### Documentation:\r\n\r\nThis brings behavior in line with doc.\r\n\r\n#### Reviewer Suggestions:\r\n\r\nAnyone."},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/109553427","html_url":"https://github.com/stan-dev/stan/pull/1468#issuecomment-109553427","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/1468","id":109553427,"user":{"login":"stan-buildbot","id":3512237,"avatar_url":"https://avatars.githubusercontent.com/u/3512237?v=3","gravatar_id":"","url":"https://api.github.com/users/stan-buildbot","html_url":"https://github.com/stan-buildbot","followers_url":"https://api.github.com/users/stan-buildbot/followers","following_url":"https://api.github.com/users/stan-buildbot/following{/other_user}","gists_url":"https://api.github.com/users/stan-buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-buildbot/subscriptions","organizations_url":"https://api.github.com/users/stan-buildbot/orgs","repos_url":"https://api.github.com/users/stan-buildbot/repos","events_url":"https://api.github.com/users/stan-buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/stan-buildbot/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T08:46:18Z","updated_at":"2015-06-06T08:46:18Z","body":"\n\n**Build Log**\n*last 20 lines*\n\n ```\n[...truncated 11 lines...]\n > /usr/local/git/bin/git rev-parse refs/remotes/origin/origin/pr/1468/merge^{commit} # timeout=10\nChecking out Revision efd6100e7dc7587f9f46da4ba0380e8ad6bf770e (refs/remotes/origin/pr/1468/merge)\n > /usr/local/git/bin/git config core.sparsecheckout # timeout=10\n > /usr/local/git/bin/git checkout -f efd6100e7dc7587f9f46da4ba0380e8ad6bf770e\nFirst time build. Skipping changelog.\nStarting build job Stan Pull Request - Doc - Doxygen.\nStarting build job Stan Pull Request - Doc - Reference Manual.\nFinished Build : #407 of Job : Stan Pull Request - Doc - Reference Manual with status : SUCCESS\nFinished Build : #413 of Job : Stan Pull Request - Doc - Doxygen with status : SUCCESS\nStarting build job Stan Pull Request - Tests - Header.\nStarting build job Stan Pull Request - Tests - Unit.\nStarting build job Stan Pull Request - Tests - Integration.\nStarting build job Stan Pull Request - Windows - Tests - Unit.\nFinished Build : #227 of Job : Stan Pull Request - Windows - Tests - Unit with status : FAILURE\nFinished Build : #380 of Job : Stan Pull Request - Tests - Unit with status : ABORTED\nFinished Build : #378 of Job : Stan Pull Request - Tests - Header with status : ABORTED\nFinished Build : #380 of Job : Stan Pull Request - Tests - Integration with status : ABORTED\nBuild step 'MultiJob Phase' marked build as failure\nSetting status of c921281495e946c38e6b5cdf912f5d7aa3828fe7 to FAILURE with url http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/414/ and message: 'Build finished.'\n```\n\nRefer to this link for build results (access rights to CI server needed): \nhttp://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/414/\n"}}