{"action":"created","issue":{"url":"https://api.github.com/repos/mila-udem/fuel/issues/144","labels_url":"https://api.github.com/repos/mila-udem/fuel/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/mila-udem/fuel/issues/144/comments","events_url":"https://api.github.com/repos/mila-udem/fuel/issues/144/events","html_url":"https://github.com/mila-udem/fuel/pull/144","id":82509472,"number":144,"title":"[WIP] Index subset support for H5PYDataset","user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-05-29T17:15:30Z","updated_at":"2015-06-15T18:11:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mila-udem/fuel/pulls/144","html_url":"https://github.com/mila-udem/fuel/pull/144","diff_url":"https://github.com/mila-udem/fuel/pull/144.diff","patch_url":"https://github.com/mila-udem/fuel/pull/144.patch"},"body":"Fixes #101. Fixes #102.\r\n\r\nThis PR adds support for two types of index subsets:\r\n* At the HDF5 level, it allows the user to specify a split as a list of indices.\r\n* At the dataset level, it allows the user to specify a subset of a split as a list of indices.\r\n\r\nThe current implementation is a draft. In particular, I had to do some pretty ugly things to the H5PYDataset interface in order to support HDF5-level index split. Basically, if `start` and `stop` are negative, H5PYDataset will look for a `split_subset` attribute in the sources (where `split` is the name of the split), which is a reference to an HDF5 dataset that contains the indices for that split/source pair.\r\n\r\nThere are two things I'd like to polish before I feel like this PR is ready to be merged:\r\n* I think it's time to rethink the H5PYDataset interface to integrate HDF5-level index splits in a less hacky way.\r\n* I'd like to document the interface itself in the online docs.\r\n\r\n@rizar I think this might interest you."},"comment":{"url":"https://api.github.com/repos/mila-udem/fuel/issues/comments/112158252","html_url":"https://github.com/mila-udem/fuel/pull/144#issuecomment-112158252","issue_url":"https://api.github.com/repos/mila-udem/fuel/issues/144","id":112158252,"user":{"login":"vdumoulin","id":2034067,"avatar_url":"https://avatars.githubusercontent.com/u/2034067?v=3","gravatar_id":"","url":"https://api.github.com/users/vdumoulin","html_url":"https://github.com/vdumoulin","followers_url":"https://api.github.com/users/vdumoulin/followers","following_url":"https://api.github.com/users/vdumoulin/following{/other_user}","gists_url":"https://api.github.com/users/vdumoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/vdumoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdumoulin/subscriptions","organizations_url":"https://api.github.com/users/vdumoulin/orgs","repos_url":"https://api.github.com/users/vdumoulin/repos","events_url":"https://api.github.com/users/vdumoulin/events{/privacy}","received_events_url":"https://api.github.com/users/vdumoulin/received_events","type":"User","site_admin":false},"created_at":"2015-06-15T18:11:11Z","updated_at":"2015-06-15T18:11:11Z","body":"I suspect that I'll have to clear the cache and run the tests again. I'll manage that and ping you when the tests pass."}}