{"action":"created","comment":{"url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/comments/33774020","id":33774020,"diff_hunk":"@@ -1,26 +1,30 @@\n [Unit]\n Description=Kubernetes Kubelet\n Documentation=https://github.com/GoogleCloudPlatform/kubernetes\n-Requires=setup-network-environment.service\n-After=setup-network-environment.service\n+Requires=kube-apiserver.service\n+After=kube-apiserver.service\n \n [Service]\n-EnvironmentFile=/etc/network-environment\n-EnvironmentFile=/etc/leader\n-ExecStartPre=-/usr/bin/rm /opt/bin/kubelet\n-ExecStartPre=/usr/bin/curl -L -o /opt/bin/kubelet -z /opt/bin/kubelet https://storage.googleapis.com/kubernetes-release/release/v0.19.3/bin/linux/amd64/kubelet\n-ExecStartPre=/usr/bin/chmod +x /opt/bin/kubelet\n+EnvironmentFile=/etc/environment\n+EnvironmentFile=/etc/kube-config.env\n+ExecStartPre=/opt/bin/curl-update-binary /opt/bin/kubelet https://storage.googleapis.com/kubernetes-release/release/v0.20.2/bin/linux/amd64/kubelet\n ExecStart=/opt/bin/kubelet \\\n+  --v=3 \\\n+  --logtostderr=true \\\n   --address=0.0.0.0 \\\n-  --port=10250 \\\n-  --hostname_override=${DEFAULT_IPV4} \\\n-  --api_servers=http://${LEADER_ENDPOINT}:9090 \\\n+  --port=${KUBE_KUBELET_PORT} \\\n+  --api_servers=http://${KUBE_MASTER_IP}:${KUBE_MASTER_PORT} \\","path":"kube-kubelet.service","position":26,"original_position":26,"commit_id":"b569e71bc0d5ed336f955599c2b8c3590915fb47","original_commit_id":"b569e71bc0d5ed336f955599c2b8c3590915fb47","user":{"login":"mhamrah","id":91162,"avatar_url":"https://avatars.githubusercontent.com/u/91162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhamrah","html_url":"https://github.com/mhamrah","followers_url":"https://api.github.com/users/mhamrah/followers","following_url":"https://api.github.com/users/mhamrah/following{/other_user}","gists_url":"https://api.github.com/users/mhamrah/gists{/gist_id}","starred_url":"https://api.github.com/users/mhamrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhamrah/subscriptions","organizations_url":"https://api.github.com/users/mhamrah/orgs","repos_url":"https://api.github.com/users/mhamrah/repos","events_url":"https://api.github.com/users/mhamrah/events{/privacy}","received_events_url":"https://api.github.com/users/mhamrah/received_events","type":"User","site_admin":false},"body":"I think this should be one value, KUBE_API_SERVERS, so users can specify a comma-delimited list of host:port combinations when dealing with multi-masters. ","created_at":"2015-07-02T12:51:31Z","updated_at":"2015-07-02T12:51:31Z","html_url":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2#discussion_r33774020","pull_request_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/comments/33774020"},"html":{"href":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2#discussion_r33774020"},"pull_request":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2","id":39005702,"html_url":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2","diff_url":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2.diff","patch_url":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2.patch","issue_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/2","number":2,"state":"open","locked":false,"title":"Slight overhaul","user":{"login":"devurandom","id":63082,"avatar_url":"https://avatars.githubusercontent.com/u/63082?v=3","gravatar_id":"","url":"https://api.github.com/users/devurandom","html_url":"https://github.com/devurandom","followers_url":"https://api.github.com/users/devurandom/followers","following_url":"https://api.github.com/users/devurandom/following{/other_user}","gists_url":"https://api.github.com/users/devurandom/gists{/gist_id}","starred_url":"https://api.github.com/users/devurandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devurandom/subscriptions","organizations_url":"https://api.github.com/users/devurandom/orgs","repos_url":"https://api.github.com/users/devurandom/repos","events_url":"https://api.github.com/users/devurandom/events{/privacy}","received_events_url":"https://api.github.com/users/devurandom/received_events","type":"User","site_admin":false},"body":"This is a slight overhaul over the existing service files.\r\n\r\n* The first commit uses internal CoreOS mechanisms instead of an additional setup-network-environment unit.\r\n* The 2nd commit uses a binary (that is expected to be dropped via cloud-config) to download the k8s binaries.\r\n* The last commit is a bit larger and adds several command arguments that are needed for k8s v0.20 and/or are present in hack/local-up-cluster.sh. But even more importantly, it makes almost every IP / port setting configurable (via a /etc/kube-config.env file that is supposed to be dropped by cloud-config).","created_at":"2015-07-01T17:27:26Z","updated_at":"2015-07-02T12:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0603c11210f1e42708416eb92913a8f29d639989","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/2/comments","statuses_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/statuses/b569e71bc0d5ed336f955599c2b8c3590915fb47","head":{"label":"devurandom:master","ref":"master","sha":"b569e71bc0d5ed336f955599c2b8c3590915fb47","user":{"login":"devurandom","id":63082,"avatar_url":"https://avatars.githubusercontent.com/u/63082?v=3","gravatar_id":"","url":"https://api.github.com/users/devurandom","html_url":"https://github.com/devurandom","followers_url":"https://api.github.com/users/devurandom/followers","following_url":"https://api.github.com/users/devurandom/following{/other_user}","gists_url":"https://api.github.com/users/devurandom/gists{/gist_id}","starred_url":"https://api.github.com/users/devurandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devurandom/subscriptions","organizations_url":"https://api.github.com/users/devurandom/orgs","repos_url":"https://api.github.com/users/devurandom/repos","events_url":"https://api.github.com/users/devurandom/events{/privacy}","received_events_url":"https://api.github.com/users/devurandom/received_events","type":"User","site_admin":false},"repo":{"id":38379427,"name":"kubernetes-coreos-units","full_name":"devurandom/kubernetes-coreos-units","owner":{"login":"devurandom","id":63082,"avatar_url":"https://avatars.githubusercontent.com/u/63082?v=3","gravatar_id":"","url":"https://api.github.com/users/devurandom","html_url":"https://github.com/devurandom","followers_url":"https://api.github.com/users/devurandom/followers","following_url":"https://api.github.com/users/devurandom/following{/other_user}","gists_url":"https://api.github.com/users/devurandom/gists{/gist_id}","starred_url":"https://api.github.com/users/devurandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devurandom/subscriptions","organizations_url":"https://api.github.com/users/devurandom/orgs","repos_url":"https://api.github.com/users/devurandom/repos","events_url":"https://api.github.com/users/devurandom/events{/privacy}","received_events_url":"https://api.github.com/users/devurandom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devurandom/kubernetes-coreos-units","description":"Fleet Unit Files for Running Kubernetes on CoreOS","fork":true,"url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units","forks_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/forks","keys_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/teams","hooks_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/hooks","issue_events_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/issues/events{/number}","events_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/events","assignees_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/assignees{/user}","branches_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/branches{/branch}","tags_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/tags","blobs_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/git/refs{/sha}","trees_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/statuses/{sha}","languages_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/languages","stargazers_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/stargazers","contributors_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/contributors","subscribers_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/subscribers","subscription_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/subscription","commits_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/commits{/sha}","git_commits_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/git/commits{/sha}","comments_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/comments{/number}","issue_comment_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/issues/comments{/number}","contents_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/contents/{+path}","compare_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/merges","archive_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/downloads","issues_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/issues{/number}","pulls_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/pulls{/number}","milestones_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/milestones{/number}","notifications_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/labels{/name}","releases_url":"https://api.github.com/repos/devurandom/kubernetes-coreos-units/releases{/id}","created_at":"2015-07-01T15:37:59Z","updated_at":"2015-07-01T09:46:42Z","pushed_at":"2015-07-02T10:18:29Z","git_url":"git://github.com/devurandom/kubernetes-coreos-units.git","ssh_url":"git@github.com:devurandom/kubernetes-coreos-units.git","clone_url":"https://github.com/devurandom/kubernetes-coreos-units.git","svn_url":"https://github.com/devurandom/kubernetes-coreos-units","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mhamrah:master","ref":"master","sha":"f8076e9e51c8ee6d419ca9d4fb083dd12b3035a7","user":{"login":"mhamrah","id":91162,"avatar_url":"https://avatars.githubusercontent.com/u/91162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhamrah","html_url":"https://github.com/mhamrah","followers_url":"https://api.github.com/users/mhamrah/followers","following_url":"https://api.github.com/users/mhamrah/following{/other_user}","gists_url":"https://api.github.com/users/mhamrah/gists{/gist_id}","starred_url":"https://api.github.com/users/mhamrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhamrah/subscriptions","organizations_url":"https://api.github.com/users/mhamrah/orgs","repos_url":"https://api.github.com/users/mhamrah/repos","events_url":"https://api.github.com/users/mhamrah/events{/privacy}","received_events_url":"https://api.github.com/users/mhamrah/received_events","type":"User","site_admin":false},"repo":{"id":38133408,"name":"kubernetes-coreos-units","full_name":"mhamrah/kubernetes-coreos-units","owner":{"login":"mhamrah","id":91162,"avatar_url":"https://avatars.githubusercontent.com/u/91162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhamrah","html_url":"https://github.com/mhamrah","followers_url":"https://api.github.com/users/mhamrah/followers","following_url":"https://api.github.com/users/mhamrah/following{/other_user}","gists_url":"https://api.github.com/users/mhamrah/gists{/gist_id}","starred_url":"https://api.github.com/users/mhamrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhamrah/subscriptions","organizations_url":"https://api.github.com/users/mhamrah/orgs","repos_url":"https://api.github.com/users/mhamrah/repos","events_url":"https://api.github.com/users/mhamrah/events{/privacy}","received_events_url":"https://api.github.com/users/mhamrah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhamrah/kubernetes-coreos-units","description":"Fleet Unit Files for Running Kubernetes on CoreOS","fork":false,"url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units","forks_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/forks","keys_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/teams","hooks_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/hooks","issue_events_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/events{/number}","events_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/events","assignees_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/assignees{/user}","branches_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/branches{/branch}","tags_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/tags","blobs_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/statuses/{sha}","languages_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/languages","stargazers_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/stargazers","contributors_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/contributors","subscribers_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/subscribers","subscription_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/subscription","commits_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/contents/{+path}","compare_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/merges","archive_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/downloads","issues_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues{/number}","pulls_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls{/number}","milestones_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/milestones{/number}","notifications_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/labels{/name}","releases_url":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/releases{/id}","created_at":"2015-06-26T20:58:50Z","updated_at":"2015-07-01T09:46:42Z","pushed_at":"2015-07-02T10:18:30Z","git_url":"git://github.com/mhamrah/kubernetes-coreos-units.git","ssh_url":"git@github.com:mhamrah/kubernetes-coreos-units.git","clone_url":"https://github.com/mhamrah/kubernetes-coreos-units.git","svn_url":"https://github.com/mhamrah/kubernetes-coreos-units","homepage":null,"size":0,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2"},"html":{"href":"https://github.com/mhamrah/kubernetes-coreos-units/pull/2"},"issue":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/2"},"comments":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mhamrah/kubernetes-coreos-units/statuses/b569e71bc0d5ed336f955599c2b8c3590915fb47"}}}}