{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/4348","labels_url":"https://api.github.com/repos/scipy/scipy/issues/4348/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/4348/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/4348/events","html_url":"https://github.com/scipy/scipy/pull/4348","id":53187988,"number":4348,"title":"Added exponential window","user":{"login":"jankoslavic","id":5072664,"avatar_url":"https://avatars.githubusercontent.com/u/5072664?v=3","gravatar_id":"","url":"https://api.github.com/users/jankoslavic","html_url":"https://github.com/jankoslavic","followers_url":"https://api.github.com/users/jankoslavic/followers","following_url":"https://api.github.com/users/jankoslavic/following{/other_user}","gists_url":"https://api.github.com/users/jankoslavic/gists{/gist_id}","starred_url":"https://api.github.com/users/jankoslavic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jankoslavic/subscriptions","organizations_url":"https://api.github.com/users/jankoslavic/orgs","repos_url":"https://api.github.com/users/jankoslavic/repos","events_url":"https://api.github.com/users/jankoslavic/events{/privacy}","received_events_url":"https://api.github.com/users/jankoslavic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scipy/scipy/labels/enhancement","name":"enhancement","color":"bfe5bf"},{"url":"https://api.github.com/repos/scipy/scipy/labels/scipy.signal","name":"scipy.signal","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/scipy/scipy/milestones/24","labels_url":"https://api.github.com/repos/scipy/scipy/milestones/24/labels","id":792277,"number":24,"title":"0.16.0","description":"","creator":{"login":"rgommers","id":98330,"avatar_url":"https://avatars.githubusercontent.com/u/98330?v=3","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":91,"state":"open","created_at":"2014-09-16T21:15:40Z","updated_at":"2015-01-04T18:15:35Z","due_on":"2016-03-30T07:00:00Z","closed_at":null},"comments":16,"created_at":"2014-12-31T15:17:47Z","updated_at":"2015-01-05T11:54:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/4348","html_url":"https://github.com/scipy/scipy/pull/4348","diff_url":"https://github.com/scipy/scipy/pull/4348.diff","patch_url":"https://github.com/scipy/scipy/pull/4348.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/68698752","html_url":"https://github.com/scipy/scipy/pull/4348#issuecomment-68698752","issue_url":"https://api.github.com/repos/scipy/scipy/issues/4348","id":68698752,"user":{"login":"FRidh","id":2129135,"avatar_url":"https://avatars.githubusercontent.com/u/2129135?v=3","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T11:54:24Z","updated_at":"2015-01-05T11:54:24Z","body":"The test should indeed fail because for `N=0` the shape is not symmetric anymore. While I suggested `N=0` as default value for `sym==False` I now think this is perhaps not such a good idea. Even though you most often would use `N=0` when analyzing impulse responses, this means the left side of the sequence is not necessarily zero. \r\n\r\nAn (acoustic) impulse response generally starts with a zero so it's not a problem, however, to fit with the other windows here it might be better to use `N=(M-1)/2` when `N==None` regardless of whether `sym` is `True` or `False`. This means the window will always \"look\" symmetric, and is going to zero at both sides, like the other windows do.\r\n\r\nThe `sym` option would then only calculate the window for `M+1` samples and truncate the final coefficient, again like the other windows.\r\n\r\nIt might be worth adding a note then in the documentation that if you would like to use this window to analyze an impulse response, you would have to prepend `L` zeros where `L` is the length of your impulse reponse, and then use `M=2L` for window length."}}