{"action":"closed","number":402,"pull_request":{"url":"https://api.github.com/repos/mothership-ec/cog/pulls/402","id":25358378,"html_url":"https://github.com/mothership-ec/cog/pull/402","diff_url":"https://github.com/mothership-ec/cog/pull/402.diff","patch_url":"https://github.com/mothership-ec/cog/pull/402.patch","issue_url":"https://api.github.com/repos/mothership-ec/cog/issues/402","number":402,"state":"closed","locked":false,"title":"Set umask to 0 before running asset tasks","user":{"login":"thomasjthomasj","id":4520924,"avatar_url":"https://avatars.githubusercontent.com/u/4520924?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasjthomasj","html_url":"https://github.com/thomasjthomasj","followers_url":"https://api.github.com/users/thomasjthomasj/followers","following_url":"https://api.github.com/users/thomasjthomasj/following{/other_user}","gists_url":"https://api.github.com/users/thomasjthomasj/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjthomasj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjthomasj/subscriptions","organizations_url":"https://api.github.com/users/thomasjthomasj/orgs","repos_url":"https://api.github.com/users/thomasjthomasj/repos","events_url":"https://api.github.com/users/thomasjthomasj/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjthomasj/received_events","type":"User","site_admin":false},"body":"#### What does this do?\r\nSets the `umask` of the PHP configuration to 0 before running tasks that involve setting permissions on directories.\r\n\r\nThe reason this is necessary is that sometimes PHP will try to set a permission on a directory to 0777 but because of what I can only describe as reasons, it will set the permissions to something like 0755. Setting the umask and then resetting ensures that the correct permissions are set (assuming PHP has permission to edit the permissions)\r\n\r\nSee: http://stackoverflow.com/questions/3997641/why-cant-php-create-a-directory-with-777-permissions\r\n\r\n#### How should this be manually tested?\r\nEmpty the `public/assets` and `public/cogules` folders and run `bin/cog asset:dump` and `bin/cog asset:generate`. They should a) not break and b) be the correct permissions\r\n\r\n#### Related PRs / Issues / Resources?\r\n\r\n#### Anything else to add? (Screenshots, background context, etc)\r\n","created_at":"2014-12-02T17:21:29Z","updated_at":"2015-03-25T10:04:53Z","closed_at":"2015-03-25T10:04:53Z","merged_at":null,"merge_commit_sha":"983cf351036614a2868d715fffc4080c1ce30aaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mothership-ec/cog/pulls/402/commits","review_comments_url":"https://api.github.com/repos/mothership-ec/cog/pulls/402/comments","review_comment_url":"https://api.github.com/repos/mothership-ec/cog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mothership-ec/cog/issues/402/comments","statuses_url":"https://api.github.com/repos/mothership-ec/cog/statuses/72baf3b024331f16bb517aefc01cc627308f49b0","head":{"label":"mothership-ec:feature/umask-on-asset-tasks","ref":"feature/umask-on-asset-tasks","sha":"72baf3b024331f16bb517aefc01cc627308f49b0","user":{"login":"mothership-ec","id":10222458,"avatar_url":"https://avatars.githubusercontent.com/u/10222458?v=3","gravatar_id":"","url":"https://api.github.com/users/mothership-ec","html_url":"https://github.com/mothership-ec","followers_url":"https://api.github.com/users/mothership-ec/followers","following_url":"https://api.github.com/users/mothership-ec/following{/other_user}","gists_url":"https://api.github.com/users/mothership-ec/gists{/gist_id}","starred_url":"https://api.github.com/users/mothership-ec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mothership-ec/subscriptions","organizations_url":"https://api.github.com/users/mothership-ec/orgs","repos_url":"https://api.github.com/users/mothership-ec/repos","events_url":"https://api.github.com/users/mothership-ec/events{/privacy}","received_events_url":"https://api.github.com/users/mothership-ec/received_events","type":"Organization","site_admin":false},"repo":{"id":10304735,"name":"cog","full_name":"mothership-ec/cog","owner":{"login":"mothership-ec","id":10222458,"avatar_url":"https://avatars.githubusercontent.com/u/10222458?v=3","gravatar_id":"","url":"https://api.github.com/users/mothership-ec","html_url":"https://github.com/mothership-ec","followers_url":"https://api.github.com/users/mothership-ec/followers","following_url":"https://api.github.com/users/mothership-ec/following{/other_user}","gists_url":"https://api.github.com/users/mothership-ec/gists{/gist_id}","starred_url":"https://api.github.com/users/mothership-ec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mothership-ec/subscriptions","organizations_url":"https://api.github.com/users/mothership-ec/orgs","repos_url":"https://api.github.com/users/mothership-ec/repos","events_url":"https://api.github.com/users/mothership-ec/events{/privacy}","received_events_url":"https://api.github.com/users/mothership-ec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mothership-ec/cog","description":"Cog","fork":false,"url":"https://api.github.com/repos/mothership-ec/cog","forks_url":"https://api.github.com/repos/mothership-ec/cog/forks","keys_url":"https://api.github.com/repos/mothership-ec/cog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mothership-ec/cog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mothership-ec/cog/teams","hooks_url":"https://api.github.com/repos/mothership-ec/cog/hooks","issue_events_url":"https://api.github.com/repos/mothership-ec/cog/issues/events{/number}","events_url":"https://api.github.com/repos/mothership-ec/cog/events","assignees_url":"https://api.github.com/repos/mothership-ec/cog/assignees{/user}","branches_url":"https://api.github.com/repos/mothership-ec/cog/branches{/branch}","tags_url":"https://api.github.com/repos/mothership-ec/cog/tags","blobs_url":"https://api.github.com/repos/mothership-ec/cog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mothership-ec/cog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mothership-ec/cog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mothership-ec/cog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mothership-ec/cog/statuses/{sha}","languages_url":"https://api.github.com/repos/mothership-ec/cog/languages","stargazers_url":"https://api.github.com/repos/mothership-ec/cog/stargazers","contributors_url":"https://api.github.com/repos/mothership-ec/cog/contributors","subscribers_url":"https://api.github.com/repos/mothership-ec/cog/subscribers","subscription_url":"https://api.github.com/repos/mothership-ec/cog/subscription","commits_url":"https://api.github.com/repos/mothership-ec/cog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mothership-ec/cog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mothership-ec/cog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mothership-ec/cog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mothership-ec/cog/contents/{+path}","compare_url":"https://api.github.com/repos/mothership-ec/cog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mothership-ec/cog/merges","archive_url":"https://api.github.com/repos/mothership-ec/cog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mothership-ec/cog/downloads","issues_url":"https://api.github.com/repos/mothership-ec/cog/issues{/number}","pulls_url":"https://api.github.com/repos/mothership-ec/cog/pulls{/number}","milestones_url":"https://api.github.com/repos/mothership-ec/cog/milestones{/number}","notifications_url":"https://api.github.com/repos/mothership-ec/cog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mothership-ec/cog/labels{/name}","releases_url":"https://api.github.com/repos/mothership-ec/cog/releases{/id}","created_at":"2013-05-26T23:04:09Z","updated_at":"2015-03-23T16:40:54Z","pushed_at":"2015-03-23T16:40:59Z","git_url":"git://github.com/mothership-ec/cog.git","ssh_url":"git@github.com:mothership-ec/cog.git","clone_url":"https://github.com/mothership-ec/cog.git","svn_url":"https://github.com/mothership-ec/cog","homepage":null,"size":7239,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":131,"forks":3,"open_issues":131,"watchers":3,"default_branch":"develop"}},"base":{"label":"mothership-ec:develop","ref":"develop","sha":"48c723972d4f82bbd0a47bedf452d93ff22a21ae","user":{"login":"mothership-ec","id":10222458,"avatar_url":"https://avatars.githubusercontent.com/u/10222458?v=3","gravatar_id":"","url":"https://api.github.com/users/mothership-ec","html_url":"https://github.com/mothership-ec","followers_url":"https://api.github.com/users/mothership-ec/followers","following_url":"https://api.github.com/users/mothership-ec/following{/other_user}","gists_url":"https://api.github.com/users/mothership-ec/gists{/gist_id}","starred_url":"https://api.github.com/users/mothership-ec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mothership-ec/subscriptions","organizations_url":"https://api.github.com/users/mothership-ec/orgs","repos_url":"https://api.github.com/users/mothership-ec/repos","events_url":"https://api.github.com/users/mothership-ec/events{/privacy}","received_events_url":"https://api.github.com/users/mothership-ec/received_events","type":"Organization","site_admin":false},"repo":{"id":10304735,"name":"cog","full_name":"mothership-ec/cog","owner":{"login":"mothership-ec","id":10222458,"avatar_url":"https://avatars.githubusercontent.com/u/10222458?v=3","gravatar_id":"","url":"https://api.github.com/users/mothership-ec","html_url":"https://github.com/mothership-ec","followers_url":"https://api.github.com/users/mothership-ec/followers","following_url":"https://api.github.com/users/mothership-ec/following{/other_user}","gists_url":"https://api.github.com/users/mothership-ec/gists{/gist_id}","starred_url":"https://api.github.com/users/mothership-ec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mothership-ec/subscriptions","organizations_url":"https://api.github.com/users/mothership-ec/orgs","repos_url":"https://api.github.com/users/mothership-ec/repos","events_url":"https://api.github.com/users/mothership-ec/events{/privacy}","received_events_url":"https://api.github.com/users/mothership-ec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mothership-ec/cog","description":"Cog","fork":false,"url":"https://api.github.com/repos/mothership-ec/cog","forks_url":"https://api.github.com/repos/mothership-ec/cog/forks","keys_url":"https://api.github.com/repos/mothership-ec/cog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mothership-ec/cog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mothership-ec/cog/teams","hooks_url":"https://api.github.com/repos/mothership-ec/cog/hooks","issue_events_url":"https://api.github.com/repos/mothership-ec/cog/issues/events{/number}","events_url":"https://api.github.com/repos/mothership-ec/cog/events","assignees_url":"https://api.github.com/repos/mothership-ec/cog/assignees{/user}","branches_url":"https://api.github.com/repos/mothership-ec/cog/branches{/branch}","tags_url":"https://api.github.com/repos/mothership-ec/cog/tags","blobs_url":"https://api.github.com/repos/mothership-ec/cog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mothership-ec/cog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mothership-ec/cog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mothership-ec/cog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mothership-ec/cog/statuses/{sha}","languages_url":"https://api.github.com/repos/mothership-ec/cog/languages","stargazers_url":"https://api.github.com/repos/mothership-ec/cog/stargazers","contributors_url":"https://api.github.com/repos/mothership-ec/cog/contributors","subscribers_url":"https://api.github.com/repos/mothership-ec/cog/subscribers","subscription_url":"https://api.github.com/repos/mothership-ec/cog/subscription","commits_url":"https://api.github.com/repos/mothership-ec/cog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mothership-ec/cog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mothership-ec/cog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mothership-ec/cog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mothership-ec/cog/contents/{+path}","compare_url":"https://api.github.com/repos/mothership-ec/cog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mothership-ec/cog/merges","archive_url":"https://api.github.com/repos/mothership-ec/cog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mothership-ec/cog/downloads","issues_url":"https://api.github.com/repos/mothership-ec/cog/issues{/number}","pulls_url":"https://api.github.com/repos/mothership-ec/cog/pulls{/number}","milestones_url":"https://api.github.com/repos/mothership-ec/cog/milestones{/number}","notifications_url":"https://api.github.com/repos/mothership-ec/cog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mothership-ec/cog/labels{/name}","releases_url":"https://api.github.com/repos/mothership-ec/cog/releases{/id}","created_at":"2013-05-26T23:04:09Z","updated_at":"2015-03-23T16:40:54Z","pushed_at":"2015-03-23T16:40:59Z","git_url":"git://github.com/mothership-ec/cog.git","ssh_url":"git@github.com:mothership-ec/cog.git","clone_url":"https://github.com/mothership-ec/cog.git","svn_url":"https://github.com/mothership-ec/cog","homepage":null,"size":7239,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":131,"forks":3,"open_issues":131,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mothership-ec/cog/pulls/402"},"html":{"href":"https://github.com/mothership-ec/cog/pull/402"},"issue":{"href":"https://api.github.com/repos/mothership-ec/cog/issues/402"},"comments":{"href":"https://api.github.com/repos/mothership-ec/cog/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/mothership-ec/cog/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/mothership-ec/cog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mothership-ec/cog/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/mothership-ec/cog/statuses/72baf3b024331f16bb517aefc01cc627308f49b0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":8,"deletions":0,"changed_files":3}}