{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/40787195","id":40787195,"diff_hunk":"@@ -237,11 +238,13 @@ public void removeListener(Listener listener) {\n \n     private Cluster getClusterForCurrentTopics(Cluster cluster) {\n         Collection<PartitionInfo> partitionInfos = new ArrayList<>();\n+        List<Node> nodes = Cluster.empty().nodes();","path":"clients/src/main/java/org/apache/kafka/clients/Metadata.java","position":12,"original_position":12,"commit_id":"960107edf131a710e1af808fe93a6ad8566098a5","original_commit_id":"960107edf131a710e1af808fe93a6ad8566098a5","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"This seems a roundabout way of saying Collections.emptyList, no?","created_at":"2015-09-30T12:27:39Z","updated_at":"2015-09-30T12:27:39Z","html_url":"https://github.com/apache/kafka/pull/262#discussion_r40787195","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/40787195"},"html":{"href":"https://github.com/apache/kafka/pull/262#discussion_r40787195"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/262","id":46329930,"html_url":"https://github.com/apache/kafka/pull/262","diff_url":"https://github.com/apache/kafka/pull/262.diff","patch_url":"https://github.com/apache/kafka/pull/262.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/262","number":262,"state":"open","locked":false,"title":"KAFKA-2599 Metadata#getClusterForCurrentTopics can throw NPE even wit…","user":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"body":"…h null checking","created_at":"2015-09-29T20:48:42Z","updated_at":"2015-09-30T12:27:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0e53a8c59439060daa9ad47d38054dfb5843269","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/262/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/262/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/262/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/960107edf131a710e1af808fe93a6ad8566098a5","head":{"label":"eribeiro:KAFKA-2599","ref":"KAFKA-2599","sha":"960107edf131a710e1af808fe93a6ad8566098a5","user":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"repo":{"id":41369262,"name":"kafka","full_name":"eribeiro/kafka","owner":{"login":"eribeiro","id":116156,"avatar_url":"https://avatars.githubusercontent.com/u/116156?v=3","gravatar_id":"","url":"https://api.github.com/users/eribeiro","html_url":"https://github.com/eribeiro","followers_url":"https://api.github.com/users/eribeiro/followers","following_url":"https://api.github.com/users/eribeiro/following{/other_user}","gists_url":"https://api.github.com/users/eribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/eribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eribeiro/subscriptions","organizations_url":"https://api.github.com/users/eribeiro/orgs","repos_url":"https://api.github.com/users/eribeiro/repos","events_url":"https://api.github.com/users/eribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/eribeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eribeiro/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/eribeiro/kafka","forks_url":"https://api.github.com/repos/eribeiro/kafka/forks","keys_url":"https://api.github.com/repos/eribeiro/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eribeiro/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eribeiro/kafka/teams","hooks_url":"https://api.github.com/repos/eribeiro/kafka/hooks","issue_events_url":"https://api.github.com/repos/eribeiro/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/eribeiro/kafka/events","assignees_url":"https://api.github.com/repos/eribeiro/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/eribeiro/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/eribeiro/kafka/tags","blobs_url":"https://api.github.com/repos/eribeiro/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eribeiro/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eribeiro/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/eribeiro/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eribeiro/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/eribeiro/kafka/languages","stargazers_url":"https://api.github.com/repos/eribeiro/kafka/stargazers","contributors_url":"https://api.github.com/repos/eribeiro/kafka/contributors","subscribers_url":"https://api.github.com/repos/eribeiro/kafka/subscribers","subscription_url":"https://api.github.com/repos/eribeiro/kafka/subscription","commits_url":"https://api.github.com/repos/eribeiro/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/eribeiro/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/eribeiro/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/eribeiro/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/eribeiro/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/eribeiro/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eribeiro/kafka/merges","archive_url":"https://api.github.com/repos/eribeiro/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eribeiro/kafka/downloads","issues_url":"https://api.github.com/repos/eribeiro/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/eribeiro/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/eribeiro/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/eribeiro/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eribeiro/kafka/labels{/name}","releases_url":"https://api.github.com/repos/eribeiro/kafka/releases{/id}","created_at":"2015-08-25T14:50:12Z","updated_at":"2015-08-25T14:50:15Z","pushed_at":"2015-09-29T21:51:40Z","git_url":"git://github.com/eribeiro/kafka.git","ssh_url":"git@github.com:eribeiro/kafka.git","clone_url":"https://github.com/eribeiro/kafka.git","svn_url":"https://github.com/eribeiro/kafka","homepage":null,"size":22040,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"f5596a851d8e8aa29686b6f9ae18cfa5183dd29c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-09-30T10:00:40Z","pushed_at":"2015-09-30T02:32:31Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":33786,"stargazers_count":1981,"watchers_count":1981,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1189,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":95,"forks":1189,"open_issues":95,"watchers":1981,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/262"},"html":{"href":"https://github.com/apache/kafka/pull/262"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/262"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/960107edf131a710e1af808fe93a6ad8566098a5"}}}}