{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/44859023","id":44859023,"diff_hunk":"@@ -1033,10 +1013,19 @@ private function tinyButtons()\n \t\t\t\t// Get the modal width/height\n \t\t\t\tif ($options)\n \t\t\t\t{\n-\t\t\t\t\tpreg_match('/x:\\s*+\\d{2,4}/', $options, $modalWidth);\n-\t\t\t\t\tpreg_match('/y:\\s*+\\d{2,4}/', $options, $modalHeight);\n-\t\t\t\t\t$modalWidth  = filter_var(implode(\"\", $modalWidth), FILTER_SANITIZE_NUMBER_INT);\n-\t\t\t\t\t$modalHeight = filter_var(implode(\"\", $modalHeight), FILTER_SANITIZE_NUMBER_INT);\n+\t\t\t\t\tpreg_match('/\\s*+(window)/', $options, $matches);","path":"plugins/editors/tinymce/tinymce.php","position":227,"original_position":245,"commit_id":"7d1b11b37dd32dc824eb7e01fc62b62b6bf77fb4","original_commit_id":"54c9cc9d02d33eb82423872598e02b59680eca5a","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"body":"ignore my previous comment, \r\nI totally missed that `getSize()` in `window.getSize()` comes from  mootools,\r\nnor `eval` nor my suggestion will not work here without mootools loaded","created_at":"2015-11-14T14:26:46Z","updated_at":"2015-11-14T14:26:46Z","html_url":"https://github.com/joomla/joomla-cms/pull/8366#discussion_r44859023","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/44859023"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/8366#discussion_r44859023"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366","id":50227530,"html_url":"https://github.com/joomla/joomla-cms/pull/8366","diff_url":"https://github.com/joomla/joomla-cms/pull/8366.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/8366.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8366","number":8366,"state":"open","locked":false,"title":"tinyMCE DRY for the inline script ","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"body":"#### DRY\r\nFew lines are repeated on the 3 different modes. We don’t have to…\r\n\r\nAlso instead of using tinyMCE.activeEditor we target exactly the editor we want. \r\n\r\n#### Testing\r\nUse tinyMCE as your editor. Try all different modes (simple, advanced, extended). ","created_at":"2015-11-10T08:47:34Z","updated_at":"2015-11-14T14:26:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a3905943b92ac4aad14edaa574faa4752705d83","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.5.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/7/labels","id":944889,"number":7,"title":"Joomla! 3.5.0","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":356,"state":"open","created_at":"2015-01-21T08:12:44Z","updated_at":"2015-11-14T08:29:26Z","due_on":"2015-12-07T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8366/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/7d1b11b37dd32dc824eb7e01fc62b62b6bf77fb4","head":{"label":"dgt41:tinyMceRedo","ref":"tinyMceRedo","sha":"7d1b11b37dd32dc824eb7e01fc62b62b6bf77fb4","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"repo":{"id":17825580,"name":"joomla-cms","full_name":"dgt41/joomla-cms","owner":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgt41/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/dgt41/joomla-cms","forks_url":"https://api.github.com/repos/dgt41/joomla-cms/forks","keys_url":"https://api.github.com/repos/dgt41/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgt41/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgt41/joomla-cms/teams","hooks_url":"https://api.github.com/repos/dgt41/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/dgt41/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/dgt41/joomla-cms/events","assignees_url":"https://api.github.com/repos/dgt41/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/dgt41/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/dgt41/joomla-cms/tags","blobs_url":"https://api.github.com/repos/dgt41/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgt41/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgt41/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgt41/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgt41/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/dgt41/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/dgt41/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/dgt41/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/dgt41/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/dgt41/joomla-cms/subscription","commits_url":"https://api.github.com/repos/dgt41/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgt41/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgt41/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgt41/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgt41/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/dgt41/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgt41/joomla-cms/merges","archive_url":"https://api.github.com/repos/dgt41/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgt41/joomla-cms/downloads","issues_url":"https://api.github.com/repos/dgt41/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/dgt41/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/dgt41/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/dgt41/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgt41/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/dgt41/joomla-cms/releases{/id}","created_at":"2014-03-17T11:18:00Z","updated_at":"2014-09-07T15:23:48Z","pushed_at":"2015-11-14T13:17:06Z","git_url":"git://github.com/dgt41/joomla-cms.git","ssh_url":"git@github.com:dgt41/joomla-cms.git","clone_url":"https://github.com/dgt41/joomla-cms.git","svn_url":"https://github.com/dgt41/joomla-cms","homepage":"http://joomla.org","size":0,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"____field.modulePosition"}},"base":{"label":"joomla:staging","ref":"staging","sha":"eea2e7d32cc9e6e15e01c4fedc643124035b8df6","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-11-14T06:51:25Z","pushed_at":"2015-11-14T13:17:07Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":0,"stargazers_count":1730,"watchers_count":1730,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1959,"mirror_url":null,"open_issues_count":534,"forks":1959,"open_issues":534,"watchers":1730,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/8366"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8366"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/8366/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/8366/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/7d1b11b37dd32dc824eb7e01fc62b62b6bf77fb4"}}}}