{"action":"opened","number":58,"pull_request":{"url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58","id":33387982,"html_url":"https://github.com/freedomjs/freedom-for-firefox/pull/58","diff_url":"https://github.com/freedomjs/freedom-for-firefox/pull/58.diff","patch_url":"https://github.com/freedomjs/freedom-for-firefox/pull/58.patch","issue_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/58","number":58,"state":"open","locked":false,"title":"Soycode fixintegrationtests","user":{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false},"body":"Meant to fix #57 - not ready yet but opening for easier examination/discussion. Summary:\r\n\r\n- The main goal is to ensure that onConnection/onDisconnect events are fired appropriately, particularly by client sockets.\r\n- The approach I'm taking is to have the connect continuation also dispatch onConnection, and to always set an onDisconnect for that dispatch as well that should be automatically called.\r\n- Per logging it does seem like the messages are firing in test, but the test still isn't passing (to reproduce, `grunt test` once to build the addon, then `cd .build` and `cfx run` and you can see logged output).\r\n\r\nMore investigation forthcoming.","created_at":"2015-04-15T19:27:06Z","updated_at":"2015-04-15T19:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58/commits","review_comments_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58/comments","review_comment_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/58/comments","statuses_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/statuses/84c19186252f8b5a8449351a39f1f7c614f33cb8","head":{"label":"freedomjs:soycode-fixintegrationtests","ref":"soycode-fixintegrationtests","sha":"84c19186252f8b5a8449351a39f1f7c614f33cb8","user":{"login":"freedomjs","id":5855670,"avatar_url":"https://avatars.githubusercontent.com/u/5855670?v=3","gravatar_id":"","url":"https://api.github.com/users/freedomjs","html_url":"https://github.com/freedomjs","followers_url":"https://api.github.com/users/freedomjs/followers","following_url":"https://api.github.com/users/freedomjs/following{/other_user}","gists_url":"https://api.github.com/users/freedomjs/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomjs/subscriptions","organizations_url":"https://api.github.com/users/freedomjs/orgs","repos_url":"https://api.github.com/users/freedomjs/repos","events_url":"https://api.github.com/users/freedomjs/events{/privacy}","received_events_url":"https://api.github.com/users/freedomjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18353469,"name":"freedom-for-firefox","full_name":"freedomjs/freedom-for-firefox","owner":{"login":"freedomjs","id":5855670,"avatar_url":"https://avatars.githubusercontent.com/u/5855670?v=3","gravatar_id":"","url":"https://api.github.com/users/freedomjs","html_url":"https://github.com/freedomjs","followers_url":"https://api.github.com/users/freedomjs/followers","following_url":"https://api.github.com/users/freedomjs/following{/other_user}","gists_url":"https://api.github.com/users/freedomjs/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomjs/subscriptions","organizations_url":"https://api.github.com/users/freedomjs/orgs","repos_url":"https://api.github.com/users/freedomjs/repos","events_url":"https://api.github.com/users/freedomjs/events{/privacy}","received_events_url":"https://api.github.com/users/freedomjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomjs/freedom-for-firefox","description":"freedom.js for firefox add-ons","fork":false,"url":"https://api.github.com/repos/freedomjs/freedom-for-firefox","forks_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/forks","keys_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/teams","hooks_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/hooks","issue_events_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/events{/number}","events_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/events","assignees_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/assignees{/user}","branches_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/branches{/branch}","tags_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/tags","blobs_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/languages","stargazers_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/stargazers","contributors_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/contributors","subscribers_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/subscribers","subscription_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/subscription","commits_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/contents/{+path}","compare_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/merges","archive_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/downloads","issues_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues{/number}","pulls_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/labels{/name}","releases_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/releases{/id}","created_at":"2014-04-02T03:28:53Z","updated_at":"2015-04-13T16:57:52Z","pushed_at":"2015-04-15T19:27:07Z","git_url":"git://github.com/freedomjs/freedom-for-firefox.git","ssh_url":"git@github.com:freedomjs/freedom-for-firefox.git","clone_url":"https://github.com/freedomjs/freedom-for-firefox.git","svn_url":"https://github.com/freedomjs/freedom-for-firefox","homepage":"http://freedomjs.org","size":984,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":1,"default_branch":"master"}},"base":{"label":"freedomjs:master","ref":"master","sha":"1e653fafe5dc907d52001b459b1b97336185938d","user":{"login":"freedomjs","id":5855670,"avatar_url":"https://avatars.githubusercontent.com/u/5855670?v=3","gravatar_id":"","url":"https://api.github.com/users/freedomjs","html_url":"https://github.com/freedomjs","followers_url":"https://api.github.com/users/freedomjs/followers","following_url":"https://api.github.com/users/freedomjs/following{/other_user}","gists_url":"https://api.github.com/users/freedomjs/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomjs/subscriptions","organizations_url":"https://api.github.com/users/freedomjs/orgs","repos_url":"https://api.github.com/users/freedomjs/repos","events_url":"https://api.github.com/users/freedomjs/events{/privacy}","received_events_url":"https://api.github.com/users/freedomjs/received_events","type":"Organization","site_admin":false},"repo":{"id":18353469,"name":"freedom-for-firefox","full_name":"freedomjs/freedom-for-firefox","owner":{"login":"freedomjs","id":5855670,"avatar_url":"https://avatars.githubusercontent.com/u/5855670?v=3","gravatar_id":"","url":"https://api.github.com/users/freedomjs","html_url":"https://github.com/freedomjs","followers_url":"https://api.github.com/users/freedomjs/followers","following_url":"https://api.github.com/users/freedomjs/following{/other_user}","gists_url":"https://api.github.com/users/freedomjs/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomjs/subscriptions","organizations_url":"https://api.github.com/users/freedomjs/orgs","repos_url":"https://api.github.com/users/freedomjs/repos","events_url":"https://api.github.com/users/freedomjs/events{/privacy}","received_events_url":"https://api.github.com/users/freedomjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomjs/freedom-for-firefox","description":"freedom.js for firefox add-ons","fork":false,"url":"https://api.github.com/repos/freedomjs/freedom-for-firefox","forks_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/forks","keys_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/teams","hooks_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/hooks","issue_events_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/events{/number}","events_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/events","assignees_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/assignees{/user}","branches_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/branches{/branch}","tags_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/tags","blobs_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/languages","stargazers_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/stargazers","contributors_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/contributors","subscribers_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/subscribers","subscription_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/subscription","commits_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/contents/{+path}","compare_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/merges","archive_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/downloads","issues_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues{/number}","pulls_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/labels{/name}","releases_url":"https://api.github.com/repos/freedomjs/freedom-for-firefox/releases{/id}","created_at":"2014-04-02T03:28:53Z","updated_at":"2015-04-13T16:57:52Z","pushed_at":"2015-04-15T19:27:07Z","git_url":"git://github.com/freedomjs/freedom-for-firefox.git","ssh_url":"git@github.com:freedomjs/freedom-for-firefox.git","clone_url":"https://github.com/freedomjs/freedom-for-firefox.git","svn_url":"https://github.com/freedomjs/freedom-for-firefox","homepage":"http://freedomjs.org","size":984,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58"},"html":{"href":"https://github.com/freedomjs/freedom-for-firefox/pull/58"},"issue":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/58"},"comments":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/freedomjs/freedom-for-firefox/statuses/84c19186252f8b5a8449351a39f1f7c614f33cb8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":91,"deletions":58,"changed_files":4}}