{"action":"created","comment":{"url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments/34432942","id":34432942,"diff_hunk":"@@ -518,38 +518,6 @@ void FileConnection::doLocking()\n   _ckpted_file = false;\n }\n \n-void FileConnection::handleUnlinkedFile()\n-{\n-  if ((!jalib::Filesystem::FileExists(_path) && !_isBlacklistedFile(_path)) ||\n-      _type == FILE_DELETED ||\n-      Util::strStartsWith(jalib::Filesystem::BaseName(_path), \".nfs\")) {\n-    /* File not present in Filesystem.\n-     * /proc/self/fd lists filename of unlink()ed files as:\n-     *   \"<original_file_name>(deleted)\"\n-     */\n-    string currPath = jalib::Filesystem::GetDeviceName(_fds[0]);\n-\n-    if (Util::strEndsWith(currPath, DELETED_FILE_SUFFIX)) {\n-      JTRACE(\"Deleted file\") (_path);\n-      _type = FILE_DELETED;","path":"src/plugin/ipc/file/fileconnection.cpp","position":17,"original_position":17,"commit_id":"7ab5aa6be91324f5fd759bf913321bf0ef536b5b","original_commit_id":"7ab5aa6be91324f5fd759bf913321bf0ef536b5b","user":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"body":"We just use a better way (`fstat()`) to detect \"unlinked\" files (see https://github.com/dmtcp/dmtcp/pull/141/files#diff-5d0e9b6251ae20cbd6e6a83177a3d586R550).","created_at":"2015-07-13T04:36:12Z","updated_at":"2015-07-13T04:36:12Z","html_url":"https://github.com/dmtcp/dmtcp/pull/141#discussion_r34432942","pull_request_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments/34432942"},"html":{"href":"https://github.com/dmtcp/dmtcp/pull/141#discussion_r34432942"},"pull_request":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141","id":39635925,"html_url":"https://github.com/dmtcp/dmtcp/pull/141","diff_url":"https://github.com/dmtcp/dmtcp/pull/141.diff","patch_url":"https://github.com/dmtcp/dmtcp/pull/141.patch","issue_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/141","number":141,"state":"open","locked":false,"title":"Better handling of deleted files.","user":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"body":"Some systems _prepend_ \" (deleted)\" instead of doing an _append_. This was observed on travis ci builds (https://travis-ci.org/dmtcp/dmtcp/builds/70006651).","created_at":"2015-07-09T22:36:59Z","updated_at":"2015-07-13T04:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25bb0f225e507903b8c1412448edf6cd93386416","assignee":null,"milestone":{"url":"https://api.github.com/repos/dmtcp/dmtcp/milestones/1","html_url":"https://github.com/dmtcp/dmtcp/milestones/2.4.0%20release","labels_url":"https://api.github.com/repos/dmtcp/dmtcp/milestones/1/labels","id":855599,"number":1,"title":"2.4.0 release","description":"The next DMTCP release.","creator":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":7,"state":"open","created_at":"2014-11-06T06:18:13Z","updated_at":"2015-07-09T22:36:59Z","due_on":"2015-11-20T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141/commits","review_comments_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141/comments","review_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/141/comments","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/7ab5aa6be91324f5fd759bf913321bf0ef536b5b","head":{"label":"karya0:deleted","ref":"deleted","sha":"7ab5aa6be91324f5fd759bf913321bf0ef536b5b","user":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"repo":{"id":24396411,"name":"dmtcp","full_name":"karya0/dmtcp","owner":{"login":"karya0","id":433762,"avatar_url":"https://avatars.githubusercontent.com/u/433762?v=3","gravatar_id":"","url":"https://api.github.com/users/karya0","html_url":"https://github.com/karya0","followers_url":"https://api.github.com/users/karya0/followers","following_url":"https://api.github.com/users/karya0/following{/other_user}","gists_url":"https://api.github.com/users/karya0/gists{/gist_id}","starred_url":"https://api.github.com/users/karya0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karya0/subscriptions","organizations_url":"https://api.github.com/users/karya0/orgs","repos_url":"https://api.github.com/users/karya0/repos","events_url":"https://api.github.com/users/karya0/events{/privacy}","received_events_url":"https://api.github.com/users/karya0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karya0/dmtcp","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":true,"url":"https://api.github.com/repos/karya0/dmtcp","forks_url":"https://api.github.com/repos/karya0/dmtcp/forks","keys_url":"https://api.github.com/repos/karya0/dmtcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karya0/dmtcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karya0/dmtcp/teams","hooks_url":"https://api.github.com/repos/karya0/dmtcp/hooks","issue_events_url":"https://api.github.com/repos/karya0/dmtcp/issues/events{/number}","events_url":"https://api.github.com/repos/karya0/dmtcp/events","assignees_url":"https://api.github.com/repos/karya0/dmtcp/assignees{/user}","branches_url":"https://api.github.com/repos/karya0/dmtcp/branches{/branch}","tags_url":"https://api.github.com/repos/karya0/dmtcp/tags","blobs_url":"https://api.github.com/repos/karya0/dmtcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karya0/dmtcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karya0/dmtcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/karya0/dmtcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karya0/dmtcp/statuses/{sha}","languages_url":"https://api.github.com/repos/karya0/dmtcp/languages","stargazers_url":"https://api.github.com/repos/karya0/dmtcp/stargazers","contributors_url":"https://api.github.com/repos/karya0/dmtcp/contributors","subscribers_url":"https://api.github.com/repos/karya0/dmtcp/subscribers","subscription_url":"https://api.github.com/repos/karya0/dmtcp/subscription","commits_url":"https://api.github.com/repos/karya0/dmtcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/karya0/dmtcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/karya0/dmtcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/karya0/dmtcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/karya0/dmtcp/contents/{+path}","compare_url":"https://api.github.com/repos/karya0/dmtcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karya0/dmtcp/merges","archive_url":"https://api.github.com/repos/karya0/dmtcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karya0/dmtcp/downloads","issues_url":"https://api.github.com/repos/karya0/dmtcp/issues{/number}","pulls_url":"https://api.github.com/repos/karya0/dmtcp/pulls{/number}","milestones_url":"https://api.github.com/repos/karya0/dmtcp/milestones{/number}","notifications_url":"https://api.github.com/repos/karya0/dmtcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karya0/dmtcp/labels{/name}","releases_url":"https://api.github.com/repos/karya0/dmtcp/releases{/id}","created_at":"2014-09-24T01:37:01Z","updated_at":"2015-05-07T03:24:02Z","pushed_at":"2015-07-09T22:41:49Z","git_url":"git://github.com/karya0/dmtcp.git","ssh_url":"git@github.com:karya0/dmtcp.git","clone_url":"https://github.com/karya0/dmtcp.git","svn_url":"https://github.com/karya0/dmtcp","homepage":"http://dmtcp.sourceforge.net/","size":11679,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmtcp:master","ref":"master","sha":"3067b7e48999a8595b607eb86a903a3cde01d35d","user":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"repo":{"id":24297650,"name":"dmtcp","full_name":"dmtcp/dmtcp","owner":{"login":"dmtcp","id":1207316,"avatar_url":"https://avatars.githubusercontent.com/u/1207316?v=3","gravatar_id":"","url":"https://api.github.com/users/dmtcp","html_url":"https://github.com/dmtcp","followers_url":"https://api.github.com/users/dmtcp/followers","following_url":"https://api.github.com/users/dmtcp/following{/other_user}","gists_url":"https://api.github.com/users/dmtcp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmtcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmtcp/subscriptions","organizations_url":"https://api.github.com/users/dmtcp/orgs","repos_url":"https://api.github.com/users/dmtcp/repos","events_url":"https://api.github.com/users/dmtcp/events{/privacy}","received_events_url":"https://api.github.com/users/dmtcp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmtcp/dmtcp","description":"DMTCP: Distributed MultiThreaded CheckPointing","fork":false,"url":"https://api.github.com/repos/dmtcp/dmtcp","forks_url":"https://api.github.com/repos/dmtcp/dmtcp/forks","keys_url":"https://api.github.com/repos/dmtcp/dmtcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmtcp/dmtcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmtcp/dmtcp/teams","hooks_url":"https://api.github.com/repos/dmtcp/dmtcp/hooks","issue_events_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/events{/number}","events_url":"https://api.github.com/repos/dmtcp/dmtcp/events","assignees_url":"https://api.github.com/repos/dmtcp/dmtcp/assignees{/user}","branches_url":"https://api.github.com/repos/dmtcp/dmtcp/branches{/branch}","tags_url":"https://api.github.com/repos/dmtcp/dmtcp/tags","blobs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmtcp/dmtcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmtcp/dmtcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmtcp/dmtcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmtcp/dmtcp/statuses/{sha}","languages_url":"https://api.github.com/repos/dmtcp/dmtcp/languages","stargazers_url":"https://api.github.com/repos/dmtcp/dmtcp/stargazers","contributors_url":"https://api.github.com/repos/dmtcp/dmtcp/contributors","subscribers_url":"https://api.github.com/repos/dmtcp/dmtcp/subscribers","subscription_url":"https://api.github.com/repos/dmtcp/dmtcp/subscription","commits_url":"https://api.github.com/repos/dmtcp/dmtcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmtcp/dmtcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmtcp/dmtcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmtcp/dmtcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmtcp/dmtcp/contents/{+path}","compare_url":"https://api.github.com/repos/dmtcp/dmtcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmtcp/dmtcp/merges","archive_url":"https://api.github.com/repos/dmtcp/dmtcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmtcp/dmtcp/downloads","issues_url":"https://api.github.com/repos/dmtcp/dmtcp/issues{/number}","pulls_url":"https://api.github.com/repos/dmtcp/dmtcp/pulls{/number}","milestones_url":"https://api.github.com/repos/dmtcp/dmtcp/milestones{/number}","notifications_url":"https://api.github.com/repos/dmtcp/dmtcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmtcp/dmtcp/labels{/name}","releases_url":"https://api.github.com/repos/dmtcp/dmtcp/releases{/id}","created_at":"2014-09-21T17:21:59Z","updated_at":"2015-07-06T00:22:50Z","pushed_at":"2015-07-13T00:05:31Z","git_url":"git://github.com/dmtcp/dmtcp.git","ssh_url":"git@github.com:dmtcp/dmtcp.git","clone_url":"https://github.com/dmtcp/dmtcp.git","svn_url":"https://github.com/dmtcp/dmtcp","homepage":"http://dmtcp.sourceforge.net/","size":16111,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":63,"forks":16,"open_issues":63,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141"},"html":{"href":"https://github.com/dmtcp/dmtcp/pull/141"},"issue":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/141"},"comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmtcp/dmtcp/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/dmtcp/dmtcp/statuses/7ab5aa6be91324f5fd759bf913321bf0ef536b5b"}}}}