{"action":"created","issue":{"url":"https://api.github.com/repos/conformal/btcjson/issues/36","labels_url":"https://api.github.com/repos/conformal/btcjson/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/conformal/btcjson/issues/36/comments","events_url":"https://api.github.com/repos/conformal/btcjson/issues/36/events","html_url":"https://github.com/conformal/btcjson/pull/36","id":54190765,"number":36,"title":"Add ErrWalletInvalidAccount","user":{"login":"tuxcanfly","id":132667,"avatar_url":"https://avatars.githubusercontent.com/u/132667?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxcanfly","html_url":"https://github.com/tuxcanfly","followers_url":"https://api.github.com/users/tuxcanfly/followers","following_url":"https://api.github.com/users/tuxcanfly/following{/other_user}","gists_url":"https://api.github.com/users/tuxcanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxcanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxcanfly/subscriptions","organizations_url":"https://api.github.com/users/tuxcanfly/orgs","repos_url":"https://api.github.com/users/tuxcanfly/repos","events_url":"https://api.github.com/users/tuxcanfly/events{/privacy}","received_events_url":"https://api.github.com/users/tuxcanfly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-13T12:58:09Z","updated_at":"2015-01-13T14:57:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conformal/btcjson/pulls/36","html_url":"https://github.com/conformal/btcjson/pull/36","diff_url":"https://github.com/conformal/btcjson/pull/36.diff","patch_url":"https://github.com/conformal/btcjson/pull/36.patch"},"body":"As mentioned in review at https://github.com/conformal/btcwallet/pull/155 we need a `btcjson` error type to indicate error dude to invalid account. To support this, I've added a new err `ErrWalletInvalidAccount`"},"comment":{"url":"https://api.github.com/repos/conformal/btcjson/issues/comments/69755995","html_url":"https://github.com/conformal/btcjson/pull/36#issuecomment-69755995","issue_url":"https://api.github.com/repos/conformal/btcjson/issues/36","id":69755995,"user":{"login":"jrick","id":1420313,"avatar_url":"https://avatars.githubusercontent.com/u/1420313?v=3","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T14:57:15Z","updated_at":"2015-01-13T14:57:15Z","body":"Agree that it makes sense to return an error in that case.  I just checked the bitcoind implementation and they return an empty string if the address is not found in the wallet (which would clash with the name of the default account).\r\n\r\nHowever, I'm still hesitant to create a new error code for this particular case.  The next wallet error code used by bitcoind will likely also be -18, and we will have to break compatibility with previous versions of our software if we try to match their change.  I think -4 (ErrWallet.Code) with a good message would be fine for this case."}}