{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/23472221","id":23472221,"diff_hunk":"@@ -108,14 +108,29 @@\n               metadata.checksum.should == \"{#{digest_algorithm}}#{checksum}\"\n             end\n \n-            it \"should give a mtime checksum when checksum_type is set\" do\n-              time = Time.now\n-              metadata.checksum_type = \"mtime\"\n-              metadata.expects(:mtime_file).returns(@time)\n+            it \"should give a #{Puppet[:digest_algorithm]} when checksum_type is set\" do\n+              Puppet[:digest_algorithm] = nil\n+              metadata.checksum_type = digest_algorithm\n               metadata.collect\n-              metadata.checksum.should == \"{mtime}#{@time}\"\n+              metadata.checksum.should == \"{#{digest_algorithm}}#{checksum}\"\n             end\n           end\n+\n+          it \"should give a mtime checksum when checksum_type is set\" do\n+            time = Time.now\n+            metadata.checksum_type = \"mtime\"\n+            metadata.expects(:mtime_file).returns(@time)\n+            metadata.collect\n+            metadata.checksum.should == \"{mtime}#{@time}\"\n+          end\n+\n+          it \"should give a ctime checksum when checksum_type is set\" do\n+            time = Time.now\n+            metadata.checksum_type = \"ctime\"\n+            metadata.expects(:ctime_file).returns(@time)","path":"spec/unit/file_serving/metadata_spec.rb","position":28,"original_position":28,"commit_id":"34dbaaa8564be89c372cf2e78362955a171f5e4a","original_commit_id":"34dbaaa8564be89c372cf2e78362955a171f5e4a","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"same comment here","created_at":"2015-01-23T19:15:51Z","updated_at":"2015-01-23T19:15:51Z","html_url":"https://github.com/puppetlabs/puppet/pull/3507#discussion_r23472221","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/23472221"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3507#discussion_r23472221"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507","id":27890242,"html_url":"https://github.com/puppetlabs/puppet/pull/3507","diff_url":"https://github.com/puppetlabs/puppet/pull/3507.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3507.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3507","number":3507,"state":"open","locked":false,"title":"(PUP-3887) Fix checksum option in file_server","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"The file_server uses the requested checksum_type to calculate a\r\nfile checksum, rather than always defaulting to md5.","created_at":"2015-01-22T23:59:47Z","updated_at":"2015-01-23T19:15:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f14939f8e79d6138db57d59797dff83fbf74f387","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3507/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/34dbaaa8564be89c372cf2e78362955a171f5e4a","head":{"label":"MikaelSmith:bug/master/PUP-3887-fix-server-checksum","ref":"bug/master/PUP-3887-fix-server-checksum","sha":"34dbaaa8564be89c372cf2e78362955a171f5e4a","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":22081114,"name":"puppet","full_name":"MikaelSmith/puppet","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/MikaelSmith/puppet","forks_url":"https://api.github.com/repos/MikaelSmith/puppet/forks","keys_url":"https://api.github.com/repos/MikaelSmith/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/puppet/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/puppet/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/puppet/events","assignees_url":"https://api.github.com/repos/MikaelSmith/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/puppet/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/puppet/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/puppet/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/puppet/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/puppet/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/puppet/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/MikaelSmith/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/puppet/merges","archive_url":"https://api.github.com/repos/MikaelSmith/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/puppet/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/puppet/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/puppet/releases{/id}","created_at":"2014-07-21T21:34:58Z","updated_at":"2015-01-22T23:35:44Z","pushed_at":"2015-01-23T18:31:58Z","git_url":"git://github.com/MikaelSmith/puppet.git","ssh_url":"git@github.com:MikaelSmith/puppet.git","clone_url":"https://github.com/MikaelSmith/puppet.git","svn_url":"https://github.com/MikaelSmith/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":44596,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"60b4939fc5fc5af5ad9b34615a1adf659a6bce6d","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-01-23T18:25:06Z","pushed_at":"2015-01-23T17:52:17Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":104486,"stargazers_count":2916,"watchers_count":2916,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1256,"mirror_url":null,"open_issues_count":36,"forks":1256,"open_issues":36,"watchers":2916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3507"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3507"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3507/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3507/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/34dbaaa8564be89c372cf2e78362955a171f5e4a"}}}}