{"action":"created","issue":{"url":"https://api.github.com/repos/contao/core-bundle/issues/374","labels_url":"https://api.github.com/repos/contao/core-bundle/issues/374/labels{/name}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/374/comments","events_url":"https://api.github.com/repos/contao/core-bundle/issues/374/events","html_url":"https://github.com/contao/core-bundle/pull/374","id":112821716,"number":374,"title":"[RFC] Extracting the request token handling from the framework","user":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-22T14:56:39Z","updated_at":"2015-10-22T20:13:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/374","html_url":"https://github.com/contao/core-bundle/pull/374","diff_url":"https://github.com/contao/core-bundle/pull/374.diff","patch_url":"https://github.com/contao/core-bundle/pull/374.patch"},"body":"Here's the first draft. Open questions:\r\n\r\n* See my `@todo`. This was copied from the original source but shouldn't this target route be different?\r\n* Same question as we had several times: Am I allowed to change the constructor of `ContaoFramework`? We really need to make a decision here once and for all.\r\n* Is the naming for `contao.request_token.routes` okay?\r\n* Where should the default settings for `contao.request_token.routes` go?\r\n* Does the listener have to have any special priority?\r\n* Isn't removing the request handling from the `ContaoFramework` a BC break? It automatically checked in Contao 4 but doesn't in Contao 4.1 anymore unless you enable it for your route...\r\n\r\nAnd of course the unit tests are missing but I'll add them once we got the questions sorted."},"comment":{"url":"https://api.github.com/repos/contao/core-bundle/issues/comments/150343430","html_url":"https://github.com/contao/core-bundle/pull/374#issuecomment-150343430","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/374","id":150343430,"user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T20:13:27Z","updated_at":"2015-10-22T20:13:27Z","body":"I think `contao.request_token.routes` will not work, because it's an array. It can't be extended by third-party bundles. Why not use route attributes for that (similar to the scope)?"}}