{"action":"opened","number":2730,"pull_request":{"url":"https://api.github.com/repos/ckan/ckan/pulls/2730","id":50531098,"html_url":"https://github.com/ckan/ckan/pull/2730","diff_url":"https://github.com/ckan/ckan/pull/2730.diff","patch_url":"https://github.com/ckan/ckan/pull/2730.patch","issue_url":"https://api.github.com/repos/ckan/ckan/issues/2730","number":2730,"state":"open","locked":false,"title":"SQL executes audit","user":{"login":"davidread","id":307612,"avatar_url":"https://avatars.githubusercontent.com/u/307612?v=3","gravatar_id":"","url":"https://api.github.com/users/davidread","html_url":"https://github.com/davidread","followers_url":"https://api.github.com/users/davidread/followers","following_url":"https://api.github.com/users/davidread/following{/other_user}","gists_url":"https://api.github.com/users/davidread/gists{/gist_id}","starred_url":"https://api.github.com/users/davidread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidread/subscriptions","organizations_url":"https://api.github.com/users/davidread/orgs","repos_url":"https://api.github.com/users/davidread/repos","events_url":"https://api.github.com/users/davidread/events{/privacy}","received_events_url":"https://api.github.com/users/davidread/received_events","type":"User","site_admin":false},"body":"I grepped for all SQL execute statements and where possible I changed them so params are passed to execute, rather than substituted into the string beforehand (for security reasons). Pleased to see there are only a couple of very minor things that could be improved.","created_at":"2015-11-12T16:16:00Z","updated_at":"2015-11-12T16:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckan/ckan/pulls/2730/commits","review_comments_url":"https://api.github.com/repos/ckan/ckan/pulls/2730/comments","review_comment_url":"https://api.github.com/repos/ckan/ckan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckan/ckan/issues/2730/comments","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/8a2f0afb2b449f1d5297ed34379f6cd4ae61ddc7","head":{"label":"ckan:sql-params","ref":"sql-params","sha":"8a2f0afb2b449f1d5297ed34379f6cd4ae61ddc7","user":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"repo":{"id":2750721,"name":"ckan","full_name":"ckan/ckan","owner":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckan/ckan","description":"CKAN is an open-source DMS (data management system) for powering data hubs and data portals. CKAN makes it easy to publish, share and use data. It powers datahub.io, catalog.data.gov and data.gov.uk among many other sites.","fork":false,"url":"https://api.github.com/repos/ckan/ckan","forks_url":"https://api.github.com/repos/ckan/ckan/forks","keys_url":"https://api.github.com/repos/ckan/ckan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckan/ckan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckan/ckan/teams","hooks_url":"https://api.github.com/repos/ckan/ckan/hooks","issue_events_url":"https://api.github.com/repos/ckan/ckan/issues/events{/number}","events_url":"https://api.github.com/repos/ckan/ckan/events","assignees_url":"https://api.github.com/repos/ckan/ckan/assignees{/user}","branches_url":"https://api.github.com/repos/ckan/ckan/branches{/branch}","tags_url":"https://api.github.com/repos/ckan/ckan/tags","blobs_url":"https://api.github.com/repos/ckan/ckan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckan/ckan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckan/ckan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckan/ckan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/{sha}","languages_url":"https://api.github.com/repos/ckan/ckan/languages","stargazers_url":"https://api.github.com/repos/ckan/ckan/stargazers","contributors_url":"https://api.github.com/repos/ckan/ckan/contributors","subscribers_url":"https://api.github.com/repos/ckan/ckan/subscribers","subscription_url":"https://api.github.com/repos/ckan/ckan/subscription","commits_url":"https://api.github.com/repos/ckan/ckan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckan/ckan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckan/ckan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckan/ckan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckan/ckan/contents/{+path}","compare_url":"https://api.github.com/repos/ckan/ckan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckan/ckan/merges","archive_url":"https://api.github.com/repos/ckan/ckan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckan/ckan/downloads","issues_url":"https://api.github.com/repos/ckan/ckan/issues{/number}","pulls_url":"https://api.github.com/repos/ckan/ckan/pulls{/number}","milestones_url":"https://api.github.com/repos/ckan/ckan/milestones{/number}","notifications_url":"https://api.github.com/repos/ckan/ckan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckan/ckan/labels{/name}","releases_url":"https://api.github.com/repos/ckan/ckan/releases{/id}","created_at":"2011-11-10T18:42:17Z","updated_at":"2015-11-12T15:26:01Z","pushed_at":"2015-11-12T16:05:41Z","git_url":"git://github.com/ckan/ckan.git","ssh_url":"git@github.com:ckan/ckan.git","clone_url":"https://github.com/ckan/ckan.git","svn_url":"https://github.com/ckan/ckan","homepage":"http://ckan.org/","size":208277,"stargazers_count":1065,"watchers_count":1065,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":337,"forks":580,"open_issues":337,"watchers":1065,"default_branch":"master"}},"base":{"label":"ckan:master","ref":"master","sha":"f74575024a472085db2c8238d8f0ff71d888ffaf","user":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"repo":{"id":2750721,"name":"ckan","full_name":"ckan/ckan","owner":{"login":"ckan","id":1630326,"avatar_url":"https://avatars.githubusercontent.com/u/1630326?v=3","gravatar_id":"","url":"https://api.github.com/users/ckan","html_url":"https://github.com/ckan","followers_url":"https://api.github.com/users/ckan/followers","following_url":"https://api.github.com/users/ckan/following{/other_user}","gists_url":"https://api.github.com/users/ckan/gists{/gist_id}","starred_url":"https://api.github.com/users/ckan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckan/subscriptions","organizations_url":"https://api.github.com/users/ckan/orgs","repos_url":"https://api.github.com/users/ckan/repos","events_url":"https://api.github.com/users/ckan/events{/privacy}","received_events_url":"https://api.github.com/users/ckan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckan/ckan","description":"CKAN is an open-source DMS (data management system) for powering data hubs and data portals. CKAN makes it easy to publish, share and use data. It powers datahub.io, catalog.data.gov and data.gov.uk among many other sites.","fork":false,"url":"https://api.github.com/repos/ckan/ckan","forks_url":"https://api.github.com/repos/ckan/ckan/forks","keys_url":"https://api.github.com/repos/ckan/ckan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckan/ckan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckan/ckan/teams","hooks_url":"https://api.github.com/repos/ckan/ckan/hooks","issue_events_url":"https://api.github.com/repos/ckan/ckan/issues/events{/number}","events_url":"https://api.github.com/repos/ckan/ckan/events","assignees_url":"https://api.github.com/repos/ckan/ckan/assignees{/user}","branches_url":"https://api.github.com/repos/ckan/ckan/branches{/branch}","tags_url":"https://api.github.com/repos/ckan/ckan/tags","blobs_url":"https://api.github.com/repos/ckan/ckan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckan/ckan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckan/ckan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckan/ckan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckan/ckan/statuses/{sha}","languages_url":"https://api.github.com/repos/ckan/ckan/languages","stargazers_url":"https://api.github.com/repos/ckan/ckan/stargazers","contributors_url":"https://api.github.com/repos/ckan/ckan/contributors","subscribers_url":"https://api.github.com/repos/ckan/ckan/subscribers","subscription_url":"https://api.github.com/repos/ckan/ckan/subscription","commits_url":"https://api.github.com/repos/ckan/ckan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckan/ckan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckan/ckan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckan/ckan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckan/ckan/contents/{+path}","compare_url":"https://api.github.com/repos/ckan/ckan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckan/ckan/merges","archive_url":"https://api.github.com/repos/ckan/ckan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckan/ckan/downloads","issues_url":"https://api.github.com/repos/ckan/ckan/issues{/number}","pulls_url":"https://api.github.com/repos/ckan/ckan/pulls{/number}","milestones_url":"https://api.github.com/repos/ckan/ckan/milestones{/number}","notifications_url":"https://api.github.com/repos/ckan/ckan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckan/ckan/labels{/name}","releases_url":"https://api.github.com/repos/ckan/ckan/releases{/id}","created_at":"2011-11-10T18:42:17Z","updated_at":"2015-11-12T15:26:01Z","pushed_at":"2015-11-12T16:05:41Z","git_url":"git://github.com/ckan/ckan.git","ssh_url":"git@github.com:ckan/ckan.git","clone_url":"https://github.com/ckan/ckan.git","svn_url":"https://github.com/ckan/ckan","homepage":"http://ckan.org/","size":208277,"stargazers_count":1065,"watchers_count":1065,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":337,"forks":580,"open_issues":337,"watchers":1065,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckan/ckan/pulls/2730"},"html":{"href":"https://github.com/ckan/ckan/pull/2730"},"issue":{"href":"https://api.github.com/repos/ckan/ckan/issues/2730"},"comments":{"href":"https://api.github.com/repos/ckan/ckan/issues/2730/comments"},"review_comments":{"href":"https://api.github.com/repos/ckan/ckan/pulls/2730/comments"},"review_comment":{"href":"https://api.github.com/repos/ckan/ckan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckan/ckan/pulls/2730/commits"},"statuses":{"href":"https://api.github.com/repos/ckan/ckan/statuses/8a2f0afb2b449f1d5297ed34379f6cd4ae61ddc7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":14,"changed_files":2}}