{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/jimhester/lintr/pulls/49","id":28775233,"html_url":"https://github.com/jimhester/lintr/pull/49","diff_url":"https://github.com/jimhester/lintr/pull/49.diff","patch_url":"https://github.com/jimhester/lintr/pull/49.patch","issue_url":"https://api.github.com/repos/jimhester/lintr/issues/49","number":49,"state":"closed","locked":false,"title":"reorganize a bit; add names.lints, split.lints methods; get lintr to pass most of its own lints :-)","user":{"login":"ttriche","id":4386,"avatar_url":"https://avatars.githubusercontent.com/u/4386?v=3","gravatar_id":"","url":"https://api.github.com/users/ttriche","html_url":"https://github.com/ttriche","followers_url":"https://api.github.com/users/ttriche/followers","following_url":"https://api.github.com/users/ttriche/following{/other_user}","gists_url":"https://api.github.com/users/ttriche/gists{/gist_id}","starred_url":"https://api.github.com/users/ttriche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttriche/subscriptions","organizations_url":"https://api.github.com/users/ttriche/orgs","repos_url":"https://api.github.com/users/ttriche/repos","events_url":"https://api.github.com/users/ttriche/events{/privacy}","received_events_url":"https://api.github.com/users/ttriche/received_events","type":"User","site_admin":false},"body":"Hopefully the changes will be fairly obvious.  The methods are primarily so that I can run a command like:\r\n\r\n```\r\nlints <- lint_package('lintr')\r\nsubdir <- Vectorize(function(x) strsplit(sub(\"./\", \"\", fixed=TRUE, x), \"/\")[[1]][1])\r\nby_subdir <- split(lints, subdir(lints))\r\n```\r\n\r\nand get something relatively easy to follow\r\n\r\n```\r\nactually_care_about <- grep('80 characters', vapply(by_subdir$R, `[[`, character(1), 'message'), invert=TRUE)\r\nby_subdir$R[ actually_care_about ]\r\n```\r\n\r\n```\r\n[[1]]\r\n./R/expect_lint.R:68:3: warning: local variable 'itr' assigned but may not be used\r\n  itr <- 0L\r\n  ^~~\r\n\r\n[[2]]\r\n./R/get_source_expressions.R:225:5: style: Closing curly-braces should always be on their own line, unless it's followed by an else.\r\n    })(prev_locs == lag(next_locs))\r\n    ^\r\n\r\n[[3]]\r\n./R/lint.R:48:54: style: Place a space before left parenthesis, except in a function call.\r\n        expr_lints <- flatten_lints(linters[[linter]](expr))                                                 ^\r\n```\r\n\r\n","created_at":"2015-02-06T00:27:14Z","updated_at":"2015-02-06T13:52:10Z","closed_at":"2015-02-06T13:52:10Z","merged_at":"2015-02-06T13:52:10Z","merge_commit_sha":"a7e60bf70b9e60545c6822412de10fa27f7e7f5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jimhester/lintr/pulls/49/commits","review_comments_url":"https://api.github.com/repos/jimhester/lintr/pulls/49/comments","review_comment_url":"https://api.github.com/repos/jimhester/lintr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jimhester/lintr/issues/49/comments","statuses_url":"https://api.github.com/repos/jimhester/lintr/statuses/427e177926421819b917c4dd55cd3c42cb231525","head":{"label":"ttriche:master","ref":"master","sha":"427e177926421819b917c4dd55cd3c42cb231525","user":{"login":"ttriche","id":4386,"avatar_url":"https://avatars.githubusercontent.com/u/4386?v=3","gravatar_id":"","url":"https://api.github.com/users/ttriche","html_url":"https://github.com/ttriche","followers_url":"https://api.github.com/users/ttriche/followers","following_url":"https://api.github.com/users/ttriche/following{/other_user}","gists_url":"https://api.github.com/users/ttriche/gists{/gist_id}","starred_url":"https://api.github.com/users/ttriche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttriche/subscriptions","organizations_url":"https://api.github.com/users/ttriche/orgs","repos_url":"https://api.github.com/users/ttriche/repos","events_url":"https://api.github.com/users/ttriche/events{/privacy}","received_events_url":"https://api.github.com/users/ttriche/received_events","type":"User","site_admin":false},"repo":{"id":30315267,"name":"lintr","full_name":"ttriche/lintr","owner":{"login":"ttriche","id":4386,"avatar_url":"https://avatars.githubusercontent.com/u/4386?v=3","gravatar_id":"","url":"https://api.github.com/users/ttriche","html_url":"https://github.com/ttriche","followers_url":"https://api.github.com/users/ttriche/followers","following_url":"https://api.github.com/users/ttriche/following{/other_user}","gists_url":"https://api.github.com/users/ttriche/gists{/gist_id}","starred_url":"https://api.github.com/users/ttriche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttriche/subscriptions","organizations_url":"https://api.github.com/users/ttriche/orgs","repos_url":"https://api.github.com/users/ttriche/repos","events_url":"https://api.github.com/users/ttriche/events{/privacy}","received_events_url":"https://api.github.com/users/ttriche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttriche/lintr","description":"Static Code Analysis for R","fork":true,"url":"https://api.github.com/repos/ttriche/lintr","forks_url":"https://api.github.com/repos/ttriche/lintr/forks","keys_url":"https://api.github.com/repos/ttriche/lintr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttriche/lintr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttriche/lintr/teams","hooks_url":"https://api.github.com/repos/ttriche/lintr/hooks","issue_events_url":"https://api.github.com/repos/ttriche/lintr/issues/events{/number}","events_url":"https://api.github.com/repos/ttriche/lintr/events","assignees_url":"https://api.github.com/repos/ttriche/lintr/assignees{/user}","branches_url":"https://api.github.com/repos/ttriche/lintr/branches{/branch}","tags_url":"https://api.github.com/repos/ttriche/lintr/tags","blobs_url":"https://api.github.com/repos/ttriche/lintr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttriche/lintr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttriche/lintr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttriche/lintr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttriche/lintr/statuses/{sha}","languages_url":"https://api.github.com/repos/ttriche/lintr/languages","stargazers_url":"https://api.github.com/repos/ttriche/lintr/stargazers","contributors_url":"https://api.github.com/repos/ttriche/lintr/contributors","subscribers_url":"https://api.github.com/repos/ttriche/lintr/subscribers","subscription_url":"https://api.github.com/repos/ttriche/lintr/subscription","commits_url":"https://api.github.com/repos/ttriche/lintr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttriche/lintr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttriche/lintr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttriche/lintr/issues/comments/{number}","contents_url":"https://api.github.com/repos/ttriche/lintr/contents/{+path}","compare_url":"https://api.github.com/repos/ttriche/lintr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttriche/lintr/merges","archive_url":"https://api.github.com/repos/ttriche/lintr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttriche/lintr/downloads","issues_url":"https://api.github.com/repos/ttriche/lintr/issues{/number}","pulls_url":"https://api.github.com/repos/ttriche/lintr/pulls{/number}","milestones_url":"https://api.github.com/repos/ttriche/lintr/milestones{/number}","notifications_url":"https://api.github.com/repos/ttriche/lintr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttriche/lintr/labels{/name}","releases_url":"https://api.github.com/repos/ttriche/lintr/releases{/id}","created_at":"2015-02-04T18:55:02Z","updated_at":"2015-02-06T00:16:10Z","pushed_at":"2015-02-06T00:16:08Z","git_url":"git://github.com/ttriche/lintr.git","ssh_url":"git@github.com:ttriche/lintr.git","clone_url":"https://github.com/ttriche/lintr.git","svn_url":"https://github.com/ttriche/lintr","homepage":"","size":744,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jimhester:master","ref":"master","sha":"734c61499db7a8ec3852f231a80ba32813b96b29","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":24548375,"name":"lintr","full_name":"jimhester/lintr","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/lintr","description":"Static Code Analysis for R","fork":false,"url":"https://api.github.com/repos/jimhester/lintr","forks_url":"https://api.github.com/repos/jimhester/lintr/forks","keys_url":"https://api.github.com/repos/jimhester/lintr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/lintr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/lintr/teams","hooks_url":"https://api.github.com/repos/jimhester/lintr/hooks","issue_events_url":"https://api.github.com/repos/jimhester/lintr/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/lintr/events","assignees_url":"https://api.github.com/repos/jimhester/lintr/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/lintr/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/lintr/tags","blobs_url":"https://api.github.com/repos/jimhester/lintr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/lintr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/lintr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/lintr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/lintr/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/lintr/languages","stargazers_url":"https://api.github.com/repos/jimhester/lintr/stargazers","contributors_url":"https://api.github.com/repos/jimhester/lintr/contributors","subscribers_url":"https://api.github.com/repos/jimhester/lintr/subscribers","subscription_url":"https://api.github.com/repos/jimhester/lintr/subscription","commits_url":"https://api.github.com/repos/jimhester/lintr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/lintr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/lintr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/lintr/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimhester/lintr/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/lintr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/lintr/merges","archive_url":"https://api.github.com/repos/jimhester/lintr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/lintr/downloads","issues_url":"https://api.github.com/repos/jimhester/lintr/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/lintr/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/lintr/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/lintr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/lintr/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/lintr/releases{/id}","created_at":"2014-09-28T02:48:15Z","updated_at":"2015-02-05T14:35:35Z","pushed_at":"2015-02-06T13:52:10Z","git_url":"git://github.com/jimhester/lintr.git","ssh_url":"git@github.com:jimhester/lintr.git","clone_url":"https://github.com/jimhester/lintr.git","svn_url":"https://github.com/jimhester/lintr","homepage":"","size":744,"stargazers_count":50,"watchers_count":50,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":20,"forks":6,"open_issues":20,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimhester/lintr/pulls/49"},"html":{"href":"https://github.com/jimhester/lintr/pull/49"},"issue":{"href":"https://api.github.com/repos/jimhester/lintr/issues/49"},"comments":{"href":"https://api.github.com/repos/jimhester/lintr/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/jimhester/lintr/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/jimhester/lintr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jimhester/lintr/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/jimhester/lintr/statuses/427e177926421819b917c4dd55cd3c42cb231525"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":52,"deletions":40,"changed_files":7}}