{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup/pulls/comments/24641855","id":24641855,"diff_hunk":"@@ -98,31 +101,50 @@ public void testSkippedArchivesFound() throws Exception\n             wc.setOptionValue(OverwriteOption.NAME, true);\n             wc.setRuleProviderFilter(new Predicate<WindupRuleProvider>()\n             {\n+                private RuleProviderWithDependenciesPredicate discoverRuleDeps\n+                        = new RuleProviderWithDependenciesPredicate(DiscoverFilesAndTypesRuleProvider.class);\n+\n                 @Override\n-                public boolean accept(WindupRuleProvider type)\n+                public boolean accept(WindupRuleProvider rules)\n                 {\n-                    return !(type.getPhase().isAssignableFrom(ReportGeneration.class))\n-                                && !(type.getPhase().isAssignableFrom(ReportRendering.class))\n-                                && !(type.getPhase().isAssignableFrom(Decompilation.class))\n-                                && !(type.getPhase().isAssignableFrom(MigrationRules.class));\n+                    /*return !(type.getPhase().isAssignableFrom(ReportGeneration.class))\n+                        && !(type.getPhase().isAssignableFrom(ReportRendering.class))","path":"rules-java-archives/tests/src/test/java/org/jboss/windup/rules/apps/java/archives/SkipArchivesRulesetTest.java","position":52,"original_position":52,"commit_id":"ac51642790347872fee3e3cac3dd399b779a9941","original_commit_id":"ac51642790347872fee3e3cac3dd399b779a9941","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-02-13T03:12:05Z","updated_at":"2015-02-13T03:12:05Z","html_url":"https://github.com/windup/windup/pull/464#discussion_r24641855","pull_request_url":"https://api.github.com/repos/windup/windup/pulls/464","_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/comments/24641855"},"html":{"href":"https://github.com/windup/windup/pull/464#discussion_r24641855"},"pull_request":{"href":"https://api.github.com/repos/windup/windup/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup/pulls/464","id":29097626,"html_url":"https://github.com/windup/windup/pull/464","diff_url":"https://github.com/windup/windup/pull/464.diff","patch_url":"https://github.com/windup/windup/pull/464.patch","issue_url":"https://api.github.com/repos/windup/windup/issues/464","number":464,"state":"open","locked":false,"title":"WINDUP-506  Identify Archives Ruleset: Improve memory footprint, fix GAPCV handling, introduce interface.","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"body":"Comes with https://github.com/windup/nexus-repository-indexer/pull/1","created_at":"2015-02-11T15:05:44Z","updated_at":"2015-02-13T03:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d487d068ecf2cb326bcec9093ca4ded0f95c647","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup/pulls/464/commits","review_comments_url":"https://api.github.com/repos/windup/windup/pulls/464/comments","review_comment_url":"https://api.github.com/repos/windup/windup/pulls/comments/{number}","comments_url":"https://api.github.com/repos/windup/windup/issues/464/comments","statuses_url":"https://api.github.com/repos/windup/windup/statuses/ac51642790347872fee3e3cac3dd399b779a9941","head":{"label":"OndraZizka:identArch2","ref":"identArch2","sha":"ac51642790347872fee3e3cac3dd399b779a9941","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"repo":{"id":10457496,"name":"windup","full_name":"OndraZizka/windup","owner":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OndraZizka/windup","description":"Windup","fork":true,"url":"https://api.github.com/repos/OndraZizka/windup","forks_url":"https://api.github.com/repos/OndraZizka/windup/forks","keys_url":"https://api.github.com/repos/OndraZizka/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OndraZizka/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OndraZizka/windup/teams","hooks_url":"https://api.github.com/repos/OndraZizka/windup/hooks","issue_events_url":"https://api.github.com/repos/OndraZizka/windup/issues/events{/number}","events_url":"https://api.github.com/repos/OndraZizka/windup/events","assignees_url":"https://api.github.com/repos/OndraZizka/windup/assignees{/user}","branches_url":"https://api.github.com/repos/OndraZizka/windup/branches{/branch}","tags_url":"https://api.github.com/repos/OndraZizka/windup/tags","blobs_url":"https://api.github.com/repos/OndraZizka/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OndraZizka/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OndraZizka/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/OndraZizka/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OndraZizka/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/OndraZizka/windup/languages","stargazers_url":"https://api.github.com/repos/OndraZizka/windup/stargazers","contributors_url":"https://api.github.com/repos/OndraZizka/windup/contributors","subscribers_url":"https://api.github.com/repos/OndraZizka/windup/subscribers","subscription_url":"https://api.github.com/repos/OndraZizka/windup/subscription","commits_url":"https://api.github.com/repos/OndraZizka/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/OndraZizka/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/OndraZizka/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/OndraZizka/windup/issues/comments/{number}","contents_url":"https://api.github.com/repos/OndraZizka/windup/contents/{+path}","compare_url":"https://api.github.com/repos/OndraZizka/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OndraZizka/windup/merges","archive_url":"https://api.github.com/repos/OndraZizka/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OndraZizka/windup/downloads","issues_url":"https://api.github.com/repos/OndraZizka/windup/issues{/number}","pulls_url":"https://api.github.com/repos/OndraZizka/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/OndraZizka/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/OndraZizka/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OndraZizka/windup/labels{/name}","releases_url":"https://api.github.com/repos/OndraZizka/windup/releases{/id}","created_at":"2013-06-03T15:17:47Z","updated_at":"2014-12-10T04:13:57Z","pushed_at":"2015-02-12T02:09:11Z","git_url":"git://github.com/OndraZizka/windup.git","ssh_url":"git@github.com:OndraZizka/windup.git","clone_url":"https://github.com/OndraZizka/windup.git","svn_url":"https://github.com/OndraZizka/windup","homepage":null,"size":35395,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"70a355c980c1e5bc909abaa537aaae65a5278881","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":9702026,"name":"windup","full_name":"windup/windup","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup","description":"Windup - JBoss Automated Migration Tool","fork":false,"url":"https://api.github.com/repos/windup/windup","forks_url":"https://api.github.com/repos/windup/windup/forks","keys_url":"https://api.github.com/repos/windup/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup/teams","hooks_url":"https://api.github.com/repos/windup/windup/hooks","issue_events_url":"https://api.github.com/repos/windup/windup/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup/events","assignees_url":"https://api.github.com/repos/windup/windup/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup/tags","blobs_url":"https://api.github.com/repos/windup/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup/languages","stargazers_url":"https://api.github.com/repos/windup/windup/stargazers","contributors_url":"https://api.github.com/repos/windup/windup/contributors","subscribers_url":"https://api.github.com/repos/windup/windup/subscribers","subscription_url":"https://api.github.com/repos/windup/windup/subscription","commits_url":"https://api.github.com/repos/windup/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup/issues/comments/{number}","contents_url":"https://api.github.com/repos/windup/windup/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup/merges","archive_url":"https://api.github.com/repos/windup/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup/downloads","issues_url":"https://api.github.com/repos/windup/windup/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup/releases{/id}","created_at":"2013-04-26T18:52:08Z","updated_at":"2015-02-12T21:48:36Z","pushed_at":"2015-02-12T21:48:35Z","git_url":"git://github.com/windup/windup.git","ssh_url":"git@github.com:windup/windup.git","clone_url":"https://github.com/windup/windup.git","svn_url":"https://github.com/windup/windup","homepage":"","size":83124,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":43,"forks":63,"open_issues":43,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/464"},"html":{"href":"https://github.com/windup/windup/pull/464"},"issue":{"href":"https://api.github.com/repos/windup/windup/issues/464"},"comments":{"href":"https://api.github.com/repos/windup/windup/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/windup/windup/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup/statuses/ac51642790347872fee3e3cac3dd399b779a9941"}}}}