{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/27772948","id":27772948,"diff_hunk":"@@ -326,13 +326,15 @@ DlgPrefControls::DlgPrefControls(QWidget * parent, MixxxMainWindow * mixxx,\n             ConfigKey(\"[Controls]\", \"RateRampSensitivity\")).toInt());\n \n     // Update Speed Auto Reset Slider Box\n-    // Cue recall\n-    ComboBoxResetSpeedAndPitch->addItem(tr(\"On track load\"));\n+    // TODO: Use an enum for the various options so it's easier to maintain.\n     ComboBoxResetSpeedAndPitch->addItem(tr(\"Off\"));\n+    ComboBoxResetSpeedAndPitch->addItem(tr(\"Reset key adjustment on track load\"));\n+    ComboBoxResetSpeedAndPitch->addItem(tr(\"Reset key and speed on track load\"));\n     connect(ComboBoxResetSpeedAndPitch, SIGNAL(activated(int)),\n             this, SLOT(slotUpdateSpeedAutoReset(int)));\n-    m_speedAutoReset = static_cast<bool>(m_pConfig->getValueString(\n-                    ConfigKey(\"[Controls]\", \"SpeedAutoReset\")).toInt());\n+    // TODO: All defaults should only be set in slotResetToDefaults.\n+    m_speedAutoReset = m_pConfig->getValueString(\n+                    ConfigKey(\"[Controls]\", \"SpeedAutoReset\"), \"1\").toInt();","path":"src/dlgprefcontrols.cpp","position":16,"original_position":16,"commit_id":"8c28f16700d5eb3771bcf8bf473d6f86b204b967","original_commit_id":"8c28f16700d5eb3771bcf8bf473d6f86b204b967","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"What is \"1\"?","created_at":"2015-04-04T22:58:40Z","updated_at":"2015-04-04T22:58:40Z","html_url":"https://github.com/mixxxdj/mixxx/pull/535#discussion_r27772948","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/27772948"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/535#discussion_r27772948"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535","id":31983511,"html_url":"https://github.com/mixxxdj/mixxx/pull/535","diff_url":"https://github.com/mixxxdj/mixxx/pull/535.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/535.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/535","number":535,"state":"open","locked":false,"title":"Add support for resetting just the key on track load","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"My controller, like many, doesn't have a dedicated slider or knob for key adjustment, just an encoder.  So I'd prefer to reset the key adjustment on track load, but not the speed slider.  This PR adds an option to do that, preserving the other options.\r\n\r\nThis will break old preferences since I've fixed the whacky ordering, but in general we're going to be breaking some people's preferences with the new version anyway so I think that's better than the alternative of keeping 1 for \"off\".","created_at":"2015-03-26T02:03:22Z","updated_at":"2015-04-04T22:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07716abec13d95bd913236238af7d12312a0eee6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/535/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/8c28f16700d5eb3771bcf8bf473d6f86b204b967","head":{"label":"ywwg:trackload-reset","ref":"trackload-reset","sha":"8c28f16700d5eb3771bcf8bf473d6f86b204b967","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"repo":{"id":10135825,"name":"mixxx","full_name":"ywwg/mixxx","owner":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywwg/mixxx","description":"Personal work branches for the mixxx project -- you may be interested in DJO-hacks-trunk, which contains a bunch of UNSUPPORTED tweaks I like","fork":true,"url":"https://api.github.com/repos/ywwg/mixxx","forks_url":"https://api.github.com/repos/ywwg/mixxx/forks","keys_url":"https://api.github.com/repos/ywwg/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywwg/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywwg/mixxx/teams","hooks_url":"https://api.github.com/repos/ywwg/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ywwg/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ywwg/mixxx/events","assignees_url":"https://api.github.com/repos/ywwg/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ywwg/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ywwg/mixxx/tags","blobs_url":"https://api.github.com/repos/ywwg/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywwg/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywwg/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywwg/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywwg/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ywwg/mixxx/languages","stargazers_url":"https://api.github.com/repos/ywwg/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ywwg/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ywwg/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ywwg/mixxx/subscription","commits_url":"https://api.github.com/repos/ywwg/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywwg/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywwg/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywwg/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywwg/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ywwg/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywwg/mixxx/merges","archive_url":"https://api.github.com/repos/ywwg/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywwg/mixxx/downloads","issues_url":"https://api.github.com/repos/ywwg/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ywwg/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ywwg/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ywwg/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywwg/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ywwg/mixxx/releases{/id}","created_at":"2013-05-18T02:52:01Z","updated_at":"2015-02-20T22:28:35Z","pushed_at":"2015-04-04T20:37:14Z","git_url":"git://github.com/ywwg/mixxx.git","ssh_url":"git@github.com:ywwg/mixxx.git","clone_url":"https://github.com/ywwg/mixxx.git","svn_url":"https://github.com/ywwg/mixxx","homepage":"","size":242111,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"48bc6c2b1de8bc5e7baadee527bc92ad32a88659","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2015-04-04T21:20:00Z","pushed_at":"2015-04-04T22:18:00Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":315364,"stargazers_count":261,"watchers_count":261,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":201,"mirror_url":null,"open_issues_count":44,"forks":201,"open_issues":44,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/535"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/535"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/8c28f16700d5eb3771bcf8bf473d6f86b204b967"}}}}