{"action":"created","issue":{"url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/8","labels_url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/8/comments","events_url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/8/events","html_url":"https://github.com/Amanieu/asyncplusplus/issues/8","id":56601379,"number":8,"title":"Update / simplify + cmake","user":{"login":"DanTheColoradan","id":3826143,"avatar_url":"https://avatars.githubusercontent.com/u/3826143?v=3","gravatar_id":"","url":"https://api.github.com/users/DanTheColoradan","html_url":"https://github.com/DanTheColoradan","followers_url":"https://api.github.com/users/DanTheColoradan/followers","following_url":"https://api.github.com/users/DanTheColoradan/following{/other_user}","gists_url":"https://api.github.com/users/DanTheColoradan/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTheColoradan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTheColoradan/subscriptions","organizations_url":"https://api.github.com/users/DanTheColoradan/orgs","repos_url":"https://api.github.com/users/DanTheColoradan/repos","events_url":"https://api.github.com/users/DanTheColoradan/events{/privacy}","received_events_url":"https://api.github.com/users/DanTheColoradan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-04T23:01:15Z","updated_at":"2015-02-04T23:38:48Z","closed_at":null,"body":"I really like what you have done here. Do you plan on updating it since many compilers now support C++11? There are also other enhancements that might be nice to add such as Travis-CI, cmake, and unit testing.\r\n\r\nI forked the project and I was able to get it to compile on Mac OS X using cmake but when I ran it on Travis it bombed. I looked at the code and there was a lot I didn't understand. I can however refork if you like and merge in / show you my changes.\r\n\r\nMostly I'm just curious to find out what you are planning for the project if anything."},"comment":{"url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/comments/72964429","html_url":"https://github.com/Amanieu/asyncplusplus/issues/8#issuecomment-72964429","issue_url":"https://api.github.com/repos/Amanieu/asyncplusplus/issues/8","id":72964429,"user":{"login":"DanTheColoradan","id":3826143,"avatar_url":"https://avatars.githubusercontent.com/u/3826143?v=3","gravatar_id":"","url":"https://api.github.com/users/DanTheColoradan","html_url":"https://github.com/DanTheColoradan","followers_url":"https://api.github.com/users/DanTheColoradan/followers","following_url":"https://api.github.com/users/DanTheColoradan/following{/other_user}","gists_url":"https://api.github.com/users/DanTheColoradan/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTheColoradan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTheColoradan/subscriptions","organizations_url":"https://api.github.com/users/DanTheColoradan/orgs","repos_url":"https://api.github.com/users/DanTheColoradan/repos","events_url":"https://api.github.com/users/DanTheColoradan/events{/privacy}","received_events_url":"https://api.github.com/users/DanTheColoradan/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T23:38:48Z","updated_at":"2015-02-04T23:38:48Z","body":"Awesome! I’m excited to try it out once you are done.\n\nAnd I didn’t explain the error properly. The error was on Travis / Linux using, if I remember correctly, gcc. It was probably that I was using a cmake file instead of the scripts you supply. On OS X Mavericks it compiled just fine.\n\nThe biggest reason I was thinking it would be nice to change it to cmake is that it would simplify building. Once you push your changes, I’ll give it another shot and see if I can get cmake to work. Also, I’ll give the changes you push (no cmake) a go on OS X again and let you know what my results are.\n\n\n\n> On Feb 4, 2015, at 4:32 PM, Amanieu <notifications@github.com> wrote:\n> \n> I am currently working on a few updates, including a significant rework of the scheduler (the current one has a few race conditions). I still need a bit of time to properly finish everything (maybe a week?), after which I will push my changes.\n> \n> I haven't added a proper build system yet because I simply haven't had a need for it, but I think something like cmake would definitely be useful. As for testing, I have a small test program that I use locally but it is very messy.\n> \n> What kind of changes did you make? I am quite interested in the error on OS X since I don't have access to a Mac and haven't been able to test my code there.\n> \n> —\n> Reply to this email directly or view it on GitHub <https://github.com/Amanieu/asyncplusplus/issues/8#issuecomment-72963486>.\n> \n\n"}}