{"action":"created","issue":{"url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/192","labels_url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/192/comments","events_url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/192/events","html_url":"https://github.com/alamkanak/Android-Week-View/pull/192","id":110863736,"number":192,"title":"improve scroll/fling performance","user":{"login":"marunjar","id":3027783,"avatar_url":"https://avatars.githubusercontent.com/u/3027783?v=3","gravatar_id":"","url":"https://api.github.com/users/marunjar","html_url":"https://github.com/marunjar","followers_url":"https://api.github.com/users/marunjar/followers","following_url":"https://api.github.com/users/marunjar/following{/other_user}","gists_url":"https://api.github.com/users/marunjar/gists{/gist_id}","starred_url":"https://api.github.com/users/marunjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marunjar/subscriptions","organizations_url":"https://api.github.com/users/marunjar/orgs","repos_url":"https://api.github.com/users/marunjar/repos","events_url":"https://api.github.com/users/marunjar/events{/privacy}","received_events_url":"https://api.github.com/users/marunjar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-11T15:37:27Z","updated_at":"2015-10-11T19:34:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alamkanak/Android-Week-View/pulls/192","html_url":"https://github.com/alamkanak/Android-Week-View/pull/192","diff_url":"https://github.com/alamkanak/Android-Week-View/pull/192.diff","patch_url":"https://github.com/alamkanak/Android-Week-View/pull/192.patch"},"body":"first try to fix #139\r\n\r\ni tried to change it to be more like the examples in android doc\r\n\r\n1: https://developer.android.com/training/gestures/scale.html\r\n2: https://developer.android.com/training/gestures/scroll.html\r\n\r\n* less calculations in computeScroll()\r\n* scrolling now is done in onScroll() and not in onDraw() anymore\r\n* no more lagging when swiping horizontal and fling is triggered\r\n* only one scroller left\r\n\r\nbut i have also some questions left, maybe you (@caske33 @lolobosse @alamkanak) can help a little bit:\r\n* there are really a lot of calls of onFirstVisibleDayChanged if there is mScrollListener set while scrolling. i'm not sure how to but shouldn't this be called only after scroll/fling has finished?\r\n* there are calls of canvas.drawRect for \"hiding\" everything drawn before, how about using clipRect to prevent from drawing in areas that should be empty?"},"comment":{"url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/comments/147238371","html_url":"https://github.com/alamkanak/Android-Week-View/pull/192#issuecomment-147238371","issue_url":"https://api.github.com/repos/alamkanak/Android-Week-View/issues/192","id":147238371,"user":{"login":"caske33","id":896093,"avatar_url":"https://avatars.githubusercontent.com/u/896093?v=3","gravatar_id":"","url":"https://api.github.com/users/caske33","html_url":"https://github.com/caske33","followers_url":"https://api.github.com/users/caske33/followers","following_url":"https://api.github.com/users/caske33/following{/other_user}","gists_url":"https://api.github.com/users/caske33/gists{/gist_id}","starred_url":"https://api.github.com/users/caske33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caske33/subscriptions","organizations_url":"https://api.github.com/users/caske33/orgs","repos_url":"https://api.github.com/users/caske33/repos","events_url":"https://api.github.com/users/caske33/events{/privacy}","received_events_url":"https://api.github.com/users/caske33/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T19:34:31Z","updated_at":"2015-10-11T19:34:31Z","body":"I think that for the first question, the listener should be called everytime the first day changes, even while scrolling. That's how I would expect the listener to behave.\r\n\r\nI'm not sure about the other question."}}