{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/29506358","id":29506358,"diff_hunk":"@@ -635,44 +634,70 @@ def c_code(self, node, name, inp, out, sub):\n           Py_XDECREF(%(gx)s);\n           %(gx)s = (PyArrayObject*) PyArray_ZEROS(4, PyArray_DIMS(%(x)s), x_typenum,0);\n         }","path":"theano/tensor/signal/downsample.py","position":61,"original_position":61,"commit_id":"8d3ad6c47ffd50bf876005805439abc541008e4f","original_commit_id":"8d3ad6c47ffd50bf876005805439abc541008e4f","user":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"body":"Do you mean we need to set gx to 0 even when the if in line 626 is not satisfied?","created_at":"2015-05-01T15:02:10Z","updated_at":"2015-05-01T15:02:10Z","html_url":"https://github.com/Theano/Theano/pull/2843#discussion_r29506358","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2843","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/29506358"},"html":{"href":"https://github.com/Theano/Theano/pull/2843#discussion_r29506358"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2843"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2843","id":34310129,"html_url":"https://github.com/Theano/Theano/pull/2843","diff_url":"https://github.com/Theano/Theano/pull/2843.diff","patch_url":"https://github.com/Theano/Theano/pull/2843.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2843","number":2843,"state":"open","locked":false,"title":"Maxpool c code","user":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"body":"all test passed with DebugMode","created_at":"2015-04-28T20:54:57Z","updated_at":"2015-05-01T15:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"902828c9a2e723ae26d22d1afa644390c0eca729","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2843/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2843/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2843/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/8d3ad6c47ffd50bf876005805439abc541008e4f","head":{"label":"yaoli:maxpool_c_code","ref":"maxpool_c_code","sha":"8d3ad6c47ffd50bf876005805439abc541008e4f","user":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"repo":{"id":2617809,"name":"Theano","full_name":"yaoli/Theano","owner":{"login":"yaoli","id":1051367,"avatar_url":"https://avatars.githubusercontent.com/u/1051367?v=3","gravatar_id":"","url":"https://api.github.com/users/yaoli","html_url":"https://github.com/yaoli","followers_url":"https://api.github.com/users/yaoli/followers","following_url":"https://api.github.com/users/yaoli/following{/other_user}","gists_url":"https://api.github.com/users/yaoli/gists{/gist_id}","starred_url":"https://api.github.com/users/yaoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaoli/subscriptions","organizations_url":"https://api.github.com/users/yaoli/orgs","repos_url":"https://api.github.com/users/yaoli/repos","events_url":"https://api.github.com/users/yaoli/events{/privacy}","received_events_url":"https://api.github.com/users/yaoli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaoli/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/yaoli/Theano","forks_url":"https://api.github.com/repos/yaoli/Theano/forks","keys_url":"https://api.github.com/repos/yaoli/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaoli/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaoli/Theano/teams","hooks_url":"https://api.github.com/repos/yaoli/Theano/hooks","issue_events_url":"https://api.github.com/repos/yaoli/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/yaoli/Theano/events","assignees_url":"https://api.github.com/repos/yaoli/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/yaoli/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/yaoli/Theano/tags","blobs_url":"https://api.github.com/repos/yaoli/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaoli/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaoli/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaoli/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaoli/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/yaoli/Theano/languages","stargazers_url":"https://api.github.com/repos/yaoli/Theano/stargazers","contributors_url":"https://api.github.com/repos/yaoli/Theano/contributors","subscribers_url":"https://api.github.com/repos/yaoli/Theano/subscribers","subscription_url":"https://api.github.com/repos/yaoli/Theano/subscription","commits_url":"https://api.github.com/repos/yaoli/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaoli/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaoli/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaoli/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaoli/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/yaoli/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaoli/Theano/merges","archive_url":"https://api.github.com/repos/yaoli/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaoli/Theano/downloads","issues_url":"https://api.github.com/repos/yaoli/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/yaoli/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/yaoli/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/yaoli/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaoli/Theano/labels{/name}","releases_url":"https://api.github.com/repos/yaoli/Theano/releases{/id}","created_at":"2011-10-21T03:02:45Z","updated_at":"2014-06-10T01:04:33Z","pushed_at":"2015-04-29T17:31:21Z","git_url":"git://github.com/yaoli/Theano.git","ssh_url":"git@github.com:yaoli/Theano.git","clone_url":"https://github.com/yaoli/Theano.git","svn_url":"https://github.com/yaoli/Theano","homepage":"http://www.deeplearning.net/software/theano","size":31496,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"352177f35a5ddf3091a36a53ba8a92ebd6adb36d","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-05-01T13:52:50Z","pushed_at":"2015-05-01T14:41:36Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":48521,"stargazers_count":1423,"watchers_count":1423,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":529,"mirror_url":null,"open_issues_count":367,"forks":529,"open_issues":367,"watchers":1423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2843"},"html":{"href":"https://github.com/Theano/Theano/pull/2843"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2843"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2843/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2843/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2843/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/8d3ad6c47ffd50bf876005805439abc541008e4f"}}}}