{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/31121928","id":31121928,"diff_hunk":"@@ -35,3 +35,4 @@\n \n $wgHooks['UserSaveSettings'][] = 'Wikia\\\\Helios\\\\User::onUserSave';\n $wgHooks['UserSaveOptions'][] = 'Wikia\\\\Helios\\\\User::onUserSave';\n+$wgHooks['UserLogout'][] = 'Wikia\\\\Helios\\\\User::clearAccessTokenCookie';","path":"extensions/wikia/Helios/Helios.setup.php","position":4,"original_position":4,"commit_id":"5895ecb55538b44d6f75103ca1d0b8f7f02e88fb","original_commit_id":"5895ecb55538b44d6f75103ca1d0b8f7f02e88fb","user":{"login":"michalroszka","id":16726,"avatar_url":"https://avatars.githubusercontent.com/u/16726?v=3","gravatar_id":"","url":"https://api.github.com/users/michalroszka","html_url":"https://github.com/michalroszka","followers_url":"https://api.github.com/users/michalroszka/followers","following_url":"https://api.github.com/users/michalroszka/following{/other_user}","gists_url":"https://api.github.com/users/michalroszka/gists{/gist_id}","starred_url":"https://api.github.com/users/michalroszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalroszka/subscriptions","organizations_url":"https://api.github.com/users/michalroszka/orgs","repos_url":"https://api.github.com/users/michalroszka/repos","events_url":"https://api.github.com/users/michalroszka/events{/privacy}","received_events_url":"https://api.github.com/users/michalroszka/received_events","type":"User","site_admin":false},"body":"Currently it is, although it seems the author's intention was to make a general purpose method.","created_at":"2015-05-27T10:57:01Z","updated_at":"2015-05-27T10:57:01Z","html_url":"https://github.com/Wikia/app/pull/7339#discussion_r31121928","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/7339","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/31121928"},"html":{"href":"https://github.com/Wikia/app/pull/7339#discussion_r31121928"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/7339"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/7339","id":36289812,"html_url":"https://github.com/Wikia/app/pull/7339","diff_url":"https://github.com/Wikia/app/pull/7339.diff","patch_url":"https://github.com/Wikia/app/pull/7339.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/7339","number":7339,"state":"open","locked":false,"title":"PLATFORM-1250 Hook Helios' clearAccessTokenCookie() to UserLogout","user":{"login":"michalroszka","id":16726,"avatar_url":"https://avatars.githubusercontent.com/u/16726?v=3","gravatar_id":"","url":"https://api.github.com/users/michalroszka","html_url":"https://github.com/michalroszka","followers_url":"https://api.github.com/users/michalroszka/followers","following_url":"https://api.github.com/users/michalroszka/following{/other_user}","gists_url":"https://api.github.com/users/michalroszka/gists{/gist_id}","starred_url":"https://api.github.com/users/michalroszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalroszka/subscriptions","organizations_url":"https://api.github.com/users/michalroszka/orgs","repos_url":"https://api.github.com/users/michalroszka/repos","events_url":"https://api.github.com/users/michalroszka/events{/privacy}","received_events_url":"https://api.github.com/users/michalroszka/received_events","type":"User","site_admin":false},"body":"Calling Helios' methods when Helios is disabled (Uncyclo) results with fatal errors which is why it is better to hook to core events rather than make explicit calls.\r\n\r\n* extensions/wikia/Helios/Helios.setup.php - hook Wikia\\Helios\\User::clearAccessTokenCookie() to UserLogout event\r\n* extensions/wikia/Helios/Helios.setup.php - Wikia\\Helios\\User::clearAccessTokenCookie() returns true so that wfRunHooks('UserLogout') evalates to true, too.\r\n* includes/User.php - remove explicit call from doLogout() and rely on wfRunHooks('UserLogout') in logout()","created_at":"2015-05-27T10:34:09Z","updated_at":"2015-05-27T10:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0457fc8843868fd7f1c2e2ba20b18c536a4d9320","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/7339/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/7339/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/7339/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/5895ecb55538b44d6f75103ca1d0b8f7f02e88fb","head":{"label":"Wikia:dev-platform-1250","ref":"dev-platform-1250","sha":"5895ecb55538b44d6f75103ca1d0b8f7f02e88fb","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-05-08T19:30:43Z","pushed_at":"2015-05-27T10:56:24Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1412067,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":69,"forks":56,"open_issues":69,"watchers":77,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"45589905aea3044c3c8110c0ba8e3d4f8a90b62a","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-05-08T19:30:43Z","pushed_at":"2015-05-27T10:56:24Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1412067,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":69,"forks":56,"open_issues":69,"watchers":77,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/7339"},"html":{"href":"https://github.com/Wikia/app/pull/7339"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/7339"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/7339/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/7339/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/7339/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/5895ecb55538b44d6f75103ca1d0b8f7f02e88fb"}}}}