{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/24046743","id":24046743,"diff_hunk":"@@ -16,10 +16,13 @@\n require('mock-modules');\n \n var React = require('React');\n+var ReactFragment = require('ReactFragment');\n var ReactTestUtils = require('ReactTestUtils');\n \n var reactComponentExpect = require('reactComponentExpect');\n \n+var frag = ReactFragment.create;","path":"src/core/__tests__/ReactMultiChildText-test.js","position":9,"original_position":9,"commit_id":"daf287e37dd90dca6feef38a0627d98ac6b2294c","original_commit_id":"daf287e37dd90dca6feef38a0627d98ac6b2294c","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"nit: any reason for inconsistency between this assignment and (in other tests) this:\r\n\r\n```\r\nfunction frag(obj) {\r\n  return ReactFragment.create(obj);\r\n}\r\n```\r\n\r\n?","created_at":"2015-02-03T22:34:39Z","updated_at":"2015-02-03T22:34:39Z","html_url":"https://github.com/facebook/react/pull/3030#discussion_r24046743","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/3030","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/24046743"},"html":{"href":"https://github.com/facebook/react/pull/3030#discussion_r24046743"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/3030"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/3030","id":28592423,"html_url":"https://github.com/facebook/react/pull/3030","diff_url":"https://github.com/facebook/react/pull/3030.diff","patch_url":"https://github.com/facebook/react/pull/3030.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/3030","number":3030,"state":"open","locked":false,"title":"Make keyed object fragments an opaque type","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"This triggers a warning if you try to pass a keyed object as a child.\r\n\r\nYou now have to wrap it in React.addons.createFragment(object) which\r\ncreates a proxy (in dev) which warns if it is accessed. The purpose of\r\nthis is to make these into opaque objects so that nobody relies on its\r\ndata structure.\r\n\r\nAfter that we can turn it into a different data structure such as a\r\nReactFragment node or an iterable of flattened ReactElements.","created_at":"2015-02-03T21:50:36Z","updated_at":"2015-02-03T22:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b0e6720f84b76ee3e9802f542480e9c2f5403b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/3030/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/3030/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/react/issues/3030/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/daf287e37dd90dca6feef38a0627d98ac6b2294c","head":{"label":"sebmarkbage:fragments","ref":"fragments","sha":"daf287e37dd90dca6feef38a0627d98ac6b2294c","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"repo":{"id":10374314,"name":"react","full_name":"sebmarkbage/react","owner":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebmarkbage/react","description":"React is a JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/sebmarkbage/react","forks_url":"https://api.github.com/repos/sebmarkbage/react/forks","keys_url":"https://api.github.com/repos/sebmarkbage/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebmarkbage/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebmarkbage/react/teams","hooks_url":"https://api.github.com/repos/sebmarkbage/react/hooks","issue_events_url":"https://api.github.com/repos/sebmarkbage/react/issues/events{/number}","events_url":"https://api.github.com/repos/sebmarkbage/react/events","assignees_url":"https://api.github.com/repos/sebmarkbage/react/assignees{/user}","branches_url":"https://api.github.com/repos/sebmarkbage/react/branches{/branch}","tags_url":"https://api.github.com/repos/sebmarkbage/react/tags","blobs_url":"https://api.github.com/repos/sebmarkbage/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebmarkbage/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebmarkbage/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebmarkbage/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebmarkbage/react/statuses/{sha}","languages_url":"https://api.github.com/repos/sebmarkbage/react/languages","stargazers_url":"https://api.github.com/repos/sebmarkbage/react/stargazers","contributors_url":"https://api.github.com/repos/sebmarkbage/react/contributors","subscribers_url":"https://api.github.com/repos/sebmarkbage/react/subscribers","subscription_url":"https://api.github.com/repos/sebmarkbage/react/subscription","commits_url":"https://api.github.com/repos/sebmarkbage/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebmarkbage/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebmarkbage/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebmarkbage/react/issues/comments/{number}","contents_url":"https://api.github.com/repos/sebmarkbage/react/contents/{+path}","compare_url":"https://api.github.com/repos/sebmarkbage/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebmarkbage/react/merges","archive_url":"https://api.github.com/repos/sebmarkbage/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebmarkbage/react/downloads","issues_url":"https://api.github.com/repos/sebmarkbage/react/issues{/number}","pulls_url":"https://api.github.com/repos/sebmarkbage/react/pulls{/number}","milestones_url":"https://api.github.com/repos/sebmarkbage/react/milestones{/number}","notifications_url":"https://api.github.com/repos/sebmarkbage/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebmarkbage/react/labels{/name}","releases_url":"https://api.github.com/repos/sebmarkbage/react/releases{/id}","created_at":"2013-05-30T03:09:16Z","updated_at":"2014-10-16T16:21:48Z","pushed_at":"2015-02-03T21:50:10Z","git_url":"git://github.com/sebmarkbage/react.git","ssh_url":"git@github.com:sebmarkbage/react.git","clone_url":"https://github.com/sebmarkbage/react.git","svn_url":"https://github.com/sebmarkbage/react","homepage":"http://facebook.github.io/react/","size":30845,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"3f60a99cd9d6f11a4def3d868e7993ae625138d9","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2015-02-03T22:33:36Z","pushed_at":"2015-02-03T18:46:22Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"http://facebook.github.io/react/","size":74338,"stargazers_count":15014,"watchers_count":15014,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1987,"mirror_url":null,"open_issues_count":505,"forks":1987,"open_issues":505,"watchers":15014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/3030"},"html":{"href":"https://github.com/facebook/react/pull/3030"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/3030"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/3030/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/3030/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/3030/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/daf287e37dd90dca6feef38a0627d98ac6b2294c"}}}}