{"action":"created","comment":{"url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments/41090710","id":41090710,"diff_hunk":"@@ -64,20 +74,18 @@\n \n // GetFunction\n //------------------------------------------------------------------------------\n-void * CachePlugin::GetFunction( const char * friendlyName, const char * mangledName ) const\n+void * CachePlugin::GetFunction( const char * name) const\n {\n     #if defined( __WINDOWS__ )\n         ASSERT( m_DLL );\n-        void * func = ::GetProcAddress( (HMODULE)m_DLL, mangledName );\n+        void * func = ::GetProcAddress( (HMODULE)m_DLL, name );\n         if ( !func )\n         {\n             FLOG_WARN( \"Missing CachePluginDLL function '%s' (Mangled: %s)\", friendlyName, mangledName );","path":"Code/Tools/FBuild/FBuildCore/Cache/CachePlugin.cpp","position":64,"original_position":64,"commit_id":"68a65dc2fec526fc4db5f00eb01234460e87c7dd","original_commit_id":"68a65dc2fec526fc4db5f00eb01234460e87c7dd","user":{"login":"ffulin","id":11589403,"avatar_url":"https://avatars.githubusercontent.com/u/11589403?v=3","gravatar_id":"","url":"https://api.github.com/users/ffulin","html_url":"https://github.com/ffulin","followers_url":"https://api.github.com/users/ffulin/followers","following_url":"https://api.github.com/users/ffulin/following{/other_user}","gists_url":"https://api.github.com/users/ffulin/gists{/gist_id}","starred_url":"https://api.github.com/users/ffulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffulin/subscriptions","organizations_url":"https://api.github.com/users/ffulin/orgs","repos_url":"https://api.github.com/users/ffulin/repos","events_url":"https://api.github.com/users/ffulin/events{/privacy}","received_events_url":"https://api.github.com/users/ffulin/received_events","type":"User","site_admin":false},"body":"This won't compile anymore on Windows, since it references friendlyName and mangledName","created_at":"2015-10-03T19:22:19Z","updated_at":"2015-10-03T19:22:19Z","html_url":"https://github.com/fastbuild/fastbuild/pull/63#discussion_r41090710","pull_request_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments/41090710"},"html":{"href":"https://github.com/fastbuild/fastbuild/pull/63#discussion_r41090710"},"pull_request":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63","id":46110310,"html_url":"https://github.com/fastbuild/fastbuild/pull/63","diff_url":"https://github.com/fastbuild/fastbuild/pull/63.diff","patch_url":"https://github.com/fastbuild/fastbuild/pull/63.patch","issue_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/63","number":63,"state":"open","locked":false,"title":"Fixs Posix","user":{"login":"gdaow","id":377430,"avatar_url":"https://avatars.githubusercontent.com/u/377430?v=3","gravatar_id":"","url":"https://api.github.com/users/gdaow","html_url":"https://github.com/gdaow","followers_url":"https://api.github.com/users/gdaow/followers","following_url":"https://api.github.com/users/gdaow/following{/other_user}","gists_url":"https://api.github.com/users/gdaow/gists{/gist_id}","starred_url":"https://api.github.com/users/gdaow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdaow/subscriptions","organizations_url":"https://api.github.com/users/gdaow/orgs","repos_url":"https://api.github.com/users/gdaow/repos","events_url":"https://api.github.com/users/gdaow/events{/privacy}","received_events_url":"https://api.github.com/users/gdaow/received_events","type":"User","site_admin":false},"body":"That's some fixs / implementations for the Posix platforms (SetThreadName, the CachePlugin code, SharedMemory). I tested under Linux, it should work on Mac modulo the build configuration, as I checked the functions I used were Posix-compliant. I'll try to set up a MacOS virtual machine to fix the build on Mac, and I guess I'll have some more fix soon. I push this already so the work isn't made two times :)","created_at":"2015-09-27T22:22:30Z","updated_at":"2015-10-03T19:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb89331992cdf327dd3cbea2ae65097453b6cb63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63/commits","review_comments_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63/comments","review_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/63/comments","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/68a65dc2fec526fc4db5f00eb01234460e87c7dd","head":{"label":"gdaow:fixs_posix","ref":"fixs_posix","sha":"68a65dc2fec526fc4db5f00eb01234460e87c7dd","user":{"login":"gdaow","id":377430,"avatar_url":"https://avatars.githubusercontent.com/u/377430?v=3","gravatar_id":"","url":"https://api.github.com/users/gdaow","html_url":"https://github.com/gdaow","followers_url":"https://api.github.com/users/gdaow/followers","following_url":"https://api.github.com/users/gdaow/following{/other_user}","gists_url":"https://api.github.com/users/gdaow/gists{/gist_id}","starred_url":"https://api.github.com/users/gdaow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdaow/subscriptions","organizations_url":"https://api.github.com/users/gdaow/orgs","repos_url":"https://api.github.com/users/gdaow/repos","events_url":"https://api.github.com/users/gdaow/events{/privacy}","received_events_url":"https://api.github.com/users/gdaow/received_events","type":"User","site_admin":false},"repo":{"id":42859129,"name":"fastbuild","full_name":"gdaow/fastbuild","owner":{"login":"gdaow","id":377430,"avatar_url":"https://avatars.githubusercontent.com/u/377430?v=3","gravatar_id":"","url":"https://api.github.com/users/gdaow","html_url":"https://github.com/gdaow","followers_url":"https://api.github.com/users/gdaow/followers","following_url":"https://api.github.com/users/gdaow/following{/other_user}","gists_url":"https://api.github.com/users/gdaow/gists{/gist_id}","starred_url":"https://api.github.com/users/gdaow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdaow/subscriptions","organizations_url":"https://api.github.com/users/gdaow/orgs","repos_url":"https://api.github.com/users/gdaow/repos","events_url":"https://api.github.com/users/gdaow/events{/privacy}","received_events_url":"https://api.github.com/users/gdaow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdaow/fastbuild","description":"","fork":true,"url":"https://api.github.com/repos/gdaow/fastbuild","forks_url":"https://api.github.com/repos/gdaow/fastbuild/forks","keys_url":"https://api.github.com/repos/gdaow/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdaow/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdaow/fastbuild/teams","hooks_url":"https://api.github.com/repos/gdaow/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/gdaow/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/gdaow/fastbuild/events","assignees_url":"https://api.github.com/repos/gdaow/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/gdaow/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/gdaow/fastbuild/tags","blobs_url":"https://api.github.com/repos/gdaow/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdaow/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdaow/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdaow/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdaow/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/gdaow/fastbuild/languages","stargazers_url":"https://api.github.com/repos/gdaow/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/gdaow/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/gdaow/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/gdaow/fastbuild/subscription","commits_url":"https://api.github.com/repos/gdaow/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdaow/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdaow/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdaow/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdaow/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/gdaow/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdaow/fastbuild/merges","archive_url":"https://api.github.com/repos/gdaow/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdaow/fastbuild/downloads","issues_url":"https://api.github.com/repos/gdaow/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/gdaow/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/gdaow/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/gdaow/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdaow/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/gdaow/fastbuild/releases{/id}","created_at":"2015-09-21T10:17:11Z","updated_at":"2015-09-21T10:17:13Z","pushed_at":"2015-09-27T21:43:26Z","git_url":"git://github.com/gdaow/fastbuild.git","ssh_url":"git@github.com:gdaow/fastbuild.git","clone_url":"https://github.com/gdaow/fastbuild.git","svn_url":"https://github.com/gdaow/fastbuild","homepage":null,"size":2525,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastbuild:dev","ref":"dev","sha":"d60d5da98afa63e6511c709e6322d4f7148ad025","user":{"login":"fastbuild","id":11589493,"avatar_url":"https://avatars.githubusercontent.com/u/11589493?v=3","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":32647696,"name":"fastbuild","full_name":"fastbuild/fastbuild","owner":{"login":"fastbuild","id":11589493,"avatar_url":"https://avatars.githubusercontent.com/u/11589493?v=3","gravatar_id":"","url":"https://api.github.com/users/fastbuild","html_url":"https://github.com/fastbuild","followers_url":"https://api.github.com/users/fastbuild/followers","following_url":"https://api.github.com/users/fastbuild/following{/other_user}","gists_url":"https://api.github.com/users/fastbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/fastbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastbuild/subscriptions","organizations_url":"https://api.github.com/users/fastbuild/orgs","repos_url":"https://api.github.com/users/fastbuild/repos","events_url":"https://api.github.com/users/fastbuild/events{/privacy}","received_events_url":"https://api.github.com/users/fastbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastbuild/fastbuild","description":"","fork":false,"url":"https://api.github.com/repos/fastbuild/fastbuild","forks_url":"https://api.github.com/repos/fastbuild/fastbuild/forks","keys_url":"https://api.github.com/repos/fastbuild/fastbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastbuild/fastbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastbuild/fastbuild/teams","hooks_url":"https://api.github.com/repos/fastbuild/fastbuild/hooks","issue_events_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/events{/number}","events_url":"https://api.github.com/repos/fastbuild/fastbuild/events","assignees_url":"https://api.github.com/repos/fastbuild/fastbuild/assignees{/user}","branches_url":"https://api.github.com/repos/fastbuild/fastbuild/branches{/branch}","tags_url":"https://api.github.com/repos/fastbuild/fastbuild/tags","blobs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastbuild/fastbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastbuild/fastbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastbuild/fastbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastbuild/fastbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/fastbuild/fastbuild/languages","stargazers_url":"https://api.github.com/repos/fastbuild/fastbuild/stargazers","contributors_url":"https://api.github.com/repos/fastbuild/fastbuild/contributors","subscribers_url":"https://api.github.com/repos/fastbuild/fastbuild/subscribers","subscription_url":"https://api.github.com/repos/fastbuild/fastbuild/subscription","commits_url":"https://api.github.com/repos/fastbuild/fastbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastbuild/fastbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastbuild/fastbuild/contents/{+path}","compare_url":"https://api.github.com/repos/fastbuild/fastbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastbuild/fastbuild/merges","archive_url":"https://api.github.com/repos/fastbuild/fastbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastbuild/fastbuild/downloads","issues_url":"https://api.github.com/repos/fastbuild/fastbuild/issues{/number}","pulls_url":"https://api.github.com/repos/fastbuild/fastbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/fastbuild/fastbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/fastbuild/fastbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastbuild/fastbuild/labels{/name}","releases_url":"https://api.github.com/repos/fastbuild/fastbuild/releases{/id}","created_at":"2015-03-21T19:53:07Z","updated_at":"2015-09-30T01:30:25Z","pushed_at":"2015-09-28T02:07:44Z","git_url":"git://github.com/fastbuild/fastbuild.git","ssh_url":"git@github.com:fastbuild/fastbuild.git","clone_url":"https://github.com/fastbuild/fastbuild.git","svn_url":"https://github.com/fastbuild/fastbuild","homepage":null,"size":3623,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":16,"forks":21,"open_issues":16,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63"},"html":{"href":"https://github.com/fastbuild/fastbuild/pull/63"},"issue":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/63"},"comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastbuild/fastbuild/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/fastbuild/fastbuild/statuses/68a65dc2fec526fc4db5f00eb01234460e87c7dd"}}}}