{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16929","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16929/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16929/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16929/events","html_url":"https://github.com/kubernetes/kubernetes/pull/16929","id":115560206,"number":16929,"title":"Use http's basic auth instead of manual encoding","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/CSI","name":"team/CSI","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-11-06T18:23:38Z","updated_at":"2015-11-07T17:54:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/16929","html_url":"https://github.com/kubernetes/kubernetes/pull/16929","diff_url":"https://github.com/kubernetes/kubernetes/pull/16929.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/16929.patch"},"body":"In some places, we were encoding/decoding basic auth headers manually. I moved this to use http's native basic auth features. I also deleted keystone_test.go because it wasn't testing the keystone package, and what it was testing was already being tested by basic_auth_test.go\r\n\r\n@kubernetes/goog-csi "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/154730109","html_url":"https://github.com/kubernetes/kubernetes/pull/16929#issuecomment-154730109","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/16929","id":154730109,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-07T17:54:21Z","updated_at":"2015-11-07T17:54:21Z","body":"GCE e2e test build/test **passed** for commit 0a4ee958c7f203644975359aca18bb4d021dd8c4.\n* [Build Log](https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/0a4ee958c7f203644975359aca18bb4d021dd8c4/kubernetes-pull-build-test-e2e-gce/15744/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/0a4ee958c7f203644975359aca18bb4d021dd8c4/kubernetes-pull-build-test-e2e-gce/15744/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//15744)\n"}}