{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/32886171","id":32886171,"diff_hunk":"@@ -399,13 +395,13 @@ var ViewDebug = Ember.Object.extend(PortMixin, {\n     if (!element) { return; }\n \n \n-    if (element instanceof Ember.View) {\n+    if (element instanceof View) {\n       view = element;\n     } else {\n-      view = this.get('viewRegistry')[element.id];\n+      view = View.views[element.id];","path":"ember_debug/view-debug.js","position":472,"original_position":472,"commit_id":"d768377e2ef6278d149d976b45fbabe2de98c722","original_commit_id":"d768377e2ef6278d149d976b45fbabe2de98c722","user":{"login":"teddyzeenny","id":1061742,"avatar_url":"https://avatars.githubusercontent.com/u/1061742?v=3","gravatar_id":"","url":"https://api.github.com/users/teddyzeenny","html_url":"https://github.com/teddyzeenny","followers_url":"https://api.github.com/users/teddyzeenny/followers","following_url":"https://api.github.com/users/teddyzeenny/following{/other_user}","gists_url":"https://api.github.com/users/teddyzeenny/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyzeenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyzeenny/subscriptions","organizations_url":"https://api.github.com/users/teddyzeenny/orgs","repos_url":"https://api.github.com/users/teddyzeenny/repos","events_url":"https://api.github.com/users/teddyzeenny/events{/privacy}","received_events_url":"https://api.github.com/users/teddyzeenny/received_events","type":"User","site_admin":false},"body":"`view = this.get('viewRegistry')[element.id];`","created_at":"2015-06-20T17:17:24Z","updated_at":"2015-06-20T17:17:24Z","html_url":"https://github.com/emberjs/ember-inspector/pull/387#discussion_r32886171","pull_request_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments/32886171"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/387#discussion_r32886171"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387","id":37166083,"html_url":"https://github.com/emberjs/ember-inspector/pull/387","diff_url":"https://github.com/emberjs/ember-inspector/pull/387.diff","patch_url":"https://github.com/emberjs/ember-inspector/pull/387.patch","issue_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/387","number":387,"state":"open","locked":false,"title":"- Refactor ember-debug to use ES6.","user":{"login":"Mawaheb","id":3714892,"avatar_url":"https://avatars.githubusercontent.com/u/3714892?v=3","gravatar_id":"","url":"https://api.github.com/users/Mawaheb","html_url":"https://github.com/Mawaheb","followers_url":"https://api.github.com/users/Mawaheb/followers","following_url":"https://api.github.com/users/Mawaheb/following{/other_user}","gists_url":"https://api.github.com/users/Mawaheb/gists{/gist_id}","starred_url":"https://api.github.com/users/Mawaheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mawaheb/subscriptions","organizations_url":"https://api.github.com/users/Mawaheb/orgs","repos_url":"https://api.github.com/users/Mawaheb/repos","events_url":"https://api.github.com/users/Mawaheb/events{/privacy}","received_events_url":"https://api.github.com/users/Mawaheb/received_events","type":"User","site_admin":false},"body":"OK, I believe this is ready, But, there are a few problems that I faced:\r\n\r\n- I couldn't refactor the contents of `/vendor`, when I tried, I got an error \"Can't use block-scoped let, const out of restricted mode.\"\r\n\r\n- Because arrow functions should always be anonymous, I couldn't/figure out how to refactor [this one](https://github.com/emberjs/ember-inspector/blob/master/ember_debug/view-debug.js#L192) to use `this` instead of `self`\r\nsimilar problem with [this one](https://github.com/emberjs/ember-inspector/blob/master/ember_debug/deprecation-debug.js#L177)\r\n\r\n\r\nAs always, Any suggestions, comments, notes, things to be changed or feedback is always appreciated","created_at":"2015-06-08T15:36:05Z","updated_at":"2015-06-20T17:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fc4838766f010fd224ebdeac66724dcb05f0c58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/387/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/d768377e2ef6278d149d976b45fbabe2de98c722","head":{"label":"Mawaheb:refactorEmberDebug","ref":"refactorEmberDebug","sha":"d768377e2ef6278d149d976b45fbabe2de98c722","user":{"login":"Mawaheb","id":3714892,"avatar_url":"https://avatars.githubusercontent.com/u/3714892?v=3","gravatar_id":"","url":"https://api.github.com/users/Mawaheb","html_url":"https://github.com/Mawaheb","followers_url":"https://api.github.com/users/Mawaheb/followers","following_url":"https://api.github.com/users/Mawaheb/following{/other_user}","gists_url":"https://api.github.com/users/Mawaheb/gists{/gist_id}","starred_url":"https://api.github.com/users/Mawaheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mawaheb/subscriptions","organizations_url":"https://api.github.com/users/Mawaheb/orgs","repos_url":"https://api.github.com/users/Mawaheb/repos","events_url":"https://api.github.com/users/Mawaheb/events{/privacy}","received_events_url":"https://api.github.com/users/Mawaheb/received_events","type":"User","site_admin":false},"repo":{"id":35880073,"name":"ember-inspector","full_name":"Mawaheb/ember-inspector","owner":{"login":"Mawaheb","id":3714892,"avatar_url":"https://avatars.githubusercontent.com/u/3714892?v=3","gravatar_id":"","url":"https://api.github.com/users/Mawaheb","html_url":"https://github.com/Mawaheb","followers_url":"https://api.github.com/users/Mawaheb/followers","following_url":"https://api.github.com/users/Mawaheb/following{/other_user}","gists_url":"https://api.github.com/users/Mawaheb/gists{/gist_id}","starred_url":"https://api.github.com/users/Mawaheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mawaheb/subscriptions","organizations_url":"https://api.github.com/users/Mawaheb/orgs","repos_url":"https://api.github.com/users/Mawaheb/repos","events_url":"https://api.github.com/users/Mawaheb/events{/privacy}","received_events_url":"https://api.github.com/users/Mawaheb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mawaheb/ember-inspector","description":"","fork":true,"url":"https://api.github.com/repos/Mawaheb/ember-inspector","forks_url":"https://api.github.com/repos/Mawaheb/ember-inspector/forks","keys_url":"https://api.github.com/repos/Mawaheb/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mawaheb/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mawaheb/ember-inspector/teams","hooks_url":"https://api.github.com/repos/Mawaheb/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/Mawaheb/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/Mawaheb/ember-inspector/events","assignees_url":"https://api.github.com/repos/Mawaheb/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/Mawaheb/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/Mawaheb/ember-inspector/tags","blobs_url":"https://api.github.com/repos/Mawaheb/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mawaheb/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mawaheb/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mawaheb/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mawaheb/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/Mawaheb/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/Mawaheb/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/Mawaheb/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/Mawaheb/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/Mawaheb/ember-inspector/subscription","commits_url":"https://api.github.com/repos/Mawaheb/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mawaheb/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mawaheb/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mawaheb/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mawaheb/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/Mawaheb/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mawaheb/ember-inspector/merges","archive_url":"https://api.github.com/repos/Mawaheb/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mawaheb/ember-inspector/downloads","issues_url":"https://api.github.com/repos/Mawaheb/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/Mawaheb/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/Mawaheb/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/Mawaheb/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mawaheb/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/Mawaheb/ember-inspector/releases{/id}","created_at":"2015-05-19T12:14:52Z","updated_at":"2015-05-19T12:55:53Z","pushed_at":"2015-06-17T15:44:32Z","git_url":"git://github.com/Mawaheb/ember-inspector.git","ssh_url":"git@github.com:Mawaheb/ember-inspector.git","clone_url":"https://github.com/Mawaheb/ember-inspector.git","svn_url":"https://github.com/Mawaheb/ember-inspector","homepage":"","size":3201,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"4e907b839ede54e02316d37d78ca2791ce27ed58","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7876204,"name":"ember-inspector","full_name":"emberjs/ember-inspector","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-inspector","description":"","fork":false,"url":"https://api.github.com/repos/emberjs/ember-inspector","forks_url":"https://api.github.com/repos/emberjs/ember-inspector/forks","keys_url":"https://api.github.com/repos/emberjs/ember-inspector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-inspector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-inspector/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-inspector/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-inspector/events","assignees_url":"https://api.github.com/repos/emberjs/ember-inspector/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-inspector/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-inspector/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-inspector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-inspector/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-inspector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-inspector/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-inspector/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-inspector/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-inspector/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-inspector/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-inspector/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-inspector/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-inspector/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-inspector/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-inspector/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember-inspector/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-inspector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-inspector/merges","archive_url":"https://api.github.com/repos/emberjs/ember-inspector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-inspector/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-inspector/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-inspector/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-inspector/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-inspector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-inspector/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-inspector/releases{/id}","created_at":"2013-01-28T18:36:15Z","updated_at":"2015-06-20T15:52:25Z","pushed_at":"2015-06-20T12:22:21Z","git_url":"git://github.com/emberjs/ember-inspector.git","ssh_url":"git@github.com:emberjs/ember-inspector.git","clone_url":"https://github.com/emberjs/ember-inspector.git","svn_url":"https://github.com/emberjs/ember-inspector","homepage":null,"size":5221,"stargazers_count":668,"watchers_count":668,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":92,"forks":138,"open_issues":92,"watchers":668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387"},"html":{"href":"https://github.com/emberjs/ember-inspector/pull/387"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/387"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-inspector/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-inspector/statuses/d768377e2ef6278d149d976b45fbabe2de98c722"}}}}