{"action":"created","issue":{"url":"https://api.github.com/repos/keystonejs/keystone/issues/865","labels_url":"https://api.github.com/repos/keystonejs/keystone/issues/865/labels{/name}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/865/comments","events_url":"https://api.github.com/repos/keystonejs/keystone/issues/865/events","html_url":"https://github.com/keystonejs/keystone/issues/865","id":53445079,"number":865,"title":"Fix jshints","user":{"login":"morenoh149","id":587438,"avatar_url":"https://avatars.githubusercontent.com/u/587438?v=3","gravatar_id":"","url":"https://api.github.com/users/morenoh149","html_url":"https://github.com/morenoh149","followers_url":"https://api.github.com/users/morenoh149/followers","following_url":"https://api.github.com/users/morenoh149/following{/other_user}","gists_url":"https://api.github.com/users/morenoh149/gists{/gist_id}","starred_url":"https://api.github.com/users/morenoh149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morenoh149/subscriptions","organizations_url":"https://api.github.com/users/morenoh149/orgs","repos_url":"https://api.github.com/users/morenoh149/repos","events_url":"https://api.github.com/users/morenoh149/events{/privacy}","received_events_url":"https://api.github.com/users/morenoh149/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/keystonejs/keystone/labels/easy+for+beginners","name":"easy for beginners","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/keystonejs/keystone/milestones/4","labels_url":"https://api.github.com/repos/keystonejs/keystone/milestones/4/labels","id":748849,"number":4,"title":"0.3.x","description":"Things that will be addressed after our move to React","creator":{"login":"JedWatson","id":872310,"avatar_url":"https://avatars.githubusercontent.com/u/872310?v=3","gravatar_id":"","url":"https://api.github.com/users/JedWatson","html_url":"https://github.com/JedWatson","followers_url":"https://api.github.com/users/JedWatson/followers","following_url":"https://api.github.com/users/JedWatson/following{/other_user}","gists_url":"https://api.github.com/users/JedWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/JedWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JedWatson/subscriptions","organizations_url":"https://api.github.com/users/JedWatson/orgs","repos_url":"https://api.github.com/users/JedWatson/repos","events_url":"https://api.github.com/users/JedWatson/events{/privacy}","received_events_url":"https://api.github.com/users/JedWatson/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":1,"state":"open","created_at":"2014-08-10T16:10:22Z","updated_at":"2015-01-10T04:22:53Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-01-05T20:40:51Z","updated_at":"2015-01-10T15:23:40Z","closed_at":"2015-01-10T04:22:53Z","body":"I recently went in and fixed most of the jshint warnings in the codebase. Currently there are 24 warnings left but these are more interesting cases (unreachable code, global variable declarations, weird return values, etc). Fixing these would be great for a beginner\r\n```\r\n\r\nadmin/src/components/toolbar.js\r\n  line 43   col 33  Expected '!==' and instead saw '!='.\r\n  line 43   col 62  Expected '!==' and instead saw '!='.\r\n  line 45   col 48  Expected '!==' and instead saw '!='.\r\n  line 52   col 56  Expected '===' and instead saw '=='.\r\n  line 12   col 18  '$' is not defined.\r\n  line 13   col 13  '$' is not defined.\r\n  line 14   col 16  '$' is not defined.\r\n\r\nadmin/src/views/item/index.js\r\n  line 155  col 1   Unnecessary semicolon.\r\n\r\nfields/components/inputDate.js\r\n  line 8    col 11  Label 'format' on YYYY-MM-DD statement.\r\n  line 8    col 23  Missing semicolon.\r\n  line 13   col 21  'Pikaday' is not defined.\r\n\r\nfields/types/cloudinaryimage/cloudinaryimage.js\r\n  line 60   col 6   'alert' is not defined.\r\n\r\nfields/types/cloudinaryimages/cloudinaryimages.js\r\n  line 120  col 5   'alert' is not defined.\r\n\r\nfields/types/date/date.js\r\n  line 23   col 17  Label 'formatString' on Do MMM YYYY statement.\r\n  line 23   col 30  Missing semicolon.\r\n\r\nfields/types/datetime/datetime.js\r\n  line 28   col 17  Label 'formatString' on Do MMM YYYY, h:mm:ss a statement.\r\n  line 28   col 41  Missing semicolon.\r\n\r\nfields/types/embedly/embedly.js\r\n  line 42   col 3   Unreachable 'return' after 'return'.\r\n\r\nfields/types/html/html.js\r\n  line 80   col 15  'i' is already defined.\r\n\r\nfields/types/relationship/relationship.js\r\n  line 109  col 19  Empty block.\r\n  line 109  col 7   'field' is not defined.\r\n  line 111  col 14  'field' is not defined.\r\n  line 118  col 11  'value' is not defined.\r\n\r\nlib/core/start.js\r\n  line 188  col 28  'https' is not defined.\r\n\r\n  ⚠  24 warnings\r\n```\r\nMoving forward. No new code should be accepted without corresponding tests and passing jshint."},"comment":{"url":"https://api.github.com/repos/keystonejs/keystone/issues/comments/69459307","html_url":"https://github.com/keystonejs/keystone/issues/865#issuecomment-69459307","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/865","id":69459307,"user":{"login":"sebmck","id":853712,"avatar_url":"https://avatars.githubusercontent.com/u/853712?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmck","html_url":"https://github.com/sebmck","followers_url":"https://api.github.com/users/sebmck/followers","following_url":"https://api.github.com/users/sebmck/following{/other_user}","gists_url":"https://api.github.com/users/sebmck/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmck/subscriptions","organizations_url":"https://api.github.com/users/sebmck/orgs","repos_url":"https://api.github.com/users/sebmck/repos","events_url":"https://api.github.com/users/sebmck/events{/privacy}","received_events_url":"https://api.github.com/users/sebmck/received_events","type":"User","site_admin":false},"created_at":"2015-01-10T15:23:40Z","updated_at":"2015-01-10T15:23:40Z","body":"Just a quick note, but if you're refactoring `Expected '!==' and instead saw '!='.` be **extremely** careful as in some places the type inference is critical."}}