{"action":"created","issue":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1742","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1742/labels{/name}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1742/comments","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1742/events","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1742","id":66771401,"number":1742,"title":"Improve performance with /ds","user":{"login":"SolarisFox","id":7889474,"avatar_url":"https://avatars.githubusercontent.com/u/7889474?v=3","gravatar_id":"","url":"https://api.github.com/users/SolarisFox","html_url":"https://github.com/SolarisFox","followers_url":"https://api.github.com/users/SolarisFox/followers","following_url":"https://api.github.com/users/SolarisFox/following{/other_user}","gists_url":"https://api.github.com/users/SolarisFox/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarisFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarisFox/subscriptions","organizations_url":"https://api.github.com/users/SolarisFox/orgs","repos_url":"https://api.github.com/users/SolarisFox/repos","events_url":"https://api.github.com/users/SolarisFox/events{/privacy}","received_events_url":"https://api.github.com/users/SolarisFox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-07T04:22:12Z","updated_at":"2015-04-08T02:54:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/1742","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1742","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1742.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1742.patch"},"body":"Reworked the search structure to use an ```Object.keys()``` array parallel to the dex object to avoid for-In loops\r\nremoved unnecessary uses of ```Tools.getMove()``` and ```Tools.getTemplate()```\r\n\r\nAverage search time currently reduced to around 20ms. (excluding recovery search)\r\n"},"comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments/90788950","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/1742#issuecomment-90788950","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/1742","id":90788950,"user":{"login":"monsanto","id":247721,"avatar_url":"https://avatars.githubusercontent.com/u/247721?v=3","gravatar_id":"","url":"https://api.github.com/users/monsanto","html_url":"https://github.com/monsanto","followers_url":"https://api.github.com/users/monsanto/followers","following_url":"https://api.github.com/users/monsanto/following{/other_user}","gists_url":"https://api.github.com/users/monsanto/gists{/gist_id}","starred_url":"https://api.github.com/users/monsanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monsanto/subscriptions","organizations_url":"https://api.github.com/users/monsanto/orgs","repos_url":"https://api.github.com/users/monsanto/repos","events_url":"https://api.github.com/users/monsanto/events{/privacy}","received_events_url":"https://api.github.com/users/monsanto/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T02:54:39Z","updated_at":"2015-04-08T02:54:39Z","body":"Are there any cases where you access an element of `dex`, where the key does not come from a loop over `Object.keys`? That is, are you actually making use of the hash table you have allocated? It doesn't seem so to me. Using an array will be much faster."}}