{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14","id":32105591,"html_url":"https://github.com/echocat/puppet-nfs/pull/14","diff_url":"https://github.com/echocat/puppet-nfs/pull/14.diff","patch_url":"https://github.com/echocat/puppet-nfs/pull/14.patch","issue_url":"https://api.github.com/repos/echocat/puppet-nfs/issues/14","number":14,"state":"open","locked":false,"title":"Changes to mount name param defined by server export class to remove spaces","user":{"login":"sedan07","id":1449113,"avatar_url":"https://avatars.githubusercontent.com/u/1449113?v=3","gravatar_id":"","url":"https://api.github.com/users/sedan07","html_url":"https://github.com/sedan07","followers_url":"https://api.github.com/users/sedan07/followers","following_url":"https://api.github.com/users/sedan07/following{/other_user}","gists_url":"https://api.github.com/users/sedan07/gists{/gist_id}","starred_url":"https://api.github.com/users/sedan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedan07/subscriptions","organizations_url":"https://api.github.com/users/sedan07/orgs","repos_url":"https://api.github.com/users/sedan07/repos","events_url":"https://api.github.com/users/sedan07/events{/privacy}","received_events_url":"https://api.github.com/users/sedan07/received_events","type":"User","site_admin":false},"body":"This pull request contains several fixes:\r\n* Fixing version of rspec used to work on ruby 1.8.7 so all travis runs work properly\r\n* Fixed usage of the PUPPET_GEM_VERSION and FACTER_GEM_VERSION env vars so travis builds actually use the dependancy versions they say they are\r\n* Fixed bug in naming of `mount()` type when not defining `mount` param on exports.\r\n\r\n**More info about mount bug:**\r\nCurrently when defining nfs3 mounts using `nfs::server::export` but not declaring the `mount` param it defaults to `undef` however because the `nfs::client::mount` defaults its `mount` param to the resources title the `undef` is ignored. This then results in the `name` param passed to the `mount()` type containing spaces (i.e. \"shared /srv/test by nfs.int.net\"). When running Puppet on the client you will get an error similar to the following on Puppet >= 3.3:\r\n\r\n```\r\nerror during compilation: Parameter name failed on Mount[shared nfs.int.net:/srv/share by mylocal.example.com shared /srv/test by nfs.int.net]: name must not contain whitespace...\r\n```\r\n\r\nSo to solve this setting `mount` to the `export_name` to ensure it is always set.\r\n\r\nSee Travis build: https://travis-ci.org/sedan07/puppet-nfs/builds/55987020 for proof of bug. Note: Puppet < 3.3 will allow spaces in mount name (but fails on dir creation) but Puppet >= 3.3 throws validation error.","created_at":"2015-03-27T13:06:35Z","updated_at":"2015-03-27T13:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14/commits","review_comments_url":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14/comments","review_comment_url":"https://api.github.com/repos/echocat/puppet-nfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/echocat/puppet-nfs/issues/14/comments","statuses_url":"https://api.github.com/repos/echocat/puppet-nfs/statuses/a0d94615dc914367a081e2976d25a60f8061753f","head":{"label":"sedan07:mount_naming","ref":"mount_naming","sha":"a0d94615dc914367a081e2976d25a60f8061753f","user":{"login":"sedan07","id":1449113,"avatar_url":"https://avatars.githubusercontent.com/u/1449113?v=3","gravatar_id":"","url":"https://api.github.com/users/sedan07","html_url":"https://github.com/sedan07","followers_url":"https://api.github.com/users/sedan07/followers","following_url":"https://api.github.com/users/sedan07/following{/other_user}","gists_url":"https://api.github.com/users/sedan07/gists{/gist_id}","starred_url":"https://api.github.com/users/sedan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedan07/subscriptions","organizations_url":"https://api.github.com/users/sedan07/orgs","repos_url":"https://api.github.com/users/sedan07/repos","events_url":"https://api.github.com/users/sedan07/events{/privacy}","received_events_url":"https://api.github.com/users/sedan07/received_events","type":"User","site_admin":false},"repo":{"id":32879671,"name":"puppet-nfs","full_name":"sedan07/puppet-nfs","owner":{"login":"sedan07","id":1449113,"avatar_url":"https://avatars.githubusercontent.com/u/1449113?v=3","gravatar_id":"","url":"https://api.github.com/users/sedan07","html_url":"https://github.com/sedan07","followers_url":"https://api.github.com/users/sedan07/followers","following_url":"https://api.github.com/users/sedan07/following{/other_user}","gists_url":"https://api.github.com/users/sedan07/gists{/gist_id}","starred_url":"https://api.github.com/users/sedan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedan07/subscriptions","organizations_url":"https://api.github.com/users/sedan07/orgs","repos_url":"https://api.github.com/users/sedan07/repos","events_url":"https://api.github.com/users/sedan07/events{/privacy}","received_events_url":"https://api.github.com/users/sedan07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sedan07/puppet-nfs","description":"Puppet module for automagic set up of up nfs servers and clients.  Storeconfigs is used for propogating configs to clients.  Optional nfs4-support.","fork":true,"url":"https://api.github.com/repos/sedan07/puppet-nfs","forks_url":"https://api.github.com/repos/sedan07/puppet-nfs/forks","keys_url":"https://api.github.com/repos/sedan07/puppet-nfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sedan07/puppet-nfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sedan07/puppet-nfs/teams","hooks_url":"https://api.github.com/repos/sedan07/puppet-nfs/hooks","issue_events_url":"https://api.github.com/repos/sedan07/puppet-nfs/issues/events{/number}","events_url":"https://api.github.com/repos/sedan07/puppet-nfs/events","assignees_url":"https://api.github.com/repos/sedan07/puppet-nfs/assignees{/user}","branches_url":"https://api.github.com/repos/sedan07/puppet-nfs/branches{/branch}","tags_url":"https://api.github.com/repos/sedan07/puppet-nfs/tags","blobs_url":"https://api.github.com/repos/sedan07/puppet-nfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sedan07/puppet-nfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sedan07/puppet-nfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sedan07/puppet-nfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sedan07/puppet-nfs/statuses/{sha}","languages_url":"https://api.github.com/repos/sedan07/puppet-nfs/languages","stargazers_url":"https://api.github.com/repos/sedan07/puppet-nfs/stargazers","contributors_url":"https://api.github.com/repos/sedan07/puppet-nfs/contributors","subscribers_url":"https://api.github.com/repos/sedan07/puppet-nfs/subscribers","subscription_url":"https://api.github.com/repos/sedan07/puppet-nfs/subscription","commits_url":"https://api.github.com/repos/sedan07/puppet-nfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sedan07/puppet-nfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sedan07/puppet-nfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sedan07/puppet-nfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sedan07/puppet-nfs/contents/{+path}","compare_url":"https://api.github.com/repos/sedan07/puppet-nfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sedan07/puppet-nfs/merges","archive_url":"https://api.github.com/repos/sedan07/puppet-nfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sedan07/puppet-nfs/downloads","issues_url":"https://api.github.com/repos/sedan07/puppet-nfs/issues{/number}","pulls_url":"https://api.github.com/repos/sedan07/puppet-nfs/pulls{/number}","milestones_url":"https://api.github.com/repos/sedan07/puppet-nfs/milestones{/number}","notifications_url":"https://api.github.com/repos/sedan07/puppet-nfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sedan07/puppet-nfs/labels{/name}","releases_url":"https://api.github.com/repos/sedan07/puppet-nfs/releases{/id}","created_at":"2015-03-25T17:20:43Z","updated_at":"2015-03-25T17:20:44Z","pushed_at":"2015-03-27T11:04:05Z","git_url":"git://github.com/sedan07/puppet-nfs.git","ssh_url":"git@github.com:sedan07/puppet-nfs.git","clone_url":"https://github.com/sedan07/puppet-nfs.git","svn_url":"https://github.com/sedan07/puppet-nfs","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"echocat:master","ref":"master","sha":"6efe4e4a078ae5437199901e6630f1b234aa9f6e","user":{"login":"echocat","id":3128980,"avatar_url":"https://avatars.githubusercontent.com/u/3128980?v=3","gravatar_id":"","url":"https://api.github.com/users/echocat","html_url":"https://github.com/echocat","followers_url":"https://api.github.com/users/echocat/followers","following_url":"https://api.github.com/users/echocat/following{/other_user}","gists_url":"https://api.github.com/users/echocat/gists{/gist_id}","starred_url":"https://api.github.com/users/echocat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echocat/subscriptions","organizations_url":"https://api.github.com/users/echocat/orgs","repos_url":"https://api.github.com/users/echocat/repos","events_url":"https://api.github.com/users/echocat/events{/privacy}","received_events_url":"https://api.github.com/users/echocat/received_events","type":"Organization","site_admin":false},"repo":{"id":27921793,"name":"puppet-nfs","full_name":"echocat/puppet-nfs","owner":{"login":"echocat","id":3128980,"avatar_url":"https://avatars.githubusercontent.com/u/3128980?v=3","gravatar_id":"","url":"https://api.github.com/users/echocat","html_url":"https://github.com/echocat","followers_url":"https://api.github.com/users/echocat/followers","following_url":"https://api.github.com/users/echocat/following{/other_user}","gists_url":"https://api.github.com/users/echocat/gists{/gist_id}","starred_url":"https://api.github.com/users/echocat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echocat/subscriptions","organizations_url":"https://api.github.com/users/echocat/orgs","repos_url":"https://api.github.com/users/echocat/repos","events_url":"https://api.github.com/users/echocat/events{/privacy}","received_events_url":"https://api.github.com/users/echocat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/echocat/puppet-nfs","description":"Puppet module for automagic set up of up nfs servers and clients.  Storeconfigs is used for propogating configs to clients.  Optional nfs4-support.","fork":true,"url":"https://api.github.com/repos/echocat/puppet-nfs","forks_url":"https://api.github.com/repos/echocat/puppet-nfs/forks","keys_url":"https://api.github.com/repos/echocat/puppet-nfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echocat/puppet-nfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echocat/puppet-nfs/teams","hooks_url":"https://api.github.com/repos/echocat/puppet-nfs/hooks","issue_events_url":"https://api.github.com/repos/echocat/puppet-nfs/issues/events{/number}","events_url":"https://api.github.com/repos/echocat/puppet-nfs/events","assignees_url":"https://api.github.com/repos/echocat/puppet-nfs/assignees{/user}","branches_url":"https://api.github.com/repos/echocat/puppet-nfs/branches{/branch}","tags_url":"https://api.github.com/repos/echocat/puppet-nfs/tags","blobs_url":"https://api.github.com/repos/echocat/puppet-nfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echocat/puppet-nfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echocat/puppet-nfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/echocat/puppet-nfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echocat/puppet-nfs/statuses/{sha}","languages_url":"https://api.github.com/repos/echocat/puppet-nfs/languages","stargazers_url":"https://api.github.com/repos/echocat/puppet-nfs/stargazers","contributors_url":"https://api.github.com/repos/echocat/puppet-nfs/contributors","subscribers_url":"https://api.github.com/repos/echocat/puppet-nfs/subscribers","subscription_url":"https://api.github.com/repos/echocat/puppet-nfs/subscription","commits_url":"https://api.github.com/repos/echocat/puppet-nfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/echocat/puppet-nfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/echocat/puppet-nfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/echocat/puppet-nfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/echocat/puppet-nfs/contents/{+path}","compare_url":"https://api.github.com/repos/echocat/puppet-nfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echocat/puppet-nfs/merges","archive_url":"https://api.github.com/repos/echocat/puppet-nfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echocat/puppet-nfs/downloads","issues_url":"https://api.github.com/repos/echocat/puppet-nfs/issues{/number}","pulls_url":"https://api.github.com/repos/echocat/puppet-nfs/pulls{/number}","milestones_url":"https://api.github.com/repos/echocat/puppet-nfs/milestones{/number}","notifications_url":"https://api.github.com/repos/echocat/puppet-nfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echocat/puppet-nfs/labels{/name}","releases_url":"https://api.github.com/repos/echocat/puppet-nfs/releases{/id}","created_at":"2014-12-12T13:37:23Z","updated_at":"2015-03-26T18:11:58Z","pushed_at":"2015-03-27T13:06:36Z","git_url":"git://github.com/echocat/puppet-nfs.git","ssh_url":"git@github.com:echocat/puppet-nfs.git","clone_url":"https://github.com/echocat/puppet-nfs.git","svn_url":"https://github.com/echocat/puppet-nfs","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14"},"html":{"href":"https://github.com/echocat/puppet-nfs/pull/14"},"issue":{"href":"https://api.github.com/repos/echocat/puppet-nfs/issues/14"},"comments":{"href":"https://api.github.com/repos/echocat/puppet-nfs/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/echocat/puppet-nfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/echocat/puppet-nfs/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/echocat/puppet-nfs/statuses/a0d94615dc914367a081e2976d25a60f8061753f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":42,"deletions":8,"changed_files":4}}