{"action":"created","comment":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/comments/44680157","id":44680157,"diff_hunk":"@@ -267,7 +267,6 @@ gulp.task('metadata', () => {\n gulp.task('default', ['clean'], cb => {\n   runSequence(\n     ['styles', 'styles-grid'],\n-    ['scripts'],","path":"gulpfile.babel.js","position":4,"original_position":4,"commit_id":"faf78e97baa193747dda3a6b39b1a4688699de42","original_commit_id":"faf78e97baa193747dda3a6b39b1a4688699de42","user":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"body":"The only way to not do this, is to have mocha be an independent task and not depend upon `scripts`. However, this then means we always need to do `gulp scripts && gulp mocha` when testing instead of just `gulp mocha` to run the unit tests. We'd also need to update the `test`  task to run scripts manually before mocha.","created_at":"2015-11-12T16:38:56Z","updated_at":"2015-11-12T16:38:56Z","html_url":"https://github.com/google/material-design-lite/pull/1874#discussion_r44680157","pull_request_url":"https://api.github.com/repos/google/material-design-lite/pulls/1874","_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments/44680157"},"html":{"href":"https://github.com/google/material-design-lite/pull/1874#discussion_r44680157"},"pull_request":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1874"}}},"pull_request":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/1874","id":50529330,"html_url":"https://github.com/google/material-design-lite/pull/1874","diff_url":"https://github.com/google/material-design-lite/pull/1874.diff","patch_url":"https://github.com/google/material-design-lite/pull/1874.patch","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/1874","number":1874,"state":"open","locked":false,"title":"Make mocha depend upon scripts, not styles.","user":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"body":"Mocha tests don't depend upon proper styling being generated. The scripts however, are the requirement. This addresses that and simplifies the `default` and `all`  tasks to take this into account.","created_at":"2015-11-12T16:03:16Z","updated_at":"2015-11-12T16:38:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff4bec76385af1c4dcbef239b30e71332e72a7ca","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/material-design-lite/milestones/3","html_url":"https://github.com/google/material-design-lite/milestones/V1.1","labels_url":"https://api.github.com/repos/google/material-design-lite/milestones/3/labels","id":1202434,"number":3,"title":"V1.1","description":"First minor update!\r\n\r\nFull plans not yet set out, purely informational at the moment.","creator":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":48,"state":"open","created_at":"2015-07-10T12:50:28Z","updated_at":"2015-11-12T16:03:16Z","due_on":"2015-11-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/material-design-lite/pulls/1874/commits","review_comments_url":"https://api.github.com/repos/google/material-design-lite/pulls/1874/comments","review_comment_url":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/1874/comments","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/faf78e97baa193747dda3a6b39b1a4688699de42","head":{"label":"google:garbee/hotfix/gulp","ref":"garbee/hotfix/gulp","sha":"faf78e97baa193747dda3a6b39b1a4688699de42","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Lite Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","created_at":"2015-01-14T22:01:33Z","updated_at":"2015-11-12T16:08:39Z","pushed_at":"2015-11-12T16:03:17Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":65847,"stargazers_count":16013,"watchers_count":16013,"language":"CSS","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2257,"mirror_url":null,"open_issues_count":296,"forks":2257,"open_issues":296,"watchers":16013,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a308d3fa779a915642061a956f16cd97c6677553","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29268051,"name":"material-design-lite","full_name":"google/material-design-lite","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/material-design-lite","description":"Material Design Lite Components in HTML/CSS/JS","fork":false,"url":"https://api.github.com/repos/google/material-design-lite","forks_url":"https://api.github.com/repos/google/material-design-lite/forks","keys_url":"https://api.github.com/repos/google/material-design-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/material-design-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/material-design-lite/teams","hooks_url":"https://api.github.com/repos/google/material-design-lite/hooks","issue_events_url":"https://api.github.com/repos/google/material-design-lite/issues/events{/number}","events_url":"https://api.github.com/repos/google/material-design-lite/events","assignees_url":"https://api.github.com/repos/google/material-design-lite/assignees{/user}","branches_url":"https://api.github.com/repos/google/material-design-lite/branches{/branch}","tags_url":"https://api.github.com/repos/google/material-design-lite/tags","blobs_url":"https://api.github.com/repos/google/material-design-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/material-design-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/material-design-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/material-design-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/material-design-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/google/material-design-lite/languages","stargazers_url":"https://api.github.com/repos/google/material-design-lite/stargazers","contributors_url":"https://api.github.com/repos/google/material-design-lite/contributors","subscribers_url":"https://api.github.com/repos/google/material-design-lite/subscribers","subscription_url":"https://api.github.com/repos/google/material-design-lite/subscription","commits_url":"https://api.github.com/repos/google/material-design-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/material-design-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/material-design-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/material-design-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/material-design-lite/contents/{+path}","compare_url":"https://api.github.com/repos/google/material-design-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/material-design-lite/merges","archive_url":"https://api.github.com/repos/google/material-design-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/material-design-lite/downloads","issues_url":"https://api.github.com/repos/google/material-design-lite/issues{/number}","pulls_url":"https://api.github.com/repos/google/material-design-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/google/material-design-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/google/material-design-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/material-design-lite/labels{/name}","releases_url":"https://api.github.com/repos/google/material-design-lite/releases{/id}","created_at":"2015-01-14T22:01:33Z","updated_at":"2015-11-12T16:08:39Z","pushed_at":"2015-11-12T16:03:17Z","git_url":"git://github.com/google/material-design-lite.git","ssh_url":"git@github.com:google/material-design-lite.git","clone_url":"https://github.com/google/material-design-lite.git","svn_url":"https://github.com/google/material-design-lite","homepage":"http://getmdl.io","size":65847,"stargazers_count":16013,"watchers_count":16013,"language":"CSS","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2257,"mirror_url":null,"open_issues_count":296,"forks":2257,"open_issues":296,"watchers":16013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1874"},"html":{"href":"https://github.com/google/material-design-lite/pull/1874"},"issue":{"href":"https://api.github.com/repos/google/material-design-lite/issues/1874"},"comments":{"href":"https://api.github.com/repos/google/material-design-lite/issues/1874/comments"},"review_comments":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1874/comments"},"review_comment":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/material-design-lite/pulls/1874/commits"},"statuses":{"href":"https://api.github.com/repos/google/material-design-lite/statuses/faf78e97baa193747dda3a6b39b1a4688699de42"}}}}