{"action":"created","comment":{"url":"https://api.github.com/repos/valhalla/thor/pulls/comments/40821793","id":40821793,"diff_hunk":"@@ -76,6 +76,17 @@ struct Destination {\n class TimeDistanceMatrix : public PathAlgorithm {\n  public:\n   /**\n+   * Constructor with default cost threshold.\n+   */\n+  TimeDistanceMatrix();","path":"valhalla/thor/timedistancematrix.h","position":6,"original_position":6,"commit_id":"3012624ec7fc17d91d548a61fcf831472fac43f7","original_commit_id":"3012624ec7fc17d91d548a61fcf831472fac43f7","user":{"login":"kevinkreiser","id":697548,"avatar_url":"https://avatars.githubusercontent.com/u/697548?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkreiser","html_url":"https://github.com/kevinkreiser","followers_url":"https://api.github.com/users/kevinkreiser/followers","following_url":"https://api.github.com/users/kevinkreiser/following{/other_user}","gists_url":"https://api.github.com/users/kevinkreiser/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkreiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkreiser/subscriptions","organizations_url":"https://api.github.com/users/kevinkreiser/orgs","repos_url":"https://api.github.com/users/kevinkreiser/repos","events_url":"https://api.github.com/users/kevinkreiser/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkreiser/received_events","type":"User","site_admin":false},"body":"instead of having two constructors can we just have one that defaults the threshhold?:\r\n\r\n`TimeDistanceMatrix(float initial_cost_threshhold = DEFAULT_COST_THRESHOLD);`","created_at":"2015-09-30T17:11:59Z","updated_at":"2015-09-30T17:11:59Z","html_url":"https://github.com/valhalla/thor/pull/238#discussion_r40821793","pull_request_url":"https://api.github.com/repos/valhalla/thor/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/valhalla/thor/pulls/comments/40821793"},"html":{"href":"https://github.com/valhalla/thor/pull/238#discussion_r40821793"},"pull_request":{"href":"https://api.github.com/repos/valhalla/thor/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/valhalla/thor/pulls/238","id":46429265,"html_url":"https://github.com/valhalla/thor/pull/238","diff_url":"https://github.com/valhalla/thor/pull/238.diff","patch_url":"https://github.com/valhalla/thor/pull/238.patch","issue_url":"https://api.github.com/repos/valhalla/thor/issues/238","number":238,"state":"open","locked":false,"title":"Customize cost threshold in TimeDistanceMatrix constructor","user":{"login":"ptpt","id":87357,"avatar_url":"https://avatars.githubusercontent.com/u/87357?v=3","gravatar_id":"","url":"https://api.github.com/users/ptpt","html_url":"https://github.com/ptpt","followers_url":"https://api.github.com/users/ptpt/followers","following_url":"https://api.github.com/users/ptpt/following{/other_user}","gists_url":"https://api.github.com/users/ptpt/gists{/gist_id}","starred_url":"https://api.github.com/users/ptpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptpt/subscriptions","organizations_url":"https://api.github.com/users/ptpt/orgs","repos_url":"https://api.github.com/users/ptpt/repos","events_url":"https://api.github.com/users/ptpt/events{/privacy}","received_events_url":"https://api.github.com/users/ptpt/received_events","type":"User","site_admin":false},"body":"So that you can use the cost threshold to control the search range.","created_at":"2015-09-30T17:08:28Z","updated_at":"2015-09-30T17:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cec75ca56465bb4a244a4eea440f8f4125abaadc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/thor/pulls/238/commits","review_comments_url":"https://api.github.com/repos/valhalla/thor/pulls/238/comments","review_comment_url":"https://api.github.com/repos/valhalla/thor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/thor/issues/238/comments","statuses_url":"https://api.github.com/repos/valhalla/thor/statuses/3012624ec7fc17d91d548a61fcf831472fac43f7","head":{"label":"mapillary:timedistance","ref":"timedistance","sha":"3012624ec7fc17d91d548a61fcf831472fac43f7","user":{"login":"mapillary","id":5332499,"avatar_url":"https://avatars.githubusercontent.com/u/5332499?v=3","gravatar_id":"","url":"https://api.github.com/users/mapillary","html_url":"https://github.com/mapillary","followers_url":"https://api.github.com/users/mapillary/followers","following_url":"https://api.github.com/users/mapillary/following{/other_user}","gists_url":"https://api.github.com/users/mapillary/gists{/gist_id}","starred_url":"https://api.github.com/users/mapillary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapillary/subscriptions","organizations_url":"https://api.github.com/users/mapillary/orgs","repos_url":"https://api.github.com/users/mapillary/repos","events_url":"https://api.github.com/users/mapillary/events{/privacy}","received_events_url":"https://api.github.com/users/mapillary/received_events","type":"Organization","site_admin":false},"repo":{"id":40995037,"name":"thor","full_name":"mapillary/thor","owner":{"login":"mapillary","id":5332499,"avatar_url":"https://avatars.githubusercontent.com/u/5332499?v=3","gravatar_id":"","url":"https://api.github.com/users/mapillary","html_url":"https://github.com/mapillary","followers_url":"https://api.github.com/users/mapillary/followers","following_url":"https://api.github.com/users/mapillary/following{/other_user}","gists_url":"https://api.github.com/users/mapillary/gists{/gist_id}","starred_url":"https://api.github.com/users/mapillary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapillary/subscriptions","organizations_url":"https://api.github.com/users/mapillary/orgs","repos_url":"https://api.github.com/users/mapillary/repos","events_url":"https://api.github.com/users/mapillary/events{/privacy}","received_events_url":"https://api.github.com/users/mapillary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapillary/thor","description":"Tiled Hierarchical Open Routing - a routing engine backed by tiled open source routing data","fork":true,"url":"https://api.github.com/repos/mapillary/thor","forks_url":"https://api.github.com/repos/mapillary/thor/forks","keys_url":"https://api.github.com/repos/mapillary/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapillary/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapillary/thor/teams","hooks_url":"https://api.github.com/repos/mapillary/thor/hooks","issue_events_url":"https://api.github.com/repos/mapillary/thor/issues/events{/number}","events_url":"https://api.github.com/repos/mapillary/thor/events","assignees_url":"https://api.github.com/repos/mapillary/thor/assignees{/user}","branches_url":"https://api.github.com/repos/mapillary/thor/branches{/branch}","tags_url":"https://api.github.com/repos/mapillary/thor/tags","blobs_url":"https://api.github.com/repos/mapillary/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapillary/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapillary/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapillary/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapillary/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/mapillary/thor/languages","stargazers_url":"https://api.github.com/repos/mapillary/thor/stargazers","contributors_url":"https://api.github.com/repos/mapillary/thor/contributors","subscribers_url":"https://api.github.com/repos/mapillary/thor/subscribers","subscription_url":"https://api.github.com/repos/mapillary/thor/subscription","commits_url":"https://api.github.com/repos/mapillary/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapillary/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapillary/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapillary/thor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapillary/thor/contents/{+path}","compare_url":"https://api.github.com/repos/mapillary/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapillary/thor/merges","archive_url":"https://api.github.com/repos/mapillary/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapillary/thor/downloads","issues_url":"https://api.github.com/repos/mapillary/thor/issues{/number}","pulls_url":"https://api.github.com/repos/mapillary/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/mapillary/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/mapillary/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapillary/thor/labels{/name}","releases_url":"https://api.github.com/repos/mapillary/thor/releases{/id}","created_at":"2015-08-18T20:08:02Z","updated_at":"2015-08-18T20:08:04Z","pushed_at":"2015-09-30T16:51:48Z","git_url":"git://github.com/mapillary/thor.git","ssh_url":"git@github.com:mapillary/thor.git","clone_url":"https://github.com/mapillary/thor.git","svn_url":"https://github.com/mapillary/thor","homepage":null,"size":4661,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"60e6ffa97554fdcd761a0098eade9aa8323a0054","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":28186592,"name":"thor","full_name":"valhalla/thor","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/thor","description":"Tiled Hierarchical Open Routing - a routing engine backed by tiled open source routing data","fork":false,"url":"https://api.github.com/repos/valhalla/thor","forks_url":"https://api.github.com/repos/valhalla/thor/forks","keys_url":"https://api.github.com/repos/valhalla/thor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/thor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/thor/teams","hooks_url":"https://api.github.com/repos/valhalla/thor/hooks","issue_events_url":"https://api.github.com/repos/valhalla/thor/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/thor/events","assignees_url":"https://api.github.com/repos/valhalla/thor/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/thor/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/thor/tags","blobs_url":"https://api.github.com/repos/valhalla/thor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/thor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/thor/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/thor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/thor/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/thor/languages","stargazers_url":"https://api.github.com/repos/valhalla/thor/stargazers","contributors_url":"https://api.github.com/repos/valhalla/thor/contributors","subscribers_url":"https://api.github.com/repos/valhalla/thor/subscribers","subscription_url":"https://api.github.com/repos/valhalla/thor/subscription","commits_url":"https://api.github.com/repos/valhalla/thor/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/thor/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/thor/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/thor/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/thor/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/thor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/thor/merges","archive_url":"https://api.github.com/repos/valhalla/thor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/thor/downloads","issues_url":"https://api.github.com/repos/valhalla/thor/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/thor/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/thor/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/thor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/thor/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/thor/releases{/id}","created_at":"2014-12-18T14:25:42Z","updated_at":"2015-09-19T15:11:19Z","pushed_at":"2015-09-30T17:08:29Z","git_url":"git://github.com/valhalla/thor.git","ssh_url":"git@github.com:valhalla/thor.git","clone_url":"https://github.com/valhalla/thor.git","svn_url":"https://github.com/valhalla/thor","homepage":null,"size":6680,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/thor/pulls/238"},"html":{"href":"https://github.com/valhalla/thor/pull/238"},"issue":{"href":"https://api.github.com/repos/valhalla/thor/issues/238"},"comments":{"href":"https://api.github.com/repos/valhalla/thor/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/thor/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/thor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/thor/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/thor/statuses/3012624ec7fc17d91d548a61fcf831472fac43f7"}}}}