{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/12718","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12718/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12718/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12718/events","html_url":"https://github.com/cms-sw/cmssw/pull/12718","id":121093259,"number":12718,"title":"Ccctf tuning","user":{"login":"rovere","id":1169991,"avatar_url":"https://avatars.githubusercontent.com/u/1169991?v=3","gravatar_id":"","url":"https://api.github.com/users/rovere","html_url":"https://github.com/rovere","followers_url":"https://api.github.com/users/rovere/followers","following_url":"https://api.github.com/users/rovere/following{/other_user}","gists_url":"https://api.github.com/users/rovere/gists{/gist_id}","starred_url":"https://api.github.com/users/rovere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovere/subscriptions","organizations_url":"https://api.github.com/users/rovere/orgs","repos_url":"https://api.github.com/users/rovere/repos","events_url":"https://api.github.com/users/rovere/events{/privacy}","received_events_url":"https://api.github.com/users/rovere/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-approved","name":"hlt-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":350,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2015-12-11T11:01:14Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2015-12-08T20:33:14Z","updated_at":"2015-12-11T11:06:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12718","html_url":"https://github.com/cms-sw/cmssw/pull/12718","diff_url":"https://github.com/cms-sw/cmssw/pull/12718.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12718.patch"},"body":"## Executive Summary\r\n\r\nThis PR is the first tuning of the cluster charge cut (CCC) that tries to recover hits-on-track on real data, while keeping the same performances in terms of efficiency, fake-rate and timing on Monte Carlo.\r\n\r\nIt is not excluded that some minor fine tuning will be needed in the course of the release, depending also on the outcome of the full release validation with this first set of changes.\r\n\r\n### Monte Carlo\r\nThe standard set of tracking MTV validation plots for a TTBar sample (35PU@25ns) that compares this PR against a recent IB are available at this [link](https://roverepublic.web.cern.ch/roverepublic/MTV_ProposedTuning2/). The main points to notice are:\r\n\r\n* overall the performance in terms of efficiency is quite the same, except for a small loss at very low pt (could be a further fine-tune will come trying to recover also this tiny fraction) [see here](https://roverepublic.web.cern.ch/roverepublic/MTV_ProposedTuning2/plots_summary_highPurity/summary.pdf)\r\n* The fake-rate increase from an ~8% to a ~10%, but this, in a sense, is kind of unavoidable, given the nature of this PR (recovering hits implies also adding some fake ones, unfortunately). Again, [see here](https://roverepublic.web.cern.ch/roverepublic/MTV_ProposedTuning2/plots_summary_highPurity/summary.pdf) for plots. Anyway we believe this level of fake is still ok, especially since it is computed with quite loose requirements. And we do not want to hold this any further.\r\n* in terms of timing, from private measurements, the reco time goes from 7.9 sec/ev to 8 sec/ev, so basically we do not observe any slowdown.\r\n* Unfortunately the MC simulation does not properly simulate the loss of hit-collection-efficiency we see on data: in order to see the real effects, we also privately reconstructed 1K event from 260627.\r\n\r\n### Data (SingleMuon, Run 260627)\r\n\r\n#### Hits on Track\r\nThe results are nicely summarized [here](https://www.dropbox.com/s/07wcxcccy5m1nxh/hits.png?dl=0)\r\n\r\n* Legend:\r\n   * black: this PR\r\n   * blue: an intermediate tuning\r\n   * orange: recent IB w/o this PR\r\n   * red: prompt-reco on the full statistics\r\n\r\n* Comments\r\n   * this PR recovers ~2 hits on track on the full eta range (black vs orange).\r\n   * the red is above the orange simply because it integrates the full run, including the last part at \"low-lumi\"\r\n\r\n#### Hit Efficiency \r\n\r\nThe plot is available [here](https://www.dropbox.com/s/hqdfptbbpr12la3/globalEfficiencies.png?dl=0). There are clear improvements in all SiStrip detectors, especially in TIB and TOB. More plots available from within CERN only [here](http://mrovere-dqmgui-slc6.cern.ch:8060/dqm/dev/start?runnr=260627;dataset=/SingleMuon/ReReco260627_ProposedTuning2_80X/DQMIO;sampletype=offline_data;filter=all;referencepos=overlay;referenceshow=all;referenceobj1=other%3A%3A/RelValTTbar/CMSSW_8_0_0_ProposedTuning2/DQMIO%3A;referenceobj2=other%3A%3A/SingleMuon/ReReco260627_ProposedTuning_80X/DQMIO%3A;referenceobj3=other%3A%3A/SingleMuon/ReReco260627_80X/DQMIO%3A;referenceobj4=other%3A%3A/SingleMuon/Run2015D-PromptReco-v4/DQMIO%3A;search=effi;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=Everything;size=M;root=Tracking/TrackParameters/highPurityTracks/pt_1/HitEffFromHitPattern;focus=;zoom=no;).\r\n\r\n#### SiStrip Cluster Charge Plots\r\n\r\nFew plots are available [here for TIB](https://www.dropbox.com/s/uef4x5izi8k5075/TIB_Charge.png?dl=0) and [here for TOB](https://www.dropbox.com/s/hgyhxziw3l84cy1/TOB_Charge.png?dl=0). From these plots it is quite clear the effect of the current PR.\r\n\r\n#### Timing\r\n\r\nTiming wise, I observed no significant slowdown comparing 80X vanilla reco and 80X+this PR reco.\r\n\r\n## New CCC Logic\r\n\r\nThe cluster charge cut is now applied in 2 different ways:\r\n* as en estimator, while deciding if a hit is compatible or not. This is the CCC that we have been using during 2015@25ns data taking. For the first 4 iterations the threshold of this cut has been lowered to 800 (was 1620/1945), while for all the latter, the thresholds are identical to what was already there.\r\n* as a trajectory filter. The first 4 iterations will accept at most 2 hits (either consecutive or not) whose charge is in the range 800;1620 (the current Loose threshold). The exception is the LowPt iteration, that will only accept one such hit (the reason being that there is not much gain in pushing it up to 2 for this iteration).\r\n* All the logic beyond the first 4 iterations has been unchanged, in order to contain timing and fake-rate.\r\n\r\n## Miscellanea\r\n\r\nThis PR contains also a customise for HLT in order to avoid crashes@HLT due to the fact that a parameter has been changed from a simple double to a refToPset_, in order to keep the symmetry with all other CCC cuts. I leave the \"integration\" of the customize into the HLT Menu to HLT experts\r\n\r\n@mtosi "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/163911141","html_url":"https://github.com/cms-sw/cmssw/pull/12718#issuecomment-163911141","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12718","id":163911141,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T11:06:14Z","updated_at":"2015-12-11T11:06:14Z","body":"This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @degano, @smuzaffar"}}