{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/36811451","id":36811451,"diff_hunk":"@@ -2481,23 +2481,14 @@ class Player extends Component {\n }\n \n /*\n- * Global player list\n- *\n- * @type {Object}\n- */\n-Player.players = {};","path":"src/js/player.js","position":82,"original_position":80,"commit_id":"52ac8c6f0ed63773ef97d3c62eb1469a0257f0ba","original_commit_id":"f377fb042fb532f1d3aedd042e3c5ebf29c19fdc","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"In 5.0 `videojs` is the main file and everything else gets imported into video.js to be exported. We can't rely on the videojs object being everywhere anymore because then videojs would require everything else and everything else would require videojs. This PR is both adding the circular dependency by importing video.js into player.js and then trying to fix it. Is there some blocker you ran into that sent you down this path?\r\n\r\nThings like `videojs.players` and `videojs.options` are just short cuts to lower level lists, so people don't have to do `videojs.getComponent('Player').players` or `videojs.getComponent('Player').prototype.options_`","created_at":"2015-08-11T23:18:12Z","updated_at":"2015-08-11T23:18:12Z","html_url":"https://github.com/videojs/video.js/pull/2461#discussion_r36811451","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2461","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/36811451"},"html":{"href":"https://github.com/videojs/video.js/pull/2461#discussion_r36811451"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2461"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2461","id":42144094,"html_url":"https://github.com/videojs/video.js/pull/2461","diff_url":"https://github.com/videojs/video.js/pull/2461.diff","patch_url":"https://github.com/videojs/video.js/pull/2461.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2461","number":2461,"state":"open","locked":false,"title":"Make global options a simple property","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"Remove getters and setters for the global options because they imply a contract that we were violating all over the place. Remove Player.players because it was just an alias for videojs.getPlayers(). Convert mergeOptions() so that it does not mutate its first option to follow 4.x behavior.","created_at":"2015-08-11T15:43:31Z","updated_at":"2015-08-11T23:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9afa2fd1c288c66449961b576c15274b8447e3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2461/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2461/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2461/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/52ac8c6f0ed63773ef97d3c62eb1469a0257f0ba","head":{"label":"dmlap:make-globals-a-global","ref":"make-globals-a-global","sha":"52ac8c6f0ed63773ef97d3c62eb1469a0257f0ba","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"repo":{"id":7782368,"name":"video.js","full_name":"dmlap/video.js","owner":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmlap/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/dmlap/video.js","forks_url":"https://api.github.com/repos/dmlap/video.js/forks","keys_url":"https://api.github.com/repos/dmlap/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlap/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlap/video.js/teams","hooks_url":"https://api.github.com/repos/dmlap/video.js/hooks","issue_events_url":"https://api.github.com/repos/dmlap/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/dmlap/video.js/events","assignees_url":"https://api.github.com/repos/dmlap/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/dmlap/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/dmlap/video.js/tags","blobs_url":"https://api.github.com/repos/dmlap/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlap/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlap/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlap/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlap/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlap/video.js/languages","stargazers_url":"https://api.github.com/repos/dmlap/video.js/stargazers","contributors_url":"https://api.github.com/repos/dmlap/video.js/contributors","subscribers_url":"https://api.github.com/repos/dmlap/video.js/subscribers","subscription_url":"https://api.github.com/repos/dmlap/video.js/subscription","commits_url":"https://api.github.com/repos/dmlap/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlap/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlap/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlap/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlap/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/dmlap/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlap/video.js/merges","archive_url":"https://api.github.com/repos/dmlap/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlap/video.js/downloads","issues_url":"https://api.github.com/repos/dmlap/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/dmlap/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlap/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlap/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlap/video.js/labels{/name}","releases_url":"https://api.github.com/repos/dmlap/video.js/releases{/id}","created_at":"2013-01-23T19:48:25Z","updated_at":"2015-04-29T21:07:18Z","pushed_at":"2015-08-11T22:45:55Z","git_url":"git://github.com/dmlap/video.js.git","ssh_url":"git@github.com:dmlap/video.js.git","clone_url":"https://github.com/dmlap/video.js.git","svn_url":"https://github.com/dmlap/video.js","homepage":"videojs.com","size":16342,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"70fec0bc5084a008eb89957ac83c5e68cf4e20c9","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-08-11T20:19:09Z","pushed_at":"2015-08-11T22:45:57Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":56684,"stargazers_count":9795,"watchers_count":9795,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2821,"mirror_url":null,"open_issues_count":207,"forks":2821,"open_issues":207,"watchers":9795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2461"},"html":{"href":"https://github.com/videojs/video.js/pull/2461"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2461"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2461/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2461/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2461/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/52ac8c6f0ed63773ef97d3c62eb1469a0257f0ba"}}}}