{"action":"created","comment":{"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments/48157460","id":48157460,"diff_hunk":"@@ -62,7 +62,13 @@ public function buildForm(FormBuilderInterface $builder, array $options)\n         foreach ($entityProperties as $name => $metadata) {\n             $formFieldOptions = $metadata['type_options'];\n \n-            if ('association' === $metadata['type']) {\n+            if ('entity' === $metadata['fieldType'] && 'association' === $metadata['type']) {\n+                if (!isset($formFieldOptions['class'])) {\n+                    $guessedOptions = $this->guesser->guessType($builder->getDataClass(), $name)->getOptions();","path":"Form/Type/EasyAdminFormType.php","position":7,"original_position":7,"commit_id":"4731ab85354918b9da4670c7f494aa6ca10c523b","original_commit_id":"eee9cdb5222b3dc04839a8dd6ff1ec5e0635cf85","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"body":"Exact! \r\nI meant the `doctrine-bridge` is required for this to work because it used the `DoctrineOrmTypeGuesser`, and I doubt someone will use Doctrine ORM with Symfony without the bundle, so actually without the bridge where is located this class. :)\r\n\r\nBut anyway, the `EntityType` is in the `doctrine-bridge`, so my assumptions were safe enough, except if someone played with the `form.type_guesser.doctrine` service.","created_at":"2015-12-21T15:45:01Z","updated_at":"2015-12-21T15:45:01Z","html_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672#discussion_r48157460","pull_request_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments/48157460"},"html":{"href":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672#discussion_r48157460"},"pull_request":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672","id":54262130,"html_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672","diff_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672.diff","patch_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672.patch","issue_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/672","number":672,"state":"open","locked":false,"title":"[Configurator] Explicitly use \"entity\" type for associations instead of guessing it later","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"body":"Related to #661. \r\nDepends on the #671 bug fix.\r\n\r\nAs you can see in tests, this would probably cause some issues if someone is relying on the `field-default` css class instead of the `field-entity` one.\r\nI hope that'll be the only one.","created_at":"2015-12-21T14:32:52Z","updated_at":"2015-12-21T15:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec1c8799b3dd535f8d934482b2c92d9206b9fdcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672/commits","review_comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672/comments","review_comment_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/672/comments","statuses_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/4731ab85354918b9da4670c7f494aa6ca10c523b","head":{"label":"ogizanagi:associations_entity_type","ref":"associations_entity_type","sha":"4731ab85354918b9da4670c7f494aa6ca10c523b","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"repo":{"id":29977379,"name":"EasyAdminBundle","full_name":"ogizanagi/EasyAdminBundle","owner":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogizanagi/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":true,"url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle","forks_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/releases{/id}","created_at":"2015-01-28T16:45:06Z","updated_at":"2015-10-20T19:58:32Z","pushed_at":"2015-12-21T15:38:15Z","git_url":"git://github.com/ogizanagi/EasyAdminBundle.git","ssh_url":"git@github.com:ogizanagi/EasyAdminBundle.git","clone_url":"https://github.com/ogizanagi/EasyAdminBundle.git","svn_url":"https://github.com/ogizanagi/EasyAdminBundle","homepage":"","size":4886,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"javiereguiluz:master","ref":"master","sha":"ab76b096ae162886171a78011287cba4dc9bf456","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":29126334,"name":"EasyAdminBundle","full_name":"javiereguiluz/EasyAdminBundle","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":false,"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle","forks_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/releases{/id}","created_at":"2015-01-12T08:43:02Z","updated_at":"2015-12-18T15:44:20Z","pushed_at":"2015-12-21T15:38:16Z","git_url":"git://github.com/javiereguiluz/EasyAdminBundle.git","ssh_url":"git@github.com:javiereguiluz/EasyAdminBundle.git","clone_url":"https://github.com/javiereguiluz/EasyAdminBundle.git","svn_url":"https://github.com/javiereguiluz/EasyAdminBundle","homepage":"","size":5798,"stargazers_count":719,"watchers_count":719,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":47,"forks":112,"open_issues":47,"watchers":719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672"},"html":{"href":"https://github.com/javiereguiluz/EasyAdminBundle/pull/672"},"issue":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/672"},"comments":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/4731ab85354918b9da4670c7f494aa6ca10c523b"}}}}