{"action":"closed","number":219,"pull_request":{"url":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219","id":30360029,"html_url":"https://github.com/KanoComputing/kano-settings/pull/219","diff_url":"https://github.com/KanoComputing/kano-settings/pull/219.diff","patch_url":"https://github.com/KanoComputing/kano-settings/pull/219.patch","issue_url":"https://api.github.com/repos/KanoComputing/kano-settings/issues/219","number":219,"state":"closed","locked":false,"title":"remove settings.json and data.py","user":{"login":"hzulla","id":1705654,"avatar_url":"https://avatars.githubusercontent.com/u/1705654?v=3","gravatar_id":"","url":"https://api.github.com/users/hzulla","html_url":"https://github.com/hzulla","followers_url":"https://api.github.com/users/hzulla/followers","following_url":"https://api.github.com/users/hzulla/following{/other_user}","gists_url":"https://api.github.com/users/hzulla/gists{/gist_id}","starred_url":"https://api.github.com/users/hzulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzulla/subscriptions","organizations_url":"https://api.github.com/users/hzulla/orgs","repos_url":"https://api.github.com/users/hzulla/repos","events_url":"https://api.github.com/users/hzulla/events{/privacy}","received_events_url":"https://api.github.com/users/hzulla/received_events","type":"User","site_admin":false},"body":"The last i18n patch #215 was too big and changed too much in one PR.\r\n\r\nTo make the stuff easier to review, I'm going to split the steps to reach the same goal.\r\n\r\nIn preparation for i18n, `settings.json` can be removed. It wasn't fully used, anyway, as the code contained message strings in the code and in the json file, already. So now all message strings are put back into the code so that gettext will handle them later.","created_at":"2015-03-03T10:02:56Z","updated_at":"2015-03-03T15:58:20Z","closed_at":"2015-03-03T15:58:20Z","merged_at":null,"merge_commit_sha":"064c9632205979c6403dc998d1b615409f9f25d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219/commits","review_comments_url":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219/comments","review_comment_url":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KanoComputing/kano-settings/issues/219/comments","statuses_url":"https://api.github.com/repos/KanoComputing/kano-settings/statuses/60780d8500910ef6a3ec3420bd93904d7ba021a6","head":{"label":"hzulla:remove-json","ref":"remove-json","sha":"60780d8500910ef6a3ec3420bd93904d7ba021a6","user":{"login":"hzulla","id":1705654,"avatar_url":"https://avatars.githubusercontent.com/u/1705654?v=3","gravatar_id":"","url":"https://api.github.com/users/hzulla","html_url":"https://github.com/hzulla","followers_url":"https://api.github.com/users/hzulla/followers","following_url":"https://api.github.com/users/hzulla/following{/other_user}","gists_url":"https://api.github.com/users/hzulla/gists{/gist_id}","starred_url":"https://api.github.com/users/hzulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzulla/subscriptions","organizations_url":"https://api.github.com/users/hzulla/orgs","repos_url":"https://api.github.com/users/hzulla/repos","events_url":"https://api.github.com/users/hzulla/events{/privacy}","received_events_url":"https://api.github.com/users/hzulla/received_events","type":"User","site_admin":false},"repo":{"id":29011350,"name":"kano-settings","full_name":"hzulla/kano-settings","owner":{"login":"hzulla","id":1705654,"avatar_url":"https://avatars.githubusercontent.com/u/1705654?v=3","gravatar_id":"","url":"https://api.github.com/users/hzulla","html_url":"https://github.com/hzulla","followers_url":"https://api.github.com/users/hzulla/followers","following_url":"https://api.github.com/users/hzulla/following{/other_user}","gists_url":"https://api.github.com/users/hzulla/gists{/gist_id}","starred_url":"https://api.github.com/users/hzulla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzulla/subscriptions","organizations_url":"https://api.github.com/users/hzulla/orgs","repos_url":"https://api.github.com/users/hzulla/repos","events_url":"https://api.github.com/users/hzulla/events{/privacy}","received_events_url":"https://api.github.com/users/hzulla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzulla/kano-settings","description":"Graphic tool to setup Kanux: email, keyboard, audio, display, wifi...","fork":true,"url":"https://api.github.com/repos/hzulla/kano-settings","forks_url":"https://api.github.com/repos/hzulla/kano-settings/forks","keys_url":"https://api.github.com/repos/hzulla/kano-settings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzulla/kano-settings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzulla/kano-settings/teams","hooks_url":"https://api.github.com/repos/hzulla/kano-settings/hooks","issue_events_url":"https://api.github.com/repos/hzulla/kano-settings/issues/events{/number}","events_url":"https://api.github.com/repos/hzulla/kano-settings/events","assignees_url":"https://api.github.com/repos/hzulla/kano-settings/assignees{/user}","branches_url":"https://api.github.com/repos/hzulla/kano-settings/branches{/branch}","tags_url":"https://api.github.com/repos/hzulla/kano-settings/tags","blobs_url":"https://api.github.com/repos/hzulla/kano-settings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzulla/kano-settings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzulla/kano-settings/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzulla/kano-settings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzulla/kano-settings/statuses/{sha}","languages_url":"https://api.github.com/repos/hzulla/kano-settings/languages","stargazers_url":"https://api.github.com/repos/hzulla/kano-settings/stargazers","contributors_url":"https://api.github.com/repos/hzulla/kano-settings/contributors","subscribers_url":"https://api.github.com/repos/hzulla/kano-settings/subscribers","subscription_url":"https://api.github.com/repos/hzulla/kano-settings/subscription","commits_url":"https://api.github.com/repos/hzulla/kano-settings/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzulla/kano-settings/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzulla/kano-settings/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzulla/kano-settings/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzulla/kano-settings/contents/{+path}","compare_url":"https://api.github.com/repos/hzulla/kano-settings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzulla/kano-settings/merges","archive_url":"https://api.github.com/repos/hzulla/kano-settings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzulla/kano-settings/downloads","issues_url":"https://api.github.com/repos/hzulla/kano-settings/issues{/number}","pulls_url":"https://api.github.com/repos/hzulla/kano-settings/pulls{/number}","milestones_url":"https://api.github.com/repos/hzulla/kano-settings/milestones{/number}","notifications_url":"https://api.github.com/repos/hzulla/kano-settings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzulla/kano-settings/labels{/name}","releases_url":"https://api.github.com/repos/hzulla/kano-settings/releases{/id}","created_at":"2015-01-09T10:10:55Z","updated_at":"2015-03-03T10:06:48Z","pushed_at":"2015-03-03T10:06:47Z","git_url":"git://github.com/hzulla/kano-settings.git","ssh_url":"git@github.com:hzulla/kano-settings.git","clone_url":"https://github.com/hzulla/kano-settings.git","svn_url":"https://github.com/hzulla/kano-settings","homepage":null,"size":1873,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KanoComputing:master","ref":"master","sha":"72d733b8b0aa5ee712cd4b57801650aa61861150","user":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"repo":{"id":17056120,"name":"kano-settings","full_name":"KanoComputing/kano-settings","owner":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KanoComputing/kano-settings","description":"Graphic tool to setup Kanux: email, keyboard, audio, display, wifi...","fork":false,"url":"https://api.github.com/repos/KanoComputing/kano-settings","forks_url":"https://api.github.com/repos/KanoComputing/kano-settings/forks","keys_url":"https://api.github.com/repos/KanoComputing/kano-settings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KanoComputing/kano-settings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KanoComputing/kano-settings/teams","hooks_url":"https://api.github.com/repos/KanoComputing/kano-settings/hooks","issue_events_url":"https://api.github.com/repos/KanoComputing/kano-settings/issues/events{/number}","events_url":"https://api.github.com/repos/KanoComputing/kano-settings/events","assignees_url":"https://api.github.com/repos/KanoComputing/kano-settings/assignees{/user}","branches_url":"https://api.github.com/repos/KanoComputing/kano-settings/branches{/branch}","tags_url":"https://api.github.com/repos/KanoComputing/kano-settings/tags","blobs_url":"https://api.github.com/repos/KanoComputing/kano-settings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KanoComputing/kano-settings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KanoComputing/kano-settings/git/refs{/sha}","trees_url":"https://api.github.com/repos/KanoComputing/kano-settings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KanoComputing/kano-settings/statuses/{sha}","languages_url":"https://api.github.com/repos/KanoComputing/kano-settings/languages","stargazers_url":"https://api.github.com/repos/KanoComputing/kano-settings/stargazers","contributors_url":"https://api.github.com/repos/KanoComputing/kano-settings/contributors","subscribers_url":"https://api.github.com/repos/KanoComputing/kano-settings/subscribers","subscription_url":"https://api.github.com/repos/KanoComputing/kano-settings/subscription","commits_url":"https://api.github.com/repos/KanoComputing/kano-settings/commits{/sha}","git_commits_url":"https://api.github.com/repos/KanoComputing/kano-settings/git/commits{/sha}","comments_url":"https://api.github.com/repos/KanoComputing/kano-settings/comments{/number}","issue_comment_url":"https://api.github.com/repos/KanoComputing/kano-settings/issues/comments{/number}","contents_url":"https://api.github.com/repos/KanoComputing/kano-settings/contents/{+path}","compare_url":"https://api.github.com/repos/KanoComputing/kano-settings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KanoComputing/kano-settings/merges","archive_url":"https://api.github.com/repos/KanoComputing/kano-settings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KanoComputing/kano-settings/downloads","issues_url":"https://api.github.com/repos/KanoComputing/kano-settings/issues{/number}","pulls_url":"https://api.github.com/repos/KanoComputing/kano-settings/pulls{/number}","milestones_url":"https://api.github.com/repos/KanoComputing/kano-settings/milestones{/number}","notifications_url":"https://api.github.com/repos/KanoComputing/kano-settings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KanoComputing/kano-settings/labels{/name}","releases_url":"https://api.github.com/repos/KanoComputing/kano-settings/releases{/id}","created_at":"2014-02-21T12:51:53Z","updated_at":"2015-03-03T13:22:17Z","pushed_at":"2015-03-03T13:22:19Z","git_url":"git://github.com/KanoComputing/kano-settings.git","ssh_url":"git@github.com:KanoComputing/kano-settings.git","clone_url":"https://github.com/KanoComputing/kano-settings.git","svn_url":"https://github.com/KanoComputing/kano-settings","homepage":null,"size":5617,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219"},"html":{"href":"https://github.com/KanoComputing/kano-settings/pull/219"},"issue":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/issues/219"},"comments":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/KanoComputing/kano-settings/statuses/60780d8500910ef6a3ec3420bd93904d7ba021a6"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":222,"deletions":524,"changed_files":16}}