{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/38785228","id":38785228,"diff_hunk":"@@ -59,6 +62,25 @@\n MAXIMUM_SEARCH_SIZE = 100000\n \n \n+@receiver(pre_save, sender=CourseTeam)\n+def team_pre_save_callback(sender, instance, **kwargs):  # pylint: disable=unused-argument","path":"lms/djangoapps/teams/views.py","position":22,"original_position":22,"commit_id":"6d4d8706e17a267ea0b1668bba083a6e9ff09c1e","original_commit_id":"c3e5808459e034170f58a27d92f15e735b14d20d","user":{"login":"peter-fogg","id":1819831,"avatar_url":"https://avatars.githubusercontent.com/u/1819831?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-fogg","html_url":"https://github.com/peter-fogg","followers_url":"https://api.github.com/users/peter-fogg/followers","following_url":"https://api.github.com/users/peter-fogg/following{/other_user}","gists_url":"https://api.github.com/users/peter-fogg/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-fogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-fogg/subscriptions","organizations_url":"https://api.github.com/users/peter-fogg/orgs","repos_url":"https://api.github.com/users/peter-fogg/repos","events_url":"https://api.github.com/users/peter-fogg/events{/privacy}","received_events_url":"https://api.github.com/users/peter-fogg/received_events","type":"User","site_admin":false},"body":"Although to be fair, I guess we don't have any real guarantees that some other signal handler doesn't throw an exception in a post-save callback, thus preventing an event from getting emitted after a successful save. Maybe we're in the same situation either way.","created_at":"2015-09-04T19:15:37Z","updated_at":"2015-09-04T19:15:37Z","html_url":"https://github.com/edx/edx-platform/pull/9632#discussion_r38785228","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9632","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/38785228"},"html":{"href":"https://github.com/edx/edx-platform/pull/9632#discussion_r38785228"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9632"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9632","id":44247051,"html_url":"https://github.com/edx/edx-platform/pull/9632","diff_url":"https://github.com/edx/edx-platform/pull/9632.diff","patch_url":"https://github.com/edx/edx-platform/pull/9632.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9632","number":9632,"state":"open","locked":false,"title":"Add events for tracking when teams are edited.","user":{"login":"dianakhuang","id":2952947,"avatar_url":"https://avatars.githubusercontent.com/u/2952947?v=3","gravatar_id":"","url":"https://api.github.com/users/dianakhuang","html_url":"https://github.com/dianakhuang","followers_url":"https://api.github.com/users/dianakhuang/followers","following_url":"https://api.github.com/users/dianakhuang/following{/other_user}","gists_url":"https://api.github.com/users/dianakhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/dianakhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianakhuang/subscriptions","organizations_url":"https://api.github.com/users/dianakhuang/orgs","repos_url":"https://api.github.com/users/dianakhuang/repos","events_url":"https://api.github.com/users/dianakhuang/events{/privacy}","received_events_url":"https://api.github.com/users/dianakhuang/received_events","type":"User","site_admin":false},"body":"## [TNL-3190](https://openedx.atlassian.net/browse/TNL-3190)\r\n\r\nAdded a new pre-save hook to the `CourseTeam` model to emit events when fields have been modified. \r\n\r\n### Testing\r\n- [x] Unit, integration, acceptance tests as appropriate\r\n- [x] Analytics\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @peter-fogg  \r\n- [ ] Code review: @efischer19 \r\n \r\n### Post-review\r\n- [ ] Squash commits","created_at":"2015-09-04T18:20:24Z","updated_at":"2015-09-04T19:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f710394bfa6297eb32b10fc05518e08ef9c354","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9632/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9632/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9632/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/6d4d8706e17a267ea0b1668bba083a6e9ff09c1e","head":{"label":"edx:diana/teams-changed-event","ref":"diana/teams-changed-event","sha":"6d4d8706e17a267ea0b1668bba083a6e9ff09c1e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-04T14:20:18Z","pushed_at":"2015-09-04T19:11:27Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2110622,"stargazers_count":2108,"watchers_count":2108,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1247,"mirror_url":null,"open_issues_count":158,"forks":1247,"open_issues":158,"watchers":2108,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"1ba4200a845fcb5a61a750c7ca197401b1663eb2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-04T14:20:18Z","pushed_at":"2015-09-04T19:11:27Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2110622,"stargazers_count":2108,"watchers_count":2108,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1247,"mirror_url":null,"open_issues_count":158,"forks":1247,"open_issues":158,"watchers":2108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9632"},"html":{"href":"https://github.com/edx/edx-platform/pull/9632"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9632"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9632/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9632/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9632/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/6d4d8706e17a267ea0b1668bba083a6e9ff09c1e"}}}}