{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/comments/39431578","id":39431578,"diff_hunk":"@@ -8,20 +8,37 @@ namespace Microsoft.Framework.DependencyInjection.ServiceLookup\n     internal class ServiceScope : IServiceScope\n     {\n         private readonly ServiceProvider _scopedProvider;\n+        private readonly ServiceScopeFactory _parentFactory;\n \n         public ServiceScope(ServiceProvider scopedProvider)\n         {\n             _scopedProvider = scopedProvider;\n         }\n+        internal ServiceScope(ServiceProvider scopedProvider, ServiceScopeFactory parentFactory)","path":"src/Microsoft.Framework.DependencyInjection/ServiceLookup/ServiceScope.cs","position":10,"original_position":10,"commit_id":"572fc71289c547214969805f5d4a4432a6d0605f","original_commit_id":"572fc71289c547214969805f5d4a4432a6d0605f","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"Why internal for this? will the public constructor ever be used with these changes?","created_at":"2015-09-14T18:50:29Z","updated_at":"2015-09-14T18:50:29Z","html_url":"https://github.com/aspnet/DependencyInjection/pull/289#discussion_r39431578","pull_request_url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289","_links":{"self":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/comments/39431578"},"html":{"href":"https://github.com/aspnet/DependencyInjection/pull/289#discussion_r39431578"},"pull_request":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289","id":44928683,"html_url":"https://github.com/aspnet/DependencyInjection/pull/289","diff_url":"https://github.com/aspnet/DependencyInjection/pull/289.diff","patch_url":"https://github.com/aspnet/DependencyInjection/pull/289.patch","issue_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/289","number":289,"state":"open","locked":false,"title":"Reduce DI Allocations","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Resolves #288","created_at":"2015-09-14T13:19:42Z","updated_at":"2015-09-14T18:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"962df2461b0a3a8993933fb16c30736f77afecaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289/commits","review_comments_url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289/comments","review_comment_url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/289/comments","statuses_url":"https://api.github.com/repos/aspnet/DependencyInjection/statuses/572fc71289c547214969805f5d4a4432a6d0605f","head":{"label":"benaadams:Reduce-DI-Allocations","ref":"Reduce-DI-Allocations","sha":"572fc71289c547214969805f5d4a4432a6d0605f","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":42442349,"name":"DependencyInjection","full_name":"benaadams/DependencyInjection","owner":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benaadams/DependencyInjection","description":"Contains the common DI abstractions that ASP.NET 5 and EF 7 use, as well as adapters for some IoC containers.","fork":true,"url":"https://api.github.com/repos/benaadams/DependencyInjection","forks_url":"https://api.github.com/repos/benaadams/DependencyInjection/forks","keys_url":"https://api.github.com/repos/benaadams/DependencyInjection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/DependencyInjection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/DependencyInjection/teams","hooks_url":"https://api.github.com/repos/benaadams/DependencyInjection/hooks","issue_events_url":"https://api.github.com/repos/benaadams/DependencyInjection/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/DependencyInjection/events","assignees_url":"https://api.github.com/repos/benaadams/DependencyInjection/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/DependencyInjection/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/DependencyInjection/tags","blobs_url":"https://api.github.com/repos/benaadams/DependencyInjection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/DependencyInjection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/DependencyInjection/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/DependencyInjection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/DependencyInjection/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/DependencyInjection/languages","stargazers_url":"https://api.github.com/repos/benaadams/DependencyInjection/stargazers","contributors_url":"https://api.github.com/repos/benaadams/DependencyInjection/contributors","subscribers_url":"https://api.github.com/repos/benaadams/DependencyInjection/subscribers","subscription_url":"https://api.github.com/repos/benaadams/DependencyInjection/subscription","commits_url":"https://api.github.com/repos/benaadams/DependencyInjection/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/DependencyInjection/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/DependencyInjection/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/DependencyInjection/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/DependencyInjection/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/DependencyInjection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/DependencyInjection/merges","archive_url":"https://api.github.com/repos/benaadams/DependencyInjection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/DependencyInjection/downloads","issues_url":"https://api.github.com/repos/benaadams/DependencyInjection/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/DependencyInjection/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/DependencyInjection/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/DependencyInjection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/DependencyInjection/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/DependencyInjection/releases{/id}","created_at":"2015-09-14T10:30:29Z","updated_at":"2015-09-14T10:30:29Z","pushed_at":"2015-09-14T17:59:02Z","git_url":"git://github.com/benaadams/DependencyInjection.git","ssh_url":"git@github.com:benaadams/DependencyInjection.git","clone_url":"https://github.com/benaadams/DependencyInjection.git","svn_url":"https://github.com/benaadams/DependencyInjection","homepage":"","size":3455,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"42fc918d93ad5e7d47cb81477a9e2c368b6f3a3f","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15814195,"name":"DependencyInjection","full_name":"aspnet/DependencyInjection","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/DependencyInjection","description":"Contains the common DI abstractions that ASP.NET 5 and EF 7 use, as well as adapters for some IoC containers.","fork":false,"url":"https://api.github.com/repos/aspnet/DependencyInjection","forks_url":"https://api.github.com/repos/aspnet/DependencyInjection/forks","keys_url":"https://api.github.com/repos/aspnet/DependencyInjection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/DependencyInjection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/DependencyInjection/teams","hooks_url":"https://api.github.com/repos/aspnet/DependencyInjection/hooks","issue_events_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/DependencyInjection/events","assignees_url":"https://api.github.com/repos/aspnet/DependencyInjection/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/DependencyInjection/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/DependencyInjection/tags","blobs_url":"https://api.github.com/repos/aspnet/DependencyInjection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/DependencyInjection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/DependencyInjection/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/DependencyInjection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/DependencyInjection/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/DependencyInjection/languages","stargazers_url":"https://api.github.com/repos/aspnet/DependencyInjection/stargazers","contributors_url":"https://api.github.com/repos/aspnet/DependencyInjection/contributors","subscribers_url":"https://api.github.com/repos/aspnet/DependencyInjection/subscribers","subscription_url":"https://api.github.com/repos/aspnet/DependencyInjection/subscription","commits_url":"https://api.github.com/repos/aspnet/DependencyInjection/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/DependencyInjection/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/DependencyInjection/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/DependencyInjection/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/DependencyInjection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/DependencyInjection/merges","archive_url":"https://api.github.com/repos/aspnet/DependencyInjection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/DependencyInjection/downloads","issues_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/DependencyInjection/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/DependencyInjection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/DependencyInjection/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/DependencyInjection/releases{/id}","created_at":"2014-01-11T00:58:01Z","updated_at":"2015-09-14T16:21:33Z","pushed_at":"2015-09-14T17:59:03Z","git_url":"git://github.com/aspnet/DependencyInjection.git","ssh_url":"git@github.com:aspnet/DependencyInjection.git","clone_url":"https://github.com/aspnet/DependencyInjection.git","svn_url":"https://github.com/aspnet/DependencyInjection","homepage":"","size":3455,"stargazers_count":232,"watchers_count":232,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":17,"forks":106,"open_issues":17,"watchers":232,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289"},"html":{"href":"https://github.com/aspnet/DependencyInjection/pull/289"},"issue":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/issues/289"},"comments":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/DependencyInjection/statuses/572fc71289c547214969805f5d4a4432a6d0605f"}}}}