{"action":"created","issue":{"url":"https://api.github.com/repos/chevah/brink/issues/58","labels_url":"https://api.github.com/repos/chevah/brink/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/chevah/brink/issues/58/comments","events_url":"https://api.github.com/repos/chevah/brink/issues/58/events","html_url":"https://github.com/chevah/brink/pull/58","id":57844192,"number":58,"title":"[#2701] Fix OS version checks.","user":{"login":"dumol","id":1620933,"avatar_url":"https://avatars.githubusercontent.com/u/1620933?v=3","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-16T19:46:28Z","updated_at":"2015-02-16T19:56:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chevah/brink/pulls/58","html_url":"https://github.com/chevah/brink/pull/58","diff_url":"https://github.com/chevah/brink/pull/58.diff","patch_url":"https://github.com/chevah/brink/pull/58.patch"},"body":"Problem?\r\n-----------\r\nOS version checks are broken for Solaris versions older then Solaris 10 and for OS X version 10.10 or newer.\r\n\r\nSolution?\r\n-----------\r\nRe-factor OS version checks to only compare integers.\r\n\r\n**Drive-by fix**:\r\n  * avoid confusing Fedora with RHEL or OpenSUSE with SLES.\r\n\r\nHow to check?\r\n-----------------\r\nPlease review changes (you may ignore style guide fixes).\r\nRun the tests.\r\nCheck the logic of `bash -x paver.sh detect_os` in AIX, Solaris, OS X and supported Linux distros.\r\n\r\nreviewer: @adiroiban "},"comment":{"url":"https://api.github.com/repos/chevah/brink/issues/comments/74563865","html_url":"https://github.com/chevah/brink/pull/58#issuecomment-74563865","issue_url":"https://api.github.com/repos/chevah/brink/issues/58","id":74563865,"user":{"login":"dumol","id":1620933,"avatar_url":"https://avatars.githubusercontent.com/u/1620933?v=3","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T19:56:52Z","updated_at":"2015-02-16T19:56:52Z","body":"**needs-review**"}}