{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/44404515","id":44404515,"diff_hunk":"@@ -54,11 +54,18 @@ under the License.\n \t\t<module name=\"IllegalImport\">\n \t\t\t<property name=\"illegalPkgs\" value=\"org.apache.flink.shaded\"/>\n \t\t</module>\n+\t\t<!-- forbid use of commons lang validate -->\n \t\t<module name=\"Regexp\">\n \t\t\t<property name=\"format\" value=\"org\\.apache\\.commons\\.lang3\\.Validate\"/>\n \t\t\t<property name=\"illegalPattern\" value=\"true\"/>\n \t\t\t<property name=\"message\" value=\"Use Guava Checks instead of Commons Validate. Please refer to the coding guidelines.\"/>\n \t\t</module>\n+\t\t<!-- forbid the use of org.apache.commons.lang.SerializationUtils -->\n+\t\t<module name=\"Regexp\">\n+\t\t\t<property name=\"format\" value=\"org\\.apache\\.commons\\.lang\\.SerializationUtils\"/>\n+\t\t\t<property name=\"illegalPattern\" value=\"true\"/>\n+\t\t\t<property name=\"message\" value=\"Use Flink's InstantiationUtil instead of common's SerializationUtils\"/>\n+\t\t</module>\n \t\t<module name=\"NeedBraces\">","path":"tools/maven/checkstyle.xml","position":16,"original_position":16,"commit_id":"7b5650bccd8959dbf1547742f610793aed7aeebe","original_commit_id":"7b5650bccd8959dbf1547742f610793aed7aeebe","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"Doesn't that still allow to import org.apache.commons.lang.* and use SerializationUtils afterwards? :)","created_at":"2015-11-10T13:18:15Z","updated_at":"2015-11-10T13:18:15Z","html_url":"https://github.com/apache/flink/pull/1343#discussion_r44404515","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1343","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/44404515"},"html":{"href":"https://github.com/apache/flink/pull/1343#discussion_r44404515"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1343"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1343","id":50242860,"html_url":"https://github.com/apache/flink/pull/1343","diff_url":"https://github.com/apache/flink/pull/1343.diff","patch_url":"https://github.com/apache/flink/pull/1343.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1343","number":1343,"state":"open","locked":false,"title":"Remove and forbid use of SerializationUtils. Fix FLINK-2992","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"The SerializationUtils are usually not using the right classloader, and they have some security issues.\r\nI'm using our checkstyle rules to forbid the use of them.","created_at":"2015-11-10T11:31:39Z","updated_at":"2015-11-10T13:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60908ed21e3873e0e18cc31123ed4465bd6c8cca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1343/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1343/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1343/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/7b5650bccd8959dbf1547742f610793aed7aeebe","head":{"label":"rmetzger:cancel_hotfix","ref":"cancel_hotfix","sha":"7b5650bccd8959dbf1547742f610793aed7aeebe","user":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"repo":{"id":20618957,"name":"flink","full_name":"rmetzger/flink","owner":{"login":"rmetzger","id":89049,"avatar_url":"https://avatars.githubusercontent.com/u/89049?v=3","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmetzger/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/rmetzger/flink","forks_url":"https://api.github.com/repos/rmetzger/flink/forks","keys_url":"https://api.github.com/repos/rmetzger/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmetzger/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmetzger/flink/teams","hooks_url":"https://api.github.com/repos/rmetzger/flink/hooks","issue_events_url":"https://api.github.com/repos/rmetzger/flink/issues/events{/number}","events_url":"https://api.github.com/repos/rmetzger/flink/events","assignees_url":"https://api.github.com/repos/rmetzger/flink/assignees{/user}","branches_url":"https://api.github.com/repos/rmetzger/flink/branches{/branch}","tags_url":"https://api.github.com/repos/rmetzger/flink/tags","blobs_url":"https://api.github.com/repos/rmetzger/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmetzger/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmetzger/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmetzger/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmetzger/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/rmetzger/flink/languages","stargazers_url":"https://api.github.com/repos/rmetzger/flink/stargazers","contributors_url":"https://api.github.com/repos/rmetzger/flink/contributors","subscribers_url":"https://api.github.com/repos/rmetzger/flink/subscribers","subscription_url":"https://api.github.com/repos/rmetzger/flink/subscription","commits_url":"https://api.github.com/repos/rmetzger/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmetzger/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmetzger/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmetzger/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmetzger/flink/contents/{+path}","compare_url":"https://api.github.com/repos/rmetzger/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmetzger/flink/merges","archive_url":"https://api.github.com/repos/rmetzger/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmetzger/flink/downloads","issues_url":"https://api.github.com/repos/rmetzger/flink/issues{/number}","pulls_url":"https://api.github.com/repos/rmetzger/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/rmetzger/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/rmetzger/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmetzger/flink/labels{/name}","releases_url":"https://api.github.com/repos/rmetzger/flink/releases{/id}","created_at":"2014-06-08T14:58:57Z","updated_at":"2015-04-21T08:05:13Z","pushed_at":"2015-11-10T11:41:47Z","git_url":"git://github.com/rmetzger/flink.git","ssh_url":"git@github.com:rmetzger/flink.git","clone_url":"https://github.com/rmetzger/flink.git","svn_url":"https://github.com/rmetzger/flink","homepage":null,"size":73773,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a684e23703033358de2f5c87f2ecd4bb0cbd4898","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-11-10T11:26:48Z","pushed_at":"2015-11-10T11:31:39Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2478015,"stargazers_count":719,"watchers_count":719,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":491,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":74,"forks":491,"open_issues":74,"watchers":719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1343"},"html":{"href":"https://github.com/apache/flink/pull/1343"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1343"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1343/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1343/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1343/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/7b5650bccd8959dbf1547742f610793aed7aeebe"}}}}