{"action":"opened","number":1385,"pull_request":{"url":"https://api.github.com/repos/thelia/thelia/pulls/1385","id":33652053,"html_url":"https://github.com/thelia/thelia/pull/1385","diff_url":"https://github.com/thelia/thelia/pull/1385.diff","patch_url":"https://github.com/thelia/thelia/pull/1385.patch","issue_url":"https://api.github.com/repos/thelia/thelia/issues/1385","number":1385,"state":"open","locked":false,"title":"Use HttpKernel RegisterListenerPass instead of a hand written one","user":{"login":"lovenunu","id":6106094,"avatar_url":"https://avatars.githubusercontent.com/u/6106094?v=3","gravatar_id":"","url":"https://api.github.com/users/lovenunu","html_url":"https://github.com/lovenunu","followers_url":"https://api.github.com/users/lovenunu/followers","following_url":"https://api.github.com/users/lovenunu/following{/other_user}","gists_url":"https://api.github.com/users/lovenunu/gists{/gist_id}","starred_url":"https://api.github.com/users/lovenunu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovenunu/subscriptions","organizations_url":"https://api.github.com/users/lovenunu/orgs","repos_url":"https://api.github.com/users/lovenunu/repos","events_url":"https://api.github.com/users/lovenunu/events{/privacy}","received_events_url":"https://api.github.com/users/lovenunu/received_events","type":"User","site_admin":false},"body":"Well ... Without that patch, if you try to register a listener with a class name that is a parameter, you get an error.\r\n\r\nExample:\r\n```\r\n<parameters>\r\n  <parameter key=\"foo.class\">Foo\\Bar</parameter>\r\n</parameters>\r\n<services>\r\n  <service id=\"foo.bar\" class=\"%foo.class%\">\r\n    <tag name=\"kernel.event_subscriber\" />\r\n  </service>\r\n</services>\r\n```\r\nHere, you get a beautiful ```The class \"%foo.class%\" doesn't exist```","created_at":"2015-04-20T10:17:59Z","updated_at":"2015-04-20T10:17:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thelia/thelia/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/thelia/thelia/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/thelia/thelia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thelia/thelia/issues/1385/comments","statuses_url":"https://api.github.com/repos/thelia/thelia/statuses/c9eec0947d4435495d108c622c0838196b5cb064","head":{"label":"lovenunu:register-listener-fix","ref":"register-listener-fix","sha":"c9eec0947d4435495d108c622c0838196b5cb064","user":{"login":"lovenunu","id":6106094,"avatar_url":"https://avatars.githubusercontent.com/u/6106094?v=3","gravatar_id":"","url":"https://api.github.com/users/lovenunu","html_url":"https://github.com/lovenunu","followers_url":"https://api.github.com/users/lovenunu/followers","following_url":"https://api.github.com/users/lovenunu/following{/other_user}","gists_url":"https://api.github.com/users/lovenunu/gists{/gist_id}","starred_url":"https://api.github.com/users/lovenunu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovenunu/subscriptions","organizations_url":"https://api.github.com/users/lovenunu/orgs","repos_url":"https://api.github.com/users/lovenunu/repos","events_url":"https://api.github.com/users/lovenunu/events{/privacy}","received_events_url":"https://api.github.com/users/lovenunu/received_events","type":"User","site_admin":false},"repo":{"id":20473118,"name":"thelia","full_name":"lovenunu/thelia","owner":{"login":"lovenunu","id":6106094,"avatar_url":"https://avatars.githubusercontent.com/u/6106094?v=3","gravatar_id":"","url":"https://api.github.com/users/lovenunu","html_url":"https://github.com/lovenunu","followers_url":"https://api.github.com/users/lovenunu/followers","following_url":"https://api.github.com/users/lovenunu/following{/other_user}","gists_url":"https://api.github.com/users/lovenunu/gists{/gist_id}","starred_url":"https://api.github.com/users/lovenunu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovenunu/subscriptions","organizations_url":"https://api.github.com/users/lovenunu/orgs","repos_url":"https://api.github.com/users/lovenunu/repos","events_url":"https://api.github.com/users/lovenunu/events{/privacy}","received_events_url":"https://api.github.com/users/lovenunu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lovenunu/thelia","description":"Thelia is an open source tool for creating e-business websites and managing online content. Repo containing the new major version (v2)","fork":true,"url":"https://api.github.com/repos/lovenunu/thelia","forks_url":"https://api.github.com/repos/lovenunu/thelia/forks","keys_url":"https://api.github.com/repos/lovenunu/thelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lovenunu/thelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lovenunu/thelia/teams","hooks_url":"https://api.github.com/repos/lovenunu/thelia/hooks","issue_events_url":"https://api.github.com/repos/lovenunu/thelia/issues/events{/number}","events_url":"https://api.github.com/repos/lovenunu/thelia/events","assignees_url":"https://api.github.com/repos/lovenunu/thelia/assignees{/user}","branches_url":"https://api.github.com/repos/lovenunu/thelia/branches{/branch}","tags_url":"https://api.github.com/repos/lovenunu/thelia/tags","blobs_url":"https://api.github.com/repos/lovenunu/thelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lovenunu/thelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lovenunu/thelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/lovenunu/thelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lovenunu/thelia/statuses/{sha}","languages_url":"https://api.github.com/repos/lovenunu/thelia/languages","stargazers_url":"https://api.github.com/repos/lovenunu/thelia/stargazers","contributors_url":"https://api.github.com/repos/lovenunu/thelia/contributors","subscribers_url":"https://api.github.com/repos/lovenunu/thelia/subscribers","subscription_url":"https://api.github.com/repos/lovenunu/thelia/subscription","commits_url":"https://api.github.com/repos/lovenunu/thelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/lovenunu/thelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/lovenunu/thelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/lovenunu/thelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/lovenunu/thelia/contents/{+path}","compare_url":"https://api.github.com/repos/lovenunu/thelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lovenunu/thelia/merges","archive_url":"https://api.github.com/repos/lovenunu/thelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lovenunu/thelia/downloads","issues_url":"https://api.github.com/repos/lovenunu/thelia/issues{/number}","pulls_url":"https://api.github.com/repos/lovenunu/thelia/pulls{/number}","milestones_url":"https://api.github.com/repos/lovenunu/thelia/milestones{/number}","notifications_url":"https://api.github.com/repos/lovenunu/thelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lovenunu/thelia/labels{/name}","releases_url":"https://api.github.com/repos/lovenunu/thelia/releases{/id}","created_at":"2014-06-04T06:48:29Z","updated_at":"2015-04-14T08:09:05Z","pushed_at":"2015-04-20T10:13:15Z","git_url":"git://github.com/lovenunu/thelia.git","ssh_url":"git@github.com:lovenunu/thelia.git","clone_url":"https://github.com/lovenunu/thelia.git","svn_url":"https://github.com/lovenunu/thelia","homepage":"http://thelia.net","size":83143,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thelia:master","ref":"master","sha":"9c98e32a239dc8087b157d61a9557040a373b817","user":{"login":"thelia","id":2196919,"avatar_url":"https://avatars.githubusercontent.com/u/2196919?v=3","gravatar_id":"","url":"https://api.github.com/users/thelia","html_url":"https://github.com/thelia","followers_url":"https://api.github.com/users/thelia/followers","following_url":"https://api.github.com/users/thelia/following{/other_user}","gists_url":"https://api.github.com/users/thelia/gists{/gist_id}","starred_url":"https://api.github.com/users/thelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelia/subscriptions","organizations_url":"https://api.github.com/users/thelia/orgs","repos_url":"https://api.github.com/users/thelia/repos","events_url":"https://api.github.com/users/thelia/events{/privacy}","received_events_url":"https://api.github.com/users/thelia/received_events","type":"Organization","site_admin":false},"repo":{"id":8863081,"name":"thelia","full_name":"thelia/thelia","owner":{"login":"thelia","id":2196919,"avatar_url":"https://avatars.githubusercontent.com/u/2196919?v=3","gravatar_id":"","url":"https://api.github.com/users/thelia","html_url":"https://github.com/thelia","followers_url":"https://api.github.com/users/thelia/followers","following_url":"https://api.github.com/users/thelia/following{/other_user}","gists_url":"https://api.github.com/users/thelia/gists{/gist_id}","starred_url":"https://api.github.com/users/thelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelia/subscriptions","organizations_url":"https://api.github.com/users/thelia/orgs","repos_url":"https://api.github.com/users/thelia/repos","events_url":"https://api.github.com/users/thelia/events{/privacy}","received_events_url":"https://api.github.com/users/thelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelia/thelia","description":"Thelia is an open source tool for creating e-business websites and managing online content. Repo containing the new major version (v2)","fork":false,"url":"https://api.github.com/repos/thelia/thelia","forks_url":"https://api.github.com/repos/thelia/thelia/forks","keys_url":"https://api.github.com/repos/thelia/thelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelia/thelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelia/thelia/teams","hooks_url":"https://api.github.com/repos/thelia/thelia/hooks","issue_events_url":"https://api.github.com/repos/thelia/thelia/issues/events{/number}","events_url":"https://api.github.com/repos/thelia/thelia/events","assignees_url":"https://api.github.com/repos/thelia/thelia/assignees{/user}","branches_url":"https://api.github.com/repos/thelia/thelia/branches{/branch}","tags_url":"https://api.github.com/repos/thelia/thelia/tags","blobs_url":"https://api.github.com/repos/thelia/thelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelia/thelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelia/thelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelia/thelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelia/thelia/statuses/{sha}","languages_url":"https://api.github.com/repos/thelia/thelia/languages","stargazers_url":"https://api.github.com/repos/thelia/thelia/stargazers","contributors_url":"https://api.github.com/repos/thelia/thelia/contributors","subscribers_url":"https://api.github.com/repos/thelia/thelia/subscribers","subscription_url":"https://api.github.com/repos/thelia/thelia/subscription","commits_url":"https://api.github.com/repos/thelia/thelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelia/thelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelia/thelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelia/thelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelia/thelia/contents/{+path}","compare_url":"https://api.github.com/repos/thelia/thelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelia/thelia/merges","archive_url":"https://api.github.com/repos/thelia/thelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelia/thelia/downloads","issues_url":"https://api.github.com/repos/thelia/thelia/issues{/number}","pulls_url":"https://api.github.com/repos/thelia/thelia/pulls{/number}","milestones_url":"https://api.github.com/repos/thelia/thelia/milestones{/number}","notifications_url":"https://api.github.com/repos/thelia/thelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelia/thelia/labels{/name}","releases_url":"https://api.github.com/repos/thelia/thelia/releases{/id}","created_at":"2013-03-18T20:10:36Z","updated_at":"2015-04-20T08:02:24Z","pushed_at":"2015-04-20T09:49:38Z","git_url":"git://github.com/thelia/thelia.git","ssh_url":"git@github.com:thelia/thelia.git","clone_url":"https://github.com/thelia/thelia.git","svn_url":"https://github.com/thelia/thelia","homepage":"http://thelia.net","size":101179,"stargazers_count":382,"watchers_count":382,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":116,"forks":126,"open_issues":116,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thelia/thelia/pulls/1385"},"html":{"href":"https://github.com/thelia/thelia/pull/1385"},"issue":{"href":"https://api.github.com/repos/thelia/thelia/issues/1385"},"comments":{"href":"https://api.github.com/repos/thelia/thelia/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/thelia/thelia/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/thelia/thelia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thelia/thelia/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/thelia/thelia/statuses/c9eec0947d4435495d108c622c0838196b5cb064"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":40,"changed_files":2}}