{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/41054763","id":41054763,"diff_hunk":"@@ -0,0 +1,65 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.operator.aggregation.state;\n+\n+import com.facebook.presto.operator.aggregation.BlockComparator;\n+import com.facebook.presto.operator.aggregation.TypedKeyValueHeap;\n+import com.facebook.presto.spi.block.Block;\n+import com.facebook.presto.spi.block.BlockBuilder;\n+import com.facebook.presto.spi.type.Type;\n+\n+public class MinMaxByNStateSerializer\n+        implements AccumulatorStateSerializer<MinMaxByNState>\n+{\n+    private final BlockComparator blockComparator;\n+    private final Type keyType;\n+    private final Type valueType;\n+    private final Type serializedType;\n+\n+    public MinMaxByNStateSerializer(BlockComparator blockComparator, Type keyType, Type valueType)\n+    {\n+        this.blockComparator = blockComparator;\n+        this.keyType = keyType;\n+        this.valueType = valueType;\n+        this.serializedType = TypedKeyValueHeap.getSerializedType(keyType, valueType);","path":"presto-main/src/main/java/com/facebook/presto/operator/aggregation/state/MinMaxByNStateSerializer.java","position":35,"original_position":35,"commit_id":"9f22cffccaa80da1c18989331350841f81ce225f","original_commit_id":"9f22cffccaa80da1c18989331350841f81ce225f","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"Can't static import, because there's a naming conflict.","created_at":"2015-10-02T18:50:45Z","updated_at":"2015-10-02T18:50:45Z","html_url":"https://github.com/facebook/presto/pull/3681#discussion_r41054763","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/3681","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/41054763"},"html":{"href":"https://github.com/facebook/presto/pull/3681#discussion_r41054763"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/3681"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/3681","id":46069668,"html_url":"https://github.com/facebook/presto/pull/3681","diff_url":"https://github.com/facebook/presto/pull/3681.diff","patch_url":"https://github.com/facebook/presto/pull/3681.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/3681","number":3681,"state":"open","locked":false,"title":"Added the parameter n to the max_by and min_by aggregation functions","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"body":"Adds feature mentioned in #3620. Unit tests, integration tests and documentation changes all done.","created_at":"2015-09-25T23:58:37Z","updated_at":"2015-10-02T18:50:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1301c954eddc7b514ef298f8a4e3cf0969213f96","assignee":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/3681/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/3681/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/3681/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/9f22cffccaa80da1c18989331350841f81ce225f","head":{"label":"raghavsethi:maxbyn","ref":"maxbyn","sha":"9f22cffccaa80da1c18989331350841f81ce225f","user":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"repo":{"id":42330619,"name":"presto","full_name":"raghavsethi/presto","owner":{"login":"raghavsethi","id":715788,"avatar_url":"https://avatars.githubusercontent.com/u/715788?v=3","gravatar_id":"","url":"https://api.github.com/users/raghavsethi","html_url":"https://github.com/raghavsethi","followers_url":"https://api.github.com/users/raghavsethi/followers","following_url":"https://api.github.com/users/raghavsethi/following{/other_user}","gists_url":"https://api.github.com/users/raghavsethi/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavsethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavsethi/subscriptions","organizations_url":"https://api.github.com/users/raghavsethi/orgs","repos_url":"https://api.github.com/users/raghavsethi/repos","events_url":"https://api.github.com/users/raghavsethi/events{/privacy}","received_events_url":"https://api.github.com/users/raghavsethi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raghavsethi/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/raghavsethi/presto","forks_url":"https://api.github.com/repos/raghavsethi/presto/forks","keys_url":"https://api.github.com/repos/raghavsethi/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raghavsethi/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raghavsethi/presto/teams","hooks_url":"https://api.github.com/repos/raghavsethi/presto/hooks","issue_events_url":"https://api.github.com/repos/raghavsethi/presto/issues/events{/number}","events_url":"https://api.github.com/repos/raghavsethi/presto/events","assignees_url":"https://api.github.com/repos/raghavsethi/presto/assignees{/user}","branches_url":"https://api.github.com/repos/raghavsethi/presto/branches{/branch}","tags_url":"https://api.github.com/repos/raghavsethi/presto/tags","blobs_url":"https://api.github.com/repos/raghavsethi/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raghavsethi/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raghavsethi/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/raghavsethi/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raghavsethi/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/raghavsethi/presto/languages","stargazers_url":"https://api.github.com/repos/raghavsethi/presto/stargazers","contributors_url":"https://api.github.com/repos/raghavsethi/presto/contributors","subscribers_url":"https://api.github.com/repos/raghavsethi/presto/subscribers","subscription_url":"https://api.github.com/repos/raghavsethi/presto/subscription","commits_url":"https://api.github.com/repos/raghavsethi/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/raghavsethi/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/raghavsethi/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/raghavsethi/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/raghavsethi/presto/contents/{+path}","compare_url":"https://api.github.com/repos/raghavsethi/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raghavsethi/presto/merges","archive_url":"https://api.github.com/repos/raghavsethi/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raghavsethi/presto/downloads","issues_url":"https://api.github.com/repos/raghavsethi/presto/issues{/number}","pulls_url":"https://api.github.com/repos/raghavsethi/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/raghavsethi/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/raghavsethi/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raghavsethi/presto/labels{/name}","releases_url":"https://api.github.com/repos/raghavsethi/presto/releases{/id}","created_at":"2015-09-11T20:28:31Z","updated_at":"2015-09-11T20:28:39Z","pushed_at":"2015-09-30T21:01:56Z","git_url":"git://github.com/raghavsethi/presto.git","ssh_url":"git@github.com:raghavsethi/presto.git","clone_url":"https://github.com/raghavsethi/presto.git","svn_url":"https://github.com/raghavsethi/presto","homepage":"https://prestodb.io","size":48820,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9ce38fa54ad62f51eaf004523c1a62144fb21ee9","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-10-02T17:20:58Z","pushed_at":"2015-10-02T18:18:52Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":103728,"stargazers_count":3932,"watchers_count":3932,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1003,"mirror_url":null,"open_issues_count":337,"forks":1003,"open_issues":337,"watchers":3932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/3681"},"html":{"href":"https://github.com/facebook/presto/pull/3681"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/3681"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/3681/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/3681/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/3681/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/9f22cffccaa80da1c18989331350841f81ce225f"}}}}