{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/22986272","id":22986272,"diff_hunk":"@@ -459,7 +459,6 @@ fn make_drop_glue<'blk, 'tcx>(bcx: Block<'blk, 'tcx>, v0: ValueRef, t: Ty<'tcx>)\n         }\n         ty::ty_vec(ty, None) => tvec::make_drop_glue_unboxed(bcx, v0, ty, false),\n         _ => {\n-            assert!(type_is_sized(bcx.tcx(), t));","path":"src/librustc_trans/trans/glue.rs","position":4,"original_position":4,"commit_id":"1e175d799b37031f183e3bed2296d7a446bf785b","original_commit_id":"1e175d799b37031f183e3bed2296d7a446bf785b","user":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"body":"this is a bit suspicious, what kind of type triggers this assertion? Is it `str`? I expect we should be dealing with ty_str in the same way as ty_vec, but it seems to be missing treatment all over this file. This is not really your problem to fix (unless you want to!). I suggest creating a ty_str branch and panic!ing in it, with a FIXME comment, leave the assertion in, and change the test to use something other than a `str`","created_at":"2015-01-15T01:59:47Z","updated_at":"2015-01-15T01:59:47Z","html_url":"https://github.com/rust-lang/rust/pull/21170#discussion_r22986272","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/21170","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/22986272"},"html":{"href":"https://github.com/rust-lang/rust/pull/21170#discussion_r22986272"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21170"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/21170","id":27399246,"html_url":"https://github.com/rust-lang/rust/pull/21170","diff_url":"https://github.com/rust-lang/rust/pull/21170.diff","patch_url":"https://github.com/rust-lang/rust/pull/21170.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/21170","number":21170,"state":"open","locked":false,"title":"Allow passing unsized types to std::intrinsics::get_tydesc","user":{"login":"Diggsey","id":451321,"avatar_url":"https://avatars.githubusercontent.com/u/451321?v=3","gravatar_id":"","url":"https://api.github.com/users/Diggsey","html_url":"https://github.com/Diggsey","followers_url":"https://api.github.com/users/Diggsey/followers","following_url":"https://api.github.com/users/Diggsey/following{/other_user}","gists_url":"https://api.github.com/users/Diggsey/gists{/gist_id}","starred_url":"https://api.github.com/users/Diggsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diggsey/subscriptions","organizations_url":"https://api.github.com/users/Diggsey/orgs","repos_url":"https://api.github.com/users/Diggsey/repos","events_url":"https://api.github.com/users/Diggsey/events{/privacy}","received_events_url":"https://api.github.com/users/Diggsey/received_events","type":"User","site_admin":false},"body":"While it's unstable and will probably be replaced or \"reformed\" at some point, it's useful in the mean time to be able to introspect the type system when debugging, and not be limited to sized types.\r\n\r\nFixes #21058","created_at":"2015-01-15T01:23:53Z","updated_at":"2015-01-15T01:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47bc45dc179222102aeee6dd75cfb893cac39f2d","assignee":{"login":"nick29581","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nick29581","html_url":"https://github.com/nick29581","followers_url":"https://api.github.com/users/nick29581/followers","following_url":"https://api.github.com/users/nick29581/following{/other_user}","gists_url":"https://api.github.com/users/nick29581/gists{/gist_id}","starred_url":"https://api.github.com/users/nick29581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick29581/subscriptions","organizations_url":"https://api.github.com/users/nick29581/orgs","repos_url":"https://api.github.com/users/nick29581/repos","events_url":"https://api.github.com/users/nick29581/events{/privacy}","received_events_url":"https://api.github.com/users/nick29581/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/21170/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/21170/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/21170/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/1e175d799b37031f183e3bed2296d7a446bf785b","head":{"label":"Diggsey:issue-21058","ref":"issue-21058","sha":"1e175d799b37031f183e3bed2296d7a446bf785b","user":{"login":"Diggsey","id":451321,"avatar_url":"https://avatars.githubusercontent.com/u/451321?v=3","gravatar_id":"","url":"https://api.github.com/users/Diggsey","html_url":"https://github.com/Diggsey","followers_url":"https://api.github.com/users/Diggsey/followers","following_url":"https://api.github.com/users/Diggsey/following{/other_user}","gists_url":"https://api.github.com/users/Diggsey/gists{/gist_id}","starred_url":"https://api.github.com/users/Diggsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diggsey/subscriptions","organizations_url":"https://api.github.com/users/Diggsey/orgs","repos_url":"https://api.github.com/users/Diggsey/repos","events_url":"https://api.github.com/users/Diggsey/events{/privacy}","received_events_url":"https://api.github.com/users/Diggsey/received_events","type":"User","site_admin":false},"repo":{"id":29195928,"name":"rust","full_name":"Diggsey/rust","owner":{"login":"Diggsey","id":451321,"avatar_url":"https://avatars.githubusercontent.com/u/451321?v=3","gravatar_id":"","url":"https://api.github.com/users/Diggsey","html_url":"https://github.com/Diggsey","followers_url":"https://api.github.com/users/Diggsey/followers","following_url":"https://api.github.com/users/Diggsey/following{/other_user}","gists_url":"https://api.github.com/users/Diggsey/gists{/gist_id}","starred_url":"https://api.github.com/users/Diggsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diggsey/subscriptions","organizations_url":"https://api.github.com/users/Diggsey/orgs","repos_url":"https://api.github.com/users/Diggsey/repos","events_url":"https://api.github.com/users/Diggsey/events{/privacy}","received_events_url":"https://api.github.com/users/Diggsey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Diggsey/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Diggsey/rust","forks_url":"https://api.github.com/repos/Diggsey/rust/forks","keys_url":"https://api.github.com/repos/Diggsey/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Diggsey/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Diggsey/rust/teams","hooks_url":"https://api.github.com/repos/Diggsey/rust/hooks","issue_events_url":"https://api.github.com/repos/Diggsey/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Diggsey/rust/events","assignees_url":"https://api.github.com/repos/Diggsey/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Diggsey/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Diggsey/rust/tags","blobs_url":"https://api.github.com/repos/Diggsey/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Diggsey/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Diggsey/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Diggsey/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Diggsey/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Diggsey/rust/languages","stargazers_url":"https://api.github.com/repos/Diggsey/rust/stargazers","contributors_url":"https://api.github.com/repos/Diggsey/rust/contributors","subscribers_url":"https://api.github.com/repos/Diggsey/rust/subscribers","subscription_url":"https://api.github.com/repos/Diggsey/rust/subscription","commits_url":"https://api.github.com/repos/Diggsey/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Diggsey/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Diggsey/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Diggsey/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/Diggsey/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Diggsey/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Diggsey/rust/merges","archive_url":"https://api.github.com/repos/Diggsey/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Diggsey/rust/downloads","issues_url":"https://api.github.com/repos/Diggsey/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Diggsey/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Diggsey/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Diggsey/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Diggsey/rust/labels{/name}","releases_url":"https://api.github.com/repos/Diggsey/rust/releases{/id}","created_at":"2015-01-13T15:20:08Z","updated_at":"2015-01-13T15:20:19Z","pushed_at":"2015-01-15T01:35:24Z","git_url":"git://github.com/Diggsey/rust.git","ssh_url":"git@github.com:Diggsey/rust.git","clone_url":"https://github.com/Diggsey/rust.git","svn_url":"https://github.com/Diggsey/rust","homepage":"http://www.rust-lang.org","size":429872,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"896cb36ecab3eaeb7f101087e030e43771eca5ca","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-01-15T01:14:21Z","pushed_at":"2015-01-15T01:42:25Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":431356,"stargazers_count":8829,"watchers_count":8829,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1698,"mirror_url":null,"open_issues_count":2423,"forks":1698,"open_issues":2423,"watchers":8829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21170"},"html":{"href":"https://github.com/rust-lang/rust/pull/21170"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/21170"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/21170/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21170/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21170/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/1e175d799b37031f183e3bed2296d7a446bf785b"}}}}