{"action":"created","issue":{"url":"https://api.github.com/repos/i18next/i18next-node/issues/183","labels_url":"https://api.github.com/repos/i18next/i18next-node/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/i18next/i18next-node/issues/183/comments","events_url":"https://api.github.com/repos/i18next/i18next-node/issues/183/events","html_url":"https://github.com/i18next/i18next-node/pull/183","id":65955680,"number":183,"title":"Fix lookup with `fallbackToDefaultNS` option","user":{"login":"lennym","id":117398,"avatar_url":"https://avatars.githubusercontent.com/u/117398?v=3","gravatar_id":"","url":"https://api.github.com/users/lennym","html_url":"https://github.com/lennym","followers_url":"https://api.github.com/users/lennym/followers","following_url":"https://api.github.com/users/lennym/following{/other_user}","gists_url":"https://api.github.com/users/lennym/gists{/gist_id}","starred_url":"https://api.github.com/users/lennym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennym/subscriptions","organizations_url":"https://api.github.com/users/lennym/orgs","repos_url":"https://api.github.com/users/lennym/repos","events_url":"https://api.github.com/users/lennym/events{/privacy}","received_events_url":"https://api.github.com/users/lennym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-02T15:48:13Z","updated_at":"2015-04-07T06:11:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/i18next/i18next-node/pulls/183","html_url":"https://github.com/i18next/i18next-node/pull/183","diff_url":"https://github.com/i18next/i18next-node/pull/183.diff","patch_url":"https://github.com/i18next/i18next-node/pull/183.patch"},"body":"Running a lookup with fallbackToDefaultNS flag was not actually doing the fallback, it was simply running the same lookup again with all of the same options - in particular the same namespace option - so it never found the fallback value.\r\n\r\nWhen running the fallback lookup set the ns option to be the default namespace and re-run the lookup.\r\n\r\n*Note: the test added will always fail unless #182 is merged*"},"comment":{"url":"https://api.github.com/repos/i18next/i18next-node/issues/comments/90384941","html_url":"https://github.com/i18next/i18next-node/pull/183#issuecomment-90384941","issue_url":"https://api.github.com/repos/i18next/i18next-node/issues/183","id":90384941,"user":{"login":"jamuhl","id":977772,"avatar_url":"https://avatars.githubusercontent.com/u/977772?v=3","gravatar_id":"","url":"https://api.github.com/users/jamuhl","html_url":"https://github.com/jamuhl","followers_url":"https://api.github.com/users/jamuhl/followers","following_url":"https://api.github.com/users/jamuhl/following{/other_user}","gists_url":"https://api.github.com/users/jamuhl/gists{/gist_id}","starred_url":"https://api.github.com/users/jamuhl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamuhl/subscriptions","organizations_url":"https://api.github.com/users/jamuhl/orgs","repos_url":"https://api.github.com/users/jamuhl/repos","events_url":"https://api.github.com/users/jamuhl/events{/privacy}","received_events_url":"https://api.github.com/users/jamuhl/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T06:11:20Z","updated_at":"2015-04-07T06:11:20Z","body":"@lennym totally agree...came up to same conclusion when i saw your PR. shouldn't be a big thing to use the i18next-client from npm instead of copying it.\r\n\r\nIf you got time a PR would be wonderful else i will change that for next version."}}