{"action":"created","comment":{"url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/comments/29906876","id":29906876,"diff_hunk":"@@ -126,6 +126,29 @@ buster.testCase('_loadInIframe',\n       assert.equals(this.testObject.window, this._stubs.window);\n       assert.equals(this.testObject.document, this._stubs.document);\n       assert.equals(this.testObject.$, this._stubs.$);\n+    },\n+\n+    'Handles the case of $ not defined':\n+    {\n+      setUp: function()\n+      {\n+        this._stubs.iframe.contentWindow = {$: undefined};\n+        this.testObject._loadInIframe(common.iframeUriPath, this._stubs.callback);\n+      },\n+\n+      'Throws an exception if $ is not defined in the iframe': function()\n+      {\n+        assert.exception(function()\n+        {\n+          this._stubs.iframe.onload();\n+        }.bind(this), {message: 'The iframe was not loaded correctly, please double check that the url you requested is available in your test: '});\n+      },\n+\n+      tearDown: function()\n+      {\n+        //restore the original stub\n+        this._stubs.iframe = {contentWindow: this._stubs.window, contentDocument: this._stubs.document};","path":"test/test-_loadInIframe.js","position":25,"original_position":25,"commit_id":"95112dfd57e102de9c072354777ad8ae847292fe","original_commit_id":"95112dfd57e102de9c072354777ad8ae847292fe","user":{"login":"ingiulio","id":1507923,"avatar_url":"https://avatars.githubusercontent.com/u/1507923?v=3","gravatar_id":"","url":"https://api.github.com/users/ingiulio","html_url":"https://github.com/ingiulio","followers_url":"https://api.github.com/users/ingiulio/followers","following_url":"https://api.github.com/users/ingiulio/following{/other_user}","gists_url":"https://api.github.com/users/ingiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/ingiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingiulio/subscriptions","organizations_url":"https://api.github.com/users/ingiulio/orgs","repos_url":"https://api.github.com/users/ingiulio/repos","events_url":"https://api.github.com/users/ingiulio/events{/privacy}","received_events_url":"https://api.github.com/users/ingiulio/received_events","type":"User","site_admin":false},"body":"this is actually restoring the object to what it's being set to in the main setUp of this test: https://github.com/ingiulio/buster-functional/blob/master/test/test-_loadInIframe.js#L30\r\ndoes this make sense? ","created_at":"2015-05-07T23:47:03Z","updated_at":"2015-05-07T23:47:03Z","html_url":"https://github.com/alexindigo/buster-functional/pull/4#discussion_r29906876","pull_request_url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/comments/29906876"},"html":{"href":"https://github.com/alexindigo/buster-functional/pull/4#discussion_r29906876"},"pull_request":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4","id":31386790,"html_url":"https://github.com/alexindigo/buster-functional/pull/4","diff_url":"https://github.com/alexindigo/buster-functional/pull/4.diff","patch_url":"https://github.com/alexindigo/buster-functional/pull/4.patch","issue_url":"https://api.github.com/repos/alexindigo/buster-functional/issues/4","number":4,"state":"open","locked":false,"title":"throw more useful exception if $ is not defined in iframe","user":{"login":"ingiulio","id":1507923,"avatar_url":"https://avatars.githubusercontent.com/u/1507923?v=3","gravatar_id":"","url":"https://api.github.com/users/ingiulio","html_url":"https://github.com/ingiulio","followers_url":"https://api.github.com/users/ingiulio/followers","following_url":"https://api.github.com/users/ingiulio/following{/other_user}","gists_url":"https://api.github.com/users/ingiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/ingiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingiulio/subscriptions","organizations_url":"https://api.github.com/users/ingiulio/orgs","repos_url":"https://api.github.com/users/ingiulio/repos","events_url":"https://api.github.com/users/ingiulio/events{/privacy}","received_events_url":"https://api.github.com/users/ingiulio/received_events","type":"User","site_admin":false},"body":"The idea is to throw a meaningful exception to help the developer find the root cause of this error","created_at":"2015-03-17T23:03:47Z","updated_at":"2015-05-07T23:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da034577eaffbfef4b9dfb7f1b16d03cde518f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4/commits","review_comments_url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4/comments","review_comment_url":"https://api.github.com/repos/alexindigo/buster-functional/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexindigo/buster-functional/issues/4/comments","statuses_url":"https://api.github.com/repos/alexindigo/buster-functional/statuses/95112dfd57e102de9c072354777ad8ae847292fe","head":{"label":"ingiulio:master","ref":"master","sha":"95112dfd57e102de9c072354777ad8ae847292fe","user":{"login":"ingiulio","id":1507923,"avatar_url":"https://avatars.githubusercontent.com/u/1507923?v=3","gravatar_id":"","url":"https://api.github.com/users/ingiulio","html_url":"https://github.com/ingiulio","followers_url":"https://api.github.com/users/ingiulio/followers","following_url":"https://api.github.com/users/ingiulio/following{/other_user}","gists_url":"https://api.github.com/users/ingiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/ingiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingiulio/subscriptions","organizations_url":"https://api.github.com/users/ingiulio/orgs","repos_url":"https://api.github.com/users/ingiulio/repos","events_url":"https://api.github.com/users/ingiulio/events{/privacy}","received_events_url":"https://api.github.com/users/ingiulio/received_events","type":"User","site_admin":false},"repo":{"id":32414045,"name":"buster-functional","full_name":"ingiulio/buster-functional","owner":{"login":"ingiulio","id":1507923,"avatar_url":"https://avatars.githubusercontent.com/u/1507923?v=3","gravatar_id":"","url":"https://api.github.com/users/ingiulio","html_url":"https://github.com/ingiulio","followers_url":"https://api.github.com/users/ingiulio/followers","following_url":"https://api.github.com/users/ingiulio/following{/other_user}","gists_url":"https://api.github.com/users/ingiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/ingiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingiulio/subscriptions","organizations_url":"https://api.github.com/users/ingiulio/orgs","repos_url":"https://api.github.com/users/ingiulio/repos","events_url":"https://api.github.com/users/ingiulio/events{/privacy}","received_events_url":"https://api.github.com/users/ingiulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingiulio/buster-functional","description":"Functional tests helper for Rendr-powered sites in BusterJS","fork":true,"url":"https://api.github.com/repos/ingiulio/buster-functional","forks_url":"https://api.github.com/repos/ingiulio/buster-functional/forks","keys_url":"https://api.github.com/repos/ingiulio/buster-functional/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingiulio/buster-functional/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingiulio/buster-functional/teams","hooks_url":"https://api.github.com/repos/ingiulio/buster-functional/hooks","issue_events_url":"https://api.github.com/repos/ingiulio/buster-functional/issues/events{/number}","events_url":"https://api.github.com/repos/ingiulio/buster-functional/events","assignees_url":"https://api.github.com/repos/ingiulio/buster-functional/assignees{/user}","branches_url":"https://api.github.com/repos/ingiulio/buster-functional/branches{/branch}","tags_url":"https://api.github.com/repos/ingiulio/buster-functional/tags","blobs_url":"https://api.github.com/repos/ingiulio/buster-functional/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingiulio/buster-functional/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingiulio/buster-functional/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingiulio/buster-functional/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingiulio/buster-functional/statuses/{sha}","languages_url":"https://api.github.com/repos/ingiulio/buster-functional/languages","stargazers_url":"https://api.github.com/repos/ingiulio/buster-functional/stargazers","contributors_url":"https://api.github.com/repos/ingiulio/buster-functional/contributors","subscribers_url":"https://api.github.com/repos/ingiulio/buster-functional/subscribers","subscription_url":"https://api.github.com/repos/ingiulio/buster-functional/subscription","commits_url":"https://api.github.com/repos/ingiulio/buster-functional/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingiulio/buster-functional/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingiulio/buster-functional/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingiulio/buster-functional/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingiulio/buster-functional/contents/{+path}","compare_url":"https://api.github.com/repos/ingiulio/buster-functional/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingiulio/buster-functional/merges","archive_url":"https://api.github.com/repos/ingiulio/buster-functional/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingiulio/buster-functional/downloads","issues_url":"https://api.github.com/repos/ingiulio/buster-functional/issues{/number}","pulls_url":"https://api.github.com/repos/ingiulio/buster-functional/pulls{/number}","milestones_url":"https://api.github.com/repos/ingiulio/buster-functional/milestones{/number}","notifications_url":"https://api.github.com/repos/ingiulio/buster-functional/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingiulio/buster-functional/labels{/name}","releases_url":"https://api.github.com/repos/ingiulio/buster-functional/releases{/id}","created_at":"2015-03-17T19:03:36Z","updated_at":"2015-05-07T00:34:58Z","pushed_at":"2015-05-07T00:34:58Z","git_url":"git://github.com/ingiulio/buster-functional.git","ssh_url":"git@github.com:ingiulio/buster-functional.git","clone_url":"https://github.com/ingiulio/buster-functional.git","svn_url":"https://github.com/ingiulio/buster-functional","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexindigo:master","ref":"master","sha":"60943e21bdb7452cfe9ffd866dd9f7a7d5df7bec","user":{"login":"alexindigo","id":127063,"avatar_url":"https://avatars.githubusercontent.com/u/127063?v=3","gravatar_id":"","url":"https://api.github.com/users/alexindigo","html_url":"https://github.com/alexindigo","followers_url":"https://api.github.com/users/alexindigo/followers","following_url":"https://api.github.com/users/alexindigo/following{/other_user}","gists_url":"https://api.github.com/users/alexindigo/gists{/gist_id}","starred_url":"https://api.github.com/users/alexindigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexindigo/subscriptions","organizations_url":"https://api.github.com/users/alexindigo/orgs","repos_url":"https://api.github.com/users/alexindigo/repos","events_url":"https://api.github.com/users/alexindigo/events{/privacy}","received_events_url":"https://api.github.com/users/alexindigo/received_events","type":"User","site_admin":false},"repo":{"id":29565261,"name":"buster-functional","full_name":"alexindigo/buster-functional","owner":{"login":"alexindigo","id":127063,"avatar_url":"https://avatars.githubusercontent.com/u/127063?v=3","gravatar_id":"","url":"https://api.github.com/users/alexindigo","html_url":"https://github.com/alexindigo","followers_url":"https://api.github.com/users/alexindigo/followers","following_url":"https://api.github.com/users/alexindigo/following{/other_user}","gists_url":"https://api.github.com/users/alexindigo/gists{/gist_id}","starred_url":"https://api.github.com/users/alexindigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexindigo/subscriptions","organizations_url":"https://api.github.com/users/alexindigo/orgs","repos_url":"https://api.github.com/users/alexindigo/repos","events_url":"https://api.github.com/users/alexindigo/events{/privacy}","received_events_url":"https://api.github.com/users/alexindigo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexindigo/buster-functional","description":"Functional tests helper for Rendr-powered sites in BusterJS","fork":false,"url":"https://api.github.com/repos/alexindigo/buster-functional","forks_url":"https://api.github.com/repos/alexindigo/buster-functional/forks","keys_url":"https://api.github.com/repos/alexindigo/buster-functional/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexindigo/buster-functional/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexindigo/buster-functional/teams","hooks_url":"https://api.github.com/repos/alexindigo/buster-functional/hooks","issue_events_url":"https://api.github.com/repos/alexindigo/buster-functional/issues/events{/number}","events_url":"https://api.github.com/repos/alexindigo/buster-functional/events","assignees_url":"https://api.github.com/repos/alexindigo/buster-functional/assignees{/user}","branches_url":"https://api.github.com/repos/alexindigo/buster-functional/branches{/branch}","tags_url":"https://api.github.com/repos/alexindigo/buster-functional/tags","blobs_url":"https://api.github.com/repos/alexindigo/buster-functional/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexindigo/buster-functional/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexindigo/buster-functional/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexindigo/buster-functional/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexindigo/buster-functional/statuses/{sha}","languages_url":"https://api.github.com/repos/alexindigo/buster-functional/languages","stargazers_url":"https://api.github.com/repos/alexindigo/buster-functional/stargazers","contributors_url":"https://api.github.com/repos/alexindigo/buster-functional/contributors","subscribers_url":"https://api.github.com/repos/alexindigo/buster-functional/subscribers","subscription_url":"https://api.github.com/repos/alexindigo/buster-functional/subscription","commits_url":"https://api.github.com/repos/alexindigo/buster-functional/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexindigo/buster-functional/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexindigo/buster-functional/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexindigo/buster-functional/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexindigo/buster-functional/contents/{+path}","compare_url":"https://api.github.com/repos/alexindigo/buster-functional/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexindigo/buster-functional/merges","archive_url":"https://api.github.com/repos/alexindigo/buster-functional/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexindigo/buster-functional/downloads","issues_url":"https://api.github.com/repos/alexindigo/buster-functional/issues{/number}","pulls_url":"https://api.github.com/repos/alexindigo/buster-functional/pulls{/number}","milestones_url":"https://api.github.com/repos/alexindigo/buster-functional/milestones{/number}","notifications_url":"https://api.github.com/repos/alexindigo/buster-functional/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexindigo/buster-functional/labels{/name}","releases_url":"https://api.github.com/repos/alexindigo/buster-functional/releases{/id}","created_at":"2015-01-21T01:44:11Z","updated_at":"2015-04-26T13:39:32Z","pushed_at":"2015-05-07T00:34:58Z","git_url":"git://github.com/alexindigo/buster-functional.git","ssh_url":"git@github.com:alexindigo/buster-functional.git","clone_url":"https://github.com/alexindigo/buster-functional.git","svn_url":"https://github.com/alexindigo/buster-functional","homepage":null,"size":503,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4"},"html":{"href":"https://github.com/alexindigo/buster-functional/pull/4"},"issue":{"href":"https://api.github.com/repos/alexindigo/buster-functional/issues/4"},"comments":{"href":"https://api.github.com/repos/alexindigo/buster-functional/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexindigo/buster-functional/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/alexindigo/buster-functional/statuses/95112dfd57e102de9c072354777ad8ae847292fe"}}}}