{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/4260","labels_url":"https://api.github.com/repos/odoo/odoo/issues/4260/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/4260/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/4260/events","html_url":"https://github.com/odoo/odoo/pull/4260","id":52076506,"number":4260,"title":"wrong journal entries created over a taxable services using hr_expense","user":{"login":"rha-odoo","id":7600371,"avatar_url":"https://avatars.githubusercontent.com/u/7600371?v=3","gravatar_id":"","url":"https://api.github.com/users/rha-odoo","html_url":"https://github.com/rha-odoo","followers_url":"https://api.github.com/users/rha-odoo/followers","following_url":"https://api.github.com/users/rha-odoo/following{/other_user}","gists_url":"https://api.github.com/users/rha-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/rha-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rha-odoo/subscriptions","organizations_url":"https://api.github.com/users/rha-odoo/orgs","repos_url":"https://api.github.com/users/rha-odoo/repos","events_url":"https://api.github.com/users/rha-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/rha-odoo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/odoo/odoo/labels/OE","name":"OE","color":"a24689"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2014-12-16T05:59:41Z","updated_at":"2015-02-10T13:57:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/4260","html_url":"https://github.com/odoo/odoo/pull/4260","diff_url":"https://github.com/odoo/odoo/pull/4260.diff","patch_url":"https://github.com/odoo/odoo/pull/4260.patch"},"body":"journal entries created from hr_expense module when the expense line has service product with default tax(include/exclude).\r\n\r\nProblem:\r\n1. a service product, contains purchase tax/taxes(can be expense, tax code and base code should be negative)\r\n2. create an entry of expense for this service product\r\n3. confirm, validate the expense, journal entries created are wrong\r\n\r\nSolution:\r\nthe tax code and base code sign was multiplied to the \"price\" of the journal items, which is wrong, because\r\nit is basically used to assign into debit/credit column, tax/base code sign it should be assigned only to \"tax_amount\""},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/73702479","html_url":"https://github.com/odoo/odoo/pull/4260#issuecomment-73702479","issue_url":"https://api.github.com/repos/odoo/odoo/issues/4260","id":73702479,"user":{"login":"vrenaville","id":355215,"avatar_url":"https://avatars.githubusercontent.com/u/355215?v=3","gravatar_id":"","url":"https://api.github.com/users/vrenaville","html_url":"https://github.com/vrenaville","followers_url":"https://api.github.com/users/vrenaville/followers","following_url":"https://api.github.com/users/vrenaville/following{/other_user}","gists_url":"https://api.github.com/users/vrenaville/gists{/gist_id}","starred_url":"https://api.github.com/users/vrenaville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrenaville/subscriptions","organizations_url":"https://api.github.com/users/vrenaville/orgs","repos_url":"https://api.github.com/users/vrenaville/repos","events_url":"https://api.github.com/users/vrenaville/events{/privacy}","received_events_url":"https://api.github.com/users/vrenaville/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T13:57:21Z","updated_at":"2015-02-10T13:57:21Z","body":"Hello,\r\n\r\nCould you please review/merge this PR, It's really dangerous.\r\n\r\nVincent"}}