{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/comments/28796784","id":28796784,"diff_hunk":"@@ -73,10 +73,15 @@ type UnsupportedFormat string\n func (e UnsupportedFormat) Error() string { return string(e) }\n \n // ConvertToPEM converts all \"safe bags\" contained in pfxData to PEM blocks.\n-func ConvertToPEM(pfxData []byte, password string) (blocks []*pem.Block, err error) {\n-\tp, err := bmpString(password)\n-\tpassword = \"\"\n+func ConvertToPEM(pfxData []byte, utf8Password []byte) (blocks []*pem.Block, err error) {","path":"pkcs12.go","position":7,"original_position":7,"commit_id":"2b3a2b00323d1388384de1c52c61063c366294f6","original_commit_id":"2b3a2b00323d1388384de1c52c61063c366294f6","user":{"login":"nathany","id":4566,"avatar_url":"https://avatars.githubusercontent.com/u/4566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathany","html_url":"https://github.com/nathany","followers_url":"https://api.github.com/users/nathany/followers","following_url":"https://api.github.com/users/nathany/following{/other_user}","gists_url":"https://api.github.com/users/nathany/gists{/gist_id}","starred_url":"https://api.github.com/users/nathany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathany/subscriptions","organizations_url":"https://api.github.com/users/nathany/orgs","repos_url":"https://api.github.com/users/nathany/repos","events_url":"https://api.github.com/users/nathany/events{/privacy}","received_events_url":"https://api.github.com/users/nathany/received_events","type":"User","site_admin":false},"body":":lipstick: This could also be written `pfxData, utf8Password []byte`.\r\nDito below.","created_at":"2015-04-21T16:37:09Z","updated_at":"2015-04-21T16:37:09Z","html_url":"https://github.com/Azure/go-pkcs12/pull/5#discussion_r28796784","pull_request_url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/comments/28796784"},"html":{"href":"https://github.com/Azure/go-pkcs12/pull/5#discussion_r28796784"},"pull_request":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5","id":33309532,"html_url":"https://github.com/Azure/go-pkcs12/pull/5","diff_url":"https://github.com/Azure/go-pkcs12/pull/5.diff","patch_url":"https://github.com/Azure/go-pkcs12/pull/5.patch","issue_url":"https://api.github.com/repos/Azure/go-pkcs12/issues/5","number":5,"state":"open","locked":false,"title":"Move password strings to []byte for active memory clearing","user":{"login":"paulmey","id":1740197,"avatar_url":"https://avatars.githubusercontent.com/u/1740197?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmey","html_url":"https://github.com/paulmey","followers_url":"https://api.github.com/users/paulmey/followers","following_url":"https://api.github.com/users/paulmey/following{/other_user}","gists_url":"https://api.github.com/users/paulmey/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmey/subscriptions","organizations_url":"https://api.github.com/users/paulmey/orgs","repos_url":"https://api.github.com/users/paulmey/repos","events_url":"https://api.github.com/users/paulmey/events{/privacy}","received_events_url":"https://api.github.com/users/paulmey/received_events","type":"User","site_admin":false},"body":"A stab at fixing #3. Please comment...","created_at":"2015-04-14T23:19:01Z","updated_at":"2015-04-21T16:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13eef24420aefa4d62a149cd325da76ef93ca477","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Azure/go-pkcs12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/go-pkcs12/issues/5/comments","statuses_url":"https://api.github.com/repos/Azure/go-pkcs12/statuses/2b3a2b00323d1388384de1c52c61063c366294f6","head":{"label":"paulmey:pwds","ref":"pwds","sha":"2b3a2b00323d1388384de1c52c61063c366294f6","user":{"login":"paulmey","id":1740197,"avatar_url":"https://avatars.githubusercontent.com/u/1740197?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmey","html_url":"https://github.com/paulmey","followers_url":"https://api.github.com/users/paulmey/followers","following_url":"https://api.github.com/users/paulmey/following{/other_user}","gists_url":"https://api.github.com/users/paulmey/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmey/subscriptions","organizations_url":"https://api.github.com/users/paulmey/orgs","repos_url":"https://api.github.com/users/paulmey/repos","events_url":"https://api.github.com/users/paulmey/events{/privacy}","received_events_url":"https://api.github.com/users/paulmey/received_events","type":"User","site_admin":false},"repo":{"id":32544961,"name":"go-pkcs12","full_name":"paulmey/go-pkcs12","owner":{"login":"paulmey","id":1740197,"avatar_url":"https://avatars.githubusercontent.com/u/1740197?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmey","html_url":"https://github.com/paulmey","followers_url":"https://api.github.com/users/paulmey/followers","following_url":"https://api.github.com/users/paulmey/following{/other_user}","gists_url":"https://api.github.com/users/paulmey/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmey/subscriptions","organizations_url":"https://api.github.com/users/paulmey/orgs","repos_url":"https://api.github.com/users/paulmey/repos","events_url":"https://api.github.com/users/paulmey/events{/privacy}","received_events_url":"https://api.github.com/users/paulmey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulmey/go-pkcs12","description":"Some Go implementations of PKCS#12 to read PFX/P12 files.","fork":true,"url":"https://api.github.com/repos/paulmey/go-pkcs12","forks_url":"https://api.github.com/repos/paulmey/go-pkcs12/forks","keys_url":"https://api.github.com/repos/paulmey/go-pkcs12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulmey/go-pkcs12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulmey/go-pkcs12/teams","hooks_url":"https://api.github.com/repos/paulmey/go-pkcs12/hooks","issue_events_url":"https://api.github.com/repos/paulmey/go-pkcs12/issues/events{/number}","events_url":"https://api.github.com/repos/paulmey/go-pkcs12/events","assignees_url":"https://api.github.com/repos/paulmey/go-pkcs12/assignees{/user}","branches_url":"https://api.github.com/repos/paulmey/go-pkcs12/branches{/branch}","tags_url":"https://api.github.com/repos/paulmey/go-pkcs12/tags","blobs_url":"https://api.github.com/repos/paulmey/go-pkcs12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulmey/go-pkcs12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulmey/go-pkcs12/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulmey/go-pkcs12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulmey/go-pkcs12/statuses/{sha}","languages_url":"https://api.github.com/repos/paulmey/go-pkcs12/languages","stargazers_url":"https://api.github.com/repos/paulmey/go-pkcs12/stargazers","contributors_url":"https://api.github.com/repos/paulmey/go-pkcs12/contributors","subscribers_url":"https://api.github.com/repos/paulmey/go-pkcs12/subscribers","subscription_url":"https://api.github.com/repos/paulmey/go-pkcs12/subscription","commits_url":"https://api.github.com/repos/paulmey/go-pkcs12/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulmey/go-pkcs12/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulmey/go-pkcs12/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulmey/go-pkcs12/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulmey/go-pkcs12/contents/{+path}","compare_url":"https://api.github.com/repos/paulmey/go-pkcs12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulmey/go-pkcs12/merges","archive_url":"https://api.github.com/repos/paulmey/go-pkcs12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulmey/go-pkcs12/downloads","issues_url":"https://api.github.com/repos/paulmey/go-pkcs12/issues{/number}","pulls_url":"https://api.github.com/repos/paulmey/go-pkcs12/pulls{/number}","milestones_url":"https://api.github.com/repos/paulmey/go-pkcs12/milestones{/number}","notifications_url":"https://api.github.com/repos/paulmey/go-pkcs12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulmey/go-pkcs12/labels{/name}","releases_url":"https://api.github.com/repos/paulmey/go-pkcs12/releases{/id}","created_at":"2015-03-19T20:37:54Z","updated_at":"2015-03-19T20:38:31Z","pushed_at":"2015-04-17T19:37:22Z","git_url":"git://github.com/paulmey/go-pkcs12.git","ssh_url":"git@github.com:paulmey/go-pkcs12.git","clone_url":"https://github.com/paulmey/go-pkcs12.git","svn_url":"https://github.com/paulmey/go-pkcs12","homepage":"","size":67,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"db7f1e6e64746c91ee2226812cdf47275e01d3c0","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":32526879,"name":"go-pkcs12","full_name":"Azure/go-pkcs12","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/go-pkcs12","description":"PCKS#12 implementation for Go","fork":false,"url":"https://api.github.com/repos/Azure/go-pkcs12","forks_url":"https://api.github.com/repos/Azure/go-pkcs12/forks","keys_url":"https://api.github.com/repos/Azure/go-pkcs12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/go-pkcs12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/go-pkcs12/teams","hooks_url":"https://api.github.com/repos/Azure/go-pkcs12/hooks","issue_events_url":"https://api.github.com/repos/Azure/go-pkcs12/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/go-pkcs12/events","assignees_url":"https://api.github.com/repos/Azure/go-pkcs12/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/go-pkcs12/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/go-pkcs12/tags","blobs_url":"https://api.github.com/repos/Azure/go-pkcs12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/go-pkcs12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/go-pkcs12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/go-pkcs12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/go-pkcs12/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/go-pkcs12/languages","stargazers_url":"https://api.github.com/repos/Azure/go-pkcs12/stargazers","contributors_url":"https://api.github.com/repos/Azure/go-pkcs12/contributors","subscribers_url":"https://api.github.com/repos/Azure/go-pkcs12/subscribers","subscription_url":"https://api.github.com/repos/Azure/go-pkcs12/subscription","commits_url":"https://api.github.com/repos/Azure/go-pkcs12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/go-pkcs12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/go-pkcs12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/go-pkcs12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/go-pkcs12/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/go-pkcs12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/go-pkcs12/merges","archive_url":"https://api.github.com/repos/Azure/go-pkcs12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/go-pkcs12/downloads","issues_url":"https://api.github.com/repos/Azure/go-pkcs12/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/go-pkcs12/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/go-pkcs12/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/go-pkcs12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/go-pkcs12/labels{/name}","releases_url":"https://api.github.com/repos/Azure/go-pkcs12/releases{/id}","created_at":"2015-03-19T14:38:03Z","updated_at":"2015-04-18T13:49:30Z","pushed_at":"2015-04-21T16:31:46Z","git_url":"git://github.com/Azure/go-pkcs12.git","ssh_url":"git@github.com:Azure/go-pkcs12.git","clone_url":"https://github.com/Azure/go-pkcs12.git","svn_url":"https://github.com/Azure/go-pkcs12","homepage":"","size":214,"stargazers_count":11,"watchers_count":11,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5"},"html":{"href":"https://github.com/Azure/go-pkcs12/pull/5"},"issue":{"href":"https://api.github.com/repos/Azure/go-pkcs12/issues/5"},"comments":{"href":"https://api.github.com/repos/Azure/go-pkcs12/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/go-pkcs12/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/go-pkcs12/statuses/2b3a2b00323d1388384de1c52c61063c366294f6"}}}}