{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3310","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3310/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3310/comments","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3310/events","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3310","id":109108184,"number":3310,"title":"streamlined the documentation","user":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-09-30T14:50:25Z","updated_at":"2015-09-30T15:10:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3310","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3310","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3310.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3310.patch"},"body":"What did i do?\r\n\r\n1. removed all ``YourNS``, ``AcmeDemoBundle`` and replaced it with ``AppBundle``,  as it is Symfony Best Practice\r\n2. checked all code indetions (yml, xml, twig, php\r\n3. formatted code -> PSR\r\n4. prefixed console command with ``$``\r\n5. tried to add the filepath to all code-blocks, i don't want, that the user is lost\r\n6. simplified some configs\r\n7. added namespaces and use statements\r\n8. we don't need double blank lines, as they weren't rendered\r\n9. renamed ``MyAdmin``, ``FooAdmin`` to something like ``PostAdmin`` or ``PersonAdmin`` and changed the conextual sentences\r\n10. wrapped some php examples on the mappers in their methods, to give the user a better context (example: https://github.com/sonata-project/SonataAdminBundle/compare/sonata-project:master...OskarStark:documentation-rewrite?expand=1#diff-f0cdb69c49fd7280d6667d9b3dc58af8R60)\r\n11. added some ``<?php`` and ``// ...`` for better readability\r\n12. renamed ``url`` to ``URL`` - thanks for the hint @javiereguiluz \r\n\r\nit would be great if **you** :smile: could review this \r\n\r\nOskar\r\n"},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments/144441417","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3310#issuecomment-144441417","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3310","id":144441417,"user":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T15:10:55Z","updated_at":"2015-09-30T15:10:55Z","body":"i will squash my commits when this PR is done!"}}