{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/15","labels_url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/15/comments","events_url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/15/events","html_url":"https://github.com/JuliaGL/GLAbstraction.jl/pull/15","id":74767498,"number":15,"title":"Resolve (partially) several issues in OrthographicCamera","user":{"login":"AlainLich","id":11294498,"avatar_url":"https://avatars.githubusercontent.com/u/11294498?v=3","gravatar_id":"","url":"https://api.github.com/users/AlainLich","html_url":"https://github.com/AlainLich","followers_url":"https://api.github.com/users/AlainLich/followers","following_url":"https://api.github.com/users/AlainLich/following{/other_user}","gists_url":"https://api.github.com/users/AlainLich/gists{/gist_id}","starred_url":"https://api.github.com/users/AlainLich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlainLich/subscriptions","organizations_url":"https://api.github.com/users/AlainLich/orgs","repos_url":"https://api.github.com/users/AlainLich/repos","events_url":"https://api.github.com/users/AlainLich/events{/privacy}","received_events_url":"https://api.github.com/users/AlainLich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-09T21:58:18Z","updated_at":"2015-05-10T07:39:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/pulls/15","html_url":"https://github.com/JuliaGL/GLAbstraction.jl/pull/15","diff_url":"https://github.com/JuliaGL/GLAbstraction.jl/pull/15.diff","patch_url":"https://github.com/JuliaGL/GLAbstraction.jl/pull/15.patch"},"body":"Hi,\r\n\r\nthis patch resolves 3 issues I encountered, only kept a traceback for one:\r\n```\r\nERROR: LoadError: MethodError: `getindex` has no method matching getindex(::Int64, ::UnitRange{Int64})\r\nClosest candidates are:\r\n  getindex(::Number)\r\n  getindex(::Number, !Matched::Integer)\r\n  getindex(::Number, !Matched::Integer...)\r\n  ...\r\n in getindex at /home/alain/.julia/v0.4/FixedSizeArrays/src/indexing.jl:20\r\n in anonymous at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:95\r\n in call at /home/alain/.julia/v0.4/GLAbstraction/src/GLCamera.jl:95\r\n in anonymous at no file:152\r\n in _treeWalkPre! at /home/alain/.julia/v0.4/Romeo/src/XMLScreens/SubScreens.jl:239\r\n in _treeWalkPre! at /home/alain/.julia/v0.4/Romeo/src/XMLScreens/SubScreens.jl:247\r\n in treeWalk! at /home/alain/.julia/v0.4/Romeo/src/XMLScreens/SubScreens.jl:212 (repeats 2 times)\r\n in init_romeo at /home/alain/.julia/v0.4/Romeo/src/XMLScreens/RomeoLib.jl:250\r\n in realMain at /home/alain/src/Julia/Romeo.jl/test/RomeoVolume.jl:112\r\n in main at /home/alain/src/Julia/Romeo.jl/test/RomeoVolume.jl:182\r\n in include at ./boot.jl:252\r\n in include_from_node1 at loading.jl:134\r\n in process_options at ./client.jl:310\r\n in _start at ./client.jl:409\r\nwhile loading /home/alain/src/Julia/Romeo.jl/test/RomeoVolume.jl, in expression starting on line 185\r\n```\r\n\r\nThe code for `simpleConvert` is not good (and code_native shows lots of insn for something\r\nthat ought to be simpler). Anyway, this quick fix has permitted to make progress.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/comments/100597881","html_url":"https://github.com/JuliaGL/GLAbstraction.jl/pull/15#issuecomment-100597881","issue_url":"https://api.github.com/repos/JuliaGL/GLAbstraction.jl/issues/15","id":100597881,"user":{"login":"SimonDanisch","id":1010467,"avatar_url":"https://avatars.githubusercontent.com/u/1010467?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonDanisch","html_url":"https://github.com/SimonDanisch","followers_url":"https://api.github.com/users/SimonDanisch/followers","following_url":"https://api.github.com/users/SimonDanisch/following{/other_user}","gists_url":"https://api.github.com/users/SimonDanisch/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonDanisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonDanisch/subscriptions","organizations_url":"https://api.github.com/users/SimonDanisch/orgs","repos_url":"https://api.github.com/users/SimonDanisch/repos","events_url":"https://api.github.com/users/SimonDanisch/events{/privacy}","received_events_url":"https://api.github.com/users/SimonDanisch/received_events","type":"User","site_admin":false},"created_at":"2015-05-10T07:39:36Z","updated_at":"2015-05-10T07:39:36Z","body":"Ah yeah, I didn't tested that.\r\nBut we should also remove all the anonymous functions in there. \r\nThe speed-up you've felt comes mainly from the removed anonymous functions in the event code..."}}