{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/bijection/pulls/comments/25084709","id":25084709,"diff_hunk":"@@ -0,0 +1,95 @@\n+/*\n+Copyright 2012 Twitter, Inc.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package com.twitter.bijection.twitter_finagle","path":"bijection-finagle/src/main/scala/com/twitter/bijection/twitter_finagle/MySqlConversions.scala","position":17,"original_position":17,"commit_id":"e5da332a002b0cf8aa8df4e19f377f293d2f4156","original_commit_id":"e5da332a002b0cf8aa8df4e19f377f293d2f4156","user":{"login":"ianoc","id":446652,"avatar_url":"https://avatars.githubusercontent.com/u/446652?v=3","gravatar_id":"","url":"https://api.github.com/users/ianoc","html_url":"https://github.com/ianoc","followers_url":"https://api.github.com/users/ianoc/followers","following_url":"https://api.github.com/users/ianoc/following{/other_user}","gists_url":"https://api.github.com/users/ianoc/gists{/gist_id}","starred_url":"https://api.github.com/users/ianoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianoc/subscriptions","organizations_url":"https://api.github.com/users/ianoc/orgs","repos_url":"https://api.github.com/users/ianoc/repos","events_url":"https://api.github.com/users/ianoc/events{/privacy}","received_events_url":"https://api.github.com/users/ianoc/received_events","type":"User","site_admin":false},"body":"twitter_finagle? are there other finagle projects? should drop the twitter_","created_at":"2015-02-20T17:08:25Z","updated_at":"2015-02-20T17:08:25Z","html_url":"https://github.com/twitter/bijection/pull/197#discussion_r25084709","pull_request_url":"https://api.github.com/repos/twitter/bijection/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/twitter/bijection/pulls/comments/25084709"},"html":{"href":"https://github.com/twitter/bijection/pull/197#discussion_r25084709"},"pull_request":{"href":"https://api.github.com/repos/twitter/bijection/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/bijection/pulls/197","id":29696528,"html_url":"https://github.com/twitter/bijection/pull/197","diff_url":"https://github.com/twitter/bijection/pull/197.diff","patch_url":"https://github.com/twitter/bijection/pull/197.patch","issue_url":"https://api.github.com/repos/twitter/bijection/issues/197","number":197,"state":"open","locked":false,"title":"Add a module for finagle bijections.","user":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?v=3","gravatar_id":"","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"body":"As suggested in https://github.com/twitter/finagle/pull/341, implemented `Bijection`s and `Injection`s for finagle-mysql datatypes.\r\n\r\n/cc @mosesn @fwbrasil @williamboxhall \r\n\r\n```scala\r\n> bijection-finagle/console\r\n[info] Starting scala interpreter...\r\n[info]\r\nWelcome to Scala version 2.10.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_20).\r\nType in expressions to have them evaluated.\r\nType :help for more information.\r\n\r\nscala> import com.twitter.finagle.exp.mysql._\r\nimport com.twitter.finagle.exp.mysql._\r\n\r\nscala> import com.twitter.bijection.Conversion.asMethod\r\nimport com.twitter.bijection.Conversion.asMethod\r\n\r\nscala> import com.twitter.bijection.twitter_finagle.MySqlConversions._\r\nimport com.twitter.bijection.twitter_finagle.MySqlConversions._\r\n\r\nscala> NullValue.as[Option[String]]\r\nres1: Option[String] = None\r\n\r\nscala> StringValue(\"Hej\").as[String]\r\nres2: String = Hej\r\n\r\nscala> IntValue(10).as[Option[Int]]\r\nres3: Option[Int] = Some(10)\r\n```","created_at":"2015-02-20T13:47:05Z","updated_at":"2015-02-20T17:08:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4bea7accfef7560a00bdeeb9422c0a2dd71625c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/bijection/pulls/197/commits","review_comments_url":"https://api.github.com/repos/twitter/bijection/pulls/197/comments","review_comment_url":"https://api.github.com/repos/twitter/bijection/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/bijection/issues/197/comments","statuses_url":"https://api.github.com/repos/twitter/bijection/statuses/e5da332a002b0cf8aa8df4e19f377f293d2f4156","head":{"label":"folone:finagle-mysql","ref":"finagle-mysql","sha":"e5da332a002b0cf8aa8df4e19f377f293d2f4156","user":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?v=3","gravatar_id":"","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"repo":{"id":31063997,"name":"bijection","full_name":"folone/bijection","owner":{"login":"folone","id":366132,"avatar_url":"https://avatars.githubusercontent.com/u/366132?v=3","gravatar_id":"","url":"https://api.github.com/users/folone","html_url":"https://github.com/folone","followers_url":"https://api.github.com/users/folone/followers","following_url":"https://api.github.com/users/folone/following{/other_user}","gists_url":"https://api.github.com/users/folone/gists{/gist_id}","starred_url":"https://api.github.com/users/folone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folone/subscriptions","organizations_url":"https://api.github.com/users/folone/orgs","repos_url":"https://api.github.com/users/folone/repos","events_url":"https://api.github.com/users/folone/events{/privacy}","received_events_url":"https://api.github.com/users/folone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/folone/bijection","description":"Reversible conversions between types","fork":true,"url":"https://api.github.com/repos/folone/bijection","forks_url":"https://api.github.com/repos/folone/bijection/forks","keys_url":"https://api.github.com/repos/folone/bijection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folone/bijection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folone/bijection/teams","hooks_url":"https://api.github.com/repos/folone/bijection/hooks","issue_events_url":"https://api.github.com/repos/folone/bijection/issues/events{/number}","events_url":"https://api.github.com/repos/folone/bijection/events","assignees_url":"https://api.github.com/repos/folone/bijection/assignees{/user}","branches_url":"https://api.github.com/repos/folone/bijection/branches{/branch}","tags_url":"https://api.github.com/repos/folone/bijection/tags","blobs_url":"https://api.github.com/repos/folone/bijection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folone/bijection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folone/bijection/git/refs{/sha}","trees_url":"https://api.github.com/repos/folone/bijection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folone/bijection/statuses/{sha}","languages_url":"https://api.github.com/repos/folone/bijection/languages","stargazers_url":"https://api.github.com/repos/folone/bijection/stargazers","contributors_url":"https://api.github.com/repos/folone/bijection/contributors","subscribers_url":"https://api.github.com/repos/folone/bijection/subscribers","subscription_url":"https://api.github.com/repos/folone/bijection/subscription","commits_url":"https://api.github.com/repos/folone/bijection/commits{/sha}","git_commits_url":"https://api.github.com/repos/folone/bijection/git/commits{/sha}","comments_url":"https://api.github.com/repos/folone/bijection/comments{/number}","issue_comment_url":"https://api.github.com/repos/folone/bijection/issues/comments/{number}","contents_url":"https://api.github.com/repos/folone/bijection/contents/{+path}","compare_url":"https://api.github.com/repos/folone/bijection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folone/bijection/merges","archive_url":"https://api.github.com/repos/folone/bijection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folone/bijection/downloads","issues_url":"https://api.github.com/repos/folone/bijection/issues{/number}","pulls_url":"https://api.github.com/repos/folone/bijection/pulls{/number}","milestones_url":"https://api.github.com/repos/folone/bijection/milestones{/number}","notifications_url":"https://api.github.com/repos/folone/bijection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folone/bijection/labels{/name}","releases_url":"https://api.github.com/repos/folone/bijection/releases{/id}","created_at":"2015-02-20T12:30:12Z","updated_at":"2015-02-20T12:30:13Z","pushed_at":"2015-02-20T13:44:41Z","git_url":"git://github.com/folone/bijection.git","ssh_url":"git@github.com:folone/bijection.git","clone_url":"https://github.com/folone/bijection.git","svn_url":"https://github.com/folone/bijection","homepage":"","size":3145,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"76f63774807c052ea3cf59064657e4e9e531806c","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":7380994,"name":"bijection","full_name":"twitter/bijection","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/bijection","description":"Reversible conversions between types","fork":false,"url":"https://api.github.com/repos/twitter/bijection","forks_url":"https://api.github.com/repos/twitter/bijection/forks","keys_url":"https://api.github.com/repos/twitter/bijection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/bijection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/bijection/teams","hooks_url":"https://api.github.com/repos/twitter/bijection/hooks","issue_events_url":"https://api.github.com/repos/twitter/bijection/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/bijection/events","assignees_url":"https://api.github.com/repos/twitter/bijection/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/bijection/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/bijection/tags","blobs_url":"https://api.github.com/repos/twitter/bijection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/bijection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/bijection/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/bijection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/bijection/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/bijection/languages","stargazers_url":"https://api.github.com/repos/twitter/bijection/stargazers","contributors_url":"https://api.github.com/repos/twitter/bijection/contributors","subscribers_url":"https://api.github.com/repos/twitter/bijection/subscribers","subscription_url":"https://api.github.com/repos/twitter/bijection/subscription","commits_url":"https://api.github.com/repos/twitter/bijection/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/bijection/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/bijection/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/bijection/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/bijection/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/bijection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/bijection/merges","archive_url":"https://api.github.com/repos/twitter/bijection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/bijection/downloads","issues_url":"https://api.github.com/repos/twitter/bijection/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/bijection/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/bijection/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/bijection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/bijection/labels{/name}","releases_url":"https://api.github.com/repos/twitter/bijection/releases{/id}","created_at":"2012-12-30T22:22:25Z","updated_at":"2015-02-16T18:37:30Z","pushed_at":"2015-01-17T00:23:58Z","git_url":"git://github.com/twitter/bijection.git","ssh_url":"git@github.com:twitter/bijection.git","clone_url":"https://github.com/twitter/bijection.git","svn_url":"https://github.com/twitter/bijection","homepage":"","size":3145,"stargazers_count":265,"watchers_count":265,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":20,"forks":48,"open_issues":20,"watchers":265,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/bijection/pulls/197"},"html":{"href":"https://github.com/twitter/bijection/pull/197"},"issue":{"href":"https://api.github.com/repos/twitter/bijection/issues/197"},"comments":{"href":"https://api.github.com/repos/twitter/bijection/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/bijection/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/bijection/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/bijection/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/bijection/statuses/e5da332a002b0cf8aa8df4e19f377f293d2f4156"}}}}