{"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/edwardr/staffer/pulls/6","id":31932586,"html_url":"https://github.com/edwardr/staffer/pull/6","diff_url":"https://github.com/edwardr/staffer/pull/6.diff","patch_url":"https://github.com/edwardr/staffer/pull/6.patch","issue_url":"https://api.github.com/repos/edwardr/staffer/issues/6","number":6,"state":"open","locked":false,"title":"ability to filter with_front arg","user":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"body":"This introduces a `staffer_with_front` filter to change the staff post type's `rewrite['with_front']` arg. This is one possible way to resolve #4. With the filter, this is all that's needed to change the permalink structure:\r\n\r\n`add_filter( 'staffer_with_front', '__return_false' );`\r\n\r\nThat's much better than the bulkier alternative given in #4.\r\n\r\nThat said, I wonder if a new option (defaulted to `true`) would make more sense. If you've never had complaints about this issue before, then a filter is probably sufficient, otherwise, an option is probably better and this pull request should be rejected.\r\n\r\nLike I said at first, I think `'with_front' => false` is probably a more sensible default but changing it at this point would probably break sites.","created_at":"2015-03-25T15:22:34Z","updated_at":"2015-03-25T15:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edwardr/staffer/pulls/6/commits","review_comments_url":"https://api.github.com/repos/edwardr/staffer/pulls/6/comments","review_comment_url":"https://api.github.com/repos/edwardr/staffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edwardr/staffer/issues/6/comments","statuses_url":"https://api.github.com/repos/edwardr/staffer/statuses/0e7386ab3b99280c319391b23977531d599c86b4","head":{"label":"mrwweb:with_front_filter","ref":"with_front_filter","sha":"0e7386ab3b99280c319391b23977531d599c86b4","user":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"repo":{"id":32412689,"name":"staffer","full_name":"mrwweb/staffer","owner":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrwweb/staffer","description":"A WordPress plugin that adds staff management and custom profiles","fork":true,"url":"https://api.github.com/repos/mrwweb/staffer","forks_url":"https://api.github.com/repos/mrwweb/staffer/forks","keys_url":"https://api.github.com/repos/mrwweb/staffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrwweb/staffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrwweb/staffer/teams","hooks_url":"https://api.github.com/repos/mrwweb/staffer/hooks","issue_events_url":"https://api.github.com/repos/mrwweb/staffer/issues/events{/number}","events_url":"https://api.github.com/repos/mrwweb/staffer/events","assignees_url":"https://api.github.com/repos/mrwweb/staffer/assignees{/user}","branches_url":"https://api.github.com/repos/mrwweb/staffer/branches{/branch}","tags_url":"https://api.github.com/repos/mrwweb/staffer/tags","blobs_url":"https://api.github.com/repos/mrwweb/staffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrwweb/staffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrwweb/staffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrwweb/staffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrwweb/staffer/statuses/{sha}","languages_url":"https://api.github.com/repos/mrwweb/staffer/languages","stargazers_url":"https://api.github.com/repos/mrwweb/staffer/stargazers","contributors_url":"https://api.github.com/repos/mrwweb/staffer/contributors","subscribers_url":"https://api.github.com/repos/mrwweb/staffer/subscribers","subscription_url":"https://api.github.com/repos/mrwweb/staffer/subscription","commits_url":"https://api.github.com/repos/mrwweb/staffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrwweb/staffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrwweb/staffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrwweb/staffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrwweb/staffer/contents/{+path}","compare_url":"https://api.github.com/repos/mrwweb/staffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrwweb/staffer/merges","archive_url":"https://api.github.com/repos/mrwweb/staffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrwweb/staffer/downloads","issues_url":"https://api.github.com/repos/mrwweb/staffer/issues{/number}","pulls_url":"https://api.github.com/repos/mrwweb/staffer/pulls{/number}","milestones_url":"https://api.github.com/repos/mrwweb/staffer/milestones{/number}","notifications_url":"https://api.github.com/repos/mrwweb/staffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrwweb/staffer/labels{/name}","releases_url":"https://api.github.com/repos/mrwweb/staffer/releases{/id}","created_at":"2015-03-17T18:36:36Z","updated_at":"2015-03-17T18:36:36Z","pushed_at":"2015-03-25T15:17:51Z","git_url":"git://github.com/mrwweb/staffer.git","ssh_url":"git@github.com:mrwweb/staffer.git","clone_url":"https://github.com/mrwweb/staffer.git","svn_url":"https://github.com/mrwweb/staffer","homepage":null,"size":506,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edwardr:master","ref":"master","sha":"21fb6a172acc6dadb624132b176982b042168f67","user":{"login":"edwardr","id":2935628,"avatar_url":"https://avatars.githubusercontent.com/u/2935628?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardr","html_url":"https://github.com/edwardr","followers_url":"https://api.github.com/users/edwardr/followers","following_url":"https://api.github.com/users/edwardr/following{/other_user}","gists_url":"https://api.github.com/users/edwardr/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardr/subscriptions","organizations_url":"https://api.github.com/users/edwardr/orgs","repos_url":"https://api.github.com/users/edwardr/repos","events_url":"https://api.github.com/users/edwardr/events{/privacy}","received_events_url":"https://api.github.com/users/edwardr/received_events","type":"User","site_admin":false},"repo":{"id":21909912,"name":"staffer","full_name":"edwardr/staffer","owner":{"login":"edwardr","id":2935628,"avatar_url":"https://avatars.githubusercontent.com/u/2935628?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardr","html_url":"https://github.com/edwardr","followers_url":"https://api.github.com/users/edwardr/followers","following_url":"https://api.github.com/users/edwardr/following{/other_user}","gists_url":"https://api.github.com/users/edwardr/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardr/subscriptions","organizations_url":"https://api.github.com/users/edwardr/orgs","repos_url":"https://api.github.com/users/edwardr/repos","events_url":"https://api.github.com/users/edwardr/events{/privacy}","received_events_url":"https://api.github.com/users/edwardr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwardr/staffer","description":"A WordPress plugin that adds staff management and custom profiles","fork":false,"url":"https://api.github.com/repos/edwardr/staffer","forks_url":"https://api.github.com/repos/edwardr/staffer/forks","keys_url":"https://api.github.com/repos/edwardr/staffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwardr/staffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwardr/staffer/teams","hooks_url":"https://api.github.com/repos/edwardr/staffer/hooks","issue_events_url":"https://api.github.com/repos/edwardr/staffer/issues/events{/number}","events_url":"https://api.github.com/repos/edwardr/staffer/events","assignees_url":"https://api.github.com/repos/edwardr/staffer/assignees{/user}","branches_url":"https://api.github.com/repos/edwardr/staffer/branches{/branch}","tags_url":"https://api.github.com/repos/edwardr/staffer/tags","blobs_url":"https://api.github.com/repos/edwardr/staffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwardr/staffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwardr/staffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwardr/staffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwardr/staffer/statuses/{sha}","languages_url":"https://api.github.com/repos/edwardr/staffer/languages","stargazers_url":"https://api.github.com/repos/edwardr/staffer/stargazers","contributors_url":"https://api.github.com/repos/edwardr/staffer/contributors","subscribers_url":"https://api.github.com/repos/edwardr/staffer/subscribers","subscription_url":"https://api.github.com/repos/edwardr/staffer/subscription","commits_url":"https://api.github.com/repos/edwardr/staffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwardr/staffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwardr/staffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwardr/staffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwardr/staffer/contents/{+path}","compare_url":"https://api.github.com/repos/edwardr/staffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwardr/staffer/merges","archive_url":"https://api.github.com/repos/edwardr/staffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwardr/staffer/downloads","issues_url":"https://api.github.com/repos/edwardr/staffer/issues{/number}","pulls_url":"https://api.github.com/repos/edwardr/staffer/pulls{/number}","milestones_url":"https://api.github.com/repos/edwardr/staffer/milestones{/number}","notifications_url":"https://api.github.com/repos/edwardr/staffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwardr/staffer/labels{/name}","releases_url":"https://api.github.com/repos/edwardr/staffer/releases{/id}","created_at":"2014-07-16T17:16:41Z","updated_at":"2015-03-17T22:45:30Z","pushed_at":"2015-03-25T15:19:16Z","git_url":"git://github.com/edwardr/staffer.git","ssh_url":"git@github.com:edwardr/staffer.git","clone_url":"https://github.com/edwardr/staffer.git","svn_url":"https://github.com/edwardr/staffer","homepage":null,"size":588,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edwardr/staffer/pulls/6"},"html":{"href":"https://github.com/edwardr/staffer/pull/6"},"issue":{"href":"https://api.github.com/repos/edwardr/staffer/issues/6"},"comments":{"href":"https://api.github.com/repos/edwardr/staffer/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/edwardr/staffer/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/edwardr/staffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edwardr/staffer/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/edwardr/staffer/statuses/0e7386ab3b99280c319391b23977531d599c86b4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}