{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/composer-restorer/issues/48","labels_url":"https://api.github.com/repos/guardian/composer-restorer/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/guardian/composer-restorer/issues/48/comments","events_url":"https://api.github.com/repos/guardian/composer-restorer/issues/48/events","html_url":"https://github.com/guardian/composer-restorer/pull/48","id":68308272,"number":48,"title":"[DO NOT MERGE] Restorer V2","user":{"login":"cutandpastey","id":1975139,"avatar_url":"https://avatars.githubusercontent.com/u/1975139?v=3","gravatar_id":"","url":"https://api.github.com/users/cutandpastey","html_url":"https://github.com/cutandpastey","followers_url":"https://api.github.com/users/cutandpastey/followers","following_url":"https://api.github.com/users/cutandpastey/following{/other_user}","gists_url":"https://api.github.com/users/cutandpastey/gists{/gist_id}","starred_url":"https://api.github.com/users/cutandpastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cutandpastey/subscriptions","organizations_url":"https://api.github.com/users/cutandpastey/orgs","repos_url":"https://api.github.com/users/cutandpastey/repos","events_url":"https://api.github.com/users/cutandpastey/events{/privacy}","received_events_url":"https://api.github.com/users/cutandpastey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-14T08:53:49Z","updated_at":"2015-04-14T23:05:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/composer-restorer/pulls/48","html_url":"https://github.com/guardian/composer-restorer/pull/48","diff_url":"https://github.com/guardian/composer-restorer/pull/48.diff","patch_url":"https://github.com/guardian/composer-restorer/pull/48.patch"},"body":"This PR re-builds the front end application using angular and the components library. It is dependent on https://github.com/guardian/tools-components/pull/26\r\n\r\nTo Run:\r\n- Clone and checkout `jp-utils` from https://github.com/guardian/tools-components\r\n- Whilst in the components repo run `npm install && jspm link github:guardian/tools-components@0.5`\r\n- Step into the restorer reop run `npm install`\r\n- Then run `jspm install --link composer-components=guithub:guardian/tools-components@0.5` (__the @{version} is important!__)\r\n- Run restorer and load the page\r\n\r\nThis is a particularly large PR. If you are going to review it I would advise running it and using the browser to inspect especially to see how the CSS works. If you need me to go through it please come and ask, I am more than happy to do so.\r\n\r\n__To complete:__\r\n- [ ] Error states\r\n- [ ] Restorer post to flex API\r\n\r\n__There is a slight amount of tidying to do:__ \r\n- [ ] Abstract `modals` into a re-usable component\r\n- [ ] Abstract `carousel` functionality into a re-usable component"},"comment":{"url":"https://api.github.com/repos/guardian/composer-restorer/issues/comments/93105478","html_url":"https://github.com/guardian/composer-restorer/pull/48#issuecomment-93105478","issue_url":"https://api.github.com/repos/guardian/composer-restorer/issues/48","id":93105478,"user":{"login":"theefer","id":36964,"avatar_url":"https://avatars.githubusercontent.com/u/36964?v=3","gravatar_id":"","url":"https://api.github.com/users/theefer","html_url":"https://github.com/theefer","followers_url":"https://api.github.com/users/theefer/followers","following_url":"https://api.github.com/users/theefer/following{/other_user}","gists_url":"https://api.github.com/users/theefer/gists{/gist_id}","starred_url":"https://api.github.com/users/theefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theefer/subscriptions","organizations_url":"https://api.github.com/users/theefer/orgs","repos_url":"https://api.github.com/users/theefer/repos","events_url":"https://api.github.com/users/theefer/events{/privacy}","received_events_url":"https://api.github.com/users/theefer/received_events","type":"User","site_admin":false},"created_at":"2015-04-14T23:05:53Z","updated_at":"2015-04-14T23:05:53Z","body":"Frontend has the Guardian webfonts committed in, [AFAICS](https://github.com/guardian/frontend/tree/master/static/src/stylesheets/components/guss-webfonts). In fact it's the committed Bower dependency (sigh) on [guss-webfonts](https://github.com/guardian/guss-webfonts), which is also open. So it seems to be OK.\r\n\r\nThe question I'd ask though is why all our repos need to have their own copy of these files (Composer, Workflow and Grid have them as well), and why we couldn't all get them from the guss-webfonts repo instead."}}