{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/41291800","id":41291800,"diff_hunk":"@@ -858,37 +857,22 @@ void PendingReceivedMessage::enqueuePacket(std::unique_ptr<Packet> packet) {\n                \"PendingReceivedMessage::enqueuePacket\",\n                \"called with a packet that is not part of a message\");\n     \n-    if (_isComplete) {\n-        qCDebug(networking) << \"UNEXPECTED: Received packet for a message that is already complete\";\n-        return;\n-    }\n-\n-    auto sequenceNumber = packet->getSequenceNumber();\n-\n-    if (packet->getPacketPosition() == Packet::PacketPosition::FIRST) {\n-        _hasFirstSequenceNumber = true;\n-        _firstSequenceNumber = sequenceNumber;\n-    } else if (packet->getPacketPosition() == Packet::PacketPosition::LAST) {\n-        _hasLastSequenceNumber = true;\n-        _lastSequenceNumber = sequenceNumber;\n-    } else if (packet->getPacketPosition() == Packet::PacketPosition::ONLY) {\n-        _hasFirstSequenceNumber = true;\n-        _hasLastSequenceNumber = true;\n-        _firstSequenceNumber = sequenceNumber;\n-        _lastSequenceNumber = sequenceNumber;\n+    if (packet->getPacketPosition() == Packet::PacketPosition::LAST ||\n+        packet->getPacketPosition() == Packet::PacketPosition::ONLY) {\n+        _hasLastPacket = true;\n+        _numPackets = packet->getMessagePart() + 1;\n     }\n \n     // Insert into the packets list in sorted order. Because we generally expect to receive packets in order, begin\n     // searching from the end of the list.\n-    auto it = find_if(_packets.rbegin(), _packets.rend(),\n-        [&](const std::unique_ptr<Packet>& packet) { return sequenceNumber > packet->getSequenceNumber(); });\n-\n-    _packets.insert(it.base(), std::move(packet));\n+    auto messagePart = packet->getMessagePart();","path":"libraries/networking/src/udt/Connection.cpp","position":54,"original_position":54,"commit_id":"f5f349e13aa1b914dccc90399204c1e502174d44","original_commit_id":"f5f349e13aa1b914dccc90399204c1e502174d44","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"Should we call this a `messagePartNumber`? Otherwise it's not clear to me that it's a sequence number and not an actual part of the message.","created_at":"2015-10-06T17:01:59Z","updated_at":"2015-10-06T17:01:59Z","html_url":"https://github.com/highfidelity/hifi/pull/5892#discussion_r41291800","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5892","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/41291800"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5892#discussion_r41291800"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5892"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5892","id":45888867,"html_url":"https://github.com/highfidelity/hifi/pull/5892","diff_url":"https://github.com/highfidelity/hifi/pull/5892.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5892.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5892","number":5892,"state":"open","locked":false,"title":"Add channels to UDT","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"- Each AssetRequest now has it's own channel\r\n\r\nMain benefits being they are transmitted in parallel.\r\nThis allows smaller assets to be transmitted at the same time than the bigger ones without having to wait.\r\n","created_at":"2015-09-24T12:04:37Z","updated_at":"2015-10-06T17:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4986e723d4cc0495e9d713fa9ef706ba60879be4","assignee":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5892/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5892/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5892/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/f5f349e13aa1b914dccc90399204c1e502174d44","head":{"label":"Atlante45:protocol","ref":"protocol","sha":"f5f349e13aa1b914dccc90399204c1e502174d44","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"repo":{"id":11436474,"name":"hifi","full_name":"Atlante45/hifi","owner":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Atlante45/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/Atlante45/hifi","forks_url":"https://api.github.com/repos/Atlante45/hifi/forks","keys_url":"https://api.github.com/repos/Atlante45/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Atlante45/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Atlante45/hifi/teams","hooks_url":"https://api.github.com/repos/Atlante45/hifi/hooks","issue_events_url":"https://api.github.com/repos/Atlante45/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/Atlante45/hifi/events","assignees_url":"https://api.github.com/repos/Atlante45/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/Atlante45/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/Atlante45/hifi/tags","blobs_url":"https://api.github.com/repos/Atlante45/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Atlante45/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Atlante45/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Atlante45/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Atlante45/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/Atlante45/hifi/languages","stargazers_url":"https://api.github.com/repos/Atlante45/hifi/stargazers","contributors_url":"https://api.github.com/repos/Atlante45/hifi/contributors","subscribers_url":"https://api.github.com/repos/Atlante45/hifi/subscribers","subscription_url":"https://api.github.com/repos/Atlante45/hifi/subscription","commits_url":"https://api.github.com/repos/Atlante45/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Atlante45/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Atlante45/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Atlante45/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Atlante45/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/Atlante45/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Atlante45/hifi/merges","archive_url":"https://api.github.com/repos/Atlante45/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Atlante45/hifi/downloads","issues_url":"https://api.github.com/repos/Atlante45/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/Atlante45/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/Atlante45/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/Atlante45/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Atlante45/hifi/labels{/name}","releases_url":"https://api.github.com/repos/Atlante45/hifi/releases{/id}","created_at":"2013-07-15T23:52:30Z","updated_at":"2015-05-08T13:17:34Z","pushed_at":"2015-10-06T02:04:53Z","git_url":"git://github.com/Atlante45/hifi.git","ssh_url":"git@github.com:Atlante45/hifi.git","clone_url":"https://github.com/Atlante45/hifi.git","svn_url":"https://github.com/Atlante45/hifi","homepage":null,"size":182350,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"f6665a4ac6889c77babd2baf0671ba3089fdc993","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-10-01T15:27:15Z","pushed_at":"2015-10-06T16:55:36Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":240608,"stargazers_count":311,"watchers_count":311,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":57,"forks":178,"open_issues":57,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5892"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5892"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5892"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5892/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5892/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5892/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/f5f349e13aa1b914dccc90399204c1e502174d44"}}}}