{"action":"created","comment":{"url":"https://api.github.com/repos/MiniProfiler/ui/pulls/comments/37431710","id":37431710,"diff_hunk":"@@ -696,6 +696,22 @@ var MiniProfiler = (function () {\n                     };\n                 }\n             }\n+\t\t\telse if (this.onload) {","path":"includes.js","position":13,"original_position":13,"commit_id":"2c8e4b98813c8e9ce85586ea2996e367b31e8bbf","original_commit_id":"2c8e4b98813c8e9ce85586ea2996e367b31e8bbf","user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"body":"Please fix the whitespace here.","created_at":"2015-08-19T15:55:40Z","updated_at":"2015-08-19T15:55:40Z","html_url":"https://github.com/MiniProfiler/ui/pull/20#discussion_r37431710","pull_request_url":"https://api.github.com/repos/MiniProfiler/ui/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/comments/37431710"},"html":{"href":"https://github.com/MiniProfiler/ui/pull/20#discussion_r37431710"},"pull_request":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/MiniProfiler/ui/pulls/20","id":41949321,"html_url":"https://github.com/MiniProfiler/ui/pull/20","diff_url":"https://github.com/MiniProfiler/ui/pull/20.diff","patch_url":"https://github.com/MiniProfiler/ui/pull/20.patch","issue_url":"https://api.github.com/repos/MiniProfiler/ui/issues/20","number":20,"state":"open","locked":false,"title":"Support profiling $http requests in Angular 1.3+","user":{"login":"jadarnel27","id":13036637,"avatar_url":"https://avatars.githubusercontent.com/u/13036637?v=3","gravatar_id":"","url":"https://api.github.com/users/jadarnel27","html_url":"https://github.com/jadarnel27","followers_url":"https://api.github.com/users/jadarnel27/followers","following_url":"https://api.github.com/users/jadarnel27/following{/other_user}","gists_url":"https://api.github.com/users/jadarnel27/gists{/gist_id}","starred_url":"https://api.github.com/users/jadarnel27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadarnel27/subscriptions","organizations_url":"https://api.github.com/users/jadarnel27/orgs","repos_url":"https://api.github.com/users/jadarnel27/repos","events_url":"https://api.github.com/users/jadarnel27/events{/privacy}","received_events_url":"https://api.github.com/users/jadarnel27/received_events","type":"User","site_admin":false},"body":"MiniProfiler currently doesn't render profiling for AJAX calls made using the $http service in AngularJS versions starting at 1.3.  This is because the $http service stopped using the `onreadystatechange` event for handling request completion (in favor of the `onload` event) in that version.  Here is the commit for that change: https://github.com/angular/angular.js/commit/40d8da80ce773dd82166428f481e33df51883340\r\n\r\nAnd it's [still like that in the latest version](https://github.com/angular/angular.js/blob/master/src/ng/httpBackend.js#L58) (1.4.3 right now).\r\n\r\nThe reason that matters is that MiniProfiler [currently depends on that pre-1.3 implementation](https://github.com/MiniProfiler/ui/blob/master/includes.js#L681) (replaces the `onreadystatechange` handler, does MiniProfiler work, calls Angular's handler at the end).\r\n\r\nThis pull request adds AngularJS 1.3+ support, while maintaining support for earlier versions as well, by trying to use onload if there is no handler for onreadystatechange.","created_at":"2015-08-08T05:59:38Z","updated_at":"2015-08-19T15:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f927326a837762fe3fd82c805055ab5ab87d7ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MiniProfiler/ui/pulls/20/commits","review_comments_url":"https://api.github.com/repos/MiniProfiler/ui/pulls/20/comments","review_comment_url":"https://api.github.com/repos/MiniProfiler/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MiniProfiler/ui/issues/20/comments","statuses_url":"https://api.github.com/repos/MiniProfiler/ui/statuses/2c8e4b98813c8e9ce85586ea2996e367b31e8bbf","head":{"label":"jadarnel27:fix-angular-1.3-support","ref":"fix-angular-1.3-support","sha":"2c8e4b98813c8e9ce85586ea2996e367b31e8bbf","user":{"login":"jadarnel27","id":13036637,"avatar_url":"https://avatars.githubusercontent.com/u/13036637?v=3","gravatar_id":"","url":"https://api.github.com/users/jadarnel27","html_url":"https://github.com/jadarnel27","followers_url":"https://api.github.com/users/jadarnel27/followers","following_url":"https://api.github.com/users/jadarnel27/following{/other_user}","gists_url":"https://api.github.com/users/jadarnel27/gists{/gist_id}","starred_url":"https://api.github.com/users/jadarnel27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadarnel27/subscriptions","organizations_url":"https://api.github.com/users/jadarnel27/orgs","repos_url":"https://api.github.com/users/jadarnel27/repos","events_url":"https://api.github.com/users/jadarnel27/events{/privacy}","received_events_url":"https://api.github.com/users/jadarnel27/received_events","type":"User","site_admin":false},"repo":{"id":40391663,"name":"ui","full_name":"jadarnel27/ui","owner":{"login":"jadarnel27","id":13036637,"avatar_url":"https://avatars.githubusercontent.com/u/13036637?v=3","gravatar_id":"","url":"https://api.github.com/users/jadarnel27","html_url":"https://github.com/jadarnel27","followers_url":"https://api.github.com/users/jadarnel27/followers","following_url":"https://api.github.com/users/jadarnel27/following{/other_user}","gists_url":"https://api.github.com/users/jadarnel27/gists{/gist_id}","starred_url":"https://api.github.com/users/jadarnel27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadarnel27/subscriptions","organizations_url":"https://api.github.com/users/jadarnel27/orgs","repos_url":"https://api.github.com/users/jadarnel27/repos","events_url":"https://api.github.com/users/jadarnel27/events{/privacy}","received_events_url":"https://api.github.com/users/jadarnel27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jadarnel27/ui","description":"Shared front-end code for any language implementation.","fork":true,"url":"https://api.github.com/repos/jadarnel27/ui","forks_url":"https://api.github.com/repos/jadarnel27/ui/forks","keys_url":"https://api.github.com/repos/jadarnel27/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadarnel27/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadarnel27/ui/teams","hooks_url":"https://api.github.com/repos/jadarnel27/ui/hooks","issue_events_url":"https://api.github.com/repos/jadarnel27/ui/issues/events{/number}","events_url":"https://api.github.com/repos/jadarnel27/ui/events","assignees_url":"https://api.github.com/repos/jadarnel27/ui/assignees{/user}","branches_url":"https://api.github.com/repos/jadarnel27/ui/branches{/branch}","tags_url":"https://api.github.com/repos/jadarnel27/ui/tags","blobs_url":"https://api.github.com/repos/jadarnel27/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadarnel27/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadarnel27/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadarnel27/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadarnel27/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jadarnel27/ui/languages","stargazers_url":"https://api.github.com/repos/jadarnel27/ui/stargazers","contributors_url":"https://api.github.com/repos/jadarnel27/ui/contributors","subscribers_url":"https://api.github.com/repos/jadarnel27/ui/subscribers","subscription_url":"https://api.github.com/repos/jadarnel27/ui/subscription","commits_url":"https://api.github.com/repos/jadarnel27/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadarnel27/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadarnel27/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadarnel27/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadarnel27/ui/contents/{+path}","compare_url":"https://api.github.com/repos/jadarnel27/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadarnel27/ui/merges","archive_url":"https://api.github.com/repos/jadarnel27/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadarnel27/ui/downloads","issues_url":"https://api.github.com/repos/jadarnel27/ui/issues{/number}","pulls_url":"https://api.github.com/repos/jadarnel27/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jadarnel27/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jadarnel27/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadarnel27/ui/labels{/name}","releases_url":"https://api.github.com/repos/jadarnel27/ui/releases{/id}","created_at":"2015-08-08T04:41:49Z","updated_at":"2015-08-08T04:41:49Z","pushed_at":"2015-08-08T05:53:37Z","git_url":"git://github.com/jadarnel27/ui.git","ssh_url":"git@github.com:jadarnel27/ui.git","clone_url":"https://github.com/jadarnel27/ui.git","svn_url":"https://github.com/jadarnel27/ui","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MiniProfiler:master","ref":"master","sha":"a87bf42b0e2ef03772f8475cbf2eb8dc04543ed1","user":{"login":"MiniProfiler","id":1631473,"avatar_url":"https://avatars.githubusercontent.com/u/1631473?v=3","gravatar_id":"","url":"https://api.github.com/users/MiniProfiler","html_url":"https://github.com/MiniProfiler","followers_url":"https://api.github.com/users/MiniProfiler/followers","following_url":"https://api.github.com/users/MiniProfiler/following{/other_user}","gists_url":"https://api.github.com/users/MiniProfiler/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniProfiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniProfiler/subscriptions","organizations_url":"https://api.github.com/users/MiniProfiler/orgs","repos_url":"https://api.github.com/users/MiniProfiler/repos","events_url":"https://api.github.com/users/MiniProfiler/events{/privacy}","received_events_url":"https://api.github.com/users/MiniProfiler/received_events","type":"Organization","site_admin":false},"repo":{"id":9971997,"name":"ui","full_name":"MiniProfiler/ui","owner":{"login":"MiniProfiler","id":1631473,"avatar_url":"https://avatars.githubusercontent.com/u/1631473?v=3","gravatar_id":"","url":"https://api.github.com/users/MiniProfiler","html_url":"https://github.com/MiniProfiler","followers_url":"https://api.github.com/users/MiniProfiler/followers","following_url":"https://api.github.com/users/MiniProfiler/following{/other_user}","gists_url":"https://api.github.com/users/MiniProfiler/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniProfiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniProfiler/subscriptions","organizations_url":"https://api.github.com/users/MiniProfiler/orgs","repos_url":"https://api.github.com/users/MiniProfiler/repos","events_url":"https://api.github.com/users/MiniProfiler/events{/privacy}","received_events_url":"https://api.github.com/users/MiniProfiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MiniProfiler/ui","description":"Shared front-end code for any language implementation.","fork":false,"url":"https://api.github.com/repos/MiniProfiler/ui","forks_url":"https://api.github.com/repos/MiniProfiler/ui/forks","keys_url":"https://api.github.com/repos/MiniProfiler/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiniProfiler/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiniProfiler/ui/teams","hooks_url":"https://api.github.com/repos/MiniProfiler/ui/hooks","issue_events_url":"https://api.github.com/repos/MiniProfiler/ui/issues/events{/number}","events_url":"https://api.github.com/repos/MiniProfiler/ui/events","assignees_url":"https://api.github.com/repos/MiniProfiler/ui/assignees{/user}","branches_url":"https://api.github.com/repos/MiniProfiler/ui/branches{/branch}","tags_url":"https://api.github.com/repos/MiniProfiler/ui/tags","blobs_url":"https://api.github.com/repos/MiniProfiler/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiniProfiler/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiniProfiler/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiniProfiler/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiniProfiler/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/MiniProfiler/ui/languages","stargazers_url":"https://api.github.com/repos/MiniProfiler/ui/stargazers","contributors_url":"https://api.github.com/repos/MiniProfiler/ui/contributors","subscribers_url":"https://api.github.com/repos/MiniProfiler/ui/subscribers","subscription_url":"https://api.github.com/repos/MiniProfiler/ui/subscription","commits_url":"https://api.github.com/repos/MiniProfiler/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiniProfiler/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiniProfiler/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiniProfiler/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/MiniProfiler/ui/contents/{+path}","compare_url":"https://api.github.com/repos/MiniProfiler/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiniProfiler/ui/merges","archive_url":"https://api.github.com/repos/MiniProfiler/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiniProfiler/ui/downloads","issues_url":"https://api.github.com/repos/MiniProfiler/ui/issues{/number}","pulls_url":"https://api.github.com/repos/MiniProfiler/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/MiniProfiler/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/MiniProfiler/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiniProfiler/ui/labels{/name}","releases_url":"https://api.github.com/repos/MiniProfiler/ui/releases{/id}","created_at":"2013-05-10T01:22:00Z","updated_at":"2015-08-14T08:52:33Z","pushed_at":"2015-08-08T05:59:38Z","git_url":"git://github.com/MiniProfiler/ui.git","ssh_url":"git@github.com:MiniProfiler/ui.git","clone_url":"https://github.com/MiniProfiler/ui.git","svn_url":"https://github.com/MiniProfiler/ui","homepage":"","size":597,"stargazers_count":32,"watchers_count":32,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":2,"forks":32,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/20"},"html":{"href":"https://github.com/MiniProfiler/ui/pull/20"},"issue":{"href":"https://api.github.com/repos/MiniProfiler/ui/issues/20"},"comments":{"href":"https://api.github.com/repos/MiniProfiler/ui/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MiniProfiler/ui/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/MiniProfiler/ui/statuses/2c8e4b98813c8e9ce85586ea2996e367b31e8bbf"}}}}