{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/22921778","id":22921778,"diff_hunk":"@@ -0,0 +1,115 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.types.date","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala","position":18,"original_position":18,"commit_id":"810c8c33582c778f32a381505ff72d858cfdb342","original_commit_id":"810c8c33582c778f32a381505ff72d858cfdb342","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars.githubusercontent.com/u/323388?v=3","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"body":"Actually we should probably put this in sql.types rather than the date package. I don't think we want to create a new package for each data type.  https://issues.apache.org/jira/browse/SPARK-5245\r\n\r\nCan you move it? Decimal was a bad example. Please do so if you want to submit a PR for moving Decimal too. ","created_at":"2015-01-14T08:25:10Z","updated_at":"2015-01-14T08:25:10Z","html_url":"https://github.com/apache/spark/pull/3732#discussion_r22921778","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3732","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/22921778"},"html":{"href":"https://github.com/apache/spark/pull/3732#discussion_r22921778"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3732"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3732","id":26283877,"html_url":"https://github.com/apache/spark/pull/3732","diff_url":"https://github.com/apache/spark/pull/3732.diff","patch_url":"https://github.com/apache/spark/pull/3732.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3732","number":3732,"state":"open","locked":false,"title":"[SPARK-4508] [SQL] build native date type to conform behavior to Hive","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"Store daysSinceEpoch as an Int value(4 bytes) to represent DateType, instead of using java.sql.Date(8 bytes as Long) in catalyst row. This ensures the same comparison behavior of Hive and Catalyst.\r\nSubsumes #3381 \r\nI thinks there are already some tests in JavaSQLSuite, and for python it will not affect python's datetime class.","created_at":"2014-12-18T08:20:56Z","updated_at":"2015-01-14T08:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ff87e5012371fa1f5f8d653951cad87ad9bc703","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3732/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3732/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3732/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/810c8c33582c778f32a381505ff72d858cfdb342","head":{"label":"adrian-wang:datenative","ref":"datenative","sha":"810c8c33582c778f32a381505ff72d858cfdb342","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"repo":{"id":18545588,"name":"spark","full_name":"adrian-wang/spark","owner":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-wang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/adrian-wang/spark","forks_url":"https://api.github.com/repos/adrian-wang/spark/forks","keys_url":"https://api.github.com/repos/adrian-wang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-wang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-wang/spark/teams","hooks_url":"https://api.github.com/repos/adrian-wang/spark/hooks","issue_events_url":"https://api.github.com/repos/adrian-wang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-wang/spark/events","assignees_url":"https://api.github.com/repos/adrian-wang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-wang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-wang/spark/tags","blobs_url":"https://api.github.com/repos/adrian-wang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-wang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-wang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-wang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-wang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-wang/spark/languages","stargazers_url":"https://api.github.com/repos/adrian-wang/spark/stargazers","contributors_url":"https://api.github.com/repos/adrian-wang/spark/contributors","subscribers_url":"https://api.github.com/repos/adrian-wang/spark/subscribers","subscription_url":"https://api.github.com/repos/adrian-wang/spark/subscription","commits_url":"https://api.github.com/repos/adrian-wang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-wang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-wang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-wang/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/adrian-wang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-wang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-wang/spark/merges","archive_url":"https://api.github.com/repos/adrian-wang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-wang/spark/downloads","issues_url":"https://api.github.com/repos/adrian-wang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-wang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-wang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-wang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-wang/spark/labels{/name}","releases_url":"https://api.github.com/repos/adrian-wang/spark/releases{/id}","created_at":"2014-04-08T04:42:25Z","updated_at":"2014-07-17T08:04:57Z","pushed_at":"2015-01-14T08:04:46Z","git_url":"git://github.com/adrian-wang/spark.git","ssh_url":"git@github.com:adrian-wang/spark.git","clone_url":"https://github.com/adrian-wang/spark.git","svn_url":"https://github.com/adrian-wang/spark","homepage":null,"size":88088,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f9969098c8cb15e36c718b80c6cf5b534a6cf7c3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-01-14T07:34:14Z","pushed_at":"2015-01-14T01:17:04Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1139457,"stargazers_count":2553,"watchers_count":2553,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2257,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":301,"forks":2257,"open_issues":301,"watchers":2553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3732"},"html":{"href":"https://github.com/apache/spark/pull/3732"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3732"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3732/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3732/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3732/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/810c8c33582c778f32a381505ff72d858cfdb342"}}}}