{"action":"created","issue":{"url":"https://api.github.com/repos/hadley/testthat/issues/262","labels_url":"https://api.github.com/repos/hadley/testthat/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/hadley/testthat/issues/262/comments","events_url":"https://api.github.com/repos/hadley/testthat/issues/262/events","html_url":"https://github.com/hadley/testthat/pull/262","id":81087290,"number":262,"title":"Handle skipped tests in TAP reporter ","user":{"login":"nealrichardson","id":2975928,"avatar_url":"https://avatars.githubusercontent.com/u/2975928?v=3","gravatar_id":"","url":"https://api.github.com/users/nealrichardson","html_url":"https://github.com/nealrichardson","followers_url":"https://api.github.com/users/nealrichardson/followers","following_url":"https://api.github.com/users/nealrichardson/following{/other_user}","gists_url":"https://api.github.com/users/nealrichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/nealrichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealrichardson/subscriptions","organizations_url":"https://api.github.com/users/nealrichardson/orgs","repos_url":"https://api.github.com/users/nealrichardson/repos","events_url":"https://api.github.com/users/nealrichardson/events{/privacy}","received_events_url":"https://api.github.com/users/nealrichardson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-26T18:46:32Z","updated_at":"2015-09-29T19:16:52Z","closed_at":"2015-09-29T18:41:43Z","pull_request":{"url":"https://api.github.com/repos/hadley/testthat/pulls/262","html_url":"https://github.com/hadley/testthat/pull/262","diff_url":"https://github.com/hadley/testthat/pull/262.diff","patch_url":"https://github.com/hadley/testthat/pull/262.patch"},"body":"Because `skip`ped tests did not have `result$passed`, they were marked as \"not ok\" in the TAP output. Following http://testanything.org/tap-specification.html, I added a skip directive to the output in case of `result$skipped`. \r\n\r\nI'd happily write a test for this change if you could indicate where that should be. I didn't find any tests for the reporter output, only for the existence of reporters. I did confirm that the output with the skip directives is correctly parsed, at least by the Jenkins TAP parser:\r\n\r\n![screen shot 2015-05-26 at 11 35 27 am](https://cloud.githubusercontent.com/assets/2975928/7820260/2ae6815a-039c-11e5-8028-84a92e9b73ee.png)"},"comment":{"url":"https://api.github.com/repos/hadley/testthat/issues/comments/144160611","html_url":"https://github.com/hadley/testthat/pull/262#issuecomment-144160611","issue_url":"https://api.github.com/repos/hadley/testthat/issues/262","id":144160611,"user":{"login":"nealrichardson","id":2975928,"avatar_url":"https://avatars.githubusercontent.com/u/2975928?v=3","gravatar_id":"","url":"https://api.github.com/users/nealrichardson","html_url":"https://github.com/nealrichardson","followers_url":"https://api.github.com/users/nealrichardson/followers","following_url":"https://api.github.com/users/nealrichardson/following{/other_user}","gists_url":"https://api.github.com/users/nealrichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/nealrichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealrichardson/subscriptions","organizations_url":"https://api.github.com/users/nealrichardson/orgs","repos_url":"https://api.github.com/users/nealrichardson/repos","events_url":"https://api.github.com/users/nealrichardson/events{/privacy}","received_events_url":"https://api.github.com/users/nealrichardson/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T19:16:52Z","updated_at":"2015-09-29T19:16:52Z","body":"Ah ok, thanks for pointing that out, will do."}}