{"action":"created","comment":{"url":"https://api.github.com/repos/meteozond/django-permanent/pulls/comments/48160518","id":48160518,"diff_hunk":"@@ -120,6 +116,21 @@ def _unpatch(self):\n             del self.query.where.children[0]\n \n \n+try:\n+    # backward compat for Django < 1.9\n+    from django.db.models.query import ValuesQuerySet\n+\n+    def values(self, *fields):\n+        klass = type('CustomValuesQuerySet', (self.__class__, ValuesQuerySet,), {})\n+        return self._clone(klass=klass, setup=True, _fields=fields)\n+\n+    BasePermanentQuerySet.values = values\n+\n+except ImportError:\n+    # Ignore for Django +1.9","path":"django_permanent/query.py","position":35,"original_position":35,"commit_id":"c931d5f9ea4fadfe986272c157a3f50b649c9d08","original_commit_id":"c931d5f9ea4fadfe986272c157a3f50b649c9d08","user":{"login":"ydaniv","id":116658,"avatar_url":"https://avatars.githubusercontent.com/u/116658?v=3","gravatar_id":"","url":"https://api.github.com/users/ydaniv","html_url":"https://github.com/ydaniv","followers_url":"https://api.github.com/users/ydaniv/followers","following_url":"https://api.github.com/users/ydaniv/following{/other_user}","gists_url":"https://api.github.com/users/ydaniv/gists{/gist_id}","starred_url":"https://api.github.com/users/ydaniv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydaniv/subscriptions","organizations_url":"https://api.github.com/users/ydaniv/orgs","repos_url":"https://api.github.com/users/ydaniv/repos","events_url":"https://api.github.com/users/ydaniv/events{/privacy}","received_events_url":"https://api.github.com/users/ydaniv/received_events","type":"User","site_admin":false},"body":"`ValuesQuerySet` is deprecated in Django 1.9, so just left this here for backward compatibility.","created_at":"2015-12-21T16:12:25Z","updated_at":"2015-12-21T16:12:25Z","html_url":"https://github.com/meteozond/django-permanent/pull/41#discussion_r48160518","pull_request_url":"https://api.github.com/repos/meteozond/django-permanent/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/comments/48160518"},"html":{"href":"https://github.com/meteozond/django-permanent/pull/41#discussion_r48160518"},"pull_request":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/meteozond/django-permanent/pulls/41","id":53531738,"html_url":"https://github.com/meteozond/django-permanent/pull/41","diff_url":"https://github.com/meteozond/django-permanent/pull/41.diff","patch_url":"https://github.com/meteozond/django-permanent/pull/41.patch","issue_url":"https://api.github.com/repos/meteozond/django-permanent/issues/41","number":41,"state":"open","locked":false,"title":"Work in progress on complete Django 1.9 compatibility.","user":{"login":"ydaniv","id":116658,"avatar_url":"https://avatars.githubusercontent.com/u/116658?v=3","gravatar_id":"","url":"https://api.github.com/users/ydaniv","html_url":"https://github.com/ydaniv","followers_url":"https://api.github.com/users/ydaniv/followers","following_url":"https://api.github.com/users/ydaniv/following{/other_user}","gists_url":"https://api.github.com/users/ydaniv/gists{/gist_id}","starred_url":"https://api.github.com/users/ydaniv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydaniv/subscriptions","organizations_url":"https://api.github.com/users/ydaniv/orgs","repos_url":"https://api.github.com/users/ydaniv/repos","events_url":"https://api.github.com/users/ydaniv/events{/privacy}","received_events_url":"https://api.github.com/users/ydaniv/received_events","type":"User","site_admin":false},"body":"Currently there are **3 failing** tests and **1 breaking** (1 skipped).\r\n\r\nAll of these are **related to `PassThroughManager`** which is **dropped** from django-model-utils' in 2.4, which is the first version compatible with Django 1.9.\r\n\r\nI suggest going along the same path and removing support for `PassThroughManager` in the next version.","created_at":"2015-12-14T07:21:45Z","updated_at":"2015-12-21T16:12:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cf73d46f6c61d13ffc68a3addb7e433875f94aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meteozond/django-permanent/pulls/41/commits","review_comments_url":"https://api.github.com/repos/meteozond/django-permanent/pulls/41/comments","review_comment_url":"https://api.github.com/repos/meteozond/django-permanent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteozond/django-permanent/issues/41/comments","statuses_url":"https://api.github.com/repos/meteozond/django-permanent/statuses/c931d5f9ea4fadfe986272c157a3f50b649c9d08","head":{"label":"ydaniv:django19","ref":"django19","sha":"c931d5f9ea4fadfe986272c157a3f50b649c9d08","user":{"login":"ydaniv","id":116658,"avatar_url":"https://avatars.githubusercontent.com/u/116658?v=3","gravatar_id":"","url":"https://api.github.com/users/ydaniv","html_url":"https://github.com/ydaniv","followers_url":"https://api.github.com/users/ydaniv/followers","following_url":"https://api.github.com/users/ydaniv/following{/other_user}","gists_url":"https://api.github.com/users/ydaniv/gists{/gist_id}","starred_url":"https://api.github.com/users/ydaniv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydaniv/subscriptions","organizations_url":"https://api.github.com/users/ydaniv/orgs","repos_url":"https://api.github.com/users/ydaniv/repos","events_url":"https://api.github.com/users/ydaniv/events{/privacy}","received_events_url":"https://api.github.com/users/ydaniv/received_events","type":"User","site_admin":false},"repo":{"id":47911816,"name":"django-permanent","full_name":"ydaniv/django-permanent","owner":{"login":"ydaniv","id":116658,"avatar_url":"https://avatars.githubusercontent.com/u/116658?v=3","gravatar_id":"","url":"https://api.github.com/users/ydaniv","html_url":"https://github.com/ydaniv","followers_url":"https://api.github.com/users/ydaniv/followers","following_url":"https://api.github.com/users/ydaniv/following{/other_user}","gists_url":"https://api.github.com/users/ydaniv/gists{/gist_id}","starred_url":"https://api.github.com/users/ydaniv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydaniv/subscriptions","organizations_url":"https://api.github.com/users/ydaniv/orgs","repos_url":"https://api.github.com/users/ydaniv/repos","events_url":"https://api.github.com/users/ydaniv/events{/privacy}","received_events_url":"https://api.github.com/users/ydaniv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ydaniv/django-permanent","description":"Yet another approach to creation of non-deletable and non-removable from db restorable django models.","fork":true,"url":"https://api.github.com/repos/ydaniv/django-permanent","forks_url":"https://api.github.com/repos/ydaniv/django-permanent/forks","keys_url":"https://api.github.com/repos/ydaniv/django-permanent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ydaniv/django-permanent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ydaniv/django-permanent/teams","hooks_url":"https://api.github.com/repos/ydaniv/django-permanent/hooks","issue_events_url":"https://api.github.com/repos/ydaniv/django-permanent/issues/events{/number}","events_url":"https://api.github.com/repos/ydaniv/django-permanent/events","assignees_url":"https://api.github.com/repos/ydaniv/django-permanent/assignees{/user}","branches_url":"https://api.github.com/repos/ydaniv/django-permanent/branches{/branch}","tags_url":"https://api.github.com/repos/ydaniv/django-permanent/tags","blobs_url":"https://api.github.com/repos/ydaniv/django-permanent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ydaniv/django-permanent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ydaniv/django-permanent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ydaniv/django-permanent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ydaniv/django-permanent/statuses/{sha}","languages_url":"https://api.github.com/repos/ydaniv/django-permanent/languages","stargazers_url":"https://api.github.com/repos/ydaniv/django-permanent/stargazers","contributors_url":"https://api.github.com/repos/ydaniv/django-permanent/contributors","subscribers_url":"https://api.github.com/repos/ydaniv/django-permanent/subscribers","subscription_url":"https://api.github.com/repos/ydaniv/django-permanent/subscription","commits_url":"https://api.github.com/repos/ydaniv/django-permanent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ydaniv/django-permanent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ydaniv/django-permanent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ydaniv/django-permanent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ydaniv/django-permanent/contents/{+path}","compare_url":"https://api.github.com/repos/ydaniv/django-permanent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ydaniv/django-permanent/merges","archive_url":"https://api.github.com/repos/ydaniv/django-permanent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ydaniv/django-permanent/downloads","issues_url":"https://api.github.com/repos/ydaniv/django-permanent/issues{/number}","pulls_url":"https://api.github.com/repos/ydaniv/django-permanent/pulls{/number}","milestones_url":"https://api.github.com/repos/ydaniv/django-permanent/milestones{/number}","notifications_url":"https://api.github.com/repos/ydaniv/django-permanent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ydaniv/django-permanent/labels{/name}","releases_url":"https://api.github.com/repos/ydaniv/django-permanent/releases{/id}","created_at":"2015-12-13T08:38:55Z","updated_at":"2015-12-13T08:38:55Z","pushed_at":"2015-12-14T07:16:13Z","git_url":"git://github.com/ydaniv/django-permanent.git","ssh_url":"git@github.com:ydaniv/django-permanent.git","clone_url":"https://github.com/ydaniv/django-permanent.git","svn_url":"https://github.com/ydaniv/django-permanent","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meteozond:master","ref":"master","sha":"4ad7a0f3be23836f06d4f8b5d814c0a9ecf62273","user":{"login":"meteozond","id":975689,"avatar_url":"https://avatars.githubusercontent.com/u/975689?v=3","gravatar_id":"","url":"https://api.github.com/users/meteozond","html_url":"https://github.com/meteozond","followers_url":"https://api.github.com/users/meteozond/followers","following_url":"https://api.github.com/users/meteozond/following{/other_user}","gists_url":"https://api.github.com/users/meteozond/gists{/gist_id}","starred_url":"https://api.github.com/users/meteozond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteozond/subscriptions","organizations_url":"https://api.github.com/users/meteozond/orgs","repos_url":"https://api.github.com/users/meteozond/repos","events_url":"https://api.github.com/users/meteozond/events{/privacy}","received_events_url":"https://api.github.com/users/meteozond/received_events","type":"User","site_admin":false},"repo":{"id":11811266,"name":"django-permanent","full_name":"meteozond/django-permanent","owner":{"login":"meteozond","id":975689,"avatar_url":"https://avatars.githubusercontent.com/u/975689?v=3","gravatar_id":"","url":"https://api.github.com/users/meteozond","html_url":"https://github.com/meteozond","followers_url":"https://api.github.com/users/meteozond/followers","following_url":"https://api.github.com/users/meteozond/following{/other_user}","gists_url":"https://api.github.com/users/meteozond/gists{/gist_id}","starred_url":"https://api.github.com/users/meteozond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteozond/subscriptions","organizations_url":"https://api.github.com/users/meteozond/orgs","repos_url":"https://api.github.com/users/meteozond/repos","events_url":"https://api.github.com/users/meteozond/events{/privacy}","received_events_url":"https://api.github.com/users/meteozond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meteozond/django-permanent","description":"Yet another approach to creation of non-deletable and non-removable from db restorable django models.","fork":false,"url":"https://api.github.com/repos/meteozond/django-permanent","forks_url":"https://api.github.com/repos/meteozond/django-permanent/forks","keys_url":"https://api.github.com/repos/meteozond/django-permanent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteozond/django-permanent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteozond/django-permanent/teams","hooks_url":"https://api.github.com/repos/meteozond/django-permanent/hooks","issue_events_url":"https://api.github.com/repos/meteozond/django-permanent/issues/events{/number}","events_url":"https://api.github.com/repos/meteozond/django-permanent/events","assignees_url":"https://api.github.com/repos/meteozond/django-permanent/assignees{/user}","branches_url":"https://api.github.com/repos/meteozond/django-permanent/branches{/branch}","tags_url":"https://api.github.com/repos/meteozond/django-permanent/tags","blobs_url":"https://api.github.com/repos/meteozond/django-permanent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteozond/django-permanent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteozond/django-permanent/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteozond/django-permanent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteozond/django-permanent/statuses/{sha}","languages_url":"https://api.github.com/repos/meteozond/django-permanent/languages","stargazers_url":"https://api.github.com/repos/meteozond/django-permanent/stargazers","contributors_url":"https://api.github.com/repos/meteozond/django-permanent/contributors","subscribers_url":"https://api.github.com/repos/meteozond/django-permanent/subscribers","subscription_url":"https://api.github.com/repos/meteozond/django-permanent/subscription","commits_url":"https://api.github.com/repos/meteozond/django-permanent/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteozond/django-permanent/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteozond/django-permanent/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteozond/django-permanent/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteozond/django-permanent/contents/{+path}","compare_url":"https://api.github.com/repos/meteozond/django-permanent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteozond/django-permanent/merges","archive_url":"https://api.github.com/repos/meteozond/django-permanent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteozond/django-permanent/downloads","issues_url":"https://api.github.com/repos/meteozond/django-permanent/issues{/number}","pulls_url":"https://api.github.com/repos/meteozond/django-permanent/pulls{/number}","milestones_url":"https://api.github.com/repos/meteozond/django-permanent/milestones{/number}","notifications_url":"https://api.github.com/repos/meteozond/django-permanent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteozond/django-permanent/labels{/name}","releases_url":"https://api.github.com/repos/meteozond/django-permanent/releases{/id}","created_at":"2013-08-01T07:56:42Z","updated_at":"2015-12-15T00:37:40Z","pushed_at":"2015-12-14T07:21:46Z","git_url":"git://github.com/meteozond/django-permanent.git","ssh_url":"git@github.com:meteozond/django-permanent.git","clone_url":"https://github.com/meteozond/django-permanent.git","svn_url":"https://github.com/meteozond/django-permanent","homepage":null,"size":107,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":12,"forks":8,"open_issues":12,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/41"},"html":{"href":"https://github.com/meteozond/django-permanent/pull/41"},"issue":{"href":"https://api.github.com/repos/meteozond/django-permanent/issues/41"},"comments":{"href":"https://api.github.com/repos/meteozond/django-permanent/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteozond/django-permanent/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/meteozond/django-permanent/statuses/c931d5f9ea4fadfe986272c157a3f50b649c9d08"}}}}