{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/23562429","id":23562429,"diff_hunk":"@@ -6,25 +6,30 @@ use Test::Quattor;\n \n use myIcinga;\n \n-use constant DIR => \"target/test/icinga/dirs\";\n+use Readonly;\n+Readonly my $DIR => \"target/test/icinga/dirs\";\n \n \n my $cmp = NCM::Component::icinga->new('icinga');\n \n-my $t = {\n-\t check_result_path => DIR,\n-\t};\n-\n+$cmp->{ERROR} = 0;\n \n+$cmp->make_dirs({check_result_path => $DIR});\n \n-$cmp->{ERROR} = 0;\n+ok(-d $DIR, \"Directory created\");\n+is($cmp->{ERROR}, 0, \"No realistic errors when creating the directory\");","path":"ncm-icinga/src/test/perl/test-mkdirs.t","position":21,"original_position":21,"commit_id":"073650a2df82944560fd9e2b42db936432f70c1d","original_commit_id":"073650a2df82944560fd9e2b42db936432f70c1d","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"body":"What does mean the error message?","created_at":"2015-01-26T20:42:48Z","updated_at":"2015-01-26T20:42:48Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/411#discussion_r23562429","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/23562429"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/411#discussion_r23562429"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411","id":27682085,"html_url":"https://github.com/quattor/configuration-modules-core/pull/411","diff_url":"https://github.com/quattor/configuration-modules-core/pull/411.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/411.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/411","number":411,"state":"open","locked":false,"title":"Required uniittest fixes for EL7 (and root)","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"These changes are required to pass the unittests on EL7 (some of them are required when running the unittests as root).\r\nPart of the effort of https://github.com/quattor/release/pull/72","created_at":"2015-01-20T14:41:58Z","updated_at":"2015-01-26T20:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63b6eab8e78e7fd1042bb4d2e61f51b3f39ac50f","assignee":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/7","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/7/labels","id":665823,"number":7,"title":"14.12","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":33,"state":"open","created_at":"2014-05-21T14:44:13Z","updated_at":"2015-01-20T14:42:04Z","due_on":"2014-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/411/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/073650a2df82944560fd9e2b42db936432f70c1d","head":{"label":"stdweird:fix_unittests","ref":"fix_unittests","sha":"073650a2df82944560fd9e2b42db936432f70c1d","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":9290244,"name":"configuration-modules-core","full_name":"stdweird/configuration-modules-core","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/configuration-modules-core","description":"Core NCM components for Quattor","fork":true,"url":"https://api.github.com/repos/stdweird/configuration-modules-core","forks_url":"https://api.github.com/repos/stdweird/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/stdweird/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/stdweird/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/stdweird/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/stdweird/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/stdweird/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/stdweird/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/stdweird/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/stdweird/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/stdweird/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/stdweird/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/stdweird/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/configuration-modules-core/releases{/id}","created_at":"2013-04-08T06:47:35Z","updated_at":"2014-12-17T12:40:36Z","pushed_at":"2015-01-20T14:39:42Z","git_url":"git://github.com/stdweird/configuration-modules-core.git","ssh_url":"git@github.com:stdweird/configuration-modules-core.git","clone_url":"https://github.com/stdweird/configuration-modules-core.git","svn_url":"https://github.com/stdweird/configuration-modules-core","homepage":null,"size":8509,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"97c07ede7794045f1abe3d965b1445264b9c3410","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","created_at":"2012-10-31T09:08:07Z","updated_at":"2015-01-12T11:46:21Z","pushed_at":"2015-01-12T11:46:19Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":13031,"stargazers_count":5,"watchers_count":5,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":46,"forks":24,"open_issues":46,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/411"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/411"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/073650a2df82944560fd9e2b42db936432f70c1d"}}}}