{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/16","id":29894905,"html_url":"https://github.com/percona/percona-server/pull/16","diff_url":"https://github.com/percona/percona-server/pull/16.diff","patch_url":"https://github.com/percona/percona-server/pull/16.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/16","number":16,"state":"open","locked":false,"title":"ps_tokudb_admin fixed error reporting and MYSQLD_SAFE my.cnf section (BLD-250)","user":{"login":"tplavcic","id":4625195,"avatar_url":"https://avatars.githubusercontent.com/u/4625195?v=3","gravatar_id":"","url":"https://api.github.com/users/tplavcic","html_url":"https://github.com/tplavcic","followers_url":"https://api.github.com/users/tplavcic/followers","following_url":"https://api.github.com/users/tplavcic/following{/other_user}","gists_url":"https://api.github.com/users/tplavcic/gists{/gist_id}","starred_url":"https://api.github.com/users/tplavcic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tplavcic/subscriptions","organizations_url":"https://api.github.com/users/tplavcic/orgs","repos_url":"https://api.github.com/users/tplavcic/repos","events_url":"https://api.github.com/users/tplavcic/events{/privacy}","received_events_url":"https://api.github.com/users/tplavcic/received_events","type":"User","site_admin":false},"body":"In BLD-250 there's a request to show actual mysql client errors when using ps_tokudb_admin script (it was showing only some generic error before which was misleading) and also to respect if in my.cnf there is a [mysqld_safe] section with all caps so [MYSQLD_SAFE] so this is to fix those two things.\r\n\r\nTesting packages are available here (centos7 build fails for some patch which should work after next upstream merge, so I've included bzr build for rpm packages also):\r\ngit builds:\r\nhttp://jenkins.percona.com/view/Percona-RELEASES/job/percona-server-5.6-redhat-binary/132/\r\nhttp://jenkins.percona.com/view/Percona-RELEASES/job/percona-server-5.6-debian-binary/122/\r\nbzr build for centos7:\r\nhttp://jenkins.percona.com/view/Percona-RELEASES/job/percona-server-5.6-redhat-binary-bzr/4/\r\n\r\nSome testing:\r\n#1: centos6: normal install with changed root pass - error is shown\r\n---------------------------------------------------------------\r\n[vagrant@t-centos6-64 ~]$ sudo ps_tokudb_admin --enable\r\nChecking if Percona server is running with jemalloc enabled...\r\nERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: NO)\r\n>> Error checking pid file location!\r\n\r\n#2: centos6: normal install proper password included\r\n------------------------------------------------\r\n[vagrant@t-centos6-64 ~]$ sudo ps_tokudb_admin --enable -u root -pxxx\r\nScript output:\r\nChecking if Percona server is running with jemalloc enabled...\r\n>> Percona server is running with jemalloc enabled.\r\n\r\nChecking transparent huge pages status on the system...\r\n>> Transparent huge pages are currently disabled on the system.\r\n\r\nChecking if thp-setting=never option is already set in config file...\r\n>> Option thp-setting=never is not set in the config file.\r\n>> (needed only if THP is not disabled permanently on the system)\r\n\r\nChecking TokuDB plugin status...\r\n>> TokuDB plugin is not installed.\r\n\r\nAdding thp-setting=never option into /etc/my.cnf\r\n>> Successfuly added thp-setting=never option into /etc/my.cnf\r\n\r\nInstalling TokuDB engine...\r\n>> Successfuly installed TokuDB plugin.\r\n\r\nmy.cnf output:\r\n[mysqld_safe]\r\nthp-setting=never\r\n\r\nshow plugins output:\r\n| TokuDB                        | ACTIVE   | STORAGE ENGINE     | ha_tokudb.so | GPL     |\r\n| TokuDB_file_map               | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n| TokuDB_fractal_tree_info      | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n| TokuDB_fractal_tree_block_map | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n| TokuDB_trx                    | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n| TokuDB_locks                  | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n| TokuDB_lock_waits             | ACTIVE   | INFORMATION SCHEMA | ha_tokudb.so | GPL     |\r\n\r\n#3: disable plugin\r\n------------------\r\nscript output:\r\n[vagrant@t-centos6-64 ~]$ sudo ps_tokudb_admin --disable -u root -pxxx\r\nChecking if Percona server is running with jemalloc enabled...\r\n>> Percona server is running with jemalloc enabled.\r\n\r\nChecking transparent huge pages status on the system...\r\n>> Transparent huge pages are currently disabled on the system.\r\n\r\nChecking if thp-setting=never option is already set in config file...\r\n>> Option thp-setting=never is set in the config file.\r\n\r\nChecking TokuDB plugin status...\r\n>> TokuDB plugin is installed.\r\n\r\nRemoving thp-setting=never option from /etc/my.cnf\r\n>> Successfuly removed thp-setting=never option from /etc/my.cnf\r\n\r\nUninstalling TokuDB plugin...\r\n>> Successfuly uninstalled TokuDB plugin.\r\n\r\nmy.cnf output:\r\n[mysqld_safe]\r\nlog-error=/var/log/mysqld.log\r\npid-file=/var/run/mysqld/mysqld.pid\r\n\r\n#4: [MYSQLD_SAFE] (all caps) section present in my.cnf\r\n------------------------------------------------------\r\nmy.cnf part before installation:\r\n[MYSQLD_SAFE]\r\nlog-error=/var/log/mysqld.log\r\npid-file=/var/run/mysqld/mysqld.pid\r\n\r\noutput of the script:\r\n[vagrant@t-centos6-64 ~]$ sudo ps_tokudb_admin --enable -u root -pxxx\r\nChecking if Percona server is running with jemalloc enabled...\r\n>> Percona server is running with jemalloc enabled.\r\n\r\nChecking transparent huge pages status on the system...\r\n>> Transparent huge pages are currently disabled on the system.\r\n\r\nChecking if thp-setting=never option is already set in config file...\r\n>> Option thp-setting=never is not set in the config file.\r\n>> (needed only if THP is not disabled permanently on the system)\r\n\r\nChecking TokuDB plugin status...\r\n>> TokuDB plugin is not installed.\r\n\r\nAdding thp-setting=never option into /etc/my.cnf\r\n>> Successfuly added thp-setting=never option into /etc/my.cnf\r\n\r\nInstalling TokuDB engine...\r\n>> Successfuly installed TokuDB plugin.\r\n\r\nmy.cnf part after installation:\r\n[MYSQLD_SAFE]\r\nthp-setting=never\r\nlog-error=/var/log/mysqld.log\r\npid-file=/var/run/mysqld/mysqld.pid\r\n\r\n#5: disable with all caps section in my.cnf\r\n-------------------------------------------\r\nscript output:\r\n[vagrant@t-centos6-64 ~]$ sudo ps_tokudb_admin --disable -u root -pxxx\r\nChecking if Percona server is running with jemalloc enabled...\r\n>> Percona server is running with jemalloc enabled.\r\n\r\nChecking transparent huge pages status on the system...\r\n>> Transparent huge pages are currently disabled on the system.\r\n\r\nChecking if thp-setting=never option is already set in config file...\r\n>> Option thp-setting=never is set in the config file.\r\n\r\nChecking TokuDB plugin status...\r\n>> TokuDB plugin is installed.\r\n\r\nRemoving thp-setting=never option from /etc/my.cnf\r\n>> Successfuly removed thp-setting=never option from /etc/my.cnf\r\n\r\nUninstalling TokuDB plugin...\r\n>> Successfuly uninstalled TokuDB plugin.\r\n\r\nmy.cnf part after disable:\r\n[MYSQLD_SAFE]\r\nlog-error=/var/log/mysqld.log\r\npid-file=/var/run/mysqld/mysqld.pid","created_at":"2015-02-24T12:58:49Z","updated_at":"2015-02-24T12:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/16/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/16/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/16/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/496dc032bfc6b38fa5360164b01756893cbf89b0","head":{"label":"tplavcic:5.6-ps-bld-250","ref":"5.6-ps-bld-250","sha":"496dc032bfc6b38fa5360164b01756893cbf89b0","user":{"login":"tplavcic","id":4625195,"avatar_url":"https://avatars.githubusercontent.com/u/4625195?v=3","gravatar_id":"","url":"https://api.github.com/users/tplavcic","html_url":"https://github.com/tplavcic","followers_url":"https://api.github.com/users/tplavcic/followers","following_url":"https://api.github.com/users/tplavcic/following{/other_user}","gists_url":"https://api.github.com/users/tplavcic/gists{/gist_id}","starred_url":"https://api.github.com/users/tplavcic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tplavcic/subscriptions","organizations_url":"https://api.github.com/users/tplavcic/orgs","repos_url":"https://api.github.com/users/tplavcic/repos","events_url":"https://api.github.com/users/tplavcic/events{/privacy}","received_events_url":"https://api.github.com/users/tplavcic/received_events","type":"User","site_admin":false},"repo":{"id":30916537,"name":"percona-server","full_name":"tplavcic/percona-server","owner":{"login":"tplavcic","id":4625195,"avatar_url":"https://avatars.githubusercontent.com/u/4625195?v=3","gravatar_id":"","url":"https://api.github.com/users/tplavcic","html_url":"https://github.com/tplavcic","followers_url":"https://api.github.com/users/tplavcic/followers","following_url":"https://api.github.com/users/tplavcic/following{/other_user}","gists_url":"https://api.github.com/users/tplavcic/gists{/gist_id}","starred_url":"https://api.github.com/users/tplavcic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tplavcic/subscriptions","organizations_url":"https://api.github.com/users/tplavcic/orgs","repos_url":"https://api.github.com/users/tplavcic/repos","events_url":"https://api.github.com/users/tplavcic/events{/privacy}","received_events_url":"https://api.github.com/users/tplavcic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tplavcic/percona-server","description":"","fork":true,"url":"https://api.github.com/repos/tplavcic/percona-server","forks_url":"https://api.github.com/repos/tplavcic/percona-server/forks","keys_url":"https://api.github.com/repos/tplavcic/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tplavcic/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tplavcic/percona-server/teams","hooks_url":"https://api.github.com/repos/tplavcic/percona-server/hooks","issue_events_url":"https://api.github.com/repos/tplavcic/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/tplavcic/percona-server/events","assignees_url":"https://api.github.com/repos/tplavcic/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/tplavcic/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/tplavcic/percona-server/tags","blobs_url":"https://api.github.com/repos/tplavcic/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tplavcic/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tplavcic/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/tplavcic/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tplavcic/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/tplavcic/percona-server/languages","stargazers_url":"https://api.github.com/repos/tplavcic/percona-server/stargazers","contributors_url":"https://api.github.com/repos/tplavcic/percona-server/contributors","subscribers_url":"https://api.github.com/repos/tplavcic/percona-server/subscribers","subscription_url":"https://api.github.com/repos/tplavcic/percona-server/subscription","commits_url":"https://api.github.com/repos/tplavcic/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/tplavcic/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/tplavcic/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/tplavcic/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/tplavcic/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/tplavcic/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tplavcic/percona-server/merges","archive_url":"https://api.github.com/repos/tplavcic/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tplavcic/percona-server/downloads","issues_url":"https://api.github.com/repos/tplavcic/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/tplavcic/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/tplavcic/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/tplavcic/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tplavcic/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/tplavcic/percona-server/releases{/id}","created_at":"2015-02-17T12:44:07Z","updated_at":"2015-02-23T09:27:09Z","pushed_at":"2015-02-24T10:22:27Z","git_url":"git://github.com/tplavcic/percona-server.git","ssh_url":"git@github.com:tplavcic/percona-server.git","clone_url":"https://github.com/tplavcic/percona-server.git","svn_url":"https://github.com/tplavcic/percona-server","homepage":null,"size":253882,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"e7c574e06c92e75e6f9bafd2966be9f747803107","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","created_at":"2015-02-13T11:32:01Z","updated_at":"2015-02-20T16:19:14Z","pushed_at":"2015-02-23T20:46:01Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":null,"size":255314,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":2,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/16"},"html":{"href":"https://github.com/percona/percona-server/pull/16"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/16"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/496dc032bfc6b38fa5360164b01756893cbf89b0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":18,"changed_files":1}}