{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments/35583798","id":35583798,"diff_hunk":"@@ -11,40 +11,35 @@\n \n     Fieldnames:\n \n-    - maxOrder: maximum order (degree) of the polynomials\n-    - numVars : maximum number of variables\n+    - order:     order (degree) of the polynomials\n+    - num_vars : number of variables\n \n     These parameters can be changed using `set_params_TaylorN(order,numVars)`\n     \"\"\" ->\n type ParamsTaylorN\n-    maxOrder :: Int\n-    numVars  :: Int\n+    order :: Int\n+    num_vars  :: Int\n     variable_names :: Array{UTF8String,1}\n end\n \n+global const _params_TaylorN_ = ParamsTaylorN(6, 2, UTF8String[\"x₁\", \"x₂\"])\n+\n+\n @doc \"\"\"Display the current parameters for `TaylorN` and\n `HomogeneousPolynomial`\"\"\" ->\n function show_params_TaylorN()\n     info( \"\"\"Parameters for `TaylorN` and `HomogeneousPolynomial`:\n-    Maximum order       = $(_params_taylorN.maxOrder)\n-    Number of variables = $(_params_taylorN.numVars)\n-    Variable names      = $(_params_taylorN.variable_names)\n+    Maximum order       = $(_params_TaylorN_.order)","path":"src/hashtables.jl","position":29,"original_position":29,"commit_id":"e3eee7e956d234c17fbc72076a362048ec819f90","original_commit_id":"e3eee7e956d234c17fbc72076a362048ec819f90","user":{"login":"lbenet","id":5237744,"avatar_url":"https://avatars.githubusercontent.com/u/5237744?v=3","gravatar_id":"","url":"https://api.github.com/users/lbenet","html_url":"https://github.com/lbenet","followers_url":"https://api.github.com/users/lbenet/followers","following_url":"https://api.github.com/users/lbenet/following{/other_user}","gists_url":"https://api.github.com/users/lbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbenet/subscriptions","organizations_url":"https://api.github.com/users/lbenet/orgs","repos_url":"https://api.github.com/users/lbenet/repos","events_url":"https://api.github.com/users/lbenet/events{/privacy}","received_events_url":"https://api.github.com/users/lbenet/received_events","type":"User","site_admin":false},"body":"Is it reasonable to use here `get_order()`, `get_numvars()` and `get_variable_names()`?","created_at":"2015-07-27T20:39:55Z","updated_at":"2015-07-27T20:39:55Z","html_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21#discussion_r35583798","pull_request_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments/35583798"},"html":{"href":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21#discussion_r35583798"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21","id":40583947,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21","diff_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21.diff","patch_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21.patch","issue_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/21","number":21,"state":"open","locked":false,"title":"Rename get_maxOrder -> get_order and get_numVars -> get_numvars.","user":{"login":"dpsanders","id":191822,"avatar_url":"https://avatars.githubusercontent.com/u/191822?v=3","gravatar_id":"","url":"https://api.github.com/users/dpsanders","html_url":"https://github.com/dpsanders","followers_url":"https://api.github.com/users/dpsanders/followers","following_url":"https://api.github.com/users/dpsanders/following{/other_user}","gists_url":"https://api.github.com/users/dpsanders/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsanders/subscriptions","organizations_url":"https://api.github.com/users/dpsanders/orgs","repos_url":"https://api.github.com/users/dpsanders/repos","events_url":"https://api.github.com/users/dpsanders/events{/privacy}","received_events_url":"https://api.github.com/users/dpsanders/received_events","type":"User","site_admin":false},"body":"Also replaces direct accesses of fields in `_params_TaylorN_`  with calls to `get_order` and `get_numvars`. \r\n\r\nNote that these calls are inlined and so do not affect performance (checked with the Fateman benchmarks, which I have separated out into a file `fateman.jl` in the new `perf` directory).","created_at":"2015-07-22T16:25:10Z","updated_at":"2015-07-27T20:39:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3e7353e7359bdd7121954308d84fd36e88cdd94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21/commits","review_comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21/comments","review_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/21/comments","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/e3eee7e956d234c17fbc72076a362048ec819f90","head":{"label":"JuliaDiff:renaming","ref":"renaming","sha":"e3eee7e956d234c17fbc72076a362048ec819f90","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","created_at":"2014-03-01T19:43:17Z","updated_at":"2015-06-28T10:20:27Z","pushed_at":"2015-07-26T14:00:25Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":1407,"stargazers_count":4,"watchers_count":4,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"JuliaDiff:master","ref":"master","sha":"dbe2c02d5bb450b6cbe1233952579d57fc680896","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars.githubusercontent.com/u/7750915?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","created_at":"2014-03-01T19:43:17Z","updated_at":"2015-06-28T10:20:27Z","pushed_at":"2015-07-26T14:00:25Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":1407,"stargazers_count":4,"watchers_count":4,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21"},"html":{"href":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/21"},"issue":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/21"},"comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/e3eee7e956d234c17fbc72076a362048ec819f90"}}}}