{"action":"closed","number":381,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/packaging/pulls/381","id":29592900,"html_url":"https://github.com/puppetlabs/packaging/pull/381","diff_url":"https://github.com/puppetlabs/packaging/pull/381.diff","patch_url":"https://github.com/puppetlabs/packaging/pull/381.patch","issue_url":"https://api.github.com/repos/puppetlabs/packaging/issues/381","number":381,"state":"closed","locked":false,"title":"(maint) On ship don't set symlinks immutable","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":" - Windows packages are being built in the AIO pipeline for installation\r\n   during acceptance runs.  However, the pipeline was passing SHA and\r\n   ARCH, but not the `git describe` used to tag the file version.\r\n\r\n   Other platforms use repo configs and are unaffected by this, but\r\n   to be able to find the packages by convention, it was decided that\r\n   symlinks should be used so that an MSI could always be found at\r\n\r\n   `puppet-agent/<SHA>/artifacts/windows/puppet-agent-<ARCH>.msi`\r\n\r\n   This symlink is generated at build time and points to a file that\r\n   contains the complete version string generated from `git describe`.\r\n\r\n   However, this generated a new problem with the :ship rake task,\r\n   since it is now trying to `chattr +i` on symlinks.  The error that\r\n   occurs is:\r\n\r\n   `chattr: Operation not supported while reading flags on <PATH>`\r\n\r\n   To fix this, filter the file set passed to remote_set_immutable to\r\n   exclude symlinks.\r\n\r\n   More details on the addition of symlinks can be found in:\r\n   https://github.com/puppetlabs/puppet/commit/0976d62","created_at":"2015-02-19T08:05:01Z","updated_at":"2015-02-19T19:13:31Z","closed_at":"2015-02-19T19:13:31Z","merged_at":null,"merge_commit_sha":"d14f1363401e8f2ff6d87195ed98c740864b4754","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/packaging/pulls/381/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/packaging/pulls/381/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/packaging/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/packaging/issues/381/comments","statuses_url":"https://api.github.com/repos/puppetlabs/packaging/statuses/e1894318bd983d758b8184f60719b5cf1e8c17cd","head":{"label":"Iristyle:maint/master/dont-set-immutable-on-symlinks","ref":"maint/master/dont-set-immutable-on-symlinks","sha":"e1894318bd983d758b8184f60719b5cf1e8c17cd","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"repo":{"id":31005991,"name":"packaging","full_name":"Iristyle/packaging","owner":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iristyle/packaging","description":"","fork":true,"url":"https://api.github.com/repos/Iristyle/packaging","forks_url":"https://api.github.com/repos/Iristyle/packaging/forks","keys_url":"https://api.github.com/repos/Iristyle/packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iristyle/packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iristyle/packaging/teams","hooks_url":"https://api.github.com/repos/Iristyle/packaging/hooks","issue_events_url":"https://api.github.com/repos/Iristyle/packaging/issues/events{/number}","events_url":"https://api.github.com/repos/Iristyle/packaging/events","assignees_url":"https://api.github.com/repos/Iristyle/packaging/assignees{/user}","branches_url":"https://api.github.com/repos/Iristyle/packaging/branches{/branch}","tags_url":"https://api.github.com/repos/Iristyle/packaging/tags","blobs_url":"https://api.github.com/repos/Iristyle/packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iristyle/packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iristyle/packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iristyle/packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iristyle/packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/Iristyle/packaging/languages","stargazers_url":"https://api.github.com/repos/Iristyle/packaging/stargazers","contributors_url":"https://api.github.com/repos/Iristyle/packaging/contributors","subscribers_url":"https://api.github.com/repos/Iristyle/packaging/subscribers","subscription_url":"https://api.github.com/repos/Iristyle/packaging/subscription","commits_url":"https://api.github.com/repos/Iristyle/packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iristyle/packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iristyle/packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iristyle/packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/Iristyle/packaging/contents/{+path}","compare_url":"https://api.github.com/repos/Iristyle/packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iristyle/packaging/merges","archive_url":"https://api.github.com/repos/Iristyle/packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iristyle/packaging/downloads","issues_url":"https://api.github.com/repos/Iristyle/packaging/issues{/number}","pulls_url":"https://api.github.com/repos/Iristyle/packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/Iristyle/packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/Iristyle/packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iristyle/packaging/labels{/name}","releases_url":"https://api.github.com/repos/Iristyle/packaging/releases{/id}","created_at":"2015-02-19T07:53:01Z","updated_at":"2015-02-19T07:53:02Z","pushed_at":"2015-02-19T08:04:38Z","git_url":"git://github.com/Iristyle/packaging.git","ssh_url":"git@github.com:Iristyle/packaging.git","clone_url":"https://github.com/Iristyle/packaging.git","svn_url":"https://github.com/Iristyle/packaging","homepage":null,"size":3498,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f2ba99b0105080afd0b9ae5c13afa00b6c7681bb","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":5209001,"name":"packaging","full_name":"puppetlabs/packaging","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/packaging","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/packaging","forks_url":"https://api.github.com/repos/puppetlabs/packaging/forks","keys_url":"https://api.github.com/repos/puppetlabs/packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/packaging/teams","hooks_url":"https://api.github.com/repos/puppetlabs/packaging/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/packaging/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/packaging/events","assignees_url":"https://api.github.com/repos/puppetlabs/packaging/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/packaging/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/packaging/tags","blobs_url":"https://api.github.com/repos/puppetlabs/packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/packaging/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/packaging/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/packaging/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/packaging/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/packaging/subscription","commits_url":"https://api.github.com/repos/puppetlabs/packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/packaging/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/packaging/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/packaging/merges","archive_url":"https://api.github.com/repos/puppetlabs/packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/packaging/downloads","issues_url":"https://api.github.com/repos/puppetlabs/packaging/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/packaging/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/packaging/releases{/id}","created_at":"2012-07-27T20:18:19Z","updated_at":"2015-02-19T00:38:30Z","pushed_at":"2015-02-19T00:38:30Z","git_url":"git://github.com/puppetlabs/packaging.git","ssh_url":"git@github.com:puppetlabs/packaging.git","clone_url":"https://github.com/puppetlabs/packaging.git","svn_url":"https://github.com/puppetlabs/packaging","homepage":null,"size":3498,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":1,"forks":40,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/packaging/pulls/381"},"html":{"href":"https://github.com/puppetlabs/packaging/pull/381"},"issue":{"href":"https://api.github.com/repos/puppetlabs/packaging/issues/381"},"comments":{"href":"https://api.github.com/repos/puppetlabs/packaging/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/packaging/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/packaging/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/packaging/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/packaging/statuses/e1894318bd983d758b8184f60719b5cf1e8c17cd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}