{"action":"created","issue":{"url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/2","labels_url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/2/comments","events_url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/2/events","html_url":"https://github.com/netputer/connect-weinre-injector/pull/2","id":51690313,"number":2,"title":"use async script injection","user":{"login":"dwightjack","id":104721,"avatar_url":"https://avatars.githubusercontent.com/u/104721?v=3","gravatar_id":"","url":"https://api.github.com/users/dwightjack","html_url":"https://github.com/dwightjack","followers_url":"https://api.github.com/users/dwightjack/followers","following_url":"https://api.github.com/users/dwightjack/following{/other_user}","gists_url":"https://api.github.com/users/dwightjack/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightjack/subscriptions","organizations_url":"https://api.github.com/users/dwightjack/orgs","repos_url":"https://api.github.com/users/dwightjack/repos","events_url":"https://api.github.com/users/dwightjack/events{/privacy}","received_events_url":"https://api.github.com/users/dwightjack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-12-11T14:08:13Z","updated_at":"2015-02-03T07:18:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netputer/connect-weinre-injector/pulls/2","html_url":"https://github.com/netputer/connect-weinre-injector/pull/2","diff_url":"https://github.com/netputer/connect-weinre-injector/pull/2.diff","patch_url":"https://github.com/netputer/connect-weinre-injector/pull/2.patch"},"body":"With this PR weinre script is injected by dynamically generating it (much like Facebook and Twitter SDKs).\r\n\r\nThis way server host URL is based on browser `location.host` which is more flexible than passing it as an option  (which anyway is used as a fallback)"},"comment":{"url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/comments/72605473","html_url":"https://github.com/netputer/connect-weinre-injector/pull/2#issuecomment-72605473","issue_url":"https://api.github.com/repos/netputer/connect-weinre-injector/issues/2","id":72605473,"user":{"login":"netputer","id":549979,"avatar_url":"https://avatars.githubusercontent.com/u/549979?v=3","gravatar_id":"","url":"https://api.github.com/users/netputer","html_url":"https://github.com/netputer","followers_url":"https://api.github.com/users/netputer/followers","following_url":"https://api.github.com/users/netputer/following{/other_user}","gists_url":"https://api.github.com/users/netputer/gists{/gist_id}","starred_url":"https://api.github.com/users/netputer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netputer/subscriptions","organizations_url":"https://api.github.com/users/netputer/orgs","repos_url":"https://api.github.com/users/netputer/repos","events_url":"https://api.github.com/users/netputer/events{/privacy}","received_events_url":"https://api.github.com/users/netputer/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T07:18:26Z","updated_at":"2015-02-03T07:18:26Z","body":"I don't think using `location.host` instead of `options.host` is a good choice.\r\n\r\nFor our team, we have a common server to run weinre. If using `location.host` we can't access this common server to debug."}}