{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/47687315","id":47687315,"diff_hunk":"@@ -340,44 +340,30 @@ define([\n             this.$('#loginError').hide();\n         },\n         deleteCookie: function() {\n-            $.ajax({\n-                type: \"GET\",\n-                url: '/logout',\n-                async: false\n-            });\n+            document.cookie = \"JSESSIONID=;path=/;domain=;expires=Thu, 01 Jan 1970 00:00:00 GMT;secure\";\n         }\n     });\n \n     Menu.LogoutForm = Marionette.ItemView.extend({\n         template: 'logoutTemplate',\n         events: {\n-            'click .btn-logout': 'logOutUser'\n+            'click .btn-logout': 'logout'\n         },\n-        logOutUser: function() {\n+        logout: function() {\n             //this function is only here to handle clearing basic auth credentials\n             //if you aren't using basic auth, this shouldn't do anything\n-            var logoutBasic = function() {\n-                $.ajax({\n-                    type: \"GET\",\n-                    url: document.URL,\n-                    async: false,\n-                    username: \"1\",\n-                    password: \"1\",\n-                    error: function() {\n-                        document.location.reload();\n-                    },\n-                    success: function() {\n-                        document.location.reload();\n-                    }\n-                });\n-            };\n-\n             $.ajax({\n                 type: \"GET\",\n-                url: '/logout',\n+                url: document.URL,\n                 async: false,\n-                error: logoutBasic,\n-                success: logoutBasic\n+                username: \"1\",\n+                password: \"1\",\n+                error: function() {\n+                    window.location = '/logout';\n+                },\n+                success: function() {\n+                    window.location = '/logout';","path":"catalog/ui/search-ui/standard/src/main/webapp/js/view/Menu.view.js","position":52,"original_position":52,"commit_id":"5d15a11a7749665c3bc6f8895b92ebf8c5d16bb0","original_commit_id":"3bb24f97d875481819f18afdf40afba1a2af5089","user":{"login":"tbatie","id":9013620,"avatar_url":"https://avatars.githubusercontent.com/u/9013620?v=3","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"body":"!fixed","created_at":"2015-12-15T19:41:32Z","updated_at":"2015-12-15T19:41:32Z","html_url":"https://github.com/codice/ddf/pull/390#discussion_r47687315","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/47687315"},"html":{"href":"https://github.com/codice/ddf/pull/390#discussion_r47687315"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/390","id":53704349,"html_url":"https://github.com/codice/ddf/pull/390","diff_url":"https://github.com/codice/ddf/pull/390.diff","patch_url":"https://github.com/codice/ddf/pull/390.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/390","number":390,"state":"open","locked":false,"title":"DDF-1605 - Idp Single Logout","user":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"body":"@stustison @pklinef @codice/green @codice/security ","created_at":"2015-12-15T13:43:51Z","updated_at":"2015-12-15T19:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"739ef1af199223fb8fea187adf119251c7c8c3b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/390/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/390/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/390/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/5d15a11a7749665c3bc6f8895b92ebf8c5d16bb0","head":{"label":"rzwiefel:DDF-1605-Ultimate","ref":"DDF-1605-Ultimate","sha":"5d15a11a7749665c3bc6f8895b92ebf8c5d16bb0","user":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"repo":{"id":37286795,"name":"ddf","full_name":"rzwiefel/ddf","owner":{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars.githubusercontent.com/u/9013416?v=3","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzwiefel/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/rzwiefel/ddf","forks_url":"https://api.github.com/repos/rzwiefel/ddf/forks","keys_url":"https://api.github.com/repos/rzwiefel/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzwiefel/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzwiefel/ddf/teams","hooks_url":"https://api.github.com/repos/rzwiefel/ddf/hooks","issue_events_url":"https://api.github.com/repos/rzwiefel/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/rzwiefel/ddf/events","assignees_url":"https://api.github.com/repos/rzwiefel/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/rzwiefel/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/rzwiefel/ddf/tags","blobs_url":"https://api.github.com/repos/rzwiefel/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzwiefel/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzwiefel/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzwiefel/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzwiefel/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/rzwiefel/ddf/languages","stargazers_url":"https://api.github.com/repos/rzwiefel/ddf/stargazers","contributors_url":"https://api.github.com/repos/rzwiefel/ddf/contributors","subscribers_url":"https://api.github.com/repos/rzwiefel/ddf/subscribers","subscription_url":"https://api.github.com/repos/rzwiefel/ddf/subscription","commits_url":"https://api.github.com/repos/rzwiefel/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzwiefel/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzwiefel/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzwiefel/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzwiefel/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/rzwiefel/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzwiefel/ddf/merges","archive_url":"https://api.github.com/repos/rzwiefel/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzwiefel/ddf/downloads","issues_url":"https://api.github.com/repos/rzwiefel/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/rzwiefel/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/rzwiefel/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/rzwiefel/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzwiefel/ddf/labels{/name}","releases_url":"https://api.github.com/repos/rzwiefel/ddf/releases{/id}","created_at":"2015-06-11T21:19:40Z","updated_at":"2015-06-11T21:19:41Z","pushed_at":"2015-12-15T16:52:52Z","git_url":"git://github.com/rzwiefel/ddf.git","ssh_url":"git@github.com:rzwiefel/ddf.git","clone_url":"https://github.com/rzwiefel/ddf.git","svn_url":"https://github.com/rzwiefel/ddf","homepage":"","size":124879,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"919d0926e3ce3e03af916a1d724312bbc4540ff1","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","created_at":"2013-12-13T20:38:28Z","updated_at":"2015-12-13T06:41:18Z","pushed_at":"2015-12-15T18:42:34Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"","size":131838,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":12,"forks":64,"open_issues":12,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/390"},"html":{"href":"https://github.com/codice/ddf/pull/390"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/390"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/5d15a11a7749665c3bc6f8895b92ebf8c5d16bb0"}}}}