{"comment":{"url":"https://api.github.com/repos/GolovanovSrg/criu/comments/14018947","html_url":"https://github.com/GolovanovSrg/criu/commit/fffe1ee661bcc21cb23e4b780bc59cd41f4b49ee#commitcomment-14018947","id":14018947,"user":{"login":"eabatalov","id":623590,"avatar_url":"https://avatars.githubusercontent.com/u/623590?v=3","gravatar_id":"","url":"https://api.github.com/users/eabatalov","html_url":"https://github.com/eabatalov","followers_url":"https://api.github.com/users/eabatalov/followers","following_url":"https://api.github.com/users/eabatalov/following{/other_user}","gists_url":"https://api.github.com/users/eabatalov/gists{/gist_id}","starred_url":"https://api.github.com/users/eabatalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eabatalov/subscriptions","organizations_url":"https://api.github.com/users/eabatalov/orgs","repos_url":"https://api.github.com/users/eabatalov/repos","events_url":"https://api.github.com/users/eabatalov/events{/privacy}","received_events_url":"https://api.github.com/users/eabatalov/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"fffe1ee661bcc21cb23e4b780bc59cd41f4b49ee","created_at":"2015-10-27T18:04:25Z","updated_at":"2015-10-27T18:04:25Z","body":"This code needs refactoring. But it is not urgent.\r\n\r\nHow it can be refactored:\r\nread input files, convert them to ps_tree_data struct that contains clear settings for the whole process tree configuration. Pass subset of ps_tree_data to child processes.\r\n\r\nps_tree_data {\r\n   ps_config root;\r\n}\r\n\r\nps_data {\r\n   pid_t pid;\r\n   size_t num_threads;\r\n   thread_data *thread_configs;\r\n   size_t num_child_ps;\r\n   ps_date *child_ps_configs;\r\n}\r\n\r\nthread_data {\r\n    pid_t pid;\r\n}\r\n\r\nWe'll discuss it in skype meeting in details."}}