{"action":"created","comment":{"url":"https://api.github.com/repos/go-goose/goose/pulls/comments/27670405","id":27670405,"diff_hunk":"@@ -744,3 +744,41 @@ func (c *Client) AttachVolume(serverId, volumeId, device string) (*VolumeAttachm\n \t}\n \treturn &resp, nil\n }\n+\n+// DetachVolume detaches the volume with the given attachmentId from\n+// the server with the given serverId.\n+func (c *Client) DetachVolume(serverId, attachmentId string) error {\n+\trequestData := goosehttp.RequestData{}\n+\turl := fmt.Sprintf(\"%s/%s/%s/%s\", apiServers, serverId, apiVolumeAttachments, attachmentId)\n+\terr := c.client.SendRequest(client.DELETE, \"compute\", url, &requestData)\n+\tif errors.IsNotFound(err) {","path":"nova/nova.go","position":11,"original_position":11,"commit_id":"a28ab7f29f06ce07ea1c2e067726f31b5fcb86f7","original_commit_id":"a28ab7f29f06ce07ea1c2e067726f31b5fcb86f7","user":{"login":"kat-co","id":5490961,"avatar_url":"https://avatars.githubusercontent.com/u/5490961?v=3","gravatar_id":"","url":"https://api.github.com/users/kat-co","html_url":"https://github.com/kat-co","followers_url":"https://api.github.com/users/kat-co/followers","following_url":"https://api.github.com/users/kat-co/following{/other_user}","gists_url":"https://api.github.com/users/kat-co/gists{/gist_id}","starred_url":"https://api.github.com/users/kat-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kat-co/subscriptions","organizations_url":"https://api.github.com/users/kat-co/orgs","repos_url":"https://api.github.com/users/kat-co/repos","events_url":"https://api.github.com/users/kat-co/events{/privacy}","received_events_url":"https://api.github.com/users/kat-co/received_events","type":"User","site_admin":false},"body":"The endpoint not existing? I don't know how common it is, but it's a definite possibility since this is supported only if the OpenStack instance supports volume extensions.","created_at":"2015-04-02T15:55:07Z","updated_at":"2015-04-02T15:55:07Z","html_url":"https://github.com/go-goose/goose/pull/6#discussion_r27670405","pull_request_url":"https://api.github.com/repos/go-goose/goose/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/go-goose/goose/pulls/comments/27670405"},"html":{"href":"https://github.com/go-goose/goose/pull/6#discussion_r27670405"},"pull_request":{"href":"https://api.github.com/repos/go-goose/goose/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/go-goose/goose/pulls/6","id":32271074,"html_url":"https://github.com/go-goose/goose/pull/6","diff_url":"https://github.com/go-goose/goose/pull/6.diff","patch_url":"https://github.com/go-goose/goose/pull/6.patch","issue_url":"https://api.github.com/repos/go-goose/goose/issues/6","number":6,"state":"open","locked":false,"title":"Added more volume attachment functionality.","user":{"login":"kat-co","id":5490961,"avatar_url":"https://avatars.githubusercontent.com/u/5490961?v=3","gravatar_id":"","url":"https://api.github.com/users/kat-co","html_url":"https://github.com/kat-co","followers_url":"https://api.github.com/users/kat-co/followers","following_url":"https://api.github.com/users/kat-co/following{/other_user}","gists_url":"https://api.github.com/users/kat-co/gists{/gist_id}","starred_url":"https://api.github.com/users/kat-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kat-co/subscriptions","organizations_url":"https://api.github.com/users/kat-co/orgs","repos_url":"https://api.github.com/users/kat-co/repos","events_url":"https://api.github.com/users/kat-co/events{/privacy}","received_events_url":"https://api.github.com/users/kat-co/received_events","type":"User","site_admin":false},"body":"- Listing volume attachments is now supported.\r\n- Detaching volumes is now supported.","created_at":"2015-03-30T21:47:37Z","updated_at":"2015-04-02T15:55:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0d929d1ca3607b87de1de61d037270f2efdd79b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-goose/goose/pulls/6/commits","review_comments_url":"https://api.github.com/repos/go-goose/goose/pulls/6/comments","review_comment_url":"https://api.github.com/repos/go-goose/goose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-goose/goose/issues/6/comments","statuses_url":"https://api.github.com/repos/go-goose/goose/statuses/a28ab7f29f06ce07ea1c2e067726f31b5fcb86f7","head":{"label":"kat-co:more-nova-volume-support","ref":"more-nova-volume-support","sha":"a28ab7f29f06ce07ea1c2e067726f31b5fcb86f7","user":{"login":"kat-co","id":5490961,"avatar_url":"https://avatars.githubusercontent.com/u/5490961?v=3","gravatar_id":"","url":"https://api.github.com/users/kat-co","html_url":"https://github.com/kat-co","followers_url":"https://api.github.com/users/kat-co/followers","following_url":"https://api.github.com/users/kat-co/following{/other_user}","gists_url":"https://api.github.com/users/kat-co/gists{/gist_id}","starred_url":"https://api.github.com/users/kat-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kat-co/subscriptions","organizations_url":"https://api.github.com/users/kat-co/orgs","repos_url":"https://api.github.com/users/kat-co/repos","events_url":"https://api.github.com/users/kat-co/events{/privacy}","received_events_url":"https://api.github.com/users/kat-co/received_events","type":"User","site_admin":false},"repo":{"id":30923977,"name":"goose","full_name":"kat-co/goose","owner":{"login":"kat-co","id":5490961,"avatar_url":"https://avatars.githubusercontent.com/u/5490961?v=3","gravatar_id":"","url":"https://api.github.com/users/kat-co","html_url":"https://github.com/kat-co","followers_url":"https://api.github.com/users/kat-co/followers","following_url":"https://api.github.com/users/kat-co/following{/other_user}","gists_url":"https://api.github.com/users/kat-co/gists{/gist_id}","starred_url":"https://api.github.com/users/kat-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kat-co/subscriptions","organizations_url":"https://api.github.com/users/kat-co/orgs","repos_url":"https://api.github.com/users/kat-co/repos","events_url":"https://api.github.com/users/kat-co/events{/privacy}","received_events_url":"https://api.github.com/users/kat-co/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kat-co/goose","description":"goose (Go OpenStack Exchange) - Go bindings for talking to OpenStack.","fork":true,"url":"https://api.github.com/repos/kat-co/goose","forks_url":"https://api.github.com/repos/kat-co/goose/forks","keys_url":"https://api.github.com/repos/kat-co/goose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kat-co/goose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kat-co/goose/teams","hooks_url":"https://api.github.com/repos/kat-co/goose/hooks","issue_events_url":"https://api.github.com/repos/kat-co/goose/issues/events{/number}","events_url":"https://api.github.com/repos/kat-co/goose/events","assignees_url":"https://api.github.com/repos/kat-co/goose/assignees{/user}","branches_url":"https://api.github.com/repos/kat-co/goose/branches{/branch}","tags_url":"https://api.github.com/repos/kat-co/goose/tags","blobs_url":"https://api.github.com/repos/kat-co/goose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kat-co/goose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kat-co/goose/git/refs{/sha}","trees_url":"https://api.github.com/repos/kat-co/goose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kat-co/goose/statuses/{sha}","languages_url":"https://api.github.com/repos/kat-co/goose/languages","stargazers_url":"https://api.github.com/repos/kat-co/goose/stargazers","contributors_url":"https://api.github.com/repos/kat-co/goose/contributors","subscribers_url":"https://api.github.com/repos/kat-co/goose/subscribers","subscription_url":"https://api.github.com/repos/kat-co/goose/subscription","commits_url":"https://api.github.com/repos/kat-co/goose/commits{/sha}","git_commits_url":"https://api.github.com/repos/kat-co/goose/git/commits{/sha}","comments_url":"https://api.github.com/repos/kat-co/goose/comments{/number}","issue_comment_url":"https://api.github.com/repos/kat-co/goose/issues/comments{/number}","contents_url":"https://api.github.com/repos/kat-co/goose/contents/{+path}","compare_url":"https://api.github.com/repos/kat-co/goose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kat-co/goose/merges","archive_url":"https://api.github.com/repos/kat-co/goose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kat-co/goose/downloads","issues_url":"https://api.github.com/repos/kat-co/goose/issues{/number}","pulls_url":"https://api.github.com/repos/kat-co/goose/pulls{/number}","milestones_url":"https://api.github.com/repos/kat-co/goose/milestones{/number}","notifications_url":"https://api.github.com/repos/kat-co/goose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kat-co/goose/labels{/name}","releases_url":"https://api.github.com/repos/kat-co/goose/releases{/id}","created_at":"2015-02-17T15:49:11Z","updated_at":"2015-03-12T16:29:48Z","pushed_at":"2015-03-30T21:47:21Z","git_url":"git://github.com/kat-co/goose.git","ssh_url":"git@github.com:kat-co/goose.git","clone_url":"https://github.com/kat-co/goose.git","svn_url":"https://github.com/kat-co/goose","homepage":null,"size":2376,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v1"}},"base":{"label":"go-goose:v1","ref":"v1","sha":"ff89212517d2f87ea24d0cb451e7c3a03244627e","user":{"login":"go-goose","id":10880085,"avatar_url":"https://avatars.githubusercontent.com/u/10880085?v=3","gravatar_id":"","url":"https://api.github.com/users/go-goose","html_url":"https://github.com/go-goose","followers_url":"https://api.github.com/users/go-goose/followers","following_url":"https://api.github.com/users/go-goose/following{/other_user}","gists_url":"https://api.github.com/users/go-goose/gists{/gist_id}","starred_url":"https://api.github.com/users/go-goose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-goose/subscriptions","organizations_url":"https://api.github.com/users/go-goose/orgs","repos_url":"https://api.github.com/users/go-goose/repos","events_url":"https://api.github.com/users/go-goose/events{/privacy}","received_events_url":"https://api.github.com/users/go-goose/received_events","type":"Organization","site_admin":false},"repo":{"id":30405075,"name":"goose","full_name":"go-goose/goose","owner":{"login":"go-goose","id":10880085,"avatar_url":"https://avatars.githubusercontent.com/u/10880085?v=3","gravatar_id":"","url":"https://api.github.com/users/go-goose","html_url":"https://github.com/go-goose","followers_url":"https://api.github.com/users/go-goose/followers","following_url":"https://api.github.com/users/go-goose/following{/other_user}","gists_url":"https://api.github.com/users/go-goose/gists{/gist_id}","starred_url":"https://api.github.com/users/go-goose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-goose/subscriptions","organizations_url":"https://api.github.com/users/go-goose/orgs","repos_url":"https://api.github.com/users/go-goose/repos","events_url":"https://api.github.com/users/go-goose/events{/privacy}","received_events_url":"https://api.github.com/users/go-goose/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-goose/goose","description":"goose (Go OpenStack Exchange) - Go bindings for talking to OpenStack.","fork":false,"url":"https://api.github.com/repos/go-goose/goose","forks_url":"https://api.github.com/repos/go-goose/goose/forks","keys_url":"https://api.github.com/repos/go-goose/goose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-goose/goose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-goose/goose/teams","hooks_url":"https://api.github.com/repos/go-goose/goose/hooks","issue_events_url":"https://api.github.com/repos/go-goose/goose/issues/events{/number}","events_url":"https://api.github.com/repos/go-goose/goose/events","assignees_url":"https://api.github.com/repos/go-goose/goose/assignees{/user}","branches_url":"https://api.github.com/repos/go-goose/goose/branches{/branch}","tags_url":"https://api.github.com/repos/go-goose/goose/tags","blobs_url":"https://api.github.com/repos/go-goose/goose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-goose/goose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-goose/goose/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-goose/goose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-goose/goose/statuses/{sha}","languages_url":"https://api.github.com/repos/go-goose/goose/languages","stargazers_url":"https://api.github.com/repos/go-goose/goose/stargazers","contributors_url":"https://api.github.com/repos/go-goose/goose/contributors","subscribers_url":"https://api.github.com/repos/go-goose/goose/subscribers","subscription_url":"https://api.github.com/repos/go-goose/goose/subscription","commits_url":"https://api.github.com/repos/go-goose/goose/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-goose/goose/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-goose/goose/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-goose/goose/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-goose/goose/contents/{+path}","compare_url":"https://api.github.com/repos/go-goose/goose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-goose/goose/merges","archive_url":"https://api.github.com/repos/go-goose/goose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-goose/goose/downloads","issues_url":"https://api.github.com/repos/go-goose/goose/issues{/number}","pulls_url":"https://api.github.com/repos/go-goose/goose/pulls{/number}","milestones_url":"https://api.github.com/repos/go-goose/goose/milestones{/number}","notifications_url":"https://api.github.com/repos/go-goose/goose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-goose/goose/labels{/name}","releases_url":"https://api.github.com/repos/go-goose/goose/releases{/id}","created_at":"2015-02-06T09:32:43Z","updated_at":"2015-03-24T23:29:19Z","pushed_at":"2015-03-30T21:47:37Z","git_url":"git://github.com/go-goose/goose.git","ssh_url":"git@github.com:go-goose/goose.git","clone_url":"https://github.com/go-goose/goose.git","svn_url":"https://github.com/go-goose/goose","homepage":null,"size":2480,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":3,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/go-goose/goose/pulls/6"},"html":{"href":"https://github.com/go-goose/goose/pull/6"},"issue":{"href":"https://api.github.com/repos/go-goose/goose/issues/6"},"comments":{"href":"https://api.github.com/repos/go-goose/goose/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/go-goose/goose/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/go-goose/goose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-goose/goose/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/go-goose/goose/statuses/a28ab7f29f06ce07ea1c2e067726f31b5fcb86f7"}}}}