{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/47717520","id":47717520,"diff_hunk":"@@ -302,7 +302,7 @@ private Result handleTake() {\n         Result result = null;\n         try {\n             result = queue.take();\n-            if (result == poisonPillResult) {\n+            if (result == POISON_PILL_RESULT) {","path":"catalog/core/catalog-core-api-impl/src/main/java/ddf/catalog/operation/impl/QueryResponseImpl.java","position":null,"original_position":23,"commit_id":"a97dcd8382d8c01134a94693e837d560e44f2736","original_commit_id":"3eb2990b30b95cc912d8b62afb5996bb20f3fdb2","user":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"body":"Wow the poisonPillResult has been here awhile. I'm assuming this was a long oversight. So I went ahead and made the change. @pklinef or @stustison do you know if we actually intended it the way it was. ","created_at":"2015-12-15T23:51:30Z","updated_at":"2015-12-15T23:51:30Z","html_url":"https://github.com/codice/ddf/pull/384#discussion_r47717520","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/384","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/47717520"},"html":{"href":"https://github.com/codice/ddf/pull/384#discussion_r47717520"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/384","id":53453307,"html_url":"https://github.com/codice/ddf/pull/384","diff_url":"https://github.com/codice/ddf/pull/384.diff","patch_url":"https://github.com/codice/ddf/pull/384.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/384","number":384,"state":"open","locked":false,"title":"DDF-1707 resolved findbugs issues and activated the findbugs profile","user":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"body":"@kcwire \r\n@lessarderic \r\n@coyotesqrl \r\n@stustison \r\n@pklinef \r\n@jlcsmith \r\n@beyelerb \r\n\r\nInitial findbugs resolutions. Still looking at cleaner solutions, but wanted to get some initial feedback. I suggest reviewers either look through a few examples or areas of interest. I'll comment for feedback on specific issues as well.\r\n\r\nTo investigate any specific issues activate the findbugs profile in the root pom.xml and build the module of interest. A couple of options for each finding: 1) resolve in a cleaner/better way 2) suppress if absolutely necessary\r\n\r\nSome of the common issues:\r\n1) Relying on the default platform encoding\r\n2) Serialization issues \r\n3) Scoping issues (vulnerabilities in what methods were returning)\r\n4) Steams not closed\r\n5) Several auto-boxing/unboxing \r\n6) Inefficient key iteration vs entry iteration\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/codice/ddf/384)\n<!-- Reviewable:end -->\n","created_at":"2015-12-11T22:38:39Z","updated_at":"2015-12-15T23:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc058024ff4ca68950d025c04a20ac87573cf4b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/384/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/384/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/384/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/a97dcd8382d8c01134a94693e837d560e44f2736","head":{"label":"shaundmorris:DDF-1707","ref":"DDF-1707","sha":"a97dcd8382d8c01134a94693e837d560e44f2736","user":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"repo":{"id":18582038,"name":"ddf","full_name":"shaundmorris/ddf","owner":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaundmorris/ddf","description":"The Distributed Data Framework","fork":true,"url":"https://api.github.com/repos/shaundmorris/ddf","forks_url":"https://api.github.com/repos/shaundmorris/ddf/forks","keys_url":"https://api.github.com/repos/shaundmorris/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaundmorris/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaundmorris/ddf/teams","hooks_url":"https://api.github.com/repos/shaundmorris/ddf/hooks","issue_events_url":"https://api.github.com/repos/shaundmorris/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/shaundmorris/ddf/events","assignees_url":"https://api.github.com/repos/shaundmorris/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/shaundmorris/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/shaundmorris/ddf/tags","blobs_url":"https://api.github.com/repos/shaundmorris/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaundmorris/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaundmorris/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaundmorris/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaundmorris/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/shaundmorris/ddf/languages","stargazers_url":"https://api.github.com/repos/shaundmorris/ddf/stargazers","contributors_url":"https://api.github.com/repos/shaundmorris/ddf/contributors","subscribers_url":"https://api.github.com/repos/shaundmorris/ddf/subscribers","subscription_url":"https://api.github.com/repos/shaundmorris/ddf/subscription","commits_url":"https://api.github.com/repos/shaundmorris/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaundmorris/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaundmorris/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaundmorris/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaundmorris/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/shaundmorris/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaundmorris/ddf/merges","archive_url":"https://api.github.com/repos/shaundmorris/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaundmorris/ddf/downloads","issues_url":"https://api.github.com/repos/shaundmorris/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/shaundmorris/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/shaundmorris/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/shaundmorris/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaundmorris/ddf/labels{/name}","releases_url":"https://api.github.com/repos/shaundmorris/ddf/releases{/id}","created_at":"2014-04-09T02:09:20Z","updated_at":"2015-03-12T20:09:39Z","pushed_at":"2015-12-15T23:10:42Z","git_url":"git://github.com/shaundmorris/ddf.git","ssh_url":"git@github.com:shaundmorris/ddf.git","clone_url":"https://github.com/shaundmorris/ddf.git","svn_url":"https://github.com/shaundmorris/ddf","homepage":null,"size":124316,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"c3b68c2e521070c74330ba3553f65e326be63a76","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","created_at":"2013-12-13T20:38:28Z","updated_at":"2015-12-13T06:41:18Z","pushed_at":"2015-12-15T23:15:12Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"","size":132006,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":14,"forks":64,"open_issues":14,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/384"},"html":{"href":"https://github.com/codice/ddf/pull/384"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/384"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/a97dcd8382d8c01134a94693e837d560e44f2736"}}}}