{"action":"created","comment":{"url":"https://api.github.com/repos/kristofa/brave/pulls/comments/25996795","id":25996795,"diff_hunk":"@@ -24,8 +24,10 @@\n   <properties>\n     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\n     <resteasy.version>3.0.8.Final</resteasy.version>\n-    <jetty.version>8.1.9.v20130131</jetty.version>\n-     <spring.version>3.2.2.RELEASE</spring.version>\n+      <jetty.version>8.1.9.v20130131</jetty.version>\n+      <!--<jetty.version>9.3.0.M1</jetty.version>-->\n+     <spring.version>4.0.5.RELEASE</spring.version>\n+          <maven.test.skip>true</maven.test.skip>","path":"brave-resteasy3-spring/pom.xml","position":9,"original_position":9,"commit_id":"b73770a411846176b95d3e3ed62abf82d74cddfd","original_commit_id":"b73770a411846176b95d3e3ed62abf82d74cddfd","user":{"login":"kristofa","id":2221492,"avatar_url":"https://avatars.githubusercontent.com/u/2221492?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofa","html_url":"https://github.com/kristofa","followers_url":"https://api.github.com/users/kristofa/followers","following_url":"https://api.github.com/users/kristofa/following{/other_user}","gists_url":"https://api.github.com/users/kristofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofa/subscriptions","organizations_url":"https://api.github.com/users/kristofa/orgs","repos_url":"https://api.github.com/users/kristofa/repos","events_url":"https://api.github.com/users/kristofa/events{/privacy}","received_events_url":"https://api.github.com/users/kristofa/received_events","type":"User","site_admin":false},"body":"Tests should not be skipped.","created_at":"2015-03-07T15:33:28Z","updated_at":"2015-03-07T15:33:28Z","html_url":"https://github.com/kristofa/brave/pull/67#discussion_r25996795","pull_request_url":"https://api.github.com/repos/kristofa/brave/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/kristofa/brave/pulls/comments/25996795"},"html":{"href":"https://github.com/kristofa/brave/pull/67#discussion_r25996795"},"pull_request":{"href":"https://api.github.com/repos/kristofa/brave/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/kristofa/brave/pulls/67","id":30644970,"html_url":"https://github.com/kristofa/brave/pull/67","diff_url":"https://github.com/kristofa/brave/pull/67.diff","patch_url":"https://github.com/kristofa/brave/pull/67.patch","issue_url":"https://api.github.com/repos/kristofa/brave/issues/67","number":67,"state":"open","locked":false,"title":"Apache CXF interceptors with Spring feature to install, Root request mode","user":{"login":"fedor57","id":9465001,"avatar_url":"https://avatars.githubusercontent.com/u/9465001?v=3","gravatar_id":"","url":"https://api.github.com/users/fedor57","html_url":"https://github.com/fedor57","followers_url":"https://api.github.com/users/fedor57/followers","following_url":"https://api.github.com/users/fedor57/following{/other_user}","gists_url":"https://api.github.com/users/fedor57/gists{/gist_id}","starred_url":"https://api.github.com/users/fedor57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedor57/subscriptions","organizations_url":"https://api.github.com/users/fedor57/orgs","repos_url":"https://api.github.com/users/fedor57/repos","events_url":"https://api.github.com/users/fedor57/events{/privacy}","received_events_url":"https://api.github.com/users/fedor57/received_events","type":"User","site_admin":false},"body":"Hi, Kristofa,\r\n\r\nI have updated the library a bit. Some refactoring, safety plus I have added a Root request mode. The functionality is the following:\r\n- disable server part of CXF interceptors\r\n- automatically create SpanId if it does not exist, so all client calls with go to the same trace tree\r\n- two API methods StartRoot() and DoneRoot() to make sure the root span is correctly formed\r\n\r\nThis is to be used in case current web request is not instrumentated or working from command line utility. I haven't found the same code in Brave. Probably some of the new classes should be moved to brave-client. Please take a look.","created_at":"2015-03-06T13:38:48Z","updated_at":"2015-03-07T15:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17b642a53389d34f089dcdbd04dad69b4375e16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kristofa/brave/pulls/67/commits","review_comments_url":"https://api.github.com/repos/kristofa/brave/pulls/67/comments","review_comment_url":"https://api.github.com/repos/kristofa/brave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kristofa/brave/issues/67/comments","statuses_url":"https://api.github.com/repos/kristofa/brave/statuses/b73770a411846176b95d3e3ed62abf82d74cddfd","head":{"label":"fedor57:fedor-brave-cxf","ref":"fedor-brave-cxf","sha":"b73770a411846176b95d3e3ed62abf82d74cddfd","user":{"login":"fedor57","id":9465001,"avatar_url":"https://avatars.githubusercontent.com/u/9465001?v=3","gravatar_id":"","url":"https://api.github.com/users/fedor57","html_url":"https://github.com/fedor57","followers_url":"https://api.github.com/users/fedor57/followers","following_url":"https://api.github.com/users/fedor57/following{/other_user}","gists_url":"https://api.github.com/users/fedor57/gists{/gist_id}","starred_url":"https://api.github.com/users/fedor57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedor57/subscriptions","organizations_url":"https://api.github.com/users/fedor57/orgs","repos_url":"https://api.github.com/users/fedor57/repos","events_url":"https://api.github.com/users/fedor57/events{/privacy}","received_events_url":"https://api.github.com/users/fedor57/received_events","type":"User","site_admin":false},"repo":{"id":30350929,"name":"brave","full_name":"fedor57/brave","owner":{"login":"fedor57","id":9465001,"avatar_url":"https://avatars.githubusercontent.com/u/9465001?v=3","gravatar_id":"","url":"https://api.github.com/users/fedor57","html_url":"https://github.com/fedor57","followers_url":"https://api.github.com/users/fedor57/followers","following_url":"https://api.github.com/users/fedor57/following{/other_user}","gists_url":"https://api.github.com/users/fedor57/gists{/gist_id}","starred_url":"https://api.github.com/users/fedor57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedor57/subscriptions","organizations_url":"https://api.github.com/users/fedor57/orgs","repos_url":"https://api.github.com/users/fedor57/repos","events_url":"https://api.github.com/users/fedor57/events{/privacy}","received_events_url":"https://api.github.com/users/fedor57/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fedor57/brave","description":"Java distributed tracing implementation compatible with Zipkin.","fork":true,"url":"https://api.github.com/repos/fedor57/brave","forks_url":"https://api.github.com/repos/fedor57/brave/forks","keys_url":"https://api.github.com/repos/fedor57/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedor57/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedor57/brave/teams","hooks_url":"https://api.github.com/repos/fedor57/brave/hooks","issue_events_url":"https://api.github.com/repos/fedor57/brave/issues/events{/number}","events_url":"https://api.github.com/repos/fedor57/brave/events","assignees_url":"https://api.github.com/repos/fedor57/brave/assignees{/user}","branches_url":"https://api.github.com/repos/fedor57/brave/branches{/branch}","tags_url":"https://api.github.com/repos/fedor57/brave/tags","blobs_url":"https://api.github.com/repos/fedor57/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedor57/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedor57/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedor57/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedor57/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/fedor57/brave/languages","stargazers_url":"https://api.github.com/repos/fedor57/brave/stargazers","contributors_url":"https://api.github.com/repos/fedor57/brave/contributors","subscribers_url":"https://api.github.com/repos/fedor57/brave/subscribers","subscription_url":"https://api.github.com/repos/fedor57/brave/subscription","commits_url":"https://api.github.com/repos/fedor57/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedor57/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedor57/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedor57/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedor57/brave/contents/{+path}","compare_url":"https://api.github.com/repos/fedor57/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedor57/brave/merges","archive_url":"https://api.github.com/repos/fedor57/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedor57/brave/downloads","issues_url":"https://api.github.com/repos/fedor57/brave/issues{/number}","pulls_url":"https://api.github.com/repos/fedor57/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/fedor57/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/fedor57/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedor57/brave/labels{/name}","releases_url":"https://api.github.com/repos/fedor57/brave/releases{/id}","created_at":"2015-02-05T10:51:33Z","updated_at":"2015-02-05T10:51:33Z","pushed_at":"2015-03-06T13:28:58Z","git_url":"git://github.com/fedor57/brave.git","ssh_url":"git@github.com:fedor57/brave.git","clone_url":"https://github.com/fedor57/brave.git","svn_url":"https://github.com/fedor57/brave","homepage":"","size":1000,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kristofa:master","ref":"master","sha":"8685e13ad32a75767feb2a9afc8fe1d4cb11318e","user":{"login":"kristofa","id":2221492,"avatar_url":"https://avatars.githubusercontent.com/u/2221492?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofa","html_url":"https://github.com/kristofa","followers_url":"https://api.github.com/users/kristofa/followers","following_url":"https://api.github.com/users/kristofa/following{/other_user}","gists_url":"https://api.github.com/users/kristofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofa/subscriptions","organizations_url":"https://api.github.com/users/kristofa/orgs","repos_url":"https://api.github.com/users/kristofa/repos","events_url":"https://api.github.com/users/kristofa/events{/privacy}","received_events_url":"https://api.github.com/users/kristofa/received_events","type":"User","site_admin":false},"repo":{"id":9278888,"name":"brave","full_name":"kristofa/brave","owner":{"login":"kristofa","id":2221492,"avatar_url":"https://avatars.githubusercontent.com/u/2221492?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofa","html_url":"https://github.com/kristofa","followers_url":"https://api.github.com/users/kristofa/followers","following_url":"https://api.github.com/users/kristofa/following{/other_user}","gists_url":"https://api.github.com/users/kristofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofa/subscriptions","organizations_url":"https://api.github.com/users/kristofa/orgs","repos_url":"https://api.github.com/users/kristofa/repos","events_url":"https://api.github.com/users/kristofa/events{/privacy}","received_events_url":"https://api.github.com/users/kristofa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kristofa/brave","description":"Java distributed tracing implementation compatible with Zipkin.","fork":false,"url":"https://api.github.com/repos/kristofa/brave","forks_url":"https://api.github.com/repos/kristofa/brave/forks","keys_url":"https://api.github.com/repos/kristofa/brave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kristofa/brave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kristofa/brave/teams","hooks_url":"https://api.github.com/repos/kristofa/brave/hooks","issue_events_url":"https://api.github.com/repos/kristofa/brave/issues/events{/number}","events_url":"https://api.github.com/repos/kristofa/brave/events","assignees_url":"https://api.github.com/repos/kristofa/brave/assignees{/user}","branches_url":"https://api.github.com/repos/kristofa/brave/branches{/branch}","tags_url":"https://api.github.com/repos/kristofa/brave/tags","blobs_url":"https://api.github.com/repos/kristofa/brave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kristofa/brave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kristofa/brave/git/refs{/sha}","trees_url":"https://api.github.com/repos/kristofa/brave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kristofa/brave/statuses/{sha}","languages_url":"https://api.github.com/repos/kristofa/brave/languages","stargazers_url":"https://api.github.com/repos/kristofa/brave/stargazers","contributors_url":"https://api.github.com/repos/kristofa/brave/contributors","subscribers_url":"https://api.github.com/repos/kristofa/brave/subscribers","subscription_url":"https://api.github.com/repos/kristofa/brave/subscription","commits_url":"https://api.github.com/repos/kristofa/brave/commits{/sha}","git_commits_url":"https://api.github.com/repos/kristofa/brave/git/commits{/sha}","comments_url":"https://api.github.com/repos/kristofa/brave/comments{/number}","issue_comment_url":"https://api.github.com/repos/kristofa/brave/issues/comments{/number}","contents_url":"https://api.github.com/repos/kristofa/brave/contents/{+path}","compare_url":"https://api.github.com/repos/kristofa/brave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kristofa/brave/merges","archive_url":"https://api.github.com/repos/kristofa/brave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kristofa/brave/downloads","issues_url":"https://api.github.com/repos/kristofa/brave/issues{/number}","pulls_url":"https://api.github.com/repos/kristofa/brave/pulls{/number}","milestones_url":"https://api.github.com/repos/kristofa/brave/milestones{/number}","notifications_url":"https://api.github.com/repos/kristofa/brave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kristofa/brave/labels{/name}","releases_url":"https://api.github.com/repos/kristofa/brave/releases{/id}","created_at":"2013-04-07T15:48:18Z","updated_at":"2015-03-06T20:11:08Z","pushed_at":"2015-02-24T20:31:17Z","git_url":"git://github.com/kristofa/brave.git","ssh_url":"git@github.com:kristofa/brave.git","clone_url":"https://github.com/kristofa/brave.git","svn_url":"https://github.com/kristofa/brave","homepage":"","size":3047,"stargazers_count":192,"watchers_count":192,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":8,"forks":78,"open_issues":8,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kristofa/brave/pulls/67"},"html":{"href":"https://github.com/kristofa/brave/pull/67"},"issue":{"href":"https://api.github.com/repos/kristofa/brave/issues/67"},"comments":{"href":"https://api.github.com/repos/kristofa/brave/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/kristofa/brave/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/kristofa/brave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kristofa/brave/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/kristofa/brave/statuses/b73770a411846176b95d3e3ed62abf82d74cddfd"}}}}