{"action":"created","comment":{"url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/comments/48175898","id":48175898,"diff_hunk":"@@ -660,10 +663,10 @@ public static void setProperty(ConfigurationManager cm, String componentName, St\n                 ps.setBoolean(propName, Boolean.valueOf(propValue));\n                 break;\n             case DOUBLE:\n-                ps.setDouble(propName, new Double(propValue));","path":"sphinx4-core/src/main/java/edu/cmu/sphinx/util/props/ConfigurationManagerUtils.java","position":23,"original_position":23,"commit_id":"8f610af6a777d5e5e9bb447fbcbcbc67f7a48e50","original_commit_id":"8f610af6a777d5e5e9bb447fbcbcbc67f7a48e50","user":{"login":"mbait","id":160226,"avatar_url":"https://avatars.githubusercontent.com/u/160226?v=3","gravatar_id":"","url":"https://api.github.com/users/mbait","html_url":"https://github.com/mbait","followers_url":"https://api.github.com/users/mbait/followers","following_url":"https://api.github.com/users/mbait/following{/other_user}","gists_url":"https://api.github.com/users/mbait/gists{/gist_id}","starred_url":"https://api.github.com/users/mbait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbait/subscriptions","organizations_url":"https://api.github.com/users/mbait/orgs","repos_url":"https://api.github.com/users/mbait/repos","events_url":"https://api.github.com/users/mbait/events{/privacy}","received_events_url":"https://api.github.com/users/mbait/received_events","type":"User","site_admin":false},"body":"Can you explain this change? `new Double` creates an object and `Double#parseDouble()` a primitive which is preferable.","created_at":"2015-12-21T18:41:39Z","updated_at":"2015-12-21T18:41:39Z","html_url":"https://github.com/cmusphinx/sphinx4/pull/47#discussion_r48175898","pull_request_url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/comments/48175898"},"html":{"href":"https://github.com/cmusphinx/sphinx4/pull/47#discussion_r48175898"},"pull_request":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47","id":54234746,"html_url":"https://github.com/cmusphinx/sphinx4/pull/47","diff_url":"https://github.com/cmusphinx/sphinx4/pull/47.diff","patch_url":"https://github.com/cmusphinx/sphinx4/pull/47.patch","issue_url":"https://api.github.com/repos/cmusphinx/sphinx4/issues/47","number":47,"state":"open","locked":false,"title":"Fixed 8 important bugs and two dozen minor bugs from findbugs","user":{"login":"DrDub","id":315403,"avatar_url":"https://avatars.githubusercontent.com/u/315403?v=3","gravatar_id":"","url":"https://api.github.com/users/DrDub","html_url":"https://github.com/DrDub","followers_url":"https://api.github.com/users/DrDub/followers","following_url":"https://api.github.com/users/DrDub/following{/other_user}","gists_url":"https://api.github.com/users/DrDub/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDub/subscriptions","organizations_url":"https://api.github.com/users/DrDub/orgs","repos_url":"https://api.github.com/users/DrDub/repos","events_url":"https://api.github.com/users/DrDub/events{/privacy}","received_events_url":"https://api.github.com/users/DrDub/received_events","type":"User","site_admin":false},"body":"The details of the bugs fixed are in the commit log.\r\n\r\nFindbugs was executed in the sphinx4-core folder after a successful gradle build as follows:\r\n\r\nsphinx4-core$ findbugs -textui -auxclasspath ~/.m2/repository/org/apache/commons/commons-math3/3.2/commons-math3-3.2.jar  -sortByClass -high build/classes/main\r\n\r\nThere are still close to 100 \"relying in default encoding\" bugs. That might affect people running sphinx4 in environments where UTF-8 is not the default encoding.\r\n","created_at":"2015-12-21T09:17:39Z","updated_at":"2015-12-21T18:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"866b791ee1d9f43dfb212daeef8c72cc63dde020","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47/commits","review_comments_url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47/comments","review_comment_url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmusphinx/sphinx4/issues/47/comments","statuses_url":"https://api.github.com/repos/cmusphinx/sphinx4/statuses/8f610af6a777d5e5e9bb447fbcbcbc67f7a48e50","head":{"label":"DrDub:master","ref":"master","sha":"8f610af6a777d5e5e9bb447fbcbcbc67f7a48e50","user":{"login":"DrDub","id":315403,"avatar_url":"https://avatars.githubusercontent.com/u/315403?v=3","gravatar_id":"","url":"https://api.github.com/users/DrDub","html_url":"https://github.com/DrDub","followers_url":"https://api.github.com/users/DrDub/followers","following_url":"https://api.github.com/users/DrDub/following{/other_user}","gists_url":"https://api.github.com/users/DrDub/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDub/subscriptions","organizations_url":"https://api.github.com/users/DrDub/orgs","repos_url":"https://api.github.com/users/DrDub/repos","events_url":"https://api.github.com/users/DrDub/events{/privacy}","received_events_url":"https://api.github.com/users/DrDub/received_events","type":"User","site_admin":false},"repo":{"id":48361437,"name":"sphinx4","full_name":"DrDub/sphinx4","owner":{"login":"DrDub","id":315403,"avatar_url":"https://avatars.githubusercontent.com/u/315403?v=3","gravatar_id":"","url":"https://api.github.com/users/DrDub","html_url":"https://github.com/DrDub","followers_url":"https://api.github.com/users/DrDub/followers","following_url":"https://api.github.com/users/DrDub/following{/other_user}","gists_url":"https://api.github.com/users/DrDub/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDub/subscriptions","organizations_url":"https://api.github.com/users/DrDub/orgs","repos_url":"https://api.github.com/users/DrDub/repos","events_url":"https://api.github.com/users/DrDub/events{/privacy}","received_events_url":"https://api.github.com/users/DrDub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrDub/sphinx4","description":"Pure Java speech recognition library","fork":true,"url":"https://api.github.com/repos/DrDub/sphinx4","forks_url":"https://api.github.com/repos/DrDub/sphinx4/forks","keys_url":"https://api.github.com/repos/DrDub/sphinx4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrDub/sphinx4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrDub/sphinx4/teams","hooks_url":"https://api.github.com/repos/DrDub/sphinx4/hooks","issue_events_url":"https://api.github.com/repos/DrDub/sphinx4/issues/events{/number}","events_url":"https://api.github.com/repos/DrDub/sphinx4/events","assignees_url":"https://api.github.com/repos/DrDub/sphinx4/assignees{/user}","branches_url":"https://api.github.com/repos/DrDub/sphinx4/branches{/branch}","tags_url":"https://api.github.com/repos/DrDub/sphinx4/tags","blobs_url":"https://api.github.com/repos/DrDub/sphinx4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrDub/sphinx4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrDub/sphinx4/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrDub/sphinx4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrDub/sphinx4/statuses/{sha}","languages_url":"https://api.github.com/repos/DrDub/sphinx4/languages","stargazers_url":"https://api.github.com/repos/DrDub/sphinx4/stargazers","contributors_url":"https://api.github.com/repos/DrDub/sphinx4/contributors","subscribers_url":"https://api.github.com/repos/DrDub/sphinx4/subscribers","subscription_url":"https://api.github.com/repos/DrDub/sphinx4/subscription","commits_url":"https://api.github.com/repos/DrDub/sphinx4/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrDub/sphinx4/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrDub/sphinx4/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrDub/sphinx4/issues/comments{/number}","contents_url":"https://api.github.com/repos/DrDub/sphinx4/contents/{+path}","compare_url":"https://api.github.com/repos/DrDub/sphinx4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrDub/sphinx4/merges","archive_url":"https://api.github.com/repos/DrDub/sphinx4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrDub/sphinx4/downloads","issues_url":"https://api.github.com/repos/DrDub/sphinx4/issues{/number}","pulls_url":"https://api.github.com/repos/DrDub/sphinx4/pulls{/number}","milestones_url":"https://api.github.com/repos/DrDub/sphinx4/milestones{/number}","notifications_url":"https://api.github.com/repos/DrDub/sphinx4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrDub/sphinx4/labels{/name}","releases_url":"https://api.github.com/repos/DrDub/sphinx4/releases{/id}","created_at":"2015-12-21T08:58:44Z","updated_at":"2015-12-21T08:58:50Z","pushed_at":"2015-12-21T09:13:03Z","git_url":"git://github.com/DrDub/sphinx4.git","ssh_url":"git@github.com:DrDub/sphinx4.git","clone_url":"https://github.com/DrDub/sphinx4.git","svn_url":"https://github.com/DrDub/sphinx4","homepage":"cmusphinx.sourceforge.net","size":154801,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmusphinx:master","ref":"master","sha":"b75b7223cc79211b6530ce9eadbc905d9d7c06b2","user":{"login":"cmusphinx","id":7203378,"avatar_url":"https://avatars.githubusercontent.com/u/7203378?v=3","gravatar_id":"","url":"https://api.github.com/users/cmusphinx","html_url":"https://github.com/cmusphinx","followers_url":"https://api.github.com/users/cmusphinx/followers","following_url":"https://api.github.com/users/cmusphinx/following{/other_user}","gists_url":"https://api.github.com/users/cmusphinx/gists{/gist_id}","starred_url":"https://api.github.com/users/cmusphinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmusphinx/subscriptions","organizations_url":"https://api.github.com/users/cmusphinx/orgs","repos_url":"https://api.github.com/users/cmusphinx/repos","events_url":"https://api.github.com/users/cmusphinx/events{/privacy}","received_events_url":"https://api.github.com/users/cmusphinx/received_events","type":"Organization","site_admin":false},"repo":{"id":18512985,"name":"sphinx4","full_name":"cmusphinx/sphinx4","owner":{"login":"cmusphinx","id":7203378,"avatar_url":"https://avatars.githubusercontent.com/u/7203378?v=3","gravatar_id":"","url":"https://api.github.com/users/cmusphinx","html_url":"https://github.com/cmusphinx","followers_url":"https://api.github.com/users/cmusphinx/followers","following_url":"https://api.github.com/users/cmusphinx/following{/other_user}","gists_url":"https://api.github.com/users/cmusphinx/gists{/gist_id}","starred_url":"https://api.github.com/users/cmusphinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmusphinx/subscriptions","organizations_url":"https://api.github.com/users/cmusphinx/orgs","repos_url":"https://api.github.com/users/cmusphinx/repos","events_url":"https://api.github.com/users/cmusphinx/events{/privacy}","received_events_url":"https://api.github.com/users/cmusphinx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmusphinx/sphinx4","description":"Pure Java speech recognition library","fork":false,"url":"https://api.github.com/repos/cmusphinx/sphinx4","forks_url":"https://api.github.com/repos/cmusphinx/sphinx4/forks","keys_url":"https://api.github.com/repos/cmusphinx/sphinx4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmusphinx/sphinx4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmusphinx/sphinx4/teams","hooks_url":"https://api.github.com/repos/cmusphinx/sphinx4/hooks","issue_events_url":"https://api.github.com/repos/cmusphinx/sphinx4/issues/events{/number}","events_url":"https://api.github.com/repos/cmusphinx/sphinx4/events","assignees_url":"https://api.github.com/repos/cmusphinx/sphinx4/assignees{/user}","branches_url":"https://api.github.com/repos/cmusphinx/sphinx4/branches{/branch}","tags_url":"https://api.github.com/repos/cmusphinx/sphinx4/tags","blobs_url":"https://api.github.com/repos/cmusphinx/sphinx4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmusphinx/sphinx4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmusphinx/sphinx4/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmusphinx/sphinx4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmusphinx/sphinx4/statuses/{sha}","languages_url":"https://api.github.com/repos/cmusphinx/sphinx4/languages","stargazers_url":"https://api.github.com/repos/cmusphinx/sphinx4/stargazers","contributors_url":"https://api.github.com/repos/cmusphinx/sphinx4/contributors","subscribers_url":"https://api.github.com/repos/cmusphinx/sphinx4/subscribers","subscription_url":"https://api.github.com/repos/cmusphinx/sphinx4/subscription","commits_url":"https://api.github.com/repos/cmusphinx/sphinx4/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmusphinx/sphinx4/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmusphinx/sphinx4/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmusphinx/sphinx4/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmusphinx/sphinx4/contents/{+path}","compare_url":"https://api.github.com/repos/cmusphinx/sphinx4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmusphinx/sphinx4/merges","archive_url":"https://api.github.com/repos/cmusphinx/sphinx4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmusphinx/sphinx4/downloads","issues_url":"https://api.github.com/repos/cmusphinx/sphinx4/issues{/number}","pulls_url":"https://api.github.com/repos/cmusphinx/sphinx4/pulls{/number}","milestones_url":"https://api.github.com/repos/cmusphinx/sphinx4/milestones{/number}","notifications_url":"https://api.github.com/repos/cmusphinx/sphinx4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmusphinx/sphinx4/labels{/name}","releases_url":"https://api.github.com/repos/cmusphinx/sphinx4/releases{/id}","created_at":"2014-04-07T10:09:02Z","updated_at":"2015-12-15T05:39:32Z","pushed_at":"2015-12-21T09:17:39Z","git_url":"git://github.com/cmusphinx/sphinx4.git","ssh_url":"git@github.com:cmusphinx/sphinx4.git","clone_url":"https://github.com/cmusphinx/sphinx4.git","svn_url":"https://github.com/cmusphinx/sphinx4","homepage":"cmusphinx.sourceforge.net","size":235576,"stargazers_count":344,"watchers_count":344,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":10,"forks":183,"open_issues":10,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47"},"html":{"href":"https://github.com/cmusphinx/sphinx4/pull/47"},"issue":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/issues/47"},"comments":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/cmusphinx/sphinx4/statuses/8f610af6a777d5e5e9bb447fbcbcbc67f7a48e50"}}}}