{"action":"created","issue":{"url":"https://api.github.com/repos/jashkenas/backbone/issues/3515","labels_url":"https://api.github.com/repos/jashkenas/backbone/issues/3515/labels{/name}","comments_url":"https://api.github.com/repos/jashkenas/backbone/issues/3515/comments","events_url":"https://api.github.com/repos/jashkenas/backbone/issues/3515/events","html_url":"https://github.com/jashkenas/backbone/pull/3515","id":58680119,"number":3515,"title":"#3345 - move attribute comparisons into their own method on the model","user":{"login":"cbroome","id":521476,"avatar_url":"https://avatars.githubusercontent.com/u/521476?v=3","gravatar_id":"","url":"https://api.github.com/users/cbroome","html_url":"https://github.com/cbroome","followers_url":"https://api.github.com/users/cbroome/followers","following_url":"https://api.github.com/users/cbroome/following{/other_user}","gists_url":"https://api.github.com/users/cbroome/gists{/gist_id}","starred_url":"https://api.github.com/users/cbroome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbroome/subscriptions","organizations_url":"https://api.github.com/users/cbroome/orgs","repos_url":"https://api.github.com/users/cbroome/repos","events_url":"https://api.github.com/users/cbroome/events{/privacy}","received_events_url":"https://api.github.com/users/cbroome/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jashkenas/backbone/labels/enhancement","name":"enhancement","color":"61b1e6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-24T01:28:26Z","updated_at":"2015-02-26T18:14:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/3515","html_url":"https://github.com/jashkenas/backbone/pull/3515","diff_url":"https://github.com/jashkenas/backbone/pull/3515.diff","patch_url":"https://github.com/jashkenas/backbone/pull/3515.patch"},"body":"This should allow models to provide custom logic to compare atributes. For a set, each attribute will still be compared to every other attribute between the two models. I'm not going to try to change that behavior. This should be enough wiggle room to allow for more powerful comparisons.\r\n\r\nI don't know about naming conventions but `attributesAreEqual` does not appear in any Backbone projects on Github. I'm not wedded to the name.\r\n\r\nAlso, I wasn't able to get the tests to work on Firefox without moving jQuery to the top of the stack. "},"comment":{"url":"https://api.github.com/repos/jashkenas/backbone/issues/comments/76232868","html_url":"https://github.com/jashkenas/backbone/pull/3515#issuecomment-76232868","issue_url":"https://api.github.com/repos/jashkenas/backbone/issues/3515","id":76232868,"user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T18:14:13Z","updated_at":"2015-02-26T18:14:13Z","body":"> This should be enough wiggle room to allow for more powerful comparisons.\r\n\r\nMore powerful comparisons like what? When and how would this be useful? Why is doing it in this way a better idea than overriding _.isEqual in your project?"}}