{"action":"closed","number":404,"pull_request":{"url":"https://api.github.com/repos/atom/settings-view/pulls/404","id":30349476,"html_url":"https://github.com/atom/settings-view/pull/404","diff_url":"https://github.com/atom/settings-view/pull/404.diff","patch_url":"https://github.com/atom/settings-view/pull/404.patch","issue_url":"https://api.github.com/repos/atom/settings-view/issues/404","number":404,"state":"closed","locked":false,"title":"Variable font size","user":{"login":"simurai","id":378023,"avatar_url":"https://avatars.githubusercontent.com/u/378023?v=3","gravatar_id":"","url":"https://api.github.com/users/simurai","html_url":"https://github.com/simurai","followers_url":"https://api.github.com/users/simurai/followers","following_url":"https://api.github.com/users/simurai/following{/other_user}","gists_url":"https://api.github.com/users/simurai/gists{/gist_id}","starred_url":"https://api.github.com/users/simurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simurai/subscriptions","organizations_url":"https://api.github.com/users/simurai/orgs","repos_url":"https://api.github.com/users/simurai/repos","events_url":"https://api.github.com/users/simurai/events{/privacy}","received_events_url":"https://api.github.com/users/simurai/received_events","type":"User","site_admin":false},"body":":warning: Don't merge yet. These changes are done on top of #373. Wait until that PR gets merged first.\r\n\r\nThis PR changes the `font-size` to `em`s. It makes it easier to change most font sizes by only selecting `.settings-view` instead of having to override lots of individual elements.\r\n\r\nFixes: https://github.com/atom/atom/issues/4342\r\n\r\nBefore:\r\n\r\n![screen shot 2015-03-03 at 3 16 03 pm](https://cloud.githubusercontent.com/assets/378023/6457366/4dcdfe4e-c1b8-11e4-8226-b7b09f7cdb72.png)\r\n\r\nAfter:\r\n\r\n![screen shot 2015-03-03 at 3 01 16 pm](https://cloud.githubusercontent.com/assets/378023/6457371/57d28a7c-c1b8-11e4-9804-679752271061.png)\r\n\r\nCustomized with:\r\n\r\n```css\r\n.settings-view { font-size: 13px; }\r\n```\r\n\r\n![screen shot 2015-03-03 at 3 01 32 pm](https://cloud.githubusercontent.com/assets/378023/6457379/7009afc6-c1b8-11e4-8543-6676dab4070d.png)\r\n\r\n\r\n__Note:__ Not everything can be changes with just the `.settings-view` selector. Controls or buttons still have a fixed px size.\r\n","created_at":"2015-03-03T06:22:15Z","updated_at":"2015-03-05T01:28:04Z","closed_at":"2015-03-05T01:28:04Z","merged_at":"2015-03-05T01:28:04Z","merge_commit_sha":"4f1251d61acc6af3aa4e5b1a3adb592ced2eed89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/settings-view/pulls/404/commits","review_comments_url":"https://api.github.com/repos/atom/settings-view/pulls/404/comments","review_comment_url":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/404/comments","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/00d7d44800900888a3711ae75cd9ed939cd82190","head":{"label":"atom:sm-font-size","ref":"sm-font-size","sha":"00d7d44800900888a3711ae75cd9ed939cd82190","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","created_at":"2013-08-13T19:16:23Z","updated_at":"2015-03-04T20:26:22Z","pushed_at":"2015-03-05T01:28:04Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":3798,"stargazers_count":40,"watchers_count":40,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":83,"forks":44,"open_issues":83,"watchers":40,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"251c7495374ba5604f884793676eed415247dbca","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","created_at":"2013-08-13T19:16:23Z","updated_at":"2015-03-04T20:26:22Z","pushed_at":"2015-03-05T01:28:04Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":3798,"stargazers_count":40,"watchers_count":40,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":83,"forks":44,"open_issues":83,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/settings-view/pulls/404"},"html":{"href":"https://github.com/atom/settings-view/pull/404"},"issue":{"href":"https://api.github.com/repos/atom/settings-view/issues/404"},"comments":{"href":"https://api.github.com/repos/atom/settings-view/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/settings-view/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/settings-view/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/atom/settings-view/statuses/00d7d44800900888a3711ae75cd9ed939cd82190"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"simurai","id":378023,"avatar_url":"https://avatars.githubusercontent.com/u/378023?v=3","gravatar_id":"","url":"https://api.github.com/users/simurai","html_url":"https://github.com/simurai","followers_url":"https://api.github.com/users/simurai/followers","following_url":"https://api.github.com/users/simurai/following{/other_user}","gists_url":"https://api.github.com/users/simurai/gists{/gist_id}","starred_url":"https://api.github.com/users/simurai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simurai/subscriptions","organizations_url":"https://api.github.com/users/simurai/orgs","repos_url":"https://api.github.com/users/simurai/repos","events_url":"https://api.github.com/users/simurai/events{/privacy}","received_events_url":"https://api.github.com/users/simurai/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":19,"deletions":38,"changed_files":3}}