{"action":"created","comment":{"url":"https://api.github.com/repos/ChandraCXC/iris/pulls/comments/43384326","id":43384326,"diff_hunk":"@@ -0,0 +1,8 @@\n+package cfa.vo.iris.utils;\n+\n+/**\n+ * Created by olaurino on 10/28/15.\n+ */\n+public class UTYPEs {","path":"iris-common/src/main/java/cfa/vo/iris/utils/UTYPEs.java","position":6,"original_position":6,"commit_id":"fa3199971a0c378124b541c13a35c1f56abf8253","original_commit_id":"fa3199971a0c378124b541c13a35c1f56abf8253","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-10-29T13:35:22Z","updated_at":"2015-10-29T13:35:22Z","html_url":"https://github.com/ChandraCXC/iris/pull/168#discussion_r43384326","pull_request_url":"https://api.github.com/repos/ChandraCXC/iris/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/comments/43384326"},"html":{"href":"https://github.com/ChandraCXC/iris/pull/168#discussion_r43384326"},"pull_request":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/ChandraCXC/iris/pulls/168","id":49054099,"html_url":"https://github.com/ChandraCXC/iris/pull/168","diff_url":"https://github.com/ChandraCXC/iris/pull/168.diff","patch_url":"https://github.com/ChandraCXC/iris/pull/168.patch","issue_url":"https://api.github.com/repos/ChandraCXC/iris/issues/168","number":168,"state":"open","locked":false,"title":"158 159 160 remove dependency on specview","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"body":"Address #158, #159, #160.\r\n\r\n# Description\r\nThis PR:\r\n* removes all references and dependencies to Specview code (#159)\r\n* replaces the Units calls with a dummy replacement, decoupling the Units implementation from its API (#160)\r\n* replaces the fit attachment calls with a standalone interface, properly decoupling what was tightly coupled in the current version\r\n* as a result, some hacks have been removed (#158)\r\n* cleans up tab characters in affected classes.\r\n* Introduces a UTYPEs class with the one UTYPE that is actually used in the affected code.\r\n\r\nUnfortunately the only tests that I would expect to be broken, i.e. the ones relevant to SedStacker, are currently ignored, and we don't have tests of the Units framework that we picked off the shelf. Thus, the tests actually pass.\r\n\r\nHowever, this PR currently breaks the smoke test, and this is expected because the dummy units package does not perform any actual conversions, making the assertions in the smoke test fail.\r\n\r\nMy plan is to introduce Specview again in this very same PR, add an implementation of the new Units API based on specview so that we can introduce it again.\r\n\r\nThis PR has implications on PR #154 (Evaluate units code) as it shows the few methods that we actually use from that framework.\r\n\r\nAs for the Fit attachments and the \"horrible hack\" that this PR removes, one potential refactoring we must evaluate is to provide components vetoing power on the modification of an SED. We had a number of issues in v2.1 that had to do with the fact that specview didn't like (and didn't do much about) users modifying SEDs. While the previous implementation was not perfect, it did indicate that the current Iris framework is lacking the ability of components to veto changes in SED, and to react to such changes. This is a design task left for the future.","created_at":"2015-10-28T19:20:44Z","updated_at":"2015-10-29T13:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"894e01b9d56684884703e889373911cf7b55cca6","assignee":null,"milestone":{"url":"https://api.github.com/repos/ChandraCXC/iris/milestones/3","html_url":"https://github.com/ChandraCXC/iris/milestones/Sprint%2011/06/15","labels_url":"https://api.github.com/repos/ChandraCXC/iris/milestones/3/labels","id":1368919,"number":3,"title":"Sprint 11/06/15","description":"","creator":{"login":"eholum","id":7966037,"avatar_url":"https://avatars.githubusercontent.com/u/7966037?v=3","gravatar_id":"","url":"https://api.github.com/users/eholum","html_url":"https://github.com/eholum","followers_url":"https://api.github.com/users/eholum/followers","following_url":"https://api.github.com/users/eholum/following{/other_user}","gists_url":"https://api.github.com/users/eholum/gists{/gist_id}","starred_url":"https://api.github.com/users/eholum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eholum/subscriptions","organizations_url":"https://api.github.com/users/eholum/orgs","repos_url":"https://api.github.com/users/eholum/repos","events_url":"https://api.github.com/users/eholum/events{/privacy}","received_events_url":"https://api.github.com/users/eholum/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":3,"state":"open","created_at":"2015-10-21T19:08:16Z","updated_at":"2015-10-28T19:20:50Z","due_on":"2015-11-06T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ChandraCXC/iris/pulls/168/commits","review_comments_url":"https://api.github.com/repos/ChandraCXC/iris/pulls/168/comments","review_comment_url":"https://api.github.com/repos/ChandraCXC/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChandraCXC/iris/issues/168/comments","statuses_url":"https://api.github.com/repos/ChandraCXC/iris/statuses/fa3199971a0c378124b541c13a35c1f56abf8253","head":{"label":"ChandraCXC:158-159-160-remove-dependency-on-specview","ref":"158-159-160-remove-dependency-on-specview","sha":"fa3199971a0c378124b541c13a35c1f56abf8253","user":{"login":"ChandraCXC","id":923866,"avatar_url":"https://avatars.githubusercontent.com/u/923866?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraCXC","html_url":"https://github.com/ChandraCXC","followers_url":"https://api.github.com/users/ChandraCXC/followers","following_url":"https://api.github.com/users/ChandraCXC/following{/other_user}","gists_url":"https://api.github.com/users/ChandraCXC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraCXC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraCXC/subscriptions","organizations_url":"https://api.github.com/users/ChandraCXC/orgs","repos_url":"https://api.github.com/users/ChandraCXC/repos","events_url":"https://api.github.com/users/ChandraCXC/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraCXC/received_events","type":"Organization","site_admin":false},"repo":{"id":17256484,"name":"iris","full_name":"ChandraCXC/iris","owner":{"login":"ChandraCXC","id":923866,"avatar_url":"https://avatars.githubusercontent.com/u/923866?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraCXC","html_url":"https://github.com/ChandraCXC","followers_url":"https://api.github.com/users/ChandraCXC/followers","following_url":"https://api.github.com/users/ChandraCXC/following{/other_user}","gists_url":"https://api.github.com/users/ChandraCXC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraCXC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraCXC/subscriptions","organizations_url":"https://api.github.com/users/ChandraCXC/orgs","repos_url":"https://api.github.com/users/ChandraCXC/repos","events_url":"https://api.github.com/users/ChandraCXC/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraCXC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChandraCXC/iris","description":"Build and Analyze Spectral Energy Distributions in the Virtual Observatory","fork":false,"url":"https://api.github.com/repos/ChandraCXC/iris","forks_url":"https://api.github.com/repos/ChandraCXC/iris/forks","keys_url":"https://api.github.com/repos/ChandraCXC/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChandraCXC/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChandraCXC/iris/teams","hooks_url":"https://api.github.com/repos/ChandraCXC/iris/hooks","issue_events_url":"https://api.github.com/repos/ChandraCXC/iris/issues/events{/number}","events_url":"https://api.github.com/repos/ChandraCXC/iris/events","assignees_url":"https://api.github.com/repos/ChandraCXC/iris/assignees{/user}","branches_url":"https://api.github.com/repos/ChandraCXC/iris/branches{/branch}","tags_url":"https://api.github.com/repos/ChandraCXC/iris/tags","blobs_url":"https://api.github.com/repos/ChandraCXC/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChandraCXC/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChandraCXC/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChandraCXC/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChandraCXC/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/ChandraCXC/iris/languages","stargazers_url":"https://api.github.com/repos/ChandraCXC/iris/stargazers","contributors_url":"https://api.github.com/repos/ChandraCXC/iris/contributors","subscribers_url":"https://api.github.com/repos/ChandraCXC/iris/subscribers","subscription_url":"https://api.github.com/repos/ChandraCXC/iris/subscription","commits_url":"https://api.github.com/repos/ChandraCXC/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChandraCXC/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChandraCXC/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChandraCXC/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChandraCXC/iris/contents/{+path}","compare_url":"https://api.github.com/repos/ChandraCXC/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChandraCXC/iris/merges","archive_url":"https://api.github.com/repos/ChandraCXC/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChandraCXC/iris/downloads","issues_url":"https://api.github.com/repos/ChandraCXC/iris/issues{/number}","pulls_url":"https://api.github.com/repos/ChandraCXC/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/ChandraCXC/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/ChandraCXC/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChandraCXC/iris/labels{/name}","releases_url":"https://api.github.com/repos/ChandraCXC/iris/releases{/id}","created_at":"2014-02-27T16:55:48Z","updated_at":"2015-05-08T17:46:47Z","pushed_at":"2015-10-28T19:49:07Z","git_url":"git://github.com/ChandraCXC/iris.git","ssh_url":"git@github.com:ChandraCXC/iris.git","clone_url":"https://github.com/ChandraCXC/iris.git","svn_url":"https://github.com/ChandraCXC/iris","homepage":"http://cxc.cfa.harvard.edu/iris","size":3724,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":71,"forks":2,"open_issues":71,"watchers":2,"default_branch":"master"}},"base":{"label":"ChandraCXC:master","ref":"master","sha":"84ed8e93d7d61d3a8d90cfe073ece089b0184618","user":{"login":"ChandraCXC","id":923866,"avatar_url":"https://avatars.githubusercontent.com/u/923866?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraCXC","html_url":"https://github.com/ChandraCXC","followers_url":"https://api.github.com/users/ChandraCXC/followers","following_url":"https://api.github.com/users/ChandraCXC/following{/other_user}","gists_url":"https://api.github.com/users/ChandraCXC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraCXC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraCXC/subscriptions","organizations_url":"https://api.github.com/users/ChandraCXC/orgs","repos_url":"https://api.github.com/users/ChandraCXC/repos","events_url":"https://api.github.com/users/ChandraCXC/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraCXC/received_events","type":"Organization","site_admin":false},"repo":{"id":17256484,"name":"iris","full_name":"ChandraCXC/iris","owner":{"login":"ChandraCXC","id":923866,"avatar_url":"https://avatars.githubusercontent.com/u/923866?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraCXC","html_url":"https://github.com/ChandraCXC","followers_url":"https://api.github.com/users/ChandraCXC/followers","following_url":"https://api.github.com/users/ChandraCXC/following{/other_user}","gists_url":"https://api.github.com/users/ChandraCXC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraCXC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraCXC/subscriptions","organizations_url":"https://api.github.com/users/ChandraCXC/orgs","repos_url":"https://api.github.com/users/ChandraCXC/repos","events_url":"https://api.github.com/users/ChandraCXC/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraCXC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChandraCXC/iris","description":"Build and Analyze Spectral Energy Distributions in the Virtual Observatory","fork":false,"url":"https://api.github.com/repos/ChandraCXC/iris","forks_url":"https://api.github.com/repos/ChandraCXC/iris/forks","keys_url":"https://api.github.com/repos/ChandraCXC/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChandraCXC/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChandraCXC/iris/teams","hooks_url":"https://api.github.com/repos/ChandraCXC/iris/hooks","issue_events_url":"https://api.github.com/repos/ChandraCXC/iris/issues/events{/number}","events_url":"https://api.github.com/repos/ChandraCXC/iris/events","assignees_url":"https://api.github.com/repos/ChandraCXC/iris/assignees{/user}","branches_url":"https://api.github.com/repos/ChandraCXC/iris/branches{/branch}","tags_url":"https://api.github.com/repos/ChandraCXC/iris/tags","blobs_url":"https://api.github.com/repos/ChandraCXC/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChandraCXC/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChandraCXC/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChandraCXC/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChandraCXC/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/ChandraCXC/iris/languages","stargazers_url":"https://api.github.com/repos/ChandraCXC/iris/stargazers","contributors_url":"https://api.github.com/repos/ChandraCXC/iris/contributors","subscribers_url":"https://api.github.com/repos/ChandraCXC/iris/subscribers","subscription_url":"https://api.github.com/repos/ChandraCXC/iris/subscription","commits_url":"https://api.github.com/repos/ChandraCXC/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChandraCXC/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChandraCXC/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChandraCXC/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChandraCXC/iris/contents/{+path}","compare_url":"https://api.github.com/repos/ChandraCXC/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChandraCXC/iris/merges","archive_url":"https://api.github.com/repos/ChandraCXC/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChandraCXC/iris/downloads","issues_url":"https://api.github.com/repos/ChandraCXC/iris/issues{/number}","pulls_url":"https://api.github.com/repos/ChandraCXC/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/ChandraCXC/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/ChandraCXC/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChandraCXC/iris/labels{/name}","releases_url":"https://api.github.com/repos/ChandraCXC/iris/releases{/id}","created_at":"2014-02-27T16:55:48Z","updated_at":"2015-05-08T17:46:47Z","pushed_at":"2015-10-28T19:49:07Z","git_url":"git://github.com/ChandraCXC/iris.git","ssh_url":"git@github.com:ChandraCXC/iris.git","clone_url":"https://github.com/ChandraCXC/iris.git","svn_url":"https://github.com/ChandraCXC/iris","homepage":"http://cxc.cfa.harvard.edu/iris","size":3724,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":71,"forks":2,"open_issues":71,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/168"},"html":{"href":"https://github.com/ChandraCXC/iris/pull/168"},"issue":{"href":"https://api.github.com/repos/ChandraCXC/iris/issues/168"},"comments":{"href":"https://api.github.com/repos/ChandraCXC/iris/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChandraCXC/iris/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/ChandraCXC/iris/statuses/fa3199971a0c378124b541c13a35c1f56abf8253"}}}}