{"action":"created","issue":{"url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/1","labels_url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/1/comments","events_url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/1/events","html_url":"https://github.com/Quuxplusone/ring_view/pull/1","id":108382920,"number":1,"title":"Fixes, code \"modernization\", noexcept, and a new test ","user":{"login":"SuperV1234","id":918661,"avatar_url":"https://avatars.githubusercontent.com/u/918661?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperV1234","html_url":"https://github.com/SuperV1234","followers_url":"https://api.github.com/users/SuperV1234/followers","following_url":"https://api.github.com/users/SuperV1234/following{/other_user}","gists_url":"https://api.github.com/users/SuperV1234/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperV1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperV1234/subscriptions","organizations_url":"https://api.github.com/users/SuperV1234/orgs","repos_url":"https://api.github.com/users/SuperV1234/repos","events_url":"https://api.github.com/users/SuperV1234/events{/privacy}","received_events_url":"https://api.github.com/users/SuperV1234/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-25T18:27:22Z","updated_at":"2015-09-28T08:48:12Z","closed_at":"2015-09-28T07:27:53Z","pull_request":{"url":"https://api.github.com/repos/Quuxplusone/ring_view/pulls/1","html_url":"https://github.com/Quuxplusone/ring_view/pull/1","diff_url":"https://github.com/Quuxplusone/ring_view/pull/1.diff","patch_url":"https://github.com/Quuxplusone/ring_view/pull/1.patch"},"body":"The implementation/semantics seem fine to me so far.\r\n\r\nI've made some minor changes, added noexcept where appropriate, and tested out `ring_view<T>` on an \"un-typed\" array of `T`-aligned bytes.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/comments/143681647","html_url":"https://github.com/Quuxplusone/ring_view/pull/1#issuecomment-143681647","issue_url":"https://api.github.com/repos/Quuxplusone/ring_view/issues/1","id":143681647,"user":{"login":"SuperV1234","id":918661,"avatar_url":"https://avatars.githubusercontent.com/u/918661?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperV1234","html_url":"https://github.com/SuperV1234","followers_url":"https://api.github.com/users/SuperV1234/followers","following_url":"https://api.github.com/users/SuperV1234/following{/other_user}","gists_url":"https://api.github.com/users/SuperV1234/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperV1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperV1234/subscriptions","organizations_url":"https://api.github.com/users/SuperV1234/orgs","repos_url":"https://api.github.com/users/SuperV1234/repos","events_url":"https://api.github.com/users/SuperV1234/events{/privacy}","received_events_url":"https://api.github.com/users/SuperV1234/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T08:48:12Z","updated_at":"2015-09-28T08:48:12Z","body":"It's definitely a bad thing if a `fixed_ring` implemented in terms of `ring_view` is not as efficient as an hand-written one - I guess that doing that is not the correct thing, then.\r\n\r\nI think having a more generic `ring_base` would be the best approach here, but I think its implementation would be pretty much the same as `ring_view`.\r\n\r\n```cpp\r\ntemplate<typename Container, typename Popper>\r\nclass ring_base;\r\n\r\ntemplate<typename T, typename Popper>\r\nusing ring_view = ring_base<T*, Popper>;\r\n\r\ntemplate<typename T, std::size_t Capacity, typename Popper>\r\nusing fixed_ring = ring_base<std::array<T, Capacity>, Popper>;\r\n```\r\n\r\nI think something like the above pseudocode could work fine."}}