{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/44306612","id":44306612,"diff_hunk":"@@ -279,9 +279,7 @@ static GenericAgentConfig *CheckOpts(int argc, char **argv)\n             break;\n \n         case 's':\n-            strlcpy(SENDCLASSES, optarg, CF_MAXVARSIZE);\n-\n-            if (strlen(optarg) > CF_MAXVARSIZE)\n+            if (strlcat(SENDCLASSES, optarg, sizeof(DEFINECLASSES)) >= sizeof(SENDCLASSES))","path":"cf-runagent/cf-runagent.c","position":7,"original_position":7,"commit_id":"3751ac935ecff81da746d1d4645b7d1690ec91e3","original_commit_id":"3751ac935ecff81da746d1d4645b7d1690ec91e3","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"body":"`s/DEFINECLASSES/SENDCLASSES/`","created_at":"2015-11-09T17:58:51Z","updated_at":"2015-11-09T17:58:51Z","html_url":"https://github.com/cfengine/core/pull/2371#discussion_r44306612","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/2371","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/44306612"},"html":{"href":"https://github.com/cfengine/core/pull/2371#discussion_r44306612"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/2371"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2371","id":49231623,"html_url":"https://github.com/cfengine/core/pull/2371","diff_url":"https://github.com/cfengine/core/pull/2371.diff","patch_url":"https://github.com/cfengine/core/pull/2371.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/2371","number":2371,"state":"open","locked":false,"title":"Allow multiple -D or -N flags to be specified on the command line","user":{"login":"worr","id":183837,"avatar_url":"https://avatars.githubusercontent.com/u/183837?v=3","gravatar_id":"","url":"https://api.github.com/users/worr","html_url":"https://github.com/worr","followers_url":"https://api.github.com/users/worr/followers","following_url":"https://api.github.com/users/worr/following{/other_user}","gists_url":"https://api.github.com/users/worr/gists{/gist_id}","starred_url":"https://api.github.com/users/worr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worr/subscriptions","organizations_url":"https://api.github.com/users/worr/orgs","repos_url":"https://api.github.com/users/worr/repos","events_url":"https://api.github.com/users/worr/events{/privacy}","received_events_url":"https://api.github.com/users/worr/received_events","type":"User","site_admin":false},"body":"Currently, if multiple -D or -N flags are specified on the command-line, this causes all but the last to be ignored. These commits fixes this such that multiple flags can be used, adding more classes to be raised and lowered.\r\n\r\nhttps://dev.cfengine.com/issues/7191","created_at":"2015-10-30T04:59:57Z","updated_at":"2015-11-09T17:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5de67db90ad6a1f77571babd8757e4b2376e0ab","assignee":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/2371/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/2371/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2371/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/3751ac935ecff81da746d1d4645b7d1690ec91e3","head":{"label":"worr:bug/multiple-d-flags","ref":"bug/multiple-d-flags","sha":"3751ac935ecff81da746d1d4645b7d1690ec91e3","user":{"login":"worr","id":183837,"avatar_url":"https://avatars.githubusercontent.com/u/183837?v=3","gravatar_id":"","url":"https://api.github.com/users/worr","html_url":"https://github.com/worr","followers_url":"https://api.github.com/users/worr/followers","following_url":"https://api.github.com/users/worr/following{/other_user}","gists_url":"https://api.github.com/users/worr/gists{/gist_id}","starred_url":"https://api.github.com/users/worr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worr/subscriptions","organizations_url":"https://api.github.com/users/worr/orgs","repos_url":"https://api.github.com/users/worr/repos","events_url":"https://api.github.com/users/worr/events{/privacy}","received_events_url":"https://api.github.com/users/worr/received_events","type":"User","site_admin":false},"repo":{"id":5564545,"name":"core","full_name":"worr/core","owner":{"login":"worr","id":183837,"avatar_url":"https://avatars.githubusercontent.com/u/183837?v=3","gravatar_id":"","url":"https://api.github.com/users/worr","html_url":"https://github.com/worr","followers_url":"https://api.github.com/users/worr/followers","following_url":"https://api.github.com/users/worr/following{/other_user}","gists_url":"https://api.github.com/users/worr/gists{/gist_id}","starred_url":"https://api.github.com/users/worr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worr/subscriptions","organizations_url":"https://api.github.com/users/worr/orgs","repos_url":"https://api.github.com/users/worr/repos","events_url":"https://api.github.com/users/worr/events{/privacy}","received_events_url":"https://api.github.com/users/worr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/worr/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/worr/core","forks_url":"https://api.github.com/repos/worr/core/forks","keys_url":"https://api.github.com/repos/worr/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worr/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worr/core/teams","hooks_url":"https://api.github.com/repos/worr/core/hooks","issue_events_url":"https://api.github.com/repos/worr/core/issues/events{/number}","events_url":"https://api.github.com/repos/worr/core/events","assignees_url":"https://api.github.com/repos/worr/core/assignees{/user}","branches_url":"https://api.github.com/repos/worr/core/branches{/branch}","tags_url":"https://api.github.com/repos/worr/core/tags","blobs_url":"https://api.github.com/repos/worr/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worr/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worr/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/worr/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worr/core/statuses/{sha}","languages_url":"https://api.github.com/repos/worr/core/languages","stargazers_url":"https://api.github.com/repos/worr/core/stargazers","contributors_url":"https://api.github.com/repos/worr/core/contributors","subscribers_url":"https://api.github.com/repos/worr/core/subscribers","subscription_url":"https://api.github.com/repos/worr/core/subscription","commits_url":"https://api.github.com/repos/worr/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/worr/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/worr/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/worr/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/worr/core/contents/{+path}","compare_url":"https://api.github.com/repos/worr/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worr/core/merges","archive_url":"https://api.github.com/repos/worr/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worr/core/downloads","issues_url":"https://api.github.com/repos/worr/core/issues{/number}","pulls_url":"https://api.github.com/repos/worr/core/pulls{/number}","milestones_url":"https://api.github.com/repos/worr/core/milestones{/number}","notifications_url":"https://api.github.com/repos/worr/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worr/core/labels{/name}","releases_url":"https://api.github.com/repos/worr/core/releases{/id}","created_at":"2012-08-26T23:16:25Z","updated_at":"2015-05-05T22:58:21Z","pushed_at":"2015-11-09T06:43:02Z","git_url":"git://github.com/worr/core.git","ssh_url":"git@github.com:worr/core.git","clone_url":"https://github.com/worr/core.git","svn_url":"https://github.com/worr/core","homepage":"https://cfengine.com/community/","size":50975,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"feaa53aaf8ddcadbe1be7392505ce888d17a245e","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","created_at":"2012-02-25T09:19:05Z","updated_at":"2015-11-09T17:25:47Z","pushed_at":"2015-11-09T17:47:33Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":106582,"stargazers_count":225,"watchers_count":225,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":34,"forks":138,"open_issues":34,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/2371"},"html":{"href":"https://github.com/cfengine/core/pull/2371"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/2371"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/2371/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/2371/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/2371/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/3751ac935ecff81da746d1d4645b7d1690ec91e3"}}}}