{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/35260019","id":35260019,"diff_hunk":"@@ -79,7 +80,8 @@\n     with_items: nodes_needing_certs\n \n - name: Configure node instances\n-  hosts: oo_nodes_to_config\n+  hosts:\n+    - oo_nodes_to_config:oo_infra_to_config","path":"playbooks/common/openshift-node/config.yml","position":15,"original_position":15,"commit_id":"05c71057403180cc82c15871308a49c6b64a1695","original_commit_id":"d8ae66335d9ed9f40e323c85c85e03dbd5d6df67","user":{"login":"twiest","id":732867,"avatar_url":"https://avatars.githubusercontent.com/u/732867?v=3","gravatar_id":"","url":"https://api.github.com/users/twiest","html_url":"https://github.com/twiest","followers_url":"https://api.github.com/users/twiest/followers","following_url":"https://api.github.com/users/twiest/following{/other_user}","gists_url":"https://api.github.com/users/twiest/gists{/gist_id}","starred_url":"https://api.github.com/users/twiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiest/subscriptions","organizations_url":"https://api.github.com/users/twiest/orgs","repos_url":"https://api.github.com/users/twiest/repos","events_url":"https://api.github.com/users/twiest/events{/privacy}","received_events_url":"https://api.github.com/users/twiest/received_events","type":"User","site_admin":false},"body":"Although, now that I look at it, I don't see oo_infra_to_config used anywhere else. Is it even being populated?","created_at":"2015-07-22T20:32:09Z","updated_at":"2015-07-22T20:32:09Z","html_url":"https://github.com/openshift/openshift-ansible/pull/376#discussion_r35260019","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/35260019"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/376#discussion_r35260019"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376","id":40393844,"html_url":"https://github.com/openshift/openshift-ansible/pull/376","diff_url":"https://github.com/openshift/openshift-ansible/pull/376.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/376.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/376","number":376,"state":"open","locked":false,"title":"Infra node support","user":{"login":"wshearn","id":1176094,"avatar_url":"https://avatars.githubusercontent.com/u/1176094?v=3","gravatar_id":"","url":"https://api.github.com/users/wshearn","html_url":"https://github.com/wshearn","followers_url":"https://api.github.com/users/wshearn/followers","following_url":"https://api.github.com/users/wshearn/following{/other_user}","gists_url":"https://api.github.com/users/wshearn/gists{/gist_id}","starred_url":"https://api.github.com/users/wshearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wshearn/subscriptions","organizations_url":"https://api.github.com/users/wshearn/orgs","repos_url":"https://api.github.com/users/wshearn/repos","events_url":"https://api.github.com/users/wshearn/events{/privacy}","received_events_url":"https://api.github.com/users/wshearn/received_events","type":"User","site_admin":false},"body":"Initial pass of adding infra nodes and support for different sized instances on AWS","created_at":"2015-07-20T20:32:29Z","updated_at":"2015-07-22T20:32:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c232d41ed0d4e923fd66f65738c5797822aa4a95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/376/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/05c71057403180cc82c15871308a49c6b64a1695","head":{"label":"wshearn:infra_node_support","ref":"infra_node_support","sha":"05c71057403180cc82c15871308a49c6b64a1695","user":{"login":"wshearn","id":1176094,"avatar_url":"https://avatars.githubusercontent.com/u/1176094?v=3","gravatar_id":"","url":"https://api.github.com/users/wshearn","html_url":"https://github.com/wshearn","followers_url":"https://api.github.com/users/wshearn/followers","following_url":"https://api.github.com/users/wshearn/following{/other_user}","gists_url":"https://api.github.com/users/wshearn/gists{/gist_id}","starred_url":"https://api.github.com/users/wshearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wshearn/subscriptions","organizations_url":"https://api.github.com/users/wshearn/orgs","repos_url":"https://api.github.com/users/wshearn/repos","events_url":"https://api.github.com/users/wshearn/events{/privacy}","received_events_url":"https://api.github.com/users/wshearn/received_events","type":"User","site_admin":false},"repo":{"id":33001715,"name":"openshift-ansible","full_name":"wshearn/openshift-ansible","owner":{"login":"wshearn","id":1176094,"avatar_url":"https://avatars.githubusercontent.com/u/1176094?v=3","gravatar_id":"","url":"https://api.github.com/users/wshearn","html_url":"https://github.com/wshearn","followers_url":"https://api.github.com/users/wshearn/followers","following_url":"https://api.github.com/users/wshearn/following{/other_user}","gists_url":"https://api.github.com/users/wshearn/gists{/gist_id}","starred_url":"https://api.github.com/users/wshearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wshearn/subscriptions","organizations_url":"https://api.github.com/users/wshearn/orgs","repos_url":"https://api.github.com/users/wshearn/repos","events_url":"https://api.github.com/users/wshearn/events{/privacy}","received_events_url":"https://api.github.com/users/wshearn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wshearn/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/wshearn/openshift-ansible","forks_url":"https://api.github.com/repos/wshearn/openshift-ansible/forks","keys_url":"https://api.github.com/repos/wshearn/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wshearn/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wshearn/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/wshearn/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/wshearn/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/wshearn/openshift-ansible/events","assignees_url":"https://api.github.com/repos/wshearn/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/wshearn/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/wshearn/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/wshearn/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wshearn/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wshearn/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/wshearn/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wshearn/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/wshearn/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/wshearn/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/wshearn/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/wshearn/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/wshearn/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/wshearn/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/wshearn/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/wshearn/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/wshearn/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/wshearn/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/wshearn/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wshearn/openshift-ansible/merges","archive_url":"https://api.github.com/repos/wshearn/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wshearn/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/wshearn/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/wshearn/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/wshearn/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/wshearn/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wshearn/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/wshearn/openshift-ansible/releases{/id}","created_at":"2015-03-27T18:10:36Z","updated_at":"2015-04-22T14:38:11Z","pushed_at":"2015-07-22T20:23:59Z","git_url":"git://github.com/wshearn/openshift-ansible.git","ssh_url":"git@github.com:wshearn/openshift-ansible.git","clone_url":"https://github.com/wshearn/openshift-ansible.git","svn_url":"https://github.com/wshearn/openshift-ansible","homepage":"","size":1168,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0cbeae4df062af3e2c1a4cb08ef3b4e742394ed6","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-07-10T17:52:08Z","pushed_at":"2015-07-22T20:23:59Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"","size":3493,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":48,"forks":78,"open_issues":48,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/376"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/376"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/05c71057403180cc82c15871308a49c6b64a1695"}}}}