{"action":"created","issue":{"url":"https://api.github.com/repos/letsencrypt/boulder/issues/908","labels_url":"https://api.github.com/repos/letsencrypt/boulder/issues/908/labels{/name}","comments_url":"https://api.github.com/repos/letsencrypt/boulder/issues/908/comments","events_url":"https://api.github.com/repos/letsencrypt/boulder/issues/908/events","html_url":"https://github.com/letsencrypt/boulder/pull/908","id":109641790,"number":908,"title":"Allow override of all build flags in Makefile.","user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/letsencrypt/boulder/labels/r?","name":"r?","color":"fad8c7"},{"url":"https://api.github.com/repos/letsencrypt/boulder/labels/tests","name":"tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-03T19:54:47Z","updated_at":"2015-10-05T04:07:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/boulder/pulls/908","html_url":"https://github.com/letsencrypt/boulder/pull/908","diff_url":"https://github.com/letsencrypt/boulder/pull/908.diff","patch_url":"https://github.com/letsencrypt/boulder/pull/908.patch"},"body":"I think even the ldflags that did not change between subsequent invocations of\r\n./start.py, e.g. BUILD_HOST_VAR, were different between ./start.py and\r\n`go test ./...`, which would cause test runs to be unnecessarily slow.\r\n\r\nOpen question: To keep local developer builds fast, maybe we should enable race\r\ndetection only in Travis? Otherwise, `go test ./...` runs with one set of\r\nldflags, and then `ampq-integration-test.py` runs with a different set, which I\r\nthink makes both of them slower."},"comment":{"url":"https://api.github.com/repos/letsencrypt/boulder/issues/comments/145425288","html_url":"https://github.com/letsencrypt/boulder/pull/908#issuecomment-145425288","issue_url":"https://api.github.com/repos/letsencrypt/boulder/issues/908","id":145425288,"user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T04:07:19Z","updated_at":"2015-10-05T04:07:19Z","body":"BTW, @jcjones @jmhodges: Are we okay removing pkcs11bench from the Makefile now? It seems that the latest `godep` run removed test files from vendorized directories, so `make` now fails unless we remove it."}}