{"action":"created","comment":{"url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/comments/24722759","id":24722759,"diff_hunk":"@@ -351,6 +252,9 @@ else if(directByteBufferClass.isInstance(buffer.base)) {\n      */\n     MessageBuffer(ByteBuffer bb) {\n         if(bb.isDirect()) {\n+            if(isUniversalBuffer) {\n+                throw new IllegalStateException(\"Cannot create MessageBuffer from DirectBuffer\");","path":"msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.java","position":348,"original_position":296,"commit_id":"5fd6964a016417afce7bf277c1074bde8a0076fc","original_commit_id":"ad711dbea72c1850c8bd05b1983945c621ad78a9","user":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"body":"Right. This code should not be called and that's why I throw IllegalStateException. ","created_at":"2015-02-15T14:24:30Z","updated_at":"2015-02-15T14:24:30Z","html_url":"https://github.com/msgpack/msgpack-java/pull/198#discussion_r24722759","pull_request_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/comments/24722759"},"html":{"href":"https://github.com/msgpack/msgpack-java/pull/198#discussion_r24722759"},"pull_request":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198","id":29038233,"html_url":"https://github.com/msgpack/msgpack-java/pull/198","diff_url":"https://github.com/msgpack/msgpack-java/pull/198.diff","patch_url":"https://github.com/msgpack/msgpack-java/pull/198.patch","issue_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/198","number":198,"state":"open","locked":false,"title":"Google App Engine Support","user":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"body":"Fixes for #194: \r\n- Refactored MessageBuffer to isolate the initialization steps between standard and Java6/Android/GAE platforms. \r\n- Extracted DirectBufferAccess code to a new file. \r\n\r\nI confirmed with this fix, we can initialize MessageBuffer class in GAE platform. ","created_at":"2015-02-10T19:47:34Z","updated_at":"2015-02-15T14:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66533910c2806294b0ce14760bed096df70ef823","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198/commits","review_comments_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198/comments","review_comment_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls/comments/{number}","comments_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/198/comments","statuses_url":"https://api.github.com/repos/msgpack/msgpack-java/statuses/5fd6964a016417afce7bf277c1074bde8a0076fc","head":{"label":"xerial:v07-no-unsafe","ref":"v07-no-unsafe","sha":"5fd6964a016417afce7bf277c1074bde8a0076fc","user":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"repo":{"id":13735214,"name":"msgpack-java","full_name":"xerial/msgpack-java","owner":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xerial/msgpack-java","description":"MessagePack serializer implementation for Java / msgpack.org[Java]","fork":true,"url":"https://api.github.com/repos/xerial/msgpack-java","forks_url":"https://api.github.com/repos/xerial/msgpack-java/forks","keys_url":"https://api.github.com/repos/xerial/msgpack-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xerial/msgpack-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xerial/msgpack-java/teams","hooks_url":"https://api.github.com/repos/xerial/msgpack-java/hooks","issue_events_url":"https://api.github.com/repos/xerial/msgpack-java/issues/events{/number}","events_url":"https://api.github.com/repos/xerial/msgpack-java/events","assignees_url":"https://api.github.com/repos/xerial/msgpack-java/assignees{/user}","branches_url":"https://api.github.com/repos/xerial/msgpack-java/branches{/branch}","tags_url":"https://api.github.com/repos/xerial/msgpack-java/tags","blobs_url":"https://api.github.com/repos/xerial/msgpack-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xerial/msgpack-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xerial/msgpack-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/xerial/msgpack-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xerial/msgpack-java/statuses/{sha}","languages_url":"https://api.github.com/repos/xerial/msgpack-java/languages","stargazers_url":"https://api.github.com/repos/xerial/msgpack-java/stargazers","contributors_url":"https://api.github.com/repos/xerial/msgpack-java/contributors","subscribers_url":"https://api.github.com/repos/xerial/msgpack-java/subscribers","subscription_url":"https://api.github.com/repos/xerial/msgpack-java/subscription","commits_url":"https://api.github.com/repos/xerial/msgpack-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/xerial/msgpack-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/xerial/msgpack-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/xerial/msgpack-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/xerial/msgpack-java/contents/{+path}","compare_url":"https://api.github.com/repos/xerial/msgpack-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xerial/msgpack-java/merges","archive_url":"https://api.github.com/repos/xerial/msgpack-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xerial/msgpack-java/downloads","issues_url":"https://api.github.com/repos/xerial/msgpack-java/issues{/number}","pulls_url":"https://api.github.com/repos/xerial/msgpack-java/pulls{/number}","milestones_url":"https://api.github.com/repos/xerial/msgpack-java/milestones{/number}","notifications_url":"https://api.github.com/repos/xerial/msgpack-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xerial/msgpack-java/labels{/name}","releases_url":"https://api.github.com/repos/xerial/msgpack-java/releases{/id}","created_at":"2013-10-21T07:07:25Z","updated_at":"2015-02-10T16:22:12Z","pushed_at":"2015-02-15T14:22:44Z","git_url":"git://github.com/xerial/msgpack-java.git","ssh_url":"git@github.com:xerial/msgpack-java.git","clone_url":"https://github.com/xerial/msgpack-java.git","svn_url":"https://github.com/xerial/msgpack-java","homepage":"http://msgpack.org/","size":3729,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v07-develop"}},"base":{"label":"msgpack:v07-develop","ref":"v07-develop","sha":"3c15d21c7a40e1097d33f3e2cac1e2984ce77fef","user":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"repo":{"id":1971346,"name":"msgpack-java","full_name":"msgpack/msgpack-java","owner":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msgpack/msgpack-java","description":"MessagePack serializer implementation for Java / msgpack.org[Java]","fork":false,"url":"https://api.github.com/repos/msgpack/msgpack-java","forks_url":"https://api.github.com/repos/msgpack/msgpack-java/forks","keys_url":"https://api.github.com/repos/msgpack/msgpack-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msgpack/msgpack-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msgpack/msgpack-java/teams","hooks_url":"https://api.github.com/repos/msgpack/msgpack-java/hooks","issue_events_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/events{/number}","events_url":"https://api.github.com/repos/msgpack/msgpack-java/events","assignees_url":"https://api.github.com/repos/msgpack/msgpack-java/assignees{/user}","branches_url":"https://api.github.com/repos/msgpack/msgpack-java/branches{/branch}","tags_url":"https://api.github.com/repos/msgpack/msgpack-java/tags","blobs_url":"https://api.github.com/repos/msgpack/msgpack-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msgpack/msgpack-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msgpack/msgpack-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/msgpack/msgpack-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msgpack/msgpack-java/statuses/{sha}","languages_url":"https://api.github.com/repos/msgpack/msgpack-java/languages","stargazers_url":"https://api.github.com/repos/msgpack/msgpack-java/stargazers","contributors_url":"https://api.github.com/repos/msgpack/msgpack-java/contributors","subscribers_url":"https://api.github.com/repos/msgpack/msgpack-java/subscribers","subscription_url":"https://api.github.com/repos/msgpack/msgpack-java/subscription","commits_url":"https://api.github.com/repos/msgpack/msgpack-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/msgpack/msgpack-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/msgpack/msgpack-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/comments/{number}","contents_url":"https://api.github.com/repos/msgpack/msgpack-java/contents/{+path}","compare_url":"https://api.github.com/repos/msgpack/msgpack-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msgpack/msgpack-java/merges","archive_url":"https://api.github.com/repos/msgpack/msgpack-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msgpack/msgpack-java/downloads","issues_url":"https://api.github.com/repos/msgpack/msgpack-java/issues{/number}","pulls_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls{/number}","milestones_url":"https://api.github.com/repos/msgpack/msgpack-java/milestones{/number}","notifications_url":"https://api.github.com/repos/msgpack/msgpack-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msgpack/msgpack-java/labels{/name}","releases_url":"https://api.github.com/repos/msgpack/msgpack-java/releases{/id}","created_at":"2011-06-29T08:45:39Z","updated_at":"2015-02-13T09:09:41Z","pushed_at":"2015-02-10T16:25:37Z","git_url":"git://github.com/msgpack/msgpack-java.git","ssh_url":"git@github.com:msgpack/msgpack-java.git","clone_url":"https://github.com/msgpack/msgpack-java.git","svn_url":"https://github.com/msgpack/msgpack-java","homepage":"http://msgpack.org/","size":5310,"stargazers_count":390,"watchers_count":390,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"open_issues_count":42,"forks":110,"open_issues":42,"watchers":390,"default_branch":"v07-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198"},"html":{"href":"https://github.com/msgpack/msgpack-java/pull/198"},"issue":{"href":"https://api.github.com/repos/msgpack/msgpack-java/issues/198"},"comments":{"href":"https://api.github.com/repos/msgpack/msgpack-java/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/msgpack/msgpack-java/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/msgpack/msgpack-java/statuses/5fd6964a016417afce7bf277c1074bde8a0076fc"}}}}