{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/886","labels_url":"https://api.github.com/repos/NLog/NLog/issues/886/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/886/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/886/events","html_url":"https://github.com/NLog/NLog/issues/886","id":104133041,"number":886,"title":"GDC/MDC/GDC/MDLC to singleton","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NLog/NLog/labels/could%20Have","name":"could Have","color":"cccccc"},{"url":"https://api.github.com/repos/NLog/NLog/labels/discussion","name":"discussion","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"Page-Not-Found","id":635337,"avatar_url":"https://avatars.githubusercontent.com/u/635337?v=3","gravatar_id":"","url":"https://api.github.com/users/Page-Not-Found","html_url":"https://github.com/Page-Not-Found","followers_url":"https://api.github.com/users/Page-Not-Found/followers","following_url":"https://api.github.com/users/Page-Not-Found/following{/other_user}","gists_url":"https://api.github.com/users/Page-Not-Found/gists{/gist_id}","starred_url":"https://api.github.com/users/Page-Not-Found/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Page-Not-Found/subscriptions","organizations_url":"https://api.github.com/users/Page-Not-Found/orgs","repos_url":"https://api.github.com/users/Page-Not-Found/repos","events_url":"https://api.github.com/users/Page-Not-Found/events{/privacy}","received_events_url":"https://api.github.com/users/Page-Not-Found/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/14","html_url":"https://github.com/NLog/NLog/milestones/4.3","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/14/labels","id":1369256,"number":14,"title":"4.3","description":"","creator":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":0,"state":"open","created_at":"2015-10-21T22:23:20Z","updated_at":"2015-10-21T22:23:30Z","due_on":null,"closed_at":null},"comments":27,"created_at":"2015-08-31T20:57:08Z","updated_at":"2015-10-23T17:53:28Z","closed_at":null,"body":"To Singleton,  but keep backwards compatible.  Create common interface for context classes when possible.  \r\n\r\nAlso:\r\n\r\n- [ ] add indexer syntax,  NOTE not possible with static .e.g. \r\n\r\n```c#\r\n\r\nvar context = MappedDiagnosticsContext.Instance;\r\ncontext[\"a\"] = \"b\";\r\nvar x= context[\"a\"];\r\n```\r\n- [ ] add `Keys` property\r\n- [ ] Remove \" Mostly for compatibility with log4net.\" comments from code \r\n- [ ] Remove \" Mostly for compatibility with log4net.\" comments from wiki \r\n- [ ] add unit tests\r\n- [ ] add common interface. Note: NDC has different methods. Mabye adding 2/3 interfaces? (with inheritance)\r\n- [ ] update wiki\r\n- [ ] discussion: add obsolete warnings.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/150646404","html_url":"https://github.com/NLog/NLog/issues/886#issuecomment-150646404","issue_url":"https://api.github.com/repos/NLog/NLog/issues/886","id":150646404,"user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T17:53:28Z","updated_at":"2015-10-23T17:53:28Z","body":"License looks good,  but I not sure if we need it. Also (note: didn't looked at depth of it), most code from blogs isn't well tested (compared to github repository) "}}