{"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/27118870","id":27118870,"diff_hunk":"@@ -75,24 +75,29 @@\n     'invenio.legacy.websubmit',\n ]\n \n-CFG_PREFIX = distutils.sysconfig.get_config_var(\"prefix\")\n+_CFG_PREFIX = distutils.sysconfig.get_config_var(\"prefix\")","path":"invenio/base/config.py","position":null,"original_position":5,"commit_id":"f21421c4f7ecc9f32428cd0d129573469a87f68d","original_commit_id":"4bbbefd403d0d041eadb98cc3dc5671ff8a09d29","user":{"login":"dset0x","id":8993055,"avatar_url":"https://avatars.githubusercontent.com/u/8993055?v=3","gravatar_id":"","url":"https://api.github.com/users/dset0x","html_url":"https://github.com/dset0x","followers_url":"https://api.github.com/users/dset0x/followers","following_url":"https://api.github.com/users/dset0x/following{/other_user}","gists_url":"https://api.github.com/users/dset0x/gists{/gist_id}","starred_url":"https://api.github.com/users/dset0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dset0x/subscriptions","organizations_url":"https://api.github.com/users/dset0x/orgs","repos_url":"https://api.github.com/users/dset0x/repos","events_url":"https://api.github.com/users/dset0x/events{/privacy}","received_events_url":"https://api.github.com/users/dset0x/received_events","type":"User","site_admin":false},"body":"Seemed appropriate. Done.\r\n\r\nI've also made the changes we discussed in #2818.","created_at":"2015-03-25T13:22:11Z","updated_at":"2015-03-25T13:22:11Z","html_url":"https://github.com/inveniosoftware/invenio/pull/2829#discussion_r27118870","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments/27118870"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2829#discussion_r27118870"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829","id":30367820,"html_url":"https://github.com/inveniosoftware/invenio/pull/2829","diff_url":"https://github.com/inveniosoftware/invenio/pull/2829.diff","patch_url":"https://github.com/inveniosoftware/invenio/pull/2829.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2829","number":2829,"state":"open","locked":false,"title":"WIP global: refactored `CFG` variables","user":{"login":"dset0x","id":8993055,"avatar_url":"https://avatars.githubusercontent.com/u/8993055?v=3","gravatar_id":"","url":"https://api.github.com/users/dset0x","html_url":"https://github.com/dset0x","followers_url":"https://api.github.com/users/dset0x/followers","following_url":"https://api.github.com/users/dset0x/following{/other_user}","gists_url":"https://api.github.com/users/dset0x/gists{/gist_id}","starred_url":"https://api.github.com/users/dset0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dset0x/subscriptions","organizations_url":"https://api.github.com/users/dset0x/orgs","repos_url":"https://api.github.com/users/dset0x/repos","events_url":"https://api.github.com/users/dset0x/events{/privacy}","received_events_url":"https://api.github.com/users/dset0x/received_events","type":"User","site_admin":false},"body":"* Replaces custom path concatenations with `os.path.join`\r\n\r\n* Refactors commonly used paths to use config variables.\r\n\r\n* Renames `CFG_PREFIX` to `_CFG_PREFIX`.\r\n\r\n---\r\n\r\nI would like some input on this in order to drop the WIP tag quicker:\r\nSome references to `_CFG_PREFIX` remain and perhaps some `legacy/` files were better off remaining similar to their `master` equivalents.\r\n\r\nIf accepted, supersedes  #2818","created_at":"2015-03-03T12:05:39Z","updated_at":"2015-03-25T13:22:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b308048928810f5ba440185d15a9261333d7634a","assignee":null,"milestone":{"url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/13","html_url":"https://github.com/inveniosoftware/invenio/milestones/v2.1","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones/13/labels","id":857114,"number":13,"title":"v2.1","description":"","creator":{"login":"tiborsimko","id":517546,"avatar_url":"https://avatars.githubusercontent.com/u/517546?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborsimko","html_url":"https://github.com/tiborsimko","followers_url":"https://api.github.com/users/tiborsimko/followers","following_url":"https://api.github.com/users/tiborsimko/following{/other_user}","gists_url":"https://api.github.com/users/tiborsimko/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborsimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborsimko/subscriptions","organizations_url":"https://api.github.com/users/tiborsimko/orgs","repos_url":"https://api.github.com/users/tiborsimko/repos","events_url":"https://api.github.com/users/tiborsimko/events{/privacy}","received_events_url":"https://api.github.com/users/tiborsimko/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":24,"state":"open","created_at":"2014-11-07T09:21:23Z","updated_at":"2015-03-25T09:20:34Z","due_on":"2015-04-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/2829/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/f21421c4f7ecc9f32428cd0d129573469a87f68d","head":{"label":"dset0x:deprecated_cfg","ref":"deprecated_cfg","sha":"f21421c4f7ecc9f32428cd0d129573469a87f68d","user":{"login":"dset0x","id":8993055,"avatar_url":"https://avatars.githubusercontent.com/u/8993055?v=3","gravatar_id":"","url":"https://api.github.com/users/dset0x","html_url":"https://github.com/dset0x","followers_url":"https://api.github.com/users/dset0x/followers","following_url":"https://api.github.com/users/dset0x/following{/other_user}","gists_url":"https://api.github.com/users/dset0x/gists{/gist_id}","starred_url":"https://api.github.com/users/dset0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dset0x/subscriptions","organizations_url":"https://api.github.com/users/dset0x/orgs","repos_url":"https://api.github.com/users/dset0x/repos","events_url":"https://api.github.com/users/dset0x/events{/privacy}","received_events_url":"https://api.github.com/users/dset0x/received_events","type":"User","site_admin":false},"repo":{"id":24757866,"name":"invenio","full_name":"dset0x/invenio","owner":{"login":"dset0x","id":8993055,"avatar_url":"https://avatars.githubusercontent.com/u/8993055?v=3","gravatar_id":"","url":"https://api.github.com/users/dset0x","html_url":"https://github.com/dset0x","followers_url":"https://api.github.com/users/dset0x/followers","following_url":"https://api.github.com/users/dset0x/following{/other_user}","gists_url":"https://api.github.com/users/dset0x/gists{/gist_id}","starred_url":"https://api.github.com/users/dset0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dset0x/subscriptions","organizations_url":"https://api.github.com/users/dset0x/orgs","repos_url":"https://api.github.com/users/dset0x/repos","events_url":"https://api.github.com/users/dset0x/events{/privacy}","received_events_url":"https://api.github.com/users/dset0x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dset0x/invenio","description":"Invenio digital library software","fork":true,"url":"https://api.github.com/repos/dset0x/invenio","forks_url":"https://api.github.com/repos/dset0x/invenio/forks","keys_url":"https://api.github.com/repos/dset0x/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dset0x/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dset0x/invenio/teams","hooks_url":"https://api.github.com/repos/dset0x/invenio/hooks","issue_events_url":"https://api.github.com/repos/dset0x/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/dset0x/invenio/events","assignees_url":"https://api.github.com/repos/dset0x/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/dset0x/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/dset0x/invenio/tags","blobs_url":"https://api.github.com/repos/dset0x/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dset0x/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dset0x/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/dset0x/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dset0x/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/dset0x/invenio/languages","stargazers_url":"https://api.github.com/repos/dset0x/invenio/stargazers","contributors_url":"https://api.github.com/repos/dset0x/invenio/contributors","subscribers_url":"https://api.github.com/repos/dset0x/invenio/subscribers","subscription_url":"https://api.github.com/repos/dset0x/invenio/subscription","commits_url":"https://api.github.com/repos/dset0x/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/dset0x/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/dset0x/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/dset0x/invenio/issues/comments{/number}","contents_url":"https://api.github.com/repos/dset0x/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/dset0x/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dset0x/invenio/merges","archive_url":"https://api.github.com/repos/dset0x/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dset0x/invenio/downloads","issues_url":"https://api.github.com/repos/dset0x/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/dset0x/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/dset0x/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/dset0x/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dset0x/invenio/labels{/name}","releases_url":"https://api.github.com/repos/dset0x/invenio/releases{/id}","created_at":"2014-10-03T12:39:09Z","updated_at":"2015-01-28T09:29:02Z","pushed_at":"2015-03-25T13:20:46Z","git_url":"git://github.com/dset0x/invenio.git","ssh_url":"git@github.com:dset0x/invenio.git","clone_url":"https://github.com/dset0x/invenio.git","svn_url":"https://github.com/dset0x/invenio","homepage":"http://invenio-software.org/","size":80907,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:pu","ref":"pu","sha":"266d98f8dd9789f641c0364dc51e60f82aedc05d","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":2665618,"name":"invenio","full_name":"inveniosoftware/invenio","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars.githubusercontent.com/u/1157480?v=3","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio","description":"Invenio digital library software","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio","forks_url":"https://api.github.com/repos/inveniosoftware/invenio/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio/issues/comments{/number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio/releases{/id}","created_at":"2011-10-28T14:33:51Z","updated_at":"2015-03-24T20:40:37Z","pushed_at":"2015-03-25T13:20:46Z","git_url":"git://github.com/inveniosoftware/invenio.git","ssh_url":"git@github.com:inveniosoftware/invenio.git","clone_url":"https://github.com/inveniosoftware/invenio.git","svn_url":"https://github.com/inveniosoftware/invenio","homepage":"http://invenio-software.org/","size":97411,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":850,"forks":116,"open_issues":850,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829"},"html":{"href":"https://github.com/inveniosoftware/invenio/pull/2829"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2829"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/issues/2829/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio/pulls/2829/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio/statuses/f21421c4f7ecc9f32428cd0d129573469a87f68d"}}}}