{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/37562291","id":37562291,"diff_hunk":"@@ -30,14 +30,13 @@ trait CassandraSpanStoreFactory {self: App =>\n \n   import com.twitter.zipkin.storage.cassandra.{CassandraSpanStoreDefaults => Defaults}\n \n-\n-  val keyspace = flag(\"zipkin.store.cassandra.keyspace\", Defaults.KeyspaceName, \"name of the keyspace to use\")\n-  val cassandraDest = flag(\"zipkin.store.cassandra.dest\", \"localhost:9042\", \"dest of the cassandra cluster; comma-separated list of host:port pairs\")\n-\n-  val cassieSpanTtl = flag(\"zipkin.store.cassandra.spanTTL\", Defaults.SpanTtl, \"length of time cassandra should store spans\")\n-  val cassieIndexTtl = flag(\"zipkin.store.cassandra.indexTTL\", Defaults.IndexTtl, \"length of time cassandra should store span indexes\")\n-\n+  val keyspace           = flag(\"zipkin.store.cassandra.keyspace\", Defaults.KeyspaceName, \"name of the keyspace to use\")\n+  val cassandraDest      = flag(\"zipkin.store.cassandra.dest\", \"localhost:9042\", \"dest of the cassandra cluster; comma-separated list of host:port pairs\")\n+  val cassieSpanTtl      = flag(\"zipkin.store.cassandra.spanTTL\", Defaults.SpanTtl, \"length of time cassandra should store spans\")\n+  val cassieIndexTtl     = flag(\"zipkin.store.cassandra.indexTTL\", Defaults.IndexTtl, \"length of time cassandra should store span indexes\")","path":"zipkin-cassandra/src/main/scala/com/twitter/zipkin/cassandra/CassandraSpanStoreFactory.scala","position":14,"original_position":14,"commit_id":"dc51be1d1a41b87389f0c80ed0559c552d48601b","original_commit_id":"dc51be1d1a41b87389f0c80ed0559c552d48601b","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"body":"justed updated the spacing","created_at":"2015-08-20T18:13:37Z","updated_at":"2015-08-20T18:13:37Z","html_url":"https://github.com/openzipkin/zipkin/pull/639#discussion_r37562291","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/37562291"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/639#discussion_r37562291"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/639","id":42883380,"html_url":"https://github.com/openzipkin/zipkin/pull/639","diff_url":"https://github.com/openzipkin/zipkin/pull/639.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/639.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/639","number":639,"state":"open","locked":false,"title":"add authentication to cassandra","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"body":"Adding authentication to cassandra.  Would have liked to do this inside of Repository.java but I think the entry point is at a higher level in the scala code.  So there are 3 entry points to passing user credentials.  If the user uses the config files (collector-cassandra.scala) they need to add environment variables as written in the submodule readme.","created_at":"2015-08-20T01:37:47Z","updated_at":"2015-08-20T18:13:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3a4b41585d33d4d5c7189723f2697dd210e60ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/639/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/639/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/639/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/dc51be1d1a41b87389f0c80ed0559c552d48601b","head":{"label":"jamescway:jamescway.cassandra-auth","ref":"jamescway.cassandra-auth","sha":"dc51be1d1a41b87389f0c80ed0559c552d48601b","user":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"repo":{"id":41013277,"name":"zipkin","full_name":"jamescway/zipkin","owner":{"login":"jamescway","id":473680,"avatar_url":"https://avatars.githubusercontent.com/u/473680?v=3","gravatar_id":"","url":"https://api.github.com/users/jamescway","html_url":"https://github.com/jamescway","followers_url":"https://api.github.com/users/jamescway/followers","following_url":"https://api.github.com/users/jamescway/following{/other_user}","gists_url":"https://api.github.com/users/jamescway/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescway/subscriptions","organizations_url":"https://api.github.com/users/jamescway/orgs","repos_url":"https://api.github.com/users/jamescway/repos","events_url":"https://api.github.com/users/jamescway/events{/privacy}","received_events_url":"https://api.github.com/users/jamescway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamescway/zipkin","description":"Zipkin is a distributed tracing system","fork":true,"url":"https://api.github.com/repos/jamescway/zipkin","forks_url":"https://api.github.com/repos/jamescway/zipkin/forks","keys_url":"https://api.github.com/repos/jamescway/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamescway/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamescway/zipkin/teams","hooks_url":"https://api.github.com/repos/jamescway/zipkin/hooks","issue_events_url":"https://api.github.com/repos/jamescway/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/jamescway/zipkin/events","assignees_url":"https://api.github.com/repos/jamescway/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/jamescway/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/jamescway/zipkin/tags","blobs_url":"https://api.github.com/repos/jamescway/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamescway/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamescway/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamescway/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamescway/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/jamescway/zipkin/languages","stargazers_url":"https://api.github.com/repos/jamescway/zipkin/stargazers","contributors_url":"https://api.github.com/repos/jamescway/zipkin/contributors","subscribers_url":"https://api.github.com/repos/jamescway/zipkin/subscribers","subscription_url":"https://api.github.com/repos/jamescway/zipkin/subscription","commits_url":"https://api.github.com/repos/jamescway/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamescway/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamescway/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamescway/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamescway/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/jamescway/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamescway/zipkin/merges","archive_url":"https://api.github.com/repos/jamescway/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamescway/zipkin/downloads","issues_url":"https://api.github.com/repos/jamescway/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/jamescway/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/jamescway/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/jamescway/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamescway/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/jamescway/zipkin/releases{/id}","created_at":"2015-08-19T04:27:57Z","updated_at":"2015-08-19T04:27:58Z","pushed_at":"2015-08-20T17:47:45Z","git_url":"git://github.com/jamescway/zipkin.git","ssh_url":"git@github.com:jamescway/zipkin.git","clone_url":"https://github.com/jamescway/zipkin.git","svn_url":"https://github.com/jamescway/zipkin","homepage":"http://zipkin.io","size":6248,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"4b6ffe42a7407ff14f3ae30754738e05eda43f7b","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":4576305,"name":"zipkin","full_name":"openzipkin/zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin","description":"Zipkin is a distributed tracing system","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin","forks_url":"https://api.github.com/repos/openzipkin/zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin/releases{/id}","created_at":"2012-06-06T18:26:16Z","updated_at":"2015-08-20T17:28:44Z","pushed_at":"2015-08-20T17:51:54Z","git_url":"git://github.com/openzipkin/zipkin.git","ssh_url":"git@github.com:openzipkin/zipkin.git","clone_url":"https://github.com/openzipkin/zipkin.git","svn_url":"https://github.com/openzipkin/zipkin","homepage":"http://zipkin.io","size":13681,"stargazers_count":2590,"watchers_count":2590,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":358,"mirror_url":null,"open_issues_count":66,"forks":358,"open_issues":66,"watchers":2590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/639"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/639"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/639"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin/statuses/dc51be1d1a41b87389f0c80ed0559c552d48601b"}}}}