{"action":"created","comment":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/30178922","id":30178922,"diff_hunk":"@@ -1078,15 +1074,13 @@ func (p *rwFolder) performFinish(state *sharedPullerState) {\n \tt := time.Unix(state.file.Modified, 0)\n \terr = os.Chtimes(state.tempName, t, t)\n \tif err != nil {\n-\t\tif p.lenientMtimes {\n-\t\t\t// We accept the failure with a warning here and allow the sync to\n-\t\t\t// continue. We'll sync the new mtime back to the other devices later.\n-\t\t\t// If they have the same problem & setting, we might never get in\n-\t\t\t// sync.\n-\t\t\tl.Infof(\"Puller (folder %q, file %q): final: %v (continuing anyway as requested)\", p.folder, state.file.Name, err)\n+\t\t// First try using virtual mtimes\n+\t\tinfo, err := os.Stat(state.tempName)","path":"internal/model/rwfolder.go","position":127,"original_position":127,"commit_id":"0692137501e6778cbd7593d4a944a4f06f7baa5e","original_commit_id":"0692137501e6778cbd7593d4a944a4f06f7baa5e","user":{"login":"cdhowie","id":354641,"avatar_url":"https://avatars.githubusercontent.com/u/354641?v=3","gravatar_id":"","url":"https://api.github.com/users/cdhowie","html_url":"https://github.com/cdhowie","followers_url":"https://api.github.com/users/cdhowie/followers","following_url":"https://api.github.com/users/cdhowie/following{/other_user}","gists_url":"https://api.github.com/users/cdhowie/gists{/gist_id}","starred_url":"https://api.github.com/users/cdhowie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdhowie/subscriptions","organizations_url":"https://api.github.com/users/cdhowie/orgs","repos_url":"https://api.github.com/users/cdhowie/repos","events_url":"https://api.github.com/users/cdhowie/events{/privacy}","received_events_url":"https://api.github.com/users/cdhowie/received_events","type":"User","site_admin":false},"body":"But then we can't use `info` in the `else` block?","created_at":"2015-05-12T20:51:41Z","updated_at":"2015-05-12T20:51:41Z","html_url":"https://github.com/syncthing/syncthing/pull/1804#discussion_r30178922","pull_request_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1804","_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/30178922"},"html":{"href":"https://github.com/syncthing/syncthing/pull/1804#discussion_r30178922"},"pull_request":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1804"}}},"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/1804","id":35258641,"html_url":"https://github.com/syncthing/syncthing/pull/1804","diff_url":"https://github.com/syncthing/syncthing/pull/1804.diff","patch_url":"https://github.com/syncthing/syncthing/pull/1804.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/1804","number":1804,"state":"open","locked":false,"title":"Implement virtual mtime support for Android","user":{"login":"cdhowie","id":354641,"avatar_url":"https://avatars.githubusercontent.com/u/354641?v=3","gravatar_id":"","url":"https://api.github.com/users/cdhowie","html_url":"https://github.com/cdhowie","followers_url":"https://api.github.com/users/cdhowie/followers","following_url":"https://api.github.com/users/cdhowie/following{/other_user}","gists_url":"https://api.github.com/users/cdhowie/gists{/gist_id}","starred_url":"https://api.github.com/users/cdhowie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdhowie/subscriptions","organizations_url":"https://api.github.com/users/cdhowie/orgs","repos_url":"https://api.github.com/users/cdhowie/repos","events_url":"https://api.github.com/users/cdhowie/events{/privacy}","received_events_url":"https://api.github.com/users/cdhowie/received_events","type":"User","site_admin":false},"body":"Fixes #831.\r\n\r\nI believe I've addressed all of the issues raised in #1802.\r\n\r\nThis PR includes #1803.\r\n\r\nNote that this patch removes the lenientMtimes option completely, as it's no longer necessary.","created_at":"2015-05-12T18:55:31Z","updated_at":"2015-05-12T20:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cc52533e27ba896a4a96294ec97e93378871146","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1804/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1804/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/1804/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/0692137501e6778cbd7593d4a944a4f06f7baa5e","head":{"label":"cdhowie:virtual-mtimes","ref":"virtual-mtimes","sha":"0692137501e6778cbd7593d4a944a4f06f7baa5e","user":{"login":"cdhowie","id":354641,"avatar_url":"https://avatars.githubusercontent.com/u/354641?v=3","gravatar_id":"","url":"https://api.github.com/users/cdhowie","html_url":"https://github.com/cdhowie","followers_url":"https://api.github.com/users/cdhowie/followers","following_url":"https://api.github.com/users/cdhowie/following{/other_user}","gists_url":"https://api.github.com/users/cdhowie/gists{/gist_id}","starred_url":"https://api.github.com/users/cdhowie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdhowie/subscriptions","organizations_url":"https://api.github.com/users/cdhowie/orgs","repos_url":"https://api.github.com/users/cdhowie/repos","events_url":"https://api.github.com/users/cdhowie/events{/privacy}","received_events_url":"https://api.github.com/users/cdhowie/received_events","type":"User","site_admin":false},"repo":{"id":35165140,"name":"syncthing","full_name":"cdhowie/syncthing","owner":{"login":"cdhowie","id":354641,"avatar_url":"https://avatars.githubusercontent.com/u/354641?v=3","gravatar_id":"","url":"https://api.github.com/users/cdhowie","html_url":"https://github.com/cdhowie","followers_url":"https://api.github.com/users/cdhowie/followers","following_url":"https://api.github.com/users/cdhowie/following{/other_user}","gists_url":"https://api.github.com/users/cdhowie/gists{/gist_id}","starred_url":"https://api.github.com/users/cdhowie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdhowie/subscriptions","organizations_url":"https://api.github.com/users/cdhowie/orgs","repos_url":"https://api.github.com/users/cdhowie/repos","events_url":"https://api.github.com/users/cdhowie/events{/privacy}","received_events_url":"https://api.github.com/users/cdhowie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdhowie/syncthing","description":"Open Source Continuous File Synchronization","fork":true,"url":"https://api.github.com/repos/cdhowie/syncthing","forks_url":"https://api.github.com/repos/cdhowie/syncthing/forks","keys_url":"https://api.github.com/repos/cdhowie/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdhowie/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdhowie/syncthing/teams","hooks_url":"https://api.github.com/repos/cdhowie/syncthing/hooks","issue_events_url":"https://api.github.com/repos/cdhowie/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/cdhowie/syncthing/events","assignees_url":"https://api.github.com/repos/cdhowie/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/cdhowie/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/cdhowie/syncthing/tags","blobs_url":"https://api.github.com/repos/cdhowie/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdhowie/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdhowie/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdhowie/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdhowie/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/cdhowie/syncthing/languages","stargazers_url":"https://api.github.com/repos/cdhowie/syncthing/stargazers","contributors_url":"https://api.github.com/repos/cdhowie/syncthing/contributors","subscribers_url":"https://api.github.com/repos/cdhowie/syncthing/subscribers","subscription_url":"https://api.github.com/repos/cdhowie/syncthing/subscription","commits_url":"https://api.github.com/repos/cdhowie/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdhowie/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdhowie/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdhowie/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdhowie/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/cdhowie/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdhowie/syncthing/merges","archive_url":"https://api.github.com/repos/cdhowie/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdhowie/syncthing/downloads","issues_url":"https://api.github.com/repos/cdhowie/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/cdhowie/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/cdhowie/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/cdhowie/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdhowie/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/cdhowie/syncthing/releases{/id}","created_at":"2015-05-06T14:56:41Z","updated_at":"2015-05-08T16:11:48Z","pushed_at":"2015-05-12T20:33:15Z","git_url":"git://github.com/cdhowie/syncthing.git","ssh_url":"git@github.com:cdhowie/syncthing.git","clone_url":"https://github.com/cdhowie/syncthing.git","svn_url":"https://github.com/cdhowie/syncthing","homepage":"http://forum.syncthing.net/","size":39026,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"83ea8dc5772c3ef54933e86a2a48330d1f2e8a51","user":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":14712850,"name":"syncthing","full_name":"syncthing/syncthing","owner":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing","description":"Open Source Continuous File Synchronization","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing","forks_url":"https://api.github.com/repos/syncthing/syncthing/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing/releases{/id}","created_at":"2013-11-26T09:48:21Z","updated_at":"2015-05-12T20:08:18Z","pushed_at":"2015-05-12T20:33:16Z","git_url":"git://github.com/syncthing/syncthing.git","ssh_url":"git@github.com:syncthing/syncthing.git","clone_url":"https://github.com/syncthing/syncthing.git","svn_url":"https://github.com/syncthing/syncthing","homepage":"http://forum.syncthing.net/","size":64532,"stargazers_count":8309,"watchers_count":8309,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":572,"mirror_url":null,"open_issues_count":126,"forks":572,"open_issues":126,"watchers":8309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1804"},"html":{"href":"https://github.com/syncthing/syncthing/pull/1804"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/1804"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/1804/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1804/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1804/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing/statuses/0692137501e6778cbd7593d4a944a4f06f7baa5e"}}}}