{"action":"created","comment":{"url":"https://api.github.com/repos/candy-chat/candy/pulls/comments/26005528","id":26005528,"diff_hunk":"@@ -241,10 +241,10 @@ Candy.Core = function(self, Strophe, $) {\n             _connection.connect(_getEscapedJidFromJid(jidOrHost) + \"/\" + _options.resource, null, Candy.Core.Event.Strophe.Connect);\n             _user = new self.ChatUser(null, nick);\n         } else if (jidOrHost) {\n-            Candy.Core.Event.Login(jidOrHost);\n+            Candy.Core.Event.Login(null, jidOrHost);\n         } else {\n             // display login modal\n-            Candy.Core.Event.Login();\n+            Candy.Core.Event.Login(null, null);","path":"candy.bundle.js","position":9,"original_position":9,"commit_id":"e2b5a2a9e97fc0130789d054fc471b50000fa05b","original_commit_id":"e2b5a2a9e97fc0130789d054fc471b50000fa05b","user":{"login":"benlangfeld","id":210221,"avatar_url":"https://avatars.githubusercontent.com/u/210221?v=3","gravatar_id":"","url":"https://api.github.com/users/benlangfeld","html_url":"https://github.com/benlangfeld","followers_url":"https://api.github.com/users/benlangfeld/followers","following_url":"https://api.github.com/users/benlangfeld/following{/other_user}","gists_url":"https://api.github.com/users/benlangfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/benlangfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlangfeld/subscriptions","organizations_url":"https://api.github.com/users/benlangfeld/orgs","repos_url":"https://api.github.com/users/benlangfeld/repos","events_url":"https://api.github.com/users/benlangfeld/events{/privacy}","received_events_url":"https://api.github.com/users/benlangfeld/received_events","type":"User","site_admin":false},"body":"It's not actually necessary to pass these options - they'll come out as `undefined` if you leave them off the method invocation.","created_at":"2015-03-08T14:29:51Z","updated_at":"2015-03-08T14:29:51Z","html_url":"https://github.com/candy-chat/candy/pull/372#discussion_r26005528","pull_request_url":"https://api.github.com/repos/candy-chat/candy/pulls/372","_links":{"self":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/comments/26005528"},"html":{"href":"https://github.com/candy-chat/candy/pull/372#discussion_r26005528"},"pull_request":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/candy-chat/candy/pulls/372","id":30716940,"html_url":"https://github.com/candy-chat/candy/pull/372","diff_url":"https://github.com/candy-chat/candy/pull/372.diff","patch_url":"https://github.com/candy-chat/candy/pull/372.patch","issue_url":"https://api.github.com/repos/candy-chat/candy/issues/372","number":372,"state":"open","locked":false,"title":"fixed core.login trigger","user":{"login":"billybennett","id":676479,"avatar_url":"https://avatars.githubusercontent.com/u/676479?v=3","gravatar_id":"","url":"https://api.github.com/users/billybennett","html_url":"https://github.com/billybennett","followers_url":"https://api.github.com/users/billybennett/followers","following_url":"https://api.github.com/users/billybennett/following{/other_user}","gists_url":"https://api.github.com/users/billybennett/gists{/gist_id}","starred_url":"https://api.github.com/users/billybennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybennett/subscriptions","organizations_url":"https://api.github.com/users/billybennett/orgs","repos_url":"https://api.github.com/users/billybennett/repos","events_url":"https://api.github.com/users/billybennett/events{/privacy}","received_events_url":"https://api.github.com/users/billybennett/received_events","type":"User","site_admin":false},"body":"In reference to issue #371 ","created_at":"2015-03-08T09:07:49Z","updated_at":"2015-03-08T14:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d66be164454643f71539b7b7dcc0db16770c5a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/candy-chat/candy/pulls/372/commits","review_comments_url":"https://api.github.com/repos/candy-chat/candy/pulls/372/comments","review_comment_url":"https://api.github.com/repos/candy-chat/candy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candy-chat/candy/issues/372/comments","statuses_url":"https://api.github.com/repos/candy-chat/candy/statuses/e2b5a2a9e97fc0130789d054fc471b50000fa05b","head":{"label":"billybennett:fix-login-trigger","ref":"fix-login-trigger","sha":"e2b5a2a9e97fc0130789d054fc471b50000fa05b","user":{"login":"billybennett","id":676479,"avatar_url":"https://avatars.githubusercontent.com/u/676479?v=3","gravatar_id":"","url":"https://api.github.com/users/billybennett","html_url":"https://github.com/billybennett","followers_url":"https://api.github.com/users/billybennett/followers","following_url":"https://api.github.com/users/billybennett/following{/other_user}","gists_url":"https://api.github.com/users/billybennett/gists{/gist_id}","starred_url":"https://api.github.com/users/billybennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybennett/subscriptions","organizations_url":"https://api.github.com/users/billybennett/orgs","repos_url":"https://api.github.com/users/billybennett/repos","events_url":"https://api.github.com/users/billybennett/events{/privacy}","received_events_url":"https://api.github.com/users/billybennett/received_events","type":"User","site_admin":false},"repo":{"id":31833395,"name":"candy","full_name":"billybennett/candy","owner":{"login":"billybennett","id":676479,"avatar_url":"https://avatars.githubusercontent.com/u/676479?v=3","gravatar_id":"","url":"https://api.github.com/users/billybennett","html_url":"https://github.com/billybennett","followers_url":"https://api.github.com/users/billybennett/followers","following_url":"https://api.github.com/users/billybennett/following{/other_user}","gists_url":"https://api.github.com/users/billybennett/gists{/gist_id}","starred_url":"https://api.github.com/users/billybennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybennett/subscriptions","organizations_url":"https://api.github.com/users/billybennett/orgs","repos_url":"https://api.github.com/users/billybennett/repos","events_url":"https://api.github.com/users/billybennett/events{/privacy}","received_events_url":"https://api.github.com/users/billybennett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billybennett/candy","description":"JavaScript-based multi-user chat client for XMPP.","fork":true,"url":"https://api.github.com/repos/billybennett/candy","forks_url":"https://api.github.com/repos/billybennett/candy/forks","keys_url":"https://api.github.com/repos/billybennett/candy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billybennett/candy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billybennett/candy/teams","hooks_url":"https://api.github.com/repos/billybennett/candy/hooks","issue_events_url":"https://api.github.com/repos/billybennett/candy/issues/events{/number}","events_url":"https://api.github.com/repos/billybennett/candy/events","assignees_url":"https://api.github.com/repos/billybennett/candy/assignees{/user}","branches_url":"https://api.github.com/repos/billybennett/candy/branches{/branch}","tags_url":"https://api.github.com/repos/billybennett/candy/tags","blobs_url":"https://api.github.com/repos/billybennett/candy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billybennett/candy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billybennett/candy/git/refs{/sha}","trees_url":"https://api.github.com/repos/billybennett/candy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billybennett/candy/statuses/{sha}","languages_url":"https://api.github.com/repos/billybennett/candy/languages","stargazers_url":"https://api.github.com/repos/billybennett/candy/stargazers","contributors_url":"https://api.github.com/repos/billybennett/candy/contributors","subscribers_url":"https://api.github.com/repos/billybennett/candy/subscribers","subscription_url":"https://api.github.com/repos/billybennett/candy/subscription","commits_url":"https://api.github.com/repos/billybennett/candy/commits{/sha}","git_commits_url":"https://api.github.com/repos/billybennett/candy/git/commits{/sha}","comments_url":"https://api.github.com/repos/billybennett/candy/comments{/number}","issue_comment_url":"https://api.github.com/repos/billybennett/candy/issues/comments{/number}","contents_url":"https://api.github.com/repos/billybennett/candy/contents/{+path}","compare_url":"https://api.github.com/repos/billybennett/candy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billybennett/candy/merges","archive_url":"https://api.github.com/repos/billybennett/candy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billybennett/candy/downloads","issues_url":"https://api.github.com/repos/billybennett/candy/issues{/number}","pulls_url":"https://api.github.com/repos/billybennett/candy/pulls{/number}","milestones_url":"https://api.github.com/repos/billybennett/candy/milestones{/number}","notifications_url":"https://api.github.com/repos/billybennett/candy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billybennett/candy/labels{/name}","releases_url":"https://api.github.com/repos/billybennett/candy/releases{/id}","created_at":"2015-03-08T00:43:37Z","updated_at":"2015-03-08T00:43:38Z","pushed_at":"2015-03-08T08:46:13Z","git_url":"git://github.com/billybennett/candy.git","ssh_url":"git@github.com:billybennett/candy.git","clone_url":"https://github.com/billybennett/candy.git","svn_url":"https://github.com/billybennett/candy","homepage":"http://candy-chat.github.io/candy","size":7123,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"candy-chat:master","ref":"master","sha":"a9dcafe1a1995b61755986b56777fb2f44c832b2","user":{"login":"candy-chat","id":779260,"avatar_url":"https://avatars.githubusercontent.com/u/779260?v=3","gravatar_id":"","url":"https://api.github.com/users/candy-chat","html_url":"https://github.com/candy-chat","followers_url":"https://api.github.com/users/candy-chat/followers","following_url":"https://api.github.com/users/candy-chat/following{/other_user}","gists_url":"https://api.github.com/users/candy-chat/gists{/gist_id}","starred_url":"https://api.github.com/users/candy-chat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candy-chat/subscriptions","organizations_url":"https://api.github.com/users/candy-chat/orgs","repos_url":"https://api.github.com/users/candy-chat/repos","events_url":"https://api.github.com/users/candy-chat/events{/privacy}","received_events_url":"https://api.github.com/users/candy-chat/received_events","type":"Organization","site_admin":false},"repo":{"id":2153528,"name":"candy","full_name":"candy-chat/candy","owner":{"login":"candy-chat","id":779260,"avatar_url":"https://avatars.githubusercontent.com/u/779260?v=3","gravatar_id":"","url":"https://api.github.com/users/candy-chat","html_url":"https://github.com/candy-chat","followers_url":"https://api.github.com/users/candy-chat/followers","following_url":"https://api.github.com/users/candy-chat/following{/other_user}","gists_url":"https://api.github.com/users/candy-chat/gists{/gist_id}","starred_url":"https://api.github.com/users/candy-chat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candy-chat/subscriptions","organizations_url":"https://api.github.com/users/candy-chat/orgs","repos_url":"https://api.github.com/users/candy-chat/repos","events_url":"https://api.github.com/users/candy-chat/events{/privacy}","received_events_url":"https://api.github.com/users/candy-chat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candy-chat/candy","description":"JavaScript-based multi-user chat client for XMPP.","fork":false,"url":"https://api.github.com/repos/candy-chat/candy","forks_url":"https://api.github.com/repos/candy-chat/candy/forks","keys_url":"https://api.github.com/repos/candy-chat/candy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candy-chat/candy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candy-chat/candy/teams","hooks_url":"https://api.github.com/repos/candy-chat/candy/hooks","issue_events_url":"https://api.github.com/repos/candy-chat/candy/issues/events{/number}","events_url":"https://api.github.com/repos/candy-chat/candy/events","assignees_url":"https://api.github.com/repos/candy-chat/candy/assignees{/user}","branches_url":"https://api.github.com/repos/candy-chat/candy/branches{/branch}","tags_url":"https://api.github.com/repos/candy-chat/candy/tags","blobs_url":"https://api.github.com/repos/candy-chat/candy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candy-chat/candy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candy-chat/candy/git/refs{/sha}","trees_url":"https://api.github.com/repos/candy-chat/candy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candy-chat/candy/statuses/{sha}","languages_url":"https://api.github.com/repos/candy-chat/candy/languages","stargazers_url":"https://api.github.com/repos/candy-chat/candy/stargazers","contributors_url":"https://api.github.com/repos/candy-chat/candy/contributors","subscribers_url":"https://api.github.com/repos/candy-chat/candy/subscribers","subscription_url":"https://api.github.com/repos/candy-chat/candy/subscription","commits_url":"https://api.github.com/repos/candy-chat/candy/commits{/sha}","git_commits_url":"https://api.github.com/repos/candy-chat/candy/git/commits{/sha}","comments_url":"https://api.github.com/repos/candy-chat/candy/comments{/number}","issue_comment_url":"https://api.github.com/repos/candy-chat/candy/issues/comments{/number}","contents_url":"https://api.github.com/repos/candy-chat/candy/contents/{+path}","compare_url":"https://api.github.com/repos/candy-chat/candy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candy-chat/candy/merges","archive_url":"https://api.github.com/repos/candy-chat/candy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candy-chat/candy/downloads","issues_url":"https://api.github.com/repos/candy-chat/candy/issues{/number}","pulls_url":"https://api.github.com/repos/candy-chat/candy/pulls{/number}","milestones_url":"https://api.github.com/repos/candy-chat/candy/milestones{/number}","notifications_url":"https://api.github.com/repos/candy-chat/candy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candy-chat/candy/labels{/name}","releases_url":"https://api.github.com/repos/candy-chat/candy/releases{/id}","created_at":"2011-08-04T08:55:32Z","updated_at":"2015-03-08T11:57:55Z","pushed_at":"2015-03-05T16:35:13Z","git_url":"git://github.com/candy-chat/candy.git","ssh_url":"git@github.com:candy-chat/candy.git","clone_url":"https://github.com/candy-chat/candy.git","svn_url":"https://github.com/candy-chat/candy","homepage":"http://candy-chat.github.io/candy","size":7123,"stargazers_count":1037,"watchers_count":1037,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":272,"mirror_url":null,"open_issues_count":18,"forks":272,"open_issues":18,"watchers":1037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/372"},"html":{"href":"https://github.com/candy-chat/candy/pull/372"},"issue":{"href":"https://api.github.com/repos/candy-chat/candy/issues/372"},"comments":{"href":"https://api.github.com/repos/candy-chat/candy/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candy-chat/candy/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/candy-chat/candy/statuses/e2b5a2a9e97fc0130789d054fc471b50000fa05b"}}}}