{"action":"created","issue":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/750","labels_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/750/comments","events_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/750/events","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/750","id":103296973,"number":750,"title":"Vectorize movePointsCloser","user":{"login":"miscco","id":3017120,"avatar_url":"https://avatars.githubusercontent.com/u/3017120?v=3","gravatar_id":"","url":"https://api.github.com/users/miscco","html_url":"https://github.com/miscco","followers_url":"https://api.github.com/users/miscco/followers","following_url":"https://api.github.com/users/miscco/following{/other_user}","gists_url":"https://api.github.com/users/miscco/gists{/gist_id}","starred_url":"https://api.github.com/users/miscco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miscco/subscriptions","organizations_url":"https://api.github.com/users/miscco/orgs","repos_url":"https://api.github.com/users/miscco/repos","events_url":"https://api.github.com/users/miscco/events{/privacy}","received_events_url":"https://api.github.com/users/miscco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/labels/+0.0.1","name":"+0.0.1","color":"d3d7cf"},{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/labels/cleanfigure","name":"cleanfigure","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-08-26T15:28:08Z","updated_at":"2015-09-01T15:42:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/pulls/750","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/750","diff_url":"https://github.com/matlab2tikz/matlab2tikz/pull/750.diff","patch_url":"https://github.com/matlab2tikz/matlab2tikz/pull/750.patch"},"body":"This is an upgrade to pull request #737. \r\n\r\nIn addition to the changes there, this vectorizes the movePointsCloser function. The new function is now considerably simpler and we can keep most of the previous structure of the code.\r\n\r\nAs the last changes were complicated enough i decided to split it into 2 separate pull requests\r\n\r\nThere is one possible functional change. The old code calculated the xNew point and checked if it would still cross one of the axes. However, per construction this has to be true, otherwise xNew would have not been updated.\r\n\r\nThe usual tests for MATLAB2015a fail:\r\n\r\n# MATLAB 8.5 (Linux 3.13.0-62-generic) commit 9f193c4675 \r\n\r\n## Unreliable tests\r\nThese do not cause the build to fail.\r\n\r\n|   Testcase |                   Name |                       OK |                                                                      Status |\r\n| :--------- | :--------------------- | :----------------------: | :-------------------------------------------------------------------------- |\r\n|  `ACID(1)` |     `multiline_labels` | :heavy_exclamation_mark: | hash 21a208748863224355861184cf9910f7 != (01d4eeae27254d91a0f8316897e23e81) |\r\n|  `ACID(6)` | `sine_with_annotation` | :heavy_exclamation_mark: | hash 995cd2a901446c59f85552d48025ba27 != (7d415c014eec35c249802eb3a3ee519e) |\r\n| `ACID(10)` |       `peaks_contourf` | :heavy_exclamation_mark: | hash 1241fa010c4c53ab967f1e61931b596f != (77bfa3a9f07e49b9061d919551ad0a0f) |\r\n| `ACID(16)` |              `logplot` |       :white_check_mark: |                                                                             |\r\n| `ACID(18)` |           `legendplot` | :heavy_exclamation_mark: | hash d37d19ba36d911a0db60095db48b08ef != (746423d1c0d403421667221a6b0528bf) |\r\n| `ACID(24)` |          `quiver3plot` |       :white_check_mark: |                                                                             |\r\n| `ACID(34)` |                 `bars` |       :white_check_mark: |                                                                             |\r\n| `ACID(38)` |          `subplot2x2b` |       :white_check_mark: |                                                                             |\r\n| `ACID(40)` |        `subplotCustom` |       :white_check_mark: |                                                                             |\r\n| `ACID(42)` |            `bodeplots` | :heavy_exclamation_mark: | hash ca7b2029a08a2a311a94b73339e2128a != (8f6cafc1771cc3a506c8fc46c15ec43e) |\r\n| `ACID(43)` |           `rlocusPlot` |       :white_check_mark: |                                                                             |\r\n| `ACID(48)` |          `zplanePlot2` | :heavy_exclamation_mark: | hash 4c2f1fea92ce3c969475e3f6b40f87cf != (fb3ba1a4db46c9975cd00e6da99ebe48) |\r\n| `ACID(58)` |            `surfPlot2` | :heavy_exclamation_mark: | hash 520bba1c7a536efb15c82dfcc8ce6a23 != (eb8e6d18db994ba4a90e177bd44b5db3) |\r\n| `ACID(94)` | `stackedBarsWithOther` |       :white_check_mark: |                                                                             |\r\n| `ACID(97)` |     `overlappingPlots` |       :white_check_mark: |                                                                             |\r\n\r\n## Reliable tests\r\nOnly the reliable tests determine the build outcome.\r\nPassing tests are not shown (only failed and skipped tests).\r\n\r\n|   Testcase |               Name |                       OK |                                                                      Status |\r\n| :--------- | :----------------- | :----------------------: | :-------------------------------------------------------------------------- |\r\n|  `ACID(8)` |    `peaks_contour` | :heavy_exclamation_mark: | hash 4c0f04124b13d5c12351f4875455a67d != (8885c9a4185aaca594ce5d0139aa578b) |\r\n|  `ACID(9)` |     `contourPenny` | :heavy_exclamation_mark: | hash 1bbca20d0029e2e510eb5d7c46222ee7 != (3ee200ec93371666499d72f790ee9bb3) |\r\n| `ACID(12)` |  `double_colorbar` | :heavy_exclamation_mark: | hash 44a0d0b4b35ed634d2f2f568e51f2c8a != (6355484ba42b84205cd6a7d6de76711d) |\r\n| `ACID(14)` |      `double_axes` | :heavy_exclamation_mark: | hash a053ed16097389ed6d6cfe6f353a46ab != (331441239c1bb077aebaf5ce8abe55f1) |\r\n| `ACID(15)` |     `double_axes2` | :heavy_exclamation_mark: | hash ec8ccb7d178fd3e0227fd2cf3b210fa0 != (739edbf88cbf57187bea11ef93ebbf9a) |\r\n| `ACID(21)` |             `zoom` | :heavy_exclamation_mark: | hash c64f7b3b3706f195123ca0c46f1de987 != (817b9999d832dc238b89573037cabc81) |\r\n| `ACID(23)` |       `quiverplot` | :heavy_exclamation_mark: | hash 6f6723cafaf167b8e13d62f56b5a0aff != (308f4ce197791f2fd5862768e1157ca8) |\r\n| `ACID(47)` |      `zplanePlot1` | :heavy_exclamation_mark: | hash 484cf570b96ae970b4e36e09d091168e != (03f1e3fabe0d9afe6692d42aa64da78e) |\r\n| `ACID(49)` | `freqResponsePlot` | :heavy_exclamation_mark: | hash 9b96a2b4111965cf9f85a61979aa837f != (396383b779bf45e50cc0561803efb4b3) |\r\n| `ACID(62)` |          `spectro` | :heavy_exclamation_mark: | hash e871a0b852a68fe12d78eead39e3de3b != (4426bb06bb44d08d016595f585fb01da) |\r\n| `ACID(71)` |    `parameterSurf` | :heavy_exclamation_mark: | hash e64030978c54cc260847bf78a8c6ea6a != (12522a58d7e3d8dc7f4e38a0970bf047) |\r\n| `ACID(17)` |  `colorbarLogplot` |          :grey_question: |                                                                     SKIPPED |\r\n\r\n## Test summary\r\nTest results for m2t commit 9f193c4675 running with MATLAB 8.5 on Linux\r\n 3.13.0-62-generic.\r\n\r\n```matlab\r\nsuite = @ACID;\r\nalltests = [1:99];\r\nreliable = [2:5 7:9 11:15 17 19:23 25:33 35:37 39 41 44:47 49:57 59:93 95:96 98:99];\r\nunreliable = [1 6 10 16 18 24 34 38 40 42:43 48 58 94 97];\r\nfailReliable = [8:9 12 14:15 21 23 47 49 62 71];\r\npassUnreliable = [16 24 34 38 40 43 94 97];\r\nskipped = [17];\r\n```\r\n\r\n|            | Pass | Fail | Skip | Total |\r\n| :--------- | ---: | ---: | ---: | ----: |\r\n| Unreliable |    8 |    7 |    0 |    15 |\r\n|   Reliable |   72 |   11 |    1 |    84 |\r\n|      Total |   80 |   18 |    1 |    99 |\r\n\r\nBuild fails with 11 errors. :heavy_exclamation_mark:\r\n\r\nHowever, I have again checked the end result and cannot find any difference between the resulting Images."},"comment":{"url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/comments/136765106","html_url":"https://github.com/matlab2tikz/matlab2tikz/pull/750#issuecomment-136765106","issue_url":"https://api.github.com/repos/matlab2tikz/matlab2tikz/issues/750","id":136765106,"user":{"login":"miscco","id":3017120,"avatar_url":"https://avatars.githubusercontent.com/u/3017120?v=3","gravatar_id":"","url":"https://api.github.com/users/miscco","html_url":"https://github.com/miscco","followers_url":"https://api.github.com/users/miscco/followers","following_url":"https://api.github.com/users/miscco/following{/other_user}","gists_url":"https://api.github.com/users/miscco/gists{/gist_id}","starred_url":"https://api.github.com/users/miscco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miscco/subscriptions","organizations_url":"https://api.github.com/users/miscco/orgs","repos_url":"https://api.github.com/users/miscco/repos","events_url":"https://api.github.com/users/miscco/events{/privacy}","received_events_url":"https://api.github.com/users/miscco/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T15:42:21Z","updated_at":"2015-09-01T15:42:21Z","body":"True,\r\n\r\ncould you please check test 23 in Octave 3.8. In 4.0 I cant see any difference."}}