{"action":"created","comment":{"url":"https://api.github.com/repos/grouplens/grapht/pulls/comments/24716956","id":24716956,"diff_hunk":"@@ -98,38 +106,51 @@ public Object instantiate() throws ConstructionException {\n         } catch (IllegalAccessException e) {\n             throw new ConstructionException(ctor, \"Access violation on \" + ctor, e);\n         }\n+        finally {\n+            mdcContext.finish();\n+        }\n \n         // satisfy dependencies in the order of the list, which was\n         // prepared to comply with JSR 330\n         Map<Method, InjectionArgs> settersAndArguments = new HashMap<Method, InjectionArgs>();\n         for (Desire d: desires) {\n             if (d.getInjectionPoint() instanceof FieldInjectionPoint) {\n+                LogContext mdcContextInjectionPointFieldValue = LogContext.create();","path":"src/main/java/org/grouplens/grapht/reflect/internal/ClassInstantiator.java","position":83,"original_position":83,"commit_id":"f39f9345e4c0a630f3e8f86c0f74291eb9f094f6","original_commit_id":"f39f9345e4c0a630f3e8f86c0f74291eb9f094f6","user":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"body":"Again, we need to start the `try` that closes this context right away. Also, we want to put the `put` statements right away, so that they are in effect when we instantiate the injection point.\r\n\r\nThe key point is that when we call `instantiate()` on the instantiator, down on line 120, the relevant value needs to be in the MDC.\r\n\r\nI think that we can just use a single key, `org.grouplens.grapht.injectionPoint`, with the `toString()` of the injection point object, instead of separate keys. Injection points do a good job of describing themselves in `toString()`.","created_at":"2015-02-14T20:12:02Z","updated_at":"2015-02-14T20:12:02Z","html_url":"https://github.com/grouplens/grapht/pull/109#discussion_r24716956","pull_request_url":"https://api.github.com/repos/grouplens/grapht/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/comments/24716956"},"html":{"href":"https://github.com/grouplens/grapht/pull/109#discussion_r24716956"},"pull_request":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/grouplens/grapht/pulls/109","id":29272075,"html_url":"https://github.com/grouplens/grapht/pull/109","diff_url":"https://github.com/grouplens/grapht/pull/109.diff","patch_url":"https://github.com/grouplens/grapht/pull/109.patch","issue_url":"https://api.github.com/repos/grouplens/grapht/issues/109","number":109,"state":"open","locked":false,"title":"changes for defect-#52","user":{"login":"ikz0809","id":10852317,"avatar_url":"https://avatars.githubusercontent.com/u/10852317?v=3","gravatar_id":"","url":"https://api.github.com/users/ikz0809","html_url":"https://github.com/ikz0809","followers_url":"https://api.github.com/users/ikz0809/followers","following_url":"https://api.github.com/users/ikz0809/following{/other_user}","gists_url":"https://api.github.com/users/ikz0809/gists{/gist_id}","starred_url":"https://api.github.com/users/ikz0809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikz0809/subscriptions","organizations_url":"https://api.github.com/users/ikz0809/orgs","repos_url":"https://api.github.com/users/ikz0809/repos","events_url":"https://api.github.com/users/ikz0809/events{/privacy}","received_events_url":"https://api.github.com/users/ikz0809/received_events","type":"User","site_admin":false},"body":"Defect #52 MDC Logger Changes","created_at":"2015-02-13T15:20:38Z","updated_at":"2015-02-14T20:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7afc82c04ddb8b595f3242d55c8582bb5007d452","assignee":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/grouplens/grapht/milestones/14","labels_url":"https://api.github.com/repos/grouplens/grapht/milestones/14/labels","id":806991,"number":14,"title":"0.10","description":null,"creator":{"login":"elehack","id":186612,"avatar_url":"https://avatars.githubusercontent.com/u/186612?v=3","gravatar_id":"","url":"https://api.github.com/users/elehack","html_url":"https://github.com/elehack","followers_url":"https://api.github.com/users/elehack/followers","following_url":"https://api.github.com/users/elehack/following{/other_user}","gists_url":"https://api.github.com/users/elehack/gists{/gist_id}","starred_url":"https://api.github.com/users/elehack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elehack/subscriptions","organizations_url":"https://api.github.com/users/elehack/orgs","repos_url":"https://api.github.com/users/elehack/repos","events_url":"https://api.github.com/users/elehack/events{/privacy}","received_events_url":"https://api.github.com/users/elehack/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2014-09-29T16:20:43Z","updated_at":"2015-02-13T15:38:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/grouplens/grapht/pulls/109/commits","review_comments_url":"https://api.github.com/repos/grouplens/grapht/pulls/109/comments","review_comment_url":"https://api.github.com/repos/grouplens/grapht/pulls/comments/{number}","comments_url":"https://api.github.com/repos/grouplens/grapht/issues/109/comments","statuses_url":"https://api.github.com/repos/grouplens/grapht/statuses/f39f9345e4c0a630f3e8f86c0f74291eb9f094f6","head":{"label":"ikz0809:master","ref":"master","sha":"f39f9345e4c0a630f3e8f86c0f74291eb9f094f6","user":{"login":"ikz0809","id":10852317,"avatar_url":"https://avatars.githubusercontent.com/u/10852317?v=3","gravatar_id":"","url":"https://api.github.com/users/ikz0809","html_url":"https://github.com/ikz0809","followers_url":"https://api.github.com/users/ikz0809/followers","following_url":"https://api.github.com/users/ikz0809/following{/other_user}","gists_url":"https://api.github.com/users/ikz0809/gists{/gist_id}","starred_url":"https://api.github.com/users/ikz0809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikz0809/subscriptions","organizations_url":"https://api.github.com/users/ikz0809/orgs","repos_url":"https://api.github.com/users/ikz0809/repos","events_url":"https://api.github.com/users/ikz0809/events{/privacy}","received_events_url":"https://api.github.com/users/ikz0809/received_events","type":"User","site_admin":false},"repo":{"id":30341365,"name":"grapht","full_name":"ikz0809/grapht","owner":{"login":"ikz0809","id":10852317,"avatar_url":"https://avatars.githubusercontent.com/u/10852317?v=3","gravatar_id":"","url":"https://api.github.com/users/ikz0809","html_url":"https://github.com/ikz0809","followers_url":"https://api.github.com/users/ikz0809/followers","following_url":"https://api.github.com/users/ikz0809/following{/other_user}","gists_url":"https://api.github.com/users/ikz0809/gists{/gist_id}","starred_url":"https://api.github.com/users/ikz0809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikz0809/subscriptions","organizations_url":"https://api.github.com/users/ikz0809/orgs","repos_url":"https://api.github.com/users/ikz0809/repos","events_url":"https://api.github.com/users/ikz0809/events{/privacy}","received_events_url":"https://api.github.com/users/ikz0809/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikz0809/grapht","description":"Grapht dependency injector.","fork":true,"url":"https://api.github.com/repos/ikz0809/grapht","forks_url":"https://api.github.com/repos/ikz0809/grapht/forks","keys_url":"https://api.github.com/repos/ikz0809/grapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikz0809/grapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikz0809/grapht/teams","hooks_url":"https://api.github.com/repos/ikz0809/grapht/hooks","issue_events_url":"https://api.github.com/repos/ikz0809/grapht/issues/events{/number}","events_url":"https://api.github.com/repos/ikz0809/grapht/events","assignees_url":"https://api.github.com/repos/ikz0809/grapht/assignees{/user}","branches_url":"https://api.github.com/repos/ikz0809/grapht/branches{/branch}","tags_url":"https://api.github.com/repos/ikz0809/grapht/tags","blobs_url":"https://api.github.com/repos/ikz0809/grapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikz0809/grapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikz0809/grapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikz0809/grapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikz0809/grapht/statuses/{sha}","languages_url":"https://api.github.com/repos/ikz0809/grapht/languages","stargazers_url":"https://api.github.com/repos/ikz0809/grapht/stargazers","contributors_url":"https://api.github.com/repos/ikz0809/grapht/contributors","subscribers_url":"https://api.github.com/repos/ikz0809/grapht/subscribers","subscription_url":"https://api.github.com/repos/ikz0809/grapht/subscription","commits_url":"https://api.github.com/repos/ikz0809/grapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikz0809/grapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikz0809/grapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikz0809/grapht/issues/comments/{number}","contents_url":"https://api.github.com/repos/ikz0809/grapht/contents/{+path}","compare_url":"https://api.github.com/repos/ikz0809/grapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikz0809/grapht/merges","archive_url":"https://api.github.com/repos/ikz0809/grapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikz0809/grapht/downloads","issues_url":"https://api.github.com/repos/ikz0809/grapht/issues{/number}","pulls_url":"https://api.github.com/repos/ikz0809/grapht/pulls{/number}","milestones_url":"https://api.github.com/repos/ikz0809/grapht/milestones{/number}","notifications_url":"https://api.github.com/repos/ikz0809/grapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikz0809/grapht/labels{/name}","releases_url":"https://api.github.com/repos/ikz0809/grapht/releases{/id}","created_at":"2015-02-05T06:27:06Z","updated_at":"2015-02-14T07:32:41Z","pushed_at":"2015-02-14T07:32:39Z","git_url":"git://github.com/ikz0809/grapht.git","ssh_url":"git@github.com:ikz0809/grapht.git","clone_url":"https://github.com/ikz0809/grapht.git","svn_url":"https://github.com/ikz0809/grapht","homepage":null,"size":3270,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grouplens:master","ref":"master","sha":"97f8158ddde8f859e2710c3e8bf0741cea6900c4","user":{"login":"grouplens","id":5495590,"avatar_url":"https://avatars.githubusercontent.com/u/5495590?v=3","gravatar_id":"","url":"https://api.github.com/users/grouplens","html_url":"https://github.com/grouplens","followers_url":"https://api.github.com/users/grouplens/followers","following_url":"https://api.github.com/users/grouplens/following{/other_user}","gists_url":"https://api.github.com/users/grouplens/gists{/gist_id}","starred_url":"https://api.github.com/users/grouplens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouplens/subscriptions","organizations_url":"https://api.github.com/users/grouplens/orgs","repos_url":"https://api.github.com/users/grouplens/repos","events_url":"https://api.github.com/users/grouplens/events{/privacy}","received_events_url":"https://api.github.com/users/grouplens/received_events","type":"Organization","site_admin":false},"repo":{"id":12996695,"name":"grapht","full_name":"grouplens/grapht","owner":{"login":"grouplens","id":5495590,"avatar_url":"https://avatars.githubusercontent.com/u/5495590?v=3","gravatar_id":"","url":"https://api.github.com/users/grouplens","html_url":"https://github.com/grouplens","followers_url":"https://api.github.com/users/grouplens/followers","following_url":"https://api.github.com/users/grouplens/following{/other_user}","gists_url":"https://api.github.com/users/grouplens/gists{/gist_id}","starred_url":"https://api.github.com/users/grouplens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grouplens/subscriptions","organizations_url":"https://api.github.com/users/grouplens/orgs","repos_url":"https://api.github.com/users/grouplens/repos","events_url":"https://api.github.com/users/grouplens/events{/privacy}","received_events_url":"https://api.github.com/users/grouplens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grouplens/grapht","description":"Grapht dependency injector.","fork":false,"url":"https://api.github.com/repos/grouplens/grapht","forks_url":"https://api.github.com/repos/grouplens/grapht/forks","keys_url":"https://api.github.com/repos/grouplens/grapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grouplens/grapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grouplens/grapht/teams","hooks_url":"https://api.github.com/repos/grouplens/grapht/hooks","issue_events_url":"https://api.github.com/repos/grouplens/grapht/issues/events{/number}","events_url":"https://api.github.com/repos/grouplens/grapht/events","assignees_url":"https://api.github.com/repos/grouplens/grapht/assignees{/user}","branches_url":"https://api.github.com/repos/grouplens/grapht/branches{/branch}","tags_url":"https://api.github.com/repos/grouplens/grapht/tags","blobs_url":"https://api.github.com/repos/grouplens/grapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grouplens/grapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grouplens/grapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/grouplens/grapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grouplens/grapht/statuses/{sha}","languages_url":"https://api.github.com/repos/grouplens/grapht/languages","stargazers_url":"https://api.github.com/repos/grouplens/grapht/stargazers","contributors_url":"https://api.github.com/repos/grouplens/grapht/contributors","subscribers_url":"https://api.github.com/repos/grouplens/grapht/subscribers","subscription_url":"https://api.github.com/repos/grouplens/grapht/subscription","commits_url":"https://api.github.com/repos/grouplens/grapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/grouplens/grapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/grouplens/grapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/grouplens/grapht/issues/comments/{number}","contents_url":"https://api.github.com/repos/grouplens/grapht/contents/{+path}","compare_url":"https://api.github.com/repos/grouplens/grapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grouplens/grapht/merges","archive_url":"https://api.github.com/repos/grouplens/grapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grouplens/grapht/downloads","issues_url":"https://api.github.com/repos/grouplens/grapht/issues{/number}","pulls_url":"https://api.github.com/repos/grouplens/grapht/pulls{/number}","milestones_url":"https://api.github.com/repos/grouplens/grapht/milestones{/number}","notifications_url":"https://api.github.com/repos/grouplens/grapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grouplens/grapht/labels{/name}","releases_url":"https://api.github.com/repos/grouplens/grapht/releases{/id}","created_at":"2013-09-21T14:45:45Z","updated_at":"2015-01-30T22:28:21Z","pushed_at":"2015-01-30T22:28:20Z","git_url":"git://github.com/grouplens/grapht.git","ssh_url":"git@github.com:grouplens/grapht.git","clone_url":"https://github.com/grouplens/grapht.git","svn_url":"https://github.com/grouplens/grapht","homepage":null,"size":3858,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":23,"forks":5,"open_issues":23,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/109"},"html":{"href":"https://github.com/grouplens/grapht/pull/109"},"issue":{"href":"https://api.github.com/repos/grouplens/grapht/issues/109"},"comments":{"href":"https://api.github.com/repos/grouplens/grapht/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/grouplens/grapht/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/grouplens/grapht/statuses/f39f9345e4c0a630f3e8f86c0f74291eb9f094f6"}}}}