{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10","id":40063116,"html_url":"https://github.com/promet/bulk_file_nodes/pull/10","diff_url":"https://github.com/promet/bulk_file_nodes/pull/10.diff","patch_url":"https://github.com/promet/bulk_file_nodes/pull/10.patch","issue_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/10","number":10,"state":"closed","locked":false,"title":"PTPIHSR-30: Make sure the image filename is maintained.","user":{"login":"johnrosswvsu","id":1127237,"avatar_url":"https://avatars.githubusercontent.com/u/1127237?v=3","gravatar_id":"","url":"https://api.github.com/users/johnrosswvsu","html_url":"https://github.com/johnrosswvsu","followers_url":"https://api.github.com/users/johnrosswvsu/followers","following_url":"https://api.github.com/users/johnrosswvsu/following{/other_user}","gists_url":"https://api.github.com/users/johnrosswvsu/gists{/gist_id}","starred_url":"https://api.github.com/users/johnrosswvsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnrosswvsu/subscriptions","organizations_url":"https://api.github.com/users/johnrosswvsu/orgs","repos_url":"https://api.github.com/users/johnrosswvsu/repos","events_url":"https://api.github.com/users/johnrosswvsu/events{/privacy}","received_events_url":"https://api.github.com/users/johnrosswvsu/received_events","type":"User","site_admin":false},"body":"Allow to use the same filename, but update image information\r\nONLY if image URI has changed.\r\n\r\nOriginally, the module changes the location and filename to [scheme]-[user-id]-[file-count-by-user].[extension] format, which is technically dirty and unwanted by client. Example: URI: public://1-1.jpg and filename 1-1.jpg.\r\n\r\nThe client does not want this behavior and wanted the filenames to be the same when it was uploaded.\r\n\r\nThe fix is to use the same filename instead of the format above. In addition, this module temporarily uploads the file to the public scheme thus it has to move the file to the correct scheme when saving on a per node basis. Not all file settings are in public.\r\n\r\nSo, I added a condition only to move the file if the temporary public location is not the same to the actual file scheme setting. If they are similar simply copy the temporary file array or file info. If not move to appropriate scheme.","created_at":"2015-07-15T20:00:53Z","updated_at":"2015-07-15T20:16:22Z","closed_at":"2015-07-15T20:16:22Z","merged_at":"2015-07-15T20:16:22Z","merge_commit_sha":"ddc15748cfc5601627d88c6508777f525413c608","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10/commits","review_comments_url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10/comments","review_comment_url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/10/comments","statuses_url":"https://api.github.com/repos/promet/bulk_file_nodes/statuses/fce7bfab473a8a8ecd8635b928d4ba9e6247d7f7","head":{"label":"promet:feature-PTPIHSR-30-maintain-file-names","ref":"feature-PTPIHSR-30-maintain-file-names","sha":"fce7bfab473a8a8ecd8635b928d4ba9e6247d7f7","user":{"login":"promet","id":1825384,"avatar_url":"https://avatars.githubusercontent.com/u/1825384?v=3","gravatar_id":"","url":"https://api.github.com/users/promet","html_url":"https://github.com/promet","followers_url":"https://api.github.com/users/promet/followers","following_url":"https://api.github.com/users/promet/following{/other_user}","gists_url":"https://api.github.com/users/promet/gists{/gist_id}","starred_url":"https://api.github.com/users/promet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promet/subscriptions","organizations_url":"https://api.github.com/users/promet/orgs","repos_url":"https://api.github.com/users/promet/repos","events_url":"https://api.github.com/users/promet/events{/privacy}","received_events_url":"https://api.github.com/users/promet/received_events","type":"Organization","site_admin":false},"repo":{"id":26595682,"name":"bulk_file_nodes","full_name":"promet/bulk_file_nodes","owner":{"login":"promet","id":1825384,"avatar_url":"https://avatars.githubusercontent.com/u/1825384?v=3","gravatar_id":"","url":"https://api.github.com/users/promet","html_url":"https://github.com/promet","followers_url":"https://api.github.com/users/promet/followers","following_url":"https://api.github.com/users/promet/following{/other_user}","gists_url":"https://api.github.com/users/promet/gists{/gist_id}","starred_url":"https://api.github.com/users/promet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promet/subscriptions","organizations_url":"https://api.github.com/users/promet/orgs","repos_url":"https://api.github.com/users/promet/repos","events_url":"https://api.github.com/users/promet/events{/privacy}","received_events_url":"https://api.github.com/users/promet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/promet/bulk_file_nodes","description":"Bulk File Nodes drupal module fork","fork":false,"url":"https://api.github.com/repos/promet/bulk_file_nodes","forks_url":"https://api.github.com/repos/promet/bulk_file_nodes/forks","keys_url":"https://api.github.com/repos/promet/bulk_file_nodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/promet/bulk_file_nodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/promet/bulk_file_nodes/teams","hooks_url":"https://api.github.com/repos/promet/bulk_file_nodes/hooks","issue_events_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/events{/number}","events_url":"https://api.github.com/repos/promet/bulk_file_nodes/events","assignees_url":"https://api.github.com/repos/promet/bulk_file_nodes/assignees{/user}","branches_url":"https://api.github.com/repos/promet/bulk_file_nodes/branches{/branch}","tags_url":"https://api.github.com/repos/promet/bulk_file_nodes/tags","blobs_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/promet/bulk_file_nodes/statuses/{sha}","languages_url":"https://api.github.com/repos/promet/bulk_file_nodes/languages","stargazers_url":"https://api.github.com/repos/promet/bulk_file_nodes/stargazers","contributors_url":"https://api.github.com/repos/promet/bulk_file_nodes/contributors","subscribers_url":"https://api.github.com/repos/promet/bulk_file_nodes/subscribers","subscription_url":"https://api.github.com/repos/promet/bulk_file_nodes/subscription","commits_url":"https://api.github.com/repos/promet/bulk_file_nodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/promet/bulk_file_nodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/promet/bulk_file_nodes/contents/{+path}","compare_url":"https://api.github.com/repos/promet/bulk_file_nodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/promet/bulk_file_nodes/merges","archive_url":"https://api.github.com/repos/promet/bulk_file_nodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/promet/bulk_file_nodes/downloads","issues_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues{/number}","pulls_url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls{/number}","milestones_url":"https://api.github.com/repos/promet/bulk_file_nodes/milestones{/number}","notifications_url":"https://api.github.com/repos/promet/bulk_file_nodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/promet/bulk_file_nodes/labels{/name}","releases_url":"https://api.github.com/repos/promet/bulk_file_nodes/releases{/id}","created_at":"2014-11-13T16:03:09Z","updated_at":"2015-03-17T10:39:14Z","pushed_at":"2015-07-15T20:16:22Z","git_url":"git://github.com/promet/bulk_file_nodes.git","ssh_url":"git@github.com:promet/bulk_file_nodes.git","clone_url":"https://github.com/promet/bulk_file_nodes.git","svn_url":"https://github.com/promet/bulk_file_nodes","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":0,"default_branch":"7.x-1.0"}},"base":{"label":"promet:7.x-1.x-patched","ref":"7.x-1.x-patched","sha":"a566495b641cfe921ad27450d07c3c638e5f5333","user":{"login":"promet","id":1825384,"avatar_url":"https://avatars.githubusercontent.com/u/1825384?v=3","gravatar_id":"","url":"https://api.github.com/users/promet","html_url":"https://github.com/promet","followers_url":"https://api.github.com/users/promet/followers","following_url":"https://api.github.com/users/promet/following{/other_user}","gists_url":"https://api.github.com/users/promet/gists{/gist_id}","starred_url":"https://api.github.com/users/promet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promet/subscriptions","organizations_url":"https://api.github.com/users/promet/orgs","repos_url":"https://api.github.com/users/promet/repos","events_url":"https://api.github.com/users/promet/events{/privacy}","received_events_url":"https://api.github.com/users/promet/received_events","type":"Organization","site_admin":false},"repo":{"id":26595682,"name":"bulk_file_nodes","full_name":"promet/bulk_file_nodes","owner":{"login":"promet","id":1825384,"avatar_url":"https://avatars.githubusercontent.com/u/1825384?v=3","gravatar_id":"","url":"https://api.github.com/users/promet","html_url":"https://github.com/promet","followers_url":"https://api.github.com/users/promet/followers","following_url":"https://api.github.com/users/promet/following{/other_user}","gists_url":"https://api.github.com/users/promet/gists{/gist_id}","starred_url":"https://api.github.com/users/promet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promet/subscriptions","organizations_url":"https://api.github.com/users/promet/orgs","repos_url":"https://api.github.com/users/promet/repos","events_url":"https://api.github.com/users/promet/events{/privacy}","received_events_url":"https://api.github.com/users/promet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/promet/bulk_file_nodes","description":"Bulk File Nodes drupal module fork","fork":false,"url":"https://api.github.com/repos/promet/bulk_file_nodes","forks_url":"https://api.github.com/repos/promet/bulk_file_nodes/forks","keys_url":"https://api.github.com/repos/promet/bulk_file_nodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/promet/bulk_file_nodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/promet/bulk_file_nodes/teams","hooks_url":"https://api.github.com/repos/promet/bulk_file_nodes/hooks","issue_events_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/events{/number}","events_url":"https://api.github.com/repos/promet/bulk_file_nodes/events","assignees_url":"https://api.github.com/repos/promet/bulk_file_nodes/assignees{/user}","branches_url":"https://api.github.com/repos/promet/bulk_file_nodes/branches{/branch}","tags_url":"https://api.github.com/repos/promet/bulk_file_nodes/tags","blobs_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/promet/bulk_file_nodes/statuses/{sha}","languages_url":"https://api.github.com/repos/promet/bulk_file_nodes/languages","stargazers_url":"https://api.github.com/repos/promet/bulk_file_nodes/stargazers","contributors_url":"https://api.github.com/repos/promet/bulk_file_nodes/contributors","subscribers_url":"https://api.github.com/repos/promet/bulk_file_nodes/subscribers","subscription_url":"https://api.github.com/repos/promet/bulk_file_nodes/subscription","commits_url":"https://api.github.com/repos/promet/bulk_file_nodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/promet/bulk_file_nodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/promet/bulk_file_nodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/promet/bulk_file_nodes/contents/{+path}","compare_url":"https://api.github.com/repos/promet/bulk_file_nodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/promet/bulk_file_nodes/merges","archive_url":"https://api.github.com/repos/promet/bulk_file_nodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/promet/bulk_file_nodes/downloads","issues_url":"https://api.github.com/repos/promet/bulk_file_nodes/issues{/number}","pulls_url":"https://api.github.com/repos/promet/bulk_file_nodes/pulls{/number}","milestones_url":"https://api.github.com/repos/promet/bulk_file_nodes/milestones{/number}","notifications_url":"https://api.github.com/repos/promet/bulk_file_nodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/promet/bulk_file_nodes/labels{/name}","releases_url":"https://api.github.com/repos/promet/bulk_file_nodes/releases{/id}","created_at":"2014-11-13T16:03:09Z","updated_at":"2015-03-17T10:39:14Z","pushed_at":"2015-07-15T20:16:22Z","git_url":"git://github.com/promet/bulk_file_nodes.git","ssh_url":"git@github.com:promet/bulk_file_nodes.git","clone_url":"https://github.com/promet/bulk_file_nodes.git","svn_url":"https://github.com/promet/bulk_file_nodes","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":0,"default_branch":"7.x-1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10"},"html":{"href":"https://github.com/promet/bulk_file_nodes/pull/10"},"issue":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/issues/10"},"comments":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/promet/bulk_file_nodes/statuses/fce7bfab473a8a8ecd8635b928d4ba9e6247d7f7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"generalredneck","id":526491,"avatar_url":"https://avatars.githubusercontent.com/u/526491?v=3","gravatar_id":"","url":"https://api.github.com/users/generalredneck","html_url":"https://github.com/generalredneck","followers_url":"https://api.github.com/users/generalredneck/followers","following_url":"https://api.github.com/users/generalredneck/following{/other_user}","gists_url":"https://api.github.com/users/generalredneck/gists{/gist_id}","starred_url":"https://api.github.com/users/generalredneck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/generalredneck/subscriptions","organizations_url":"https://api.github.com/users/generalredneck/orgs","repos_url":"https://api.github.com/users/generalredneck/repos","events_url":"https://api.github.com/users/generalredneck/events{/privacy}","received_events_url":"https://api.github.com/users/generalredneck/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":2,"additions":8,"deletions":4,"changed_files":1}}