{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/firefox-ios/issues/938","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/938/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/938/comments","events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/938/events","html_url":"https://github.com/mozilla/firefox-ios/pull/938","id":101259832,"number":938,"title":"Bug 1162843 - Allow searching for multiple non-consecutive words in a title","user":{"login":"Johennes","id":1137962,"avatar_url":"https://avatars.githubusercontent.com/u/1137962?v=3","gravatar_id":"","url":"https://api.github.com/users/Johennes","html_url":"https://github.com/Johennes","followers_url":"https://api.github.com/users/Johennes/followers","following_url":"https://api.github.com/users/Johennes/following{/other_user}","gists_url":"https://api.github.com/users/Johennes/gists{/gist_id}","starred_url":"https://api.github.com/users/Johennes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Johennes/subscriptions","organizations_url":"https://api.github.com/users/Johennes/orgs","repos_url":"https://api.github.com/users/Johennes/repos","events_url":"https://api.github.com/users/Johennes/events{/privacy}","received_events_url":"https://api.github.com/users/Johennes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-16T12:32:23Z","updated_at":"2015-08-16T16:22:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/938","html_url":"https://github.com/mozilla/firefox-ios/pull/938","diff_url":"https://github.com/mozilla/firefox-ios/pull/938.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/938.patch"},"body":"I'd appreciate some feedback here. I have a feeling my code might be a little too compact and could be hard to read. I could make it more expressive by using a dedicated `for` loop. I'm also thinking about adding unit tests for this but I wanted to get some early opinion first."},"comment":{"url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments/131578258","html_url":"https://github.com/mozilla/firefox-ios/pull/938#issuecomment-131578258","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/938","id":131578258,"user":{"login":"rnewman","id":91722,"avatar_url":"https://avatars.githubusercontent.com/u/91722?v=3","gravatar_id":"","url":"https://api.github.com/users/rnewman","html_url":"https://github.com/rnewman","followers_url":"https://api.github.com/users/rnewman/followers","following_url":"https://api.github.com/users/rnewman/following{/other_user}","gists_url":"https://api.github.com/users/rnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/rnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnewman/subscriptions","organizations_url":"https://api.github.com/users/rnewman/orgs","repos_url":"https://api.github.com/users/rnewman/repos","events_url":"https://api.github.com/users/rnewman/events{/privacy}","received_events_url":"https://api.github.com/users/rnewman/received_events","type":"User","site_admin":false},"created_at":"2015-08-16T16:22:29Z","updated_at":"2015-08-16T16:22:29Z","body":"I'd want to see a query plan and some perf measurements for this before moving forward. Best-case this is still a single table scan, but it's doing a linear string match for each substring, and who knows what the worst case is.\r\n\r\nBug 1194325 is likely to make our perf slightly worse, not better, so we have to be conscious of the costs and benefits.\r\n\r\nI'd also like someone to figure out what our FTS story is.\r\n\r\nIt's also worth thinking about whether or how this can interact with ranking, and whether it's worthwhile introducing the concept of matching the whole entered substring."}}