{"action":"created","comment":{"url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/comments/32115065","id":32115065,"diff_hunk":"@@ -150,9 +150,10 @@ public bool Equals(BoundingFrustum other)\n         /// </returns>\n         public override bool Equals(object obj)\n         {\n-            if (obj != null && obj is BoundingFrustum)\n-                return Equals((BoundingFrustum)obj);\n-            return false;\n+            if(!(obj is BoundingBox))","path":"Source/SharpDX.Mathematics/BoundingFrustum.cs","position":7,"original_position":7,"commit_id":"a87b1ab0cea60fa9ca05a4eea8e0a271d15756ff","original_commit_id":"a87b1ab0cea60fa9ca05a4eea8e0a271d15756ff","user":{"login":"xoofx","id":715038,"avatar_url":"https://avatars.githubusercontent.com/u/715038?v=3","gravatar_id":"","url":"https://api.github.com/users/xoofx","html_url":"https://github.com/xoofx","followers_url":"https://api.github.com/users/xoofx/followers","following_url":"https://api.github.com/users/xoofx/following{/other_user}","gists_url":"https://api.github.com/users/xoofx/gists{/gist_id}","starred_url":"https://api.github.com/users/xoofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoofx/subscriptions","organizations_url":"https://api.github.com/users/xoofx/orgs","repos_url":"https://api.github.com/users/xoofx/repos","events_url":"https://api.github.com/users/xoofx/events{/privacy}","received_events_url":"https://api.github.com/users/xoofx/received_events","type":"User","site_admin":false},"body":"Be careful, this should be `BoudingFrustum` instead of `BoudingBox`","created_at":"2015-06-10T13:12:56Z","updated_at":"2015-06-10T13:12:56Z","html_url":"https://github.com/sharpdx/SharpDX/pull/597#discussion_r32115065","pull_request_url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597","_links":{"self":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/comments/32115065"},"html":{"href":"https://github.com/sharpdx/SharpDX/pull/597#discussion_r32115065"},"pull_request":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597"}}},"pull_request":{"url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597","id":37096046,"html_url":"https://github.com/sharpdx/SharpDX/pull/597","diff_url":"https://github.com/sharpdx/SharpDX/pull/597.diff","patch_url":"https://github.com/sharpdx/SharpDX/pull/597.patch","issue_url":"https://api.github.com/repos/sharpdx/SharpDX/issues/597","number":597,"state":"open","locked":false,"title":"Improve Equals(object) in SharpDx.Mathematics.","user":{"login":"andrewst","id":828244,"avatar_url":"https://avatars.githubusercontent.com/u/828244?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewst","html_url":"https://github.com/andrewst","followers_url":"https://api.github.com/users/andrewst/followers","following_url":"https://api.github.com/users/andrewst/following{/other_user}","gists_url":"https://api.github.com/users/andrewst/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewst/subscriptions","organizations_url":"https://api.github.com/users/andrewst/orgs","repos_url":"https://api.github.com/users/andrewst/repos","events_url":"https://api.github.com/users/andrewst/events{/privacy}","received_events_url":"https://api.github.com/users/andrewst/received_events","type":"User","site_admin":false},"body":"Hello,\r\nI propose to improve the Equals in SharpDx.Mathematics","created_at":"2015-06-06T20:17:14Z","updated_at":"2015-06-10T13:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e80013ecd2a15874eef72d36123901b2f07cdba5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597/commits","review_comments_url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597/comments","review_comment_url":"https://api.github.com/repos/sharpdx/SharpDX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sharpdx/SharpDX/issues/597/comments","statuses_url":"https://api.github.com/repos/sharpdx/SharpDX/statuses/a87b1ab0cea60fa9ca05a4eea8e0a271d15756ff","head":{"label":"andrewst:EqualsImprove","ref":"EqualsImprove","sha":"a87b1ab0cea60fa9ca05a4eea8e0a271d15756ff","user":{"login":"andrewst","id":828244,"avatar_url":"https://avatars.githubusercontent.com/u/828244?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewst","html_url":"https://github.com/andrewst","followers_url":"https://api.github.com/users/andrewst/followers","following_url":"https://api.github.com/users/andrewst/following{/other_user}","gists_url":"https://api.github.com/users/andrewst/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewst/subscriptions","organizations_url":"https://api.github.com/users/andrewst/orgs","repos_url":"https://api.github.com/users/andrewst/repos","events_url":"https://api.github.com/users/andrewst/events{/privacy}","received_events_url":"https://api.github.com/users/andrewst/received_events","type":"User","site_admin":false},"repo":{"id":36991429,"name":"SharpDX","full_name":"andrewst/SharpDX","owner":{"login":"andrewst","id":828244,"avatar_url":"https://avatars.githubusercontent.com/u/828244?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewst","html_url":"https://github.com/andrewst","followers_url":"https://api.github.com/users/andrewst/followers","following_url":"https://api.github.com/users/andrewst/following{/other_user}","gists_url":"https://api.github.com/users/andrewst/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewst/subscriptions","organizations_url":"https://api.github.com/users/andrewst/orgs","repos_url":"https://api.github.com/users/andrewst/repos","events_url":"https://api.github.com/users/andrewst/events{/privacy}","received_events_url":"https://api.github.com/users/andrewst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewst/SharpDX","description":"SharpDX GitHub Repository","fork":true,"url":"https://api.github.com/repos/andrewst/SharpDX","forks_url":"https://api.github.com/repos/andrewst/SharpDX/forks","keys_url":"https://api.github.com/repos/andrewst/SharpDX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewst/SharpDX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewst/SharpDX/teams","hooks_url":"https://api.github.com/repos/andrewst/SharpDX/hooks","issue_events_url":"https://api.github.com/repos/andrewst/SharpDX/issues/events{/number}","events_url":"https://api.github.com/repos/andrewst/SharpDX/events","assignees_url":"https://api.github.com/repos/andrewst/SharpDX/assignees{/user}","branches_url":"https://api.github.com/repos/andrewst/SharpDX/branches{/branch}","tags_url":"https://api.github.com/repos/andrewst/SharpDX/tags","blobs_url":"https://api.github.com/repos/andrewst/SharpDX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewst/SharpDX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewst/SharpDX/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewst/SharpDX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewst/SharpDX/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewst/SharpDX/languages","stargazers_url":"https://api.github.com/repos/andrewst/SharpDX/stargazers","contributors_url":"https://api.github.com/repos/andrewst/SharpDX/contributors","subscribers_url":"https://api.github.com/repos/andrewst/SharpDX/subscribers","subscription_url":"https://api.github.com/repos/andrewst/SharpDX/subscription","commits_url":"https://api.github.com/repos/andrewst/SharpDX/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewst/SharpDX/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewst/SharpDX/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewst/SharpDX/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewst/SharpDX/contents/{+path}","compare_url":"https://api.github.com/repos/andrewst/SharpDX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewst/SharpDX/merges","archive_url":"https://api.github.com/repos/andrewst/SharpDX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewst/SharpDX/downloads","issues_url":"https://api.github.com/repos/andrewst/SharpDX/issues{/number}","pulls_url":"https://api.github.com/repos/andrewst/SharpDX/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewst/SharpDX/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewst/SharpDX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewst/SharpDX/labels{/name}","releases_url":"https://api.github.com/repos/andrewst/SharpDX/releases{/id}","created_at":"2015-06-06T18:52:19Z","updated_at":"2015-06-06T18:52:26Z","pushed_at":"2015-06-06T20:04:37Z","git_url":"git://github.com/andrewst/SharpDX.git","ssh_url":"git@github.com:andrewst/SharpDX.git","clone_url":"https://github.com/andrewst/SharpDX.git","svn_url":"https://github.com/andrewst/SharpDX","homepage":null,"size":121752,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sharpdx:master_integration","ref":"master_integration","sha":"867d8210495444fd9094d8cfcdf30fad95c7bda8","user":{"login":"sharpdx","id":715251,"avatar_url":"https://avatars.githubusercontent.com/u/715251?v=3","gravatar_id":"","url":"https://api.github.com/users/sharpdx","html_url":"https://github.com/sharpdx","followers_url":"https://api.github.com/users/sharpdx/followers","following_url":"https://api.github.com/users/sharpdx/following{/other_user}","gists_url":"https://api.github.com/users/sharpdx/gists{/gist_id}","starred_url":"https://api.github.com/users/sharpdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharpdx/subscriptions","organizations_url":"https://api.github.com/users/sharpdx/orgs","repos_url":"https://api.github.com/users/sharpdx/repos","events_url":"https://api.github.com/users/sharpdx/events{/privacy}","received_events_url":"https://api.github.com/users/sharpdx/received_events","type":"Organization","site_admin":false},"repo":{"id":6595844,"name":"SharpDX","full_name":"sharpdx/SharpDX","owner":{"login":"sharpdx","id":715251,"avatar_url":"https://avatars.githubusercontent.com/u/715251?v=3","gravatar_id":"","url":"https://api.github.com/users/sharpdx","html_url":"https://github.com/sharpdx","followers_url":"https://api.github.com/users/sharpdx/followers","following_url":"https://api.github.com/users/sharpdx/following{/other_user}","gists_url":"https://api.github.com/users/sharpdx/gists{/gist_id}","starred_url":"https://api.github.com/users/sharpdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharpdx/subscriptions","organizations_url":"https://api.github.com/users/sharpdx/orgs","repos_url":"https://api.github.com/users/sharpdx/repos","events_url":"https://api.github.com/users/sharpdx/events{/privacy}","received_events_url":"https://api.github.com/users/sharpdx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sharpdx/SharpDX","description":"SharpDX GitHub Repository","fork":false,"url":"https://api.github.com/repos/sharpdx/SharpDX","forks_url":"https://api.github.com/repos/sharpdx/SharpDX/forks","keys_url":"https://api.github.com/repos/sharpdx/SharpDX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharpdx/SharpDX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharpdx/SharpDX/teams","hooks_url":"https://api.github.com/repos/sharpdx/SharpDX/hooks","issue_events_url":"https://api.github.com/repos/sharpdx/SharpDX/issues/events{/number}","events_url":"https://api.github.com/repos/sharpdx/SharpDX/events","assignees_url":"https://api.github.com/repos/sharpdx/SharpDX/assignees{/user}","branches_url":"https://api.github.com/repos/sharpdx/SharpDX/branches{/branch}","tags_url":"https://api.github.com/repos/sharpdx/SharpDX/tags","blobs_url":"https://api.github.com/repos/sharpdx/SharpDX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharpdx/SharpDX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharpdx/SharpDX/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharpdx/SharpDX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharpdx/SharpDX/statuses/{sha}","languages_url":"https://api.github.com/repos/sharpdx/SharpDX/languages","stargazers_url":"https://api.github.com/repos/sharpdx/SharpDX/stargazers","contributors_url":"https://api.github.com/repos/sharpdx/SharpDX/contributors","subscribers_url":"https://api.github.com/repos/sharpdx/SharpDX/subscribers","subscription_url":"https://api.github.com/repos/sharpdx/SharpDX/subscription","commits_url":"https://api.github.com/repos/sharpdx/SharpDX/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharpdx/SharpDX/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharpdx/SharpDX/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharpdx/SharpDX/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharpdx/SharpDX/contents/{+path}","compare_url":"https://api.github.com/repos/sharpdx/SharpDX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharpdx/SharpDX/merges","archive_url":"https://api.github.com/repos/sharpdx/SharpDX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharpdx/SharpDX/downloads","issues_url":"https://api.github.com/repos/sharpdx/SharpDX/issues{/number}","pulls_url":"https://api.github.com/repos/sharpdx/SharpDX/pulls{/number}","milestones_url":"https://api.github.com/repos/sharpdx/SharpDX/milestones{/number}","notifications_url":"https://api.github.com/repos/sharpdx/SharpDX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharpdx/SharpDX/labels{/name}","releases_url":"https://api.github.com/repos/sharpdx/SharpDX/releases{/id}","created_at":"2012-11-08T12:17:01Z","updated_at":"2015-06-09T08:00:43Z","pushed_at":"2015-06-09T12:13:46Z","git_url":"git://github.com/sharpdx/SharpDX.git","ssh_url":"git@github.com:sharpdx/SharpDX.git","clone_url":"https://github.com/sharpdx/SharpDX.git","svn_url":"https://github.com/sharpdx/SharpDX","homepage":null,"size":133212,"stargazers_count":396,"watchers_count":396,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":39,"forks":190,"open_issues":39,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597"},"html":{"href":"https://github.com/sharpdx/SharpDX/pull/597"},"issue":{"href":"https://api.github.com/repos/sharpdx/SharpDX/issues/597"},"comments":{"href":"https://api.github.com/repos/sharpdx/SharpDX/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sharpdx/SharpDX/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/sharpdx/SharpDX/statuses/a87b1ab0cea60fa9ca05a4eea8e0a271d15756ff"}}}}