{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26627989","id":26627989,"diff_hunk":"@@ -454,10 +454,30 @@ def self.default_diffargs\n     :environment_timeout => {\n       :default    => \"0\",\n       :type       => :ttl,\n-      :desc       => \"The time to live for a cached environment.\n+      :desc       => \"How long the Puppet master should cache data it loads from an\n+      environment.\n       #{AS_DURATION}\n-      This setting can also be set to `unlimited`, which causes the environment to\n-      be cached until the master is restarted.\"\n+      A value of `0` will disable caching. This setting can also be set to\n+      `unlimited`, which will cache environments until the master is restarted\n+      or told to refresh the cache.\n+\n+      You should change this setting once your Puppet deployment is doing\n+      non-trivial work. We chose the default value of `0` because it lets new\n+      users update their code without any extra steps, but it lowers the\n+      performance of your Puppet master.\n+\n+      We recommend setting this to `unlimited` and explicitly refreshing your\n+      Puppet master as part of your code deployment process.\n+\n+      * With Puppet Server, you should refresh environments by calling the\n+        `environment-cache` API endpoint. See the docs for the Puppet Server\n+        administrative API.\n+      * With a Rack Puppet master like Passenger, you should restart the web server.","path":"lib/puppet/defaults.rb","position":25,"original_position":25,"commit_id":"6948c88350c5d8fed688ef8f09d64d1bf01955fc","original_commit_id":"6948c88350c5d8fed688ef8f09d64d1bf01955fc","user":{"login":"ahpook","id":56753,"avatar_url":"https://avatars.githubusercontent.com/u/56753?v=3","gravatar_id":"","url":"https://api.github.com/users/ahpook","html_url":"https://github.com/ahpook","followers_url":"https://api.github.com/users/ahpook/followers","following_url":"https://api.github.com/users/ahpook/following{/other_user}","gists_url":"https://api.github.com/users/ahpook/gists{/gist_id}","starred_url":"https://api.github.com/users/ahpook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahpook/subscriptions","organizations_url":"https://api.github.com/users/ahpook/orgs","repos_url":"https://api.github.com/users/ahpook/repos","events_url":"https://api.github.com/users/ahpook/events{/privacy}","received_events_url":"https://api.github.com/users/ahpook/received_events","type":"User","site_admin":false},"body":"Better, you can restart the *application* server, not the whole web server -- in Passenger this means touching `tmp/restart.txt` under the PassengerRoot directory: https://www.phusionpassenger.com/documentation/Users%20guide%20Nginx.html#_redeploying_restarting_the_rack_application","created_at":"2015-03-17T23:51:22Z","updated_at":"2015-03-17T23:51:22Z","html_url":"https://github.com/puppetlabs/puppet/pull/3727#discussion_r26627989","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26627989"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3727#discussion_r26627989"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727","id":31387842,"html_url":"https://github.com/puppetlabs/puppet/pull/3727","diff_url":"https://github.com/puppetlabs/puppet/pull/3727.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3727.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3727","number":3727,"state":"open","locked":false,"title":"(PUP-4094) Update description of environment_timeout in defaults.rb","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"body":"The defaults.rb file didn't have any advice on how to use this setting, so this\r\ncommit adds our current best practices.","created_at":"2015-03-17T23:20:44Z","updated_at":"2015-03-17T23:51:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"069756cfd4a501ec985f1f926194248572bc0240","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3727/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/6948c88350c5d8fed688ef8f09d64d1bf01955fc","head":{"label":"nfagerlund:mar2015_environment_timeout_375","ref":"mar2015_environment_timeout_375","sha":"6948c88350c5d8fed688ef8f09d64d1bf01955fc","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"repo":{"id":1247122,"name":"puppet","full_name":"nfagerlund/puppet","owner":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfagerlund/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/nfagerlund/puppet","forks_url":"https://api.github.com/repos/nfagerlund/puppet/forks","keys_url":"https://api.github.com/repos/nfagerlund/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfagerlund/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfagerlund/puppet/teams","hooks_url":"https://api.github.com/repos/nfagerlund/puppet/hooks","issue_events_url":"https://api.github.com/repos/nfagerlund/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/nfagerlund/puppet/events","assignees_url":"https://api.github.com/repos/nfagerlund/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/nfagerlund/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/nfagerlund/puppet/tags","blobs_url":"https://api.github.com/repos/nfagerlund/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfagerlund/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfagerlund/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfagerlund/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfagerlund/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/nfagerlund/puppet/languages","stargazers_url":"https://api.github.com/repos/nfagerlund/puppet/stargazers","contributors_url":"https://api.github.com/repos/nfagerlund/puppet/contributors","subscribers_url":"https://api.github.com/repos/nfagerlund/puppet/subscribers","subscription_url":"https://api.github.com/repos/nfagerlund/puppet/subscription","commits_url":"https://api.github.com/repos/nfagerlund/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfagerlund/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfagerlund/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfagerlund/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfagerlund/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/nfagerlund/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfagerlund/puppet/merges","archive_url":"https://api.github.com/repos/nfagerlund/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfagerlund/puppet/downloads","issues_url":"https://api.github.com/repos/nfagerlund/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/nfagerlund/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/nfagerlund/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/nfagerlund/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfagerlund/puppet/labels{/name}","releases_url":"https://api.github.com/repos/nfagerlund/puppet/releases{/id}","created_at":"2011-01-12T18:43:23Z","updated_at":"2014-06-23T17:53:40Z","pushed_at":"2015-03-17T23:20:08Z","git_url":"git://github.com/nfagerlund/puppet.git","ssh_url":"git@github.com:nfagerlund/puppet.git","clone_url":"https://github.com/nfagerlund/puppet.git","svn_url":"https://github.com/nfagerlund/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":45845,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"8c6c36dcdb55995726ef668507bf7cc189e075b3","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-03-17T23:19:28Z","pushed_at":"2015-03-17T23:19:28Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":109644,"stargazers_count":3058,"watchers_count":3058,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1305,"mirror_url":null,"open_issues_count":45,"forks":1305,"open_issues":45,"watchers":3058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3727"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3727"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3727/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3727/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/6948c88350c5d8fed688ef8f09d64d1bf01955fc"}}}}