{"action":"created","comment":{"url":"https://api.github.com/repos/webgme/webgme/pulls/comments/38350914","id":38350914,"diff_hunk":"@@ -852,24 +852,20 @@ function StandAloneServer(gmeConfig) {\n                 logger.error('worker/simpleResult err', err);\n                 res.sendStatus(500);\n             } else {\n-                res.header('Content-Disposition', 'attachment;filename=\\'' + filename + '\\'');\n+                res.header('Content-Disposition', 'attachment;filename=' + filename);","path":"src/server/standalone.js","position":5,"original_position":5,"commit_id":"49fd994dfb4e795db563de906f6462014b2ebb95","original_commit_id":"49fd994dfb4e795db563de906f6462014b2ebb95","user":{"login":"ksmyth","id":1047813,"avatar_url":"https://avatars.githubusercontent.com/u/1047813?v=3","gravatar_id":"","url":"https://api.github.com/users/ksmyth","html_url":"https://github.com/ksmyth","followers_url":"https://api.github.com/users/ksmyth/followers","following_url":"https://api.github.com/users/ksmyth/following{/other_user}","gists_url":"https://api.github.com/users/ksmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/ksmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksmyth/subscriptions","organizations_url":"https://api.github.com/users/ksmyth/orgs","repos_url":"https://api.github.com/users/ksmyth/repos","events_url":"https://api.github.com/users/ksmyth/events{/privacy}","received_events_url":"https://api.github.com/users/ksmyth/received_events","type":"User","site_admin":false},"body":"This will be wrong if filename contains `%` or non-ASCII. Use https://www.npmjs.com/package/content-disposition","created_at":"2015-08-31T19:44:49Z","updated_at":"2015-08-31T19:44:49Z","html_url":"https://github.com/webgme/webgme/pull/523#discussion_r38350914","pull_request_url":"https://api.github.com/repos/webgme/webgme/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/webgme/webgme/pulls/comments/38350914"},"html":{"href":"https://github.com/webgme/webgme/pull/523#discussion_r38350914"},"pull_request":{"href":"https://api.github.com/repos/webgme/webgme/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/webgme/webgme/pulls/523","id":43798508,"html_url":"https://github.com/webgme/webgme/pull/523","diff_url":"https://github.com/webgme/webgme/pull/523.diff","patch_url":"https://github.com/webgme/webgme/pull/523.patch","issue_url":"https://api.github.com/repos/webgme/webgme/issues/523","number":523,"state":"closed","locked":false,"title":"Fixes #515","user":{"login":"kecso","id":1371489,"avatar_url":"https://avatars.githubusercontent.com/u/1371489?v=3","gravatar_id":"","url":"https://api.github.com/users/kecso","html_url":"https://github.com/kecso","followers_url":"https://api.github.com/users/kecso/followers","following_url":"https://api.github.com/users/kecso/following{/other_user}","gists_url":"https://api.github.com/users/kecso/gists{/gist_id}","starred_url":"https://api.github.com/users/kecso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecso/subscriptions","organizations_url":"https://api.github.com/users/kecso/orgs","repos_url":"https://api.github.com/users/kecso/repos","events_url":"https://api.github.com/users/kecso/events{/privacy}","received_events_url":"https://api.github.com/users/kecso/received_events","type":"User","site_admin":false},"body":"Changing parameters of download links (target='_self') so it work until Safari as well","created_at":"2015-08-31T19:11:58Z","updated_at":"2015-08-31T19:44:49Z","closed_at":"2015-08-31T19:19:33Z","merged_at":"2015-08-31T19:19:33Z","merge_commit_sha":"dfe5aba553ca77222ed723d202de76e35d025083","assignee":{"login":"pmeijer","id":6518904,"avatar_url":"https://avatars.githubusercontent.com/u/6518904?v=3","gravatar_id":"","url":"https://api.github.com/users/pmeijer","html_url":"https://github.com/pmeijer","followers_url":"https://api.github.com/users/pmeijer/followers","following_url":"https://api.github.com/users/pmeijer/following{/other_user}","gists_url":"https://api.github.com/users/pmeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeijer/subscriptions","organizations_url":"https://api.github.com/users/pmeijer/orgs","repos_url":"https://api.github.com/users/pmeijer/repos","events_url":"https://api.github.com/users/pmeijer/events{/privacy}","received_events_url":"https://api.github.com/users/pmeijer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/webgme/webgme/milestones/18","html_url":"https://github.com/webgme/webgme/milestones/v0.14.0","labels_url":"https://api.github.com/repos/webgme/webgme/milestones/18/labels","id":1239306,"number":18,"title":"v0.14.0","description":"","creator":{"login":"pmeijer","id":6518904,"avatar_url":"https://avatars.githubusercontent.com/u/6518904?v=3","gravatar_id":"","url":"https://api.github.com/users/pmeijer","html_url":"https://github.com/pmeijer","followers_url":"https://api.github.com/users/pmeijer/followers","following_url":"https://api.github.com/users/pmeijer/following{/other_user}","gists_url":"https://api.github.com/users/pmeijer/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeijer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeijer/subscriptions","organizations_url":"https://api.github.com/users/pmeijer/orgs","repos_url":"https://api.github.com/users/pmeijer/repos","events_url":"https://api.github.com/users/pmeijer/events{/privacy}","received_events_url":"https://api.github.com/users/pmeijer/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":44,"state":"open","created_at":"2015-08-03T22:47:23Z","updated_at":"2015-08-31T19:32:56Z","due_on":"2015-08-31T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/webgme/webgme/pulls/523/commits","review_comments_url":"https://api.github.com/repos/webgme/webgme/pulls/523/comments","review_comment_url":"https://api.github.com/repos/webgme/webgme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webgme/webgme/issues/523/comments","statuses_url":"https://api.github.com/repos/webgme/webgme/statuses/49fd994dfb4e795db563de906f6462014b2ebb95","head":{"label":"webgme:issue/515_export_in_safari","ref":"issue/515_export_in_safari","sha":"49fd994dfb4e795db563de906f6462014b2ebb95","user":{"login":"webgme","id":1107609,"avatar_url":"https://avatars.githubusercontent.com/u/1107609?v=3","gravatar_id":"","url":"https://api.github.com/users/webgme","html_url":"https://github.com/webgme","followers_url":"https://api.github.com/users/webgme/followers","following_url":"https://api.github.com/users/webgme/following{/other_user}","gists_url":"https://api.github.com/users/webgme/gists{/gist_id}","starred_url":"https://api.github.com/users/webgme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webgme/subscriptions","organizations_url":"https://api.github.com/users/webgme/orgs","repos_url":"https://api.github.com/users/webgme/repos","events_url":"https://api.github.com/users/webgme/events{/privacy}","received_events_url":"https://api.github.com/users/webgme/received_events","type":"Organization","site_admin":false},"repo":{"id":2526173,"name":"webgme","full_name":"webgme/webgme","owner":{"login":"webgme","id":1107609,"avatar_url":"https://avatars.githubusercontent.com/u/1107609?v=3","gravatar_id":"","url":"https://api.github.com/users/webgme","html_url":"https://github.com/webgme","followers_url":"https://api.github.com/users/webgme/followers","following_url":"https://api.github.com/users/webgme/following{/other_user}","gists_url":"https://api.github.com/users/webgme/gists{/gist_id}","starred_url":"https://api.github.com/users/webgme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webgme/subscriptions","organizations_url":"https://api.github.com/users/webgme/orgs","repos_url":"https://api.github.com/users/webgme/repos","events_url":"https://api.github.com/users/webgme/events{/privacy}","received_events_url":"https://api.github.com/users/webgme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webgme/webgme","description":"Web-based Generic Modeling Environment","fork":false,"url":"https://api.github.com/repos/webgme/webgme","forks_url":"https://api.github.com/repos/webgme/webgme/forks","keys_url":"https://api.github.com/repos/webgme/webgme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webgme/webgme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webgme/webgme/teams","hooks_url":"https://api.github.com/repos/webgme/webgme/hooks","issue_events_url":"https://api.github.com/repos/webgme/webgme/issues/events{/number}","events_url":"https://api.github.com/repos/webgme/webgme/events","assignees_url":"https://api.github.com/repos/webgme/webgme/assignees{/user}","branches_url":"https://api.github.com/repos/webgme/webgme/branches{/branch}","tags_url":"https://api.github.com/repos/webgme/webgme/tags","blobs_url":"https://api.github.com/repos/webgme/webgme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webgme/webgme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webgme/webgme/git/refs{/sha}","trees_url":"https://api.github.com/repos/webgme/webgme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webgme/webgme/statuses/{sha}","languages_url":"https://api.github.com/repos/webgme/webgme/languages","stargazers_url":"https://api.github.com/repos/webgme/webgme/stargazers","contributors_url":"https://api.github.com/repos/webgme/webgme/contributors","subscribers_url":"https://api.github.com/repos/webgme/webgme/subscribers","subscription_url":"https://api.github.com/repos/webgme/webgme/subscription","commits_url":"https://api.github.com/repos/webgme/webgme/commits{/sha}","git_commits_url":"https://api.github.com/repos/webgme/webgme/git/commits{/sha}","comments_url":"https://api.github.com/repos/webgme/webgme/comments{/number}","issue_comment_url":"https://api.github.com/repos/webgme/webgme/issues/comments{/number}","contents_url":"https://api.github.com/repos/webgme/webgme/contents/{+path}","compare_url":"https://api.github.com/repos/webgme/webgme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webgme/webgme/merges","archive_url":"https://api.github.com/repos/webgme/webgme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webgme/webgme/downloads","issues_url":"https://api.github.com/repos/webgme/webgme/issues{/number}","pulls_url":"https://api.github.com/repos/webgme/webgme/pulls{/number}","milestones_url":"https://api.github.com/repos/webgme/webgme/milestones{/number}","notifications_url":"https://api.github.com/repos/webgme/webgme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webgme/webgme/labels{/name}","releases_url":"https://api.github.com/repos/webgme/webgme/releases{/id}","created_at":"2011-10-06T14:01:08Z","updated_at":"2015-08-11T13:36:12Z","pushed_at":"2015-08-31T19:33:32Z","git_url":"git://github.com/webgme/webgme.git","ssh_url":"git@github.com:webgme/webgme.git","clone_url":"https://github.com/webgme/webgme.git","svn_url":"https://github.com/webgme/webgme","homepage":"http://webgme.org","size":139204,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":60,"forks":12,"open_issues":60,"watchers":19,"default_branch":"master"}},"base":{"label":"webgme:master","ref":"master","sha":"f16879c57f537c5c15998bd41f45d5b95bd18af2","user":{"login":"webgme","id":1107609,"avatar_url":"https://avatars.githubusercontent.com/u/1107609?v=3","gravatar_id":"","url":"https://api.github.com/users/webgme","html_url":"https://github.com/webgme","followers_url":"https://api.github.com/users/webgme/followers","following_url":"https://api.github.com/users/webgme/following{/other_user}","gists_url":"https://api.github.com/users/webgme/gists{/gist_id}","starred_url":"https://api.github.com/users/webgme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webgme/subscriptions","organizations_url":"https://api.github.com/users/webgme/orgs","repos_url":"https://api.github.com/users/webgme/repos","events_url":"https://api.github.com/users/webgme/events{/privacy}","received_events_url":"https://api.github.com/users/webgme/received_events","type":"Organization","site_admin":false},"repo":{"id":2526173,"name":"webgme","full_name":"webgme/webgme","owner":{"login":"webgme","id":1107609,"avatar_url":"https://avatars.githubusercontent.com/u/1107609?v=3","gravatar_id":"","url":"https://api.github.com/users/webgme","html_url":"https://github.com/webgme","followers_url":"https://api.github.com/users/webgme/followers","following_url":"https://api.github.com/users/webgme/following{/other_user}","gists_url":"https://api.github.com/users/webgme/gists{/gist_id}","starred_url":"https://api.github.com/users/webgme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webgme/subscriptions","organizations_url":"https://api.github.com/users/webgme/orgs","repos_url":"https://api.github.com/users/webgme/repos","events_url":"https://api.github.com/users/webgme/events{/privacy}","received_events_url":"https://api.github.com/users/webgme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webgme/webgme","description":"Web-based Generic Modeling Environment","fork":false,"url":"https://api.github.com/repos/webgme/webgme","forks_url":"https://api.github.com/repos/webgme/webgme/forks","keys_url":"https://api.github.com/repos/webgme/webgme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webgme/webgme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webgme/webgme/teams","hooks_url":"https://api.github.com/repos/webgme/webgme/hooks","issue_events_url":"https://api.github.com/repos/webgme/webgme/issues/events{/number}","events_url":"https://api.github.com/repos/webgme/webgme/events","assignees_url":"https://api.github.com/repos/webgme/webgme/assignees{/user}","branches_url":"https://api.github.com/repos/webgme/webgme/branches{/branch}","tags_url":"https://api.github.com/repos/webgme/webgme/tags","blobs_url":"https://api.github.com/repos/webgme/webgme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webgme/webgme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webgme/webgme/git/refs{/sha}","trees_url":"https://api.github.com/repos/webgme/webgme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webgme/webgme/statuses/{sha}","languages_url":"https://api.github.com/repos/webgme/webgme/languages","stargazers_url":"https://api.github.com/repos/webgme/webgme/stargazers","contributors_url":"https://api.github.com/repos/webgme/webgme/contributors","subscribers_url":"https://api.github.com/repos/webgme/webgme/subscribers","subscription_url":"https://api.github.com/repos/webgme/webgme/subscription","commits_url":"https://api.github.com/repos/webgme/webgme/commits{/sha}","git_commits_url":"https://api.github.com/repos/webgme/webgme/git/commits{/sha}","comments_url":"https://api.github.com/repos/webgme/webgme/comments{/number}","issue_comment_url":"https://api.github.com/repos/webgme/webgme/issues/comments{/number}","contents_url":"https://api.github.com/repos/webgme/webgme/contents/{+path}","compare_url":"https://api.github.com/repos/webgme/webgme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webgme/webgme/merges","archive_url":"https://api.github.com/repos/webgme/webgme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webgme/webgme/downloads","issues_url":"https://api.github.com/repos/webgme/webgme/issues{/number}","pulls_url":"https://api.github.com/repos/webgme/webgme/pulls{/number}","milestones_url":"https://api.github.com/repos/webgme/webgme/milestones{/number}","notifications_url":"https://api.github.com/repos/webgme/webgme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webgme/webgme/labels{/name}","releases_url":"https://api.github.com/repos/webgme/webgme/releases{/id}","created_at":"2011-10-06T14:01:08Z","updated_at":"2015-08-11T13:36:12Z","pushed_at":"2015-08-31T19:33:32Z","git_url":"git://github.com/webgme/webgme.git","ssh_url":"git@github.com:webgme/webgme.git","clone_url":"https://github.com/webgme/webgme.git","svn_url":"https://github.com/webgme/webgme","homepage":"http://webgme.org","size":139204,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":60,"forks":12,"open_issues":60,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webgme/webgme/pulls/523"},"html":{"href":"https://github.com/webgme/webgme/pull/523"},"issue":{"href":"https://api.github.com/repos/webgme/webgme/issues/523"},"comments":{"href":"https://api.github.com/repos/webgme/webgme/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/webgme/webgme/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/webgme/webgme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webgme/webgme/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/webgme/webgme/statuses/49fd994dfb4e795db563de906f6462014b2ebb95"}}}}