{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/40496505","id":40496505,"diff_hunk":"@@ -216,18 +223,14 @@ def _create_test_user(self, cursor, parameters, verbosity):\n                      CREATE TRIGGER\n                TO %(user)s\"\"\",\n         ]\n-        self._execute_statements(cursor, statements, parameters, verbosity)\n+        acceptable_ora_err = None\n+        if keepdb:\n+            # Avoid user already exists error when keepdb is on\n+            acceptable_ora_err = 'ORA-01920'\n+        self._execute_allow_fail_statements(cursor, statements, parameters, verbosity, acceptable_ora_err)\n         # Most test-suites can be run without the create-view privilege. But some need it.\n         extra = \"GRANT CREATE VIEW TO %(user)s\"\n-        try:\n-            self._execute_statements(cursor, [extra], parameters, verbosity, allow_quiet_fail=True)\n-        except DatabaseError as err:\n-            description = str(err)\n-            if 'ORA-01031' in description:\n-                if verbosity >= 2:\n-                    print(\"Failed to grant CREATE VIEW permission to test user. This may be ok.\")","path":"django/db/backends/oracle/creation.py","position":83,"original_position":83,"commit_id":"c5eeb668f61de7ec810262ee3d93d35c2f2b01f1","original_commit_id":"c5eeb668f61de7ec810262ee3d93d35c2f2b01f1","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"Does it seem fine that we lost this message in the refactor?","created_at":"2015-09-26T18:12:22Z","updated_at":"2015-09-26T18:12:22Z","html_url":"https://github.com/django/django/pull/5362#discussion_r40496505","pull_request_url":"https://api.github.com/repos/django/django/pulls/5362","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/40496505"},"html":{"href":"https://github.com/django/django/pull/5362#discussion_r40496505"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/5362"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/5362","id":46055551,"html_url":"https://github.com/django/django/pull/5362","diff_url":"https://github.com/django/django/pull/5362.diff","patch_url":"https://github.com/django/django/pull/5362.patch","issue_url":"https://api.github.com/repos/django/django/issues/5362","number":5362,"state":"open","locked":false,"title":"Fixed #25421 -- Fixed test --keepdb option on Oracle.","user":{"login":"felixxm","id":2865885,"avatar_url":"https://avatars.githubusercontent.com/u/2865885?v=3","gravatar_id":"","url":"https://api.github.com/users/felixxm","html_url":"https://github.com/felixxm","followers_url":"https://api.github.com/users/felixxm/followers","following_url":"https://api.github.com/users/felixxm/following{/other_user}","gists_url":"https://api.github.com/users/felixxm/gists{/gist_id}","starred_url":"https://api.github.com/users/felixxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixxm/subscriptions","organizations_url":"https://api.github.com/users/felixxm/orgs","repos_url":"https://api.github.com/users/felixxm/repos","events_url":"https://api.github.com/users/felixxm/events{/privacy}","received_events_url":"https://api.github.com/users/felixxm/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-25T20:38:20Z","updated_at":"2015-09-26T18:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db267c1c9f6a27bd519b1473cfd005eb88b5467d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/5362/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/5362/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/5362/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/c5eeb668f61de7ec810262ee3d93d35c2f2b01f1","head":{"label":"felixxm:issue-25421","ref":"issue-25421","sha":"c5eeb668f61de7ec810262ee3d93d35c2f2b01f1","user":{"login":"felixxm","id":2865885,"avatar_url":"https://avatars.githubusercontent.com/u/2865885?v=3","gravatar_id":"","url":"https://api.github.com/users/felixxm","html_url":"https://github.com/felixxm","followers_url":"https://api.github.com/users/felixxm/followers","following_url":"https://api.github.com/users/felixxm/following{/other_user}","gists_url":"https://api.github.com/users/felixxm/gists{/gist_id}","starred_url":"https://api.github.com/users/felixxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixxm/subscriptions","organizations_url":"https://api.github.com/users/felixxm/orgs","repos_url":"https://api.github.com/users/felixxm/repos","events_url":"https://api.github.com/users/felixxm/events{/privacy}","received_events_url":"https://api.github.com/users/felixxm/received_events","type":"User","site_admin":false},"repo":{"id":10663111,"name":"django","full_name":"felixxm/django","owner":{"login":"felixxm","id":2865885,"avatar_url":"https://avatars.githubusercontent.com/u/2865885?v=3","gravatar_id":"","url":"https://api.github.com/users/felixxm","html_url":"https://github.com/felixxm","followers_url":"https://api.github.com/users/felixxm/followers","following_url":"https://api.github.com/users/felixxm/following{/other_user}","gists_url":"https://api.github.com/users/felixxm/gists{/gist_id}","starred_url":"https://api.github.com/users/felixxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixxm/subscriptions","organizations_url":"https://api.github.com/users/felixxm/orgs","repos_url":"https://api.github.com/users/felixxm/repos","events_url":"https://api.github.com/users/felixxm/events{/privacy}","received_events_url":"https://api.github.com/users/felixxm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixxm/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/felixxm/django","forks_url":"https://api.github.com/repos/felixxm/django/forks","keys_url":"https://api.github.com/repos/felixxm/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixxm/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixxm/django/teams","hooks_url":"https://api.github.com/repos/felixxm/django/hooks","issue_events_url":"https://api.github.com/repos/felixxm/django/issues/events{/number}","events_url":"https://api.github.com/repos/felixxm/django/events","assignees_url":"https://api.github.com/repos/felixxm/django/assignees{/user}","branches_url":"https://api.github.com/repos/felixxm/django/branches{/branch}","tags_url":"https://api.github.com/repos/felixxm/django/tags","blobs_url":"https://api.github.com/repos/felixxm/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixxm/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixxm/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixxm/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixxm/django/statuses/{sha}","languages_url":"https://api.github.com/repos/felixxm/django/languages","stargazers_url":"https://api.github.com/repos/felixxm/django/stargazers","contributors_url":"https://api.github.com/repos/felixxm/django/contributors","subscribers_url":"https://api.github.com/repos/felixxm/django/subscribers","subscription_url":"https://api.github.com/repos/felixxm/django/subscription","commits_url":"https://api.github.com/repos/felixxm/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixxm/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixxm/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixxm/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixxm/django/contents/{+path}","compare_url":"https://api.github.com/repos/felixxm/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixxm/django/merges","archive_url":"https://api.github.com/repos/felixxm/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixxm/django/downloads","issues_url":"https://api.github.com/repos/felixxm/django/issues{/number}","pulls_url":"https://api.github.com/repos/felixxm/django/pulls{/number}","milestones_url":"https://api.github.com/repos/felixxm/django/milestones{/number}","notifications_url":"https://api.github.com/repos/felixxm/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixxm/django/labels{/name}","releases_url":"https://api.github.com/repos/felixxm/django/releases{/id}","created_at":"2013-06-13T09:37:52Z","updated_at":"2015-03-10T00:44:58Z","pushed_at":"2015-09-25T21:01:55Z","git_url":"git://github.com/felixxm/django.git","ssh_url":"git@github.com:felixxm/django.git","clone_url":"https://github.com/felixxm/django.git","svn_url":"https://github.com/felixxm/django","homepage":"http://www.djangoproject.com/","size":129526,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"829e33f67f8b3fa8ccade46f14482f4a6ddd7b9d","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-09-26T17:02:26Z","pushed_at":"2015-09-26T18:10:16Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":314447,"stargazers_count":16100,"watchers_count":16100,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6487,"mirror_url":null,"open_issues_count":55,"forks":6487,"open_issues":55,"watchers":16100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/5362"},"html":{"href":"https://github.com/django/django/pull/5362"},"issue":{"href":"https://api.github.com/repos/django/django/issues/5362"},"comments":{"href":"https://api.github.com/repos/django/django/issues/5362/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/5362/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/5362/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/c5eeb668f61de7ec810262ee3d93d35c2f2b01f1"}}}}