{"push_id":565008554,"size":15,"distinct_size":15,"ref":"refs/heads/master","head":"cbadc0dcae13ac44b139d3194defceb12d6d0bba","before":"9cf616b6fdf62a9f6065beaaa626b85afafa1031","commits":[{"sha":"dd059054875c57d876496888f7cedf28f8450fcf","author":{"email":"a4379d9071d2bc61dde500b1b931d03e5af91428@techfak.uni-bielefeld.de","name":"Johannes Wienke"},"message":"Comply to spec when reading data message old mac\n\nThe \"Old MAC keys to be revealed\" field is a DATA field according to\nthe OTR protocol specification of all versions. Hence, reading it as a\n(single) mac address of 20 bytes is wrong in two senses:\n1. it might be empty or contain more than one address, which would be\n   ignored then\n2. a DATA field contains a 4 byte length header, which would be read as\n   the first 4 bytes of the first mac address.\n\nThis commit correctly parses the field as a DATA field. For more info, see\n\"old mac keys\" in the protocol document:\nhttps://otr.cypherpunks.ca/Protocol-v3-4.0.0.html\n\ncloses https://github.com/otr4j/otr4j/pull/3","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/dd059054875c57d876496888f7cedf28f8450fcf"},{"sha":"8b86a43a32f4fa2c4a50aeb4e0e60623772fbc4c","author":{"email":"a4379d9071d2bc61dde500b1b931d03e5af91428@techfak.uni-bielefeld.de","name":"Johannes Wienke"},"message":"When decoding, check for supported protocol versions\n\nCheck a message to decode for having a supported protocol version.\nOtherwise, throw an exception.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/8b86a43a32f4fa2c4a50aeb4e0e60623772fbc4c"},{"sha":"78560666112eb8393e02bb23c9355951e7c660d1","author":{"email":"a4379d9071d2bc61dde500b1b931d03e5af91428@techfak.uni-bielefeld.de","name":"Johannes Wienke"},"message":"Check read calls in OtrInputStream\n\nCheck that the requested amount of bytes could be read from the input\nstream. If not, throw an exception.\n\ncloses https://github.com/otr4j/otr4j/pull/4","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/78560666112eb8393e02bb23c9355951e7c660d1"},{"sha":"ba335c46b0d8db0b79e77a0663b79d386f323aa4","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"use SerializationConstants.TYPE_LEN_MAC for MAC length everywhere\n\nJust to keep the code consistent","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/ba335c46b0d8db0b79e77a0663b79d386f323aa4"},{"sha":"8ef1c64dcf749c06f9a13b93153f39fa1b911c0b","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"remove unused Util.arrayEquals(), java.util.Arrays.equals() is better\n\njava.util.Arrays.equals() is actually what is used in the code.  This\narrayEquals() method should be removed to make people stop using it.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/8ef1c64dcf749c06f9a13b93153f39fa1b911c0b"},{"sha":"f6cf71aba5d401d08adfb92d94536a52fd1cf53c","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"document the two Strings representing the sides of the convo in SessionID\n\nThe terms used here are confusing since both sides of the conversation have\naccounts and users, so this documents things to clarify the distinction,\nbut leaves the API the same.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/f6cf71aba5d401d08adfb92d94536a52fd1cf53c"},{"sha":"bb47eb47fd68569505da624682c235ac0ba95d35","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"create common method for setting up test conversations\n\nSince these bits of code are used more than once, and will be used more,\nput them into their own methods.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/bb47eb47fd68569505da624682c235ac0ba95d35"},{"sha":"9676888fda8be22d37c9dcad73958c217517543a","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"renamed test message classes to separate them from actual message classes\n\nHaving a class called net.java.otr4j.session.Message is easily confused\nwith net.java.otr4j.io.messages.AbstractMessage and those.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/9676888fda8be22d37c9dcad73958c217517543a"},{"sha":"1d0166dc493caa15dcd9359942a6ba3ab9577b6f","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"move DummyClient classes into their own package\n\nThe DummyClient classes are not directly part of net.java.otr4j.session, so\nit doesn't make sense for them to be there.  The DummyClient is also useful\nfor testing classes in other parts of otr4j, so that is another reason to\nsplit it out into its own package.  Then only the tests that directly\nrelate to the classes of a given package will be included in the test\nversion of that package.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/1d0166dc493caa15dcd9359942a6ba3ab9577b6f"},{"sha":"1980a2a376b66086464cf05bc8185e49188fb46a","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"merge AuthContext and AuthContextImpl into a single class\n\nBased on a discussion with gpolitis in #jiti on 2014-02-03, we bought\nthough it made a lot of sense to get rid of the *Impl classes and\ncorresponding abstract classes since each abstract class only had a single\nsubclass, the *Impl version.\n\nMerging these also makes it much easier to write tests for all of the\nclasses that are split between an abstract and *Impl.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/1980a2a376b66086464cf05bc8185e49188fb46a"},{"sha":"719605ccfdd37c8f43487f6044ac6b6d2bfd6dfa","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"merge Session and SessionImpl into a single class\n\nBased on a discussion with gpolitis in #jitsi on 2014-02-03, we both\nthought it made a lot of sense to get rid of the *Impl classes and\ncorresponding abstract classes since each abstract class only had a single\nsubclass, the *Impl version.\n\nMerging these also makes it much easier to write tests for all of the\nclasses that are split between an abstract and *Impl.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/719605ccfdd37c8f43487f6044ac6b6d2bfd6dfa"},{"sha":"e1271a61380267dd6a519c354cf7d6f4e619efde","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"provide method to get AuthContext instance in tests only\n\nTo do detailed testing of the OTR messages, it is necessary to get the\ninstance of AuthContext.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/e1271a61380267dd6a519c354cf7d6f4e619efde"},{"sha":"0898af1aafac61bbaa980c7acc8c628c9f58ab2b","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"improved, one-line logging format for `mvn test`\n\nThis reformats what is printed out into a single line that contains more\nuseful info, like which account the message is related to.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/0898af1aafac61bbaa980c7acc8c628c9f58ab2b"},{"sha":"c1c870a91d11e0facfd3d7ce1465e69c803236eb","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"tests: add method to DummyClient to get raw incoming message\n\nThis method allows a test to get an incoming message is processed at all,\nso that various tests can be run against that message.","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/c1c870a91d11e0facfd3d7ce1465e69c803236eb"},{"sha":"cbadc0dcae13ac44b139d3194defceb12d6d0bba","author":{"email":"8800578b51f022c8d8adb9606a8b3db4fedbdac6@eds.org","name":"Hans-Christoph Steiner"},"message":"add tests for SignatureMessage equals(), verify(), and hashCode()\n\nThis test would have caught the bug reported in:\nhttps://github.com/otr4j/otr4j/pull/6\n\nfrom this line:\n\treturn Arrays.equals(xEncryptedMAC, xEncryptedMAC);","distinct":true,"url":"https://api.github.com/repos/eighthave/otr4j/commits/cbadc0dcae13ac44b139d3194defceb12d6d0bba"}]}