{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/83","labels_url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/83/comments","events_url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/83/events","html_url":"https://github.com/zooniverse/wildcam-gorongosa/pull/83","id":103323951,"number":83,"title":"Directly call classification store finish rather than through listener","user":{"login":"srallen","id":5016731,"avatar_url":"https://avatars.githubusercontent.com/u/5016731?v=3","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"chrissnyder","id":735191,"avatar_url":"https://avatars.githubusercontent.com/u/735191?v=3","gravatar_id":"","url":"https://api.github.com/users/chrissnyder","html_url":"https://github.com/chrissnyder","followers_url":"https://api.github.com/users/chrissnyder/followers","following_url":"https://api.github.com/users/chrissnyder/following{/other_user}","gists_url":"https://api.github.com/users/chrissnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/chrissnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrissnyder/subscriptions","organizations_url":"https://api.github.com/users/chrissnyder/orgs","repos_url":"https://api.github.com/users/chrissnyder/repos","events_url":"https://api.github.com/users/chrissnyder/events{/privacy}","received_events_url":"https://api.github.com/users/chrissnyder/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-26T17:22:02Z","updated_at":"2015-08-26T18:09:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/pulls/83","html_url":"https://github.com/zooniverse/wildcam-gorongosa/pull/83","diff_url":"https://github.com/zooniverse/wildcam-gorongosa/pull/83.diff","patch_url":"https://github.com/zooniverse/wildcam-gorongosa/pull/83.patch"},"body":"- Fixed #45 \r\n\r\nI couldn't get the action listener to work with calling the classification store's finish method. I'm not sure if it's a matter of misunderstanding action listeners in Reflux or if something is buggy. I came across this a few times with working with it in mammoths. Anyway, `classificationStore.finish()` is now being called directly in `onFinishClassification` in the classifier-store"},"comment":{"url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/comments/135126821","html_url":"https://github.com/zooniverse/wildcam-gorongosa/pull/83#issuecomment-135126821","issue_url":"https://api.github.com/repos/zooniverse/wildcam-gorongosa/issues/83","id":135126821,"user":{"login":"chrissnyder","id":735191,"avatar_url":"https://avatars.githubusercontent.com/u/735191?v=3","gravatar_id":"","url":"https://api.github.com/users/chrissnyder","html_url":"https://github.com/chrissnyder","followers_url":"https://api.github.com/users/chrissnyder/followers","following_url":"https://api.github.com/users/chrissnyder/following{/other_user}","gists_url":"https://api.github.com/users/chrissnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/chrissnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrissnyder/subscriptions","organizations_url":"https://api.github.com/users/chrissnyder/orgs","repos_url":"https://api.github.com/users/chrissnyder/repos","events_url":"https://api.github.com/users/chrissnyder/events{/privacy}","received_events_url":"https://api.github.com/users/chrissnyder/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T18:09:00Z","updated_at":"2015-08-26T18:09:00Z","body":"Works, but I would like to revisit this pattern at some point.\r\n\r\nI think it's pretty important we stay as close as we can to a perfect unidirectional data flow. Part of me thinks the aggregate data stores offered by Reflux is an anti-pattern, establishing dependencies between the stores which are harder to reason about and grok at a quick glance.\r\n\r\nIf it turns out to be a bug with Reflux, we should explore other libraries in the future."}}