{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/comments/34102643","id":34102643,"diff_hunk":"@@ -36,8 +18,47 @@\n \t<string>1.0</string>\n \t<key>CFBundleSignature</key>\n \t<string>????</string>\n+\t<key>CFBundleURLTypes</key>\n+\t<array>\n+\t\t<dict>\n+\t\t\t<key>CFBundleTypeRole</key>\n+\t\t\t<string>Editor</string>\n+\t\t\t<key>CFBundleURLName</key>\n+\t\t\t<string>com.firebase.$(PRODUCT_NAME:rfc1034identifier)</string>\n+\t\t\t<key>CFBundleURLSchemes</key>\n+\t\t\t<array>\n+\t\t\t\t<string>com.firebase.$(PRODUCT_NAME:rfc1034identifier)</string>\n+\t\t\t</array>\n+\t\t</dict>\n+\t\t<dict>\n+\t\t\t<key>CFBundleTypeRole</key>\n+\t\t\t<string>Editor</string>\n+\t\t\t<key>CFBundleURLName</key>\n+\t\t\t<string>FacebookURL</string>\n+\t\t\t<key>CFBundleURLSchemes</key>\n+\t\t\t<array>\n+\t\t\t\t<string>fb&lt;YOUR FACEBOOK APP ID&gt;</string>\n+\t\t\t</array>\n+\t\t</dict>\n+\t\t<dict>\n+\t\t\t<key>CFBundleTypeRole</key>\n+\t\t\t<string>Editor</string>\n+\t\t\t<key>CFBundleURLName</key>\n+\t\t\t<string>GoogleURL</string>\n+\t\t\t<key>CFBundleURLSchemes</key>\n+\t\t\t<array>\n+\t\t\t\t<string>&lt;YOUR GOOGLE REVERSE CLIENT ID&gt;</string>\n+\t\t\t</array>\n+\t\t</dict>\n+\t</array>\n \t<key>CFBundleVersion</key>\n \t<string>1</string>\n+\t<key>Dummy</key>\n+\t<string>NOTE: Expand the URL types below and configure &quot;&lt;YOUR FACEBOOK APP ID&gt;&quot;</string>","path":"Login Demo/Info.plist","position":65,"original_position":65,"commit_id":"2db41823ec80b863528f8cc229d716731b9b3770","original_commit_id":"2db41823ec80b863528f8cc229d716731b9b3770","user":{"login":"katfang","id":1884049,"avatar_url":"https://avatars.githubusercontent.com/u/1884049?v=3","gravatar_id":"","url":"https://api.github.com/users/katfang","html_url":"https://github.com/katfang","followers_url":"https://api.github.com/users/katfang/followers","following_url":"https://api.github.com/users/katfang/following{/other_user}","gists_url":"https://api.github.com/users/katfang/gists{/gist_id}","starred_url":"https://api.github.com/users/katfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katfang/subscriptions","organizations_url":"https://api.github.com/users/katfang/orgs","repos_url":"https://api.github.com/users/katfang/repos","events_url":"https://api.github.com/users/katfang/events{/privacy}","received_events_url":"https://api.github.com/users/katfang/received_events","type":"User","site_admin":false},"body":"Actually ... this just looks different and more hidden.\r\n\r\nI think before we just had one URL type with multiple URL Schemes. I'm not saying it was beautiful, but I think it was easier to discover what you were supposed to edit.","created_at":"2015-07-07T23:22:26Z","updated_at":"2015-07-07T23:22:26Z","html_url":"https://github.com/firebase/login-demo-ios/pull/12#discussion_r34102643","pull_request_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/comments/34102643"},"html":{"href":"https://github.com/firebase/login-demo-ios/pull/12#discussion_r34102643"},"pull_request":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12","id":39423537,"html_url":"https://github.com/firebase/login-demo-ios/pull/12","diff_url":"https://github.com/firebase/login-demo-ios/pull/12.diff","patch_url":"https://github.com/firebase/login-demo-ios/pull/12.patch","issue_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/12","number":12,"state":"open","locked":false,"title":"Switched out Google+ login with generic Google login","user":{"login":"mcdonamp","id":2575327,"avatar_url":"https://avatars.githubusercontent.com/u/2575327?v=3","gravatar_id":"","url":"https://api.github.com/users/mcdonamp","html_url":"https://github.com/mcdonamp","followers_url":"https://api.github.com/users/mcdonamp/followers","following_url":"https://api.github.com/users/mcdonamp/following{/other_user}","gists_url":"https://api.github.com/users/mcdonamp/gists{/gist_id}","starred_url":"https://api.github.com/users/mcdonamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcdonamp/subscriptions","organizations_url":"https://api.github.com/users/mcdonamp/orgs","repos_url":"https://api.github.com/users/mcdonamp/repos","events_url":"https://api.github.com/users/mcdonamp/events{/privacy}","received_events_url":"https://api.github.com/users/mcdonamp/received_events","type":"User","site_admin":false},"body":"@katfang please review and merge. Fixes #11 \r\n\r\nShould conform to the docs here: https://developers.google.com/identity/sign-in/ios/","created_at":"2015-07-07T22:24:04Z","updated_at":"2015-07-07T23:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7404102b09b0fd29cdb7304ffc245b4ff75ee30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12/commits","review_comments_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12/comments","review_comment_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/12/comments","statuses_url":"https://api.github.com/repos/firebase/login-demo-ios/statuses/2db41823ec80b863528f8cc229d716731b9b3770","head":{"label":"firebase:mm-google-login-change","ref":"mm-google-login-change","sha":"2db41823ec80b863528f8cc229d716731b9b3770","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":23157070,"name":"login-demo-ios","full_name":"firebase/login-demo-ios","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/login-demo-ios","description":"","fork":false,"url":"https://api.github.com/repos/firebase/login-demo-ios","forks_url":"https://api.github.com/repos/firebase/login-demo-ios/forks","keys_url":"https://api.github.com/repos/firebase/login-demo-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/login-demo-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/login-demo-ios/teams","hooks_url":"https://api.github.com/repos/firebase/login-demo-ios/hooks","issue_events_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/login-demo-ios/events","assignees_url":"https://api.github.com/repos/firebase/login-demo-ios/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/login-demo-ios/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/login-demo-ios/tags","blobs_url":"https://api.github.com/repos/firebase/login-demo-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/login-demo-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/login-demo-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/login-demo-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/login-demo-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/login-demo-ios/languages","stargazers_url":"https://api.github.com/repos/firebase/login-demo-ios/stargazers","contributors_url":"https://api.github.com/repos/firebase/login-demo-ios/contributors","subscribers_url":"https://api.github.com/repos/firebase/login-demo-ios/subscribers","subscription_url":"https://api.github.com/repos/firebase/login-demo-ios/subscription","commits_url":"https://api.github.com/repos/firebase/login-demo-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/login-demo-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/login-demo-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/login-demo-ios/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/login-demo-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/login-demo-ios/merges","archive_url":"https://api.github.com/repos/firebase/login-demo-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/login-demo-ios/downloads","issues_url":"https://api.github.com/repos/firebase/login-demo-ios/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/login-demo-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/login-demo-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/login-demo-ios/labels{/name}","releases_url":"https://api.github.com/repos/firebase/login-demo-ios/releases{/id}","created_at":"2014-08-20T17:16:06Z","updated_at":"2015-06-02T01:14:50Z","pushed_at":"2015-07-07T22:24:04Z","git_url":"git://github.com/firebase/login-demo-ios.git","ssh_url":"git@github.com:firebase/login-demo-ios.git","clone_url":"https://github.com/firebase/login-demo-ios.git","svn_url":"https://github.com/firebase/login-demo-ios","homepage":null,"size":284,"stargazers_count":18,"watchers_count":18,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":18,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"fc528cc488e1ec4a7b75a0320f52f7c96d6a6995","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":23157070,"name":"login-demo-ios","full_name":"firebase/login-demo-ios","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/login-demo-ios","description":"","fork":false,"url":"https://api.github.com/repos/firebase/login-demo-ios","forks_url":"https://api.github.com/repos/firebase/login-demo-ios/forks","keys_url":"https://api.github.com/repos/firebase/login-demo-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/login-demo-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/login-demo-ios/teams","hooks_url":"https://api.github.com/repos/firebase/login-demo-ios/hooks","issue_events_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/login-demo-ios/events","assignees_url":"https://api.github.com/repos/firebase/login-demo-ios/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/login-demo-ios/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/login-demo-ios/tags","blobs_url":"https://api.github.com/repos/firebase/login-demo-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/login-demo-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/login-demo-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/login-demo-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/login-demo-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/login-demo-ios/languages","stargazers_url":"https://api.github.com/repos/firebase/login-demo-ios/stargazers","contributors_url":"https://api.github.com/repos/firebase/login-demo-ios/contributors","subscribers_url":"https://api.github.com/repos/firebase/login-demo-ios/subscribers","subscription_url":"https://api.github.com/repos/firebase/login-demo-ios/subscription","commits_url":"https://api.github.com/repos/firebase/login-demo-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/login-demo-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/login-demo-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/login-demo-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/login-demo-ios/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/login-demo-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/login-demo-ios/merges","archive_url":"https://api.github.com/repos/firebase/login-demo-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/login-demo-ios/downloads","issues_url":"https://api.github.com/repos/firebase/login-demo-ios/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/login-demo-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/login-demo-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/login-demo-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/login-demo-ios/labels{/name}","releases_url":"https://api.github.com/repos/firebase/login-demo-ios/releases{/id}","created_at":"2014-08-20T17:16:06Z","updated_at":"2015-06-02T01:14:50Z","pushed_at":"2015-07-07T22:24:04Z","git_url":"git://github.com/firebase/login-demo-ios.git","ssh_url":"git@github.com:firebase/login-demo-ios.git","clone_url":"https://github.com/firebase/login-demo-ios.git","svn_url":"https://github.com/firebase/login-demo-ios","homepage":null,"size":284,"stargazers_count":18,"watchers_count":18,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12"},"html":{"href":"https://github.com/firebase/login-demo-ios/pull/12"},"issue":{"href":"https://api.github.com/repos/firebase/login-demo-ios/issues/12"},"comments":{"href":"https://api.github.com/repos/firebase/login-demo-ios/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/login-demo-ios/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/login-demo-ios/statuses/2db41823ec80b863528f8cc229d716731b9b3770"}}}}