{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/38141770","id":38141770,"diff_hunk":"@@ -0,0 +1,144 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+#include \"../config.h\"\n+#include \"pal_mount.h\"\n+#include <assert.h>\n+#include <string.h>\n+#include <errno.h>\n+\n+// Check if we should use getmntinfo or /proc/mounts\n+#if HAVE_MNTINFO\n+#include <sys/mount.h>\n+#else\n+#include <sys/statfs.h>\n+#include <mntent.h>\n+#define STRING_BUFFER_SIZE 8192\n+#endif\n+\n+#if HAVE_MNTINFO\n+\n+int GetMountInfo(MountPointFound onFound)\n+{\n+    // getmntinfo returns pointers to OS-internal structs, so we don't need to worry about free'ing the object\n+    int result = 0;\n+    struct statfs* mounts = nullptr;\n+    int count = getmntinfo(&mounts, 0);\n+    if (count > 0)\n+    {\n+        for (int32_t i = 0; i < count; i++)\n+        {\n+            int32_t nameLength = strlen(mounts[i].f_mntonname);\n+            onFound(mounts[i].f_mntonname, nameLength);\n+        }\n+    }\n+    else\n+    {\n+        // Something went wrong so set our result to errno\n+        result = errno;","path":"src/Native/System.Native/pal_mount.cpp","position":38,"original_position":38,"commit_id":"dbd55c3205c2fcf068b102575c615c9e941915e3","original_commit_id":"dbd55c3205c2fcf068b102575c615c9e941915e3","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"I'm all for keeping with the convention of the underlying function, but getmntinfo either returns 0 or -1...it seemed like it would save a step or having to get errno by having the PAL function return 0 or the error code. This makes it immediately obvious (and easy to determine) what the cause of error was without having to make any more function calls in C#. I'm happy to roll this back if you don't think this design is best, however. ","created_at":"2015-08-27T20:23:40Z","updated_at":"2015-08-27T20:23:40Z","html_url":"https://github.com/dotnet/corefx/pull/2999#discussion_r38141770","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2999","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/38141770"},"html":{"href":"https://github.com/dotnet/corefx/pull/2999#discussion_r38141770"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2999"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2999","id":43557490,"html_url":"https://github.com/dotnet/corefx/pull/2999","diff_url":"https://github.com/dotnet/corefx/pull/2999.diff","patch_url":"https://github.com/dotnet/corefx/pull/2999.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2999","number":2999,"state":"open","locked":false,"title":"Moving statfs calls and DriveInfo PInvokes over to use the PAL layer.","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"The PAL layer will abstract away the knowledge of if the OS has\r\n/proc/mounts or a C API to gather the mount point information. This\r\nchange also means we only need one DriveInfo.Unix file for all\r\nnon-Windows platforms.\r\n\r\n@nguerrera \r\n/cc: @stephentoub @janhenke @jasonwilliams200OK ","created_at":"2015-08-27T19:37:02Z","updated_at":"2015-08-27T20:23:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"892e6f4e6f249c68508d4ba186d4b66b580a9bf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2999/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2999/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2999/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/dbd55c3205c2fcf068b102575c615c9e941915e3","head":{"label":"sokket:pal","ref":"pal","sha":"dbd55c3205c2fcf068b102575c615c9e941915e3","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","created_at":"2015-03-10T18:45:28Z","updated_at":"2015-05-06T18:55:19Z","pushed_at":"2015-08-27T19:35:23Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":29885,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9c4a347f1cba97e0e06c57001bd35f97bc144de9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-08-27T13:56:20Z","pushed_at":"2015-08-27T20:02:42Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":65324,"stargazers_count":8254,"watchers_count":8254,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1750,"mirror_url":null,"open_issues_count":555,"forks":1750,"open_issues":555,"watchers":8254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2999"},"html":{"href":"https://github.com/dotnet/corefx/pull/2999"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2999"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2999/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2999/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2999/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/dbd55c3205c2fcf068b102575c615c9e941915e3"}}}}