{"action":"created","comment":{"url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/comments/39771369","id":39771369,"diff_hunk":"@@ -426,4 +446,42 @@ public void onModeratorSet(String channelName, String username) {\n     }\n     chatUser.getModeratorInChannels().add(channelName);\n   }\n+\n+  @Override\n+  public Collection<Color> getAssignedColors() {\n+    return assignedColors;\n+  }\n+\n+  @Override\n+  public ImmutableSortedSet<Channel> getChannelsForUser(String username) {\n+    return pircBotX.getUserChannelDao().getChannels(pircBotX.getUserChannelDao().getUser(username));\n+  }\n+\n+  @Override\n+  public ChatUser getChatUser(String username) {\n+    for (String channel : chatUserLists.keySet()) {","path":"src/main/java/com/faforever/client/chat/PircBotXChatService.java","position":124,"original_position":124,"commit_id":"3b949cb932c75599ef488e53f174119cfcde7925","original_commit_id":"3b949cb932c75599ef488e53f174119cfcde7925","user":{"login":"micheljung","id":1864183,"avatar_url":"https://avatars.githubusercontent.com/u/1864183?v=3","gravatar_id":"","url":"https://api.github.com/users/micheljung","html_url":"https://github.com/micheljung","followers_url":"https://api.github.com/users/micheljung/followers","following_url":"https://api.github.com/users/micheljung/following{/other_user}","gists_url":"https://api.github.com/users/micheljung/gists{/gist_id}","starred_url":"https://api.github.com/users/micheljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micheljung/subscriptions","organizations_url":"https://api.github.com/users/micheljung/orgs","repos_url":"https://api.github.com/users/micheljung/repos","events_url":"https://api.github.com/users/micheljung/events{/privacy}","received_events_url":"https://api.github.com/users/micheljung/received_events","type":"User","site_admin":false},"body":"Don't iterate over `keySet()`, iterate over `entrySet()` instead: http://home.micheljung.ch/sonar/coding_rules#rule_key=squid%3AS2864","created_at":"2015-09-17T17:08:19Z","updated_at":"2015-09-17T17:08:19Z","html_url":"https://github.com/micheljung/downlords-faf-client/pull/103#discussion_r39771369","pull_request_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/comments/39771369"},"html":{"href":"https://github.com/micheljung/downlords-faf-client/pull/103#discussion_r39771369"},"pull_request":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103","id":45232376,"html_url":"https://github.com/micheljung/downlords-faf-client/pull/103","diff_url":"https://github.com/micheljung/downlords-faf-client/pull/103.diff","patch_url":"https://github.com/micheljung/downlords-faf-client/pull/103.patch","issue_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/103","number":103,"state":"open","locked":false,"title":"Enhanced chat","user":{"login":"Cheyans","id":8811789,"avatar_url":"https://avatars.githubusercontent.com/u/8811789?v=3","gravatar_id":"","url":"https://api.github.com/users/Cheyans","html_url":"https://github.com/Cheyans","followers_url":"https://api.github.com/users/Cheyans/followers","following_url":"https://api.github.com/users/Cheyans/following{/other_user}","gists_url":"https://api.github.com/users/Cheyans/gists{/gist_id}","starred_url":"https://api.github.com/users/Cheyans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cheyans/subscriptions","organizations_url":"https://api.github.com/users/Cheyans/orgs","repos_url":"https://api.github.com/users/Cheyans/repos","events_url":"https://api.github.com/users/Cheyans/events{/privacy}","received_events_url":"https://api.github.com/users/Cheyans/received_events","type":"User","site_admin":false},"body":"chat Colors for player groups\r\nprettyColors\r\ngameStatus + nice preview\r\ngameStatus symbol still needs to be fixed in regards to chatUserControl","created_at":"2015-09-16T22:30:53Z","updated_at":"2015-09-17T17:08:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"009807761ef6e63407319c3e5d3298b818dc2567","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103/commits","review_comments_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103/comments","review_comment_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/103/comments","statuses_url":"https://api.github.com/repos/micheljung/downlords-faf-client/statuses/3b949cb932c75599ef488e53f174119cfcde7925","head":{"label":"micheljung:enhancedChat","ref":"enhancedChat","sha":"3b949cb932c75599ef488e53f174119cfcde7925","user":{"login":"micheljung","id":1864183,"avatar_url":"https://avatars.githubusercontent.com/u/1864183?v=3","gravatar_id":"","url":"https://api.github.com/users/micheljung","html_url":"https://github.com/micheljung","followers_url":"https://api.github.com/users/micheljung/followers","following_url":"https://api.github.com/users/micheljung/following{/other_user}","gists_url":"https://api.github.com/users/micheljung/gists{/gist_id}","starred_url":"https://api.github.com/users/micheljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micheljung/subscriptions","organizations_url":"https://api.github.com/users/micheljung/orgs","repos_url":"https://api.github.com/users/micheljung/repos","events_url":"https://api.github.com/users/micheljung/events{/privacy}","received_events_url":"https://api.github.com/users/micheljung/received_events","type":"User","site_admin":false},"repo":{"id":32919066,"name":"downlords-faf-client","full_name":"micheljung/downlords-faf-client","owner":{"login":"micheljung","id":1864183,"avatar_url":"https://avatars.githubusercontent.com/u/1864183?v=3","gravatar_id":"","url":"https://api.github.com/users/micheljung","html_url":"https://github.com/micheljung","followers_url":"https://api.github.com/users/micheljung/followers","following_url":"https://api.github.com/users/micheljung/following{/other_user}","gists_url":"https://api.github.com/users/micheljung/gists{/gist_id}","starred_url":"https://api.github.com/users/micheljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micheljung/subscriptions","organizations_url":"https://api.github.com/users/micheljung/orgs","repos_url":"https://api.github.com/users/micheljung/repos","events_url":"https://api.github.com/users/micheljung/events{/privacy}","received_events_url":"https://api.github.com/users/micheljung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micheljung/downlords-faf-client","description":"A high quality re-implementation of the Forged Alliance Forever client","fork":false,"url":"https://api.github.com/repos/micheljung/downlords-faf-client","forks_url":"https://api.github.com/repos/micheljung/downlords-faf-client/forks","keys_url":"https://api.github.com/repos/micheljung/downlords-faf-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micheljung/downlords-faf-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micheljung/downlords-faf-client/teams","hooks_url":"https://api.github.com/repos/micheljung/downlords-faf-client/hooks","issue_events_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/events{/number}","events_url":"https://api.github.com/repos/micheljung/downlords-faf-client/events","assignees_url":"https://api.github.com/repos/micheljung/downlords-faf-client/assignees{/user}","branches_url":"https://api.github.com/repos/micheljung/downlords-faf-client/branches{/branch}","tags_url":"https://api.github.com/repos/micheljung/downlords-faf-client/tags","blobs_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micheljung/downlords-faf-client/statuses/{sha}","languages_url":"https://api.github.com/repos/micheljung/downlords-faf-client/languages","stargazers_url":"https://api.github.com/repos/micheljung/downlords-faf-client/stargazers","contributors_url":"https://api.github.com/repos/micheljung/downlords-faf-client/contributors","subscribers_url":"https://api.github.com/repos/micheljung/downlords-faf-client/subscribers","subscription_url":"https://api.github.com/repos/micheljung/downlords-faf-client/subscription","commits_url":"https://api.github.com/repos/micheljung/downlords-faf-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/micheljung/downlords-faf-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/micheljung/downlords-faf-client/contents/{+path}","compare_url":"https://api.github.com/repos/micheljung/downlords-faf-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micheljung/downlords-faf-client/merges","archive_url":"https://api.github.com/repos/micheljung/downlords-faf-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micheljung/downlords-faf-client/downloads","issues_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues{/number}","pulls_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls{/number}","milestones_url":"https://api.github.com/repos/micheljung/downlords-faf-client/milestones{/number}","notifications_url":"https://api.github.com/repos/micheljung/downlords-faf-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micheljung/downlords-faf-client/labels{/name}","releases_url":"https://api.github.com/repos/micheljung/downlords-faf-client/releases{/id}","created_at":"2015-03-26T09:47:32Z","updated_at":"2015-08-07T14:52:54Z","pushed_at":"2015-09-17T15:09:44Z","git_url":"git://github.com/micheljung/downlords-faf-client.git","ssh_url":"git@github.com:micheljung/downlords-faf-client.git","clone_url":"https://github.com/micheljung/downlords-faf-client.git","svn_url":"https://github.com/micheljung/downlords-faf-client","homepage":"","size":11166,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":54,"forks":1,"open_issues":54,"watchers":5,"default_branch":"master"}},"base":{"label":"micheljung:master","ref":"master","sha":"ba736a886ed487ad1b4132200ecfa52c2caa172f","user":{"login":"micheljung","id":1864183,"avatar_url":"https://avatars.githubusercontent.com/u/1864183?v=3","gravatar_id":"","url":"https://api.github.com/users/micheljung","html_url":"https://github.com/micheljung","followers_url":"https://api.github.com/users/micheljung/followers","following_url":"https://api.github.com/users/micheljung/following{/other_user}","gists_url":"https://api.github.com/users/micheljung/gists{/gist_id}","starred_url":"https://api.github.com/users/micheljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micheljung/subscriptions","organizations_url":"https://api.github.com/users/micheljung/orgs","repos_url":"https://api.github.com/users/micheljung/repos","events_url":"https://api.github.com/users/micheljung/events{/privacy}","received_events_url":"https://api.github.com/users/micheljung/received_events","type":"User","site_admin":false},"repo":{"id":32919066,"name":"downlords-faf-client","full_name":"micheljung/downlords-faf-client","owner":{"login":"micheljung","id":1864183,"avatar_url":"https://avatars.githubusercontent.com/u/1864183?v=3","gravatar_id":"","url":"https://api.github.com/users/micheljung","html_url":"https://github.com/micheljung","followers_url":"https://api.github.com/users/micheljung/followers","following_url":"https://api.github.com/users/micheljung/following{/other_user}","gists_url":"https://api.github.com/users/micheljung/gists{/gist_id}","starred_url":"https://api.github.com/users/micheljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micheljung/subscriptions","organizations_url":"https://api.github.com/users/micheljung/orgs","repos_url":"https://api.github.com/users/micheljung/repos","events_url":"https://api.github.com/users/micheljung/events{/privacy}","received_events_url":"https://api.github.com/users/micheljung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micheljung/downlords-faf-client","description":"A high quality re-implementation of the Forged Alliance Forever client","fork":false,"url":"https://api.github.com/repos/micheljung/downlords-faf-client","forks_url":"https://api.github.com/repos/micheljung/downlords-faf-client/forks","keys_url":"https://api.github.com/repos/micheljung/downlords-faf-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micheljung/downlords-faf-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micheljung/downlords-faf-client/teams","hooks_url":"https://api.github.com/repos/micheljung/downlords-faf-client/hooks","issue_events_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/events{/number}","events_url":"https://api.github.com/repos/micheljung/downlords-faf-client/events","assignees_url":"https://api.github.com/repos/micheljung/downlords-faf-client/assignees{/user}","branches_url":"https://api.github.com/repos/micheljung/downlords-faf-client/branches{/branch}","tags_url":"https://api.github.com/repos/micheljung/downlords-faf-client/tags","blobs_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micheljung/downlords-faf-client/statuses/{sha}","languages_url":"https://api.github.com/repos/micheljung/downlords-faf-client/languages","stargazers_url":"https://api.github.com/repos/micheljung/downlords-faf-client/stargazers","contributors_url":"https://api.github.com/repos/micheljung/downlords-faf-client/contributors","subscribers_url":"https://api.github.com/repos/micheljung/downlords-faf-client/subscribers","subscription_url":"https://api.github.com/repos/micheljung/downlords-faf-client/subscription","commits_url":"https://api.github.com/repos/micheljung/downlords-faf-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/micheljung/downlords-faf-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/micheljung/downlords-faf-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/micheljung/downlords-faf-client/contents/{+path}","compare_url":"https://api.github.com/repos/micheljung/downlords-faf-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micheljung/downlords-faf-client/merges","archive_url":"https://api.github.com/repos/micheljung/downlords-faf-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micheljung/downlords-faf-client/downloads","issues_url":"https://api.github.com/repos/micheljung/downlords-faf-client/issues{/number}","pulls_url":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls{/number}","milestones_url":"https://api.github.com/repos/micheljung/downlords-faf-client/milestones{/number}","notifications_url":"https://api.github.com/repos/micheljung/downlords-faf-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micheljung/downlords-faf-client/labels{/name}","releases_url":"https://api.github.com/repos/micheljung/downlords-faf-client/releases{/id}","created_at":"2015-03-26T09:47:32Z","updated_at":"2015-08-07T14:52:54Z","pushed_at":"2015-09-17T15:09:44Z","git_url":"git://github.com/micheljung/downlords-faf-client.git","ssh_url":"git@github.com:micheljung/downlords-faf-client.git","clone_url":"https://github.com/micheljung/downlords-faf-client.git","svn_url":"https://github.com/micheljung/downlords-faf-client","homepage":"","size":11166,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":54,"forks":1,"open_issues":54,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103"},"html":{"href":"https://github.com/micheljung/downlords-faf-client/pull/103"},"issue":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/103"},"comments":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/micheljung/downlords-faf-client/statuses/3b949cb932c75599ef488e53f174119cfcde7925"}}}}