{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1695","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1695/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1695/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1695/events","html_url":"https://github.com/buildbot/buildbot/pull/1695","id":82310297,"number":1695,"title":"Remove slave source commands","user":{"login":"elmirjagudin","id":3404641,"avatar_url":"https://avatars.githubusercontent.com/u/3404641?v=3","gravatar_id":"","url":"https://api.github.com/users/elmirjagudin","html_url":"https://github.com/elmirjagudin","followers_url":"https://api.github.com/users/elmirjagudin/followers","following_url":"https://api.github.com/users/elmirjagudin/following{/other_user}","gists_url":"https://api.github.com/users/elmirjagudin/gists{/gist_id}","starred_url":"https://api.github.com/users/elmirjagudin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmirjagudin/subscriptions","organizations_url":"https://api.github.com/users/elmirjagudin/orgs","repos_url":"https://api.github.com/users/elmirjagudin/repos","events_url":"https://api.github.com/users/elmirjagudin/events{/privacy}","received_events_url":"https://api.github.com/users/elmirjagudin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20more%20review","name":"needs more review","color":"bfe5bf"},{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20work","name":"needs work","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-29T07:34:12Z","updated_at":"2015-06-06T22:13:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1695","html_url":"https://github.com/buildbot/buildbot/pull/1695","diff_url":"https://github.com/buildbot/buildbot/pull/1695.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1695.patch"},"body":"As discussed in PR https://github.com/buildbot/buildbot/pull/1659, here is PR that drops the slave-side source commands.\r\n\r\nThe 'trial buildslave.test' passes and I did some light testing with Git/Hg based checkouts. Nothing obvious breaks."},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/109654222","html_url":"https://github.com/buildbot/buildbot/pull/1695#issuecomment-109654222","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1695","id":109654222,"user":{"login":"elmirjagudin","id":3404641,"avatar_url":"https://avatars.githubusercontent.com/u/3404641?v=3","gravatar_id":"","url":"https://api.github.com/users/elmirjagudin","html_url":"https://github.com/elmirjagudin","followers_url":"https://api.github.com/users/elmirjagudin/followers","following_url":"https://api.github.com/users/elmirjagudin/following{/other_user}","gists_url":"https://api.github.com/users/elmirjagudin/gists{/gist_id}","starred_url":"https://api.github.com/users/elmirjagudin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmirjagudin/subscriptions","organizations_url":"https://api.github.com/users/elmirjagudin/orgs","repos_url":"https://api.github.com/users/elmirjagudin/repos","events_url":"https://api.github.com/users/elmirjagudin/events{/privacy}","received_events_url":"https://api.github.com/users/elmirjagudin/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T22:13:58Z","updated_at":"2015-06-06T22:13:58Z","body":"Not sure what is a good way to generate the error message. As far as I can tell it's not possible to signal that a slave command have been removed within current protocol.\r\n\r\nHere is one way I managed to come up with: https://github.com/elmirjagudin/buildbot/commit/4fa4e18119a04bc76e34f4e43d53973a337b5f7e\r\n\r\nI have added a list of removed commands to the slave. Whenever master tries to run a command that the slave does not recognize, the list will be checked, and a RemoveCommand exception will be raised.\r\n\r\n(This is still work in progress, I plan on adding unittests)\r\n\r\nWhat do you think?"}}