{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/24633","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/24633/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/24633/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/24633/events","html_url":"https://github.com/dart-lang/sdk/issues/24633","id":112251531,"number":24633,"title":"Please merge revision several Dartium revisions into dev channel","user":{"login":"alan-knight","id":3476088,"avatar_url":"https://avatars.githubusercontent.com/u/3476088?v=3","gravatar_id":"","url":"https://api.github.com/users/alan-knight","html_url":"https://github.com/alan-knight","followers_url":"https://api.github.com/users/alan-knight/followers","following_url":"https://api.github.com/users/alan-knight/following{/other_user}","gists_url":"https://api.github.com/users/alan-knight/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-knight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-knight/subscriptions","organizations_url":"https://api.github.com/users/alan-knight/orgs","repos_url":"https://api.github.com/users/alan-knight/repos","events_url":"https://api.github.com/users/alan-knight/events{/privacy}","received_events_url":"https://api.github.com/users/alan-knight/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dart-lang/sdk/labels/Area-Dartium","name":"Area-Dartium","color":"ededed"},{"url":"https://api.github.com/repos/dart-lang/sdk/labels/MergeToDev","name":"MergeToDev","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/dart-lang/sdk/milestones/30","html_url":"https://github.com/dart-lang/sdk/milestones/1.13","labels_url":"https://api.github.com/repos/dart-lang/sdk/milestones/30/labels","id":1171621,"number":30,"title":"1.13","description":null,"creator":{"login":"kwalrath","id":2164483,"avatar_url":"https://avatars.githubusercontent.com/u/2164483?v=3","gravatar_id":"","url":"https://api.github.com/users/kwalrath","html_url":"https://github.com/kwalrath","followers_url":"https://api.github.com/users/kwalrath/followers","following_url":"https://api.github.com/users/kwalrath/following{/other_user}","gists_url":"https://api.github.com/users/kwalrath/gists{/gist_id}","starred_url":"https://api.github.com/users/kwalrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwalrath/subscriptions","organizations_url":"https://api.github.com/users/kwalrath/orgs","repos_url":"https://api.github.com/users/kwalrath/repos","events_url":"https://api.github.com/users/kwalrath/events{/privacy}","received_events_url":"https://api.github.com/users/kwalrath/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":47,"state":"open","created_at":"2015-06-18T23:05:19Z","updated_at":"2015-10-20T17:23:34Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-10-19T23:11:20Z","updated_at":"2015-10-20T17:28:05Z","closed_at":null,"body":"@whesse @mit-mit @kasperl\r\n@kevmoo @terrylucas \r\n\r\nThis merges two CLs that move top-level methods used for JS-interop Dartium out of the public dart:html api, and one which fixes custom element issues, and is required for an almost-clean merge of the others. And for custom elements to work properly.\r\n\r\n<What revision(s) needs to be merged - please annotate revisions with reason if more than one>\r\n1a1820bbe3bf3b393105a342b414730f9ba105d3      - moves make_dart_rectangle\r\n4653701a7656136d2725b76497cf1a67a15dd4f4      - custom element fixes\r\na9362610ee429a0b69653635039696f86976f564      - moves various other methods\r\n\r\n<Please try out the merge yourself. If there are merge conflicts please resolve these and upload the cl to rietveld and provide a link here>\r\nThis did not merge cleanly. There was only one conflict, which affected a comment line. And when running the tests, I had to remove one test suppression. And I regenerated html_dartium.dart\r\n\r\nhttps://codereview.chromium.org/1413763005\r\n"},"comment":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/comments/149640091","html_url":"https://github.com/dart-lang/sdk/issues/24633#issuecomment-149640091","issue_url":"https://api.github.com/repos/dart-lang/sdk/issues/24633","id":149640091,"user":{"login":"alan-knight","id":3476088,"avatar_url":"https://avatars.githubusercontent.com/u/3476088?v=3","gravatar_id":"","url":"https://api.github.com/users/alan-knight","html_url":"https://github.com/alan-knight","followers_url":"https://api.github.com/users/alan-knight/followers","following_url":"https://api.github.com/users/alan-knight/following{/other_user}","gists_url":"https://api.github.com/users/alan-knight/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-knight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-knight/subscriptions","organizations_url":"https://api.github.com/users/alan-knight/orgs","repos_url":"https://api.github.com/users/alan-knight/repos","events_url":"https://api.github.com/users/alan-knight/events{/privacy}","received_events_url":"https://api.github.com/users/alan-knight/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T17:28:05Z","updated_at":"2015-10-20T17:28:05Z","body":"Terry points out that this does merge cleanly if we incorporate all the Dartium-related updates into one. So, instead\r\n\r\n  5bd1ce68d1301f017234dc3696bb1fafaaf8cbbe - Fixed native element extension, custom events, _VMUpgrader\r\n\r\n  3e48b42360297ae8f306668fc74331f7a80a2526 - move make_dart_rectangle out of dart:html into html_common\r\n\r\na86f7dbeb047e7ca99dca3c0e3cfcb51f6f952af - Custom elements should work only in html and svg namespaces\r\n\r\n2f999508446428d18c0962a47ab4f00c4a03d87a - Move additional methods from dart:html into html_common\r\n\r\n6ab000fbd3db499d7cd83e232f09a30d1ffa281f - Update test suppressions\r\n\r\n7aedf74616bffdedebb7c50aea8a98a0749a07b1 - DEPS update for webkit change: Make Dart objects passed to JavaScript expose the Dart toString method\r\n\r\nNow this merges cleanly and all tests pass."}}