{"action":"created","issue":{"url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/40","labels_url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/40/comments","events_url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/40/events","html_url":"https://github.com/thecodejunkie/github.expandinizr/pull/40","id":102025105,"number":40,"title":"Enterprise Github Options for Issue #4","user":{"login":"ccampanale","id":7512892,"avatar_url":"https://avatars.githubusercontent.com/u/7512892?v=3","gravatar_id":"","url":"https://api.github.com/users/ccampanale","html_url":"https://github.com/ccampanale","followers_url":"https://api.github.com/users/ccampanale/followers","following_url":"https://api.github.com/users/ccampanale/following{/other_user}","gists_url":"https://api.github.com/users/ccampanale/gists{/gist_id}","starred_url":"https://api.github.com/users/ccampanale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccampanale/subscriptions","organizations_url":"https://api.github.com/users/ccampanale/orgs","repos_url":"https://api.github.com/users/ccampanale/repos","events_url":"https://api.github.com/users/ccampanale/events{/privacy}","received_events_url":"https://api.github.com/users/ccampanale/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/labels/Feature","name":"Feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/milestones/7","html_url":"https://github.com/thecodejunkie/github.expandinizr/milestones/1.8.0","labels_url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/milestones/7/labels","id":1344759,"number":7,"title":"1.8.0","description":"","creator":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-10-08T14:34:25Z","updated_at":"2015-10-08T14:34:38Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-08-19T23:47:55Z","updated_at":"2015-10-11T17:35:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/pulls/40","html_url":"https://github.com/thecodejunkie/github.expandinizr/pull/40","diff_url":"https://github.com/thecodejunkie/github.expandinizr/pull/40.diff","patch_url":"https://github.com/thecodejunkie/github.expandinizr/pull/40.patch"},"body":"Lots of changes to add support for Enterprise Github installations in response to issue #4:\r\n\r\n- Added backgorund script which is necessary to inject scripts to optional_permissions sites\r\n- Updated manifest to include new background.js page\r\n- Added options page to project and manifest\r\n- Added option to toggle functionality for default sites: github.com and gist.github.com\r\n- Removed content scripts from manifest and wrote new logic for injection into the background.js\r\n- Default sites will always show up first in the options list\r\n- Added permissions for tabs in order to check URL against default options\r\n- Added permissions for storage in order to store options for toggling default site functionality\r\n- Add button disabled when url field is empty\r\n- Errors now show up in a message div to the right of the add button\r\n- Attempt to add duplicate URL error is more verbose now\r\n- Changed some line endings on a couple files from Windows to Linux"},"comment":{"url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/comments/147223556","html_url":"https://github.com/thecodejunkie/github.expandinizr/pull/40#issuecomment-147223556","issue_url":"https://api.github.com/repos/thecodejunkie/github.expandinizr/issues/40","id":147223556,"user":{"login":"ccampanale","id":7512892,"avatar_url":"https://avatars.githubusercontent.com/u/7512892?v=3","gravatar_id":"","url":"https://api.github.com/users/ccampanale","html_url":"https://github.com/ccampanale","followers_url":"https://api.github.com/users/ccampanale/followers","following_url":"https://api.github.com/users/ccampanale/following{/other_user}","gists_url":"https://api.github.com/users/ccampanale/gists{/gist_id}","starred_url":"https://api.github.com/users/ccampanale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccampanale/subscriptions","organizations_url":"https://api.github.com/users/ccampanale/orgs","repos_url":"https://api.github.com/users/ccampanale/repos","events_url":"https://api.github.com/users/ccampanale/events{/privacy}","received_events_url":"https://api.github.com/users/ccampanale/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T17:35:08Z","updated_at":"2015-10-11T17:35:08Z","body":"@khellang You can start reviewing the code now if you'd like. I resolved the conflicts and made a few adjustments to account for using bower now as well as some logic that needed to be retouched. \r\n\r\nI still need to double check the enterprise functionality though just to make sure that everything is working the way I expect it to. I will post again once I've done this.\r\n\r\nI made a couple notes throughout the code about where things are and why they are/not there but please do let me know if you have any questions. "}}