{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31266311","id":31266311,"diff_hunk":"@@ -40,6 +40,13 @@ DAEMON_USER=root\n #\n do_start()\n {\n+        # Avoid a potential race at boot time when both monit and init.d start\n+        # the same service\n+        PIDS=$(pidof $DAEMON)\n+        for PID in \"${PIDS}\"; do","path":"cluster/saltbase/salt/kube-proxy/initd","position":null,"original_position":7,"commit_id":"79a2a4f18db9d16789df51ebdf2bc1b009e80f38","original_commit_id":"3bc095e5f2de47b88d4112beb9d47b0cf220ed46","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"body":"Oops, same mistake again. Fixed. Thanks for catching this, and luckily we only have one for each daemon here. :-(","created_at":"2015-05-28T18:59:38Z","updated_at":"2015-05-28T18:59:38Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931#discussion_r31266311","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31266311"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931#discussion_r31266311"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931","id":36434505,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8931","number":8931,"state":"open","locked":false,"title":"Fix the race when monit is used to monitor services which are also","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"body":"started at boot time via init.d at boot time.\r\n\r\nFixed #8742\r\n\r\nI ran e2e tests earlier this morning, but failed due to e2e current breakage. I manually tested this on machine without current patch, manually running service kubelet start (not restart) will reproduce binding issue reported in #8742 \r\n\r\n```\r\n# ps -ef | grep kubelet\r\nroot      5609     1  1 17:38 ?        00:00:12 /usr/local/bin/kubelet --api_servers=https://kubernetes-master --cloud_provider=gce --config=/etc/kubernetes/manifests --allow_privileged=False --v=2 --cluster_dns=10.0.0.10 --cluster_domain=cluster.local --configure-cbr0=true --cgroup_root=/\r\n\r\n# service kubelet start\r\n[ ok ] Starting The Kubernetes container manager: kubelet.\r\n\r\n# ps -ef | grep kubelet\r\nroot     16737     1  9 17:56 ?        00:00:01 /usr/local/bin/kubelet --api_servers=https://kubernetes-master --cloud_provider=gce --config=/etc/kubernetes/manifests --allow_privileged=False --v=2 --cluster_dns=10.0.0.10 --cluster_domain=cluster.local --configure-cbr0=true --cgroup_root=/\r\n\r\n```\r\n\r\ncc/ @vmarmol @roberthbailey ","created_at":"2015-05-28T18:08:43Z","updated_at":"2015-05-28T18:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2676c66d0c9e37ac759ce047bcc492386db1cc26","assignee":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8931/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/79a2a4f18db9d16789df51ebdf2bc1b009e80f38","head":{"label":"dchen1107:clean","ref":"clean","sha":"79a2a4f18db9d16789df51ebdf2bc1b009e80f38","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"repo":{"id":21153738,"name":"kubernetes-1","full_name":"dchen1107/kubernetes-1","owner":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchen1107/kubernetes-1","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/dchen1107/kubernetes-1","forks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/forks","keys_url":"https://api.github.com/repos/dchen1107/kubernetes-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchen1107/kubernetes-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchen1107/kubernetes-1/teams","hooks_url":"https://api.github.com/repos/dchen1107/kubernetes-1/hooks","issue_events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/events{/number}","events_url":"https://api.github.com/repos/dchen1107/kubernetes-1/events","assignees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/assignees{/user}","branches_url":"https://api.github.com/repos/dchen1107/kubernetes-1/branches{/branch}","tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/tags","blobs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchen1107/kubernetes-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dchen1107/kubernetes-1/languages","stargazers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/stargazers","contributors_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contributors","subscribers_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscribers","subscription_url":"https://api.github.com/repos/dchen1107/kubernetes-1/subscription","commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchen1107/kubernetes-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchen1107/kubernetes-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchen1107/kubernetes-1/contents/{+path}","compare_url":"https://api.github.com/repos/dchen1107/kubernetes-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchen1107/kubernetes-1/merges","archive_url":"https://api.github.com/repos/dchen1107/kubernetes-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchen1107/kubernetes-1/downloads","issues_url":"https://api.github.com/repos/dchen1107/kubernetes-1/issues{/number}","pulls_url":"https://api.github.com/repos/dchen1107/kubernetes-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dchen1107/kubernetes-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dchen1107/kubernetes-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchen1107/kubernetes-1/labels{/name}","releases_url":"https://api.github.com/repos/dchen1107/kubernetes-1/releases{/id}","created_at":"2014-06-24T05:53:16Z","updated_at":"2015-04-03T05:38:13Z","pushed_at":"2015-05-28T18:58:41Z","git_url":"git://github.com/dchen1107/kubernetes-1.git","ssh_url":"git@github.com:dchen1107/kubernetes-1.git","clone_url":"https://github.com/dchen1107/kubernetes-1.git","svn_url":"https://github.com/dchen1107/kubernetes-1","homepage":null,"size":60528,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f015a2102662d983abb981ed3202210400b9aafe","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-28T17:39:21Z","pushed_at":"2015-05-28T18:58:42Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":296534,"stargazers_count":7966,"watchers_count":7966,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1666,"mirror_url":null,"open_issues_count":1258,"forks":1666,"open_issues":1258,"watchers":7966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8931"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8931"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8931/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8931/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/79a2a4f18db9d16789df51ebdf2bc1b009e80f38"}}}}