{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123","id":32118482,"html_url":"https://github.com/Zizzamia/ng-tasty/pull/123","diff_url":"https://github.com/Zizzamia/ng-tasty/pull/123.diff","patch_url":"https://github.com/Zizzamia/ng-tasty/pull/123.patch","issue_url":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/123","number":123,"state":"open","locked":false,"title":"cleanFieldName may now contain _ and keep it, instead of replacing it","user":{"login":"wahidnory","id":3277057,"avatar_url":"https://avatars.githubusercontent.com/u/3277057?v=3","gravatar_id":"","url":"https://api.github.com/users/wahidnory","html_url":"https://github.com/wahidnory","followers_url":"https://api.github.com/users/wahidnory/followers","following_url":"https://api.github.com/users/wahidnory/following{/other_user}","gists_url":"https://api.github.com/users/wahidnory/gists{/gist_id}","starred_url":"https://api.github.com/users/wahidnory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wahidnory/subscriptions","organizations_url":"https://api.github.com/users/wahidnory/orgs","repos_url":"https://api.github.com/users/wahidnory/repos","events_url":"https://api.github.com/users/wahidnory/events{/privacy}","received_events_url":"https://api.github.com/users/wahidnory/received_events","type":"User","site_admin":false},"body":"Hi, \r\nI've started using this great component for my project and came across an odd issue. \r\n\r\nWhat happened was that I've gotten the key value as 'some_value' from the server for the header. And after I've tried to click on the header to sort it, nothing happened and no errors occurred.\r\nWell the first time something does happen, but the icon does not get set properly and on second click you can't click it anymore. \r\n\r\nI think I've managed to fix the problem.\r\n\r\nAlso added a test-case to see if it was working. \r\n\r\nIf you want to see what was wrong on the regular branch you can add the following lines to the server.js\r\n```javascript\r\n(line 112)\r\nrows = [\r\n    { 'name': 'Ritual Coffee Roasters', 'star': '★★★★★', 'sf-location': 'Hayes Valley', 'some_value': 'Test'},\r\n    { 'name': 'Blue Bottle', 'star': '★★★★★', 'sf-location': 'Hayes Valley', 'some_value': 'Test'},\r\n    { 'name': 'CoffeeShop', 'star': '★★★', 'sf-location': 'Bernal Heights', 'some_value': 'Test'},\r\n    { 'name': 'Spike\\'s Coffee & Teas', 'star': '★★★', 'sf-location': 'Castro', 'some_value': 'Test'},\r\n    { 'name': 'La Boulange', 'star': '★★', 'sf-location': 'Cole Valley', 'some_value': 'Test'},\r\n    { 'name': 'Dynamo Donut and Coffee', 'star': '★★★★★', 'sf-location': 'Cow Hollow', 'some_value': 'Test'},\r\n    { 'name': 'The Mill', 'star': '★★★★', 'sf-location': 'Divisadero', 'some_value': 'Test'},\r\n    { 'name': 'Piccino Coffee Bar', 'star': '★★★', 'sf-location': 'Dogpatch', 'some_value': 'Test'},\r\n    { 'name': 'Philz', 'star': '★★★', 'sf-location': 'Downtown', 'some_value': 'Test'},\r\n    { 'name': 'Duboce Park Cafe', 'star': '★★', 'sf-location': 'Duboce Triangle', 'some_value': 'Test'},\r\n    { 'name': 'Blue Bottle', 'star': '★★★★★', 'sf-location': 'Embarcadero', 'some_value': 'Test'},\r\n    { 'name': 'Four Barrel', 'star': '★★★', 'sf-location': 'Excelsior', 'some_value': 'Test'},\r\n    { 'name': 'Coffee Bar', 'star': '★★★★★', 'sf-location': 'FiDi', 'some_value': 'Test'},\r\n    { 'name': 'Biscoff Coffee Corner', 'star': '★★★', 'sf-location': 'Fisherman’s Wharf', 'some_value': 'Test'},\r\n    { 'name': 'Fifty/Fifty Coffee and Tea', 'star': '★★★', 'sf-location': 'Inner Richmond', 'some_value': 'Test'},\r\n    { 'name': 'Beanery', 'star': '★★★', 'sf-location': 'Inner Sunset', 'some_value': 'Test'},\r\n    { 'name': 'Cafe du Soleil', 'star': '★★', 'sf-location': 'Lower Haight', 'some_value': 'Test'},\r\n    { 'name': 'Dimmi Tutto Cafe', 'star': '★★★', 'sf-location': 'North Beach', 'some_value': 'Test'},\r\n    { 'name': 'Peet\\'s', 'star': '★', 'sf-location': 'The Marina', 'some_value': 'Test'},\r\n    { 'name': 'Sightglass', 'star': '★★★★', 'sf-location': 'The Mission', 'some_value': 'Test'},\r\n    { 'name': 'Contraband Coffee Bar', 'star': '★★★★', 'sf-location': 'Nob Hill', 'some_value': 'Test'},\r\n    { 'name': 'Martha & Bros Coffee', 'star': '★★★', 'sf-location': 'Noe Valley', 'some_value': 'Test'},\r\n    { 'name': 'Réveille', 'star': '★★★', 'sf-location': 'North Beach', 'some_value': 'Test'},\r\n    { 'name': 'Cup Coffee Bar', 'star': '★★★', 'sf-location': 'Outer Mission', 'some_value': 'Test'},\r\n    { 'name': 'Garden House Cafe', 'star': '★★★', 'sf-location': 'Outer Richmond', 'some_value': 'Test'},\r\n    { 'name': 'Andytown Coffee Roasters', 'star': '★★★', 'sf-location': 'Outer Sunset', 'some_value': 'Test'},\r\n    { 'name': 'Jane on Fillmore', 'star': '★★', 'sf-location': 'Pacific Heights', 'some_value': 'Test'},\r\n    { 'name': 'Saint Frank Coffee', 'star': '★★★', 'sf-location': 'Polk', 'some_value': 'Test'},\r\n    { 'name': 'Farley’s', 'star': '★★★', 'sf-location': 'Potrero Hill', 'some_value': 'Test'},\r\n    { 'name': 'House of Snacks', 'star': '★★★', 'sf-location': 'The Presidio', 'some_value': 'Test'},\r\n    { 'name': 'The Brew', 'star': '★★★', 'sf-location': 'Russian Hill' , 'some_value': 'Test'},\r\n    { 'name': 'Wicked Grounds', 'star': '★★★', 'sf-location': 'SOMA', 'some_value': 'Test'},\r\n    { 'name': 'Starbucks', 'star': '★', 'sf-location': 'Union Square', 'some_value': 'Test'},\r\n    { 'name': 'Flywheel Coffee Roasters', 'star': '★★★★★', 'sf-location': 'Upper Haight', 'some_value': 'Welp'},\r\n  ];\r\n\r\n// from line 182 so the server sorts the table when we want it to.\r\n} else if (req.query['some_value'] && req.query['some_value'].length) {\r\n      location = req.query['some_value'].toLowerCase();\r\n      return el['some_vlaue'].toLowerCase().indexOf(location) >= 0;\r\n\r\n// from line 217 an extra header key value for the table to display.\r\n{\r\n        'key': 'some_value', \r\n        'name': 'Test Column'\r\n}\r\n```\r\n\r\nAnd the following line to the `complete.html` in `docs/template/table-server-side/`\r\n```html\r\nfrom line 26\r\n<tr ng-repeat=\"row in rows\">\r\n              <td>{{ row.name }}</td>\r\n              <td>{{ row.star }}</td>\r\n              <td>{{ row['sf-location'] }}</td>\r\n              <td>{{ row.some_value }}</td> <!-- this one -->\r\n</tr>\r\n```\r\nAnd if you go to the table server side on the docs page you should be able to see what I mean. \r\n\r\nMy best regards and hope this was clear enough.\r\n\r\nps. Keep up the great work!\r\n\r\n","created_at":"2015-03-27T15:43:47Z","updated_at":"2015-03-27T15:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123/commits","review_comments_url":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123/comments","review_comment_url":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/123/comments","statuses_url":"https://api.github.com/repos/Zizzamia/ng-tasty/statuses/1a4b52f870f53f32f4b6edd2e9711cb2ec3c4421","head":{"label":"wahidnory:master","ref":"master","sha":"1a4b52f870f53f32f4b6edd2e9711cb2ec3c4421","user":{"login":"wahidnory","id":3277057,"avatar_url":"https://avatars.githubusercontent.com/u/3277057?v=3","gravatar_id":"","url":"https://api.github.com/users/wahidnory","html_url":"https://github.com/wahidnory","followers_url":"https://api.github.com/users/wahidnory/followers","following_url":"https://api.github.com/users/wahidnory/following{/other_user}","gists_url":"https://api.github.com/users/wahidnory/gists{/gist_id}","starred_url":"https://api.github.com/users/wahidnory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wahidnory/subscriptions","organizations_url":"https://api.github.com/users/wahidnory/orgs","repos_url":"https://api.github.com/users/wahidnory/repos","events_url":"https://api.github.com/users/wahidnory/events{/privacy}","received_events_url":"https://api.github.com/users/wahidnory/received_events","type":"User","site_admin":false},"repo":{"id":32991040,"name":"ng-tasty","full_name":"wahidnory/ng-tasty","owner":{"login":"wahidnory","id":3277057,"avatar_url":"https://avatars.githubusercontent.com/u/3277057?v=3","gravatar_id":"","url":"https://api.github.com/users/wahidnory","html_url":"https://github.com/wahidnory","followers_url":"https://api.github.com/users/wahidnory/followers","following_url":"https://api.github.com/users/wahidnory/following{/other_user}","gists_url":"https://api.github.com/users/wahidnory/gists{/gist_id}","starred_url":"https://api.github.com/users/wahidnory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wahidnory/subscriptions","organizations_url":"https://api.github.com/users/wahidnory/orgs","repos_url":"https://api.github.com/users/wahidnory/repos","events_url":"https://api.github.com/users/wahidnory/events{/privacy}","received_events_url":"https://api.github.com/users/wahidnory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wahidnory/ng-tasty","description":"A tasty collection of reusable UI components for Angular, like grandma used to make. Like Table directive, WebSocket / Debounce / Throttle service, Range / Camelize / Slugify filters","fork":true,"url":"https://api.github.com/repos/wahidnory/ng-tasty","forks_url":"https://api.github.com/repos/wahidnory/ng-tasty/forks","keys_url":"https://api.github.com/repos/wahidnory/ng-tasty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wahidnory/ng-tasty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wahidnory/ng-tasty/teams","hooks_url":"https://api.github.com/repos/wahidnory/ng-tasty/hooks","issue_events_url":"https://api.github.com/repos/wahidnory/ng-tasty/issues/events{/number}","events_url":"https://api.github.com/repos/wahidnory/ng-tasty/events","assignees_url":"https://api.github.com/repos/wahidnory/ng-tasty/assignees{/user}","branches_url":"https://api.github.com/repos/wahidnory/ng-tasty/branches{/branch}","tags_url":"https://api.github.com/repos/wahidnory/ng-tasty/tags","blobs_url":"https://api.github.com/repos/wahidnory/ng-tasty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wahidnory/ng-tasty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wahidnory/ng-tasty/git/refs{/sha}","trees_url":"https://api.github.com/repos/wahidnory/ng-tasty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wahidnory/ng-tasty/statuses/{sha}","languages_url":"https://api.github.com/repos/wahidnory/ng-tasty/languages","stargazers_url":"https://api.github.com/repos/wahidnory/ng-tasty/stargazers","contributors_url":"https://api.github.com/repos/wahidnory/ng-tasty/contributors","subscribers_url":"https://api.github.com/repos/wahidnory/ng-tasty/subscribers","subscription_url":"https://api.github.com/repos/wahidnory/ng-tasty/subscription","commits_url":"https://api.github.com/repos/wahidnory/ng-tasty/commits{/sha}","git_commits_url":"https://api.github.com/repos/wahidnory/ng-tasty/git/commits{/sha}","comments_url":"https://api.github.com/repos/wahidnory/ng-tasty/comments{/number}","issue_comment_url":"https://api.github.com/repos/wahidnory/ng-tasty/issues/comments{/number}","contents_url":"https://api.github.com/repos/wahidnory/ng-tasty/contents/{+path}","compare_url":"https://api.github.com/repos/wahidnory/ng-tasty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wahidnory/ng-tasty/merges","archive_url":"https://api.github.com/repos/wahidnory/ng-tasty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wahidnory/ng-tasty/downloads","issues_url":"https://api.github.com/repos/wahidnory/ng-tasty/issues{/number}","pulls_url":"https://api.github.com/repos/wahidnory/ng-tasty/pulls{/number}","milestones_url":"https://api.github.com/repos/wahidnory/ng-tasty/milestones{/number}","notifications_url":"https://api.github.com/repos/wahidnory/ng-tasty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wahidnory/ng-tasty/labels{/name}","releases_url":"https://api.github.com/repos/wahidnory/ng-tasty/releases{/id}","created_at":"2015-03-27T14:29:29Z","updated_at":"2015-03-27T15:08:45Z","pushed_at":"2015-03-27T15:08:44Z","git_url":"git://github.com/wahidnory/ng-tasty.git","ssh_url":"git@github.com:wahidnory/ng-tasty.git","clone_url":"https://github.com/wahidnory/ng-tasty.git","svn_url":"https://github.com/wahidnory/ng-tasty","homepage":"http://zizzamia.com/ng-tasty/","size":2448,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zizzamia:master","ref":"master","sha":"849ff074988358cccb6e431de41c1252ef5309da","user":{"login":"Zizzamia","id":829214,"avatar_url":"https://avatars.githubusercontent.com/u/829214?v=3","gravatar_id":"","url":"https://api.github.com/users/Zizzamia","html_url":"https://github.com/Zizzamia","followers_url":"https://api.github.com/users/Zizzamia/followers","following_url":"https://api.github.com/users/Zizzamia/following{/other_user}","gists_url":"https://api.github.com/users/Zizzamia/gists{/gist_id}","starred_url":"https://api.github.com/users/Zizzamia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zizzamia/subscriptions","organizations_url":"https://api.github.com/users/Zizzamia/orgs","repos_url":"https://api.github.com/users/Zizzamia/repos","events_url":"https://api.github.com/users/Zizzamia/events{/privacy}","received_events_url":"https://api.github.com/users/Zizzamia/received_events","type":"User","site_admin":false},"repo":{"id":22486094,"name":"ng-tasty","full_name":"Zizzamia/ng-tasty","owner":{"login":"Zizzamia","id":829214,"avatar_url":"https://avatars.githubusercontent.com/u/829214?v=3","gravatar_id":"","url":"https://api.github.com/users/Zizzamia","html_url":"https://github.com/Zizzamia","followers_url":"https://api.github.com/users/Zizzamia/followers","following_url":"https://api.github.com/users/Zizzamia/following{/other_user}","gists_url":"https://api.github.com/users/Zizzamia/gists{/gist_id}","starred_url":"https://api.github.com/users/Zizzamia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zizzamia/subscriptions","organizations_url":"https://api.github.com/users/Zizzamia/orgs","repos_url":"https://api.github.com/users/Zizzamia/repos","events_url":"https://api.github.com/users/Zizzamia/events{/privacy}","received_events_url":"https://api.github.com/users/Zizzamia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zizzamia/ng-tasty","description":"A tasty collection of reusable UI components for Angular, like grandma used to make. Like Table directive, WebSocket / Debounce / Throttle service, Range / Camelize / Slugify filters","fork":false,"url":"https://api.github.com/repos/Zizzamia/ng-tasty","forks_url":"https://api.github.com/repos/Zizzamia/ng-tasty/forks","keys_url":"https://api.github.com/repos/Zizzamia/ng-tasty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zizzamia/ng-tasty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zizzamia/ng-tasty/teams","hooks_url":"https://api.github.com/repos/Zizzamia/ng-tasty/hooks","issue_events_url":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/events{/number}","events_url":"https://api.github.com/repos/Zizzamia/ng-tasty/events","assignees_url":"https://api.github.com/repos/Zizzamia/ng-tasty/assignees{/user}","branches_url":"https://api.github.com/repos/Zizzamia/ng-tasty/branches{/branch}","tags_url":"https://api.github.com/repos/Zizzamia/ng-tasty/tags","blobs_url":"https://api.github.com/repos/Zizzamia/ng-tasty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zizzamia/ng-tasty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zizzamia/ng-tasty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zizzamia/ng-tasty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zizzamia/ng-tasty/statuses/{sha}","languages_url":"https://api.github.com/repos/Zizzamia/ng-tasty/languages","stargazers_url":"https://api.github.com/repos/Zizzamia/ng-tasty/stargazers","contributors_url":"https://api.github.com/repos/Zizzamia/ng-tasty/contributors","subscribers_url":"https://api.github.com/repos/Zizzamia/ng-tasty/subscribers","subscription_url":"https://api.github.com/repos/Zizzamia/ng-tasty/subscription","commits_url":"https://api.github.com/repos/Zizzamia/ng-tasty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zizzamia/ng-tasty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zizzamia/ng-tasty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zizzamia/ng-tasty/contents/{+path}","compare_url":"https://api.github.com/repos/Zizzamia/ng-tasty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zizzamia/ng-tasty/merges","archive_url":"https://api.github.com/repos/Zizzamia/ng-tasty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zizzamia/ng-tasty/downloads","issues_url":"https://api.github.com/repos/Zizzamia/ng-tasty/issues{/number}","pulls_url":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls{/number}","milestones_url":"https://api.github.com/repos/Zizzamia/ng-tasty/milestones{/number}","notifications_url":"https://api.github.com/repos/Zizzamia/ng-tasty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zizzamia/ng-tasty/labels{/name}","releases_url":"https://api.github.com/repos/Zizzamia/ng-tasty/releases{/id}","created_at":"2014-07-31T21:41:16Z","updated_at":"2015-03-27T00:08:39Z","pushed_at":"2015-03-27T00:08:39Z","git_url":"git://github.com/Zizzamia/ng-tasty.git","ssh_url":"git@github.com:Zizzamia/ng-tasty.git","clone_url":"https://github.com/Zizzamia/ng-tasty.git","svn_url":"https://github.com/Zizzamia/ng-tasty","homepage":"http://zizzamia.com/ng-tasty/","size":2448,"stargazers_count":237,"watchers_count":237,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":21,"forks":21,"open_issues":21,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123"},"html":{"href":"https://github.com/Zizzamia/ng-tasty/pull/123"},"issue":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/123"},"comments":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/Zizzamia/ng-tasty/statuses/1a4b52f870f53f32f4b6edd2e9711cb2ec3c4421"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":2}}