{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/39311107","id":39311107,"diff_hunk":"@@ -378,8 +378,6 @@ def deploy_certificate(self, domains, privkey_path, cert_path, chain_path):\n         # sites may have been enabled / final cleanup\n         self.installer.restart()\n \n-        display_ops.success_installation(domains)","path":"letsencrypt/client.py","position":4,"original_position":4,"commit_id":"f09016321bcc9dc54e823f633fd8f62130cae479","original_commit_id":"f09016321bcc9dc54e823f633fd8f62130cae479","user":{"login":"schoen","id":1750103,"avatar_url":"https://avatars.githubusercontent.com/u/1750103?v=3","gravatar_id":"","url":"https://api.github.com/users/schoen","html_url":"https://github.com/schoen","followers_url":"https://api.github.com/users/schoen/followers","following_url":"https://api.github.com/users/schoen/following{/other_user}","gists_url":"https://api.github.com/users/schoen/gists{/gist_id}","starred_url":"https://api.github.com/users/schoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoen/subscriptions","organizations_url":"https://api.github.com/users/schoen/orgs","repos_url":"https://api.github.com/users/schoen/repos","events_url":"https://api.github.com/users/schoen/events{/privacy}","received_events_url":"https://api.github.com/users/schoen/received_events","type":"User","site_admin":false},"body":"Great!","created_at":"2015-09-11T20:03:51Z","updated_at":"2015-09-11T20:03:51Z","html_url":"https://github.com/letsencrypt/letsencrypt/pull/758#discussion_r39311107","pull_request_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/39311107"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/758#discussion_r39311107"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758","id":44406827,"html_url":"https://github.com/letsencrypt/letsencrypt/pull/758","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/758.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/758.patch","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/758","number":758,"state":"open","locked":false,"title":"Treat duplicative certificate requests as renewals by default","user":{"login":"schoen","id":1750103,"avatar_url":"https://avatars.githubusercontent.com/u/1750103?v=3","gravatar_id":"","url":"https://api.github.com/users/schoen","html_url":"https://github.com/schoen","followers_url":"https://api.github.com/users/schoen/followers","following_url":"https://api.github.com/users/schoen/following{/other_user}","gists_url":"https://api.github.com/users/schoen/gists{/gist_id}","starred_url":"https://api.github.com/users/schoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoen/subscriptions","organizations_url":"https://api.github.com/users/schoen/orgs","repos_url":"https://api.github.com/users/schoen/repos","events_url":"https://api.github.com/users/schoen/events{/privacy}","received_events_url":"https://api.github.com/users/schoen/received_events","type":"User","site_admin":false},"body":"This worked properly in several configurations and permutations for me, and should fix #411.\r\n\r\nI have also added a version of the `--duplicate` option to override this behavior. Following a previous discussion, this has to be specified manually because we concluded that most users are very unlikely to actually want duplicate certificates.\r\n\r\nCoverage went down and this PR currently fails coverage on Travis by about 1%. There are no existing tests for the portions of `client.py` and `cli.py` that the PR modifies so I don't have anything to build on.","created_at":"2015-09-08T08:52:29Z","updated_at":"2015-09-11T20:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5e5e10d745ef6977248e42bc8f26e8ce53e810b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/758/comments","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/f09016321bcc9dc54e823f633fd8f62130cae479","head":{"label":"letsencrypt:treat_duplicate_as_renewal","ref":"treat_duplicate_as_renewal","sha":"f09016321bcc9dc54e823f633fd8f62130cae479","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"An ACME client that can update Apache/Nginx configurations","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-09-11T19:05:54Z","pushed_at":"2015-09-11T07:46:21Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":9683,"stargazers_count":3221,"watchers_count":3221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":160,"forks":234,"open_issues":160,"watchers":3221,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"eb2173ca1272b8aedb3a027d97f99db8592fc113","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"An ACME client that can update Apache/Nginx configurations","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-09-11T19:05:54Z","pushed_at":"2015-09-11T07:46:21Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":9683,"stargazers_count":3221,"watchers_count":3221,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":160,"forks":234,"open_issues":160,"watchers":3221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/758"},"issue":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/758"},"comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/758/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/758/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/f09016321bcc9dc54e823f633fd8f62130cae479"}}}}