{"action":"created","issue":{"url":"https://api.github.com/repos/thephpleague/commonmark/issues/205","labels_url":"https://api.github.com/repos/thephpleague/commonmark/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/thephpleague/commonmark/issues/205/comments","events_url":"https://api.github.com/repos/thephpleague/commonmark/issues/205/events","html_url":"https://github.com/thephpleague/commonmark/pull/205","id":117095793,"number":205,"title":"Fixed SmilieParser example","user":{"login":"ikkentim","id":2820647,"avatar_url":"https://avatars.githubusercontent.com/u/2820647?v=3","gravatar_id":"","url":"https://api.github.com/users/ikkentim","html_url":"https://github.com/ikkentim","followers_url":"https://api.github.com/users/ikkentim/followers","following_url":"https://api.github.com/users/ikkentim/following{/other_user}","gists_url":"https://api.github.com/users/ikkentim/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkentim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkentim/subscriptions","organizations_url":"https://api.github.com/users/ikkentim/orgs","repos_url":"https://api.github.com/users/ikkentim/repos","events_url":"https://api.github.com/users/ikkentim/events{/privacy}","received_events_url":"https://api.github.com/users/ikkentim/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-16T10:43:04Z","updated_at":"2015-11-16T15:01:06Z","closed_at":"2015-11-16T14:32:53Z","pull_request":{"url":"https://api.github.com/repos/thephpleague/commonmark/pulls/205","html_url":"https://github.com/thephpleague/commonmark/pull/205","diff_url":"https://github.com/thephpleague/commonmark/pull/205.diff","patch_url":"https://github.com/thephpleague/commonmark/pull/205.patch"},"body":"This or should be an and in order for the parser to work correctly."},"comment":{"url":"https://api.github.com/repos/thephpleague/commonmark/issues/comments/157059842","html_url":"https://github.com/thephpleague/commonmark/pull/205#issuecomment-157059842","issue_url":"https://api.github.com/repos/thephpleague/commonmark/issues/205","id":157059842,"user":{"login":"ikkentim","id":2820647,"avatar_url":"https://avatars.githubusercontent.com/u/2820647?v=3","gravatar_id":"","url":"https://api.github.com/users/ikkentim","html_url":"https://github.com/ikkentim","followers_url":"https://api.github.com/users/ikkentim/followers","following_url":"https://api.github.com/users/ikkentim/following{/other_user}","gists_url":"https://api.github.com/users/ikkentim/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkentim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkentim/subscriptions","organizations_url":"https://api.github.com/users/ikkentim/orgs","repos_url":"https://api.github.com/users/ikkentim/repos","events_url":"https://api.github.com/users/ikkentim/events{/privacy}","received_events_url":"https://api.github.com/users/ikkentim/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T15:01:06Z","updated_at":"2015-11-16T15:01:06Z","body":"Sorry, but @GrahamCampbell and @colinodell are both mistaken.\r\n\r\nI didn't expect to have to explain this obvious issue.\r\n\r\n```\r\n-        if ($nextChar !== '(' || $nextChar !== ')') {\r\n+        if ($nextChar !== '(' && $nextChar !== ')') {\r\n```\r\n\r\nIf we're looking whether the next character is NOT ( and NOT ) then my PR is correct.\r\n\r\nIf we're using the old code ( with the `||` ). The next would happen:\r\n\r\nLets say we're processing `:(`. The next character is `(`. The if statement would basically be like `if( true || false )` which is true, meaning the code will return `false` and not use the parser. \r\n\r\nLets say we're processing `:)`. The next character is `)`. The if statement would basically be like `if( false || true )` which is true, meaning the code will return false and not use the parser. \r\n\r\nBasically, `parse` will always return `false`, which is wrong."}}