{"action":"created","issue":{"url":"https://api.github.com/repos/agnwinds/python/issues/145","labels_url":"https://api.github.com/repos/agnwinds/python/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/agnwinds/python/issues/145/comments","events_url":"https://api.github.com/repos/agnwinds/python/issues/145/events","html_url":"https://github.com/agnwinds/python/pull/145","id":71341489,"number":145,"title":"Reverb Code Merge","user":{"login":"smangham","id":8093436,"avatar_url":"https://avatars.githubusercontent.com/u/8093436?v=3","gravatar_id":"","url":"https://api.github.com/users/smangham","html_url":"https://github.com/smangham","followers_url":"https://api.github.com/users/smangham/followers","following_url":"https://api.github.com/users/smangham/following{/other_user}","gists_url":"https://api.github.com/users/smangham/gists{/gist_id}","starred_url":"https://api.github.com/users/smangham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smangham/subscriptions","organizations_url":"https://api.github.com/users/smangham/orgs","repos_url":"https://api.github.com/users/smangham/repos","events_url":"https://api.github.com/users/smangham/events{/privacy}","received_events_url":"https://api.github.com/users/smangham/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/agnwinds/python/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-27T16:51:47Z","updated_at":"2015-04-28T11:09:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/agnwinds/python/pulls/145","html_url":"https://github.com/agnwinds/python/pull/145","diff_url":"https://github.com/agnwinds/python/pull/145.diff","patch_url":"https://github.com/agnwinds/python/pull/145.patch"},"body":"Code for reverberation mapping. The post processing code used to build transfer function maps from the .delay_dump files is at:\r\nhttps://github.com/smangham/bindata\r\n\r\nThe following option(s) are added to input files after \"Use.standard.care.factors(1=yes)\":\r\nreverb.type(0=no,1=phot,2=wind)\t\t\t2\r\nreverb.path_bins\t\t\t\t\t\t30 - If type 2, sets number of path bins discretised \r\nreverb.theta_bins\t\t\t\t\t\t30 - If type 2, used for output of .vtk file"},"comment":{"url":"https://api.github.com/repos/agnwinds/python/issues/comments/97021723","html_url":"https://github.com/agnwinds/python/pull/145#issuecomment-97021723","issue_url":"https://api.github.com/repos/agnwinds/python/issues/145","id":97021723,"user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T11:09:03Z","updated_at":"2015-04-28T11:09:03Z","body":"I guess the way to think about it is if something isn't worth logging to the diagfile then it's not worth having in the proper version of the code - so any messages to user use either Log or Error. See e.g. Knox's writing here: https://github.com/agnwinds/python/wiki/Avoid-printf - it's not something which particularly bothers me but it's very easy to end up clogging the on screen printing. \r\n\r\nVR- I'd suggest the functions aren't tracked in this merge then. Separate branch for VR work?\r\n\r\nRE declaration format- happy to change this if needs be but in a separate commit to clean up this diff. Need to check others are OK and should probably discuss indent format while we're at it. \r\n\r\n"}}