{"action":"created","issue":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/877","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/877/labels{/name}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/877/comments","events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/877/events","html_url":"https://github.com/freedomofpress/securedrop/issues/877","id":57496777,"number":877,"title":"Restart submission counter after deleting submissions","user":{"login":"runasand","id":85289,"avatar_url":"https://avatars.githubusercontent.com/u/85289?v=3","gravatar_id":"","url":"https://api.github.com/users/runasand","html_url":"https://github.com/runasand","followers_url":"https://api.github.com/users/runasand/followers","following_url":"https://api.github.com/users/runasand/following{/other_user}","gists_url":"https://api.github.com/users/runasand/gists{/gist_id}","starred_url":"https://api.github.com/users/runasand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runasand/subscriptions","organizations_url":"https://api.github.com/users/runasand/orgs","repos_url":"https://api.github.com/users/runasand/repos","events_url":"https://api.github.com/users/runasand/events{/privacy}","received_events_url":"https://api.github.com/users/runasand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-12T18:06:04Z","updated_at":"2015-02-27T19:41:42Z","closed_at":null,"body":"The first time the source \"positive toast\" sends a message, the submission is given the filename \"1-positive_toast-msg.gpg\" in the Document Interface. The second time the source sends a message, the submission is given the filename \"2-positive_toast-msg.gpg,\" the third time \"3-positive_toast-msg.gpg,\" and so on. \r\n\r\nIf a journalist decided to delete the three submissions, but keep the source in the system, the Document Interface would simply say that there are no documents to display. If \"positive toast\" sent a new message at this point, the submission would be given the name \"4-positive_toast-msg.gpg.\"\r\n\r\nThe filename makes it clear that \"positive toast\" and the journalist have communicated before. I realize the number is a way to help journalists keep track of the submissions when using the Secure Viewing Station, but it seems a bit unfortunate that it also leaks whether a source has communicated with a journalist - and how much. \r\n\r\nI think it would be fine to keep it this way as long as the submissions exist in the system, but perhaps restart the counter when submissions are deleted? That could cause some issues with submissions being overwritten on the Transfer Device or Secure Viewing Station, however. "},"comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments/76458370","html_url":"https://github.com/freedomofpress/securedrop/issues/877#issuecomment-76458370","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/877","id":76458370,"user":{"login":"garrettr","id":407302,"avatar_url":"https://avatars.githubusercontent.com/u/407302?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettr","html_url":"https://github.com/garrettr","followers_url":"https://api.github.com/users/garrettr/followers","following_url":"https://api.github.com/users/garrettr/following{/other_user}","gists_url":"https://api.github.com/users/garrettr/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettr/subscriptions","organizations_url":"https://api.github.com/users/garrettr/orgs","repos_url":"https://api.github.com/users/garrettr/repos","events_url":"https://api.github.com/users/garrettr/events{/privacy}","received_events_url":"https://api.github.com/users/garrettr/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T19:41:42Z","updated_at":"2015-02-27T19:41:42Z","body":"> That could cause some issues with submissions being overwritten on the Transfer Device or Secure Viewing Station, however.\r\n\r\n@runasand Yeah, that's exactly why we always increment the \"interaction count\". People often keep downloaded submissions in cold storage and delete them from the server, and resetting the counter would cause new submissions' names to overlap with those of old submissions, which could lead to confusion/accidental overwriting of important files."}}