{"action":"created","issue":{"url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/18","labels_url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/18/comments","events_url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/18/events","html_url":"https://github.com/CyberCraftInc/vacation_system/pull/18","id":108661449,"number":18,"title":"Add ApprovalRequestsController#accept action method","user":{"login":"eleidan","id":540832,"avatar_url":"https://avatars.githubusercontent.com/u/540832?v=3","gravatar_id":"","url":"https://api.github.com/users/eleidan","html_url":"https://github.com/eleidan","followers_url":"https://api.github.com/users/eleidan/followers","following_url":"https://api.github.com/users/eleidan/following{/other_user}","gists_url":"https://api.github.com/users/eleidan/gists{/gist_id}","starred_url":"https://api.github.com/users/eleidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleidan/subscriptions","organizations_url":"https://api.github.com/users/eleidan/orgs","repos_url":"https://api.github.com/users/eleidan/repos","events_url":"https://api.github.com/users/eleidan/events{/privacy}","received_events_url":"https://api.github.com/users/eleidan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-28T13:47:29Z","updated_at":"2015-09-29T09:40:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CyberCraftInc/vacation_system/pulls/18","html_url":"https://github.com/CyberCraftInc/vacation_system/pull/18","diff_url":"https://github.com/CyberCraftInc/vacation_system/pull/18.diff","patch_url":"https://github.com/CyberCraftInc/vacation_system/pull/18.patch"},"body":"Update RoR router\r\nThe following action methods are members of :approval_requests\r\nresources:\r\n  - accept,\r\n  - decline.\r\n\r\nUpdate :vacation_request factory\r\nAdd :with_approval_requests trait that creates approval requests\r\nassigned to team managers.\r\n\r\nAdd tests for ApprovalRequestsController\r\nThe following action methods are tested:\r\n  - accept,\r\n  - decline.\r\n\r\nAdd authorization policy for ApprovalRequest\r\n\r\nAdd custom error ConflictError\r\nThis error is used to implement handy handling of conflicts in\r\nVacationRequest model state.\r\n\r\nUpdate User model\r\nThe model provides #manager_of_user?(user) method to verify if the user\r\nis a manager for another user.\r\n\r\nFix custom validation in VacationRequest model\r\nIt was not possible to save existing model because of false positive\r\nvalidation issue.\r\nNow cannot_intersect_with_other_vacations() considers the fact that it\r\nmay be used for an existing record and checks the ID of the record.\r\n\r\n@alazarchuk , @epmlys , @rubycop, @afurm "},"comment":{"url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/comments/144007230","html_url":"https://github.com/CyberCraftInc/vacation_system/pull/18#issuecomment-144007230","issue_url":"https://api.github.com/repos/CyberCraftInc/vacation_system/issues/18","id":144007230,"user":{"login":"afurm","id":6375192,"avatar_url":"https://avatars.githubusercontent.com/u/6375192?v=3","gravatar_id":"","url":"https://api.github.com/users/afurm","html_url":"https://github.com/afurm","followers_url":"https://api.github.com/users/afurm/followers","following_url":"https://api.github.com/users/afurm/following{/other_user}","gists_url":"https://api.github.com/users/afurm/gists{/gist_id}","starred_url":"https://api.github.com/users/afurm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afurm/subscriptions","organizations_url":"https://api.github.com/users/afurm/orgs","repos_url":"https://api.github.com/users/afurm/repos","events_url":"https://api.github.com/users/afurm/events{/privacy}","received_events_url":"https://api.github.com/users/afurm/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T09:40:22Z","updated_at":"2015-09-29T09:40:22Z","body":"LGTM"}}