{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/onyx-platform/onyx/pulls/244","id":39751074,"html_url":"https://github.com/onyx-platform/onyx/pull/244","diff_url":"https://github.com/onyx-platform/onyx/pull/244.diff","patch_url":"https://github.com/onyx-platform/onyx/pull/244.patch","issue_url":"https://api.github.com/repos/onyx-platform/onyx/issues/244","number":244,"state":"closed","locked":false,"title":"Aeron share subscription","user":{"login":"lbradstreet","id":252189,"avatar_url":"https://avatars.githubusercontent.com/u/252189?v=3","gravatar_id":"","url":"https://api.github.com/users/lbradstreet","html_url":"https://github.com/lbradstreet","followers_url":"https://api.github.com/users/lbradstreet/followers","following_url":"https://api.github.com/users/lbradstreet/following{/other_user}","gists_url":"https://api.github.com/users/lbradstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbradstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbradstreet/subscriptions","organizations_url":"https://api.github.com/users/lbradstreet/orgs","repos_url":"https://api.github.com/users/lbradstreet/repos","events_url":"https://api.github.com/users/lbradstreet/events{/privacy}","received_events_url":"https://api.github.com/users/lbradstreet/received_events","type":"User","site_admin":false},"body":"This PR allows all virtual peers to multiplex over a single subscription, which will scale as the number of peers/vpeers increases. It also allows Aeron messaging to short circuit \r\n\r\nThe main problem that I can see with it that the subscriber thread is currently responsible for all the deserialization for all the vpeers using the same peer group. For serialization heavy operations this thread could end up being overwhelmed.\r\n\r\nWe will likely have to push the buffers onto our channels and serialize them outside of the subscriber thread. By the way, I think our netty implementation may also have this issue.\r\n\r\nAlso worth noting, impl detail wise: every message sent via aeron now includes a short which maps between the id and a virtual peer. This is necessary because we now share a subscription, and we need to know which vpeer to send the message on to. By using the short -> vpeer mapping scheme, we save 14 bytes in every message. This is allocated in the same way that ports were before. Also worth noting: aeron only needs one port per peer group now (since we multiplex).","created_at":"2015-07-11T19:35:20Z","updated_at":"2015-07-18T02:02:58Z","closed_at":"2015-07-18T02:02:58Z","merged_at":"2015-07-18T02:02:58Z","merge_commit_sha":"a882463c288f82c8511fc95e014ae4336d229587","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/244/commits","review_comments_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/244/comments","review_comment_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/issues/244/comments","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/744e2a55d223bf87927dd672bd7914009370c5e1","head":{"label":"onyx-platform:messaging/aeron-share-publication","ref":"messaging/aeron-share-publication","sha":"744e2a55d223bf87927dd672bd7914009370c5e1","user":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":14849761,"name":"onyx","full_name":"onyx-platform/onyx","owner":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onyx-platform/onyx","description":"Distributed, masterless, high performance, fault tolerant data processing for Clojure","fork":false,"url":"https://api.github.com/repos/onyx-platform/onyx","forks_url":"https://api.github.com/repos/onyx-platform/onyx/forks","keys_url":"https://api.github.com/repos/onyx-platform/onyx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onyx-platform/onyx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onyx-platform/onyx/teams","hooks_url":"https://api.github.com/repos/onyx-platform/onyx/hooks","issue_events_url":"https://api.github.com/repos/onyx-platform/onyx/issues/events{/number}","events_url":"https://api.github.com/repos/onyx-platform/onyx/events","assignees_url":"https://api.github.com/repos/onyx-platform/onyx/assignees{/user}","branches_url":"https://api.github.com/repos/onyx-platform/onyx/branches{/branch}","tags_url":"https://api.github.com/repos/onyx-platform/onyx/tags","blobs_url":"https://api.github.com/repos/onyx-platform/onyx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onyx-platform/onyx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onyx-platform/onyx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onyx-platform/onyx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/{sha}","languages_url":"https://api.github.com/repos/onyx-platform/onyx/languages","stargazers_url":"https://api.github.com/repos/onyx-platform/onyx/stargazers","contributors_url":"https://api.github.com/repos/onyx-platform/onyx/contributors","subscribers_url":"https://api.github.com/repos/onyx-platform/onyx/subscribers","subscription_url":"https://api.github.com/repos/onyx-platform/onyx/subscription","commits_url":"https://api.github.com/repos/onyx-platform/onyx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onyx-platform/onyx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onyx-platform/onyx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onyx-platform/onyx/contents/{+path}","compare_url":"https://api.github.com/repos/onyx-platform/onyx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onyx-platform/onyx/merges","archive_url":"https://api.github.com/repos/onyx-platform/onyx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onyx-platform/onyx/downloads","issues_url":"https://api.github.com/repos/onyx-platform/onyx/issues{/number}","pulls_url":"https://api.github.com/repos/onyx-platform/onyx/pulls{/number}","milestones_url":"https://api.github.com/repos/onyx-platform/onyx/milestones{/number}","notifications_url":"https://api.github.com/repos/onyx-platform/onyx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onyx-platform/onyx/labels{/name}","releases_url":"https://api.github.com/repos/onyx-platform/onyx/releases{/id}","created_at":"2013-12-02T01:21:14Z","updated_at":"2015-07-17T16:10:57Z","pushed_at":"2015-07-18T02:02:58Z","git_url":"git://github.com/onyx-platform/onyx.git","ssh_url":"git@github.com:onyx-platform/onyx.git","clone_url":"https://github.com/onyx-platform/onyx.git","svn_url":"https://github.com/onyx-platform/onyx","homepage":"","size":9845,"stargazers_count":794,"watchers_count":794,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":28,"forks":61,"open_issues":28,"watchers":794,"default_branch":"master"}},"base":{"label":"onyx-platform:develop","ref":"develop","sha":"d50de7a896608cf5f8ba6a0001e24521a67a6e9e","user":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":14849761,"name":"onyx","full_name":"onyx-platform/onyx","owner":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onyx-platform/onyx","description":"Distributed, masterless, high performance, fault tolerant data processing for Clojure","fork":false,"url":"https://api.github.com/repos/onyx-platform/onyx","forks_url":"https://api.github.com/repos/onyx-platform/onyx/forks","keys_url":"https://api.github.com/repos/onyx-platform/onyx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onyx-platform/onyx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onyx-platform/onyx/teams","hooks_url":"https://api.github.com/repos/onyx-platform/onyx/hooks","issue_events_url":"https://api.github.com/repos/onyx-platform/onyx/issues/events{/number}","events_url":"https://api.github.com/repos/onyx-platform/onyx/events","assignees_url":"https://api.github.com/repos/onyx-platform/onyx/assignees{/user}","branches_url":"https://api.github.com/repos/onyx-platform/onyx/branches{/branch}","tags_url":"https://api.github.com/repos/onyx-platform/onyx/tags","blobs_url":"https://api.github.com/repos/onyx-platform/onyx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onyx-platform/onyx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onyx-platform/onyx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onyx-platform/onyx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/{sha}","languages_url":"https://api.github.com/repos/onyx-platform/onyx/languages","stargazers_url":"https://api.github.com/repos/onyx-platform/onyx/stargazers","contributors_url":"https://api.github.com/repos/onyx-platform/onyx/contributors","subscribers_url":"https://api.github.com/repos/onyx-platform/onyx/subscribers","subscription_url":"https://api.github.com/repos/onyx-platform/onyx/subscription","commits_url":"https://api.github.com/repos/onyx-platform/onyx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onyx-platform/onyx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onyx-platform/onyx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onyx-platform/onyx/contents/{+path}","compare_url":"https://api.github.com/repos/onyx-platform/onyx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onyx-platform/onyx/merges","archive_url":"https://api.github.com/repos/onyx-platform/onyx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onyx-platform/onyx/downloads","issues_url":"https://api.github.com/repos/onyx-platform/onyx/issues{/number}","pulls_url":"https://api.github.com/repos/onyx-platform/onyx/pulls{/number}","milestones_url":"https://api.github.com/repos/onyx-platform/onyx/milestones{/number}","notifications_url":"https://api.github.com/repos/onyx-platform/onyx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onyx-platform/onyx/labels{/name}","releases_url":"https://api.github.com/repos/onyx-platform/onyx/releases{/id}","created_at":"2013-12-02T01:21:14Z","updated_at":"2015-07-17T16:10:57Z","pushed_at":"2015-07-18T02:02:58Z","git_url":"git://github.com/onyx-platform/onyx.git","ssh_url":"git@github.com:onyx-platform/onyx.git","clone_url":"https://github.com/onyx-platform/onyx.git","svn_url":"https://github.com/onyx-platform/onyx","homepage":"","size":9845,"stargazers_count":794,"watchers_count":794,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":28,"forks":61,"open_issues":28,"watchers":794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/244"},"html":{"href":"https://github.com/onyx-platform/onyx/pull/244"},"issue":{"href":"https://api.github.com/repos/onyx-platform/onyx/issues/244"},"comments":{"href":"https://api.github.com/repos/onyx-platform/onyx/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/onyx-platform/onyx/statuses/744e2a55d223bf87927dd672bd7914009370c5e1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MichaelDrogalis","id":918857,"avatar_url":"https://avatars.githubusercontent.com/u/918857?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelDrogalis","html_url":"https://github.com/MichaelDrogalis","followers_url":"https://api.github.com/users/MichaelDrogalis/followers","following_url":"https://api.github.com/users/MichaelDrogalis/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDrogalis/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDrogalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDrogalis/subscriptions","organizations_url":"https://api.github.com/users/MichaelDrogalis/orgs","repos_url":"https://api.github.com/users/MichaelDrogalis/repos","events_url":"https://api.github.com/users/MichaelDrogalis/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDrogalis/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":29,"additions":615,"deletions":341,"changed_files":17}}