{"action":"created","comment":{"url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/comments/45563805","id":45563805,"diff_hunk":"@@ -88,6 +89,11 @@ Object.defineProperties(MediaSession.prototype, {\n             }\n             return [];\n         }\n+    },\n+    channels: {\n+        get: function () {\n+            return this.pc._remoteDataChannels.concat(this.pc._localDataChannels);","path":"index.js","position":15,"original_position":15,"commit_id":"5c2db366971b8d476297416418c7f06a865277a4","original_commit_id":"5c2db366971b8d476297416418c7f06a865277a4","user":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"body":"Sounds good to me. I'll update.\nOn Sun, Nov 22, 2015 at 1:13 PM Philipp Hancke <notifications@github.com>\nwrote:\n\n> In index.js\n> <https://github.com/otalk/jingle-media-session/pull/15#discussion_r45562188>\n> :\n>\n> > @@ -88,6 +89,11 @@ Object.defineProperties(MediaSession.prototype, {\n> >              }\n> >              return [];\n> >          }\n> > +    },\n> > +    channels: {\n> > +        get: function () {\n> > +            return this.pc._remoteDataChannels.concat(this.pc._localDataChannels);\n>\n> oddly, there is no equivalent to getLocalStreams/getRemoteStreams.\n> Managing the datachannel lifecycle is app reponsibility. I don't think the\n> media session is the right place even though I agree we should be emitting\n> channelAdded to enable the application (or any modules on top of this) to\n> handle this.\n>\n> tl;dr: can we just do onAddChannel? ;-)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/otalk/jingle-media-session/pull/15/files#r45562188>.\n>\n","created_at":"2015-11-22T20:16:35Z","updated_at":"2015-11-22T20:16:35Z","html_url":"https://github.com/otalk/jingle-media-session/pull/15#discussion_r45563805","pull_request_url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/comments/45563805"},"html":{"href":"https://github.com/otalk/jingle-media-session/pull/15#discussion_r45563805"},"pull_request":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15","id":51466992,"html_url":"https://github.com/otalk/jingle-media-session/pull/15","diff_url":"https://github.com/otalk/jingle-media-session/pull/15.diff","patch_url":"https://github.com/otalk/jingle-media-session/pull/15.patch","issue_url":"https://api.github.com/repos/otalk/jingle-media-session/issues/15","number":15,"state":"open","locked":false,"title":"Add support for channel events ","user":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"body":"by proxying add channel and channel message to the session. @legastero @fippo?\r\n\r\nI'm guessing you do something in talky with `session.pc._remoteDataChannels`? That's how I was picking up the channel and events for last-n, and figured this made more sense.","created_at":"2015-11-22T15:23:28Z","updated_at":"2015-11-22T20:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c09b5fd0a21ab85706946c9eec65cf1b3deb06cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15/commits","review_comments_url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15/comments","review_comment_url":"https://api.github.com/repos/otalk/jingle-media-session/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otalk/jingle-media-session/issues/15/comments","statuses_url":"https://api.github.com/repos/otalk/jingle-media-session/statuses/5c2db366971b8d476297416418c7f06a865277a4","head":{"label":"xdumaine:remote-datachannels","ref":"remote-datachannels","sha":"5c2db366971b8d476297416418c7f06a865277a4","user":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"repo":{"id":33681776,"name":"jingle-media-session","full_name":"xdumaine/jingle-media-session","owner":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xdumaine/jingle-media-session","description":"Jingle Media Session","fork":true,"url":"https://api.github.com/repos/xdumaine/jingle-media-session","forks_url":"https://api.github.com/repos/xdumaine/jingle-media-session/forks","keys_url":"https://api.github.com/repos/xdumaine/jingle-media-session/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xdumaine/jingle-media-session/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xdumaine/jingle-media-session/teams","hooks_url":"https://api.github.com/repos/xdumaine/jingle-media-session/hooks","issue_events_url":"https://api.github.com/repos/xdumaine/jingle-media-session/issues/events{/number}","events_url":"https://api.github.com/repos/xdumaine/jingle-media-session/events","assignees_url":"https://api.github.com/repos/xdumaine/jingle-media-session/assignees{/user}","branches_url":"https://api.github.com/repos/xdumaine/jingle-media-session/branches{/branch}","tags_url":"https://api.github.com/repos/xdumaine/jingle-media-session/tags","blobs_url":"https://api.github.com/repos/xdumaine/jingle-media-session/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xdumaine/jingle-media-session/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xdumaine/jingle-media-session/git/refs{/sha}","trees_url":"https://api.github.com/repos/xdumaine/jingle-media-session/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xdumaine/jingle-media-session/statuses/{sha}","languages_url":"https://api.github.com/repos/xdumaine/jingle-media-session/languages","stargazers_url":"https://api.github.com/repos/xdumaine/jingle-media-session/stargazers","contributors_url":"https://api.github.com/repos/xdumaine/jingle-media-session/contributors","subscribers_url":"https://api.github.com/repos/xdumaine/jingle-media-session/subscribers","subscription_url":"https://api.github.com/repos/xdumaine/jingle-media-session/subscription","commits_url":"https://api.github.com/repos/xdumaine/jingle-media-session/commits{/sha}","git_commits_url":"https://api.github.com/repos/xdumaine/jingle-media-session/git/commits{/sha}","comments_url":"https://api.github.com/repos/xdumaine/jingle-media-session/comments{/number}","issue_comment_url":"https://api.github.com/repos/xdumaine/jingle-media-session/issues/comments{/number}","contents_url":"https://api.github.com/repos/xdumaine/jingle-media-session/contents/{+path}","compare_url":"https://api.github.com/repos/xdumaine/jingle-media-session/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xdumaine/jingle-media-session/merges","archive_url":"https://api.github.com/repos/xdumaine/jingle-media-session/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xdumaine/jingle-media-session/downloads","issues_url":"https://api.github.com/repos/xdumaine/jingle-media-session/issues{/number}","pulls_url":"https://api.github.com/repos/xdumaine/jingle-media-session/pulls{/number}","milestones_url":"https://api.github.com/repos/xdumaine/jingle-media-session/milestones{/number}","notifications_url":"https://api.github.com/repos/xdumaine/jingle-media-session/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xdumaine/jingle-media-session/labels{/name}","releases_url":"https://api.github.com/repos/xdumaine/jingle-media-session/releases{/id}","created_at":"2015-04-09T17:06:49Z","updated_at":"2015-04-09T17:19:23Z","pushed_at":"2015-11-22T17:16:41Z","git_url":"git://github.com/xdumaine/jingle-media-session.git","ssh_url":"git@github.com:xdumaine/jingle-media-session.git","clone_url":"https://github.com/xdumaine/jingle-media-session.git","svn_url":"https://github.com/xdumaine/jingle-media-session","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"otalk:master","ref":"master","sha":"29c92f5b918c13d6fa833e613ed1b2ecf3cbdb55","user":{"login":"otalk","id":7915062,"avatar_url":"https://avatars.githubusercontent.com/u/7915062?v=3","gravatar_id":"","url":"https://api.github.com/users/otalk","html_url":"https://github.com/otalk","followers_url":"https://api.github.com/users/otalk/followers","following_url":"https://api.github.com/users/otalk/following{/other_user}","gists_url":"https://api.github.com/users/otalk/gists{/gist_id}","starred_url":"https://api.github.com/users/otalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otalk/subscriptions","organizations_url":"https://api.github.com/users/otalk/orgs","repos_url":"https://api.github.com/users/otalk/repos","events_url":"https://api.github.com/users/otalk/events{/privacy}","received_events_url":"https://api.github.com/users/otalk/received_events","type":"Organization","site_admin":false},"repo":{"id":24069623,"name":"jingle-media-session","full_name":"otalk/jingle-media-session","owner":{"login":"otalk","id":7915062,"avatar_url":"https://avatars.githubusercontent.com/u/7915062?v=3","gravatar_id":"","url":"https://api.github.com/users/otalk","html_url":"https://github.com/otalk","followers_url":"https://api.github.com/users/otalk/followers","following_url":"https://api.github.com/users/otalk/following{/other_user}","gists_url":"https://api.github.com/users/otalk/gists{/gist_id}","starred_url":"https://api.github.com/users/otalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otalk/subscriptions","organizations_url":"https://api.github.com/users/otalk/orgs","repos_url":"https://api.github.com/users/otalk/repos","events_url":"https://api.github.com/users/otalk/events{/privacy}","received_events_url":"https://api.github.com/users/otalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otalk/jingle-media-session","description":"Jingle Media Session","fork":false,"url":"https://api.github.com/repos/otalk/jingle-media-session","forks_url":"https://api.github.com/repos/otalk/jingle-media-session/forks","keys_url":"https://api.github.com/repos/otalk/jingle-media-session/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otalk/jingle-media-session/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otalk/jingle-media-session/teams","hooks_url":"https://api.github.com/repos/otalk/jingle-media-session/hooks","issue_events_url":"https://api.github.com/repos/otalk/jingle-media-session/issues/events{/number}","events_url":"https://api.github.com/repos/otalk/jingle-media-session/events","assignees_url":"https://api.github.com/repos/otalk/jingle-media-session/assignees{/user}","branches_url":"https://api.github.com/repos/otalk/jingle-media-session/branches{/branch}","tags_url":"https://api.github.com/repos/otalk/jingle-media-session/tags","blobs_url":"https://api.github.com/repos/otalk/jingle-media-session/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otalk/jingle-media-session/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otalk/jingle-media-session/git/refs{/sha}","trees_url":"https://api.github.com/repos/otalk/jingle-media-session/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otalk/jingle-media-session/statuses/{sha}","languages_url":"https://api.github.com/repos/otalk/jingle-media-session/languages","stargazers_url":"https://api.github.com/repos/otalk/jingle-media-session/stargazers","contributors_url":"https://api.github.com/repos/otalk/jingle-media-session/contributors","subscribers_url":"https://api.github.com/repos/otalk/jingle-media-session/subscribers","subscription_url":"https://api.github.com/repos/otalk/jingle-media-session/subscription","commits_url":"https://api.github.com/repos/otalk/jingle-media-session/commits{/sha}","git_commits_url":"https://api.github.com/repos/otalk/jingle-media-session/git/commits{/sha}","comments_url":"https://api.github.com/repos/otalk/jingle-media-session/comments{/number}","issue_comment_url":"https://api.github.com/repos/otalk/jingle-media-session/issues/comments{/number}","contents_url":"https://api.github.com/repos/otalk/jingle-media-session/contents/{+path}","compare_url":"https://api.github.com/repos/otalk/jingle-media-session/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otalk/jingle-media-session/merges","archive_url":"https://api.github.com/repos/otalk/jingle-media-session/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otalk/jingle-media-session/downloads","issues_url":"https://api.github.com/repos/otalk/jingle-media-session/issues{/number}","pulls_url":"https://api.github.com/repos/otalk/jingle-media-session/pulls{/number}","milestones_url":"https://api.github.com/repos/otalk/jingle-media-session/milestones{/number}","notifications_url":"https://api.github.com/repos/otalk/jingle-media-session/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otalk/jingle-media-session/labels{/name}","releases_url":"https://api.github.com/repos/otalk/jingle-media-session/releases{/id}","created_at":"2014-09-15T19:06:28Z","updated_at":"2015-11-19T18:49:07Z","pushed_at":"2015-11-22T17:16:41Z","git_url":"git://github.com/otalk/jingle-media-session.git","ssh_url":"git@github.com:otalk/jingle-media-session.git","clone_url":"https://github.com/otalk/jingle-media-session.git","svn_url":"https://github.com/otalk/jingle-media-session","homepage":null,"size":22,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15"},"html":{"href":"https://github.com/otalk/jingle-media-session/pull/15"},"issue":{"href":"https://api.github.com/repos/otalk/jingle-media-session/issues/15"},"comments":{"href":"https://api.github.com/repos/otalk/jingle-media-session/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otalk/jingle-media-session/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/otalk/jingle-media-session/statuses/5c2db366971b8d476297416418c7f06a865277a4"}}}}