{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/236","labels_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/236/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/236/comments","events_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/236/events","html_url":"https://github.com/aspnet/DependencyInjection/pull/236","id":75968392,"number":236,"title":"Bugfix for non-generic GetRequiredServices","user":{"login":"henkmollema","id":1521207,"avatar_url":"https://avatars.githubusercontent.com/u/1521207?v=3","gravatar_id":"","url":"https://api.github.com/users/henkmollema","html_url":"https://github.com/henkmollema","followers_url":"https://api.github.com/users/henkmollema/followers","following_url":"https://api.github.com/users/henkmollema/following{/other_user}","gists_url":"https://api.github.com/users/henkmollema/gists{/gist_id}","starred_url":"https://api.github.com/users/henkmollema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henkmollema/subscriptions","organizations_url":"https://api.github.com/users/henkmollema/orgs","repos_url":"https://api.github.com/users/henkmollema/repos","events_url":"https://api.github.com/users/henkmollema/events{/privacy}","received_events_url":"https://api.github.com/users/henkmollema/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aspnet/DependencyInjection/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-05-13T12:29:17Z","updated_at":"2015-05-15T08:24:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/pulls/236","html_url":"https://github.com/aspnet/DependencyInjection/pull/236","diff_url":"https://github.com/aspnet/DependencyInjection/pull/236.diff","patch_url":"https://github.com/aspnet/DependencyInjection/pull/236.patch"},"body":"The non-generic GetRequiredServices wasn't actually checking if the service exists. Solved this by moving the code from the generic method to the non-generic method and changing the  generic method to use the non-generic one.\r\n\r\nThis made the `NonGeneric_GetRequiredServices_ReturnsAllServices()` test redundant."},"comment":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/comments/102315087","html_url":"https://github.com/aspnet/DependencyInjection/pull/236#issuecomment-102315087","issue_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/236","id":102315087,"user":{"login":"henkmollema","id":1521207,"avatar_url":"https://avatars.githubusercontent.com/u/1521207?v=3","gravatar_id":"","url":"https://api.github.com/users/henkmollema","html_url":"https://github.com/henkmollema","followers_url":"https://api.github.com/users/henkmollema/followers","following_url":"https://api.github.com/users/henkmollema/following{/other_user}","gists_url":"https://api.github.com/users/henkmollema/gists{/gist_id}","starred_url":"https://api.github.com/users/henkmollema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henkmollema/subscriptions","organizations_url":"https://api.github.com/users/henkmollema/orgs","repos_url":"https://api.github.com/users/henkmollema/repos","events_url":"https://api.github.com/users/henkmollema/events{/privacy}","received_events_url":"https://api.github.com/users/henkmollema/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T08:24:11Z","updated_at":"2015-05-15T08:24:11Z","body":"@Tragetaschen nice catch, thanks!"}}