{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36145331","id":36145331,"diff_hunk":"@@ -343,13 +350,24 @@ func createEndpointsLW(kubeClient *kclient.Client) *kcache.ListWatch {\n \treturn kcache.NewListWatchFromClient(kubeClient, \"endpoints\", kapi.NamespaceAll, kSelector.Everything())\n }\n \n+func (ks *kube2sky) addServiceRecords(records *recordTree, svc *kapi.Service) {","path":"cluster/addons/dns/kube2sky/kube2sky.go","position":null,"original_position":141,"commit_id":"34adcd25c77200796fc9b26da3d7dce09a8f92e1","original_commit_id":"4481836043c7cb1da89ad715c3cdf4a55b017c42","user":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"body":"Inlined.","created_at":"2015-08-04T00:00:07Z","updated_at":"2015-08-04T00:00:07Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404#discussion_r36145331","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36145331"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404#discussion_r36145331"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404","id":40181721,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11404","number":11404,"state":"open","locked":false,"title":"Incrementally update DNS records instead of remove and recreate.","user":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"body":"@thockin ","created_at":"2015-07-16T22:09:12Z","updated_at":"2015-08-04T00:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a98b8207f0ce24f16ce77992167f49b029738318","assignee":{"login":"ArtfulCoder","id":1220660,"avatar_url":"https://avatars.githubusercontent.com/u/1220660?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtfulCoder","html_url":"https://github.com/ArtfulCoder","followers_url":"https://api.github.com/users/ArtfulCoder/followers","following_url":"https://api.github.com/users/ArtfulCoder/following{/other_user}","gists_url":"https://api.github.com/users/ArtfulCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtfulCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtfulCoder/subscriptions","organizations_url":"https://api.github.com/users/ArtfulCoder/orgs","repos_url":"https://api.github.com/users/ArtfulCoder/repos","events_url":"https://api.github.com/users/ArtfulCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ArtfulCoder/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11404/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/34adcd25c77200796fc9b26da3d7dce09a8f92e1","head":{"label":"uluyol:dnsdiff","ref":"dnsdiff","sha":"34adcd25c77200796fc9b26da3d7dce09a8f92e1","user":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"repo":{"id":36756702,"name":"kubernetes","full_name":"uluyol/kubernetes","owner":{"login":"uluyol","id":4128872,"avatar_url":"https://avatars.githubusercontent.com/u/4128872?v=3","gravatar_id":"","url":"https://api.github.com/users/uluyol","html_url":"https://github.com/uluyol","followers_url":"https://api.github.com/users/uluyol/followers","following_url":"https://api.github.com/users/uluyol/following{/other_user}","gists_url":"https://api.github.com/users/uluyol/gists{/gist_id}","starred_url":"https://api.github.com/users/uluyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uluyol/subscriptions","organizations_url":"https://api.github.com/users/uluyol/orgs","repos_url":"https://api.github.com/users/uluyol/repos","events_url":"https://api.github.com/users/uluyol/events{/privacy}","received_events_url":"https://api.github.com/users/uluyol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uluyol/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/uluyol/kubernetes","forks_url":"https://api.github.com/repos/uluyol/kubernetes/forks","keys_url":"https://api.github.com/repos/uluyol/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uluyol/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uluyol/kubernetes/teams","hooks_url":"https://api.github.com/repos/uluyol/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/uluyol/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/uluyol/kubernetes/events","assignees_url":"https://api.github.com/repos/uluyol/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/uluyol/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/uluyol/kubernetes/tags","blobs_url":"https://api.github.com/repos/uluyol/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uluyol/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uluyol/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/uluyol/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uluyol/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/uluyol/kubernetes/languages","stargazers_url":"https://api.github.com/repos/uluyol/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/uluyol/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/uluyol/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/uluyol/kubernetes/subscription","commits_url":"https://api.github.com/repos/uluyol/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/uluyol/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/uluyol/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/uluyol/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/uluyol/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/uluyol/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uluyol/kubernetes/merges","archive_url":"https://api.github.com/repos/uluyol/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uluyol/kubernetes/downloads","issues_url":"https://api.github.com/repos/uluyol/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/uluyol/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/uluyol/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/uluyol/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uluyol/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/uluyol/kubernetes/releases{/id}","created_at":"2015-06-02T19:30:19Z","updated_at":"2015-06-02T19:30:24Z","pushed_at":"2015-08-03T23:59:41Z","git_url":"git://github.com/uluyol/kubernetes.git","ssh_url":"git@github.com:uluyol/kubernetes.git","clone_url":"https://github.com/uluyol/kubernetes.git","svn_url":"https://github.com/uluyol/kubernetes","homepage":"http://kubernetes.io","size":95535,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6d16c18d6fcef7b66507ac4383262335eb04423a","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-03T20:50:59Z","pushed_at":"2015-08-03T23:59:43Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":337915,"stargazers_count":9508,"watchers_count":9508,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2227,"mirror_url":null,"open_issues_count":1689,"forks":2227,"open_issues":1689,"watchers":9508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11404"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11404"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11404/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11404/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/34adcd25c77200796fc9b26da3d7dce09a8f92e1"}}}}