{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/13970","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/13970/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/13970/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/13970/events","html_url":"https://github.com/JuliaLang/julia/pull/13970","id":116738367,"number":13970,"title":"Fix MSVC build of threading code","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JuliaLang/julia/labels/multi-threading","name":"multi-threading","color":"fbca04"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/windows","name":"windows","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-13T10:08:47Z","updated_at":"2015-11-13T19:05:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/13970","html_url":"https://github.com/JuliaLang/julia/pull/13970","diff_url":"https://github.com/JuliaLang/julia/pull/13970.diff","patch_url":"https://github.com/JuliaLang/julia/pull/13970.patch"},"body":"Not sure if this code actually works on Windows (LLVM 3.7.0 crashes at the start of bootstrap with a `Relocation type not implemented yet!\r\nUNREACHABLE executed at /home/Tony/julia/deps/srccache/llvm-3.7.0/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:230!`), but at least we can check whether it builds. Some of the `!defined(_OS_WINDOWS_)` in here should maybe actually be `!defined(_COMPILER_MICROSOFT_)`, but we can sort that out when newer LLVM and the threading code are closer to being enabled by default."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/156527489","html_url":"https://github.com/JuliaLang/julia/pull/13970#issuecomment-156527489","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/13970","id":156527489,"user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T19:05:58Z","updated_at":"2015-11-13T19:05:58Z","body":"I should say I was using unpatched LLVM 3.7.0 here because I have a copy of that built, I have not tried with the tls branch yet. You have said elsewhere that it does not include a windows implementation of the relevant llvm features though?"}}