{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/28641668","id":28641668,"diff_hunk":"@@ -0,0 +1,23 @@\n+local helpers = require(\"test.unit.helpers\")\n+local cimport = helpers.cimport\n+local env = cimport('./src/nvim/os/os.h')\n+local eq = helpers.eq\n+local neq = helpers.neq\n+\n+describe('Dont use $VIM/$VIMRUNTIME', function()\n+\n+  env.os_unsetenv('NVIM')\n+  env.os_unsetenv('NVIMRUNTIME')\n+  env.os_setenv('VIM', 'VIM_VALUE', 1)\n+  env.os_setenv('VIMRUNTIME', 'VIMRUNTIME_VALUE', 1)\n+\n+  helpers.vim_init()","path":"test/unit/env_nvim2_spec.lua","position":14,"original_position":14,"commit_id":"06fb7b9ac414b6b769cfd49858cc5d9cf829872b","original_commit_id":"06fb7b9ac414b6b769cfd49858cc5d9cf829872b","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"Is this why the tests need to be separate? Or can they be combined to 1 env_nvim_spec.lua file? I am also wondering why there are nested `describe()` blocks with no `it()` specs. Suggestion:\r\n\r\n```lua\r\nlocal helpers = require(\"test.unit.helpers\")\r\nlocal cimport = helpers.cimport\r\nlocal env = cimport('./src/nvim/os/os.h')\r\nlocal eq = helpers.eq\r\nlocal neq = helpers.neq\r\n\r\ndescribe('$NVIM/$NVIMRUNTIME', function()\r\n  before_each(function()\r\n    env.os_unsetenv('NVIM')\r\n    env.os_unsetenv('NVIMRUNTIME')\r\n    env.os_unsetenv('VIM')\r\n    env.os_unsetenv('VIMRUNTIME')\r\n\r\n    helpers.vim_init()\r\n  end)\r\n\r\n  it('$VIM is cleared if $NVIM is unset', function()\r\n    env.os_setenv('VIM', 'VIM_VALUE', 1)\r\n    neq(os.getenv('VIM'), 'VIM_VALUE')\r\n  end)\r\n  it('$VIMRUNTIME is cleared if $NVIMRUNTIME is unset', function()\r\n    env.os_setenv('VIMRUNTIME', 'VIMRUNTIME_VALUE', 1)\r\n    neq(os.getenv('VIMRUNTIME'), 'VIMRUNTIME_VALUE')\r\n  end)\r\n\r\n  it('$VIM is set to $NVIM', function()\r\n    env.os_setenv('NVIM', 'NVIM_VALUE', 1)\r\n    eq(os.getenv('VIM'), os.getenv('NVIM'))\r\n  end)\r\n  it('$VIMRUNTIME is set to $NVIMRUNTIME', function()\r\n    env.os_setenv('NVIMRUNTIME', 'NVIMRUNTIME_VALUE', 1)\r\n    eq(os.getenv('VIMRUNTIME'), os.getenv('NVIMRUNTIME'))\r\n  end)\r\nend)\r\n\r\n\r\n```","created_at":"2015-04-18T05:42:46Z","updated_at":"2015-04-18T05:42:46Z","html_url":"https://github.com/neovim/neovim/pull/1927#discussion_r28641668","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/1927","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/28641668"},"html":{"href":"https://github.com/neovim/neovim/pull/1927#discussion_r28641668"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1927"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1927","id":28440000,"html_url":"https://github.com/neovim/neovim/pull/1927","diff_url":"https://github.com/neovim/neovim/pull/1927.diff","patch_url":"https://github.com/neovim/neovim/pull/1927.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1927","number":1927,"state":"open","locked":false,"title":"[RFC] Replace $VIMRUNTIME with $NVIMRUNTIME","user":{"login":"equalsraf","id":715238,"avatar_url":"https://avatars.githubusercontent.com/u/715238?v=3","gravatar_id":"","url":"https://api.github.com/users/equalsraf","html_url":"https://github.com/equalsraf","followers_url":"https://api.github.com/users/equalsraf/followers","following_url":"https://api.github.com/users/equalsraf/following{/other_user}","gists_url":"https://api.github.com/users/equalsraf/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsraf/subscriptions","organizations_url":"https://api.github.com/users/equalsraf/orgs","repos_url":"https://api.github.com/users/equalsraf/repos","events_url":"https://api.github.com/users/equalsraf/events{/privacy}","received_events_url":"https://api.github.com/users/equalsraf/received_events","type":"User","site_admin":false},"body":"- For compatibility plugins still need $VIMRUNTIME, but getting or\r\n  settings VIMRUNTIME will use NVIMRUNTIME instead.\r\n\r\nFor #1924.","created_at":"2015-02-02T00:29:24Z","updated_at":"2015-04-18T05:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afe642302769c7295ac6ec1da339fc66ddb2c76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1927/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1927/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1927/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/06fb7b9ac414b6b769cfd49858cc5d9cf829872b","head":{"label":"equalsraf:tb-vimruntime","ref":"tb-vimruntime","sha":"06fb7b9ac414b6b769cfd49858cc5d9cf829872b","user":{"login":"equalsraf","id":715238,"avatar_url":"https://avatars.githubusercontent.com/u/715238?v=3","gravatar_id":"","url":"https://api.github.com/users/equalsraf","html_url":"https://github.com/equalsraf","followers_url":"https://api.github.com/users/equalsraf/followers","following_url":"https://api.github.com/users/equalsraf/following{/other_user}","gists_url":"https://api.github.com/users/equalsraf/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsraf/subscriptions","organizations_url":"https://api.github.com/users/equalsraf/orgs","repos_url":"https://api.github.com/users/equalsraf/repos","events_url":"https://api.github.com/users/equalsraf/events{/privacy}","received_events_url":"https://api.github.com/users/equalsraf/received_events","type":"User","site_admin":false},"repo":{"id":17216430,"name":"neovim","full_name":"equalsraf/neovim","owner":{"login":"equalsraf","id":715238,"avatar_url":"https://avatars.githubusercontent.com/u/715238?v=3","gravatar_id":"","url":"https://api.github.com/users/equalsraf","html_url":"https://github.com/equalsraf","followers_url":"https://api.github.com/users/equalsraf/followers","following_url":"https://api.github.com/users/equalsraf/following{/other_user}","gists_url":"https://api.github.com/users/equalsraf/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsraf/subscriptions","organizations_url":"https://api.github.com/users/equalsraf/orgs","repos_url":"https://api.github.com/users/equalsraf/repos","events_url":"https://api.github.com/users/equalsraf/events{/privacy}","received_events_url":"https://api.github.com/users/equalsraf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/equalsraf/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/equalsraf/neovim","forks_url":"https://api.github.com/repos/equalsraf/neovim/forks","keys_url":"https://api.github.com/repos/equalsraf/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/equalsraf/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/equalsraf/neovim/teams","hooks_url":"https://api.github.com/repos/equalsraf/neovim/hooks","issue_events_url":"https://api.github.com/repos/equalsraf/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/equalsraf/neovim/events","assignees_url":"https://api.github.com/repos/equalsraf/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/equalsraf/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/equalsraf/neovim/tags","blobs_url":"https://api.github.com/repos/equalsraf/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/equalsraf/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/equalsraf/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/equalsraf/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/equalsraf/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/equalsraf/neovim/languages","stargazers_url":"https://api.github.com/repos/equalsraf/neovim/stargazers","contributors_url":"https://api.github.com/repos/equalsraf/neovim/contributors","subscribers_url":"https://api.github.com/repos/equalsraf/neovim/subscribers","subscription_url":"https://api.github.com/repos/equalsraf/neovim/subscription","commits_url":"https://api.github.com/repos/equalsraf/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/equalsraf/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/equalsraf/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/equalsraf/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/equalsraf/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/equalsraf/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/equalsraf/neovim/merges","archive_url":"https://api.github.com/repos/equalsraf/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/equalsraf/neovim/downloads","issues_url":"https://api.github.com/repos/equalsraf/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/equalsraf/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/equalsraf/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/equalsraf/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/equalsraf/neovim/labels{/name}","releases_url":"https://api.github.com/repos/equalsraf/neovim/releases{/id}","created_at":"2014-02-26T16:10:08Z","updated_at":"2015-02-11T09:46:28Z","pushed_at":"2015-04-17T23:24:21Z","git_url":"git://github.com/equalsraf/neovim.git","ssh_url":"git@github.com:equalsraf/neovim.git","clone_url":"https://github.com/equalsraf/neovim.git","svn_url":"https://github.com/equalsraf/neovim","homepage":"http://neovim.org/","size":31780,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"c1a3d289d69b93092247e0eca3bf4b43992791a1","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-04-18T04:51:47Z","pushed_at":"2015-04-18T04:59:36Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org","size":63351,"stargazers_count":12939,"watchers_count":12939,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":877,"mirror_url":null,"open_issues_count":442,"forks":877,"open_issues":442,"watchers":12939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1927"},"html":{"href":"https://github.com/neovim/neovim/pull/1927"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1927"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1927/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1927/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1927/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/06fb7b9ac414b6b769cfd49858cc5d9cf829872b"}}}}