{"action":"created","issue":{"url":"https://api.github.com/repos/amitaibu/og/issues/4","labels_url":"https://api.github.com/repos/amitaibu/og/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/amitaibu/og/issues/4/comments","events_url":"https://api.github.com/repos/amitaibu/og/issues/4/events","html_url":"https://github.com/amitaibu/og/pull/4","id":106152604,"number":4,"title":"Replace audience field definition with an OG FieldStorageConfig decorator to set custom storage","user":{"login":"damiankloip","id":1053891,"avatar_url":"https://avatars.githubusercontent.com/u/1053891?v=3","gravatar_id":"","url":"https://api.github.com/users/damiankloip","html_url":"https://github.com/damiankloip","followers_url":"https://api.github.com/users/damiankloip/followers","following_url":"https://api.github.com/users/damiankloip/following{/other_user}","gists_url":"https://api.github.com/users/damiankloip/gists{/gist_id}","starred_url":"https://api.github.com/users/damiankloip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiankloip/subscriptions","organizations_url":"https://api.github.com/users/damiankloip/orgs","repos_url":"https://api.github.com/users/damiankloip/repos","events_url":"https://api.github.com/users/damiankloip/events{/privacy}","received_events_url":"https://api.github.com/users/damiankloip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-09-12T12:28:31Z","updated_at":"2015-09-15T18:14:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/amitaibu/og/pulls/4","html_url":"https://github.com/amitaibu/og/pull/4","diff_url":"https://github.com/amitaibu/og/pull/4.diff","patch_url":"https://github.com/amitaibu/og/pull/4.patch"},"body":"I currently can't see a better way (or any way actually) to do this whilst still using a configurable field. With base field definitions you can easily just set `setCustomStorage(TRUE)` and be done. That is not as easy for configurable fields, as core's `FieldStorageConfig` definition (config entity) hard codes custom storage to `FALSE`.\r\n\r\nExtending the core `FieldStorageConfig` class is also not really an option, as all the inherited methods will not proxy but look for properties on the decorated class. Trying to get all the properties from the object also seems pretty painful. This decorator class is not ideal, as there are a lot of methods that need to be implemented, just to pass the call on to the decorated object.\r\n\r\nThe other option here is to take care of field config ourselves, and create our own base field definitions. That seems slightly crazy though, as fields can store everything already.\r\n\r\nAnother potential option is to replace the field instance with a base field instance. Not replacing the OG_AUDIENCE_FIELD itself (removing that) but creating another base_og_group_ref or something. Also, not ideal."},"comment":{"url":"https://api.github.com/repos/amitaibu/og/issues/comments/140487642","html_url":"https://github.com/amitaibu/og/pull/4#issuecomment-140487642","issue_url":"https://api.github.com/repos/amitaibu/og/issues/4","id":140487642,"user":{"login":"yched","id":193080,"avatar_url":"https://avatars.githubusercontent.com/u/193080?v=3","gravatar_id":"","url":"https://api.github.com/users/yched","html_url":"https://github.com/yched","followers_url":"https://api.github.com/users/yched/followers","following_url":"https://api.github.com/users/yched/following{/other_user}","gists_url":"https://api.github.com/users/yched/gists{/gist_id}","starred_url":"https://api.github.com/users/yched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yched/subscriptions","organizations_url":"https://api.github.com/users/yched/orgs","repos_url":"https://api.github.com/users/yched/repos","events_url":"https://api.github.com/users/yched/events{/privacy}","received_events_url":"https://api.github.com/users/yched/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T18:14:01Z","updated_at":"2015-09-15T18:14:01Z","body":"Thanks for the details - I definitely think we should try to find some time with plach and fago in Barcelona :-)"}}