{"action":"created","comment":{"url":"https://api.github.com/repos/elaforge/fast-tags/pulls/comments/22702614","id":22702614,"diff_hunk":"@@ -78,6 +85,15 @@ data Type =\n   | Pattern\n   deriving (Eq, Ord, Show)\n \n+instance NFData Type where\n+  rnf Function    = ()\n+  rnf Type        = ()\n+  rnf Constructor = ()\n+  rnf Class       = ()\n+  rnf Module      = ()\n+  rnf Operator    = ()\n+  rnf Pattern     = ()","path":"src/FastTags.hs","position":36,"original_position":36,"commit_id":"96d849538ab8adbbea6f6883c5a2498a97e7bd6c","original_commit_id":"96d849538ab8adbbea6f6883c5a2498a97e7bd6c","user":{"login":"elaforge","id":1077360,"avatar_url":"https://avatars.githubusercontent.com/u/1077360?v=3","gravatar_id":"","url":"https://api.github.com/users/elaforge","html_url":"https://github.com/elaforge","followers_url":"https://api.github.com/users/elaforge/followers","following_url":"https://api.github.com/users/elaforge/following{/other_user}","gists_url":"https://api.github.com/users/elaforge/gists{/gist_id}","starred_url":"https://api.github.com/users/elaforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaforge/subscriptions","organizations_url":"https://api.github.com/users/elaforge/orgs","repos_url":"https://api.github.com/users/elaforge/repos","events_url":"https://api.github.com/users/elaforge/events{/privacy}","received_events_url":"https://api.github.com/users/elaforge/received_events","type":"User","site_admin":false},"body":"I think 'rnf t = t `seq` ()' should do.","created_at":"2015-01-09T05:59:00Z","updated_at":"2015-01-09T05:59:00Z","html_url":"https://github.com/elaforge/fast-tags/pull/7#discussion_r22702614","pull_request_url":"https://api.github.com/repos/elaforge/fast-tags/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/comments/22702614"},"html":{"href":"https://github.com/elaforge/fast-tags/pull/7#discussion_r22702614"},"pull_request":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/elaforge/fast-tags/pulls/7","id":27045782,"html_url":"https://github.com/elaforge/fast-tags/pull/7","diff_url":"https://github.com/elaforge/fast-tags/pull/7.diff","patch_url":"https://github.com/elaforge/fast-tags/pull/7.patch","issue_url":"https://api.github.com/repos/elaforge/fast-tags/issues/7","number":7,"state":"open","locked":false,"title":"Handling of @-patterns, sorting fix, collect tags of .hsc files","user":{"login":"sergv","id":1149355,"avatar_url":"https://avatars.githubusercontent.com/u/1149355?v=3","gravatar_id":"","url":"https://api.github.com/users/sergv","html_url":"https://github.com/sergv","followers_url":"https://api.github.com/users/sergv/followers","following_url":"https://api.github.com/users/sergv/following{/other_user}","gists_url":"https://api.github.com/users/sergv/gists{/gist_id}","starred_url":"https://api.github.com/users/sergv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergv/subscriptions","organizations_url":"https://api.github.com/users/sergv/orgs","repos_url":"https://api.github.com/users/sergv/repos","events_url":"https://api.github.com/users/sergv/events{/privacy}","received_events_url":"https://api.github.com/users/sergv/received_events","type":"User","site_admin":false},"body":"Hi, this is followup to https://github.com/elaforge/fast-tags/pull/6. It includes fixing of sorting so that two `AttributeMap` tags, constructor and type name, will be detected in the following code snippet\r\n\r\n```Haskell\r\nnewtype AttributeMap =\r\n    AttributeMap [(Score.Attributes, [Keyswitch], Maybe Keymap)]\r\n    deriving (Eq, Show, Pretty.Pretty, DeepSeq.NFData)\r\n```\r\n\r\nThe handling of at patterns was also fixed, now they're not confused for operators.\r\n\r\nI also added instances of `NFData` for tags since they're convenient for benchmarks and clients of the fast-tags library (of which there's only me but nonetheless), do not impose external dependencies as `deepseq` package is part of the platform and should not result in any overhead or executable size increase as they're not used by the actual fast-tags binary.\r\n\r\nI also added .hsc files to candidates for tag collection since they're basically haskell files with some preprocessor-like extensions which are stripped away by fast-tags. Which means that .hsc files can be reliably handled by the fast-tags tool.\r\n\r\nAnd the last change is fix of check for missing input files, which I messed up when merging my changes into the master.","created_at":"2015-01-08T17:44:11Z","updated_at":"2015-01-09T05:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8ecd73410526da5e0e6b21682bfd78faa277738","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elaforge/fast-tags/pulls/7/commits","review_comments_url":"https://api.github.com/repos/elaforge/fast-tags/pulls/7/comments","review_comment_url":"https://api.github.com/repos/elaforge/fast-tags/pulls/comments/{number}","comments_url":"https://api.github.com/repos/elaforge/fast-tags/issues/7/comments","statuses_url":"https://api.github.com/repos/elaforge/fast-tags/statuses/96d849538ab8adbbea6f6883c5a2498a97e7bd6c","head":{"label":"sergv:master","ref":"master","sha":"96d849538ab8adbbea6f6883c5a2498a97e7bd6c","user":{"login":"sergv","id":1149355,"avatar_url":"https://avatars.githubusercontent.com/u/1149355?v=3","gravatar_id":"","url":"https://api.github.com/users/sergv","html_url":"https://github.com/sergv","followers_url":"https://api.github.com/users/sergv/followers","following_url":"https://api.github.com/users/sergv/following{/other_user}","gists_url":"https://api.github.com/users/sergv/gists{/gist_id}","starred_url":"https://api.github.com/users/sergv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergv/subscriptions","organizations_url":"https://api.github.com/users/sergv/orgs","repos_url":"https://api.github.com/users/sergv/repos","events_url":"https://api.github.com/users/sergv/events{/privacy}","received_events_url":"https://api.github.com/users/sergv/received_events","type":"User","site_admin":false},"repo":{"id":14788074,"name":"fast-tags","full_name":"sergv/fast-tags","owner":{"login":"sergv","id":1149355,"avatar_url":"https://avatars.githubusercontent.com/u/1149355?v=3","gravatar_id":"","url":"https://api.github.com/users/sergv","html_url":"https://github.com/sergv","followers_url":"https://api.github.com/users/sergv/followers","following_url":"https://api.github.com/users/sergv/following{/other_user}","gists_url":"https://api.github.com/users/sergv/gists{/gist_id}","starred_url":"https://api.github.com/users/sergv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergv/subscriptions","organizations_url":"https://api.github.com/users/sergv/orgs","repos_url":"https://api.github.com/users/sergv/repos","events_url":"https://api.github.com/users/sergv/events{/privacy}","received_events_url":"https://api.github.com/users/sergv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergv/fast-tags","description":"Fork of elaforge/fast-tags that adds Emacs support","fork":true,"url":"https://api.github.com/repos/sergv/fast-tags","forks_url":"https://api.github.com/repos/sergv/fast-tags/forks","keys_url":"https://api.github.com/repos/sergv/fast-tags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergv/fast-tags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergv/fast-tags/teams","hooks_url":"https://api.github.com/repos/sergv/fast-tags/hooks","issue_events_url":"https://api.github.com/repos/sergv/fast-tags/issues/events{/number}","events_url":"https://api.github.com/repos/sergv/fast-tags/events","assignees_url":"https://api.github.com/repos/sergv/fast-tags/assignees{/user}","branches_url":"https://api.github.com/repos/sergv/fast-tags/branches{/branch}","tags_url":"https://api.github.com/repos/sergv/fast-tags/tags","blobs_url":"https://api.github.com/repos/sergv/fast-tags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergv/fast-tags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergv/fast-tags/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergv/fast-tags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergv/fast-tags/statuses/{sha}","languages_url":"https://api.github.com/repos/sergv/fast-tags/languages","stargazers_url":"https://api.github.com/repos/sergv/fast-tags/stargazers","contributors_url":"https://api.github.com/repos/sergv/fast-tags/contributors","subscribers_url":"https://api.github.com/repos/sergv/fast-tags/subscribers","subscription_url":"https://api.github.com/repos/sergv/fast-tags/subscription","commits_url":"https://api.github.com/repos/sergv/fast-tags/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergv/fast-tags/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergv/fast-tags/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergv/fast-tags/issues/comments/{number}","contents_url":"https://api.github.com/repos/sergv/fast-tags/contents/{+path}","compare_url":"https://api.github.com/repos/sergv/fast-tags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergv/fast-tags/merges","archive_url":"https://api.github.com/repos/sergv/fast-tags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergv/fast-tags/downloads","issues_url":"https://api.github.com/repos/sergv/fast-tags/issues{/number}","pulls_url":"https://api.github.com/repos/sergv/fast-tags/pulls{/number}","milestones_url":"https://api.github.com/repos/sergv/fast-tags/milestones{/number}","notifications_url":"https://api.github.com/repos/sergv/fast-tags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergv/fast-tags/labels{/name}","releases_url":"https://api.github.com/repos/sergv/fast-tags/releases{/id}","created_at":"2013-11-28T22:44:27Z","updated_at":"2015-01-08T20:10:18Z","pushed_at":"2015-01-08T20:10:17Z","git_url":"git://github.com/sergv/fast-tags.git","ssh_url":"git@github.com:sergv/fast-tags.git","clone_url":"https://github.com/sergv/fast-tags.git","svn_url":"https://github.com/sergv/fast-tags","homepage":"http://hackage.haskell.org/package/fast-tags","size":493,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elaforge:master","ref":"master","sha":"114a48feb845eeca2ba497dfde5b65c7203189d5","user":{"login":"elaforge","id":1077360,"avatar_url":"https://avatars.githubusercontent.com/u/1077360?v=3","gravatar_id":"","url":"https://api.github.com/users/elaforge","html_url":"https://github.com/elaforge","followers_url":"https://api.github.com/users/elaforge/followers","following_url":"https://api.github.com/users/elaforge/following{/other_user}","gists_url":"https://api.github.com/users/elaforge/gists{/gist_id}","starred_url":"https://api.github.com/users/elaforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaforge/subscriptions","organizations_url":"https://api.github.com/users/elaforge/orgs","repos_url":"https://api.github.com/users/elaforge/repos","events_url":"https://api.github.com/users/elaforge/events{/privacy}","received_events_url":"https://api.github.com/users/elaforge/received_events","type":"User","site_admin":false},"repo":{"id":3914795,"name":"fast-tags","full_name":"elaforge/fast-tags","owner":{"login":"elaforge","id":1077360,"avatar_url":"https://avatars.githubusercontent.com/u/1077360?v=3","gravatar_id":"","url":"https://api.github.com/users/elaforge","html_url":"https://github.com/elaforge","followers_url":"https://api.github.com/users/elaforge/followers","following_url":"https://api.github.com/users/elaforge/following{/other_user}","gists_url":"https://api.github.com/users/elaforge/gists{/gist_id}","starred_url":"https://api.github.com/users/elaforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaforge/subscriptions","organizations_url":"https://api.github.com/users/elaforge/orgs","repos_url":"https://api.github.com/users/elaforge/repos","events_url":"https://api.github.com/users/elaforge/events{/privacy}","received_events_url":"https://api.github.com/users/elaforge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elaforge/fast-tags","description":"Incremental vi tags for haskell.","fork":false,"url":"https://api.github.com/repos/elaforge/fast-tags","forks_url":"https://api.github.com/repos/elaforge/fast-tags/forks","keys_url":"https://api.github.com/repos/elaforge/fast-tags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elaforge/fast-tags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elaforge/fast-tags/teams","hooks_url":"https://api.github.com/repos/elaforge/fast-tags/hooks","issue_events_url":"https://api.github.com/repos/elaforge/fast-tags/issues/events{/number}","events_url":"https://api.github.com/repos/elaforge/fast-tags/events","assignees_url":"https://api.github.com/repos/elaforge/fast-tags/assignees{/user}","branches_url":"https://api.github.com/repos/elaforge/fast-tags/branches{/branch}","tags_url":"https://api.github.com/repos/elaforge/fast-tags/tags","blobs_url":"https://api.github.com/repos/elaforge/fast-tags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elaforge/fast-tags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elaforge/fast-tags/git/refs{/sha}","trees_url":"https://api.github.com/repos/elaforge/fast-tags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elaforge/fast-tags/statuses/{sha}","languages_url":"https://api.github.com/repos/elaforge/fast-tags/languages","stargazers_url":"https://api.github.com/repos/elaforge/fast-tags/stargazers","contributors_url":"https://api.github.com/repos/elaforge/fast-tags/contributors","subscribers_url":"https://api.github.com/repos/elaforge/fast-tags/subscribers","subscription_url":"https://api.github.com/repos/elaforge/fast-tags/subscription","commits_url":"https://api.github.com/repos/elaforge/fast-tags/commits{/sha}","git_commits_url":"https://api.github.com/repos/elaforge/fast-tags/git/commits{/sha}","comments_url":"https://api.github.com/repos/elaforge/fast-tags/comments{/number}","issue_comment_url":"https://api.github.com/repos/elaforge/fast-tags/issues/comments/{number}","contents_url":"https://api.github.com/repos/elaforge/fast-tags/contents/{+path}","compare_url":"https://api.github.com/repos/elaforge/fast-tags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elaforge/fast-tags/merges","archive_url":"https://api.github.com/repos/elaforge/fast-tags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elaforge/fast-tags/downloads","issues_url":"https://api.github.com/repos/elaforge/fast-tags/issues{/number}","pulls_url":"https://api.github.com/repos/elaforge/fast-tags/pulls{/number}","milestones_url":"https://api.github.com/repos/elaforge/fast-tags/milestones{/number}","notifications_url":"https://api.github.com/repos/elaforge/fast-tags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elaforge/fast-tags/labels{/name}","releases_url":"https://api.github.com/repos/elaforge/fast-tags/releases{/id}","created_at":"2012-04-03T04:51:51Z","updated_at":"2015-01-08T21:42:02Z","pushed_at":"2015-01-08T05:47:40Z","git_url":"git://github.com/elaforge/fast-tags.git","ssh_url":"git@github.com:elaforge/fast-tags.git","clone_url":"https://github.com/elaforge/fast-tags.git","svn_url":"https://github.com/elaforge/fast-tags","homepage":"http://hackage.haskell.org/package/fast-tags","size":216,"stargazers_count":5,"watchers_count":5,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/7"},"html":{"href":"https://github.com/elaforge/fast-tags/pull/7"},"issue":{"href":"https://api.github.com/repos/elaforge/fast-tags/issues/7"},"comments":{"href":"https://api.github.com/repos/elaforge/fast-tags/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/elaforge/fast-tags/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/elaforge/fast-tags/statuses/96d849538ab8adbbea6f6883c5a2498a97e7bd6c"}}}}