{"action":"created","comment":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/23776686","id":23776686,"diff_hunk":"@@ -17,6 +17,9 @@ function ArchiveTest($id, $store_result = true, $delete = false) {\n     if ( strpos($id, '.') === false &&                           // make sure it isn't a relay test\r\n         (array_key_exists('archive_dir', $settings) ||           // local mount\r\n         array_key_exists('archive_s3_server', $settings)) ) {    // S3 Interface (Internet Archive or standard)\r\n+        if ($settings['archive_dir'] == 'none') { // don't archive anything\r","path":"www/archive.inc","position":4,"original_position":4,"commit_id":"61a5d79d1b57f53656922af1ae2c9ab6aa613963","original_commit_id":"61a5d79d1b57f53656922af1ae2c9ab6aa613963","user":{"login":"pmeenan","id":444165,"avatar_url":"https://avatars.githubusercontent.com/u/444165?v=3","gravatar_id":"","url":"https://api.github.com/users/pmeenan","html_url":"https://github.com/pmeenan","followers_url":"https://api.github.com/users/pmeenan/followers","following_url":"https://api.github.com/users/pmeenan/following{/other_user}","gists_url":"https://api.github.com/users/pmeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/pmeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmeenan/subscriptions","organizations_url":"https://api.github.com/users/pmeenan/orgs","repos_url":"https://api.github.com/users/pmeenan/repos","events_url":"https://api.github.com/users/pmeenan/events{/privacy}","received_events_url":"https://api.github.com/users/pmeenan/received_events","type":"User","site_admin":false},"body":"Can you make this a case-insensitive comparison just to be safe (and potentially also allow for /dev/null)?\r\n\r\nSomething like:\r\n```\r\nif (strcasecmp($settings['archive_dir'], 'none') === false || strcasecmp($settings['archive_dir'], '/dev/null') === false) {\r\n```","created_at":"2015-01-29T15:49:36Z","updated_at":"2015-01-29T15:49:36Z","html_url":"https://github.com/WPO-Foundation/webpagetest/pull/392#discussion_r23776686","pull_request_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392","_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/23776686"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/392#discussion_r23776686"},"pull_request":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392","id":28251127,"html_url":"https://github.com/WPO-Foundation/webpagetest/pull/392","diff_url":"https://github.com/WPO-Foundation/webpagetest/pull/392.diff","patch_url":"https://github.com/WPO-Foundation/webpagetest/pull/392.patch","issue_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/392","number":392,"state":"open","locked":false,"title":"allow clearing out disk space without archiving","user":{"login":"ovesh","id":567433,"avatar_url":"https://avatars.githubusercontent.com/u/567433?v=3","gravatar_id":"","url":"https://api.github.com/users/ovesh","html_url":"https://github.com/ovesh","followers_url":"https://api.github.com/users/ovesh/followers","following_url":"https://api.github.com/users/ovesh/following{/other_user}","gists_url":"https://api.github.com/users/ovesh/gists{/gist_id}","starred_url":"https://api.github.com/users/ovesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovesh/subscriptions","organizations_url":"https://api.github.com/users/ovesh/orgs","repos_url":"https://api.github.com/users/ovesh/repos","events_url":"https://api.github.com/users/ovesh/events{/privacy}","received_events_url":"https://api.github.com/users/ovesh/received_events","type":"User","site_admin":false},"body":"Specifying archive_dir='none' in settings.ini will now skip archiving\r\nin www/cli/archive.php\r\n\r\nSee discussion in http://www.webpagetest.org/forums/showthread.php?tid=13516&pid=25469","created_at":"2015-01-29T03:24:28Z","updated_at":"2015-01-29T15:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47ef3b17d2f9f1b07a0e8fd49355b6279aef417b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392/commits","review_comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392/comments","review_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/392/comments","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/61a5d79d1b57f53656922af1ae2c9ab6aa613963","head":{"label":"indeedeng:master","ref":"master","sha":"61a5d79d1b57f53656922af1ae2c9ab6aa613963","user":{"login":"indeedeng","id":2905043,"avatar_url":"https://avatars.githubusercontent.com/u/2905043?v=3","gravatar_id":"","url":"https://api.github.com/users/indeedeng","html_url":"https://github.com/indeedeng","followers_url":"https://api.github.com/users/indeedeng/followers","following_url":"https://api.github.com/users/indeedeng/following{/other_user}","gists_url":"https://api.github.com/users/indeedeng/gists{/gist_id}","starred_url":"https://api.github.com/users/indeedeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indeedeng/subscriptions","organizations_url":"https://api.github.com/users/indeedeng/orgs","repos_url":"https://api.github.com/users/indeedeng/repos","events_url":"https://api.github.com/users/indeedeng/events{/privacy}","received_events_url":"https://api.github.com/users/indeedeng/received_events","type":"Organization","site_admin":false},"repo":{"id":29999270,"name":"webpagetest","full_name":"indeedeng/webpagetest","owner":{"login":"indeedeng","id":2905043,"avatar_url":"https://avatars.githubusercontent.com/u/2905043?v=3","gravatar_id":"","url":"https://api.github.com/users/indeedeng","html_url":"https://github.com/indeedeng","followers_url":"https://api.github.com/users/indeedeng/followers","following_url":"https://api.github.com/users/indeedeng/following{/other_user}","gists_url":"https://api.github.com/users/indeedeng/gists{/gist_id}","starred_url":"https://api.github.com/users/indeedeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indeedeng/subscriptions","organizations_url":"https://api.github.com/users/indeedeng/orgs","repos_url":"https://api.github.com/users/indeedeng/repos","events_url":"https://api.github.com/users/indeedeng/events{/privacy}","received_events_url":"https://api.github.com/users/indeedeng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indeedeng/webpagetest","description":"Official repository for WebPagetest","fork":true,"url":"https://api.github.com/repos/indeedeng/webpagetest","forks_url":"https://api.github.com/repos/indeedeng/webpagetest/forks","keys_url":"https://api.github.com/repos/indeedeng/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indeedeng/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indeedeng/webpagetest/teams","hooks_url":"https://api.github.com/repos/indeedeng/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/indeedeng/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/indeedeng/webpagetest/events","assignees_url":"https://api.github.com/repos/indeedeng/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/indeedeng/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/indeedeng/webpagetest/tags","blobs_url":"https://api.github.com/repos/indeedeng/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indeedeng/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indeedeng/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/indeedeng/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indeedeng/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/indeedeng/webpagetest/languages","stargazers_url":"https://api.github.com/repos/indeedeng/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/indeedeng/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/indeedeng/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/indeedeng/webpagetest/subscription","commits_url":"https://api.github.com/repos/indeedeng/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/indeedeng/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/indeedeng/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/indeedeng/webpagetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/indeedeng/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/indeedeng/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indeedeng/webpagetest/merges","archive_url":"https://api.github.com/repos/indeedeng/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indeedeng/webpagetest/downloads","issues_url":"https://api.github.com/repos/indeedeng/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/indeedeng/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/indeedeng/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/indeedeng/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indeedeng/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/indeedeng/webpagetest/releases{/id}","created_at":"2015-01-29T02:15:58Z","updated_at":"2015-01-29T04:40:53Z","pushed_at":"2015-01-29T04:40:52Z","git_url":"git://github.com/indeedeng/webpagetest.git","ssh_url":"git@github.com:indeedeng/webpagetest.git","clone_url":"https://github.com/indeedeng/webpagetest.git","svn_url":"https://github.com/indeedeng/webpagetest","homepage":null,"size":616631,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WPO-Foundation:master","ref":"master","sha":"8e49a3f3d906550685b496bb40bc686918e9cb37","user":{"login":"WPO-Foundation","id":4622875,"avatar_url":"https://avatars.githubusercontent.com/u/4622875?v=3","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":11029192,"name":"webpagetest","full_name":"WPO-Foundation/webpagetest","owner":{"login":"WPO-Foundation","id":4622875,"avatar_url":"https://avatars.githubusercontent.com/u/4622875?v=3","gravatar_id":"","url":"https://api.github.com/users/WPO-Foundation","html_url":"https://github.com/WPO-Foundation","followers_url":"https://api.github.com/users/WPO-Foundation/followers","following_url":"https://api.github.com/users/WPO-Foundation/following{/other_user}","gists_url":"https://api.github.com/users/WPO-Foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/WPO-Foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPO-Foundation/subscriptions","organizations_url":"https://api.github.com/users/WPO-Foundation/orgs","repos_url":"https://api.github.com/users/WPO-Foundation/repos","events_url":"https://api.github.com/users/WPO-Foundation/events{/privacy}","received_events_url":"https://api.github.com/users/WPO-Foundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WPO-Foundation/webpagetest","description":"Official repository for WebPagetest","fork":false,"url":"https://api.github.com/repos/WPO-Foundation/webpagetest","forks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/forks","keys_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/teams","hooks_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/hooks","issue_events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/events{/number}","events_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/events","assignees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/assignees{/user}","branches_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/branches{/branch}","tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/tags","blobs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/{sha}","languages_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/languages","stargazers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/stargazers","contributors_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contributors","subscribers_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscribers","subscription_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/subscription","commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/contents/{+path}","compare_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/merges","archive_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/downloads","issues_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues{/number}","pulls_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls{/number}","milestones_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/milestones{/number}","notifications_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/labels{/name}","releases_url":"https://api.github.com/repos/WPO-Foundation/webpagetest/releases{/id}","created_at":"2013-06-28T14:54:54Z","updated_at":"2015-01-29T15:29:35Z","pushed_at":"2015-01-29T15:29:34Z","git_url":"git://github.com/WPO-Foundation/webpagetest.git","ssh_url":"git@github.com:WPO-Foundation/webpagetest.git","clone_url":"https://github.com/WPO-Foundation/webpagetest.git","svn_url":"https://github.com/WPO-Foundation/webpagetest","homepage":null,"size":616631,"stargazers_count":558,"watchers_count":558,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":150,"forks":150,"open_issues":150,"watchers":558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392"},"html":{"href":"https://github.com/WPO-Foundation/webpagetest/pull/392"},"issue":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/392"},"comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/WPO-Foundation/webpagetest/statuses/61a5d79d1b57f53656922af1ae2c9ab6aa613963"}}}}