{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/43015393","id":43015393,"diff_hunk":"@@ -396,7 +396,17 @@ def solve_univariate_inequality(expr, gen, relational=True):\n \n     \"\"\"\n \n-    from sympy.solvers.solvers import solve, denoms\n+    from sympy.solvers.solvers import denoms\n+    from sympy.solvers.solveset import solveset\n+\n+    def solve_replacement(f_x, x):","path":"sympy/solvers/inequalities.py","position":8,"original_position":8,"commit_id":"efe2b12c1ecbbeff1f7d5be7adcdc5aaf7816771","original_commit_id":"efe2b12c1ecbbeff1f7d5be7adcdc5aaf7816771","user":{"login":"hargup","id":2477788,"avatar_url":"https://avatars.githubusercontent.com/u/2477788?v=3","gravatar_id":"","url":"https://api.github.com/users/hargup","html_url":"https://github.com/hargup","followers_url":"https://api.github.com/users/hargup/followers","following_url":"https://api.github.com/users/hargup/following{/other_user}","gists_url":"https://api.github.com/users/hargup/gists{/gist_id}","starred_url":"https://api.github.com/users/hargup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hargup/subscriptions","organizations_url":"https://api.github.com/users/hargup/orgs","repos_url":"https://api.github.com/users/hargup/repos","events_url":"https://api.github.com/users/hargup/events{/privacy}","received_events_url":"https://api.github.com/users/hargup/received_events","type":"User","site_admin":false},"body":"> The name `solve_replacement` makes sense in the context of this PR, but will it make sense a year from now in this file when people come across it?\r\n\r\nProbably it won't, I like @smichr 's suggestion to keep the name of this function as `solve` so that we won't have to change the actual code. This function which emulates the output api of `solve` using `solveset` is of more general use than just this file hence I'm moving it to `solveset`. We will have two solves:\r\n```python\r\nsympy.solvers.solvers.solve # The actual old solve\r\nsympy.solvers.solveset.solve # emulation of old solve by solveset\r\n```","created_at":"2015-10-26T16:21:09Z","updated_at":"2015-10-26T16:21:09Z","html_url":"https://github.com/sympy/sympy/pull/10022#discussion_r43015393","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/10022","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/43015393"},"html":{"href":"https://github.com/sympy/sympy/pull/10022#discussion_r43015393"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10022"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10022","id":48496295,"html_url":"https://github.com/sympy/sympy/pull/10022","diff_url":"https://github.com/sympy/sympy/pull/10022.diff","patch_url":"https://github.com/sympy/sympy/pull/10022.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10022","number":10022,"state":"open","locked":false,"title":"Replace solve by solveset in inequalities","user":{"login":"hargup","id":2477788,"avatar_url":"https://avatars.githubusercontent.com/u/2477788?v=3","gravatar_id":"","url":"https://api.github.com/users/hargup","html_url":"https://github.com/hargup","followers_url":"https://api.github.com/users/hargup/followers","following_url":"https://api.github.com/users/hargup/following{/other_user}","gists_url":"https://api.github.com/users/hargup/gists{/gist_id}","starred_url":"https://api.github.com/users/hargup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hargup/subscriptions","organizations_url":"https://api.github.com/users/hargup/orgs","repos_url":"https://api.github.com/users/hargup/repos","events_url":"https://api.github.com/users/hargup/events{/privacy}","received_events_url":"https://api.github.com/users/hargup/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-22T18:44:57Z","updated_at":"2015-10-26T16:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"335d71b4d976dacfcdf85c51978e79f5ea567421","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/10022/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/10022/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10022/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/efe2b12c1ecbbeff1f7d5be7adcdc5aaf7816771","head":{"label":"hargup:ineq_solveset","ref":"ineq_solveset","sha":"efe2b12c1ecbbeff1f7d5be7adcdc5aaf7816771","user":{"login":"hargup","id":2477788,"avatar_url":"https://avatars.githubusercontent.com/u/2477788?v=3","gravatar_id":"","url":"https://api.github.com/users/hargup","html_url":"https://github.com/hargup","followers_url":"https://api.github.com/users/hargup/followers","following_url":"https://api.github.com/users/hargup/following{/other_user}","gists_url":"https://api.github.com/users/hargup/gists{/gist_id}","starred_url":"https://api.github.com/users/hargup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hargup/subscriptions","organizations_url":"https://api.github.com/users/hargup/orgs","repos_url":"https://api.github.com/users/hargup/repos","events_url":"https://api.github.com/users/hargup/events{/privacy}","received_events_url":"https://api.github.com/users/hargup/received_events","type":"User","site_admin":false},"repo":{"id":8270609,"name":"sympy","full_name":"hargup/sympy","owner":{"login":"hargup","id":2477788,"avatar_url":"https://avatars.githubusercontent.com/u/2477788?v=3","gravatar_id":"","url":"https://api.github.com/users/hargup","html_url":"https://github.com/hargup","followers_url":"https://api.github.com/users/hargup/followers","following_url":"https://api.github.com/users/hargup/following{/other_user}","gists_url":"https://api.github.com/users/hargup/gists{/gist_id}","starred_url":"https://api.github.com/users/hargup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hargup/subscriptions","organizations_url":"https://api.github.com/users/hargup/orgs","repos_url":"https://api.github.com/users/hargup/repos","events_url":"https://api.github.com/users/hargup/events{/privacy}","received_events_url":"https://api.github.com/users/hargup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hargup/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/hargup/sympy","forks_url":"https://api.github.com/repos/hargup/sympy/forks","keys_url":"https://api.github.com/repos/hargup/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hargup/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hargup/sympy/teams","hooks_url":"https://api.github.com/repos/hargup/sympy/hooks","issue_events_url":"https://api.github.com/repos/hargup/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/hargup/sympy/events","assignees_url":"https://api.github.com/repos/hargup/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/hargup/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/hargup/sympy/tags","blobs_url":"https://api.github.com/repos/hargup/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hargup/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hargup/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hargup/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hargup/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/hargup/sympy/languages","stargazers_url":"https://api.github.com/repos/hargup/sympy/stargazers","contributors_url":"https://api.github.com/repos/hargup/sympy/contributors","subscribers_url":"https://api.github.com/repos/hargup/sympy/subscribers","subscription_url":"https://api.github.com/repos/hargup/sympy/subscription","commits_url":"https://api.github.com/repos/hargup/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hargup/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hargup/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hargup/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hargup/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/hargup/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hargup/sympy/merges","archive_url":"https://api.github.com/repos/hargup/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hargup/sympy/downloads","issues_url":"https://api.github.com/repos/hargup/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/hargup/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/hargup/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/hargup/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hargup/sympy/labels{/name}","releases_url":"https://api.github.com/repos/hargup/sympy/releases{/id}","created_at":"2013-02-18T15:03:14Z","updated_at":"2014-11-23T14:03:06Z","pushed_at":"2015-10-22T18:44:24Z","git_url":"git://github.com/hargup/sympy.git","ssh_url":"git@github.com:hargup/sympy.git","clone_url":"https://github.com/hargup/sympy.git","svn_url":"https://github.com/hargup/sympy","homepage":"http://sympy.org/","size":83004,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"69f86987e722d7b559676017a3cc483b626f9100","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-10-25T12:45:06Z","pushed_at":"2015-10-26T07:14:42Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":156545,"stargazers_count":2412,"watchers_count":2412,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1182,"mirror_url":null,"open_issues_count":2007,"forks":1182,"open_issues":2007,"watchers":2412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10022"},"html":{"href":"https://github.com/sympy/sympy/pull/10022"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/10022"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/10022/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10022/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10022/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/efe2b12c1ecbbeff1f7d5be7adcdc5aaf7816771"}}}}