{"action":"created","issue":{"url":"https://api.github.com/repos/SoCo/SoCo/issues/267","labels_url":"https://api.github.com/repos/SoCo/SoCo/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/SoCo/SoCo/issues/267/comments","events_url":"https://api.github.com/repos/SoCo/SoCo/issues/267/events","html_url":"https://github.com/SoCo/SoCo/pull/267","id":52967128,"number":267,"title":"Initial Commit:  Plugin works for my single speaker system. I attempted ...","user":{"login":"jlmcgehee21","id":8727616,"avatar_url":"https://avatars.githubusercontent.com/u/8727616?v=3","gravatar_id":"","url":"https://api.github.com/users/jlmcgehee21","html_url":"https://github.com/jlmcgehee21","followers_url":"https://api.github.com/users/jlmcgehee21/followers","following_url":"https://api.github.com/users/jlmcgehee21/following{/other_user}","gists_url":"https://api.github.com/users/jlmcgehee21/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmcgehee21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmcgehee21/subscriptions","organizations_url":"https://api.github.com/users/jlmcgehee21/orgs","repos_url":"https://api.github.com/users/jlmcgehee21/repos","events_url":"https://api.github.com/users/jlmcgehee21/events{/privacy}","received_events_url":"https://api.github.com/users/jlmcgehee21/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2014-12-27T22:08:49Z","updated_at":"2015-01-17T07:11:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SoCo/SoCo/pulls/267","html_url":"https://github.com/SoCo/SoCo/pull/267","diff_url":"https://github.com/SoCo/SoCo/pull/267.diff","patch_url":"https://github.com/SoCo/SoCo/pull/267.patch"},"body":"I attempted to build this for multiple speaker systems, but I have no way to test/troubleshoot it.\r\n\r\nI'm not sure if this fits your programming style, but I tried my best.  I would love for someone with multiple speakers to test/add to this.  It may be a little while before I add speakers to my system.\r\n\r\nThe main purpose of this for me is to link it with my DIY home automation system.  I wanted to contribute to what I feel is a great project instead of just branching out on my own.\r\n\r\n-Jeff McGehee"},"comment":{"url":"https://api.github.com/repos/SoCo/SoCo/issues/comments/70357747","html_url":"https://github.com/SoCo/SoCo/pull/267#issuecomment-70357747","issue_url":"https://api.github.com/repos/SoCo/SoCo/issues/267","id":70357747,"user":{"login":"jlmcgehee21","id":8727616,"avatar_url":"https://avatars.githubusercontent.com/u/8727616?v=3","gravatar_id":"","url":"https://api.github.com/users/jlmcgehee21","html_url":"https://github.com/jlmcgehee21","followers_url":"https://api.github.com/users/jlmcgehee21/followers","following_url":"https://api.github.com/users/jlmcgehee21/following{/other_user}","gists_url":"https://api.github.com/users/jlmcgehee21/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmcgehee21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmcgehee21/subscriptions","organizations_url":"https://api.github.com/users/jlmcgehee21/orgs","repos_url":"https://api.github.com/users/jlmcgehee21/repos","events_url":"https://api.github.com/users/jlmcgehee21/events{/privacy}","received_events_url":"https://api.github.com/users/jlmcgehee21/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T07:11:01Z","updated_at":"2015-01-17T07:11:01Z","body":"After some review of the code in #99 and more testing with my pull request,\r\nI think the best solution would be to modify #99 to function as a proper\r\nplugin.  The use of the Snapshot class (which I didn't even realize existed\r\nuntil I got some responses to my pull request) is much better than what I\r\ntried to hack together.\r\n\r\nMy plan is to implement #99 as a plugin when I find some free time and\r\nsubmit a new pull request then.  I think I'll go ahead and close this one.\r\nThanks for the awesome work you guys are doing!\r\n\r\nOn Fri, Jan 16, 2015 at 2:46 AM, Kenneth Nielsen <notifications@github.com>\r\nwrote:\r\n\r\n> Hi @jlmcgehee21 <https://github.com/jlmcgehee21> and thanks for putting\r\n> the stuff out here.\r\n>\r\n> I'm a little in doubt about the status here, and the text-to-speech stuff\r\n> is not my strong suit. Does this plugin represent functionality not already\r\n> in SoCo (@jlmcgehee21 <https://github.com/jlmcgehee21>, @robwebset\r\n> <https://github.com/robwebset>, @DPH <https://github.com/DPH>). At first\r\n> glance I would say that it does, since it seems most of the existing\r\n> text-to-speech stuff has been external scripts and this is made as a proper\r\n> plugin. It might of course be very useful for @jlmcgehee21\r\n> <https://github.com/jlmcgehee21> to have a look at the code @robwebset\r\n> <https://github.com/robwebset> published in #99\r\n> <https://github.com/SoCo/SoCo/issues/99>, so if you want to continue\r\n> working on the plugin and make a PR later, we can also do that.\r\n>\r\n> I just wanted to check before I started reviewing.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/SoCo/SoCo/pull/267#issuecomment-70218603>.\r\n>\r\n>"}}