{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/30955097","id":30955097,"diff_hunk":"@@ -980,6 +985,10 @@ func initNetworkController(config *Config) (libnetwork.NetworkController, error)\n \treturn controller, nil\n }\n \n+func (daemon *Daemon) NetworkApiRouter() func(w http.ResponseWriter, req *http.Request) {","path":"daemon/daemon.go","position":30,"original_position":30,"commit_id":"a96612618fcc9e12e08e61e08b17637eb1cafea5","original_commit_id":"a96612618fcc9e12e08e61e08b17637eb1cafea5","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"But these vars don't look like there being used at all.","created_at":"2015-05-24T19:34:33Z","updated_at":"2015-05-24T19:34:33Z","html_url":"https://github.com/docker/docker/pull/13441#discussion_r30955097","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/13441","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/30955097"},"html":{"href":"https://github.com/docker/docker/pull/13441#discussion_r30955097"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/13441"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/13441","id":36104955,"html_url":"https://github.com/docker/docker/pull/13441","diff_url":"https://github.com/docker/docker/pull/13441.diff","patch_url":"https://github.com/docker/docker/pull/13441.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/13441","number":13441,"state":"open","locked":false,"title":"Networks API & UI","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"This PR brings in the API & UI support for `networks` resource provided by `libnetwork`.\r\n* New API Sub-Router that handles everything for `networks` resource\r\n* UI hook for `docker network` into libnetwork UI handler\r\n* `docker run --net={user-defined-network}\r\n* Initial version of docs from @dave-tucker. (Will be updated with more upto-date content)","created_at":"2015-05-24T16:38:44Z","updated_at":"2015-05-24T19:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8328cc2e778ea0b1325775be99465a3fd8e11c7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/13441/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/13441/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/13441/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a96612618fcc9e12e08e61e08b17637eb1cafea5","head":{"label":"mavenugo:api_ui","ref":"api_ui","sha":"a96612618fcc9e12e08e61e08b17637eb1cafea5","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"repo":{"id":25433630,"name":"docker","full_name":"mavenugo/docker","owner":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mavenugo/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mavenugo/docker","forks_url":"https://api.github.com/repos/mavenugo/docker/forks","keys_url":"https://api.github.com/repos/mavenugo/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavenugo/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavenugo/docker/teams","hooks_url":"https://api.github.com/repos/mavenugo/docker/hooks","issue_events_url":"https://api.github.com/repos/mavenugo/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mavenugo/docker/events","assignees_url":"https://api.github.com/repos/mavenugo/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mavenugo/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mavenugo/docker/tags","blobs_url":"https://api.github.com/repos/mavenugo/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavenugo/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavenugo/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavenugo/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavenugo/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mavenugo/docker/languages","stargazers_url":"https://api.github.com/repos/mavenugo/docker/stargazers","contributors_url":"https://api.github.com/repos/mavenugo/docker/contributors","subscribers_url":"https://api.github.com/repos/mavenugo/docker/subscribers","subscription_url":"https://api.github.com/repos/mavenugo/docker/subscription","commits_url":"https://api.github.com/repos/mavenugo/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavenugo/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavenugo/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavenugo/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavenugo/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mavenugo/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavenugo/docker/merges","archive_url":"https://api.github.com/repos/mavenugo/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavenugo/docker/downloads","issues_url":"https://api.github.com/repos/mavenugo/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mavenugo/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mavenugo/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mavenugo/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavenugo/docker/labels{/name}","releases_url":"https://api.github.com/repos/mavenugo/docker/releases{/id}","created_at":"2014-10-19T17:04:36Z","updated_at":"2015-04-24T13:45:12Z","pushed_at":"2015-05-24T17:31:37Z","git_url":"git://github.com/mavenugo/docker.git","ssh_url":"git@github.com:mavenugo/docker.git","clone_url":"https://github.com/mavenugo/docker.git","svn_url":"https://github.com/mavenugo/docker","homepage":"http://www.docker.com","size":55282,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"f83073d3eb23a3f3c22bef9401090df5da53cc2f","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-05-24T19:00:21Z","pushed_at":"2015-05-24T18:23:54Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":217488,"stargazers_count":21881,"watchers_count":21881,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5171,"mirror_url":null,"open_issues_count":1018,"forks":5171,"open_issues":1018,"watchers":21881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/13441"},"html":{"href":"https://github.com/docker/docker/pull/13441"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/13441"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/13441/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/13441/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/13441/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a96612618fcc9e12e08e61e08b17637eb1cafea5"}}}}