{"action":"created","comment":{"url":"https://api.github.com/repos/libgraviton/graviton/pulls/comments/27432211","id":27432211,"diff_hunk":"@@ -3,6 +3,7 @@ parameters:\n     mongodb.default.server.db: db\n     mongodb.default.server.uri: ~\n \n+    graviton.translator.default.locale: en","path":"app/config/parameters.yml.dist","position":4,"original_position":4,"commit_id":"7b6b00f0467b6a3df838783a479ed011bffab599","original_commit_id":"7b6b00f0467b6a3df838783a479ed011bffab599","user":{"login":"hairmare","id":116588,"avatar_url":"https://avatars.githubusercontent.com/u/116588?v=3","gravatar_id":"","url":"https://api.github.com/users/hairmare","html_url":"https://github.com/hairmare","followers_url":"https://api.github.com/users/hairmare/followers","following_url":"https://api.github.com/users/hairmare/following{/other_user}","gists_url":"https://api.github.com/users/hairmare/gists{/gist_id}","starred_url":"https://api.github.com/users/hairmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairmare/subscriptions","organizations_url":"https://api.github.com/users/hairmare/orgs","repos_url":"https://api.github.com/users/hairmare/repos","events_url":"https://api.github.com/users/hairmare/events{/privacy}","received_events_url":"https://api.github.com/users/hairmare/received_events","type":"User","site_admin":false},"body":"I don't like this change at all. It completely contradicts what we defined a long time ago (keeping the default as ``en`` and making everything else translated).","created_at":"2015-03-30T21:09:20Z","updated_at":"2015-03-30T21:09:20Z","html_url":"https://github.com/libgraviton/graviton/pull/84#discussion_r27432211","pull_request_url":"https://api.github.com/repos/libgraviton/graviton/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/comments/27432211"},"html":{"href":"https://github.com/libgraviton/graviton/pull/84#discussion_r27432211"},"pull_request":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/libgraviton/graviton/pulls/84","id":32238810,"html_url":"https://github.com/libgraviton/graviton/pull/84","diff_url":"https://github.com/libgraviton/graviton/pull/84.diff","patch_url":"https://github.com/libgraviton/graviton/pull/84.patch","issue_url":"https://api.github.com/repos/libgraviton/graviton/issues/84","number":84,"state":"open","locked":false,"title":"fix translation","user":{"login":"narcoticfresh","id":245441,"avatar_url":"https://avatars.githubusercontent.com/u/245441?v=3","gravatar_id":"","url":"https://api.github.com/users/narcoticfresh","html_url":"https://github.com/narcoticfresh","followers_url":"https://api.github.com/users/narcoticfresh/followers","following_url":"https://api.github.com/users/narcoticfresh/following{/other_user}","gists_url":"https://api.github.com/users/narcoticfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/narcoticfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narcoticfresh/subscriptions","organizations_url":"https://api.github.com/users/narcoticfresh/orgs","repos_url":"https://api.github.com/users/narcoticfresh/repos","events_url":"https://api.github.com/users/narcoticfresh/events{/privacy}","received_events_url":"https://api.github.com/users/narcoticfresh/received_events","type":"User","site_admin":false},"body":"i'm not trying to re-invent the translation wheel or fix all broken things. This PR just wants translation to actually *work*\r\n\r\nIt corrects some bugs:\r\n* Make sure that both Listeners use the same `domain` for there translation (thus finding them in the first place)\r\n* Touch the trigger file for the loader not only when the file *doesn't* exist..\r\n* Create a new `I18nUtils` service that keeps all this stuff in one place - it is called `intUtils` in the classes as `$i18nUtils` is not valid according to syntax check.\r\n\r\nAfter this merge, translations actually and really work across all controllers. Hooray!","created_at":"2015-03-30T15:42:22Z","updated_at":"2015-03-30T21:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de3ff578eac31649e28e1026ccd664a4d4c22107","assignee":{"login":"hairmare","id":116588,"avatar_url":"https://avatars.githubusercontent.com/u/116588?v=3","gravatar_id":"","url":"https://api.github.com/users/hairmare","html_url":"https://github.com/hairmare","followers_url":"https://api.github.com/users/hairmare/followers","following_url":"https://api.github.com/users/hairmare/following{/other_user}","gists_url":"https://api.github.com/users/hairmare/gists{/gist_id}","starred_url":"https://api.github.com/users/hairmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairmare/subscriptions","organizations_url":"https://api.github.com/users/hairmare/orgs","repos_url":"https://api.github.com/users/hairmare/repos","events_url":"https://api.github.com/users/hairmare/events{/privacy}","received_events_url":"https://api.github.com/users/hairmare/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/libgraviton/graviton/pulls/84/commits","review_comments_url":"https://api.github.com/repos/libgraviton/graviton/pulls/84/comments","review_comment_url":"https://api.github.com/repos/libgraviton/graviton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgraviton/graviton/issues/84/comments","statuses_url":"https://api.github.com/repos/libgraviton/graviton/statuses/7b6b00f0467b6a3df838783a479ed011bffab599","head":{"label":"libgraviton:feature/fix-translation","ref":"feature/fix-translation","sha":"7b6b00f0467b6a3df838783a479ed011bffab599","user":{"login":"libgraviton","id":4174061,"avatar_url":"https://avatars.githubusercontent.com/u/4174061?v=3","gravatar_id":"","url":"https://api.github.com/users/libgraviton","html_url":"https://github.com/libgraviton","followers_url":"https://api.github.com/users/libgraviton/followers","following_url":"https://api.github.com/users/libgraviton/following{/other_user}","gists_url":"https://api.github.com/users/libgraviton/gists{/gist_id}","starred_url":"https://api.github.com/users/libgraviton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgraviton/subscriptions","organizations_url":"https://api.github.com/users/libgraviton/orgs","repos_url":"https://api.github.com/users/libgraviton/repos","events_url":"https://api.github.com/users/libgraviton/events{/privacy}","received_events_url":"https://api.github.com/users/libgraviton/received_events","type":"Organization","site_admin":false},"repo":{"id":13440432,"name":"graviton","full_name":"libgraviton/graviton","owner":{"login":"libgraviton","id":4174061,"avatar_url":"https://avatars.githubusercontent.com/u/4174061?v=3","gravatar_id":"","url":"https://api.github.com/users/libgraviton","html_url":"https://github.com/libgraviton","followers_url":"https://api.github.com/users/libgraviton/followers","following_url":"https://api.github.com/users/libgraviton/following{/other_user}","gists_url":"https://api.github.com/users/libgraviton/gists{/gist_id}","starred_url":"https://api.github.com/users/libgraviton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgraviton/subscriptions","organizations_url":"https://api.github.com/users/libgraviton/orgs","repos_url":"https://api.github.com/users/libgraviton/repos","events_url":"https://api.github.com/users/libgraviton/events{/privacy}","received_events_url":"https://api.github.com/users/libgraviton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgraviton/graviton","description":"","fork":false,"url":"https://api.github.com/repos/libgraviton/graviton","forks_url":"https://api.github.com/repos/libgraviton/graviton/forks","keys_url":"https://api.github.com/repos/libgraviton/graviton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgraviton/graviton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgraviton/graviton/teams","hooks_url":"https://api.github.com/repos/libgraviton/graviton/hooks","issue_events_url":"https://api.github.com/repos/libgraviton/graviton/issues/events{/number}","events_url":"https://api.github.com/repos/libgraviton/graviton/events","assignees_url":"https://api.github.com/repos/libgraviton/graviton/assignees{/user}","branches_url":"https://api.github.com/repos/libgraviton/graviton/branches{/branch}","tags_url":"https://api.github.com/repos/libgraviton/graviton/tags","blobs_url":"https://api.github.com/repos/libgraviton/graviton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgraviton/graviton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgraviton/graviton/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgraviton/graviton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgraviton/graviton/statuses/{sha}","languages_url":"https://api.github.com/repos/libgraviton/graviton/languages","stargazers_url":"https://api.github.com/repos/libgraviton/graviton/stargazers","contributors_url":"https://api.github.com/repos/libgraviton/graviton/contributors","subscribers_url":"https://api.github.com/repos/libgraviton/graviton/subscribers","subscription_url":"https://api.github.com/repos/libgraviton/graviton/subscription","commits_url":"https://api.github.com/repos/libgraviton/graviton/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgraviton/graviton/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgraviton/graviton/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgraviton/graviton/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgraviton/graviton/contents/{+path}","compare_url":"https://api.github.com/repos/libgraviton/graviton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgraviton/graviton/merges","archive_url":"https://api.github.com/repos/libgraviton/graviton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgraviton/graviton/downloads","issues_url":"https://api.github.com/repos/libgraviton/graviton/issues{/number}","pulls_url":"https://api.github.com/repos/libgraviton/graviton/pulls{/number}","milestones_url":"https://api.github.com/repos/libgraviton/graviton/milestones{/number}","notifications_url":"https://api.github.com/repos/libgraviton/graviton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgraviton/graviton/labels{/name}","releases_url":"https://api.github.com/repos/libgraviton/graviton/releases{/id}","created_at":"2013-10-09T11:26:14Z","updated_at":"2015-03-30T16:24:28Z","pushed_at":"2015-03-30T16:24:27Z","git_url":"git://github.com/libgraviton/graviton.git","ssh_url":"git@github.com:libgraviton/graviton.git","clone_url":"https://github.com/libgraviton/graviton.git","svn_url":"https://github.com/libgraviton/graviton","homepage":"http://gravity-platform.github.io/","size":6266,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":2,"default_branch":"develop"}},"base":{"label":"libgraviton:develop","ref":"develop","sha":"5c951ae6f0d0723fa827c622561d62e905f87b16","user":{"login":"libgraviton","id":4174061,"avatar_url":"https://avatars.githubusercontent.com/u/4174061?v=3","gravatar_id":"","url":"https://api.github.com/users/libgraviton","html_url":"https://github.com/libgraviton","followers_url":"https://api.github.com/users/libgraviton/followers","following_url":"https://api.github.com/users/libgraviton/following{/other_user}","gists_url":"https://api.github.com/users/libgraviton/gists{/gist_id}","starred_url":"https://api.github.com/users/libgraviton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgraviton/subscriptions","organizations_url":"https://api.github.com/users/libgraviton/orgs","repos_url":"https://api.github.com/users/libgraviton/repos","events_url":"https://api.github.com/users/libgraviton/events{/privacy}","received_events_url":"https://api.github.com/users/libgraviton/received_events","type":"Organization","site_admin":false},"repo":{"id":13440432,"name":"graviton","full_name":"libgraviton/graviton","owner":{"login":"libgraviton","id":4174061,"avatar_url":"https://avatars.githubusercontent.com/u/4174061?v=3","gravatar_id":"","url":"https://api.github.com/users/libgraviton","html_url":"https://github.com/libgraviton","followers_url":"https://api.github.com/users/libgraviton/followers","following_url":"https://api.github.com/users/libgraviton/following{/other_user}","gists_url":"https://api.github.com/users/libgraviton/gists{/gist_id}","starred_url":"https://api.github.com/users/libgraviton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgraviton/subscriptions","organizations_url":"https://api.github.com/users/libgraviton/orgs","repos_url":"https://api.github.com/users/libgraviton/repos","events_url":"https://api.github.com/users/libgraviton/events{/privacy}","received_events_url":"https://api.github.com/users/libgraviton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgraviton/graviton","description":"","fork":false,"url":"https://api.github.com/repos/libgraviton/graviton","forks_url":"https://api.github.com/repos/libgraviton/graviton/forks","keys_url":"https://api.github.com/repos/libgraviton/graviton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgraviton/graviton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgraviton/graviton/teams","hooks_url":"https://api.github.com/repos/libgraviton/graviton/hooks","issue_events_url":"https://api.github.com/repos/libgraviton/graviton/issues/events{/number}","events_url":"https://api.github.com/repos/libgraviton/graviton/events","assignees_url":"https://api.github.com/repos/libgraviton/graviton/assignees{/user}","branches_url":"https://api.github.com/repos/libgraviton/graviton/branches{/branch}","tags_url":"https://api.github.com/repos/libgraviton/graviton/tags","blobs_url":"https://api.github.com/repos/libgraviton/graviton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgraviton/graviton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgraviton/graviton/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgraviton/graviton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgraviton/graviton/statuses/{sha}","languages_url":"https://api.github.com/repos/libgraviton/graviton/languages","stargazers_url":"https://api.github.com/repos/libgraviton/graviton/stargazers","contributors_url":"https://api.github.com/repos/libgraviton/graviton/contributors","subscribers_url":"https://api.github.com/repos/libgraviton/graviton/subscribers","subscription_url":"https://api.github.com/repos/libgraviton/graviton/subscription","commits_url":"https://api.github.com/repos/libgraviton/graviton/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgraviton/graviton/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgraviton/graviton/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgraviton/graviton/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgraviton/graviton/contents/{+path}","compare_url":"https://api.github.com/repos/libgraviton/graviton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgraviton/graviton/merges","archive_url":"https://api.github.com/repos/libgraviton/graviton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgraviton/graviton/downloads","issues_url":"https://api.github.com/repos/libgraviton/graviton/issues{/number}","pulls_url":"https://api.github.com/repos/libgraviton/graviton/pulls{/number}","milestones_url":"https://api.github.com/repos/libgraviton/graviton/milestones{/number}","notifications_url":"https://api.github.com/repos/libgraviton/graviton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgraviton/graviton/labels{/name}","releases_url":"https://api.github.com/repos/libgraviton/graviton/releases{/id}","created_at":"2013-10-09T11:26:14Z","updated_at":"2015-03-30T16:24:28Z","pushed_at":"2015-03-30T16:24:27Z","git_url":"git://github.com/libgraviton/graviton.git","ssh_url":"git@github.com:libgraviton/graviton.git","clone_url":"https://github.com/libgraviton/graviton.git","svn_url":"https://github.com/libgraviton/graviton","homepage":"http://gravity-platform.github.io/","size":6266,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/84"},"html":{"href":"https://github.com/libgraviton/graviton/pull/84"},"issue":{"href":"https://api.github.com/repos/libgraviton/graviton/issues/84"},"comments":{"href":"https://api.github.com/repos/libgraviton/graviton/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgraviton/graviton/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/libgraviton/graviton/statuses/7b6b00f0467b6a3df838783a479ed011bffab599"}}}}