{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/44665368","id":44665368,"diff_hunk":"@@ -62,7 +62,8 @@ class SQLite3Adapter < AbstractAdapter\n         time:         { name: \"time\" },\n         date:         { name: \"date\" },\n         binary:       { name: \"blob\" },\n-        boolean:      { name: \"boolean\" }\n+        boolean:      { name: \"boolean\" },\n+        bigint:       { name: \"bigint\" },","path":"activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb","position":6,"original_position":6,"commit_id":"26128949bbe5985e99b11dd8c8b9c0c562c3bb5c","original_commit_id":"26128949bbe5985e99b11dd8c8b9c0c562c3bb5c","user":{"login":"senny","id":5402,"avatar_url":"https://avatars.githubusercontent.com/u/5402?v=3","gravatar_id":"","url":"https://api.github.com/users/senny","html_url":"https://github.com/senny","followers_url":"https://api.github.com/users/senny/followers","following_url":"https://api.github.com/users/senny/following{/other_user}","gists_url":"https://api.github.com/users/senny/gists{/gist_id}","starred_url":"https://api.github.com/users/senny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senny/subscriptions","organizations_url":"https://api.github.com/users/senny/orgs","repos_url":"https://api.github.com/users/senny/repos","events_url":"https://api.github.com/users/senny/events{/privacy}","received_events_url":"https://api.github.com/users/senny/received_events","type":"User","site_admin":false},"body":"My guess is that we can probably remove most of the entries in the `Sqlite3Adapter` but let's explore that in another PR. As long as they don't make a transformation or have some non standard options, they won't affect behavior.\r\n\r\nIn terms of consistency. In my opinion we should target removing instead of adding new entries. Especially in sqlite3 where the column types don't really matter.","created_at":"2015-11-12T14:54:09Z","updated_at":"2015-11-12T14:54:09Z","html_url":"https://github.com/rails/rails/pull/22188#discussion_r44665368","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/22188","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/44665368"},"html":{"href":"https://github.com/rails/rails/pull/22188#discussion_r44665368"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/22188"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22188","id":49798250,"html_url":"https://github.com/rails/rails/pull/22188","diff_url":"https://github.com/rails/rails/pull/22188.diff","patch_url":"https://github.com/rails/rails/pull/22188.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/22188","number":22188,"state":"open","locked":false,"title":"Add missing `serial` in `NATIVE_DATABASE_TYPES`","user":{"login":"kamipo","id":12642,"avatar_url":"https://avatars.githubusercontent.com/u/12642?v=3","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"body":"* Add missing `serial` type in `NATIVE_DATABASE_TYPES` for PG adapter\r\n * The short-hand methods was added by #19030.\r\n * Schema dumping support was added by #19185.\r\n* Add missing geometric types in `NATIVE_DATABASE_TYPES` for PG adapter\r\n * The short-hand methods was added by #20459.\r\n* Add missing `bigint` type in `NATIVE_DATABASE_TYPES` for SQLite3 adapter\r\n * The short-hand method added by 574234b.\r\n * But only added in `NATIVE_DATABASE_TYPES` for PG adapter.\r\n\r\nThis PR is follow up to the above changes.","created_at":"2015-11-05T09:12:46Z","updated_at":"2015-11-12T14:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cddee60bdedb64d583f6f47a72954522fa76ee92","assignee":{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars.githubusercontent.com/u/1080678?v=3","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/22188/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/22188/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/22188/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/26128949bbe5985e99b11dd8c8b9c0c562c3bb5c","head":{"label":"kamipo:add_missing_serial_in_native_database_types","ref":"add_missing_serial_in_native_database_types","sha":"26128949bbe5985e99b11dd8c8b9c0c562c3bb5c","user":{"login":"kamipo","id":12642,"avatar_url":"https://avatars.githubusercontent.com/u/12642?v=3","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"repo":{"id":14544189,"name":"rails","full_name":"kamipo/rails","owner":{"login":"kamipo","id":12642,"avatar_url":"https://avatars.githubusercontent.com/u/12642?v=3","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamipo/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/kamipo/rails","forks_url":"https://api.github.com/repos/kamipo/rails/forks","keys_url":"https://api.github.com/repos/kamipo/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamipo/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamipo/rails/teams","hooks_url":"https://api.github.com/repos/kamipo/rails/hooks","issue_events_url":"https://api.github.com/repos/kamipo/rails/issues/events{/number}","events_url":"https://api.github.com/repos/kamipo/rails/events","assignees_url":"https://api.github.com/repos/kamipo/rails/assignees{/user}","branches_url":"https://api.github.com/repos/kamipo/rails/branches{/branch}","tags_url":"https://api.github.com/repos/kamipo/rails/tags","blobs_url":"https://api.github.com/repos/kamipo/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamipo/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamipo/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamipo/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamipo/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/kamipo/rails/languages","stargazers_url":"https://api.github.com/repos/kamipo/rails/stargazers","contributors_url":"https://api.github.com/repos/kamipo/rails/contributors","subscribers_url":"https://api.github.com/repos/kamipo/rails/subscribers","subscription_url":"https://api.github.com/repos/kamipo/rails/subscription","commits_url":"https://api.github.com/repos/kamipo/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamipo/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamipo/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamipo/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamipo/rails/contents/{+path}","compare_url":"https://api.github.com/repos/kamipo/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamipo/rails/merges","archive_url":"https://api.github.com/repos/kamipo/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamipo/rails/downloads","issues_url":"https://api.github.com/repos/kamipo/rails/issues{/number}","pulls_url":"https://api.github.com/repos/kamipo/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/kamipo/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/kamipo/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamipo/rails/labels{/name}","releases_url":"https://api.github.com/repos/kamipo/rails/releases{/id}","created_at":"2013-11-20T02:14:22Z","updated_at":"2015-02-16T07:18:13Z","pushed_at":"2015-11-12T13:07:56Z","git_url":"git://github.com/kamipo/rails.git","ssh_url":"git@github.com:kamipo/rails.git","clone_url":"https://github.com/kamipo/rails.git","svn_url":"https://github.com/kamipo/rails","homepage":"http://rubyonrails.org","size":112470,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"24bddfc542cf218e395029db3ece4502ae79eb3d","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-11-12T13:01:50Z","pushed_at":"2015-11-12T14:10:37Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":619328,"stargazers_count":28368,"watchers_count":28368,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11459,"mirror_url":null,"open_issues_count":842,"forks":11459,"open_issues":842,"watchers":28368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/22188"},"html":{"href":"https://github.com/rails/rails/pull/22188"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/22188"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/22188/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/22188/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/22188/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/26128949bbe5985e99b11dd8c8b9c0c562c3bb5c"}}}}