{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments/41133832","id":41133832,"diff_hunk":"@@ -20,14 +20,26 @@ class Gmsh < Formula\n     sha256 \"b23a220ace5b4c4d083a53d6d4860820c4b1a48dcdc1c4dba03459a55d9a224e\" => :mavericks\n   end\n \n+  option \"with-fltk\",              \"Build with fltk support\"\n+  option \"with-oce\",               \"Build with oce support (conflicts with opencascade)\"\n+  option \"without-opencascade\",    \"Build without opencascade support\"\n+  option \"without-petsc\",          \"Build without petsc support\"\n+  option \"without-slepc\",          \"Build without slepc support\"\n+\n   depends_on :fortran\n   depends_on :mpi => [:cc, :cxx, :f90, :recommended]\n   depends_on \"cmake\" => :build\n-  depends_on \"petsc\" => :optional\n-  depends_on \"slepc\" => :optional\n-  depends_on \"opencascade\" => :recommended\n-  depends_on \"fltk\" => :optional\n-  depends_on \"cairo\" if build.with? \"fltk\"\n+  depends_on \"petsc\"              if build.with? \"petsc\"\n+  depends_on \"slepc\"              if build.with? \"slepc\"\n+  depends_on \"fltk\"               if build.with? \"fltk\"","path":"gmsh.rb","position":35,"original_position":35,"commit_id":"459697f64b6759f9c2033a1efd3edcaca48758bb","original_commit_id":"459697f64b6759f9c2033a1efd3edcaca48758bb","user":{"login":"dpo","id":38760,"avatar_url":"https://avatars.githubusercontent.com/u/38760?v=3","gravatar_id":"","url":"https://api.github.com/users/dpo","html_url":"https://github.com/dpo","followers_url":"https://api.github.com/users/dpo/followers","following_url":"https://api.github.com/users/dpo/following{/other_user}","gists_url":"https://api.github.com/users/dpo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpo/subscriptions","organizations_url":"https://api.github.com/users/dpo/orgs","repos_url":"https://api.github.com/users/dpo/repos","events_url":"https://api.github.com/users/dpo/events{/privacy}","received_events_url":"https://api.github.com/users/dpo/received_events","type":"User","site_admin":false},"body":"Why this change? I've always found this redundant and much prefer `:optional` dependencies.","created_at":"2015-10-05T11:33:48Z","updated_at":"2015-10-05T11:33:48Z","html_url":"https://github.com/Homebrew/homebrew-science/pull/2824#discussion_r41133832","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments/41133832"},"html":{"href":"https://github.com/Homebrew/homebrew-science/pull/2824#discussion_r41133832"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824","id":46751834,"html_url":"https://github.com/Homebrew/homebrew-science/pull/2824","diff_url":"https://github.com/Homebrew/homebrew-science/pull/2824.diff","patch_url":"https://github.com/Homebrew/homebrew-science/pull/2824.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/2824","number":2824,"state":"open","locked":false,"title":"Updated Gmsh Formula With oce","user":{"login":"schoeps","id":868081,"avatar_url":"https://avatars.githubusercontent.com/u/868081?v=3","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"body":"as discussed in #2785. Seem to work find. However, I see sometimes segfaults of gmsh when compiled opencascade or oce. Sorry, I can currently not debug this.","created_at":"2015-10-05T07:49:56Z","updated_at":"2015-10-05T11:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23581aaab9e6f163030f9629ec152188dd5136d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/2824/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/459697f64b6759f9c2033a1efd3edcaca48758bb","head":{"label":"schoeps:gmsh","ref":"gmsh","sha":"459697f64b6759f9c2033a1efd3edcaca48758bb","user":{"login":"schoeps","id":868081,"avatar_url":"https://avatars.githubusercontent.com/u/868081?v=3","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"repo":{"id":43554085,"name":"homebrew-science","full_name":"schoeps/homebrew-science","owner":{"login":"schoeps","id":868081,"avatar_url":"https://avatars.githubusercontent.com/u/868081?v=3","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schoeps/homebrew-science","description":":microscope: Scientific formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/schoeps/homebrew-science","forks_url":"https://api.github.com/repos/schoeps/homebrew-science/forks","keys_url":"https://api.github.com/repos/schoeps/homebrew-science/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schoeps/homebrew-science/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schoeps/homebrew-science/teams","hooks_url":"https://api.github.com/repos/schoeps/homebrew-science/hooks","issue_events_url":"https://api.github.com/repos/schoeps/homebrew-science/issues/events{/number}","events_url":"https://api.github.com/repos/schoeps/homebrew-science/events","assignees_url":"https://api.github.com/repos/schoeps/homebrew-science/assignees{/user}","branches_url":"https://api.github.com/repos/schoeps/homebrew-science/branches{/branch}","tags_url":"https://api.github.com/repos/schoeps/homebrew-science/tags","blobs_url":"https://api.github.com/repos/schoeps/homebrew-science/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schoeps/homebrew-science/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schoeps/homebrew-science/git/refs{/sha}","trees_url":"https://api.github.com/repos/schoeps/homebrew-science/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schoeps/homebrew-science/statuses/{sha}","languages_url":"https://api.github.com/repos/schoeps/homebrew-science/languages","stargazers_url":"https://api.github.com/repos/schoeps/homebrew-science/stargazers","contributors_url":"https://api.github.com/repos/schoeps/homebrew-science/contributors","subscribers_url":"https://api.github.com/repos/schoeps/homebrew-science/subscribers","subscription_url":"https://api.github.com/repos/schoeps/homebrew-science/subscription","commits_url":"https://api.github.com/repos/schoeps/homebrew-science/commits{/sha}","git_commits_url":"https://api.github.com/repos/schoeps/homebrew-science/git/commits{/sha}","comments_url":"https://api.github.com/repos/schoeps/homebrew-science/comments{/number}","issue_comment_url":"https://api.github.com/repos/schoeps/homebrew-science/issues/comments{/number}","contents_url":"https://api.github.com/repos/schoeps/homebrew-science/contents/{+path}","compare_url":"https://api.github.com/repos/schoeps/homebrew-science/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schoeps/homebrew-science/merges","archive_url":"https://api.github.com/repos/schoeps/homebrew-science/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schoeps/homebrew-science/downloads","issues_url":"https://api.github.com/repos/schoeps/homebrew-science/issues{/number}","pulls_url":"https://api.github.com/repos/schoeps/homebrew-science/pulls{/number}","milestones_url":"https://api.github.com/repos/schoeps/homebrew-science/milestones{/number}","notifications_url":"https://api.github.com/repos/schoeps/homebrew-science/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schoeps/homebrew-science/labels{/name}","releases_url":"https://api.github.com/repos/schoeps/homebrew-science/releases{/id}","created_at":"2015-10-02T13:25:34Z","updated_at":"2015-10-02T13:25:36Z","pushed_at":"2015-10-05T07:47:06Z","git_url":"git://github.com/schoeps/homebrew-science.git","ssh_url":"git@github.com:schoeps/homebrew-science.git","clone_url":"https://github.com/schoeps/homebrew-science.git","svn_url":"https://github.com/schoeps/homebrew-science","homepage":"http://brew.sh/homebrew-science/","size":4026,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"d0dbb3dd1229e2aead9d3dc45c652b864d642c36","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":4106792,"name":"homebrew-science","full_name":"Homebrew/homebrew-science","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-science","description":":microscope: Scientific formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-science","forks_url":"https://api.github.com/repos/Homebrew/homebrew-science/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-science/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-science/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-science/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-science/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-science/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-science/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-science/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-science/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-science/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-science/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-science/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-science/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-science/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-science/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-science/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-science/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-science/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-science/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-science/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-science/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-science/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-science/releases{/id}","created_at":"2012-04-22T20:16:34Z","updated_at":"2015-10-05T02:10:20Z","pushed_at":"2015-10-05T07:49:56Z","git_url":"git://github.com/Homebrew/homebrew-science.git","ssh_url":"git@github.com:Homebrew/homebrew-science.git","clone_url":"https://github.com/Homebrew/homebrew-science.git","svn_url":"https://github.com/Homebrew/homebrew-science","homepage":"http://brew.sh/homebrew-science/","size":23671,"stargazers_count":557,"watchers_count":557,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":606,"mirror_url":null,"open_issues_count":145,"forks":606,"open_issues":145,"watchers":557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824"},"html":{"href":"https://github.com/Homebrew/homebrew-science/pull/2824"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/issues/2824"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/issues/2824/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/2824/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/459697f64b6759f9c2033a1efd3edcaca48758bb"}}}}