{"action":"created","comment":{"url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/comments/41735849","id":41735849,"diff_hunk":"@@ -18,8 +18,16 @@\n import com.databasepreservation.model.exception.ModuleException;\n import com.databasepreservation.model.structure.DatabaseStructure;\n import com.databasepreservation.modules.siard.common.SIARDArchiveContainer;\n+import com.databasepreservation.modules.siard.constants.SIARDDKConstants;\n+import com.databasepreservation.modules.siard.out.output.SIARDDKExportModule;\n import com.databasepreservation.modules.siard.out.write.WriteStrategy;\n-import dk.magenta.siarddk.fileindex.FileIndexType;\n+\n+// import dk.magenta.siarddk.fileindex.FileIndexType;\n+\n+\n+\n+","path":"dbptk-core/src/main/java/com/databasepreservation/modules/siard/out/metadata/FileIndexFileStrategy.java","position":22,"original_position":22,"commit_id":"ea3acf83e809ef073f6eecad7fccaf143f477e04","original_commit_id":"ea3acf83e809ef073f6eecad7fccaf143f477e04","user":{"login":"andreaskring","id":12028976,"avatar_url":"https://avatars.githubusercontent.com/u/12028976?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaskring","html_url":"https://github.com/andreaskring","followers_url":"https://api.github.com/users/andreaskring/followers","following_url":"https://api.github.com/users/andreaskring/following{/other_user}","gists_url":"https://api.github.com/users/andreaskring/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaskring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaskring/subscriptions","organizations_url":"https://api.github.com/users/andreaskring/orgs","repos_url":"https://api.github.com/users/andreaskring/repos","events_url":"https://api.github.com/users/andreaskring/events{/privacy}","received_events_url":"https://api.github.com/users/andreaskring/received_events","type":"User","site_admin":false},"body":"No - forgot to remove those\n\n2015-10-12 10:29 GMT+02:00 Bruno Ferreira <notifications@github.com>:\n\n> In\n> dbptk-core/src/main/java/com/databasepreservation/modules/siard/out/metadata/FileIndexFileStrategy.java\n> <https://github.com/keeps/db-preservation-toolkit/pull/74#discussion_r41733848>\n> :\n>\n> >  import com.databasepreservation.modules.siard.out.write.WriteStrategy;\n> > -import dk.magenta.siarddk.fileindex.FileIndexType;\n> > +\n> > +// import dk.magenta.siarddk.fileindex.FileIndexType;\n> > +\n> > +\n> > +\n> > +\n>\n> is there any special reason to keep the comment and blank lines?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/keeps/db-preservation-toolkit/pull/74/files#r41733848>\n> .\n>\n\n\n\n-- \nMagenta Aps\n\nE-mail: andreas@magenta.dk\nTlf.: 81 77 16 98\n","created_at":"2015-10-12T08:58:13Z","updated_at":"2015-10-12T08:58:13Z","html_url":"https://github.com/keeps/db-preservation-toolkit/pull/74#discussion_r41735849","pull_request_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/comments/41735849"},"html":{"href":"https://github.com/keeps/db-preservation-toolkit/pull/74#discussion_r41735849"},"pull_request":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74","id":47390104,"html_url":"https://github.com/keeps/db-preservation-toolkit/pull/74","diff_url":"https://github.com/keeps/db-preservation-toolkit/pull/74.diff","patch_url":"https://github.com/keeps/db-preservation-toolkit/pull/74.patch","issue_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/74","number":74,"state":"open","locked":false,"title":"Renamed dk.magenta packages to com.databasepreservation","user":{"login":"andreaskring","id":12028976,"avatar_url":"https://avatars.githubusercontent.com/u/12028976?v=3","gravatar_id":"","url":"https://api.github.com/users/andreaskring","html_url":"https://github.com/andreaskring","followers_url":"https://api.github.com/users/andreaskring/followers","following_url":"https://api.github.com/users/andreaskring/following{/other_user}","gists_url":"https://api.github.com/users/andreaskring/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaskring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaskring/subscriptions","organizations_url":"https://api.github.com/users/andreaskring/orgs","repos_url":"https://api.github.com/users/andreaskring/repos","events_url":"https://api.github.com/users/andreaskring/events{/privacy}","received_events_url":"https://api.github.com/users/andreaskring/received_events","type":"User","site_admin":false},"body":"Renamed dk.magenta packages to com.databasepreservation and put the files into the appropriate folders. Still throws ModuleException in case og LOBs","created_at":"2015-10-12T07:03:41Z","updated_at":"2015-10-12T08:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"858f26411aac9a7ce2969de776be124b874f62af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74/commits","review_comments_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74/comments","review_comment_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/74/comments","statuses_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/statuses/ea3acf83e809ef073f6eecad7fccaf143f477e04","head":{"label":"magenta-aps:develop","ref":"develop","sha":"ea3acf83e809ef073f6eecad7fccaf143f477e04","user":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars.githubusercontent.com/u/996271?v=3","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"repo":{"id":38817711,"name":"db-preservation-toolkit","full_name":"magenta-aps/db-preservation-toolkit","owner":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars.githubusercontent.com/u/996271?v=3","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magenta-aps/db-preservation-toolkit","description":"Database Preservation Toolkit","fork":true,"url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit","forks_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/forks","keys_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/teams","hooks_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/hooks","issue_events_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/events","assignees_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/tags","blobs_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/languages","stargazers_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/stargazers","contributors_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/contributors","subscribers_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/subscribers","subscription_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/subscription","commits_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/merges","archive_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/downloads","issues_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/magenta-aps/db-preservation-toolkit/releases{/id}","created_at":"2015-07-09T12:01:30Z","updated_at":"2015-07-09T12:01:30Z","pushed_at":"2015-10-12T06:55:28Z","git_url":"git://github.com/magenta-aps/db-preservation-toolkit.git","ssh_url":"git@github.com:magenta-aps/db-preservation-toolkit.git","clone_url":"https://github.com/magenta-aps/db-preservation-toolkit.git","svn_url":"https://github.com/magenta-aps/db-preservation-toolkit","homepage":"http://keeps.github.io/db-preservation-toolkit","size":78742,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"keeps:ak-siarddk","ref":"ak-siarddk","sha":"4f34ec25b6136246f4c35e532a9958b251609408","user":{"login":"keeps","id":1716414,"avatar_url":"https://avatars.githubusercontent.com/u/1716414?v=3","gravatar_id":"","url":"https://api.github.com/users/keeps","html_url":"https://github.com/keeps","followers_url":"https://api.github.com/users/keeps/followers","following_url":"https://api.github.com/users/keeps/following{/other_user}","gists_url":"https://api.github.com/users/keeps/gists{/gist_id}","starred_url":"https://api.github.com/users/keeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeps/subscriptions","organizations_url":"https://api.github.com/users/keeps/orgs","repos_url":"https://api.github.com/users/keeps/repos","events_url":"https://api.github.com/users/keeps/events{/privacy}","received_events_url":"https://api.github.com/users/keeps/received_events","type":"Organization","site_admin":false},"repo":{"id":12726858,"name":"db-preservation-toolkit","full_name":"keeps/db-preservation-toolkit","owner":{"login":"keeps","id":1716414,"avatar_url":"https://avatars.githubusercontent.com/u/1716414?v=3","gravatar_id":"","url":"https://api.github.com/users/keeps","html_url":"https://github.com/keeps","followers_url":"https://api.github.com/users/keeps/followers","following_url":"https://api.github.com/users/keeps/following{/other_user}","gists_url":"https://api.github.com/users/keeps/gists{/gist_id}","starred_url":"https://api.github.com/users/keeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeps/subscriptions","organizations_url":"https://api.github.com/users/keeps/orgs","repos_url":"https://api.github.com/users/keeps/repos","events_url":"https://api.github.com/users/keeps/events{/privacy}","received_events_url":"https://api.github.com/users/keeps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keeps/db-preservation-toolkit","description":"Database Preservation Toolkit","fork":false,"url":"https://api.github.com/repos/keeps/db-preservation-toolkit","forks_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/forks","keys_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/teams","hooks_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/hooks","issue_events_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/events","assignees_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/tags","blobs_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/languages","stargazers_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/stargazers","contributors_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/contributors","subscribers_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/subscribers","subscription_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/subscription","commits_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/merges","archive_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/downloads","issues_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/keeps/db-preservation-toolkit/releases{/id}","created_at":"2013-09-10T10:32:54Z","updated_at":"2015-09-25T21:15:48Z","pushed_at":"2015-10-12T07:03:41Z","git_url":"git://github.com/keeps/db-preservation-toolkit.git","ssh_url":"git@github.com:keeps/db-preservation-toolkit.git","clone_url":"https://github.com/keeps/db-preservation-toolkit.git","svn_url":"https://github.com/keeps/db-preservation-toolkit","homepage":"http://keeps.github.io/db-preservation-toolkit","size":78928,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":32,"forks":6,"open_issues":32,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74"},"html":{"href":"https://github.com/keeps/db-preservation-toolkit/pull/74"},"issue":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/74"},"comments":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/keeps/db-preservation-toolkit/statuses/ea3acf83e809ef073f6eecad7fccaf143f477e04"}}}}