{"action":"created","issue":{"url":"https://api.github.com/repos/mjibson/appstats/issues/19","labels_url":"https://api.github.com/repos/mjibson/appstats/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/mjibson/appstats/issues/19/comments","events_url":"https://api.github.com/repos/mjibson/appstats/issues/19/events","html_url":"https://github.com/mjibson/appstats/pull/19","id":109391191,"number":19,"title":"Rewrite stack trace parsing for Go 1.5 and clarity","user":{"login":"flowlo","id":542154,"avatar_url":"https://avatars.githubusercontent.com/u/542154?v=3","gravatar_id":"","url":"https://api.github.com/users/flowlo","html_url":"https://github.com/flowlo","followers_url":"https://api.github.com/users/flowlo/followers","following_url":"https://api.github.com/users/flowlo/following{/other_user}","gists_url":"https://api.github.com/users/flowlo/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlo/subscriptions","organizations_url":"https://api.github.com/users/flowlo/orgs","repos_url":"https://api.github.com/users/flowlo/repos","events_url":"https://api.github.com/users/flowlo/events{/privacy}","received_events_url":"https://api.github.com/users/flowlo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-01T21:42:18Z","updated_at":"2015-10-04T10:59:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mjibson/appstats/pulls/19","html_url":"https://github.com/mjibson/appstats/pull/19","diff_url":"https://github.com/mjibson/appstats/pull/19.diff","patch_url":"https://github.com/mjibson/appstats/pull/19.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/mjibson/appstats/issues/comments/145336664","html_url":"https://github.com/mjibson/appstats/pull/19#issuecomment-145336664","issue_url":"https://api.github.com/repos/mjibson/appstats/issues/19","id":145336664,"user":{"login":"flowlo","id":542154,"avatar_url":"https://avatars.githubusercontent.com/u/542154?v=3","gravatar_id":"","url":"https://api.github.com/users/flowlo","html_url":"https://github.com/flowlo","followers_url":"https://api.github.com/users/flowlo/followers","following_url":"https://api.github.com/users/flowlo/following{/other_user}","gists_url":"https://api.github.com/users/flowlo/gists{/gist_id}","starred_url":"https://api.github.com/users/flowlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowlo/subscriptions","organizations_url":"https://api.github.com/users/flowlo/orgs","repos_url":"https://api.github.com/users/flowlo/repos","events_url":"https://api.github.com/users/flowlo/events{/privacy}","received_events_url":"https://api.github.com/users/flowlo/received_events","type":"User","site_admin":false},"created_at":"2015-10-04T10:59:06Z","updated_at":"2015-10-04T10:59:06Z","body":"[The old code panics on my stack traces](http://play.golang.org/p/yeof8YfM2f), that's why I changed it in the first place. Now that it works with those traces, I proposed to switch on the Go version at build time to make everyone happy. (BTW, you'll see a stack traces that correlates with what I posted there.)\r\n\r\nThe stack trace I posted comes from [`panic()`, which calls `systemstack()`](https://golang.org/src/runtime/panic.go), just like [`runtime.Stack`](https://golang.org/pkg/runtime#Stack) (the successor of `runtime/debug.Stack`) [does](https://golang.org/src/runtime/mprof.go?s=15278:15314#L552).\r\n\r\n[`runtime/debug.Stack`](https://golang.org/pkg/runtime/debug/#Stack) is deprecated. And with you mentioning it, I just found that [`appstats` callls it](https://github.com/mjibson/appstats/blob/0542d5f0e87ea3a8fa4174322b9532f5d04f9fa8/appstats.go#L107). So it might be worth trying to replace the call to `runtime.Stack`. This may solve our problems."}}