{"action":"created","comment":{"url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/comments/30171060","id":30171060,"diff_hunk":"@@ -89,17 +131,74 @@ typedef UIImage *(^XExtensionItemThumbnailProvidingBlock)(CGSize suggestedSize,\n @property (nonatomic) XExtensionItemReferrer *referrer;\n \n /**\n- An optional dictionary of keys and values. Individual applications can add advertise whatever custom parameters they\n- support, and extension developers can add values for those parameters in this dictionary.\n+ A block that will be called with the suggested size for the thumbnail image, in points, and the activity type chosen by \n+ the user. It should return an image using the appropriate scale for the screen. Images provided at the suggested size \n+ will result in the best experience.\n+ */\n+@property (nonatomic, copy) XExtensionItemThumbnailProvidingBlock thumbnailProvider;\n+\n+/**\n+ Add parameters from a dictionary-serializable custom parameters object.\n+ \n+ @param dictionarySerializable A custom parameters object.\n+ */\n+- (void)addCustomParameters:(id <XExtensionItemCustomParameters>)dictionarySerializable;\n+\n+/**\n+ An optional dictionary of keys and values.\n+ \n+ @discussion Please look at `addCustomParameters` and the `XExtensionItemCustomParameters` protocol before considering\n+ populating this dictionary directly.\n  \n- Custom user info keys should *not* start with `x-extension-item`, as those will be used internally by this library.\n+ Individual applications can add advertise the custom parameter keys that they support, and extension developers can add \n+ values for those parameters to this dictionary, but a better solution is for third-party developers to create an object \n+ that conforms to `XExtensionItemCustomParameters`, and open a pull request to add it to the `XExtensionItem` \n+ repository. See `XExtensionItemTumblrParameters` for an example of this.\n+ \n+ Custom user info keys should *not* start with `x-extension-item`, as those are used internally by this library. Custom \n+ user info keys are also at risk of colliding with keys found in the dictionary representations of custom parameters ","path":"Pod/Classes/XExtensionItem.h","position":131,"original_position":131,"commit_id":"68705f4a3fa0cabe65537ebe6756284dc873a51b","original_commit_id":"68705f4a3fa0cabe65537ebe6756284dc873a51b","user":{"login":"AriX","id":398952,"avatar_url":"https://avatars.githubusercontent.com/u/398952?v=3","gravatar_id":"","url":"https://api.github.com/users/AriX","html_url":"https://github.com/AriX","followers_url":"https://api.github.com/users/AriX/followers","following_url":"https://api.github.com/users/AriX/following{/other_user}","gists_url":"https://api.github.com/users/AriX/gists{/gist_id}","starred_url":"https://api.github.com/users/AriX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriX/subscriptions","organizations_url":"https://api.github.com/users/AriX/orgs","repos_url":"https://api.github.com/users/AriX/repos","events_url":"https://api.github.com/users/AriX/events{/privacy}","received_events_url":"https://api.github.com/users/AriX/received_events","type":"User","site_admin":false},"body":"This doesn't bother me too much and I'm not super worried about collisions, especially if you just encourage people to prefix with their app name or something (and since we are encouraging people to add their custom objects to the `XExtensionItem` repo via pull request). Whatever you're comfortable with is fine with me.","created_at":"2015-05-12T19:29:58Z","updated_at":"2015-05-12T19:29:58Z","html_url":"https://github.com/AriX/XExtensionItem/pull/1#discussion_r30171060","pull_request_url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/comments/30171060"},"html":{"href":"https://github.com/AriX/XExtensionItem/pull/1#discussion_r30171060"},"pull_request":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1","id":35237776,"html_url":"https://github.com/AriX/XExtensionItem/pull/1","diff_url":"https://github.com/AriX/XExtensionItem/pull/1.diff","patch_url":"https://github.com/AriX/XExtensionItem/pull/1.patch","issue_url":"https://api.github.com/repos/AriX/XExtensionItem/issues/1","number":1,"state":"open","locked":false,"title":"Bunch of cleanup work on top of Ari’s `XExtensionItemSource` refactor","user":{"login":"irace","id":399560,"avatar_url":"https://avatars.githubusercontent.com/u/399560?v=3","gravatar_id":"","url":"https://api.github.com/users/irace","html_url":"https://github.com/irace","followers_url":"https://api.github.com/users/irace/followers","following_url":"https://api.github.com/users/irace/following{/other_user}","gists_url":"https://api.github.com/users/irace/gists{/gist_id}","starred_url":"https://api.github.com/users/irace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irace/subscriptions","organizations_url":"https://api.github.com/users/irace/orgs","repos_url":"https://api.github.com/users/irace/repos","events_url":"https://api.github.com/users/irace/events{/privacy}","received_events_url":"https://api.github.com/users/irace/received_events","type":"User","site_admin":false},"body":"Still very much a WIP","created_at":"2015-05-12T15:21:35Z","updated_at":"2015-05-12T19:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4f666a87957d9c73ea6a0297a54cb344bd053a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AriX/XExtensionItem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AriX/XExtensionItem/issues/1/comments","statuses_url":"https://api.github.com/repos/AriX/XExtensionItem/statuses/68705f4a3fa0cabe65537ebe6756284dc873a51b","head":{"label":"irace:master","ref":"master","sha":"68705f4a3fa0cabe65537ebe6756284dc873a51b","user":{"login":"irace","id":399560,"avatar_url":"https://avatars.githubusercontent.com/u/399560?v=3","gravatar_id":"","url":"https://api.github.com/users/irace","html_url":"https://github.com/irace","followers_url":"https://api.github.com/users/irace/followers","following_url":"https://api.github.com/users/irace/following{/other_user}","gists_url":"https://api.github.com/users/irace/gists{/gist_id}","starred_url":"https://api.github.com/users/irace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irace/subscriptions","organizations_url":"https://api.github.com/users/irace/orgs","repos_url":"https://api.github.com/users/irace/repos","events_url":"https://api.github.com/users/irace/events{/privacy}","received_events_url":"https://api.github.com/users/irace/received_events","type":"User","site_admin":false},"repo":{"id":35491805,"name":"XExtensionItem","full_name":"irace/XExtensionItem","owner":{"login":"irace","id":399560,"avatar_url":"https://avatars.githubusercontent.com/u/399560?v=3","gravatar_id":"","url":"https://api.github.com/users/irace","html_url":"https://github.com/irace","followers_url":"https://api.github.com/users/irace/followers","following_url":"https://api.github.com/users/irace/following{/other_user}","gists_url":"https://api.github.com/users/irace/gists{/gist_id}","starred_url":"https://api.github.com/users/irace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irace/subscriptions","organizations_url":"https://api.github.com/users/irace/orgs","repos_url":"https://api.github.com/users/irace/repos","events_url":"https://api.github.com/users/irace/events{/privacy}","received_events_url":"https://api.github.com/users/irace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irace/XExtensionItem","description":"Easier sharing of structured data between iOS applications and share extensions","fork":true,"url":"https://api.github.com/repos/irace/XExtensionItem","forks_url":"https://api.github.com/repos/irace/XExtensionItem/forks","keys_url":"https://api.github.com/repos/irace/XExtensionItem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irace/XExtensionItem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irace/XExtensionItem/teams","hooks_url":"https://api.github.com/repos/irace/XExtensionItem/hooks","issue_events_url":"https://api.github.com/repos/irace/XExtensionItem/issues/events{/number}","events_url":"https://api.github.com/repos/irace/XExtensionItem/events","assignees_url":"https://api.github.com/repos/irace/XExtensionItem/assignees{/user}","branches_url":"https://api.github.com/repos/irace/XExtensionItem/branches{/branch}","tags_url":"https://api.github.com/repos/irace/XExtensionItem/tags","blobs_url":"https://api.github.com/repos/irace/XExtensionItem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irace/XExtensionItem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irace/XExtensionItem/git/refs{/sha}","trees_url":"https://api.github.com/repos/irace/XExtensionItem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irace/XExtensionItem/statuses/{sha}","languages_url":"https://api.github.com/repos/irace/XExtensionItem/languages","stargazers_url":"https://api.github.com/repos/irace/XExtensionItem/stargazers","contributors_url":"https://api.github.com/repos/irace/XExtensionItem/contributors","subscribers_url":"https://api.github.com/repos/irace/XExtensionItem/subscribers","subscription_url":"https://api.github.com/repos/irace/XExtensionItem/subscription","commits_url":"https://api.github.com/repos/irace/XExtensionItem/commits{/sha}","git_commits_url":"https://api.github.com/repos/irace/XExtensionItem/git/commits{/sha}","comments_url":"https://api.github.com/repos/irace/XExtensionItem/comments{/number}","issue_comment_url":"https://api.github.com/repos/irace/XExtensionItem/issues/comments{/number}","contents_url":"https://api.github.com/repos/irace/XExtensionItem/contents/{+path}","compare_url":"https://api.github.com/repos/irace/XExtensionItem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irace/XExtensionItem/merges","archive_url":"https://api.github.com/repos/irace/XExtensionItem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irace/XExtensionItem/downloads","issues_url":"https://api.github.com/repos/irace/XExtensionItem/issues{/number}","pulls_url":"https://api.github.com/repos/irace/XExtensionItem/pulls{/number}","milestones_url":"https://api.github.com/repos/irace/XExtensionItem/milestones{/number}","notifications_url":"https://api.github.com/repos/irace/XExtensionItem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irace/XExtensionItem/labels{/name}","releases_url":"https://api.github.com/repos/irace/XExtensionItem/releases{/id}","created_at":"2015-05-12T14:06:58Z","updated_at":"2015-05-12T14:06:59Z","pushed_at":"2015-05-12T19:21:46Z","git_url":"git://github.com/irace/XExtensionItem.git","ssh_url":"git@github.com:irace/XExtensionItem.git","clone_url":"https://github.com/irace/XExtensionItem.git","svn_url":"https://github.com/irace/XExtensionItem","homepage":"","size":928,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AriX:master","ref":"master","sha":"d23a480df95d76f1d063765b3ea82e914de3f2d0","user":{"login":"AriX","id":398952,"avatar_url":"https://avatars.githubusercontent.com/u/398952?v=3","gravatar_id":"","url":"https://api.github.com/users/AriX","html_url":"https://github.com/AriX","followers_url":"https://api.github.com/users/AriX/followers","following_url":"https://api.github.com/users/AriX/following{/other_user}","gists_url":"https://api.github.com/users/AriX/gists{/gist_id}","starred_url":"https://api.github.com/users/AriX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriX/subscriptions","organizations_url":"https://api.github.com/users/AriX/orgs","repos_url":"https://api.github.com/users/AriX/repos","events_url":"https://api.github.com/users/AriX/events{/privacy}","received_events_url":"https://api.github.com/users/AriX/received_events","type":"User","site_admin":false},"repo":{"id":35182575,"name":"XExtensionItem","full_name":"AriX/XExtensionItem","owner":{"login":"AriX","id":398952,"avatar_url":"https://avatars.githubusercontent.com/u/398952?v=3","gravatar_id":"","url":"https://api.github.com/users/AriX","html_url":"https://github.com/AriX","followers_url":"https://api.github.com/users/AriX/followers","following_url":"https://api.github.com/users/AriX/following{/other_user}","gists_url":"https://api.github.com/users/AriX/gists{/gist_id}","starred_url":"https://api.github.com/users/AriX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AriX/subscriptions","organizations_url":"https://api.github.com/users/AriX/orgs","repos_url":"https://api.github.com/users/AriX/repos","events_url":"https://api.github.com/users/AriX/events{/privacy}","received_events_url":"https://api.github.com/users/AriX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AriX/XExtensionItem","description":"Easier sharing of structured data between iOS applications and share extensions","fork":true,"url":"https://api.github.com/repos/AriX/XExtensionItem","forks_url":"https://api.github.com/repos/AriX/XExtensionItem/forks","keys_url":"https://api.github.com/repos/AriX/XExtensionItem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AriX/XExtensionItem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AriX/XExtensionItem/teams","hooks_url":"https://api.github.com/repos/AriX/XExtensionItem/hooks","issue_events_url":"https://api.github.com/repos/AriX/XExtensionItem/issues/events{/number}","events_url":"https://api.github.com/repos/AriX/XExtensionItem/events","assignees_url":"https://api.github.com/repos/AriX/XExtensionItem/assignees{/user}","branches_url":"https://api.github.com/repos/AriX/XExtensionItem/branches{/branch}","tags_url":"https://api.github.com/repos/AriX/XExtensionItem/tags","blobs_url":"https://api.github.com/repos/AriX/XExtensionItem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AriX/XExtensionItem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AriX/XExtensionItem/git/refs{/sha}","trees_url":"https://api.github.com/repos/AriX/XExtensionItem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AriX/XExtensionItem/statuses/{sha}","languages_url":"https://api.github.com/repos/AriX/XExtensionItem/languages","stargazers_url":"https://api.github.com/repos/AriX/XExtensionItem/stargazers","contributors_url":"https://api.github.com/repos/AriX/XExtensionItem/contributors","subscribers_url":"https://api.github.com/repos/AriX/XExtensionItem/subscribers","subscription_url":"https://api.github.com/repos/AriX/XExtensionItem/subscription","commits_url":"https://api.github.com/repos/AriX/XExtensionItem/commits{/sha}","git_commits_url":"https://api.github.com/repos/AriX/XExtensionItem/git/commits{/sha}","comments_url":"https://api.github.com/repos/AriX/XExtensionItem/comments{/number}","issue_comment_url":"https://api.github.com/repos/AriX/XExtensionItem/issues/comments{/number}","contents_url":"https://api.github.com/repos/AriX/XExtensionItem/contents/{+path}","compare_url":"https://api.github.com/repos/AriX/XExtensionItem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AriX/XExtensionItem/merges","archive_url":"https://api.github.com/repos/AriX/XExtensionItem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AriX/XExtensionItem/downloads","issues_url":"https://api.github.com/repos/AriX/XExtensionItem/issues{/number}","pulls_url":"https://api.github.com/repos/AriX/XExtensionItem/pulls{/number}","milestones_url":"https://api.github.com/repos/AriX/XExtensionItem/milestones{/number}","notifications_url":"https://api.github.com/repos/AriX/XExtensionItem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AriX/XExtensionItem/labels{/name}","releases_url":"https://api.github.com/repos/AriX/XExtensionItem/releases{/id}","created_at":"2015-05-06T20:58:11Z","updated_at":"2015-05-08T00:38:11Z","pushed_at":"2015-05-12T19:21:47Z","git_url":"git://github.com/AriX/XExtensionItem.git","ssh_url":"git@github.com:AriX/XExtensionItem.git","clone_url":"https://github.com/AriX/XExtensionItem.git","svn_url":"https://github.com/AriX/XExtensionItem","homepage":"","size":928,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1"},"html":{"href":"https://github.com/AriX/XExtensionItem/pull/1"},"issue":{"href":"https://api.github.com/repos/AriX/XExtensionItem/issues/1"},"comments":{"href":"https://api.github.com/repos/AriX/XExtensionItem/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AriX/XExtensionItem/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AriX/XExtensionItem/statuses/68705f4a3fa0cabe65537ebe6756284dc873a51b"}}}}