{"action":"created","comment":{"url":"https://api.github.com/repos/rackt/redux/pulls/comments/44657770","id":44657770,"diff_hunk":"@@ -68,7 +68,7 @@ export default function createStore(reducer, initialState) {\n \n       isSubscribed = false\n       var index = listeners.indexOf(listener)\n-      listeners.splice(index, 1)\n+      listeners = [ ...listeners.slice(0, index), ...listeners.slice(index + 1) ]","path":"src/createStore.js","position":14,"original_position":14,"commit_id":"b8862d2f5378c0e6aa97f70954de3b5a623e336a","original_commit_id":"b8862d2f5378c0e6aa97f70954de3b5a623e336a","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"Do you mind splitting this to two lines please, and then squashing your commits? Thanks.","created_at":"2015-11-12T13:45:37Z","updated_at":"2015-11-12T13:45:37Z","html_url":"https://github.com/rackt/redux/pull/1019#discussion_r44657770","pull_request_url":"https://api.github.com/repos/rackt/redux/pulls/1019","_links":{"self":{"href":"https://api.github.com/repos/rackt/redux/pulls/comments/44657770"},"html":{"href":"https://github.com/rackt/redux/pull/1019#discussion_r44657770"},"pull_request":{"href":"https://api.github.com/repos/rackt/redux/pulls/1019"}}},"pull_request":{"url":"https://api.github.com/repos/rackt/redux/pulls/1019","id":50156476,"html_url":"https://github.com/rackt/redux/pull/1019","diff_url":"https://github.com/rackt/redux/pull/1019.diff","patch_url":"https://github.com/rackt/redux/pull/1019.patch","issue_url":"https://api.github.com/repos/rackt/redux/issues/1019","number":1019,"state":"open","locked":false,"title":"Clone listeners at subscription / unsubscription","user":{"login":"rpominov","id":825702,"avatar_url":"https://avatars.githubusercontent.com/u/825702?v=3","gravatar_id":"","url":"https://api.github.com/users/rpominov","html_url":"https://github.com/rpominov","followers_url":"https://api.github.com/users/rpominov/followers","following_url":"https://api.github.com/users/rpominov/following{/other_user}","gists_url":"https://api.github.com/users/rpominov/gists{/gist_id}","starred_url":"https://api.github.com/users/rpominov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpominov/subscriptions","organizations_url":"https://api.github.com/users/rpominov/orgs","repos_url":"https://api.github.com/users/rpominov/repos","events_url":"https://api.github.com/users/rpominov/events{/privacy}","received_events_url":"https://api.github.com/users/rpominov/received_events","type":"User","site_admin":false},"body":"This should improve performance a bit because dispatch is more frequent operation than subscription / unsubscription.","created_at":"2015-11-09T18:07:27Z","updated_at":"2015-11-12T13:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76bca8d755e82b7770bbc90e8d0a0c5eb681a7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackt/redux/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/rackt/redux/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/rackt/redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackt/redux/issues/1019/comments","statuses_url":"https://api.github.com/repos/rackt/redux/statuses/b8862d2f5378c0e6aa97f70954de3b5a623e336a","head":{"label":"rpominov:immutable-listeners","ref":"immutable-listeners","sha":"b8862d2f5378c0e6aa97f70954de3b5a623e336a","user":{"login":"rpominov","id":825702,"avatar_url":"https://avatars.githubusercontent.com/u/825702?v=3","gravatar_id":"","url":"https://api.github.com/users/rpominov","html_url":"https://github.com/rpominov","followers_url":"https://api.github.com/users/rpominov/followers","following_url":"https://api.github.com/users/rpominov/following{/other_user}","gists_url":"https://api.github.com/users/rpominov/gists{/gist_id}","starred_url":"https://api.github.com/users/rpominov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpominov/subscriptions","organizations_url":"https://api.github.com/users/rpominov/orgs","repos_url":"https://api.github.com/users/rpominov/repos","events_url":"https://api.github.com/users/rpominov/events{/privacy}","received_events_url":"https://api.github.com/users/rpominov/received_events","type":"User","site_admin":false},"repo":{"id":45855140,"name":"redux","full_name":"rpominov/redux","owner":{"login":"rpominov","id":825702,"avatar_url":"https://avatars.githubusercontent.com/u/825702?v=3","gravatar_id":"","url":"https://api.github.com/users/rpominov","html_url":"https://github.com/rpominov","followers_url":"https://api.github.com/users/rpominov/followers","following_url":"https://api.github.com/users/rpominov/following{/other_user}","gists_url":"https://api.github.com/users/rpominov/gists{/gist_id}","starred_url":"https://api.github.com/users/rpominov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpominov/subscriptions","organizations_url":"https://api.github.com/users/rpominov/orgs","repos_url":"https://api.github.com/users/rpominov/repos","events_url":"https://api.github.com/users/rpominov/events{/privacy}","received_events_url":"https://api.github.com/users/rpominov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpominov/redux","description":"Predictable state container for JavaScript apps","fork":true,"url":"https://api.github.com/repos/rpominov/redux","forks_url":"https://api.github.com/repos/rpominov/redux/forks","keys_url":"https://api.github.com/repos/rpominov/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpominov/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpominov/redux/teams","hooks_url":"https://api.github.com/repos/rpominov/redux/hooks","issue_events_url":"https://api.github.com/repos/rpominov/redux/issues/events{/number}","events_url":"https://api.github.com/repos/rpominov/redux/events","assignees_url":"https://api.github.com/repos/rpominov/redux/assignees{/user}","branches_url":"https://api.github.com/repos/rpominov/redux/branches{/branch}","tags_url":"https://api.github.com/repos/rpominov/redux/tags","blobs_url":"https://api.github.com/repos/rpominov/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpominov/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpominov/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpominov/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpominov/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/rpominov/redux/languages","stargazers_url":"https://api.github.com/repos/rpominov/redux/stargazers","contributors_url":"https://api.github.com/repos/rpominov/redux/contributors","subscribers_url":"https://api.github.com/repos/rpominov/redux/subscribers","subscription_url":"https://api.github.com/repos/rpominov/redux/subscription","commits_url":"https://api.github.com/repos/rpominov/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpominov/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpominov/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpominov/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpominov/redux/contents/{+path}","compare_url":"https://api.github.com/repos/rpominov/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpominov/redux/merges","archive_url":"https://api.github.com/repos/rpominov/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpominov/redux/downloads","issues_url":"https://api.github.com/repos/rpominov/redux/issues{/number}","pulls_url":"https://api.github.com/repos/rpominov/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/rpominov/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/rpominov/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpominov/redux/labels{/name}","releases_url":"https://api.github.com/repos/rpominov/redux/releases{/id}","created_at":"2015-11-09T17:39:43Z","updated_at":"2015-11-09T17:39:45Z","pushed_at":"2015-11-09T20:25:06Z","git_url":"git://github.com/rpominov/redux.git","ssh_url":"git@github.com:rpominov/redux.git","clone_url":"https://github.com/rpominov/redux.git","svn_url":"https://github.com/rpominov/redux","homepage":"http://redux.js.org","size":9648,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackt:master","ref":"master","sha":"3b6f3edbaef910b91dfa998d1abe3c0047103866","user":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"repo":{"id":36535156,"name":"redux","full_name":"rackt/redux","owner":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackt/redux","description":"Predictable state container for JavaScript apps","fork":false,"url":"https://api.github.com/repos/rackt/redux","forks_url":"https://api.github.com/repos/rackt/redux/forks","keys_url":"https://api.github.com/repos/rackt/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackt/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackt/redux/teams","hooks_url":"https://api.github.com/repos/rackt/redux/hooks","issue_events_url":"https://api.github.com/repos/rackt/redux/issues/events{/number}","events_url":"https://api.github.com/repos/rackt/redux/events","assignees_url":"https://api.github.com/repos/rackt/redux/assignees{/user}","branches_url":"https://api.github.com/repos/rackt/redux/branches{/branch}","tags_url":"https://api.github.com/repos/rackt/redux/tags","blobs_url":"https://api.github.com/repos/rackt/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackt/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackt/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackt/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackt/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/rackt/redux/languages","stargazers_url":"https://api.github.com/repos/rackt/redux/stargazers","contributors_url":"https://api.github.com/repos/rackt/redux/contributors","subscribers_url":"https://api.github.com/repos/rackt/redux/subscribers","subscription_url":"https://api.github.com/repos/rackt/redux/subscription","commits_url":"https://api.github.com/repos/rackt/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackt/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackt/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackt/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackt/redux/contents/{+path}","compare_url":"https://api.github.com/repos/rackt/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackt/redux/merges","archive_url":"https://api.github.com/repos/rackt/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackt/redux/downloads","issues_url":"https://api.github.com/repos/rackt/redux/issues{/number}","pulls_url":"https://api.github.com/repos/rackt/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/rackt/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/rackt/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackt/redux/labels{/name}","releases_url":"https://api.github.com/repos/rackt/redux/releases{/id}","created_at":"2015-05-29T23:53:15Z","updated_at":"2015-11-12T13:42:41Z","pushed_at":"2015-11-09T20:25:06Z","git_url":"git://github.com/rackt/redux.git","ssh_url":"git@github.com:rackt/redux.git","clone_url":"https://github.com/rackt/redux.git","svn_url":"https://github.com/rackt/redux","homepage":"http://redux.js.org","size":9648,"stargazers_count":8976,"watchers_count":8976,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":851,"mirror_url":null,"open_issues_count":30,"forks":851,"open_issues":30,"watchers":8976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackt/redux/pulls/1019"},"html":{"href":"https://github.com/rackt/redux/pull/1019"},"issue":{"href":"https://api.github.com/repos/rackt/redux/issues/1019"},"comments":{"href":"https://api.github.com/repos/rackt/redux/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/rackt/redux/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/rackt/redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackt/redux/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/rackt/redux/statuses/b8862d2f5378c0e6aa97f70954de3b5a623e336a"}}}}