{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/34847538","id":34847538,"diff_hunk":"@@ -538,6 +544,29 @@ private bool ResolutionSucceeded(IEnumerable<RestoreTargetGraph> graphs)\n                         correctedPackageName: library.Name);\n \n                     target.Libraries.Add(targetLibrary);\n+\n+                    // Log warnings if the target library used the fallback framework\n+                    if (warnForImportsOnGraph && !librariesWithWarnings.Contains(library))","path":"src/NuGet.Commands/RestoreCommand.cs","position":26,"original_position":26,"commit_id":"8f8c47b623fdb01f915e343cfba4a918134eb474","original_commit_id":"8f8c47b623fdb01f915e343cfba4a918134eb474","user":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars.githubusercontent.com/u/174281?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"body":"Feel free to create a follow up item for this. Seem super low pri.","created_at":"2015-07-16T22:59:02Z","updated_at":"2015-07-16T22:59:02Z","html_url":"https://github.com/NuGet/NuGet3/pull/88#discussion_r34847538","pull_request_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments/34847538"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/88#discussion_r34847538"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet3/pulls/88","id":40080076,"html_url":"https://github.com/NuGet/NuGet3/pull/88","diff_url":"https://github.com/NuGet/NuGet3/pull/88.diff","patch_url":"https://github.com/NuGet/NuGet3/pull/88.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet3/issues/88","number":88,"state":"open","locked":false,"title":"Imports support for fallback frameworks","user":{"login":"emgarten","id":6381138,"avatar_url":"https://avatars.githubusercontent.com/u/6381138?v=3","gravatar_id":"","url":"https://api.github.com/users/emgarten","html_url":"https://github.com/emgarten","followers_url":"https://api.github.com/users/emgarten/followers","following_url":"https://api.github.com/users/emgarten/following{/other_user}","gists_url":"https://api.github.com/users/emgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/emgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emgarten/subscriptions","organizations_url":"https://api.github.com/users/emgarten/orgs","repos_url":"https://api.github.com/users/emgarten/repos","events_url":"https://api.github.com/users/emgarten/events{/privacy}","received_events_url":"https://api.github.com/users/emgarten/received_events","type":"User","site_admin":false},"body":"This change adds support for fallback frameworks under the \"imports\" property.\r\n\r\nThe additional framework is passed around a FallbackFramework which extends NuGetFramework. GetNearest checks for this type and handles it at the lowest level. This makes the change much less invasive than changing everything to take multiple frameworks.\r\n\r\nWarnings are displayed if the fallback framework was used, this is done by building the target library using the normal fallback framework, and using the project framework only. If there are differences the warning is logged once per library.\r\n\r\n```json\r\n                \"frameworks\": {\r\n                    \"dotnet\": {\r\n                        \"imports\": \"portable-net452+win81\",\r\n                        \"warn\"\": false\r\n                    }\r\n```","created_at":"2015-07-15T23:14:57Z","updated_at":"2015-07-16T22:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbd353f83ec4a45462c6e776965d759df9d36230","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/88/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/88/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/issues/88/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/8f8c47b623fdb01f915e343cfba4a918134eb474","head":{"label":"NuGet:dev-imports","ref":"dev-imports","sha":"8f8c47b623fdb01f915e343cfba4a918134eb474","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-07-16T11:33:52Z","pushed_at":"2015-07-16T22:39:30Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":7529,"stargazers_count":26,"watchers_count":26,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":26,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"eddb7f49b515ac892dd1c9cefcb4830b755f7f47","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":31300058,"name":"NuGet3","full_name":"NuGet/NuGet3","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet3","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet3","forks_url":"https://api.github.com/repos/NuGet/NuGet3/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet3/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet3/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet3/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet3/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet3/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet3/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet3/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet3/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet3/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet3/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet3/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet3/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet3/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet3/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet3/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet3/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet3/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet3/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet3/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet3/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet3/releases{/id}","created_at":"2015-02-25T06:15:00Z","updated_at":"2015-07-16T11:33:52Z","pushed_at":"2015-07-16T22:39:30Z","git_url":"git://github.com/NuGet/NuGet3.git","ssh_url":"git@github.com:NuGet/NuGet3.git","clone_url":"https://github.com/NuGet/NuGet3.git","svn_url":"https://github.com/NuGet/NuGet3","homepage":null,"size":7529,"stargazers_count":26,"watchers_count":26,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":26,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/88"},"html":{"href":"https://github.com/NuGet/NuGet3/pull/88"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/88"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet3/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet3/statuses/8f8c47b623fdb01f915e343cfba4a918134eb474"}}}}