{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/30485517","id":30485517,"diff_hunk":"@@ -6,10 +6,17 @@\n from sklearn.base import BaseEstimator, ClassifierMixin\n from sklearn.utils.testing import assert_raises_regex, assert_true\n from sklearn.utils.estimator_checks import check_estimator\n+from sklearn.utils.estimator_checks import check_estimators_unfitted\n from sklearn.linear_model import LogisticRegression\n from sklearn.utils.validation import check_X_y, check_array\n \n \n+class CorrectNotFittedError(ValueError):\n+    \"\"\"Exception class to raise if estimator is used before fitting.\n+    Like NotFittedError, it inherits from ValueError, but not from","path":"sklearn/utils/tests/test_estimator_checks.py","position":11,"original_position":11,"commit_id":"13904bbc4dca13b1b238eccb6bf3f6f6af4e1d9e","original_commit_id":"13904bbc4dca13b1b238eccb6bf3f6f6af4e1d9e","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"Please add a blank line before this line to follow PEP 257.","created_at":"2015-05-18T07:20:12Z","updated_at":"2015-05-18T07:20:12Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4716#discussion_r30485517","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/30485517"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4716#discussion_r30485517"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716","id":35305357,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/4716","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4716.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4716.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4716","number":4716,"state":"open","locked":false,"title":"[WIP] check that unfitted estimators raise ValueError","user":{"login":"TomDLT","id":11065596,"avatar_url":"https://avatars.githubusercontent.com/u/11065596?v=3","gravatar_id":"","url":"https://api.github.com/users/TomDLT","html_url":"https://github.com/TomDLT","followers_url":"https://api.github.com/users/TomDLT/followers","following_url":"https://api.github.com/users/TomDLT/following{/other_user}","gists_url":"https://api.github.com/users/TomDLT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomDLT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomDLT/subscriptions","organizations_url":"https://api.github.com/users/TomDLT/orgs","repos_url":"https://api.github.com/users/TomDLT/repos","events_url":"https://api.github.com/users/TomDLT/events{/privacy}","received_events_url":"https://api.github.com/users/TomDLT/received_events","type":"User","site_admin":false},"body":">Issue : check_estimator requires raising NotFittedError #4661\r\n\r\nPlease tell me what you think","created_at":"2015-05-13T08:46:21Z","updated_at":"2015-05-18T07:20:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0733fd648fd16c59a4359b5996eaaa242b4d230f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4716/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/13904bbc4dca13b1b238eccb6bf3f6f6af4e1d9e","head":{"label":"TomDLT:notfitted","ref":"notfitted","sha":"13904bbc4dca13b1b238eccb6bf3f6f6af4e1d9e","user":{"login":"TomDLT","id":11065596,"avatar_url":"https://avatars.githubusercontent.com/u/11065596?v=3","gravatar_id":"","url":"https://api.github.com/users/TomDLT","html_url":"https://github.com/TomDLT","followers_url":"https://api.github.com/users/TomDLT/followers","following_url":"https://api.github.com/users/TomDLT/following{/other_user}","gists_url":"https://api.github.com/users/TomDLT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomDLT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomDLT/subscriptions","organizations_url":"https://api.github.com/users/TomDLT/orgs","repos_url":"https://api.github.com/users/TomDLT/repos","events_url":"https://api.github.com/users/TomDLT/events{/privacy}","received_events_url":"https://api.github.com/users/TomDLT/received_events","type":"User","site_admin":false},"repo":{"id":34376788,"name":"scikit-learn","full_name":"TomDLT/scikit-learn","owner":{"login":"TomDLT","id":11065596,"avatar_url":"https://avatars.githubusercontent.com/u/11065596?v=3","gravatar_id":"","url":"https://api.github.com/users/TomDLT","html_url":"https://github.com/TomDLT","followers_url":"https://api.github.com/users/TomDLT/followers","following_url":"https://api.github.com/users/TomDLT/following{/other_user}","gists_url":"https://api.github.com/users/TomDLT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomDLT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomDLT/subscriptions","organizations_url":"https://api.github.com/users/TomDLT/orgs","repos_url":"https://api.github.com/users/TomDLT/repos","events_url":"https://api.github.com/users/TomDLT/events{/privacy}","received_events_url":"https://api.github.com/users/TomDLT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomDLT/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/TomDLT/scikit-learn","forks_url":"https://api.github.com/repos/TomDLT/scikit-learn/forks","keys_url":"https://api.github.com/repos/TomDLT/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomDLT/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomDLT/scikit-learn/teams","hooks_url":"https://api.github.com/repos/TomDLT/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/TomDLT/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/TomDLT/scikit-learn/events","assignees_url":"https://api.github.com/repos/TomDLT/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/TomDLT/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/TomDLT/scikit-learn/tags","blobs_url":"https://api.github.com/repos/TomDLT/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomDLT/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomDLT/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomDLT/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomDLT/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/TomDLT/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/TomDLT/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/TomDLT/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/TomDLT/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/TomDLT/scikit-learn/subscription","commits_url":"https://api.github.com/repos/TomDLT/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomDLT/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomDLT/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomDLT/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomDLT/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/TomDLT/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomDLT/scikit-learn/merges","archive_url":"https://api.github.com/repos/TomDLT/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomDLT/scikit-learn/downloads","issues_url":"https://api.github.com/repos/TomDLT/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/TomDLT/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/TomDLT/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/TomDLT/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomDLT/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/TomDLT/scikit-learn/releases{/id}","created_at":"2015-04-22T07:53:08Z","updated_at":"2015-05-12T12:17:35Z","pushed_at":"2015-05-13T11:08:04Z","git_url":"git://github.com/TomDLT/scikit-learn.git","ssh_url":"git@github.com:TomDLT/scikit-learn.git","clone_url":"https://github.com/TomDLT/scikit-learn.git","svn_url":"https://github.com/TomDLT/scikit-learn","homepage":"http://scikit-learn.org","size":62103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"8f3ef2aa901ada25ed4b5ee5ff0205eec538165b","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-05-18T05:53:04Z","pushed_at":"2015-05-17T19:37:07Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":125876,"stargazers_count":6022,"watchers_count":6022,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3600,"mirror_url":null,"open_issues_count":660,"forks":3600,"open_issues":660,"watchers":6022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4716"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4716"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4716/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4716/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/13904bbc4dca13b1b238eccb6bf3f6f6af4e1d9e"}}}}