{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/packaging/issues/30","labels_url":"https://api.github.com/repos/jenkinsci/packaging/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/packaging/issues/30/comments","events_url":"https://api.github.com/repos/jenkinsci/packaging/issues/30/events","html_url":"https://github.com/jenkinsci/packaging/pull/30","id":114286823,"number":30,"title":"Incorrect branding vars","user":{"login":"jtnord","id":494726,"avatar_url":"https://avatars.githubusercontent.com/u/494726?v=3","gravatar_id":"","url":"https://api.github.com/users/jtnord","html_url":"https://github.com/jtnord","followers_url":"https://api.github.com/users/jtnord/followers","following_url":"https://api.github.com/users/jtnord/following{/other_user}","gists_url":"https://api.github.com/users/jtnord/gists{/gist_id}","starred_url":"https://api.github.com/users/jtnord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtnord/subscriptions","organizations_url":"https://api.github.com/users/jtnord/orgs","repos_url":"https://api.github.com/users/jtnord/repos","events_url":"https://api.github.com/users/jtnord/events{/privacy}","received_events_url":"https://api.github.com/users/jtnord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-30T15:01:32Z","updated_at":"2015-10-30T16:07:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/packaging/pulls/30","html_url":"https://github.com/jenkinsci/packaging/pull/30","diff_url":"https://github.com/jenkinsci/packaging/pull/30.diff","patch_url":"https://github.com/jenkinsci/packaging/pull/30.patch"},"body":"@reviewbybees \r\n\r\n@@WAR@@ and @@HOME@@ are not branding variables - and so when using a more strict branding approach the build will fail.\r\nAs they are not branding variables they should not look and smell like branding variables.\r\n\r\nLong term I question the sanity of doing this - as the paths being replaced can be known and created from the branding variables anyway (unless someone redefines _usr or _var macros in RPM - but that would be a WAAT...)"},"comment":{"url":"https://api.github.com/repos/jenkinsci/packaging/issues/comments/152567479","html_url":"https://github.com/jenkinsci/packaging/pull/30#issuecomment-152567479","issue_url":"https://api.github.com/repos/jenkinsci/packaging/issues/30","id":152567479,"user":{"login":"reviewbybees","id":10512980,"avatar_url":"https://avatars.githubusercontent.com/u/10512980?v=3","gravatar_id":"","url":"https://api.github.com/users/reviewbybees","html_url":"https://github.com/reviewbybees","followers_url":"https://api.github.com/users/reviewbybees/followers","following_url":"https://api.github.com/users/reviewbybees/following{/other_user}","gists_url":"https://api.github.com/users/reviewbybees/gists{/gist_id}","starred_url":"https://api.github.com/users/reviewbybees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reviewbybees/subscriptions","organizations_url":"https://api.github.com/users/reviewbybees/orgs","repos_url":"https://api.github.com/users/reviewbybees/repos","events_url":"https://api.github.com/users/reviewbybees/events{/privacy}","received_events_url":"https://api.github.com/users/reviewbybees/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T16:07:28Z","updated_at":"2015-10-30T16:07:28Z","body":"This pull request originates from a [CloudBees](https://www.cloudbees.com/) employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see [this explanation](https://github.com/reviewbybees/about#about-reviewbybees).\n"}}