{"action":"created","issue":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1435","labels_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1435/labels{/name}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1435/comments","events_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1435/events","html_url":"https://github.com/jscs-dev/node-jscs/pull/1435","id":85803458,"number":1435,"title":"Refactor integration tests","user":{"login":"mdevils","id":176898,"avatar_url":"https://avatars.githubusercontent.com/u/176898?v=3","gravatar_id":"","url":"https://api.github.com/users/mdevils","html_url":"https://github.com/mdevils","followers_url":"https://api.github.com/users/mdevils/followers","following_url":"https://api.github.com/users/mdevils/following{/other_user}","gists_url":"https://api.github.com/users/mdevils/gists{/gist_id}","starred_url":"https://api.github.com/users/mdevils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdevils/subscriptions","organizations_url":"https://api.github.com/users/mdevils/orgs","repos_url":"https://api.github.com/users/mdevils/repos","events_url":"https://api.github.com/users/mdevils/events{/privacy}","received_events_url":"https://api.github.com/users/mdevils/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-06T19:19:54Z","updated_at":"2015-06-06T20:24:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/1435","html_url":"https://github.com/jscs-dev/node-jscs/pull/1435","diff_url":"https://github.com/jscs-dev/node-jscs/pull/1435.diff","patch_url":"https://github.com/jscs-dev/node-jscs/pull/1435.patch"},"body":"After integration tests silently failed, I decided to figure out why, and during that process, I made some refactoring:\r\n\r\n* More human-readable integration tests code.\r\n* Use promises instead of callbacks: bulletproof execution flow and readability.\r\n* Show test output (currently output is hidden, it hides errors).\r\n* Fix STDIO-error (the actual cause of the problem).\r\n\r\n/cc @markelog"},"comment":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/comments/109645341","html_url":"https://github.com/jscs-dev/node-jscs/pull/1435#issuecomment-109645341","issue_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/1435","id":109645341,"user":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T20:24:11Z","updated_at":"2015-06-06T20:24:11Z","body":"> Show test output (currently output is hidden, it hides errors).\r\n> Fix STDIO-error (the actual cause of the problem).\r\n\r\nThose are fixed in 2.0 branch :)\r\n\r\n> Use promises instead of callbacks: bulletproof execution flow and readability.\r\n\r\nWell, `promise().then(fn)` is basically the same as `read(..., fn)` if there was something like `.then().then()` i would all for it, otherwise i don't see the point. Besides there is still code that uses callbacks which makes the code heterogeneous, i.e. uses two different concepts."}}