{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29270215","id":29270215,"diff_hunk":"@@ -1242,6 +1242,29 @@ func ValidateSecret(secret *api.Secret) errs.ValidationErrorList {\n \t\tallErrs = append(allErrs, errs.NewFieldForbidden(\"data\", \"Maximum secret size exceeded\"))\n \t}\n \n+\tswitch secret.Type {\n+\tcase api.SecretTypeOpaque, \"\":\n+\t\t// no-op\n+\tdefault:\n+\t\tallErrs = append(allErrs, errs.NewFieldInvalid(\"type\", secret.Type, \"unknown SecretType\"))","path":"pkg/api/validation/validation.go","position":8,"original_position":8,"commit_id":"e1e9bd5bdddbc45b7e4f34bca3281eaea9dd1b3e","original_commit_id":"83b85672e9645a135dc9616a4f62cc66bae0a338","user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"body":"@liggitt I think we should take this validation out for now and open an issue re: types and whether they can be user defined.","created_at":"2015-04-28T18:02:52Z","updated_at":"2015-04-28T18:02:52Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419#discussion_r29270215","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29270215"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419#discussion_r29270215"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419","id":34232237,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7419","number":7419,"state":"open","locked":false,"title":"Convert Secret registry to use update/create strategy, allow filtering by Type","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"Noticed the secret registry hadn't been updated to make use of the strategy bits in generic etcd. Pulled this one commit out of https://github.com/GoogleCloudPlatform/kubernetes/pull/7101 into it's own PR to get eyes on it separately.\r\n\r\n1. Removes a lot of boilerplate around metadata filling\r\n2. Makes generated names work for secrets\r\n3. Makes `type` immutable (it was allowed to change before, though we only had one specified type)\r\n4. Adds `type` as an allowed field filter\r\n5. Changes package structure to match other registries","created_at":"2015-04-28T04:07:57Z","updated_at":"2015-04-28T18:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11d8be31ae2946b2fb0f186da3175b2c76fc37b8","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7419/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/e1e9bd5bdddbc45b7e4f34bca3281eaea9dd1b3e","head":{"label":"liggitt:secrets_etcd","ref":"secrets_etcd","sha":"e1e9bd5bdddbc45b7e4f34bca3281eaea9dd1b3e","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"repo":{"id":22823654,"name":"kubernetes","full_name":"liggitt/kubernetes","owner":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liggitt/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/liggitt/kubernetes","forks_url":"https://api.github.com/repos/liggitt/kubernetes/forks","keys_url":"https://api.github.com/repos/liggitt/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liggitt/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liggitt/kubernetes/teams","hooks_url":"https://api.github.com/repos/liggitt/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/liggitt/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/liggitt/kubernetes/events","assignees_url":"https://api.github.com/repos/liggitt/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/liggitt/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/liggitt/kubernetes/tags","blobs_url":"https://api.github.com/repos/liggitt/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liggitt/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liggitt/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/liggitt/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liggitt/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/liggitt/kubernetes/languages","stargazers_url":"https://api.github.com/repos/liggitt/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/liggitt/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/liggitt/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/liggitt/kubernetes/subscription","commits_url":"https://api.github.com/repos/liggitt/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/liggitt/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/liggitt/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/liggitt/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/liggitt/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/liggitt/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liggitt/kubernetes/merges","archive_url":"https://api.github.com/repos/liggitt/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liggitt/kubernetes/downloads","issues_url":"https://api.github.com/repos/liggitt/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/liggitt/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/liggitt/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/liggitt/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liggitt/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/liggitt/kubernetes/releases{/id}","created_at":"2014-08-11T01:56:03Z","updated_at":"2015-04-28T15:07:41Z","pushed_at":"2015-04-28T16:58:17Z","git_url":"git://github.com/liggitt/kubernetes.git","ssh_url":"git@github.com:liggitt/kubernetes.git","clone_url":"https://github.com/liggitt/kubernetes.git","svn_url":"https://github.com/liggitt/kubernetes","homepage":null,"size":49026,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"4045dedc99442e2a0bcc8b9a7148ae045905e452","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-28T18:01:15Z","pushed_at":"2015-04-28T18:01:15Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":209033,"stargazers_count":7387,"watchers_count":7387,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1481,"mirror_url":null,"open_issues_count":957,"forks":1481,"open_issues":957,"watchers":7387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7419"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7419"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7419/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7419/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/e1e9bd5bdddbc45b7e4f34bca3281eaea9dd1b3e"}}}}