{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/35401129","id":35401129,"diff_hunk":"@@ -0,0 +1,138 @@\n+#-- encoding: UTF-8\n+#-- copyright\n+# OpenProject is a project management system.\n+# Copyright (C) 2012-2015 the OpenProject Foundation (OPF)\n+#\n+# This program is free software; you can redistribute it and/or\n+# modify it under the terms of the GNU General Public License version 3.\n+#\n+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:\n+# Copyright (C) 2006-2013 Jean-Philippe Lang\n+# Copyright (C) 2010-2013 the ChiliProject Team\n+#\n+# This program is free software; you can redistribute it and/or\n+# modify it under the terms of the GNU General Public License\n+# as published by the Free Software Foundation; either version 2\n+# of the License, or (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program; if not, write to the Free Software\n+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+#\n+# See doc/COPYRIGHT.rdoc for more details.\n+#++\n+require 'spec_helper'\n+\n+describe JournalNotificationMailer do\n+  let(:project) { FactoryGirl.create(:project_with_types) }\n+  let(:user) do\n+    FactoryGirl.build(:user,\n+                      mail_notification: 'all',\n+                      member_in_project: project)\n+  end\n+  let(:work_package) do\n+    FactoryGirl.create(:work_package,\n+                       project_id: project.id,\n+                       project: project,","path":"spec/models/journal_notification_mailer_spec.rb","position":41,"original_position":41,"commit_id":"2bca02a6b41fb3a7df52bb256b9fee59eb3be9c5","original_commit_id":"2bca02a6b41fb3a7df52bb256b9fee59eb3be9c5","user":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"body":"Either use `project` or `project_id`.\r\n\r\nMore specifically: Use `project`","created_at":"2015-07-24T07:34:42Z","updated_at":"2015-07-24T07:34:42Z","html_url":"https://github.com/opf/openproject/pull/3254#discussion_r35401129","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3254","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/35401129"},"html":{"href":"https://github.com/opf/openproject/pull/3254#discussion_r35401129"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3254"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3254","id":40242363,"html_url":"https://github.com/opf/openproject/pull/3254","diff_url":"https://github.com/opf/openproject/pull/3254.diff","patch_url":"https://github.com/opf/openproject/pull/3254.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3254","number":3254,"state":"open","locked":false,"title":"Feature aggregated notifications","user":{"login":"Azure7111","id":1461183,"avatar_url":"https://avatars.githubusercontent.com/u/1461183?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure7111","html_url":"https://github.com/Azure7111","followers_url":"https://api.github.com/users/Azure7111/followers","following_url":"https://api.github.com/users/Azure7111/following{/other_user}","gists_url":"https://api.github.com/users/Azure7111/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure7111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure7111/subscriptions","organizations_url":"https://api.github.com/users/Azure7111/orgs","repos_url":"https://api.github.com/users/Azure7111/repos","events_url":"https://api.github.com/users/Azure7111/events{/privacy}","received_events_url":"https://api.github.com/users/Azure7111/received_events","type":"User","site_admin":false},"body":"This PR aims to replace the observer functionality in use for notifications about e.g. work package updates by an event driven variant.\r\n\r\nhttps://community.openproject.org/work_packages/20693","created_at":"2015-07-17T15:28:56Z","updated_at":"2015-07-24T07:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793c2020efd1dd9e2c3f7c8e9163202cf9654138","assignee":null,"milestone":{"url":"https://api.github.com/repos/opf/openproject/milestones/3","html_url":"https://github.com/opf/openproject/milestones/4.3","labels_url":"https://api.github.com/repos/opf/openproject/milestones/3/labels","id":1104474,"number":3,"title":"4.3","description":"","creator":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":8,"state":"open","created_at":"2015-05-11T10:04:28Z","updated_at":"2015-07-23T12:53:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3254/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3254/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3254/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/2bca02a6b41fb3a7df52bb256b9fee59eb3be9c5","head":{"label":"Azure7111:feature/aggregated_notifications","ref":"feature/aggregated_notifications","sha":"2bca02a6b41fb3a7df52bb256b9fee59eb3be9c5","user":{"login":"Azure7111","id":1461183,"avatar_url":"https://avatars.githubusercontent.com/u/1461183?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure7111","html_url":"https://github.com/Azure7111","followers_url":"https://api.github.com/users/Azure7111/followers","following_url":"https://api.github.com/users/Azure7111/following{/other_user}","gists_url":"https://api.github.com/users/Azure7111/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure7111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure7111/subscriptions","organizations_url":"https://api.github.com/users/Azure7111/orgs","repos_url":"https://api.github.com/users/Azure7111/repos","events_url":"https://api.github.com/users/Azure7111/events{/privacy}","received_events_url":"https://api.github.com/users/Azure7111/received_events","type":"User","site_admin":false},"repo":{"id":32079075,"name":"openproject","full_name":"Azure7111/openproject","owner":{"login":"Azure7111","id":1461183,"avatar_url":"https://avatars.githubusercontent.com/u/1461183?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure7111","html_url":"https://github.com/Azure7111","followers_url":"https://api.github.com/users/Azure7111/followers","following_url":"https://api.github.com/users/Azure7111/following{/other_user}","gists_url":"https://api.github.com/users/Azure7111/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure7111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure7111/subscriptions","organizations_url":"https://api.github.com/users/Azure7111/orgs","repos_url":"https://api.github.com/users/Azure7111/repos","events_url":"https://api.github.com/users/Azure7111/events{/privacy}","received_events_url":"https://api.github.com/users/Azure7111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Azure7111/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/Azure7111/openproject","forks_url":"https://api.github.com/repos/Azure7111/openproject/forks","keys_url":"https://api.github.com/repos/Azure7111/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure7111/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure7111/openproject/teams","hooks_url":"https://api.github.com/repos/Azure7111/openproject/hooks","issue_events_url":"https://api.github.com/repos/Azure7111/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/Azure7111/openproject/events","assignees_url":"https://api.github.com/repos/Azure7111/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/Azure7111/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/Azure7111/openproject/tags","blobs_url":"https://api.github.com/repos/Azure7111/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure7111/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure7111/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure7111/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure7111/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure7111/openproject/languages","stargazers_url":"https://api.github.com/repos/Azure7111/openproject/stargazers","contributors_url":"https://api.github.com/repos/Azure7111/openproject/contributors","subscribers_url":"https://api.github.com/repos/Azure7111/openproject/subscribers","subscription_url":"https://api.github.com/repos/Azure7111/openproject/subscription","commits_url":"https://api.github.com/repos/Azure7111/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure7111/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure7111/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure7111/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure7111/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/Azure7111/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure7111/openproject/merges","archive_url":"https://api.github.com/repos/Azure7111/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure7111/openproject/downloads","issues_url":"https://api.github.com/repos/Azure7111/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/Azure7111/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure7111/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure7111/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure7111/openproject/labels{/name}","releases_url":"https://api.github.com/repos/Azure7111/openproject/releases{/id}","created_at":"2015-03-12T13:42:37Z","updated_at":"2015-03-12T13:42:45Z","pushed_at":"2015-07-23T15:10:01Z","git_url":"git://github.com/Azure7111/openproject.git","ssh_url":"git@github.com:Azure7111/openproject.git","clone_url":"https://github.com/Azure7111/openproject.git","svn_url":"https://github.com/Azure7111/openproject","homepage":"https://www.openproject.org","size":66361,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:release/4.3","ref":"release/4.3","sha":"33105eaae63f91104039707da32e31dffbcd3503","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-07-23T13:56:12Z","pushed_at":"2015-07-24T07:28:24Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":205513,"stargazers_count":685,"watchers_count":685,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":26,"forks":290,"open_issues":26,"watchers":685,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3254"},"html":{"href":"https://github.com/opf/openproject/pull/3254"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3254"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3254/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3254/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3254/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/2bca02a6b41fb3a7df52bb256b9fee59eb3be9c5"}}}}