{"action":"created","comment":{"url":"https://api.github.com/repos/dockyard/styleguides/pulls/comments/46453343","id":46453343,"diff_hunk":"@@ -66,6 +66,29 @@ export default DS.Model.extend({\n });\n ```\n \n+## Use Ember.set and Ember.get\n+Calling `someObj.get('prop')` couples your code to the fact that\n+`someObj` is an Ember Object. It prevents you from passing in a\n+POJO, which is sometimes preferable in test.\n+\n+Although when defining a method in a controller, component, etc. you\n+can be fairly sure `this` is an Ember Object, for consistency with the\n+above, we still use Ember.get/set.","path":"engineering/ember.md","position":11,"original_position":11,"commit_id":"5521c5cd550e1394802e3ba1d9f7ee29a6d67829","original_commit_id":"5521c5cd550e1394802e3ba1d9f7ee29a6d67829","user":{"login":"michaeldupuisjr","id":1060866,"avatar_url":"https://avatars.githubusercontent.com/u/1060866?v=3","gravatar_id":"","url":"https://api.github.com/users/michaeldupuisjr","html_url":"https://github.com/michaeldupuisjr","followers_url":"https://api.github.com/users/michaeldupuisjr/followers","following_url":"https://api.github.com/users/michaeldupuisjr/following{/other_user}","gists_url":"https://api.github.com/users/michaeldupuisjr/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeldupuisjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeldupuisjr/subscriptions","organizations_url":"https://api.github.com/users/michaeldupuisjr/orgs","repos_url":"https://api.github.com/users/michaeldupuisjr/repos","events_url":"https://api.github.com/users/michaeldupuisjr/events{/privacy}","received_events_url":"https://api.github.com/users/michaeldupuisjr/received_events","type":"User","site_admin":false},"body":"use `Ember.get`/`set` (monospace)","created_at":"2015-12-02T18:27:48Z","updated_at":"2015-12-02T18:27:48Z","html_url":"https://github.com/dockyard/styleguides/pull/52#discussion_r46453343","pull_request_url":"https://api.github.com/repos/dockyard/styleguides/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/comments/46453343"},"html":{"href":"https://github.com/dockyard/styleguides/pull/52#discussion_r46453343"},"pull_request":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/dockyard/styleguides/pulls/52","id":52424658,"html_url":"https://github.com/dockyard/styleguides/pull/52","diff_url":"https://github.com/dockyard/styleguides/pull/52.diff","patch_url":"https://github.com/dockyard/styleguides/pull/52.patch","issue_url":"https://api.github.com/repos/dockyard/styleguides/issues/52","number":52,"state":"open","locked":false,"title":"User Ember.set & Ember.get","user":{"login":"drspaniel","id":1588273,"avatar_url":"https://avatars.githubusercontent.com/u/1588273?v=3","gravatar_id":"","url":"https://api.github.com/users/drspaniel","html_url":"https://github.com/drspaniel","followers_url":"https://api.github.com/users/drspaniel/followers","following_url":"https://api.github.com/users/drspaniel/following{/other_user}","gists_url":"https://api.github.com/users/drspaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/drspaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drspaniel/subscriptions","organizations_url":"https://api.github.com/users/drspaniel/orgs","repos_url":"https://api.github.com/users/drspaniel/repos","events_url":"https://api.github.com/users/drspaniel/events{/privacy}","received_events_url":"https://api.github.com/users/drspaniel/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-02T17:08:24Z","updated_at":"2015-12-02T18:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6671115814bd00593dde4a09ad96f1254e6ff8b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dockyard/styleguides/pulls/52/commits","review_comments_url":"https://api.github.com/repos/dockyard/styleguides/pulls/52/comments","review_comment_url":"https://api.github.com/repos/dockyard/styleguides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dockyard/styleguides/issues/52/comments","statuses_url":"https://api.github.com/repos/dockyard/styleguides/statuses/5521c5cd550e1394802e3ba1d9f7ee29a6d67829","head":{"label":"dockyard:ember-get-set","ref":"ember-get-set","sha":"5521c5cd550e1394802e3ba1d9f7ee29a6d67829","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":29650939,"name":"styleguides","full_name":"dockyard/styleguides","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/styleguides","description":"Styleguides for DockYard","fork":false,"url":"https://api.github.com/repos/dockyard/styleguides","forks_url":"https://api.github.com/repos/dockyard/styleguides/forks","keys_url":"https://api.github.com/repos/dockyard/styleguides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/styleguides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/styleguides/teams","hooks_url":"https://api.github.com/repos/dockyard/styleguides/hooks","issue_events_url":"https://api.github.com/repos/dockyard/styleguides/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/styleguides/events","assignees_url":"https://api.github.com/repos/dockyard/styleguides/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/styleguides/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/styleguides/tags","blobs_url":"https://api.github.com/repos/dockyard/styleguides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/styleguides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/styleguides/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/styleguides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/styleguides/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/styleguides/languages","stargazers_url":"https://api.github.com/repos/dockyard/styleguides/stargazers","contributors_url":"https://api.github.com/repos/dockyard/styleguides/contributors","subscribers_url":"https://api.github.com/repos/dockyard/styleguides/subscribers","subscription_url":"https://api.github.com/repos/dockyard/styleguides/subscription","commits_url":"https://api.github.com/repos/dockyard/styleguides/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/styleguides/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/styleguides/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/styleguides/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockyard/styleguides/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/styleguides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/styleguides/merges","archive_url":"https://api.github.com/repos/dockyard/styleguides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/styleguides/downloads","issues_url":"https://api.github.com/repos/dockyard/styleguides/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/styleguides/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/styleguides/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/styleguides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/styleguides/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/styleguides/releases{/id}","created_at":"2015-01-22T03:34:12Z","updated_at":"2015-11-25T19:41:24Z","pushed_at":"2015-12-02T17:23:56Z","git_url":"git://github.com/dockyard/styleguides.git","ssh_url":"git@github.com:dockyard/styleguides.git","clone_url":"https://github.com/dockyard/styleguides.git","svn_url":"https://github.com/dockyard/styleguides","homepage":null,"size":352,"stargazers_count":95,"watchers_count":95,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":17,"forks":10,"open_issues":17,"watchers":95,"default_branch":"master"}},"base":{"label":"dockyard:master","ref":"master","sha":"5610ce197682107c663a37d9c229525697f69276","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":29650939,"name":"styleguides","full_name":"dockyard/styleguides","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/styleguides","description":"Styleguides for DockYard","fork":false,"url":"https://api.github.com/repos/dockyard/styleguides","forks_url":"https://api.github.com/repos/dockyard/styleguides/forks","keys_url":"https://api.github.com/repos/dockyard/styleguides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/styleguides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/styleguides/teams","hooks_url":"https://api.github.com/repos/dockyard/styleguides/hooks","issue_events_url":"https://api.github.com/repos/dockyard/styleguides/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/styleguides/events","assignees_url":"https://api.github.com/repos/dockyard/styleguides/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/styleguides/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/styleguides/tags","blobs_url":"https://api.github.com/repos/dockyard/styleguides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/styleguides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/styleguides/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/styleguides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/styleguides/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/styleguides/languages","stargazers_url":"https://api.github.com/repos/dockyard/styleguides/stargazers","contributors_url":"https://api.github.com/repos/dockyard/styleguides/contributors","subscribers_url":"https://api.github.com/repos/dockyard/styleguides/subscribers","subscription_url":"https://api.github.com/repos/dockyard/styleguides/subscription","commits_url":"https://api.github.com/repos/dockyard/styleguides/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/styleguides/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/styleguides/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/styleguides/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockyard/styleguides/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/styleguides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/styleguides/merges","archive_url":"https://api.github.com/repos/dockyard/styleguides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/styleguides/downloads","issues_url":"https://api.github.com/repos/dockyard/styleguides/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/styleguides/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/styleguides/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/styleguides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/styleguides/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/styleguides/releases{/id}","created_at":"2015-01-22T03:34:12Z","updated_at":"2015-11-25T19:41:24Z","pushed_at":"2015-12-02T17:23:56Z","git_url":"git://github.com/dockyard/styleguides.git","ssh_url":"git@github.com:dockyard/styleguides.git","clone_url":"https://github.com/dockyard/styleguides.git","svn_url":"https://github.com/dockyard/styleguides","homepage":null,"size":352,"stargazers_count":95,"watchers_count":95,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":17,"forks":10,"open_issues":17,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/52"},"html":{"href":"https://github.com/dockyard/styleguides/pull/52"},"issue":{"href":"https://api.github.com/repos/dockyard/styleguides/issues/52"},"comments":{"href":"https://api.github.com/repos/dockyard/styleguides/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dockyard/styleguides/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/dockyard/styleguides/statuses/5521c5cd550e1394802e3ba1d9f7ee29a6d67829"}}}}