{"action":"closed","number":14502,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502","id":54177317,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14502","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14502.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14502.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14502","number":14502,"state":"closed","locked":false,"title":"[CR] Remove unnecessary overmap flags","user":{"login":"illi-kun","id":5421954,"avatar_url":"https://avatars.githubusercontent.com/u/5421954?v=3","gravatar_id":"","url":"https://api.github.com/users/illi-kun","html_url":"https://github.com/illi-kun","followers_url":"https://api.github.com/users/illi-kun/followers","following_url":"https://api.github.com/users/illi-kun/following{/other_user}","gists_url":"https://api.github.com/users/illi-kun/gists{/gist_id}","starred_url":"https://api.github.com/users/illi-kun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illi-kun/subscriptions","organizations_url":"https://api.github.com/users/illi-kun/orgs","repos_url":"https://api.github.com/users/illi-kun/repos","events_url":"https://api.github.com/users/illi-kun/events{/privacy}","received_events_url":"https://api.github.com/users/illi-kun/received_events","type":"User","site_admin":false},"body":"Boolean values of json entries \"rotate\", \"unique\", and \"required\" are loaded in overmap.cpp:L162, so flags with the same names seem useless.\r\n\r\nIt's [CR] because of two things:\r\n1) I want to receive confirmation from someone who more experienced with this code that I got everything correctly.\r\n2) Boolean values and flags are in contradiction in some places and it's better to double check the final statements.","created_at":"2015-12-19T11:55:26Z","updated_at":"2015-12-20T10:18:26Z","closed_at":"2015-12-20T10:18:26Z","merged_at":null,"merge_commit_sha":"cf08b4fcf6c1faa1b64da234a243b6490f95a5ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14502/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/189ddfbbbb265588812bde6a8a45bbd76aca31ce","head":{"label":"illi-kun:map_flags","ref":"map_flags","sha":"189ddfbbbb265588812bde6a8a45bbd76aca31ce","user":{"login":"illi-kun","id":5421954,"avatar_url":"https://avatars.githubusercontent.com/u/5421954?v=3","gravatar_id":"","url":"https://api.github.com/users/illi-kun","html_url":"https://github.com/illi-kun","followers_url":"https://api.github.com/users/illi-kun/followers","following_url":"https://api.github.com/users/illi-kun/following{/other_user}","gists_url":"https://api.github.com/users/illi-kun/gists{/gist_id}","starred_url":"https://api.github.com/users/illi-kun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illi-kun/subscriptions","organizations_url":"https://api.github.com/users/illi-kun/orgs","repos_url":"https://api.github.com/users/illi-kun/repos","events_url":"https://api.github.com/users/illi-kun/events{/privacy}","received_events_url":"https://api.github.com/users/illi-kun/received_events","type":"User","site_admin":false},"repo":{"id":38418763,"name":"Cataclysm-DDA","full_name":"illi-kun/Cataclysm-DDA","owner":{"login":"illi-kun","id":5421954,"avatar_url":"https://avatars.githubusercontent.com/u/5421954?v=3","gravatar_id":"","url":"https://api.github.com/users/illi-kun","html_url":"https://github.com/illi-kun","followers_url":"https://api.github.com/users/illi-kun/followers","following_url":"https://api.github.com/users/illi-kun/following{/other_user}","gists_url":"https://api.github.com/users/illi-kun/gists{/gist_id}","starred_url":"https://api.github.com/users/illi-kun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illi-kun/subscriptions","organizations_url":"https://api.github.com/users/illi-kun/orgs","repos_url":"https://api.github.com/users/illi-kun/repos","events_url":"https://api.github.com/users/illi-kun/events{/privacy}","received_events_url":"https://api.github.com/users/illi-kun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/illi-kun/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA","forks_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/illi-kun/Cataclysm-DDA/releases{/id}","created_at":"2015-07-02T07:47:29Z","updated_at":"2015-07-02T07:47:37Z","pushed_at":"2015-12-20T10:11:54Z","git_url":"git://github.com/illi-kun/Cataclysm-DDA.git","ssh_url":"git@github.com:illi-kun/Cataclysm-DDA.git","clone_url":"https://github.com/illi-kun/Cataclysm-DDA.git","svn_url":"https://github.com/illi-kun/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":607037,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"ba984eec58dbdd040048ca8279e6f2d4ebb5259c","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-12-20T02:54:08Z","pushed_at":"2015-12-20T10:18:12Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":857805,"stargazers_count":829,"watchers_count":829,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":824,"mirror_url":null,"open_issues_count":1199,"forks":824,"open_issues":1199,"watchers":829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14502"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14502"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14502/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14502/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/189ddfbbbb265588812bde6a8a45bbd76aca31ce"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":2,"commits":1,"additions":4,"deletions":5,"changed_files":1}}