{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/46507133","id":46507133,"diff_hunk":"@@ -2757,13 +2757,7 @@ YUI.add('juju-models', function(Y) {\n \n       var changedMachines = [];\n       this.machines.each(function(machine) {\n-        var units = machine.units;\n-        if (!units) {\n-          // If the machine view hasn't been opened yet then there won't be a\n-          // units collection on the machines. So we need to get the 'real'\n-          // unit list.\n-          units = this.units.filterByMachine(machine.id, true);\n-        }\n+        var units = this.units.filterByMachine(machine.id, true);","path":"jujugui/static/gui/src/app/models/models.js","position":11,"original_position":11,"commit_id":"991864b3a2786efe687a6ce7bc365c0c14daebbd","original_commit_id":"991864b3a2786efe687a6ce7bc365c0c14daebbd","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"body":"Removed this kinda hacky unit list, we can just do a lookup using the machine id.","created_at":"2015-12-03T02:44:43Z","updated_at":"2015-12-03T02:44:43Z","html_url":"https://github.com/juju/juju-gui/pull/1043#discussion_r46507133","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/1043","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/46507133"},"html":{"href":"https://github.com/juju/juju-gui/pull/1043#discussion_r46507133"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/1043"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/1043","id":52483524,"html_url":"https://github.com/juju/juju-gui/pull/1043","diff_url":"https://github.com/juju/juju-gui/pull/1043.diff","patch_url":"https://github.com/juju/juju-gui/pull/1043.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/1043","number":1043,"state":"open","locked":false,"title":"Machine removal","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"body":"Allow machines and containers to be removed.","created_at":"2015-12-03T02:17:42Z","updated_at":"2015-12-03T02:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30f52b4731df739762b52d7fa6a3517d07b94760","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/1043/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/1043/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/1043/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/991864b3a2786efe687a6ce7bc365c0c14daebbd","head":{"label":"huwshimi:machine-removal","ref":"machine-removal","sha":"991864b3a2786efe687a6ce7bc365c0c14daebbd","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"repo":{"id":15032585,"name":"juju-gui","full_name":"huwshimi/juju-gui","owner":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huwshimi/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/huwshimi/juju-gui","forks_url":"https://api.github.com/repos/huwshimi/juju-gui/forks","keys_url":"https://api.github.com/repos/huwshimi/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huwshimi/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huwshimi/juju-gui/teams","hooks_url":"https://api.github.com/repos/huwshimi/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/huwshimi/juju-gui/events","assignees_url":"https://api.github.com/repos/huwshimi/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/huwshimi/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/huwshimi/juju-gui/tags","blobs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huwshimi/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/huwshimi/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huwshimi/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/huwshimi/juju-gui/languages","stargazers_url":"https://api.github.com/repos/huwshimi/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/huwshimi/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/huwshimi/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/huwshimi/juju-gui/subscription","commits_url":"https://api.github.com/repos/huwshimi/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/huwshimi/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/huwshimi/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/huwshimi/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/huwshimi/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huwshimi/juju-gui/merges","archive_url":"https://api.github.com/repos/huwshimi/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huwshimi/juju-gui/downloads","issues_url":"https://api.github.com/repos/huwshimi/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/huwshimi/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/huwshimi/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/huwshimi/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huwshimi/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/huwshimi/juju-gui/releases{/id}","created_at":"2013-12-08T22:20:08Z","updated_at":"2014-06-25T06:57:23Z","pushed_at":"2015-12-03T02:43:40Z","git_url":"git://github.com/huwshimi/juju-gui.git","ssh_url":"git@github.com:huwshimi/juju-gui.git","clone_url":"https://github.com/huwshimi/juju-gui.git","svn_url":"https://github.com/huwshimi/juju-gui","homepage":null,"size":111923,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"6098c496e1dd20a66fe73c508bedddb53bff9c4f","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2015-11-24T15:41:39Z","pushed_at":"2015-12-03T02:43:40Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":112892,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":6,"forks":45,"open_issues":6,"watchers":57,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/1043"},"html":{"href":"https://github.com/juju/juju-gui/pull/1043"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/1043"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/1043/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/1043/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/1043/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/991864b3a2786efe687a6ce7bc365c0c14daebbd"}}}}