{"action":"created","comment":{"url":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments/33423166","id":33423166,"diff_hunk":"@@ -66,21 +62,66 @@\n                 (count active-peers)))\n       (rand-nth (operation/select-n-peers id active-peers max-downstream-links)))))\n \n-;; Needs a performance boost\n-(defmethod p-ext/write-batch :default\n-  [{:keys [onyx.core/id onyx.core/results onyx.core/messenger onyx.core/job-id onyx.core/max-downstream-links] :as event}]\n-  (let [leaves (fast-concat (map :leaves results))\n-        egress-tasks (:egress-ids (:onyx.core/serialized-task event))]\n-    (when-not (empty? leaves)\n-      (let [replica @(:onyx.core/replica event)\n-            segments (build-segments-to-send leaves)\n-            groups (group-by (juxt :route :hash-group) segments)\n-            allocations (get (:allocations replica) job-id)]\n-        (doseq [[[route hash-group] segs] groups]\n-          (let [peers (get allocations (get egress-tasks route))\n-                active-peers (filter #(= (get-in replica [:peer-state %]) :active) peers)\n-                target (pick-peer id active-peers hash-group max-downstream-links)]\n-            (when target\n-              (let [link (operation/peer-link event target)]\n-                (onyx.extensions/send-messages messenger event link segs)))))\n-        {}))))\n+(defn read-batch [{:keys [onyx.core/messenger] :as event}]","path":"src/onyx/peer/function.clj","position":64,"original_position":64,"commit_id":"9ee66bc53a1fefe49d4aa754a455d349d5042628","original_commit_id":"9ee66bc53a1fefe49d4aa754a455d349d5042628","user":{"login":"MichaelDrogalis","id":918857,"avatar_url":"https://avatars.githubusercontent.com/u/918857?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelDrogalis","html_url":"https://github.com/MichaelDrogalis","followers_url":"https://api.github.com/users/MichaelDrogalis/followers","following_url":"https://api.github.com/users/MichaelDrogalis/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDrogalis/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDrogalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDrogalis/subscriptions","organizations_url":"https://api.github.com/users/MichaelDrogalis/orgs","repos_url":"https://api.github.com/users/MichaelDrogalis/repos","events_url":"https://api.github.com/users/MichaelDrogalis/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDrogalis/received_events","type":"User","site_admin":false},"body":"Is this a left over?","created_at":"2015-06-28T14:07:43Z","updated_at":"2015-06-28T14:07:43Z","html_url":"https://github.com/onyx-platform/onyx/pull/227#discussion_r33423166","pull_request_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments/33423166"},"html":{"href":"https://github.com/onyx-platform/onyx/pull/227#discussion_r33423166"},"pull_request":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/onyx-platform/onyx/pulls/227","id":38661876,"html_url":"https://github.com/onyx-platform/onyx/pull/227","diff_url":"https://github.com/onyx-platform/onyx/pull/227.diff","patch_url":"https://github.com/onyx-platform/onyx/pull/227.patch","issue_url":"https://api.github.com/repos/onyx-platform/onyx/issues/227","number":227,"state":"open","locked":false,"title":"Pipeline Extensions implementation via protocols","user":{"login":"lbradstreet","id":252189,"avatar_url":"https://avatars.githubusercontent.com/u/252189?v=3","gravatar_id":"","url":"https://api.github.com/users/lbradstreet","html_url":"https://github.com/lbradstreet","followers_url":"https://api.github.com/users/lbradstreet/followers","following_url":"https://api.github.com/users/lbradstreet/following{/other_user}","gists_url":"https://api.github.com/users/lbradstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbradstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbradstreet/subscriptions","organizations_url":"https://api.github.com/users/lbradstreet/orgs","repos_url":"https://api.github.com/users/lbradstreet/repos","events_url":"https://api.github.com/users/lbradstreet/events{/privacy}","received_events_url":"https://api.github.com/users/lbradstreet/received_events","type":"User","site_admin":false},"body":"Onyx plugins now require a path to a builder fn that builds that pipeline,i.e. :ns/fn \r\nJava plugins can be dispatched via :ident :ns.ClassName.\r\nJava task fns can be resolved to static methods via :ns.Classname/methodName \r\n\r\nAlso includes some performance optimisation work in task-lifecycle (mostly splitting out once only key lookups outside of the task-lifecycle loop).\r\n","created_at":"2015-06-26T15:41:36Z","updated_at":"2015-06-28T14:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc5408a786e8683b1268bd5c31d4a65cd1e2d102","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/227/commits","review_comments_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/227/comments","review_comment_url":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/issues/227/comments","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/9ee66bc53a1fefe49d4aa754a455d349d5042628","head":{"label":"onyx-platform:pext-protocol","ref":"pext-protocol","sha":"9ee66bc53a1fefe49d4aa754a455d349d5042628","user":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":14849761,"name":"onyx","full_name":"onyx-platform/onyx","owner":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onyx-platform/onyx","description":"Distributed, masterless, high performance, fault tolerant data processing for Clojure","fork":false,"url":"https://api.github.com/repos/onyx-platform/onyx","forks_url":"https://api.github.com/repos/onyx-platform/onyx/forks","keys_url":"https://api.github.com/repos/onyx-platform/onyx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onyx-platform/onyx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onyx-platform/onyx/teams","hooks_url":"https://api.github.com/repos/onyx-platform/onyx/hooks","issue_events_url":"https://api.github.com/repos/onyx-platform/onyx/issues/events{/number}","events_url":"https://api.github.com/repos/onyx-platform/onyx/events","assignees_url":"https://api.github.com/repos/onyx-platform/onyx/assignees{/user}","branches_url":"https://api.github.com/repos/onyx-platform/onyx/branches{/branch}","tags_url":"https://api.github.com/repos/onyx-platform/onyx/tags","blobs_url":"https://api.github.com/repos/onyx-platform/onyx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onyx-platform/onyx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onyx-platform/onyx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onyx-platform/onyx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/{sha}","languages_url":"https://api.github.com/repos/onyx-platform/onyx/languages","stargazers_url":"https://api.github.com/repos/onyx-platform/onyx/stargazers","contributors_url":"https://api.github.com/repos/onyx-platform/onyx/contributors","subscribers_url":"https://api.github.com/repos/onyx-platform/onyx/subscribers","subscription_url":"https://api.github.com/repos/onyx-platform/onyx/subscription","commits_url":"https://api.github.com/repos/onyx-platform/onyx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onyx-platform/onyx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onyx-platform/onyx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onyx-platform/onyx/contents/{+path}","compare_url":"https://api.github.com/repos/onyx-platform/onyx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onyx-platform/onyx/merges","archive_url":"https://api.github.com/repos/onyx-platform/onyx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onyx-platform/onyx/downloads","issues_url":"https://api.github.com/repos/onyx-platform/onyx/issues{/number}","pulls_url":"https://api.github.com/repos/onyx-platform/onyx/pulls{/number}","milestones_url":"https://api.github.com/repos/onyx-platform/onyx/milestones{/number}","notifications_url":"https://api.github.com/repos/onyx-platform/onyx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onyx-platform/onyx/labels{/name}","releases_url":"https://api.github.com/repos/onyx-platform/onyx/releases{/id}","created_at":"2013-12-02T01:21:14Z","updated_at":"2015-06-28T04:56:53Z","pushed_at":"2015-06-28T09:52:04Z","git_url":"git://github.com/onyx-platform/onyx.git","ssh_url":"git@github.com:onyx-platform/onyx.git","clone_url":"https://github.com/onyx-platform/onyx.git","svn_url":"https://github.com/onyx-platform/onyx","homepage":"","size":9394,"stargazers_count":777,"watchers_count":777,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":27,"forks":55,"open_issues":27,"watchers":777,"default_branch":"master"}},"base":{"label":"onyx-platform:develop","ref":"develop","sha":"e836211ffbe251894e810465a82dcb69d0147b41","user":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":14849761,"name":"onyx","full_name":"onyx-platform/onyx","owner":{"login":"onyx-platform","id":11951174,"avatar_url":"https://avatars.githubusercontent.com/u/11951174?v=3","gravatar_id":"","url":"https://api.github.com/users/onyx-platform","html_url":"https://github.com/onyx-platform","followers_url":"https://api.github.com/users/onyx-platform/followers","following_url":"https://api.github.com/users/onyx-platform/following{/other_user}","gists_url":"https://api.github.com/users/onyx-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/onyx-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onyx-platform/subscriptions","organizations_url":"https://api.github.com/users/onyx-platform/orgs","repos_url":"https://api.github.com/users/onyx-platform/repos","events_url":"https://api.github.com/users/onyx-platform/events{/privacy}","received_events_url":"https://api.github.com/users/onyx-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onyx-platform/onyx","description":"Distributed, masterless, high performance, fault tolerant data processing for Clojure","fork":false,"url":"https://api.github.com/repos/onyx-platform/onyx","forks_url":"https://api.github.com/repos/onyx-platform/onyx/forks","keys_url":"https://api.github.com/repos/onyx-platform/onyx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onyx-platform/onyx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onyx-platform/onyx/teams","hooks_url":"https://api.github.com/repos/onyx-platform/onyx/hooks","issue_events_url":"https://api.github.com/repos/onyx-platform/onyx/issues/events{/number}","events_url":"https://api.github.com/repos/onyx-platform/onyx/events","assignees_url":"https://api.github.com/repos/onyx-platform/onyx/assignees{/user}","branches_url":"https://api.github.com/repos/onyx-platform/onyx/branches{/branch}","tags_url":"https://api.github.com/repos/onyx-platform/onyx/tags","blobs_url":"https://api.github.com/repos/onyx-platform/onyx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onyx-platform/onyx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onyx-platform/onyx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onyx-platform/onyx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onyx-platform/onyx/statuses/{sha}","languages_url":"https://api.github.com/repos/onyx-platform/onyx/languages","stargazers_url":"https://api.github.com/repos/onyx-platform/onyx/stargazers","contributors_url":"https://api.github.com/repos/onyx-platform/onyx/contributors","subscribers_url":"https://api.github.com/repos/onyx-platform/onyx/subscribers","subscription_url":"https://api.github.com/repos/onyx-platform/onyx/subscription","commits_url":"https://api.github.com/repos/onyx-platform/onyx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onyx-platform/onyx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onyx-platform/onyx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onyx-platform/onyx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onyx-platform/onyx/contents/{+path}","compare_url":"https://api.github.com/repos/onyx-platform/onyx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onyx-platform/onyx/merges","archive_url":"https://api.github.com/repos/onyx-platform/onyx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onyx-platform/onyx/downloads","issues_url":"https://api.github.com/repos/onyx-platform/onyx/issues{/number}","pulls_url":"https://api.github.com/repos/onyx-platform/onyx/pulls{/number}","milestones_url":"https://api.github.com/repos/onyx-platform/onyx/milestones{/number}","notifications_url":"https://api.github.com/repos/onyx-platform/onyx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onyx-platform/onyx/labels{/name}","releases_url":"https://api.github.com/repos/onyx-platform/onyx/releases{/id}","created_at":"2013-12-02T01:21:14Z","updated_at":"2015-06-28T04:56:53Z","pushed_at":"2015-06-28T09:52:04Z","git_url":"git://github.com/onyx-platform/onyx.git","ssh_url":"git@github.com:onyx-platform/onyx.git","clone_url":"https://github.com/onyx-platform/onyx.git","svn_url":"https://github.com/onyx-platform/onyx","homepage":"","size":9394,"stargazers_count":777,"watchers_count":777,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":27,"forks":55,"open_issues":27,"watchers":777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/227"},"html":{"href":"https://github.com/onyx-platform/onyx/pull/227"},"issue":{"href":"https://api.github.com/repos/onyx-platform/onyx/issues/227"},"comments":{"href":"https://api.github.com/repos/onyx-platform/onyx/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onyx-platform/onyx/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/onyx-platform/onyx/statuses/9ee66bc53a1fefe49d4aa754a455d349d5042628"}}}}