{"action":"closed","number":340,"pull_request":{"url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340","id":48084536,"html_url":"https://github.com/projectatomic/atomicapp/pull/340","diff_url":"https://github.com/projectatomic/atomicapp/pull/340.diff","patch_url":"https://github.com/projectatomic/atomicapp/pull/340.patch","issue_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/340","number":340,"state":"closed","locked":false,"title":"Fix dry-run not stopping","user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"body":"Fixes issue #339.\n\nDry-run isn't passed to stop\n\nFound fix via `python -m trace -t` and some logging","created_at":"2015-10-19T15:11:40Z","updated_at":"2015-10-20T12:17:51Z","closed_at":"2015-10-20T12:17:51Z","merged_at":"2015-10-20T12:17:51Z","merge_commit_sha":"056bff70780f4306e4fedcb18db0c6814874232d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340/commits","review_comments_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340/comments","review_comment_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/340/comments","statuses_url":"https://api.github.com/repos/projectatomic/atomicapp/statuses/10bcd927e4dffb78e25211c76a7c31948ad2079e","head":{"label":"charliedrage:fix-dryrun","ref":"fix-dryrun","sha":"10bcd927e4dffb78e25211c76a7c31948ad2079e","user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"repo":{"id":41424648,"name":"atomicapp","full_name":"charliedrage/atomicapp","owner":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charliedrage/atomicapp","description":"This is the reference implementation of the Nulecule container application Specification: Atomic App","fork":true,"url":"https://api.github.com/repos/charliedrage/atomicapp","forks_url":"https://api.github.com/repos/charliedrage/atomicapp/forks","keys_url":"https://api.github.com/repos/charliedrage/atomicapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charliedrage/atomicapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charliedrage/atomicapp/teams","hooks_url":"https://api.github.com/repos/charliedrage/atomicapp/hooks","issue_events_url":"https://api.github.com/repos/charliedrage/atomicapp/issues/events{/number}","events_url":"https://api.github.com/repos/charliedrage/atomicapp/events","assignees_url":"https://api.github.com/repos/charliedrage/atomicapp/assignees{/user}","branches_url":"https://api.github.com/repos/charliedrage/atomicapp/branches{/branch}","tags_url":"https://api.github.com/repos/charliedrage/atomicapp/tags","blobs_url":"https://api.github.com/repos/charliedrage/atomicapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charliedrage/atomicapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charliedrage/atomicapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/charliedrage/atomicapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charliedrage/atomicapp/statuses/{sha}","languages_url":"https://api.github.com/repos/charliedrage/atomicapp/languages","stargazers_url":"https://api.github.com/repos/charliedrage/atomicapp/stargazers","contributors_url":"https://api.github.com/repos/charliedrage/atomicapp/contributors","subscribers_url":"https://api.github.com/repos/charliedrage/atomicapp/subscribers","subscription_url":"https://api.github.com/repos/charliedrage/atomicapp/subscription","commits_url":"https://api.github.com/repos/charliedrage/atomicapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/charliedrage/atomicapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/charliedrage/atomicapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/charliedrage/atomicapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/charliedrage/atomicapp/contents/{+path}","compare_url":"https://api.github.com/repos/charliedrage/atomicapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charliedrage/atomicapp/merges","archive_url":"https://api.github.com/repos/charliedrage/atomicapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charliedrage/atomicapp/downloads","issues_url":"https://api.github.com/repos/charliedrage/atomicapp/issues{/number}","pulls_url":"https://api.github.com/repos/charliedrage/atomicapp/pulls{/number}","milestones_url":"https://api.github.com/repos/charliedrage/atomicapp/milestones{/number}","notifications_url":"https://api.github.com/repos/charliedrage/atomicapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charliedrage/atomicapp/labels{/name}","releases_url":"https://api.github.com/repos/charliedrage/atomicapp/releases{/id}","created_at":"2015-08-26T12:37:30Z","updated_at":"2015-08-26T12:37:30Z","pushed_at":"2015-10-19T16:24:28Z","git_url":"git://github.com/charliedrage/atomicapp.git","ssh_url":"git@github.com:charliedrage/atomicapp.git","clone_url":"https://github.com/charliedrage/atomicapp.git","svn_url":"https://github.com/charliedrage/atomicapp","homepage":"","size":737,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:cdk2-beta3-rc1","ref":"cdk2-beta3-rc1","sha":"ec21bbbb891454690a4af36b5cd1ce75bc0acd2e","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":32819266,"name":"atomicapp","full_name":"projectatomic/atomicapp","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/atomicapp","description":"This is the reference implementation of the Nulecule container application Specification: Atomic App","fork":false,"url":"https://api.github.com/repos/projectatomic/atomicapp","forks_url":"https://api.github.com/repos/projectatomic/atomicapp/forks","keys_url":"https://api.github.com/repos/projectatomic/atomicapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/atomicapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/atomicapp/teams","hooks_url":"https://api.github.com/repos/projectatomic/atomicapp/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/atomicapp/events","assignees_url":"https://api.github.com/repos/projectatomic/atomicapp/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/atomicapp/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/atomicapp/tags","blobs_url":"https://api.github.com/repos/projectatomic/atomicapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/atomicapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/atomicapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/atomicapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/atomicapp/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/atomicapp/languages","stargazers_url":"https://api.github.com/repos/projectatomic/atomicapp/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/atomicapp/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/atomicapp/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/atomicapp/subscription","commits_url":"https://api.github.com/repos/projectatomic/atomicapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/atomicapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/atomicapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/atomicapp/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/atomicapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/atomicapp/merges","archive_url":"https://api.github.com/repos/projectatomic/atomicapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/atomicapp/downloads","issues_url":"https://api.github.com/repos/projectatomic/atomicapp/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/atomicapp/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/atomicapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/atomicapp/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/atomicapp/releases{/id}","created_at":"2015-03-24T19:09:39Z","updated_at":"2015-09-26T05:40:12Z","pushed_at":"2015-10-20T12:17:51Z","git_url":"git://github.com/projectatomic/atomicapp.git","ssh_url":"git@github.com:projectatomic/atomicapp.git","clone_url":"https://github.com/projectatomic/atomicapp.git","svn_url":"https://github.com/projectatomic/atomicapp","homepage":"","size":2351,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":69,"forks":32,"open_issues":69,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340"},"html":{"href":"https://github.com/projectatomic/atomicapp/pull/340"},"issue":{"href":"https://api.github.com/repos/projectatomic/atomicapp/issues/340"},"comments":{"href":"https://api.github.com/repos/projectatomic/atomicapp/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/atomicapp/statuses/10bcd927e4dffb78e25211c76a7c31948ad2079e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dustymabe","id":4530030,"avatar_url":"https://avatars.githubusercontent.com/u/4530030?v=3","gravatar_id":"","url":"https://api.github.com/users/dustymabe","html_url":"https://github.com/dustymabe","followers_url":"https://api.github.com/users/dustymabe/followers","following_url":"https://api.github.com/users/dustymabe/following{/other_user}","gists_url":"https://api.github.com/users/dustymabe/gists{/gist_id}","starred_url":"https://api.github.com/users/dustymabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustymabe/subscriptions","organizations_url":"https://api.github.com/users/dustymabe/orgs","repos_url":"https://api.github.com/users/dustymabe/repos","events_url":"https://api.github.com/users/dustymabe/events{/privacy}","received_events_url":"https://api.github.com/users/dustymabe/received_events","type":"User","site_admin":false},"comments":3,"review_comments":5,"commits":2,"additions":7,"deletions":51,"changed_files":2}}