{"action":"closed","number":61,"pull_request":{"url":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61","id":34649854,"html_url":"https://github.com/FriendsOfCake/travis/pull/61","diff_url":"https://github.com/FriendsOfCake/travis/pull/61.diff","patch_url":"https://github.com/FriendsOfCake/travis/pull/61.patch","issue_url":"https://api.github.com/repos/FriendsOfCake/travis/issues/61","number":61,"state":"closed","locked":false,"title":"Exclude Plugin/$PLUGIN_NAME/vendor from phpunit coverage.","user":{"login":"beporter","id":637270,"avatar_url":"https://avatars.githubusercontent.com/u/637270?v=3","gravatar_id":"","url":"https://api.github.com/users/beporter","html_url":"https://github.com/beporter","followers_url":"https://api.github.com/users/beporter/followers","following_url":"https://api.github.com/users/beporter/following{/other_user}","gists_url":"https://api.github.com/users/beporter/gists{/gist_id}","starred_url":"https://api.github.com/users/beporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beporter/subscriptions","organizations_url":"https://api.github.com/users/beporter/orgs","repos_url":"https://api.github.com/users/beporter/repos","events_url":"https://api.github.com/users/beporter/events{/privacy}","received_events_url":"https://api.github.com/users/beporter/received_events","type":"User","site_admin":false},"body":"If for any reason composer runs in the plugin's directory during a travis build, you will end up with a `vendor/` folder present. PHPUnit will then include this folder in its `clover.xml` coverage output, which can seriously throw off Coveralls code coverage reports.\r\n\r\nI can't think of any circumstances where someone might _want_ to include the `vendor/` directory in their code coverage, and its safe to exclude that folder even if it is not present or empty, so to me this change seems pretty safe to make.\r\n\r\nExpand [the contents of after_script.sh in this build](https://travis-ci.org/loadsys/CakePHP-Stateless-Auth/jobs/58286758#L241) for an example of the failure described here. Here is the corresponding [Coveralls report](https://coveralls.io/builds/2326241).","created_at":"2015-05-04T16:03:51Z","updated_at":"2015-06-09T05:47:08Z","closed_at":"2015-06-09T05:47:08Z","merged_at":"2015-06-09T05:47:08Z","merge_commit_sha":"7775eae9905bd3953affdee621a70ce746823798","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61/commits","review_comments_url":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61/comments","review_comment_url":"https://api.github.com/repos/FriendsOfCake/travis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfCake/travis/issues/61/comments","statuses_url":"https://api.github.com/repos/FriendsOfCake/travis/statuses/19d4c2afee66813ff4f7fd7f071eccf5396046e6","head":{"label":"beporter:patch-1","ref":"patch-1","sha":"19d4c2afee66813ff4f7fd7f071eccf5396046e6","user":{"login":"beporter","id":637270,"avatar_url":"https://avatars.githubusercontent.com/u/637270?v=3","gravatar_id":"","url":"https://api.github.com/users/beporter","html_url":"https://github.com/beporter","followers_url":"https://api.github.com/users/beporter/followers","following_url":"https://api.github.com/users/beporter/following{/other_user}","gists_url":"https://api.github.com/users/beporter/gists{/gist_id}","starred_url":"https://api.github.com/users/beporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beporter/subscriptions","organizations_url":"https://api.github.com/users/beporter/orgs","repos_url":"https://api.github.com/users/beporter/repos","events_url":"https://api.github.com/users/beporter/events{/privacy}","received_events_url":"https://api.github.com/users/beporter/received_events","type":"User","site_admin":false},"repo":{"id":35044360,"name":"travis","full_name":"beporter/travis","owner":{"login":"beporter","id":637270,"avatar_url":"https://avatars.githubusercontent.com/u/637270?v=3","gravatar_id":"","url":"https://api.github.com/users/beporter","html_url":"https://github.com/beporter","followers_url":"https://api.github.com/users/beporter/followers","following_url":"https://api.github.com/users/beporter/following{/other_user}","gists_url":"https://api.github.com/users/beporter/gists{/gist_id}","starred_url":"https://api.github.com/users/beporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beporter/subscriptions","organizations_url":"https://api.github.com/users/beporter/orgs","repos_url":"https://api.github.com/users/beporter/repos","events_url":"https://api.github.com/users/beporter/events{/privacy}","received_events_url":"https://api.github.com/users/beporter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beporter/travis","description":"Easy travis setup for CakePHP plugins","fork":true,"url":"https://api.github.com/repos/beporter/travis","forks_url":"https://api.github.com/repos/beporter/travis/forks","keys_url":"https://api.github.com/repos/beporter/travis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beporter/travis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beporter/travis/teams","hooks_url":"https://api.github.com/repos/beporter/travis/hooks","issue_events_url":"https://api.github.com/repos/beporter/travis/issues/events{/number}","events_url":"https://api.github.com/repos/beporter/travis/events","assignees_url":"https://api.github.com/repos/beporter/travis/assignees{/user}","branches_url":"https://api.github.com/repos/beporter/travis/branches{/branch}","tags_url":"https://api.github.com/repos/beporter/travis/tags","blobs_url":"https://api.github.com/repos/beporter/travis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beporter/travis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beporter/travis/git/refs{/sha}","trees_url":"https://api.github.com/repos/beporter/travis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beporter/travis/statuses/{sha}","languages_url":"https://api.github.com/repos/beporter/travis/languages","stargazers_url":"https://api.github.com/repos/beporter/travis/stargazers","contributors_url":"https://api.github.com/repos/beporter/travis/contributors","subscribers_url":"https://api.github.com/repos/beporter/travis/subscribers","subscription_url":"https://api.github.com/repos/beporter/travis/subscription","commits_url":"https://api.github.com/repos/beporter/travis/commits{/sha}","git_commits_url":"https://api.github.com/repos/beporter/travis/git/commits{/sha}","comments_url":"https://api.github.com/repos/beporter/travis/comments{/number}","issue_comment_url":"https://api.github.com/repos/beporter/travis/issues/comments{/number}","contents_url":"https://api.github.com/repos/beporter/travis/contents/{+path}","compare_url":"https://api.github.com/repos/beporter/travis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beporter/travis/merges","archive_url":"https://api.github.com/repos/beporter/travis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beporter/travis/downloads","issues_url":"https://api.github.com/repos/beporter/travis/issues{/number}","pulls_url":"https://api.github.com/repos/beporter/travis/pulls{/number}","milestones_url":"https://api.github.com/repos/beporter/travis/milestones{/number}","notifications_url":"https://api.github.com/repos/beporter/travis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beporter/travis/labels{/name}","releases_url":"https://api.github.com/repos/beporter/travis/releases{/id}","created_at":"2015-05-04T15:55:28Z","updated_at":"2015-05-04T15:55:29Z","pushed_at":"2015-05-04T16:03:29Z","git_url":"git://github.com/beporter/travis.git","ssh_url":"git@github.com:beporter/travis.git","clone_url":"https://github.com/beporter/travis.git","svn_url":"https://github.com/beporter/travis","homepage":"http://friendsofcake.com/","size":146,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfCake:master","ref":"master","sha":"34ba1809ba8237e9486dcbccaee6d431a97497fd","user":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"repo":{"id":12853386,"name":"travis","full_name":"FriendsOfCake/travis","owner":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfCake/travis","description":"Easy travis setup for CakePHP plugins","fork":false,"url":"https://api.github.com/repos/FriendsOfCake/travis","forks_url":"https://api.github.com/repos/FriendsOfCake/travis/forks","keys_url":"https://api.github.com/repos/FriendsOfCake/travis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfCake/travis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfCake/travis/teams","hooks_url":"https://api.github.com/repos/FriendsOfCake/travis/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfCake/travis/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfCake/travis/events","assignees_url":"https://api.github.com/repos/FriendsOfCake/travis/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfCake/travis/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfCake/travis/tags","blobs_url":"https://api.github.com/repos/FriendsOfCake/travis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfCake/travis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfCake/travis/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfCake/travis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfCake/travis/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfCake/travis/languages","stargazers_url":"https://api.github.com/repos/FriendsOfCake/travis/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfCake/travis/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfCake/travis/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfCake/travis/subscription","commits_url":"https://api.github.com/repos/FriendsOfCake/travis/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfCake/travis/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfCake/travis/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfCake/travis/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfCake/travis/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfCake/travis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfCake/travis/merges","archive_url":"https://api.github.com/repos/FriendsOfCake/travis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfCake/travis/downloads","issues_url":"https://api.github.com/repos/FriendsOfCake/travis/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfCake/travis/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfCake/travis/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfCake/travis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfCake/travis/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfCake/travis/releases{/id}","created_at":"2013-09-15T22:02:33Z","updated_at":"2015-05-30T22:50:25Z","pushed_at":"2015-06-09T05:47:08Z","git_url":"git://github.com/FriendsOfCake/travis.git","ssh_url":"git@github.com:FriendsOfCake/travis.git","clone_url":"https://github.com/FriendsOfCake/travis.git","svn_url":"https://github.com/FriendsOfCake/travis","homepage":"http://friendsofcake.com/","size":849,"stargazers_count":29,"watchers_count":29,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":13,"forks":22,"open_issues":13,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61"},"html":{"href":"https://github.com/FriendsOfCake/travis/pull/61"},"issue":{"href":"https://api.github.com/repos/FriendsOfCake/travis/issues/61"},"comments":{"href":"https://api.github.com/repos/FriendsOfCake/travis/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfCake/travis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfCake/travis/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfCake/travis/statuses/19d4c2afee66813ff4f7fd7f071eccf5396046e6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jadb","id":33527,"avatar_url":"https://avatars.githubusercontent.com/u/33527?v=3","gravatar_id":"","url":"https://api.github.com/users/jadb","html_url":"https://github.com/jadb","followers_url":"https://api.github.com/users/jadb/followers","following_url":"https://api.github.com/users/jadb/following{/other_user}","gists_url":"https://api.github.com/users/jadb/gists{/gist_id}","starred_url":"https://api.github.com/users/jadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadb/subscriptions","organizations_url":"https://api.github.com/users/jadb/orgs","repos_url":"https://api.github.com/users/jadb/repos","events_url":"https://api.github.com/users/jadb/events{/privacy}","received_events_url":"https://api.github.com/users/jadb/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}