{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/40829740","id":40829740,"diff_hunk":"@@ -0,0 +1,83 @@\n+/* This file is part of VoltDB.\n+ * Copyright (C) 2008-2015 VoltDB Inc.\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License as\n+ * published by the Free Software Foundation, either version 3 of the\n+ * License, or (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License\n+ * along with VoltDB.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+package org.voltdb;\n+\n+import org.voltdb.iv2.UniqueIdGenerator;\n+\n+import com.google_voltpatches.common.base.Preconditions;\n+\n+public class DRLogSegmentId {\n+    public static final short MAX_CLUSTER_ID = (1 << 8) - 1;\n+    public static final long MAX_SEQUENCE_NUMBER = (1L << 55) - 1L;\n+\n+    public static final long UNINITIALIZED_SEQUENCE_NUMBER = -1L;\n+\n+    public long drId;","path":"src/frontend/org/voltdb/DRLogSegmentId.java","position":30,"original_position":30,"commit_id":"66cb5329688d94fde155f229520817fd7d81d06b","original_commit_id":"66cb5329688d94fde155f229520817fd7d81d06b","user":{"login":"afrogers","id":4966215,"avatar_url":"https://avatars.githubusercontent.com/u/4966215?v=3","gravatar_id":"","url":"https://api.github.com/users/afrogers","html_url":"https://github.com/afrogers","followers_url":"https://api.github.com/users/afrogers/followers","following_url":"https://api.github.com/users/afrogers/following{/other_user}","gists_url":"https://api.github.com/users/afrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/afrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrogers/subscriptions","organizations_url":"https://api.github.com/users/afrogers/orgs","repos_url":"https://api.github.com/users/afrogers/repos","events_url":"https://api.github.com/users/afrogers/events{/privacy}","received_events_url":"https://api.github.com/users/afrogers/received_events","type":"User","site_admin":false},"body":"I'm not sure I'm entirely comfortable with this class being built entirely on state that is both public and mutable...","created_at":"2015-09-30T18:14:15Z","updated_at":"2015-09-30T18:14:15Z","html_url":"https://github.com/VoltDB/voltdb/pull/2837#discussion_r40829740","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/40829740"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2837#discussion_r40829740"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837","id":45726969,"html_url":"https://github.com/VoltDB/voltdb/pull/2837","diff_url":"https://github.com/VoltDB/voltdb/pull/2837.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2837.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2837","number":2837,"state":"open","locked":false,"title":"ENG-9022: Track both MpUniqueId and SpUniqueId in InvocationBuffers","user":{"login":"wweiss-voltdb","id":6462615,"avatar_url":"https://avatars.githubusercontent.com/u/6462615?v=3","gravatar_id":"","url":"https://api.github.com/users/wweiss-voltdb","html_url":"https://github.com/wweiss-voltdb","followers_url":"https://api.github.com/users/wweiss-voltdb/followers","following_url":"https://api.github.com/users/wweiss-voltdb/following{/other_user}","gists_url":"https://api.github.com/users/wweiss-voltdb/gists{/gist_id}","starred_url":"https://api.github.com/users/wweiss-voltdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wweiss-voltdb/subscriptions","organizations_url":"https://api.github.com/users/wweiss-voltdb/orgs","repos_url":"https://api.github.com/users/wweiss-voltdb/repos","events_url":"https://api.github.com/users/wweiss-voltdb/events{/privacy}","received_events_url":"https://api.github.com/users/wweiss-voltdb/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-22T22:49:11Z","updated_at":"2015-09-30T18:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9e5cd96e2be7512f3b90302a16ed7f4b1ded991","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2837/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/66cb5329688d94fde155f229520817fd7d81d06b","head":{"label":"VoltDB:ENG-9022-IncludeLastMpUniqueIdInApplyBinaryLog","ref":"ENG-9022-IncludeLastMpUniqueIdInApplyBinaryLog","sha":"66cb5329688d94fde155f229520817fd7d81d06b","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-09-30T15:19:00Z","pushed_at":"2015-09-30T17:50:08Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":905114,"stargazers_count":633,"watchers_count":633,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":31,"forks":187,"open_issues":31,"watchers":633,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"bab91d0f2dc98bb28ff8be711cc0c17840a4a484","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-09-30T15:19:00Z","pushed_at":"2015-09-30T17:50:08Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":905114,"stargazers_count":633,"watchers_count":633,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":31,"forks":187,"open_issues":31,"watchers":633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2837"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2837"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2837/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2837/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/66cb5329688d94fde155f229520817fd7d81d06b"}}}}