{"action":"created","comment":{"url":"https://api.github.com/repos/EQEmu/Server/pulls/comments/34824520","id":34824520,"diff_hunk":"@@ -1525,6 +1530,7 @@ luabind::scope lua_register_client() {\n \t\t.def(\"FindSpellBookSlotBySpellID\", (int(Lua_Client::*)(int))&Lua_Client::FindSpellBookSlotBySpellID)\n \t\t.def(\"UpdateTaskActivity\", (void(Lua_Client::*)(int,int,int))&Lua_Client::UpdateTaskActivity)\n \t\t.def(\"AssignTask\", (void(Lua_Client::*)(int,int))&Lua_Client::AssignTask)\n+\t\t.def(\"AssignTask\", (void(Lua_Client::*)(int,int,bool))&Lua_Client::AssignTask","path":"zone/lua_client.cpp","position":null,"original_position":16,"commit_id":"cb874ad4e2aacdadbbd73c16b0981d1d99b3a8a3","original_commit_id":"1b8f613391da1ce92799538f265abcb03326d58a","user":{"login":"hateborne","id":4691451,"avatar_url":"https://avatars.githubusercontent.com/u/4691451?v=3","gravatar_id":"","url":"https://api.github.com/users/hateborne","html_url":"https://github.com/hateborne","followers_url":"https://api.github.com/users/hateborne/followers","following_url":"https://api.github.com/users/hateborne/following{/other_user}","gists_url":"https://api.github.com/users/hateborne/gists{/gist_id}","starred_url":"https://api.github.com/users/hateborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hateborne/subscriptions","organizations_url":"https://api.github.com/users/hateborne/orgs","repos_url":"https://api.github.com/users/hateborne/repos","events_url":"https://api.github.com/users/hateborne/events{/privacy}","received_events_url":"https://api.github.com/users/hateborne/received_events","type":"User","site_admin":false},"body":"Did a live edit and resolved. Apologies. :-\\","created_at":"2015-07-16T18:56:38Z","updated_at":"2015-07-16T18:56:38Z","html_url":"https://github.com/EQEmu/Server/pull/438#discussion_r34824520","pull_request_url":"https://api.github.com/repos/EQEmu/Server/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/comments/34824520"},"html":{"href":"https://github.com/EQEmu/Server/pull/438#discussion_r34824520"},"pull_request":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/EQEmu/Server/pulls/438","id":40156723,"html_url":"https://github.com/EQEmu/Server/pull/438","diff_url":"https://github.com/EQEmu/Server/pull/438.diff","patch_url":"https://github.com/EQEmu/Server/pull/438.patch","issue_url":"https://api.github.com/repos/EQEmu/Server/issues/438","number":438,"state":"open","locked":false,"title":"Add Optional Enforce Task Level Requirement on AssignTask","user":{"login":"hateborne","id":4691451,"avatar_url":"https://avatars.githubusercontent.com/u/4691451?v=3","gravatar_id":"","url":"https://api.github.com/users/hateborne","html_url":"https://github.com/hateborne","followers_url":"https://api.github.com/users/hateborne/followers","following_url":"https://api.github.com/users/hateborne/following{/other_user}","gists_url":"https://api.github.com/users/hateborne/gists{/gist_id}","starred_url":"https://api.github.com/users/hateborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hateborne/subscriptions","organizations_url":"https://api.github.com/users/hateborne/orgs","repos_url":"https://api.github.com/users/hateborne/repos","events_url":"https://api.github.com/users/hateborne/events{/privacy}","received_events_url":"https://api.github.com/users/hateborne/received_events","type":"User","site_admin":false},"body":"Affected:\r\n* quest::assigntask\r\n* $client->AssignTask\r\n\r\nThis is to allow those task level requirements in DB to be used,\r\noptionally. It defaults to do not enforce (translated: no change for\r\ncurrent servers), but can be set with an additional flag to both\r\ncommands (see below). The LUA bit was added thanks to help from demonstar55.\r\n\r\n* quest::assigntask(703); # works\r\n* quest::assigntask(703, 1); # denies user\r\n* $client->AssignTask(701, $npc->GetID()); # works\r\n* $client->AssignTask(701, $npc->GetID(), 1); # denies user","created_at":"2015-07-16T17:52:45Z","updated_at":"2015-07-16T18:56:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c031d6717557ae1c0f940dfaa5d92dc6791c6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EQEmu/Server/pulls/438/commits","review_comments_url":"https://api.github.com/repos/EQEmu/Server/pulls/438/comments","review_comment_url":"https://api.github.com/repos/EQEmu/Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EQEmu/Server/issues/438/comments","statuses_url":"https://api.github.com/repos/EQEmu/Server/statuses/cb874ad4e2aacdadbbd73c16b0981d1d99b3a8a3","head":{"label":"hateborne:master","ref":"master","sha":"cb874ad4e2aacdadbbd73c16b0981d1d99b3a8a3","user":{"login":"hateborne","id":4691451,"avatar_url":"https://avatars.githubusercontent.com/u/4691451?v=3","gravatar_id":"","url":"https://api.github.com/users/hateborne","html_url":"https://github.com/hateborne","followers_url":"https://api.github.com/users/hateborne/followers","following_url":"https://api.github.com/users/hateborne/following{/other_user}","gists_url":"https://api.github.com/users/hateborne/gists{/gist_id}","starred_url":"https://api.github.com/users/hateborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hateborne/subscriptions","organizations_url":"https://api.github.com/users/hateborne/orgs","repos_url":"https://api.github.com/users/hateborne/repos","events_url":"https://api.github.com/users/hateborne/events{/privacy}","received_events_url":"https://api.github.com/users/hateborne/received_events","type":"User","site_admin":false},"repo":{"id":39159377,"name":"Server","full_name":"hateborne/Server","owner":{"login":"hateborne","id":4691451,"avatar_url":"https://avatars.githubusercontent.com/u/4691451?v=3","gravatar_id":"","url":"https://api.github.com/users/hateborne","html_url":"https://github.com/hateborne","followers_url":"https://api.github.com/users/hateborne/followers","following_url":"https://api.github.com/users/hateborne/following{/other_user}","gists_url":"https://api.github.com/users/hateborne/gists{/gist_id}","starred_url":"https://api.github.com/users/hateborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hateborne/subscriptions","organizations_url":"https://api.github.com/users/hateborne/orgs","repos_url":"https://api.github.com/users/hateborne/repos","events_url":"https://api.github.com/users/hateborne/events{/privacy}","received_events_url":"https://api.github.com/users/hateborne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hateborne/Server","description":"EQEmu: Core Server","fork":true,"url":"https://api.github.com/repos/hateborne/Server","forks_url":"https://api.github.com/repos/hateborne/Server/forks","keys_url":"https://api.github.com/repos/hateborne/Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hateborne/Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hateborne/Server/teams","hooks_url":"https://api.github.com/repos/hateborne/Server/hooks","issue_events_url":"https://api.github.com/repos/hateborne/Server/issues/events{/number}","events_url":"https://api.github.com/repos/hateborne/Server/events","assignees_url":"https://api.github.com/repos/hateborne/Server/assignees{/user}","branches_url":"https://api.github.com/repos/hateborne/Server/branches{/branch}","tags_url":"https://api.github.com/repos/hateborne/Server/tags","blobs_url":"https://api.github.com/repos/hateborne/Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hateborne/Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hateborne/Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hateborne/Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hateborne/Server/statuses/{sha}","languages_url":"https://api.github.com/repos/hateborne/Server/languages","stargazers_url":"https://api.github.com/repos/hateborne/Server/stargazers","contributors_url":"https://api.github.com/repos/hateborne/Server/contributors","subscribers_url":"https://api.github.com/repos/hateborne/Server/subscribers","subscription_url":"https://api.github.com/repos/hateborne/Server/subscription","commits_url":"https://api.github.com/repos/hateborne/Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hateborne/Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hateborne/Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hateborne/Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hateborne/Server/contents/{+path}","compare_url":"https://api.github.com/repos/hateborne/Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hateborne/Server/merges","archive_url":"https://api.github.com/repos/hateborne/Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hateborne/Server/downloads","issues_url":"https://api.github.com/repos/hateborne/Server/issues{/number}","pulls_url":"https://api.github.com/repos/hateborne/Server/pulls{/number}","milestones_url":"https://api.github.com/repos/hateborne/Server/milestones{/number}","notifications_url":"https://api.github.com/repos/hateborne/Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hateborne/Server/labels{/name}","releases_url":"https://api.github.com/repos/hateborne/Server/releases{/id}","created_at":"2015-07-15T20:24:28Z","updated_at":"2015-07-15T20:24:34Z","pushed_at":"2015-07-16T18:56:08Z","git_url":"git://github.com/hateborne/Server.git","ssh_url":"git@github.com:hateborne/Server.git","clone_url":"https://github.com/hateborne/Server.git","svn_url":"https://github.com/hateborne/Server","homepage":"www.eqemulator.net","size":44711,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EQEmu:master","ref":"master","sha":"c8f6b098c2d55e1cd534e48886e0c793c1c9a50b","user":{"login":"EQEmu","id":3301526,"avatar_url":"https://avatars.githubusercontent.com/u/3301526?v=3","gravatar_id":"","url":"https://api.github.com/users/EQEmu","html_url":"https://github.com/EQEmu","followers_url":"https://api.github.com/users/EQEmu/followers","following_url":"https://api.github.com/users/EQEmu/following{/other_user}","gists_url":"https://api.github.com/users/EQEmu/gists{/gist_id}","starred_url":"https://api.github.com/users/EQEmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EQEmu/subscriptions","organizations_url":"https://api.github.com/users/EQEmu/orgs","repos_url":"https://api.github.com/users/EQEmu/repos","events_url":"https://api.github.com/users/EQEmu/events{/privacy}","received_events_url":"https://api.github.com/users/EQEmu/received_events","type":"Organization","site_admin":false},"repo":{"id":7677845,"name":"Server","full_name":"EQEmu/Server","owner":{"login":"EQEmu","id":3301526,"avatar_url":"https://avatars.githubusercontent.com/u/3301526?v=3","gravatar_id":"","url":"https://api.github.com/users/EQEmu","html_url":"https://github.com/EQEmu","followers_url":"https://api.github.com/users/EQEmu/followers","following_url":"https://api.github.com/users/EQEmu/following{/other_user}","gists_url":"https://api.github.com/users/EQEmu/gists{/gist_id}","starred_url":"https://api.github.com/users/EQEmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EQEmu/subscriptions","organizations_url":"https://api.github.com/users/EQEmu/orgs","repos_url":"https://api.github.com/users/EQEmu/repos","events_url":"https://api.github.com/users/EQEmu/events{/privacy}","received_events_url":"https://api.github.com/users/EQEmu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EQEmu/Server","description":"EQEmu: Core Server","fork":false,"url":"https://api.github.com/repos/EQEmu/Server","forks_url":"https://api.github.com/repos/EQEmu/Server/forks","keys_url":"https://api.github.com/repos/EQEmu/Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EQEmu/Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EQEmu/Server/teams","hooks_url":"https://api.github.com/repos/EQEmu/Server/hooks","issue_events_url":"https://api.github.com/repos/EQEmu/Server/issues/events{/number}","events_url":"https://api.github.com/repos/EQEmu/Server/events","assignees_url":"https://api.github.com/repos/EQEmu/Server/assignees{/user}","branches_url":"https://api.github.com/repos/EQEmu/Server/branches{/branch}","tags_url":"https://api.github.com/repos/EQEmu/Server/tags","blobs_url":"https://api.github.com/repos/EQEmu/Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EQEmu/Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EQEmu/Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/EQEmu/Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EQEmu/Server/statuses/{sha}","languages_url":"https://api.github.com/repos/EQEmu/Server/languages","stargazers_url":"https://api.github.com/repos/EQEmu/Server/stargazers","contributors_url":"https://api.github.com/repos/EQEmu/Server/contributors","subscribers_url":"https://api.github.com/repos/EQEmu/Server/subscribers","subscription_url":"https://api.github.com/repos/EQEmu/Server/subscription","commits_url":"https://api.github.com/repos/EQEmu/Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/EQEmu/Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/EQEmu/Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/EQEmu/Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/EQEmu/Server/contents/{+path}","compare_url":"https://api.github.com/repos/EQEmu/Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EQEmu/Server/merges","archive_url":"https://api.github.com/repos/EQEmu/Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EQEmu/Server/downloads","issues_url":"https://api.github.com/repos/EQEmu/Server/issues{/number}","pulls_url":"https://api.github.com/repos/EQEmu/Server/pulls{/number}","milestones_url":"https://api.github.com/repos/EQEmu/Server/milestones{/number}","notifications_url":"https://api.github.com/repos/EQEmu/Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EQEmu/Server/labels{/name}","releases_url":"https://api.github.com/repos/EQEmu/Server/releases{/id}","created_at":"2013-01-18T01:13:34Z","updated_at":"2015-07-08T08:44:40Z","pushed_at":"2015-07-16T18:56:08Z","git_url":"git://github.com/EQEmu/Server.git","ssh_url":"git@github.com:EQEmu/Server.git","clone_url":"https://github.com/EQEmu/Server.git","svn_url":"https://github.com/EQEmu/Server","homepage":"www.eqemulator.net","size":64580,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":26,"forks":86,"open_issues":26,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/438"},"html":{"href":"https://github.com/EQEmu/Server/pull/438"},"issue":{"href":"https://api.github.com/repos/EQEmu/Server/issues/438"},"comments":{"href":"https://api.github.com/repos/EQEmu/Server/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EQEmu/Server/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/EQEmu/Server/statuses/cb874ad4e2aacdadbbd73c16b0981d1d99b3a8a3"}}}}