{"action":"closed","number":310,"pull_request":{"url":"https://api.github.com/repos/Yelp/Tron/pulls/310","id":43632622,"html_url":"https://github.com/Yelp/Tron/pull/310","diff_url":"https://github.com/Yelp/Tron/pull/310.diff","patch_url":"https://github.com/Yelp/Tron/pull/310.patch","issue_url":"https://api.github.com/repos/Yelp/Tron/issues/310","number":310,"state":"closed","locked":false,"title":"Add job and service support fields: owner, summary, notes.","user":{"login":"mikepea","id":9037,"avatar_url":"https://avatars.githubusercontent.com/u/9037?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepea","html_url":"https://github.com/mikepea","followers_url":"https://api.github.com/users/mikepea/followers","following_url":"https://api.github.com/users/mikepea/following{/other_user}","gists_url":"https://api.github.com/users/mikepea/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepea/subscriptions","organizations_url":"https://api.github.com/users/mikepea/orgs","repos_url":"https://api.github.com/users/mikepea/repos","events_url":"https://api.github.com/users/mikepea/events{/privacy}","received_events_url":"https://api.github.com/users/mikepea/received_events","type":"User","site_admin":false},"body":"When supporting Tron with a large configuration managed by many people and teams, it gets very difficult to see who owns what. 'git blame' and looking at the code of individual jobs, basically.\r\n\r\nNamespaces help with this, and naturally comments in the YAML files help too. However, this is pretty basic and very difficult to enforce.\r\n\r\nThis PR adds the following fields to the configuration, and extends visibility to the API and Tronview.\r\n\r\n* owner (string)\r\n* summary (string)\r\n* notes (string)\r\n\r\nThese should allow job/service authors to give reasonable hints as to who to contact in the event of maintenance/update, what the job/service does, and arbitrary notes (such as links to runbooks, details of business impacts, etc).\r\n\r\nThe fields are all optional, and default to the empty string.\r\n\r\nThe PR also updates the Vagrant playground environment to have working playground tronfig, with these fields included.\r\n\r\n","created_at":"2015-08-28T14:20:10Z","updated_at":"2015-10-02T18:35:37Z","closed_at":"2015-10-02T18:35:37Z","merged_at":"2015-10-02T18:35:37Z","merge_commit_sha":"06dd377ab13581d2af7ef993891cef15d45520e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/Tron/pulls/310/commits","review_comments_url":"https://api.github.com/repos/Yelp/Tron/pulls/310/comments","review_comment_url":"https://api.github.com/repos/Yelp/Tron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/Tron/issues/310/comments","statuses_url":"https://api.github.com/repos/Yelp/Tron/statuses/4b93a02e3fc15b269c2530f3eeceed67155db9e5","head":{"label":"mikepea:job_service_support_fields","ref":"job_service_support_fields","sha":"4b93a02e3fc15b269c2530f3eeceed67155db9e5","user":{"login":"mikepea","id":9037,"avatar_url":"https://avatars.githubusercontent.com/u/9037?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepea","html_url":"https://github.com/mikepea","followers_url":"https://api.github.com/users/mikepea/followers","following_url":"https://api.github.com/users/mikepea/following{/other_user}","gists_url":"https://api.github.com/users/mikepea/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepea/subscriptions","organizations_url":"https://api.github.com/users/mikepea/orgs","repos_url":"https://api.github.com/users/mikepea/repos","events_url":"https://api.github.com/users/mikepea/events{/privacy}","received_events_url":"https://api.github.com/users/mikepea/received_events","type":"User","site_admin":false},"repo":{"id":33280285,"name":"Tron","full_name":"mikepea/Tron","owner":{"login":"mikepea","id":9037,"avatar_url":"https://avatars.githubusercontent.com/u/9037?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepea","html_url":"https://github.com/mikepea","followers_url":"https://api.github.com/users/mikepea/followers","following_url":"https://api.github.com/users/mikepea/following{/other_user}","gists_url":"https://api.github.com/users/mikepea/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepea/subscriptions","organizations_url":"https://api.github.com/users/mikepea/orgs","repos_url":"https://api.github.com/users/mikepea/repos","events_url":"https://api.github.com/users/mikepea/events{/privacy}","received_events_url":"https://api.github.com/users/mikepea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikepea/Tron","description":"Next generation batch process scheduling and management","fork":true,"url":"https://api.github.com/repos/mikepea/Tron","forks_url":"https://api.github.com/repos/mikepea/Tron/forks","keys_url":"https://api.github.com/repos/mikepea/Tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikepea/Tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikepea/Tron/teams","hooks_url":"https://api.github.com/repos/mikepea/Tron/hooks","issue_events_url":"https://api.github.com/repos/mikepea/Tron/issues/events{/number}","events_url":"https://api.github.com/repos/mikepea/Tron/events","assignees_url":"https://api.github.com/repos/mikepea/Tron/assignees{/user}","branches_url":"https://api.github.com/repos/mikepea/Tron/branches{/branch}","tags_url":"https://api.github.com/repos/mikepea/Tron/tags","blobs_url":"https://api.github.com/repos/mikepea/Tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikepea/Tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikepea/Tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikepea/Tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikepea/Tron/statuses/{sha}","languages_url":"https://api.github.com/repos/mikepea/Tron/languages","stargazers_url":"https://api.github.com/repos/mikepea/Tron/stargazers","contributors_url":"https://api.github.com/repos/mikepea/Tron/contributors","subscribers_url":"https://api.github.com/repos/mikepea/Tron/subscribers","subscription_url":"https://api.github.com/repos/mikepea/Tron/subscription","commits_url":"https://api.github.com/repos/mikepea/Tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikepea/Tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikepea/Tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikepea/Tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikepea/Tron/contents/{+path}","compare_url":"https://api.github.com/repos/mikepea/Tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikepea/Tron/merges","archive_url":"https://api.github.com/repos/mikepea/Tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikepea/Tron/downloads","issues_url":"https://api.github.com/repos/mikepea/Tron/issues{/number}","pulls_url":"https://api.github.com/repos/mikepea/Tron/pulls{/number}","milestones_url":"https://api.github.com/repos/mikepea/Tron/milestones{/number}","notifications_url":"https://api.github.com/repos/mikepea/Tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikepea/Tron/labels{/name}","releases_url":"https://api.github.com/repos/mikepea/Tron/releases{/id}","created_at":"2015-04-02T00:27:53Z","updated_at":"2015-04-02T00:27:54Z","pushed_at":"2015-08-28T14:14:38Z","git_url":"git://github.com/mikepea/Tron.git","ssh_url":"git@github.com:mikepea/Tron.git","clone_url":"https://github.com/mikepea/Tron.git","svn_url":"https://github.com/mikepea/Tron","homepage":"","size":7532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"4fe6116f59811d4752da38c638283557953d9ce2","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":899771,"name":"Tron","full_name":"Yelp/Tron","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/Tron","description":"Next generation batch process scheduling and management","fork":false,"url":"https://api.github.com/repos/Yelp/Tron","forks_url":"https://api.github.com/repos/Yelp/Tron/forks","keys_url":"https://api.github.com/repos/Yelp/Tron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/Tron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/Tron/teams","hooks_url":"https://api.github.com/repos/Yelp/Tron/hooks","issue_events_url":"https://api.github.com/repos/Yelp/Tron/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/Tron/events","assignees_url":"https://api.github.com/repos/Yelp/Tron/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/Tron/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/Tron/tags","blobs_url":"https://api.github.com/repos/Yelp/Tron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/Tron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/Tron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/Tron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/Tron/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/Tron/languages","stargazers_url":"https://api.github.com/repos/Yelp/Tron/stargazers","contributors_url":"https://api.github.com/repos/Yelp/Tron/contributors","subscribers_url":"https://api.github.com/repos/Yelp/Tron/subscribers","subscription_url":"https://api.github.com/repos/Yelp/Tron/subscription","commits_url":"https://api.github.com/repos/Yelp/Tron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/Tron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/Tron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/Tron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/Tron/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/Tron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/Tron/merges","archive_url":"https://api.github.com/repos/Yelp/Tron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/Tron/downloads","issues_url":"https://api.github.com/repos/Yelp/Tron/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/Tron/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/Tron/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/Tron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/Tron/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/Tron/releases{/id}","created_at":"2010-09-09T20:54:04Z","updated_at":"2015-09-19T01:56:24Z","pushed_at":"2015-10-02T18:35:37Z","git_url":"git://github.com/Yelp/Tron.git","ssh_url":"git@github.com:Yelp/Tron.git","clone_url":"https://github.com/Yelp/Tron.git","svn_url":"https://github.com/Yelp/Tron","homepage":"","size":9183,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":50,"forks":41,"open_issues":50,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/310"},"html":{"href":"https://github.com/Yelp/Tron/pull/310"},"issue":{"href":"https://api.github.com/repos/Yelp/Tron/issues/310"},"comments":{"href":"https://api.github.com/repos/Yelp/Tron/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/Tron/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/Tron/statuses/4b93a02e3fc15b269c2530f3eeceed67155db9e5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yyejun","id":5640582,"avatar_url":"https://avatars.githubusercontent.com/u/5640582?v=3","gravatar_id":"","url":"https://api.github.com/users/yyejun","html_url":"https://github.com/yyejun","followers_url":"https://api.github.com/users/yyejun/followers","following_url":"https://api.github.com/users/yyejun/following{/other_user}","gists_url":"https://api.github.com/users/yyejun/gists{/gist_id}","starred_url":"https://api.github.com/users/yyejun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyejun/subscriptions","organizations_url":"https://api.github.com/users/yyejun/orgs","repos_url":"https://api.github.com/users/yyejun/repos","events_url":"https://api.github.com/users/yyejun/events{/privacy}","received_events_url":"https://api.github.com/users/yyejun/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":8,"additions":371,"deletions":14,"changed_files":14}}