{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/8282","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8282/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8282/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8282/events","html_url":"https://github.com/joomla/joomla-cms/pull/8282","id":115244907,"number":8282,"title":"Move component message to system-message-container","user":{"login":"n9iels","id":2659866,"avatar_url":"https://avatars.githubusercontent.com/u/2659866?v=3","gravatar_id":"","url":"https://api.github.com/users/n9iels","html_url":"https://github.com/n9iels","followers_url":"https://api.github.com/users/n9iels/followers","following_url":"https://api.github.com/users/n9iels/following{/other_user}","gists_url":"https://api.github.com/users/n9iels/gists{/gist_id}","starred_url":"https://api.github.com/users/n9iels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n9iels/subscriptions","organizations_url":"https://api.github.com/users/n9iels/orgs","repos_url":"https://api.github.com/users/n9iels/repos","events_url":"https://api.github.com/users/n9iels/events{/privacy}","received_events_url":"https://api.github.com/users/n9iels/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-05T09:41:39Z","updated_at":"2015-11-06T08:30:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/8282","html_url":"https://github.com/joomla/joomla-cms/pull/8282","diff_url":"https://github.com/joomla/joomla-cms/pull/8282.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/8282.patch"},"body":"With the move of all the filter from the left sidebar to `joomla.serachtools` some component messages has a small layout issue. The messages are stick to the serachtools, without padding.\r\n\r\nThis PR moves all messages like \"Enable this plugin\", \"This option is enabled\" to a `JFactory::getApplication()->enqueueMessage()`. So they will be displayed above the serachtools. All messages like \"There are no item available` stay below the searchtools.\r\n\r\n## Test instructions\r\nCompare the following screenshots\r\n1) Go to Components -> Smart Search\r\nBefore the patch:\r\n![com_finder before](https://cloud.githubusercontent.com/assets/2659866/10964458/8a5986e2-83a7-11e5-9161-70d29ccd86e8.PNG)\r\n\r\nAfter the patch:\r\n![com_finder after](https://cloud.githubusercontent.com/assets/2659866/10964461/925e7730-83a7-11e5-80b8-01d17bfd056d.PNG)\r\n\r\n2) Go to Extensions -> Manage -> Database\r\nBefore the patch:\r\n![com_installer database before](https://cloud.githubusercontent.com/assets/2659866/10964528/f1393b50-83a7-11e5-8938-3401a1aa87f4.PNG)\r\n\r\nAfter the patch:\r\n![com_install database after](https://cloud.githubusercontent.com/assets/2659866/10964538/fe40c2c8-83a7-11e5-87fe-17e11e3719f6.PNG)\r\n\r\n3) Go to Extensions -> Install\r\nBefore patch:\r\n![com_install before](https://cloud.githubusercontent.com/assets/2659866/10964573/3c6187a4-83a8-11e5-8545-9315788a2b39.PNG)\r\n\r\nAfter patch:\r\n![com_install after](https://cloud.githubusercontent.com/assets/2659866/10964578/4a1b43e4-83a8-11e5-825b-00cb9e920ad7.PNG)\r\n\r\n4) Go to Extensions -> update\r\nBefore patch:\r\n![com_install update before](https://cloud.githubusercontent.com/assets/2659866/10964658/c083c452-83a8-11e5-86d4-691e5c983f42.PNG)\r\n\r\nAfter patch:\r\n![com_install update after](https://cloud.githubusercontent.com/assets/2659866/10964665/cb739f7c-83a8-11e5-869c-690e7dab619c.PNG)\r\n\r\n5) Go to Components -> Redirect\r\nBefore the patch:\r\n![com_redirect before](https://cloud.githubusercontent.com/assets/2659866/10964722/1ba38822-83a9-11e5-87e7-1d308332a23a.PNG)\r\n\r\nAfter the patch:\r\n![com_redirect after](https://cloud.githubusercontent.com/assets/2659866/10964730/22679374-83a9-11e5-835f-3e87b2781c31.PNG)\r\n\r\n6) Go to components -> Search\r\nBefore the patch:\r\n![com_search before](https://cloud.githubusercontent.com/assets/2659866/10964780/7530e5c4-83a9-11e5-9870-40a4b9a1a42f.PNG)\r\n\r\nAfter the patch:\r\n![com_search after](https://cloud.githubusercontent.com/assets/2659866/10964785/7d489662-83a9-11e5-88ea-ee7c96a9a2b6.PNG)\r\n\r\n7) Disable the plugin, and enable/disable the Gathering statistics options. Confirm the messages are the same before and after the patch\r\n\r\n## Question\r\nDoes anybody know if the remove of `administrator/manifests/packages/pkg_weblinks.xml` in this PR is something I should care about? "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/154343808","html_url":"https://github.com/joomla/joomla-cms/pull/8282#issuecomment-154343808","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/8282","id":154343808,"user":{"login":"n9iels","id":2659866,"avatar_url":"https://avatars.githubusercontent.com/u/2659866?v=3","gravatar_id":"","url":"https://api.github.com/users/n9iels","html_url":"https://github.com/n9iels","followers_url":"https://api.github.com/users/n9iels/followers","following_url":"https://api.github.com/users/n9iels/following{/other_user}","gists_url":"https://api.github.com/users/n9iels/gists{/gist_id}","starred_url":"https://api.github.com/users/n9iels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n9iels/subscriptions","organizations_url":"https://api.github.com/users/n9iels/orgs","repos_url":"https://api.github.com/users/n9iels/repos","events_url":"https://api.github.com/users/n9iels/events{/privacy}","received_events_url":"https://api.github.com/users/n9iels/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T08:30:45Z","updated_at":"2015-11-06T08:30:45Z","body":"I can't find why and when that class and css were add. My only guess is that the colour is done for usability, so you can see the difference between the links and the normal text. For the `line-height` I have no idea...\r\nThe other css class for that view is for the loader. I think that class can stay there, because the loader is not used for many page. So we don't have to load that images every time.\r\n\r\nAnd yes off course, make the changes in LESS. How could I forget that.... :sweat_smile:"}}