{"action":"created","issue":{"url":"https://api.github.com/repos/Aeva/m.grl/issues/167","labels_url":"https://api.github.com/repos/Aeva/m.grl/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/Aeva/m.grl/issues/167/comments","events_url":"https://api.github.com/repos/Aeva/m.grl/issues/167/events","html_url":"https://github.com/Aeva/m.grl/pull/167","id":110580740,"number":167,"title":"#166 - support non-opengl 2D mode","user":{"login":"wijnen","id":1199014,"avatar_url":"https://avatars.githubusercontent.com/u/1199014?v=3","gravatar_id":"","url":"https://api.github.com/users/wijnen","html_url":"https://github.com/wijnen","followers_url":"https://api.github.com/users/wijnen/followers","following_url":"https://api.github.com/users/wijnen/following{/other_user}","gists_url":"https://api.github.com/users/wijnen/gists{/gist_id}","starred_url":"https://api.github.com/users/wijnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wijnen/subscriptions","organizations_url":"https://api.github.com/users/wijnen/orgs","repos_url":"https://api.github.com/users/wijnen/repos","events_url":"https://api.github.com/users/wijnen/events{/privacy}","received_events_url":"https://api.github.com/users/wijnen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Aeva/m.grl/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/Aeva/m.grl/labels/optimization","name":"optimization","color":"baff00"}],"state":"open","locked":false,"assignee":{"login":"Aeva","id":768449,"avatar_url":"https://avatars.githubusercontent.com/u/768449?v=3","gravatar_id":"","url":"https://api.github.com/users/Aeva","html_url":"https://github.com/Aeva","followers_url":"https://api.github.com/users/Aeva/followers","following_url":"https://api.github.com/users/Aeva/following{/other_user}","gists_url":"https://api.github.com/users/Aeva/gists{/gist_id}","starred_url":"https://api.github.com/users/Aeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aeva/subscriptions","organizations_url":"https://api.github.com/users/Aeva/orgs","repos_url":"https://api.github.com/users/Aeva/repos","events_url":"https://api.github.com/users/Aeva/events{/privacy}","received_events_url":"https://api.github.com/users/Aeva/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Aeva/m.grl/milestones/1","html_url":"https://github.com/Aeva/m.grl/milestones/Milestone%20One","labels_url":"https://api.github.com/repos/Aeva/m.grl/milestones/1/labels","id":829516,"number":1,"title":"Milestone One","description":"This milestone is complete when the jta model format's file format is stable, and there are enough core features to make this project useful for other people.\r\n\r\nThe estimated completion date is a floating target.","creator":{"login":"Aeva","id":768449,"avatar_url":"https://avatars.githubusercontent.com/u/768449?v=3","gravatar_id":"","url":"https://api.github.com/users/Aeva","html_url":"https://github.com/Aeva","followers_url":"https://api.github.com/users/Aeva/followers","following_url":"https://api.github.com/users/Aeva/following{/other_user}","gists_url":"https://api.github.com/users/Aeva/gists{/gist_id}","starred_url":"https://api.github.com/users/Aeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aeva/subscriptions","organizations_url":"https://api.github.com/users/Aeva/orgs","repos_url":"https://api.github.com/users/Aeva/repos","events_url":"https://api.github.com/users/Aeva/events{/privacy}","received_events_url":"https://api.github.com/users/Aeva/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":92,"state":"open","created_at":"2014-10-16T21:22:56Z","updated_at":"2015-11-07T03:07:48Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-10-09T03:15:35Z","updated_at":"2015-11-11T05:00:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Aeva/m.grl/pulls/167","html_url":"https://github.com/Aeva/m.grl/pull/167","diff_url":"https://github.com/Aeva/m.grl/pull/167.diff","patch_url":"https://github.com/Aeva/m.grl/pull/167.patch"},"body":"Here's the pull request for #166 as you requested.  The patch applied to the latest version, so that was easy.  I originally wrote the \"canvas\" needed to be a div; that's no longer true.  This version expects it to be a canvas, making it easier to select the mode from javascript without needing any changes in the html."},"comment":{"url":"https://api.github.com/repos/Aeva/m.grl/issues/comments/155666881","html_url":"https://github.com/Aeva/m.grl/pull/167#issuecomment-155666881","issue_url":"https://api.github.com/repos/Aeva/m.grl/issues/167","id":155666881,"user":{"login":"Aeva","id":768449,"avatar_url":"https://avatars.githubusercontent.com/u/768449?v=3","gravatar_id":"","url":"https://api.github.com/users/Aeva","html_url":"https://github.com/Aeva","followers_url":"https://api.github.com/users/Aeva/followers","following_url":"https://api.github.com/users/Aeva/following{/other_user}","gists_url":"https://api.github.com/users/Aeva/gists{/gist_id}","starred_url":"https://api.github.com/users/Aeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aeva/subscriptions","organizations_url":"https://api.github.com/users/Aeva/orgs","repos_url":"https://api.github.com/users/Aeva/repos","events_url":"https://api.github.com/users/Aeva/events{/privacy}","received_events_url":"https://api.github.com/users/Aeva/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T05:00:49Z","updated_at":"2015-11-11T05:00:49Z","body":"Getting close!  I need to find some time to review more in depth, but the one thing that stands out at the moment is that you pulled a number of areas out of files like m.graph.js and m.camera.js and put them into m.gl.js.  I would say that pulling that functionality out into its own method like you did is the right call, but it should still live in the same file.  Eg, code that pertains to the camera should live in m.camera.js.  m.gl.js exists entirely to provide dynamic bindings to shaders and abstract the crunchier parts of webgl like VBOs.\r\n\r\nIf you like, I can help clean up this feature (I think it'll mostly just be minor changes) so that we can merge it expediently, but I'd need commit access to your fork."}}