{"action":"created","issue":{"url":"https://api.github.com/repos/FPtje/DarkRP/issues/1988","labels_url":"https://api.github.com/repos/FPtje/DarkRP/issues/1988/labels{/name}","comments_url":"https://api.github.com/repos/FPtje/DarkRP/issues/1988/comments","events_url":"https://api.github.com/repos/FPtje/DarkRP/issues/1988/events","html_url":"https://github.com/FPtje/DarkRP/pull/1988","id":88855839,"number":1988,"title":"Converted all usermessages to netmessages","user":{"login":"Kefta","id":4593679,"avatar_url":"https://avatars.githubusercontent.com/u/4593679?v=3","gravatar_id":"","url":"https://api.github.com/users/Kefta","html_url":"https://github.com/Kefta","followers_url":"https://api.github.com/users/Kefta/followers","following_url":"https://api.github.com/users/Kefta/following{/other_user}","gists_url":"https://api.github.com/users/Kefta/gists{/gist_id}","starred_url":"https://api.github.com/users/Kefta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kefta/subscriptions","organizations_url":"https://api.github.com/users/Kefta/orgs","repos_url":"https://api.github.com/users/Kefta/repos","events_url":"https://api.github.com/users/Kefta/events{/privacy}","received_events_url":"https://api.github.com/users/Kefta/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2015-06-16T22:26:31Z","updated_at":"2015-06-17T07:49:38Z","closed_at":"2015-06-17T06:57:38Z","pull_request":{"url":"https://api.github.com/repos/FPtje/DarkRP/pulls/1988","html_url":"https://github.com/FPtje/DarkRP/pull/1988","diff_url":"https://github.com/FPtje/DarkRP/pull/1988.diff","patch_url":"https://github.com/FPtje/DarkRP/pull/1988.patch"},"body":"*Phew*\r\n\r\nAll these changes were rote conversion and are untested. I call out to\r\nall server owners to test these changes and report back any\r\nerrors/functionality problems.\r\n\r\nFalco, I noticed on FPP_ShareSettings, you left a comment saying you had\r\nissues with the usermessage being too large on servers with >60 people.\r\nI would test the changes you wanted to make with net messages since they\r\nhave an increased query size.\r\n\r\nAlso, I noticed some weird functionality on player hulls. You broadcasted the hull change clientside of a single player, then, set the hull size of that one player on every client. Was this intentional?\r\n\r\nLastly, I left the VOTE:getFilter() function there for legacy purposes, but changed it to return a table instead."},"comment":{"url":"https://api.github.com/repos/FPtje/DarkRP/issues/comments/112699638","html_url":"https://github.com/FPtje/DarkRP/pull/1988#issuecomment-112699638","issue_url":"https://api.github.com/repos/FPtje/DarkRP/issues/1988","id":112699638,"user":{"login":"RonPaul2012","id":11430670,"avatar_url":"https://avatars.githubusercontent.com/u/11430670?v=3","gravatar_id":"","url":"https://api.github.com/users/RonPaul2012","html_url":"https://github.com/RonPaul2012","followers_url":"https://api.github.com/users/RonPaul2012/followers","following_url":"https://api.github.com/users/RonPaul2012/following{/other_user}","gists_url":"https://api.github.com/users/RonPaul2012/gists{/gist_id}","starred_url":"https://api.github.com/users/RonPaul2012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonPaul2012/subscriptions","organizations_url":"https://api.github.com/users/RonPaul2012/orgs","repos_url":"https://api.github.com/users/RonPaul2012/repos","events_url":"https://api.github.com/users/RonPaul2012/events{/privacy}","received_events_url":"https://api.github.com/users/RonPaul2012/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T07:49:38Z","updated_at":"2015-06-17T07:49:38Z","body":"Yeah I mean I think code is right falco, catering to a majority of a playerbase that purchases scripts off of a third party website to use in this autistic cluster fucks they call \"servers\" isn't the coolest thing to do right? I mean, what ever happend to encouraging development or uniqueness? Nope! I gotta go buy that new sweet MOTD on scriptfodder because I'm 16 and don't want to put any effort into being unique. WOO THIRD PARTY SCRIPTS! YA SHITTY GMOD SERVERS! LET'S CATER TO THE PROBLEM! WOO!"}}