{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/30927241","id":30927241,"diff_hunk":"@@ -76,3 +101,12 @@ public function fire($job, $data) {\n \t\t$_SERVER['__sync.test'] = func_get_args();\n \t}\n }\n+\n+class FailingSyncQueueTestHandler {\n+\tpublic function fire($job, $data) {\n+\t\tthrow new Exception();\n+\t}\n+\tpublic function failed(){\n+\t\t$_SERVER['__sync.failed'] = true;\n+\t}\n+}","path":"tests/Queue/QueueSyncQueueTest.php","position":50,"original_position":50,"commit_id":"8b7c5a42895f41028899f9dfeb0059bcdb250183","original_commit_id":"8b7c5a42895f41028899f9dfeb0059bcdb250183","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"cs","created_at":"2015-05-22T20:17:06Z","updated_at":"2015-05-22T20:17:06Z","html_url":"https://github.com/laravel/framework/pull/8847#discussion_r30927241","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/8847","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/30927241"},"html":{"href":"https://github.com/laravel/framework/pull/8847#discussion_r30927241"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/8847"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/8847","id":36028662,"html_url":"https://github.com/laravel/framework/pull/8847","diff_url":"https://github.com/laravel/framework/pull/8847.diff","patch_url":"https://github.com/laravel/framework/pull/8847.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/8847","number":8847,"state":"closed","locked":false,"title":"[5.0] Failed job handling for SyncQueue","user":{"login":"patrickbrouwers","id":7728097,"avatar_url":"https://avatars.githubusercontent.com/u/7728097?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickbrouwers","html_url":"https://github.com/patrickbrouwers","followers_url":"https://api.github.com/users/patrickbrouwers/followers","following_url":"https://api.github.com/users/patrickbrouwers/following{/other_user}","gists_url":"https://api.github.com/users/patrickbrouwers/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickbrouwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickbrouwers/subscriptions","organizations_url":"https://api.github.com/users/patrickbrouwers/orgs","repos_url":"https://api.github.com/users/patrickbrouwers/repos","events_url":"https://api.github.com/users/patrickbrouwers/events{/privacy}","received_events_url":"https://api.github.com/users/patrickbrouwers/received_events","type":"User","site_admin":false},"body":"I love the Queued Commands/Jobs functionality. It allowed me to simply send an application notification whenever the (redis) queue failed using the `failed()` method in the `CommandHandler`.\r\n\r\nHowever it was a bit difficult to develop, because I needed to have redis and the queue worker running. When testing it with `sync` the `failed()` method never got triggered, because `sync` doesn't have a Worker. \r\n\r\nBy adding a try-catch inside the `SyncQueue@push` the failed method gets called and the `illuminate.queue.failed` event gets triggered, which helps a lot in developing the stuff that's inside the `failed()` method.","created_at":"2015-05-22T13:04:13Z","updated_at":"2015-05-22T20:17:06Z","closed_at":"2015-05-22T14:30:48Z","merged_at":"2015-05-22T14:30:48Z","merge_commit_sha":"7feb8e92a4fe347c89ebc8afcd3543cfdb29de41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/8847/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/8847/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/8847/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/8b7c5a42895f41028899f9dfeb0059bcdb250183","head":{"label":"patrickbrouwers:feature/sync-queue-failed-handling","ref":"feature/sync-queue-failed-handling","sha":"8b7c5a42895f41028899f9dfeb0059bcdb250183","user":{"login":"patrickbrouwers","id":7728097,"avatar_url":"https://avatars.githubusercontent.com/u/7728097?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickbrouwers","html_url":"https://github.com/patrickbrouwers","followers_url":"https://api.github.com/users/patrickbrouwers/followers","following_url":"https://api.github.com/users/patrickbrouwers/following{/other_user}","gists_url":"https://api.github.com/users/patrickbrouwers/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickbrouwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickbrouwers/subscriptions","organizations_url":"https://api.github.com/users/patrickbrouwers/orgs","repos_url":"https://api.github.com/users/patrickbrouwers/repos","events_url":"https://api.github.com/users/patrickbrouwers/events{/privacy}","received_events_url":"https://api.github.com/users/patrickbrouwers/received_events","type":"User","site_admin":false},"repo":{"id":36070129,"name":"framework","full_name":"patrickbrouwers/framework","owner":{"login":"patrickbrouwers","id":7728097,"avatar_url":"https://avatars.githubusercontent.com/u/7728097?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickbrouwers","html_url":"https://github.com/patrickbrouwers","followers_url":"https://api.github.com/users/patrickbrouwers/followers","following_url":"https://api.github.com/users/patrickbrouwers/following{/other_user}","gists_url":"https://api.github.com/users/patrickbrouwers/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickbrouwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickbrouwers/subscriptions","organizations_url":"https://api.github.com/users/patrickbrouwers/orgs","repos_url":"https://api.github.com/users/patrickbrouwers/repos","events_url":"https://api.github.com/users/patrickbrouwers/events{/privacy}","received_events_url":"https://api.github.com/users/patrickbrouwers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickbrouwers/framework","description":"","fork":true,"url":"https://api.github.com/repos/patrickbrouwers/framework","forks_url":"https://api.github.com/repos/patrickbrouwers/framework/forks","keys_url":"https://api.github.com/repos/patrickbrouwers/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickbrouwers/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickbrouwers/framework/teams","hooks_url":"https://api.github.com/repos/patrickbrouwers/framework/hooks","issue_events_url":"https://api.github.com/repos/patrickbrouwers/framework/issues/events{/number}","events_url":"https://api.github.com/repos/patrickbrouwers/framework/events","assignees_url":"https://api.github.com/repos/patrickbrouwers/framework/assignees{/user}","branches_url":"https://api.github.com/repos/patrickbrouwers/framework/branches{/branch}","tags_url":"https://api.github.com/repos/patrickbrouwers/framework/tags","blobs_url":"https://api.github.com/repos/patrickbrouwers/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickbrouwers/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickbrouwers/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickbrouwers/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickbrouwers/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickbrouwers/framework/languages","stargazers_url":"https://api.github.com/repos/patrickbrouwers/framework/stargazers","contributors_url":"https://api.github.com/repos/patrickbrouwers/framework/contributors","subscribers_url":"https://api.github.com/repos/patrickbrouwers/framework/subscribers","subscription_url":"https://api.github.com/repos/patrickbrouwers/framework/subscription","commits_url":"https://api.github.com/repos/patrickbrouwers/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickbrouwers/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickbrouwers/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickbrouwers/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickbrouwers/framework/contents/{+path}","compare_url":"https://api.github.com/repos/patrickbrouwers/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickbrouwers/framework/merges","archive_url":"https://api.github.com/repos/patrickbrouwers/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickbrouwers/framework/downloads","issues_url":"https://api.github.com/repos/patrickbrouwers/framework/issues{/number}","pulls_url":"https://api.github.com/repos/patrickbrouwers/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickbrouwers/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickbrouwers/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickbrouwers/framework/labels{/name}","releases_url":"https://api.github.com/repos/patrickbrouwers/framework/releases{/id}","created_at":"2015-05-22T12:03:07Z","updated_at":"2015-05-22T12:03:13Z","pushed_at":"2015-05-22T14:49:53Z","git_url":"git://github.com/patrickbrouwers/framework.git","ssh_url":"git@github.com:patrickbrouwers/framework.git","clone_url":"https://github.com/patrickbrouwers/framework.git","svn_url":"https://github.com/patrickbrouwers/framework","homepage":"http://laravel.com","size":15958,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.0","ref":"5.0","sha":"f92a8becbb31132cd92c03f94a6278a848fcfff9","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-05-22T15:14:05Z","pushed_at":"2015-05-22T20:11:28Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":67878,"stargazers_count":3602,"watchers_count":3602,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1995,"mirror_url":null,"open_issues_count":133,"forks":1995,"open_issues":133,"watchers":3602,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/8847"},"html":{"href":"https://github.com/laravel/framework/pull/8847"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/8847"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/8847/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/8847/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/8847/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/8b7c5a42895f41028899f9dfeb0059bcdb250183"}}}}