{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/14","labels_url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/14/comments","events_url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/14/events","html_url":"https://github.com/vaadin/gwt-api-generator/pull/14","id":88424715,"number":14,"title":"Generated discaimers contain information about the related component","user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-15T13:18:26Z","updated_at":"2015-06-16T12:02:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/gwt-api-generator/pulls/14","html_url":"https://github.com/vaadin/gwt-api-generator/pull/14","diff_url":"https://github.com/vaadin/gwt-api-generator/pull/14.diff","patch_url":"https://github.com/vaadin/gwt-api-generator/pull/14.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/vaadin/gwt-api-generator/14)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/comments/112401478","html_url":"https://github.com/vaadin/gwt-api-generator/pull/14#issuecomment-112401478","issue_url":"https://api.github.com/repos/vaadin/gwt-api-generator/issues/14","id":112401478,"user":{"login":"manolo","id":161853,"avatar_url":"https://avatars.githubusercontent.com/u/161853?v=3","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T12:02:53Z","updated_at":"2015-06-16T12:02:53Z","body":"\n\n\n\nReview status: 0 of 8 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[gulpfile.js, line 132 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/gwt-api-generator/14#-JrwEXXUvy70p3sGv1Tq)** ([raw file](https://github.com/vaadin/gwt-api-generator/blob/87b28a2a2ee0c49583c361b6793396f3188cec07/gulpfile.js#L132)):</sup>\nI would get rid of bowerData parameter since it comes in obj.bowerData\n\n---\n\n<sup>**[template/Element.template, line 1 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/gwt-api-generator/14#-JrwEhpjHes8msTjYpZb)** ([raw file](https://github.com/vaadin/gwt-api-generator/blob/87b28a2a2ee0c49583c361b6793396f3188cec07/template/Element.template#L1)):</sup>\nUse just disclaimer() since helper is executed in the item context\n\n---\n\n<sup>**[template/helpers.js, line 188 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/gwt-api-generator/14#-JrwEpK-gP_7b5A5TFDD)** ([raw file](https://github.com/vaadin/gwt-api-generator/blob/87b28a2a2ee0c49583c361b6793396f3188cec07/template/helpers.js#L188)):</sup>\nthis.bowerData should bring this info\n\n---\n\n<sup>**[template/ImportsMap.template, line 2 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/gwt-api-generator/14#-JrwExnT9wbI9lpAp8Im)** ([raw file](https://github.com/vaadin/gwt-api-generator/blob/87b28a2a2ee0c49583c361b6793396f3188cec07/template/ImportsMap.template#L2)):</sup>\nThis file was removed, why do you commit again?\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/vaadin/gwt-api-generator/14)\n<!-- Sent from Reviewable.io -->\n"}}