{"comment":{"url":"https://api.github.com/repos/robvdl/pyramidcms/comments/9954759","html_url":"https://github.com/robvdl/pyramidcms/commit/a1533c4668ab6fc3b921629f900d43ad432fcaea#commitcomment-9954759","id":9954759,"user":{"login":"robvdl","id":1018674,"avatar_url":"https://avatars.githubusercontent.com/u/1018674?v=3","gravatar_id":"","url":"https://api.github.com/users/robvdl","html_url":"https://github.com/robvdl","followers_url":"https://api.github.com/users/robvdl/followers","following_url":"https://api.github.com/users/robvdl/following{/other_user}","gists_url":"https://api.github.com/users/robvdl/gists{/gist_id}","starred_url":"https://api.github.com/users/robvdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robvdl/subscriptions","organizations_url":"https://api.github.com/users/robvdl/orgs","repos_url":"https://api.github.com/users/robvdl/repos","events_url":"https://api.github.com/users/robvdl/events{/privacy}","received_events_url":"https://api.github.com/users/robvdl/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"a1533c4668ab6fc3b921629f900d43ad432fcaea","created_at":"2015-02-27T11:03:59Z","updated_at":"2015-02-27T11:03:59Z","body":"I am wondering what should happen with inactive users, how you have it at the moment, if a user is in the system and disabled, it would flash the same message as if the user wasn't in the system at all, which is simply \"Invalid username or password\"\r\n\r\nIt might be better to alter the logic just a little to flash a different message if the user is there in the db but inactive, Something like \"account is inactive\" which would be a different error message, you could potentially test for that then."}}