{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Security/pulls/comments/23625303","id":23625303,"diff_hunk":"@@ -179,7 +195,7 @@ protected override void ApplyResponseChallenge()\n                 string redirectUri = notification.ProtocolMessage.CreateAuthenticationRequestUrl();\n                 if (!Uri.IsWellFormedUriString(redirectUri, UriKind.Absolute))\n                 {\n-                    _logger.WriteWarning(\"The authenticate redirect URI is malformed: \" + redirectUri);\n+                    _logger.WriteWarning(\"Uri.IsWellFormedUriString(redirectUri, UriKind.Absolute) returned 'false', redirectUri is: \" + (redirectUri ?? \"null\"));","path":"src/Microsoft.AspNet.Security.OpenIdConnect/OpenidConnectAuthenticationHandler.cs","position":62,"original_position":62,"commit_id":"e5518e6fc25874920e203dfcd923868ad5de6cbb","original_commit_id":"e5518e6fc25874920e203dfcd923868ad5de6cbb","user":{"login":"Praburaj","id":2294732,"avatar_url":"https://avatars.githubusercontent.com/u/2294732?v=3","gravatar_id":"","url":"https://api.github.com/users/Praburaj","html_url":"https://github.com/Praburaj","followers_url":"https://api.github.com/users/Praburaj/followers","following_url":"https://api.github.com/users/Praburaj/following{/other_user}","gists_url":"https://api.github.com/users/Praburaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Praburaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praburaj/subscriptions","organizations_url":"https://api.github.com/users/Praburaj/orgs","repos_url":"https://api.github.com/users/Praburaj/repos","events_url":"https://api.github.com/users/Praburaj/events{/privacy}","received_events_url":"https://api.github.com/users/Praburaj/received_events","type":"User","site_admin":false},"body":"use `_logger.WriteWarning(\"{0}\", redirectUri ?? \"null\")` overload of logger to substitute parameters. ","created_at":"2015-01-27T17:26:16Z","updated_at":"2015-01-27T17:26:16Z","html_url":"https://github.com/aspnet/Security/pull/137#discussion_r23625303","pull_request_url":"https://api.github.com/repos/aspnet/Security/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments/23625303"},"html":{"href":"https://github.com/aspnet/Security/pull/137#discussion_r23625303"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Security/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Security/pulls/137","id":28121424,"html_url":"https://github.com/aspnet/Security/pull/137","diff_url":"https://github.com/aspnet/Security/pull/137.diff","patch_url":"https://github.com/aspnet/Security/pull/137.patch","issue_url":"https://api.github.com/repos/aspnet/Security/issues/137","number":137,"state":"open","locked":false,"title":"ChallengeContext will be null with [Authorize] attribute","user":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"body":"OpenIdConnect set Ticket.Principal, get identity from there.","created_at":"2015-01-27T16:16:11Z","updated_at":"2015-01-27T17:26:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f608eac92c2f4c8908a912a0ca4e055ef1826ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Security/pulls/137/commits","review_comments_url":"https://api.github.com/repos/aspnet/Security/pulls/137/comments","review_comment_url":"https://api.github.com/repos/aspnet/Security/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Security/issues/137/comments","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/e5518e6fc25874920e203dfcd923868ad5de6cbb","head":{"label":"brentschmaltz:release","ref":"release","sha":"e5518e6fc25874920e203dfcd923868ad5de6cbb","user":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"repo":{"id":28565810,"name":"Security","full_name":"brentschmaltz/Security","owner":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars.githubusercontent.com/u/3172421?v=3","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brentschmaltz/Security","description":"Middleware for security and authorization of web apps.","fork":true,"url":"https://api.github.com/repos/brentschmaltz/Security","forks_url":"https://api.github.com/repos/brentschmaltz/Security/forks","keys_url":"https://api.github.com/repos/brentschmaltz/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brentschmaltz/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brentschmaltz/Security/teams","hooks_url":"https://api.github.com/repos/brentschmaltz/Security/hooks","issue_events_url":"https://api.github.com/repos/brentschmaltz/Security/issues/events{/number}","events_url":"https://api.github.com/repos/brentschmaltz/Security/events","assignees_url":"https://api.github.com/repos/brentschmaltz/Security/assignees{/user}","branches_url":"https://api.github.com/repos/brentschmaltz/Security/branches{/branch}","tags_url":"https://api.github.com/repos/brentschmaltz/Security/tags","blobs_url":"https://api.github.com/repos/brentschmaltz/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brentschmaltz/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brentschmaltz/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/brentschmaltz/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brentschmaltz/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/brentschmaltz/Security/languages","stargazers_url":"https://api.github.com/repos/brentschmaltz/Security/stargazers","contributors_url":"https://api.github.com/repos/brentschmaltz/Security/contributors","subscribers_url":"https://api.github.com/repos/brentschmaltz/Security/subscribers","subscription_url":"https://api.github.com/repos/brentschmaltz/Security/subscription","commits_url":"https://api.github.com/repos/brentschmaltz/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/brentschmaltz/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/brentschmaltz/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/brentschmaltz/Security/issues/comments/{number}","contents_url":"https://api.github.com/repos/brentschmaltz/Security/contents/{+path}","compare_url":"https://api.github.com/repos/brentschmaltz/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brentschmaltz/Security/merges","archive_url":"https://api.github.com/repos/brentschmaltz/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brentschmaltz/Security/downloads","issues_url":"https://api.github.com/repos/brentschmaltz/Security/issues{/number}","pulls_url":"https://api.github.com/repos/brentschmaltz/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/brentschmaltz/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/brentschmaltz/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brentschmaltz/Security/labels{/name}","releases_url":"https://api.github.com/repos/brentschmaltz/Security/releases{/id}","created_at":"2014-12-28T16:09:45Z","updated_at":"2015-01-20T00:50:18Z","pushed_at":"2015-01-27T16:15:41Z","git_url":"git://github.com/brentschmaltz/Security.git","ssh_url":"git@github.com:brentschmaltz/Security.git","clone_url":"https://github.com/brentschmaltz/Security.git","svn_url":"https://github.com/brentschmaltz/Security","homepage":"","size":722,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:release","ref":"release","sha":"d7b389e595a6a79793548e4d3671141d3e1fed48","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17723699,"name":"Security","full_name":"aspnet/Security","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Security","description":"Middleware for security and authorization of web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Security","forks_url":"https://api.github.com/repos/aspnet/Security/forks","keys_url":"https://api.github.com/repos/aspnet/Security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Security/teams","hooks_url":"https://api.github.com/repos/aspnet/Security/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Security/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Security/events","assignees_url":"https://api.github.com/repos/aspnet/Security/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Security/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Security/tags","blobs_url":"https://api.github.com/repos/aspnet/Security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Security/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Security/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Security/languages","stargazers_url":"https://api.github.com/repos/aspnet/Security/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Security/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Security/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Security/subscription","commits_url":"https://api.github.com/repos/aspnet/Security/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Security/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Security/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Security/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Security/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Security/merges","archive_url":"https://api.github.com/repos/aspnet/Security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Security/downloads","issues_url":"https://api.github.com/repos/aspnet/Security/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Security/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Security/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Security/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Security/releases{/id}","created_at":"2014-03-13T19:44:34Z","updated_at":"2015-01-22T01:05:08Z","pushed_at":"2015-01-27T00:55:24Z","git_url":"git://github.com/aspnet/Security.git","ssh_url":"git@github.com:aspnet/Security.git","clone_url":"https://github.com/aspnet/Security.git","svn_url":"https://github.com/aspnet/Security","homepage":"","size":2052,"stargazers_count":93,"watchers_count":93,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":44,"forks":36,"open_issues":44,"watchers":93,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Security/pulls/137"},"html":{"href":"https://github.com/aspnet/Security/pull/137"},"issue":{"href":"https://api.github.com/repos/aspnet/Security/issues/137"},"comments":{"href":"https://api.github.com/repos/aspnet/Security/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Security/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Security/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Security/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Security/statuses/e5518e6fc25874920e203dfcd923868ad5de6cbb"}}}}