{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29","id":46308340,"html_url":"https://github.com/nfroidure/gulp-svgicons2svgfont/pull/29","diff_url":"https://github.com/nfroidure/gulp-svgicons2svgfont/pull/29.diff","patch_url":"https://github.com/nfroidure/gulp-svgicons2svgfont/pull/29.patch","issue_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/29","number":29,"state":"closed","locked":false,"title":"fix a bug where metadataProvider slices items off the file list while its being mutated","user":{"login":"morleyzhi","id":1668327,"avatar_url":"https://avatars.githubusercontent.com/u/1668327?v=3","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"body":"I ran into an issue where gulp-svgicons2svgfont was only applying the metadataProvider to every other svg file, and the final file wasn't being generated. My theory is that I was using `require(\"babel/register\")` in Gulp, and it shims forEach into something closer to a for loop.\r\n\r\nSince this bug possibly relies on Babel, and I didn't want to add it to the project just for the test, I just used a different method for defining \"progress\" (i.e., I made a new variable to index files). Since all the tests pass, it seems okay to try for a PR, but let me know if you want me to explore writing a real test for this case.","created_at":"2015-09-29T17:40:57Z","updated_at":"2015-11-16T22:44:17Z","closed_at":"2015-11-16T22:44:17Z","merged_at":null,"merge_commit_sha":"5c1ed0304fa5384ca8995639bc6247ba08d0d37d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29/commits","review_comments_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29/comments","review_comment_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/29/comments","statuses_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/statuses/5ea69384f605f717ea17a61f96ce11ce281e058b","head":{"label":"morleyzhi:master","ref":"master","sha":"5ea69384f605f717ea17a61f96ce11ce281e058b","user":{"login":"morleyzhi","id":1668327,"avatar_url":"https://avatars.githubusercontent.com/u/1668327?v=3","gravatar_id":"","url":"https://api.github.com/users/morleyzhi","html_url":"https://github.com/morleyzhi","followers_url":"https://api.github.com/users/morleyzhi/followers","following_url":"https://api.github.com/users/morleyzhi/following{/other_user}","gists_url":"https://api.github.com/users/morleyzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/morleyzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morleyzhi/subscriptions","organizations_url":"https://api.github.com/users/morleyzhi/orgs","repos_url":"https://api.github.com/users/morleyzhi/repos","events_url":"https://api.github.com/users/morleyzhi/events{/privacy}","received_events_url":"https://api.github.com/users/morleyzhi/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"nfroidure:master","ref":"master","sha":"bf0f6288c168c6d004fb2110947a5b6cedf49a78","user":{"login":"nfroidure","id":229633,"avatar_url":"https://avatars.githubusercontent.com/u/229633?v=3","gravatar_id":"","url":"https://api.github.com/users/nfroidure","html_url":"https://github.com/nfroidure","followers_url":"https://api.github.com/users/nfroidure/followers","following_url":"https://api.github.com/users/nfroidure/following{/other_user}","gists_url":"https://api.github.com/users/nfroidure/gists{/gist_id}","starred_url":"https://api.github.com/users/nfroidure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfroidure/subscriptions","organizations_url":"https://api.github.com/users/nfroidure/orgs","repos_url":"https://api.github.com/users/nfroidure/repos","events_url":"https://api.github.com/users/nfroidure/events{/privacy}","received_events_url":"https://api.github.com/users/nfroidure/received_events","type":"User","site_admin":false},"repo":{"id":15456098,"name":"gulp-svgicons2svgfont","full_name":"nfroidure/gulp-svgicons2svgfont","owner":{"login":"nfroidure","id":229633,"avatar_url":"https://avatars.githubusercontent.com/u/229633?v=3","gravatar_id":"","url":"https://api.github.com/users/nfroidure","html_url":"https://github.com/nfroidure","followers_url":"https://api.github.com/users/nfroidure/followers","following_url":"https://api.github.com/users/nfroidure/following{/other_user}","gists_url":"https://api.github.com/users/nfroidure/gists{/gist_id}","starred_url":"https://api.github.com/users/nfroidure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfroidure/subscriptions","organizations_url":"https://api.github.com/users/nfroidure/orgs","repos_url":"https://api.github.com/users/nfroidure/repos","events_url":"https://api.github.com/users/nfroidure/events{/privacy}","received_events_url":"https://api.github.com/users/nfroidure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfroidure/gulp-svgicons2svgfont","description":"Bundle several SVG icons to a single SVG font","fork":false,"url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont","forks_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/forks","keys_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/teams","hooks_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/hooks","issue_events_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/events{/number}","events_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/events","assignees_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/assignees{/user}","branches_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/branches{/branch}","tags_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/tags","blobs_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/statuses/{sha}","languages_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/languages","stargazers_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/stargazers","contributors_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/contributors","subscribers_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/subscribers","subscription_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/subscription","commits_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/contents/{+path}","compare_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/merges","archive_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/downloads","issues_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues{/number}","pulls_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls{/number}","milestones_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/milestones{/number}","notifications_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/labels{/name}","releases_url":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/releases{/id}","created_at":"2013-12-26T16:27:22Z","updated_at":"2015-10-28T13:10:16Z","pushed_at":"2015-10-30T13:44:23Z","git_url":"git://github.com/nfroidure/gulp-svgicons2svgfont.git","ssh_url":"git@github.com:nfroidure/gulp-svgicons2svgfont.git","clone_url":"https://github.com/nfroidure/gulp-svgicons2svgfont.git","svn_url":"https://github.com/nfroidure/gulp-svgicons2svgfont","homepage":null,"size":520,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":0,"forks":19,"open_issues":0,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29"},"html":{"href":"https://github.com/nfroidure/gulp-svgicons2svgfont/pull/29"},"issue":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/29"},"comments":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/nfroidure/gulp-svgicons2svgfont/statuses/5ea69384f605f717ea17a61f96ce11ce281e058b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":1}}