{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/22444573","id":22444573,"diff_hunk":"@@ -0,0 +1,36 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.spark.streaming.util\n+\n+\n+private[streaming] object TimeoutUtils {\n+  /**\n+   * Waiting function with a timeout.\n+   * Returns true if done, false for timeout\n+   */\n+  def waitUntilDone(timeout:Long, done:() => Boolean): Boolean = {","path":"streaming/src/main/scala/org/apache/spark/streaming/util/TimeoutUtils.scala","position":25,"original_position":25,"commit_id":"8f0b6365274b437299f60fa25195c166750007fb","original_commit_id":"8f0b6365274b437299f60fa25195c166750007fb","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"body":"Also, this method is kind of similar to ScalaTest's `eventually`; maybe we can adopt some of the sugar / syntax from there (e.g. timeouts and polling intervals using the Scala `Duration` class), although I guess there is the key difference that `eventually` throws exceptions while this returns booleans to signal success/failure.","created_at":"2015-01-05T00:27:50Z","updated_at":"2015-01-05T00:27:50Z","html_url":"https://github.com/apache/spark/pull/3868#discussion_r22444573","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/3868","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/22444573"},"html":{"href":"https://github.com/apache/spark/pull/3868#discussion_r22444573"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/3868"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/3868","id":26741046,"html_url":"https://github.com/apache/spark/pull/3868","diff_url":"https://github.com/apache/spark/pull/3868.diff","patch_url":"https://github.com/apache/spark/pull/3868.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/3868","number":3868,"state":"open","locked":false,"title":"[STREAMING] SPARK-4986 Wait for receivers to deregister and receiver job to terminate","user":{"login":"cleaton","id":200892,"avatar_url":"https://avatars.githubusercontent.com/u/200892?v=3","gravatar_id":"","url":"https://api.github.com/users/cleaton","html_url":"https://github.com/cleaton","followers_url":"https://api.github.com/users/cleaton/followers","following_url":"https://api.github.com/users/cleaton/following{/other_user}","gists_url":"https://api.github.com/users/cleaton/gists{/gist_id}","starred_url":"https://api.github.com/users/cleaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleaton/subscriptions","organizations_url":"https://api.github.com/users/cleaton/orgs","repos_url":"https://api.github.com/users/cleaton/repos","events_url":"https://api.github.com/users/cleaton/events{/privacy}","received_events_url":"https://api.github.com/users/cleaton/received_events","type":"User","site_admin":false},"body":"Spark Streaming does not wait for all receivers to deregister and the receiver job to terminate before killing spark context which can cause data loss. This PR solves this by waiting for all receivers in ReceiverTracker stop function when using graceful shutdown.\r\n\r\nThis together with https://github.com/apache/spark/pull/3857 fixes SPARK-4986.","created_at":"2015-01-01T06:55:25Z","updated_at":"2015-01-05T00:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc96654e0275fe7b4b32c861f0b5a64e11bb44f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/3868/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/3868/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments/{number}","comments_url":"https://api.github.com/repos/apache/spark/issues/3868/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8f0b6365274b437299f60fa25195c166750007fb","head":{"label":"cleaton:gracefulshutdown","ref":"gracefulshutdown","sha":"8f0b6365274b437299f60fa25195c166750007fb","user":{"login":"cleaton","id":200892,"avatar_url":"https://avatars.githubusercontent.com/u/200892?v=3","gravatar_id":"","url":"https://api.github.com/users/cleaton","html_url":"https://github.com/cleaton","followers_url":"https://api.github.com/users/cleaton/followers","following_url":"https://api.github.com/users/cleaton/following{/other_user}","gists_url":"https://api.github.com/users/cleaton/gists{/gist_id}","starred_url":"https://api.github.com/users/cleaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleaton/subscriptions","organizations_url":"https://api.github.com/users/cleaton/orgs","repos_url":"https://api.github.com/users/cleaton/repos","events_url":"https://api.github.com/users/cleaton/events{/privacy}","received_events_url":"https://api.github.com/users/cleaton/received_events","type":"User","site_admin":false},"repo":{"id":28681174,"name":"spark","full_name":"cleaton/spark","owner":{"login":"cleaton","id":200892,"avatar_url":"https://avatars.githubusercontent.com/u/200892?v=3","gravatar_id":"","url":"https://api.github.com/users/cleaton","html_url":"https://github.com/cleaton","followers_url":"https://api.github.com/users/cleaton/followers","following_url":"https://api.github.com/users/cleaton/following{/other_user}","gists_url":"https://api.github.com/users/cleaton/gists{/gist_id}","starred_url":"https://api.github.com/users/cleaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleaton/subscriptions","organizations_url":"https://api.github.com/users/cleaton/orgs","repos_url":"https://api.github.com/users/cleaton/repos","events_url":"https://api.github.com/users/cleaton/events{/privacy}","received_events_url":"https://api.github.com/users/cleaton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cleaton/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/cleaton/spark","forks_url":"https://api.github.com/repos/cleaton/spark/forks","keys_url":"https://api.github.com/repos/cleaton/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleaton/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleaton/spark/teams","hooks_url":"https://api.github.com/repos/cleaton/spark/hooks","issue_events_url":"https://api.github.com/repos/cleaton/spark/issues/events{/number}","events_url":"https://api.github.com/repos/cleaton/spark/events","assignees_url":"https://api.github.com/repos/cleaton/spark/assignees{/user}","branches_url":"https://api.github.com/repos/cleaton/spark/branches{/branch}","tags_url":"https://api.github.com/repos/cleaton/spark/tags","blobs_url":"https://api.github.com/repos/cleaton/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleaton/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleaton/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleaton/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleaton/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/cleaton/spark/languages","stargazers_url":"https://api.github.com/repos/cleaton/spark/stargazers","contributors_url":"https://api.github.com/repos/cleaton/spark/contributors","subscribers_url":"https://api.github.com/repos/cleaton/spark/subscribers","subscription_url":"https://api.github.com/repos/cleaton/spark/subscription","commits_url":"https://api.github.com/repos/cleaton/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleaton/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleaton/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleaton/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/cleaton/spark/contents/{+path}","compare_url":"https://api.github.com/repos/cleaton/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleaton/spark/merges","archive_url":"https://api.github.com/repos/cleaton/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleaton/spark/downloads","issues_url":"https://api.github.com/repos/cleaton/spark/issues{/number}","pulls_url":"https://api.github.com/repos/cleaton/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/cleaton/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/cleaton/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleaton/spark/labels{/name}","releases_url":"https://api.github.com/repos/cleaton/spark/releases{/id}","created_at":"2015-01-01T05:41:05Z","updated_at":"2015-01-01T05:41:20Z","pushed_at":"2015-01-01T06:46:26Z","git_url":"git://github.com/cleaton/spark.git","ssh_url":"git@github.com:cleaton/spark.git","clone_url":"https://github.com/cleaton/spark.git","svn_url":"https://github.com/cleaton/spark","homepage":null,"size":87959,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:branch-1.2","ref":"branch-1.2","sha":"434ea009cd7efb2c29e88a889e87f501647a7fa6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments/{number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-01-04T21:29:54Z","pushed_at":"2015-01-04T21:30:52Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1086961,"stargazers_count":2474,"watchers_count":2474,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2197,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":288,"forks":2197,"open_issues":288,"watchers":2474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/3868"},"html":{"href":"https://github.com/apache/spark/pull/3868"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/3868"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/3868/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/3868/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/3868/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8f0b6365274b437299f60fa25195c166750007fb"}}}}