{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/26050","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/26050/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/26050/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/26050/events","html_url":"https://github.com/rust-lang/rust/pull/26050","id":85735198,"number":26050,"title":"LinkedList: Incremental improvements","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-06-06T10:47:53Z","updated_at":"2015-06-06T18:09:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/26050","html_url":"https://github.com/rust-lang/rust/pull/26050","diff_url":"https://github.com/rust-lang/rust/pull/26050.diff","patch_url":"https://github.com/rust-lang/rust/pull/26050.patch"},"body":"The recent bug that was found in LinkedList reminded me of some general cleanup\r\nthat's been waiting for some time.\r\n\r\n- Use a loop from the front in Drop, it works just as well and without an unsafe block\r\n- Change Rawlink methods to use `unsafe` in an idiomatic way. This does mean that\r\nwe need an unsafe block for each dereference of a raw link. Even then, the extent\r\nof unsafe-critical code is even larger of course, since safety depends on the whole\r\ndata structure's integrity. This is a general problem we are aware of.\r\n- Some cleanup just to try to decrease the amount of Rawlink handling."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/109626848","html_url":"https://github.com/rust-lang/rust/pull/26050#issuecomment-109626848","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/26050","id":109626848,"user":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"created_at":"2015-06-06T18:09:54Z","updated_at":"2015-06-06T18:09:54Z","body":":pushpin: Commit 32037a5 has been approved by `Gankro`\n\n<!-- @bors r=Gankro 32037a5696272f1c34f3692dcdc59b4ada91bdc7 -->"}}