{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1","id":19015089,"html_url":"https://github.com/AU-Landing-Project/rssimport/pull/1","diff_url":"https://github.com/AU-Landing-Project/rssimport/pull/1.diff","patch_url":"https://github.com/AU-Landing-Project/rssimport/pull/1.patch","issue_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/1","number":1,"state":"closed","locked":false,"title":"FR translation + ESOPE improvements","user":{"login":"Facyla","id":286492,"avatar_url":"https://avatars.githubusercontent.com/u/286492?v=3","gravatar_id":"","url":"https://api.github.com/users/Facyla","html_url":"https://github.com/Facyla","followers_url":"https://api.github.com/users/Facyla/followers","following_url":"https://api.github.com/users/Facyla/following{/other_user}","gists_url":"https://api.github.com/users/Facyla/gists{/gist_id}","starred_url":"https://api.github.com/users/Facyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Facyla/subscriptions","organizations_url":"https://api.github.com/users/Facyla/orgs","repos_url":"https://api.github.com/users/Facyla/repos","events_url":"https://api.github.com/users/Facyla/events{/privacy}","received_events_url":"https://api.github.com/users/Facyla/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI've updated your nice plugin with some changes that better fit our needs, here are the changes details : \r\n- languages/en.php : only spacing +  new string\r\n- languages/fr.php : added\r\n- views/default/plugins/rssimport/settings.php : added 2 settings \r\n   1. Imported element container setting : defaults to the container, instead of the owner, so to the group in a group, and the user when used outside of a group\r\n   2. Enable per-tool import setting : gives a finer control over import availability\r\n   Also there was another option (in a previous backport to 1.6) that let the tool be restricted to user/admins and also groupadmin - which is not enabled in this PR (as there is already a user/admin setting)\r\n- lib/functions.php : new functions that implement the added settings, and also adds a filtering function based on imported domain name + real source URL detection. And also use a translation string for date.\r\n\r\nIf you are interested into these changes, we can discuss it further so i can update it until it's OK for you to merge ?\r\nI could make a few more changes such as changing the defaults so it better integrates with existing instances, implement the group admin setting (which i think gives much more flexibility for big networks), and add a hook in the filtering function so it becomes more extendable...\r\n\r\nPlease let me know if you are interested.\r\n\r\nBest regards,\r\nFlorian DANIEL","created_at":"2014-07-29T09:04:17Z","updated_at":"2015-10-09T07:20:29Z","closed_at":"2015-10-09T07:20:28Z","merged_at":"2015-10-09T07:20:28Z","merge_commit_sha":"9f44062e64b8a2a49a1f5e459b00d94bb25833b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/1/comments","statuses_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/statuses/1a7c4fd4abb9cf6689d5475c3a61a53a9b612fbb","head":{"label":"Facyla:master","ref":"master","sha":"1a7c4fd4abb9cf6689d5475c3a61a53a9b612fbb","user":{"login":"Facyla","id":286492,"avatar_url":"https://avatars.githubusercontent.com/u/286492?v=3","gravatar_id":"","url":"https://api.github.com/users/Facyla","html_url":"https://github.com/Facyla","followers_url":"https://api.github.com/users/Facyla/followers","following_url":"https://api.github.com/users/Facyla/following{/other_user}","gists_url":"https://api.github.com/users/Facyla/gists{/gist_id}","starred_url":"https://api.github.com/users/Facyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Facyla/subscriptions","organizations_url":"https://api.github.com/users/Facyla/orgs","repos_url":"https://api.github.com/users/Facyla/repos","events_url":"https://api.github.com/users/Facyla/events{/privacy}","received_events_url":"https://api.github.com/users/Facyla/received_events","type":"User","site_admin":false},"repo":{"id":22373374,"name":"rssimport","full_name":"Facyla/rssimport","owner":{"login":"Facyla","id":286492,"avatar_url":"https://avatars.githubusercontent.com/u/286492?v=3","gravatar_id":"","url":"https://api.github.com/users/Facyla","html_url":"https://github.com/Facyla","followers_url":"https://api.github.com/users/Facyla/followers","following_url":"https://api.github.com/users/Facyla/following{/other_user}","gists_url":"https://api.github.com/users/Facyla/gists{/gist_id}","starred_url":"https://api.github.com/users/Facyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Facyla/subscriptions","organizations_url":"https://api.github.com/users/Facyla/orgs","repos_url":"https://api.github.com/users/Facyla/repos","events_url":"https://api.github.com/users/Facyla/events{/privacy}","received_events_url":"https://api.github.com/users/Facyla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Facyla/rssimport","description":"Import RSS feed items into various Elgg content types","fork":true,"url":"https://api.github.com/repos/Facyla/rssimport","forks_url":"https://api.github.com/repos/Facyla/rssimport/forks","keys_url":"https://api.github.com/repos/Facyla/rssimport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Facyla/rssimport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Facyla/rssimport/teams","hooks_url":"https://api.github.com/repos/Facyla/rssimport/hooks","issue_events_url":"https://api.github.com/repos/Facyla/rssimport/issues/events{/number}","events_url":"https://api.github.com/repos/Facyla/rssimport/events","assignees_url":"https://api.github.com/repos/Facyla/rssimport/assignees{/user}","branches_url":"https://api.github.com/repos/Facyla/rssimport/branches{/branch}","tags_url":"https://api.github.com/repos/Facyla/rssimport/tags","blobs_url":"https://api.github.com/repos/Facyla/rssimport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Facyla/rssimport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Facyla/rssimport/git/refs{/sha}","trees_url":"https://api.github.com/repos/Facyla/rssimport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Facyla/rssimport/statuses/{sha}","languages_url":"https://api.github.com/repos/Facyla/rssimport/languages","stargazers_url":"https://api.github.com/repos/Facyla/rssimport/stargazers","contributors_url":"https://api.github.com/repos/Facyla/rssimport/contributors","subscribers_url":"https://api.github.com/repos/Facyla/rssimport/subscribers","subscription_url":"https://api.github.com/repos/Facyla/rssimport/subscription","commits_url":"https://api.github.com/repos/Facyla/rssimport/commits{/sha}","git_commits_url":"https://api.github.com/repos/Facyla/rssimport/git/commits{/sha}","comments_url":"https://api.github.com/repos/Facyla/rssimport/comments{/number}","issue_comment_url":"https://api.github.com/repos/Facyla/rssimport/issues/comments{/number}","contents_url":"https://api.github.com/repos/Facyla/rssimport/contents/{+path}","compare_url":"https://api.github.com/repos/Facyla/rssimport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Facyla/rssimport/merges","archive_url":"https://api.github.com/repos/Facyla/rssimport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Facyla/rssimport/downloads","issues_url":"https://api.github.com/repos/Facyla/rssimport/issues{/number}","pulls_url":"https://api.github.com/repos/Facyla/rssimport/pulls{/number}","milestones_url":"https://api.github.com/repos/Facyla/rssimport/milestones{/number}","notifications_url":"https://api.github.com/repos/Facyla/rssimport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Facyla/rssimport/labels{/name}","releases_url":"https://api.github.com/repos/Facyla/rssimport/releases{/id}","created_at":"2014-07-29T08:45:43Z","updated_at":"2014-07-29T08:49:47Z","pushed_at":"2014-07-29T08:49:47Z","git_url":"git://github.com/Facyla/rssimport.git","ssh_url":"git@github.com:Facyla/rssimport.git","clone_url":"https://github.com/Facyla/rssimport.git","svn_url":"https://github.com/Facyla/rssimport","homepage":null,"size":690,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AU-Landing-Project:master","ref":"master","sha":"562df31543bfa4bb8800d4573605aee115387233","user":{"login":"AU-Landing-Project","id":3934216,"avatar_url":"https://avatars.githubusercontent.com/u/3934216?v=3","gravatar_id":"","url":"https://api.github.com/users/AU-Landing-Project","html_url":"https://github.com/AU-Landing-Project","followers_url":"https://api.github.com/users/AU-Landing-Project/followers","following_url":"https://api.github.com/users/AU-Landing-Project/following{/other_user}","gists_url":"https://api.github.com/users/AU-Landing-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/AU-Landing-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AU-Landing-Project/subscriptions","organizations_url":"https://api.github.com/users/AU-Landing-Project/orgs","repos_url":"https://api.github.com/users/AU-Landing-Project/repos","events_url":"https://api.github.com/users/AU-Landing-Project/events{/privacy}","received_events_url":"https://api.github.com/users/AU-Landing-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":5440681,"name":"rssimport","full_name":"AU-Landing-Project/rssimport","owner":{"login":"AU-Landing-Project","id":3934216,"avatar_url":"https://avatars.githubusercontent.com/u/3934216?v=3","gravatar_id":"","url":"https://api.github.com/users/AU-Landing-Project","html_url":"https://github.com/AU-Landing-Project","followers_url":"https://api.github.com/users/AU-Landing-Project/followers","following_url":"https://api.github.com/users/AU-Landing-Project/following{/other_user}","gists_url":"https://api.github.com/users/AU-Landing-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/AU-Landing-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AU-Landing-Project/subscriptions","organizations_url":"https://api.github.com/users/AU-Landing-Project/orgs","repos_url":"https://api.github.com/users/AU-Landing-Project/repos","events_url":"https://api.github.com/users/AU-Landing-Project/events{/privacy}","received_events_url":"https://api.github.com/users/AU-Landing-Project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AU-Landing-Project/rssimport","description":"Import RSS feed items into various Elgg content types","fork":false,"url":"https://api.github.com/repos/AU-Landing-Project/rssimport","forks_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/forks","keys_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/teams","hooks_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/hooks","issue_events_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/events{/number}","events_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/events","assignees_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/assignees{/user}","branches_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/branches{/branch}","tags_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/tags","blobs_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/git/refs{/sha}","trees_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/statuses/{sha}","languages_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/languages","stargazers_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/stargazers","contributors_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/contributors","subscribers_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/subscribers","subscription_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/subscription","commits_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/commits{/sha}","git_commits_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/git/commits{/sha}","comments_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/comments{/number}","issue_comment_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/comments{/number}","contents_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/contents/{+path}","compare_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/merges","archive_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/downloads","issues_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues{/number}","pulls_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls{/number}","milestones_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/milestones{/number}","notifications_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/labels{/name}","releases_url":"https://api.github.com/repos/AU-Landing-Project/rssimport/releases{/id}","created_at":"2012-08-16T15:24:07Z","updated_at":"2013-10-01T08:24:17Z","pushed_at":"2015-10-09T07:20:29Z","git_url":"git://github.com/AU-Landing-Project/rssimport.git","ssh_url":"git@github.com:AU-Landing-Project/rssimport.git","clone_url":"https://github.com/AU-Landing-Project/rssimport.git","svn_url":"https://github.com/AU-Landing-Project/rssimport","homepage":null,"size":747,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1"},"html":{"href":"https://github.com/AU-Landing-Project/rssimport/pull/1"},"issue":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/1"},"comments":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AU-Landing-Project/rssimport/statuses/1a7c4fd4abb9cf6689d5475c3a61a53a9b612fbb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"beck24","id":738363,"avatar_url":"https://avatars.githubusercontent.com/u/738363?v=3","gravatar_id":"","url":"https://api.github.com/users/beck24","html_url":"https://github.com/beck24","followers_url":"https://api.github.com/users/beck24/followers","following_url":"https://api.github.com/users/beck24/following{/other_user}","gists_url":"https://api.github.com/users/beck24/gists{/gist_id}","starred_url":"https://api.github.com/users/beck24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beck24/subscriptions","organizations_url":"https://api.github.com/users/beck24/orgs","repos_url":"https://api.github.com/users/beck24/repos","events_url":"https://api.github.com/users/beck24/events{/privacy}","received_events_url":"https://api.github.com/users/beck24/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":433,"deletions":114,"changed_files":4}}