{"action":"created","issue":{"url":"https://api.github.com/repos/kframework/k/issues/1819","labels_url":"https://api.github.com/repos/kframework/k/issues/1819/labels{/name}","comments_url":"https://api.github.com/repos/kframework/k/issues/1819/comments","events_url":"https://api.github.com/repos/kframework/k/issues/1819/events","html_url":"https://github.com/kframework/k/pull/1819","id":114932236,"number":1819,"title":"Kil Kill","user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=3","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-03T23:14:51Z","updated_at":"2015-11-04T18:27:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kframework/k/pulls/1819","html_url":"https://github.com/kframework/k/pull/1819","diff_url":"https://github.com/kframework/k/pull/1819.diff","patch_url":"https://github.com/kframework/k/pull/1819.patch"},"body":"**please review**"},"comment":{"url":"https://api.github.com/repos/kframework/k/issues/comments/153820869","html_url":"https://github.com/kframework/k/pull/1819#issuecomment-153820869","issue_url":"https://api.github.com/repos/kframework/k/issues/1819","id":153820869,"user":{"login":"dwightguth","id":5104541,"avatar_url":"https://avatars.githubusercontent.com/u/5104541?v=3","gravatar_id":"","url":"https://api.github.com/users/dwightguth","html_url":"https://github.com/dwightguth","followers_url":"https://api.github.com/users/dwightguth/followers","following_url":"https://api.github.com/users/dwightguth/following{/other_user}","gists_url":"https://api.github.com/users/dwightguth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwightguth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwightguth/subscriptions","organizations_url":"https://api.github.com/users/dwightguth/orgs","repos_url":"https://api.github.com/users/dwightguth/repos","events_url":"https://api.github.com/users/dwightguth/events{/privacy}","received_events_url":"https://api.github.com/users/dwightguth/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T18:27:55Z","updated_at":"2015-11-04T18:27:55Z","body":"@andreistefanescu @cos @bmmoore @radumereuta @daejunpark @msaxena2 @laurayuwen  @grosu please review\r\n\r\n### things I deleted ###\r\n- sdf parser\r\n- old krun, kompile, kast frontends\r\n- old compiler\r\n- old debugger, executor, model checker, prover frontends\r\n- old unparser\r\n- unparser and unflatten backend\r\n- `--kore` flag (now the default)\r\n- dead code arising from deletion of the above\r\n\r\n### things I did not delete ###\r\n- html, latex, pdf, doc, coq backends\r\n- checks that need to be rewritten for kore\r\n- kil hierarchy\r\n\r\n### things I moved ###\r\n- various static things that were part of a class I deleted but used by the new pipeline\r\n- various classes that were part of a package that I deleted but were used by the new pipeline\r\n\r\n### things I commented out ###\r\n- all the kil tests in ktest. None of them pass still because their definitions have not yet been updated. I think we should make a major push following this merge to add back as many definitions as possible to improve test coverage..\r\n\r\nI suggest you review the diff one commit at a time. I separated out the deletions from the changes to Java code, and from the modified ktest xml files. The deletions commit contains only deletions so you should be able to review it easily on the command line if it gets cut off. Just do something like \"git show 612db45 --name-only\" and it will spit out a complete list of deleted files.\r\n\r\nIf we need to bring anything back, we can always do that. I didn't comment out any of the KORE tests and as you can see they all still pass, so I don't think anything got deleted that was part of the KORE pipeline. But there are certainly things that got deleted that will need to be converted into the new pipeline, like collection normalization and lexicographic sorting of search results."}}