{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/23530968","id":23530968,"diff_hunk":"@@ -0,0 +1,26 @@\n+/*\n+ * Hibernate Search, full-text search for your domain model\n+ *\n+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later\n+ * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.\n+ */\n+package org.hibernate.search.test.errorhandling;\n+\n+import org.hibernate.cfg.Configuration;\n+import org.hibernate.search.cfg.Environment;\n+import org.hibernate.search.testsupport.TestForIssue;\n+\n+/**\n+ * Test for making sure error handlers can also be passed as instances rather than via their FQN.\n+ *\n+ * @author Gunnar Morling\n+ */\n+@TestForIssue(jiraKey = \"HSEARCH-1624\")\n+public class ErrorHandlerGivenAsInstanceTest extends ErrorHandlingDuringDocumentCreationTest {","path":"orm/src/test/java/org/hibernate/search/test/errorhandling/ErrorHandlerGivenAsInstanceTest.java","position":19,"original_position":19,"commit_id":"6ccb5b10992a3381d0f22b10095e62379aa052dc","original_commit_id":"6ccb5b10992a3381d0f22b10095e62379aa052dc","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"> Ok, that was the quickest to do but I can change it the way you describe. Probably better :)\r\n\r\nthanks","created_at":"2015-01-26T13:52:37Z","updated_at":"2015-01-26T13:52:37Z","html_url":"https://github.com/hibernate/hibernate-search/pull/773#discussion_r23530968","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/23530968"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/773#discussion_r23530968"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773","id":28024507,"html_url":"https://github.com/hibernate/hibernate-search/pull/773","diff_url":"https://github.com/hibernate/hibernate-search/pull/773.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/773.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/773","number":773,"state":"open","locked":false,"title":"HSEARCH-1624 Allowing error handlers to be given as instances","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-26T12:56:49Z","updated_at":"2015-01-26T13:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5476da5d858096fdd1374bc026f05976da89f3d","assignee":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/773/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/6ccb5b10992a3381d0f22b10095e62379aa052dc","head":{"label":"gunnarmorling:HSEARCH-1624","ref":"HSEARCH-1624","sha":"6ccb5b10992a3381d0f22b10095e62379aa052dc","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"repo":{"id":10077974,"name":"hibernate-search","full_name":"gunnarmorling/hibernate-search","owner":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunnarmorling/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/gunnarmorling/hibernate-search","forks_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/forks","keys_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/teams","hooks_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/events","assignees_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/tags","blobs_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/subscription","commits_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/merges","archive_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/downloads","issues_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/releases{/id}","created_at":"2013-05-15T12:21:58Z","updated_at":"2014-08-07T13:43:45Z","pushed_at":"2015-01-26T13:05:50Z","git_url":"git://github.com/gunnarmorling/hibernate-search.git","ssh_url":"git@github.com:gunnarmorling/hibernate-search.git","clone_url":"https://github.com/gunnarmorling/hibernate-search.git","svn_url":"https://github.com/gunnarmorling/hibernate-search","homepage":"http://search.hibernate.org","size":39573,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"f1d677ddb4bac00c28cbdfe9eaf13732416e0887","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments/{number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","created_at":"2010-10-15T15:55:09Z","updated_at":"2015-01-25T13:31:44Z","pushed_at":"2015-01-22T18:36:44Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":62274,"stargazers_count":138,"watchers_count":138,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":5,"forks":97,"open_issues":5,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/773"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/773"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/6ccb5b10992a3381d0f22b10095e62379aa052dc"}}}}