{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/zktraffic/pulls/comments/46508885","id":46508885,"diff_hunk":"@@ -1,7 +1,7 @@\n ChangeLog\n =========\n \n-0.1.7 (2015-07-XX)","path":"CHANGES.md","position":4,"original_position":4,"commit_id":"1c0e7076ebf06dca5ac392078edbac2f1f58e972","original_commit_id":"1c0e7076ebf06dca5ac392078edbac2f1f58e972","user":{"login":"Yasumoto","id":48383,"avatar_url":"https://avatars.githubusercontent.com/u/48383?v=3","gravatar_id":"","url":"https://api.github.com/users/Yasumoto","html_url":"https://github.com/Yasumoto","followers_url":"https://api.github.com/users/Yasumoto/followers","following_url":"https://api.github.com/users/Yasumoto/following{/other_user}","gists_url":"https://api.github.com/users/Yasumoto/gists{/gist_id}","starred_url":"https://api.github.com/users/Yasumoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yasumoto/subscriptions","organizations_url":"https://api.github.com/users/Yasumoto/orgs","repos_url":"https://api.github.com/users/Yasumoto/repos","events_url":"https://api.github.com/users/Yasumoto/events{/privacy}","received_events_url":"https://api.github.com/users/Yasumoto/received_events","type":"User","site_admin":false},"body":"0.1.8?","created_at":"2015-12-03T03:22:56Z","updated_at":"2015-12-03T03:22:56Z","html_url":"https://github.com/twitter/zktraffic/pull/65#discussion_r46508885","pull_request_url":"https://api.github.com/repos/twitter/zktraffic/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/comments/46508885"},"html":{"href":"https://github.com/twitter/zktraffic/pull/65#discussion_r46508885"},"pull_request":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/zktraffic/pulls/65","id":52477868,"html_url":"https://github.com/twitter/zktraffic/pull/65","diff_url":"https://github.com/twitter/zktraffic/pull/65.diff","patch_url":"https://github.com/twitter/zktraffic/pull/65.patch","issue_url":"https://api.github.com/repos/twitter/zktraffic/issues/65","number":65,"state":"open","locked":false,"title":"Perf improvements","user":{"login":"rgs1","id":1349891,"avatar_url":"https://avatars.githubusercontent.com/u/1349891?v=3","gravatar_id":"","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"body":"Even though --set-cpu-affinity is great to pin zk-stats-daemon to just one CPU, it still uses too much of it when there is a high packet rate.\r\n\r\nThis PR introduces a few optimizations to reduce memory usage plus --sampling to avoid inspecting _all_ packets (which can help a lot on busy servers). ","created_at":"2015-12-03T00:55:18Z","updated_at":"2015-12-03T03:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0125f87cf984537ee5d700217084c83e80201f72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/zktraffic/pulls/65/commits","review_comments_url":"https://api.github.com/repos/twitter/zktraffic/pulls/65/comments","review_comment_url":"https://api.github.com/repos/twitter/zktraffic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/zktraffic/issues/65/comments","statuses_url":"https://api.github.com/repos/twitter/zktraffic/statuses/1c0e7076ebf06dca5ac392078edbac2f1f58e972","head":{"label":"rgs1:perf-improvements","ref":"perf-improvements","sha":"1c0e7076ebf06dca5ac392078edbac2f1f58e972","user":{"login":"rgs1","id":1349891,"avatar_url":"https://avatars.githubusercontent.com/u/1349891?v=3","gravatar_id":"","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"repo":{"id":24901186,"name":"zktraffic","full_name":"rgs1/zktraffic","owner":{"login":"rgs1","id":1349891,"avatar_url":"https://avatars.githubusercontent.com/u/1349891?v=3","gravatar_id":"","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgs1/zktraffic","description":"ZooKeeper protocol analyzer and stats gathering daemon","fork":true,"url":"https://api.github.com/repos/rgs1/zktraffic","forks_url":"https://api.github.com/repos/rgs1/zktraffic/forks","keys_url":"https://api.github.com/repos/rgs1/zktraffic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgs1/zktraffic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgs1/zktraffic/teams","hooks_url":"https://api.github.com/repos/rgs1/zktraffic/hooks","issue_events_url":"https://api.github.com/repos/rgs1/zktraffic/issues/events{/number}","events_url":"https://api.github.com/repos/rgs1/zktraffic/events","assignees_url":"https://api.github.com/repos/rgs1/zktraffic/assignees{/user}","branches_url":"https://api.github.com/repos/rgs1/zktraffic/branches{/branch}","tags_url":"https://api.github.com/repos/rgs1/zktraffic/tags","blobs_url":"https://api.github.com/repos/rgs1/zktraffic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgs1/zktraffic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgs1/zktraffic/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgs1/zktraffic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgs1/zktraffic/statuses/{sha}","languages_url":"https://api.github.com/repos/rgs1/zktraffic/languages","stargazers_url":"https://api.github.com/repos/rgs1/zktraffic/stargazers","contributors_url":"https://api.github.com/repos/rgs1/zktraffic/contributors","subscribers_url":"https://api.github.com/repos/rgs1/zktraffic/subscribers","subscription_url":"https://api.github.com/repos/rgs1/zktraffic/subscription","commits_url":"https://api.github.com/repos/rgs1/zktraffic/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgs1/zktraffic/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgs1/zktraffic/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgs1/zktraffic/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgs1/zktraffic/contents/{+path}","compare_url":"https://api.github.com/repos/rgs1/zktraffic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgs1/zktraffic/merges","archive_url":"https://api.github.com/repos/rgs1/zktraffic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgs1/zktraffic/downloads","issues_url":"https://api.github.com/repos/rgs1/zktraffic/issues{/number}","pulls_url":"https://api.github.com/repos/rgs1/zktraffic/pulls{/number}","milestones_url":"https://api.github.com/repos/rgs1/zktraffic/milestones{/number}","notifications_url":"https://api.github.com/repos/rgs1/zktraffic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgs1/zktraffic/labels{/name}","releases_url":"https://api.github.com/repos/rgs1/zktraffic/releases{/id}","created_at":"2014-10-07T17:02:57Z","updated_at":"2015-02-25T22:54:50Z","pushed_at":"2015-12-03T01:20:01Z","git_url":"git://github.com/rgs1/zktraffic.git","ssh_url":"git@github.com:rgs1/zktraffic.git","clone_url":"https://github.com/rgs1/zktraffic.git","svn_url":"https://github.com/rgs1/zktraffic","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"3145bfbb9b7990477f64b3efb2ac50d9cc6971a3","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":21988855,"name":"zktraffic","full_name":"twitter/zktraffic","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/zktraffic","description":"ZooKeeper protocol analyzer and stats gathering daemon","fork":false,"url":"https://api.github.com/repos/twitter/zktraffic","forks_url":"https://api.github.com/repos/twitter/zktraffic/forks","keys_url":"https://api.github.com/repos/twitter/zktraffic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/zktraffic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/zktraffic/teams","hooks_url":"https://api.github.com/repos/twitter/zktraffic/hooks","issue_events_url":"https://api.github.com/repos/twitter/zktraffic/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/zktraffic/events","assignees_url":"https://api.github.com/repos/twitter/zktraffic/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/zktraffic/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/zktraffic/tags","blobs_url":"https://api.github.com/repos/twitter/zktraffic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/zktraffic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/zktraffic/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/zktraffic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/zktraffic/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/zktraffic/languages","stargazers_url":"https://api.github.com/repos/twitter/zktraffic/stargazers","contributors_url":"https://api.github.com/repos/twitter/zktraffic/contributors","subscribers_url":"https://api.github.com/repos/twitter/zktraffic/subscribers","subscription_url":"https://api.github.com/repos/twitter/zktraffic/subscription","commits_url":"https://api.github.com/repos/twitter/zktraffic/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/zktraffic/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/zktraffic/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/zktraffic/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/zktraffic/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/zktraffic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/zktraffic/merges","archive_url":"https://api.github.com/repos/twitter/zktraffic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/zktraffic/downloads","issues_url":"https://api.github.com/repos/twitter/zktraffic/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/zktraffic/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/zktraffic/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/zktraffic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/zktraffic/labels{/name}","releases_url":"https://api.github.com/repos/twitter/zktraffic/releases{/id}","created_at":"2014-07-18T17:39:42Z","updated_at":"2015-11-26T04:57:07Z","pushed_at":"2015-12-03T01:20:01Z","git_url":"git://github.com/twitter/zktraffic.git","ssh_url":"git@github.com:twitter/zktraffic.git","clone_url":"https://github.com/twitter/zktraffic.git","svn_url":"https://github.com/twitter/zktraffic","homepage":null,"size":273,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/65"},"html":{"href":"https://github.com/twitter/zktraffic/pull/65"},"issue":{"href":"https://api.github.com/repos/twitter/zktraffic/issues/65"},"comments":{"href":"https://api.github.com/repos/twitter/zktraffic/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/zktraffic/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/zktraffic/statuses/1c0e7076ebf06dca5ac392078edbac2f1f58e972"}}}}