{"action":"closed","number":4522,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522","id":28526315,"html_url":"https://github.com/hazelcast/hazelcast/pull/4522","diff_url":"https://github.com/hazelcast/hazelcast/pull/4522.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/4522.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4522","number":4522,"state":"closed","locked":false,"title":"When near cache configured to store OBJECT then more efficient to nearca...","user":{"login":"dirkvanrensburg","id":1143148,"avatar_url":"https://avatars.githubusercontent.com/u/1143148?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkvanrensburg","html_url":"https://github.com/dirkvanrensburg","followers_url":"https://api.github.com/users/dirkvanrensburg/followers","following_url":"https://api.github.com/users/dirkvanrensburg/following{/other_user}","gists_url":"https://api.github.com/users/dirkvanrensburg/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkvanrensburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkvanrensburg/subscriptions","organizations_url":"https://api.github.com/users/dirkvanrensburg/orgs","repos_url":"https://api.github.com/users/dirkvanrensburg/repos","events_url":"https://api.github.com/users/dirkvanrensburg/events{/privacy}","received_events_url":"https://api.github.com/users/dirkvanrensburg/received_events","type":"User","site_admin":false},"body":"When ```readBackupData``` is true and near caching is configured then the value is not placed in the near cache when it is read from backup. On high frequency reads the value will be read from the backup and de-serialised on every request, but if the near cache is configured with ```InMemoryFormat.OBJECT``` then storing it in the near cache is much more efficient. \r\n\r\nIt has the downside of using more memory, but that can be controlled by the near cache TTL  and max size settings.\r\n\r\nThe included test does not test the performance improvement - just that the same object is returned, but local tests showed a 5 times improvement for high frequency gets of the same value when the near cache is configured with ```InMemoryFormat.OBJECT```.","created_at":"2015-02-03T04:35:57Z","updated_at":"2015-11-09T12:38:09Z","closed_at":"2015-11-09T12:38:09Z","merged_at":null,"merge_commit_sha":"1546bcbdc6689e9549d1a2bb8be6de4988875071","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4522/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d5a4d3066ab9154ab8a088e6c9c4ce6cbb5b824f","head":{"label":"dirkvanrensburg:backupsToNearcache","ref":"backupsToNearcache","sha":"d5a4d3066ab9154ab8a088e6c9c4ce6cbb5b824f","user":{"login":"dirkvanrensburg","id":1143148,"avatar_url":"https://avatars.githubusercontent.com/u/1143148?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkvanrensburg","html_url":"https://github.com/dirkvanrensburg","followers_url":"https://api.github.com/users/dirkvanrensburg/followers","following_url":"https://api.github.com/users/dirkvanrensburg/following{/other_user}","gists_url":"https://api.github.com/users/dirkvanrensburg/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkvanrensburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkvanrensburg/subscriptions","organizations_url":"https://api.github.com/users/dirkvanrensburg/orgs","repos_url":"https://api.github.com/users/dirkvanrensburg/repos","events_url":"https://api.github.com/users/dirkvanrensburg/events{/privacy}","received_events_url":"https://api.github.com/users/dirkvanrensburg/received_events","type":"User","site_admin":false},"repo":{"id":23134566,"name":"hazelcast","full_name":"dirkvanrensburg/hazelcast","owner":{"login":"dirkvanrensburg","id":1143148,"avatar_url":"https://avatars.githubusercontent.com/u/1143148?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkvanrensburg","html_url":"https://github.com/dirkvanrensburg","followers_url":"https://api.github.com/users/dirkvanrensburg/followers","following_url":"https://api.github.com/users/dirkvanrensburg/following{/other_user}","gists_url":"https://api.github.com/users/dirkvanrensburg/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkvanrensburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkvanrensburg/subscriptions","organizations_url":"https://api.github.com/users/dirkvanrensburg/orgs","repos_url":"https://api.github.com/users/dirkvanrensburg/repos","events_url":"https://api.github.com/users/dirkvanrensburg/events{/privacy}","received_events_url":"https://api.github.com/users/dirkvanrensburg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkvanrensburg/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/dirkvanrensburg/hazelcast","forks_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/forks","keys_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/teams","hooks_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/events","assignees_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/tags","blobs_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/languages","stargazers_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/subscription","commits_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/merges","archive_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/downloads","issues_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/dirkvanrensburg/hazelcast/releases{/id}","created_at":"2014-08-20T03:28:21Z","updated_at":"2015-02-02T02:03:28Z","pushed_at":"2015-02-11T03:55:55Z","git_url":"git://github.com/dirkvanrensburg/hazelcast.git","ssh_url":"git@github.com:dirkvanrensburg/hazelcast.git","clone_url":"https://github.com/dirkvanrensburg/hazelcast.git","svn_url":"https://github.com/dirkvanrensburg/hazelcast","homepage":"www.hazelcast.com","size":58368,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"262c5e7e167a8cf48a06c87ee1011ded17710f24","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-11-09T06:58:06Z","pushed_at":"2015-11-09T12:36:18Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":166665,"stargazers_count":1302,"watchers_count":1302,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":629,"mirror_url":null,"open_issues_count":526,"forks":629,"open_issues":526,"watchers":1302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4522"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4522"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4522/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4522/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d5a4d3066ab9154ab8a088e6c9c4ce6cbb5b824f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":2,"commits":1,"additions":34,"deletions":9,"changed_files":2}}