{"action":"created","issue":{"url":"https://api.github.com/repos/pyne/pyne/issues/742","labels_url":"https://api.github.com/repos/pyne/pyne/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/pyne/pyne/issues/742/comments","events_url":"https://api.github.com/repos/pyne/pyne/issues/742/events","html_url":"https://github.com/pyne/pyne/pull/742","id":93535301,"number":742,"title":"Rewrite and expansion of pyne.endf.Evaluation","user":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-07T13:54:07Z","updated_at":"2015-07-22T19:20:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyne/pyne/pulls/742","html_url":"https://github.com/pyne/pyne/pull/742","diff_url":"https://github.com/pyne/pyne/pull/742.diff","patch_url":"https://github.com/pyne/pyne/pull/742.patch"},"body":"This pull request implements a major reworking of the functionality in the pyne.endf.Evaluation class. For starters, the class has been expanded such that it supports parsing ENDF data in all files with MT < 30, i.e. everything other than covariance files. I've tried to make the functionality and documentation a little more user-friendly (although I still need to add more docs before this PR can be considered complete). To highlight some of the salient changes:\r\n\r\n- Got rid of the ENDFFile* and ENDF*Record classes\r\n- Reworked Tab1 class to be much more useful. The class now has a `__call__` method that accepts scalar or array x and returns back interpolated y value(s). \r\n- Use polymorphism judiciously. For example, in ENDF, fission nu can be stored either as polynomial coefficients or as a tabulated function. In my implementation, it's stored either as numpy.polynomial.polymial.Polynomial or Tab1. Since both can be called as functions, to a user it doesn't matter what the actual type is. Angular distributions also take advantage of polymorphism with numpy.polynomial.legendre.Legendre and Tab1.\r\n- Added energy distribution classes. The idea is that the functionality could be expanded in the future, e.g. each energy distribution could have a sample() method or integrate() method.\r\n- Added resonance energy range classes. I'm hoping to implement resonance reconstruction in the future as a reconstruct() method to these classes.\r\n\r\nThere are a few things I need to do before this PR is complete:\r\n- [ ] Add tests for Evaluation and related classes\r\n- [ ] Add IPython notebook demonstrating capabilities\r\n- [ ] Add documentation to user's guide\r\n\r\nNevertheless, I thought it would be good to initiate this to start getting reviewer feedback."},"comment":{"url":"https://api.github.com/repos/pyne/pyne/issues/comments/123832378","html_url":"https://github.com/pyne/pyne/pull/742#issuecomment-123832378","issue_url":"https://api.github.com/repos/pyne/pyne/issues/742","id":123832378,"user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"created_at":"2015-07-22T19:20:06Z","updated_at":"2015-07-22T19:20:06Z","body":"Sorry for taking so long to review this and fix CI."}}