{"action":"created","issue":{"url":"https://api.github.com/repos/privly/privly-safari/issues/22","labels_url":"https://api.github.com/repos/privly/privly-safari/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/privly/privly-safari/issues/22/comments","events_url":"https://api.github.com/repos/privly/privly-safari/issues/22/events","html_url":"https://github.com/privly/privly-safari/pull/22","id":87916967,"number":22,"title":"Basic popover added with Start/Stop Injecting option","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-13T03:21:20Z","updated_at":"2015-06-15T06:59:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/privly/privly-safari/pulls/22","html_url":"https://github.com/privly/privly-safari/pull/22","diff_url":"https://github.com/privly/privly-safari/pull/22.diff","patch_url":"https://github.com/privly/privly-safari/pull/22.patch"},"body":"Basic popover has been added with Start/Stop Injecting option.\r\nThe images and the css has been copied from the privly-chrome repo.\r\nPresently, when the `Start/Stop Injecting` option is clicked in the popover, the `modal_button.js` sends a message with `name: modeChange` and `message: on`(if the Start Injecting option is pressed) or `message: off`(if the Stop Injecting option is pressed).\r\nIn the `reading_process.js`, the `handleMessage()` function is implemented, which on receiving the `modeChange` message, calls `privly.start()` or `privly.stop()` accordingly.\r\n@smcgregor Let me know if you think the changes are okay, then, I will add more comments to the files so that they can be merged.\r\nAll the tests pass and can be seen at https://travis-ci.org/sammyshj/privly-safari/builds/66632406"},"comment":{"url":"https://api.github.com/repos/privly/privly-safari/issues/comments/111956043","html_url":"https://github.com/privly/privly-safari/pull/22#issuecomment-111956043","issue_url":"https://api.github.com/repos/privly/privly-safari/issues/22","id":111956043,"user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"created_at":"2015-06-15T06:59:46Z","updated_at":"2015-06-15T06:59:46Z","body":"@smcgregor Okay, I will refer to the bootstrap files in privly-applications repo.\r\nShould I update the docs right now with the implementation of Start/Stop Injecting? Or should I wait for https://github.com/privly/privly-applications/pull/250 and leave the message sending and receiving for then?"}}