{"action":"created","issue":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/212","labels_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/212/comments","events_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/212/events","html_url":"https://github.com/Exa-Networks/exabgp/issues/212","id":53630839,"number":212,"title":"aggregator clause causes an exception on 3.4.6","user":{"login":"tim-preston","id":10435042,"avatar_url":"https://avatars.githubusercontent.com/u/10435042?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-preston","html_url":"https://github.com/tim-preston","followers_url":"https://api.github.com/users/tim-preston/followers","following_url":"https://api.github.com/users/tim-preston/following{/other_user}","gists_url":"https://api.github.com/users/tim-preston/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-preston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-preston/subscriptions","organizations_url":"https://api.github.com/users/tim-preston/orgs","repos_url":"https://api.github.com/users/tim-preston/repos","events_url":"https://api.github.com/users/tim-preston/events{/privacy}","received_events_url":"https://api.github.com/users/tim-preston/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Exa-Networks/exabgp/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-07T13:12:49Z","updated_at":"2015-01-08T09:08:43Z","closed_at":"2015-01-08T09:08:43Z","body":"Attempting to set an ```aggregator``` clause on a prefix causes an error on 3.4.6\r\n\r\n```\r\nExaBGP version : 3.4.6\r\nPython version : 2.7.7 (default, Oct 28 2014, 13:30:28)  [GCC 4.8.3]\r\nSystem Uname   : #1 SMP Wed Oct 8 12:26:01 BST 2014\r\nSystem MaxInt  : 9223372036854775807\r\n\r\n\r\npeer 195.66.225.230 ASN 8714    \r\n\r\n<type 'exceptions.AttributeError'>\r\n'bool' object has no attribute 'asn4'\r\nTraceback (most recent call last):\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/reactor/peer.py\", line 589, in _run\r\n    for action in self._main(direction):\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/reactor/peer.py\", line 539, in _main\r\n    new_routes.next()\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/reactor/protocol.py\", line 270, in new_update\r\n    for message in update.messages(self.negotiated):\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/bgp/message/update/__init__.py\", line 130, in messages\r\n    attr = self.attributes.pack(negotiated,True)\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/bgp/message/update/attribute/__init__.py\", line 235, in pack\r\n    message += self[code].pack(negotiated)\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/bgp/message/update/attribute/aggregator.py\", line 31, in pack\r\n    return self._attribute(self.asn.pack(True)+self.speaker.pack())\r\n  File \"/home/tim/exabgp/exabgp-3.4.6/lib/exabgp/bgp/message/open/asn.py\", line 19, in pack\r\n    asn4 = negotiated.asn4 if negotiated else self.asn4()\r\nAttributeError: 'bool' object has no attribute 'asn4'\r\n```\r\n\r\nSample config to to trip this - this goes through the parser fine, but throws the above exception as soon as it tries to announce the prefix.\r\n```\r\nneighbor 195.66.225.230 {\r\n  router-id 62.117.100.254;\r\n  local-address 195.66.225.117;\r\n  local-as 8732;\r\n  peer-as 8714;\r\n  group-updates;\r\n\r\n  static {\r\n    route 81.200.112.0/20 {\r\n      next-hop 195.66.225.117;\r\n      origin igp;\r\n      as-path [ 8732 8595 33902 ];\r\n      community [ 0:2578 0:9002 0:42861 8732:1000 ];\r\n      aggregator ( 33902:79.141.224.1 );\r\n    }\r\n  }\r\n}\r\n```\r\n\r\nRemoving the ```aggregator``` clause clears the issue. This was working fine on 3.3.2, I haven't tested on versions between 3.3.2 and 3.4.6"},"comment":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/comments/69153133","html_url":"https://github.com/Exa-Networks/exabgp/issues/212#issuecomment-69153133","issue_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/212","id":69153133,"user":{"login":"thomas-mangin","id":1227755,"avatar_url":"https://avatars.githubusercontent.com/u/1227755?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-mangin","html_url":"https://github.com/thomas-mangin","followers_url":"https://api.github.com/users/thomas-mangin/followers","following_url":"https://api.github.com/users/thomas-mangin/following{/other_user}","gists_url":"https://api.github.com/users/thomas-mangin/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-mangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-mangin/subscriptions","organizations_url":"https://api.github.com/users/thomas-mangin/orgs","repos_url":"https://api.github.com/users/thomas-mangin/repos","events_url":"https://api.github.com/users/thomas-mangin/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-mangin/received_events","type":"User","site_admin":false},"created_at":"2015-01-08T09:08:43Z","updated_at":"2015-01-08T09:08:43Z","body":"Hello, this is already fixed in the latest master."}}