{"action":"created","comment":{"url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/comments/43211430","id":43211430,"diff_hunk":"@@ -117,5 +117,7 @@ function(L) {\n     'fillColor': '#fcd96c'\n   };\n \n+  settings.cors = ('withCredentials' in new XMLHttpRequest());","path":"src/js/settings.js","position":4,"original_position":4,"commit_id":"9178f6ca6abd773f2033b95c2d2a063b00fb5902","original_commit_id":"9178f6ca6abd773f2033b95c2d2a063b00fb5902","user":{"login":"hampelm","id":86435,"avatar_url":"https://avatars.githubusercontent.com/u/86435?v=3","gravatar_id":"","url":"https://api.github.com/users/hampelm","html_url":"https://github.com/hampelm","followers_url":"https://api.github.com/users/hampelm/followers","following_url":"https://api.github.com/users/hampelm/following{/other_user}","gists_url":"https://api.github.com/users/hampelm/gists{/gist_id}","starred_url":"https://api.github.com/users/hampelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hampelm/subscriptions","organizations_url":"https://api.github.com/users/hampelm/orgs","repos_url":"https://api.github.com/users/hampelm/repos","events_url":"https://api.github.com/users/hampelm/events{/privacy}","received_events_url":"https://api.github.com/users/hampelm/received_events","type":"User","site_admin":false},"body":"Cool, thanks for the explanation!","created_at":"2015-10-28T01:52:42Z","updated_at":"2015-10-28T01:52:42Z","html_url":"https://github.com/LocalData/localdata-dashboard/pull/624#discussion_r43211430","pull_request_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624","_links":{"self":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/comments/43211430"},"html":{"href":"https://github.com/LocalData/localdata-dashboard/pull/624#discussion_r43211430"},"pull_request":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624"}}},"pull_request":{"url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624","id":48942537,"html_url":"https://github.com/LocalData/localdata-dashboard/pull/624","diff_url":"https://github.com/LocalData/localdata-dashboard/pull/624.diff","patch_url":"https://github.com/LocalData/localdata-dashboard/pull/624.patch","issue_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/624","number":624,"state":"open","locked":false,"title":"Avoid using JSONP for grids when the browser will support CORS requests","user":{"login":"prashtx","id":1307783,"avatar_url":"https://avatars.githubusercontent.com/u/1307783?v=3","gravatar_id":"","url":"https://api.github.com/users/prashtx","html_url":"https://github.com/prashtx","followers_url":"https://api.github.com/users/prashtx/followers","following_url":"https://api.github.com/users/prashtx/following{/other_user}","gists_url":"https://api.github.com/users/prashtx/gists{/gist_id}","starred_url":"https://api.github.com/users/prashtx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashtx/subscriptions","organizations_url":"https://api.github.com/users/prashtx/orgs","repos_url":"https://api.github.com/users/prashtx/repos","events_url":"https://api.github.com/users/prashtx/events{/privacy}","received_events_url":"https://api.github.com/users/prashtx/received_events","type":"User","site_admin":false},"body":"This should help a little with grid caching, since the grid response content will be the same regardless of load order/etc. With JSONP, the callback names can change, leading to cache misses.\r\n\r\nThis change depends on https://github.com/LocalData/localdata-tiles/pull/158","created_at":"2015-10-27T22:37:59Z","updated_at":"2015-10-28T01:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6eab18775ea6dd596144e9e2200918ed4cec84c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624/commits","review_comments_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624/comments","review_comment_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/624/comments","statuses_url":"https://api.github.com/repos/LocalData/localdata-dashboard/statuses/9178f6ca6abd773f2033b95c2d2a063b00fb5902","head":{"label":"LocalData:grid-json","ref":"grid-json","sha":"9178f6ca6abd773f2033b95c2d2a063b00fb5902","user":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=3","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"repo":{"id":7634994,"name":"localdata-dashboard","full_name":"LocalData/localdata-dashboard","owner":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=3","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LocalData/localdata-dashboard","description":"","fork":false,"url":"https://api.github.com/repos/LocalData/localdata-dashboard","forks_url":"https://api.github.com/repos/LocalData/localdata-dashboard/forks","keys_url":"https://api.github.com/repos/LocalData/localdata-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LocalData/localdata-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LocalData/localdata-dashboard/teams","hooks_url":"https://api.github.com/repos/LocalData/localdata-dashboard/hooks","issue_events_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/LocalData/localdata-dashboard/events","assignees_url":"https://api.github.com/repos/LocalData/localdata-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/LocalData/localdata-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/LocalData/localdata-dashboard/tags","blobs_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LocalData/localdata-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/LocalData/localdata-dashboard/languages","stargazers_url":"https://api.github.com/repos/LocalData/localdata-dashboard/stargazers","contributors_url":"https://api.github.com/repos/LocalData/localdata-dashboard/contributors","subscribers_url":"https://api.github.com/repos/LocalData/localdata-dashboard/subscribers","subscription_url":"https://api.github.com/repos/LocalData/localdata-dashboard/subscription","commits_url":"https://api.github.com/repos/LocalData/localdata-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/LocalData/localdata-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/LocalData/localdata-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/LocalData/localdata-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LocalData/localdata-dashboard/merges","archive_url":"https://api.github.com/repos/LocalData/localdata-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LocalData/localdata-dashboard/downloads","issues_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/LocalData/localdata-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/LocalData/localdata-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LocalData/localdata-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/LocalData/localdata-dashboard/releases{/id}","created_at":"2013-01-15T22:57:35Z","updated_at":"2015-09-11T18:28:32Z","pushed_at":"2015-10-27T22:38:00Z","git_url":"git://github.com/LocalData/localdata-dashboard.git","ssh_url":"git@github.com:LocalData/localdata-dashboard.git","clone_url":"https://github.com/LocalData/localdata-dashboard.git","svn_url":"https://github.com/LocalData/localdata-dashboard","homepage":"","size":7590,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":136,"forks":4,"open_issues":136,"watchers":10,"default_branch":"master"}},"base":{"label":"LocalData:master","ref":"master","sha":"ac6641bad07f54eaf159b6440559bcc8f95d68e0","user":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=3","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"repo":{"id":7634994,"name":"localdata-dashboard","full_name":"LocalData/localdata-dashboard","owner":{"login":"LocalData","id":2413672,"avatar_url":"https://avatars.githubusercontent.com/u/2413672?v=3","gravatar_id":"","url":"https://api.github.com/users/LocalData","html_url":"https://github.com/LocalData","followers_url":"https://api.github.com/users/LocalData/followers","following_url":"https://api.github.com/users/LocalData/following{/other_user}","gists_url":"https://api.github.com/users/LocalData/gists{/gist_id}","starred_url":"https://api.github.com/users/LocalData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LocalData/subscriptions","organizations_url":"https://api.github.com/users/LocalData/orgs","repos_url":"https://api.github.com/users/LocalData/repos","events_url":"https://api.github.com/users/LocalData/events{/privacy}","received_events_url":"https://api.github.com/users/LocalData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LocalData/localdata-dashboard","description":"","fork":false,"url":"https://api.github.com/repos/LocalData/localdata-dashboard","forks_url":"https://api.github.com/repos/LocalData/localdata-dashboard/forks","keys_url":"https://api.github.com/repos/LocalData/localdata-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LocalData/localdata-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LocalData/localdata-dashboard/teams","hooks_url":"https://api.github.com/repos/LocalData/localdata-dashboard/hooks","issue_events_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/LocalData/localdata-dashboard/events","assignees_url":"https://api.github.com/repos/LocalData/localdata-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/LocalData/localdata-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/LocalData/localdata-dashboard/tags","blobs_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LocalData/localdata-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/LocalData/localdata-dashboard/languages","stargazers_url":"https://api.github.com/repos/LocalData/localdata-dashboard/stargazers","contributors_url":"https://api.github.com/repos/LocalData/localdata-dashboard/contributors","subscribers_url":"https://api.github.com/repos/LocalData/localdata-dashboard/subscribers","subscription_url":"https://api.github.com/repos/LocalData/localdata-dashboard/subscription","commits_url":"https://api.github.com/repos/LocalData/localdata-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/LocalData/localdata-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/LocalData/localdata-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/LocalData/localdata-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/LocalData/localdata-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LocalData/localdata-dashboard/merges","archive_url":"https://api.github.com/repos/LocalData/localdata-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LocalData/localdata-dashboard/downloads","issues_url":"https://api.github.com/repos/LocalData/localdata-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/LocalData/localdata-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/LocalData/localdata-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LocalData/localdata-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/LocalData/localdata-dashboard/releases{/id}","created_at":"2013-01-15T22:57:35Z","updated_at":"2015-09-11T18:28:32Z","pushed_at":"2015-10-27T22:38:00Z","git_url":"git://github.com/LocalData/localdata-dashboard.git","ssh_url":"git@github.com:LocalData/localdata-dashboard.git","clone_url":"https://github.com/LocalData/localdata-dashboard.git","svn_url":"https://github.com/LocalData/localdata-dashboard","homepage":"","size":7590,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":136,"forks":4,"open_issues":136,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624"},"html":{"href":"https://github.com/LocalData/localdata-dashboard/pull/624"},"issue":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/624"},"comments":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/issues/624/comments"},"review_comments":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624/comments"},"review_comment":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/pulls/624/commits"},"statuses":{"href":"https://api.github.com/repos/LocalData/localdata-dashboard/statuses/9178f6ca6abd773f2033b95c2d2a063b00fb5902"}}}}