{"action":"created","comment":{"url":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/25533059","id":25533059,"diff_hunk":"@@ -441,10 +441,10 @@ bool cBlockArea::Read(cForEachChunkProvider * a_ForEachChunkProvider, int a_MinB\n \t\tLOGWARNING(\"%s: MaxBlockY less than zero, adjusting to zero\", __FUNCTION__);\n \t\ta_MaxBlockY = 0;\n \t}\n-\telse if (a_MaxBlockY > cChunkDef::Height)\n+\telse if (a_MaxBlockY >= cChunkDef::Height)\n \t{\n \t\tLOGWARNING(\"%s: MaxBlockY more than chunk height, adjusting to chunk height\", __FUNCTION__);\n-\t\ta_MaxBlockY = cChunkDef::Height;\n+\t\ta_MaxBlockY = cChunkDef::Height - 1;","path":"src/BlockArea.cpp","position":null,"original_position":9,"commit_id":"3856a730fe42203cde78acc44b537f160b7e33a7","original_commit_id":"5d45d6b05389de74293d4bf7321b835636d69ad5","user":{"login":"tommysanterre","id":2781089,"avatar_url":"https://avatars.githubusercontent.com/u/2781089?v=3","gravatar_id":"","url":"https://api.github.com/users/tommysanterre","html_url":"https://github.com/tommysanterre","followers_url":"https://api.github.com/users/tommysanterre/followers","following_url":"https://api.github.com/users/tommysanterre/following{/other_user}","gists_url":"https://api.github.com/users/tommysanterre/gists{/gist_id}","starred_url":"https://api.github.com/users/tommysanterre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommysanterre/subscriptions","organizations_url":"https://api.github.com/users/tommysanterre/orgs","repos_url":"https://api.github.com/users/tommysanterre/repos","events_url":"https://api.github.com/users/tommysanterre/events{/privacy}","received_events_url":"https://api.github.com/users/tommysanterre/received_events","type":"User","site_admin":false},"body":"Oh I see that's the goal of that block. Make them exclusive.\r\n\r\n\t// Include the Max coords:\r\n\ta_MaxBlockX += 1;\r\n\ta_MaxBlockY += 1;\r\n\ta_MaxBlockZ += 1;\r\n\r\nMy proposition doesn't make sense then, sorry.","created_at":"2015-02-27T19:43:44Z","updated_at":"2015-02-27T19:43:44Z","html_url":"https://github.com/mc-server/MCServer/pull/1775#discussion_r25533059","pull_request_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1775","_links":{"self":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/comments/25533059"},"html":{"href":"https://github.com/mc-server/MCServer/pull/1775#discussion_r25533059"},"pull_request":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1775"}}},"pull_request":{"url":"https://api.github.com/repos/mc-server/MCServer/pulls/1775","id":30141181,"html_url":"https://github.com/mc-server/MCServer/pull/1775","diff_url":"https://github.com/mc-server/MCServer/pull/1775.diff","patch_url":"https://github.com/mc-server/MCServer/pull/1775.patch","issue_url":"https://api.github.com/repos/mc-server/MCServer/issues/1775","number":1775,"state":"open","locked":false,"title":"Correct all world height validations.","user":{"login":"tommysanterre","id":2781089,"avatar_url":"https://avatars.githubusercontent.com/u/2781089?v=3","gravatar_id":"","url":"https://api.github.com/users/tommysanterre","html_url":"https://github.com/tommysanterre","followers_url":"https://api.github.com/users/tommysanterre/followers","following_url":"https://api.github.com/users/tommysanterre/following{/other_user}","gists_url":"https://api.github.com/users/tommysanterre/gists{/gist_id}","starred_url":"https://api.github.com/users/tommysanterre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommysanterre/subscriptions","organizations_url":"https://api.github.com/users/tommysanterre/orgs","repos_url":"https://api.github.com/users/tommysanterre/repos","events_url":"https://api.github.com/users/tommysanterre/events{/privacy}","received_events_url":"https://api.github.com/users/tommysanterre/received_events","type":"User","site_admin":false},"body":"Addesses issue https://github.com/mc-server/MCServer/issues/1606.\r\n\r\nNo more assertion triggered.","created_at":"2015-02-27T04:32:32Z","updated_at":"2015-02-27T19:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a21635d0cd0bc10645f0610647901938bcd712","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1775/commits","review_comments_url":"https://api.github.com/repos/mc-server/MCServer/pulls/1775/comments","review_comment_url":"https://api.github.com/repos/mc-server/MCServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mc-server/MCServer/issues/1775/comments","statuses_url":"https://api.github.com/repos/mc-server/MCServer/statuses/3856a730fe42203cde78acc44b537f160b7e33a7","head":{"label":"tommysanterre:terrainheightfix","ref":"terrainheightfix","sha":"3856a730fe42203cde78acc44b537f160b7e33a7","user":{"login":"tommysanterre","id":2781089,"avatar_url":"https://avatars.githubusercontent.com/u/2781089?v=3","gravatar_id":"","url":"https://api.github.com/users/tommysanterre","html_url":"https://github.com/tommysanterre","followers_url":"https://api.github.com/users/tommysanterre/followers","following_url":"https://api.github.com/users/tommysanterre/following{/other_user}","gists_url":"https://api.github.com/users/tommysanterre/gists{/gist_id}","starred_url":"https://api.github.com/users/tommysanterre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommysanterre/subscriptions","organizations_url":"https://api.github.com/users/tommysanterre/orgs","repos_url":"https://api.github.com/users/tommysanterre/repos","events_url":"https://api.github.com/users/tommysanterre/events{/privacy}","received_events_url":"https://api.github.com/users/tommysanterre/received_events","type":"User","site_admin":false},"repo":{"id":30223302,"name":"MCServer","full_name":"tommysanterre/MCServer","owner":{"login":"tommysanterre","id":2781089,"avatar_url":"https://avatars.githubusercontent.com/u/2781089?v=3","gravatar_id":"","url":"https://api.github.com/users/tommysanterre","html_url":"https://github.com/tommysanterre","followers_url":"https://api.github.com/users/tommysanterre/followers","following_url":"https://api.github.com/users/tommysanterre/following{/other_user}","gists_url":"https://api.github.com/users/tommysanterre/gists{/gist_id}","starred_url":"https://api.github.com/users/tommysanterre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommysanterre/subscriptions","organizations_url":"https://api.github.com/users/tommysanterre/orgs","repos_url":"https://api.github.com/users/tommysanterre/repos","events_url":"https://api.github.com/users/tommysanterre/events{/privacy}","received_events_url":"https://api.github.com/users/tommysanterre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tommysanterre/MCServer","description":"A performant C++ Minecraft Server","fork":true,"url":"https://api.github.com/repos/tommysanterre/MCServer","forks_url":"https://api.github.com/repos/tommysanterre/MCServer/forks","keys_url":"https://api.github.com/repos/tommysanterre/MCServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tommysanterre/MCServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tommysanterre/MCServer/teams","hooks_url":"https://api.github.com/repos/tommysanterre/MCServer/hooks","issue_events_url":"https://api.github.com/repos/tommysanterre/MCServer/issues/events{/number}","events_url":"https://api.github.com/repos/tommysanterre/MCServer/events","assignees_url":"https://api.github.com/repos/tommysanterre/MCServer/assignees{/user}","branches_url":"https://api.github.com/repos/tommysanterre/MCServer/branches{/branch}","tags_url":"https://api.github.com/repos/tommysanterre/MCServer/tags","blobs_url":"https://api.github.com/repos/tommysanterre/MCServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tommysanterre/MCServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tommysanterre/MCServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tommysanterre/MCServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tommysanterre/MCServer/statuses/{sha}","languages_url":"https://api.github.com/repos/tommysanterre/MCServer/languages","stargazers_url":"https://api.github.com/repos/tommysanterre/MCServer/stargazers","contributors_url":"https://api.github.com/repos/tommysanterre/MCServer/contributors","subscribers_url":"https://api.github.com/repos/tommysanterre/MCServer/subscribers","subscription_url":"https://api.github.com/repos/tommysanterre/MCServer/subscription","commits_url":"https://api.github.com/repos/tommysanterre/MCServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tommysanterre/MCServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tommysanterre/MCServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tommysanterre/MCServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tommysanterre/MCServer/contents/{+path}","compare_url":"https://api.github.com/repos/tommysanterre/MCServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tommysanterre/MCServer/merges","archive_url":"https://api.github.com/repos/tommysanterre/MCServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tommysanterre/MCServer/downloads","issues_url":"https://api.github.com/repos/tommysanterre/MCServer/issues{/number}","pulls_url":"https://api.github.com/repos/tommysanterre/MCServer/pulls{/number}","milestones_url":"https://api.github.com/repos/tommysanterre/MCServer/milestones{/number}","notifications_url":"https://api.github.com/repos/tommysanterre/MCServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tommysanterre/MCServer/labels{/name}","releases_url":"https://api.github.com/repos/tommysanterre/MCServer/releases{/id}","created_at":"2015-02-03T03:42:21Z","updated_at":"2015-02-23T21:41:47Z","pushed_at":"2015-02-27T16:02:07Z","git_url":"git://github.com/tommysanterre/MCServer.git","ssh_url":"git@github.com:tommysanterre/MCServer.git","clone_url":"https://github.com/tommysanterre/MCServer.git","svn_url":"https://github.com/tommysanterre/MCServer","homepage":"mc-server.org","size":71903,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mc-server:master","ref":"master","sha":"e7708d483eee57fbdd457f566a97315a72fa09e3","user":{"login":"mc-server","id":5096476,"avatar_url":"https://avatars.githubusercontent.com/u/5096476?v=3","gravatar_id":"","url":"https://api.github.com/users/mc-server","html_url":"https://github.com/mc-server","followers_url":"https://api.github.com/users/mc-server/followers","following_url":"https://api.github.com/users/mc-server/following{/other_user}","gists_url":"https://api.github.com/users/mc-server/gists{/gist_id}","starred_url":"https://api.github.com/users/mc-server/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc-server/subscriptions","organizations_url":"https://api.github.com/users/mc-server/orgs","repos_url":"https://api.github.com/users/mc-server/repos","events_url":"https://api.github.com/users/mc-server/events{/privacy}","received_events_url":"https://api.github.com/users/mc-server/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"MCServer","full_name":"mc-server/MCServer","owner":{"login":"mc-server","id":5096476,"avatar_url":"https://avatars.githubusercontent.com/u/5096476?v=3","gravatar_id":"","url":"https://api.github.com/users/mc-server","html_url":"https://github.com/mc-server","followers_url":"https://api.github.com/users/mc-server/followers","following_url":"https://api.github.com/users/mc-server/following{/other_user}","gists_url":"https://api.github.com/users/mc-server/gists{/gist_id}","starred_url":"https://api.github.com/users/mc-server/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc-server/subscriptions","organizations_url":"https://api.github.com/users/mc-server/orgs","repos_url":"https://api.github.com/users/mc-server/repos","events_url":"https://api.github.com/users/mc-server/events{/privacy}","received_events_url":"https://api.github.com/users/mc-server/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mc-server/MCServer","description":"A performant C++ Minecraft Server","fork":false,"url":"https://api.github.com/repos/mc-server/MCServer","forks_url":"https://api.github.com/repos/mc-server/MCServer/forks","keys_url":"https://api.github.com/repos/mc-server/MCServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mc-server/MCServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mc-server/MCServer/teams","hooks_url":"https://api.github.com/repos/mc-server/MCServer/hooks","issue_events_url":"https://api.github.com/repos/mc-server/MCServer/issues/events{/number}","events_url":"https://api.github.com/repos/mc-server/MCServer/events","assignees_url":"https://api.github.com/repos/mc-server/MCServer/assignees{/user}","branches_url":"https://api.github.com/repos/mc-server/MCServer/branches{/branch}","tags_url":"https://api.github.com/repos/mc-server/MCServer/tags","blobs_url":"https://api.github.com/repos/mc-server/MCServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mc-server/MCServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mc-server/MCServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mc-server/MCServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mc-server/MCServer/statuses/{sha}","languages_url":"https://api.github.com/repos/mc-server/MCServer/languages","stargazers_url":"https://api.github.com/repos/mc-server/MCServer/stargazers","contributors_url":"https://api.github.com/repos/mc-server/MCServer/contributors","subscribers_url":"https://api.github.com/repos/mc-server/MCServer/subscribers","subscription_url":"https://api.github.com/repos/mc-server/MCServer/subscription","commits_url":"https://api.github.com/repos/mc-server/MCServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mc-server/MCServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mc-server/MCServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mc-server/MCServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mc-server/MCServer/contents/{+path}","compare_url":"https://api.github.com/repos/mc-server/MCServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mc-server/MCServer/merges","archive_url":"https://api.github.com/repos/mc-server/MCServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mc-server/MCServer/downloads","issues_url":"https://api.github.com/repos/mc-server/MCServer/issues{/number}","pulls_url":"https://api.github.com/repos/mc-server/MCServer/pulls{/number}","milestones_url":"https://api.github.com/repos/mc-server/MCServer/milestones{/number}","notifications_url":"https://api.github.com/repos/mc-server/MCServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mc-server/MCServer/labels{/name}","releases_url":"https://api.github.com/repos/mc-server/MCServer/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2015-02-27T03:50:29Z","pushed_at":"2015-02-26T22:08:32Z","git_url":"git://github.com/mc-server/MCServer.git","ssh_url":"git@github.com:mc-server/MCServer.git","clone_url":"https://github.com/mc-server/MCServer.git","svn_url":"https://github.com/mc-server/MCServer","homepage":"mc-server.org","size":157044,"stargazers_count":403,"watchers_count":403,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":275,"forks":141,"open_issues":275,"watchers":403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1775"},"html":{"href":"https://github.com/mc-server/MCServer/pull/1775"},"issue":{"href":"https://api.github.com/repos/mc-server/MCServer/issues/1775"},"comments":{"href":"https://api.github.com/repos/mc-server/MCServer/issues/1775/comments"},"review_comments":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1775/comments"},"review_comment":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mc-server/MCServer/pulls/1775/commits"},"statuses":{"href":"https://api.github.com/repos/mc-server/MCServer/statuses/3856a730fe42203cde78acc44b537f160b7e33a7"}}}}