{"action":"closed","issue":{"url":"https://api.github.com/repos/dosx/node-vips/issues/10","labels_url":"https://api.github.com/repos/dosx/node-vips/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/dosx/node-vips/issues/10/comments","events_url":"https://api.github.com/repos/dosx/node-vips/issues/10/events","html_url":"https://github.com/dosx/node-vips/issues/10","id":17934646,"number":10,"title":"Sharpen by default","user":{"login":"lovell","id":210965,"avatar_url":"https://avatars.githubusercontent.com/u/210965?v=3","gravatar_id":"","url":"https://api.github.com/users/lovell","html_url":"https://github.com/lovell","followers_url":"https://api.github.com/users/lovell/followers","following_url":"https://api.github.com/users/lovell/following{/other_user}","gists_url":"https://api.github.com/users/lovell/gists{/gist_id}","starred_url":"https://api.github.com/users/lovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovell/subscriptions","organizations_url":"https://api.github.com/users/lovell/orgs","repos_url":"https://api.github.com/users/lovell/repos","events_url":"https://api.github.com/users/lovell/events{/privacy}","received_events_url":"https://api.github.com/users/lovell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2013-08-12T11:04:32Z","updated_at":"2015-01-23T19:22:46Z","closed_at":"2015-01-23T19:22:46Z","body":"I notice the source of https://github.com/dosx/node-vips/blob/master/src/transform.cc#L167 includes \"TODO(walt): add sharpening?\".\r\n\r\nThe vipsthumbnail tool, upon which this code is based, now performs a \"mild\" sharpen by default.\r\n\r\nhttps://github.com/jcupitt/libvips/commit/7eb3513d462e3ebb037520468ecd4bd7c1d186da\r\n\r\nI've backported this code to node-vips ResizeAndCrop method.\r\n\r\n*Question for @dosx: Are you happy to accept a Pull Request making this the default behaviour to match the upstream behaviour?*\r\n\r\nPros: In user testing the images it produces are significantly clearer.\r\n\r\nCons: In some basic performance testing I found the sharpening step adds around 20% to the overall image processing time (although it's still very, very fast). YMMV.\r\n"}}