{"action":"created","comment":{"url":"https://api.github.com/repos/Juniper/OpenClos/pulls/comments/24167620","id":24167620,"diff_hunk":"@@ -72,8 +73,19 @@ def onTrap(transportDispatcher, transportDomain, transportAddress, wholeMsg):\n                 for oid, val in varBinds:\n                     logger.debug('%s = %s' % (oid.prettyPrint(), val.prettyPrint()))\n                     \n+    \n     # start the 2-stage configuration in a separate thread\n     if trapReceiver is not None:\n+        # execute 2-stage configuration callback if there is one configured in openclos.yaml","path":"jnpr/openclos/trapd.py","position":15,"original_position":15,"commit_id":"4e8d7fffae4e11369c9e61ed210b6da72838314c","original_commit_id":"4e8d7fffae4e11369c9e61ed210b6da72838314c","user":{"login":"yunli2004","id":8332402,"avatar_url":"https://avatars.githubusercontent.com/u/8332402?v=3","gravatar_id":"","url":"https://api.github.com/users/yunli2004","html_url":"https://github.com/yunli2004","followers_url":"https://api.github.com/users/yunli2004/followers","following_url":"https://api.github.com/users/yunli2004/following{/other_user}","gists_url":"https://api.github.com/users/yunli2004/gists{/gist_id}","starred_url":"https://api.github.com/users/yunli2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunli2004/subscriptions","organizations_url":"https://api.github.com/users/yunli2004/orgs","repos_url":"https://api.github.com/users/yunli2004/repos","events_url":"https://api.github.com/users/yunli2004/events{/privacy}","received_events_url":"https://api.github.com/users/yunli2004/received_events","type":"User","site_admin":false},"body":"Since we invent this twoStageConfigurationCallback to be sort of generic, so theoretically standalone version OpenClos should be able to use it too.\r\n\r\nThanks.\r\n-yun\r\n\r\nFrom: moloyc [mailto:notifications@github.com]\r\nSent: Wednesday, February 04, 2015 11:23 PM\r\nTo: Juniper/OpenClos\r\nCc: Yun Li\r\nSubject: Re: [OpenClos] added check for master in trap daemon. it can be configured in openclos.... (#147)\r\n\r\n\r\nIn jnpr/openclos/trapd.py<https://github.com/Juniper/OpenClos/pull/147#discussion_r24142536>:\r\n\r\n>      # start the 2-stage configuration in a separate thread\r\n\r\n>      if trapReceiver is not None:\r\n\r\n> +        # execute 2-stage configuration callback if there is one configured in openclos.yaml\r\n\r\nDo you want to add isNdIntegrated check here?\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/Juniper/OpenClos/pull/147/files#r24142536>.\r\n","created_at":"2015-02-05T14:54:22Z","updated_at":"2015-02-05T14:54:22Z","html_url":"https://github.com/Juniper/OpenClos/pull/147#discussion_r24167620","pull_request_url":"https://api.github.com/repos/Juniper/OpenClos/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/comments/24167620"},"html":{"href":"https://github.com/Juniper/OpenClos/pull/147#discussion_r24167620"},"pull_request":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/Juniper/OpenClos/pulls/147","id":28697710,"html_url":"https://github.com/Juniper/OpenClos/pull/147","diff_url":"https://github.com/Juniper/OpenClos/pull/147.diff","patch_url":"https://github.com/Juniper/OpenClos/pull/147.patch","issue_url":"https://api.github.com/repos/Juniper/OpenClos/issues/147","number":147,"state":"closed","locked":false,"title":"added check for master in trap daemon. it can be configured in openclos....","user":{"login":"yunli2004","id":8332402,"avatar_url":"https://avatars.githubusercontent.com/u/8332402?v=3","gravatar_id":"","url":"https://api.github.com/users/yunli2004","html_url":"https://github.com/yunli2004","followers_url":"https://api.github.com/users/yunli2004/followers","following_url":"https://api.github.com/users/yunli2004/following{/other_user}","gists_url":"https://api.github.com/users/yunli2004/gists{/gist_id}","starred_url":"https://api.github.com/users/yunli2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunli2004/subscriptions","organizations_url":"https://api.github.com/users/yunli2004/orgs","repos_url":"https://api.github.com/users/yunli2004/repos","events_url":"https://api.github.com/users/yunli2004/events{/privacy}","received_events_url":"https://api.github.com/users/yunli2004/received_events","type":"User","site_admin":false},"body":"...yaml","created_at":"2015-02-05T03:59:33Z","updated_at":"2015-02-05T14:54:22Z","closed_at":"2015-02-05T03:59:40Z","merged_at":"2015-02-05T03:59:40Z","merge_commit_sha":"e9a7233d0a521b2b321a3b4bcda6d28a7df7f8dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Juniper/OpenClos/pulls/147/commits","review_comments_url":"https://api.github.com/repos/Juniper/OpenClos/pulls/147/comments","review_comment_url":"https://api.github.com/repos/Juniper/OpenClos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Juniper/OpenClos/issues/147/comments","statuses_url":"https://api.github.com/repos/Juniper/OpenClos/statuses/4e8d7fffae4e11369c9e61ed210b6da72838314c","head":{"label":"yunli2004:devR2.0","ref":"devR2.0","sha":"4e8d7fffae4e11369c9e61ed210b6da72838314c","user":{"login":"yunli2004","id":8332402,"avatar_url":"https://avatars.githubusercontent.com/u/8332402?v=3","gravatar_id":"","url":"https://api.github.com/users/yunli2004","html_url":"https://github.com/yunli2004","followers_url":"https://api.github.com/users/yunli2004/followers","following_url":"https://api.github.com/users/yunli2004/following{/other_user}","gists_url":"https://api.github.com/users/yunli2004/gists{/gist_id}","starred_url":"https://api.github.com/users/yunli2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunli2004/subscriptions","organizations_url":"https://api.github.com/users/yunli2004/orgs","repos_url":"https://api.github.com/users/yunli2004/repos","events_url":"https://api.github.com/users/yunli2004/events{/privacy}","received_events_url":"https://api.github.com/users/yunli2004/received_events","type":"User","site_admin":false},"repo":{"id":27887219,"name":"OpenClos","full_name":"yunli2004/OpenClos","owner":{"login":"yunli2004","id":8332402,"avatar_url":"https://avatars.githubusercontent.com/u/8332402?v=3","gravatar_id":"","url":"https://api.github.com/users/yunli2004","html_url":"https://github.com/yunli2004","followers_url":"https://api.github.com/users/yunli2004/followers","following_url":"https://api.github.com/users/yunli2004/following{/other_user}","gists_url":"https://api.github.com/users/yunli2004/gists{/gist_id}","starred_url":"https://api.github.com/users/yunli2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunli2004/subscriptions","organizations_url":"https://api.github.com/users/yunli2004/orgs","repos_url":"https://api.github.com/users/yunli2004/repos","events_url":"https://api.github.com/users/yunli2004/events{/privacy}","received_events_url":"https://api.github.com/users/yunli2004/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yunli2004/OpenClos","description":"","fork":true,"url":"https://api.github.com/repos/yunli2004/OpenClos","forks_url":"https://api.github.com/repos/yunli2004/OpenClos/forks","keys_url":"https://api.github.com/repos/yunli2004/OpenClos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yunli2004/OpenClos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yunli2004/OpenClos/teams","hooks_url":"https://api.github.com/repos/yunli2004/OpenClos/hooks","issue_events_url":"https://api.github.com/repos/yunli2004/OpenClos/issues/events{/number}","events_url":"https://api.github.com/repos/yunli2004/OpenClos/events","assignees_url":"https://api.github.com/repos/yunli2004/OpenClos/assignees{/user}","branches_url":"https://api.github.com/repos/yunli2004/OpenClos/branches{/branch}","tags_url":"https://api.github.com/repos/yunli2004/OpenClos/tags","blobs_url":"https://api.github.com/repos/yunli2004/OpenClos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yunli2004/OpenClos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yunli2004/OpenClos/git/refs{/sha}","trees_url":"https://api.github.com/repos/yunli2004/OpenClos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yunli2004/OpenClos/statuses/{sha}","languages_url":"https://api.github.com/repos/yunli2004/OpenClos/languages","stargazers_url":"https://api.github.com/repos/yunli2004/OpenClos/stargazers","contributors_url":"https://api.github.com/repos/yunli2004/OpenClos/contributors","subscribers_url":"https://api.github.com/repos/yunli2004/OpenClos/subscribers","subscription_url":"https://api.github.com/repos/yunli2004/OpenClos/subscription","commits_url":"https://api.github.com/repos/yunli2004/OpenClos/commits{/sha}","git_commits_url":"https://api.github.com/repos/yunli2004/OpenClos/git/commits{/sha}","comments_url":"https://api.github.com/repos/yunli2004/OpenClos/comments{/number}","issue_comment_url":"https://api.github.com/repos/yunli2004/OpenClos/issues/comments/{number}","contents_url":"https://api.github.com/repos/yunli2004/OpenClos/contents/{+path}","compare_url":"https://api.github.com/repos/yunli2004/OpenClos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yunli2004/OpenClos/merges","archive_url":"https://api.github.com/repos/yunli2004/OpenClos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yunli2004/OpenClos/downloads","issues_url":"https://api.github.com/repos/yunli2004/OpenClos/issues{/number}","pulls_url":"https://api.github.com/repos/yunli2004/OpenClos/pulls{/number}","milestones_url":"https://api.github.com/repos/yunli2004/OpenClos/milestones{/number}","notifications_url":"https://api.github.com/repos/yunli2004/OpenClos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yunli2004/OpenClos/labels{/name}","releases_url":"https://api.github.com/repos/yunli2004/OpenClos/releases{/id}","created_at":"2014-12-11T19:12:16Z","updated_at":"2015-02-05T03:58:26Z","pushed_at":"2015-02-05T03:58:25Z","git_url":"git://github.com/yunli2004/OpenClos.git","ssh_url":"git@github.com:yunli2004/OpenClos.git","clone_url":"https://github.com/yunli2004/OpenClos.git","svn_url":"https://github.com/yunli2004/OpenClos","homepage":null,"size":991,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devR2.0"}},"base":{"label":"Juniper:devR2.0","ref":"devR2.0","sha":"2c58246a0926db06176e364b43bfbbedaf98d168","user":{"login":"Juniper","id":3935164,"avatar_url":"https://avatars.githubusercontent.com/u/3935164?v=3","gravatar_id":"","url":"https://api.github.com/users/Juniper","html_url":"https://github.com/Juniper","followers_url":"https://api.github.com/users/Juniper/followers","following_url":"https://api.github.com/users/Juniper/following{/other_user}","gists_url":"https://api.github.com/users/Juniper/gists{/gist_id}","starred_url":"https://api.github.com/users/Juniper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juniper/subscriptions","organizations_url":"https://api.github.com/users/Juniper/orgs","repos_url":"https://api.github.com/users/Juniper/repos","events_url":"https://api.github.com/users/Juniper/events{/privacy}","received_events_url":"https://api.github.com/users/Juniper/received_events","type":"Organization","site_admin":false},"repo":{"id":20309790,"name":"OpenClos","full_name":"Juniper/OpenClos","owner":{"login":"Juniper","id":3935164,"avatar_url":"https://avatars.githubusercontent.com/u/3935164?v=3","gravatar_id":"","url":"https://api.github.com/users/Juniper","html_url":"https://github.com/Juniper","followers_url":"https://api.github.com/users/Juniper/followers","following_url":"https://api.github.com/users/Juniper/following{/other_user}","gists_url":"https://api.github.com/users/Juniper/gists{/gist_id}","starred_url":"https://api.github.com/users/Juniper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juniper/subscriptions","organizations_url":"https://api.github.com/users/Juniper/orgs","repos_url":"https://api.github.com/users/Juniper/repos","events_url":"https://api.github.com/users/Juniper/events{/privacy}","received_events_url":"https://api.github.com/users/Juniper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Juniper/OpenClos","description":"","fork":false,"url":"https://api.github.com/repos/Juniper/OpenClos","forks_url":"https://api.github.com/repos/Juniper/OpenClos/forks","keys_url":"https://api.github.com/repos/Juniper/OpenClos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Juniper/OpenClos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Juniper/OpenClos/teams","hooks_url":"https://api.github.com/repos/Juniper/OpenClos/hooks","issue_events_url":"https://api.github.com/repos/Juniper/OpenClos/issues/events{/number}","events_url":"https://api.github.com/repos/Juniper/OpenClos/events","assignees_url":"https://api.github.com/repos/Juniper/OpenClos/assignees{/user}","branches_url":"https://api.github.com/repos/Juniper/OpenClos/branches{/branch}","tags_url":"https://api.github.com/repos/Juniper/OpenClos/tags","blobs_url":"https://api.github.com/repos/Juniper/OpenClos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Juniper/OpenClos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Juniper/OpenClos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Juniper/OpenClos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Juniper/OpenClos/statuses/{sha}","languages_url":"https://api.github.com/repos/Juniper/OpenClos/languages","stargazers_url":"https://api.github.com/repos/Juniper/OpenClos/stargazers","contributors_url":"https://api.github.com/repos/Juniper/OpenClos/contributors","subscribers_url":"https://api.github.com/repos/Juniper/OpenClos/subscribers","subscription_url":"https://api.github.com/repos/Juniper/OpenClos/subscription","commits_url":"https://api.github.com/repos/Juniper/OpenClos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Juniper/OpenClos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Juniper/OpenClos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Juniper/OpenClos/issues/comments/{number}","contents_url":"https://api.github.com/repos/Juniper/OpenClos/contents/{+path}","compare_url":"https://api.github.com/repos/Juniper/OpenClos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Juniper/OpenClos/merges","archive_url":"https://api.github.com/repos/Juniper/OpenClos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Juniper/OpenClos/downloads","issues_url":"https://api.github.com/repos/Juniper/OpenClos/issues{/number}","pulls_url":"https://api.github.com/repos/Juniper/OpenClos/pulls{/number}","milestones_url":"https://api.github.com/repos/Juniper/OpenClos/milestones{/number}","notifications_url":"https://api.github.com/repos/Juniper/OpenClos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Juniper/OpenClos/labels{/name}","releases_url":"https://api.github.com/repos/Juniper/OpenClos/releases{/id}","created_at":"2014-05-29T22:04:10Z","updated_at":"2015-01-27T21:24:17Z","pushed_at":"2015-02-05T03:59:40Z","git_url":"git://github.com/Juniper/OpenClos.git","ssh_url":"git@github.com:Juniper/OpenClos.git","clone_url":"https://github.com/Juniper/OpenClos.git","svn_url":"https://github.com/Juniper/OpenClos","homepage":null,"size":2052,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/147"},"html":{"href":"https://github.com/Juniper/OpenClos/pull/147"},"issue":{"href":"https://api.github.com/repos/Juniper/OpenClos/issues/147"},"comments":{"href":"https://api.github.com/repos/Juniper/OpenClos/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Juniper/OpenClos/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/Juniper/OpenClos/statuses/4e8d7fffae4e11369c9e61ed210b6da72838314c"}}}}