{"action":"created","issue":{"url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/56","labels_url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/56/comments","events_url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/56/events","html_url":"https://github.com/PracticallyGreen/omniauth-saml/pull/56","id":109525593,"number":56,"title":"Make a copy of @options when this strategy instance is dup'd","user":{"login":"md5","id":76367,"avatar_url":"https://avatars.githubusercontent.com/u/76367?v=3","gravatar_id":"","url":"https://api.github.com/users/md5","html_url":"https://github.com/md5","followers_url":"https://api.github.com/users/md5/followers","following_url":"https://api.github.com/users/md5/following{/other_user}","gists_url":"https://api.github.com/users/md5/gists{/gist_id}","starred_url":"https://api.github.com/users/md5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/md5/subscriptions","organizations_url":"https://api.github.com/users/md5/orgs","repos_url":"https://api.github.com/users/md5/repos","events_url":"https://api.github.com/users/md5/events{/privacy}","received_events_url":"https://api.github.com/users/md5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-02T16:25:04Z","updated_at":"2015-11-08T21:08:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/pulls/56","html_url":"https://github.com/PracticallyGreen/omniauth-saml/pull/56","diff_url":"https://github.com/PracticallyGreen/omniauth-saml/pull/56.diff","patch_url":"https://github.com/PracticallyGreen/omniauth-saml/pull/56.patch"},"body":"Since `OmniAuth::Strategy#call` does `dup` before calling `call!`, this allows the `options` to be mutated without affecting subsequent requests.\r\n\r\nFixes #54 "},"comment":{"url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/comments/154871910","html_url":"https://github.com/PracticallyGreen/omniauth-saml/pull/56#issuecomment-154871910","issue_url":"https://api.github.com/repos/PracticallyGreen/omniauth-saml/issues/56","id":154871910,"user":{"login":"md5","id":76367,"avatar_url":"https://avatars.githubusercontent.com/u/76367?v=3","gravatar_id":"","url":"https://api.github.com/users/md5","html_url":"https://github.com/md5","followers_url":"https://api.github.com/users/md5/followers","following_url":"https://api.github.com/users/md5/following{/other_user}","gists_url":"https://api.github.com/users/md5/gists{/gist_id}","starred_url":"https://api.github.com/users/md5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/md5/subscriptions","organizations_url":"https://api.github.com/users/md5/orgs","repos_url":"https://api.github.com/users/md5/repos","events_url":"https://api.github.com/users/md5/events{/privacy}","received_events_url":"https://api.github.com/users/md5/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T21:08:29Z","updated_at":"2015-11-08T21:08:29Z","body":"I just realized that this patch won't work outside of a Rails environment because `#deep_dup` is a Rails addition. Outside of Rails, calling `@options.deep_dup` will return `nil`, since Hashie will interpret it as `@options['deep_dup']`.\r\n\r\nI'm going to work on a patch for `omniauth` itself that works outside of Rails."}}