{"action":"opened","number":1003,"pull_request":{"url":"https://api.github.com/repos/martine/ninja/pulls/1003","id":41986787,"html_url":"https://github.com/martine/ninja/pull/1003","diff_url":"https://github.com/martine/ninja/pull/1003.diff","patch_url":"https://github.com/martine/ninja/pull/1003.patch","issue_url":"https://api.github.com/repos/martine/ninja/issues/1003","number":1003,"state":"open","locked":false,"title":"Fix compile on VS2015","user":{"login":"sgraham","id":1822,"avatar_url":"https://avatars.githubusercontent.com/u/1822?v=3","gravatar_id":"","url":"https://api.github.com/users/sgraham","html_url":"https://github.com/sgraham","followers_url":"https://api.github.com/users/sgraham/followers","following_url":"https://api.github.com/users/sgraham/following{/other_user}","gists_url":"https://api.github.com/users/sgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/sgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgraham/subscriptions","organizations_url":"https://api.github.com/users/sgraham/orgs","repos_url":"https://api.github.com/users/sgraham/repos","events_url":"https://api.github.com/users/sgraham/events{/privacy}","received_events_url":"https://api.github.com/users/sgraham/received_events","type":"User","site_admin":false},"body":"This fixes issue #995. Defining _HAS_EXCEPTIONS=0 is the important part.\r\n\r\nUnfortunately, it seems set_terminate and terminate_handler have declarations both in and out of `std::` now (maybe only when exceptions are disabled? I didn't stare too hard at the headers), so `using namespace std;` causes some problems (below). I hacked around these by removing/adding a couple `std::` but maybe it's time to get rid of `using std`. :(\r\n\r\ngraphviz.cc\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(33): error C2872: 'terminate_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(18): note: could be 'void (__cdecl *__cdecl terminate_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(191): note: or       'std::terminate_handler'\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(34): error C2872: 'terminate_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(18): note: could be 'void (__cdecl *__cdecl terminate_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(191): note: or       'std::terminate_handler'\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(37): error C2872: 'terminate_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.10150.0\\ucrt\\corecrt_terminate.h(18): note: could be 'void (__cdecl *__cdecl terminate_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(191): note: or       'std::terminate_handler'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(35): error C2872: 'unexpected_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(19): note: could be 'void (__cdecl *__cdecl unexpected_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(192): note: or       'std::unexpected_handler'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(36): error C2872: 'unexpected_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(19): note: could be 'void (__cdecl *__cdecl unexpected_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(192): note: or       'std::unexpected_handler'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(39): error C2872: 'unexpected_handler': ambiguous symbol\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\eh.h(19): note: could be 'void (__cdecl *__cdecl unexpected_handler)(void)'\r\nC:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE\\exception(192): note: or       'std::unexpected_handler'\r\nwhen running:  cl /nologo /Zi /W4 /WX /wd4530 /wd4100 /wd4706 /wd4512 /wd4800 /wd4702 /wd4819 /wd4355 /wd4091 /GR- /wd4267 /DNOMINMAX /D_CRT_SECURE_NO_WARNINGS /D_HAS_EXCEPTIONS=0 /DNINJA_PYTHON=\"python.exe\" /FS /Ox /DNDEBUG /GL -I. -c d:\\src\\ninja\\src\\graphviz.cc /Fobuild\\graphviz.obj","created_at":"2015-08-10T04:31:34Z","updated_at":"2015-08-10T04:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/martine/ninja/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/martine/ninja/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/martine/ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martine/ninja/issues/1003/comments","statuses_url":"https://api.github.com/repos/martine/ninja/statuses/956b4f1bc4f276325fd3ad8670be6bc9c9804fb9","head":{"label":"sgraham:2015-compile","ref":"2015-compile","sha":"956b4f1bc4f276325fd3ad8670be6bc9c9804fb9","user":{"login":"sgraham","id":1822,"avatar_url":"https://avatars.githubusercontent.com/u/1822?v=3","gravatar_id":"","url":"https://api.github.com/users/sgraham","html_url":"https://github.com/sgraham","followers_url":"https://api.github.com/users/sgraham/followers","following_url":"https://api.github.com/users/sgraham/following{/other_user}","gists_url":"https://api.github.com/users/sgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/sgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgraham/subscriptions","organizations_url":"https://api.github.com/users/sgraham/orgs","repos_url":"https://api.github.com/users/sgraham/repos","events_url":"https://api.github.com/users/sgraham/events{/privacy}","received_events_url":"https://api.github.com/users/sgraham/received_events","type":"User","site_admin":false},"repo":{"id":2129215,"name":"ninja","full_name":"sgraham/ninja","owner":{"login":"sgraham","id":1822,"avatar_url":"https://avatars.githubusercontent.com/u/1822?v=3","gravatar_id":"","url":"https://api.github.com/users/sgraham","html_url":"https://github.com/sgraham","followers_url":"https://api.github.com/users/sgraham/followers","following_url":"https://api.github.com/users/sgraham/following{/other_user}","gists_url":"https://api.github.com/users/sgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/sgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgraham/subscriptions","organizations_url":"https://api.github.com/users/sgraham/orgs","repos_url":"https://api.github.com/users/sgraham/repos","events_url":"https://api.github.com/users/sgraham/events{/privacy}","received_events_url":"https://api.github.com/users/sgraham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgraham/ninja","description":"a small build system similar to make","fork":true,"url":"https://api.github.com/repos/sgraham/ninja","forks_url":"https://api.github.com/repos/sgraham/ninja/forks","keys_url":"https://api.github.com/repos/sgraham/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgraham/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgraham/ninja/teams","hooks_url":"https://api.github.com/repos/sgraham/ninja/hooks","issue_events_url":"https://api.github.com/repos/sgraham/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/sgraham/ninja/events","assignees_url":"https://api.github.com/repos/sgraham/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/sgraham/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/sgraham/ninja/tags","blobs_url":"https://api.github.com/repos/sgraham/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgraham/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgraham/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgraham/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgraham/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/sgraham/ninja/languages","stargazers_url":"https://api.github.com/repos/sgraham/ninja/stargazers","contributors_url":"https://api.github.com/repos/sgraham/ninja/contributors","subscribers_url":"https://api.github.com/repos/sgraham/ninja/subscribers","subscription_url":"https://api.github.com/repos/sgraham/ninja/subscription","commits_url":"https://api.github.com/repos/sgraham/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgraham/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgraham/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgraham/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgraham/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/sgraham/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgraham/ninja/merges","archive_url":"https://api.github.com/repos/sgraham/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgraham/ninja/downloads","issues_url":"https://api.github.com/repos/sgraham/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/sgraham/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/sgraham/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/sgraham/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgraham/ninja/labels{/name}","releases_url":"https://api.github.com/repos/sgraham/ninja/releases{/id}","created_at":"2011-07-30T15:59:22Z","updated_at":"2014-06-19T19:21:33Z","pushed_at":"2015-08-10T04:27:46Z","git_url":"git://github.com/sgraham/ninja.git","ssh_url":"git@github.com:sgraham/ninja.git","clone_url":"https://github.com/sgraham/ninja.git","svn_url":"https://github.com/sgraham/ninja","homepage":"http://martine.github.com/ninja/","size":7692,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"martine:master","ref":"master","sha":"ddc1777449208ace6f494277c329ebd84671f4b5","user":{"login":"martine","id":3847,"avatar_url":"https://avatars.githubusercontent.com/u/3847?v=3","gravatar_id":"","url":"https://api.github.com/users/martine","html_url":"https://github.com/martine","followers_url":"https://api.github.com/users/martine/followers","following_url":"https://api.github.com/users/martine/following{/other_user}","gists_url":"https://api.github.com/users/martine/gists{/gist_id}","starred_url":"https://api.github.com/users/martine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martine/subscriptions","organizations_url":"https://api.github.com/users/martine/orgs","repos_url":"https://api.github.com/users/martine/repos","events_url":"https://api.github.com/users/martine/events{/privacy}","received_events_url":"https://api.github.com/users/martine/received_events","type":"User","site_admin":false},"repo":{"id":1335132,"name":"ninja","full_name":"martine/ninja","owner":{"login":"martine","id":3847,"avatar_url":"https://avatars.githubusercontent.com/u/3847?v=3","gravatar_id":"","url":"https://api.github.com/users/martine","html_url":"https://github.com/martine","followers_url":"https://api.github.com/users/martine/followers","following_url":"https://api.github.com/users/martine/following{/other_user}","gists_url":"https://api.github.com/users/martine/gists{/gist_id}","starred_url":"https://api.github.com/users/martine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martine/subscriptions","organizations_url":"https://api.github.com/users/martine/orgs","repos_url":"https://api.github.com/users/martine/repos","events_url":"https://api.github.com/users/martine/events{/privacy}","received_events_url":"https://api.github.com/users/martine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martine/ninja","description":"a small build system with a focus on speed","fork":false,"url":"https://api.github.com/repos/martine/ninja","forks_url":"https://api.github.com/repos/martine/ninja/forks","keys_url":"https://api.github.com/repos/martine/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martine/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martine/ninja/teams","hooks_url":"https://api.github.com/repos/martine/ninja/hooks","issue_events_url":"https://api.github.com/repos/martine/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/martine/ninja/events","assignees_url":"https://api.github.com/repos/martine/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/martine/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/martine/ninja/tags","blobs_url":"https://api.github.com/repos/martine/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martine/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martine/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/martine/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martine/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/martine/ninja/languages","stargazers_url":"https://api.github.com/repos/martine/ninja/stargazers","contributors_url":"https://api.github.com/repos/martine/ninja/contributors","subscribers_url":"https://api.github.com/repos/martine/ninja/subscribers","subscription_url":"https://api.github.com/repos/martine/ninja/subscription","commits_url":"https://api.github.com/repos/martine/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/martine/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/martine/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/martine/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/martine/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/martine/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martine/ninja/merges","archive_url":"https://api.github.com/repos/martine/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martine/ninja/downloads","issues_url":"https://api.github.com/repos/martine/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/martine/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/martine/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/martine/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martine/ninja/labels{/name}","releases_url":"https://api.github.com/repos/martine/ninja/releases{/id}","created_at":"2011-02-06T19:07:12Z","updated_at":"2015-08-09T15:36:18Z","pushed_at":"2015-08-07T13:38:19Z","git_url":"git://github.com/martine/ninja.git","ssh_url":"git@github.com:martine/ninja.git","clone_url":"https://github.com/martine/ninja.git","svn_url":"https://github.com/martine/ninja","homepage":"http://martine.github.com/ninja/","size":8217,"stargazers_count":1479,"watchers_count":1479,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":151,"forks":259,"open_issues":151,"watchers":1479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martine/ninja/pulls/1003"},"html":{"href":"https://github.com/martine/ninja/pull/1003"},"issue":{"href":"https://api.github.com/repos/martine/ninja/issues/1003"},"comments":{"href":"https://api.github.com/repos/martine/ninja/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/martine/ninja/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/martine/ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martine/ninja/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/martine/ninja/statuses/956b4f1bc4f276325fd3ad8670be6bc9c9804fb9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":4,"deletions":4,"changed_files":3}}