{"action":"closed","issue":{"url":"https://api.github.com/repos/ef4/liquid-fire/issues/184","labels_url":"https://api.github.com/repos/ef4/liquid-fire/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/ef4/liquid-fire/issues/184/comments","events_url":"https://api.github.com/repos/ef4/liquid-fire/issues/184/events","html_url":"https://github.com/ef4/liquid-fire/issues/184","id":58971300,"number":184,"title":"Trouble with the Modal example","user":{"login":"urahonky","id":6754000,"avatar_url":"https://avatars.githubusercontent.com/u/6754000?v=3","gravatar_id":"","url":"https://api.github.com/users/urahonky","html_url":"https://github.com/urahonky","followers_url":"https://api.github.com/users/urahonky/followers","following_url":"https://api.github.com/users/urahonky/following{/other_user}","gists_url":"https://api.github.com/users/urahonky/gists{/gist_id}","starred_url":"https://api.github.com/users/urahonky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urahonky/subscriptions","organizations_url":"https://api.github.com/users/urahonky/orgs","repos_url":"https://api.github.com/users/urahonky/repos","events_url":"https://api.github.com/users/urahonky/events{/privacy}","received_events_url":"https://api.github.com/users/urahonky/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-25T21:17:37Z","updated_at":"2015-02-26T16:13:05Z","closed_at":"2015-02-26T16:13:05Z","body":"Hello!\r\n\r\nFirst of all I just want to say thank you for making this addon for Ember CLI. Transitions and Modals are a huge pain in the butt for me and having an addon would take a lot of stress off my mind.\r\n\r\nNow on to the issue:\r\n\r\nI followed your http://ef4.github.io/liquid-fire/#/modals tutorial. Whenever I click the button the modal window pops up at the bottom of the page (but does not pop out of the page). \r\n\r\nI'm using Ember CLI version: 0.2.0-beta.1 and Ember v 1.10 with liquid-fire v1. 0.17.0 (since I'm not on Ember v1.11 yet). \r\n\r\nHere's the code I'm using:\r\n\r\ncontroller:\r\n```\r\n    export default Ember.Controller.extend({\r\n        queryParams: ['salutation', 'person'],\r\n        salutation: null,\r\n        person: null,\r\n        modalMessage: \"bound text for modal\"\r\n    });\r\n```\r\nrouter.js:\r\n```\r\n    this.modal('hello-modal', {\r\n        withParams: ['salutation', 'person'],\r\n        otherParams: {\r\n            modalMessage: \"message\"\r\n        },\r\n        actions: {\r\n            changeSalutation: \"changeSalutation\"\r\n        }\r\n    });\r\n```\r\nhello-modal.hbs:\r\n```\r\n<div>{{salutation}} {{person}}!</div>\r\n<div>{{input value=message class=\"modal-input\"}}</div>\r\n<button {{action \"gotIt\"}} class=\"done\">Thanks</button>\r\n<button {{action \"change\"}} class=\"change\">Change</button>\r\n```\r\ncomponents/hello-modal.js:\r\n```\r\nexport default Ember.Component.extend({\r\n\tclassNames: ['hello-modal'],\r\n\tactions: {\r\n\t    gotIt: function() {\r\n\t      this.sendAction('dismiss');\r\n\t    },\r\n\t    change: function() {\r\n\t      this.sendAction('changeSalutation');\r\n\t    }\r\n\t  }\r\n});\r\n```\r\ntemplate:\r\n```\r\n{{#link-to (query-params salutation=\"Guten tag\" person=\"Stef\") tagName=\"button\"}}\r\nTry It\r\n{{/link-to}}\r\n```\r\n\r\nquick screenshot (this is appended to the bottom of the html page and doesn't pop out like a model window as your example shows):\r\n![modal](https://cloud.githubusercontent.com/assets/6754000/6380635/132239ee-bd09-11e4-9eee-5adc442add45.PNG)\r\n\r\n\r\nThis warning also shows up in my console if it gives any help:\r\nWARNING: You're attempting to render a view by passing boundContextBinding to a view helper without a quoted value, but this syntax is ambiguous. You should either surround boundContextBinding's value in quotes or remove `Binding` from boundContextBinding.\r\nvendor.js:80744 Object\r\n\r\nThank you for your time! If you need any additional information please let me know."}}