{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1384","labels_url":"https://api.github.com/repos/philc/vimium/issues/1384/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1384/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1384/events","html_url":"https://github.com/philc/vimium/pull/1384","id":53004942,"number":1384,"title":"Uniform treatment of search queries","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/philc/vimium/labels/smb-watching","name":"smb-watching","color":"bfd4f2"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-12-28T17:13:56Z","updated_at":"2015-01-28T13:42:44Z","closed_at":"2014-12-29T15:16:46Z","pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1384","html_url":"https://github.com/philc/vimium/pull/1384","diff_url":"https://github.com/philc/vimium/pull/1384.diff","patch_url":"https://github.com/philc/vimium/pull/1384.patch"},"body":"Our approach to building search URLs for the default search engine and for custom search engines has been different.  See #1334 for a case which is broken.  In fact, if you define Wikipedia to be your default search engine, then our long-established existing implementation is broken too\r\n\r\nThis PR introduces a consistent approach to building search URLs:\r\n- URL encode each \"word\"\r\n- Join url-encoded words with `+` instead of `Space`.\r\n\r\nThis is how chrome handles custom search engines, and seems (?) to work in more cases.\r\n\r\nNote... There's a long discussion in #1169 about custom search engines which are admitted by our current implementation but probably shouldn't be.  This PR breaks such custom search engines (e.g it breaks a \"custom search engine\" which calls arbitrary Javascript).\r\n\r\nReplaces #1335.\r\nFixes #1334."},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/71836130","html_url":"https://github.com/philc/vimium/pull/1384#issuecomment-71836130","issue_url":"https://api.github.com/repos/philc/vimium/issues/1384","id":71836130,"user":{"login":"mijoharas","id":4069743,"avatar_url":"https://avatars.githubusercontent.com/u/4069743?v=3","gravatar_id":"","url":"https://api.github.com/users/mijoharas","html_url":"https://github.com/mijoharas","followers_url":"https://api.github.com/users/mijoharas/followers","following_url":"https://api.github.com/users/mijoharas/following{/other_user}","gists_url":"https://api.github.com/users/mijoharas/gists{/gist_id}","starred_url":"https://api.github.com/users/mijoharas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mijoharas/subscriptions","organizations_url":"https://api.github.com/users/mijoharas/orgs","repos_url":"https://api.github.com/users/mijoharas/repos","events_url":"https://api.github.com/users/mijoharas/events{/privacy}","received_events_url":"https://api.github.com/users/mijoharas/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T13:42:44Z","updated_at":"2015-01-28T13:42:44Z","body":"Do we know when the next release is likely to be? I just got annoyed enough by the broken multi-word searches to come over here and fix it, looks like it's already been fixed :smile: . Will this be in the next release?"}}