{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58","id":51975986,"html_url":"https://github.com/Polyconseil/aioamqp/pull/58","diff_url":"https://github.com/Polyconseil/aioamqp/pull/58.diff","patch_url":"https://github.com/Polyconseil/aioamqp/pull/58.patch","issue_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/58","number":58,"state":"closed","locked":false,"title":"channel: ensure we don't mess with waiter when the connection is closing","user":{"login":"dzen","id":50241,"avatar_url":"https://avatars.githubusercontent.com/u/50241?v=3","gravatar_id":"","url":"https://api.github.com/users/dzen","html_url":"https://github.com/dzen","followers_url":"https://api.github.com/users/dzen/followers","following_url":"https://api.github.com/users/dzen/following{/other_user}","gists_url":"https://api.github.com/users/dzen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzen/subscriptions","organizations_url":"https://api.github.com/users/dzen/orgs","repos_url":"https://api.github.com/users/dzen/repos","events_url":"https://api.github.com/users/dzen/events{/privacy}","received_events_url":"https://api.github.com/users/dzen/received_events","type":"User","site_admin":false},"body":"When the connection is closing, the current code tries to stop all the waiters (on all previous command sent to the server).\r\n\r\n","created_at":"2015-11-27T09:45:42Z","updated_at":"2015-12-02T15:49:25Z","closed_at":"2015-12-02T15:49:25Z","merged_at":"2015-12-02T15:49:25Z","merge_commit_sha":"39aedfc4d1e5f2c5fbe6304e22564a2675ea09a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58/commits","review_comments_url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58/comments","review_comment_url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/58/comments","statuses_url":"https://api.github.com/repos/Polyconseil/aioamqp/statuses/4e6576bac45d83f36688c9fda665ed479dad053b","head":{"label":"Polyconseil:bcz/closing_channels","ref":"bcz/closing_channels","sha":"4e6576bac45d83f36688c9fda665ed479dad053b","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":17059992,"name":"aioamqp","full_name":"Polyconseil/aioamqp","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/aioamqp","description":"AMQP implementation using asyncio","fork":false,"url":"https://api.github.com/repos/Polyconseil/aioamqp","forks_url":"https://api.github.com/repos/Polyconseil/aioamqp/forks","keys_url":"https://api.github.com/repos/Polyconseil/aioamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/aioamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/aioamqp/teams","hooks_url":"https://api.github.com/repos/Polyconseil/aioamqp/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/aioamqp/events","assignees_url":"https://api.github.com/repos/Polyconseil/aioamqp/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/aioamqp/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/aioamqp/tags","blobs_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/aioamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/aioamqp/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/aioamqp/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/aioamqp/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/aioamqp/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/aioamqp/subscription","commits_url":"https://api.github.com/repos/Polyconseil/aioamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/aioamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/aioamqp/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/aioamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/aioamqp/merges","archive_url":"https://api.github.com/repos/Polyconseil/aioamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/aioamqp/downloads","issues_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/aioamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/aioamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/aioamqp/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/aioamqp/releases{/id}","created_at":"2014-02-21T15:15:31Z","updated_at":"2015-11-24T07:16:17Z","pushed_at":"2015-12-02T15:49:25Z","git_url":"git://github.com/Polyconseil/aioamqp.git","ssh_url":"git@github.com:Polyconseil/aioamqp.git","clone_url":"https://github.com/Polyconseil/aioamqp.git","svn_url":"https://github.com/Polyconseil/aioamqp","homepage":null,"size":290,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":27,"default_branch":"master"}},"base":{"label":"Polyconseil:master","ref":"master","sha":"8fcc4826af63bc377ace93ad7ab18d4e171fc68a","user":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"repo":{"id":17059992,"name":"aioamqp","full_name":"Polyconseil/aioamqp","owner":{"login":"Polyconseil","id":818669,"avatar_url":"https://avatars.githubusercontent.com/u/818669?v=3","gravatar_id":"","url":"https://api.github.com/users/Polyconseil","html_url":"https://github.com/Polyconseil","followers_url":"https://api.github.com/users/Polyconseil/followers","following_url":"https://api.github.com/users/Polyconseil/following{/other_user}","gists_url":"https://api.github.com/users/Polyconseil/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyconseil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyconseil/subscriptions","organizations_url":"https://api.github.com/users/Polyconseil/orgs","repos_url":"https://api.github.com/users/Polyconseil/repos","events_url":"https://api.github.com/users/Polyconseil/events{/privacy}","received_events_url":"https://api.github.com/users/Polyconseil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polyconseil/aioamqp","description":"AMQP implementation using asyncio","fork":false,"url":"https://api.github.com/repos/Polyconseil/aioamqp","forks_url":"https://api.github.com/repos/Polyconseil/aioamqp/forks","keys_url":"https://api.github.com/repos/Polyconseil/aioamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polyconseil/aioamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polyconseil/aioamqp/teams","hooks_url":"https://api.github.com/repos/Polyconseil/aioamqp/hooks","issue_events_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/events{/number}","events_url":"https://api.github.com/repos/Polyconseil/aioamqp/events","assignees_url":"https://api.github.com/repos/Polyconseil/aioamqp/assignees{/user}","branches_url":"https://api.github.com/repos/Polyconseil/aioamqp/branches{/branch}","tags_url":"https://api.github.com/repos/Polyconseil/aioamqp/tags","blobs_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polyconseil/aioamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/Polyconseil/aioamqp/languages","stargazers_url":"https://api.github.com/repos/Polyconseil/aioamqp/stargazers","contributors_url":"https://api.github.com/repos/Polyconseil/aioamqp/contributors","subscribers_url":"https://api.github.com/repos/Polyconseil/aioamqp/subscribers","subscription_url":"https://api.github.com/repos/Polyconseil/aioamqp/subscription","commits_url":"https://api.github.com/repos/Polyconseil/aioamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polyconseil/aioamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polyconseil/aioamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polyconseil/aioamqp/contents/{+path}","compare_url":"https://api.github.com/repos/Polyconseil/aioamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polyconseil/aioamqp/merges","archive_url":"https://api.github.com/repos/Polyconseil/aioamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polyconseil/aioamqp/downloads","issues_url":"https://api.github.com/repos/Polyconseil/aioamqp/issues{/number}","pulls_url":"https://api.github.com/repos/Polyconseil/aioamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/Polyconseil/aioamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/Polyconseil/aioamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polyconseil/aioamqp/labels{/name}","releases_url":"https://api.github.com/repos/Polyconseil/aioamqp/releases{/id}","created_at":"2014-02-21T15:15:31Z","updated_at":"2015-11-24T07:16:17Z","pushed_at":"2015-12-02T15:49:25Z","git_url":"git://github.com/Polyconseil/aioamqp.git","ssh_url":"git@github.com:Polyconseil/aioamqp.git","clone_url":"https://github.com/Polyconseil/aioamqp.git","svn_url":"https://github.com/Polyconseil/aioamqp","homepage":null,"size":290,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58"},"html":{"href":"https://github.com/Polyconseil/aioamqp/pull/58"},"issue":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/issues/58"},"comments":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/Polyconseil/aioamqp/statuses/4e6576bac45d83f36688c9fda665ed479dad053b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dzen","id":50241,"avatar_url":"https://avatars.githubusercontent.com/u/50241?v=3","gravatar_id":"","url":"https://api.github.com/users/dzen","html_url":"https://github.com/dzen","followers_url":"https://api.github.com/users/dzen/followers","following_url":"https://api.github.com/users/dzen/following{/other_user}","gists_url":"https://api.github.com/users/dzen/gists{/gist_id}","starred_url":"https://api.github.com/users/dzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzen/subscriptions","organizations_url":"https://api.github.com/users/dzen/orgs","repos_url":"https://api.github.com/users/dzen/repos","events_url":"https://api.github.com/users/dzen/events{/privacy}","received_events_url":"https://api.github.com/users/dzen/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}