{"action":"closed","number":10773,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/10773","id":32262082,"html_url":"https://github.com/emberjs/ember.js/pull/10773","diff_url":"https://github.com/emberjs/ember.js/pull/10773.diff","patch_url":"https://github.com/emberjs/ember.js/pull/10773.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/10773","number":10773,"state":"closed","locked":false,"title":"[BUGFIX beta] fix Em.computed.sort leaking listeners","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"body":"First commit will be a failing test case, second is the fix.\r\n\r\nWhen an object is torn down, it should remove the array observers from\r\nthe sortProperties array. Unfortunately, they are currently not removed.\r\n\r\nIf `sortProperties` is on the prototype (e.g. an array literal when\r\nusing `extend` or `createWithMixins`, these event listeners can never\r\nbe garbage collected.\r\n\r\nThis doesn't tend to be as much of an issue in production but can really start to slow tests down.\r\n\r\nThe current workaround is to wrap the array literal in a computed property:\r\n\r\n```javascript\r\n\r\nvar MyObj = Ember.Object.extend({\r\n  sortPropertiest: Ember.computed(function(){\r\n    return ['firstName'];\r\n  })\r\n})\r\n```","created_at":"2015-03-30T20:07:14Z","updated_at":"2015-04-05T02:16:44Z","closed_at":"2015-04-05T02:16:44Z","merged_at":"2015-04-05T02:16:44Z","merge_commit_sha":"8d42dc56c7b4c4a5da9aa6765871a1a530bd66ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10773/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/10773/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/10773/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/c8b2ebf1a5d3d51b0c14e4fa87e9a97413412488","head":{"label":"fivetanley:fivetanley/array-observer-leaks","ref":"fivetanley/array-observer-leaks","sha":"c8b2ebf1a5d3d51b0c14e4fa87e9a97413412488","user":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"repo":{"id":7310943,"name":"ember.js","full_name":"fivetanley/ember.js","owner":{"login":"fivetanley","id":1275021,"avatar_url":"https://avatars.githubusercontent.com/u/1275021?v=3","gravatar_id":"","url":"https://api.github.com/users/fivetanley","html_url":"https://github.com/fivetanley","followers_url":"https://api.github.com/users/fivetanley/followers","following_url":"https://api.github.com/users/fivetanley/following{/other_user}","gists_url":"https://api.github.com/users/fivetanley/gists{/gist_id}","starred_url":"https://api.github.com/users/fivetanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fivetanley/subscriptions","organizations_url":"https://api.github.com/users/fivetanley/orgs","repos_url":"https://api.github.com/users/fivetanley/repos","events_url":"https://api.github.com/users/fivetanley/events{/privacy}","received_events_url":"https://api.github.com/users/fivetanley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fivetanley/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/fivetanley/ember.js","forks_url":"https://api.github.com/repos/fivetanley/ember.js/forks","keys_url":"https://api.github.com/repos/fivetanley/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fivetanley/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fivetanley/ember.js/teams","hooks_url":"https://api.github.com/repos/fivetanley/ember.js/hooks","issue_events_url":"https://api.github.com/repos/fivetanley/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/fivetanley/ember.js/events","assignees_url":"https://api.github.com/repos/fivetanley/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/fivetanley/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/fivetanley/ember.js/tags","blobs_url":"https://api.github.com/repos/fivetanley/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fivetanley/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fivetanley/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/fivetanley/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fivetanley/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/fivetanley/ember.js/languages","stargazers_url":"https://api.github.com/repos/fivetanley/ember.js/stargazers","contributors_url":"https://api.github.com/repos/fivetanley/ember.js/contributors","subscribers_url":"https://api.github.com/repos/fivetanley/ember.js/subscribers","subscription_url":"https://api.github.com/repos/fivetanley/ember.js/subscription","commits_url":"https://api.github.com/repos/fivetanley/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/fivetanley/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/fivetanley/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/fivetanley/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/fivetanley/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/fivetanley/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fivetanley/ember.js/merges","archive_url":"https://api.github.com/repos/fivetanley/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fivetanley/ember.js/downloads","issues_url":"https://api.github.com/repos/fivetanley/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/fivetanley/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/fivetanley/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/fivetanley/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fivetanley/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/fivetanley/ember.js/releases{/id}","created_at":"2012-12-24T19:47:12Z","updated_at":"2014-10-24T23:59:55Z","pushed_at":"2015-03-30T20:11:21Z","git_url":"git://github.com/fivetanley/ember.js.git","ssh_url":"git@github.com:fivetanley/ember.js.git","clone_url":"https://github.com/fivetanley/ember.js.git","svn_url":"https://github.com/fivetanley/ember.js","homepage":"http://www.emberjs.com","size":24342,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"8e8b33261cc4e7ba6c4f14cc0c2a6590213089eb","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-04-05T02:14:36Z","pushed_at":"2015-04-05T02:16:44Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":75726,"stargazers_count":13271,"watchers_count":13271,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2826,"mirror_url":null,"open_issues_count":336,"forks":2826,"open_issues":336,"watchers":13271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10773"},"html":{"href":"https://github.com/emberjs/ember.js/pull/10773"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10773"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/10773/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10773/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/10773/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/c8b2ebf1a5d3d51b0c14e4fa87e9a97413412488"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":41,"deletions":1,"changed_files":2}}