{"action":"created","comment":{"url":"https://api.github.com/repos/Astrac/consierge/pulls/comments/47573181","id":47573181,"diff_hunk":"@@ -66,7 +50,14 @@ trait IssueFetching {\n       response.entity\n         .toStrict(config.timeout)\n         .map { entity =>\n-          Json.parse(entity.data.decodeString(\"UTF-8\")).as[Seq[Issue]]\n+          val dt = entity.data.decodeString(\"UTF-8\")\n+          try {\n+            Json.parse(dt).as[Seq[Issue]]\n+          } catch {\n+            case e: Exception =>\n+              logger.error(s\"Unable to parse server results: $dt\")\n+              throw e","path":"src/main/scala/ensime/consierge/IssueFetching.scala","position":50,"original_position":50,"commit_id":"52746f2bcb8ca87ca619f97788732e40bb673966","original_commit_id":"52746f2bcb8ca87ca619f97788732e40bb673966","user":{"login":"fommil","id":1914041,"avatar_url":"https://avatars.githubusercontent.com/u/1914041?v=3","gravatar_id":"","url":"https://api.github.com/users/fommil","html_url":"https://github.com/fommil","followers_url":"https://api.github.com/users/fommil/followers","following_url":"https://api.github.com/users/fommil/following{/other_user}","gists_url":"https://api.github.com/users/fommil/gists{/gist_id}","starred_url":"https://api.github.com/users/fommil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fommil/subscriptions","organizations_url":"https://api.github.com/users/fommil/orgs","repos_url":"https://api.github.com/users/fommil/repos","events_url":"https://api.github.com/users/fommil/events{/privacy}","received_events_url":"https://api.github.com/users/fommil/received_events","type":"User","site_admin":false},"body":"I'm usually not keen on catching, logging and rethrowing. Is there an advantage to doing it here? It kills the stack trace.\r\n","created_at":"2015-12-14T23:04:08Z","updated_at":"2015-12-14T23:04:08Z","html_url":"https://github.com/Astrac/consierge/pull/22#discussion_r47573181","pull_request_url":"https://api.github.com/repos/Astrac/consierge/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/comments/47573181"},"html":{"href":"https://github.com/Astrac/consierge/pull/22#discussion_r47573181"},"pull_request":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Astrac/consierge/pulls/22","id":53634933,"html_url":"https://github.com/Astrac/consierge/pull/22","diff_url":"https://github.com/Astrac/consierge/pull/22.diff","patch_url":"https://github.com/Astrac/consierge/pull/22.patch","issue_url":"https://api.github.com/repos/Astrac/consierge/issues/22","number":22,"state":"open","locked":false,"title":"Tini set of improvements for consiege","user":{"login":"rumoku","id":3731901,"avatar_url":"https://avatars.githubusercontent.com/u/3731901?v=3","gravatar_id":"","url":"https://api.github.com/users/rumoku","html_url":"https://github.com/rumoku","followers_url":"https://api.github.com/users/rumoku/followers","following_url":"https://api.github.com/users/rumoku/following{/other_user}","gists_url":"https://api.github.com/users/rumoku/gists{/gist_id}","starred_url":"https://api.github.com/users/rumoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rumoku/subscriptions","organizations_url":"https://api.github.com/users/rumoku/orgs","repos_url":"https://api.github.com/users/rumoku/repos","events_url":"https://api.github.com/users/rumoku/events{/privacy}","received_events_url":"https://api.github.com/users/rumoku/received_events","type":"User","site_admin":false},"body":"Hi, meet you on hack day on saturday.\r\nHappy to be involved.","created_at":"2015-12-14T22:54:10Z","updated_at":"2015-12-14T23:04:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b258871d9fd65f95fbb55b8c7419d6b657e389aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Astrac/consierge/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Astrac/consierge/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Astrac/consierge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Astrac/consierge/issues/22/comments","statuses_url":"https://api.github.com/repos/Astrac/consierge/statuses/52746f2bcb8ca87ca619f97788732e40bb673966","head":{"label":"rumoku:master","ref":"master","sha":"52746f2bcb8ca87ca619f97788732e40bb673966","user":{"login":"rumoku","id":3731901,"avatar_url":"https://avatars.githubusercontent.com/u/3731901?v=3","gravatar_id":"","url":"https://api.github.com/users/rumoku","html_url":"https://github.com/rumoku","followers_url":"https://api.github.com/users/rumoku/followers","following_url":"https://api.github.com/users/rumoku/following{/other_user}","gists_url":"https://api.github.com/users/rumoku/gists{/gist_id}","starred_url":"https://api.github.com/users/rumoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rumoku/subscriptions","organizations_url":"https://api.github.com/users/rumoku/orgs","repos_url":"https://api.github.com/users/rumoku/repos","events_url":"https://api.github.com/users/rumoku/events{/privacy}","received_events_url":"https://api.github.com/users/rumoku/received_events","type":"User","site_admin":false},"repo":{"id":47924109,"name":"consierge","full_name":"rumoku/consierge","owner":{"login":"rumoku","id":3731901,"avatar_url":"https://avatars.githubusercontent.com/u/3731901?v=3","gravatar_id":"","url":"https://api.github.com/users/rumoku","html_url":"https://github.com/rumoku","followers_url":"https://api.github.com/users/rumoku/followers","following_url":"https://api.github.com/users/rumoku/following{/other_user}","gists_url":"https://api.github.com/users/rumoku/gists{/gist_id}","starred_url":"https://api.github.com/users/rumoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rumoku/subscriptions","organizations_url":"https://api.github.com/users/rumoku/orgs","repos_url":"https://api.github.com/users/rumoku/repos","events_url":"https://api.github.com/users/rumoku/events{/privacy}","received_events_url":"https://api.github.com/users/rumoku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rumoku/consierge","description":"","fork":true,"url":"https://api.github.com/repos/rumoku/consierge","forks_url":"https://api.github.com/repos/rumoku/consierge/forks","keys_url":"https://api.github.com/repos/rumoku/consierge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rumoku/consierge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rumoku/consierge/teams","hooks_url":"https://api.github.com/repos/rumoku/consierge/hooks","issue_events_url":"https://api.github.com/repos/rumoku/consierge/issues/events{/number}","events_url":"https://api.github.com/repos/rumoku/consierge/events","assignees_url":"https://api.github.com/repos/rumoku/consierge/assignees{/user}","branches_url":"https://api.github.com/repos/rumoku/consierge/branches{/branch}","tags_url":"https://api.github.com/repos/rumoku/consierge/tags","blobs_url":"https://api.github.com/repos/rumoku/consierge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rumoku/consierge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rumoku/consierge/git/refs{/sha}","trees_url":"https://api.github.com/repos/rumoku/consierge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rumoku/consierge/statuses/{sha}","languages_url":"https://api.github.com/repos/rumoku/consierge/languages","stargazers_url":"https://api.github.com/repos/rumoku/consierge/stargazers","contributors_url":"https://api.github.com/repos/rumoku/consierge/contributors","subscribers_url":"https://api.github.com/repos/rumoku/consierge/subscribers","subscription_url":"https://api.github.com/repos/rumoku/consierge/subscription","commits_url":"https://api.github.com/repos/rumoku/consierge/commits{/sha}","git_commits_url":"https://api.github.com/repos/rumoku/consierge/git/commits{/sha}","comments_url":"https://api.github.com/repos/rumoku/consierge/comments{/number}","issue_comment_url":"https://api.github.com/repos/rumoku/consierge/issues/comments{/number}","contents_url":"https://api.github.com/repos/rumoku/consierge/contents/{+path}","compare_url":"https://api.github.com/repos/rumoku/consierge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rumoku/consierge/merges","archive_url":"https://api.github.com/repos/rumoku/consierge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rumoku/consierge/downloads","issues_url":"https://api.github.com/repos/rumoku/consierge/issues{/number}","pulls_url":"https://api.github.com/repos/rumoku/consierge/pulls{/number}","milestones_url":"https://api.github.com/repos/rumoku/consierge/milestones{/number}","notifications_url":"https://api.github.com/repos/rumoku/consierge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rumoku/consierge/labels{/name}","releases_url":"https://api.github.com/repos/rumoku/consierge/releases{/id}","created_at":"2015-12-13T15:13:50Z","updated_at":"2015-12-13T15:43:39Z","pushed_at":"2015-12-14T22:51:56Z","git_url":"git://github.com/rumoku/consierge.git","ssh_url":"git@github.com:rumoku/consierge.git","clone_url":"https://github.com/rumoku/consierge.git","svn_url":"https://github.com/rumoku/consierge","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Astrac:master","ref":"master","sha":"68d18daffbc8c25ee157227de45ef8385148ae6b","user":{"login":"Astrac","id":766007,"avatar_url":"https://avatars.githubusercontent.com/u/766007?v=3","gravatar_id":"","url":"https://api.github.com/users/Astrac","html_url":"https://github.com/Astrac","followers_url":"https://api.github.com/users/Astrac/followers","following_url":"https://api.github.com/users/Astrac/following{/other_user}","gists_url":"https://api.github.com/users/Astrac/gists{/gist_id}","starred_url":"https://api.github.com/users/Astrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astrac/subscriptions","organizations_url":"https://api.github.com/users/Astrac/orgs","repos_url":"https://api.github.com/users/Astrac/repos","events_url":"https://api.github.com/users/Astrac/events{/privacy}","received_events_url":"https://api.github.com/users/Astrac/received_events","type":"User","site_admin":false},"repo":{"id":46172299,"name":"consierge","full_name":"Astrac/consierge","owner":{"login":"Astrac","id":766007,"avatar_url":"https://avatars.githubusercontent.com/u/766007?v=3","gravatar_id":"","url":"https://api.github.com/users/Astrac","html_url":"https://github.com/Astrac","followers_url":"https://api.github.com/users/Astrac/followers","following_url":"https://api.github.com/users/Astrac/following{/other_user}","gists_url":"https://api.github.com/users/Astrac/gists{/gist_id}","starred_url":"https://api.github.com/users/Astrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Astrac/subscriptions","organizations_url":"https://api.github.com/users/Astrac/orgs","repos_url":"https://api.github.com/users/Astrac/repos","events_url":"https://api.github.com/users/Astrac/events{/privacy}","received_events_url":"https://api.github.com/users/Astrac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Astrac/consierge","description":"","fork":false,"url":"https://api.github.com/repos/Astrac/consierge","forks_url":"https://api.github.com/repos/Astrac/consierge/forks","keys_url":"https://api.github.com/repos/Astrac/consierge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Astrac/consierge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Astrac/consierge/teams","hooks_url":"https://api.github.com/repos/Astrac/consierge/hooks","issue_events_url":"https://api.github.com/repos/Astrac/consierge/issues/events{/number}","events_url":"https://api.github.com/repos/Astrac/consierge/events","assignees_url":"https://api.github.com/repos/Astrac/consierge/assignees{/user}","branches_url":"https://api.github.com/repos/Astrac/consierge/branches{/branch}","tags_url":"https://api.github.com/repos/Astrac/consierge/tags","blobs_url":"https://api.github.com/repos/Astrac/consierge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Astrac/consierge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Astrac/consierge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Astrac/consierge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Astrac/consierge/statuses/{sha}","languages_url":"https://api.github.com/repos/Astrac/consierge/languages","stargazers_url":"https://api.github.com/repos/Astrac/consierge/stargazers","contributors_url":"https://api.github.com/repos/Astrac/consierge/contributors","subscribers_url":"https://api.github.com/repos/Astrac/consierge/subscribers","subscription_url":"https://api.github.com/repos/Astrac/consierge/subscription","commits_url":"https://api.github.com/repos/Astrac/consierge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Astrac/consierge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Astrac/consierge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Astrac/consierge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Astrac/consierge/contents/{+path}","compare_url":"https://api.github.com/repos/Astrac/consierge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Astrac/consierge/merges","archive_url":"https://api.github.com/repos/Astrac/consierge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Astrac/consierge/downloads","issues_url":"https://api.github.com/repos/Astrac/consierge/issues{/number}","pulls_url":"https://api.github.com/repos/Astrac/consierge/pulls{/number}","milestones_url":"https://api.github.com/repos/Astrac/consierge/milestones{/number}","notifications_url":"https://api.github.com/repos/Astrac/consierge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Astrac/consierge/labels{/name}","releases_url":"https://api.github.com/repos/Astrac/consierge/releases{/id}","created_at":"2015-11-14T11:37:02Z","updated_at":"2015-12-12T15:38:17Z","pushed_at":"2015-12-14T22:54:11Z","git_url":"git://github.com/Astrac/consierge.git","ssh_url":"git@github.com:Astrac/consierge.git","clone_url":"https://github.com/Astrac/consierge.git","svn_url":"https://github.com/Astrac/consierge","homepage":null,"size":30,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/22"},"html":{"href":"https://github.com/Astrac/consierge/pull/22"},"issue":{"href":"https://api.github.com/repos/Astrac/consierge/issues/22"},"comments":{"href":"https://api.github.com/repos/Astrac/consierge/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Astrac/consierge/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Astrac/consierge/statuses/52746f2bcb8ca87ca619f97788732e40bb673966"}}}}