{"action":"created","issue":{"url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/50","labels_url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/50/comments","events_url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/50/events","html_url":"https://github.com/winstonjs/winston-mongodb/pull/50","id":63750526,"number":50,"title":"Logging fix and database promise feature","user":{"login":"dankahle","id":5048609,"avatar_url":"https://avatars.githubusercontent.com/u/5048609?v=3","gravatar_id":"","url":"https://api.github.com/users/dankahle","html_url":"https://github.com/dankahle","followers_url":"https://api.github.com/users/dankahle/followers","following_url":"https://api.github.com/users/dankahle/following{/other_user}","gists_url":"https://api.github.com/users/dankahle/gists{/gist_id}","starred_url":"https://api.github.com/users/dankahle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankahle/subscriptions","organizations_url":"https://api.github.com/users/dankahle/orgs","repos_url":"https://api.github.com/users/dankahle/repos","events_url":"https://api.github.com/users/dankahle/events{/privacy}","received_events_url":"https://api.github.com/users/dankahle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-23T15:24:27Z","updated_at":"2015-03-23T17:37:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/winstonjs/winston-mongodb/pulls/50","html_url":"https://github.com/winstonjs/winston-mongodb/pull/50","diff_url":"https://github.com/winstonjs/winston-mongodb/pull/50.diff","patch_url":"https://github.com/winstonjs/winston-mongodb/pull/50.patch"},"body":"fixes: #48 \r\nSorry for putting these together, but fixes the bug and allows database promises and doesn't affect the way code runs now. I don't see any contrib.md on winston, and can't figure out how these winston-mongodb tests get wrapped into the rest. Something's missing as I don't even see asserts. "},"comment":{"url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/comments/85118203","html_url":"https://github.com/winstonjs/winston-mongodb/pull/50#issuecomment-85118203","issue_url":"https://api.github.com/repos/winstonjs/winston-mongodb/issues/50","id":85118203,"user":{"login":"dankahle","id":5048609,"avatar_url":"https://avatars.githubusercontent.com/u/5048609?v=3","gravatar_id":"","url":"https://api.github.com/users/dankahle","html_url":"https://github.com/dankahle","followers_url":"https://api.github.com/users/dankahle/followers","following_url":"https://api.github.com/users/dankahle/following{/other_user}","gists_url":"https://api.github.com/users/dankahle/gists{/gist_id}","starred_url":"https://api.github.com/users/dankahle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankahle/subscriptions","organizations_url":"https://api.github.com/users/dankahle/orgs","repos_url":"https://api.github.com/users/dankahle/repos","events_url":"https://api.github.com/users/dankahle/events{/privacy}","received_events_url":"https://api.github.com/users/dankahle/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T17:37:34Z","updated_at":"2015-03-23T17:37:34Z","body":"btw if someone's feeling generous down the git line... I can't figure this out:\r\n1) I put all my changes in one commit push and PR, so when the owner merges, there's one commit for the change. I assume that's how it's done.\r\n2) I get stuck making more changes, but... I still want that one commit, so I rebase/squash my commits locally, then try to push up the single commit. \r\n\r\nThe push is denied because the github wants me to merge first. If I force push, the PR gets destroyed and I have to enter a new one, losing the old comment stream. If I do the merge, I get the mess I have now which is the original commit, a new commit with the new and old changes, and an empty merge commit. \r\nHow exactly is this done? Surely I need to rebase/squash, and all looks fine locally, but how am I to get it up to github without it dropping the PR and forcing the merge. I'm lost on that. \r\n\r\n\r\n"}}