{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/comments/36894687","id":36894687,"diff_hunk":"@@ -2369,20 +2388,13 @@ public boolean isStrict() {\n     /** Whether this is ECMAScript 5 or higher. */\n     public boolean isEs5OrHigher() {\n       Preconditions.checkState(this != NO_TRANSPILE);\n-      return this != LanguageMode.ECMASCRIPT3;\n+      return this.toInteger() >= 5;\n     }\n \n     /** Whether this is ECMAScript 6 or higher. */\n     public boolean isEs6OrHigher() {\n       Preconditions.checkState(this != NO_TRANSPILE);\n-      switch (this) {\n-        case ECMASCRIPT6:\n-        case ECMASCRIPT6_STRICT:\n-        case ECMASCRIPT6_TYPED:\n-          return true;\n-        default:\n-          return false;\n-      }\n+      return this.toInteger() >= 6;","path":"src/com/google/javascript/jscomp/CompilerOptions.java","position":59,"original_position":59,"commit_id":"2126d1eaf30e7007acfba9d84c14f1ab5731c70a","original_commit_id":"2126d1eaf30e7007acfba9d84c14f1ab5731c70a","user":{"login":"dimvar","id":286890,"avatar_url":"https://avatars.githubusercontent.com/u/286890?v=3","gravatar_id":"","url":"https://api.github.com/users/dimvar","html_url":"https://github.com/dimvar","followers_url":"https://api.github.com/users/dimvar/followers","following_url":"https://api.github.com/users/dimvar/following{/other_user}","gists_url":"https://api.github.com/users/dimvar/gists{/gist_id}","starred_url":"https://api.github.com/users/dimvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimvar/subscriptions","organizations_url":"https://api.github.com/users/dimvar/orgs","repos_url":"https://api.github.com/users/dimvar/repos","events_url":"https://api.github.com/users/dimvar/events{/privacy}","received_events_url":"https://api.github.com/users/dimvar/received_events","type":"User","site_admin":false},"body":"    return this.toInteger() == 6;\r\n\r\nSince toInteger never returns > 6, I find the >= a bit confusing (even though it's more future-proof).","created_at":"2015-08-12T18:18:37Z","updated_at":"2015-08-12T18:18:37Z","html_url":"https://github.com/google/closure-compiler/pull/1047#discussion_r36894687","pull_request_url":"https://api.github.com/repos/google/closure-compiler/pulls/1047","_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments/36894687"},"html":{"href":"https://github.com/google/closure-compiler/pull/1047#discussion_r36894687"},"pull_request":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1047"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1047","id":40616297,"html_url":"https://github.com/google/closure-compiler/pull/1047","diff_url":"https://github.com/google/closure-compiler/pull/1047.diff","patch_url":"https://github.com/google/closure-compiler/pull/1047.patch","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1047","number":1047,"state":"open","locked":false,"title":"Initial support for the --env flag","user":{"login":"ChadKillingsworth","id":1247639,"avatar_url":"https://avatars.githubusercontent.com/u/1247639?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadKillingsworth","html_url":"https://github.com/ChadKillingsworth","followers_url":"https://api.github.com/users/ChadKillingsworth/followers","following_url":"https://api.github.com/users/ChadKillingsworth/following{/other_user}","gists_url":"https://api.github.com/users/ChadKillingsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadKillingsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadKillingsworth/subscriptions","organizations_url":"https://api.github.com/users/ChadKillingsworth/orgs","repos_url":"https://api.github.com/users/ChadKillingsworth/repos","events_url":"https://api.github.com/users/ChadKillingsworth/events{/privacy}","received_events_url":"https://api.github.com/users/ChadKillingsworth/received_events","type":"User","site_admin":false},"body":"I expect this PR to have a rather large impact. Definitely should block this until after the next release.\r\n\r\n* Builtin externs are now arranged by environment specific folders\r\n* Adds a NODEJS environment\r\n* Replaces the --use_only_custom_externs flag with the --env=CUSTOM argument\r\n* esX.js externs are now included for every environment - including CUSTOM\r\n* Makes it easy to add future environments\r\n\r\n@nicks Would you like to take a look at the NODEJS part? I think the externs may need tweaking.\r\n\r\nFixes #966","created_at":"2015-07-22T21:54:27Z","updated_at":"2015-08-12T18:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac2869b38ae367443cebf98bbbf78b66e4011666","assignee":{"login":"dimvar","id":286890,"avatar_url":"https://avatars.githubusercontent.com/u/286890?v=3","gravatar_id":"","url":"https://api.github.com/users/dimvar","html_url":"https://github.com/dimvar","followers_url":"https://api.github.com/users/dimvar/followers","following_url":"https://api.github.com/users/dimvar/following{/other_user}","gists_url":"https://api.github.com/users/dimvar/gists{/gist_id}","starred_url":"https://api.github.com/users/dimvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimvar/subscriptions","organizations_url":"https://api.github.com/users/dimvar/orgs","repos_url":"https://api.github.com/users/dimvar/repos","events_url":"https://api.github.com/users/dimvar/events{/privacy}","received_events_url":"https://api.github.com/users/dimvar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-compiler/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/google/closure-compiler/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1047/comments","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/2126d1eaf30e7007acfba9d84c14f1ab5731c70a","head":{"label":"ChadKillingsworth:env-flag","ref":"env-flag","sha":"2126d1eaf30e7007acfba9d84c14f1ab5731c70a","user":{"login":"ChadKillingsworth","id":1247639,"avatar_url":"https://avatars.githubusercontent.com/u/1247639?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadKillingsworth","html_url":"https://github.com/ChadKillingsworth","followers_url":"https://api.github.com/users/ChadKillingsworth/followers","following_url":"https://api.github.com/users/ChadKillingsworth/following{/other_user}","gists_url":"https://api.github.com/users/ChadKillingsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadKillingsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadKillingsworth/subscriptions","organizations_url":"https://api.github.com/users/ChadKillingsworth/orgs","repos_url":"https://api.github.com/users/ChadKillingsworth/repos","events_url":"https://api.github.com/users/ChadKillingsworth/events{/privacy}","received_events_url":"https://api.github.com/users/ChadKillingsworth/received_events","type":"User","site_admin":false},"repo":{"id":19463857,"name":"closure-compiler","full_name":"ChadKillingsworth/closure-compiler","owner":{"login":"ChadKillingsworth","id":1247639,"avatar_url":"https://avatars.githubusercontent.com/u/1247639?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadKillingsworth","html_url":"https://github.com/ChadKillingsworth","followers_url":"https://api.github.com/users/ChadKillingsworth/followers","following_url":"https://api.github.com/users/ChadKillingsworth/following{/other_user}","gists_url":"https://api.github.com/users/ChadKillingsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadKillingsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadKillingsworth/subscriptions","organizations_url":"https://api.github.com/users/ChadKillingsworth/orgs","repos_url":"https://api.github.com/users/ChadKillingsworth/repos","events_url":"https://api.github.com/users/ChadKillingsworth/events{/privacy}","received_events_url":"https://api.github.com/users/ChadKillingsworth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChadKillingsworth/closure-compiler","description":"A JavaScript checker and optimizer.","fork":true,"url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler","forks_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/forks","keys_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/teams","hooks_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/events","assignees_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/tags","blobs_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/subscription","commits_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/merges","archive_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/downloads","issues_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/ChadKillingsworth/closure-compiler/releases{/id}","created_at":"2014-05-05T17:09:47Z","updated_at":"2015-05-04T13:54:18Z","pushed_at":"2015-08-11T21:04:41Z","git_url":"git://github.com/ChadKillingsworth/closure-compiler.git","ssh_url":"git@github.com:ChadKillingsworth/closure-compiler.git","clone_url":"https://github.com/ChadKillingsworth/closure-compiler.git","svn_url":"https://github.com/ChadKillingsworth/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":98893,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"22f1fda2052030914eed890d6aa715c9dc40b36a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845024,"name":"closure-compiler","full_name":"google/closure-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-compiler","description":"A JavaScript checker and optimizer.","fork":false,"url":"https://api.github.com/repos/google/closure-compiler","forks_url":"https://api.github.com/repos/google/closure-compiler/forks","keys_url":"https://api.github.com/repos/google/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-compiler/teams","hooks_url":"https://api.github.com/repos/google/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-compiler/events","assignees_url":"https://api.github.com/repos/google/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-compiler/tags","blobs_url":"https://api.github.com/repos/google/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/google/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/closure-compiler/subscription","commits_url":"https://api.github.com/repos/google/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-compiler/merges","archive_url":"https://api.github.com/repos/google/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-compiler/downloads","issues_url":"https://api.github.com/repos/google/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-compiler/releases{/id}","created_at":"2014-04-16T15:30:36Z","updated_at":"2015-08-12T13:02:54Z","pushed_at":"2015-08-12T17:40:52Z","git_url":"git://github.com/google/closure-compiler.git","ssh_url":"git@github.com:google/closure-compiler.git","clone_url":"https://github.com/google/closure-compiler.git","svn_url":"https://github.com/google/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":109274,"stargazers_count":1550,"watchers_count":1550,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":389,"forks":347,"open_issues":389,"watchers":1550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1047"},"html":{"href":"https://github.com/google/closure-compiler/pull/1047"},"issue":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1047"},"comments":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-compiler/statuses/2126d1eaf30e7007acfba9d84c14f1ab5731c70a"}}}}