{"action":"created","issue":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/140","labels_url":"https://api.github.com/repos/cloudflare/cfssl/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/140/comments","events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/140/events","html_url":"https://github.com/cloudflare/cfssl/pull/140","id":64180056,"number":140,"title":"Wyatt/pkcs7","user":{"login":"ZenGround0","id":5515260,"avatar_url":"https://avatars.githubusercontent.com/u/5515260?v=3","gravatar_id":"","url":"https://api.github.com/users/ZenGround0","html_url":"https://github.com/ZenGround0","followers_url":"https://api.github.com/users/ZenGround0/followers","following_url":"https://api.github.com/users/ZenGround0/following{/other_user}","gists_url":"https://api.github.com/users/ZenGround0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZenGround0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZenGround0/subscriptions","organizations_url":"https://api.github.com/users/ZenGround0/orgs","repos_url":"https://api.github.com/users/ZenGround0/repos","events_url":"https://api.github.com/users/ZenGround0/events{/privacy}","received_events_url":"https://api.github.com/users/ZenGround0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-25T05:28:05Z","updated_at":"2015-04-06T15:37:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/140","html_url":"https://github.com/cloudflare/cfssl/pull/140","diff_url":"https://github.com/cloudflare/cfssl/pull/140.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/140.patch"},"body":"Add support for PKCS #7 \r\n\r\nThis pull request addresses issue 97, by introducing a PKCS #7 data type and Parser into the CFSSL crypto folder.  As PKCS #7 is composed of one of possibly many types, this pull request only implements the minimum subset of the data type to allow for PEM formatted PKCS #7 packaged certificates to be bundled alongside x509 certificates, see the header of pkcs7.go for more information.  The helper function ParseOneCertificateFromPEM was refactored into ParseOneObjectFromPEM, in order to support the parsing of certificate lists from individual PKCS#7 structures.  Tests were added to ParseCertificatePEM and ParseCertificatesPEM making use of newly added PKCS#7 certificates created from the certificates within the helpers test_data folder.\r\n\r\nAdditionally the PKCS #7 Parser grabs and stores any CRLS in the structure.  Possible simple extensions include adding support for PKCS #6 extended certificates within the cert list, and parsing PKCS #7 contentInfo types \"data\" and \"signedAndEnvelopedData\".\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments/90112925","html_url":"https://github.com/cloudflare/cfssl/pull/140#issuecomment-90112925","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/140","id":90112925,"user":{"login":"ZenGround0","id":5515260,"avatar_url":"https://avatars.githubusercontent.com/u/5515260?v=3","gravatar_id":"","url":"https://api.github.com/users/ZenGround0","html_url":"https://github.com/ZenGround0","followers_url":"https://api.github.com/users/ZenGround0/followers","following_url":"https://api.github.com/users/ZenGround0/following{/other_user}","gists_url":"https://api.github.com/users/ZenGround0/gists{/gist_id}","starred_url":"https://api.github.com/users/ZenGround0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZenGround0/subscriptions","organizations_url":"https://api.github.com/users/ZenGround0/orgs","repos_url":"https://api.github.com/users/ZenGround0/repos","events_url":"https://api.github.com/users/ZenGround0/events{/privacy}","received_events_url":"https://api.github.com/users/ZenGround0/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T15:37:21Z","updated_at":"2015-04-06T15:37:21Z","body":"Looking at Travis's results, everything should now be ready."}}