{"action":"created","comment":{"url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/comments/29924848","id":29924848,"diff_hunk":"@@ -0,0 +1,63 @@\n+package orwell.proxy;\n+\n+import orwell.messages.Controller.Input;\n+\n+public interface IRobot {\n+\n+    String getTeamName();\n+\n+    EnumRegistrationState getRegistrationState();\n+\n+    EnumConnectionState getConnectionState();\n+\n+    String getRoutingID();\n+\n+    void setRoutingID(String routingID);\n+\n+    String getImage();\n+\n+    /*\n+     * Image is a picture of the robot itself to be sent to the\n+     * server before the start of the game\n+     */\n+    void setImage(String image);\n+\n+    /*\n+     * This will clear the current ServerRobotState\n+     */\n+    byte[] getAndClearZmqServerRobotStateBytes();\n+\n+    void setRegistered(byte[] registeredMessage);\n+\n+    byte[] getZmqRegister();","path":"proxy-robots-module/src/main/java/orwell/proxy/IRobot.java","position":32,"original_position":32,"commit_id":"5bb8a127834afd7123b45c36f08be139784916fc","original_commit_id":"5bb8a127834afd7123b45c36f08be139784916fc","user":{"login":"dchilot","id":2634447,"avatar_url":"https://avatars.githubusercontent.com/u/2634447?v=3","gravatar_id":"","url":"https://api.github.com/users/dchilot","html_url":"https://github.com/dchilot","followers_url":"https://api.github.com/users/dchilot/followers","following_url":"https://api.github.com/users/dchilot/following{/other_user}","gists_url":"https://api.github.com/users/dchilot/gists{/gist_id}","starred_url":"https://api.github.com/users/dchilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchilot/subscriptions","organizations_url":"https://api.github.com/users/dchilot/orgs","repos_url":"https://api.github.com/users/dchilot/repos","events_url":"https://api.github.com/users/dchilot/events{/privacy}","received_events_url":"https://api.github.com/users/dchilot/received_events","type":"User","site_admin":false},"body":"The naming convention might not be very consistent with the following method (getRegisterBytes).\r\nIt might be better to state in the method that it is about a message. It is difficult to find good names ; today I would be inclined to suggest getMessageRegisterZmq / getMessageRegisterBytes.","created_at":"2015-05-08T08:45:45Z","updated_at":"2015-05-08T08:45:45Z","html_url":"https://github.com/orwell-int/proxy-robots/pull/31#discussion_r29924848","pull_request_url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/comments/29924848"},"html":{"href":"https://github.com/orwell-int/proxy-robots/pull/31#discussion_r29924848"},"pull_request":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31","id":34796636,"html_url":"https://github.com/orwell-int/proxy-robots/pull/31","diff_url":"https://github.com/orwell-int/proxy-robots/pull/31.diff","patch_url":"https://github.com/orwell-int/proxy-robots/pull/31.patch","issue_url":"https://api.github.com/repos/orwell-int/proxy-robots/issues/31","number":31,"state":"open","locked":false,"title":"ServerRobotState, Config readable out of jar, decoupling of classes, more tests","user":{"login":"miludmann","id":4282356,"avatar_url":"https://avatars.githubusercontent.com/u/4282356?v=3","gravatar_id":"","url":"https://api.github.com/users/miludmann","html_url":"https://github.com/miludmann","followers_url":"https://api.github.com/users/miludmann/followers","following_url":"https://api.github.com/users/miludmann/following{/other_user}","gists_url":"https://api.github.com/users/miludmann/gists{/gist_id}","starred_url":"https://api.github.com/users/miludmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miludmann/subscriptions","organizations_url":"https://api.github.com/users/miludmann/orgs","repos_url":"https://api.github.com/users/miludmann/repos","events_url":"https://api.github.com/users/miludmann/events{/privacy}","received_events_url":"https://api.github.com/users/miludmann/received_events","type":"User","site_admin":false},"body":"Implement features: \r\n-sending of ServerRobotState once a Tank has an updated status\r\n-configuration.xml file can be provided as a parameter when launching the jar\r\n\r\nHeavy refactoring since last PR with lots of inter-classes decoupling.\r\nImprove test coverage.\r\nMisc. bugfixes","created_at":"2015-05-06T08:24:23Z","updated_at":"2015-05-08T08:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea1f08d375ab124c9ab4f93717017e7c9ff9c7d6","assignee":{"login":"dchilot","id":2634447,"avatar_url":"https://avatars.githubusercontent.com/u/2634447?v=3","gravatar_id":"","url":"https://api.github.com/users/dchilot","html_url":"https://github.com/dchilot","followers_url":"https://api.github.com/users/dchilot/followers","following_url":"https://api.github.com/users/dchilot/following{/other_user}","gists_url":"https://api.github.com/users/dchilot/gists{/gist_id}","starred_url":"https://api.github.com/users/dchilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchilot/subscriptions","organizations_url":"https://api.github.com/users/dchilot/orgs","repos_url":"https://api.github.com/users/dchilot/repos","events_url":"https://api.github.com/users/dchilot/events{/privacy}","received_events_url":"https://api.github.com/users/dchilot/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/orwell-int/proxy-robots/milestones/1","html_url":"https://github.com/orwell-int/proxy-robots/milestones/Implement%20a%20first%20game%20mode%20for%20a%20playable%20prototype","labels_url":"https://api.github.com/repos/orwell-int/proxy-robots/milestones/1/labels","id":711450,"number":1,"title":"Implement a first game mode for a playable prototype","description":"","creator":{"login":"miludmann","id":4282356,"avatar_url":"https://avatars.githubusercontent.com/u/4282356?v=3","gravatar_id":"","url":"https://api.github.com/users/miludmann","html_url":"https://github.com/miludmann","followers_url":"https://api.github.com/users/miludmann/followers","following_url":"https://api.github.com/users/miludmann/following{/other_user}","gists_url":"https://api.github.com/users/miludmann/gists{/gist_id}","starred_url":"https://api.github.com/users/miludmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miludmann/subscriptions","organizations_url":"https://api.github.com/users/miludmann/orgs","repos_url":"https://api.github.com/users/miludmann/repos","events_url":"https://api.github.com/users/miludmann/events{/privacy}","received_events_url":"https://api.github.com/users/miludmann/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":5,"state":"open","created_at":"2014-07-06T13:54:38Z","updated_at":"2015-05-06T08:24:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31/commits","review_comments_url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31/comments","review_comment_url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orwell-int/proxy-robots/issues/31/comments","statuses_url":"https://api.github.com/repos/orwell-int/proxy-robots/statuses/5bb8a127834afd7123b45c36f08be139784916fc","head":{"label":"miludmann:master","ref":"master","sha":"5bb8a127834afd7123b45c36f08be139784916fc","user":{"login":"miludmann","id":4282356,"avatar_url":"https://avatars.githubusercontent.com/u/4282356?v=3","gravatar_id":"","url":"https://api.github.com/users/miludmann","html_url":"https://github.com/miludmann","followers_url":"https://api.github.com/users/miludmann/followers","following_url":"https://api.github.com/users/miludmann/following{/other_user}","gists_url":"https://api.github.com/users/miludmann/gists{/gist_id}","starred_url":"https://api.github.com/users/miludmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miludmann/subscriptions","organizations_url":"https://api.github.com/users/miludmann/orgs","repos_url":"https://api.github.com/users/miludmann/repos","events_url":"https://api.github.com/users/miludmann/events{/privacy}","received_events_url":"https://api.github.com/users/miludmann/received_events","type":"User","site_admin":false},"repo":{"id":9980913,"name":"proxy-robots","full_name":"miludmann/proxy-robots","owner":{"login":"miludmann","id":4282356,"avatar_url":"https://avatars.githubusercontent.com/u/4282356?v=3","gravatar_id":"","url":"https://api.github.com/users/miludmann","html_url":"https://github.com/miludmann","followers_url":"https://api.github.com/users/miludmann/followers","following_url":"https://api.github.com/users/miludmann/following{/other_user}","gists_url":"https://api.github.com/users/miludmann/gists{/gist_id}","starred_url":"https://api.github.com/users/miludmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miludmann/subscriptions","organizations_url":"https://api.github.com/users/miludmann/orgs","repos_url":"https://api.github.com/users/miludmann/repos","events_url":"https://api.github.com/users/miludmann/events{/privacy}","received_events_url":"https://api.github.com/users/miludmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miludmann/proxy-robots","description":"Handles the communication between the server and the (real) robots.","fork":true,"url":"https://api.github.com/repos/miludmann/proxy-robots","forks_url":"https://api.github.com/repos/miludmann/proxy-robots/forks","keys_url":"https://api.github.com/repos/miludmann/proxy-robots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miludmann/proxy-robots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miludmann/proxy-robots/teams","hooks_url":"https://api.github.com/repos/miludmann/proxy-robots/hooks","issue_events_url":"https://api.github.com/repos/miludmann/proxy-robots/issues/events{/number}","events_url":"https://api.github.com/repos/miludmann/proxy-robots/events","assignees_url":"https://api.github.com/repos/miludmann/proxy-robots/assignees{/user}","branches_url":"https://api.github.com/repos/miludmann/proxy-robots/branches{/branch}","tags_url":"https://api.github.com/repos/miludmann/proxy-robots/tags","blobs_url":"https://api.github.com/repos/miludmann/proxy-robots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miludmann/proxy-robots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miludmann/proxy-robots/git/refs{/sha}","trees_url":"https://api.github.com/repos/miludmann/proxy-robots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miludmann/proxy-robots/statuses/{sha}","languages_url":"https://api.github.com/repos/miludmann/proxy-robots/languages","stargazers_url":"https://api.github.com/repos/miludmann/proxy-robots/stargazers","contributors_url":"https://api.github.com/repos/miludmann/proxy-robots/contributors","subscribers_url":"https://api.github.com/repos/miludmann/proxy-robots/subscribers","subscription_url":"https://api.github.com/repos/miludmann/proxy-robots/subscription","commits_url":"https://api.github.com/repos/miludmann/proxy-robots/commits{/sha}","git_commits_url":"https://api.github.com/repos/miludmann/proxy-robots/git/commits{/sha}","comments_url":"https://api.github.com/repos/miludmann/proxy-robots/comments{/number}","issue_comment_url":"https://api.github.com/repos/miludmann/proxy-robots/issues/comments{/number}","contents_url":"https://api.github.com/repos/miludmann/proxy-robots/contents/{+path}","compare_url":"https://api.github.com/repos/miludmann/proxy-robots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miludmann/proxy-robots/merges","archive_url":"https://api.github.com/repos/miludmann/proxy-robots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miludmann/proxy-robots/downloads","issues_url":"https://api.github.com/repos/miludmann/proxy-robots/issues{/number}","pulls_url":"https://api.github.com/repos/miludmann/proxy-robots/pulls{/number}","milestones_url":"https://api.github.com/repos/miludmann/proxy-robots/milestones{/number}","notifications_url":"https://api.github.com/repos/miludmann/proxy-robots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miludmann/proxy-robots/labels{/name}","releases_url":"https://api.github.com/repos/miludmann/proxy-robots/releases{/id}","created_at":"2013-05-10T12:23:48Z","updated_at":"2015-05-05T14:51:05Z","pushed_at":"2015-05-07T14:53:26Z","git_url":"git://github.com/miludmann/proxy-robots.git","ssh_url":"git@github.com:miludmann/proxy-robots.git","clone_url":"https://github.com/miludmann/proxy-robots.git","svn_url":"https://github.com/miludmann/proxy-robots","homepage":null,"size":1010,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"orwell-int:master","ref":"master","sha":"7fa6758df538299d865849f747a90a401423063c","user":{"login":"orwell-int","id":4205279,"avatar_url":"https://avatars.githubusercontent.com/u/4205279?v=3","gravatar_id":"","url":"https://api.github.com/users/orwell-int","html_url":"https://github.com/orwell-int","followers_url":"https://api.github.com/users/orwell-int/followers","following_url":"https://api.github.com/users/orwell-int/following{/other_user}","gists_url":"https://api.github.com/users/orwell-int/gists{/gist_id}","starred_url":"https://api.github.com/users/orwell-int/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orwell-int/subscriptions","organizations_url":"https://api.github.com/users/orwell-int/orgs","repos_url":"https://api.github.com/users/orwell-int/repos","events_url":"https://api.github.com/users/orwell-int/events{/privacy}","received_events_url":"https://api.github.com/users/orwell-int/received_events","type":"Organization","site_admin":false},"repo":{"id":9554645,"name":"proxy-robots","full_name":"orwell-int/proxy-robots","owner":{"login":"orwell-int","id":4205279,"avatar_url":"https://avatars.githubusercontent.com/u/4205279?v=3","gravatar_id":"","url":"https://api.github.com/users/orwell-int","html_url":"https://github.com/orwell-int","followers_url":"https://api.github.com/users/orwell-int/followers","following_url":"https://api.github.com/users/orwell-int/following{/other_user}","gists_url":"https://api.github.com/users/orwell-int/gists{/gist_id}","starred_url":"https://api.github.com/users/orwell-int/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orwell-int/subscriptions","organizations_url":"https://api.github.com/users/orwell-int/orgs","repos_url":"https://api.github.com/users/orwell-int/repos","events_url":"https://api.github.com/users/orwell-int/events{/privacy}","received_events_url":"https://api.github.com/users/orwell-int/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orwell-int/proxy-robots","description":"Handles the communication between the server and the (real) robots.","fork":false,"url":"https://api.github.com/repos/orwell-int/proxy-robots","forks_url":"https://api.github.com/repos/orwell-int/proxy-robots/forks","keys_url":"https://api.github.com/repos/orwell-int/proxy-robots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orwell-int/proxy-robots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orwell-int/proxy-robots/teams","hooks_url":"https://api.github.com/repos/orwell-int/proxy-robots/hooks","issue_events_url":"https://api.github.com/repos/orwell-int/proxy-robots/issues/events{/number}","events_url":"https://api.github.com/repos/orwell-int/proxy-robots/events","assignees_url":"https://api.github.com/repos/orwell-int/proxy-robots/assignees{/user}","branches_url":"https://api.github.com/repos/orwell-int/proxy-robots/branches{/branch}","tags_url":"https://api.github.com/repos/orwell-int/proxy-robots/tags","blobs_url":"https://api.github.com/repos/orwell-int/proxy-robots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orwell-int/proxy-robots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orwell-int/proxy-robots/git/refs{/sha}","trees_url":"https://api.github.com/repos/orwell-int/proxy-robots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orwell-int/proxy-robots/statuses/{sha}","languages_url":"https://api.github.com/repos/orwell-int/proxy-robots/languages","stargazers_url":"https://api.github.com/repos/orwell-int/proxy-robots/stargazers","contributors_url":"https://api.github.com/repos/orwell-int/proxy-robots/contributors","subscribers_url":"https://api.github.com/repos/orwell-int/proxy-robots/subscribers","subscription_url":"https://api.github.com/repos/orwell-int/proxy-robots/subscription","commits_url":"https://api.github.com/repos/orwell-int/proxy-robots/commits{/sha}","git_commits_url":"https://api.github.com/repos/orwell-int/proxy-robots/git/commits{/sha}","comments_url":"https://api.github.com/repos/orwell-int/proxy-robots/comments{/number}","issue_comment_url":"https://api.github.com/repos/orwell-int/proxy-robots/issues/comments{/number}","contents_url":"https://api.github.com/repos/orwell-int/proxy-robots/contents/{+path}","compare_url":"https://api.github.com/repos/orwell-int/proxy-robots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orwell-int/proxy-robots/merges","archive_url":"https://api.github.com/repos/orwell-int/proxy-robots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orwell-int/proxy-robots/downloads","issues_url":"https://api.github.com/repos/orwell-int/proxy-robots/issues{/number}","pulls_url":"https://api.github.com/repos/orwell-int/proxy-robots/pulls{/number}","milestones_url":"https://api.github.com/repos/orwell-int/proxy-robots/milestones{/number}","notifications_url":"https://api.github.com/repos/orwell-int/proxy-robots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orwell-int/proxy-robots/labels{/name}","releases_url":"https://api.github.com/repos/orwell-int/proxy-robots/releases{/id}","created_at":"2013-04-19T21:08:47Z","updated_at":"2015-05-06T09:04:54Z","pushed_at":"2015-05-06T09:04:54Z","git_url":"git://github.com/orwell-int/proxy-robots.git","ssh_url":"git@github.com:orwell-int/proxy-robots.git","clone_url":"https://github.com/orwell-int/proxy-robots.git","svn_url":"https://github.com/orwell-int/proxy-robots","homepage":null,"size":696,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31"},"html":{"href":"https://github.com/orwell-int/proxy-robots/pull/31"},"issue":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/issues/31"},"comments":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/orwell-int/proxy-robots/statuses/5bb8a127834afd7123b45c36f08be139784916fc"}}}}