{"action":"created","comment":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/comments/30515965","id":30515965,"diff_hunk":"@@ -912,9 +912,10 @@ hash_consume(khmer_KCountingHash_Object * me, PyObject * args)\n                         \"string length must >= the hashtable k-mer size\");\n         return NULL;\n     }\n-\n+    std::string read(long_str);\n+    bool is_valid;\n     unsigned int n_consumed;\n-    n_consumed = counting->consume_string(long_str);\n+    n_consumed = counting->check_and_process_read(read, is_valid);","path":"khmer/_khmermodule.cc","position":9,"original_position":9,"commit_id":"b95a7c7c115bfb2857ba80f28bdeab3e3deb1892","original_commit_id":"71ba0b6c5746d715a4a7501b8625d6e816d68cda","user":{"login":"drtamermansour","id":6537740,"avatar_url":"https://avatars.githubusercontent.com/u/6537740?v=3","gravatar_id":"","url":"https://api.github.com/users/drtamermansour","html_url":"https://github.com/drtamermansour","followers_url":"https://api.github.com/users/drtamermansour/followers","following_url":"https://api.github.com/users/drtamermansour/following{/other_user}","gists_url":"https://api.github.com/users/drtamermansour/gists{/gist_id}","starred_url":"https://api.github.com/users/drtamermansour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drtamermansour/subscriptions","organizations_url":"https://api.github.com/users/drtamermansour/orgs","repos_url":"https://api.github.com/users/drtamermansour/repos","events_url":"https://api.github.com/users/drtamermansour/events{/privacy}","received_events_url":"https://api.github.com/users/drtamermansour/received_events","type":"User","site_admin":false},"body":"It should not break anything. I did not fix consume_string(). I used another function instead which do the check then call consume_string. I am testing the new functionally by trying data file with 'N's characters.","created_at":"2015-05-18T15:08:32Z","updated_at":"2015-05-18T15:08:32Z","html_url":"https://github.com/dib-lab/khmer/pull/1001#discussion_r30515965","pull_request_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1001","_links":{"self":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/comments/30515965"},"html":{"href":"https://github.com/dib-lab/khmer/pull/1001#discussion_r30515965"},"pull_request":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1001"}}},"pull_request":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/1001","id":35507087,"html_url":"https://github.com/dib-lab/khmer/pull/1001","diff_url":"https://github.com/dib-lab/khmer/pull/1001.diff","patch_url":"https://github.com/dib-lab/khmer/pull/1001.patch","issue_url":"https://api.github.com/repos/dib-lab/khmer/issues/1001","number":1001,"state":"open","locked":false,"title":"Diginorm skip kmers","user":{"login":"drtamermansour","id":6537740,"avatar_url":"https://avatars.githubusercontent.com/u/6537740?v=3","gravatar_id":"","url":"https://api.github.com/users/drtamermansour","html_url":"https://github.com/drtamermansour","followers_url":"https://api.github.com/users/drtamermansour/followers","following_url":"https://api.github.com/users/drtamermansour/following{/other_user}","gists_url":"https://api.github.com/users/drtamermansour/gists{/gist_id}","starred_url":"https://api.github.com/users/drtamermansour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drtamermansour/subscriptions","organizations_url":"https://api.github.com/users/drtamermansour/orgs","repos_url":"https://api.github.com/users/drtamermansour/repos","events_url":"https://api.github.com/users/drtamermansour/events{/privacy}","received_events_url":"https://api.github.com/users/drtamermansour/received_events","type":"User","site_admin":false},"body":"This should fix #1000 solving 2 main problems:\r\n1) fix normalize-by-median.py to count kmers from both PE reads when either one of them is below the coverage cutoff.\r\n2) Change the function hash_consume in khmer/_khmermodule.cc to checks for non-ACGT characters","created_at":"2015-05-15T12:00:25Z","updated_at":"2015-05-18T15:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db2e308cec46e242aadedafbfe1d900d9f57930e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/dib-lab/khmer/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/dib-lab/khmer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dib-lab/khmer/issues/1001/comments","statuses_url":"https://api.github.com/repos/dib-lab/khmer/statuses/b95a7c7c115bfb2857ba80f28bdeab3e3deb1892","head":{"label":"drtamermansour:diginormSkipKmers","ref":"diginormSkipKmers","sha":"b95a7c7c115bfb2857ba80f28bdeab3e3deb1892","user":{"login":"drtamermansour","id":6537740,"avatar_url":"https://avatars.githubusercontent.com/u/6537740?v=3","gravatar_id":"","url":"https://api.github.com/users/drtamermansour","html_url":"https://github.com/drtamermansour","followers_url":"https://api.github.com/users/drtamermansour/followers","following_url":"https://api.github.com/users/drtamermansour/following{/other_user}","gists_url":"https://api.github.com/users/drtamermansour/gists{/gist_id}","starred_url":"https://api.github.com/users/drtamermansour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drtamermansour/subscriptions","organizations_url":"https://api.github.com/users/drtamermansour/orgs","repos_url":"https://api.github.com/users/drtamermansour/repos","events_url":"https://api.github.com/users/drtamermansour/events{/privacy}","received_events_url":"https://api.github.com/users/drtamermansour/received_events","type":"User","site_admin":false},"repo":{"id":28987797,"name":"khmer","full_name":"drtamermansour/khmer","owner":{"login":"drtamermansour","id":6537740,"avatar_url":"https://avatars.githubusercontent.com/u/6537740?v=3","gravatar_id":"","url":"https://api.github.com/users/drtamermansour","html_url":"https://github.com/drtamermansour","followers_url":"https://api.github.com/users/drtamermansour/followers","following_url":"https://api.github.com/users/drtamermansour/following{/other_user}","gists_url":"https://api.github.com/users/drtamermansour/gists{/gist_id}","starred_url":"https://api.github.com/users/drtamermansour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drtamermansour/subscriptions","organizations_url":"https://api.github.com/users/drtamermansour/orgs","repos_url":"https://api.github.com/users/drtamermansour/repos","events_url":"https://api.github.com/users/drtamermansour/events{/privacy}","received_events_url":"https://api.github.com/users/drtamermansour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drtamermansour/khmer","description":"In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more","fork":true,"url":"https://api.github.com/repos/drtamermansour/khmer","forks_url":"https://api.github.com/repos/drtamermansour/khmer/forks","keys_url":"https://api.github.com/repos/drtamermansour/khmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drtamermansour/khmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drtamermansour/khmer/teams","hooks_url":"https://api.github.com/repos/drtamermansour/khmer/hooks","issue_events_url":"https://api.github.com/repos/drtamermansour/khmer/issues/events{/number}","events_url":"https://api.github.com/repos/drtamermansour/khmer/events","assignees_url":"https://api.github.com/repos/drtamermansour/khmer/assignees{/user}","branches_url":"https://api.github.com/repos/drtamermansour/khmer/branches{/branch}","tags_url":"https://api.github.com/repos/drtamermansour/khmer/tags","blobs_url":"https://api.github.com/repos/drtamermansour/khmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drtamermansour/khmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drtamermansour/khmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/drtamermansour/khmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drtamermansour/khmer/statuses/{sha}","languages_url":"https://api.github.com/repos/drtamermansour/khmer/languages","stargazers_url":"https://api.github.com/repos/drtamermansour/khmer/stargazers","contributors_url":"https://api.github.com/repos/drtamermansour/khmer/contributors","subscribers_url":"https://api.github.com/repos/drtamermansour/khmer/subscribers","subscription_url":"https://api.github.com/repos/drtamermansour/khmer/subscription","commits_url":"https://api.github.com/repos/drtamermansour/khmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/drtamermansour/khmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/drtamermansour/khmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/drtamermansour/khmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/drtamermansour/khmer/contents/{+path}","compare_url":"https://api.github.com/repos/drtamermansour/khmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drtamermansour/khmer/merges","archive_url":"https://api.github.com/repos/drtamermansour/khmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drtamermansour/khmer/downloads","issues_url":"https://api.github.com/repos/drtamermansour/khmer/issues{/number}","pulls_url":"https://api.github.com/repos/drtamermansour/khmer/pulls{/number}","milestones_url":"https://api.github.com/repos/drtamermansour/khmer/milestones{/number}","notifications_url":"https://api.github.com/repos/drtamermansour/khmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drtamermansour/khmer/labels{/name}","releases_url":"https://api.github.com/repos/drtamermansour/khmer/releases{/id}","created_at":"2015-01-08T21:50:07Z","updated_at":"2015-04-23T02:25:32Z","pushed_at":"2015-05-18T14:57:29Z","git_url":"git://github.com/drtamermansour/khmer.git","ssh_url":"git@github.com:drtamermansour/khmer.git","clone_url":"https://github.com/drtamermansour/khmer.git","svn_url":"https://github.com/drtamermansour/khmer","homepage":"http://khmer.readthedocs.org/","size":101509,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dib-lab:master","ref":"master","sha":"ffb8865d28ccf584e5de3362f9150a6b020eaa11","user":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":4331833,"name":"khmer","full_name":"dib-lab/khmer","owner":{"login":"dib-lab","id":1740697,"avatar_url":"https://avatars.githubusercontent.com/u/1740697?v=3","gravatar_id":"","url":"https://api.github.com/users/dib-lab","html_url":"https://github.com/dib-lab","followers_url":"https://api.github.com/users/dib-lab/followers","following_url":"https://api.github.com/users/dib-lab/following{/other_user}","gists_url":"https://api.github.com/users/dib-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/dib-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dib-lab/subscriptions","organizations_url":"https://api.github.com/users/dib-lab/orgs","repos_url":"https://api.github.com/users/dib-lab/repos","events_url":"https://api.github.com/users/dib-lab/events{/privacy}","received_events_url":"https://api.github.com/users/dib-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dib-lab/khmer","description":"In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more","fork":false,"url":"https://api.github.com/repos/dib-lab/khmer","forks_url":"https://api.github.com/repos/dib-lab/khmer/forks","keys_url":"https://api.github.com/repos/dib-lab/khmer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dib-lab/khmer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dib-lab/khmer/teams","hooks_url":"https://api.github.com/repos/dib-lab/khmer/hooks","issue_events_url":"https://api.github.com/repos/dib-lab/khmer/issues/events{/number}","events_url":"https://api.github.com/repos/dib-lab/khmer/events","assignees_url":"https://api.github.com/repos/dib-lab/khmer/assignees{/user}","branches_url":"https://api.github.com/repos/dib-lab/khmer/branches{/branch}","tags_url":"https://api.github.com/repos/dib-lab/khmer/tags","blobs_url":"https://api.github.com/repos/dib-lab/khmer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dib-lab/khmer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dib-lab/khmer/git/refs{/sha}","trees_url":"https://api.github.com/repos/dib-lab/khmer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dib-lab/khmer/statuses/{sha}","languages_url":"https://api.github.com/repos/dib-lab/khmer/languages","stargazers_url":"https://api.github.com/repos/dib-lab/khmer/stargazers","contributors_url":"https://api.github.com/repos/dib-lab/khmer/contributors","subscribers_url":"https://api.github.com/repos/dib-lab/khmer/subscribers","subscription_url":"https://api.github.com/repos/dib-lab/khmer/subscription","commits_url":"https://api.github.com/repos/dib-lab/khmer/commits{/sha}","git_commits_url":"https://api.github.com/repos/dib-lab/khmer/git/commits{/sha}","comments_url":"https://api.github.com/repos/dib-lab/khmer/comments{/number}","issue_comment_url":"https://api.github.com/repos/dib-lab/khmer/issues/comments{/number}","contents_url":"https://api.github.com/repos/dib-lab/khmer/contents/{+path}","compare_url":"https://api.github.com/repos/dib-lab/khmer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dib-lab/khmer/merges","archive_url":"https://api.github.com/repos/dib-lab/khmer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dib-lab/khmer/downloads","issues_url":"https://api.github.com/repos/dib-lab/khmer/issues{/number}","pulls_url":"https://api.github.com/repos/dib-lab/khmer/pulls{/number}","milestones_url":"https://api.github.com/repos/dib-lab/khmer/milestones{/number}","notifications_url":"https://api.github.com/repos/dib-lab/khmer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dib-lab/khmer/labels{/name}","releases_url":"https://api.github.com/repos/dib-lab/khmer/releases{/id}","created_at":"2012-05-15T03:52:53Z","updated_at":"2015-05-15T14:14:04Z","pushed_at":"2015-05-18T14:57:30Z","git_url":"git://github.com/dib-lab/khmer.git","ssh_url":"git@github.com:dib-lab/khmer.git","clone_url":"https://github.com/dib-lab/khmer.git","svn_url":"https://github.com/dib-lab/khmer","homepage":"http://khmer.readthedocs.org/","size":172343,"stargazers_count":225,"watchers_count":225,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":259,"forks":189,"open_issues":259,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1001"},"html":{"href":"https://github.com/dib-lab/khmer/pull/1001"},"issue":{"href":"https://api.github.com/repos/dib-lab/khmer/issues/1001"},"comments":{"href":"https://api.github.com/repos/dib-lab/khmer/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dib-lab/khmer/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/dib-lab/khmer/statuses/b95a7c7c115bfb2857ba80f28bdeab3e3deb1892"}}}}