{"action":"opened","number":11507,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/11507","id":54549326,"html_url":"https://github.com/laravel/framework/pull/11507","diff_url":"https://github.com/laravel/framework/pull/11507.diff","patch_url":"https://github.com/laravel/framework/pull/11507.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/11507","number":11507,"state":"open","locked":false,"title":"[5.2] VerifyPostSize Middleware","user":{"login":"KennedyTedesco","id":999232,"avatar_url":"https://avatars.githubusercontent.com/u/999232?v=3","gravatar_id":"","url":"https://api.github.com/users/KennedyTedesco","html_url":"https://github.com/KennedyTedesco","followers_url":"https://api.github.com/users/KennedyTedesco/followers","following_url":"https://api.github.com/users/KennedyTedesco/following{/other_user}","gists_url":"https://api.github.com/users/KennedyTedesco/gists{/gist_id}","starred_url":"https://api.github.com/users/KennedyTedesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennedyTedesco/subscriptions","organizations_url":"https://api.github.com/users/KennedyTedesco/orgs","repos_url":"https://api.github.com/users/KennedyTedesco/repos","events_url":"https://api.github.com/users/KennedyTedesco/events{/privacy}","received_events_url":"https://api.github.com/users/KennedyTedesco/received_events","type":"User","site_admin":false},"body":"Not a functional change. Just for a better readability.\r\n\r\nOriginal implementation:\r\n\r\n```\r\n/**\r\n* Determine the server 'post_max_size' as bytes.\r\n*\r\n* @return int\r\n*/\r\nprotected function getPostMaxSize()\r\n{\r\n   $postMaxSize = ini_get('post_max_size');\r\n\r\n   switch (substr($postMaxSize, -1)) {\r\n    case 'M':\r\n    case 'm':\r\n        return (int) $postMaxSize * 1048576;\r\n    case 'K':\r\n    case 'k':\r\n        return (int) $postMaxSize * 1024;\r\n    case 'G':\r\n    case 'g':\r\n        return (int) $postMaxSize * 1073741824;\r\n\t}\r\n\r\n   return (int) $postMaxSize;\r\n}\r\n```\r\n\r\nNew one:\r\n\r\n```\r\n/**\r\n * Determine the server 'post_max_size' as bytes.\r\n *\r\n * @return int\r\n */\r\nprotected function getPostMaxSize()\r\n{\r\n    $postMaxSize = ini_get('post_max_size');\r\n\r\n    $metric = strtoupper(substr($postMaxSize, -1));\r\n\r\n    switch ($metric) {\r\n        case 'K':\r\n            return (int) $postMaxSize * 1024;\r\n        case 'M':\r\n            return (int) $postMaxSize * 1048576;\r\n        case 'G':\r\n            return (int) $postMaxSize * 1073741824;\r\n        default:\r\n            return (int) $postMaxSize;\r\n    }\r\n}\r\n```\r\n\r\n","created_at":"2015-12-24T12:48:16Z","updated_at":"2015-12-24T12:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd14025fd3fd039850a09dcf3341faea21105de4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/11507/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/11507/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/11507/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/6838acf5b7284963d34ba0e481c3ce39be170c97","head":{"label":"KennedyTedesco:foundation-http-5.2","ref":"foundation-http-5.2","sha":"6838acf5b7284963d34ba0e481c3ce39be170c97","user":{"login":"KennedyTedesco","id":999232,"avatar_url":"https://avatars.githubusercontent.com/u/999232?v=3","gravatar_id":"","url":"https://api.github.com/users/KennedyTedesco","html_url":"https://github.com/KennedyTedesco","followers_url":"https://api.github.com/users/KennedyTedesco/followers","following_url":"https://api.github.com/users/KennedyTedesco/following{/other_user}","gists_url":"https://api.github.com/users/KennedyTedesco/gists{/gist_id}","starred_url":"https://api.github.com/users/KennedyTedesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennedyTedesco/subscriptions","organizations_url":"https://api.github.com/users/KennedyTedesco/orgs","repos_url":"https://api.github.com/users/KennedyTedesco/repos","events_url":"https://api.github.com/users/KennedyTedesco/events{/privacy}","received_events_url":"https://api.github.com/users/KennedyTedesco/received_events","type":"User","site_admin":false},"repo":{"id":48459637,"name":"framework","full_name":"KennedyTedesco/framework","owner":{"login":"KennedyTedesco","id":999232,"avatar_url":"https://avatars.githubusercontent.com/u/999232?v=3","gravatar_id":"","url":"https://api.github.com/users/KennedyTedesco","html_url":"https://github.com/KennedyTedesco","followers_url":"https://api.github.com/users/KennedyTedesco/followers","following_url":"https://api.github.com/users/KennedyTedesco/following{/other_user}","gists_url":"https://api.github.com/users/KennedyTedesco/gists{/gist_id}","starred_url":"https://api.github.com/users/KennedyTedesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KennedyTedesco/subscriptions","organizations_url":"https://api.github.com/users/KennedyTedesco/orgs","repos_url":"https://api.github.com/users/KennedyTedesco/repos","events_url":"https://api.github.com/users/KennedyTedesco/events{/privacy}","received_events_url":"https://api.github.com/users/KennedyTedesco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KennedyTedesco/framework","description":"","fork":true,"url":"https://api.github.com/repos/KennedyTedesco/framework","forks_url":"https://api.github.com/repos/KennedyTedesco/framework/forks","keys_url":"https://api.github.com/repos/KennedyTedesco/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KennedyTedesco/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KennedyTedesco/framework/teams","hooks_url":"https://api.github.com/repos/KennedyTedesco/framework/hooks","issue_events_url":"https://api.github.com/repos/KennedyTedesco/framework/issues/events{/number}","events_url":"https://api.github.com/repos/KennedyTedesco/framework/events","assignees_url":"https://api.github.com/repos/KennedyTedesco/framework/assignees{/user}","branches_url":"https://api.github.com/repos/KennedyTedesco/framework/branches{/branch}","tags_url":"https://api.github.com/repos/KennedyTedesco/framework/tags","blobs_url":"https://api.github.com/repos/KennedyTedesco/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KennedyTedesco/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KennedyTedesco/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/KennedyTedesco/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KennedyTedesco/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/KennedyTedesco/framework/languages","stargazers_url":"https://api.github.com/repos/KennedyTedesco/framework/stargazers","contributors_url":"https://api.github.com/repos/KennedyTedesco/framework/contributors","subscribers_url":"https://api.github.com/repos/KennedyTedesco/framework/subscribers","subscription_url":"https://api.github.com/repos/KennedyTedesco/framework/subscription","commits_url":"https://api.github.com/repos/KennedyTedesco/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/KennedyTedesco/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/KennedyTedesco/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/KennedyTedesco/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/KennedyTedesco/framework/contents/{+path}","compare_url":"https://api.github.com/repos/KennedyTedesco/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KennedyTedesco/framework/merges","archive_url":"https://api.github.com/repos/KennedyTedesco/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KennedyTedesco/framework/downloads","issues_url":"https://api.github.com/repos/KennedyTedesco/framework/issues{/number}","pulls_url":"https://api.github.com/repos/KennedyTedesco/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/KennedyTedesco/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/KennedyTedesco/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KennedyTedesco/framework/labels{/name}","releases_url":"https://api.github.com/repos/KennedyTedesco/framework/releases{/id}","created_at":"2015-12-22T23:57:45Z","updated_at":"2015-12-22T23:57:49Z","pushed_at":"2015-12-24T12:28:14Z","git_url":"git://github.com/KennedyTedesco/framework.git","ssh_url":"git@github.com:KennedyTedesco/framework.git","clone_url":"https://github.com/KennedyTedesco/framework.git","svn_url":"https://github.com/KennedyTedesco/framework","homepage":"http://laravel.com","size":20296,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:5.2","ref":"5.2","sha":"774c01a990d5e96ef7f70ed2c78d741addab9ea5","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-12-24T10:33:49Z","pushed_at":"2015-12-24T12:48:18Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33193,"stargazers_count":4525,"watchers_count":4525,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2625,"mirror_url":null,"open_issues_count":33,"forks":2625,"open_issues":33,"watchers":4525,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/11507"},"html":{"href":"https://github.com/laravel/framework/pull/11507"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/11507"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/11507/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/11507/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/11507/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/6838acf5b7284963d34ba0e481c3ce39be170c97"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":8,"changed_files":1}}