{"action":"created","comment":{"url":"https://api.github.com/repos/gaearon/redux/pulls/comments/33102047","id":33102047,"diff_hunk":"@@ -1,8 +1,17 @@\n import mapValues from '../utils/mapValues';\n import pick from '../utils/pick';\n+import invariant from 'invariant';\n \n export default function composeStores(stores) {\n   const finalStores = pick(stores, (val) => typeof val === 'function');\n+\n+  Object.keys(finalStores).forEach(key => {\n+    invariant(\n+        typeof finalStores[key]({}, {}) !== 'undefined',","path":"src/utils/composeStores.js","position":10,"original_position":10,"commit_id":"71d54b0d6e7276555fd5aefb7b0a662e4466f21c","original_commit_id":"71d54b0d6e7276555fd5aefb7b0a662e4466f21c","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"Okay, I think I'm confident now I only want to do this in development. Let's add `process.env.NODE_ENV !== 'production'` check and use `console.warn` instead.","created_at":"2015-06-23T22:53:04Z","updated_at":"2015-06-23T22:53:04Z","html_url":"https://github.com/gaearon/redux/pull/174#discussion_r33102047","pull_request_url":"https://api.github.com/repos/gaearon/redux/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/gaearon/redux/pulls/comments/33102047"},"html":{"href":"https://github.com/gaearon/redux/pull/174#discussion_r33102047"},"pull_request":{"href":"https://api.github.com/repos/gaearon/redux/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/gaearon/redux/pulls/174","id":38391200,"html_url":"https://github.com/gaearon/redux/pull/174","diff_url":"https://github.com/gaearon/redux/pull/174.diff","patch_url":"https://github.com/gaearon/redux/pull/174.patch","issue_url":"https://api.github.com/repos/gaearon/redux/issues/174","number":174,"state":"open","locked":false,"title":"Checking that the return value of every store function inside compose…","user":{"login":"honzatrtik","id":1225333,"avatar_url":"https://avatars.githubusercontent.com/u/1225333?v=3","gravatar_id":"","url":"https://api.github.com/users/honzatrtik","html_url":"https://github.com/honzatrtik","followers_url":"https://api.github.com/users/honzatrtik/followers","following_url":"https://api.github.com/users/honzatrtik/following{/other_user}","gists_url":"https://api.github.com/users/honzatrtik/gists{/gist_id}","starred_url":"https://api.github.com/users/honzatrtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honzatrtik/subscriptions","organizations_url":"https://api.github.com/users/honzatrtik/orgs","repos_url":"https://api.github.com/users/honzatrtik/repos","events_url":"https://api.github.com/users/honzatrtik/events{/privacy}","received_events_url":"https://api.github.com/users/honzatrtik/received_events","type":"User","site_admin":false},"body":"…Stores is not undefined","created_at":"2015-06-23T22:43:29Z","updated_at":"2015-06-23T22:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e510098aa6670193049b04cbbe72598cb6bdf03f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gaearon/redux/pulls/174/commits","review_comments_url":"https://api.github.com/repos/gaearon/redux/pulls/174/comments","review_comment_url":"https://api.github.com/repos/gaearon/redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gaearon/redux/issues/174/comments","statuses_url":"https://api.github.com/repos/gaearon/redux/statuses/71d54b0d6e7276555fd5aefb7b0a662e4466f21c","head":{"label":"honzatrtik:master","ref":"master","sha":"71d54b0d6e7276555fd5aefb7b0a662e4466f21c","user":{"login":"honzatrtik","id":1225333,"avatar_url":"https://avatars.githubusercontent.com/u/1225333?v=3","gravatar_id":"","url":"https://api.github.com/users/honzatrtik","html_url":"https://github.com/honzatrtik","followers_url":"https://api.github.com/users/honzatrtik/followers","following_url":"https://api.github.com/users/honzatrtik/following{/other_user}","gists_url":"https://api.github.com/users/honzatrtik/gists{/gist_id}","starred_url":"https://api.github.com/users/honzatrtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honzatrtik/subscriptions","organizations_url":"https://api.github.com/users/honzatrtik/orgs","repos_url":"https://api.github.com/users/honzatrtik/repos","events_url":"https://api.github.com/users/honzatrtik/events{/privacy}","received_events_url":"https://api.github.com/users/honzatrtik/received_events","type":"User","site_admin":false},"repo":{"id":37948743,"name":"redux","full_name":"honzatrtik/redux","owner":{"login":"honzatrtik","id":1225333,"avatar_url":"https://avatars.githubusercontent.com/u/1225333?v=3","gravatar_id":"","url":"https://api.github.com/users/honzatrtik","html_url":"https://github.com/honzatrtik","followers_url":"https://api.github.com/users/honzatrtik/followers","following_url":"https://api.github.com/users/honzatrtik/following{/other_user}","gists_url":"https://api.github.com/users/honzatrtik/gists{/gist_id}","starred_url":"https://api.github.com/users/honzatrtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honzatrtik/subscriptions","organizations_url":"https://api.github.com/users/honzatrtik/orgs","repos_url":"https://api.github.com/users/honzatrtik/repos","events_url":"https://api.github.com/users/honzatrtik/events{/privacy}","received_events_url":"https://api.github.com/users/honzatrtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honzatrtik/redux","description":"Atomic Flux with hot reloading","fork":true,"url":"https://api.github.com/repos/honzatrtik/redux","forks_url":"https://api.github.com/repos/honzatrtik/redux/forks","keys_url":"https://api.github.com/repos/honzatrtik/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honzatrtik/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honzatrtik/redux/teams","hooks_url":"https://api.github.com/repos/honzatrtik/redux/hooks","issue_events_url":"https://api.github.com/repos/honzatrtik/redux/issues/events{/number}","events_url":"https://api.github.com/repos/honzatrtik/redux/events","assignees_url":"https://api.github.com/repos/honzatrtik/redux/assignees{/user}","branches_url":"https://api.github.com/repos/honzatrtik/redux/branches{/branch}","tags_url":"https://api.github.com/repos/honzatrtik/redux/tags","blobs_url":"https://api.github.com/repos/honzatrtik/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honzatrtik/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honzatrtik/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/honzatrtik/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honzatrtik/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/honzatrtik/redux/languages","stargazers_url":"https://api.github.com/repos/honzatrtik/redux/stargazers","contributors_url":"https://api.github.com/repos/honzatrtik/redux/contributors","subscribers_url":"https://api.github.com/repos/honzatrtik/redux/subscribers","subscription_url":"https://api.github.com/repos/honzatrtik/redux/subscription","commits_url":"https://api.github.com/repos/honzatrtik/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/honzatrtik/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/honzatrtik/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/honzatrtik/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/honzatrtik/redux/contents/{+path}","compare_url":"https://api.github.com/repos/honzatrtik/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honzatrtik/redux/merges","archive_url":"https://api.github.com/repos/honzatrtik/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honzatrtik/redux/downloads","issues_url":"https://api.github.com/repos/honzatrtik/redux/issues{/number}","pulls_url":"https://api.github.com/repos/honzatrtik/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/honzatrtik/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/honzatrtik/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honzatrtik/redux/labels{/name}","releases_url":"https://api.github.com/repos/honzatrtik/redux/releases{/id}","created_at":"2015-06-23T22:33:04Z","updated_at":"2015-06-23T22:33:04Z","pushed_at":"2015-06-23T22:41:39Z","git_url":"git://github.com/honzatrtik/redux.git","ssh_url":"git@github.com:honzatrtik/redux.git","clone_url":"https://github.com/honzatrtik/redux.git","svn_url":"https://github.com/honzatrtik/redux","homepage":"https://medium.com/@dan_abramov/the-evolution-of-flux-frameworks-6c16ad26bb31","size":2299,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gaearon:master","ref":"master","sha":"c1964b012d9fea51fe7f474924994c8cb9850b26","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"repo":{"id":36535156,"name":"redux","full_name":"gaearon/redux","owner":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaearon/redux","description":"Atomic Flux with hot reloading","fork":false,"url":"https://api.github.com/repos/gaearon/redux","forks_url":"https://api.github.com/repos/gaearon/redux/forks","keys_url":"https://api.github.com/repos/gaearon/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaearon/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaearon/redux/teams","hooks_url":"https://api.github.com/repos/gaearon/redux/hooks","issue_events_url":"https://api.github.com/repos/gaearon/redux/issues/events{/number}","events_url":"https://api.github.com/repos/gaearon/redux/events","assignees_url":"https://api.github.com/repos/gaearon/redux/assignees{/user}","branches_url":"https://api.github.com/repos/gaearon/redux/branches{/branch}","tags_url":"https://api.github.com/repos/gaearon/redux/tags","blobs_url":"https://api.github.com/repos/gaearon/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaearon/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaearon/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaearon/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaearon/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/gaearon/redux/languages","stargazers_url":"https://api.github.com/repos/gaearon/redux/stargazers","contributors_url":"https://api.github.com/repos/gaearon/redux/contributors","subscribers_url":"https://api.github.com/repos/gaearon/redux/subscribers","subscription_url":"https://api.github.com/repos/gaearon/redux/subscription","commits_url":"https://api.github.com/repos/gaearon/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaearon/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaearon/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaearon/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaearon/redux/contents/{+path}","compare_url":"https://api.github.com/repos/gaearon/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaearon/redux/merges","archive_url":"https://api.github.com/repos/gaearon/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaearon/redux/downloads","issues_url":"https://api.github.com/repos/gaearon/redux/issues{/number}","pulls_url":"https://api.github.com/repos/gaearon/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/gaearon/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/gaearon/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaearon/redux/labels{/name}","releases_url":"https://api.github.com/repos/gaearon/redux/releases{/id}","created_at":"2015-05-29T23:53:15Z","updated_at":"2015-06-23T21:42:10Z","pushed_at":"2015-06-23T22:43:29Z","git_url":"git://github.com/gaearon/redux.git","ssh_url":"git@github.com:gaearon/redux.git","clone_url":"https://github.com/gaearon/redux.git","svn_url":"https://github.com/gaearon/redux","homepage":"https://medium.com/@dan_abramov/the-evolution-of-flux-frameworks-6c16ad26bb31","size":2299,"stargazers_count":790,"watchers_count":790,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":33,"forks":45,"open_issues":33,"watchers":790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gaearon/redux/pulls/174"},"html":{"href":"https://github.com/gaearon/redux/pull/174"},"issue":{"href":"https://api.github.com/repos/gaearon/redux/issues/174"},"comments":{"href":"https://api.github.com/repos/gaearon/redux/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/gaearon/redux/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/gaearon/redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gaearon/redux/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/gaearon/redux/statuses/71d54b0d6e7276555fd5aefb7b0a662e4466f21c"}}}}