{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/36180907","id":36180907,"diff_hunk":"@@ -116,10 +116,8 @@ def _no_sign(src, dest):\n     # If this is a local development instance, just copy the file around\n     # so that everything seems to work locally.\n     log.info('Not signing the app, no signing server is active.')\n-    dest_dir = os.path.dirname(dest)\n-    if not os.path.exists(dest_dir):\n-        os.makedirs(dest_dir)\n-    shutil.copy(src, dest)\n+    with storage.open(dest, 'w') as destf:\n+        shutil.copyfileobj(open(src), destf)","path":"lib/crypto/packaged.py","position":9,"original_position":9,"commit_id":"03f3e1c70e43e77061678568b2c90e6640c7e0c3","original_commit_id":"03f3e1c70e43e77061678568b2c90e6640c7e0c3","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"This seems wrong, and breaks a few tests when remote storage is enabled. The `src` here will be the `file_path` of a `File` instance, which is supposed to be using the storage already. So we should be using `storage.open()` here.","created_at":"2015-08-04T12:17:04Z","updated_at":"2015-08-04T12:17:04Z","html_url":"https://github.com/mozilla/zamboni/pull/3208#discussion_r36180907","pull_request_url":"https://api.github.com/repos/mozilla/zamboni/pulls/3208","_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments/36180907"},"html":{"href":"https://github.com/mozilla/zamboni/pull/3208#discussion_r36180907"},"pull_request":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/3208"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/zamboni/pulls/3208","id":41390543,"html_url":"https://github.com/mozilla/zamboni/pull/3208","diff_url":"https://github.com/mozilla/zamboni/pull/3208.diff","patch_url":"https://github.com/mozilla/zamboni/pull/3208.patch","issue_url":"https://api.github.com/repos/mozilla/zamboni/issues/3208","number":3208,"state":"open","locked":false,"title":"Test fixes for S3 storage (bug 1167271)","user":{"login":"washort","id":947487,"avatar_url":"https://avatars.githubusercontent.com/u/947487?v=3","gravatar_id":"","url":"https://api.github.com/users/washort","html_url":"https://github.com/washort","followers_url":"https://api.github.com/users/washort/followers","following_url":"https://api.github.com/users/washort/following{/other_user}","gists_url":"https://api.github.com/users/washort/gists{/gist_id}","starred_url":"https://api.github.com/users/washort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washort/subscriptions","organizations_url":"https://api.github.com/users/washort/orgs","repos_url":"https://api.github.com/users/washort/repos","events_url":"https://api.github.com/users/washort/events{/privacy}","received_events_url":"https://api.github.com/users/washort/received_events","type":"User","site_admin":false},"body":"Some more test fixes.","created_at":"2015-07-31T23:37:49Z","updated_at":"2015-08-04T12:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"247d0bfd8671bb76faa30a67268ba362036bf488","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/zamboni/pulls/3208/commits","review_comments_url":"https://api.github.com/repos/mozilla/zamboni/pulls/3208/comments","review_comment_url":"https://api.github.com/repos/mozilla/zamboni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/zamboni/issues/3208/comments","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/03f3e1c70e43e77061678568b2c90e6640c7e0c3","head":{"label":"washort:more-s3-fixes","ref":"more-s3-fixes","sha":"03f3e1c70e43e77061678568b2c90e6640c7e0c3","user":{"login":"washort","id":947487,"avatar_url":"https://avatars.githubusercontent.com/u/947487?v=3","gravatar_id":"","url":"https://api.github.com/users/washort","html_url":"https://github.com/washort","followers_url":"https://api.github.com/users/washort/followers","following_url":"https://api.github.com/users/washort/following{/other_user}","gists_url":"https://api.github.com/users/washort/gists{/gist_id}","starred_url":"https://api.github.com/users/washort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washort/subscriptions","organizations_url":"https://api.github.com/users/washort/orgs","repos_url":"https://api.github.com/users/washort/repos","events_url":"https://api.github.com/users/washort/events{/privacy}","received_events_url":"https://api.github.com/users/washort/received_events","type":"User","site_admin":false},"repo":{"id":2126060,"name":"zamboni","full_name":"washort/zamboni","owner":{"login":"washort","id":947487,"avatar_url":"https://avatars.githubusercontent.com/u/947487?v=3","gravatar_id":"","url":"https://api.github.com/users/washort","html_url":"https://github.com/washort","followers_url":"https://api.github.com/users/washort/followers","following_url":"https://api.github.com/users/washort/following{/other_user}","gists_url":"https://api.github.com/users/washort/gists{/gist_id}","starred_url":"https://api.github.com/users/washort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washort/subscriptions","organizations_url":"https://api.github.com/users/washort/orgs","repos_url":"https://api.github.com/users/washort/repos","events_url":"https://api.github.com/users/washort/events{/privacy}","received_events_url":"https://api.github.com/users/washort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/washort/zamboni","description":"A clandestine operation to make AMO happy","fork":true,"url":"https://api.github.com/repos/washort/zamboni","forks_url":"https://api.github.com/repos/washort/zamboni/forks","keys_url":"https://api.github.com/repos/washort/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/washort/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/washort/zamboni/teams","hooks_url":"https://api.github.com/repos/washort/zamboni/hooks","issue_events_url":"https://api.github.com/repos/washort/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/washort/zamboni/events","assignees_url":"https://api.github.com/repos/washort/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/washort/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/washort/zamboni/tags","blobs_url":"https://api.github.com/repos/washort/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/washort/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/washort/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/washort/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/washort/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/washort/zamboni/languages","stargazers_url":"https://api.github.com/repos/washort/zamboni/stargazers","contributors_url":"https://api.github.com/repos/washort/zamboni/contributors","subscribers_url":"https://api.github.com/repos/washort/zamboni/subscribers","subscription_url":"https://api.github.com/repos/washort/zamboni/subscription","commits_url":"https://api.github.com/repos/washort/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/washort/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/washort/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/washort/zamboni/issues/comments{/number}","contents_url":"https://api.github.com/repos/washort/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/washort/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/washort/zamboni/merges","archive_url":"https://api.github.com/repos/washort/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/washort/zamboni/downloads","issues_url":"https://api.github.com/repos/washort/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/washort/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/washort/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/washort/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/washort/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/washort/zamboni/releases{/id}","created_at":"2011-07-29T20:50:16Z","updated_at":"2015-03-03T00:13:01Z","pushed_at":"2015-08-03T22:34:56Z","git_url":"git://github.com/washort/zamboni.git","ssh_url":"git@github.com:washort/zamboni.git","clone_url":"https://github.com/washort/zamboni.git","svn_url":"https://github.com/washort/zamboni","homepage":"http://jbalogh.github.com/zamboni/","size":379344,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c6fd999124706d438cf6bc905cbdba0b775a1682","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":347655,"name":"zamboni","full_name":"mozilla/zamboni","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/zamboni","description":"Backend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/zamboni","forks_url":"https://api.github.com/repos/mozilla/zamboni/forks","keys_url":"https://api.github.com/repos/mozilla/zamboni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/zamboni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/zamboni/teams","hooks_url":"https://api.github.com/repos/mozilla/zamboni/hooks","issue_events_url":"https://api.github.com/repos/mozilla/zamboni/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/zamboni/events","assignees_url":"https://api.github.com/repos/mozilla/zamboni/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/zamboni/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/zamboni/tags","blobs_url":"https://api.github.com/repos/mozilla/zamboni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/zamboni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/zamboni/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/zamboni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/zamboni/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/zamboni/languages","stargazers_url":"https://api.github.com/repos/mozilla/zamboni/stargazers","contributors_url":"https://api.github.com/repos/mozilla/zamboni/contributors","subscribers_url":"https://api.github.com/repos/mozilla/zamboni/subscribers","subscription_url":"https://api.github.com/repos/mozilla/zamboni/subscription","commits_url":"https://api.github.com/repos/mozilla/zamboni/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/zamboni/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/zamboni/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/zamboni/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/zamboni/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/zamboni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/zamboni/merges","archive_url":"https://api.github.com/repos/mozilla/zamboni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/zamboni/downloads","issues_url":"https://api.github.com/repos/mozilla/zamboni/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/zamboni/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/zamboni/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/zamboni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/zamboni/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/zamboni/releases{/id}","created_at":"2009-10-23T19:35:34Z","updated_at":"2015-07-22T20:15:23Z","pushed_at":"2015-08-04T11:59:37Z","git_url":"git://github.com/mozilla/zamboni.git","ssh_url":"git@github.com:mozilla/zamboni.git","clone_url":"https://github.com/mozilla/zamboni.git","svn_url":"https://github.com/mozilla/zamboni","homepage":"http://marketplace.readthedocs.org/en/latest/topics/backend.html","size":445253,"stargazers_count":467,"watchers_count":467,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":249,"mirror_url":null,"open_issues_count":15,"forks":249,"open_issues":15,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/3208"},"html":{"href":"https://github.com/mozilla/zamboni/pull/3208"},"issue":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/3208"},"comments":{"href":"https://api.github.com/repos/mozilla/zamboni/issues/3208/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/3208/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/zamboni/pulls/3208/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/zamboni/statuses/03f3e1c70e43e77061678568b2c90e6640c7e0c3"}}}}