{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/comments/38304022","id":38304022,"diff_hunk":"@@ -170,6 +119,12 @@ this is mapped to memory. This is intentional, so make sure you have enough\n RAM or you can experience some swapping. Alternatively, change the temp\n directory in the scripts.\n \n+It is possible to modify SYSLINUX kernel command line by changing\n+livecd-creator code in /usr/lib/python2.7/site-packages/imgcreate/live.py","path":"README.md","position":93,"original_position":93,"commit_id":"51d2ec5a691bfce0b83c6d472f6557b5e38c3720","original_commit_id":"51d2ec5a691bfce0b83c6d472f6557b5e38c3720","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"I have a TODO item to expand this. Existing image should be modifiable, don't know how yet. Will rewrite this section.","created_at":"2015-08-31T11:40:25Z","updated_at":"2015-08-31T11:40:25Z","html_url":"https://github.com/theforeman/foreman-discovery-image/pull/21#discussion_r38304022","pull_request_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/comments/38304022"},"html":{"href":"https://github.com/theforeman/foreman-discovery-image/pull/21#discussion_r38304022"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21","id":41894925,"html_url":"https://github.com/theforeman/foreman-discovery-image/pull/21","diff_url":"https://github.com/theforeman/foreman-discovery-image/pull/21.diff","patch_url":"https://github.com/theforeman/foreman-discovery-image/pull/21.patch","issue_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/21","number":21,"state":"open","locked":false,"title":"Fixes #10299 - PXELess discovery with TUI interface","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"The code is done, *feel free to review and test now*.\r\n\r\nSee the README change for instructions how this is supposed to work.\r\n\r\nChanges required to test this:\r\n* Discovery plugin: https://github.com/theforeman/foreman_discovery/pull/210\r\n* Smart-proxy discovery image (new) plugin: https://github.com/theforeman/smart_proxy_discovery_image/pull/1\r\n* Smart-proxy discovery \"proxy\": https://github.com/theforeman/smart_proxy_discovery/pull/8\r\n* Documentation: https://github.com/theforeman/theforeman.org/pull/421\r\n\r\nInstructions:\r\n\r\nBuild image with this patch and make sure you provide explicit version to it `3.0.0`. This is important, if you build with latest tag `2.1.1` it will not work. Give it any release number you want like 1 or 99.\r\n\r\n     ./build-livecd fdi-centos7.ks 99 3.0.0 && sudo ./build-livecd-root 3.0.0\r\n\r\nVersion can be checked on the TUI interface, in the `/usr/share/fdi/VERSION` file or uploaded facts.\r\n\r\nThen checkout foreman develop with foreman_discovery with the patch above. Checkout smart-proxy with discovery \"proxy\" plugin enabled and with the patch above (note the difference between discovery image and discovery proxy plugins).\r\n\r\nThe last remaining bit is to install smart_proxy_discovery into the image. You need to do it via ssh since there is no RPM package yet: `gem build smart_proxy_discovery_image.gemspec && sshpass -p redhat scp smart_proxy_discovery_image-1.0.0.gem root@192.168.122.68: && sshpass -p redhat ssh root@192.168.122.68 \"gem install smart_proxy_discovery_image-1.0.0.gem && echo 'gem \\\"smart_proxy_discovery_image\\\"' > /usr/share/foreman-proxy/bundler.d/discovery_image.rb && systemctl restart foreman-proxy && tail -f /tmp/proxy.log\"`\r\n\r\nKnown issues (TODO):\r\n\r\n- [x] better semi-automatic mode (currently it is all or nothing)\r\n- [ ] document how to modify kernel command line options ISO file\r\n- [x] better taxonomy support for discovered hosts (https://github.com/theforeman/foreman_discovery/pull/211)\r\n- [x] better screen texts and buttons\r\n- [x] do IP address CIDR validation on the network form\r\n- [x] move the README block in the official docs\r\n- [x] test with DHCP (but no PXE)\r\n- [x] test without DHCP with multiple NICs (currently not able to pass the correct provisioning interface into Anaconda because of naming conventions RHEL6 vs RHEL7 http://thread.gmane.org/gmane.linux.redhat.anaconda.devel/26055)\r\n- [x] added extra \"append\" fact into the template to workaround above\r\n\r\nWhen testing this, do all three scenarios:\r\n\r\n* DHCP & PXE (traditional discovery, interrupt with a key)\r\n* DHCP only\r\n* no DHCP","created_at":"2015-08-07T14:04:51Z","updated_at":"2015-08-31T11:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3fb8d753fb55829e620879c5a691b272c799874","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/21/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/statuses/51d2ec5a691bfce0b83c6d472f6557b5e38c3720","head":{"label":"lzap:tui","ref":"tui","sha":"51d2ec5a691bfce0b83c6d472f6557b5e38c3720","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":28855084,"name":"foreman-discovery-image","full_name":"lzap/foreman-discovery-image","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman-discovery-image","description":"Foreman discovery image live distro","fork":true,"url":"https://api.github.com/repos/lzap/foreman-discovery-image","forks_url":"https://api.github.com/repos/lzap/foreman-discovery-image/forks","keys_url":"https://api.github.com/repos/lzap/foreman-discovery-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman-discovery-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman-discovery-image/teams","hooks_url":"https://api.github.com/repos/lzap/foreman-discovery-image/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman-discovery-image/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman-discovery-image/events","assignees_url":"https://api.github.com/repos/lzap/foreman-discovery-image/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman-discovery-image/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman-discovery-image/tags","blobs_url":"https://api.github.com/repos/lzap/foreman-discovery-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman-discovery-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman-discovery-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman-discovery-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman-discovery-image/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman-discovery-image/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman-discovery-image/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman-discovery-image/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman-discovery-image/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman-discovery-image/subscription","commits_url":"https://api.github.com/repos/lzap/foreman-discovery-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman-discovery-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman-discovery-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman-discovery-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/foreman-discovery-image/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman-discovery-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman-discovery-image/merges","archive_url":"https://api.github.com/repos/lzap/foreman-discovery-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman-discovery-image/downloads","issues_url":"https://api.github.com/repos/lzap/foreman-discovery-image/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman-discovery-image/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman-discovery-image/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman-discovery-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman-discovery-image/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman-discovery-image/releases{/id}","created_at":"2015-01-06T08:58:39Z","updated_at":"2015-04-28T14:25:32Z","pushed_at":"2015-08-28T14:35:22Z","git_url":"git://github.com/lzap/foreman-discovery-image.git","ssh_url":"git@github.com:lzap/foreman-discovery-image.git","clone_url":"https://github.com/lzap/foreman-discovery-image.git","svn_url":"https://github.com/lzap/foreman-discovery-image","homepage":null,"size":241,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"6a1dc8fda041a24bbb1909afa6b9dcf3ec597633","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":25574310,"name":"foreman-discovery-image","full_name":"theforeman/foreman-discovery-image","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman-discovery-image","description":"Foreman discovery image live distro","fork":false,"url":"https://api.github.com/repos/theforeman/foreman-discovery-image","forks_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/forks","keys_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/events","assignees_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/merges","archive_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman-discovery-image/releases{/id}","created_at":"2014-10-22T09:55:08Z","updated_at":"2015-08-13T06:51:00Z","pushed_at":"2015-08-28T14:35:23Z","git_url":"git://github.com/theforeman/foreman-discovery-image.git","ssh_url":"git@github.com:theforeman/foreman-discovery-image.git","clone_url":"https://github.com/theforeman/foreman-discovery-image.git","svn_url":"https://github.com/theforeman/foreman-discovery-image","homepage":null,"size":550,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21"},"html":{"href":"https://github.com/theforeman/foreman-discovery-image/pull/21"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/21"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman-discovery-image/statuses/51d2ec5a691bfce0b83c6d472f6557b5e38c3720"}}}}