{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9","id":45807477,"html_url":"https://github.com/sghiassy/react-native-sglistview/pull/9","diff_url":"https://github.com/sghiassy/react-native-sglistview/pull/9.diff","patch_url":"https://github.com/sghiassy/react-native-sglistview/pull/9.patch","issue_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/9","number":9,"state":"closed","locked":false,"title":"Improve handling of large rows","user":{"login":"udfalkso","id":2029383,"avatar_url":"https://avatars.githubusercontent.com/u/2029383?v=3","gravatar_id":"","url":"https://api.github.com/users/udfalkso","html_url":"https://github.com/udfalkso","followers_url":"https://api.github.com/users/udfalkso/followers","following_url":"https://api.github.com/users/udfalkso/following{/other_user}","gists_url":"https://api.github.com/users/udfalkso/gists{/gist_id}","starred_url":"https://api.github.com/users/udfalkso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udfalkso/subscriptions","organizations_url":"https://api.github.com/users/udfalkso/orgs","repos_url":"https://api.github.com/users/udfalkso/repos","events_url":"https://api.github.com/users/udfalkso/events{/privacy}","received_events_url":"https://api.github.com/users/udfalkso/received_events","type":"User","site_admin":false},"body":"Our app has list items that are quite large and are often larger than the screen height.  In this case, it seems that the premptive loading was not functioning correctly, leading to lots of flickering and flashing.  \r\n\r\nThis PR attempts to better handle this case.  Performance in our case definitely seems improved, and I did some quick trials with smaller rows and they also seem to work well.  I do still see some flashing issues when scrolling up, not quite sure why though.  \r\n\r\nHighlights:\r\n- Assumes that things start scrolling down and adjusted scroll direction logic a bit.  \r\n\r\n- Set lastVisibleSection & lastVisibleRow such that if there's only 1 visible item things aren't undefined.  \r\n\r\n- Put a stronger cap on how many items are added to premptive list.  I saw that this list was ballooning out of control in some cases while testing (because when scrolling quickly the popping of visible elements wasn't catching everything?)\r\n\r\nThat's all I've got for now.  Hope this is helpful to some.  Thanks again for this great Component!!","created_at":"2015-09-23T17:30:43Z","updated_at":"2015-11-06T18:40:34Z","closed_at":"2015-11-06T18:40:34Z","merged_at":null,"merge_commit_sha":"005fff12d82f23a9844becb632c4bf48fa1df525","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9/commits","review_comments_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9/comments","review_comment_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/9/comments","statuses_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/statuses/eb66522a3a27c075cc91e46a4d738fc9053da4eb","head":{"label":"udfalkso:improve-large-rows-premptive","ref":"improve-large-rows-premptive","sha":"eb66522a3a27c075cc91e46a4d738fc9053da4eb","user":{"login":"udfalkso","id":2029383,"avatar_url":"https://avatars.githubusercontent.com/u/2029383?v=3","gravatar_id":"","url":"https://api.github.com/users/udfalkso","html_url":"https://github.com/udfalkso","followers_url":"https://api.github.com/users/udfalkso/followers","following_url":"https://api.github.com/users/udfalkso/following{/other_user}","gists_url":"https://api.github.com/users/udfalkso/gists{/gist_id}","starred_url":"https://api.github.com/users/udfalkso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udfalkso/subscriptions","organizations_url":"https://api.github.com/users/udfalkso/orgs","repos_url":"https://api.github.com/users/udfalkso/repos","events_url":"https://api.github.com/users/udfalkso/events{/privacy}","received_events_url":"https://api.github.com/users/udfalkso/received_events","type":"User","site_admin":false},"repo":{"id":43015685,"name":"react-native-sglistview","full_name":"udfalkso/react-native-sglistview","owner":{"login":"udfalkso","id":2029383,"avatar_url":"https://avatars.githubusercontent.com/u/2029383?v=3","gravatar_id":"","url":"https://api.github.com/users/udfalkso","html_url":"https://github.com/udfalkso","followers_url":"https://api.github.com/users/udfalkso/followers","following_url":"https://api.github.com/users/udfalkso/following{/other_user}","gists_url":"https://api.github.com/users/udfalkso/gists{/gist_id}","starred_url":"https://api.github.com/users/udfalkso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/udfalkso/subscriptions","organizations_url":"https://api.github.com/users/udfalkso/orgs","repos_url":"https://api.github.com/users/udfalkso/repos","events_url":"https://api.github.com/users/udfalkso/events{/privacy}","received_events_url":"https://api.github.com/users/udfalkso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/udfalkso/react-native-sglistview","description":"","fork":true,"url":"https://api.github.com/repos/udfalkso/react-native-sglistview","forks_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/forks","keys_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/teams","hooks_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/hooks","issue_events_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/issues/events{/number}","events_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/events","assignees_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/assignees{/user}","branches_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/branches{/branch}","tags_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/tags","blobs_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/git/refs{/sha}","trees_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/statuses/{sha}","languages_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/languages","stargazers_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/stargazers","contributors_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/contributors","subscribers_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/subscribers","subscription_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/subscription","commits_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/commits{/sha}","git_commits_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/git/commits{/sha}","comments_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/comments{/number}","issue_comment_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/issues/comments{/number}","contents_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/contents/{+path}","compare_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/merges","archive_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/downloads","issues_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/issues{/number}","pulls_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/pulls{/number}","milestones_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/milestones{/number}","notifications_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/labels{/name}","releases_url":"https://api.github.com/repos/udfalkso/react-native-sglistview/releases{/id}","created_at":"2015-09-23T17:19:09Z","updated_at":"2015-09-23T17:19:09Z","pushed_at":"2015-09-26T13:55:36Z","git_url":"git://github.com/udfalkso/react-native-sglistview.git","ssh_url":"git@github.com:udfalkso/react-native-sglistview.git","clone_url":"https://github.com/udfalkso/react-native-sglistview.git","svn_url":"https://github.com/udfalkso/react-native-sglistview","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sghiassy:master","ref":"master","sha":"424cf621baa42f21c010fc618100a794dee259f0","user":{"login":"sghiassy","id":792606,"avatar_url":"https://avatars.githubusercontent.com/u/792606?v=3","gravatar_id":"","url":"https://api.github.com/users/sghiassy","html_url":"https://github.com/sghiassy","followers_url":"https://api.github.com/users/sghiassy/followers","following_url":"https://api.github.com/users/sghiassy/following{/other_user}","gists_url":"https://api.github.com/users/sghiassy/gists{/gist_id}","starred_url":"https://api.github.com/users/sghiassy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghiassy/subscriptions","organizations_url":"https://api.github.com/users/sghiassy/orgs","repos_url":"https://api.github.com/users/sghiassy/repos","events_url":"https://api.github.com/users/sghiassy/events{/privacy}","received_events_url":"https://api.github.com/users/sghiassy/received_events","type":"User","site_admin":false},"repo":{"id":40141478,"name":"react-native-sglistview","full_name":"sghiassy/react-native-sglistview","owner":{"login":"sghiassy","id":792606,"avatar_url":"https://avatars.githubusercontent.com/u/792606?v=3","gravatar_id":"","url":"https://api.github.com/users/sghiassy","html_url":"https://github.com/sghiassy","followers_url":"https://api.github.com/users/sghiassy/followers","following_url":"https://api.github.com/users/sghiassy/following{/other_user}","gists_url":"https://api.github.com/users/sghiassy/gists{/gist_id}","starred_url":"https://api.github.com/users/sghiassy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghiassy/subscriptions","organizations_url":"https://api.github.com/users/sghiassy/orgs","repos_url":"https://api.github.com/users/sghiassy/repos","events_url":"https://api.github.com/users/sghiassy/events{/privacy}","received_events_url":"https://api.github.com/users/sghiassy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sghiassy/react-native-sglistview","description":"","fork":false,"url":"https://api.github.com/repos/sghiassy/react-native-sglistview","forks_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/forks","keys_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/teams","hooks_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/hooks","issue_events_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/events{/number}","events_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/events","assignees_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/assignees{/user}","branches_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/branches{/branch}","tags_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/tags","blobs_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/git/refs{/sha}","trees_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/statuses/{sha}","languages_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/languages","stargazers_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/stargazers","contributors_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/contributors","subscribers_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/subscribers","subscription_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/subscription","commits_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/commits{/sha}","git_commits_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/git/commits{/sha}","comments_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/comments{/number}","issue_comment_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/comments{/number}","contents_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/contents/{+path}","compare_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/merges","archive_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/downloads","issues_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues{/number}","pulls_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls{/number}","milestones_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/milestones{/number}","notifications_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/labels{/name}","releases_url":"https://api.github.com/repos/sghiassy/react-native-sglistview/releases{/id}","created_at":"2015-08-03T18:34:09Z","updated_at":"2015-11-05T00:43:46Z","pushed_at":"2015-09-29T13:44:36Z","git_url":"git://github.com/sghiassy/react-native-sglistview.git","ssh_url":"git@github.com:sghiassy/react-native-sglistview.git","clone_url":"https://github.com/sghiassy/react-native-sglistview.git","svn_url":"https://github.com/sghiassy/react-native-sglistview","homepage":null,"size":285,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9"},"html":{"href":"https://github.com/sghiassy/react-native-sglistview/pull/9"},"issue":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/9"},"comments":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/sghiassy/react-native-sglistview/statuses/eb66522a3a27c075cc91e46a4d738fc9053da4eb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":3,"commits":5,"additions":45,"deletions":52,"changed_files":2}}