{"action":"opened","number":196,"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196","id":27605706,"html_url":"https://github.com/rpm-software-management/dnf/pull/196","diff_url":"https://github.com/rpm-software-management/dnf/pull/196.diff","patch_url":"https://github.com/rpm-software-management/dnf/pull/196.patch","issue_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/196","number":196,"state":"open","locked":false,"title":"Enhancement to dnf.spec.in file which follows current fedora packaging guidelines","user":{"login":"pnemade","id":671366,"avatar_url":"https://avatars.githubusercontent.com/u/671366?v=3","gravatar_id":"","url":"https://api.github.com/users/pnemade","html_url":"https://github.com/pnemade","followers_url":"https://api.github.com/users/pnemade/followers","following_url":"https://api.github.com/users/pnemade/following{/other_user}","gists_url":"https://api.github.com/users/pnemade/gists{/gist_id}","starred_url":"https://api.github.com/users/pnemade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnemade/subscriptions","organizations_url":"https://api.github.com/users/pnemade/orgs","repos_url":"https://api.github.com/users/pnemade/repos","events_url":"https://api.github.com/users/pnemade/events{/privacy}","received_events_url":"https://api.github.com/users/pnemade/received_events","type":"User","site_admin":false},"body":"This PR will address following changes\r\n1) There is no information in spec file about how one can generate a tarball from the given git revision. Please add that like\r\nThe Source0 tarball can be generated using following commands:\r\ngit clone http://github.com/rpm-software-management/dnf.git\r\ncd dnf\r\ngit archive --format=tar %%{gitrev} | xz -z --force - > dnf-%%{gitrev}.tar.xz\r\n\r\n2) We have few packaging guidelines been in use now by many existing packages as well as new packages contributed in Fedora.\r\na) Remove Group tag it is optional and can be removed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag\r\nb) in %install we don't need following now\r\nrm -rf $RPM_BUILD_ROOT\r\nSee http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean\r\nc) Good to have all the %global definition macro at top of the spec file","created_at":"2015-01-19T13:11:24Z","updated_at":"2015-01-19T13:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/196/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/bc18056a2e70eb23a36cc4f5e9d25173f6898c39","head":{"label":"pnemade:master","ref":"master","sha":"bc18056a2e70eb23a36cc4f5e9d25173f6898c39","user":{"login":"pnemade","id":671366,"avatar_url":"https://avatars.githubusercontent.com/u/671366?v=3","gravatar_id":"","url":"https://api.github.com/users/pnemade","html_url":"https://github.com/pnemade","followers_url":"https://api.github.com/users/pnemade/followers","following_url":"https://api.github.com/users/pnemade/following{/other_user}","gists_url":"https://api.github.com/users/pnemade/gists{/gist_id}","starred_url":"https://api.github.com/users/pnemade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnemade/subscriptions","organizations_url":"https://api.github.com/users/pnemade/orgs","repos_url":"https://api.github.com/users/pnemade/repos","events_url":"https://api.github.com/users/pnemade/events{/privacy}","received_events_url":"https://api.github.com/users/pnemade/received_events","type":"User","site_admin":false},"repo":{"id":29471061,"name":"dnf","full_name":"pnemade/dnf","owner":{"login":"pnemade","id":671366,"avatar_url":"https://avatars.githubusercontent.com/u/671366?v=3","gravatar_id":"","url":"https://api.github.com/users/pnemade","html_url":"https://github.com/pnemade","followers_url":"https://api.github.com/users/pnemade/followers","following_url":"https://api.github.com/users/pnemade/following{/other_user}","gists_url":"https://api.github.com/users/pnemade/gists{/gist_id}","starred_url":"https://api.github.com/users/pnemade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnemade/subscriptions","organizations_url":"https://api.github.com/users/pnemade/orgs","repos_url":"https://api.github.com/users/pnemade/repos","events_url":"https://api.github.com/users/pnemade/events{/privacy}","received_events_url":"https://api.github.com/users/pnemade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnemade/dnf","description":"dnf is a package manager based on yum and libsolv","fork":true,"url":"https://api.github.com/repos/pnemade/dnf","forks_url":"https://api.github.com/repos/pnemade/dnf/forks","keys_url":"https://api.github.com/repos/pnemade/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnemade/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnemade/dnf/teams","hooks_url":"https://api.github.com/repos/pnemade/dnf/hooks","issue_events_url":"https://api.github.com/repos/pnemade/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/pnemade/dnf/events","assignees_url":"https://api.github.com/repos/pnemade/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/pnemade/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/pnemade/dnf/tags","blobs_url":"https://api.github.com/repos/pnemade/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnemade/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnemade/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnemade/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnemade/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/pnemade/dnf/languages","stargazers_url":"https://api.github.com/repos/pnemade/dnf/stargazers","contributors_url":"https://api.github.com/repos/pnemade/dnf/contributors","subscribers_url":"https://api.github.com/repos/pnemade/dnf/subscribers","subscription_url":"https://api.github.com/repos/pnemade/dnf/subscription","commits_url":"https://api.github.com/repos/pnemade/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnemade/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnemade/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnemade/dnf/issues/comments/{number}","contents_url":"https://api.github.com/repos/pnemade/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/pnemade/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnemade/dnf/merges","archive_url":"https://api.github.com/repos/pnemade/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnemade/dnf/downloads","issues_url":"https://api.github.com/repos/pnemade/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/pnemade/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/pnemade/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/pnemade/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnemade/dnf/labels{/name}","releases_url":"https://api.github.com/repos/pnemade/dnf/releases{/id}","created_at":"2015-01-19T13:01:15Z","updated_at":"2015-01-19T13:09:11Z","pushed_at":"2015-01-19T13:09:11Z","git_url":"git://github.com/pnemade/dnf.git","ssh_url":"git@github.com:pnemade/dnf.git","clone_url":"https://github.com/pnemade/dnf.git","svn_url":"https://github.com/pnemade/dnf","homepage":"","size":38109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"206099c5c3b552fb4c09ea62593e3b5173b5c227","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":3671909,"name":"dnf","full_name":"rpm-software-management/dnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/dnf","description":"dnf is a package manager based on yum and libsolv","fork":false,"url":"https://api.github.com/repos/rpm-software-management/dnf","forks_url":"https://api.github.com/repos/rpm-software-management/dnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/dnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/dnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/dnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/dnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/dnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/dnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/dnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/dnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/dnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/comments/{number}","contents_url":"https://api.github.com/repos/rpm-software-management/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/dnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/dnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/dnf/releases{/id}","created_at":"2012-03-09T15:31:09Z","updated_at":"2015-01-15T20:43:19Z","pushed_at":"2015-01-15T20:43:19Z","git_url":"git://github.com/rpm-software-management/dnf.git","ssh_url":"git@github.com:rpm-software-management/dnf.git","clone_url":"https://github.com/rpm-software-management/dnf.git","svn_url":"https://github.com/rpm-software-management/dnf","homepage":"","size":38109,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":8,"forks":39,"open_issues":8,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/196"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/196"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/dnf/statuses/bc18056a2e70eb23a36cc4f5e9d25173f6898c39"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":7,"changed_files":1}}