{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/22770271","id":22770271,"diff_hunk":"@@ -29,6 +29,19 @@\n #include <vector>\n #include <list>\n \n+namespace WorldPackets\n+{\n+    namespace Loot\n+    {\n+        class LootResponse;\n+    }\n+\n+    namespace Item\n+    {\n+        class ItemInstance;","path":"src/server/game/Loot/LootMgr.h","position":13,"original_position":13,"commit_id":"4e716543c48d2d5f35dd419316d57f3d9fdee66a","original_commit_id":"4e716543c48d2d5f35dd419316d57f3d9fdee66a","user":{"login":"cemak","id":305634,"avatar_url":"https://avatars.githubusercontent.com/u/305634?v=3","gravatar_id":"","url":"https://api.github.com/users/cemak","html_url":"https://github.com/cemak","followers_url":"https://api.github.com/users/cemak/followers","following_url":"https://api.github.com/users/cemak/following{/other_user}","gists_url":"https://api.github.com/users/cemak/gists{/gist_id}","starred_url":"https://api.github.com/users/cemak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cemak/subscriptions","organizations_url":"https://api.github.com/users/cemak/orgs","repos_url":"https://api.github.com/users/cemak/repos","events_url":"https://api.github.com/users/cemak/events{/privacy}","received_events_url":"https://api.github.com/users/cemak/received_events","type":"User","site_admin":false},"body":"warning C4099","created_at":"2015-01-11T21:32:01Z","updated_at":"2015-01-11T21:32:01Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/13817#discussion_r22770271","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/22770271"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13817#discussion_r22770271"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817","id":26669265,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/13817","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/13817.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/13817.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13817","number":13817,"state":"open","locked":false,"title":"[WIP] Loot System","user":{"login":"Intel","id":326232,"avatar_url":"https://avatars.githubusercontent.com/u/326232?v=3","gravatar_id":"","url":"https://api.github.com/users/Intel","html_url":"https://github.com/Intel","followers_url":"https://api.github.com/users/Intel/followers","following_url":"https://api.github.com/users/Intel/following{/other_user}","gists_url":"https://api.github.com/users/Intel/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel/subscriptions","organizations_url":"https://api.github.com/users/Intel/orgs","repos_url":"https://api.github.com/users/Intel/repos","events_url":"https://api.github.com/users/Intel/events{/privacy}","received_events_url":"https://api.github.com/users/Intel/received_events","type":"User","site_admin":false},"body":"Creating this PR for the loot system update. Currently all loot is tied to an entity (Loot class as an entity member) but blizz started using HighGuid::LootObject and all loot packets come with it. So it would make sense to split all loot into it's own container and lookup by loot guid. Also current loot system does not support currencies.\r\n\r\nThis commit enables basic looting functions and it could be merged as is but it may get complicated with this old system in the future. I hope to get some input on this.","created_at":"2014-12-30T00:43:45Z","updated_at":"2015-01-11T21:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1d95251834c0dfbb8e844807d67cd472811f531","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13817/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/4e716543c48d2d5f35dd419316d57f3d9fdee66a","head":{"label":"Intel:loot","ref":"loot","sha":"4e716543c48d2d5f35dd419316d57f3d9fdee66a","user":{"login":"Intel","id":326232,"avatar_url":"https://avatars.githubusercontent.com/u/326232?v=3","gravatar_id":"","url":"https://api.github.com/users/Intel","html_url":"https://github.com/Intel","followers_url":"https://api.github.com/users/Intel/followers","following_url":"https://api.github.com/users/Intel/following{/other_user}","gists_url":"https://api.github.com/users/Intel/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel/subscriptions","organizations_url":"https://api.github.com/users/Intel/orgs","repos_url":"https://api.github.com/users/Intel/repos","events_url":"https://api.github.com/users/Intel/events{/privacy}","received_events_url":"https://api.github.com/users/Intel/received_events","type":"User","site_admin":false},"repo":{"id":26719632,"name":"TrinityCore","full_name":"Intel/TrinityCore","owner":{"login":"Intel","id":326232,"avatar_url":"https://avatars.githubusercontent.com/u/326232?v=3","gravatar_id":"","url":"https://api.github.com/users/Intel","html_url":"https://github.com/Intel","followers_url":"https://api.github.com/users/Intel/followers","following_url":"https://api.github.com/users/Intel/following{/other_user}","gists_url":"https://api.github.com/users/Intel/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel/subscriptions","organizations_url":"https://api.github.com/users/Intel/orgs","repos_url":"https://api.github.com/users/Intel/repos","events_url":"https://api.github.com/users/Intel/events{/privacy}","received_events_url":"https://api.github.com/users/Intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Intel/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Intel/TrinityCore","forks_url":"https://api.github.com/repos/Intel/TrinityCore/forks","keys_url":"https://api.github.com/repos/Intel/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Intel/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Intel/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Intel/TrinityCore/events","assignees_url":"https://api.github.com/repos/Intel/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Intel/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Intel/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Intel/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Intel/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Intel/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Intel/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Intel/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Intel/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/Intel/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Intel/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel/TrinityCore/merges","archive_url":"https://api.github.com/repos/Intel/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Intel/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Intel/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Intel/TrinityCore/releases{/id}","created_at":"2014-11-16T16:16:19Z","updated_at":"2014-12-30T00:24:23Z","pushed_at":"2014-12-30T00:34:45Z","git_url":"git://github.com/Intel/TrinityCore.git","ssh_url":"git@github.com:Intel/TrinityCore.git","clone_url":"https://github.com/Intel/TrinityCore.git","svn_url":"https://github.com/Intel/TrinityCore","homepage":"http://www.trinitycore.org","size":287701,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:6.x","ref":"6.x","sha":"1f7e6a976d345204f7ff123e2eda51a719d25d2e","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/{number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-01-11T20:18:06Z","pushed_at":"2015-01-11T19:43:15Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":734439,"stargazers_count":2693,"watchers_count":2693,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2747,"mirror_url":null,"open_issues_count":1328,"forks":2747,"open_issues":1328,"watchers":2693,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/13817"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13817"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/13817/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/13817/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/4e716543c48d2d5f35dd419316d57f3d9fdee66a"}}}}