{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2365","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2365/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2365/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2365/events","html_url":"https://github.com/LMMS/lmms/issues/2365","id":107509140,"number":2365,"title":"Misleading version information","user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars.githubusercontent.com/u/6345473?v=3","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-21T13:16:42Z","updated_at":"2015-09-21T13:39:04Z","closed_at":null,"body":"Currently, if someone grabs the master branch, they build LMMS and it will be labeled in respect to the version information in `/CMakeLists.txt`, which currently is `1.1.3`.\r\n\r\nThis is misleading because most developers will build from `master` when developing a new feature and any binaries released will bear the stable version number in the dialogs.\r\n\r\nShould we try to leverage git in the build process to detect a non-stable build?  If so, how should we do the numbering for a non-stable build?\r\n\r\nMy thought is to take a \"nightly\" approach:\r\n\r\n```\r\n   VERSION_MAJOR       \"2015\"\r\n   VERSION_MINOR       \"09\"\r\n   VERSION_PATCH       \"21\"\r\n```\r\n\r\nThis would be done by checking the origin of the `git remote` and if it is not `/lmms/lmms` and does not contain the word `stable` in the branch name, use the above versioning.\r\n\r\nThe biggest downside is that this may have some unintended side-effects when comparing stuff like `ProjectVersion` which uses version_major, etc inside the code for compat code and project and config file upgrades.  Thoughts?"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/141981239","html_url":"https://github.com/LMMS/lmms/issues/2365#issuecomment-141981239","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2365","id":141981239,"user":{"login":"musikBear","id":6662066,"avatar_url":"https://avatars.githubusercontent.com/u/6662066?v=3","gravatar_id":"","url":"https://api.github.com/users/musikBear","html_url":"https://github.com/musikBear","followers_url":"https://api.github.com/users/musikBear/followers","following_url":"https://api.github.com/users/musikBear/following{/other_user}","gists_url":"https://api.github.com/users/musikBear/gists{/gist_id}","starred_url":"https://api.github.com/users/musikBear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musikBear/subscriptions","organizations_url":"https://api.github.com/users/musikBear/orgs","repos_url":"https://api.github.com/users/musikBear/repos","events_url":"https://api.github.com/users/musikBear/events{/privacy}","received_events_url":"https://api.github.com/users/musikBear/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T13:39:04Z","updated_at":"2015-09-21T13:39:04Z","body":">  Thoughts?\r\n\r\nOnly that i highly applause this initiative :+ \r\nVersion control is SO important, and i have been confused a couple of times \r\nbut\r\nVERSION_MINOR       \"09\"\r\ncouldent date and perhap even timestamp be a part too?\r\nlike\r\nVERSION_MINOR       \"09_21_15:42\""}}