{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/569","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/569/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/569/events","html_url":"https://github.com/mixxxdj/mixxx/pull/569","id":71072272,"number":569,"title":"Fix coverity warnings for new SoundSources","user":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars.githubusercontent.com/u/1474154?v=3","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-26T14:00:40Z","updated_at":"2015-04-27T13:54:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/569","html_url":"https://github.com/mixxxdj/mixxx/pull/569","diff_url":"https://github.com/mixxxdj/mixxx/pull/569.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/569.patch"},"body":"Try to fix some minor Coverity warnings for 2 SoundSources by moving the initialization from tryOpen() into the constructor.\r\n\r\nFor details please refer to the individual commit messages that contain the Coverity warnings."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/96660618","html_url":"https://github.com/mixxxdj/mixxx/pull/569#issuecomment-96660618","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/569","id":96660618,"user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T13:54:01Z","updated_at":"2015-04-27T13:54:01Z","body":"If you do the equivalent of what tryOpen does (i.e. call the _init methods) then when the SoundSource is opened it will first be closed which clears them -- so it should be matched pairs of init/close if you do it that way (we were calling a close without a corresponding init before)."}}