{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/15848","labels_url":"https://api.github.com/repos/owncloud/core/issues/15848/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/15848/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/15848/events","html_url":"https://github.com/owncloud/core/issues/15848","id":70525989,"number":15848,"title":"[master] Encryption wrapper makes all storages it wraps non-local","user":{"login":"VicDeo","id":991300,"avatar_url":"https://avatars.githubusercontent.com/u/991300?v=3","gravatar_id":"","url":"https://api.github.com/users/VicDeo","html_url":"https://github.com/VicDeo","followers_url":"https://api.github.com/users/VicDeo/followers","following_url":"https://api.github.com/users/VicDeo/following{/other_user}","gists_url":"https://api.github.com/users/VicDeo/gists{/gist_id}","starred_url":"https://api.github.com/users/VicDeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VicDeo/subscriptions","organizations_url":"https://api.github.com/users/VicDeo/orgs","repos_url":"https://api.github.com/users/VicDeo/repos","events_url":"https://api.github.com/users/VicDeo/events{/privacy}","received_events_url":"https://api.github.com/users/VicDeo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","html_url":"https://github.com/owncloud/core/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":155,"closed_issues":890,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-04-27T08:30:39Z","due_on":"2015-04-02T22:00:00Z","closed_at":null},"comments":11,"created_at":"2015-04-23T22:14:00Z","updated_at":"2015-04-27T09:08:11Z","closed_at":null,"body":"and as soon as it wraps user home by default we end up with non-local storages only, that is definitely makes no sense (and brokes all actions that should be applied to local files only by using `Storage::isLocal` call )\r\n\r\nhttps://github.com/owncloud/core/blob/master/lib/private/files/storage/wrapper/encryption.php#L345 : \r\n\r\n```\r\n\t/**\r\n\t * Returns the wrapped storage's value for isLocal()\r\n\t *\r\n\t * @return bool wrapped storage's isLocal() value\r\n\t */\r\n\tpublic function isLocal() {\r\n\t\treturn false;\r\n\t}\r\n```\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/96576866","html_url":"https://github.com/owncloud/core/issues/15848#issuecomment-96576866","issue_url":"https://api.github.com/repos/owncloud/core/issues/15848","id":96576866,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T09:08:11Z","updated_at":"2015-04-27T09:08:11Z","body":"Ok one thing I just remembered: the encryption wrapper is always there even when encryption isn't enabled. This means that `isLocal()` needs to check whether the encryption module is enabled for the underlying storage. If it's not, then call `return $this->storage->isLocal()`. If encryption is enabled, then `return false'."}}