{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/49","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/49/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/49/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/49","id":100370732,"number":49,"title":"Redo article transitions to work inside a `UINavigationController`","user":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-11T18:01:45Z","updated_at":"2015-08-11T19:45:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/49","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/49","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/49.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/49.patch"},"body":"Bug: [T106152](https://phabricator.wikimedia.org/T106152)\r\n\r\n_explanation & visual aids forthcoming..._"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/130040079","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/49#issuecomment-130040079","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/49","id":130040079,"user":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"created_at":"2015-08-11T19:45:27Z","updated_at":"2015-08-11T19:45:27Z","body":"> - Pushing article containers VC in the nav stack. and vending transitions for the root nav controller\r\n> - Moving popups to be based on navigation transition \r\n\r\nThese two can't really be separated as the custom transitions needed to be modified to work with a navigation controller .\r\n\r\n> - Refactoring the container VC architecture.\r\n\r\nI can look into separating this out, but at this point it would probably be easier to just revert if this setup isn't satisfactory.\r\n\r\n> Additionally the web link stuff was fixed somewhere in here… by some combination of these changes (but not exactly clear how/where - just basically architecture changes and hooking things up it seems)\r\n\r\nIn a nutshell, the webview was delegating to the article, who tried to present another article modally, even though its view wasn't in the hiearchy:\r\n\r\n```\r\nContainer:\r\n  -> ArticleVC -x-> ArticleVC\r\n    -> WebView\r\n```\r\n\r\nIMO fixing this by asking the article to ask the container to present another article is hacky.  Better to have webview delegate to the container (just as the articleVC now does) so the container can own both article<->web transitions and pushing new content onto the stack.\r\n\r\n> Are there other large fixes here that I missed? If so can you list them out?\r\n\r\nIt's intermingled w/ the \"making transitions work in a navigation controller,\" but the ability to start transitions w/o being at the top of the view.\r\n\r\n> If this sounds about right, it would be good to split this up into 3 pull requests so we can address each of these concerns individually. \r\n\r\nLet's talk when you get back. I can either amend or revert the article container architecture (i.e. try putting back the internal navigation controller)\r\n\r\n> Also it would be nice to explain exactly what was broken about the web link stuff and how this fixes it (it seems it was mostly a matter of hooking things up through delegation, but maybe there is more to it)\r\n\r\nSee above"}}