{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments/26136108","id":26136108,"diff_hunk":"@@ -26,7 +26,7 @@\n     /* Location constructor requires a named origin, these are created in the app. */\n     public static final String LOCATION_ORIGIN_INTERNAL = \"internal\";\n     /* In passive mode, only scan this many times for each gps. */\n-    public static final int PASSIVE_MODE_MAX_SCANS_PER_GPS = 3;\n+    public static final int PASSIVE_MODE_MAX_SCANS_PER_GPS = 2;","path":"libraries/stumbler/src/main/java/org/mozilla/mozstumbler/service/AppGlobals.java","position":5,"original_position":5,"commit_id":"0eb7d80e09c60534ba00b9a7d49da506872cf2f8","original_commit_id":"0eb7d80e09c60534ba00b9a7d49da506872cf2f8","user":{"login":"garvankeeley","id":5495083,"avatar_url":"https://avatars.githubusercontent.com/u/5495083?v=3","gravatar_id":"","url":"https://api.github.com/users/garvankeeley","html_url":"https://github.com/garvankeeley","followers_url":"https://api.github.com/users/garvankeeley/followers","following_url":"https://api.github.com/users/garvankeeley/following{/other_user}","gists_url":"https://api.github.com/users/garvankeeley/gists{/gist_id}","starred_url":"https://api.github.com/users/garvankeeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garvankeeley/subscriptions","organizations_url":"https://api.github.com/users/garvankeeley/orgs","repos_url":"https://api.github.com/users/garvankeeley/repos","events_url":"https://api.github.com/users/garvankeeley/events{/privacy}","received_events_url":"https://api.github.com/users/garvankeeley/received_events","type":"User","site_admin":false},"body":"Agreed","created_at":"2015-03-10T16:08:59Z","updated_at":"2015-03-10T16:08:59Z","html_url":"https://github.com/mozilla/MozStumbler/pull/1546#discussion_r26136108","pull_request_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546","_links":{"self":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments/26136108"},"html":{"href":"https://github.com/mozilla/MozStumbler/pull/1546#discussion_r26136108"},"pull_request":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546","id":30725068,"html_url":"https://github.com/mozilla/MozStumbler/pull/1546","diff_url":"https://github.com/mozilla/MozStumbler/pull/1546.diff","patch_url":"https://github.com/mozilla/MozStumbler/pull/1546.patch","issue_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1546","number":1546,"state":"open","locked":false,"title":"Fixes to passive scanning mode","user":{"login":"cascheberg","id":3845150,"avatar_url":"https://avatars.githubusercontent.com/u/3845150?v=3","gravatar_id":"","url":"https://api.github.com/users/cascheberg","html_url":"https://github.com/cascheberg","followers_url":"https://api.github.com/users/cascheberg/followers","following_url":"https://api.github.com/users/cascheberg/following{/other_user}","gists_url":"https://api.github.com/users/cascheberg/gists{/gist_id}","starred_url":"https://api.github.com/users/cascheberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cascheberg/subscriptions","organizations_url":"https://api.github.com/users/cascheberg/orgs","repos_url":"https://api.github.com/users/cascheberg/repos","events_url":"https://api.github.com/users/cascheberg/events{/privacy}","received_events_url":"https://api.github.com/users/cascheberg/received_events","type":"User","site_admin":false},"body":"I found some issues in passive scanning mode:\r\n- number of passive scans per location was always one too many because of post increment\r\n- the scanners always needed to be stopped even if a new position was reported instantly\r\n- scanner data was flushed after 10 seconds while wifi scanning continued (3 * 5 sec = 15 sec). So I decreased `MAX_SCANS_PER_GPS` and `WIFI_MIN_UPDATE_TIME` to fit into one interval, which should also increase data accuracy\r\n\r\nI learned that changes to the library code are especially critical, so I'm awaiting comments.","created_at":"2015-03-08T19:40:44Z","updated_at":"2015-03-10T16:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ed1378ab843820eb0093cc4fb628ca849a197c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546/commits","review_comments_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546/comments","review_comment_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/1546/comments","statuses_url":"https://api.github.com/repos/mozilla/MozStumbler/statuses/0eb7d80e09c60534ba00b9a7d49da506872cf2f8","head":{"label":"cascheberg:fix-passive-scanning","ref":"fix-passive-scanning","sha":"0eb7d80e09c60534ba00b9a7d49da506872cf2f8","user":{"login":"cascheberg","id":3845150,"avatar_url":"https://avatars.githubusercontent.com/u/3845150?v=3","gravatar_id":"","url":"https://api.github.com/users/cascheberg","html_url":"https://github.com/cascheberg","followers_url":"https://api.github.com/users/cascheberg/followers","following_url":"https://api.github.com/users/cascheberg/following{/other_user}","gists_url":"https://api.github.com/users/cascheberg/gists{/gist_id}","starred_url":"https://api.github.com/users/cascheberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cascheberg/subscriptions","organizations_url":"https://api.github.com/users/cascheberg/orgs","repos_url":"https://api.github.com/users/cascheberg/repos","events_url":"https://api.github.com/users/cascheberg/events{/privacy}","received_events_url":"https://api.github.com/users/cascheberg/received_events","type":"User","site_admin":false},"repo":{"id":24945786,"name":"MozStumbler","full_name":"cascheberg/MozStumbler","owner":{"login":"cascheberg","id":3845150,"avatar_url":"https://avatars.githubusercontent.com/u/3845150?v=3","gravatar_id":"","url":"https://api.github.com/users/cascheberg","html_url":"https://github.com/cascheberg","followers_url":"https://api.github.com/users/cascheberg/followers","following_url":"https://api.github.com/users/cascheberg/following{/other_user}","gists_url":"https://api.github.com/users/cascheberg/gists{/gist_id}","starred_url":"https://api.github.com/users/cascheberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cascheberg/subscriptions","organizations_url":"https://api.github.com/users/cascheberg/orgs","repos_url":"https://api.github.com/users/cascheberg/repos","events_url":"https://api.github.com/users/cascheberg/events{/privacy}","received_events_url":"https://api.github.com/users/cascheberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cascheberg/MozStumbler","description":"Android Stumbler for Mozilla","fork":true,"url":"https://api.github.com/repos/cascheberg/MozStumbler","forks_url":"https://api.github.com/repos/cascheberg/MozStumbler/forks","keys_url":"https://api.github.com/repos/cascheberg/MozStumbler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cascheberg/MozStumbler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cascheberg/MozStumbler/teams","hooks_url":"https://api.github.com/repos/cascheberg/MozStumbler/hooks","issue_events_url":"https://api.github.com/repos/cascheberg/MozStumbler/issues/events{/number}","events_url":"https://api.github.com/repos/cascheberg/MozStumbler/events","assignees_url":"https://api.github.com/repos/cascheberg/MozStumbler/assignees{/user}","branches_url":"https://api.github.com/repos/cascheberg/MozStumbler/branches{/branch}","tags_url":"https://api.github.com/repos/cascheberg/MozStumbler/tags","blobs_url":"https://api.github.com/repos/cascheberg/MozStumbler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cascheberg/MozStumbler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cascheberg/MozStumbler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cascheberg/MozStumbler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cascheberg/MozStumbler/statuses/{sha}","languages_url":"https://api.github.com/repos/cascheberg/MozStumbler/languages","stargazers_url":"https://api.github.com/repos/cascheberg/MozStumbler/stargazers","contributors_url":"https://api.github.com/repos/cascheberg/MozStumbler/contributors","subscribers_url":"https://api.github.com/repos/cascheberg/MozStumbler/subscribers","subscription_url":"https://api.github.com/repos/cascheberg/MozStumbler/subscription","commits_url":"https://api.github.com/repos/cascheberg/MozStumbler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cascheberg/MozStumbler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cascheberg/MozStumbler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cascheberg/MozStumbler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cascheberg/MozStumbler/contents/{+path}","compare_url":"https://api.github.com/repos/cascheberg/MozStumbler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cascheberg/MozStumbler/merges","archive_url":"https://api.github.com/repos/cascheberg/MozStumbler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cascheberg/MozStumbler/downloads","issues_url":"https://api.github.com/repos/cascheberg/MozStumbler/issues{/number}","pulls_url":"https://api.github.com/repos/cascheberg/MozStumbler/pulls{/number}","milestones_url":"https://api.github.com/repos/cascheberg/MozStumbler/milestones{/number}","notifications_url":"https://api.github.com/repos/cascheberg/MozStumbler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cascheberg/MozStumbler/labels{/name}","releases_url":"https://api.github.com/repos/cascheberg/MozStumbler/releases{/id}","created_at":"2014-10-08T14:58:06Z","updated_at":"2015-03-07T19:40:10Z","pushed_at":"2015-03-08T20:26:23Z","git_url":"git://github.com/cascheberg/MozStumbler.git","ssh_url":"git@github.com:cascheberg/MozStumbler.git","clone_url":"https://github.com/cascheberg/MozStumbler.git","svn_url":"https://github.com/cascheberg/MozStumbler","homepage":"http://location.services.mozilla.com","size":7652,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mozilla:dev","ref":"dev","sha":"bed3969ecb9ab8fffeefc6804501fb88dcce0643","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11164718,"name":"MozStumbler","full_name":"mozilla/MozStumbler","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/MozStumbler","description":"Android Stumbler for Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla/MozStumbler","forks_url":"https://api.github.com/repos/mozilla/MozStumbler/forks","keys_url":"https://api.github.com/repos/mozilla/MozStumbler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/MozStumbler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/MozStumbler/teams","hooks_url":"https://api.github.com/repos/mozilla/MozStumbler/hooks","issue_events_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/MozStumbler/events","assignees_url":"https://api.github.com/repos/mozilla/MozStumbler/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/MozStumbler/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/MozStumbler/tags","blobs_url":"https://api.github.com/repos/mozilla/MozStumbler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/MozStumbler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/MozStumbler/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/MozStumbler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/MozStumbler/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/MozStumbler/languages","stargazers_url":"https://api.github.com/repos/mozilla/MozStumbler/stargazers","contributors_url":"https://api.github.com/repos/mozilla/MozStumbler/contributors","subscribers_url":"https://api.github.com/repos/mozilla/MozStumbler/subscribers","subscription_url":"https://api.github.com/repos/mozilla/MozStumbler/subscription","commits_url":"https://api.github.com/repos/mozilla/MozStumbler/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/MozStumbler/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/MozStumbler/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/MozStumbler/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/MozStumbler/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/MozStumbler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/MozStumbler/merges","archive_url":"https://api.github.com/repos/mozilla/MozStumbler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/MozStumbler/downloads","issues_url":"https://api.github.com/repos/mozilla/MozStumbler/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/MozStumbler/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/MozStumbler/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/MozStumbler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/MozStumbler/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/MozStumbler/releases{/id}","created_at":"2013-07-04T01:22:30Z","updated_at":"2015-03-10T14:54:06Z","pushed_at":"2015-03-10T14:54:06Z","git_url":"git://github.com/mozilla/MozStumbler.git","ssh_url":"git@github.com:mozilla/MozStumbler.git","clone_url":"https://github.com/mozilla/MozStumbler.git","svn_url":"https://github.com/mozilla/MozStumbler","homepage":"http://location.services.mozilla.com","size":14789,"stargazers_count":426,"watchers_count":426,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":177,"forks":165,"open_issues":177,"watchers":426,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546"},"html":{"href":"https://github.com/mozilla/MozStumbler/pull/1546"},"issue":{"href":"https://api.github.com/repos/mozilla/MozStumbler/issues/1546"},"comments":{"href":"https://api.github.com/repos/mozilla/MozStumbler/issues/1546/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/MozStumbler/pulls/1546/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/MozStumbler/statuses/0eb7d80e09c60534ba00b9a7d49da506872cf2f8"}}}}