{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/40731989","id":40731989,"diff_hunk":"@@ -43,6 +44,30 @@ export default function buildComponentTemplate({ component, layout, isAngleBrack\n   return { createdElement: !!tagName, block: blockToRender };\n }\n \n+function canChangeTypeAfterRender(attrs) {\n+  // This permits testing of the unbound type attr behavior outside of IE8.\n+  if (attrs.ie8SafeInput) {\n+    return false;\n+  }\n+  var mutableInputTypeTextElement, docFragment;\n+  if (!docFragment) {","path":"packages/ember-views/lib/system/build-component-template.js","position":20,"original_position":20,"commit_id":"dd5745272ef743a39415ae65f90dcb29e5d75e20","original_commit_id":"dd5745272ef743a39415ae65f90dcb29e5d75e20","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"When can this be truthy?  Seems like it can only ever be `undefined`.  Why not initialize `docFragment` and `mutableInputTypeTextElement` upon declaration?","created_at":"2015-09-29T21:25:22Z","updated_at":"2015-09-29T21:25:22Z","html_url":"https://github.com/emberjs/ember.js/pull/12351#discussion_r40731989","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12351","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/40731989"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12351#discussion_r40731989"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12351"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12351","id":45126380,"html_url":"https://github.com/emberjs/ember.js/pull/12351","diff_url":"https://github.com/emberjs/ember.js/pull/12351.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12351.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12351","number":12351,"state":"open","locked":false,"title":"[BUGFIX release-1-13] Make type attr on inputs immutable for IE8","user":{"login":"xcskier56","id":2357871,"avatar_url":"https://avatars.githubusercontent.com/u/2357871?v=3","gravatar_id":"","url":"https://api.github.com/users/xcskier56","html_url":"https://github.com/xcskier56","followers_url":"https://api.github.com/users/xcskier56/followers","following_url":"https://api.github.com/users/xcskier56/following{/other_user}","gists_url":"https://api.github.com/users/xcskier56/gists{/gist_id}","starred_url":"https://api.github.com/users/xcskier56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcskier56/subscriptions","organizations_url":"https://api.github.com/users/xcskier56/orgs","repos_url":"https://api.github.com/users/xcskier56/repos","events_url":"https://api.github.com/users/xcskier56/events{/privacy}","received_events_url":"https://api.github.com/users/xcskier56/received_events","type":"User","site_admin":false},"body":"This fixes #11553 and #12295 as well as https://github.com/tildeio/htmlbars/issues/380. This works by detecting if the browser can change the type attr on an input after it has been appended to a node, and then if it cannot, unbinding the type attr so that it is set on the input immediately before being appended to a node.","created_at":"2015-09-16T02:59:39Z","updated_at":"2015-09-29T21:25:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3bd44c0c4d41b9ebbead2470c856dae9ca2af1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12351/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12351/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12351/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/dd5745272ef743a39415ae65f90dcb29e5d75e20","head":{"label":"xcskier56:release-1-13","ref":"release-1-13","sha":"dd5745272ef743a39415ae65f90dcb29e5d75e20","user":{"login":"xcskier56","id":2357871,"avatar_url":"https://avatars.githubusercontent.com/u/2357871?v=3","gravatar_id":"","url":"https://api.github.com/users/xcskier56","html_url":"https://github.com/xcskier56","followers_url":"https://api.github.com/users/xcskier56/followers","following_url":"https://api.github.com/users/xcskier56/following{/other_user}","gists_url":"https://api.github.com/users/xcskier56/gists{/gist_id}","starred_url":"https://api.github.com/users/xcskier56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcskier56/subscriptions","organizations_url":"https://api.github.com/users/xcskier56/orgs","repos_url":"https://api.github.com/users/xcskier56/repos","events_url":"https://api.github.com/users/xcskier56/events{/privacy}","received_events_url":"https://api.github.com/users/xcskier56/received_events","type":"User","site_admin":false},"repo":{"id":42334189,"name":"ember.js","full_name":"xcskier56/ember.js","owner":{"login":"xcskier56","id":2357871,"avatar_url":"https://avatars.githubusercontent.com/u/2357871?v=3","gravatar_id":"","url":"https://api.github.com/users/xcskier56","html_url":"https://github.com/xcskier56","followers_url":"https://api.github.com/users/xcskier56/followers","following_url":"https://api.github.com/users/xcskier56/following{/other_user}","gists_url":"https://api.github.com/users/xcskier56/gists{/gist_id}","starred_url":"https://api.github.com/users/xcskier56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcskier56/subscriptions","organizations_url":"https://api.github.com/users/xcskier56/orgs","repos_url":"https://api.github.com/users/xcskier56/repos","events_url":"https://api.github.com/users/xcskier56/events{/privacy}","received_events_url":"https://api.github.com/users/xcskier56/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xcskier56/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/xcskier56/ember.js","forks_url":"https://api.github.com/repos/xcskier56/ember.js/forks","keys_url":"https://api.github.com/repos/xcskier56/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcskier56/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcskier56/ember.js/teams","hooks_url":"https://api.github.com/repos/xcskier56/ember.js/hooks","issue_events_url":"https://api.github.com/repos/xcskier56/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/xcskier56/ember.js/events","assignees_url":"https://api.github.com/repos/xcskier56/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/xcskier56/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/xcskier56/ember.js/tags","blobs_url":"https://api.github.com/repos/xcskier56/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcskier56/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcskier56/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcskier56/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcskier56/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/xcskier56/ember.js/languages","stargazers_url":"https://api.github.com/repos/xcskier56/ember.js/stargazers","contributors_url":"https://api.github.com/repos/xcskier56/ember.js/contributors","subscribers_url":"https://api.github.com/repos/xcskier56/ember.js/subscribers","subscription_url":"https://api.github.com/repos/xcskier56/ember.js/subscription","commits_url":"https://api.github.com/repos/xcskier56/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcskier56/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcskier56/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcskier56/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcskier56/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/xcskier56/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcskier56/ember.js/merges","archive_url":"https://api.github.com/repos/xcskier56/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcskier56/ember.js/downloads","issues_url":"https://api.github.com/repos/xcskier56/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/xcskier56/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/xcskier56/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/xcskier56/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcskier56/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/xcskier56/ember.js/releases{/id}","created_at":"2015-09-11T21:59:20Z","updated_at":"2015-09-11T21:59:25Z","pushed_at":"2015-09-16T02:51:48Z","git_url":"git://github.com/xcskier56/ember.js.git","ssh_url":"git@github.com:xcskier56/ember.js.git","clone_url":"https://github.com/xcskier56/ember.js.git","svn_url":"https://github.com/xcskier56/ember.js","homepage":"http://www.emberjs.com","size":29879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:release-1-13","ref":"release-1-13","sha":"a527955889ec8fc133d2a473b1022e6e1b4bce9a","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","created_at":"2011-05-25T23:39:40Z","updated_at":"2015-09-29T18:28:14Z","pushed_at":"2015-09-29T21:13:12Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":91283,"stargazers_count":14818,"watchers_count":14818,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3172,"mirror_url":null,"open_issues_count":297,"forks":3172,"open_issues":297,"watchers":14818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12351"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12351"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12351"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12351/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12351/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12351/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/dd5745272ef743a39415ae65f90dcb29e5d75e20"}}}}