{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/comments/28067868","id":28067868,"diff_hunk":"@@ -9,7 +9,7 @@ SERVER_PORT=34343\n SECRET_KEY_BASE=FA11FA11FA11FA11FA11\n \n # Authentication setting\n-AUTHENTICATION_SITE_URL='http://localhost:3000'\n-AUTHENTICATION_REDIRECT_URI='http://localhost:4000/auth/defence_request/callback'\n-AUTHENTICATION_APPLICATION_ID='xxx'\n-AUTHENTICATION_APPLICATION_SECRET='xxx'\n+AUTHENTICATION_SITE_URL='http://localhost:45454'\n+AUTHENTICATION_REDIRECT_URI='http://localhost:34343/auth/defence_request/callback'\n+AUTHENTICATION_APPLICATION_ID=8d142261e79fd579777c83bba6deffb9dea9499e696b41c839d101718819a48794d6b359bd51eae94b47c04fc1","path":".env.development","position":10,"original_position":10,"commit_id":"3dcb734b8cabb78c7b475a5616d2e34a103ee782","original_commit_id":"3dcb734b8cabb78c7b475a5616d2e34a103ee782","user":{"login":"oskarpearson","id":129002,"avatar_url":"https://avatars.githubusercontent.com/u/129002?v=3","gravatar_id":"","url":"https://api.github.com/users/oskarpearson","html_url":"https://github.com/oskarpearson","followers_url":"https://api.github.com/users/oskarpearson/followers","following_url":"https://api.github.com/users/oskarpearson/following{/other_user}","gists_url":"https://api.github.com/users/oskarpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarpearson/subscriptions","organizations_url":"https://api.github.com/users/oskarpearson/orgs","repos_url":"https://api.github.com/users/oskarpearson/repos","events_url":"https://api.github.com/users/oskarpearson/events{/privacy}","received_events_url":"https://api.github.com/users/oskarpearson/received_events","type":"User","site_admin":false},"body":"A few things:\r\n\r\n1. Could we be consistent with quoting? Just makes things easier generally. You're welcome to remove all the quotes if you want.\r\n2. If the application IDs contain things that are not actual secrets, could we try and set them to something that's 'obviously wrong'? I did this with 'SECRET_KEY_BASE' above. So you could set it to something appropriate from https://reminiscential.wordpress.com/2008/09/03/hexspeak-word-list/ if it has to be hex. Or you could just set it to 'not-actually-a-valid-auth-secret', for example. That just reduces the chances of someone copy-and-pasting things into production incorrectly because they don't truly understand that it needs to be set to something unique.\r\n3. I didn't see a PR for the auth app that creates the matching secrets and application IDs? We need to make them match.\r\n4. In the auth app, the ID value is referred to as a 'uid' - so I've set the app IDs to a generated uuid. Not sure if we should be consistent with them.","created_at":"2015-04-09T14:46:30Z","updated_at":"2015-04-09T14:46:30Z","html_url":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21#discussion_r28067868","pull_request_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/comments/28067868"},"html":{"href":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21#discussion_r28067868"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21","id":32961449,"html_url":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21","diff_url":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21.diff","patch_url":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21.patch","issue_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/21","number":21,"state":"open","locked":false,"title":"Configure to allow login via auth app locally.","user":{"login":"robmckinnon","id":3447,"avatar_url":"https://avatars.githubusercontent.com/u/3447?v=3","gravatar_id":"","url":"https://api.github.com/users/robmckinnon","html_url":"https://github.com/robmckinnon","followers_url":"https://api.github.com/users/robmckinnon/followers","following_url":"https://api.github.com/users/robmckinnon/following{/other_user}","gists_url":"https://api.github.com/users/robmckinnon/gists{/gist_id}","starred_url":"https://api.github.com/users/robmckinnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmckinnon/subscriptions","organizations_url":"https://api.github.com/users/robmckinnon/orgs","repos_url":"https://api.github.com/users/robmckinnon/repos","events_url":"https://api.github.com/users/robmckinnon/events{/privacy}","received_events_url":"https://api.github.com/users/robmckinnon/received_events","type":"User","site_admin":false},"body":"* Change port numbers to match `.env.development` config in other repos.\r\n* Set application id and secret to match those set in auth app `.env.development`","created_at":"2015-04-09T14:36:19Z","updated_at":"2015-04-09T14:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb3cace58819fe244bf9ebe4e6f019805629802c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/21/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/statuses/3dcb734b8cabb78c7b475a5616d2e34a103ee782","head":{"label":"ministryofjustice:dev-ports","ref":"dev-ports","sha":"3dcb734b8cabb78c7b475a5616d2e34a103ee782","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":32456341,"name":"defence-request-service-rota","full_name":"ministryofjustice/defence-request-service-rota","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/defence-request-service-rota","description":"Defence Request Service - Rota Handling","fork":false,"url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota","forks_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/forks","keys_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/events","assignees_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/merges","archive_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/releases{/id}","created_at":"2015-03-18T12:04:23Z","updated_at":"2015-04-08T17:51:53Z","pushed_at":"2015-04-09T14:36:19Z","git_url":"git://github.com/ministryofjustice/defence-request-service-rota.git","ssh_url":"git@github.com:ministryofjustice/defence-request-service-rota.git","clone_url":"https://github.com/ministryofjustice/defence-request-service-rota.git","svn_url":"https://github.com/ministryofjustice/defence-request-service-rota","homepage":null,"size":512,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"3be237e04d32b2cf6717f1154080879f5241947e","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":32456341,"name":"defence-request-service-rota","full_name":"ministryofjustice/defence-request-service-rota","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/defence-request-service-rota","description":"Defence Request Service - Rota Handling","fork":false,"url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota","forks_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/forks","keys_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/events","assignees_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/merges","archive_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/releases{/id}","created_at":"2015-03-18T12:04:23Z","updated_at":"2015-04-08T17:51:53Z","pushed_at":"2015-04-09T14:36:19Z","git_url":"git://github.com/ministryofjustice/defence-request-service-rota.git","ssh_url":"git@github.com:ministryofjustice/defence-request-service-rota.git","clone_url":"https://github.com/ministryofjustice/defence-request-service-rota.git","svn_url":"https://github.com/ministryofjustice/defence-request-service-rota","homepage":null,"size":512,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21"},"html":{"href":"https://github.com/ministryofjustice/defence-request-service-rota/pull/21"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/21"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/defence-request-service-rota/statuses/3dcb734b8cabb78c7b475a5616d2e34a103ee782"}}}}