{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/22425068","id":22425068,"diff_hunk":"@@ -113,6 +113,9 @@ void mattack::antqueen(monster *z, int index)\n \n void mattack::shriek(monster *z, int index)\n {\n+    if( z->friendly ) {\n+        return; // TODO: handle friendly monsters","path":"src/monattack.cpp","position":5,"original_position":5,"commit_id":"a8f69d36522e9fc9f347a8f3ba9b0cca4eeee3e0","original_commit_id":"a8f69d36522e9fc9f347a8f3ba9b0cca4eeee3e0","user":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=3","gravatar_id":"","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"body":"Friendly shrieker might shriek with good intentions, but would only summon more hostiles.  Either shrieking or not-shrieking is acceptable, but I'd rule shrieking as it's not smart enough to know that it shouldn't.","created_at":"2015-01-02T22:24:44Z","updated_at":"2015-01-02T22:24:44Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718#discussion_r22425068","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/22425068"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718#discussion_r22425068"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718","id":26769885,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10718","number":10718,"state":"open","locked":false,"title":"Remove the FRIENDLY_SPECIAL monster flag.","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"Each attack function should know on its own whether it makes sense to be used on a friendly monster.\r\nAs the monster flag would apply to all special functions of the monster, it was not good for monsters with multiple special functions (of which some can apply to friendly monsters and some can't).\r\n\r\nAttack functions that were already used with a monster that had the FRIENDLY_SPECIAL flag are unchanged. They will be used by other monsters that did not had that flag (if there were any of them).\r\n\r\nThe following functions will now be done by friendly monsters as well:\r\n- generator\r\n- disappear\r\n- parrot\r\n- antqueen\r\n- jackson\r\n- dance\r\n- dogthing\r\n- upgrade\r\n- breathe\r\n\r\nTheir logic is not affected by the status of the player character (distance to them, visibility etc.)\r\n\r\nAll the other functions have a check at the very beginning that cancels them on friendly monsters and a TODO comment.\r\n","created_at":"2015-01-02T20:27:57Z","updated_at":"2015-01-02T22:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e50cc0378d40d54adab49536f8a99b74c2915a42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10718/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a8f69d36522e9fc9f347a8f3ba9b0cca4eeee3e0","head":{"label":"BevapDin:ERASE_FRIENDLY_SPECIAL","ref":"ERASE_FRIENDLY_SPECIAL","sha":"a8f69d36522e9fc9f347a8f3ba9b0cca4eeee3e0","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"repo":{"id":11775770,"name":"Cataclysm-DDA","full_name":"BevapDin/Cataclysm-DDA","owner":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BevapDin/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA","forks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/releases{/id}","created_at":"2013-07-30T21:12:59Z","updated_at":"2014-09-19T12:18:20Z","pushed_at":"2015-01-02T19:47:09Z","git_url":"git://github.com/BevapDin/Cataclysm-DDA.git","ssh_url":"git@github.com:BevapDin/Cataclysm-DDA.git","clone_url":"https://github.com/BevapDin/Cataclysm-DDA.git","svn_url":"https://github.com/BevapDin/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":334543,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"b41c47c5aec752576894d943bc9c0219d946cb31","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-01-02T08:10:26Z","pushed_at":"2015-01-02T06:19:56Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":401809,"stargazers_count":557,"watchers_count":557,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":620,"mirror_url":null,"open_issues_count":776,"forks":620,"open_issues":776,"watchers":557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/10718"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10718"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/10718/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/10718/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a8f69d36522e9fc9f347a8f3ba9b0cca4eeee3e0"}}}}