{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7","id":45209086,"html_url":"https://github.com/lsst/sims_coordUtils/pull/7","diff_url":"https://github.com/lsst/sims_coordUtils/pull/7.diff","patch_url":"https://github.com/lsst/sims_coordUtils/pull/7.patch","issue_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/7","number":7,"state":"closed","locked":false,"title":"Feature/sim 1206/angle api","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"This is a fairly large pull request.\r\n\r\nI have rewritten all of the coordinate transformation routines so that routines that deal exclusively in radians are named, for example, _observedFromICRS, and routines that deal in sensible units (degrees for RA, Dec; arcseconds for proper motion and parallax) are named observedFromICRS.\r\n\r\nI have also broken up methods like findChipName, which used to accept either pupil coordinates or Ra, Dec as arguments, into chipNameFromRaDec and chipNameFromPupilCoords.\r\n\r\nI completely rewrote the unit test testCameraUtils.py to more systematically test all of the functionality in CameraUtils.py.\r\n\r\nI added the unit test testDegreesVersusRadians.py to test the self-consistency of the degree- and radian-handling methods in AstrometryUtils.py\r\n\r\nObviously, this has impacts on a lot of upstream packages.  There are supporting pull requests in\r\nsims_utils\r\nsims_catalogs_generation\r\nsims_photUtils\r\nsims_catUtils\r\nsims_GalSimInterface\r\nsims_maf","created_at":"2015-09-16T18:46:12Z","updated_at":"2015-09-18T18:52:18Z","closed_at":"2015-09-18T18:52:18Z","merged_at":"2015-09-18T18:52:18Z","merge_commit_sha":"30d93f50ef6ada0a3392d5bb93388097b13db5ab","assignee":{"login":"yoachim","id":3673733,"avatar_url":"https://avatars.githubusercontent.com/u/3673733?v=3","gravatar_id":"","url":"https://api.github.com/users/yoachim","html_url":"https://github.com/yoachim","followers_url":"https://api.github.com/users/yoachim/followers","following_url":"https://api.github.com/users/yoachim/following{/other_user}","gists_url":"https://api.github.com/users/yoachim/gists{/gist_id}","starred_url":"https://api.github.com/users/yoachim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoachim/subscriptions","organizations_url":"https://api.github.com/users/yoachim/orgs","repos_url":"https://api.github.com/users/yoachim/repos","events_url":"https://api.github.com/users/yoachim/events{/privacy}","received_events_url":"https://api.github.com/users/yoachim/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/7/comments","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/0134a9f0ab214c5409515a7890332713fa10dfcd","head":{"label":"lsst:feature/SIM-1206/angleAPI","ref":"feature/SIM-1206/angleAPI","sha":"0134a9f0ab214c5409515a7890332713fa10dfcd","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","created_at":"2015-04-27T13:28:33Z","updated_at":"2015-04-30T16:24:17Z","pushed_at":"2015-09-18T18:52:18Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":983,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"6f291ed0700cca791d7d718114416c31ce3af134","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","created_at":"2015-04-27T13:28:33Z","updated_at":"2015-04-30T16:24:17Z","pushed_at":"2015-09-18T18:52:18Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":983,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7"},"html":{"href":"https://github.com/lsst/sims_coordUtils/pull/7"},"issue":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/7"},"comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/0134a9f0ab214c5409515a7890332713fa10dfcd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":44,"additions":2529,"deletions":678,"changed_files":6}}