{"action":"created","issue":{"url":"https://api.github.com/repos/emacs-ess/ESS/issues/261","labels_url":"https://api.github.com/repos/emacs-ess/ESS/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/issues/261/comments","events_url":"https://api.github.com/repos/emacs-ess/ESS/issues/261/events","html_url":"https://github.com/emacs-ess/ESS/pull/261","id":113107209,"number":261,"title":"Display knitr output buffers only on error","user":{"login":"Jehops","id":6874951,"avatar_url":"https://avatars.githubusercontent.com/u/6874951?v=3","gravatar_id":"","url":"https://api.github.com/users/Jehops","html_url":"https://github.com/Jehops","followers_url":"https://api.github.com/users/Jehops/followers","following_url":"https://api.github.com/users/Jehops/following{/other_user}","gists_url":"https://api.github.com/users/Jehops/gists{/gist_id}","starred_url":"https://api.github.com/users/Jehops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jehops/subscriptions","organizations_url":"https://api.github.com/users/Jehops/orgs","repos_url":"https://api.github.com/users/Jehops/repos","events_url":"https://api.github.com/users/Jehops/events{/privacy}","received_events_url":"https://api.github.com/users/Jehops/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-23T21:56:45Z","updated_at":"2015-10-29T01:51:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/261","html_url":"https://github.com/emacs-ess/ESS/pull/261","diff_url":"https://github.com/emacs-ess/ESS/pull/261.diff","patch_url":"https://github.com/emacs-ess/ESS/pull/261.patch"},"body":"The patch to `ess-swv-run-in-R` will only display a new window when\r\nthere is an error in the R code and will display a message in the\r\nminubuffer when the weaving/tangling/kniting/purling is complete.\r\n`ess-swv-run-in-R` is currently only used for\r\nweaving/tangling/kniting/purling, so this won't affect other aspects of\r\nESS.\r\n\r\nThe patch to `ess-swv-PDF` simply prevents the buffer with the TeX\r\noutput from being displayed when there are no errors compiling the TeX.\r\nInstead, a status message is displayed in the minibuffer.\r\n\r\nMotivation:\r\n\r\nThe usual routine to create a PDF file from a knitr Rnw document is to\r\nrun `ess-swv-knit` with `M-n r`, then `ess-swv-PDF` with `M-n P`.  It's\r\nnot hard to do `C-x 1` after these commands to close the newly displayed\r\nwindow, but for anyone with multiple windows displaying, it can be\r\ntedious to return to the previous window configuration.\r\n\r\nTODO:\r\n\r\nFor consistency, update ess-swv-PS to mimic the behaviour of ess-swv-PDF."},"comment":{"url":"https://api.github.com/repos/emacs-ess/ESS/issues/comments/152049811","html_url":"https://github.com/emacs-ess/ESS/pull/261#issuecomment-152049811","issue_url":"https://api.github.com/repos/emacs-ess/ESS/issues/261","id":152049811,"user":{"login":"Jehops","id":6874951,"avatar_url":"https://avatars.githubusercontent.com/u/6874951?v=3","gravatar_id":"","url":"https://api.github.com/users/Jehops","html_url":"https://github.com/Jehops","followers_url":"https://api.github.com/users/Jehops/followers","following_url":"https://api.github.com/users/Jehops/following{/other_user}","gists_url":"https://api.github.com/users/Jehops/gists{/gist_id}","starred_url":"https://api.github.com/users/Jehops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jehops/subscriptions","organizations_url":"https://api.github.com/users/Jehops/orgs","repos_url":"https://api.github.com/users/Jehops/repos","events_url":"https://api.github.com/users/Jehops/events{/privacy}","received_events_url":"https://api.github.com/users/Jehops/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T01:51:48Z","updated_at":"2015-10-29T01:51:48Z","body":"Martin Mächler <notifications@github.com> writes:\n\n> The proposed changes look good to me ((but I did not even try them)).\n> You mention / changed 'knitting'  only, but not Sweaving. \n\n>  Shouldn't there be analogous changes (i.e. not showing the \"log\" buffer by default unless in case of errors)?  Or are they not needed there?  {{sorry for being lazy and not checking myself}}\n\nThe changes affect all related functions (weaving/tangling knitting/purling) since they all call `ess-swv-run-in-R`.\n"}}