{"action":"closed","number":3305,"pull_request":{"url":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305","id":52972591,"html_url":"https://github.com/diydrones/ardupilot/pull/3305","diff_url":"https://github.com/diydrones/ardupilot/pull/3305.diff","patch_url":"https://github.com/diydrones/ardupilot/pull/3305.patch","issue_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3305","number":3305,"state":"closed","locked":false,"title":"Plane: Don't disable compass checks for HIL mode unless actually in hil mode","user":{"login":"WickedShell","id":567688,"avatar_url":"https://avatars.githubusercontent.com/u/567688?v=3","gravatar_id":"","url":"https://api.github.com/users/WickedShell","html_url":"https://github.com/WickedShell","followers_url":"https://api.github.com/users/WickedShell/followers","following_url":"https://api.github.com/users/WickedShell/following{/other_user}","gists_url":"https://api.github.com/users/WickedShell/gists{/gist_id}","starred_url":"https://api.github.com/users/WickedShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickedShell/subscriptions","organizations_url":"https://api.github.com/users/WickedShell/orgs","repos_url":"https://api.github.com/users/WickedShell/repos","events_url":"https://api.github.com/users/WickedShell/events{/privacy}","received_events_url":"https://api.github.com/users/WickedShell/received_events","type":"User","site_admin":false},"body":"Detected by coverity 113979. HIL_SUPPORT is always true in the build system, which means we never ran the checks if the compass wasn't okay after init.","created_at":"2015-12-08T12:10:28Z","updated_at":"2015-12-09T03:00:16Z","closed_at":"2015-12-09T03:00:16Z","merged_at":"2015-12-09T03:00:16Z","merge_commit_sha":"54dfb298114e0b02007510e8680edf3631c5f51c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305/commits","review_comments_url":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305/comments","review_comment_url":"https://api.github.com/repos/diydrones/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diydrones/ardupilot/issues/3305/comments","statuses_url":"https://api.github.com/repos/diydrones/ardupilot/statuses/4b40a884e9485509a0862d1b6f0d7f576b2bfdcc","head":{"label":"WickedShell:hilCompass","ref":"hilCompass","sha":"4b40a884e9485509a0862d1b6f0d7f576b2bfdcc","user":{"login":"WickedShell","id":567688,"avatar_url":"https://avatars.githubusercontent.com/u/567688?v=3","gravatar_id":"","url":"https://api.github.com/users/WickedShell","html_url":"https://github.com/WickedShell","followers_url":"https://api.github.com/users/WickedShell/followers","following_url":"https://api.github.com/users/WickedShell/following{/other_user}","gists_url":"https://api.github.com/users/WickedShell/gists{/gist_id}","starred_url":"https://api.github.com/users/WickedShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickedShell/subscriptions","organizations_url":"https://api.github.com/users/WickedShell/orgs","repos_url":"https://api.github.com/users/WickedShell/repos","events_url":"https://api.github.com/users/WickedShell/events{/privacy}","received_events_url":"https://api.github.com/users/WickedShell/received_events","type":"User","site_admin":false},"repo":{"id":33838710,"name":"ardupilot","full_name":"WickedShell/ardupilot","owner":{"login":"WickedShell","id":567688,"avatar_url":"https://avatars.githubusercontent.com/u/567688?v=3","gravatar_id":"","url":"https://api.github.com/users/WickedShell","html_url":"https://github.com/WickedShell","followers_url":"https://api.github.com/users/WickedShell/followers","following_url":"https://api.github.com/users/WickedShell/following{/other_user}","gists_url":"https://api.github.com/users/WickedShell/gists{/gist_id}","starred_url":"https://api.github.com/users/WickedShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WickedShell/subscriptions","organizations_url":"https://api.github.com/users/WickedShell/orgs","repos_url":"https://api.github.com/users/WickedShell/repos","events_url":"https://api.github.com/users/WickedShell/events{/privacy}","received_events_url":"https://api.github.com/users/WickedShell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WickedShell/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/WickedShell/ardupilot","forks_url":"https://api.github.com/repos/WickedShell/ardupilot/forks","keys_url":"https://api.github.com/repos/WickedShell/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WickedShell/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WickedShell/ardupilot/teams","hooks_url":"https://api.github.com/repos/WickedShell/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/WickedShell/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/WickedShell/ardupilot/events","assignees_url":"https://api.github.com/repos/WickedShell/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/WickedShell/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/WickedShell/ardupilot/tags","blobs_url":"https://api.github.com/repos/WickedShell/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WickedShell/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WickedShell/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/WickedShell/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WickedShell/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/WickedShell/ardupilot/languages","stargazers_url":"https://api.github.com/repos/WickedShell/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/WickedShell/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/WickedShell/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/WickedShell/ardupilot/subscription","commits_url":"https://api.github.com/repos/WickedShell/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/WickedShell/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/WickedShell/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/WickedShell/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/WickedShell/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/WickedShell/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WickedShell/ardupilot/merges","archive_url":"https://api.github.com/repos/WickedShell/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WickedShell/ardupilot/downloads","issues_url":"https://api.github.com/repos/WickedShell/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/WickedShell/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/WickedShell/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/WickedShell/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WickedShell/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/WickedShell/ardupilot/releases{/id}","created_at":"2015-04-12T23:49:21Z","updated_at":"2015-04-14T03:16:04Z","pushed_at":"2015-12-08T12:08:44Z","git_url":"git://github.com/WickedShell/ardupilot.git","ssh_url":"git@github.com:WickedShell/ardupilot.git","clone_url":"https://github.com/WickedShell/ardupilot.git","svn_url":"https://github.com/WickedShell/ardupilot","homepage":"http://ardupilot.com/","size":74461,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diydrones:master","ref":"master","sha":"7236b485181f4171ce87f5e81ab6940b1f9c158b","user":{"login":"diydrones","id":3189387,"avatar_url":"https://avatars.githubusercontent.com/u/3189387?v=3","gravatar_id":"","url":"https://api.github.com/users/diydrones","html_url":"https://github.com/diydrones","followers_url":"https://api.github.com/users/diydrones/followers","following_url":"https://api.github.com/users/diydrones/following{/other_user}","gists_url":"https://api.github.com/users/diydrones/gists{/gist_id}","starred_url":"https://api.github.com/users/diydrones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diydrones/subscriptions","organizations_url":"https://api.github.com/users/diydrones/orgs","repos_url":"https://api.github.com/users/diydrones/repos","events_url":"https://api.github.com/users/diydrones/events{/privacy}","received_events_url":"https://api.github.com/users/diydrones/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"diydrones/ardupilot","owner":{"login":"diydrones","id":3189387,"avatar_url":"https://avatars.githubusercontent.com/u/3189387?v=3","gravatar_id":"","url":"https://api.github.com/users/diydrones","html_url":"https://github.com/diydrones","followers_url":"https://api.github.com/users/diydrones/followers","following_url":"https://api.github.com/users/diydrones/following{/other_user}","gists_url":"https://api.github.com/users/diydrones/gists{/gist_id}","starred_url":"https://api.github.com/users/diydrones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diydrones/subscriptions","organizations_url":"https://api.github.com/users/diydrones/orgs","repos_url":"https://api.github.com/users/diydrones/repos","events_url":"https://api.github.com/users/diydrones/events{/privacy}","received_events_url":"https://api.github.com/users/diydrones/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diydrones/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":false,"url":"https://api.github.com/repos/diydrones/ardupilot","forks_url":"https://api.github.com/repos/diydrones/ardupilot/forks","keys_url":"https://api.github.com/repos/diydrones/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diydrones/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diydrones/ardupilot/teams","hooks_url":"https://api.github.com/repos/diydrones/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/diydrones/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/diydrones/ardupilot/events","assignees_url":"https://api.github.com/repos/diydrones/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/diydrones/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/diydrones/ardupilot/tags","blobs_url":"https://api.github.com/repos/diydrones/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diydrones/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diydrones/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/diydrones/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diydrones/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/diydrones/ardupilot/languages","stargazers_url":"https://api.github.com/repos/diydrones/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/diydrones/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/diydrones/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/diydrones/ardupilot/subscription","commits_url":"https://api.github.com/repos/diydrones/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/diydrones/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/diydrones/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/diydrones/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/diydrones/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/diydrones/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diydrones/ardupilot/merges","archive_url":"https://api.github.com/repos/diydrones/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diydrones/ardupilot/downloads","issues_url":"https://api.github.com/repos/diydrones/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/diydrones/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/diydrones/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/diydrones/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diydrones/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/diydrones/ardupilot/releases{/id}","created_at":"2013-01-09T00:58:52Z","updated_at":"2015-12-08T13:13:55Z","pushed_at":"2015-12-09T03:00:12Z","git_url":"git://github.com/diydrones/ardupilot.git","ssh_url":"git@github.com:diydrones/ardupilot.git","clone_url":"https://github.com/diydrones/ardupilot.git","svn_url":"https://github.com/diydrones/ardupilot","homepage":"http://ardupilot.com/","size":106194,"stargazers_count":1559,"watchers_count":1559,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3133,"mirror_url":null,"open_issues_count":628,"forks":3133,"open_issues":628,"watchers":1559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305"},"html":{"href":"https://github.com/diydrones/ardupilot/pull/3305"},"issue":{"href":"https://api.github.com/repos/diydrones/ardupilot/issues/3305"},"comments":{"href":"https://api.github.com/repos/diydrones/ardupilot/issues/3305/comments"},"review_comments":{"href":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305/comments"},"review_comment":{"href":"https://api.github.com/repos/diydrones/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diydrones/ardupilot/pulls/3305/commits"},"statuses":{"href":"https://api.github.com/repos/diydrones/ardupilot/statuses/4b40a884e9485509a0862d1b6f0d7f576b2bfdcc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}