{"action":"created","comment":{"url":"https://api.github.com/repos/certtools/intelmq/pulls/comments/43106062","id":43106062,"diff_hunk":"@@ -36,19 +36,19 @@\n                    \"destination.network\": \"2001:500:88::/48\",\n                    }\n UNICODE_INPUT = {\"__type\": \"Event\",\n-                 \"destination.ip\": \"177.81.215.80\",  # some brazil IP\n+                 \"destination.ip\": \"186.226.224.9\",  # some brazil IP\n                  \"time.observation\": \"2015-01-01T00:00:00+00:00\",\n                  }\n UNICODE_OUTPUT = {\"__type\": \"Event\",\n-                  \"destination.ip\": \"177.81.215.80\",  # some brazil IP\n+                  \"destination.ip\": \"186.226.224.9\",  # some brazil IP\n                   \"time.observation\": \"2015-01-01T00:00:00+00:00\",\n                   \"destination.registry\": \"lacnic\",\n-                  \"destination.allocated\": \"2011-08-30T00:00:00+00:00\",\n-                  \"destination.as_name\": \"NET Servi\\xe7os de Comunica\\xe7\\xe3o\"\n-                                         \" S.A.,BR\",\n+                  \"destination.allocated\": \"2010-08-13T00:00:00+00:00\",\n+                  \"destination.as_name\": \"Local Datacenter Solu\\xe7\\xf5es em\"","path":"intelmq/tests/bots/experts/cymru_whois/test_expert.py","position":17,"original_position":17,"commit_id":"895bcaf84684f79b48c3f4caa4246531f23ccefa","original_commit_id":"895bcaf84684f79b48c3f4caa4246531f23ccefa","user":{"login":"sebix","id":199050,"avatar_url":"https://avatars.githubusercontent.com/u/199050?v=3","gravatar_id":"","url":"https://api.github.com/users/sebix","html_url":"https://github.com/sebix","followers_url":"https://api.github.com/users/sebix/followers","following_url":"https://api.github.com/users/sebix/following{/other_user}","gists_url":"https://api.github.com/users/sebix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebix/subscriptions","organizations_url":"https://api.github.com/users/sebix/orgs","repos_url":"https://api.github.com/users/sebix/repos","events_url":"https://api.github.com/users/sebix/events{/privacy}","received_events_url":"https://api.github.com/users/sebix/received_events","type":"User","site_admin":false},"body":"I just got `CLARO S.A.,BR`, no more unicode :( We need another example.","created_at":"2015-10-27T10:47:15Z","updated_at":"2015-10-27T10:47:15Z","html_url":"https://github.com/certtools/intelmq/pull/376#discussion_r43106062","pull_request_url":"https://api.github.com/repos/certtools/intelmq/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/comments/43106062"},"html":{"href":"https://github.com/certtools/intelmq/pull/376#discussion_r43106062"},"pull_request":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/certtools/intelmq/pulls/376","id":48828774,"html_url":"https://github.com/certtools/intelmq/pull/376","diff_url":"https://github.com/certtools/intelmq/pull/376.diff","patch_url":"https://github.com/certtools/intelmq/pull/376.patch","issue_url":"https://api.github.com/repos/certtools/intelmq/issues/376","number":376,"state":"open","locked":false,"title":"ENH: new error handling","user":{"login":"SYNchroACK","id":4184292,"avatar_url":"https://avatars.githubusercontent.com/u/4184292?v=3","gravatar_id":"","url":"https://api.github.com/users/SYNchroACK","html_url":"https://github.com/SYNchroACK","followers_url":"https://api.github.com/users/SYNchroACK/followers","following_url":"https://api.github.com/users/SYNchroACK/following{/other_user}","gists_url":"https://api.github.com/users/SYNchroACK/gists{/gist_id}","starred_url":"https://api.github.com/users/SYNchroACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SYNchroACK/subscriptions","organizations_url":"https://api.github.com/users/SYNchroACK/orgs","repos_url":"https://api.github.com/users/SYNchroACK/repos","events_url":"https://api.github.com/users/SYNchroACK/events{/privacy}","received_events_url":"https://api.github.com/users/SYNchroACK/received_events","type":"User","site_admin":false},"body":"**Notes:**\r\n1. `error_traceback` variable is because in `finally:` section of the `try:except` is not possible to get the exception message through `traceback.format_exc()`. New approaches are welcome! :)\r\n2. In case of pipeline error, the message will not be dumped because it stills saved on pipeline. I think the dumped message will not add extra value to the system in this specific situation.\r\n3. This pull req keeps a bug which already exists (https://github.com/SYNchroACK/intelmq/blob/error_handling/intelmq/lib/bot.py#L149)\r\n4. The new behavior of error handling is described in documentation. Feedback is welcome!\r\n\r\n@sebix , your feedback on this is a must! :p Thank you.","created_at":"2015-10-27T04:55:35Z","updated_at":"2015-10-27T10:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dfaad399c30a18eb6740b488a1c7446f1b36d82","assignee":{"login":"sebix","id":199050,"avatar_url":"https://avatars.githubusercontent.com/u/199050?v=3","gravatar_id":"","url":"https://api.github.com/users/sebix","html_url":"https://github.com/sebix","followers_url":"https://api.github.com/users/sebix/followers","following_url":"https://api.github.com/users/sebix/following{/other_user}","gists_url":"https://api.github.com/users/sebix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebix/subscriptions","organizations_url":"https://api.github.com/users/sebix/orgs","repos_url":"https://api.github.com/users/sebix/repos","events_url":"https://api.github.com/users/sebix/events{/privacy}","received_events_url":"https://api.github.com/users/sebix/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/certtools/intelmq/milestones/2","html_url":"https://github.com/certtools/intelmq/milestones/Release%201%20-%20v1.0","labels_url":"https://api.github.com/repos/certtools/intelmq/milestones/2/labels","id":719078,"number":2,"title":"Release 1 - v1.0","description":"Complete version 1.0","creator":{"login":"SYNchroACK","id":4184292,"avatar_url":"https://avatars.githubusercontent.com/u/4184292?v=3","gravatar_id":"","url":"https://api.github.com/users/SYNchroACK","html_url":"https://github.com/SYNchroACK","followers_url":"https://api.github.com/users/SYNchroACK/followers","following_url":"https://api.github.com/users/SYNchroACK/following{/other_user}","gists_url":"https://api.github.com/users/SYNchroACK/gists{/gist_id}","starred_url":"https://api.github.com/users/SYNchroACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SYNchroACK/subscriptions","organizations_url":"https://api.github.com/users/SYNchroACK/orgs","repos_url":"https://api.github.com/users/SYNchroACK/repos","events_url":"https://api.github.com/users/SYNchroACK/events{/privacy}","received_events_url":"https://api.github.com/users/SYNchroACK/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":186,"state":"open","created_at":"2014-07-12T18:19:52Z","updated_at":"2015-10-27T04:55:35Z","due_on":"2015-11-01T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/certtools/intelmq/pulls/376/commits","review_comments_url":"https://api.github.com/repos/certtools/intelmq/pulls/376/comments","review_comment_url":"https://api.github.com/repos/certtools/intelmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certtools/intelmq/issues/376/comments","statuses_url":"https://api.github.com/repos/certtools/intelmq/statuses/895bcaf84684f79b48c3f4caa4246531f23ccefa","head":{"label":"SYNchroACK:error_handling","ref":"error_handling","sha":"895bcaf84684f79b48c3f4caa4246531f23ccefa","user":{"login":"SYNchroACK","id":4184292,"avatar_url":"https://avatars.githubusercontent.com/u/4184292?v=3","gravatar_id":"","url":"https://api.github.com/users/SYNchroACK","html_url":"https://github.com/SYNchroACK","followers_url":"https://api.github.com/users/SYNchroACK/followers","following_url":"https://api.github.com/users/SYNchroACK/following{/other_user}","gists_url":"https://api.github.com/users/SYNchroACK/gists{/gist_id}","starred_url":"https://api.github.com/users/SYNchroACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SYNchroACK/subscriptions","organizations_url":"https://api.github.com/users/SYNchroACK/orgs","repos_url":"https://api.github.com/users/SYNchroACK/repos","events_url":"https://api.github.com/users/SYNchroACK/events{/privacy}","received_events_url":"https://api.github.com/users/SYNchroACK/received_events","type":"User","site_admin":false},"repo":{"id":42790173,"name":"intelmq","full_name":"SYNchroACK/intelmq","owner":{"login":"SYNchroACK","id":4184292,"avatar_url":"https://avatars.githubusercontent.com/u/4184292?v=3","gravatar_id":"","url":"https://api.github.com/users/SYNchroACK","html_url":"https://github.com/SYNchroACK","followers_url":"https://api.github.com/users/SYNchroACK/followers","following_url":"https://api.github.com/users/SYNchroACK/following{/other_user}","gists_url":"https://api.github.com/users/SYNchroACK/gists{/gist_id}","starred_url":"https://api.github.com/users/SYNchroACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SYNchroACK/subscriptions","organizations_url":"https://api.github.com/users/SYNchroACK/orgs","repos_url":"https://api.github.com/users/SYNchroACK/repos","events_url":"https://api.github.com/users/SYNchroACK/events{/privacy}","received_events_url":"https://api.github.com/users/SYNchroACK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SYNchroACK/intelmq","description":"IntelMQ is a solution for CERTs to process data feeds, pastebins, tweets throught a message queue.","fork":true,"url":"https://api.github.com/repos/SYNchroACK/intelmq","forks_url":"https://api.github.com/repos/SYNchroACK/intelmq/forks","keys_url":"https://api.github.com/repos/SYNchroACK/intelmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SYNchroACK/intelmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SYNchroACK/intelmq/teams","hooks_url":"https://api.github.com/repos/SYNchroACK/intelmq/hooks","issue_events_url":"https://api.github.com/repos/SYNchroACK/intelmq/issues/events{/number}","events_url":"https://api.github.com/repos/SYNchroACK/intelmq/events","assignees_url":"https://api.github.com/repos/SYNchroACK/intelmq/assignees{/user}","branches_url":"https://api.github.com/repos/SYNchroACK/intelmq/branches{/branch}","tags_url":"https://api.github.com/repos/SYNchroACK/intelmq/tags","blobs_url":"https://api.github.com/repos/SYNchroACK/intelmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SYNchroACK/intelmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SYNchroACK/intelmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/SYNchroACK/intelmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SYNchroACK/intelmq/statuses/{sha}","languages_url":"https://api.github.com/repos/SYNchroACK/intelmq/languages","stargazers_url":"https://api.github.com/repos/SYNchroACK/intelmq/stargazers","contributors_url":"https://api.github.com/repos/SYNchroACK/intelmq/contributors","subscribers_url":"https://api.github.com/repos/SYNchroACK/intelmq/subscribers","subscription_url":"https://api.github.com/repos/SYNchroACK/intelmq/subscription","commits_url":"https://api.github.com/repos/SYNchroACK/intelmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/SYNchroACK/intelmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/SYNchroACK/intelmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/SYNchroACK/intelmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/SYNchroACK/intelmq/contents/{+path}","compare_url":"https://api.github.com/repos/SYNchroACK/intelmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SYNchroACK/intelmq/merges","archive_url":"https://api.github.com/repos/SYNchroACK/intelmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SYNchroACK/intelmq/downloads","issues_url":"https://api.github.com/repos/SYNchroACK/intelmq/issues{/number}","pulls_url":"https://api.github.com/repos/SYNchroACK/intelmq/pulls{/number}","milestones_url":"https://api.github.com/repos/SYNchroACK/intelmq/milestones{/number}","notifications_url":"https://api.github.com/repos/SYNchroACK/intelmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SYNchroACK/intelmq/labels{/name}","releases_url":"https://api.github.com/repos/SYNchroACK/intelmq/releases{/id}","created_at":"2015-09-19T21:25:22Z","updated_at":"2015-09-19T21:25:23Z","pushed_at":"2015-10-27T05:25:31Z","git_url":"git://github.com/SYNchroACK/intelmq.git","ssh_url":"git@github.com:SYNchroACK/intelmq.git","clone_url":"https://github.com/SYNchroACK/intelmq.git","svn_url":"https://github.com/SYNchroACK/intelmq","homepage":"http://www.enisa.europa.eu/activities/cert/support/incident-handling-automation","size":2213,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"certtools:master","ref":"master","sha":"a04d1548d626b0d2d315a1014e9780df3b6d99b0","user":{"login":"certtools","id":5830035,"avatar_url":"https://avatars.githubusercontent.com/u/5830035?v=3","gravatar_id":"","url":"https://api.github.com/users/certtools","html_url":"https://github.com/certtools","followers_url":"https://api.github.com/users/certtools/followers","following_url":"https://api.github.com/users/certtools/following{/other_user}","gists_url":"https://api.github.com/users/certtools/gists{/gist_id}","starred_url":"https://api.github.com/users/certtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certtools/subscriptions","organizations_url":"https://api.github.com/users/certtools/orgs","repos_url":"https://api.github.com/users/certtools/repos","events_url":"https://api.github.com/users/certtools/events{/privacy}","received_events_url":"https://api.github.com/users/certtools/received_events","type":"Organization","site_admin":false},"repo":{"id":21160389,"name":"intelmq","full_name":"certtools/intelmq","owner":{"login":"certtools","id":5830035,"avatar_url":"https://avatars.githubusercontent.com/u/5830035?v=3","gravatar_id":"","url":"https://api.github.com/users/certtools","html_url":"https://github.com/certtools","followers_url":"https://api.github.com/users/certtools/followers","following_url":"https://api.github.com/users/certtools/following{/other_user}","gists_url":"https://api.github.com/users/certtools/gists{/gist_id}","starred_url":"https://api.github.com/users/certtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certtools/subscriptions","organizations_url":"https://api.github.com/users/certtools/orgs","repos_url":"https://api.github.com/users/certtools/repos","events_url":"https://api.github.com/users/certtools/events{/privacy}","received_events_url":"https://api.github.com/users/certtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certtools/intelmq","description":"IntelMQ is a solution to process data feeds, pastebins, tweets throught a message queue.","fork":false,"url":"https://api.github.com/repos/certtools/intelmq","forks_url":"https://api.github.com/repos/certtools/intelmq/forks","keys_url":"https://api.github.com/repos/certtools/intelmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certtools/intelmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certtools/intelmq/teams","hooks_url":"https://api.github.com/repos/certtools/intelmq/hooks","issue_events_url":"https://api.github.com/repos/certtools/intelmq/issues/events{/number}","events_url":"https://api.github.com/repos/certtools/intelmq/events","assignees_url":"https://api.github.com/repos/certtools/intelmq/assignees{/user}","branches_url":"https://api.github.com/repos/certtools/intelmq/branches{/branch}","tags_url":"https://api.github.com/repos/certtools/intelmq/tags","blobs_url":"https://api.github.com/repos/certtools/intelmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certtools/intelmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certtools/intelmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/certtools/intelmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certtools/intelmq/statuses/{sha}","languages_url":"https://api.github.com/repos/certtools/intelmq/languages","stargazers_url":"https://api.github.com/repos/certtools/intelmq/stargazers","contributors_url":"https://api.github.com/repos/certtools/intelmq/contributors","subscribers_url":"https://api.github.com/repos/certtools/intelmq/subscribers","subscription_url":"https://api.github.com/repos/certtools/intelmq/subscription","commits_url":"https://api.github.com/repos/certtools/intelmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/certtools/intelmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/certtools/intelmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/certtools/intelmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/certtools/intelmq/contents/{+path}","compare_url":"https://api.github.com/repos/certtools/intelmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certtools/intelmq/merges","archive_url":"https://api.github.com/repos/certtools/intelmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certtools/intelmq/downloads","issues_url":"https://api.github.com/repos/certtools/intelmq/issues{/number}","pulls_url":"https://api.github.com/repos/certtools/intelmq/pulls{/number}","milestones_url":"https://api.github.com/repos/certtools/intelmq/milestones{/number}","notifications_url":"https://api.github.com/repos/certtools/intelmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certtools/intelmq/labels{/name}","releases_url":"https://api.github.com/repos/certtools/intelmq/releases{/id}","created_at":"2014-06-24T10:11:39Z","updated_at":"2015-10-24T14:37:52Z","pushed_at":"2015-10-27T05:25:32Z","git_url":"git://github.com/certtools/intelmq.git","ssh_url":"git@github.com:certtools/intelmq.git","clone_url":"https://github.com/certtools/intelmq.git","svn_url":"https://github.com/certtools/intelmq","homepage":"http://www.enisa.europa.eu/activities/cert/support/incident-handling-automation","size":19807,"stargazers_count":89,"watchers_count":89,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":72,"forks":33,"open_issues":72,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/376"},"html":{"href":"https://github.com/certtools/intelmq/pull/376"},"issue":{"href":"https://api.github.com/repos/certtools/intelmq/issues/376"},"comments":{"href":"https://api.github.com/repos/certtools/intelmq/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certtools/intelmq/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/certtools/intelmq/statuses/895bcaf84684f79b48c3f4caa4246531f23ccefa"}}}}