{"action":"closed","number":2366,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/2366","id":35743416,"html_url":"https://github.com/juju/juju/pull/2366","diff_url":"https://github.com/juju/juju/pull/2366.diff","patch_url":"https://github.com/juju/juju/pull/2366.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/2366","number":2366,"state":"closed","locked":false,"title":"Ported #2365 and #2190 to 1.24l; fix lp:1442257; disabling SNAT for MAAS","user":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"body":"This includes 2 fixes for 1.24:\n* http://pad.lv/1442257 - instead of inheriting LXC containers' host's\n  primary NIC's MTU value for container NICs, now we have an optional\n  integer environment setting \"lxc-default-mtu\", which when set to a\n  positive number will cause all LXC (but not KVM) NICs to use that MTU.\n  This is a straightforward port of #2365 to 1.24.\n* Related, but not a fix for http://pad.lv/1443942 (originally proposed\n  as #2190 but it didn't land in time) - only add iptables SNAT rules on\n  the container hosts for EC2 environments, as this breaks MAAS and it's\n  not needed (fallout from the original fix #2071 for bug http://pad.lv/1442801).\n\nThe second port is only live-tested on MAAS and EC2, but and improved\nfix and more tests will be added later, as described bug lp:1443942.\n\n(Review request: http://reviews.vapour.ws/r/1726/)","created_at":"2015-05-19T15:35:17Z","updated_at":"2015-05-20T10:58:18Z","closed_at":"2015-05-20T10:58:17Z","merged_at":"2015-05-20T10:58:17Z","merge_commit_sha":"99080f7b421e91ee5e2666975a4a4ba35a6df6a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/2366/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/2366/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/2366/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/e8a01fcfd84d099ebb784c04dd8d720536f2b85f","head":{"label":"dimitern:lp-1442257-lxc-default-mtu-1.24","ref":"lp-1442257-lxc-default-mtu-1.24","sha":"e8a01fcfd84d099ebb784c04dd8d720536f2b85f","user":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"repo":{"id":20473382,"name":"juju","full_name":"dimitern/juju","owner":{"login":"dimitern","id":619986,"avatar_url":"https://avatars.githubusercontent.com/u/619986?v=3","gravatar_id":"","url":"https://api.github.com/users/dimitern","html_url":"https://github.com/dimitern","followers_url":"https://api.github.com/users/dimitern/followers","following_url":"https://api.github.com/users/dimitern/following{/other_user}","gists_url":"https://api.github.com/users/dimitern/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitern/subscriptions","organizations_url":"https://api.github.com/users/dimitern/orgs","repos_url":"https://api.github.com/users/dimitern/repos","events_url":"https://api.github.com/users/dimitern/events{/privacy}","received_events_url":"https://api.github.com/users/dimitern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimitern/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/dimitern/juju","forks_url":"https://api.github.com/repos/dimitern/juju/forks","keys_url":"https://api.github.com/repos/dimitern/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimitern/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimitern/juju/teams","hooks_url":"https://api.github.com/repos/dimitern/juju/hooks","issue_events_url":"https://api.github.com/repos/dimitern/juju/issues/events{/number}","events_url":"https://api.github.com/repos/dimitern/juju/events","assignees_url":"https://api.github.com/repos/dimitern/juju/assignees{/user}","branches_url":"https://api.github.com/repos/dimitern/juju/branches{/branch}","tags_url":"https://api.github.com/repos/dimitern/juju/tags","blobs_url":"https://api.github.com/repos/dimitern/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimitern/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimitern/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimitern/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimitern/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/dimitern/juju/languages","stargazers_url":"https://api.github.com/repos/dimitern/juju/stargazers","contributors_url":"https://api.github.com/repos/dimitern/juju/contributors","subscribers_url":"https://api.github.com/repos/dimitern/juju/subscribers","subscription_url":"https://api.github.com/repos/dimitern/juju/subscription","commits_url":"https://api.github.com/repos/dimitern/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimitern/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimitern/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimitern/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimitern/juju/contents/{+path}","compare_url":"https://api.github.com/repos/dimitern/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimitern/juju/merges","archive_url":"https://api.github.com/repos/dimitern/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimitern/juju/downloads","issues_url":"https://api.github.com/repos/dimitern/juju/issues{/number}","pulls_url":"https://api.github.com/repos/dimitern/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/dimitern/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/dimitern/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimitern/juju/labels{/name}","releases_url":"https://api.github.com/repos/dimitern/juju/releases{/id}","created_at":"2014-06-04T06:58:49Z","updated_at":"2015-04-29T13:41:20Z","pushed_at":"2015-05-19T15:19:30Z","git_url":"git://github.com/dimitern/juju.git","ssh_url":"git@github.com:dimitern/juju.git","clone_url":"https://github.com/dimitern/juju.git","svn_url":"https://github.com/dimitern/juju","homepage":null,"size":53248,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:1.24","ref":"1.24","sha":"13d9d3c810b2c4dc1123f5efb0de81d60f186a1c","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-05-20T07:33:08Z","pushed_at":"2015-05-20T10:58:17Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":91942,"stargazers_count":277,"watchers_count":277,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":63,"forks":90,"open_issues":63,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/2366"},"html":{"href":"https://github.com/juju/juju/pull/2366"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/2366"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/2366/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/2366/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/2366/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/e8a01fcfd84d099ebb784c04dd8d720536f2b85f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":389,"deletions":179,"changed_files":24}}