{"action":"created","comment":{"url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments/42133322","id":42133322,"diff_hunk":"@@ -253,26 +339,48 @@ Kwf.EyeCandy.Lightbox.Lightbox.prototype = {\n             Kwf.EyeCandy.Lightbox.currentOpen.close(closeOptions);\n         }\n         Kwf.EyeCandy.Lightbox.currentOpen = this;\n-\n         this.showOptions = options;\n+        if (!this.fetched) {\n+            this.fetchContent();\n+        }\n \n-        this.lightboxEl.addClass('kwfLightboxOpen');\n-        if (this.fetched) {\n-            if (!this.lightboxEl.is(':visible')) {\n-                this.lightboxEl.show();\n-                Kwf.callOnContentReady(this.lightboxEl, {action: 'show'});\n-                this.style.afterContentShown();\n-                this.preloadLinks();\n-            }\n-        } else {\n+        var transEndEventName = this.getTransitionEndName();\n+        if (!this.lightboxEl.is(':visible')) {\n             this.lightboxEl.show();\n-            this.fetchContent();\n+            if (this.innerLightboxEl.magicTransform) {\n+                var transformName = Modernizr.prefixed('transform');\n+                var matrix = this.innerLightboxEl.css(transformName);\n+                var values = matrix.match(/-?[\\d\\.]+/g);\n+                if (this.innerLightboxEl.magicScale) {\n+                    values[0] = 1;\n+                    values[3] = 1;\n+                }\n+                var newMatrix = 'matrix('+values[0]+','+values[1]+','+values[2]+','+values[3]+',0,0)';\n+                this.innerLightboxEl.css(transformName, newMatrix);\n+            }\n+            var transitionDurationName = Modernizr.prefixed('transitionDuration');\n+            var duration = this.innerLightboxEl.css(transitionDurationName);\n+            if (parseFloat(duration)>0) {\n+                $('body').addClass('kwfLightboxAnimate');\n+                this.innerLightboxEl.one(transEndEventName,\n+                    (function() {\n+                        $('body').removeClass('kwfLightboxAnimate');\n+                        Kwf.callOnContentReady(this.lightboxEl, {action: 'show'});\n+                        this.style.afterContentShown();\n+                        this.preloadLinks();\n+                    }).bind(this));\n+            }\n         }\n+        this.lightboxEl.addClass('kwfLightboxOpen');\n         this.style.afterShow(options);\n \n         Kwf.Statistics.count(this.href);\n     },\n     close: function(options) {\n+        $('html').removeClass('kwfup-lightboxActive');\n+        $('.kwfup-fixedContent').each(function(key, el){","path":"Kwf_js/EyeCandy/Lightbox/Lightbox.js","position":null,"original_position":264,"commit_id":"3d567d8652d6c34395a2b224c160a40b0d844377","original_commit_id":"59172c9b3dc171e15591399c32078226c9ab33f0","user":{"login":"nsams","id":50764,"avatar_url":"https://avatars.githubusercontent.com/u/50764?v=3","gravatar_id":"","url":"https://api.github.com/users/nsams","html_url":"https://github.com/nsams","followers_url":"https://api.github.com/users/nsams/followers","following_url":"https://api.github.com/users/nsams/following{/other_user}","gists_url":"https://api.github.com/users/nsams/gists{/gist_id}","starred_url":"https://api.github.com/users/nsams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsams/subscriptions","organizations_url":"https://api.github.com/users/nsams/orgs","repos_url":"https://api.github.com/users/nsams/repos","events_url":"https://api.github.com/users/nsams/events{/privacy}","received_events_url":"https://api.github.com/users/nsams/received_events","type":"User","site_admin":false},"body":"what is fixedContent?","created_at":"2015-10-15T14:47:29Z","updated_at":"2015-10-15T14:47:29Z","html_url":"https://github.com/koala-framework/koala-framework/pull/419#discussion_r42133322","pull_request_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419","_links":{"self":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments/42133322"},"html":{"href":"https://github.com/koala-framework/koala-framework/pull/419#discussion_r42133322"},"pull_request":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419"}}},"pull_request":{"url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419","id":47792796,"html_url":"https://github.com/koala-framework/koala-framework/pull/419","diff_url":"https://github.com/koala-framework/koala-framework/pull/419.diff","patch_url":"https://github.com/koala-framework/koala-framework/pull/419.patch","issue_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/419","number":419,"state":"open","locked":false,"title":"3.11 lightbox","user":{"login":"yacon","id":1352879,"avatar_url":"https://avatars.githubusercontent.com/u/1352879?v=3","gravatar_id":"","url":"https://api.github.com/users/yacon","html_url":"https://github.com/yacon","followers_url":"https://api.github.com/users/yacon/followers","following_url":"https://api.github.com/users/yacon/following{/other_user}","gists_url":"https://api.github.com/users/yacon/gists{/gist_id}","starred_url":"https://api.github.com/users/yacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacon/subscriptions","organizations_url":"https://api.github.com/users/yacon/orgs","repos_url":"https://api.github.com/users/yacon/repos","events_url":"https://api.github.com/users/yacon/events{/privacy}","received_events_url":"https://api.github.com/users/yacon/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-15T14:22:42Z","updated_at":"2015-10-15T14:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"021be528a4cbe0df377c276de7b39f5bc0dc2f09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419/commits","review_comments_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419/comments","review_comment_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/419/comments","statuses_url":"https://api.github.com/repos/koala-framework/koala-framework/statuses/3d567d8652d6c34395a2b224c160a40b0d844377","head":{"label":"yacon:3.10_lightbox","ref":"3.10_lightbox","sha":"3d567d8652d6c34395a2b224c160a40b0d844377","user":{"login":"yacon","id":1352879,"avatar_url":"https://avatars.githubusercontent.com/u/1352879?v=3","gravatar_id":"","url":"https://api.github.com/users/yacon","html_url":"https://github.com/yacon","followers_url":"https://api.github.com/users/yacon/followers","following_url":"https://api.github.com/users/yacon/following{/other_user}","gists_url":"https://api.github.com/users/yacon/gists{/gist_id}","starred_url":"https://api.github.com/users/yacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacon/subscriptions","organizations_url":"https://api.github.com/users/yacon/orgs","repos_url":"https://api.github.com/users/yacon/repos","events_url":"https://api.github.com/users/yacon/events{/privacy}","received_events_url":"https://api.github.com/users/yacon/received_events","type":"User","site_admin":false},"repo":{"id":6774516,"name":"koala-framework","full_name":"yacon/koala-framework","owner":{"login":"yacon","id":1352879,"avatar_url":"https://avatars.githubusercontent.com/u/1352879?v=3","gravatar_id":"","url":"https://api.github.com/users/yacon","html_url":"https://github.com/yacon","followers_url":"https://api.github.com/users/yacon/followers","following_url":"https://api.github.com/users/yacon/following{/other_user}","gists_url":"https://api.github.com/users/yacon/gists{/gist_id}","starred_url":"https://api.github.com/users/yacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacon/subscriptions","organizations_url":"https://api.github.com/users/yacon/orgs","repos_url":"https://api.github.com/users/yacon/repos","events_url":"https://api.github.com/users/yacon/events{/privacy}","received_events_url":"https://api.github.com/users/yacon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yacon/koala-framework","description":"Framework and CMS based on Zend Framework and ExtJS","fork":true,"url":"https://api.github.com/repos/yacon/koala-framework","forks_url":"https://api.github.com/repos/yacon/koala-framework/forks","keys_url":"https://api.github.com/repos/yacon/koala-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yacon/koala-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yacon/koala-framework/teams","hooks_url":"https://api.github.com/repos/yacon/koala-framework/hooks","issue_events_url":"https://api.github.com/repos/yacon/koala-framework/issues/events{/number}","events_url":"https://api.github.com/repos/yacon/koala-framework/events","assignees_url":"https://api.github.com/repos/yacon/koala-framework/assignees{/user}","branches_url":"https://api.github.com/repos/yacon/koala-framework/branches{/branch}","tags_url":"https://api.github.com/repos/yacon/koala-framework/tags","blobs_url":"https://api.github.com/repos/yacon/koala-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yacon/koala-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yacon/koala-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/yacon/koala-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yacon/koala-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/yacon/koala-framework/languages","stargazers_url":"https://api.github.com/repos/yacon/koala-framework/stargazers","contributors_url":"https://api.github.com/repos/yacon/koala-framework/contributors","subscribers_url":"https://api.github.com/repos/yacon/koala-framework/subscribers","subscription_url":"https://api.github.com/repos/yacon/koala-framework/subscription","commits_url":"https://api.github.com/repos/yacon/koala-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/yacon/koala-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/yacon/koala-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/yacon/koala-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/yacon/koala-framework/contents/{+path}","compare_url":"https://api.github.com/repos/yacon/koala-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yacon/koala-framework/merges","archive_url":"https://api.github.com/repos/yacon/koala-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yacon/koala-framework/downloads","issues_url":"https://api.github.com/repos/yacon/koala-framework/issues{/number}","pulls_url":"https://api.github.com/repos/yacon/koala-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/yacon/koala-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/yacon/koala-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yacon/koala-framework/labels{/name}","releases_url":"https://api.github.com/repos/yacon/koala-framework/releases{/id}","created_at":"2012-11-20T08:26:08Z","updated_at":"2015-05-02T08:48:03Z","pushed_at":"2015-10-15T14:45:22Z","git_url":"git://github.com/yacon/koala-framework.git","ssh_url":"git@github.com:yacon/koala-framework.git","clone_url":"https://github.com/yacon/koala-framework.git","svn_url":"https://github.com/yacon/koala-framework","homepage":"http://www.koala-framework.org/","size":62248,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.8"}},"base":{"label":"koala-framework:3.11","ref":"3.11","sha":"58b07c95e4629da244e2aa49b6132f0f37834454","user":{"login":"koala-framework","id":7679767,"avatar_url":"https://avatars.githubusercontent.com/u/7679767?v=3","gravatar_id":"","url":"https://api.github.com/users/koala-framework","html_url":"https://github.com/koala-framework","followers_url":"https://api.github.com/users/koala-framework/followers","following_url":"https://api.github.com/users/koala-framework/following{/other_user}","gists_url":"https://api.github.com/users/koala-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/koala-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koala-framework/subscriptions","organizations_url":"https://api.github.com/users/koala-framework/orgs","repos_url":"https://api.github.com/users/koala-framework/repos","events_url":"https://api.github.com/users/koala-framework/events{/privacy}","received_events_url":"https://api.github.com/users/koala-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":2466955,"name":"koala-framework","full_name":"koala-framework/koala-framework","owner":{"login":"koala-framework","id":7679767,"avatar_url":"https://avatars.githubusercontent.com/u/7679767?v=3","gravatar_id":"","url":"https://api.github.com/users/koala-framework","html_url":"https://github.com/koala-framework","followers_url":"https://api.github.com/users/koala-framework/followers","following_url":"https://api.github.com/users/koala-framework/following{/other_user}","gists_url":"https://api.github.com/users/koala-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/koala-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koala-framework/subscriptions","organizations_url":"https://api.github.com/users/koala-framework/orgs","repos_url":"https://api.github.com/users/koala-framework/repos","events_url":"https://api.github.com/users/koala-framework/events{/privacy}","received_events_url":"https://api.github.com/users/koala-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koala-framework/koala-framework","description":"Framework and CMS based on Zend Framework and ExtJS","fork":false,"url":"https://api.github.com/repos/koala-framework/koala-framework","forks_url":"https://api.github.com/repos/koala-framework/koala-framework/forks","keys_url":"https://api.github.com/repos/koala-framework/koala-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koala-framework/koala-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koala-framework/koala-framework/teams","hooks_url":"https://api.github.com/repos/koala-framework/koala-framework/hooks","issue_events_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/events{/number}","events_url":"https://api.github.com/repos/koala-framework/koala-framework/events","assignees_url":"https://api.github.com/repos/koala-framework/koala-framework/assignees{/user}","branches_url":"https://api.github.com/repos/koala-framework/koala-framework/branches{/branch}","tags_url":"https://api.github.com/repos/koala-framework/koala-framework/tags","blobs_url":"https://api.github.com/repos/koala-framework/koala-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koala-framework/koala-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koala-framework/koala-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/koala-framework/koala-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koala-framework/koala-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/koala-framework/koala-framework/languages","stargazers_url":"https://api.github.com/repos/koala-framework/koala-framework/stargazers","contributors_url":"https://api.github.com/repos/koala-framework/koala-framework/contributors","subscribers_url":"https://api.github.com/repos/koala-framework/koala-framework/subscribers","subscription_url":"https://api.github.com/repos/koala-framework/koala-framework/subscription","commits_url":"https://api.github.com/repos/koala-framework/koala-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/koala-framework/koala-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/koala-framework/koala-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/koala-framework/koala-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/koala-framework/koala-framework/contents/{+path}","compare_url":"https://api.github.com/repos/koala-framework/koala-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koala-framework/koala-framework/merges","archive_url":"https://api.github.com/repos/koala-framework/koala-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koala-framework/koala-framework/downloads","issues_url":"https://api.github.com/repos/koala-framework/koala-framework/issues{/number}","pulls_url":"https://api.github.com/repos/koala-framework/koala-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/koala-framework/koala-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/koala-framework/koala-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koala-framework/koala-framework/labels{/name}","releases_url":"https://api.github.com/repos/koala-framework/koala-framework/releases{/id}","created_at":"2011-09-27T10:36:51Z","updated_at":"2015-09-16T13:32:22Z","pushed_at":"2015-10-15T14:45:23Z","git_url":"git://github.com/koala-framework/koala-framework.git","ssh_url":"git@github.com:koala-framework/koala-framework.git","clone_url":"https://github.com/koala-framework/koala-framework.git","svn_url":"https://github.com/koala-framework/koala-framework","homepage":"http://www.koala-framework.org/","size":95877,"stargazers_count":35,"watchers_count":35,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":22,"forks":21,"open_issues":22,"watchers":35,"default_branch":"3.8"}},"_links":{"self":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419"},"html":{"href":"https://github.com/koala-framework/koala-framework/pull/419"},"issue":{"href":"https://api.github.com/repos/koala-framework/koala-framework/issues/419"},"comments":{"href":"https://api.github.com/repos/koala-framework/koala-framework/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koala-framework/koala-framework/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/koala-framework/koala-framework/statuses/3d567d8652d6c34395a2b224c160a40b0d844377"}}}}