{"action":"opened","number":1044,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044","id":34583687,"html_url":"https://github.com/checkstyle/checkstyle/pull/1044","diff_url":"https://github.com/checkstyle/checkstyle/pull/1044.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/1044.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1044","number":1044,"state":"open","locked":false,"title":"Make message-based checks invariant to Locale","user":{"login":"msteiger","id":1820007,"avatar_url":"https://avatars.githubusercontent.com/u/1820007?v=3","gravatar_id":"","url":"https://api.github.com/users/msteiger","html_url":"https://github.com/msteiger","followers_url":"https://api.github.com/users/msteiger/followers","following_url":"https://api.github.com/users/msteiger/following{/other_user}","gists_url":"https://api.github.com/users/msteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/msteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msteiger/subscriptions","organizations_url":"https://api.github.com/users/msteiger/orgs","repos_url":"https://api.github.com/users/msteiger/repos","events_url":"https://api.github.com/users/msteiger/events{/privacy}","received_events_url":"https://api.github.com/users/msteiger/received_events","type":"User","site_admin":false},"body":"This PR uses the `ROOT` locale for tests, rather than `ENGLISH` to fix compatibility issues on non-English systems.\r\n\r\nThe problem with `ENGLISH` is that Java searches for the file `messages_en.properties`, which does not exist. Instead of falling back to `messages.properties`, it tries to load the one for the current locale first. I'm not sure why it does that.\r\n\r\nIn any case, the correct way is to use `ROOT`, which explicitly uses the \"default\" and language-invariant file without language specifier.","created_at":"2015-05-02T09:49:56Z","updated_at":"2015-05-02T09:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1044/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/028c1b0088a479b9b8e662d8684c3d8586f4f489","head":{"label":"msteiger:fix_locale","ref":"fix_locale","sha":"028c1b0088a479b9b8e662d8684c3d8586f4f489","user":{"login":"msteiger","id":1820007,"avatar_url":"https://avatars.githubusercontent.com/u/1820007?v=3","gravatar_id":"","url":"https://api.github.com/users/msteiger","html_url":"https://github.com/msteiger","followers_url":"https://api.github.com/users/msteiger/followers","following_url":"https://api.github.com/users/msteiger/following{/other_user}","gists_url":"https://api.github.com/users/msteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/msteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msteiger/subscriptions","organizations_url":"https://api.github.com/users/msteiger/orgs","repos_url":"https://api.github.com/users/msteiger/repos","events_url":"https://api.github.com/users/msteiger/events{/privacy}","received_events_url":"https://api.github.com/users/msteiger/received_events","type":"User","site_admin":false},"repo":{"id":34939701,"name":"checkstyle","full_name":"msteiger/checkstyle","owner":{"login":"msteiger","id":1820007,"avatar_url":"https://avatars.githubusercontent.com/u/1820007?v=3","gravatar_id":"","url":"https://api.github.com/users/msteiger","html_url":"https://github.com/msteiger","followers_url":"https://api.github.com/users/msteiger/followers","following_url":"https://api.github.com/users/msteiger/following{/other_user}","gists_url":"https://api.github.com/users/msteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/msteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msteiger/subscriptions","organizations_url":"https://api.github.com/users/msteiger/orgs","repos_url":"https://api.github.com/users/msteiger/repos","events_url":"https://api.github.com/users/msteiger/events{/privacy}","received_events_url":"https://api.github.com/users/msteiger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msteiger/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/msteiger/checkstyle","forks_url":"https://api.github.com/repos/msteiger/checkstyle/forks","keys_url":"https://api.github.com/repos/msteiger/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msteiger/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msteiger/checkstyle/teams","hooks_url":"https://api.github.com/repos/msteiger/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/msteiger/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/msteiger/checkstyle/events","assignees_url":"https://api.github.com/repos/msteiger/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/msteiger/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/msteiger/checkstyle/tags","blobs_url":"https://api.github.com/repos/msteiger/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msteiger/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msteiger/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/msteiger/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msteiger/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/msteiger/checkstyle/languages","stargazers_url":"https://api.github.com/repos/msteiger/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/msteiger/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/msteiger/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/msteiger/checkstyle/subscription","commits_url":"https://api.github.com/repos/msteiger/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/msteiger/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/msteiger/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/msteiger/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/msteiger/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/msteiger/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msteiger/checkstyle/merges","archive_url":"https://api.github.com/repos/msteiger/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msteiger/checkstyle/downloads","issues_url":"https://api.github.com/repos/msteiger/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/msteiger/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/msteiger/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/msteiger/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msteiger/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/msteiger/checkstyle/releases{/id}","created_at":"2015-05-02T07:46:12Z","updated_at":"2015-05-02T07:46:16Z","pushed_at":"2015-05-02T09:42:45Z","git_url":"git://github.com/msteiger/checkstyle.git","ssh_url":"git@github.com:msteiger/checkstyle.git","clone_url":"https://github.com/msteiger/checkstyle.git","svn_url":"https://github.com/msteiger/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":53420,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"d784ab7f69d0194c242af17875cdb2f60a9fd5f7","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","created_at":"2013-08-31T02:05:05Z","updated_at":"2015-05-02T05:38:21Z","pushed_at":"2015-05-02T09:49:32Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":53420,"stargazers_count":310,"watchers_count":310,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":159,"forks":192,"open_issues":159,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/1044"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/1044"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/1044/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1044/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/028c1b0088a479b9b8e662d8684c3d8586f4f489"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":5}}