{"action":"created","comment":{"url":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments/28180653","id":28180653,"diff_hunk":"@@ -1100,7 +1106,8 @@ interface StreamableInterface\n      *\n      * @see seek()\n      * @link http://www.php.net/manual/en/function.fseek.php\n-     * @return bool Returns TRUE on success or FALSE on failure.\n+     * @return bool Returns TRUE on success.","path":"proposed/http-message.md","position":34,"original_position":34,"commit_id":"ad43b3c35963b6cd8eca0349970122da01c4e05b","original_commit_id":"4cc2282e03ccead2a9daa8abdf9d701b86aa4035","user":{"login":"mtdowling","id":190930,"avatar_url":"https://avatars.githubusercontent.com/u/190930?v=3","gravatar_id":"","url":"https://api.github.com/users/mtdowling","html_url":"https://github.com/mtdowling","followers_url":"https://api.github.com/users/mtdowling/followers","following_url":"https://api.github.com/users/mtdowling/following{/other_user}","gists_url":"https://api.github.com/users/mtdowling/gists{/gist_id}","starred_url":"https://api.github.com/users/mtdowling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtdowling/subscriptions","organizations_url":"https://api.github.com/users/mtdowling/orgs","repos_url":"https://api.github.com/users/mtdowling/repos","events_url":"https://api.github.com/users/mtdowling/events{/privacy}","received_events_url":"https://api.github.com/users/mtdowling/received_events","type":"User","site_admin":false},"body":"I apologize, I don't think I was being clear. This method says that it will throw a RuntimeException on error and will return `true` on success, with false not allowed. My point is that returning any value at all is unnecessary because the failure case here is to throw an exception meaning that the return value is irrelevant. I also don't think we need to return the value returned by an underlying fseek() or rewind() call as those also have a true/false return value which we have abstracted into throwing an exception.","created_at":"2015-04-10T21:08:43Z","updated_at":"2015-04-10T21:08:43Z","html_url":"https://github.com/php-fig/fig-standards/pull/504#discussion_r28180653","pull_request_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/504","_links":{"self":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments/28180653"},"html":{"href":"https://github.com/php-fig/fig-standards/pull/504#discussion_r28180653"},"pull_request":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/php-fig/fig-standards/pulls/504","id":33082445,"html_url":"https://github.com/php-fig/fig-standards/pull/504","diff_url":"https://github.com/php-fig/fig-standards/pull/504.diff","patch_url":"https://github.com/php-fig/fig-standards/pull/504.patch","issue_url":"https://api.github.com/repos/php-fig/fig-standards/issues/504","number":504,"state":"open","locked":false,"title":"[PSR-7] Use exceptions for error handling in streams","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"Per discussion:\n\n- https://groups.google.com/d/msgid/php-fig/d5a9b044-1862-4333-bb67-645de997078c%40googlegroups.com\n\n@ircmaxell indicates that raising exceptions is acceptable for StreamWrapper implementations, making it acceptable within this domain.\n\nThis patch modifies `StreamableInterface` methods that were following PHP stream error handling conventions (i.e., multiple return values, using int/bool returns to indicate errors) to instead raise `RuntimeException` instances.","created_at":"2015-04-10T20:51:56Z","updated_at":"2015-04-10T21:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04f1ae6a0a62610ef4c04f7323322a4a570ec83b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/504/commits","review_comments_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/504/comments","review_comment_url":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-fig/fig-standards/issues/504/comments","statuses_url":"https://api.github.com/repos/php-fig/fig-standards/statuses/ad43b3c35963b6cd8eca0349970122da01c4e05b","head":{"label":"weierophinney:feature/stream-exceptions","ref":"feature/stream-exceptions","sha":"ad43b3c35963b6cd8eca0349970122da01c4e05b","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"repo":{"id":1053294,"name":"fig-standards","full_name":"weierophinney/fig-standards","owner":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weierophinney/fig-standards","description":"Standards either proposed or approved by the Framework Interop Group","fork":true,"url":"https://api.github.com/repos/weierophinney/fig-standards","forks_url":"https://api.github.com/repos/weierophinney/fig-standards/forks","keys_url":"https://api.github.com/repos/weierophinney/fig-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weierophinney/fig-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weierophinney/fig-standards/teams","hooks_url":"https://api.github.com/repos/weierophinney/fig-standards/hooks","issue_events_url":"https://api.github.com/repos/weierophinney/fig-standards/issues/events{/number}","events_url":"https://api.github.com/repos/weierophinney/fig-standards/events","assignees_url":"https://api.github.com/repos/weierophinney/fig-standards/assignees{/user}","branches_url":"https://api.github.com/repos/weierophinney/fig-standards/branches{/branch}","tags_url":"https://api.github.com/repos/weierophinney/fig-standards/tags","blobs_url":"https://api.github.com/repos/weierophinney/fig-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weierophinney/fig-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weierophinney/fig-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/weierophinney/fig-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weierophinney/fig-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/weierophinney/fig-standards/languages","stargazers_url":"https://api.github.com/repos/weierophinney/fig-standards/stargazers","contributors_url":"https://api.github.com/repos/weierophinney/fig-standards/contributors","subscribers_url":"https://api.github.com/repos/weierophinney/fig-standards/subscribers","subscription_url":"https://api.github.com/repos/weierophinney/fig-standards/subscription","commits_url":"https://api.github.com/repos/weierophinney/fig-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/weierophinney/fig-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/weierophinney/fig-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/weierophinney/fig-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/weierophinney/fig-standards/contents/{+path}","compare_url":"https://api.github.com/repos/weierophinney/fig-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weierophinney/fig-standards/merges","archive_url":"https://api.github.com/repos/weierophinney/fig-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weierophinney/fig-standards/downloads","issues_url":"https://api.github.com/repos/weierophinney/fig-standards/issues{/number}","pulls_url":"https://api.github.com/repos/weierophinney/fig-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/weierophinney/fig-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/weierophinney/fig-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weierophinney/fig-standards/labels{/name}","releases_url":"https://api.github.com/repos/weierophinney/fig-standards/releases{/id}","created_at":"2010-11-05T05:05:40Z","updated_at":"2012-12-15T22:47:46Z","pushed_at":"2015-04-10T21:03:56Z","git_url":"git://github.com/weierophinney/fig-standards.git","ssh_url":"git@github.com:weierophinney/fig-standards.git","clone_url":"https://github.com/weierophinney/fig-standards.git","svn_url":"https://github.com/weierophinney/fig-standards","homepage":"","size":1646,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"php-fig:master","ref":"master","sha":"76569d86c01c7487929ffaa01df70e5a2e8bb121","user":{"login":"php-fig","id":468401,"avatar_url":"https://avatars.githubusercontent.com/u/468401?v=3","gravatar_id":"","url":"https://api.github.com/users/php-fig","html_url":"https://github.com/php-fig","followers_url":"https://api.github.com/users/php-fig/followers","following_url":"https://api.github.com/users/php-fig/following{/other_user}","gists_url":"https://api.github.com/users/php-fig/gists{/gist_id}","starred_url":"https://api.github.com/users/php-fig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-fig/subscriptions","organizations_url":"https://api.github.com/users/php-fig/orgs","repos_url":"https://api.github.com/users/php-fig/repos","events_url":"https://api.github.com/users/php-fig/events{/privacy}","received_events_url":"https://api.github.com/users/php-fig/received_events","type":"Organization","site_admin":false},"repo":{"id":1053270,"name":"fig-standards","full_name":"php-fig/fig-standards","owner":{"login":"php-fig","id":468401,"avatar_url":"https://avatars.githubusercontent.com/u/468401?v=3","gravatar_id":"","url":"https://api.github.com/users/php-fig","html_url":"https://github.com/php-fig","followers_url":"https://api.github.com/users/php-fig/followers","following_url":"https://api.github.com/users/php-fig/following{/other_user}","gists_url":"https://api.github.com/users/php-fig/gists{/gist_id}","starred_url":"https://api.github.com/users/php-fig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-fig/subscriptions","organizations_url":"https://api.github.com/users/php-fig/orgs","repos_url":"https://api.github.com/users/php-fig/repos","events_url":"https://api.github.com/users/php-fig/events{/privacy}","received_events_url":"https://api.github.com/users/php-fig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-fig/fig-standards","description":"Standards either proposed or approved by the Framework Interop Group","fork":false,"url":"https://api.github.com/repos/php-fig/fig-standards","forks_url":"https://api.github.com/repos/php-fig/fig-standards/forks","keys_url":"https://api.github.com/repos/php-fig/fig-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-fig/fig-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-fig/fig-standards/teams","hooks_url":"https://api.github.com/repos/php-fig/fig-standards/hooks","issue_events_url":"https://api.github.com/repos/php-fig/fig-standards/issues/events{/number}","events_url":"https://api.github.com/repos/php-fig/fig-standards/events","assignees_url":"https://api.github.com/repos/php-fig/fig-standards/assignees{/user}","branches_url":"https://api.github.com/repos/php-fig/fig-standards/branches{/branch}","tags_url":"https://api.github.com/repos/php-fig/fig-standards/tags","blobs_url":"https://api.github.com/repos/php-fig/fig-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-fig/fig-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-fig/fig-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-fig/fig-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-fig/fig-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/php-fig/fig-standards/languages","stargazers_url":"https://api.github.com/repos/php-fig/fig-standards/stargazers","contributors_url":"https://api.github.com/repos/php-fig/fig-standards/contributors","subscribers_url":"https://api.github.com/repos/php-fig/fig-standards/subscribers","subscription_url":"https://api.github.com/repos/php-fig/fig-standards/subscription","commits_url":"https://api.github.com/repos/php-fig/fig-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-fig/fig-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-fig/fig-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-fig/fig-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-fig/fig-standards/contents/{+path}","compare_url":"https://api.github.com/repos/php-fig/fig-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-fig/fig-standards/merges","archive_url":"https://api.github.com/repos/php-fig/fig-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-fig/fig-standards/downloads","issues_url":"https://api.github.com/repos/php-fig/fig-standards/issues{/number}","pulls_url":"https://api.github.com/repos/php-fig/fig-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/php-fig/fig-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/php-fig/fig-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-fig/fig-standards/labels{/name}","releases_url":"https://api.github.com/repos/php-fig/fig-standards/releases{/id}","created_at":"2010-11-05T04:44:12Z","updated_at":"2015-04-10T20:03:51Z","pushed_at":"2015-04-10T21:03:57Z","git_url":"git://github.com/php-fig/fig-standards.git","ssh_url":"git@github.com:php-fig/fig-standards.git","clone_url":"https://github.com/php-fig/fig-standards.git","svn_url":"https://github.com/php-fig/fig-standards","homepage":"http://www.php-fig.org/","size":6203,"stargazers_count":5867,"watchers_count":5867,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1413,"mirror_url":null,"open_issues_count":79,"forks":1413,"open_issues":79,"watchers":5867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/504"},"html":{"href":"https://github.com/php-fig/fig-standards/pull/504"},"issue":{"href":"https://api.github.com/repos/php-fig/fig-standards/issues/504"},"comments":{"href":"https://api.github.com/repos/php-fig/fig-standards/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-fig/fig-standards/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/php-fig/fig-standards/statuses/ad43b3c35963b6cd8eca0349970122da01c4e05b"}}}}