{"action":"closed","number":269,"pull_request":{"url":"https://api.github.com/repos/scala/pickling/pulls/269","id":27527600,"html_url":"https://github.com/scala/pickling/pull/269","diff_url":"https://github.com/scala/pickling/pull/269.diff","patch_url":"https://github.com/scala/pickling/pull/269.patch","issue_url":"https://api.github.com/repos/scala/pickling/issues/269","number":269,"state":"closed","locked":false,"title":"Convert pickle macro into regular method.","user":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"body":"* We have to leave around macro implementation for dynamic picklers\r\n* We can only convert `pickleInto` and `pickleTo` for now, as\r\n  the type trickery to do `PickleFormat` lookup and `U <:< PickleFormat.PickleType`\r\n  unification is gunky in regular methods.\r\n* We do not convert `unpickle` for now do to related GPL/runtime lookup\r\n  issues.\r\n\r\n\r\nReview by @phaller @heathermiller cc> @havocp","created_at":"2015-01-16T18:54:58Z","updated_at":"2015-01-18T15:01:38Z","closed_at":"2015-01-18T15:01:38Z","merged_at":null,"merge_commit_sha":"e5cae1c5aabe38f7353e45ca125675d4fb0e84a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala/pickling/pulls/269/commits","review_comments_url":"https://api.github.com/repos/scala/pickling/pulls/269/comments","review_comment_url":"https://api.github.com/repos/scala/pickling/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scala/pickling/issues/269/comments","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/25dff85434074623d9e100d2973216d1e1c20934","head":{"label":"jsuereth:wip/jsuereth-pickle-as-method","ref":"wip/jsuereth-pickle-as-method","sha":"25dff85434074623d9e100d2973216d1e1c20934","user":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"repo":{"id":29362737,"name":"pickling","full_name":"jsuereth/pickling","owner":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuereth/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":true,"url":"https://api.github.com/repos/jsuereth/pickling","forks_url":"https://api.github.com/repos/jsuereth/pickling/forks","keys_url":"https://api.github.com/repos/jsuereth/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuereth/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuereth/pickling/teams","hooks_url":"https://api.github.com/repos/jsuereth/pickling/hooks","issue_events_url":"https://api.github.com/repos/jsuereth/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/jsuereth/pickling/events","assignees_url":"https://api.github.com/repos/jsuereth/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/jsuereth/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/jsuereth/pickling/tags","blobs_url":"https://api.github.com/repos/jsuereth/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuereth/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuereth/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuereth/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuereth/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuereth/pickling/languages","stargazers_url":"https://api.github.com/repos/jsuereth/pickling/stargazers","contributors_url":"https://api.github.com/repos/jsuereth/pickling/contributors","subscribers_url":"https://api.github.com/repos/jsuereth/pickling/subscribers","subscription_url":"https://api.github.com/repos/jsuereth/pickling/subscription","commits_url":"https://api.github.com/repos/jsuereth/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuereth/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuereth/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuereth/pickling/issues/comments/{number}","contents_url":"https://api.github.com/repos/jsuereth/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/jsuereth/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuereth/pickling/merges","archive_url":"https://api.github.com/repos/jsuereth/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuereth/pickling/downloads","issues_url":"https://api.github.com/repos/jsuereth/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/jsuereth/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuereth/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuereth/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuereth/pickling/labels{/name}","releases_url":"https://api.github.com/repos/jsuereth/pickling/releases{/id}","created_at":"2015-01-16T18:53:05Z","updated_at":"2015-01-16T18:53:08Z","pushed_at":"2015-01-18T14:56:12Z","git_url":"git://github.com/jsuereth/pickling.git","ssh_url":"git@github.com:jsuereth/pickling.git","clone_url":"https://github.com/jsuereth/pickling.git","svn_url":"https://github.com/jsuereth/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":50792,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.10.x"}},"base":{"label":"scala:0.10.x","ref":"0.10.x","sha":"c0fc5df7784188cf470debb3f9d41adaf37df5a6","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":10566713,"name":"pickling","full_name":"scala/pickling","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":false,"url":"https://api.github.com/repos/scala/pickling","forks_url":"https://api.github.com/repos/scala/pickling/forks","keys_url":"https://api.github.com/repos/scala/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/pickling/teams","hooks_url":"https://api.github.com/repos/scala/pickling/hooks","issue_events_url":"https://api.github.com/repos/scala/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/scala/pickling/events","assignees_url":"https://api.github.com/repos/scala/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/scala/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/scala/pickling/tags","blobs_url":"https://api.github.com/repos/scala/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/pickling/languages","stargazers_url":"https://api.github.com/repos/scala/pickling/stargazers","contributors_url":"https://api.github.com/repos/scala/pickling/contributors","subscribers_url":"https://api.github.com/repos/scala/pickling/subscribers","subscription_url":"https://api.github.com/repos/scala/pickling/subscription","commits_url":"https://api.github.com/repos/scala/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/pickling/issues/comments/{number}","contents_url":"https://api.github.com/repos/scala/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/scala/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/pickling/merges","archive_url":"https://api.github.com/repos/scala/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/pickling/downloads","issues_url":"https://api.github.com/repos/scala/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/scala/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/pickling/labels{/name}","releases_url":"https://api.github.com/repos/scala/pickling/releases{/id}","created_at":"2013-06-08T09:37:07Z","updated_at":"2015-01-18T10:27:02Z","pushed_at":"2015-01-16T08:11:53Z","git_url":"git://github.com/scala/pickling.git","ssh_url":"git@github.com:scala/pickling.git","clone_url":"https://github.com/scala/pickling.git","svn_url":"https://github.com/scala/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":53025,"stargazers_count":478,"watchers_count":478,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":90,"forks":43,"open_issues":90,"watchers":478,"default_branch":"0.10.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/pickling/pulls/269"},"html":{"href":"https://github.com/scala/pickling/pull/269"},"issue":{"href":"https://api.github.com/repos/scala/pickling/issues/269"},"comments":{"href":"https://api.github.com/repos/scala/pickling/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/pickling/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/pickling/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scala/pickling/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/scala/pickling/statuses/25dff85434074623d9e100d2973216d1e1c20934"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":1,"commits":2,"additions":74,"deletions":2,"changed_files":4}}