{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/1734","labels_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1734/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1734/comments","events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1734/events","html_url":"https://github.com/bbatsov/rubocop/issues/1734","id":63575185,"number":1734,"title":"Hidden directories search performance decreased","user":{"login":"sometimesfood","id":153385,"avatar_url":"https://avatars.githubusercontent.com/u/153385?v=3","gravatar_id":"","url":"https://api.github.com/users/sometimesfood","html_url":"https://github.com/sometimesfood","followers_url":"https://api.github.com/users/sometimesfood/followers","following_url":"https://api.github.com/users/sometimesfood/following{/other_user}","gists_url":"https://api.github.com/users/sometimesfood/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesfood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesfood/subscriptions","organizations_url":"https://api.github.com/users/sometimesfood/orgs","repos_url":"https://api.github.com/users/sometimesfood/repos","events_url":"https://api.github.com/users/sometimesfood/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesfood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-22T20:50:21Z","updated_at":"2015-03-24T07:21:26Z","closed_at":null,"body":"While commit 5df9ffb seems to have fixed #1656, it seems to have introduced a significant drop in performance.\r\n\r\nI am using rubocop commit a1865b5 without a custom `.rubocop.yml`.\r\n\r\nWith `bundle install --path vendor`:\r\n```\r\n% time bundle exec rubocop    \r\nInspecting 75 files\r\n[…]\r\nbundle exec rubocop  9.69s user 0.31s system 98% cpu 10.131 total\r\n```\r\n\r\nIf I install my gems to `.bundle` (`bundle install --path .bundle`), performance decreases sharply:\r\n```\r\n% time bundle exec rubocop\r\nInspecting 75 files\r\n[…]\r\nbundle exec rubocop  30.91s user 1.55s system 95% cpu 33.914 total\r\n```\r\n\r\nSorry to keep bothering you about this, but as rubocop is becoming increasingly popular and many developers are relying on it, I feel that this could affect other projects as well. (My project has a relatively small number of dependencies – for a typical Rails project the effect of this change would probably be even more pronounced.)"},"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/85373665","html_url":"https://github.com/bbatsov/rubocop/issues/1734#issuecomment-85373665","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/1734","id":85373665,"user":{"login":"jonas054","id":336720,"avatar_url":"https://avatars.githubusercontent.com/u/336720?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas054","html_url":"https://github.com/jonas054","followers_url":"https://api.github.com/users/jonas054/followers","following_url":"https://api.github.com/users/jonas054/following{/other_user}","gists_url":"https://api.github.com/users/jonas054/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas054/subscriptions","organizations_url":"https://api.github.com/users/jonas054/orgs","repos_url":"https://api.github.com/users/jonas054/repos","events_url":"https://api.github.com/users/jonas054/events{/privacy}","received_events_url":"https://api.github.com/users/jonas054/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T07:21:26Z","updated_at":"2015-03-24T07:21:26Z","body":"@sometimesfood It's the other way around, right? Hidden directories are slower than excluded directories. At least that's what I get.\r\n\r\n@bquorning I think it's time to remove support for the old pattern style, but it won't solve the whole problem. There are some optimizations we could do to speed up the (non-)matching of hidden directories. I'll submit a PR soon so we can discuss whether the added code is justified."}}