{"action":"closed","number":1174,"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174","id":42593996,"html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1174","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1174.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1174.patch","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1174","number":1174,"state":"closed","locked":false,"title":"added react-overlays for base overlay components","user":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"body":"Step 1. just replaces the stuff that required minimal refactoring, and no api changes. The next step is to rewrite the Modal component.\r\n\r\nI am also unsure what we should do for components that are straight reexports: Position, Portal, Transition. Does it make sense to just re-export them? Or do we want to pull them out of our public api and point ppl to react overlays?\r\n\r\nThen there are components like Overlay with have reallly light additions to the base Overlay component","created_at":"2015-08-17T14:29:58Z","updated_at":"2015-08-23T23:31:25Z","closed_at":"2015-08-23T23:31:25Z","merged_at":"2015-08-23T23:31:25Z","merge_commit_sha":"2af6b734322e60dcad6fa0752ce00f46a7663542","assignee":null,"milestone":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones/5","html_url":"https://github.com/react-bootstrap/react-bootstrap/milestones/v0.25%20Release","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones/5/labels","id":1203444,"number":5,"title":"v0.25 Release","description":"","creator":{"login":"AlexKVal","id":847572,"avatar_url":"https://avatars.githubusercontent.com/u/847572?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKVal","html_url":"https://github.com/AlexKVal","followers_url":"https://api.github.com/users/AlexKVal/followers","following_url":"https://api.github.com/users/AlexKVal/following{/other_user}","gists_url":"https://api.github.com/users/AlexKVal/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKVal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKVal/subscriptions","organizations_url":"https://api.github.com/users/AlexKVal/orgs","repos_url":"https://api.github.com/users/AlexKVal/repos","events_url":"https://api.github.com/users/AlexKVal/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKVal/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2015-07-11T16:23:56Z","updated_at":"2015-08-23T23:31:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174/commits","review_comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174/comments","review_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1174/comments","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/97a7801ee9e3e925e9156b20e61e24e2c9284f8e","head":{"label":"react-bootstrap:react-overlays","ref":"react-overlays","sha":"97a7801ee9e3e925e9156b20e61e24e2c9284f8e","user":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":15480067,"name":"react-bootstrap","full_name":"react-bootstrap/react-bootstrap","owner":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-bootstrap/react-bootstrap","description":"Bootstrap 3 components built with React","fork":false,"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","forks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/forks","keys_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/events","assignees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/merges","archive_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/releases{/id}","created_at":"2013-12-27T19:06:07Z","updated_at":"2015-08-23T17:26:02Z","pushed_at":"2015-08-23T23:31:25Z","git_url":"git://github.com/react-bootstrap/react-bootstrap.git","ssh_url":"git@github.com:react-bootstrap/react-bootstrap.git","clone_url":"https://github.com/react-bootstrap/react-bootstrap.git","svn_url":"https://github.com/react-bootstrap/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":9614,"stargazers_count":3149,"watchers_count":3149,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"open_issues_count":59,"forks":522,"open_issues":59,"watchers":3149,"default_branch":"master"}},"base":{"label":"react-bootstrap:v0.25-rc","ref":"v0.25-rc","sha":"9dad63e03fe94d759c83b5fc3468a9e8dfcfa78c","user":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":15480067,"name":"react-bootstrap","full_name":"react-bootstrap/react-bootstrap","owner":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-bootstrap/react-bootstrap","description":"Bootstrap 3 components built with React","fork":false,"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","forks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/forks","keys_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/events","assignees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/merges","archive_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/releases{/id}","created_at":"2013-12-27T19:06:07Z","updated_at":"2015-08-23T17:26:02Z","pushed_at":"2015-08-23T23:31:25Z","git_url":"git://github.com/react-bootstrap/react-bootstrap.git","ssh_url":"git@github.com:react-bootstrap/react-bootstrap.git","clone_url":"https://github.com/react-bootstrap/react-bootstrap.git","svn_url":"https://github.com/react-bootstrap/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":9614,"stargazers_count":3149,"watchers_count":3149,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"open_issues_count":59,"forks":522,"open_issues":59,"watchers":3149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/1174"},"issue":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1174"},"comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1174/comments"},"review_comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174/comments"},"review_comment":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1174/commits"},"statuses":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/97a7801ee9e3e925e9156b20e61e24e2c9284f8e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":6,"additions":157,"deletions":1405,"changed_files":18}}