{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/42325029","id":42325029,"diff_hunk":"@@ -37,6 +37,10 @@ interface Element : Node {\n   DOMString? getAttribute(DOMString name);\n   [Pure]\n   DOMString? getAttributeNS(DOMString? namespace, DOMString localName);\n+  [Pure]\n+  DOMString? getAttributeNode(DOMString name);","path":"components/script/dom/webidls/Element.webidl","position":5,"original_position":5,"commit_id":"5c5c3253d17a8904da89ecc71270eae984bfd470","original_commit_id":"5c5c3253d17a8904da89ecc71270eae984bfd470","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"This is incorrect, see https://dom.spec.whatwg.org/#node","created_at":"2015-10-18T19:24:01Z","updated_at":"2015-10-18T19:24:01Z","html_url":"https://github.com/servo/servo/pull/8068#discussion_r42325029","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/8068","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/42325029"},"html":{"href":"https://github.com/servo/servo/pull/8068#discussion_r42325029"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/8068"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/8068","id":48014919,"html_url":"https://github.com/servo/servo/pull/8068","diff_url":"https://github.com/servo/servo/pull/8068.diff","patch_url":"https://github.com/servo/servo/pull/8068.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/8068","number":8068,"state":"open","locked":false,"title":"Implementing getAttributeNode() and similar methods","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"body":"Attempting to solve #8066 Does it look good so far @Manishearth ?\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/8068)\n<!-- Reviewable:end -->\n","created_at":"2015-10-18T19:00:07Z","updated_at":"2015-10-18T19:24:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62eb2187d6da2ca26e878f6e7e65e18edfaee6dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/8068/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/8068/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/8068/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/5c5c3253d17a8904da89ecc71270eae984bfd470","head":{"label":"martiansideofthemoon:my-code-fix","ref":"my-code-fix","sha":"5c5c3253d17a8904da89ecc71270eae984bfd470","user":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"repo":{"id":44195828,"name":"servo","full_name":"martiansideofthemoon/servo","owner":{"login":"martiansideofthemoon","id":8805240,"avatar_url":"https://avatars.githubusercontent.com/u/8805240?v=3","gravatar_id":"","url":"https://api.github.com/users/martiansideofthemoon","html_url":"https://github.com/martiansideofthemoon","followers_url":"https://api.github.com/users/martiansideofthemoon/followers","following_url":"https://api.github.com/users/martiansideofthemoon/following{/other_user}","gists_url":"https://api.github.com/users/martiansideofthemoon/gists{/gist_id}","starred_url":"https://api.github.com/users/martiansideofthemoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martiansideofthemoon/subscriptions","organizations_url":"https://api.github.com/users/martiansideofthemoon/orgs","repos_url":"https://api.github.com/users/martiansideofthemoon/repos","events_url":"https://api.github.com/users/martiansideofthemoon/events{/privacy}","received_events_url":"https://api.github.com/users/martiansideofthemoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martiansideofthemoon/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/martiansideofthemoon/servo","forks_url":"https://api.github.com/repos/martiansideofthemoon/servo/forks","keys_url":"https://api.github.com/repos/martiansideofthemoon/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martiansideofthemoon/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martiansideofthemoon/servo/teams","hooks_url":"https://api.github.com/repos/martiansideofthemoon/servo/hooks","issue_events_url":"https://api.github.com/repos/martiansideofthemoon/servo/issues/events{/number}","events_url":"https://api.github.com/repos/martiansideofthemoon/servo/events","assignees_url":"https://api.github.com/repos/martiansideofthemoon/servo/assignees{/user}","branches_url":"https://api.github.com/repos/martiansideofthemoon/servo/branches{/branch}","tags_url":"https://api.github.com/repos/martiansideofthemoon/servo/tags","blobs_url":"https://api.github.com/repos/martiansideofthemoon/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martiansideofthemoon/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martiansideofthemoon/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/martiansideofthemoon/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martiansideofthemoon/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/martiansideofthemoon/servo/languages","stargazers_url":"https://api.github.com/repos/martiansideofthemoon/servo/stargazers","contributors_url":"https://api.github.com/repos/martiansideofthemoon/servo/contributors","subscribers_url":"https://api.github.com/repos/martiansideofthemoon/servo/subscribers","subscription_url":"https://api.github.com/repos/martiansideofthemoon/servo/subscription","commits_url":"https://api.github.com/repos/martiansideofthemoon/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/martiansideofthemoon/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/martiansideofthemoon/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/martiansideofthemoon/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/martiansideofthemoon/servo/contents/{+path}","compare_url":"https://api.github.com/repos/martiansideofthemoon/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martiansideofthemoon/servo/merges","archive_url":"https://api.github.com/repos/martiansideofthemoon/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martiansideofthemoon/servo/downloads","issues_url":"https://api.github.com/repos/martiansideofthemoon/servo/issues{/number}","pulls_url":"https://api.github.com/repos/martiansideofthemoon/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/martiansideofthemoon/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/martiansideofthemoon/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martiansideofthemoon/servo/labels{/name}","releases_url":"https://api.github.com/repos/martiansideofthemoon/servo/releases{/id}","created_at":"2015-10-13T18:18:16Z","updated_at":"2015-10-13T18:03:07Z","pushed_at":"2015-10-18T19:03:45Z","git_url":"git://github.com/martiansideofthemoon/servo.git","ssh_url":"git@github.com:martiansideofthemoon/servo.git","clone_url":"https://github.com/martiansideofthemoon/servo.git","svn_url":"https://github.com/martiansideofthemoon/servo","homepage":"","size":142082,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"b847e4dd778e49ba60c786da4aa77813dee8b553","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-10-18T03:45:18Z","pushed_at":"2015-10-18T19:04:09Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":343695,"stargazers_count":5025,"watchers_count":5025,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":803,"mirror_url":null,"open_issues_count":1161,"forks":803,"open_issues":1161,"watchers":5025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/8068"},"html":{"href":"https://github.com/servo/servo/pull/8068"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/8068"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/8068/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/8068/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/8068/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/5c5c3253d17a8904da89ecc71270eae984bfd470"}}}}