{"action":"closed","number":1783,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/1783","id":40769622,"html_url":"https://github.com/pfsense/pfsense/pull/1783","diff_url":"https://github.com/pfsense/pfsense/pull/1783.diff","patch_url":"https://github.com/pfsense/pfsense/pull/1783.patch","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/1783","number":1783,"state":"closed","locked":false,"title":"Ignore DHCP pools that are out of range","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"body":"If the user changes the subnet of an interface then applies without adjusting the DHCP pool range/s to be in the new subnet, then an invalid dhcpd.conf is generated. The DHCP server complains about it and exits. If you have only 1 LAN with DHCP then it does not make a difference - you are not going to get DHCP whatever happens because there is no valid pool data. But if there are multiple LAN-style interfaces with DHCP then you can cause no DHCP-service on LAN when you are messing with settings on OPT1/OPT2...\r\n\r\nI did this to myself last night, and even after rebooting got no DHCP for either my LAN or OPT1, just because the OPT1 pool settings were bad.\r\n\r\nThis change checks that the pool ranges are in the interface subnet. If they are not, then they are excluded from dhcpd.conf and a notice os filed. The user gets the flashing notice stuff on the webGUI to tell them what is wrong. And any other good DHCP interfaces+pools continue to work.","created_at":"2015-07-24T12:24:22Z","updated_at":"2015-08-26T06:47:31Z","closed_at":"2015-08-26T06:47:31Z","merged_at":null,"merge_commit_sha":"a5ddf354cb6009973855882339e7acb881611419","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1783/commits","review_comments_url":"https://api.github.com/repos/pfsense/pfsense/pulls/1783/comments","review_comment_url":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/1783/comments","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/07d49376f389f025ae6a90fdfc7e0f1d91d803ce","head":{"label":"phil-davis:patch-5","ref":"patch-5","sha":"07d49376f389f025ae6a90fdfc7e0f1d91d803ce","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"repo":{"id":33725284,"name":"pfsense","full_name":"phil-davis/pfsense","owner":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil-davis/pfsense","description":"Main repository for pfSense","fork":true,"url":"https://api.github.com/repos/phil-davis/pfsense","forks_url":"https://api.github.com/repos/phil-davis/pfsense/forks","keys_url":"https://api.github.com/repos/phil-davis/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil-davis/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil-davis/pfsense/teams","hooks_url":"https://api.github.com/repos/phil-davis/pfsense/hooks","issue_events_url":"https://api.github.com/repos/phil-davis/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/phil-davis/pfsense/events","assignees_url":"https://api.github.com/repos/phil-davis/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/phil-davis/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/phil-davis/pfsense/tags","blobs_url":"https://api.github.com/repos/phil-davis/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil-davis/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil-davis/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil-davis/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil-davis/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/phil-davis/pfsense/languages","stargazers_url":"https://api.github.com/repos/phil-davis/pfsense/stargazers","contributors_url":"https://api.github.com/repos/phil-davis/pfsense/contributors","subscribers_url":"https://api.github.com/repos/phil-davis/pfsense/subscribers","subscription_url":"https://api.github.com/repos/phil-davis/pfsense/subscription","commits_url":"https://api.github.com/repos/phil-davis/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil-davis/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil-davis/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil-davis/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/phil-davis/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/phil-davis/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil-davis/pfsense/merges","archive_url":"https://api.github.com/repos/phil-davis/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil-davis/pfsense/downloads","issues_url":"https://api.github.com/repos/phil-davis/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/phil-davis/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/phil-davis/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/phil-davis/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil-davis/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/phil-davis/pfsense/releases{/id}","created_at":"2015-04-10T11:33:35Z","updated_at":"2015-04-29T12:34:22Z","pushed_at":"2015-08-26T06:45:04Z","git_url":"git://github.com/phil-davis/pfsense.git","ssh_url":"git@github.com:phil-davis/pfsense.git","clone_url":"https://github.com/phil-davis/pfsense.git","svn_url":"https://github.com/phil-davis/pfsense","homepage":"http://www.pfsense.org","size":66264,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfsense:master","ref":"master","sha":"f674922ee93a3bef6158754bc08d4a6b5ace0daa","user":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"repo":{"id":1740040,"name":"pfsense","full_name":"pfsense/pfsense","owner":{"login":"pfsense","id":3716965,"avatar_url":"https://avatars.githubusercontent.com/u/3716965?v=3","gravatar_id":"","url":"https://api.github.com/users/pfsense","html_url":"https://github.com/pfsense","followers_url":"https://api.github.com/users/pfsense/followers","following_url":"https://api.github.com/users/pfsense/following{/other_user}","gists_url":"https://api.github.com/users/pfsense/gists{/gist_id}","starred_url":"https://api.github.com/users/pfsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfsense/subscriptions","organizations_url":"https://api.github.com/users/pfsense/orgs","repos_url":"https://api.github.com/users/pfsense/repos","events_url":"https://api.github.com/users/pfsense/events{/privacy}","received_events_url":"https://api.github.com/users/pfsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfsense/pfsense","description":"Main repository for pfSense","fork":false,"url":"https://api.github.com/repos/pfsense/pfsense","forks_url":"https://api.github.com/repos/pfsense/pfsense/forks","keys_url":"https://api.github.com/repos/pfsense/pfsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfsense/pfsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfsense/pfsense/teams","hooks_url":"https://api.github.com/repos/pfsense/pfsense/hooks","issue_events_url":"https://api.github.com/repos/pfsense/pfsense/issues/events{/number}","events_url":"https://api.github.com/repos/pfsense/pfsense/events","assignees_url":"https://api.github.com/repos/pfsense/pfsense/assignees{/user}","branches_url":"https://api.github.com/repos/pfsense/pfsense/branches{/branch}","tags_url":"https://api.github.com/repos/pfsense/pfsense/tags","blobs_url":"https://api.github.com/repos/pfsense/pfsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfsense/pfsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfsense/pfsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfsense/pfsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfsense/pfsense/statuses/{sha}","languages_url":"https://api.github.com/repos/pfsense/pfsense/languages","stargazers_url":"https://api.github.com/repos/pfsense/pfsense/stargazers","contributors_url":"https://api.github.com/repos/pfsense/pfsense/contributors","subscribers_url":"https://api.github.com/repos/pfsense/pfsense/subscribers","subscription_url":"https://api.github.com/repos/pfsense/pfsense/subscription","commits_url":"https://api.github.com/repos/pfsense/pfsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfsense/pfsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfsense/pfsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfsense/pfsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfsense/pfsense/contents/{+path}","compare_url":"https://api.github.com/repos/pfsense/pfsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfsense/pfsense/merges","archive_url":"https://api.github.com/repos/pfsense/pfsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfsense/pfsense/downloads","issues_url":"https://api.github.com/repos/pfsense/pfsense/issues{/number}","pulls_url":"https://api.github.com/repos/pfsense/pfsense/pulls{/number}","milestones_url":"https://api.github.com/repos/pfsense/pfsense/milestones{/number}","notifications_url":"https://api.github.com/repos/pfsense/pfsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfsense/pfsense/labels{/name}","releases_url":"https://api.github.com/repos/pfsense/pfsense/releases{/id}","created_at":"2011-05-12T19:44:21Z","updated_at":"2015-08-24T10:35:42Z","pushed_at":"2015-08-26T06:45:51Z","git_url":"git://github.com/pfsense/pfsense.git","ssh_url":"git@github.com:pfsense/pfsense.git","clone_url":"https://github.com/pfsense/pfsense.git","svn_url":"https://github.com/pfsense/pfsense","homepage":"http://www.pfsense.org","size":98706,"stargazers_count":642,"watchers_count":642,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":73,"forks":407,"open_issues":73,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1783"},"html":{"href":"https://github.com/pfsense/pfsense/pull/1783"},"issue":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1783"},"comments":{"href":"https://api.github.com/repos/pfsense/pfsense/issues/1783/comments"},"review_comments":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1783/comments"},"review_comment":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfsense/pfsense/pulls/1783/commits"},"statuses":{"href":"https://api.github.com/repos/pfsense/pfsense/statuses/07d49376f389f025ae6a90fdfc7e0f1d91d803ce"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":8,"deletions":0,"changed_files":1}}