{"action":"closed","number":1282,"pull_request":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282","id":35935565,"html_url":"https://github.com/rtfd/readthedocs.org/pull/1282","diff_url":"https://github.com/rtfd/readthedocs.org/pull/1282.diff","patch_url":"https://github.com/rtfd/readthedocs.org/pull/1282.patch","issue_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/1282","number":1282,"state":"closed","locked":false,"title":"Mocking os.path.exists in test_builds.BuildTests.test_build","user":{"login":"gregmuellegger","id":88278,"avatar_url":"https://avatars.githubusercontent.com/u/88278?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmuellegger","html_url":"https://github.com/gregmuellegger","followers_url":"https://api.github.com/users/gregmuellegger/followers","following_url":"https://api.github.com/users/gregmuellegger/following{/other_user}","gists_url":"https://api.github.com/users/gregmuellegger/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmuellegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmuellegger/subscriptions","organizations_url":"https://api.github.com/users/gregmuellegger/orgs","repos_url":"https://api.github.com/users/gregmuellegger/repos","events_url":"https://api.github.com/users/gregmuellegger/events{/privacy}","received_events_url":"https://api.github.com/users/gregmuellegger/received_events","type":"User","site_admin":false},"body":"Mocking `os.path.exists´ in `rtd_tests.test_builds.BuildTests.test_build` in order to simulate a successfull project checkout including the conf.py file defined in the Project model.\r\n\r\nThat should fix the currently broken build, see https://travis-ci.org/rtfd/readthedocs.org/builds/62574036\r\n\r\nI'm not sure if that is the way to go as it more or less silences the issue that the `Project` model touches the filesystem. The filesystem access should be encapsulated somehow so that it can easily be switched out. But that might be a bigger task. Better to fix the mocks now to get the builds back to green :) ","created_at":"2015-05-21T13:53:20Z","updated_at":"2015-05-21T15:42:44Z","closed_at":"2015-05-21T15:42:44Z","merged_at":"2015-05-21T15:42:44Z","merge_commit_sha":"93744bb14510db7f0fb34909a329aaa6408d5064","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282/commits","review_comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282/comments","review_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/1282/comments","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/ab379c0571f32ab7838760acf04fc062cba3e745","head":{"label":"gregmuellegger:pr/fix-build-tests","ref":"pr/fix-build-tests","sha":"ab379c0571f32ab7838760acf04fc062cba3e745","user":{"login":"gregmuellegger","id":88278,"avatar_url":"https://avatars.githubusercontent.com/u/88278?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmuellegger","html_url":"https://github.com/gregmuellegger","followers_url":"https://api.github.com/users/gregmuellegger/followers","following_url":"https://api.github.com/users/gregmuellegger/following{/other_user}","gists_url":"https://api.github.com/users/gregmuellegger/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmuellegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmuellegger/subscriptions","organizations_url":"https://api.github.com/users/gregmuellegger/orgs","repos_url":"https://api.github.com/users/gregmuellegger/repos","events_url":"https://api.github.com/users/gregmuellegger/events{/privacy}","received_events_url":"https://api.github.com/users/gregmuellegger/received_events","type":"User","site_admin":false},"repo":{"id":26315447,"name":"readthedocs.org","full_name":"gregmuellegger/readthedocs.org","owner":{"login":"gregmuellegger","id":88278,"avatar_url":"https://avatars.githubusercontent.com/u/88278?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmuellegger","html_url":"https://github.com/gregmuellegger","followers_url":"https://api.github.com/users/gregmuellegger/followers","following_url":"https://api.github.com/users/gregmuellegger/following{/other_user}","gists_url":"https://api.github.com/users/gregmuellegger/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmuellegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmuellegger/subscriptions","organizations_url":"https://api.github.com/users/gregmuellegger/orgs","repos_url":"https://api.github.com/users/gregmuellegger/repos","events_url":"https://api.github.com/users/gregmuellegger/events{/privacy}","received_events_url":"https://api.github.com/users/gregmuellegger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregmuellegger/readthedocs.org","description":"source code to readthedocs.org","fork":true,"url":"https://api.github.com/repos/gregmuellegger/readthedocs.org","forks_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/forks","keys_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/events","assignees_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/merges","archive_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/gregmuellegger/readthedocs.org/releases{/id}","created_at":"2014-11-07T10:41:47Z","updated_at":"2015-05-21T12:22:02Z","pushed_at":"2015-05-21T13:57:24Z","git_url":"git://github.com/gregmuellegger/readthedocs.org.git","ssh_url":"git@github.com:gregmuellegger/readthedocs.org.git","clone_url":"https://github.com/gregmuellegger/readthedocs.org.git","svn_url":"https://github.com/gregmuellegger/readthedocs.org","homepage":"http://rtfd.org/","size":30861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rtfd:master","ref":"master","sha":"a2428aed605bf004e4b43a9ecc1cc5494384bcb0","user":{"login":"rtfd","id":366329,"avatar_url":"https://avatars.githubusercontent.com/u/366329?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"name":"readthedocs.org","full_name":"rtfd/readthedocs.org","owner":{"login":"rtfd","id":366329,"avatar_url":"https://avatars.githubusercontent.com/u/366329?v=3","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtfd/readthedocs.org","description":"source code to readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","created_at":"2010-08-16T19:18:06Z","updated_at":"2015-05-21T15:33:56Z","pushed_at":"2015-05-21T15:42:44Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"http://rtfd.org/","size":42346,"stargazers_count":1842,"watchers_count":1842,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":808,"mirror_url":null,"open_issues_count":224,"forks":808,"open_issues":224,"watchers":1842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/1282"},"issue":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/1282"},"comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/1282/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/1282/commits"},"statuses":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/ab379c0571f32ab7838760acf04fc062cba3e745"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ericholscher","id":25510,"avatar_url":"https://avatars.githubusercontent.com/u/25510?v=3","gravatar_id":"","url":"https://api.github.com/users/ericholscher","html_url":"https://github.com/ericholscher","followers_url":"https://api.github.com/users/ericholscher/followers","following_url":"https://api.github.com/users/ericholscher/following{/other_user}","gists_url":"https://api.github.com/users/ericholscher/gists{/gist_id}","starred_url":"https://api.github.com/users/ericholscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericholscher/subscriptions","organizations_url":"https://api.github.com/users/ericholscher/orgs","repos_url":"https://api.github.com/users/ericholscher/repos","events_url":"https://api.github.com/users/ericholscher/events{/privacy}","received_events_url":"https://api.github.com/users/ericholscher/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":9,"changed_files":1}}