{"action":"opened","number":151,"pull_request":{"url":"https://api.github.com/repos/cc65/cc65/pulls/151","id":31154525,"html_url":"https://github.com/cc65/cc65/pull/151","diff_url":"https://github.com/cc65/cc65/pull/151.diff","patch_url":"https://github.com/cc65/cc65/pull/151.patch","issue_url":"https://api.github.com/repos/cc65/cc65/issues/151","number":151,"state":"open","locked":false,"title":"Make __fastcall__ be the default calling convention.","user":{"login":"greg-king5","id":4145570,"avatar_url":"https://avatars.githubusercontent.com/u/4145570?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-king5","html_url":"https://github.com/greg-king5","followers_url":"https://api.github.com/users/greg-king5/followers","following_url":"https://api.github.com/users/greg-king5/following{/other_user}","gists_url":"https://api.github.com/users/greg-king5/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-king5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-king5/subscriptions","organizations_url":"https://api.github.com/users/greg-king5/orgs","repos_url":"https://api.github.com/users/greg-king5/repos","events_url":"https://api.github.com/users/greg-king5/events{/privacy}","received_events_url":"https://api.github.com/users/greg-king5/received_events","type":"User","site_admin":false},"body":"[Alan Cox's message thread](http://www.cc65.org/mailarchive/2015-01/11694.html) on the cc65 mailing list gave me the clues that I needed to do this upgrade.  Thanks to him, I knew where to look for much of the code that needed to be changed.\r\n\r\nUz had implemented `__cdecl__` as the name of the original calling convention; but, he had not changed a mask-constant argument that recognized only `__fastcall__`.  I fixed it; and, I added:\r\n* code to move both calling convention tags from pointers to function prototypes;\r\n* error traps for some coding mistakes;\r\n* and, the meat of this pull request:\r\n  * in the code generator, everywhere that Uz tested a function for `__fastcall__`, I test for not-variadic and not-`__cdecl__`.  Therefore, functions default to fastcalling.","created_at":"2015-03-13T19:02:21Z","updated_at":"2015-03-13T19:02:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cc65/cc65/pulls/151/commits","review_comments_url":"https://api.github.com/repos/cc65/cc65/pulls/151/comments","review_comment_url":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cc65/cc65/issues/151/comments","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/b452bdc5e46ce6626293ba8ac1f8a4a9f37f73b6","head":{"label":"greg-king5:fastcall","ref":"fastcall","sha":"b452bdc5e46ce6626293ba8ac1f8a4a9f37f73b6","user":{"login":"greg-king5","id":4145570,"avatar_url":"https://avatars.githubusercontent.com/u/4145570?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-king5","html_url":"https://github.com/greg-king5","followers_url":"https://api.github.com/users/greg-king5/followers","following_url":"https://api.github.com/users/greg-king5/following{/other_user}","gists_url":"https://api.github.com/users/greg-king5/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-king5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-king5/subscriptions","organizations_url":"https://api.github.com/users/greg-king5/orgs","repos_url":"https://api.github.com/users/greg-king5/repos","events_url":"https://api.github.com/users/greg-king5/events{/privacy}","received_events_url":"https://api.github.com/users/greg-king5/received_events","type":"User","site_admin":false},"repo":{"id":9601731,"name":"cc65","full_name":"greg-king5/cc65","owner":{"login":"greg-king5","id":4145570,"avatar_url":"https://avatars.githubusercontent.com/u/4145570?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-king5","html_url":"https://github.com/greg-king5","followers_url":"https://api.github.com/users/greg-king5/followers","following_url":"https://api.github.com/users/greg-king5/following{/other_user}","gists_url":"https://api.github.com/users/greg-king5/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-king5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-king5/subscriptions","organizations_url":"https://api.github.com/users/greg-king5/orgs","repos_url":"https://api.github.com/users/greg-king5/repos","events_url":"https://api.github.com/users/greg-king5/events{/privacy}","received_events_url":"https://api.github.com/users/greg-king5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg-king5/cc65","description":"CC65 — A freeware C compiler for 6502-based systems.","fork":true,"url":"https://api.github.com/repos/greg-king5/cc65","forks_url":"https://api.github.com/repos/greg-king5/cc65/forks","keys_url":"https://api.github.com/repos/greg-king5/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg-king5/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg-king5/cc65/teams","hooks_url":"https://api.github.com/repos/greg-king5/cc65/hooks","issue_events_url":"https://api.github.com/repos/greg-king5/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/greg-king5/cc65/events","assignees_url":"https://api.github.com/repos/greg-king5/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/greg-king5/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/greg-king5/cc65/tags","blobs_url":"https://api.github.com/repos/greg-king5/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg-king5/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg-king5/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg-king5/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg-king5/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/greg-king5/cc65/languages","stargazers_url":"https://api.github.com/repos/greg-king5/cc65/stargazers","contributors_url":"https://api.github.com/repos/greg-king5/cc65/contributors","subscribers_url":"https://api.github.com/repos/greg-king5/cc65/subscribers","subscription_url":"https://api.github.com/repos/greg-king5/cc65/subscription","commits_url":"https://api.github.com/repos/greg-king5/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg-king5/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg-king5/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg-king5/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg-king5/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/greg-king5/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg-king5/cc65/merges","archive_url":"https://api.github.com/repos/greg-king5/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg-king5/cc65/downloads","issues_url":"https://api.github.com/repos/greg-king5/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/greg-king5/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/greg-king5/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/greg-king5/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg-king5/cc65/labels{/name}","releases_url":"https://api.github.com/repos/greg-king5/cc65/releases{/id}","created_at":"2013-04-22T15:09:08Z","updated_at":"2015-03-09T15:43:24Z","pushed_at":"2015-03-13T16:20:14Z","git_url":"git://github.com/greg-king5/cc65.git","ssh_url":"git@github.com:greg-king5/cc65.git","clone_url":"https://github.com/greg-king5/cc65.git","svn_url":"https://github.com/greg-king5/cc65","homepage":"http://cc65.github.io/cc65/","size":21027,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cc65:master","ref":"master","sha":"f014800d3c0cd2ca400e81038c713379e34198d0","user":{"login":"cc65","id":6959645,"avatar_url":"https://avatars.githubusercontent.com/u/6959645?v=3","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"repo":{"id":8932489,"name":"cc65","full_name":"cc65/cc65","owner":{"login":"cc65","id":6959645,"avatar_url":"https://avatars.githubusercontent.com/u/6959645?v=3","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cc65/cc65","description":"cc65 - a freeware C compiler for 6502 based systems -","fork":false,"url":"https://api.github.com/repos/cc65/cc65","forks_url":"https://api.github.com/repos/cc65/cc65/forks","keys_url":"https://api.github.com/repos/cc65/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cc65/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cc65/cc65/teams","hooks_url":"https://api.github.com/repos/cc65/cc65/hooks","issue_events_url":"https://api.github.com/repos/cc65/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/cc65/cc65/events","assignees_url":"https://api.github.com/repos/cc65/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/cc65/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/cc65/cc65/tags","blobs_url":"https://api.github.com/repos/cc65/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cc65/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cc65/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/cc65/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/cc65/cc65/languages","stargazers_url":"https://api.github.com/repos/cc65/cc65/stargazers","contributors_url":"https://api.github.com/repos/cc65/cc65/contributors","subscribers_url":"https://api.github.com/repos/cc65/cc65/subscribers","subscription_url":"https://api.github.com/repos/cc65/cc65/subscription","commits_url":"https://api.github.com/repos/cc65/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/cc65/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/cc65/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/cc65/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/cc65/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/cc65/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cc65/cc65/merges","archive_url":"https://api.github.com/repos/cc65/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cc65/cc65/downloads","issues_url":"https://api.github.com/repos/cc65/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/cc65/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/cc65/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/cc65/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cc65/cc65/labels{/name}","releases_url":"https://api.github.com/repos/cc65/cc65/releases{/id}","created_at":"2013-03-21T15:56:48Z","updated_at":"2015-03-11T13:25:00Z","pushed_at":"2015-03-09T14:35:26Z","git_url":"git://github.com/cc65/cc65.git","ssh_url":"git@github.com:cc65/cc65.git","clone_url":"https://github.com/cc65/cc65.git","svn_url":"https://github.com/cc65/cc65","homepage":"http://cc65.github.io/cc65","size":398907,"stargazers_count":120,"watchers_count":120,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":1,"forks":43,"open_issues":1,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cc65/cc65/pulls/151"},"html":{"href":"https://github.com/cc65/cc65/pull/151"},"issue":{"href":"https://api.github.com/repos/cc65/cc65/issues/151"},"comments":{"href":"https://api.github.com/repos/cc65/cc65/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/cc65/cc65/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cc65/cc65/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/cc65/cc65/statuses/b452bdc5e46ce6626293ba8ac1f8a4a9f37f73b6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":196,"deletions":145,"changed_files":18}}