{"action":"created","issue":{"url":"https://api.github.com/repos/nilearn/nilearn/issues/693","labels_url":"https://api.github.com/repos/nilearn/nilearn/issues/693/labels{/name}","comments_url":"https://api.github.com/repos/nilearn/nilearn/issues/693/comments","events_url":"https://api.github.com/repos/nilearn/nilearn/issues/693/events","html_url":"https://github.com/nilearn/nilearn/pull/693","id":95461560,"number":693,"title":"[MRG] Dictionary learning + nilearn.decomposition refactoring","user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-16T15:36:20Z","updated_at":"2015-07-20T11:35:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/693","html_url":"https://github.com/nilearn/nilearn/pull/693","diff_url":"https://github.com/nilearn/nilearn/pull/693.diff","patch_url":"https://github.com/nilearn/nilearn/pull/693.patch"},"body":"Decomposition estimators (`DictLearning` / `MultiPCA`) now inherit a  `DecompositionEstimator`.\r\n\r\nLoading of data is made through a `PCAMultiNiftiMasker`, which loads data from files and compress it.\r\n\r\nPotentially, the function check_masker could solve issue #688, as it factorizes the input checking of estimator to which you provide either a masker or parameters for a mask. It is tuned to be able to use `PCAMultiNiftiMasker`"},"comment":{"url":"https://api.github.com/repos/nilearn/nilearn/issues/comments/122855593","html_url":"https://github.com/nilearn/nilearn/pull/693#issuecomment-122855593","issue_url":"https://api.github.com/repos/nilearn/nilearn/issues/693","id":122855593,"user":{"login":"arthurmensch","id":4078691,"avatar_url":"https://avatars.githubusercontent.com/u/4078691?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurmensch","html_url":"https://github.com/arthurmensch","followers_url":"https://api.github.com/users/arthurmensch/followers","following_url":"https://api.github.com/users/arthurmensch/following{/other_user}","gists_url":"https://api.github.com/users/arthurmensch/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmensch/subscriptions","organizations_url":"https://api.github.com/users/arthurmensch/orgs","repos_url":"https://api.github.com/users/arthurmensch/repos","events_url":"https://api.github.com/users/arthurmensch/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmensch/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T11:35:43Z","updated_at":"2015-07-20T11:35:43Z","body":"I moved the fast concatenation to a separate _utils function. For the moment you can observe than multi_pca and dict_learning has a few common lines that could be factorized, but I think that these belongs to the own logic of both objects so it may not be worth.\r\n\r\nIn term of merging strategy, I merged PR #702 for testing purpose on this PR, but I can remove the commits for this PR easily, so we can merge this PR on top of PR #702"}}