{"action":"created","issue":{"url":"https://api.github.com/repos/spree/spree/issues/6001","labels_url":"https://api.github.com/repos/spree/spree/issues/6001/labels{/name}","comments_url":"https://api.github.com/repos/spree/spree/issues/6001/comments","events_url":"https://api.github.com/repos/spree/spree/issues/6001/events","html_url":"https://github.com/spree/spree/pull/6001","id":56507528,"number":6001,"title":"Attach address to shipment","user":{"login":"reinaris","id":106335,"avatar_url":"https://avatars.githubusercontent.com/u/106335?v=3","gravatar_id":"","url":"https://api.github.com/users/reinaris","html_url":"https://github.com/reinaris","followers_url":"https://api.github.com/users/reinaris/followers","following_url":"https://api.github.com/users/reinaris/following{/other_user}","gists_url":"https://api.github.com/users/reinaris/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaris/subscriptions","organizations_url":"https://api.github.com/users/reinaris/orgs","repos_url":"https://api.github.com/users/reinaris/repos","events_url":"https://api.github.com/users/reinaris/events{/privacy}","received_events_url":"https://api.github.com/users/reinaris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-04T10:13:21Z","updated_at":"2015-02-10T12:12:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/6001","html_url":"https://github.com/spree/spree/pull/6001","diff_url":"https://github.com/spree/spree/pull/6001.diff","patch_url":"https://github.com/spree/spree/pull/6001.patch"},"body":"Currently a shipment address is stored on the order.\r\nI'm working on this feature where you can change the address per shipment.\r\n\r\nThe address is still stored on the order by default, but now you can supply a new address to a single shipment. Very useful if you have multiple shipments.\r\n\r\nThe best way to explain is with screenshots:\r\n\r\n## Change address feature on the order/shipment page\r\n![screen_shot_2015-02-04_at_09_54_34](https://cloud.githubusercontent.com/assets/106335/6038408/addcca0a-ac54-11e4-8648-7c0a78541c14.png)\r\n\r\n## Supply a new address modal\r\n![screen_shot_2015-02-04_at_09_55_23](https://cloud.githubusercontent.com/assets/106335/6038412/b1da9524-ac54-11e4-9edf-0e9052594aec.png)\r\n\r\n## A different address for each shipment\r\n![screen_shot_2015-02-04_at_09_55_50](https://cloud.githubusercontent.com/assets/106335/6038419/c3adf1d8-ac54-11e4-9a2b-6617c6da5cad.png)\r\n\r\nIt still needs:\r\n1) Specs\r\n\r\nWhile working on this feature a couple of things came up to discuss:\r\n1) Why not store the address to a shipment by default\r\n2) In this version (0.1) I only made it possible to add a new address to a shipment. But it should be nicer to also be able to change the current address. I din't took this approach because it is not clear that you're editing the order address (if you didn't created a new address for a shipment first).\r\n3) In general I think we need to think about the order.ship_address comparing to saving the address to a shipment.\r\n\r\nI think even this current PR is very usable, but it needs some discussion for the future.\r\n\r\nLet me know what you think about this!"},"comment":{"url":"https://api.github.com/repos/spree/spree/issues/comments/73689707","html_url":"https://github.com/spree/spree/pull/6001#issuecomment-73689707","issue_url":"https://api.github.com/repos/spree/spree/issues/6001","id":73689707,"user":{"login":"reinaris","id":106335,"avatar_url":"https://avatars.githubusercontent.com/u/106335?v=3","gravatar_id":"","url":"https://api.github.com/users/reinaris","html_url":"https://github.com/reinaris","followers_url":"https://api.github.com/users/reinaris/followers","following_url":"https://api.github.com/users/reinaris/following{/other_user}","gists_url":"https://api.github.com/users/reinaris/gists{/gist_id}","starred_url":"https://api.github.com/users/reinaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinaris/subscriptions","organizations_url":"https://api.github.com/users/reinaris/orgs","repos_url":"https://api.github.com/users/reinaris/repos","events_url":"https://api.github.com/users/reinaris/events{/privacy}","received_events_url":"https://api.github.com/users/reinaris/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T12:12:40Z","updated_at":"2015-02-10T12:12:40Z","body":"I did more work to make this user friendly and solid.\r\nSome screens!\r\n\r\n## Order customer details page\r\n![screen_shot_2015-02-10_at_11_59_54](https://cloud.githubusercontent.com/assets/106335/6126909/1e2b5bf6-b11d-11e4-8e95-ff323a7e692f.png)\r\n\r\n## Order shipments page\r\n![screen_shot_2015-02-10_at_12_00_15](https://cloud.githubusercontent.com/assets/106335/6126910/21527148-b11d-11e4-9b23-a6733cd1ddc6.png)\r\n\r\n## Change a shipment address\r\n![screen_shot_2015-02-10_at_12_00_44](https://cloud.githubusercontent.com/assets/106335/6126913/2fdf3e30-b11d-11e4-9db8-077447bc4f62.png)\r\n\r\nIn my opinion this works perfect if you need to edit shipment addresses. The address is in the same place as the other shipment info (tracking number, shipping method etc.). Not at the customer page anymore what makes sense to me.\r\n\r\nThe feature to apply a changed shipment address to multiple shipments makes it easy to update multiple shipments.\r\n\r\nA shipment address is never updated but a new one is created, so it's immutable.\r\nWe took this approach so you will never create a situation where a shipment address is changed and an other shipment address changed as well while the user didn't noticed.\r\n\r\nOf course this needs some specs but I first like to hear your opinion.\r\nFrom a UI view this is a nice improvement."}}