{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/31597600","id":31597600,"diff_hunk":"@@ -66,7 +66,12 @@ func init() {\n func runTrust(args []string) (exit int) {\n \tif flagPrefix == \"\" && !flagRoot {\n \t\tif len(args) != 0 {\n-\t\t\tstderr(\"--root required for non-prefixed (root) keys\")\n+\t\t\trootKeyName := args[0]\n+\t\t\tstderr(`Prevented potentially dangerous unbounded trust of all containers signed by keys from \"%s\"\n+To contintue trusting this root domain:","path":"rkt/trust.go","position":7,"original_position":7,"commit_id":"2aad923c04cd6accf73b670aa152d7f7d44ecd5b","original_commit_id":"2aad923c04cd6accf73b670aa152d7f7d44ecd5b","user":{"login":"nederdirk","id":778965,"avatar_url":"https://avatars.githubusercontent.com/u/778965?v=3","gravatar_id":"","url":"https://api.github.com/users/nederdirk","html_url":"https://github.com/nederdirk","followers_url":"https://api.github.com/users/nederdirk/followers","following_url":"https://api.github.com/users/nederdirk/following{/other_user}","gists_url":"https://api.github.com/users/nederdirk/gists{/gist_id}","starred_url":"https://api.github.com/users/nederdirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nederdirk/subscriptions","organizations_url":"https://api.github.com/users/nederdirk/orgs","repos_url":"https://api.github.com/users/nederdirk/repos","events_url":"https://api.github.com/users/nederdirk/events{/privacy}","received_events_url":"https://api.github.com/users/nederdirk/received_events","type":"User","site_admin":false},"body":"good catch!","created_at":"2015-06-03T06:51:57Z","updated_at":"2015-06-03T06:51:57Z","html_url":"https://github.com/coreos/rkt/pull/979#discussion_r31597600","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/31597600"},"html":{"href":"https://github.com/coreos/rkt/pull/979#discussion_r31597600"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/979","id":36765454,"html_url":"https://github.com/coreos/rkt/pull/979","diff_url":"https://github.com/coreos/rkt/pull/979.diff","patch_url":"https://github.com/coreos/rkt/pull/979.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/979","number":979,"state":"open","locked":false,"title":"trust: expand message for invalid command","user":{"login":"nederdirk","id":778965,"avatar_url":"https://avatars.githubusercontent.com/u/778965?v=3","gravatar_id":"","url":"https://api.github.com/users/nederdirk","html_url":"https://github.com/nederdirk","followers_url":"https://api.github.com/users/nederdirk/followers","following_url":"https://api.github.com/users/nederdirk/following{/other_user}","gists_url":"https://api.github.com/users/nederdirk/gists{/gist_id}","starred_url":"https://api.github.com/users/nederdirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nederdirk/subscriptions","organizations_url":"https://api.github.com/users/nederdirk/orgs","repos_url":"https://api.github.com/users/nederdirk/repos","events_url":"https://api.github.com/users/nederdirk/events{/privacy}","received_events_url":"https://api.github.com/users/nederdirk/received_events","type":"User","site_admin":false},"body":"This PR implements the friendly error message as suggested. I would have specified it, but the possibilities for the meaning of `args[0]` were a bit too broad: either a URL without URL schema (as in `rkt trust --prefix coreos.com/etcd`), a URL with schema (`rkt trust --root https://coreos.com/dist/pubkeys/aci-pubkeys.gpg`), a file on disk (`rkt trust --root aci-pubkeys.gpg`)\r\n\r\nTherefor I thought it would be better to keep the instruction as broad as possible.","created_at":"2015-06-02T19:33:59Z","updated_at":"2015-06-03T06:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f2a9d87a41b89da71744095f516503befad4ec2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/979/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/979/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/979/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/2aad923c04cd6accf73b670aa152d7f7d44ecd5b","head":{"label":"nederdirk:root-keys-ux","ref":"root-keys-ux","sha":"2aad923c04cd6accf73b670aa152d7f7d44ecd5b","user":{"login":"nederdirk","id":778965,"avatar_url":"https://avatars.githubusercontent.com/u/778965?v=3","gravatar_id":"","url":"https://api.github.com/users/nederdirk","html_url":"https://github.com/nederdirk","followers_url":"https://api.github.com/users/nederdirk/followers","following_url":"https://api.github.com/users/nederdirk/following{/other_user}","gists_url":"https://api.github.com/users/nederdirk/gists{/gist_id}","starred_url":"https://api.github.com/users/nederdirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nederdirk/subscriptions","organizations_url":"https://api.github.com/users/nederdirk/orgs","repos_url":"https://api.github.com/users/nederdirk/repos","events_url":"https://api.github.com/users/nederdirk/events{/privacy}","received_events_url":"https://api.github.com/users/nederdirk/received_events","type":"User","site_admin":false},"repo":{"id":31556268,"name":"rocket","full_name":"nederdirk/rocket","owner":{"login":"nederdirk","id":778965,"avatar_url":"https://avatars.githubusercontent.com/u/778965?v=3","gravatar_id":"","url":"https://api.github.com/users/nederdirk","html_url":"https://github.com/nederdirk","followers_url":"https://api.github.com/users/nederdirk/followers","following_url":"https://api.github.com/users/nederdirk/following{/other_user}","gists_url":"https://api.github.com/users/nederdirk/gists{/gist_id}","starred_url":"https://api.github.com/users/nederdirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nederdirk/subscriptions","organizations_url":"https://api.github.com/users/nederdirk/orgs","repos_url":"https://api.github.com/users/nederdirk/repos","events_url":"https://api.github.com/users/nederdirk/events{/privacy}","received_events_url":"https://api.github.com/users/nederdirk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nederdirk/rocket","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/nederdirk/rocket","forks_url":"https://api.github.com/repos/nederdirk/rocket/forks","keys_url":"https://api.github.com/repos/nederdirk/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nederdirk/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nederdirk/rocket/teams","hooks_url":"https://api.github.com/repos/nederdirk/rocket/hooks","issue_events_url":"https://api.github.com/repos/nederdirk/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/nederdirk/rocket/events","assignees_url":"https://api.github.com/repos/nederdirk/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/nederdirk/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/nederdirk/rocket/tags","blobs_url":"https://api.github.com/repos/nederdirk/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nederdirk/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nederdirk/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/nederdirk/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nederdirk/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/nederdirk/rocket/languages","stargazers_url":"https://api.github.com/repos/nederdirk/rocket/stargazers","contributors_url":"https://api.github.com/repos/nederdirk/rocket/contributors","subscribers_url":"https://api.github.com/repos/nederdirk/rocket/subscribers","subscription_url":"https://api.github.com/repos/nederdirk/rocket/subscription","commits_url":"https://api.github.com/repos/nederdirk/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/nederdirk/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/nederdirk/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/nederdirk/rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/nederdirk/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/nederdirk/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nederdirk/rocket/merges","archive_url":"https://api.github.com/repos/nederdirk/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nederdirk/rocket/downloads","issues_url":"https://api.github.com/repos/nederdirk/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/nederdirk/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/nederdirk/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/nederdirk/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nederdirk/rocket/labels{/name}","releases_url":"https://api.github.com/repos/nederdirk/rocket/releases{/id}","created_at":"2015-03-02T18:39:21Z","updated_at":"2015-03-02T18:39:22Z","pushed_at":"2015-06-02T19:27:07Z","git_url":"git://github.com/nederdirk/rocket.git","ssh_url":"git@github.com:nederdirk/rocket.git","clone_url":"https://github.com/nederdirk/rocket.git","svn_url":"https://github.com/nederdirk/rocket","homepage":"","size":4493,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e58e40bf34da4781e10ddf12f40b141702ec3ffc","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-06-03T05:49:45Z","pushed_at":"2015-06-02T23:14:54Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":17254,"stargazers_count":4259,"watchers_count":4259,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":112,"forks":326,"open_issues":112,"watchers":4259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/979"},"html":{"href":"https://github.com/coreos/rkt/pull/979"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/979"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/2aad923c04cd6accf73b670aa152d7f7d44ecd5b"}}}}