{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/41484437","id":41484437,"diff_hunk":"@@ -38,6 +38,11 @@\n       <version>4.11</version>\n       <scope>test</scope>\n     </dependency>\n+    <dependency>","path":"collector/pom.xml","position":4,"original_position":4,"commit_id":"e3748883e5b167c689510711626005da75c880ab","original_commit_id":"e3748883e5b167c689510711626005da75c880ab","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"Can the json dependency be removed now?","created_at":"2015-10-08T07:46:49Z","updated_at":"2015-10-08T07:46:49Z","html_url":"https://github.com/prometheus/jmx_exporter/pull/39#discussion_r41484437","pull_request_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/41484437"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/39#discussion_r41484437"},"pull_request":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39","id":47104567,"html_url":"https://github.com/prometheus/jmx_exporter/pull/39","diff_url":"https://github.com/prometheus/jmx_exporter/pull/39.diff","patch_url":"https://github.com/prometheus/jmx_exporter/pull/39.patch","issue_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/39","number":39,"state":"open","locked":false,"title":"Added Yaml file support, reconfigured JmxCollector and test cases.  ","user":{"login":"inondle","id":12456116,"avatar_url":"https://avatars.githubusercontent.com/u/12456116?v=3","gravatar_id":"","url":"https://api.github.com/users/inondle","html_url":"https://github.com/inondle","followers_url":"https://api.github.com/users/inondle/followers","following_url":"https://api.github.com/users/inondle/following{/other_user}","gists_url":"https://api.github.com/users/inondle/gists{/gist_id}","starred_url":"https://api.github.com/users/inondle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inondle/subscriptions","organizations_url":"https://api.github.com/users/inondle/orgs","repos_url":"https://api.github.com/users/inondle/repos","events_url":"https://api.github.com/users/inondle/events{/privacy}","received_events_url":"https://api.github.com/users/inondle/received_events","type":"User","site_admin":false},"body":"Used snakeYaml to update the JmxCollector to handle yaml files. I also updated the test case strings, sample_config, and the example config files to yaml. ","created_at":"2015-10-08T02:09:39Z","updated_at":"2015-10-08T07:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08115630da8c32f99ad11d8d21d6715d42c5bea1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39/commits","review_comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39/comments","review_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/39/comments","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/e3748883e5b167c689510711626005da75c880ab","head":{"label":"inondle:master","ref":"master","sha":"e3748883e5b167c689510711626005da75c880ab","user":{"login":"inondle","id":12456116,"avatar_url":"https://avatars.githubusercontent.com/u/12456116?v=3","gravatar_id":"","url":"https://api.github.com/users/inondle","html_url":"https://github.com/inondle","followers_url":"https://api.github.com/users/inondle/followers","following_url":"https://api.github.com/users/inondle/following{/other_user}","gists_url":"https://api.github.com/users/inondle/gists{/gist_id}","starred_url":"https://api.github.com/users/inondle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inondle/subscriptions","organizations_url":"https://api.github.com/users/inondle/orgs","repos_url":"https://api.github.com/users/inondle/repos","events_url":"https://api.github.com/users/inondle/events{/privacy}","received_events_url":"https://api.github.com/users/inondle/received_events","type":"User","site_admin":false},"repo":{"id":43719790,"name":"jmx_exporter","full_name":"inondle/jmx_exporter","owner":{"login":"inondle","id":12456116,"avatar_url":"https://avatars.githubusercontent.com/u/12456116?v=3","gravatar_id":"","url":"https://api.github.com/users/inondle","html_url":"https://github.com/inondle","followers_url":"https://api.github.com/users/inondle/followers","following_url":"https://api.github.com/users/inondle/following{/other_user}","gists_url":"https://api.github.com/users/inondle/gists{/gist_id}","starred_url":"https://api.github.com/users/inondle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inondle/subscriptions","organizations_url":"https://api.github.com/users/inondle/orgs","repos_url":"https://api.github.com/users/inondle/repos","events_url":"https://api.github.com/users/inondle/events{/privacy}","received_events_url":"https://api.github.com/users/inondle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inondle/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":true,"url":"https://api.github.com/repos/inondle/jmx_exporter","forks_url":"https://api.github.com/repos/inondle/jmx_exporter/forks","keys_url":"https://api.github.com/repos/inondle/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inondle/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inondle/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/inondle/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/inondle/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/inondle/jmx_exporter/events","assignees_url":"https://api.github.com/repos/inondle/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/inondle/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/inondle/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/inondle/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inondle/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inondle/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/inondle/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inondle/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/inondle/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/inondle/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/inondle/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/inondle/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/inondle/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/inondle/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/inondle/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/inondle/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/inondle/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/inondle/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/inondle/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inondle/jmx_exporter/merges","archive_url":"https://api.github.com/repos/inondle/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inondle/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/inondle/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/inondle/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/inondle/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/inondle/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inondle/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/inondle/jmx_exporter/releases{/id}","created_at":"2015-10-05T23:31:03Z","updated_at":"2015-10-05T23:31:04Z","pushed_at":"2015-10-08T01:57:23Z","git_url":"git://github.com/inondle/jmx_exporter.git","ssh_url":"git@github.com:inondle/jmx_exporter.git","clone_url":"https://github.com/inondle/jmx_exporter.git","svn_url":"https://github.com/inondle/jmx_exporter","homepage":"","size":1383,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"42c8791e7b421551b3f979b30586623eb1c25758","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":17170044,"name":"jmx_exporter","full_name":"prometheus/jmx_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":false,"url":"https://api.github.com/repos/prometheus/jmx_exporter","forks_url":"https://api.github.com/repos/prometheus/jmx_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/jmx_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/jmx_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/jmx_exporter/releases{/id}","created_at":"2014-02-25T10:55:39Z","updated_at":"2015-09-29T03:24:59Z","pushed_at":"2015-10-08T02:09:39Z","git_url":"git://github.com/prometheus/jmx_exporter.git","ssh_url":"git@github.com:prometheus/jmx_exporter.git","clone_url":"https://github.com/prometheus/jmx_exporter.git","svn_url":"https://github.com/prometheus/jmx_exporter","homepage":"","size":1383,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/39"},"issue":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/39"},"comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/e3748883e5b167c689510711626005da75c880ab"}}}}