{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/17483","labels_url":"https://api.github.com/repos/owncloud/core/issues/17483/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17483/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/17483/events","html_url":"https://github.com/owncloud/core/pull/17483","id":93775526,"number":17483,"title":"Move away from OCA.files.getMimeIcon and use OC.MimeType.getIconUrl","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":618,"closed_issues":93,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-07-09T16:42:33Z","due_on":"2015-10-19T22:00:00Z","closed_at":null},"comments":21,"created_at":"2015-07-08T12:24:02Z","updated_at":"2015-07-09T18:21:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17483","html_url":"https://github.com/owncloud/core/pull/17483","diff_url":"https://github.com/owncloud/core/pull/17483.diff","patch_url":"https://github.com/owncloud/core/pull/17483.patch"},"body":"Since we now have the fancy OC.MimeType class (#16724) we should actively use it!\r\n\r\nThis moves the file app away from the getMimeIcon function that did a request for every mimetype to the server\r\n\r\nTesting is easy!\r\n\r\n1. Add some files for which we have mimetypes\r\n2. Reload files app and observe the console.. for each mimetype you should see at least 1 request to the server (ajax/mimeicon.php)\r\n3. Now checkout this awesome branch\r\n4. Reload files app\r\n5. Observe no calls to the server for each mimetype (but you still see them)\r\n\r\nTODO:\r\n- [x] Remove ajax/mimeicon.php (and its routes)\r\n- [x] Migrate calls in core app to getMimeIcon to OC.MimeType.getIconUrl\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/120093952","html_url":"https://github.com/owncloud/core/pull/17483#issuecomment-120093952","issue_url":"https://api.github.com/repos/owncloud/core/issues/17483","id":120093952,"user":{"login":"owncloud-bot","id":2709266,"avatar_url":"https://avatars.githubusercontent.com/u/2709266?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud-bot","html_url":"https://github.com/owncloud-bot","followers_url":"https://api.github.com/users/owncloud-bot/followers","following_url":"https://api.github.com/users/owncloud-bot/following{/other_user}","gists_url":"https://api.github.com/users/owncloud-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud-bot/subscriptions","organizations_url":"https://api.github.com/users/owncloud-bot/orgs","repos_url":"https://api.github.com/users/owncloud-bot/repos","events_url":"https://api.github.com/users/owncloud-bot/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud-bot/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T18:21:09Z","updated_at":"2015-07-09T18:21:09Z","body":":rocket: Test PASSed.:rocket:\n![chuck](https://cloud.githubusercontent.com/assets/1005065/6865211/d99978f2-d46b-11e4-9c1d-66f21a737511.jpg)\n"}}