{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/plottable/pulls/comments/26721026","id":26721026,"diff_hunk":"@@ -0,0 +1,42 @@\n+module Plottable {\n+export module Plot {\n+  export class ErrorBar<X> extends AbstractXYPlot<X,number> {\n+\n+    private _isVertical: boolean;\n+    private _defaultStrokeColor: string;\n+\n+    /**\n+     * Constructs an ErrorBarPlot.\n+     *\n+     * Error bar plots are used to show variability in a reported measurement on a plot.\n+     * They are intended to be merged on top of other sorts of plots.\n+     *\n+     * @constructor\n+     * @param {AbstractScale} xScale The x scale to use.\n+     * @param {AbstractScale} yScale The y scale to use.\n+     */\n+    constructor(xScale: Scale.AbstractScale<X, number>, yScale: Scale.AbstractScale<X, number>, isVertical = true) {\n+      super(xScale, yScale);\n+      this.classed(\"error-plot\", true);\n+      this._defaultStrokeColor = new Scale.Color().range()[1];\n+      this._isVertical = isVertical;\n+    }\n+\n+    protected _getDrawer(key: string) {\n+      return new Plottable._Drawer.ErrorBar(key, this._isVertical);\n+    }\n+\n+    protected _generateAttrToProjector() {\n+      var attrToProjector = super._generateAttrToProjector();\n+\n+      var xFunction = attrToProjector[\"x\"];\n+      var yFunction = attrToProjector[\"y\"];","path":"src/components/plots/errorBarPlot.ts","position":33,"original_position":33,"commit_id":"624e4c73db6a37bd3c970b4eb72f450af12ffb48","original_commit_id":"624e4c73db6a37bd3c970b4eb72f450af12ffb48","user":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"body":"These two lines seem to do nothing","created_at":"2015-03-19T00:24:08Z","updated_at":"2015-03-19T00:24:08Z","html_url":"https://github.com/palantir/plottable/pull/1746#discussion_r26721026","pull_request_url":"https://api.github.com/repos/palantir/plottable/pulls/1746","_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments/26721026"},"html":{"href":"https://github.com/palantir/plottable/pull/1746#discussion_r26721026"},"pull_request":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1746"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/plottable/pulls/1746","id":31394152,"html_url":"https://github.com/palantir/plottable/pull/1746","diff_url":"https://github.com/palantir/plottable/pull/1746.diff","patch_url":"https://github.com/palantir/plottable/pull/1746.patch","issue_url":"https://api.github.com/repos/palantir/plottable/issues/1746","number":1746,"state":"open","locked":false,"title":"[ErrorBarPlot] Implement ErrorBarPlot","user":{"login":"rcchen","id":1175041,"avatar_url":"https://avatars.githubusercontent.com/u/1175041?v=3","gravatar_id":"","url":"https://api.github.com/users/rcchen","html_url":"https://github.com/rcchen","followers_url":"https://api.github.com/users/rcchen/followers","following_url":"https://api.github.com/users/rcchen/following{/other_user}","gists_url":"https://api.github.com/users/rcchen/gists{/gist_id}","starred_url":"https://api.github.com/users/rcchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcchen/subscriptions","organizations_url":"https://api.github.com/users/rcchen/orgs","repos_url":"https://api.github.com/users/rcchen/repos","events_url":"https://api.github.com/users/rcchen/events{/privacy}","received_events_url":"https://api.github.com/users/rcchen/received_events","type":"User","site_admin":false},"body":"ErrorBarPot shows nice error bars. It is meant to be merged with other plots as needed.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1175041/6701012/c4a4e58e-ccd3-11e4-8285-4155d0cfd2e1.png)\r\n\r\nJSFiddle: http://jsfiddle.net/Ltayarx4/\r\n\r\nFixes #1379 ","created_at":"2015-03-18T01:39:06Z","updated_at":"2015-03-19T00:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a195000928264c32bcd94e12263b5732e2fb16e","assignee":{"login":"bluong","id":1448299,"avatar_url":"https://avatars.githubusercontent.com/u/1448299?v=3","gravatar_id":"","url":"https://api.github.com/users/bluong","html_url":"https://github.com/bluong","followers_url":"https://api.github.com/users/bluong/followers","following_url":"https://api.github.com/users/bluong/following{/other_user}","gists_url":"https://api.github.com/users/bluong/gists{/gist_id}","starred_url":"https://api.github.com/users/bluong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluong/subscriptions","organizations_url":"https://api.github.com/users/bluong/orgs","repos_url":"https://api.github.com/users/bluong/repos","events_url":"https://api.github.com/users/bluong/events{/privacy}","received_events_url":"https://api.github.com/users/bluong/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/palantir/plottable/pulls/1746/commits","review_comments_url":"https://api.github.com/repos/palantir/plottable/pulls/1746/comments","review_comment_url":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/plottable/issues/1746/comments","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/624e4c73db6a37bd3c970b4eb72f450af12ffb48","head":{"label":"palantir:1379-fix","ref":"1379-fix","sha":"624e4c73db6a37bd3c970b4eb72f450af12ffb48","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2015-03-18T17:57:21Z","pushed_at":"2015-03-19T00:22:16Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":60995,"stargazers_count":425,"watchers_count":425,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":135,"forks":33,"open_issues":135,"watchers":425,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"77701851efccb92c7749bdcd5f9705565e8c996a","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":16149854,"name":"plottable","full_name":"palantir/plottable","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/plottable","description":"A library of modular chart components, built on D3","fork":false,"url":"https://api.github.com/repos/palantir/plottable","forks_url":"https://api.github.com/repos/palantir/plottable/forks","keys_url":"https://api.github.com/repos/palantir/plottable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/plottable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/plottable/teams","hooks_url":"https://api.github.com/repos/palantir/plottable/hooks","issue_events_url":"https://api.github.com/repos/palantir/plottable/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/plottable/events","assignees_url":"https://api.github.com/repos/palantir/plottable/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/plottable/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/plottable/tags","blobs_url":"https://api.github.com/repos/palantir/plottable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/plottable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/plottable/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/plottable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/plottable/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/plottable/languages","stargazers_url":"https://api.github.com/repos/palantir/plottable/stargazers","contributors_url":"https://api.github.com/repos/palantir/plottable/contributors","subscribers_url":"https://api.github.com/repos/palantir/plottable/subscribers","subscription_url":"https://api.github.com/repos/palantir/plottable/subscription","commits_url":"https://api.github.com/repos/palantir/plottable/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/plottable/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/plottable/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/plottable/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/plottable/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/plottable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/plottable/merges","archive_url":"https://api.github.com/repos/palantir/plottable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/plottable/downloads","issues_url":"https://api.github.com/repos/palantir/plottable/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/plottable/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/plottable/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/plottable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/plottable/labels{/name}","releases_url":"https://api.github.com/repos/palantir/plottable/releases{/id}","created_at":"2014-01-22T19:29:19Z","updated_at":"2015-03-18T17:57:21Z","pushed_at":"2015-03-19T00:22:16Z","git_url":"git://github.com/palantir/plottable.git","ssh_url":"git@github.com:palantir/plottable.git","clone_url":"https://github.com/palantir/plottable.git","svn_url":"https://github.com/palantir/plottable","homepage":"plottablejs.org","size":60995,"stargazers_count":425,"watchers_count":425,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":135,"forks":33,"open_issues":135,"watchers":425,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1746"},"html":{"href":"https://github.com/palantir/plottable/pull/1746"},"issue":{"href":"https://api.github.com/repos/palantir/plottable/issues/1746"},"comments":{"href":"https://api.github.com/repos/palantir/plottable/issues/1746/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1746/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/plottable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/plottable/pulls/1746/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/plottable/statuses/624e4c73db6a37bd3c970b4eb72f450af12ffb48"}}}}