{"action":"created","issue":{"url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/29","labels_url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/29/comments","events_url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/29/events","html_url":"https://github.com/10se1ucgo/DisableWinTracking/pull/29","id":101294191,"number":29,"title":"Block by tracking IP addresses","user":{"login":"lallousx86","id":5303297,"avatar_url":"https://avatars.githubusercontent.com/u/5303297?v=3","gravatar_id":"","url":"https://api.github.com/users/lallousx86","html_url":"https://github.com/lallousx86","followers_url":"https://api.github.com/users/lallousx86/followers","following_url":"https://api.github.com/users/lallousx86/following{/other_user}","gists_url":"https://api.github.com/users/lallousx86/gists{/gist_id}","starred_url":"https://api.github.com/users/lallousx86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lallousx86/subscriptions","organizations_url":"https://api.github.com/users/lallousx86/orgs","repos_url":"https://api.github.com/users/lallousx86/repos","events_url":"https://api.github.com/users/lallousx86/events{/privacy}","received_events_url":"https://api.github.com/users/lallousx86/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-16T19:54:41Z","updated_at":"2015-08-18T21:47:17Z","closed_at":"2015-08-17T04:30:34Z","pull_request":{"url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/pulls/29","html_url":"https://github.com/10se1ucgo/DisableWinTracking/pull/29","diff_url":"https://github.com/10se1ucgo/DisableWinTracking/pull/29.diff","patch_url":"https://github.com/10se1ucgo/DisableWinTracking/pull/29.patch"},"body":"-  Block by IP addresses\r\n- Cache IP resolution\r\n- Clear blocking rules option"},"comment":{"url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/comments/132365772","html_url":"https://github.com/10se1ucgo/DisableWinTracking/pull/29#issuecomment-132365772","issue_url":"https://api.github.com/repos/10se1ucgo/DisableWinTracking/issues/29","id":132365772,"user":{"login":"lallousx86","id":5303297,"avatar_url":"https://avatars.githubusercontent.com/u/5303297?v=3","gravatar_id":"","url":"https://api.github.com/users/lallousx86","html_url":"https://github.com/lallousx86","followers_url":"https://api.github.com/users/lallousx86/followers","following_url":"https://api.github.com/users/lallousx86/following{/other_user}","gists_url":"https://api.github.com/users/lallousx86/gists{/gist_id}","starred_url":"https://api.github.com/users/lallousx86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lallousx86/subscriptions","organizations_url":"https://api.github.com/users/lallousx86/orgs","repos_url":"https://api.github.com/users/lallousx86/repos","events_url":"https://api.github.com/users/lallousx86/events{/privacy}","received_events_url":"https://api.github.com/users/lallousx86/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T21:47:17Z","updated_at":"2015-08-18T21:47:17Z","body":"\"it's just the coding style is awful. I've never seen anyone ever write code in that format. I'll write my own IP blocking later\" I don't know what you're complaining about and what is \"awful\". But thanks for the feedback.\r\n\r\nThe formatting? that's just my editor being misconfigured.\r\n\r\nL17-L25: these are regular constants. I could put them outside in the module scope or in the class. That's usual. I have seen it a lot.\r\n\r\nL435-L442: that's something I overlooked. A copy/paste bug. The \"and 0 self.servicebox.IsChecked()\" is not needed.\r\n\r\nSo basically, you check if that checkbox is set once and then inside that check you check the radio button value. It is cleaner then checking \"self.servicebox.IsChecked()\" twice.\r\n\r\n* Tabs and spaces? I had a fresh PC and my editor (EditPlus) was not yet configured, so that explains this mix and match between spaces and tabs.\r\n"}}