{"action":"created","comment":{"url":"https://api.github.com/repos/loomio/loomio/pulls/comments/47989632","id":47989632,"diff_hunk":"@@ -17,9 +17,7 @@\n       %h3.new-comment__in-reply-to{ng-if: 'comment.parentId', id: 'event-{{event.id}}'}\n         %strong\n           %a{lmo-href-for: 'comment.author()'}> {{ comment.authorName() }}\n-        %span{translate: 'new_comment_item.in_reply_to'}\n-        %strong\n-          %a{lmo-href-for: 'comment.parentAuthor()'}> {{ comment.parentAuthorName }}\n+        %span{translate: 'new_comment_item.in_reply_to', translate-value-recipient: '{{comment.parentAuthorName}}'}","path":"lineman/app/components/thread_page/activity_card/new_comment.haml","position":7,"original_position":7,"commit_id":"a4f32f1392d0196110d64d3c6b2b522d6dccf351","original_commit_id":"a4f32f1392d0196110d64d3c6b2b522d6dccf351","user":{"login":"gdpelican","id":750477,"avatar_url":"https://avatars.githubusercontent.com/u/750477?v=3","gravatar_id":"","url":"https://api.github.com/users/gdpelican","html_url":"https://github.com/gdpelican","followers_url":"https://api.github.com/users/gdpelican/followers","following_url":"https://api.github.com/users/gdpelican/following{/other_user}","gists_url":"https://api.github.com/users/gdpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/gdpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdpelican/subscriptions","organizations_url":"https://api.github.com/users/gdpelican/orgs","repos_url":"https://api.github.com/users/gdpelican/repos","events_url":"https://api.github.com/users/gdpelican/events{/privacy}","received_events_url":"https://api.github.com/users/gdpelican/received_events","type":"User","site_admin":false},"body":"What's the reasoning for not serializing out the parent with the comment? I\nseem to remember we used to do that... was it too slow?\n\nOn Fri, Dec 18, 2015 at 3:48 AM, Robert Guthrie <notifications@github.com>\nwrote:\n\n> In lineman/app/components/thread_page/activity_card/new_comment.haml\n> <https://github.com/loomio/loomio/pull/2836#discussion_r47989490>:\n>\n> > @@ -17,9 +17,7 @@\n> >        %h3.new-comment__in-reply-to{ng-if: 'comment.parentId', id: 'event-{{event.id}}'}\n> >          %strong\n> >            %a{lmo-href-for: 'comment.author()'}> {{ comment.authorName() }}\n> > -        %span{translate: 'new_comment_item.in_reply_to'}\n> > -        %strong\n> > -          %a{lmo-href-for: 'comment.parentAuthor()'}> {{ comment.parentAuthorName }}\n> > +        %span{translate: 'new_comment_item.in_reply_to', translate-value-recipient: '{{comment.parentAuthorName}}'}\n>\n> hrrmm.. yes I guess so. would be nice to have the whole user object\n> though. I wonder if we can do that with AMS yet.\n> … <#151b2fd5018add38_>\n> On Fri, 18 Dec 2015 at 15:15 James Kiesel <notifications@github.com>\n> wrote: In lineman/app/components/thread_page/activity_card/new_comment.haml\n> <#2836 (comment)\n> <https://github.com/loomio/loomio/pull/2836#discussion_r47987727>>: > @@\n> -17,9 +17,7 @@ > %h3.new-comment__in-reply-to{ng-if: 'comment.parentId',\n> id: 'event-{{event.id}}'} > %strong > %a{lmo-href-for:\n> 'comment.author()'}> {{ comment.authorName() }} > - %span{translate:\n> 'new_comment_item.in_reply_to'} > - %strong > - %a{lmo-href-for:\n> 'comment.parentAuthor()'}> {{ comment.parentAuthorName }} > +\n> %span{translate: 'new_comment_item.in_reply_to', translate-value-recipient:\n> '{{comment.parentAuthorName}}'} Oh, I see. specifically the case where\n> we're jumping directly to a comment and not back-loading it's parent.\n> Should we be serializing out the parentAuthorUsername alongside the\n> parentAuthorName then? … <#msg-f:1520859769167276480_> On Fri, Dec 18, 2015\n> at 3:11 AM, Robert Guthrie <notifications@github.com> wrote: In\n> lineman/app/components/thread_page/activity_card/new_comment.haml <#2836\n> <https://github.com/loomio/loomio/pull/2836> (comment) <#2836 (comment)\n> <https://github.com/loomio/loomio/pull/2836#discussion_r47987588>>>: > @@\n> -17,9 +17,7 @@ > %h3.new-comment__in-reply-to{ng-if: 'comment.parentId',\n> id: 'event-{{event.id}}'} > %strong > %a{lmo-href-for:\n> 'comment.author()'}> {{ comment.authorName() }} > - %span{translate:\n> 'new_comment_item.in_reply_to'} > - %strong > - %a{lmo-href-for:\n> 'comment.parentAuthor()'}> {{ comment.parentAuthorName }} > +\n> %span{translate: 'new_comment_item.in_reply_to', translate-value-recipient:\n> '{{comment.parentAuthorName}}'} I don't understand what you're saying. We\n> don't serialize the parent author with the comment, so there are cases when\n> the parent author is not loaded in the client so we don't know their user\n> id — Reply to this email directly or view it on GitHub <\n> https://github.com/loomio/loomio/pull/2836/files#r47987588>. — Reply to\n> this email directly or view it on GitHub <\n> https://github.com/loomio/loomio/pull/2836/files#r47987727>.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/loomio/loomio/pull/2836/files#r47989490>.\n>\n","created_at":"2015-12-18T02:51:52Z","updated_at":"2015-12-18T02:51:52Z","html_url":"https://github.com/loomio/loomio/pull/2836#discussion_r47989632","pull_request_url":"https://api.github.com/repos/loomio/loomio/pulls/2836","_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments/47989632"},"html":{"href":"https://github.com/loomio/loomio/pull/2836#discussion_r47989632"},"pull_request":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2836"}}},"pull_request":{"url":"https://api.github.com/repos/loomio/loomio/pulls/2836","id":54041275,"html_url":"https://github.com/loomio/loomio/pull/2836","diff_url":"https://github.com/loomio/loomio/pull/2836.diff","patch_url":"https://github.com/loomio/loomio/pull/2836.patch","issue_url":"https://api.github.com/repos/loomio/loomio/issues/2836","number":2836,"state":"closed","locked":false,"title":"Remove link for recipient of comment reply","user":{"login":"HSalmon","id":2882097,"avatar_url":"https://avatars.githubusercontent.com/u/2882097?v=3","gravatar_id":"","url":"https://api.github.com/users/HSalmon","html_url":"https://github.com/HSalmon","followers_url":"https://api.github.com/users/HSalmon/followers","following_url":"https://api.github.com/users/HSalmon/following{/other_user}","gists_url":"https://api.github.com/users/HSalmon/gists{/gist_id}","starred_url":"https://api.github.com/users/HSalmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSalmon/subscriptions","organizations_url":"https://api.github.com/users/HSalmon/orgs","repos_url":"https://api.github.com/users/HSalmon/repos","events_url":"https://api.github.com/users/HSalmon/events{/privacy}","received_events_url":"https://api.github.com/users/HSalmon/received_events","type":"User","site_admin":false},"body":"@robguthrie, I think this should do the trick","created_at":"2015-12-17T22:33:25Z","updated_at":"2015-12-18T02:51:53Z","closed_at":"2015-12-18T01:30:54Z","merged_at":"2015-12-18T01:30:54Z","merge_commit_sha":"5a6834ccbd3b6d7ef69b2ce691f46ee20c16c128","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/loomio/loomio/pulls/2836/commits","review_comments_url":"https://api.github.com/repos/loomio/loomio/pulls/2836/comments","review_comment_url":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loomio/loomio/issues/2836/comments","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/a4f32f1392d0196110d64d3c6b2b522d6dccf351","head":{"label":"loomio:fix-reply-comment-author-link","ref":"fix-reply-comment-author-link","sha":"a4f32f1392d0196110d64d3c6b2b522d6dccf351","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","created_at":"2011-11-08T03:27:12Z","updated_at":"2015-12-16T20:19:35Z","pushed_at":"2015-12-18T02:39:59Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":146223,"stargazers_count":1057,"watchers_count":1057,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":59,"forks":380,"open_issues":59,"watchers":1057,"default_branch":"master"}},"base":{"label":"loomio:master","ref":"master","sha":"b84533898cfe7fcbedbd8e19597689f70874de05","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","created_at":"2011-11-08T03:27:12Z","updated_at":"2015-12-16T20:19:35Z","pushed_at":"2015-12-18T02:39:59Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":146223,"stargazers_count":1057,"watchers_count":1057,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":59,"forks":380,"open_issues":59,"watchers":1057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2836"},"html":{"href":"https://github.com/loomio/loomio/pull/2836"},"issue":{"href":"https://api.github.com/repos/loomio/loomio/issues/2836"},"comments":{"href":"https://api.github.com/repos/loomio/loomio/issues/2836/comments"},"review_comments":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2836/comments"},"review_comment":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loomio/loomio/pulls/2836/commits"},"statuses":{"href":"https://api.github.com/repos/loomio/loomio/statuses/a4f32f1392d0196110d64d3c6b2b522d6dccf351"}}}}