{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/36004571","id":36004571,"diff_hunk":"@@ -586,21 +586,24 @@ static int fi_ibv_fi_to_rai(const struct fi_info *fi, uint64_t flags, struct rdm\n \tif (!fi)\n \t\treturn 0;\n \n-\tswitch(fi->addr_format) {\n-\tcase FI_SOCKADDR_IN:\n-\t\trai->ai_family = AF_INET;\n-\t\tbreak;\n-\tcase FI_SOCKADDR_IN6:\n-\t\trai->ai_family = AF_INET6;\n-\t\tbreak;\n-\tcase FI_SOCKADDR_IB:\n-\t\trai->ai_family = AF_IB;\n-\t\tbreak;\n-\tcase FI_SOCKADDR:\n-\tcase FI_FORMAT_UNSPEC:\n-\t\tbreak;\n-\tdefault:\n-\t\tFI_INFO(&fi_ibv_prov, FI_LOG_CORE, \"Unknown fi->addr_format\\n\");\n+\tif (fi->addr_format) {\n+\t\trai->ai_flags |= RAI_FAMILY;","path":"prov/verbs/src/fi_verbs.c","position":20,"original_position":20,"commit_id":"ecebf441087da1b29ba07f903b9512e92f9a7704","original_commit_id":"ecebf441087da1b29ba07f903b9512e92f9a7704","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Is this correct in the case where addr_format is FI_SOCKADDR?","created_at":"2015-07-31T18:50:20Z","updated_at":"2015-07-31T18:50:20Z","html_url":"https://github.com/ofiwg/libfabric/pull/1185#discussion_r36004571","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/36004571"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1185#discussion_r36004571"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185","id":41356636,"html_url":"https://github.com/ofiwg/libfabric/pull/1185","diff_url":"https://github.com/ofiwg/libfabric/pull/1185.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1185.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1185","number":1185,"state":"open","locked":false,"title":"prov/verbs: Add support for AF_IB addresses.","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"Allow app to pass AF_IB addresses via fi_getinfo node argument.\r\nThe app should set the hints.addr_format to FI_SOCKADDR_IB. Server\r\nshould be bound to a specific AF_IB address and can't listen on a\r\nwild card address.\r\n\r\nNote:\r\n1. Currently there is an issue with opensm so apps can't pass IB\r\n   addresses yet. ibacm 1.1 is expected to have a workaround fix\r\n   for the opensm issue. Till then, disable ibacm to pass AF_IB\r\n   addresses.\r\n2. Another potential issue with rdma_cm requires the app to\r\n   pass FI_NUMERICHOST flag during fi_getinfo. This might be fixed\r\n   in rdma_cm in the future.\r\n\r\nSigned-off-by: Arun C Ilango <arun.ilango@intel.com>","created_at":"2015-07-31T16:27:48Z","updated_at":"2015-07-31T18:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63331716e1b92c3a28f9c79a85ce3a6c5aaaf565","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1185/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/ecebf441087da1b29ba07f903b9512e92f9a7704","head":{"label":"a-ilango:dev","ref":"dev","sha":"ecebf441087da1b29ba07f903b9512e92f9a7704","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"repo":{"id":24616163,"name":"libfabric","full_name":"a-ilango/libfabric","owner":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-ilango/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/a-ilango/libfabric","forks_url":"https://api.github.com/repos/a-ilango/libfabric/forks","keys_url":"https://api.github.com/repos/a-ilango/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-ilango/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-ilango/libfabric/teams","hooks_url":"https://api.github.com/repos/a-ilango/libfabric/hooks","issue_events_url":"https://api.github.com/repos/a-ilango/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/a-ilango/libfabric/events","assignees_url":"https://api.github.com/repos/a-ilango/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/a-ilango/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/a-ilango/libfabric/tags","blobs_url":"https://api.github.com/repos/a-ilango/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-ilango/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-ilango/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-ilango/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-ilango/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/a-ilango/libfabric/languages","stargazers_url":"https://api.github.com/repos/a-ilango/libfabric/stargazers","contributors_url":"https://api.github.com/repos/a-ilango/libfabric/contributors","subscribers_url":"https://api.github.com/repos/a-ilango/libfabric/subscribers","subscription_url":"https://api.github.com/repos/a-ilango/libfabric/subscription","commits_url":"https://api.github.com/repos/a-ilango/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-ilango/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-ilango/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-ilango/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-ilango/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/a-ilango/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-ilango/libfabric/merges","archive_url":"https://api.github.com/repos/a-ilango/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-ilango/libfabric/downloads","issues_url":"https://api.github.com/repos/a-ilango/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/a-ilango/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/a-ilango/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/a-ilango/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-ilango/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/a-ilango/libfabric/releases{/id}","created_at":"2014-09-29T22:57:04Z","updated_at":"2015-04-29T22:50:48Z","pushed_at":"2015-07-31T16:17:08Z","git_url":"git://github.com/a-ilango/libfabric.git","ssh_url":"git@github.com:a-ilango/libfabric.git","clone_url":"https://github.com/a-ilango/libfabric.git","svn_url":"https://github.com/a-ilango/libfabric","homepage":null,"size":6542,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"79909acd94c6f140518d7914342d581374c2e9d1","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-07-25T05:06:01Z","pushed_at":"2015-07-31T18:48:52Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":12631,"stargazers_count":39,"watchers_count":39,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":58,"forks":40,"open_issues":58,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1185"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1185"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1185/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1185/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/ecebf441087da1b29ba07f903b9512e92f9a7704"}}}}