{"action":"opened","number":19404,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/19404","id":31505754,"html_url":"https://github.com/rails/rails/pull/19404","diff_url":"https://github.com/rails/rails/pull/19404.diff","patch_url":"https://github.com/rails/rails/pull/19404.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/19404","number":19404,"state":"open","locked":false,"title":"Don't fallback to RACK_ENV when RAILS_ENV is not present","user":{"login":"dmathieu","id":9347,"avatar_url":"https://avatars.githubusercontent.com/u/9347?v=3","gravatar_id":"","url":"https://api.github.com/users/dmathieu","html_url":"https://github.com/dmathieu","followers_url":"https://api.github.com/users/dmathieu/followers","following_url":"https://api.github.com/users/dmathieu/following{/other_user}","gists_url":"https://api.github.com/users/dmathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmathieu/subscriptions","organizations_url":"https://api.github.com/users/dmathieu/orgs","repos_url":"https://api.github.com/users/dmathieu/repos","events_url":"https://api.github.com/users/dmathieu/events{/privacy}","received_events_url":"https://api.github.com/users/dmathieu/received_events","type":"User","site_admin":false},"body":"`RACK_ENV` is *not* the same as `RAILS_ENV`, and can't serve as a fallback when the later isn't present.\r\n\r\nSee http://www.hezmatt.org/~mpalmer/blog/2013/10/13/rack_env-its-not-for-you.html\r\n\r\nIn fact, it can even cause some issues if your app is using unicorn, as they're including internal rack middlewares relying on `RACK_ENV` to have the `deployment` value.\r\nSee https://github.com/defunkt/unicorn/blob/master/lib/unicorn.rb#L56-L79\r\n\r\nThis removes support for falling back to RACK_ENV when RAILS_ENV is not available.","created_at":"2015-03-19T09:14:43Z","updated_at":"2015-03-19T09:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/19404/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/19404/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/19404/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/d578cbfb5c9fa353ce041bc826e13905910e2d2a","head":{"label":"dmathieu:remove_rack_env","ref":"remove_rack_env","sha":"d578cbfb5c9fa353ce041bc826e13905910e2d2a","user":{"login":"dmathieu","id":9347,"avatar_url":"https://avatars.githubusercontent.com/u/9347?v=3","gravatar_id":"","url":"https://api.github.com/users/dmathieu","html_url":"https://github.com/dmathieu","followers_url":"https://api.github.com/users/dmathieu/followers","following_url":"https://api.github.com/users/dmathieu/following{/other_user}","gists_url":"https://api.github.com/users/dmathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmathieu/subscriptions","organizations_url":"https://api.github.com/users/dmathieu/orgs","repos_url":"https://api.github.com/users/dmathieu/repos","events_url":"https://api.github.com/users/dmathieu/events{/privacy}","received_events_url":"https://api.github.com/users/dmathieu/received_events","type":"User","site_admin":false},"repo":{"id":32511174,"name":"rails","full_name":"dmathieu/rails","owner":{"login":"dmathieu","id":9347,"avatar_url":"https://avatars.githubusercontent.com/u/9347?v=3","gravatar_id":"","url":"https://api.github.com/users/dmathieu","html_url":"https://github.com/dmathieu","followers_url":"https://api.github.com/users/dmathieu/followers","following_url":"https://api.github.com/users/dmathieu/following{/other_user}","gists_url":"https://api.github.com/users/dmathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmathieu/subscriptions","organizations_url":"https://api.github.com/users/dmathieu/orgs","repos_url":"https://api.github.com/users/dmathieu/repos","events_url":"https://api.github.com/users/dmathieu/events{/privacy}","received_events_url":"https://api.github.com/users/dmathieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmathieu/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/dmathieu/rails","forks_url":"https://api.github.com/repos/dmathieu/rails/forks","keys_url":"https://api.github.com/repos/dmathieu/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmathieu/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmathieu/rails/teams","hooks_url":"https://api.github.com/repos/dmathieu/rails/hooks","issue_events_url":"https://api.github.com/repos/dmathieu/rails/issues/events{/number}","events_url":"https://api.github.com/repos/dmathieu/rails/events","assignees_url":"https://api.github.com/repos/dmathieu/rails/assignees{/user}","branches_url":"https://api.github.com/repos/dmathieu/rails/branches{/branch}","tags_url":"https://api.github.com/repos/dmathieu/rails/tags","blobs_url":"https://api.github.com/repos/dmathieu/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmathieu/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmathieu/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmathieu/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmathieu/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/dmathieu/rails/languages","stargazers_url":"https://api.github.com/repos/dmathieu/rails/stargazers","contributors_url":"https://api.github.com/repos/dmathieu/rails/contributors","subscribers_url":"https://api.github.com/repos/dmathieu/rails/subscribers","subscription_url":"https://api.github.com/repos/dmathieu/rails/subscription","commits_url":"https://api.github.com/repos/dmathieu/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmathieu/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmathieu/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmathieu/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmathieu/rails/contents/{+path}","compare_url":"https://api.github.com/repos/dmathieu/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmathieu/rails/merges","archive_url":"https://api.github.com/repos/dmathieu/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmathieu/rails/downloads","issues_url":"https://api.github.com/repos/dmathieu/rails/issues{/number}","pulls_url":"https://api.github.com/repos/dmathieu/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/dmathieu/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/dmathieu/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmathieu/rails/labels{/name}","releases_url":"https://api.github.com/repos/dmathieu/rails/releases{/id}","created_at":"2015-03-19T09:06:49Z","updated_at":"2015-03-19T09:07:25Z","pushed_at":"2015-03-19T09:09:35Z","git_url":"git://github.com/dmathieu/rails.git","ssh_url":"git@github.com:dmathieu/rails.git","clone_url":"https://github.com/dmathieu/rails.git","svn_url":"https://github.com/dmathieu/rails","homepage":"http://rubyonrails.org","size":394906,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"338d25083bafff24c285a141a0caa182a5c2b9ec","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-03-19T09:04:13Z","pushed_at":"2015-03-19T09:05:05Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":394906,"stargazers_count":25313,"watchers_count":25313,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9931,"mirror_url":null,"open_issues_count":730,"forks":9931,"open_issues":730,"watchers":25313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/19404"},"html":{"href":"https://github.com/rails/rails/pull/19404"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/19404"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/19404/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/19404/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/19404/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/d578cbfb5c9fa353ce041bc826e13905910e2d2a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":31,"deletions":120,"changed_files":16}}