{"action":"created","comment":{"url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/comments/44629398","id":44629398,"diff_hunk":"@@ -515,8 +515,6 @@ public void insertDownloads(List<RevisionInternal> downloads) {\n                     }\n                 }\n \n-                if(rev.getBody() != null) rev.getBody().release();\n-","path":"src/main/java/com/couchbase/lite/replicator/PullerInternal.java","position":5,"original_position":5,"commit_id":"45a78570f63ac8e656840e4db78731f9b82c6579","original_commit_id":"45a78570f63ac8e656840e4db78731f9b82c6579","user":{"login":"hideki","id":15889,"avatar_url":"https://avatars.githubusercontent.com/u/15889?v=3","gravatar_id":"","url":"https://api.github.com/users/hideki","html_url":"https://github.com/hideki","followers_url":"https://api.github.com/users/hideki/followers","following_url":"https://api.github.com/users/hideki/following{/other_user}","gists_url":"https://api.github.com/users/hideki/gists{/gist_id}","starred_url":"https://api.github.com/users/hideki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hideki/subscriptions","organizations_url":"https://api.github.com/users/hideki/orgs","repos_url":"https://api.github.com/users/hideki/repos","events_url":"https://api.github.com/users/hideki/events{/privacy}","received_events_url":"https://api.github.com/users/hideki/received_events","type":"User","site_admin":false},"body":"`Body.compact()` is called before reaching this line. So `Body` holds `json` value. I believe iOS implementation also holds `json` value at this point. However, as you mentioned, the peak memory usage might increase by deleting this line.\r\n\r\n","created_at":"2015-11-12T07:58:41Z","updated_at":"2015-11-12T07:58:41Z","html_url":"https://github.com/couchbase/couchbase-lite-java-core/pull/817#discussion_r44629398","pull_request_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817","_links":{"self":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/comments/44629398"},"html":{"href":"https://github.com/couchbase/couchbase-lite-java-core/pull/817#discussion_r44629398"},"pull_request":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817"}}},"pull_request":{"url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817","id":50480085,"html_url":"https://github.com/couchbase/couchbase-lite-java-core/pull/817","diff_url":"https://github.com/couchbase/couchbase-lite-java-core/pull/817.diff","patch_url":"https://github.com/couchbase/couchbase-lite-java-core/pull/817.patch","issue_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/817","number":817,"state":"open","locked":false,"title":"Fixed https://github.com/couchbase/couchbase-lite-android/issues/683","user":{"login":"hideki","id":15889,"avatar_url":"https://avatars.githubusercontent.com/u/15889?v=3","gravatar_id":"","url":"https://api.github.com/users/hideki","html_url":"https://github.com/hideki","followers_url":"https://api.github.com/users/hideki/followers","following_url":"https://api.github.com/users/hideki/following{/other_user}","gists_url":"https://api.github.com/users/hideki/gists{/gist_id}","starred_url":"https://api.github.com/users/hideki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hideki/subscriptions","organizations_url":"https://api.github.com/users/hideki/orgs","repos_url":"https://api.github.com/users/hideki/repos","events_url":"https://api.github.com/users/hideki/events{/privacy}","received_events_url":"https://api.github.com/users/hideki/received_events","type":"User","site_admin":false},"body":"Inserted revision body by pull replication could be accessed from other codes. In case of the https://github.com/couchbase/couchbase-lite-android/issues/683 , `/_changes?include_docs=true` access revision body.\r\n\r\n`if(rev.getBody() != null) rev.getBody().release();` was added to reduce memory usage during pull replication, but it should not be added here.","created_at":"2015-11-12T07:36:28Z","updated_at":"2015-11-12T07:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a1498cbd16e1eb4a0dbecbb8938c50a88d3325e","assignee":{"login":"pasin","id":801454,"avatar_url":"https://avatars.githubusercontent.com/u/801454?v=3","gravatar_id":"","url":"https://api.github.com/users/pasin","html_url":"https://github.com/pasin","followers_url":"https://api.github.com/users/pasin/followers","following_url":"https://api.github.com/users/pasin/following{/other_user}","gists_url":"https://api.github.com/users/pasin/gists{/gist_id}","starred_url":"https://api.github.com/users/pasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasin/subscriptions","organizations_url":"https://api.github.com/users/pasin/orgs","repos_url":"https://api.github.com/users/pasin/repos","events_url":"https://api.github.com/users/pasin/events{/privacy}","received_events_url":"https://api.github.com/users/pasin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817/commits","review_comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817/comments","review_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/817/comments","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/statuses/45a78570f63ac8e656840e4db78731f9b82c6579","head":{"label":"couchbase:feature/issue_android_683_router_changes_2nd_attempt","ref":"feature/issue_android_683_router_changes_2nd_attempt","sha":"45a78570f63ac8e656840e4db78731f9b82c6579","user":{"login":"couchbase","id":605755,"avatar_url":"https://avatars.githubusercontent.com/u/605755?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":12310030,"name":"couchbase-lite-java-core","full_name":"couchbase/couchbase-lite-java-core","owner":{"login":"couchbase","id":605755,"avatar_url":"https://avatars.githubusercontent.com/u/605755?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbase/couchbase-lite-java-core","description":"Couchbase Lite Java core library","fork":false,"url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core","forks_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/forks","keys_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/teams","hooks_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/hooks","issue_events_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/events","assignees_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/tags","blobs_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/languages","stargazers_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/stargazers","contributors_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/contributors","subscribers_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/subscribers","subscription_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/subscription","commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/merges","archive_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/downloads","issues_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/releases{/id}","created_at":"2013-08-22T23:13:23Z","updated_at":"2015-10-28T23:11:10Z","pushed_at":"2015-11-12T07:36:28Z","git_url":"git://github.com/couchbase/couchbase-lite-java-core.git","ssh_url":"git@github.com:couchbase/couchbase-lite-java-core.git","clone_url":"https://github.com/couchbase/couchbase-lite-java-core.git","svn_url":"https://github.com/couchbase/couchbase-lite-java-core","homepage":"","size":12927,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":166,"forks":57,"open_issues":166,"watchers":32,"default_branch":"master"}},"base":{"label":"couchbase:hotfix/1.1.0.2184","ref":"hotfix/1.1.0.2184","sha":"733954834d71d7b15426f4c685c8ff002461bbb1","user":{"login":"couchbase","id":605755,"avatar_url":"https://avatars.githubusercontent.com/u/605755?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":12310030,"name":"couchbase-lite-java-core","full_name":"couchbase/couchbase-lite-java-core","owner":{"login":"couchbase","id":605755,"avatar_url":"https://avatars.githubusercontent.com/u/605755?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbase/couchbase-lite-java-core","description":"Couchbase Lite Java core library","fork":false,"url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core","forks_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/forks","keys_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/teams","hooks_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/hooks","issue_events_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/events","assignees_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/tags","blobs_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/languages","stargazers_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/stargazers","contributors_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/contributors","subscribers_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/subscribers","subscription_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/subscription","commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/merges","archive_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/downloads","issues_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/releases{/id}","created_at":"2013-08-22T23:13:23Z","updated_at":"2015-10-28T23:11:10Z","pushed_at":"2015-11-12T07:36:28Z","git_url":"git://github.com/couchbase/couchbase-lite-java-core.git","ssh_url":"git@github.com:couchbase/couchbase-lite-java-core.git","clone_url":"https://github.com/couchbase/couchbase-lite-java-core.git","svn_url":"https://github.com/couchbase/couchbase-lite-java-core","homepage":"","size":12927,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":166,"forks":57,"open_issues":166,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817"},"html":{"href":"https://github.com/couchbase/couchbase-lite-java-core/pull/817"},"issue":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/817"},"comments":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/817/comments"},"review_comments":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817/comments"},"review_comment":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/pulls/817/commits"},"statuses":{"href":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/statuses/45a78570f63ac8e656840e4db78731f9b82c6579"}}}}