{"action":"created","issue":{"url":"https://api.github.com/repos/tildeio/rsvp.js/issues/373","labels_url":"https://api.github.com/repos/tildeio/rsvp.js/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/tildeio/rsvp.js/issues/373/comments","events_url":"https://api.github.com/repos/tildeio/rsvp.js/issues/373/events","html_url":"https://github.com/tildeio/rsvp.js/issues/373","id":60851179,"number":373,"title":"missing done() is a bummer","user":{"login":"vitaly-t","id":5108906,"avatar_url":"https://avatars.githubusercontent.com/u/5108906?v=3","gravatar_id":"","url":"https://api.github.com/users/vitaly-t","html_url":"https://github.com/vitaly-t","followers_url":"https://api.github.com/users/vitaly-t/followers","following_url":"https://api.github.com/users/vitaly-t/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-t/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-t/subscriptions","organizations_url":"https://api.github.com/users/vitaly-t/orgs","repos_url":"https://api.github.com/users/vitaly-t/repos","events_url":"https://api.github.com/users/vitaly-t/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-t/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-03-12T16:48:24Z","updated_at":"2015-03-22T02:42:19Z","closed_at":"2015-03-12T17:03:26Z","body":"I've been working on my own library that's compatible with most of Promises/A+ implementations:\r\n\r\nhttps://github.com/vitaly-t/pg-promise\r\n\r\nAnd here's the result of running tests for compatibility that should give you an idea for a change ;)\r\n\r\n* Promise - PASS;\r\n* Bluebird - PASS;\r\n* When - PASS;\r\n* Q - PASS;\r\n* RSVP - FAIL: missing method `done()`, have to replace with `finally()`\r\n* Lie - FAIL: missing method `done()`, no alternative provided;\r\n\r\nNever mind `Lie`, it lost its momentum, but you see that all major competitions have `done()` in their implementation, so it is fair to say you guys really should add it also.\r\n"},"comment":{"url":"https://api.github.com/repos/tildeio/rsvp.js/issues/comments/84502426","html_url":"https://github.com/tildeio/rsvp.js/issues/373#issuecomment-84502426","issue_url":"https://api.github.com/repos/tildeio/rsvp.js/issues/373","id":84502426,"user":{"login":"vitaly-t","id":5108906,"avatar_url":"https://avatars.githubusercontent.com/u/5108906?v=3","gravatar_id":"","url":"https://api.github.com/users/vitaly-t","html_url":"https://github.com/vitaly-t","followers_url":"https://api.github.com/users/vitaly-t/followers","following_url":"https://api.github.com/users/vitaly-t/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-t/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-t/subscriptions","organizations_url":"https://api.github.com/users/vitaly-t/orgs","repos_url":"https://api.github.com/users/vitaly-t/repos","events_url":"https://api.github.com/users/vitaly-t/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-t/received_events","type":"User","site_admin":false},"created_at":"2015-03-22T02:42:19Z","updated_at":"2015-03-22T02:42:19Z","body":"So much talking about a perfect architecture, while it's being failing tests for 2 weeks now :(\r\n"}}