{"action":"created","comment":{"url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/comments/32050653","id":32050653,"diff_hunk":"@@ -39,6 +39,8 @@\n (require 'merlin)\n (require 'flycheck)\n \n+(defvar merlin-command-priority) ;; enjoy dynamic scoping","path":"flycheck-ocaml.el","position":4,"original_position":4,"commit_id":"6bb8f9fe58dcde0a26c91d58fd52914d2eb5bf58","original_commit_id":"6bb8f9fe58dcde0a26c91d58fd52914d2eb5bf58","user":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"body":"I find this strange.  We already `(require 'merlin)`.  Why do we have to define this variable explicitly?  Does Merlin not define it?","created_at":"2015-06-09T19:03:59Z","updated_at":"2015-06-09T19:03:59Z","html_url":"https://github.com/flycheck/flycheck-ocaml/pull/4#discussion_r32050653","pull_request_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/comments/32050653"},"html":{"href":"https://github.com/flycheck/flycheck-ocaml/pull/4#discussion_r32050653"},"pull_request":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4","id":37282232,"html_url":"https://github.com/flycheck/flycheck-ocaml/pull/4","diff_url":"https://github.com/flycheck/flycheck-ocaml/pull/4.diff","patch_url":"https://github.com/flycheck/flycheck-ocaml/pull/4.patch","issue_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/4","number":4,"state":"open","locked":false,"title":"Use \"command priority\" of merlin-mode to handle racy situations","user":{"login":"def-lkb","id":1048096,"avatar_url":"https://avatars.githubusercontent.com/u/1048096?v=3","gravatar_id":"","url":"https://api.github.com/users/def-lkb","html_url":"https://github.com/def-lkb","followers_url":"https://api.github.com/users/def-lkb/followers","following_url":"https://api.github.com/users/def-lkb/following{/other_user}","gists_url":"https://api.github.com/users/def-lkb/gists{/gist_id}","starred_url":"https://api.github.com/users/def-lkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/def-lkb/subscriptions","organizations_url":"https://api.github.com/users/def-lkb/orgs","repos_url":"https://api.github.com/users/def-lkb/repos","events_url":"https://api.github.com/users/def-lkb/events{/privacy}","received_events_url":"https://api.github.com/users/def-lkb/received_events","type":"User","site_admin":false},"body":"The fix for handling competing access to merlin.\r\nThe idea is that `flycheck-ocaml` indicates its low priority and if merlin can't satisfy the request, merlin-cancelled will be signaled (only `merlin-sync-to-point` can fail).\r\n\r\nNote the `(defvar merlin-command-priority)`: the file is lexically-scoped, but merlin-mode expects this setting to be dynamically redefined. Using a defvar seems to be the normal way to recover dynamic scoping.","created_at":"2015-06-09T18:10:13Z","updated_at":"2015-06-09T19:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3b24447770f49483f51c895f77240ad9f0b398c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4/commits","review_comments_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4/comments","review_comment_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/4/comments","statuses_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/statuses/6bb8f9fe58dcde0a26c91d58fd52914d2eb5bf58","head":{"label":"def-lkb:master","ref":"master","sha":"6bb8f9fe58dcde0a26c91d58fd52914d2eb5bf58","user":{"login":"def-lkb","id":1048096,"avatar_url":"https://avatars.githubusercontent.com/u/1048096?v=3","gravatar_id":"","url":"https://api.github.com/users/def-lkb","html_url":"https://github.com/def-lkb","followers_url":"https://api.github.com/users/def-lkb/followers","following_url":"https://api.github.com/users/def-lkb/following{/other_user}","gists_url":"https://api.github.com/users/def-lkb/gists{/gist_id}","starred_url":"https://api.github.com/users/def-lkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/def-lkb/subscriptions","organizations_url":"https://api.github.com/users/def-lkb/orgs","repos_url":"https://api.github.com/users/def-lkb/repos","events_url":"https://api.github.com/users/def-lkb/events{/privacy}","received_events_url":"https://api.github.com/users/def-lkb/received_events","type":"User","site_admin":false},"repo":{"id":36999322,"name":"flycheck-ocaml","full_name":"def-lkb/flycheck-ocaml","owner":{"login":"def-lkb","id":1048096,"avatar_url":"https://avatars.githubusercontent.com/u/1048096?v=3","gravatar_id":"","url":"https://api.github.com/users/def-lkb","html_url":"https://github.com/def-lkb","followers_url":"https://api.github.com/users/def-lkb/followers","following_url":"https://api.github.com/users/def-lkb/following{/other_user}","gists_url":"https://api.github.com/users/def-lkb/gists{/gist_id}","starred_url":"https://api.github.com/users/def-lkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/def-lkb/subscriptions","organizations_url":"https://api.github.com/users/def-lkb/orgs","repos_url":"https://api.github.com/users/def-lkb/repos","events_url":"https://api.github.com/users/def-lkb/events{/privacy}","received_events_url":"https://api.github.com/users/def-lkb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/def-lkb/flycheck-ocaml","description":"OCaml support for Flycheck using Merlin","fork":true,"url":"https://api.github.com/repos/def-lkb/flycheck-ocaml","forks_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/forks","keys_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/teams","hooks_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/hooks","issue_events_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/events","assignees_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/tags","blobs_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/languages","stargazers_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/stargazers","contributors_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/contributors","subscribers_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/subscribers","subscription_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/subscription","commits_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/merges","archive_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/downloads","issues_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/labels{/name}","releases_url":"https://api.github.com/repos/def-lkb/flycheck-ocaml/releases{/id}","created_at":"2015-06-07T00:19:21Z","updated_at":"2015-06-07T00:19:21Z","pushed_at":"2015-06-07T00:21:24Z","git_url":"git://github.com/def-lkb/flycheck-ocaml.git","ssh_url":"git@github.com:def-lkb/flycheck-ocaml.git","clone_url":"https://github.com/def-lkb/flycheck-ocaml.git","svn_url":"https://github.com/def-lkb/flycheck-ocaml","homepage":"","size":360,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flycheck:master","ref":"master","sha":"247b533a36b2d4753969dff6f784f6455027b947","user":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":27186162,"name":"flycheck-ocaml","full_name":"flycheck/flycheck-ocaml","owner":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flycheck/flycheck-ocaml","description":"OCaml support for Flycheck using Merlin","fork":false,"url":"https://api.github.com/repos/flycheck/flycheck-ocaml","forks_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/forks","keys_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/teams","hooks_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/hooks","issue_events_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/events","assignees_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/tags","blobs_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/languages","stargazers_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/stargazers","contributors_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/contributors","subscribers_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/subscribers","subscription_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/subscription","commits_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/merges","archive_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/downloads","issues_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/labels{/name}","releases_url":"https://api.github.com/repos/flycheck/flycheck-ocaml/releases{/id}","created_at":"2014-11-26T16:42:08Z","updated_at":"2015-06-07T14:46:38Z","pushed_at":"2015-06-09T18:10:14Z","git_url":"git://github.com/flycheck/flycheck-ocaml.git","ssh_url":"git@github.com:flycheck/flycheck-ocaml.git","clone_url":"https://github.com/flycheck/flycheck-ocaml.git","svn_url":"https://github.com/flycheck/flycheck-ocaml","homepage":"","size":360,"stargazers_count":4,"watchers_count":4,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4"},"html":{"href":"https://github.com/flycheck/flycheck-ocaml/pull/4"},"issue":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/4"},"comments":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/flycheck/flycheck-ocaml/statuses/6bb8f9fe58dcde0a26c91d58fd52914d2eb5bf58"}}}}