{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/38799552","id":38799552,"diff_hunk":"@@ -2352,7 +2362,8 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi\n                             operand.kind !== SyntaxKind.PostfixUnaryExpression &&\r\n                             operand.kind !== SyntaxKind.NewExpression &&\r\n                             !(operand.kind === SyntaxKind.CallExpression && node.parent.kind === SyntaxKind.NewExpression) &&\r\n-                            !(operand.kind === SyntaxKind.FunctionExpression && node.parent.kind === SyntaxKind.CallExpression)) {\r\n+                            !(operand.kind === SyntaxKind.FunctionExpression && node.parent.kind === SyntaxKind.CallExpression) &&\r\n+                            !(operand.kind === SyntaxKind.NumericLiteral && node.parent.kind === SyntaxKind.PropertyAccessExpression && !/^0[box]|[e.]/i.test(getEmittingNumericLiteralText(<LiteralExpression>operand)))) {\r","path":"src/compiler/emitter.ts","position":23,"original_position":23,"commit_id":"32d8a22990612e3616068960042803d63b5b3150","original_commit_id":"32d8a22990612e3616068960042803d63b5b3150","user":{"login":"DanielRosenwasser","id":972891,"avatar_url":"https://avatars.githubusercontent.com/u/972891?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielRosenwasser","html_url":"https://github.com/DanielRosenwasser","followers_url":"https://api.github.com/users/DanielRosenwasser/followers","following_url":"https://api.github.com/users/DanielRosenwasser/following{/other_user}","gists_url":"https://api.github.com/users/DanielRosenwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRosenwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRosenwasser/subscriptions","organizations_url":"https://api.github.com/users/DanielRosenwasser/orgs","repos_url":"https://api.github.com/users/DanielRosenwasser/repos","events_url":"https://api.github.com/users/DanielRosenwasser/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRosenwasser/received_events","type":"User","site_admin":false},"body":"This doesn't cover when your numeric literal consists of escapes sequences.","created_at":"2015-09-04T22:28:34Z","updated_at":"2015-09-04T22:28:34Z","html_url":"https://github.com/Microsoft/TypeScript/pull/4641#discussion_r38799552","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/38799552"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/4641#discussion_r38799552"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641","id":44222965,"html_url":"https://github.com/Microsoft/TypeScript/pull/4641","diff_url":"https://github.com/Microsoft/TypeScript/pull/4641.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/4641.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/4641","number":4641,"state":"open","locked":false,"title":"Do not omit parentheses for numeric literal with \".property\" if it can not be followed by dot operator directly.","user":{"login":"vilic","id":970430,"avatar_url":"https://avatars.githubusercontent.com/u/970430?v=3","gravatar_id":"","url":"https://api.github.com/users/vilic","html_url":"https://github.com/vilic","followers_url":"https://api.github.com/users/vilic/followers","following_url":"https://api.github.com/users/vilic/following{/other_user}","gists_url":"https://api.github.com/users/vilic/gists{/gist_id}","starred_url":"https://api.github.com/users/vilic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilic/subscriptions","organizations_url":"https://api.github.com/users/vilic/orgs","repos_url":"https://api.github.com/users/vilic/repos","events_url":"https://api.github.com/users/vilic/events{/privacy}","received_events_url":"https://api.github.com/users/vilic/received_events","type":"User","site_admin":false},"body":"Fix issue #4603.\r\n\r\nAdded a function `getEmittingNumericLiteralText` as a helper of determine whether we want to keep the parentheses, as the emitted numeric literal maybe different under different target.\r\n\r\nE.g., `0o123` emits `83` (which needs the parentheses) under ES3/5, but emits `0o123` under ES6.","created_at":"2015-09-04T14:22:04Z","updated_at":"2015-09-04T22:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad52514e5c9c6b2717c1eef02a5ee82b8d774b6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/4641/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/32d8a22990612e3616068960042803d63b5b3150","head":{"label":"vilic:cast-expression-parentheses-with-numeric-literal","ref":"cast-expression-parentheses-with-numeric-literal","sha":"32d8a22990612e3616068960042803d63b5b3150","user":{"login":"vilic","id":970430,"avatar_url":"https://avatars.githubusercontent.com/u/970430?v=3","gravatar_id":"","url":"https://api.github.com/users/vilic","html_url":"https://github.com/vilic","followers_url":"https://api.github.com/users/vilic/followers","following_url":"https://api.github.com/users/vilic/following{/other_user}","gists_url":"https://api.github.com/users/vilic/gists{/gist_id}","starred_url":"https://api.github.com/users/vilic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilic/subscriptions","organizations_url":"https://api.github.com/users/vilic/orgs","repos_url":"https://api.github.com/users/vilic/repos","events_url":"https://api.github.com/users/vilic/events{/privacy}","received_events_url":"https://api.github.com/users/vilic/received_events","type":"User","site_admin":false},"repo":{"id":41917513,"name":"TypeScript","full_name":"vilic/TypeScript","owner":{"login":"vilic","id":970430,"avatar_url":"https://avatars.githubusercontent.com/u/970430?v=3","gravatar_id":"","url":"https://api.github.com/users/vilic","html_url":"https://github.com/vilic","followers_url":"https://api.github.com/users/vilic/followers","following_url":"https://api.github.com/users/vilic/following{/other_user}","gists_url":"https://api.github.com/users/vilic/gists{/gist_id}","starred_url":"https://api.github.com/users/vilic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilic/subscriptions","organizations_url":"https://api.github.com/users/vilic/orgs","repos_url":"https://api.github.com/users/vilic/repos","events_url":"https://api.github.com/users/vilic/events{/privacy}","received_events_url":"https://api.github.com/users/vilic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilic/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/vilic/TypeScript","forks_url":"https://api.github.com/repos/vilic/TypeScript/forks","keys_url":"https://api.github.com/repos/vilic/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilic/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilic/TypeScript/teams","hooks_url":"https://api.github.com/repos/vilic/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/vilic/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/vilic/TypeScript/events","assignees_url":"https://api.github.com/repos/vilic/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/vilic/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/vilic/TypeScript/tags","blobs_url":"https://api.github.com/repos/vilic/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilic/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilic/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilic/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilic/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/vilic/TypeScript/languages","stargazers_url":"https://api.github.com/repos/vilic/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/vilic/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/vilic/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/vilic/TypeScript/subscription","commits_url":"https://api.github.com/repos/vilic/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilic/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilic/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilic/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/vilic/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/vilic/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilic/TypeScript/merges","archive_url":"https://api.github.com/repos/vilic/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilic/TypeScript/downloads","issues_url":"https://api.github.com/repos/vilic/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/vilic/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/vilic/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/vilic/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilic/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/vilic/TypeScript/releases{/id}","created_at":"2015-09-04T13:33:30Z","updated_at":"2015-09-04T13:34:07Z","pushed_at":"2015-09-04T14:15:52Z","git_url":"git://github.com/vilic/TypeScript.git","ssh_url":"git@github.com:vilic/TypeScript.git","clone_url":"https://github.com/vilic/TypeScript.git","svn_url":"https://github.com/vilic/TypeScript","homepage":"http://www.typescriptlang.org","size":1040041,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"dc867368200feaf56bbb9bb3317bfe357cce3fd5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","created_at":"2014-06-17T15:28:39Z","updated_at":"2015-09-04T22:07:24Z","pushed_at":"2015-09-04T20:36:15Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":1040041,"stargazers_count":6553,"watchers_count":6553,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":734,"mirror_url":null,"open_issues_count":803,"forks":734,"open_issues":803,"watchers":6553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/4641"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/4641"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/4641/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/4641/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/32d8a22990612e3616068960042803d63b5b3150"}}}}