{"action":"created","issue":{"url":"https://api.github.com/repos/allegro/ralph_pricing/issues/372","labels_url":"https://api.github.com/repos/allegro/ralph_pricing/issues/372/labels{/name}","comments_url":"https://api.github.com/repos/allegro/ralph_pricing/issues/372/comments","events_url":"https://api.github.com/repos/allegro/ralph_pricing/issues/372/events","html_url":"https://github.com/allegro/ralph_pricing/pull/372","id":55386016,"number":372,"title":"fixed pricing service costs calculation, improved log details and added possibility to save only first depth costs","user":{"login":"mkurek","id":107437,"avatar_url":"https://avatars.githubusercontent.com/u/107437?v=3","gravatar_id":"","url":"https://api.github.com/users/mkurek","html_url":"https://github.com/mkurek","followers_url":"https://api.github.com/users/mkurek/followers","following_url":"https://api.github.com/users/mkurek/following{/other_user}","gists_url":"https://api.github.com/users/mkurek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurek/subscriptions","organizations_url":"https://api.github.com/users/mkurek/orgs","repos_url":"https://api.github.com/users/mkurek/repos","events_url":"https://api.github.com/users/mkurek/events{/privacy}","received_events_url":"https://api.github.com/users/mkurek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-24T21:47:11Z","updated_at":"2015-01-25T11:29:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/allegro/ralph_pricing/pulls/372","html_url":"https://github.com/allegro/ralph_pricing/pull/372","diff_url":"https://github.com/allegro/ralph_pricing/pull/372.diff","patch_url":"https://github.com/allegro/ralph_pricing/pull/372.patch"},"body":"* fixed pricing service costs calculation\r\n  * removed unnecessary excluded_services passed to dependent services (excluded services are only relevant on costs distribution, not calculatin total costs of pricing serivce)\r\n  * fixed calculation of costs from services, which charge pricing service by their diff with real costs (previously costs dictionary was basicly updated by diff costs, which causes lost of previously calculated values - now if key is already in dictionary, substraction on costs is done)\r\n  * fixed total_cost method for pricing service, when calculating costs of whole service (for all service environments) - when pricing service has other plugin than universal (ex. fixed price plugin), it's service usages percentage division doesn't matter - especially sum could be different than 100, which causes errors when calculating total cost of this pricing service using universal plugin. Now, when total costs is calculated for all service environment, there is no cost-distribution part - only calculating total costs for all service environments.\r\n\r\n* unification of costs plugins log messages\r\n* added possibility to save only first depth costs (direct costs, not intermediate), which could significantly improve costs calculation performance, but intermediate costs (ex. for costs-dependency-graph) will not be saved"},"comment":{"url":"https://api.github.com/repos/allegro/ralph_pricing/issues/comments/71367717","html_url":"https://github.com/allegro/ralph_pricing/pull/372#issuecomment-71367717","issue_url":"https://api.github.com/repos/allegro/ralph_pricing/issues/372","id":71367717,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T11:29:10Z","updated_at":"2015-01-25T11:29:10Z","body":"\n[![Coverage Status](https://coveralls.io/builds/1801582/badge)](https://coveralls.io/builds/1801582)\n\nCoverage increased (+0.33%) to 77.87% when pulling **9580040b8a29655519a42230bfada9943bb15829 on mkurek:fix/pricing-service-diff-service-environments** into **eef1083b5b8d8fde953820984e55004e5c9bc42e on allegro:develop**.\n"}}