{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/30427038","id":30427038,"diff_hunk":"@@ -1668,11 +1753,18 @@ func (kl *Kubelet) tryUpdateNodeStatus() error {\n \t// cAdvisor locally, e.g. for test-cmd.sh, and in integration test.\n \tinfo, err := kl.GetCachedMachineInfo()\n \tif err != nil {\n-\t\tglog.Errorf(\"error getting machine info: %v\", err)\n+\t\t// TODO(roberthbailey): This is required for test-cmd.sh to pass.","path":"pkg/kubelet/kubelet.go","position":208,"original_position":208,"commit_id":"de90d601aa843be714f40a7b301f5aad6c4d8ccf","original_commit_id":"de90d601aa843be714f40a7b301f5aad6c4d8ccf","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"That sounds reasonable and it'll allow us to keep data we knew to be true.\n\nIt is important to note that under normal circumstances cAdvisor is\nrunning, I have yet to see a situation in production where it is not. These\nedge cases happen in testing where we mock or stub out different parts of\nthe Kubelet.\n\nOn Fri, May 15, 2015 at 10:08 AM, Clayton Coleman <notifications@github.com>\nwrote:\n\n> In pkg/kubelet/kubelet.go\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/6949#discussion_r30426565>\n> :\n>\n> > @@ -1668,11 +1753,18 @@ func (kl *Kubelet) tryUpdateNodeStatus() error {\n> >  \t// cAdvisor locally, e.g. for test-cmd.sh, and in integration test.\n> >  \tinfo, err := kl.GetCachedMachineInfo()\n> >  \tif err != nil {\n> > -\t\tglog.Errorf(\"error getting machine info: %v\", err)\n> > +\t\t// TODO(roberthbailey): This is required for test-cmd.sh to pass.\n>\n> Anyone can call the node api. If cadvisor can't report anything, and the\n> node already has something, should the node overwrite the capacity? I would\n> argue it should set zero if nothing is set, but if it's explicitly set\n> (perhaps from the last time) it shouldn't be reset. Not a massively strong\n> feeling, but if cadvisor is dead I don't know that we should be making the\n> node completely unschedulable (by forcing capacity to 0)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/6949/files#r30426565>\n> .\n>\n","created_at":"2015-05-15T17:14:34Z","updated_at":"2015-05-15T17:14:34Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949#discussion_r30427038","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/30427038"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949#discussion_r30427038"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949","id":33507891,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6949","number":6949,"state":"open","locked":false,"title":"Modify nodes to register directly with the master.","user":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"body":"Ref #6087. \r\nFixes #7495. ","created_at":"2015-04-17T01:28:31Z","updated_at":"2015-05-15T17:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8de291e5bf1300266067f89f4cc1b19e61e61e45","assignee":{"login":"cjcullen","id":7154008,"avatar_url":"https://avatars.githubusercontent.com/u/7154008?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcullen","html_url":"https://github.com/cjcullen","followers_url":"https://api.github.com/users/cjcullen/followers","following_url":"https://api.github.com/users/cjcullen/following{/other_user}","gists_url":"https://api.github.com/users/cjcullen/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcullen/subscriptions","organizations_url":"https://api.github.com/users/cjcullen/orgs","repos_url":"https://api.github.com/users/cjcullen/repos","events_url":"https://api.github.com/users/cjcullen/events{/privacy}","received_events_url":"https://api.github.com/users/cjcullen/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6949/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/de90d601aa843be714f40a7b301f5aad6c4d8ccf","head":{"label":"roberthbailey:node-register","ref":"node-register","sha":"de90d601aa843be714f40a7b301f5aad6c4d8ccf","user":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"repo":{"id":21398175,"name":"kubernetes","full_name":"roberthbailey/kubernetes","owner":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roberthbailey/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/roberthbailey/kubernetes","forks_url":"https://api.github.com/repos/roberthbailey/kubernetes/forks","keys_url":"https://api.github.com/repos/roberthbailey/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roberthbailey/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roberthbailey/kubernetes/teams","hooks_url":"https://api.github.com/repos/roberthbailey/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/roberthbailey/kubernetes/events","assignees_url":"https://api.github.com/repos/roberthbailey/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/roberthbailey/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/roberthbailey/kubernetes/tags","blobs_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roberthbailey/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/roberthbailey/kubernetes/languages","stargazers_url":"https://api.github.com/repos/roberthbailey/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/roberthbailey/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/roberthbailey/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/roberthbailey/kubernetes/subscription","commits_url":"https://api.github.com/repos/roberthbailey/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/roberthbailey/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/roberthbailey/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/roberthbailey/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roberthbailey/kubernetes/merges","archive_url":"https://api.github.com/repos/roberthbailey/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roberthbailey/kubernetes/downloads","issues_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/roberthbailey/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/roberthbailey/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/roberthbailey/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roberthbailey/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/roberthbailey/kubernetes/releases{/id}","created_at":"2014-07-01T18:28:50Z","updated_at":"2015-05-08T18:53:49Z","pushed_at":"2015-05-14T23:06:20Z","git_url":"git://github.com/roberthbailey/kubernetes.git","ssh_url":"git@github.com:roberthbailey/kubernetes.git","clone_url":"https://github.com/roberthbailey/kubernetes.git","svn_url":"https://github.com/roberthbailey/kubernetes","homepage":null,"size":54137,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"c50f90617016d6fb36ba3b43b5fdf0530075d6b9","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-15T13:35:53Z","pushed_at":"2015-05-15T17:01:37Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":267253,"stargazers_count":7664,"watchers_count":7664,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1568,"mirror_url":null,"open_issues_count":1099,"forks":1568,"open_issues":1099,"watchers":7664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6949"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6949"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6949/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6949/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/de90d601aa843be714f40a7b301f5aad6c4d8ccf"}}}}