{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29795492","id":29795492,"diff_hunk":"@@ -76,9 +76,16 @@ public void Dispose()\n             var blendedTokens = _blendedTokens;\n             if (blendedTokens != null)\n             {\n-                Array.Clear(_blendedTokens, 0, _blendedTokens.Length);\n-                s_blendedNodesPool.Free(_blendedTokens);\n                 _blendedTokens = null;\n+                Array.Clear(blendedTokens, 0, blendedTokens.Length);","path":"src/Compilers/CSharp/Portable/Parser/SyntaxParser.cs","position":7,"original_position":7,"commit_id":"598cf3ee6677763ac947d7ce4a660881ee4c6c00","original_commit_id":"598cf3ee6677763ac947d7ce4a660881ee4c6c00","user":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars.githubusercontent.com/u/8218165?v=3","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"body":"no need to clear when not returning to the pool","created_at":"2015-05-06T19:56:29Z","updated_at":"2015-05-06T19:56:29Z","html_url":"https://github.com/dotnet/roslyn/pull/2558#discussion_r29795492","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2558","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29795492"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2558#discussion_r29795492"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2558"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2558","id":34852475,"html_url":"https://github.com/dotnet/roslyn/pull/2558","diff_url":"https://github.com/dotnet/roslyn/pull/2558.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2558.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2558","number":2558,"state":"open","locked":false,"title":"Blended node pooling","user":{"login":"pharring","id":9952654,"avatar_url":"https://avatars.githubusercontent.com/u/9952654?v=3","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"body":"Limit the size of BlendedNode arrays returned to the pool in C# incremental parsing. The 4096 value was determined by gathering statistics on typing scenarios in a reasonably large solution. The pathological case described in #2551 has over 2^19 elements.\r\nFixes #2551 \r\n","created_at":"2015-05-06T19:42:32Z","updated_at":"2015-05-06T19:56:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"279135eec1d3d3fc63e6ee1eb8c0f2b4d97710b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2558/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2558/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2558/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/598cf3ee6677763ac947d7ce4a660881ee4c6c00","head":{"label":"pharring:BlendedNodePooling","ref":"BlendedNodePooling","sha":"598cf3ee6677763ac947d7ce4a660881ee4c6c00","user":{"login":"pharring","id":9952654,"avatar_url":"https://avatars.githubusercontent.com/u/9952654?v=3","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"repo":{"id":30550474,"name":"roslyn","full_name":"pharring/roslyn","owner":{"login":"pharring","id":9952654,"avatar_url":"https://avatars.githubusercontent.com/u/9952654?v=3","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pharring/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/pharring/roslyn","forks_url":"https://api.github.com/repos/pharring/roslyn/forks","keys_url":"https://api.github.com/repos/pharring/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pharring/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pharring/roslyn/teams","hooks_url":"https://api.github.com/repos/pharring/roslyn/hooks","issue_events_url":"https://api.github.com/repos/pharring/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/pharring/roslyn/events","assignees_url":"https://api.github.com/repos/pharring/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/pharring/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/pharring/roslyn/tags","blobs_url":"https://api.github.com/repos/pharring/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pharring/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pharring/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/pharring/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pharring/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/pharring/roslyn/languages","stargazers_url":"https://api.github.com/repos/pharring/roslyn/stargazers","contributors_url":"https://api.github.com/repos/pharring/roslyn/contributors","subscribers_url":"https://api.github.com/repos/pharring/roslyn/subscribers","subscription_url":"https://api.github.com/repos/pharring/roslyn/subscription","commits_url":"https://api.github.com/repos/pharring/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/pharring/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/pharring/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/pharring/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/pharring/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/pharring/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pharring/roslyn/merges","archive_url":"https://api.github.com/repos/pharring/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pharring/roslyn/downloads","issues_url":"https://api.github.com/repos/pharring/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/pharring/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/pharring/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/pharring/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pharring/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/pharring/roslyn/releases{/id}","created_at":"2015-02-09T18:13:42Z","updated_at":"2015-05-06T16:11:44Z","pushed_at":"2015-05-06T19:48:41Z","git_url":"git://github.com/pharring/roslyn.git","ssh_url":"git@github.com:pharring/roslyn.git","clone_url":"https://github.com/pharring/roslyn.git","svn_url":"https://github.com/pharring/roslyn","homepage":"","size":71995,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d23b86c8532f4b79e2bdbe5080df7a1d625f9721","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-06T18:27:22Z","pushed_at":"2015-05-06T19:55:29Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":126093,"stargazers_count":2205,"watchers_count":2205,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":461,"mirror_url":null,"open_issues_count":778,"forks":461,"open_issues":778,"watchers":2205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2558"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2558"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2558"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2558/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2558/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2558/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/598cf3ee6677763ac947d7ce4a660881ee4c6c00"}}}}