{"action":"created","issue":{"url":"https://api.github.com/repos/raintank/meta/issues/4","labels_url":"https://api.github.com/repos/raintank/meta/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/raintank/meta/issues/4/comments","events_url":"https://api.github.com/repos/raintank/meta/issues/4/events","html_url":"https://github.com/raintank/meta/issues/4","id":114104543,"number":4,"title":"when to close tickets, tracking fix verification status","user":{"login":"Dieterbe","id":20774,"avatar_url":"https://avatars.githubusercontent.com/u/20774?v=3","gravatar_id":"","url":"https://api.github.com/users/Dieterbe","html_url":"https://github.com/Dieterbe","followers_url":"https://api.github.com/users/Dieterbe/followers","following_url":"https://api.github.com/users/Dieterbe/following{/other_user}","gists_url":"https://api.github.com/users/Dieterbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterbe/subscriptions","organizations_url":"https://api.github.com/users/Dieterbe/orgs","repos_url":"https://api.github.com/users/Dieterbe/repos","events_url":"https://api.github.com/users/Dieterbe/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-29T17:33:57Z","updated_at":"2015-10-29T19:01:56Z","closed_at":null,"body":"@torkelo mentioned this the other day but we didn't actually commit to anything.\r\nthe idea of tracking tickets through the bugfix->deploy->verify->done cycle.\r\ni know he wants to do lots of changes to our PM, possibly changing boards, but that's taking a while.\r\ni don't see why we can't get started using this method with our current setup. there's only 2 tiny things that need to happen:\r\n* add a \"to verify\" column to codetree between \"in progress\" and \"done\". I just did this.\r\n* now simply don't close any tickets merely after pushing a bugfix to git. rather move it to the \"to verify\" column. once the thing is live, we actually make sure it works in production, and only then do we close the ticket/move to done column.\r\n\r\ni'm deliberately keeping things very simple here. just 1 extra column. no extra \"to-deploy-dev\", \"to-deploy-prod\" columns etc.\r\n\r\nthis does come with a little bit of extra overhead which i know is not fun. but sometimes fixes don't actually seem to work, https://github.com/raintank/ops/issues/171 for example. and also external people are using our tickets to know when issues are fixed \"for them\" (i.e. live in prod), they don't care as much about it being in git or not.\r\nand finally, right now we have a mixed approach. some tickets are closed when fix is in git, for others we wait when it's live or verified.  we should be more uniform.\r\n\r\n@woodsaj @torkelo @ctdk @nopzor1200 do you think this is a good approach? or is there a better mechanism through which we can create higher reliability with less overhead?\r\none thing that i would miss is the ability to put `fix: #num` in a commit and have github auto-close the ticket on push to master.  i don't think we can make it reassign labels on push or anything like that.\r\nyet another alternative would be create a new ticket or separate state somewhere to track whether the fix has been verified or not. we could then load in a badge in the original ticket, but it wouldn't inform people about a change.\r\n\r\nso it seems like the extra verification step and keeping the ticket open longer is the least sucky solution that i can see."},"comment":{"url":"https://api.github.com/repos/raintank/meta/issues/comments/152287984","html_url":"https://github.com/raintank/meta/issues/4#issuecomment-152287984","issue_url":"https://api.github.com/repos/raintank/meta/issues/4","id":152287984,"user":{"login":"torkelo","id":10999,"avatar_url":"https://avatars.githubusercontent.com/u/10999?v=3","gravatar_id":"","url":"https://api.github.com/users/torkelo","html_url":"https://github.com/torkelo","followers_url":"https://api.github.com/users/torkelo/followers","following_url":"https://api.github.com/users/torkelo/following{/other_user}","gists_url":"https://api.github.com/users/torkelo/gists{/gist_id}","starred_url":"https://api.github.com/users/torkelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkelo/subscriptions","organizations_url":"https://api.github.com/users/torkelo/orgs","repos_url":"https://api.github.com/users/torkelo/repos","events_url":"https://api.github.com/users/torkelo/events{/privacy}","received_events_url":"https://api.github.com/users/torkelo/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T19:01:56Z","updated_at":"2015-10-29T19:01:56Z","body":"We need github labels for staging, prod, waiting-fo-deploy-to-prod , waiting-for-deploy-to-staging etc or something like that "}}