{"action":"opened","number":305,"pull_request":{"url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305","id":41723815,"html_url":"https://github.com/pdxcat/puppet-module-collectd/pull/305","diff_url":"https://github.com/pdxcat/puppet-module-collectd/pull/305.diff","patch_url":"https://github.com/pdxcat/puppet-module-collectd/pull/305.patch","issue_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/305","number":305,"state":"open","locked":false,"title":"Improve version handling to avoid multiple puppet runs for some situa…","user":{"login":"bdellegrazie","id":973480,"avatar_url":"https://avatars.githubusercontent.com/u/973480?v=3","gravatar_id":"","url":"https://api.github.com/users/bdellegrazie","html_url":"https://github.com/bdellegrazie","followers_url":"https://api.github.com/users/bdellegrazie/followers","following_url":"https://api.github.com/users/bdellegrazie/following{/other_user}","gists_url":"https://api.github.com/users/bdellegrazie/gists{/gist_id}","starred_url":"https://api.github.com/users/bdellegrazie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdellegrazie/subscriptions","organizations_url":"https://api.github.com/users/bdellegrazie/orgs","repos_url":"https://api.github.com/users/bdellegrazie/repos","events_url":"https://api.github.com/users/bdellegrazie/events{/privacy}","received_events_url":"https://api.github.com/users/bdellegrazie/received_events","type":"User","site_admin":false},"body":"…tions\r\n\r\nWhen an administrator knows the version of collectd that will be used or\r\nat least the minimum version available the need for two puppet runs before\r\nconvergence can be avoided or at least minimised.\r\n\r\nInstead of using the fact in the templates they now use a class variable\r\nset to one of (in priority order):\r\n* collectd_version (i.e. the fact)\r\n* version (the semver matched part of it only)\r\n* minimum_version (undef by default)\r\n\r\nExisting behaviour is preserved except for a corner case where version is\r\nset to something specific and collectd is not yet installed. In this case\r\npuppet will only take one run and assume the version specified when creating\r\nthe templates\r\n\r\nreferences pdxcat/puppet-module-collectd#162","created_at":"2015-08-05T20:43:06Z","updated_at":"2015-08-05T20:43:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305/commits","review_comments_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305/comments","review_comment_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/305/comments","statuses_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/statuses/434aa36a5f685bf62378d4d0fd13e8b881bf71f7","head":{"label":"bdellegrazie:fix-multiple-puppet-runs","ref":"fix-multiple-puppet-runs","sha":"434aa36a5f685bf62378d4d0fd13e8b881bf71f7","user":{"login":"bdellegrazie","id":973480,"avatar_url":"https://avatars.githubusercontent.com/u/973480?v=3","gravatar_id":"","url":"https://api.github.com/users/bdellegrazie","html_url":"https://github.com/bdellegrazie","followers_url":"https://api.github.com/users/bdellegrazie/followers","following_url":"https://api.github.com/users/bdellegrazie/following{/other_user}","gists_url":"https://api.github.com/users/bdellegrazie/gists{/gist_id}","starred_url":"https://api.github.com/users/bdellegrazie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdellegrazie/subscriptions","organizations_url":"https://api.github.com/users/bdellegrazie/orgs","repos_url":"https://api.github.com/users/bdellegrazie/repos","events_url":"https://api.github.com/users/bdellegrazie/events{/privacy}","received_events_url":"https://api.github.com/users/bdellegrazie/received_events","type":"User","site_admin":false},"repo":{"id":40210198,"name":"puppet-module-collectd","full_name":"bdellegrazie/puppet-module-collectd","owner":{"login":"bdellegrazie","id":973480,"avatar_url":"https://avatars.githubusercontent.com/u/973480?v=3","gravatar_id":"","url":"https://api.github.com/users/bdellegrazie","html_url":"https://github.com/bdellegrazie","followers_url":"https://api.github.com/users/bdellegrazie/followers","following_url":"https://api.github.com/users/bdellegrazie/following{/other_user}","gists_url":"https://api.github.com/users/bdellegrazie/gists{/gist_id}","starred_url":"https://api.github.com/users/bdellegrazie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdellegrazie/subscriptions","organizations_url":"https://api.github.com/users/bdellegrazie/orgs","repos_url":"https://api.github.com/users/bdellegrazie/repos","events_url":"https://api.github.com/users/bdellegrazie/events{/privacy}","received_events_url":"https://api.github.com/users/bdellegrazie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdellegrazie/puppet-module-collectd","description":"Collectd module for Puppet","fork":true,"url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd","forks_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/forks","keys_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/teams","hooks_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/hooks","issue_events_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/issues/events{/number}","events_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/events","assignees_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/assignees{/user}","branches_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/branches{/branch}","tags_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/tags","blobs_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/languages","stargazers_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/stargazers","contributors_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/contributors","subscribers_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/subscribers","subscription_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/subscription","commits_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/contents/{+path}","compare_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/merges","archive_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/downloads","issues_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/issues{/number}","pulls_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/labels{/name}","releases_url":"https://api.github.com/repos/bdellegrazie/puppet-module-collectd/releases{/id}","created_at":"2015-08-04T21:31:35Z","updated_at":"2015-08-04T21:31:36Z","pushed_at":"2015-08-05T19:51:05Z","git_url":"git://github.com/bdellegrazie/puppet-module-collectd.git","ssh_url":"git@github.com:bdellegrazie/puppet-module-collectd.git","clone_url":"https://github.com/bdellegrazie/puppet-module-collectd.git","svn_url":"https://github.com/bdellegrazie/puppet-module-collectd","homepage":"http://forge.puppetlabs.com/pdxcat/collectd","size":617,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pdxcat:master","ref":"master","sha":"8d89800a869981aa297f5d9103d15ad9493c6e0c","user":{"login":"pdxcat","id":649480,"avatar_url":"https://avatars.githubusercontent.com/u/649480?v=3","gravatar_id":"","url":"https://api.github.com/users/pdxcat","html_url":"https://github.com/pdxcat","followers_url":"https://api.github.com/users/pdxcat/followers","following_url":"https://api.github.com/users/pdxcat/following{/other_user}","gists_url":"https://api.github.com/users/pdxcat/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcat/subscriptions","organizations_url":"https://api.github.com/users/pdxcat/orgs","repos_url":"https://api.github.com/users/pdxcat/repos","events_url":"https://api.github.com/users/pdxcat/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcat/received_events","type":"Organization","site_admin":false},"repo":{"id":8063324,"name":"puppet-module-collectd","full_name":"pdxcat/puppet-module-collectd","owner":{"login":"pdxcat","id":649480,"avatar_url":"https://avatars.githubusercontent.com/u/649480?v=3","gravatar_id":"","url":"https://api.github.com/users/pdxcat","html_url":"https://github.com/pdxcat","followers_url":"https://api.github.com/users/pdxcat/followers","following_url":"https://api.github.com/users/pdxcat/following{/other_user}","gists_url":"https://api.github.com/users/pdxcat/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcat/subscriptions","organizations_url":"https://api.github.com/users/pdxcat/orgs","repos_url":"https://api.github.com/users/pdxcat/repos","events_url":"https://api.github.com/users/pdxcat/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pdxcat/puppet-module-collectd","description":"Collectd module for Puppet","fork":false,"url":"https://api.github.com/repos/pdxcat/puppet-module-collectd","forks_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/forks","keys_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/teams","hooks_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/hooks","issue_events_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/events{/number}","events_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/events","assignees_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/assignees{/user}","branches_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/branches{/branch}","tags_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/tags","blobs_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/languages","stargazers_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/stargazers","contributors_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/contributors","subscribers_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/subscribers","subscription_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/subscription","commits_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/contents/{+path}","compare_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/merges","archive_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/downloads","issues_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues{/number}","pulls_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/labels{/name}","releases_url":"https://api.github.com/repos/pdxcat/puppet-module-collectd/releases{/id}","created_at":"2013-02-07T00:21:39Z","updated_at":"2015-08-03T16:09:44Z","pushed_at":"2015-08-05T15:45:02Z","git_url":"git://github.com/pdxcat/puppet-module-collectd.git","ssh_url":"git@github.com:pdxcat/puppet-module-collectd.git","clone_url":"https://github.com/pdxcat/puppet-module-collectd.git","svn_url":"https://github.com/pdxcat/puppet-module-collectd","homepage":"http://forge.puppetlabs.com/pdxcat/collectd","size":2233,"stargazers_count":44,"watchers_count":44,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":22,"forks":136,"open_issues":22,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305"},"html":{"href":"https://github.com/pdxcat/puppet-module-collectd/pull/305"},"issue":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/305"},"comments":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/pdxcat/puppet-module-collectd/statuses/434aa36a5f685bf62378d4d0fd13e8b881bf71f7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":69,"deletions":57,"changed_files":29}}