{"action":"created","comment":{"url":"https://api.github.com/repos/turn/Smart-Table/pulls/comments/25676661","id":25676661,"diff_hunk":"@@ -113,6 +113,15 @@\n             };\n \n             /**\n+             * set lastColumnSort to defaultSortColumn if any based on column's reverse value\n+             * @method setDefaultSortColumn\n+             * @param column\n+             */\n+            function setDefaultSortColumn (defaultSortColumn) {\n+                lastColumnSort = (lastColumnSort !== '') ? defaultSortColumn : lastColumnSort;","path":"smart-table-module/js/Table.js","position":null,"original_position":9,"commit_id":"a7b0dac2f402b238b4cfbce777dc8297d06a28d5","original_commit_id":"c4d8e24c619da925ad25d0f3950611c899b6dd26","user":{"login":"parag-shah","id":8723799,"avatar_url":"https://avatars.githubusercontent.com/u/8723799?v=3","gravatar_id":"","url":"https://api.github.com/users/parag-shah","html_url":"https://github.com/parag-shah","followers_url":"https://api.github.com/users/parag-shah/followers","following_url":"https://api.github.com/users/parag-shah/following{/other_user}","gists_url":"https://api.github.com/users/parag-shah/gists{/gist_id}","starred_url":"https://api.github.com/users/parag-shah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parag-shah/subscriptions","organizations_url":"https://api.github.com/users/parag-shah/orgs","repos_url":"https://api.github.com/users/parag-shah/repos","events_url":"https://api.github.com/users/parag-shah/events{/privacy}","received_events_url":"https://api.github.com/users/parag-shah/received_events","type":"User","site_admin":false},"body":"@2013gang thanks for pointing out, now I have validated the `lastColumnSort` object using `angular.isObject`, this would also return false for *null* object.","created_at":"2015-03-03T10:31:08Z","updated_at":"2015-03-03T10:31:08Z","html_url":"https://github.com/turn/Smart-Table/pull/25#discussion_r25676661","pull_request_url":"https://api.github.com/repos/turn/Smart-Table/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/comments/25676661"},"html":{"href":"https://github.com/turn/Smart-Table/pull/25#discussion_r25676661"},"pull_request":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/turn/Smart-Table/pulls/25","id":29891160,"html_url":"https://github.com/turn/Smart-Table/pull/25","diff_url":"https://github.com/turn/Smart-Table/pull/25.diff","patch_url":"https://github.com/turn/Smart-Table/pull/25.patch","issue_url":"https://api.github.com/repos/turn/Smart-Table/issues/25","number":25,"state":"open","locked":false,"title":"Changes done to set lastColumnSort to already sorted column","user":{"login":"parag-shah","id":8723799,"avatar_url":"https://avatars.githubusercontent.com/u/8723799?v=3","gravatar_id":"","url":"https://api.github.com/users/parag-shah","html_url":"https://github.com/parag-shah","followers_url":"https://api.github.com/users/parag-shah/followers","following_url":"https://api.github.com/users/parag-shah/following{/other_user}","gists_url":"https://api.github.com/users/parag-shah/gists{/gist_id}","starred_url":"https://api.github.com/users/parag-shah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parag-shah/subscriptions","organizations_url":"https://api.github.com/users/parag-shah/orgs","repos_url":"https://api.github.com/users/parag-shah/repos","events_url":"https://api.github.com/users/parag-shah/events{/privacy}","received_events_url":"https://api.github.com/users/parag-shah/received_events","type":"User","site_admin":false},"body":"Jira: ASCYB-3401\r\nSigned-off-by: Parag Shah <paragsha@cybage.com>","created_at":"2015-02-24T11:56:02Z","updated_at":"2015-03-03T10:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c422af24bf4333213d1d659b97ae949be801aee5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/turn/Smart-Table/pulls/25/commits","review_comments_url":"https://api.github.com/repos/turn/Smart-Table/pulls/25/comments","review_comment_url":"https://api.github.com/repos/turn/Smart-Table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/turn/Smart-Table/issues/25/comments","statuses_url":"https://api.github.com/repos/turn/Smart-Table/statuses/a7b0dac2f402b238b4cfbce777dc8297d06a28d5","head":{"label":"parag-shah:master","ref":"master","sha":"a7b0dac2f402b238b4cfbce777dc8297d06a28d5","user":{"login":"parag-shah","id":8723799,"avatar_url":"https://avatars.githubusercontent.com/u/8723799?v=3","gravatar_id":"","url":"https://api.github.com/users/parag-shah","html_url":"https://github.com/parag-shah","followers_url":"https://api.github.com/users/parag-shah/followers","following_url":"https://api.github.com/users/parag-shah/following{/other_user}","gists_url":"https://api.github.com/users/parag-shah/gists{/gist_id}","starred_url":"https://api.github.com/users/parag-shah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parag-shah/subscriptions","organizations_url":"https://api.github.com/users/parag-shah/orgs","repos_url":"https://api.github.com/users/parag-shah/repos","events_url":"https://api.github.com/users/parag-shah/events{/privacy}","received_events_url":"https://api.github.com/users/parag-shah/received_events","type":"User","site_admin":false},"repo":{"id":31200599,"name":"Smart-Table","full_name":"parag-shah/Smart-Table","owner":{"login":"parag-shah","id":8723799,"avatar_url":"https://avatars.githubusercontent.com/u/8723799?v=3","gravatar_id":"","url":"https://api.github.com/users/parag-shah","html_url":"https://github.com/parag-shah","followers_url":"https://api.github.com/users/parag-shah/followers","following_url":"https://api.github.com/users/parag-shah/following{/other_user}","gists_url":"https://api.github.com/users/parag-shah/gists{/gist_id}","starred_url":"https://api.github.com/users/parag-shah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parag-shah/subscriptions","organizations_url":"https://api.github.com/users/parag-shah/orgs","repos_url":"https://api.github.com/users/parag-shah/repos","events_url":"https://api.github.com/users/parag-shah/events{/privacy}","received_events_url":"https://api.github.com/users/parag-shah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parag-shah/Smart-Table","description":"Code source of Smart Table module: a table/grid for Angularjs","fork":true,"url":"https://api.github.com/repos/parag-shah/Smart-Table","forks_url":"https://api.github.com/repos/parag-shah/Smart-Table/forks","keys_url":"https://api.github.com/repos/parag-shah/Smart-Table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parag-shah/Smart-Table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parag-shah/Smart-Table/teams","hooks_url":"https://api.github.com/repos/parag-shah/Smart-Table/hooks","issue_events_url":"https://api.github.com/repos/parag-shah/Smart-Table/issues/events{/number}","events_url":"https://api.github.com/repos/parag-shah/Smart-Table/events","assignees_url":"https://api.github.com/repos/parag-shah/Smart-Table/assignees{/user}","branches_url":"https://api.github.com/repos/parag-shah/Smart-Table/branches{/branch}","tags_url":"https://api.github.com/repos/parag-shah/Smart-Table/tags","blobs_url":"https://api.github.com/repos/parag-shah/Smart-Table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parag-shah/Smart-Table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parag-shah/Smart-Table/git/refs{/sha}","trees_url":"https://api.github.com/repos/parag-shah/Smart-Table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parag-shah/Smart-Table/statuses/{sha}","languages_url":"https://api.github.com/repos/parag-shah/Smart-Table/languages","stargazers_url":"https://api.github.com/repos/parag-shah/Smart-Table/stargazers","contributors_url":"https://api.github.com/repos/parag-shah/Smart-Table/contributors","subscribers_url":"https://api.github.com/repos/parag-shah/Smart-Table/subscribers","subscription_url":"https://api.github.com/repos/parag-shah/Smart-Table/subscription","commits_url":"https://api.github.com/repos/parag-shah/Smart-Table/commits{/sha}","git_commits_url":"https://api.github.com/repos/parag-shah/Smart-Table/git/commits{/sha}","comments_url":"https://api.github.com/repos/parag-shah/Smart-Table/comments{/number}","issue_comment_url":"https://api.github.com/repos/parag-shah/Smart-Table/issues/comments{/number}","contents_url":"https://api.github.com/repos/parag-shah/Smart-Table/contents/{+path}","compare_url":"https://api.github.com/repos/parag-shah/Smart-Table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parag-shah/Smart-Table/merges","archive_url":"https://api.github.com/repos/parag-shah/Smart-Table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parag-shah/Smart-Table/downloads","issues_url":"https://api.github.com/repos/parag-shah/Smart-Table/issues{/number}","pulls_url":"https://api.github.com/repos/parag-shah/Smart-Table/pulls{/number}","milestones_url":"https://api.github.com/repos/parag-shah/Smart-Table/milestones{/number}","notifications_url":"https://api.github.com/repos/parag-shah/Smart-Table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parag-shah/Smart-Table/labels{/name}","releases_url":"https://api.github.com/repos/parag-shah/Smart-Table/releases{/id}","created_at":"2015-02-23T09:11:46Z","updated_at":"2015-03-03T10:11:48Z","pushed_at":"2015-03-03T10:11:48Z","git_url":"git://github.com/parag-shah/Smart-Table.git","ssh_url":"git@github.com:parag-shah/Smart-Table.git","clone_url":"https://github.com/parag-shah/Smart-Table.git","svn_url":"https://github.com/parag-shah/Smart-Table","homepage":"http://lorenzofox3.github.io/smart-table-website/","size":8356,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"turn:master","ref":"master","sha":"47f63dc0132ada61baf0f98ca0b7e1d97f9fd831","user":{"login":"turn","id":882636,"avatar_url":"https://avatars.githubusercontent.com/u/882636?v=3","gravatar_id":"","url":"https://api.github.com/users/turn","html_url":"https://github.com/turn","followers_url":"https://api.github.com/users/turn/followers","following_url":"https://api.github.com/users/turn/following{/other_user}","gists_url":"https://api.github.com/users/turn/gists{/gist_id}","starred_url":"https://api.github.com/users/turn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turn/subscriptions","organizations_url":"https://api.github.com/users/turn/orgs","repos_url":"https://api.github.com/users/turn/repos","events_url":"https://api.github.com/users/turn/events{/privacy}","received_events_url":"https://api.github.com/users/turn/received_events","type":"Organization","site_admin":false},"repo":{"id":16970769,"name":"Smart-Table","full_name":"turn/Smart-Table","owner":{"login":"turn","id":882636,"avatar_url":"https://avatars.githubusercontent.com/u/882636?v=3","gravatar_id":"","url":"https://api.github.com/users/turn","html_url":"https://github.com/turn","followers_url":"https://api.github.com/users/turn/followers","following_url":"https://api.github.com/users/turn/following{/other_user}","gists_url":"https://api.github.com/users/turn/gists{/gist_id}","starred_url":"https://api.github.com/users/turn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turn/subscriptions","organizations_url":"https://api.github.com/users/turn/orgs","repos_url":"https://api.github.com/users/turn/repos","events_url":"https://api.github.com/users/turn/events{/privacy}","received_events_url":"https://api.github.com/users/turn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/turn/Smart-Table","description":"Code source of Smart Table module: a table/grid for Angularjs","fork":true,"url":"https://api.github.com/repos/turn/Smart-Table","forks_url":"https://api.github.com/repos/turn/Smart-Table/forks","keys_url":"https://api.github.com/repos/turn/Smart-Table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turn/Smart-Table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turn/Smart-Table/teams","hooks_url":"https://api.github.com/repos/turn/Smart-Table/hooks","issue_events_url":"https://api.github.com/repos/turn/Smart-Table/issues/events{/number}","events_url":"https://api.github.com/repos/turn/Smart-Table/events","assignees_url":"https://api.github.com/repos/turn/Smart-Table/assignees{/user}","branches_url":"https://api.github.com/repos/turn/Smart-Table/branches{/branch}","tags_url":"https://api.github.com/repos/turn/Smart-Table/tags","blobs_url":"https://api.github.com/repos/turn/Smart-Table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turn/Smart-Table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turn/Smart-Table/git/refs{/sha}","trees_url":"https://api.github.com/repos/turn/Smart-Table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turn/Smart-Table/statuses/{sha}","languages_url":"https://api.github.com/repos/turn/Smart-Table/languages","stargazers_url":"https://api.github.com/repos/turn/Smart-Table/stargazers","contributors_url":"https://api.github.com/repos/turn/Smart-Table/contributors","subscribers_url":"https://api.github.com/repos/turn/Smart-Table/subscribers","subscription_url":"https://api.github.com/repos/turn/Smart-Table/subscription","commits_url":"https://api.github.com/repos/turn/Smart-Table/commits{/sha}","git_commits_url":"https://api.github.com/repos/turn/Smart-Table/git/commits{/sha}","comments_url":"https://api.github.com/repos/turn/Smart-Table/comments{/number}","issue_comment_url":"https://api.github.com/repos/turn/Smart-Table/issues/comments{/number}","contents_url":"https://api.github.com/repos/turn/Smart-Table/contents/{+path}","compare_url":"https://api.github.com/repos/turn/Smart-Table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turn/Smart-Table/merges","archive_url":"https://api.github.com/repos/turn/Smart-Table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turn/Smart-Table/downloads","issues_url":"https://api.github.com/repos/turn/Smart-Table/issues{/number}","pulls_url":"https://api.github.com/repos/turn/Smart-Table/pulls{/number}","milestones_url":"https://api.github.com/repos/turn/Smart-Table/milestones{/number}","notifications_url":"https://api.github.com/repos/turn/Smart-Table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turn/Smart-Table/labels{/name}","releases_url":"https://api.github.com/repos/turn/Smart-Table/releases{/id}","created_at":"2014-02-19T01:56:56Z","updated_at":"2015-02-12T23:12:48Z","pushed_at":"2015-02-13T18:17:59Z","git_url":"git://github.com/turn/Smart-Table.git","ssh_url":"git@github.com:turn/Smart-Table.git","clone_url":"https://github.com/turn/Smart-Table.git","svn_url":"https://github.com/turn/Smart-Table","homepage":"http://lorenzofox3.github.io/smart-table-website/","size":8798,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/25"},"html":{"href":"https://github.com/turn/Smart-Table/pull/25"},"issue":{"href":"https://api.github.com/repos/turn/Smart-Table/issues/25"},"comments":{"href":"https://api.github.com/repos/turn/Smart-Table/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/turn/Smart-Table/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/turn/Smart-Table/statuses/a7b0dac2f402b238b4cfbce777dc8297d06a28d5"}}}}