{"action":"created","issue":{"url":"https://api.github.com/repos/gamerson/blade.tools/issues/184","labels_url":"https://api.github.com/repos/gamerson/blade.tools/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/gamerson/blade.tools/issues/184/comments","events_url":"https://api.github.com/repos/gamerson/blade.tools/issues/184/events","html_url":"https://github.com/gamerson/blade.tools/pull/184","id":98871859,"number":184,"title":"[migrator] add AssertPreviewTags and fixes #25","user":{"login":"lovettli","id":10591143,"avatar_url":"https://avatars.githubusercontent.com/u/10591143?v=3","gravatar_id":"","url":"https://api.github.com/users/lovettli","html_url":"https://github.com/lovettli","followers_url":"https://api.github.com/users/lovettli/followers","following_url":"https://api.github.com/users/lovettli/following{/other_user}","gists_url":"https://api.github.com/users/lovettli/gists{/gist_id}","starred_url":"https://api.github.com/users/lovettli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovettli/subscriptions","organizations_url":"https://api.github.com/users/lovettli/orgs","repos_url":"https://api.github.com/users/lovettli/repos","events_url":"https://api.github.com/users/lovettli/events{/privacy}","received_events_url":"https://api.github.com/users/lovettli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-04T01:52:59Z","updated_at":"2015-08-04T02:18:47Z","closed_at":"2015-08-04T02:18:28Z","pull_request":{"url":"https://api.github.com/repos/gamerson/blade.tools/pulls/184","html_url":"https://github.com/gamerson/blade.tools/pull/184","diff_url":"https://github.com/gamerson/blade.tools/pull/184.diff","patch_url":"https://github.com/gamerson/blade.tools/pull/184.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gamerson/blade.tools/issues/comments/127456965","html_url":"https://github.com/gamerson/blade.tools/pull/184#issuecomment-127456965","issue_url":"https://api.github.com/repos/gamerson/blade.tools/issues/184","id":127456965,"user":{"login":"gamerson","id":595221,"avatar_url":"https://avatars.githubusercontent.com/u/595221?v=3","gravatar_id":"","url":"https://api.github.com/users/gamerson","html_url":"https://github.com/gamerson","followers_url":"https://api.github.com/users/gamerson/followers","following_url":"https://api.github.com/users/gamerson/following{/other_user}","gists_url":"https://api.github.com/users/gamerson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamerson/subscriptions","organizations_url":"https://api.github.com/users/gamerson/orgs","repos_url":"https://api.github.com/users/gamerson/repos","events_url":"https://api.github.com/users/gamerson/events{/privacy}","received_events_url":"https://api.github.com/users/gamerson/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T02:18:47Z","updated_at":"2015-08-04T02:18:47Z","body":"Hey Lovett,\n\nWhen I run this I see lots and lots of stacktraces here:\n\njava.lang.NullPointerException\nat\nblade.migrate.core.JSPFileChecker.createJSPTranslation(JSPFileChecker.java:43)\nat blade.migrate.core.JSPFileChecker.getTranslation(JSPFileChecker.java:127)\nat blade.migrate.core.JSPFileChecker.<init>(JSPFileChecker.java:31)\nat\nblade.migrate.core.JSPTagsFileMigrator.analyzeFile(JSPTagsFileMigrator.java:31)\nat\nblade.migrate.provider.ProjectMigrationService$1.visitFile(ProjectMigrationService.java:144)\nat\nblade.migrate.provider.ProjectMigrationService$1.visitFile(ProjectMigrationService.java:123)\nat java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:135)\nat java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:199)\nat java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:199)\n\n\nCan you check it on your side?\n\nOn Mon, Aug 3, 2015 at 8:52 PM, Lovett Li <notifications@github.com> wrote:\n\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/gamerson/blade.tools/pull/184\n> Commit Summary\n>\n>    - [migrator] add AssertPreviewTags and fixes #25\n>\n> File Changes\n>\n>    - *M*\n>    blade.migrate.liferay70/src/blade/migrate/core/JSPFileChecker.java\n>    <https://github.com/gamerson/blade.tools/pull/184/files#diff-0> (2)\n>    - *A*\n>    blade.migrate.liferay70/src/blade/migrate/liferay70/AssetPreviewTags.java\n>    <https://github.com/gamerson/blade.tools/pull/184/files#diff-1> (31)\n>    - *A* blade.migrate.test/jsptests/asset-preview/AssetPreviewTest.jsp\n>    <https://github.com/gamerson/blade.tools/pull/184/files#diff-2> (27)\n>    - *A*\n>    blade.migrate.test/src/blade/migrate/test/AssetPreviewTagsTest.java\n>    <https://github.com/gamerson/blade.tools/pull/184/files#diff-3> (50)\n>\n> Patch Links:\n>\n>    - https://github.com/gamerson/blade.tools/pull/184.patch\n>    - https://github.com/gamerson/blade.tools/pull/184.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/gamerson/blade.tools/pull/184>.\n>\n\n\n\n-- \nGreg Amerson\nLiferay Developer Tools\nLiferay, Inc. www.liferay.com\n"}}