{"action":"created","issue":{"url":"https://api.github.com/repos/aodn/netcdf_filters/issues/2","labels_url":"https://api.github.com/repos/aodn/netcdf_filters/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/aodn/netcdf_filters/issues/2/comments","events_url":"https://api.github.com/repos/aodn/netcdf_filters/issues/2/events","html_url":"https://github.com/aodn/netcdf_filters/pull/2","id":68527395,"number":2,"title":"Mybranch","user":{"login":"julian1","id":4312379,"avatar_url":"https://avatars.githubusercontent.com/u/4312379?v=3","gravatar_id":"","url":"https://api.github.com/users/julian1","html_url":"https://github.com/julian1","followers_url":"https://api.github.com/users/julian1/followers","following_url":"https://api.github.com/users/julian1/following{/other_user}","gists_url":"https://api.github.com/users/julian1/gists{/gist_id}","starred_url":"https://api.github.com/users/julian1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julian1/subscriptions","organizations_url":"https://api.github.com/users/julian1/orgs","repos_url":"https://api.github.com/users/julian1/repos","events_url":"https://api.github.com/users/julian1/events{/privacy}","received_events_url":"https://api.github.com/users/julian1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-14T23:36:24Z","updated_at":"2015-04-16T06:36:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aodn/netcdf_filters/pulls/2","html_url":"https://github.com/aodn/netcdf_filters/pull/2","diff_url":"https://github.com/aodn/netcdf_filters/pull/2.diff","patch_url":"https://github.com/aodn/netcdf_filters/pull/2.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/aodn/netcdf_filters/issues/comments/93656151","html_url":"https://github.com/aodn/netcdf_filters/pull/2#issuecomment-93656151","issue_url":"https://api.github.com/repos/aodn/netcdf_filters/issues/2","id":93656151,"user":{"login":"jonescc","id":1860215,"avatar_url":"https://avatars.githubusercontent.com/u/1860215?v=3","gravatar_id":"","url":"https://api.github.com/users/jonescc","html_url":"https://github.com/jonescc","followers_url":"https://api.github.com/users/jonescc/followers","following_url":"https://api.github.com/users/jonescc/following{/other_user}","gists_url":"https://api.github.com/users/jonescc/gists{/gist_id}","starred_url":"https://api.github.com/users/jonescc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonescc/subscriptions","organizations_url":"https://api.github.com/users/jonescc/orgs","repos_url":"https://api.github.com/users/jonescc/repos","events_url":"https://api.github.com/users/jonescc/events{/privacy}","received_events_url":"https://api.github.com/users/jonescc/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T06:36:15Z","updated_at":"2015-04-16T06:36:15Z","body":"@julian1 Looks good. Algorithm looks pretty sound.  Yes it is a prototype, so fair enough there are lots of 'tidy up' stuff which you can address as required/time permitting.  As per line comments, at some point (not for the prototype) I think we should look at using a library for parsing the xml netcdf definition, I think this will remove a lot of xml parsing code.  I think using the geotools cql parser has the potential to to do the same for code parsing the filter expression and generating the required sql where clause.\r\n\r\n"}}