{"action":"created","issue":{"url":"https://api.github.com/repos/rebar/rebar3/issues/680","labels_url":"https://api.github.com/repos/rebar/rebar3/issues/680/labels{/name}","comments_url":"https://api.github.com/repos/rebar/rebar3/issues/680/comments","events_url":"https://api.github.com/repos/rebar/rebar3/issues/680/events","html_url":"https://github.com/rebar/rebar3/pull/680","id":98563170,"number":680,"title":"[WIP] Carrying the changes to State through provider hooks","user":{"login":"Licenser","id":119093,"avatar_url":"https://avatars.githubusercontent.com/u/119093?v=3","gravatar_id":"","url":"https://api.github.com/users/Licenser","html_url":"https://github.com/Licenser","followers_url":"https://api.github.com/users/Licenser/followers","following_url":"https://api.github.com/users/Licenser/following{/other_user}","gists_url":"https://api.github.com/users/Licenser/gists{/gist_id}","starred_url":"https://api.github.com/users/Licenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Licenser/subscriptions","organizations_url":"https://api.github.com/users/Licenser/orgs","repos_url":"https://api.github.com/users/Licenser/repos","events_url":"https://api.github.com/users/Licenser/events{/privacy}","received_events_url":"https://api.github.com/users/Licenser/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-01T21:50:17Z","updated_at":"2015-09-07T13:33:17Z","closed_at":"2015-09-07T13:33:16Z","pull_request":{"url":"https://api.github.com/repos/rebar/rebar3/pulls/680","html_url":"https://github.com/rebar/rebar3/pull/680","diff_url":"https://github.com/rebar/rebar3/pull/680.diff","patch_url":"https://github.com/rebar/rebar3/pull/680.patch"},"body":"This is not fully working, please see the big comment in `rebar_prv_compiler.erl` line 102. I am not exactly sure of the logic behind the way the state is re-generated at that point. Simply swapping the line for\r\n\r\n```erlang\r\nS = State,\r\n```\r\n\r\ndoes work (for this) but will break other things. I just used this to prove locally that this is where things to back.\r\n\r\nbasically I think what this should look like is:\r\n\r\n```erlang\r\nS = case is_top_level_app(State, AppInfo) of\r\n      true -> State;\r\n      false -> rebar_app_info:state_or_new(State, AppInfo)\r\n    end\r\n```\r\n\r\nI am not sure how to is_top_level_app would be determining weather it's top level or not.\r\n"},"comment":{"url":"https://api.github.com/repos/rebar/rebar3/issues/comments/138300631","html_url":"https://github.com/rebar/rebar3/pull/680#issuecomment-138300631","issue_url":"https://api.github.com/repos/rebar/rebar3/issues/680","id":138300631,"user":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T13:33:16Z","updated_at":"2015-09-07T13:33:16Z","body":"Going to close this."}}