{"action":"closed","number":161,"pull_request":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161","id":37494326,"html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/161","diff_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/161.diff","patch_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/161.patch","issue_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/161","number":161,"state":"closed","locked":false,"title":"move </dom-module> to bottom of file","user":{"login":"yufengg","id":4944507,"avatar_url":"https://avatars.githubusercontent.com/u/4944507?v=3","gravatar_id":"","url":"https://api.github.com/users/yufengg","html_url":"https://github.com/yufengg","followers_url":"https://api.github.com/users/yufengg/followers","following_url":"https://api.github.com/users/yufengg/following{/other_user}","gists_url":"https://api.github.com/users/yufengg/gists{/gist_id}","starred_url":"https://api.github.com/users/yufengg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufengg/subscriptions","organizations_url":"https://api.github.com/users/yufengg/orgs","repos_url":"https://api.github.com/users/yufengg/repos","events_url":"https://api.github.com/users/yufengg/events{/privacy}","received_events_url":"https://api.github.com/users/yufengg/received_events","type":"User","site_admin":false},"body":"I moved the </dom-module> closing tag to the bottom, and adjusted indentation. Github's diff shows it as being crazy.\r\n\r\nPer the code samples in the docs (many examples, one such: https://www.polymer-project.org/1.0/docs/start/quick-tour.html), it seems like the style that is being encouraged is to have the dom-module wrap everything, including the <script> tag. If this is good, the my-greeting should also be updated similarly. It's worth noting that before the change to \"fix indentation\" on this file, all that needed to change was move the dom-module down, as the indentation was already set up for it to be at the bottom.","created_at":"2015-06-11T18:33:26Z","updated_at":"2015-06-12T18:01:41Z","closed_at":"2015-06-12T18:01:41Z","merged_at":null,"merge_commit_sha":"20f4480b124fe8aa05df285f077f6b38f19e1a62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/161/comments","statuses_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/5819c0e43abc94efa4d9f81826f28a10896fd0ed","head":{"label":"yufengg:patch-1","ref":"patch-1","sha":"5819c0e43abc94efa4d9f81826f28a10896fd0ed","user":{"login":"yufengg","id":4944507,"avatar_url":"https://avatars.githubusercontent.com/u/4944507?v=3","gravatar_id":"","url":"https://api.github.com/users/yufengg","html_url":"https://github.com/yufengg","followers_url":"https://api.github.com/users/yufengg/followers","following_url":"https://api.github.com/users/yufengg/following{/other_user}","gists_url":"https://api.github.com/users/yufengg/gists{/gist_id}","starred_url":"https://api.github.com/users/yufengg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufengg/subscriptions","organizations_url":"https://api.github.com/users/yufengg/orgs","repos_url":"https://api.github.com/users/yufengg/repos","events_url":"https://api.github.com/users/yufengg/events{/privacy}","received_events_url":"https://api.github.com/users/yufengg/received_events","type":"User","site_admin":false},"repo":{"id":37278551,"name":"polymer-starter-kit","full_name":"yufengg/polymer-starter-kit","owner":{"login":"yufengg","id":4944507,"avatar_url":"https://avatars.githubusercontent.com/u/4944507?v=3","gravatar_id":"","url":"https://api.github.com/users/yufengg","html_url":"https://github.com/yufengg","followers_url":"https://api.github.com/users/yufengg/followers","following_url":"https://api.github.com/users/yufengg/following{/other_user}","gists_url":"https://api.github.com/users/yufengg/gists{/gist_id}","starred_url":"https://api.github.com/users/yufengg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yufengg/subscriptions","organizations_url":"https://api.github.com/users/yufengg/orgs","repos_url":"https://api.github.com/users/yufengg/repos","events_url":"https://api.github.com/users/yufengg/events{/privacy}","received_events_url":"https://api.github.com/users/yufengg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yufengg/polymer-starter-kit","description":"A starting point for Polymer 1.0 apps","fork":true,"url":"https://api.github.com/repos/yufengg/polymer-starter-kit","forks_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/forks","keys_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/teams","hooks_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/events","assignees_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/tags","blobs_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/languages","stargazers_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/subscription","commits_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/merges","archive_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/downloads","issues_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/yufengg/polymer-starter-kit/releases{/id}","created_at":"2015-06-11T18:30:14Z","updated_at":"2015-06-11T18:30:14Z","pushed_at":"2015-06-11T19:27:27Z","git_url":"git://github.com/yufengg/polymer-starter-kit.git","ssh_url":"git@github.com:yufengg/polymer-starter-kit.git","clone_url":"https://github.com/yufengg/polymer-starter-kit.git","svn_url":"https://github.com/yufengg/polymer-starter-kit","homepage":"https://developers.google.com/web/tools/polymer-starter-kit/","size":5105,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"96c1748777cddcdae20bd1399e8f11b9798fb746","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34105868,"name":"polymer-starter-kit","full_name":"PolymerElements/polymer-starter-kit","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/polymer-starter-kit","description":"A starting point for Polymer 1.0 apps","fork":false,"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit","forks_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/forks","keys_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/teams","hooks_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/events","assignees_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/tags","blobs_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/subscription","commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/merges","archive_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/downloads","issues_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/releases{/id}","created_at":"2015-04-17T08:41:44Z","updated_at":"2015-06-12T17:54:58Z","pushed_at":"2015-06-12T17:59:38Z","git_url":"git://github.com/PolymerElements/polymer-starter-kit.git","ssh_url":"git@github.com:PolymerElements/polymer-starter-kit.git","clone_url":"https://github.com/PolymerElements/polymer-starter-kit.git","svn_url":"https://github.com/PolymerElements/polymer-starter-kit","homepage":"https://developers.google.com/web/tools/polymer-starter-kit/","size":5105,"stargazers_count":789,"watchers_count":789,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"open_issues_count":26,"forks":129,"open_issues":26,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161"},"html":{"href":"https://github.com/PolymerElements/polymer-starter-kit/pull/161"},"issue":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/161"},"comments":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/statuses/5819c0e43abc94efa4d9f81826f28a10896fd0ed"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":41,"deletions":37,"changed_files":2}}