{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/42262631","id":42262631,"diff_hunk":"@@ -0,0 +1,34 @@\n+import {verifyNoBrowserErrors} from 'angular2/src/testing/e2e_util';\n+\n+describe('hello world', function() {\n+\n+  afterEach(verifyNoBrowserErrors);\n+\n+  describe('upgrade app', function() {\n+    var URL = 'examples/src/upgrade/index.html';\n+\n+    it('should greet', function() {\n+      browser.get(URL);\n+\n+      expect(getComponentText('user', '.greeting')).toEqual('Greetings from World!');\n+    });\n+\n+    it('should reset', function() {\n+      browser.get(URL);\n+\n+      clickComponentButton('user', 'button');\n+      expect(getComponentText('hello-app', '.greeting')).toEqual('Greetings from !');\n+    });\n+  });\n+\n+});\n+\n+function getComponentText(selector, innerSelector) {\n+  return browser.executeScript('return document.querySelector(\"' + selector + '\").querySelector(\"' +\n+                               innerSelector + '\").textContent');","path":"modules/examples/e2e_test/upgrade/upgrade_spec.ts","position":28,"original_position":28,"commit_id":"1758191a4d0fa34ee8818f28e2c19c5d8505bcb2","original_commit_id":"1758191a4d0fa34ee8818f28e2c19c5d8505bcb2","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"Isn't this the same as `document.querySelector(selector + ' '  ± innerSelector)` ?\r\nWhy not use just one selector (to simplify things) ?","created_at":"2015-10-16T16:39:35Z","updated_at":"2015-10-16T16:39:35Z","html_url":"https://github.com/angular/angular/pull/4691#discussion_r42262631","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/4691","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/42262631"},"html":{"href":"https://github.com/angular/angular/pull/4691#discussion_r42262631"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/4691"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/4691","id":47490801,"html_url":"https://github.com/angular/angular/pull/4691","diff_url":"https://github.com/angular/angular/pull/4691.diff","patch_url":"https://github.com/angular/angular/pull/4691.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/4691","number":4691,"state":"open","locked":false,"title":"Upgrade example","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-13T04:48:54Z","updated_at":"2015-10-16T16:39:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bef76b54aeedb6f14696addc32838287cdb49f1","assignee":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/4691/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/4691/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/4691/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/1758191a4d0fa34ee8818f28e2c19c5d8505bcb2","head":{"label":"mhevery:upgrade-example","ref":"upgrade-example","sha":"1758191a4d0fa34ee8818f28e2c19c5d8505bcb2","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"repo":{"id":24658749,"name":"angular","full_name":"mhevery/angular","owner":{"login":"mhevery","id":111951,"avatar_url":"https://avatars.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhevery/angular","description":"","fork":true,"url":"https://api.github.com/repos/mhevery/angular","forks_url":"https://api.github.com/repos/mhevery/angular/forks","keys_url":"https://api.github.com/repos/mhevery/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhevery/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhevery/angular/teams","hooks_url":"https://api.github.com/repos/mhevery/angular/hooks","issue_events_url":"https://api.github.com/repos/mhevery/angular/issues/events{/number}","events_url":"https://api.github.com/repos/mhevery/angular/events","assignees_url":"https://api.github.com/repos/mhevery/angular/assignees{/user}","branches_url":"https://api.github.com/repos/mhevery/angular/branches{/branch}","tags_url":"https://api.github.com/repos/mhevery/angular/tags","blobs_url":"https://api.github.com/repos/mhevery/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhevery/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhevery/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhevery/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhevery/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/mhevery/angular/languages","stargazers_url":"https://api.github.com/repos/mhevery/angular/stargazers","contributors_url":"https://api.github.com/repos/mhevery/angular/contributors","subscribers_url":"https://api.github.com/repos/mhevery/angular/subscribers","subscription_url":"https://api.github.com/repos/mhevery/angular/subscription","commits_url":"https://api.github.com/repos/mhevery/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhevery/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhevery/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhevery/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhevery/angular/contents/{+path}","compare_url":"https://api.github.com/repos/mhevery/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhevery/angular/merges","archive_url":"https://api.github.com/repos/mhevery/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhevery/angular/downloads","issues_url":"https://api.github.com/repos/mhevery/angular/issues{/number}","pulls_url":"https://api.github.com/repos/mhevery/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/mhevery/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/mhevery/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhevery/angular/labels{/name}","releases_url":"https://api.github.com/repos/mhevery/angular/releases{/id}","created_at":"2014-09-30T22:59:23Z","updated_at":"2015-06-15T23:11:12Z","pushed_at":"2015-10-15T22:18:38Z","git_url":"git://github.com/mhevery/angular.git","ssh_url":"git@github.com:mhevery/angular.git","clone_url":"https://github.com/mhevery/angular.git","svn_url":"https://github.com/mhevery/angular","homepage":null,"size":17408,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"d896e4350a950c758dbb19cb71dd928835ec84c1","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-10-16T16:20:16Z","pushed_at":"2015-10-16T10:36:35Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":65013,"stargazers_count":5835,"watchers_count":5835,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1584,"mirror_url":null,"open_issues_count":562,"forks":1584,"open_issues":562,"watchers":5835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/4691"},"html":{"href":"https://github.com/angular/angular/pull/4691"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/4691"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/4691/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/4691/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/4691/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/1758191a4d0fa34ee8818f28e2c19c5d8505bcb2"}}}}