{"action":"created","issue":{"url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/71","labels_url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/71/comments","events_url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/71/events","html_url":"https://github.com/andrewferrier/email2pdf/pull/71","id":87290813,"number":71,"title":"Compensate for local url bug in wkhtmltopdf","user":{"login":"griff","id":4368,"avatar_url":"https://avatars.githubusercontent.com/u/4368?v=3","gravatar_id":"","url":"https://api.github.com/users/griff","html_url":"https://github.com/griff","followers_url":"https://api.github.com/users/griff/followers","following_url":"https://api.github.com/users/griff/following{/other_user}","gists_url":"https://api.github.com/users/griff/gists{/gist_id}","starred_url":"https://api.github.com/users/griff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griff/subscriptions","organizations_url":"https://api.github.com/users/griff/orgs","repos_url":"https://api.github.com/users/griff/repos","events_url":"https://api.github.com/users/griff/events{/privacy}","received_events_url":"https://api.github.com/users/griff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andrewferrier","id":107015,"avatar_url":"https://avatars.githubusercontent.com/u/107015?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewferrier","html_url":"https://github.com/andrewferrier","followers_url":"https://api.github.com/users/andrewferrier/followers","following_url":"https://api.github.com/users/andrewferrier/following{/other_user}","gists_url":"https://api.github.com/users/andrewferrier/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewferrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewferrier/subscriptions","organizations_url":"https://api.github.com/users/andrewferrier/orgs","repos_url":"https://api.github.com/users/andrewferrier/repos","events_url":"https://api.github.com/users/andrewferrier/events{/privacy}","received_events_url":"https://api.github.com/users/andrewferrier/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-06-11T10:10:27Z","updated_at":"2015-06-11T13:00:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/andrewferrier/email2pdf/pulls/71","html_url":"https://github.com/andrewferrier/email2pdf/pull/71","diff_url":"https://github.com/andrewferrier/email2pdf/pull/71.diff","patch_url":"https://github.com/andrewferrier/email2pdf/pull/71.patch"},"body":"Because of the bug wkhtmltopdf/wkhtmltopdf#2051 when the html contains\r\nrelative links with query parameters wkhtmltopdf will exit with an\r\nerror code but still generate the pdf correctly. This commit handles\r\nthat case and adds tests to illustrate the problem."},"comment":{"url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/comments/111124127","html_url":"https://github.com/andrewferrier/email2pdf/pull/71#issuecomment-111124127","issue_url":"https://api.github.com/repos/andrewferrier/email2pdf/issues/71","id":111124127,"user":{"login":"griff","id":4368,"avatar_url":"https://avatars.githubusercontent.com/u/4368?v=3","gravatar_id":"","url":"https://api.github.com/users/griff","html_url":"https://github.com/griff","followers_url":"https://api.github.com/users/griff/followers","following_url":"https://api.github.com/users/griff/following{/other_user}","gists_url":"https://api.github.com/users/griff/gists{/gist_id}","starred_url":"https://api.github.com/users/griff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griff/subscriptions","organizations_url":"https://api.github.com/users/griff/orgs","repos_url":"https://api.github.com/users/griff/repos","events_url":"https://api.github.com/users/griff/events{/privacy}","received_events_url":"https://api.github.com/users/griff/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T13:00:17Z","updated_at":"2015-06-11T13:00:17Z","body":"Well if you want it to fail on local links you might want to do something else than what I have done here. \r\n\r\nThis commit only compensates for the fact that wkhtmltopdf does two completely different things depending on whether the local URL has a query parameter or not. With the current options you are running wkhtmltopdf with it will silently ignore script urls like /test.js and email2pdf will succeed while wkhtmltopdf will fail and return an exit code of 1 when the url is /test.js?muh which is very inconsistent. \r\n\r\nMy change only makes the behavior of these two urls consistent by also silently ignoring urls with query parameters."}}