{"action":"created","issue":{"url":"https://api.github.com/repos/multani/sonata/issues/85","labels_url":"https://api.github.com/repos/multani/sonata/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/multani/sonata/issues/85/comments","events_url":"https://api.github.com/repos/multani/sonata/issues/85/events","html_url":"https://github.com/multani/sonata/pull/85","id":89542600,"number":85,"title":"Playlists","user":{"login":"rocus","id":3619404,"avatar_url":"https://avatars.githubusercontent.com/u/3619404?v=3","gravatar_id":"","url":"https://api.github.com/users/rocus","html_url":"https://github.com/rocus","followers_url":"https://api.github.com/users/rocus/followers","following_url":"https://api.github.com/users/rocus/following{/other_user}","gists_url":"https://api.github.com/users/rocus/gists{/gist_id}","starred_url":"https://api.github.com/users/rocus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocus/subscriptions","organizations_url":"https://api.github.com/users/rocus/orgs","repos_url":"https://api.github.com/users/rocus/repos","events_url":"https://api.github.com/users/rocus/events{/privacy}","received_events_url":"https://api.github.com/users/rocus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-19T11:36:05Z","updated_at":"2015-06-21T18:39:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/multani/sonata/pulls/85","html_url":"https://github.com/multani/sonata/pull/85","diff_url":"https://github.com/multani/sonata/pull/85.diff","patch_url":"https://github.com/multani/sonata/pull/85.patch"},"body":"MPD can load playlists (located on the MPD server). Sonata ignores those playlists. This modification shows playlists in the library view. You can add them to the current queue. If the playlist contains mp3's you can find these mp3's in your current queue: they will be played in due time. If the playlist contains one or more URL's (of radio streams), they will also be added to the current queue (and played later). \r\n\r\nMost MPD clients ignore playlists, gmpc does not. Sonata changed by the suggested modifications in library.py and main.py will work as gmpc as far as playlists are concerned.\r\n\r\nThe playlist as implemented sofar in sonata (see playlist tab) are stored in the client (whithout directory structure).  This modification stores them at the MPD server and they can be structured in directories.\r\n\r\n![screenshot from 2015-06-19 13 35 06](https://cloud.githubusercontent.com/assets/3619404/8252654/124eb3ac-1688-11e5-8077-fb975ad4504b.png)\r\n\r\n![screenshot from 2015-06-19 13 32 23](https://cloud.githubusercontent.com/assets/3619404/8252626/d0a1c0e8-1687-11e5-90d5-13a328eee4f5.png)\r\n"},"comment":{"url":"https://api.github.com/repos/multani/sonata/issues/comments/113939009","html_url":"https://github.com/multani/sonata/pull/85#issuecomment-113939009","issue_url":"https://api.github.com/repos/multani/sonata/issues/85","id":113939009,"user":{"login":"multani","id":65311,"avatar_url":"https://avatars.githubusercontent.com/u/65311?v=3","gravatar_id":"","url":"https://api.github.com/users/multani","html_url":"https://github.com/multani","followers_url":"https://api.github.com/users/multani/followers","following_url":"https://api.github.com/users/multani/following{/other_user}","gists_url":"https://api.github.com/users/multani/gists{/gist_id}","starred_url":"https://api.github.com/users/multani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/multani/subscriptions","organizations_url":"https://api.github.com/users/multani/orgs","repos_url":"https://api.github.com/users/multani/repos","events_url":"https://api.github.com/users/multani/events{/privacy}","received_events_url":"https://api.github.com/users/multani/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T18:39:46Z","updated_at":"2015-06-21T18:39:46Z","body":"OK, I think I finally understand what you want.\r\n\r\nBasically, you want the playlist files to appear in the Filesystem view of the library, right? It's probably a bit redundant with the Playlist tab, and the justification gmpc does it and Sonata doesn't isn't really one. But why not, I'm not against it.\r\n\r\nI had a look at your code - can you at least squash your 2 commits into one and remove the comments you put? (we don't need ``####``)\r\n\r\nI'm not a huge fan of duplicating all the playlist detection code: MPD already tells us which items are playlists and which are files, but we need to make additional comparisons against the icon (really?) and then again with the end of the string (really?). That's a lot of duplicated effort, not really understandable code (why comparing pixbuf to add or not an item?) and fragile code (what if one day we need to support other playlists than ``.pls`` and ``.m3u``)\r\n\r\nI'm going to make some comments on the code, please have look.\r\n\r\nAlso, could you provide a better icon for the playlist items in the Library view? Something which looks like more a playlist than something which looks like \"song currently played\"."}}