{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/270","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/270/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/270/events","html_url":"https://github.com/dotnet/coreclr/issues/270","id":57685043,"number":270,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-14T07:30:55Z","updated_at":"2015-02-14T07:47:33Z","closed_at":null,"body":"I would like to point out that identifiers like \"[```__CAPARSER_H__```](https://github.com/dotnet/coreclr/blob/ef1e2ab328087c61a6878c1e84f4fc5d710aebce/src/inc/caparser.h#L15)\" and \"[```__GC_H```](https://github.com/dotnet/coreclr/blob/ef1e2ab328087c61a6878c1e84f4fc5d710aebce/src/gc/gc.h#L15)\" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not use identifiers that are reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/74365955","html_url":"https://github.com/dotnet/coreclr/issues/270#issuecomment-74365955","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/270","id":74365955,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2015-02-14T07:47:33Z","updated_at":"2015-02-14T07:47:33Z","body":"Majority of the CoreCLR code is compiled against PAL headers that isolate from system C++ headers, and so the identifiers cannot collide by design.\r\n\r\nIt would nice to clean this up for parts of the tree that are likely to evolve into reusable components - GC is one that we know about so far.\r\n\r\n@elfring  We will be happy to accept PR that cleans up the header guards in files under src\\gc. Thanks!"}}