{"action":"closed","number":1470,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470","id":39878193,"html_url":"https://github.com/ethereum/go-ethereum/pull/1470","diff_url":"https://github.com/ethereum/go-ethereum/pull/1470.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/1470.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1470","number":1470,"state":"closed","locked":false,"title":"p2p: validate recovered ephemeral pubkey","user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"body":"Validate recovered ephemeral pubkey against checksum in decodeAuthMsg\r\n\r\nInitiator sends an `authMsg` containing a signature produced by the ephemeral private key, and a sha3 checksum of the ephemeral public key. However the receiver was not validating the recovered pubkey against the checksum.\r\n\r\nThe other change is to check the validity of a remote peer right away, so we don't first waste entropy/time on a nonce and private key. \r\n","created_at":"2015-07-14T03:12:42Z","updated_at":"2015-08-13T09:59:27Z","closed_at":"2015-08-13T09:59:27Z","merged_at":"2015-08-13T09:59:27Z","merge_commit_sha":"c24c72e44435cac13ca4ae765bc36ab12b191197","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1470/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/37efd08b42f595eac8146b6b81f3f36e2e6f340d","head":{"label":"ebuchman:encHandshake","ref":"encHandshake","sha":"37efd08b42f595eac8146b6b81f3f36e2e6f340d","user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"repo":{"id":27009361,"name":"go-ethereum","full_name":"ebuchman/go-ethereum","owner":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebuchman/go-ethereum","description":"Ethereum Go - Mist (Ether Browser)","fork":true,"url":"https://api.github.com/repos/ebuchman/go-ethereum","forks_url":"https://api.github.com/repos/ebuchman/go-ethereum/forks","keys_url":"https://api.github.com/repos/ebuchman/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebuchman/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebuchman/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ebuchman/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ebuchman/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ebuchman/go-ethereum/events","assignees_url":"https://api.github.com/repos/ebuchman/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ebuchman/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ebuchman/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ebuchman/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebuchman/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebuchman/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebuchman/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebuchman/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ebuchman/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ebuchman/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ebuchman/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ebuchman/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ebuchman/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ebuchman/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebuchman/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebuchman/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebuchman/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebuchman/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ebuchman/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebuchman/go-ethereum/merges","archive_url":"https://api.github.com/repos/ebuchman/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebuchman/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ebuchman/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ebuchman/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ebuchman/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ebuchman/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebuchman/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ebuchman/go-ethereum/releases{/id}","created_at":"2014-11-22T19:11:51Z","updated_at":"2015-01-26T19:49:58Z","pushed_at":"2015-08-08T22:55:21Z","git_url":"git://github.com/ebuchman/go-ethereum.git","ssh_url":"git@github.com:ebuchman/go-ethereum.git","clone_url":"https://github.com/ebuchman/go-ethereum.git","svn_url":"https://github.com/ebuchman/go-ethereum","homepage":"","size":47282,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"796c18db93add1d145db99d6088e445a56851e8b","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Jeffrey Wilcke's Go implementation of the Ethereum y/w paper","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","created_at":"2013-12-26T13:05:46Z","updated_at":"2015-08-13T02:29:28Z","pushed_at":"2015-08-13T09:59:27Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"","size":74527,"stargazers_count":582,"watchers_count":582,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":150,"forks":187,"open_issues":150,"watchers":582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/1470"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/1470"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/37efd08b42f595eac8146b6b81f3f36e2e6f340d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":12,"deletions":4,"changed_files":1}}