{"action":"created","comment":{"url":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments/40005672","id":40005672,"diff_hunk":"@@ -66,38 +66,38 @@ def self.included(klass)\n             before_save :maintain_sessions, :if => :update_sessions?\n           end\n         end\n-        \n+\n         # Save the record and skip session maintenance all together.\n-        def save_without_session_maintenance(*args)\n+        def save_without_session_maintenance(validate=true)","path":"lib/authlogic/acts_as_authentic/session_maintenance.rb","position":44,"original_position":44,"commit_id":"58c0bead597db81dfbeabf4e017a1b396baf3e80","original_commit_id":"58c0bead597db81dfbeabf4e017a1b396baf3e80","user":{"login":"tiegz","id":5054,"avatar_url":"https://avatars.githubusercontent.com/u/5054?v=3","gravatar_id":"","url":"https://api.github.com/users/tiegz","html_url":"https://github.com/tiegz","followers_url":"https://api.github.com/users/tiegz/followers","following_url":"https://api.github.com/users/tiegz/following{/other_user}","gists_url":"https://api.github.com/users/tiegz/gists{/gist_id}","starred_url":"https://api.github.com/users/tiegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiegz/subscriptions","organizations_url":"https://api.github.com/users/tiegz/orgs","repos_url":"https://api.github.com/users/tiegz/repos","events_url":"https://api.github.com/users/tiegz/events{/privacy}","received_events_url":"https://api.github.com/users/tiegz/received_events","type":"User","site_admin":false},"body":"@SamuelMartini I think `*args` is actually a good option here since it's more-or-less a mixin method. I think the idea is that this method should act like `save`, and `*args` is a good conventional way to do that (ie you could replace `save(*args)` with `super` for the same result). \r\n\r\nIs this method being called directly from your app, and passing in `false` instead of an options hash?","created_at":"2015-09-21T18:17:48Z","updated_at":"2015-09-21T18:17:48Z","html_url":"https://github.com/binarylogic/authlogic/pull/478#discussion_r40005672","pull_request_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments/40005672"},"html":{"href":"https://github.com/binarylogic/authlogic/pull/478#discussion_r40005672"},"pull_request":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/binarylogic/authlogic/pulls/478","id":44798069,"html_url":"https://github.com/binarylogic/authlogic/pull/478","diff_url":"https://github.com/binarylogic/authlogic/pull/478.diff","patch_url":"https://github.com/binarylogic/authlogic/pull/478.patch","issue_url":"https://api.github.com/repos/binarylogic/authlogic/issues/478","number":478,"state":"open","locked":false,"title":"Avoid save(false) deprecation warning","user":{"login":"SamuelMartini","id":8694436,"avatar_url":"https://avatars.githubusercontent.com/u/8694436?v=3","gravatar_id":"","url":"https://api.github.com/users/SamuelMartini","html_url":"https://github.com/SamuelMartini","followers_url":"https://api.github.com/users/SamuelMartini/followers","following_url":"https://api.github.com/users/SamuelMartini/following{/other_user}","gists_url":"https://api.github.com/users/SamuelMartini/gists{/gist_id}","starred_url":"https://api.github.com/users/SamuelMartini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamuelMartini/subscriptions","organizations_url":"https://api.github.com/users/SamuelMartini/orgs","repos_url":"https://api.github.com/users/SamuelMartini/repos","events_url":"https://api.github.com/users/SamuelMartini/events{/privacy}","received_events_url":"https://api.github.com/users/SamuelMartini/received_events","type":"User","site_admin":false},"body":"Avoid deprecation warning:\r\nDEPRECATION WARNING: save(false) is deprecated, please give save(:validate => false) instead. (called from save_without_session_maintenance at /Library/Ruby/Gems/2.0.0/gems/authlogic-2.1.6/lib/authlogic/acts_as_authentic/session_maintenance.rb:73)","created_at":"2015-09-11T15:49:00Z","updated_at":"2015-09-21T18:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7634665773b6f87981621ebb3b6cb2971afe8f35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/478/commits","review_comments_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/478/comments","review_comment_url":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binarylogic/authlogic/issues/478/comments","statuses_url":"https://api.github.com/repos/binarylogic/authlogic/statuses/58c0bead597db81dfbeabf4e017a1b396baf3e80","head":{"label":"SamuelMartini:deprecation","ref":"deprecation","sha":"58c0bead597db81dfbeabf4e017a1b396baf3e80","user":{"login":"SamuelMartini","id":8694436,"avatar_url":"https://avatars.githubusercontent.com/u/8694436?v=3","gravatar_id":"","url":"https://api.github.com/users/SamuelMartini","html_url":"https://github.com/SamuelMartini","followers_url":"https://api.github.com/users/SamuelMartini/followers","following_url":"https://api.github.com/users/SamuelMartini/following{/other_user}","gists_url":"https://api.github.com/users/SamuelMartini/gists{/gist_id}","starred_url":"https://api.github.com/users/SamuelMartini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamuelMartini/subscriptions","organizations_url":"https://api.github.com/users/SamuelMartini/orgs","repos_url":"https://api.github.com/users/SamuelMartini/repos","events_url":"https://api.github.com/users/SamuelMartini/events{/privacy}","received_events_url":"https://api.github.com/users/SamuelMartini/received_events","type":"User","site_admin":false},"repo":{"id":42303035,"name":"authlogic","full_name":"SamuelMartini/authlogic","owner":{"login":"SamuelMartini","id":8694436,"avatar_url":"https://avatars.githubusercontent.com/u/8694436?v=3","gravatar_id":"","url":"https://api.github.com/users/SamuelMartini","html_url":"https://github.com/SamuelMartini","followers_url":"https://api.github.com/users/SamuelMartini/followers","following_url":"https://api.github.com/users/SamuelMartini/following{/other_user}","gists_url":"https://api.github.com/users/SamuelMartini/gists{/gist_id}","starred_url":"https://api.github.com/users/SamuelMartini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamuelMartini/subscriptions","organizations_url":"https://api.github.com/users/SamuelMartini/orgs","repos_url":"https://api.github.com/users/SamuelMartini/repos","events_url":"https://api.github.com/users/SamuelMartini/events{/privacy}","received_events_url":"https://api.github.com/users/SamuelMartini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamuelMartini/authlogic","description":"A simple ruby authentication solution.","fork":true,"url":"https://api.github.com/repos/SamuelMartini/authlogic","forks_url":"https://api.github.com/repos/SamuelMartini/authlogic/forks","keys_url":"https://api.github.com/repos/SamuelMartini/authlogic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamuelMartini/authlogic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamuelMartini/authlogic/teams","hooks_url":"https://api.github.com/repos/SamuelMartini/authlogic/hooks","issue_events_url":"https://api.github.com/repos/SamuelMartini/authlogic/issues/events{/number}","events_url":"https://api.github.com/repos/SamuelMartini/authlogic/events","assignees_url":"https://api.github.com/repos/SamuelMartini/authlogic/assignees{/user}","branches_url":"https://api.github.com/repos/SamuelMartini/authlogic/branches{/branch}","tags_url":"https://api.github.com/repos/SamuelMartini/authlogic/tags","blobs_url":"https://api.github.com/repos/SamuelMartini/authlogic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamuelMartini/authlogic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamuelMartini/authlogic/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamuelMartini/authlogic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamuelMartini/authlogic/statuses/{sha}","languages_url":"https://api.github.com/repos/SamuelMartini/authlogic/languages","stargazers_url":"https://api.github.com/repos/SamuelMartini/authlogic/stargazers","contributors_url":"https://api.github.com/repos/SamuelMartini/authlogic/contributors","subscribers_url":"https://api.github.com/repos/SamuelMartini/authlogic/subscribers","subscription_url":"https://api.github.com/repos/SamuelMartini/authlogic/subscription","commits_url":"https://api.github.com/repos/SamuelMartini/authlogic/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamuelMartini/authlogic/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamuelMartini/authlogic/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamuelMartini/authlogic/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamuelMartini/authlogic/contents/{+path}","compare_url":"https://api.github.com/repos/SamuelMartini/authlogic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamuelMartini/authlogic/merges","archive_url":"https://api.github.com/repos/SamuelMartini/authlogic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamuelMartini/authlogic/downloads","issues_url":"https://api.github.com/repos/SamuelMartini/authlogic/issues{/number}","pulls_url":"https://api.github.com/repos/SamuelMartini/authlogic/pulls{/number}","milestones_url":"https://api.github.com/repos/SamuelMartini/authlogic/milestones{/number}","notifications_url":"https://api.github.com/repos/SamuelMartini/authlogic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamuelMartini/authlogic/labels{/name}","releases_url":"https://api.github.com/repos/SamuelMartini/authlogic/releases{/id}","created_at":"2015-09-11T10:44:34Z","updated_at":"2015-09-11T10:44:34Z","pushed_at":"2015-09-11T15:47:00Z","git_url":"git://github.com/SamuelMartini/authlogic.git","ssh_url":"git@github.com:SamuelMartini/authlogic.git","clone_url":"https://github.com/SamuelMartini/authlogic.git","svn_url":"https://github.com/SamuelMartini/authlogic","homepage":"http://rdoc.info/projects/binarylogic/authlogic","size":2077,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binarylogic:master","ref":"master","sha":"11368f7793052f27c8d5a852e398ea31137d03ce","user":{"login":"binarylogic","id":1663286,"avatar_url":"https://avatars.githubusercontent.com/u/1663286?v=3","gravatar_id":"","url":"https://api.github.com/users/binarylogic","html_url":"https://github.com/binarylogic","followers_url":"https://api.github.com/users/binarylogic/followers","following_url":"https://api.github.com/users/binarylogic/following{/other_user}","gists_url":"https://api.github.com/users/binarylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/binarylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarylogic/subscriptions","organizations_url":"https://api.github.com/users/binarylogic/orgs","repos_url":"https://api.github.com/users/binarylogic/repos","events_url":"https://api.github.com/users/binarylogic/events{/privacy}","received_events_url":"https://api.github.com/users/binarylogic/received_events","type":"User","site_admin":false},"repo":{"id":67451,"name":"authlogic","full_name":"binarylogic/authlogic","owner":{"login":"binarylogic","id":1663286,"avatar_url":"https://avatars.githubusercontent.com/u/1663286?v=3","gravatar_id":"","url":"https://api.github.com/users/binarylogic","html_url":"https://github.com/binarylogic","followers_url":"https://api.github.com/users/binarylogic/followers","following_url":"https://api.github.com/users/binarylogic/following{/other_user}","gists_url":"https://api.github.com/users/binarylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/binarylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarylogic/subscriptions","organizations_url":"https://api.github.com/users/binarylogic/orgs","repos_url":"https://api.github.com/users/binarylogic/repos","events_url":"https://api.github.com/users/binarylogic/events{/privacy}","received_events_url":"https://api.github.com/users/binarylogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binarylogic/authlogic","description":"A simple ruby authentication solution.","fork":false,"url":"https://api.github.com/repos/binarylogic/authlogic","forks_url":"https://api.github.com/repos/binarylogic/authlogic/forks","keys_url":"https://api.github.com/repos/binarylogic/authlogic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarylogic/authlogic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarylogic/authlogic/teams","hooks_url":"https://api.github.com/repos/binarylogic/authlogic/hooks","issue_events_url":"https://api.github.com/repos/binarylogic/authlogic/issues/events{/number}","events_url":"https://api.github.com/repos/binarylogic/authlogic/events","assignees_url":"https://api.github.com/repos/binarylogic/authlogic/assignees{/user}","branches_url":"https://api.github.com/repos/binarylogic/authlogic/branches{/branch}","tags_url":"https://api.github.com/repos/binarylogic/authlogic/tags","blobs_url":"https://api.github.com/repos/binarylogic/authlogic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarylogic/authlogic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarylogic/authlogic/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarylogic/authlogic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarylogic/authlogic/statuses/{sha}","languages_url":"https://api.github.com/repos/binarylogic/authlogic/languages","stargazers_url":"https://api.github.com/repos/binarylogic/authlogic/stargazers","contributors_url":"https://api.github.com/repos/binarylogic/authlogic/contributors","subscribers_url":"https://api.github.com/repos/binarylogic/authlogic/subscribers","subscription_url":"https://api.github.com/repos/binarylogic/authlogic/subscription","commits_url":"https://api.github.com/repos/binarylogic/authlogic/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarylogic/authlogic/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarylogic/authlogic/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarylogic/authlogic/issues/comments{/number}","contents_url":"https://api.github.com/repos/binarylogic/authlogic/contents/{+path}","compare_url":"https://api.github.com/repos/binarylogic/authlogic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarylogic/authlogic/merges","archive_url":"https://api.github.com/repos/binarylogic/authlogic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarylogic/authlogic/downloads","issues_url":"https://api.github.com/repos/binarylogic/authlogic/issues{/number}","pulls_url":"https://api.github.com/repos/binarylogic/authlogic/pulls{/number}","milestones_url":"https://api.github.com/repos/binarylogic/authlogic/milestones{/number}","notifications_url":"https://api.github.com/repos/binarylogic/authlogic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarylogic/authlogic/labels{/name}","releases_url":"https://api.github.com/repos/binarylogic/authlogic/releases{/id}","created_at":"2008-10-24T21:13:34Z","updated_at":"2015-09-21T16:24:42Z","pushed_at":"2015-09-11T15:49:01Z","git_url":"git://github.com/binarylogic/authlogic.git","ssh_url":"git@github.com:binarylogic/authlogic.git","clone_url":"https://github.com/binarylogic/authlogic.git","svn_url":"https://github.com/binarylogic/authlogic","homepage":"http://rdoc.info/projects/binarylogic/authlogic","size":3471,"stargazers_count":3769,"watchers_count":3769,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":172,"forks":538,"open_issues":172,"watchers":3769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/478"},"html":{"href":"https://github.com/binarylogic/authlogic/pull/478"},"issue":{"href":"https://api.github.com/repos/binarylogic/authlogic/issues/478"},"comments":{"href":"https://api.github.com/repos/binarylogic/authlogic/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binarylogic/authlogic/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/binarylogic/authlogic/statuses/58c0bead597db81dfbeabf4e017a1b396baf3e80"}}}}