{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1","id":33993276,"html_url":"https://github.com/mhamrah/ansible-zookeeper/pull/1","diff_url":"https://github.com/mhamrah/ansible-zookeeper/pull/1.diff","patch_url":"https://github.com/mhamrah/ansible-zookeeper/pull/1.patch","issue_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/1","number":1,"state":"open","locked":false,"title":"Prefer the `hostvars[server].hostname` attribute in zoo.cfg, and default to just `server` if `.hostname` is not available.","user":{"login":"jaytaylor","id":435652,"avatar_url":"https://avatars.githubusercontent.com/u/435652?v=3","gravatar_id":"","url":"https://api.github.com/users/jaytaylor","html_url":"https://github.com/jaytaylor","followers_url":"https://api.github.com/users/jaytaylor/followers","following_url":"https://api.github.com/users/jaytaylor/following{/other_user}","gists_url":"https://api.github.com/users/jaytaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/jaytaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaytaylor/subscriptions","organizations_url":"https://api.github.com/users/jaytaylor/orgs","repos_url":"https://api.github.com/users/jaytaylor/repos","events_url":"https://api.github.com/users/jaytaylor/events{/privacy}","received_events_url":"https://api.github.com/users/jaytaylor/received_events","type":"User","site_admin":false},"body":"This PR allows a `hostname` to be specified in the ansible hosts file, and then this value will be used in zookeeper's `zoo.cfg`.  This is a backwards-compatible change, meaning that if no hostname is specified, it will use the default `{{server}}` value just like before.\r\n\r\nexample hosts file:\r\n\r\n```ini\r\n[tag_Name_mesos_primary1a:vars]\r\nzoo_id=1\r\nhostname=mesos-primary1a\r\n\r\n[tag_Name_mesos_primary2a:vars]\r\nzoo_id=2\r\nhostname=mesos-primary2a\r\n\r\n[tag_Name_mesos_primary3a:vars]\r\nzoo_id=3\r\nhostname=mesos-primary3a\r\n```","created_at":"2015-04-23T20:28:21Z","updated_at":"2015-04-23T20:28:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/1/comments","statuses_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/statuses/22b042532a6f0ed6a34f43ba0d63deb424c8474f","head":{"label":"jaytaylor:master","ref":"master","sha":"22b042532a6f0ed6a34f43ba0d63deb424c8474f","user":{"login":"jaytaylor","id":435652,"avatar_url":"https://avatars.githubusercontent.com/u/435652?v=3","gravatar_id":"","url":"https://api.github.com/users/jaytaylor","html_url":"https://github.com/jaytaylor","followers_url":"https://api.github.com/users/jaytaylor/followers","following_url":"https://api.github.com/users/jaytaylor/following{/other_user}","gists_url":"https://api.github.com/users/jaytaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/jaytaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaytaylor/subscriptions","organizations_url":"https://api.github.com/users/jaytaylor/orgs","repos_url":"https://api.github.com/users/jaytaylor/repos","events_url":"https://api.github.com/users/jaytaylor/events{/privacy}","received_events_url":"https://api.github.com/users/jaytaylor/received_events","type":"User","site_admin":false},"repo":{"id":34477809,"name":"ansible-zookeeper","full_name":"jaytaylor/ansible-zookeeper","owner":{"login":"jaytaylor","id":435652,"avatar_url":"https://avatars.githubusercontent.com/u/435652?v=3","gravatar_id":"","url":"https://api.github.com/users/jaytaylor","html_url":"https://github.com/jaytaylor","followers_url":"https://api.github.com/users/jaytaylor/followers","following_url":"https://api.github.com/users/jaytaylor/following{/other_user}","gists_url":"https://api.github.com/users/jaytaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/jaytaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaytaylor/subscriptions","organizations_url":"https://api.github.com/users/jaytaylor/orgs","repos_url":"https://api.github.com/users/jaytaylor/repos","events_url":"https://api.github.com/users/jaytaylor/events{/privacy}","received_events_url":"https://api.github.com/users/jaytaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaytaylor/ansible-zookeeper","description":"Ansible playbook for ZooKeeper","fork":true,"url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper","forks_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/forks","keys_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/teams","hooks_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/events","assignees_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/tags","blobs_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/languages","stargazers_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/subscription","commits_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/merges","archive_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/downloads","issues_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/jaytaylor/ansible-zookeeper/releases{/id}","created_at":"2015-04-23T19:46:03Z","updated_at":"2015-02-17T15:44:39Z","pushed_at":"2015-04-23T19:52:48Z","git_url":"git://github.com/jaytaylor/ansible-zookeeper.git","ssh_url":"git@github.com:jaytaylor/ansible-zookeeper.git","clone_url":"https://github.com/jaytaylor/ansible-zookeeper.git","svn_url":"https://github.com/jaytaylor/ansible-zookeeper","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mhamrah:master","ref":"master","sha":"ba4340361486b58f13d7581e9a0ba87c11ec4b49","user":{"login":"mhamrah","id":91162,"avatar_url":"https://avatars.githubusercontent.com/u/91162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhamrah","html_url":"https://github.com/mhamrah","followers_url":"https://api.github.com/users/mhamrah/followers","following_url":"https://api.github.com/users/mhamrah/following{/other_user}","gists_url":"https://api.github.com/users/mhamrah/gists{/gist_id}","starred_url":"https://api.github.com/users/mhamrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhamrah/subscriptions","organizations_url":"https://api.github.com/users/mhamrah/orgs","repos_url":"https://api.github.com/users/mhamrah/repos","events_url":"https://api.github.com/users/mhamrah/events{/privacy}","received_events_url":"https://api.github.com/users/mhamrah/received_events","type":"User","site_admin":false},"repo":{"id":25713278,"name":"ansible-zookeeper","full_name":"mhamrah/ansible-zookeeper","owner":{"login":"mhamrah","id":91162,"avatar_url":"https://avatars.githubusercontent.com/u/91162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhamrah","html_url":"https://github.com/mhamrah","followers_url":"https://api.github.com/users/mhamrah/followers","following_url":"https://api.github.com/users/mhamrah/following{/other_user}","gists_url":"https://api.github.com/users/mhamrah/gists{/gist_id}","starred_url":"https://api.github.com/users/mhamrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhamrah/subscriptions","organizations_url":"https://api.github.com/users/mhamrah/orgs","repos_url":"https://api.github.com/users/mhamrah/repos","events_url":"https://api.github.com/users/mhamrah/events{/privacy}","received_events_url":"https://api.github.com/users/mhamrah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhamrah/ansible-zookeeper","description":"Ansible playbook for ZooKeeper","fork":true,"url":"https://api.github.com/repos/mhamrah/ansible-zookeeper","forks_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/forks","keys_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/teams","hooks_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/events","assignees_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/tags","blobs_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/languages","stargazers_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/subscription","commits_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/merges","archive_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/downloads","issues_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/mhamrah/ansible-zookeeper/releases{/id}","created_at":"2014-10-24T23:44:25Z","updated_at":"2015-02-17T15:44:39Z","pushed_at":"2015-04-23T20:28:21Z","git_url":"git://github.com/mhamrah/ansible-zookeeper.git","ssh_url":"git@github.com:mhamrah/ansible-zookeeper.git","clone_url":"https://github.com/mhamrah/ansible-zookeeper.git","svn_url":"https://github.com/mhamrah/ansible-zookeeper","homepage":null,"size":139,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1"},"html":{"href":"https://github.com/mhamrah/ansible-zookeeper/pull/1"},"issue":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/1"},"comments":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mhamrah/ansible-zookeeper/statuses/22b042532a6f0ed6a34f43ba0d63deb424c8474f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}