{"action":"created","issue":{"url":"https://api.github.com/repos/skidding/react-component-playground/issues/15","labels_url":"https://api.github.com/repos/skidding/react-component-playground/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/skidding/react-component-playground/issues/15/comments","events_url":"https://api.github.com/repos/skidding/react-component-playground/issues/15/events","html_url":"https://github.com/skidding/react-component-playground/pull/15","id":83474852,"number":15,"title":"Better support for unserializable props in fixture","user":{"login":"skidding","id":250750,"avatar_url":"https://avatars.githubusercontent.com/u/250750?v=3","gravatar_id":"","url":"https://api.github.com/users/skidding","html_url":"https://github.com/skidding","followers_url":"https://api.github.com/users/skidding/followers","following_url":"https://api.github.com/users/skidding/following{/other_user}","gists_url":"https://api.github.com/users/skidding/gists{/gist_id}","starred_url":"https://api.github.com/users/skidding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidding/subscriptions","organizations_url":"https://api.github.com/users/skidding/orgs","repos_url":"https://api.github.com/users/skidding/repos","events_url":"https://api.github.com/users/skidding/events{/privacy}","received_events_url":"https://api.github.com/users/skidding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-01T12:46:19Z","updated_at":"2015-06-01T19:08:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/skidding/react-component-playground/pulls/15","html_url":"https://github.com/skidding/react-component-playground/pull/15","diff_url":"https://github.com/skidding/react-component-playground/pull/15.diff","patch_url":"https://github.com/skidding/react-component-playground/pull/15.patch"},"body":"- [x] `state.fixtureUnserializableProps`\r\n  - [x] compute on `statics.getFixtureState`, faster than on every editor change (`onFixtureState`)\r\n  - [x] ~~`deepEqual(prop, parse(stringify(prop))` to determine unserializable props~~ Custom `isSerializable` helper\r\n- [x] new state tests\r\n  - [x] create test with .children inspired from https://github.com/skidding/cosmos/issues/130"},"comment":{"url":"https://api.github.com/repos/skidding/react-component-playground/issues/comments/107673779","html_url":"https://github.com/skidding/react-component-playground/pull/15#issuecomment-107673779","issue_url":"https://api.github.com/repos/skidding/react-component-playground/issues/15","id":107673779,"user":{"login":"skidding","id":250750,"avatar_url":"https://avatars.githubusercontent.com/u/250750?v=3","gravatar_id":"","url":"https://api.github.com/users/skidding","html_url":"https://github.com/skidding","followers_url":"https://api.github.com/users/skidding/followers","following_url":"https://api.github.com/users/skidding/following{/other_user}","gists_url":"https://api.github.com/users/skidding/gists{/gist_id}","starred_url":"https://api.github.com/users/skidding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skidding/subscriptions","organizations_url":"https://api.github.com/users/skidding/orgs","repos_url":"https://api.github.com/users/skidding/repos","events_url":"https://api.github.com/users/skidding/events{/privacy}","received_events_url":"https://api.github.com/users/skidding/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T19:08:59Z","updated_at":"2015-06-01T19:08:59Z","body":"@w0rm can you please take a look?\r\n\r\nIt's a generic fix for https://github.com/skidding/cosmos/issues/130 and other use cases when fixture props aren't serializable (state should always be).\r\n\r\nThis is how I test Cosmos with a WIP ComponentPlayground branch: https://github.com/skidding/react-component-playground/issues/14#issuecomment-105966279\r\n\r\nI'm not very happy with the ad-hoc `isSerializable` implementation. Also started a question on SO in the meantime: http://stackoverflow.com/questions/30579940/reliable-way-to-check-if-objects-is-serializable-in-javascript"}}