{"action":"created","comment":{"url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/comments/45555748","id":45555748,"diff_hunk":"@@ -1366,9 +1370,9 @@ class ROISelector {\n };\n \n Rect2d CV_EXPORTS_W selectROI(Mat img, bool fromCenter = true);\n-Rect2d CV_EXPORTS_W selectROI(const cv::String& windowName, Mat img, bool showCrossair = true, bool fromCenter = true);\n-void CV_EXPORTS_W selectROI(const cv::String& windowName, Mat img, std::vector<Rect2d> & boundingBox, bool fromCenter = true);\n-\n+Rect2d CV_EXPORTS_W selectROI(const cv::String &windowName, Mat img, bool showCrossair = true, bool fromCenter = true);\n+void CV_EXPORTS_W selectROI(const cv::String &windowName, Mat img, std::vector<Rect2d> &boundingBox, bool fromCenter = true);\n+void CV_EXPORTS_W selectROI(const cv::String &windowName, cv::VideoCapture &cap, std::vector<Rect2d> &boundingBox, bool fromCenter = true);","path":"modules/tracking/include/opencv2/tracking/tracker.hpp","position":35,"original_position":35,"commit_id":"06f72d20df1e546a2ebe1d366cbdf9b66668d942","original_commit_id":"06f72d20df1e546a2ebe1d366cbdf9b66668d942","user":{"login":"berak","id":854416,"avatar_url":"https://avatars.githubusercontent.com/u/854416?v=3","gravatar_id":"","url":"https://api.github.com/users/berak","html_url":"https://github.com/berak","followers_url":"https://api.github.com/users/berak/followers","following_url":"https://api.github.com/users/berak/following{/other_user}","gists_url":"https://api.github.com/users/berak/gists{/gist_id}","starred_url":"https://api.github.com/users/berak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berak/subscriptions","organizations_url":"https://api.github.com/users/berak/orgs","repos_url":"https://api.github.com/users/berak/repos","events_url":"https://api.github.com/users/berak/events{/privacy}","received_events_url":"https://api.github.com/users/berak/received_events","type":"User","site_admin":false},"body":"does it really need this function ? \r\n\r\n* imho, it's not practical to draw a boundingrect while the video moves, there's good reason to do this on a still image instead.\r\n\r\n* the python wrappers complain about passing a reference to VideoCapture, so it probably should be CV_EXPORTS (w/o _W) , and so not wrapped to python","created_at":"2015-11-22T08:13:04Z","updated_at":"2015-11-22T08:13:04Z","html_url":"https://github.com/Itseez/opencv_contrib/pull/438#discussion_r45555748","pull_request_url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/comments/45555748"},"html":{"href":"https://github.com/Itseez/opencv_contrib/pull/438#discussion_r45555748"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438","id":50716195,"html_url":"https://github.com/Itseez/opencv_contrib/pull/438","diff_url":"https://github.com/Itseez/opencv_contrib/pull/438.diff","patch_url":"https://github.com/Itseez/opencv_contrib/pull/438.patch","issue_url":"https://api.github.com/repos/Itseez/opencv_contrib/issues/438","number":438,"state":"open","locked":false,"title":"Fix misleading message and keyboard input printed by roiSelector.cpp.","user":{"login":"superxingzheng","id":3332414,"avatar_url":"https://avatars.githubusercontent.com/u/3332414?v=3","gravatar_id":"","url":"https://api.github.com/users/superxingzheng","html_url":"https://github.com/superxingzheng","followers_url":"https://api.github.com/users/superxingzheng/followers","following_url":"https://api.github.com/users/superxingzheng/following{/other_user}","gists_url":"https://api.github.com/users/superxingzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/superxingzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superxingzheng/subscriptions","organizations_url":"https://api.github.com/users/superxingzheng/orgs","repos_url":"https://api.github.com/users/superxingzheng/repos","events_url":"https://api.github.com/users/superxingzheng/events{/privacy}","received_events_url":"https://api.github.com/users/superxingzheng/received_events","type":"User","site_admin":false},"body":"BACKSPACE's ASCII code is not 27. 27 is for ESC.","created_at":"2015-11-14T04:32:28Z","updated_at":"2015-11-22T08:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45f3ac8811996971bce3f5ce209e183f1471f931","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438/commits","review_comments_url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438/comments","review_comment_url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Itseez/opencv_contrib/issues/438/comments","statuses_url":"https://api.github.com/repos/Itseez/opencv_contrib/statuses/06f72d20df1e546a2ebe1d366cbdf9b66668d942","head":{"label":"superxingzheng:master","ref":"master","sha":"06f72d20df1e546a2ebe1d366cbdf9b66668d942","user":{"login":"superxingzheng","id":3332414,"avatar_url":"https://avatars.githubusercontent.com/u/3332414?v=3","gravatar_id":"","url":"https://api.github.com/users/superxingzheng","html_url":"https://github.com/superxingzheng","followers_url":"https://api.github.com/users/superxingzheng/followers","following_url":"https://api.github.com/users/superxingzheng/following{/other_user}","gists_url":"https://api.github.com/users/superxingzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/superxingzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superxingzheng/subscriptions","organizations_url":"https://api.github.com/users/superxingzheng/orgs","repos_url":"https://api.github.com/users/superxingzheng/repos","events_url":"https://api.github.com/users/superxingzheng/events{/privacy}","received_events_url":"https://api.github.com/users/superxingzheng/received_events","type":"User","site_admin":false},"repo":{"id":46160302,"name":"opencv_contrib","full_name":"superxingzheng/opencv_contrib","owner":{"login":"superxingzheng","id":3332414,"avatar_url":"https://avatars.githubusercontent.com/u/3332414?v=3","gravatar_id":"","url":"https://api.github.com/users/superxingzheng","html_url":"https://github.com/superxingzheng","followers_url":"https://api.github.com/users/superxingzheng/followers","following_url":"https://api.github.com/users/superxingzheng/following{/other_user}","gists_url":"https://api.github.com/users/superxingzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/superxingzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superxingzheng/subscriptions","organizations_url":"https://api.github.com/users/superxingzheng/orgs","repos_url":"https://api.github.com/users/superxingzheng/repos","events_url":"https://api.github.com/users/superxingzheng/events{/privacy}","received_events_url":"https://api.github.com/users/superxingzheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/superxingzheng/opencv_contrib","description":"Repository for OpenCV's extra modules","fork":true,"url":"https://api.github.com/repos/superxingzheng/opencv_contrib","forks_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/forks","keys_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/teams","hooks_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/hooks","issue_events_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/issues/events{/number}","events_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/events","assignees_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/assignees{/user}","branches_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/branches{/branch}","tags_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/tags","blobs_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/languages","stargazers_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/stargazers","contributors_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/contributors","subscribers_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/subscribers","subscription_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/subscription","commits_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/contents/{+path}","compare_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/merges","archive_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/downloads","issues_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/issues{/number}","pulls_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/labels{/name}","releases_url":"https://api.github.com/repos/superxingzheng/opencv_contrib/releases{/id}","created_at":"2015-11-14T03:45:06Z","updated_at":"2015-11-14T03:45:14Z","pushed_at":"2015-11-20T13:37:20Z","git_url":"git://github.com/superxingzheng/opencv_contrib.git","ssh_url":"git@github.com:superxingzheng/opencv_contrib.git","clone_url":"https://github.com/superxingzheng/opencv_contrib.git","svn_url":"https://github.com/superxingzheng/opencv_contrib","homepage":null,"size":107736,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Itseez:master","ref":"master","sha":"5e008c8758be1f11d831331d57256592e01f9a2f","user":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"repo":{"id":12756992,"name":"opencv_contrib","full_name":"Itseez/opencv_contrib","owner":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Itseez/opencv_contrib","description":"Repository for OpenCV's extra modules","fork":false,"url":"https://api.github.com/repos/Itseez/opencv_contrib","forks_url":"https://api.github.com/repos/Itseez/opencv_contrib/forks","keys_url":"https://api.github.com/repos/Itseez/opencv_contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Itseez/opencv_contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Itseez/opencv_contrib/teams","hooks_url":"https://api.github.com/repos/Itseez/opencv_contrib/hooks","issue_events_url":"https://api.github.com/repos/Itseez/opencv_contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Itseez/opencv_contrib/events","assignees_url":"https://api.github.com/repos/Itseez/opencv_contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Itseez/opencv_contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Itseez/opencv_contrib/tags","blobs_url":"https://api.github.com/repos/Itseez/opencv_contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Itseez/opencv_contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Itseez/opencv_contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Itseez/opencv_contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Itseez/opencv_contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Itseez/opencv_contrib/languages","stargazers_url":"https://api.github.com/repos/Itseez/opencv_contrib/stargazers","contributors_url":"https://api.github.com/repos/Itseez/opencv_contrib/contributors","subscribers_url":"https://api.github.com/repos/Itseez/opencv_contrib/subscribers","subscription_url":"https://api.github.com/repos/Itseez/opencv_contrib/subscription","commits_url":"https://api.github.com/repos/Itseez/opencv_contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Itseez/opencv_contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Itseez/opencv_contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Itseez/opencv_contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Itseez/opencv_contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Itseez/opencv_contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Itseez/opencv_contrib/merges","archive_url":"https://api.github.com/repos/Itseez/opencv_contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Itseez/opencv_contrib/downloads","issues_url":"https://api.github.com/repos/Itseez/opencv_contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Itseez/opencv_contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Itseez/opencv_contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Itseez/opencv_contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Itseez/opencv_contrib/labels{/name}","releases_url":"https://api.github.com/repos/Itseez/opencv_contrib/releases{/id}","created_at":"2013-09-11T13:28:04Z","updated_at":"2015-11-21T12:14:49Z","pushed_at":"2015-11-21T19:10:35Z","git_url":"git://github.com/Itseez/opencv_contrib.git","ssh_url":"git@github.com:Itseez/opencv_contrib.git","clone_url":"https://github.com/Itseez/opencv_contrib.git","svn_url":"https://github.com/Itseez/opencv_contrib","homepage":null,"size":161932,"stargazers_count":457,"watchers_count":457,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":635,"mirror_url":null,"open_issues_count":88,"forks":635,"open_issues":88,"watchers":457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438"},"html":{"href":"https://github.com/Itseez/opencv_contrib/pull/438"},"issue":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/issues/438"},"comments":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/Itseez/opencv_contrib/statuses/06f72d20df1e546a2ebe1d366cbdf9b66668d942"}}}}