{"action":"created","comment":{"url":"https://api.github.com/repos/micropython/micropython/pulls/comments/43022119","id":43022119,"diff_hunk":"@@ -1,5 +1,5 @@\n ﻿<?xml version=\"1.0\" encoding=\"utf-8\"?>\n-<Project DefaultTargets=\"Build\" ToolsVersion=\"12.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+<Project DefaultTargets=\"Build\" ToolsVersion=\"14.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">","path":"windows/micropython.vcxproj","position":3,"original_position":3,"commit_id":"7566e09210baad72b7213e9879ea1148ac580905","original_commit_id":"b8783fb56d8e45159db236ca6eecd74bb3f4a0fc","user":{"login":"omtinez","id":2659489,"avatar_url":"https://avatars.githubusercontent.com/u/2659489?v=3","gravatar_id":"","url":"https://api.github.com/users/omtinez","html_url":"https://github.com/omtinez","followers_url":"https://api.github.com/users/omtinez/followers","following_url":"https://api.github.com/users/omtinez/following{/other_user}","gists_url":"https://api.github.com/users/omtinez/gists{/gist_id}","starred_url":"https://api.github.com/users/omtinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omtinez/subscriptions","organizations_url":"https://api.github.com/users/omtinez/orgs","repos_url":"https://api.github.com/users/omtinez/repos","events_url":"https://api.github.com/users/omtinez/events{/privacy}","received_events_url":"https://api.github.com/users/omtinez/received_events","type":"User","site_admin":false},"body":"So you can just double click the project file and it opens in Visual Studio 2013 just fine? That's news to me. Did it prompt you that the project could not be loaded? Did it prompt you to convert the project to a compatible VS version? Did the project file change to v120 everywhere after opening it?","created_at":"2015-10-26T17:09:17Z","updated_at":"2015-10-26T17:09:17Z","html_url":"https://github.com/micropython/micropython/pull/1538#discussion_r43022119","pull_request_url":"https://api.github.com/repos/micropython/micropython/pulls/1538","_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments/43022119"},"html":{"href":"https://github.com/micropython/micropython/pull/1538#discussion_r43022119"},"pull_request":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1538"}}},"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1538","id":48683886,"html_url":"https://github.com/micropython/micropython/pull/1538","diff_url":"https://github.com/micropython/micropython/pull/1538.diff","patch_url":"https://github.com/micropython/micropython/pull/1538.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1538","number":1538,"state":"open","locked":false,"title":"Fix project build for VS2015","user":{"login":"omtinez","id":2659489,"avatar_url":"https://avatars.githubusercontent.com/u/2659489?v=3","gravatar_id":"","url":"https://api.github.com/users/omtinez","html_url":"https://github.com/omtinez","followers_url":"https://api.github.com/users/omtinez/followers","following_url":"https://api.github.com/users/omtinez/following{/other_user}","gists_url":"https://api.github.com/users/omtinez/gists{/gist_id}","starred_url":"https://api.github.com/users/omtinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omtinez/subscriptions","organizations_url":"https://api.github.com/users/omtinez/orgs","repos_url":"https://api.github.com/users/omtinez/repos","events_url":"https://api.github.com/users/omtinez/events{/privacy}","received_events_url":"https://api.github.com/users/omtinez/received_events","type":"User","site_admin":false},"body":"This change addresses the required build configuration changes for this project to build in the latest version of Visual Studio. Summary of changes:\r\n- Use platform-independent `os.path.join` and `os.sep` instead of hardcoded directory separators\r\n- Add `settimeout` function to the list of automatically generated header files. This is necessary when trying to compile with some of the components under /lib\r\n- Remove two digit exponent directive for Visual Studio versions 2015 and above, since now it's the default and it would cause a build failure.\r\n- Update output location of binaries in the `vcxproj` file to a more standard location, rather than the project root folder\r\n\r\nTested and working for Win32 and x64. ","created_at":"2015-10-25T18:11:09Z","updated_at":"2015-10-26T17:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c57d27a1675e6ba95b631da0da389f6919c6b282","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/1538/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/1538/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1538/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/7566e09210baad72b7213e9879ea1148ac580905","head":{"label":"omtinez:master","ref":"master","sha":"7566e09210baad72b7213e9879ea1148ac580905","user":{"login":"omtinez","id":2659489,"avatar_url":"https://avatars.githubusercontent.com/u/2659489?v=3","gravatar_id":"","url":"https://api.github.com/users/omtinez","html_url":"https://github.com/omtinez","followers_url":"https://api.github.com/users/omtinez/followers","following_url":"https://api.github.com/users/omtinez/following{/other_user}","gists_url":"https://api.github.com/users/omtinez/gists{/gist_id}","starred_url":"https://api.github.com/users/omtinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omtinez/subscriptions","organizations_url":"https://api.github.com/users/omtinez/orgs","repos_url":"https://api.github.com/users/omtinez/repos","events_url":"https://api.github.com/users/omtinez/events{/privacy}","received_events_url":"https://api.github.com/users/omtinez/received_events","type":"User","site_admin":false},"repo":{"id":44894258,"name":"micropython","full_name":"omtinez/micropython","owner":{"login":"omtinez","id":2659489,"avatar_url":"https://avatars.githubusercontent.com/u/2659489?v=3","gravatar_id":"","url":"https://api.github.com/users/omtinez","html_url":"https://github.com/omtinez","followers_url":"https://api.github.com/users/omtinez/followers","following_url":"https://api.github.com/users/omtinez/following{/other_user}","gists_url":"https://api.github.com/users/omtinez/gists{/gist_id}","starred_url":"https://api.github.com/users/omtinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omtinez/subscriptions","organizations_url":"https://api.github.com/users/omtinez/orgs","repos_url":"https://api.github.com/users/omtinez/repos","events_url":"https://api.github.com/users/omtinez/events{/privacy}","received_events_url":"https://api.github.com/users/omtinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omtinez/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":true,"url":"https://api.github.com/repos/omtinez/micropython","forks_url":"https://api.github.com/repos/omtinez/micropython/forks","keys_url":"https://api.github.com/repos/omtinez/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omtinez/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omtinez/micropython/teams","hooks_url":"https://api.github.com/repos/omtinez/micropython/hooks","issue_events_url":"https://api.github.com/repos/omtinez/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/omtinez/micropython/events","assignees_url":"https://api.github.com/repos/omtinez/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/omtinez/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/omtinez/micropython/tags","blobs_url":"https://api.github.com/repos/omtinez/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omtinez/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omtinez/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/omtinez/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omtinez/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/omtinez/micropython/languages","stargazers_url":"https://api.github.com/repos/omtinez/micropython/stargazers","contributors_url":"https://api.github.com/repos/omtinez/micropython/contributors","subscribers_url":"https://api.github.com/repos/omtinez/micropython/subscribers","subscription_url":"https://api.github.com/repos/omtinez/micropython/subscription","commits_url":"https://api.github.com/repos/omtinez/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/omtinez/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/omtinez/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/omtinez/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/omtinez/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/omtinez/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omtinez/micropython/merges","archive_url":"https://api.github.com/repos/omtinez/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omtinez/micropython/downloads","issues_url":"https://api.github.com/repos/omtinez/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/omtinez/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/omtinez/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/omtinez/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omtinez/micropython/labels{/name}","releases_url":"https://api.github.com/repos/omtinez/micropython/releases{/id}","created_at":"2015-10-25T03:02:35Z","updated_at":"2015-10-25T03:02:47Z","pushed_at":"2015-10-25T19:19:23Z","git_url":"git://github.com/omtinez/micropython.git","ssh_url":"git@github.com:omtinez/micropython.git","clone_url":"https://github.com/omtinez/micropython.git","svn_url":"https://github.com/omtinez/micropython","homepage":"","size":22021,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"ca9eb81d0b8624bfee6dac7b062747b01e8aeb4b","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","created_at":"2013-12-20T11:47:07Z","updated_at":"2015-10-26T16:59:20Z","pushed_at":"2015-10-26T11:46:07Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":"","size":49634,"stargazers_count":2384,"watchers_count":2384,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":464,"mirror_url":null,"open_issues_count":160,"forks":464,"open_issues":160,"watchers":2384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1538"},"html":{"href":"https://github.com/micropython/micropython/pull/1538"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/1538"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/1538/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1538/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/1538/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/7566e09210baad72b7213e9879ea1148ac580905"}}}}