{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/43576186","id":43576186,"diff_hunk":"@@ -42,17 +43,27 @@\n class EB_Perl(ConfigureMake):\n     \"\"\"Support for building and installing Perl.\"\"\"\n \n+    @staticmethod\n+    def extra_options():\n+        \"\"\"Add extra config options specific to Perl.\"\"\"\n+        extra_vars = {\n+            'use_perl_threads': [True, \"Use internal Perl threads by means of the -Dusethreads compiler directive\", CUSTOM],\n+        }\n+        return ConfigureMake.extra_options(extra_vars)\n+\n     def configure_step(self):\n         \"\"\"\n         Configure Perl build: run ./Configure instead of ./configure with some different options\n         \"\"\"\n         configopts = ' '.join([\n             self.cfg['configopts'],\n-            \"-Dusethreads\",\n             '-Dcc=\"%s\"' % os.getenv('CC'),\n             '-Dccflags=\"%s\"' % os.getenv('CFLAGS'),\n             '-Dinc_version_list=none',\n         ])\n+        if self.cfg['use_perl_threads']:\n+            configopts.append(\"-Dusethreads\")\n+\n         cmd = './Configure -de %s -Dprefix=\"%s\" ' % (configopts, self.installdir)","path":"easybuild/easyblocks/p/perl.py","position":34,"original_position":34,"commit_id":"ca5e0d6df23a3dd9e5e3443b13dc1b72ce27c356","original_commit_id":"ca5e0d6df23a3dd9e5e3443b13dc1b72ce27c356","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"maybe use `' '.join(configopts)` here instead of `configopts`, and remove it above (then the `.append` will work)","created_at":"2015-10-31T21:07:08Z","updated_at":"2015-10-31T21:07:08Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/724#discussion_r43576186","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/43576186"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/724#discussion_r43576186"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724","id":48936341,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/724","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/724.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/724.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/724","number":724,"state":"open","locked":false,"title":"Perl","user":{"login":"valtandor","id":2653689,"avatar_url":"https://avatars.githubusercontent.com/u/2653689?v=3","gravatar_id":"","url":"https://api.github.com/users/valtandor","html_url":"https://github.com/valtandor","followers_url":"https://api.github.com/users/valtandor/followers","following_url":"https://api.github.com/users/valtandor/following{/other_user}","gists_url":"https://api.github.com/users/valtandor/gists{/gist_id}","starred_url":"https://api.github.com/users/valtandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valtandor/subscriptions","organizations_url":"https://api.github.com/users/valtandor/orgs","repos_url":"https://api.github.com/users/valtandor/repos","events_url":"https://api.github.com/users/valtandor/events{/privacy}","received_events_url":"https://api.github.com/users/valtandor/received_events","type":"User","site_admin":false},"body":"Add an option to allow removal of the -Dusethreads flag","created_at":"2015-10-27T21:38:19Z","updated_at":"2015-10-31T21:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"639581ca1dda49cc4c99add84d72d4f2491bc51a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/724/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/ca5e0d6df23a3dd9e5e3443b13dc1b72ce27c356","head":{"label":"valtandor:Perl","ref":"Perl","sha":"ca5e0d6df23a3dd9e5e3443b13dc1b72ce27c356","user":{"login":"valtandor","id":2653689,"avatar_url":"https://avatars.githubusercontent.com/u/2653689?v=3","gravatar_id":"","url":"https://api.github.com/users/valtandor","html_url":"https://github.com/valtandor","followers_url":"https://api.github.com/users/valtandor/followers","following_url":"https://api.github.com/users/valtandor/following{/other_user}","gists_url":"https://api.github.com/users/valtandor/gists{/gist_id}","starred_url":"https://api.github.com/users/valtandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valtandor/subscriptions","organizations_url":"https://api.github.com/users/valtandor/orgs","repos_url":"https://api.github.com/users/valtandor/repos","events_url":"https://api.github.com/users/valtandor/events{/privacy}","received_events_url":"https://api.github.com/users/valtandor/received_events","type":"User","site_admin":false},"repo":{"id":24910972,"name":"easybuild-easyblocks","full_name":"valtandor/easybuild-easyblocks","owner":{"login":"valtandor","id":2653689,"avatar_url":"https://avatars.githubusercontent.com/u/2653689?v=3","gravatar_id":"","url":"https://api.github.com/users/valtandor","html_url":"https://github.com/valtandor","followers_url":"https://api.github.com/users/valtandor/followers","following_url":"https://api.github.com/users/valtandor/following{/other_user}","gists_url":"https://api.github.com/users/valtandor/gists{/gist_id}","starred_url":"https://api.github.com/users/valtandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valtandor/subscriptions","organizations_url":"https://api.github.com/users/valtandor/orgs","repos_url":"https://api.github.com/users/valtandor/repos","events_url":"https://api.github.com/users/valtandor/events{/privacy}","received_events_url":"https://api.github.com/users/valtandor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valtandor/easybuild-easyblocks","description":"Collection of easyblock that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/valtandor/easybuild-easyblocks","forks_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/valtandor/easybuild-easyblocks/releases{/id}","created_at":"2014-10-07T20:50:15Z","updated_at":"2015-03-31T21:09:58Z","pushed_at":"2015-10-28T00:26:44Z","git_url":"git://github.com/valtandor/easybuild-easyblocks.git","ssh_url":"git@github.com:valtandor/easybuild-easyblocks.git","clone_url":"https://github.com/valtandor/easybuild-easyblocks.git","svn_url":"https://github.com/valtandor/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":8527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"94843b9d66df09e9c2c6cf37fb4714ac0688db92","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","created_at":"2012-10-15T14:31:19Z","updated_at":"2015-09-28T14:43:46Z","pushed_at":"2015-10-31T20:00:47Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":12408,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":113,"forks":82,"open_issues":113,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/724"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/724"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/ca5e0d6df23a3dd9e5e3443b13dc1b72ce27c356"}}}}