{"action":"closed","issue":{"url":"https://api.github.com/repos/amiv-eth/amivapi/issues/97","labels_url":"https://api.github.com/repos/amiv-eth/amivapi/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/amiv-eth/amivapi/issues/97/comments","events_url":"https://api.github.com/repos/amiv-eth/amivapi/issues/97/events","html_url":"https://github.com/amiv-eth/amivapi/issues/97","id":117878398,"number":97,"title":"Changes in group organisation structure","user":{"login":"NotSpecial","id":7079143,"avatar_url":"https://avatars.githubusercontent.com/u/7079143?v=3","gravatar_id":"","url":"https://api.github.com/users/NotSpecial","html_url":"https://github.com/NotSpecial","followers_url":"https://api.github.com/users/NotSpecial/followers","following_url":"https://api.github.com/users/NotSpecial/following{/other_user}","gists_url":"https://api.github.com/users/NotSpecial/gists{/gist_id}","starred_url":"https://api.github.com/users/NotSpecial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotSpecial/subscriptions","organizations_url":"https://api.github.com/users/NotSpecial/orgs","repos_url":"https://api.github.com/users/NotSpecial/repos","events_url":"https://api.github.com/users/NotSpecial/events{/privacy}","received_events_url":"https://api.github.com/users/NotSpecial/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/amiv-eth/amivapi/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"NotSpecial","id":7079143,"avatar_url":"https://avatars.githubusercontent.com/u/7079143?v=3","gravatar_id":"","url":"https://api.github.com/users/NotSpecial","html_url":"https://github.com/NotSpecial","followers_url":"https://api.github.com/users/NotSpecial/followers","following_url":"https://api.github.com/users/NotSpecial/following{/other_user}","gists_url":"https://api.github.com/users/NotSpecial/gists{/gist_id}","starred_url":"https://api.github.com/users/NotSpecial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotSpecial/subscriptions","organizations_url":"https://api.github.com/users/NotSpecial/orgs","repos_url":"https://api.github.com/users/NotSpecial/repos","events_url":"https://api.github.com/users/NotSpecial/events{/privacy}","received_events_url":"https://api.github.com/users/NotSpecial/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-19T18:36:20Z","updated_at":"2015-11-20T10:32:13Z","closed_at":"2015-11-20T10:32:13Z","body":"In contrast to events, which have several usecases of events which have participants which are not AMIV members, I cannot think of any case in which some random person should enter a group/mailinglist on their own.\r\n\r\nCurrent situation:\r\n\r\nGroups have user and address members. If the field \"public\" is true, address members are allowed.\r\nRegistered users can sign up for any group.\r\n\r\nWhile this structure was fitting for mailinglists, I think it needs to be changed for groups.\r\n\r\nWe need groups which allow no self enroll (e.g. Vorstand)\r\nWe dont need the possibility for random people to enter any group (I believe)\r\nBut we need the possibility to add additional email addresses to a group (for the purpose of forwarding mails to other groups or external systems, e.g. lan-party which needs to reach VIS as well)\r\n\r\nI would propose the following changes:\r\n\r\nthe \"public\" field controls if AMIV Members can sign up themselves to the group, e.g. a \"Helfer\" group.\r\nIf it is not public, only the group owner or admins can add people to groups.\r\nGroupAddressMembers could be renamed to \"AdditionalAdress\" or something, They can only be added by group owner/admin.\r\n\r\nSo basically: no random people for groups anymore, because not needed.\r\n\r\nAny thoughts on this?"}}