{"action":"created","comment":{"url":"https://api.github.com/repos/alda-lang/alda/pulls/comments/39354509","id":39354509,"diff_hunk":"@@ -22,7 +22,8 @@ chord                   = (note | rest) subchord+\n note                    = pitch duration? <ows> slur?\n rest                    = <\"r\"> duration? <ows>\n \n-pitch                   = !name #\"[a-g][+-]*\"\n+pitch                   = pitch-notation\n+pitch-notation          = !name #\"[a-g][+-=]*\"","path":"grammar/alda.bnf","position":6,"original_position":6,"commit_id":"60b41fe3f9e714ea28858f6e07e02b18e343e2bf","original_commit_id":"60b41fe3f9e714ea28858f6e07e02b18e343e2bf","user":{"login":"daveyarwood","id":4909079,"avatar_url":"https://avatars.githubusercontent.com/u/4909079?v=3","gravatar_id":"","url":"https://api.github.com/users/daveyarwood","html_url":"https://github.com/daveyarwood","followers_url":"https://api.github.com/users/daveyarwood/followers","following_url":"https://api.github.com/users/daveyarwood/following{/other_user}","gists_url":"https://api.github.com/users/daveyarwood/gists{/gist_id}","starred_url":"https://api.github.com/users/daveyarwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveyarwood/subscriptions","organizations_url":"https://api.github.com/users/daveyarwood/orgs","repos_url":"https://api.github.com/users/daveyarwood/repos","events_url":"https://api.github.com/users/daveyarwood/events{/privacy}","received_events_url":"https://api.github.com/users/daveyarwood/received_events","type":"User","site_admin":false},"body":"could change THIS to `<pitch-notation>`, so that the contents of the `:pitch-notation` node get lifted up into the next higher level of the parse tree, e.g. into the `:pitch` node","created_at":"2015-09-14T00:18:34Z","updated_at":"2015-09-14T00:18:34Z","html_url":"https://github.com/alda-lang/alda/pull/89#discussion_r39354509","pull_request_url":"https://api.github.com/repos/alda-lang/alda/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/comments/39354509"},"html":{"href":"https://github.com/alda-lang/alda/pull/89#discussion_r39354509"},"pull_request":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/alda-lang/alda/pulls/89","id":44861368,"html_url":"https://github.com/alda-lang/alda/pull/89","diff_url":"https://github.com/alda-lang/alda/pull/89.diff","patch_url":"https://github.com/alda-lang/alda/pull/89.patch","issue_url":"https://api.github.com/repos/alda-lang/alda/issues/89","number":89,"state":"open","locked":false,"title":"Feature: key signatures","user":{"login":"FragLegs","id":961944,"avatar_url":"https://avatars.githubusercontent.com/u/961944?v=3","gravatar_id":"","url":"https://api.github.com/users/FragLegs","html_url":"https://github.com/FragLegs","followers_url":"https://api.github.com/users/FragLegs/followers","following_url":"https://api.github.com/users/FragLegs/following{/other_user}","gists_url":"https://api.github.com/users/FragLegs/gists{/gist_id}","starred_url":"https://api.github.com/users/FragLegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FragLegs/subscriptions","organizations_url":"https://api.github.com/users/FragLegs/orgs","repos_url":"https://api.github.com/users/FragLegs/repos","events_url":"https://api.github.com/users/FragLegs/events{/privacy}","received_events_url":"https://api.github.com/users/FragLegs/received_events","type":"User","site_admin":false},"body":"My initial attempt at providing the feature referenced in issue #36. I need to fix all of the now-broken unit tests, add new ones, and provide documentation, but I wanted to open the PR early to get feedback on the design.\r\n\r\nYou can change a key signature like this `piano: (key c++ e-) c c+ c=` which will map to `c++ c+ c`\r\n\r\nThis is my first time working in Clojure, so please tell me what you don't like and why - it will help me immensely in my learning. I'm sure I did a lot of stupid noobish things.","created_at":"2015-09-12T21:16:45Z","updated_at":"2015-09-14T00:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0028642dbf823b05a26332ef7348086f1032c2ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alda-lang/alda/pulls/89/commits","review_comments_url":"https://api.github.com/repos/alda-lang/alda/pulls/89/comments","review_comment_url":"https://api.github.com/repos/alda-lang/alda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alda-lang/alda/issues/89/comments","statuses_url":"https://api.github.com/repos/alda-lang/alda/statuses/60b41fe3f9e714ea28858f6e07e02b18e343e2bf","head":{"label":"FragLegs:key","ref":"key","sha":"60b41fe3f9e714ea28858f6e07e02b18e343e2bf","user":{"login":"FragLegs","id":961944,"avatar_url":"https://avatars.githubusercontent.com/u/961944?v=3","gravatar_id":"","url":"https://api.github.com/users/FragLegs","html_url":"https://github.com/FragLegs","followers_url":"https://api.github.com/users/FragLegs/followers","following_url":"https://api.github.com/users/FragLegs/following{/other_user}","gists_url":"https://api.github.com/users/FragLegs/gists{/gist_id}","starred_url":"https://api.github.com/users/FragLegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FragLegs/subscriptions","organizations_url":"https://api.github.com/users/FragLegs/orgs","repos_url":"https://api.github.com/users/FragLegs/repos","events_url":"https://api.github.com/users/FragLegs/events{/privacy}","received_events_url":"https://api.github.com/users/FragLegs/received_events","type":"User","site_admin":false},"repo":{"id":42069064,"name":"alda","full_name":"FragLegs/alda","owner":{"login":"FragLegs","id":961944,"avatar_url":"https://avatars.githubusercontent.com/u/961944?v=3","gravatar_id":"","url":"https://api.github.com/users/FragLegs","html_url":"https://github.com/FragLegs","followers_url":"https://api.github.com/users/FragLegs/followers","following_url":"https://api.github.com/users/FragLegs/following{/other_user}","gists_url":"https://api.github.com/users/FragLegs/gists{/gist_id}","starred_url":"https://api.github.com/users/FragLegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FragLegs/subscriptions","organizations_url":"https://api.github.com/users/FragLegs/orgs","repos_url":"https://api.github.com/users/FragLegs/repos","events_url":"https://api.github.com/users/FragLegs/events{/privacy}","received_events_url":"https://api.github.com/users/FragLegs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FragLegs/alda","description":"A music programming language for musicians. :notes:","fork":true,"url":"https://api.github.com/repos/FragLegs/alda","forks_url":"https://api.github.com/repos/FragLegs/alda/forks","keys_url":"https://api.github.com/repos/FragLegs/alda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FragLegs/alda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FragLegs/alda/teams","hooks_url":"https://api.github.com/repos/FragLegs/alda/hooks","issue_events_url":"https://api.github.com/repos/FragLegs/alda/issues/events{/number}","events_url":"https://api.github.com/repos/FragLegs/alda/events","assignees_url":"https://api.github.com/repos/FragLegs/alda/assignees{/user}","branches_url":"https://api.github.com/repos/FragLegs/alda/branches{/branch}","tags_url":"https://api.github.com/repos/FragLegs/alda/tags","blobs_url":"https://api.github.com/repos/FragLegs/alda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FragLegs/alda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FragLegs/alda/git/refs{/sha}","trees_url":"https://api.github.com/repos/FragLegs/alda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FragLegs/alda/statuses/{sha}","languages_url":"https://api.github.com/repos/FragLegs/alda/languages","stargazers_url":"https://api.github.com/repos/FragLegs/alda/stargazers","contributors_url":"https://api.github.com/repos/FragLegs/alda/contributors","subscribers_url":"https://api.github.com/repos/FragLegs/alda/subscribers","subscription_url":"https://api.github.com/repos/FragLegs/alda/subscription","commits_url":"https://api.github.com/repos/FragLegs/alda/commits{/sha}","git_commits_url":"https://api.github.com/repos/FragLegs/alda/git/commits{/sha}","comments_url":"https://api.github.com/repos/FragLegs/alda/comments{/number}","issue_comment_url":"https://api.github.com/repos/FragLegs/alda/issues/comments{/number}","contents_url":"https://api.github.com/repos/FragLegs/alda/contents/{+path}","compare_url":"https://api.github.com/repos/FragLegs/alda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FragLegs/alda/merges","archive_url":"https://api.github.com/repos/FragLegs/alda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FragLegs/alda/downloads","issues_url":"https://api.github.com/repos/FragLegs/alda/issues{/number}","pulls_url":"https://api.github.com/repos/FragLegs/alda/pulls{/number}","milestones_url":"https://api.github.com/repos/FragLegs/alda/milestones{/number}","notifications_url":"https://api.github.com/repos/FragLegs/alda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FragLegs/alda/labels{/name}","releases_url":"https://api.github.com/repos/FragLegs/alda/releases{/id}","created_at":"2015-09-07T18:43:59Z","updated_at":"2015-09-07T18:43:59Z","pushed_at":"2015-09-12T21:01:11Z","git_url":"git://github.com/FragLegs/alda.git","ssh_url":"git@github.com:FragLegs/alda.git","clone_url":"https://github.com/FragLegs/alda.git","svn_url":"https://github.com/FragLegs/alda","homepage":"","size":324,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alda-lang:master","ref":"master","sha":"a7d8defa20a34b47fcf84a7494328d1b99317e3d","user":{"login":"alda-lang","id":10534187,"avatar_url":"https://avatars.githubusercontent.com/u/10534187?v=3","gravatar_id":"","url":"https://api.github.com/users/alda-lang","html_url":"https://github.com/alda-lang","followers_url":"https://api.github.com/users/alda-lang/followers","following_url":"https://api.github.com/users/alda-lang/following{/other_user}","gists_url":"https://api.github.com/users/alda-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/alda-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alda-lang/subscriptions","organizations_url":"https://api.github.com/users/alda-lang/orgs","repos_url":"https://api.github.com/users/alda-lang/repos","events_url":"https://api.github.com/users/alda-lang/events{/privacy}","received_events_url":"https://api.github.com/users/alda-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":23338323,"name":"alda","full_name":"alda-lang/alda","owner":{"login":"alda-lang","id":10534187,"avatar_url":"https://avatars.githubusercontent.com/u/10534187?v=3","gravatar_id":"","url":"https://api.github.com/users/alda-lang","html_url":"https://github.com/alda-lang","followers_url":"https://api.github.com/users/alda-lang/followers","following_url":"https://api.github.com/users/alda-lang/following{/other_user}","gists_url":"https://api.github.com/users/alda-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/alda-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alda-lang/subscriptions","organizations_url":"https://api.github.com/users/alda-lang/orgs","repos_url":"https://api.github.com/users/alda-lang/repos","events_url":"https://api.github.com/users/alda-lang/events{/privacy}","received_events_url":"https://api.github.com/users/alda-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alda-lang/alda","description":"A music programming language for musicians. :notes:","fork":false,"url":"https://api.github.com/repos/alda-lang/alda","forks_url":"https://api.github.com/repos/alda-lang/alda/forks","keys_url":"https://api.github.com/repos/alda-lang/alda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alda-lang/alda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alda-lang/alda/teams","hooks_url":"https://api.github.com/repos/alda-lang/alda/hooks","issue_events_url":"https://api.github.com/repos/alda-lang/alda/issues/events{/number}","events_url":"https://api.github.com/repos/alda-lang/alda/events","assignees_url":"https://api.github.com/repos/alda-lang/alda/assignees{/user}","branches_url":"https://api.github.com/repos/alda-lang/alda/branches{/branch}","tags_url":"https://api.github.com/repos/alda-lang/alda/tags","blobs_url":"https://api.github.com/repos/alda-lang/alda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alda-lang/alda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alda-lang/alda/git/refs{/sha}","trees_url":"https://api.github.com/repos/alda-lang/alda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alda-lang/alda/statuses/{sha}","languages_url":"https://api.github.com/repos/alda-lang/alda/languages","stargazers_url":"https://api.github.com/repos/alda-lang/alda/stargazers","contributors_url":"https://api.github.com/repos/alda-lang/alda/contributors","subscribers_url":"https://api.github.com/repos/alda-lang/alda/subscribers","subscription_url":"https://api.github.com/repos/alda-lang/alda/subscription","commits_url":"https://api.github.com/repos/alda-lang/alda/commits{/sha}","git_commits_url":"https://api.github.com/repos/alda-lang/alda/git/commits{/sha}","comments_url":"https://api.github.com/repos/alda-lang/alda/comments{/number}","issue_comment_url":"https://api.github.com/repos/alda-lang/alda/issues/comments{/number}","contents_url":"https://api.github.com/repos/alda-lang/alda/contents/{+path}","compare_url":"https://api.github.com/repos/alda-lang/alda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alda-lang/alda/merges","archive_url":"https://api.github.com/repos/alda-lang/alda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alda-lang/alda/downloads","issues_url":"https://api.github.com/repos/alda-lang/alda/issues{/number}","pulls_url":"https://api.github.com/repos/alda-lang/alda/pulls{/number}","milestones_url":"https://api.github.com/repos/alda-lang/alda/milestones{/number}","notifications_url":"https://api.github.com/repos/alda-lang/alda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alda-lang/alda/labels{/name}","releases_url":"https://api.github.com/repos/alda-lang/alda/releases{/id}","created_at":"2014-08-26T04:07:53Z","updated_at":"2015-09-13T23:52:10Z","pushed_at":"2015-09-13T01:35:30Z","git_url":"git://github.com/alda-lang/alda.git","ssh_url":"git@github.com:alda-lang/alda.git","clone_url":"https://github.com/alda-lang/alda.git","svn_url":"https://github.com/alda-lang/alda","homepage":"","size":1274,"stargazers_count":1173,"watchers_count":1173,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":35,"forks":54,"open_issues":35,"watchers":1173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/89"},"html":{"href":"https://github.com/alda-lang/alda/pull/89"},"issue":{"href":"https://api.github.com/repos/alda-lang/alda/issues/89"},"comments":{"href":"https://api.github.com/repos/alda-lang/alda/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alda-lang/alda/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/alda-lang/alda/statuses/60b41fe3f9e714ea28858f6e07e02b18e343e2bf"}}}}