{"action":"created","comment":{"url":"https://api.github.com/repos/openchange/openchange/pulls/comments/28767383","id":28767383,"diff_hunk":"@@ -281,383 +281,17 @@ static enum MAPISTATUS dcesrv_EcDoDisconnect(struct dcesrv_call_state *dce_call,\n \treturn MAPI_E_SUCCESS;\n }\n \n-static bool emsmdbp_fill_notification(TALLOC_CTX *mem_ctx, \n-                                      struct emsmdbp_context *emsmdbp_ctx,\n-                                      struct EcDoRpc_MAPI_REPL *mapi_repl,\n-                                      struct mapistore_subscription *subscription,\n-                                      struct mapistore_notification *notification,\n-                                      uint16_t *sizep)\n-{\n-\tbool\t\t\tsuccess = true;\t\n-        struct Notify_repl      *reply;\n-        struct emsmdbp_object   *handle_object;\n-        struct emsmdbp_object_table *table;\n-\tstruct mapi_handles     *handle_object_handle;\n-\tenum MAPISTATUS         retval;\n-        void                    **data_pointers;\n-        DATA_BLOB               *table_row;\n-        enum MAPISTATUS\t\t*retvals;\n-        uint32_t                contextID, saved_prop_count, prev_instance;\n-        enum MAPITAGS           *saved_properties, *previous_row_properties;\n-        uint64_t                prev_fid, prev_mid;\n-\n-        mapi_repl->opnum = op_MAPI_Notify;\n-        reply = &mapi_repl->u.mapi_Notify;\n-        reply->LogonId = 0; /* TODO: seems to be always 0 ? */\n-\n-\tretval = mapi_handles_search(emsmdbp_ctx->handles_ctx, subscription->handle, &handle_object_handle);\n-\tif (retval) {\n-\t\treply->NotificationType = fnevCriticalError;\n-\t\tOC_DEBUG(5, \"notification handle not found\\n\");\n-\t\tgoto end;\n-\t}\n-\tretval = mapi_handles_get_private_data(handle_object_handle, (void **) &handle_object);\n-\tif (retval) {\n-\t\treply->NotificationType = fnevCriticalError;\n-\t\tOC_DEBUG(5, \"object not found for notification handle\\n\");\n-\t\tgoto end;\n-\t}\n-\n-\treply->NotificationHandle = subscription->handle;\n-        switch (notification->object_type) {\n-        case MAPISTORE_MESSAGE:\n-                reply->NotificationType = fnevMbit;\n-                break;\n-        case MAPISTORE_FOLDER:\n-                if (notification->parameters.object_parameters.new_message_count) {\n-                  reply->NotificationType = fnevTbit;\n-                }\n-                else {\n-                  reply->NotificationType = 0; // FIXME - THIS IS WRONG - IT'S AN INVALID NOTIFICATION TYPE\n-                }\n-                break;\n-        case MAPISTORE_TABLE:\n-                reply->NotificationType = fnevTableModified;\n-                if (notification->parameters.table_parameters.table_type != MAPISTORE_FOLDER_TABLE) {\n-                        reply->NotificationType |= (fnevMbit | fnevSbit);\n-                }\n-                break;\n-        default:\n-                reply->NotificationType = fnevCriticalError;\n-                OC_DEBUG(5, \"unknown value for notification object type: %d\\n\", notification->object_type);\n-                goto end;\n-        }\n-\n-        if (notification->object_type == MAPISTORE_TABLE) {\n-                table = handle_object->object.table;\n-\n-                /* FIXME: here is a hack to update table counters and which would not be needed if the backend had access to the table structure... */\n-                if (notification->event == MAPISTORE_OBJECT_CREATED) {\n-                        table->denominator++;\n-                }\n-                else if (notification->event == MAPISTORE_OBJECT_DELETED) {\n-                        table->denominator--;\n-                        if (table->numerator >= table->denominator) {\n-                                table->numerator = table->denominator;\n-                        }\n-                }\n-\n-                if (notification->parameters.table_parameters.table_type == MAPISTORE_FOLDER_TABLE) {\n-                        if (notification->event == MAPISTORE_OBJECT_CREATED || notification->event == MAPISTORE_OBJECT_MODIFIED) {\n-                                if (notification->parameters.table_parameters.row_id > 0) {\n-                                        /* FIXME: this hack enables the fetching of some properties from the previous row */\n-                                        saved_prop_count = table->prop_count;\n-                                        saved_properties = table->properties;\n-                                        previous_row_properties = talloc_array(NULL, enum MAPITAGS, 1);\n-                                        previous_row_properties[0] = PR_FID;\n-                                        table->properties = previous_row_properties;\n-                                        table->prop_count = 1;\n-\t\t\t\t\tcontextID = emsmdbp_get_contextID(handle_object);\n-\t\t\t\t\tmapistore_table_set_columns(emsmdbp_ctx->mstore_ctx, contextID, handle_object->backend_object, table->prop_count, (enum MAPITAGS *) table->properties);\n-                                        data_pointers = emsmdbp_object_table_get_row_props(mem_ctx, emsmdbp_ctx, handle_object,\n-                                                                                           notification->parameters.table_parameters.row_id - 1, MAPISTORE_PREFILTERED_QUERY,\n-                                                                                           &retvals);\n-                                        if (data_pointers) {\n-                                                prev_fid = *(uint32_t *) data_pointers[0];\n-                                                talloc_free(data_pointers);\n-                                        }\n-                                        else {\n-                                                prev_fid = -1;\n-                                        }\n-\n-                                        table->prop_count = saved_prop_count;\n-                                        table->properties = saved_properties;\n-                                        talloc_free(previous_row_properties);\n-\t\t\t\t\tmapistore_table_set_columns(emsmdbp_ctx->mstore_ctx, contextID, handle_object->backend_object, table->prop_count, (enum MAPITAGS *) table->properties);\n-                                }\n-                                else {\n-                                        prev_fid = 0;\n-                                }\n-\n-                                table_row = talloc_zero(mem_ctx, DATA_BLOB);\n-                                data_pointers = emsmdbp_object_table_get_row_props(mem_ctx, emsmdbp_ctx, handle_object,\n-                                                                                   notification->parameters.table_parameters.row_id, MAPISTORE_PREFILTERED_QUERY,\n-                                                                                   &retvals);\n-\t\t\t\tif (data_pointers) {\n-\t\t\t\t\temsmdbp_fill_table_row_blob(mem_ctx, emsmdbp_ctx, table_row, table->prop_count, (enum MAPITAGS *) table->properties, data_pointers, retvals);\n-\t\t\t\t\ttalloc_free(data_pointers);\n-\t\t\t\t\ttalloc_free(retvals);\n-\t\t\t\t}\n-\t\t\t\telse {\n-\t\t\t\t\tsuccess = false;\n-\t\t\t\t\tOC_DEBUG(5, \"no data returned for row, notification ignored\\n\");\n-\t\t\t\t}\n-                        }\n-\n-                        /* FIXME: for some reason, TABLE_ROW_MODIFIED and TABLE_ROW_DELETED do not work... */\n-                        reply->NotificationData.SearchTableChange.TableEvent = TABLE_CHANGED;\n-                        switch (notification->event) {\n-                        case MAPISTORE_OBJECT_CREATED:\n-\t\t\t\t/* case MAPISTORE_OBJECT_MODIFIED: */\n-                                reply->NotificationData.HierarchyTableChange.TableEvent = (notification->event == MAPISTORE_OBJECT_CREATED ? TABLE_ROW_ADDED : TABLE_ROW_MODIFIED);\n-                                reply->NotificationData.HierarchyTableChange.HierarchyTableChangeUnion.HierarchyRowAddedNotification.FID = notification->parameters.table_parameters.object_id;\n-                                reply->NotificationData.HierarchyTableChange.HierarchyTableChangeUnion.HierarchyRowAddedNotification.InsertAfterFID = prev_fid;\n-                                reply->NotificationData.HierarchyTableChange.HierarchyTableChangeUnion.HierarchyRowAddedNotification.Columns = *table_row;\n-                                break;\n-\t\t\tcase MAPISTORE_OBJECT_MODIFIED:\n-\t\t\tcase MAPISTORE_OBJECT_DELETED:\n-\t\t\tcase MAPISTORE_OBJECT_COPIED:\n-\t\t\tcase MAPISTORE_OBJECT_MOVED:\n-\t\t\tcase MAPISTORE_OBJECT_NEWMAIL:\n-\t\t\t\tbreak;\n-                        /* case MAPISTORE_OBJECT_DELETED: */\n-                        /*         reply->NotificationData.HierarchyTableChange.TableEvent = TABLE_ROW_DELETED; */\n-                        /*         reply->NotificationData.HierarchyTableChange.HierarchyTableChangeUnion.HierarchyRowDeletedNotification.FID = notification->parameters.table_parameters.object_id; */\n-                        /*         break; */\n-                        /* default: */\n-                        /*         reply->NotificationType = fnevCriticalError; */\n-                        /*         OC_DEBUG(5, (\"unknown value for notification event: %d\\n\", notification->event)); */\n-                        /*         goto end; */\n-                        }\n-                }\n-                else {\n-                        if (notification->event == MAPISTORE_OBJECT_CREATED || notification->event == MAPISTORE_OBJECT_MODIFIED) {\n-                                if (notification->parameters.table_parameters.row_id > 0) {\n-                                        /* FIXME: this hack enables the fetching of some properties from the previous row */\n-                                        saved_prop_count = table->prop_count;\n-                                        saved_properties = table->properties;\n-                                        previous_row_properties = talloc_array(NULL, enum MAPITAGS, 3);\n-                                        previous_row_properties[0] = PR_FID;\n-                                        previous_row_properties[1] = PR_MID;\n-                                        previous_row_properties[2] = PR_INSTANCE_NUM;\n-                                        table->properties = previous_row_properties;\n-                                        table->prop_count = 3;\n-\t\t\t\t\tcontextID = emsmdbp_get_contextID(handle_object);\n-\t\t\t\t\tmapistore_table_set_columns(emsmdbp_ctx->mstore_ctx, contextID, handle_object->backend_object, table->prop_count, (enum MAPITAGS *) table->properties);\n-                                        data_pointers = emsmdbp_object_table_get_row_props(mem_ctx, emsmdbp_ctx, handle_object, notification->parameters.table_parameters.row_id - 1, MAPISTORE_PREFILTERED_QUERY, NULL);\n-                                        if (data_pointers) {\n-                                                prev_fid = *(uint64_t *) data_pointers[0];\n-                                                prev_mid = *(uint64_t *) data_pointers[1];\n-                                                prev_instance = *(uint32_t *) data_pointers[2];\n-                                                talloc_free(data_pointers);\n-                                        }\n-                                        else {\n-                                                prev_fid = -1;\n-                                                prev_mid = -1;\n-                                                prev_instance = -1;\n-                                        }\n-\n-                                        table->prop_count = saved_prop_count;\n-                                        table->properties = saved_properties;\n-                                        talloc_free(previous_row_properties);\n-\t\t\t\t\tmapistore_table_set_columns(emsmdbp_ctx->mstore_ctx, contextID, handle_object->backend_object, table->prop_count, (enum MAPITAGS *) table->properties);\n-                                }\n-                                else {\n-                                        prev_fid = 0;\n-                                        prev_mid = 0;\n-                                        prev_instance = 0;\n-                                }\n-\n-                                table_row = talloc_zero(mem_ctx, DATA_BLOB);\n-                                data_pointers = emsmdbp_object_table_get_row_props(mem_ctx, emsmdbp_ctx, handle_object,\n-                                                                                   notification->parameters.table_parameters.row_id, MAPISTORE_PREFILTERED_QUERY,\n-                                                                                   &retvals);\n-\t\t\t\tif (data_pointers) {\n-\t\t\t\t\temsmdbp_fill_table_row_blob(mem_ctx, emsmdbp_ctx, table_row, table->prop_count, (enum MAPITAGS *) table->properties, data_pointers, retvals);\n-\t\t\t\t\ttalloc_free(data_pointers);\n-\t\t\t\t\ttalloc_free(retvals);\n-\t\t\t\t}\n-\t\t\t\telse {\n-\t\t\t\t\tsuccess = false;\n-\t\t\t\t\tOC_DEBUG(5, \"no data returned for row, notification ignored\\n\");\n-\t\t\t\t}\n-                        }\n-\n-                        /* FIXME: for some reason, TABLE_ROW_MODIFIED and TABLE_ROW_DELETED do not work... */\n-                        reply->NotificationData.SearchTableChange.TableEvent = TABLE_CHANGED;\n-                        switch (notification->event) {\n-                        case MAPISTORE_OBJECT_CREATED:\n-                        /* case MAPISTORE_OBJECT_MODIFIED: */\n-                                reply->NotificationData.SearchTableChange.TableEvent = (notification->event == MAPISTORE_OBJECT_CREATED ? TABLE_ROW_ADDED : TABLE_ROW_MODIFIED);\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.FID = notification->parameters.table_parameters.folder_id;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.MID = notification->parameters.table_parameters.object_id;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.Instance = notification->parameters.table_parameters.instance_id;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.InsertAfterFID = prev_fid;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.InsertAfterMID = prev_mid;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.InsertAfterInstance = prev_instance;\n-                                reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowAddedNotification.Columns = *table_row;\n-                                break;\n-                        /* case MAPISTORE_OBJECT_DELETED: */\n-                        /*         reply->NotificationData.SearchTableChange.TableEvent = TABLE_ROW_DELETED; */\n-                        /*         reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowDeletedNotification.FID = notification->parameters.table_parameters.folder_id; */\n-                        /*         reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowDeletedNotification.MID = notification->parameters.table_parameters.object_id; */\n-                        /*         reply->NotificationData.SearchTableChange.ContentsTableChangeUnion.ContentsRowDeletedNotification.Instance = notification->parameters.table_parameters.instance_id; */\n-                        /*         break; */\n-                        /* default: */\n-                        /*         reply->NotificationType = fnevCriticalError; */\n-                        /*         OC_DEBUG(5, (\"unknown value for notification event: %d\\n\", notification->event)); */\n-                        /*         goto end; */\n-\t\t\tcase MAPISTORE_OBJECT_MODIFIED:\n-\t\t\tcase MAPISTORE_OBJECT_DELETED:\n-\t\t\tcase MAPISTORE_OBJECT_COPIED:\n-\t\t\tcase MAPISTORE_OBJECT_MOVED:\n-\t\t\tcase MAPISTORE_OBJECT_NEWMAIL:\n-\t\t\t\tbreak;\n-                        }\n-                }\n-        }\n-        else {\n-                switch (notification->event) {\n-\t\tcase MAPISTORE_OBJECT_NEWMAIL:\n-\t\t\treply->NotificationType |= fnevNewMail;\n-\t\t\tbreak;\n-                case MAPISTORE_OBJECT_CREATED:\n-                        reply->NotificationType |= fnevObjectCreated;\n-                        break;\n-                case MAPISTORE_OBJECT_DELETED:\n-                        reply->NotificationType |= fnevObjectDeleted;\n-                        break;\n-                case MAPISTORE_OBJECT_MODIFIED:\n-                        reply->NotificationType |= fnevObjectModified;\n-                        break;\n-\t\tcase MAPISTORE_OBJECT_COPIED:\n-\t\t        reply->NotificationType |= fnevObjectCopied;\n-\t\t\tbreak;\n-\t\tcase MAPISTORE_OBJECT_MOVED:\n-\t\t        reply->NotificationType |= fnevObjectMoved;\n-\t\t\tbreak;\n-                default:\n-                        reply->NotificationType = fnevCriticalError;\n-                        OC_DEBUG(5, \"unknown value for notification event: %d\\n\", notification->event);\n-                        goto end;\n-                }\n-                if (notification->object_type == MAPISTORE_MESSAGE) {\n-                        switch (notification->event) {\n-\t\t\tcase MAPISTORE_OBJECT_NEWMAIL:\n-\t\t\t\treply->NotificationData.NewMailNotification.FID = notification->parameters.object_parameters.folder_id;\n-\t\t\t\treply->NotificationData.NewMailNotification.MID = notification->parameters.object_parameters.object_id;\n-\t\t\t\t/* Hack for now */\n-\t\t\t\treply->NotificationData.NewMailNotification.MessageFlags = 0x4;\n-\t\t\t\treply->NotificationData.NewMailNotification.UnicodeFlag = true;\n-\t\t\t\treply->NotificationData.NewMailNotification.MessageClass.lpszW = \"IPF.Note\";\n-\t\t\t\tbreak;\n-                        case MAPISTORE_OBJECT_CREATED:\n-                                reply->NotificationData.MessageCreatedNotification.FID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.MessageCreatedNotification.MID = notification->parameters.object_parameters.object_id;\n-                                reply->NotificationData.MessageCreatedNotification.TagCount = notification->parameters.object_parameters.tag_count;\n-                                if (notification->parameters.object_parameters.tag_count\n-                                    && notification->parameters.object_parameters.tag_count != 0xffff) {\n-                                        reply->NotificationData.MessageCreatedNotification.NotificationTags.Tags = talloc_memdup(mem_ctx, notification->parameters.object_parameters.tags, notification->parameters.object_parameters.tag_count * sizeof(enum MAPITAGS));\n-                                }\n-                                else {\n-                                        reply->NotificationData.MessageCreatedNotification.NotificationTags.Tags = NULL;\n-                                }\n-                                break;\n-                        case MAPISTORE_OBJECT_MODIFIED:\n-                                reply->NotificationData.MessageModifiedNotification.FID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.MessageModifiedNotification.MID = notification->parameters.object_parameters.object_id;\n-                                reply->NotificationData.MessageModifiedNotification.TagCount = notification->parameters.object_parameters.tag_count;\n-                                if (notification->parameters.object_parameters.tag_count\n-                                    && notification->parameters.object_parameters.tag_count != 0xffff) {\n-                                        reply->NotificationData.MessageModifiedNotification.NotificationTags.Tags = talloc_memdup(mem_ctx, notification->parameters.object_parameters.tags, notification->parameters.object_parameters.tag_count * sizeof(enum MAPITAGS));\n-                                }\n-                                else {\n-                                        reply->NotificationData.MessageModifiedNotification.NotificationTags.Tags = NULL;\n-                                }\n-                                break;\n-\t\t\tcase MAPISTORE_OBJECT_COPIED:\n-\t\t\tcase MAPISTORE_OBJECT_MOVED:\n-\t\t\t        reply->NotificationData.MessageMoveNotification.FID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.MessageMoveNotification.MID = notification->parameters.object_parameters.object_id;\n-\t\t\t\treply->NotificationData.MessageMoveNotification.OldFID = notification->parameters.object_parameters.old_folder_id;\n-                                reply->NotificationData.MessageMoveNotification.OldMID = notification->parameters.object_parameters.old_object_id;\n-\t\t\t\tbreak;\n-\t\t\t\t\n-                        default: /* MAPISTORE_OBJECT_DELETED */\n-                                reply->NotificationData.MessageDeletedNotification.FID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.MessageDeletedNotification.MID = notification->parameters.object_parameters.object_id;\n-                        }\n-                }\n-                else { /* MAPISTORE_FOLDER */\n-                        switch (notification->event) {\n-\t\t\tcase MAPISTORE_OBJECT_NEWMAIL:\n-\t\t\t\treply->NotificationData.NewMailNotification.FID = notification->parameters.object_parameters.folder_id;\n-\t\t\t\treply->NotificationData.NewMailNotification.MID = notification->parameters.object_parameters.object_id;\n-\t\t\t\t/* Hack for now */\n-\t\t\t\treply->NotificationData.NewMailNotification.MessageFlags = 0x4;\n-\t\t\t\treply->NotificationData.NewMailNotification.UnicodeFlag = true;\n-\t\t\t\treply->NotificationData.NewMailNotification.MessageClass.lpszW = \"IPF.Note\";\n-\t\t\t\tbreak;\n-                        case MAPISTORE_OBJECT_CREATED:\n-                                reply->NotificationData.FolderCreatedNotification.ParentFID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.FolderCreatedNotification.FID = notification->parameters.object_parameters.object_id;\n-                                reply->NotificationData.FolderCreatedNotification.TagCount = notification->parameters.object_parameters.tag_count;\n-                                if (notification->parameters.object_parameters.tag_count\n-                                    && notification->parameters.object_parameters.tag_count != 0xffff) {\n-                                        reply->NotificationData.FolderCreatedNotification.NotificationTags.Tags = talloc_memdup(mem_ctx, notification->parameters.object_parameters.tags, notification->parameters.object_parameters.tag_count * sizeof(enum MAPITAGS));\n-                                }\n-                                else {\n-                                        reply->NotificationData.FolderCreatedNotification.NotificationTags.Tags = NULL;\n-                                }\n-                                break;\n-                        case MAPISTORE_OBJECT_MODIFIED:\n-                                reply->NotificationData.FolderModifiedNotification_10.FID = notification->parameters.object_parameters.object_id;\n-                                reply->NotificationData.FolderModifiedNotification_10.TagCount = notification->parameters.object_parameters.tag_count;\n-                                if (notification->parameters.object_parameters.tag_count\n-                                    && notification->parameters.object_parameters.tag_count != 0xffff) {\n-                                        reply->NotificationData.FolderModifiedNotification_10.NotificationTags.Tags = talloc_memdup(mem_ctx, notification->parameters.object_parameters.tags, notification->parameters.object_parameters.tag_count * sizeof(enum MAPITAGS));\n-                                }\n-                                else {\n-                                        reply->NotificationData.FolderModifiedNotification_10.NotificationTags.Tags = NULL;\n-                                }\n-\n-                                if (notification->parameters.object_parameters.new_message_count) {\n-                                        reply->NotificationData.FolderModifiedNotification_1010.TotalMessageCount = notification->parameters.object_parameters.message_count;\n-                                }\n-\n-                                break;\n-                        default: /* MAPISTORE_OBJECT_DELETED */\n-                                reply->NotificationData.FolderDeletedNotification.ParentFID = notification->parameters.object_parameters.folder_id;\n-                                reply->NotificationData.FolderDeletedNotification.FID = notification->parameters.object_parameters.object_id;\n-                        }\n-                }\n-        }\n-\n-end:\n-\t*sizep += libmapiserver_RopNotify_size(mapi_repl);\n-\n-\treturn success;\n-}\n-\n static struct mapi_response *EcDoRpc_process_transaction(TALLOC_CTX *mem_ctx, \n \t\t\t\t\t\t\t struct emsmdbp_context *emsmdbp_ctx,\n-\t\t\t\t\t\t\t struct mapi_request *mapi_request)\n+\t\t\t\t\t\t\t struct mapi_request *mapi_request,\n+\t\t\t\t\t\t\t struct GUID uuid)","path":"mapiproxy/servers/default/emsmdb/dcesrv_exchange_emsmdb.c","position":375,"original_position":375,"commit_id":"585e4f38778fdff64141715feb557f148e03f7aa","original_commit_id":"d958156e9092bb604d4245b0a6e1c173cb890e78","user":{"login":"jkerihuel","id":3603061,"avatar_url":"https://avatars.githubusercontent.com/u/3603061?v=3","gravatar_id":"","url":"https://api.github.com/users/jkerihuel","html_url":"https://github.com/jkerihuel","followers_url":"https://api.github.com/users/jkerihuel/followers","following_url":"https://api.github.com/users/jkerihuel/following{/other_user}","gists_url":"https://api.github.com/users/jkerihuel/gists{/gist_id}","starred_url":"https://api.github.com/users/jkerihuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkerihuel/subscriptions","organizations_url":"https://api.github.com/users/jkerihuel/orgs","repos_url":"https://api.github.com/users/jkerihuel/repos","events_url":"https://api.github.com/users/jkerihuel/events{/privacy}","received_events_url":"https://api.github.com/users/jkerihuel/received_events","type":"User","site_admin":false},"body":"correct. good catch!","created_at":"2015-04-21T10:50:21Z","updated_at":"2015-04-21T10:50:21Z","html_url":"https://github.com/openchange/openchange/pull/282#discussion_r28767383","pull_request_url":"https://api.github.com/repos/openchange/openchange/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments/28767383"},"html":{"href":"https://github.com/openchange/openchange/pull/282#discussion_r28767383"},"pull_request":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/openchange/openchange/pulls/282","id":33437546,"html_url":"https://github.com/openchange/openchange/pull/282","diff_url":"https://github.com/openchange/openchange/pull/282.diff","patch_url":"https://github.com/openchange/openchange/pull/282.patch","issue_url":"https://api.github.com/repos/openchange/openchange/issues/282","number":282,"state":"open","locked":false,"title":"[oxcnotif] Add asynchronous notification framework","user":{"login":"jkerihuel","id":3603061,"avatar_url":"https://avatars.githubusercontent.com/u/3603061?v=3","gravatar_id":"","url":"https://api.github.com/users/jkerihuel","html_url":"https://github.com/jkerihuel","followers_url":"https://api.github.com/users/jkerihuel/followers","following_url":"https://api.github.com/users/jkerihuel/following{/other_user}","gists_url":"https://api.github.com/users/jkerihuel/gists{/gist_id}","starred_url":"https://api.github.com/users/jkerihuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkerihuel/subscriptions","organizations_url":"https://api.github.com/users/jkerihuel/orgs","repos_url":"https://api.github.com/users/jkerihuel/repos","events_url":"https://api.github.com/users/jkerihuel/events{/privacy}","received_events_url":"https://api.github.com/users/jkerihuel/received_events","type":"User","site_admin":false},"body":"This pull request provides the full asynchronous notification framework and removes references to all the existing and deprecated notification code. All new additions to mapistore API (session, resolver, subscription, deliver) are unit tested. The PR also includes an updated dovecot plugin for 2.2 series.","created_at":"2015-04-16T10:30:01Z","updated_at":"2015-04-21T10:50:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43a3fdc89762edf7cd6903d1c914b3d5ec218d7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openchange/openchange/pulls/282/commits","review_comments_url":"https://api.github.com/repos/openchange/openchange/pulls/282/comments","review_comment_url":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openchange/openchange/issues/282/comments","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/585e4f38778fdff64141715feb557f148e03f7aa","head":{"label":"openchange:jkerihuel/asynchronous-notifications","ref":"jkerihuel/asynchronous-notifications","sha":"585e4f38778fdff64141715feb557f148e03f7aa","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-04-20T10:37:21Z","pushed_at":"2015-04-21T09:49:10Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":26583,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":25,"forks":28,"open_issues":25,"watchers":52,"default_branch":"master"}},"base":{"label":"openchange:master","ref":"master","sha":"2bf1c87c25f8ff0ad78bdf571d7ee406d59e6391","user":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"repo":{"id":12688822,"name":"openchange","full_name":"openchange/openchange","owner":{"login":"openchange","id":5413705,"avatar_url":"https://avatars.githubusercontent.com/u/5413705?v=3","gravatar_id":"","url":"https://api.github.com/users/openchange","html_url":"https://github.com/openchange","followers_url":"https://api.github.com/users/openchange/followers","following_url":"https://api.github.com/users/openchange/following{/other_user}","gists_url":"https://api.github.com/users/openchange/gists{/gist_id}","starred_url":"https://api.github.com/users/openchange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openchange/subscriptions","organizations_url":"https://api.github.com/users/openchange/orgs","repos_url":"https://api.github.com/users/openchange/repos","events_url":"https://api.github.com/users/openchange/events{/privacy}","received_events_url":"https://api.github.com/users/openchange/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openchange/openchange","description":"OpenChange Project","fork":false,"url":"https://api.github.com/repos/openchange/openchange","forks_url":"https://api.github.com/repos/openchange/openchange/forks","keys_url":"https://api.github.com/repos/openchange/openchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openchange/openchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openchange/openchange/teams","hooks_url":"https://api.github.com/repos/openchange/openchange/hooks","issue_events_url":"https://api.github.com/repos/openchange/openchange/issues/events{/number}","events_url":"https://api.github.com/repos/openchange/openchange/events","assignees_url":"https://api.github.com/repos/openchange/openchange/assignees{/user}","branches_url":"https://api.github.com/repos/openchange/openchange/branches{/branch}","tags_url":"https://api.github.com/repos/openchange/openchange/tags","blobs_url":"https://api.github.com/repos/openchange/openchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openchange/openchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openchange/openchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/openchange/openchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openchange/openchange/statuses/{sha}","languages_url":"https://api.github.com/repos/openchange/openchange/languages","stargazers_url":"https://api.github.com/repos/openchange/openchange/stargazers","contributors_url":"https://api.github.com/repos/openchange/openchange/contributors","subscribers_url":"https://api.github.com/repos/openchange/openchange/subscribers","subscription_url":"https://api.github.com/repos/openchange/openchange/subscription","commits_url":"https://api.github.com/repos/openchange/openchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/openchange/openchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/openchange/openchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/openchange/openchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/openchange/openchange/contents/{+path}","compare_url":"https://api.github.com/repos/openchange/openchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openchange/openchange/merges","archive_url":"https://api.github.com/repos/openchange/openchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openchange/openchange/downloads","issues_url":"https://api.github.com/repos/openchange/openchange/issues{/number}","pulls_url":"https://api.github.com/repos/openchange/openchange/pulls{/number}","milestones_url":"https://api.github.com/repos/openchange/openchange/milestones{/number}","notifications_url":"https://api.github.com/repos/openchange/openchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openchange/openchange/labels{/name}","releases_url":"https://api.github.com/repos/openchange/openchange/releases{/id}","created_at":"2013-09-08T22:39:00Z","updated_at":"2015-04-20T10:37:21Z","pushed_at":"2015-04-21T09:49:10Z","git_url":"git://github.com/openchange/openchange.git","ssh_url":"git@github.com:openchange/openchange.git","clone_url":"https://github.com/openchange/openchange.git","svn_url":"https://github.com/openchange/openchange","homepage":null,"size":26583,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":25,"forks":28,"open_issues":25,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282"},"html":{"href":"https://github.com/openchange/openchange/pull/282"},"issue":{"href":"https://api.github.com/repos/openchange/openchange/issues/282"},"comments":{"href":"https://api.github.com/repos/openchange/openchange/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/openchange/openchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openchange/openchange/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/openchange/openchange/statuses/585e4f38778fdff64141715feb557f148e03f7aa"}}}}