{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/1302","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/1302/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1302/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/1302/events","html_url":"https://github.com/dotnet/corefx/pull/1302","id":65540243,"number":1302,"title":"Lots of FileSystem test fixes for Unix","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-not-required","name":"cla-not-required","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-31T20:38:07Z","updated_at":"2015-04-02T13:23:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1302","html_url":"https://github.com/dotnet/corefx/pull/1302","diff_url":"https://github.com/dotnet/corefx/pull/1302.diff","patch_url":"https://github.com/dotnet/corefx/pull/1302.patch"},"body":"The FileSystem tests are a mess, especially on Unix.  Before the File/Directory/etc. tests got checked in, the FileSystem tests (which then were really only for FileStream and were fairly clean) could run on Unix, with 25 of the 360 tests failing due primarily to lack of support for FileShare options.  Now, with ~575 tests, when run on Unix more than 300 fail, runtime assertions occur in multiple places (due to globalization issues), and worst, all of the files in the working directory end up getting deleted.\r\n\r\nThis commit has a first set of fixes, primarily involving ensuring that paths are specified appropriately, with hundreds of changes to ensure that the right path separator is used, that particular roots aren't assumed, etc.  After this commit, on Unix we're down from > 300 failures to 114 failures, and the suite is able to finish running without deleting the working directory.\r\n\r\nThere's still more work to be done after this, but I wanted to get these fixes committed before continuing on."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/88895053","html_url":"https://github.com/dotnet/corefx/pull/1302#issuecomment-88895053","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1302","id":88895053,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2015-04-02T13:23:25Z","updated_at":"2015-04-02T13:23:25Z","body":"Thanks, Jeremy."}}