{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26100609","id":26100609,"diff_hunk":"@@ -80,4 +80,9 @@ class helloworld {\n     assert_match(/^Generated, 1 => 10, 2 => 20, 3 => 30$/, stdout, \"Generated the wrong content\")\n   end\n \n+  teardown do","path":"acceptance/tests/loader/func4x_loadable_from_modules.rb","position":4,"original_position":4,"commit_id":"d04d6214c21bbce20bc7cc687837b32a73aed716","original_commit_id":"d04d6214c21bbce20bc7cc687837b32a73aed716","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"If the test raises an exception after running `puppet apply` but before we get to the teardown, then the permissions won't be reset correctly. We could register the teardown earlier, but I don't like letting the test \"corrupt\" the permissions and then trying to patch them up. I'd rather redo e6e0ae02dcc41746d8196b4a6e0e11248af51006 so the workaround is specific to PE:\r\n\r\n```\r\npuppetconf = get_test_file_path(agent, 'puppet.conf')\r\nif agent.is_pe?\r\n  user = agent.puppet['user']\r\n  group = agent.puppet['group']\r\n  on agent, puppet(\"config\", \"set\", \"user\", user, \"--section\", \"main\", \"--config\", puppetconf)\r\n  on agent, puppet(\"config\", \"set\", \"group\", group, \"--section\", \"main\", \"--config\", puppetconf)\r\nend\r\n```\r\n\r\nWe could also just revert e6e0ae02dcc41746d8196b4a6e0e11248af51006 since PE4 will be using AIO agents and there won't be a `puppet` vs `pe-puppet` issue.","created_at":"2015-03-10T06:07:07Z","updated_at":"2015-03-10T06:07:07Z","html_url":"https://github.com/puppetlabs/puppet/pull/3696#discussion_r26100609","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26100609"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3696#discussion_r26100609"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696","id":30822655,"html_url":"https://github.com/puppetlabs/puppet/pull/3696","diff_url":"https://github.com/puppetlabs/puppet/pull/3696.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3696.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3696","number":3696,"state":"open","locked":false,"title":"(PUP-3997) Run puppet apply to reset logdir owner","user":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"body":"This commit adds a teardown step in the\r\ntests/loader/func4x_loadable_from_modules.rb acceptance test to\r\nrun puppet apply without a puppet.conf specified in order to\r\nrestore the ownership of the logdir.\r\n\r\nPrior to this commit, the test left ownership of the logdir set to\r\nthe user and group specified in the test, which may not be the\r\nproper standard ownership.","created_at":"2015-03-10T04:51:15Z","updated_at":"2015-03-10T06:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc47ce86e9ebba1bfcbee3bec848a35e7c36cc39","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3696/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/d04d6214c21bbce20bc7cc687837b32a73aed716","head":{"label":"johnduarte:pup-3997-patch-func4x","ref":"pup-3997-patch-func4x","sha":"d04d6214c21bbce20bc7cc687837b32a73aed716","user":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"repo":{"id":10199100,"name":"puppet","full_name":"johnduarte/puppet","owner":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnduarte/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/johnduarte/puppet","forks_url":"https://api.github.com/repos/johnduarte/puppet/forks","keys_url":"https://api.github.com/repos/johnduarte/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnduarte/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnduarte/puppet/teams","hooks_url":"https://api.github.com/repos/johnduarte/puppet/hooks","issue_events_url":"https://api.github.com/repos/johnduarte/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/johnduarte/puppet/events","assignees_url":"https://api.github.com/repos/johnduarte/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/johnduarte/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/johnduarte/puppet/tags","blobs_url":"https://api.github.com/repos/johnduarte/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnduarte/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnduarte/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnduarte/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnduarte/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/johnduarte/puppet/languages","stargazers_url":"https://api.github.com/repos/johnduarte/puppet/stargazers","contributors_url":"https://api.github.com/repos/johnduarte/puppet/contributors","subscribers_url":"https://api.github.com/repos/johnduarte/puppet/subscribers","subscription_url":"https://api.github.com/repos/johnduarte/puppet/subscription","commits_url":"https://api.github.com/repos/johnduarte/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnduarte/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnduarte/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnduarte/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnduarte/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/johnduarte/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnduarte/puppet/merges","archive_url":"https://api.github.com/repos/johnduarte/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnduarte/puppet/downloads","issues_url":"https://api.github.com/repos/johnduarte/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/johnduarte/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/johnduarte/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/johnduarte/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnduarte/puppet/labels{/name}","releases_url":"https://api.github.com/repos/johnduarte/puppet/releases{/id}","created_at":"2013-05-21T15:31:44Z","updated_at":"2015-03-05T04:43:13Z","pushed_at":"2015-03-10T04:50:03Z","git_url":"git://github.com/johnduarte/puppet.git","ssh_url":"git@github.com:johnduarte/puppet.git","clone_url":"https://github.com/johnduarte/puppet.git","svn_url":"https://github.com/johnduarte/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":46980,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6d8b65e4d4a246f8101396f68ba8ad9cbb200bf5","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-03-10T05:23:49Z","pushed_at":"2015-03-09T22:56:14Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":109710,"stargazers_count":3036,"watchers_count":3036,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1292,"mirror_url":null,"open_issues_count":33,"forks":1292,"open_issues":33,"watchers":3036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3696"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3696"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3696/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3696/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/d04d6214c21bbce20bc7cc687837b32a73aed716"}}}}