{"action":"created","issue":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/4010","labels_url":"https://api.github.com/repos/influxdb/influxdb/issues/4010/labels{/name}","comments_url":"https://api.github.com/repos/influxdb/influxdb/issues/4010/comments","events_url":"https://api.github.com/repos/influxdb/influxdb/issues/4010/events","html_url":"https://github.com/influxdb/influxdb/pull/4010","id":104995561,"number":4010,"title":"remove pidofproc function","user":{"login":"daachi","id":2219358,"avatar_url":"https://avatars.githubusercontent.com/u/2219358?v=3","gravatar_id":"","url":"https://api.github.com/users/daachi","html_url":"https://github.com/daachi","followers_url":"https://api.github.com/users/daachi/followers","following_url":"https://api.github.com/users/daachi/following{/other_user}","gists_url":"https://api.github.com/users/daachi/gists{/gist_id}","starred_url":"https://api.github.com/users/daachi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daachi/subscriptions","organizations_url":"https://api.github.com/users/daachi/orgs","repos_url":"https://api.github.com/users/daachi/repos","events_url":"https://api.github.com/users/daachi/events{/privacy}","received_events_url":"https://api.github.com/users/daachi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-05T01:46:24Z","updated_at":"2015-09-05T04:06:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/influxdb/influxdb/pulls/4010","html_url":"https://github.com/influxdb/influxdb/pull/4010","diff_url":"https://github.com/influxdb/influxdb/pull/4010.diff","patch_url":"https://github.com/influxdb/influxdb/pull/4010.patch"},"body":"The pidofproc function should not be redefined here because the same function from the LSB works correctly. Using pgrep will not work correctly if you have a file named similarly to the \"daemon-name\" open (i.e. \"/etc/opt/influxdb/influxdb.conf\").\r\n\r\nThis is with 0.9.2 installed on a base 64-Bit Debian Wheezy system, using the `.deb` from InfluxDB.com.\r\n\r\nIt's easy to recreate this situation by simply opening the configuration file (i.e. `sudo vi /etc/opt/influxdb/influxdb.conf`), and running `/etc/init.d/influxdb status`. With the configuration file open, `pgrep -f /opt/influxdb/influxd` picks up multiple pids, which causes the init script to report incorrectly that the influxd process is not running (e.g. `influxd Process is not running [ FAILED ]`)."},"comment":{"url":"https://api.github.com/repos/influxdb/influxdb/issues/comments/137904005","html_url":"https://github.com/influxdb/influxdb/pull/4010#issuecomment-137904005","issue_url":"https://api.github.com/repos/influxdb/influxdb/issues/4010","id":137904005,"user":{"login":"otoolep","id":536312,"avatar_url":"https://avatars.githubusercontent.com/u/536312?v=3","gravatar_id":"","url":"https://api.github.com/users/otoolep","html_url":"https://github.com/otoolep","followers_url":"https://api.github.com/users/otoolep/followers","following_url":"https://api.github.com/users/otoolep/following{/other_user}","gists_url":"https://api.github.com/users/otoolep/gists{/gist_id}","starred_url":"https://api.github.com/users/otoolep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otoolep/subscriptions","organizations_url":"https://api.github.com/users/otoolep/orgs","repos_url":"https://api.github.com/users/otoolep/repos","events_url":"https://api.github.com/users/otoolep/events{/privacy}","received_events_url":"https://api.github.com/users/otoolep/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T04:06:14Z","updated_at":"2015-09-05T04:06:14Z","body":"Thanks @daachi -- I too noticed this in the script and was wondering why it was there since it is defined elsewhere as you say, but left it for now.\r\n\r\nMy concern is what will happen on distros that do not have LSB. Is that a concern?"}}