{"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/30080818","id":30080818,"diff_hunk":"@@ -142,27 +162,113 @@ void onBufferFinished(StateContext context) throws IOException {\n                 flush( context );\n             }\n \n-            private void flush(StateContext context) throws IOException {\n-                if ( null != context.characters && context.currentIndex - context.lastStateChange > 0 ) {\n-                    context.writer.write(\n-                        context.characters,\n-                        context.lastStateChange,\n-                        context.currentIndex - context.lastStateChange\n-                    );\n+        },\n \n-                    if ( DEBUG ) {\n-                        System.out.print(\n-                            new String(\n-                                java.util.Arrays.copyOfRange(\n-                                    context.characters,\n-                                    context.lastStateChange,\n-                                    context.currentIndex\n-                                )\n-                            )\n-                        );\n-                    }\n+        /**\n+         * In a String definition, Between un-escaped quotes \" \"\n+         */\n+        IN_TEXT_IN_STRING {","path":"processor/src/main/java/org/mapstruct/ap/writer/IndentationCorrectingWriter.java","position":85,"original_position":85,"commit_id":"7e77cf69c110128fcae5117cb2c6c85683a59d53","original_commit_id":"7e77cf69c110128fcae5117cb2c6c85683a59d53","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Maybe just `IN_STRING`?","created_at":"2015-05-11T20:55:36Z","updated_at":"2015-05-11T20:55:36Z","html_url":"https://github.com/mapstruct/mapstruct/pull/545#discussion_r30080818","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/30080818"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/545#discussion_r30080818"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545"}}},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545","id":35166667,"html_url":"https://github.com/mapstruct/mapstruct/pull/545","diff_url":"https://github.com/mapstruct/mapstruct/pull/545.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/545.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/545","number":545,"state":"open","locked":false,"title":"515 Negative array index in indentation writer","user":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"body":"In expressions (and presumably also in contstants) its possible to create Strings definitions in the generated code. Indentation should therefore not be increased / decreased when braces (curly or round) are encountered inside a String definition (so between \" \"). \r\n\r\nDecreasing due to an unbalanced round brace inside a String definition led to the problem above.\r\n\r\nLikewise, escaped '\"' should be ignored.\r\n\r\nThe enum-state pattern (one of my favourites :+1: ) has been updated with a couple of extra states to handle this. \r\n ","created_at":"2015-05-11T20:36:39Z","updated_at":"2015-05-11T20:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22c92211f98956ccefe8e9a2cd7d83e9d7cd0286","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/545/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/7e77cf69c110128fcae5117cb2c6c85683a59d53","head":{"label":"sjaakd:515","ref":"515","sha":"7e77cf69c110128fcae5117cb2c6c85683a59d53","user":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"repo":{"id":15548682,"name":"mapstruct","full_name":"sjaakd/mapstruct","owner":{"login":"sjaakd","id":6173283,"avatar_url":"https://avatars.githubusercontent.com/u/6173283?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjaakd/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/sjaakd/mapstruct","forks_url":"https://api.github.com/repos/sjaakd/mapstruct/forks","keys_url":"https://api.github.com/repos/sjaakd/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjaakd/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjaakd/mapstruct/teams","hooks_url":"https://api.github.com/repos/sjaakd/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/sjaakd/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/sjaakd/mapstruct/events","assignees_url":"https://api.github.com/repos/sjaakd/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/sjaakd/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/sjaakd/mapstruct/tags","blobs_url":"https://api.github.com/repos/sjaakd/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjaakd/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjaakd/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjaakd/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjaakd/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/sjaakd/mapstruct/languages","stargazers_url":"https://api.github.com/repos/sjaakd/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/sjaakd/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/sjaakd/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/sjaakd/mapstruct/subscription","commits_url":"https://api.github.com/repos/sjaakd/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjaakd/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjaakd/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjaakd/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjaakd/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/sjaakd/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjaakd/mapstruct/merges","archive_url":"https://api.github.com/repos/sjaakd/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjaakd/mapstruct/downloads","issues_url":"https://api.github.com/repos/sjaakd/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/sjaakd/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/sjaakd/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/sjaakd/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjaakd/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/sjaakd/mapstruct/releases{/id}","created_at":"2013-12-31T11:17:00Z","updated_at":"2015-05-08T20:21:16Z","pushed_at":"2015-05-11T20:32:01Z","git_url":"git://github.com/sjaakd/mapstruct.git","ssh_url":"git@github.com:sjaakd/mapstruct.git","clone_url":"https://github.com/sjaakd/mapstruct.git","svn_url":"https://github.com/sjaakd/mapstruct","homepage":"http://mapstruct.org/","size":4271,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"2ece25a086e2f97e6f2243aaeed34798f8fc32a7","user":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"name":"mapstruct","full_name":"mapstruct/mapstruct","owner":{"login":"mapstruct","id":4086779,"avatar_url":"https://avatars.githubusercontent.com/u/4086779?v=3","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","created_at":"2012-05-28T12:42:42Z","updated_at":"2015-05-08T20:26:39Z","pushed_at":"2015-05-11T20:36:41Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":7674,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":80,"forks":34,"open_issues":80,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/545"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/545"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/545/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/545/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/7e77cf69c110128fcae5117cb2c6c85683a59d53"}}}}