{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95","id":12832743,"html_url":"https://github.com/bouchard/thumbs_up/pull/95","diff_url":"https://github.com/bouchard/thumbs_up/pull/95.diff","patch_url":"https://github.com/bouchard/thumbs_up/pull/95.patch","issue_url":"https://api.github.com/repos/bouchard/thumbs_up/issues/95","number":95,"state":"closed","locked":false,"title":"ignore text type columns from column_names_for_tally","user":{"login":"fddayan","id":188936,"avatar_url":"https://avatars.githubusercontent.com/u/188936?v=3","gravatar_id":"","url":"https://api.github.com/users/fddayan","html_url":"https://github.com/fddayan","followers_url":"https://api.github.com/users/fddayan/followers","following_url":"https://api.github.com/users/fddayan/following{/other_user}","gists_url":"https://api.github.com/users/fddayan/gists{/gist_id}","starred_url":"https://api.github.com/users/fddayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fddayan/subscriptions","organizations_url":"https://api.github.com/users/fddayan/orgs","repos_url":"https://api.github.com/users/fddayan/repos","events_url":"https://api.github.com/users/fddayan/events{/privacy}","received_events_url":"https://api.github.com/users/fddayan/received_events","type":"User","site_admin":false},"body":"I found a bug using `kaminari` if I have a `text` type column paginationhelper  does not work\r\n\r\nso for something like this does, `paginate` helper does not work\r\n\r\n    Model.plusminus_tally.page(0)    \r\n\r\n`column_names_for_tally`  includes all the columns that should be included in the group by\r\nI changed it to exclude columns with `text` type. \r\n\r\nit might or it might not be a good idea, I do not know why it fails or if it should be fixed in `kaminari`\r\n\r\n","created_at":"2014-02-23T15:28:39Z","updated_at":"2015-07-01T13:45:22Z","closed_at":"2015-07-01T13:45:22Z","merged_at":null,"merge_commit_sha":"480eee560ed1018939b438d39c3478dcabcf5f48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95/commits","review_comments_url":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95/comments","review_comment_url":"https://api.github.com/repos/bouchard/thumbs_up/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bouchard/thumbs_up/issues/95/comments","statuses_url":"https://api.github.com/repos/bouchard/thumbs_up/statuses/eb8c023bd9af6bcd10ec74133f0962998c07539c","head":{"label":"fddayan:master","ref":"master","sha":"eb8c023bd9af6bcd10ec74133f0962998c07539c","user":{"login":"fddayan","id":188936,"avatar_url":"https://avatars.githubusercontent.com/u/188936?v=3","gravatar_id":"","url":"https://api.github.com/users/fddayan","html_url":"https://github.com/fddayan","followers_url":"https://api.github.com/users/fddayan/followers","following_url":"https://api.github.com/users/fddayan/following{/other_user}","gists_url":"https://api.github.com/users/fddayan/gists{/gist_id}","starred_url":"https://api.github.com/users/fddayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fddayan/subscriptions","organizations_url":"https://api.github.com/users/fddayan/orgs","repos_url":"https://api.github.com/users/fddayan/repos","events_url":"https://api.github.com/users/fddayan/events{/privacy}","received_events_url":"https://api.github.com/users/fddayan/received_events","type":"User","site_admin":false},"repo":{"id":17110306,"name":"thumbs_up","full_name":"fddayan/thumbs_up","owner":{"login":"fddayan","id":188936,"avatar_url":"https://avatars.githubusercontent.com/u/188936?v=3","gravatar_id":"","url":"https://api.github.com/users/fddayan","html_url":"https://github.com/fddayan","followers_url":"https://api.github.com/users/fddayan/followers","following_url":"https://api.github.com/users/fddayan/following{/other_user}","gists_url":"https://api.github.com/users/fddayan/gists{/gist_id}","starred_url":"https://api.github.com/users/fddayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fddayan/subscriptions","organizations_url":"https://api.github.com/users/fddayan/orgs","repos_url":"https://api.github.com/users/fddayan/repos","events_url":"https://api.github.com/users/fddayan/events{/privacy}","received_events_url":"https://api.github.com/users/fddayan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fddayan/thumbs_up","description":"Dead-Simple Vote and Karma Management","fork":true,"url":"https://api.github.com/repos/fddayan/thumbs_up","forks_url":"https://api.github.com/repos/fddayan/thumbs_up/forks","keys_url":"https://api.github.com/repos/fddayan/thumbs_up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fddayan/thumbs_up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fddayan/thumbs_up/teams","hooks_url":"https://api.github.com/repos/fddayan/thumbs_up/hooks","issue_events_url":"https://api.github.com/repos/fddayan/thumbs_up/issues/events{/number}","events_url":"https://api.github.com/repos/fddayan/thumbs_up/events","assignees_url":"https://api.github.com/repos/fddayan/thumbs_up/assignees{/user}","branches_url":"https://api.github.com/repos/fddayan/thumbs_up/branches{/branch}","tags_url":"https://api.github.com/repos/fddayan/thumbs_up/tags","blobs_url":"https://api.github.com/repos/fddayan/thumbs_up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fddayan/thumbs_up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fddayan/thumbs_up/git/refs{/sha}","trees_url":"https://api.github.com/repos/fddayan/thumbs_up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fddayan/thumbs_up/statuses/{sha}","languages_url":"https://api.github.com/repos/fddayan/thumbs_up/languages","stargazers_url":"https://api.github.com/repos/fddayan/thumbs_up/stargazers","contributors_url":"https://api.github.com/repos/fddayan/thumbs_up/contributors","subscribers_url":"https://api.github.com/repos/fddayan/thumbs_up/subscribers","subscription_url":"https://api.github.com/repos/fddayan/thumbs_up/subscription","commits_url":"https://api.github.com/repos/fddayan/thumbs_up/commits{/sha}","git_commits_url":"https://api.github.com/repos/fddayan/thumbs_up/git/commits{/sha}","comments_url":"https://api.github.com/repos/fddayan/thumbs_up/comments{/number}","issue_comment_url":"https://api.github.com/repos/fddayan/thumbs_up/issues/comments{/number}","contents_url":"https://api.github.com/repos/fddayan/thumbs_up/contents/{+path}","compare_url":"https://api.github.com/repos/fddayan/thumbs_up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fddayan/thumbs_up/merges","archive_url":"https://api.github.com/repos/fddayan/thumbs_up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fddayan/thumbs_up/downloads","issues_url":"https://api.github.com/repos/fddayan/thumbs_up/issues{/number}","pulls_url":"https://api.github.com/repos/fddayan/thumbs_up/pulls{/number}","milestones_url":"https://api.github.com/repos/fddayan/thumbs_up/milestones{/number}","notifications_url":"https://api.github.com/repos/fddayan/thumbs_up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fddayan/thumbs_up/labels{/name}","releases_url":"https://api.github.com/repos/fddayan/thumbs_up/releases{/id}","created_at":"2014-02-23T15:20:36Z","updated_at":"2014-02-23T15:28:39Z","pushed_at":"2014-02-23T15:23:41Z","git_url":"git://github.com/fddayan/thumbs_up.git","ssh_url":"git@github.com:fddayan/thumbs_up.git","clone_url":"https://github.com/fddayan/thumbs_up.git","svn_url":"https://github.com/fddayan/thumbs_up","homepage":"","size":320,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bouchard:master","ref":"master","sha":"e7be17e31305180e2a9400e65ecde16911f732f2","user":{"login":"bouchard","id":4944,"avatar_url":"https://avatars.githubusercontent.com/u/4944?v=3","gravatar_id":"","url":"https://api.github.com/users/bouchard","html_url":"https://github.com/bouchard","followers_url":"https://api.github.com/users/bouchard/followers","following_url":"https://api.github.com/users/bouchard/following{/other_user}","gists_url":"https://api.github.com/users/bouchard/gists{/gist_id}","starred_url":"https://api.github.com/users/bouchard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bouchard/subscriptions","organizations_url":"https://api.github.com/users/bouchard/orgs","repos_url":"https://api.github.com/users/bouchard/repos","events_url":"https://api.github.com/users/bouchard/events{/privacy}","received_events_url":"https://api.github.com/users/bouchard/received_events","type":"User","site_admin":false},"repo":{"id":797554,"name":"thumbs_up","full_name":"bouchard/thumbs_up","owner":{"login":"bouchard","id":4944,"avatar_url":"https://avatars.githubusercontent.com/u/4944?v=3","gravatar_id":"","url":"https://api.github.com/users/bouchard","html_url":"https://github.com/bouchard","followers_url":"https://api.github.com/users/bouchard/followers","following_url":"https://api.github.com/users/bouchard/following{/other_user}","gists_url":"https://api.github.com/users/bouchard/gists{/gist_id}","starred_url":"https://api.github.com/users/bouchard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bouchard/subscriptions","organizations_url":"https://api.github.com/users/bouchard/orgs","repos_url":"https://api.github.com/users/bouchard/repos","events_url":"https://api.github.com/users/bouchard/events{/privacy}","received_events_url":"https://api.github.com/users/bouchard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bouchard/thumbs_up","description":"Dead-Simple Vote and Karma Management","fork":true,"url":"https://api.github.com/repos/bouchard/thumbs_up","forks_url":"https://api.github.com/repos/bouchard/thumbs_up/forks","keys_url":"https://api.github.com/repos/bouchard/thumbs_up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bouchard/thumbs_up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bouchard/thumbs_up/teams","hooks_url":"https://api.github.com/repos/bouchard/thumbs_up/hooks","issue_events_url":"https://api.github.com/repos/bouchard/thumbs_up/issues/events{/number}","events_url":"https://api.github.com/repos/bouchard/thumbs_up/events","assignees_url":"https://api.github.com/repos/bouchard/thumbs_up/assignees{/user}","branches_url":"https://api.github.com/repos/bouchard/thumbs_up/branches{/branch}","tags_url":"https://api.github.com/repos/bouchard/thumbs_up/tags","blobs_url":"https://api.github.com/repos/bouchard/thumbs_up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bouchard/thumbs_up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bouchard/thumbs_up/git/refs{/sha}","trees_url":"https://api.github.com/repos/bouchard/thumbs_up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bouchard/thumbs_up/statuses/{sha}","languages_url":"https://api.github.com/repos/bouchard/thumbs_up/languages","stargazers_url":"https://api.github.com/repos/bouchard/thumbs_up/stargazers","contributors_url":"https://api.github.com/repos/bouchard/thumbs_up/contributors","subscribers_url":"https://api.github.com/repos/bouchard/thumbs_up/subscribers","subscription_url":"https://api.github.com/repos/bouchard/thumbs_up/subscription","commits_url":"https://api.github.com/repos/bouchard/thumbs_up/commits{/sha}","git_commits_url":"https://api.github.com/repos/bouchard/thumbs_up/git/commits{/sha}","comments_url":"https://api.github.com/repos/bouchard/thumbs_up/comments{/number}","issue_comment_url":"https://api.github.com/repos/bouchard/thumbs_up/issues/comments{/number}","contents_url":"https://api.github.com/repos/bouchard/thumbs_up/contents/{+path}","compare_url":"https://api.github.com/repos/bouchard/thumbs_up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bouchard/thumbs_up/merges","archive_url":"https://api.github.com/repos/bouchard/thumbs_up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bouchard/thumbs_up/downloads","issues_url":"https://api.github.com/repos/bouchard/thumbs_up/issues{/number}","pulls_url":"https://api.github.com/repos/bouchard/thumbs_up/pulls{/number}","milestones_url":"https://api.github.com/repos/bouchard/thumbs_up/milestones{/number}","notifications_url":"https://api.github.com/repos/bouchard/thumbs_up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bouchard/thumbs_up/labels{/name}","releases_url":"https://api.github.com/repos/bouchard/thumbs_up/releases{/id}","created_at":"2010-07-26T03:11:45Z","updated_at":"2015-06-23T12:18:27Z","pushed_at":"2015-06-20T18:40:43Z","git_url":"git://github.com/bouchard/thumbs_up.git","ssh_url":"git@github.com:bouchard/thumbs_up.git","clone_url":"https://github.com/bouchard/thumbs_up.git","svn_url":"https://github.com/bouchard/thumbs_up","homepage":"","size":572,"stargazers_count":391,"watchers_count":391,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":11,"forks":70,"open_issues":11,"watchers":391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95"},"html":{"href":"https://github.com/bouchard/thumbs_up/pull/95"},"issue":{"href":"https://api.github.com/repos/bouchard/thumbs_up/issues/95"},"comments":{"href":"https://api.github.com/repos/bouchard/thumbs_up/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/bouchard/thumbs_up/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bouchard/thumbs_up/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/bouchard/thumbs_up/statuses/eb8c023bd9af6bcd10ec74133f0962998c07539c"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}