{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/22690685","id":22690685,"diff_hunk":"@@ -281,17 +284,19 @@ public DyingQueryRunner(CountDownLatch start, CountDownLatch stop)\n     @Override\n     public Sequence<Integer> run(Query<Integer> query, Map<String, Object> responseContext)\n     {\n-      hasStarted = true;\n-      start.countDown();\n-      if (Thread.interrupted()) {\n-        interrupted = true;\n-        stop.countDown();\n-        throw new QueryInterruptedException(\"I got killed\");\n+      synchronized (this) { // ensure hasStarted and interrupted are updated simultaneously\n+        hasStarted = true;\n+        start.countDown();\n+        if (Thread.interrupted()) {\n+          interrupted = true;\n+          stop.countDown();\n+          throw new QueryInterruptedException(\"I got killed\");\n+        }\n       }\n \n       // do a lot of work\n       try {\n-        Thread.sleep(500);\n+        Thread.sleep(5000);","path":"processing/src/test/java/io/druid/query/ChainedExecutionQueryRunnerTest.java","position":118,"original_position":118,"commit_id":"d5f4182de4535a3999bfbfc703530bf4731cea97","original_commit_id":"d5f4182de4535a3999bfbfc703530bf4731cea97","user":{"login":"druid-robot","id":10248528,"avatar_url":"https://avatars.githubusercontent.com/u/10248528?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-robot","html_url":"https://github.com/druid-robot","followers_url":"https://api.github.com/users/druid-robot/followers","following_url":"https://api.github.com/users/druid-robot/following{/other_user}","gists_url":"https://api.github.com/users/druid-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-robot/subscriptions","organizations_url":"https://api.github.com/users/druid-robot/orgs","repos_url":"https://api.github.com/users/druid-robot/repos","events_url":"https://api.github.com/users/druid-robot/events{/privacy}","received_events_url":"https://api.github.com/users/druid-robot/received_events","type":"User","site_admin":false},"body":"if the test passes, the sleep gets interrupted right away. 500ms could be too short if the build machine is too slow.","created_at":"2015-01-08T23:10:41Z","updated_at":"2015-01-08T23:10:41Z","html_url":"https://github.com/druid-io/druid/pull/1018#discussion_r22690685","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/1018","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/22690685"},"html":{"href":"https://github.com/druid-io/druid/pull/1018#discussion_r22690685"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1018"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/1018","id":26996470,"html_url":"https://github.com/druid-io/druid/pull/1018","diff_url":"https://github.com/druid-io/druid/pull/1018.diff","patch_url":"https://github.com/druid-io/druid/pull/1018.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/1018","number":1018,"state":"open","locked":false,"title":"new faster container builds in Travis-CI","user":{"login":"xvrl","id":815147,"avatar_url":"https://avatars.githubusercontent.com/u/815147?v=3","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-07T23:25:45Z","updated_at":"2015-01-08T23:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e7cfff248710bb67699e9d3d2fffe0f6316ca32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments/{number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/1018/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/d5f4182de4535a3999bfbfc703530bf4731cea97","head":{"label":"metamx:faster-builds","ref":"faster-builds","sha":"d5f4182de4535a3999bfbfc703530bf4731cea97","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":28248872,"name":"druid","full_name":"metamx/druid","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/metamx/druid","forks_url":"https://api.github.com/repos/metamx/druid/forks","keys_url":"https://api.github.com/repos/metamx/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/druid/teams","hooks_url":"https://api.github.com/repos/metamx/druid/hooks","issue_events_url":"https://api.github.com/repos/metamx/druid/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/druid/events","assignees_url":"https://api.github.com/repos/metamx/druid/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/druid/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/druid/tags","blobs_url":"https://api.github.com/repos/metamx/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/druid/languages","stargazers_url":"https://api.github.com/repos/metamx/druid/stargazers","contributors_url":"https://api.github.com/repos/metamx/druid/contributors","subscribers_url":"https://api.github.com/repos/metamx/druid/subscribers","subscription_url":"https://api.github.com/repos/metamx/druid/subscription","commits_url":"https://api.github.com/repos/metamx/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/druid/issues/comments/{number}","contents_url":"https://api.github.com/repos/metamx/druid/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/druid/merges","archive_url":"https://api.github.com/repos/metamx/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/druid/downloads","issues_url":"https://api.github.com/repos/metamx/druid/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/druid/labels{/name}","releases_url":"https://api.github.com/repos/metamx/druid/releases{/id}","created_at":"2014-12-19T22:30:25Z","updated_at":"2015-01-08T19:42:26Z","pushed_at":"2015-01-08T19:42:26Z","git_url":"git://github.com/metamx/druid.git","ssh_url":"git@github.com:metamx/druid.git","clone_url":"https://github.com/metamx/druid.git","svn_url":"https://github.com/metamx/druid","homepage":"http://druid.io","size":87959,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"8ea237d6a101d9c1458da258870973c9ee82896b","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments/{number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-01-08T22:34:52Z","pushed_at":"2015-01-08T22:49:16Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":152074,"stargazers_count":1307,"watchers_count":1307,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":133,"forks":278,"open_issues":133,"watchers":1307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1018"},"html":{"href":"https://github.com/druid-io/druid/pull/1018"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/1018"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/d5f4182de4535a3999bfbfc703530bf4731cea97"}}}}