{"action":"created","comment":{"url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/comments/48059302","id":48059302,"diff_hunk":"@@ -324,7 +285,58 @@ def _handle_package(self, pkg):\n                 os.path.join(self.installdir, 'usr', 'bin', 'g++'))\n         ])\n \n-        self._rosrun(catkincmd)\n+        # This command must run in bash due to a bug in Catkin that causes it\n+        # to explode if there are spaces in the cmake args (which there are).\n+        # This has been fixed in Catkin Tools... perhaps we should be using\n+        # that instead.","path":"snapcraft/plugins/catkin.py","position":394,"original_position":394,"commit_id":"ba0eb4004bce7ce764450fc0c8697d504caa1a5f","original_commit_id":"ba0eb4004bce7ce764450fc0c8697d504caa1a5f","user":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars.githubusercontent.com/u/1146853?v=3","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"not sure what *Catkin Tools* are but I'm inclined to say yes","created_at":"2015-12-18T19:19:50Z","updated_at":"2015-12-18T19:19:50Z","html_url":"https://github.com/ubuntu-core/snapcraft/pull/175#discussion_r48059302","pull_request_url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/comments/48059302"},"html":{"href":"https://github.com/ubuntu-core/snapcraft/pull/175#discussion_r48059302"},"pull_request":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175","id":54134640,"html_url":"https://github.com/ubuntu-core/snapcraft/pull/175","diff_url":"https://github.com/ubuntu-core/snapcraft/pull/175.diff","patch_url":"https://github.com/ubuntu-core/snapcraft/pull/175.patch","issue_url":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/175","number":175,"state":"open","locked":false,"title":"Catkin plugin: Refactor build.","user":{"login":"kyrofa","id":946674,"avatar_url":"https://avatars.githubusercontent.com/u/946674?v=3","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"body":"This PR contains a number of small refactors:\r\n\r\n- Change env() to only contain variables for run-time, and document each of them.\r\n- Only obtain dependencies upon pull()-- for build() they should just be ready to go.\r\n- Extract dependency resolution into a standalone function that can be tested in isolation.\r\n- Change build() to be less clever and more simple/verbose/robust.\r\n- Add `source-space` keyword to get rid of custom build().\r\n- Get unit testing coverage to 100%.","created_at":"2015-12-18T18:32:57Z","updated_at":"2015-12-18T19:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bd5d198fb1d96a3e57604b05a79c041c6892ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175/commits","review_comments_url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175/comments","review_comment_url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/175/comments","statuses_url":"https://api.github.com/repos/ubuntu-core/snapcraft/statuses/ba0eb4004bce7ce764450fc0c8697d504caa1a5f","head":{"label":"kyrofa:catkin_refactor_build","ref":"catkin_refactor_build","sha":"ba0eb4004bce7ce764450fc0c8697d504caa1a5f","user":{"login":"kyrofa","id":946674,"avatar_url":"https://avatars.githubusercontent.com/u/946674?v=3","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"repo":{"id":46729716,"name":"snapcraft","full_name":"kyrofa/snapcraft","owner":{"login":"kyrofa","id":946674,"avatar_url":"https://avatars.githubusercontent.com/u/946674?v=3","gravatar_id":"","url":"https://api.github.com/users/kyrofa","html_url":"https://github.com/kyrofa","followers_url":"https://api.github.com/users/kyrofa/followers","following_url":"https://api.github.com/users/kyrofa/following{/other_user}","gists_url":"https://api.github.com/users/kyrofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrofa/subscriptions","organizations_url":"https://api.github.com/users/kyrofa/orgs","repos_url":"https://api.github.com/users/kyrofa/repos","events_url":"https://api.github.com/users/kyrofa/events{/privacy}","received_events_url":"https://api.github.com/users/kyrofa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyrofa/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/kyrofa/snapcraft","forks_url":"https://api.github.com/repos/kyrofa/snapcraft/forks","keys_url":"https://api.github.com/repos/kyrofa/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyrofa/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyrofa/snapcraft/teams","hooks_url":"https://api.github.com/repos/kyrofa/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/kyrofa/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/kyrofa/snapcraft/events","assignees_url":"https://api.github.com/repos/kyrofa/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/kyrofa/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/kyrofa/snapcraft/tags","blobs_url":"https://api.github.com/repos/kyrofa/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyrofa/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyrofa/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyrofa/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyrofa/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/kyrofa/snapcraft/languages","stargazers_url":"https://api.github.com/repos/kyrofa/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/kyrofa/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/kyrofa/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/kyrofa/snapcraft/subscription","commits_url":"https://api.github.com/repos/kyrofa/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyrofa/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyrofa/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyrofa/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyrofa/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/kyrofa/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyrofa/snapcraft/merges","archive_url":"https://api.github.com/repos/kyrofa/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyrofa/snapcraft/downloads","issues_url":"https://api.github.com/repos/kyrofa/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/kyrofa/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/kyrofa/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/kyrofa/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyrofa/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/kyrofa/snapcraft/releases{/id}","created_at":"2015-11-23T15:35:14Z","updated_at":"2015-11-23T15:35:16Z","pushed_at":"2015-12-18T18:34:25Z","git_url":"git://github.com/kyrofa/snapcraft.git","ssh_url":"git@github.com:kyrofa/snapcraft.git","clone_url":"https://github.com/kyrofa/snapcraft.git","svn_url":"https://github.com/kyrofa/snapcraft","homepage":null,"size":2641,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntu-core:master","ref":"master","sha":"5e15b30203e285912da3e88fa55ddd8c4f66d6fa","user":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"ubuntu-core/snapcraft","owner":{"login":"ubuntu-core","id":15022473,"avatar_url":"https://avatars.githubusercontent.com/u/15022473?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntu-core","html_url":"https://github.com/ubuntu-core","followers_url":"https://api.github.com/users/ubuntu-core/followers","following_url":"https://api.github.com/users/ubuntu-core/following{/other_user}","gists_url":"https://api.github.com/users/ubuntu-core/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntu-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntu-core/subscriptions","organizations_url":"https://api.github.com/users/ubuntu-core/orgs","repos_url":"https://api.github.com/users/ubuntu-core/repos","events_url":"https://api.github.com/users/ubuntu-core/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntu-core/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntu-core/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/ubuntu-core/snapcraft","forks_url":"https://api.github.com/repos/ubuntu-core/snapcraft/forks","keys_url":"https://api.github.com/repos/ubuntu-core/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntu-core/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntu-core/snapcraft/teams","hooks_url":"https://api.github.com/repos/ubuntu-core/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntu-core/snapcraft/events","assignees_url":"https://api.github.com/repos/ubuntu-core/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntu-core/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntu-core/snapcraft/tags","blobs_url":"https://api.github.com/repos/ubuntu-core/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntu-core/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntu-core/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntu-core/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntu-core/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntu-core/snapcraft/languages","stargazers_url":"https://api.github.com/repos/ubuntu-core/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/ubuntu-core/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/ubuntu-core/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/ubuntu-core/snapcraft/subscription","commits_url":"https://api.github.com/repos/ubuntu-core/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntu-core/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntu-core/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntu-core/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntu-core/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntu-core/snapcraft/merges","archive_url":"https://api.github.com/repos/ubuntu-core/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntu-core/snapcraft/downloads","issues_url":"https://api.github.com/repos/ubuntu-core/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntu-core/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntu-core/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntu-core/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/ubuntu-core/snapcraft/releases{/id}","created_at":"2015-10-29T17:23:15Z","updated_at":"2015-12-13T23:03:37Z","pushed_at":"2015-12-18T18:47:24Z","git_url":"git://github.com/ubuntu-core/snapcraft.git","ssh_url":"git@github.com:ubuntu-core/snapcraft.git","clone_url":"https://github.com/ubuntu-core/snapcraft.git","svn_url":"https://github.com/ubuntu-core/snapcraft","homepage":null,"size":2694,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175"},"html":{"href":"https://github.com/ubuntu-core/snapcraft/pull/175"},"issue":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/175"},"comments":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntu-core/snapcraft/statuses/ba0eb4004bce7ce764450fc0c8697d504caa1a5f"}}}}