{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/chipper/issues/260","labels_url":"https://api.github.com/repos/phetsims/chipper/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/chipper/issues/260/comments","events_url":"https://api.github.com/repos/phetsims/chipper/issues/260/events","html_url":"https://github.com/phetsims/chipper/issues/260","id":100893535,"number":260,"title":"use \"requirejsNamespace\" consistently?","user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-13T23:39:16Z","updated_at":"2015-08-13T23:43:32Z","closed_at":null,"body":"There are (at least) 3 names in the code for what we've been calling \"requirejs namespace\" (e.g. ACID_BASE_SOLUTIONS).  The 3 names are `requirejsNamespace`, `requirePrefix` and `prefix`.\r\n\r\npackage.json uses `requirejsNamespace`, e.g.:\r\n\r\n`\"requirejsNamespace\": \"ACID_BASE_SOLUTIONS\",`\r\n\r\nstring.js uses `requirePrefix`:\r\n\r\n```\r\n95 var requirePrefix = name.substring( 0, name.indexOf( '/' ) ); // e.g. 'SOME_SIM'\r\n... and several other places\r\n```\r\n\r\nafterRequirejsBuild.js reads `requirePrefix`, and gives it yet-another name, `prefix`:\r\n\r\n`97 prefix: global.phet.strings[ stringKey ].requirePrefix`\r\n\r\n... then uses `prefix` when building a map:\r\n\r\n`139 fileMap[ repository.prefix + '/' + stringKeyMissingPrefix ] = fileContents[ stringKeyMissingPrefix ];`\r\n\r\nafterRequirejsBuild.js is interesting because it uses all 3 names.\r\n\r\nShould we consolidate these 3 names to \"requirejsNamespace\" for consistency?"},"comment":{"url":"https://api.github.com/repos/phetsims/chipper/issues/comments/130887516","html_url":"https://github.com/phetsims/chipper/issues/260#issuecomment-130887516","issue_url":"https://api.github.com/repos/phetsims/chipper/issues/260","id":130887516,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T23:43:32Z","updated_at":"2015-08-13T23:43:32Z","body":"Another variation in reportUnusedMedia.js:\r\n\r\n` @param {string} simNameUppercase - the upper-case string prefix such as BALANCING_ACT`"}}