{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/comments/42483644","id":42483644,"diff_hunk":"@@ -92,6 +93,44 @@ namespace Opm\n                     undersat_gas_tables_[pvtTableIdx][i][1][j] = 1.0 / undersat_gas_tables_[pvtTableIdx][i][1][j];\n                 }\n             }\n+\n+             // Complete undersaturated tables by extrapolating from existing data\n+            int iNext = -1;\n+            for (int i=0; i<sz; ++i) {\n+                // Skip records already containing undersaturated data\n+                if (undersat_gas_tables_[pvtTableIdx][i][0].size() > 1) {\n+                    continue;\n+                }\n+                // Look ahead for next record containing undersaturated data\n+                if (iNext < i) {\n+                    iNext = i+1;\n+                    while (iNext < sz && undersat_gas_tables_[pvtTableIdx][iNext][0].size() < 2) {\n+                        ++iNext;\n+                    }\n+                    if (iNext == sz) OPM_THROW(std::runtime_error,\"Unable to complete undersaturated table.\");\n+                }\n+                // Add undersaturated data to current record while maintaining compressibility and viscosibility","path":"opm/core/props/pvt/PvtLiveGas.cpp","position":28,"original_position":28,"commit_id":"2330cd615a895a87c672656f4a08a730c34c2e98","original_commit_id":"2330cd615a895a87c672656f4a08a730c34c2e98","user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"body":"Is this comment correct? It is not obvious to me that this would be conserved.","created_at":"2015-10-20T11:31:34Z","updated_at":"2015-10-20T11:31:34Z","html_url":"https://github.com/OPM/opm-core/pull/906#discussion_r42483644","pull_request_url":"https://api.github.com/repos/OPM/opm-core/pulls/906","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments/42483644"},"html":{"href":"https://github.com/OPM/opm-core/pull/906#discussion_r42483644"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/906","id":48176217,"html_url":"https://github.com/OPM/opm-core/pull/906","diff_url":"https://github.com/OPM/opm-core/pull/906.diff","patch_url":"https://github.com/OPM/opm-core/pull/906.patch","issue_url":"https://api.github.com/repos/OPM/opm-core/issues/906","number":906,"state":"open","locked":false,"title":"Complete undersaturated PVTG tables by extrapolating from existing data","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=3","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"body":"This PR copies equivalent code from PvtLiveOil","created_at":"2015-10-20T09:30:35Z","updated_at":"2015-10-20T11:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c55404fe3bab6dbd2489ec111e4b7a8f599e6ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-core/pulls/906/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-core/pulls/906/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-core/issues/906/comments","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/2330cd615a895a87c672656f4a08a730c34c2e98","head":{"label":"totto82:livegas","ref":"livegas","sha":"2330cd615a895a87c672656f4a08a730c34c2e98","user":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=3","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"repo":{"id":7516283,"name":"opm-core","full_name":"totto82/opm-core","owner":{"login":"totto82","id":3223024,"avatar_url":"https://avatars.githubusercontent.com/u/3223024?v=3","gravatar_id":"","url":"https://api.github.com/users/totto82","html_url":"https://github.com/totto82","followers_url":"https://api.github.com/users/totto82/followers","following_url":"https://api.github.com/users/totto82/following{/other_user}","gists_url":"https://api.github.com/users/totto82/gists{/gist_id}","starred_url":"https://api.github.com/users/totto82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/totto82/subscriptions","organizations_url":"https://api.github.com/users/totto82/orgs","repos_url":"https://api.github.com/users/totto82/repos","events_url":"https://api.github.com/users/totto82/events{/privacy}","received_events_url":"https://api.github.com/users/totto82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/totto82/opm-core","description":"Open Porous Media Core Library","fork":true,"url":"https://api.github.com/repos/totto82/opm-core","forks_url":"https://api.github.com/repos/totto82/opm-core/forks","keys_url":"https://api.github.com/repos/totto82/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/totto82/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/totto82/opm-core/teams","hooks_url":"https://api.github.com/repos/totto82/opm-core/hooks","issue_events_url":"https://api.github.com/repos/totto82/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/totto82/opm-core/events","assignees_url":"https://api.github.com/repos/totto82/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/totto82/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/totto82/opm-core/tags","blobs_url":"https://api.github.com/repos/totto82/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/totto82/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/totto82/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/totto82/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/totto82/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/totto82/opm-core/languages","stargazers_url":"https://api.github.com/repos/totto82/opm-core/stargazers","contributors_url":"https://api.github.com/repos/totto82/opm-core/contributors","subscribers_url":"https://api.github.com/repos/totto82/opm-core/subscribers","subscription_url":"https://api.github.com/repos/totto82/opm-core/subscription","commits_url":"https://api.github.com/repos/totto82/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/totto82/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/totto82/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/totto82/opm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/totto82/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/totto82/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/totto82/opm-core/merges","archive_url":"https://api.github.com/repos/totto82/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/totto82/opm-core/downloads","issues_url":"https://api.github.com/repos/totto82/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/totto82/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/totto82/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/totto82/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/totto82/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/totto82/opm-core/releases{/id}","created_at":"2013-01-09T06:50:10Z","updated_at":"2015-04-10T09:16:25Z","pushed_at":"2015-10-20T09:29:27Z","git_url":"git://github.com/totto82/opm-core.git","ssh_url":"git@github.com:totto82/opm-core.git","clone_url":"https://github.com/totto82/opm-core.git","svn_url":"https://github.com/totto82/opm-core","homepage":"http://www.opm-project.org","size":12191,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"0cd08a1f12b936b3c1ccdae86425cd9b26fc6fc1","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4787500,"name":"opm-core","full_name":"OPM/opm-core","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-core","description":"Open Porous Media Core Library","fork":false,"url":"https://api.github.com/repos/OPM/opm-core","forks_url":"https://api.github.com/repos/OPM/opm-core/forks","keys_url":"https://api.github.com/repos/OPM/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-core/teams","hooks_url":"https://api.github.com/repos/OPM/opm-core/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-core/events","assignees_url":"https://api.github.com/repos/OPM/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-core/tags","blobs_url":"https://api.github.com/repos/OPM/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-core/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-core/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-core/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-core/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-core/subscription","commits_url":"https://api.github.com/repos/OPM/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-core/merges","archive_url":"https://api.github.com/repos/OPM/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-core/downloads","issues_url":"https://api.github.com/repos/OPM/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-core/releases{/id}","created_at":"2012-06-25T21:14:06Z","updated_at":"2015-09-02T05:40:29Z","pushed_at":"2015-10-20T09:30:35Z","git_url":"git://github.com/OPM/opm-core.git","ssh_url":"git@github.com:OPM/opm-core.git","clone_url":"https://github.com/OPM/opm-core.git","svn_url":"https://github.com/OPM/opm-core","homepage":"http://www.opm-project.org","size":16534,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":21,"forks":42,"open_issues":21,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/906"},"html":{"href":"https://github.com/OPM/opm-core/pull/906"},"issue":{"href":"https://api.github.com/repos/OPM/opm-core/issues/906"},"comments":{"href":"https://api.github.com/repos/OPM/opm-core/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-core/statuses/2330cd615a895a87c672656f4a08a730c34c2e98"}}}}