{"action":"created","comment":{"url":"https://api.github.com/repos/purescript/purescript/pulls/comments/44230776","id":44230776,"diff_hunk":"@@ -334,9 +334,15 @@ parseObjectLiteral :: TokenParser Expr\n parseObjectLiteral = ObjectConstructor <$> braces (commaSep parseIdentifierAndValue)\n \n parseIdentifierAndValue :: TokenParser (String, Maybe Expr)\n-parseIdentifierAndValue = (,) <$> (C.indented *> (lname <|> stringLiteral) <* C.indented <* colon)\n-                              <*> (C.indented *> val)\n+parseIdentifierAndValue =\n+  do\n+    name <- ident\n+    b <- P.option (Just $ Var $ (Qualified Nothing) $ (Ident name)) rest\n+    return (name, b)\n+  <|> (,) <$> ident <*> rest","path":"src/Language/PureScript/Parser/Declarations.hs","position":11,"original_position":11,"commit_id":"e7e100d913d804ff57ffe96fdffcfd4e0dfc16dd","original_commit_id":"e7e100d913d804ff57ffe96fdffcfd4e0dfc16dd","user":{"login":"paf31","id":630306,"avatar_url":"https://avatars.githubusercontent.com/u/630306?v=3","gravatar_id":"","url":"https://api.github.com/users/paf31","html_url":"https://github.com/paf31","followers_url":"https://api.github.com/users/paf31/followers","following_url":"https://api.github.com/users/paf31/following{/other_user}","gists_url":"https://api.github.com/users/paf31/gists{/gist_id}","starred_url":"https://api.github.com/users/paf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paf31/subscriptions","organizations_url":"https://api.github.com/users/paf31/orgs","repos_url":"https://api.github.com/users/paf31/repos","events_url":"https://api.github.com/users/paf31/events{/privacy}","received_events_url":"https://api.github.com/users/paf31/received_events","type":"User","site_admin":false},"body":"One branch should be `stringLiteral` (with a required value) and the other should be an `lname` (without) since `Var` needs to take an `lname` not an arbitrary string.","created_at":"2015-11-08T21:19:37Z","updated_at":"2015-11-08T21:19:37Z","html_url":"https://github.com/purescript/purescript/pull/1618#discussion_r44230776","pull_request_url":"https://api.github.com/repos/purescript/purescript/pulls/1618","_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments/44230776"},"html":{"href":"https://github.com/purescript/purescript/pull/1618#discussion_r44230776"},"pull_request":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1618"}}},"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/1618","id":50067498,"html_url":"https://github.com/purescript/purescript/pull/1618","diff_url":"https://github.com/purescript/purescript/pull/1618.diff","patch_url":"https://github.com/purescript/purescript/pull/1618.patch","issue_url":"https://api.github.com/repos/purescript/purescript/issues/1618","number":1618,"state":"open","locked":false,"title":"Record constructor field puns, fix #921","user":{"login":"balajirrao","id":193413,"avatar_url":"https://avatars.githubusercontent.com/u/193413?v=3","gravatar_id":"","url":"https://api.github.com/users/balajirrao","html_url":"https://github.com/balajirrao","followers_url":"https://api.github.com/users/balajirrao/followers","following_url":"https://api.github.com/users/balajirrao/following{/other_user}","gists_url":"https://api.github.com/users/balajirrao/gists{/gist_id}","starred_url":"https://api.github.com/users/balajirrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajirrao/subscriptions","organizations_url":"https://api.github.com/users/balajirrao/orgs","repos_url":"https://api.github.com/users/balajirrao/repos","events_url":"https://api.github.com/users/balajirrao/events{/privacy}","received_events_url":"https://api.github.com/users/balajirrao/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-08T19:19:15Z","updated_at":"2015-11-08T21:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22d933be96c79f23393574556b49ed2c9f880bd6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/purescript/purescript/pulls/1618/commits","review_comments_url":"https://api.github.com/repos/purescript/purescript/pulls/1618/comments","review_comment_url":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/1618/comments","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/e7e100d913d804ff57ffe96fdffcfd4e0dfc16dd","head":{"label":"balajirrao:master","ref":"master","sha":"e7e100d913d804ff57ffe96fdffcfd4e0dfc16dd","user":{"login":"balajirrao","id":193413,"avatar_url":"https://avatars.githubusercontent.com/u/193413?v=3","gravatar_id":"","url":"https://api.github.com/users/balajirrao","html_url":"https://github.com/balajirrao","followers_url":"https://api.github.com/users/balajirrao/followers","following_url":"https://api.github.com/users/balajirrao/following{/other_user}","gists_url":"https://api.github.com/users/balajirrao/gists{/gist_id}","starred_url":"https://api.github.com/users/balajirrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajirrao/subscriptions","organizations_url":"https://api.github.com/users/balajirrao/orgs","repos_url":"https://api.github.com/users/balajirrao/repos","events_url":"https://api.github.com/users/balajirrao/events{/privacy}","received_events_url":"https://api.github.com/users/balajirrao/received_events","type":"User","site_admin":false},"repo":{"id":32625613,"name":"purescript","full_name":"balajirrao/purescript","owner":{"login":"balajirrao","id":193413,"avatar_url":"https://avatars.githubusercontent.com/u/193413?v=3","gravatar_id":"","url":"https://api.github.com/users/balajirrao","html_url":"https://github.com/balajirrao","followers_url":"https://api.github.com/users/balajirrao/followers","following_url":"https://api.github.com/users/balajirrao/following{/other_user}","gists_url":"https://api.github.com/users/balajirrao/gists{/gist_id}","starred_url":"https://api.github.com/users/balajirrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajirrao/subscriptions","organizations_url":"https://api.github.com/users/balajirrao/orgs","repos_url":"https://api.github.com/users/balajirrao/repos","events_url":"https://api.github.com/users/balajirrao/events{/privacy}","received_events_url":"https://api.github.com/users/balajirrao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balajirrao/purescript","description":"A small strongly typed language that compiles to Javascript","fork":true,"url":"https://api.github.com/repos/balajirrao/purescript","forks_url":"https://api.github.com/repos/balajirrao/purescript/forks","keys_url":"https://api.github.com/repos/balajirrao/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balajirrao/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balajirrao/purescript/teams","hooks_url":"https://api.github.com/repos/balajirrao/purescript/hooks","issue_events_url":"https://api.github.com/repos/balajirrao/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/balajirrao/purescript/events","assignees_url":"https://api.github.com/repos/balajirrao/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/balajirrao/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/balajirrao/purescript/tags","blobs_url":"https://api.github.com/repos/balajirrao/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balajirrao/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balajirrao/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/balajirrao/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balajirrao/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/balajirrao/purescript/languages","stargazers_url":"https://api.github.com/repos/balajirrao/purescript/stargazers","contributors_url":"https://api.github.com/repos/balajirrao/purescript/contributors","subscribers_url":"https://api.github.com/repos/balajirrao/purescript/subscribers","subscription_url":"https://api.github.com/repos/balajirrao/purescript/subscription","commits_url":"https://api.github.com/repos/balajirrao/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/balajirrao/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/balajirrao/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/balajirrao/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/balajirrao/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/balajirrao/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balajirrao/purescript/merges","archive_url":"https://api.github.com/repos/balajirrao/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balajirrao/purescript/downloads","issues_url":"https://api.github.com/repos/balajirrao/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/balajirrao/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/balajirrao/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/balajirrao/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balajirrao/purescript/labels{/name}","releases_url":"https://api.github.com/repos/balajirrao/purescript/releases{/id}","created_at":"2015-03-21T08:39:50Z","updated_at":"2015-04-27T18:59:16Z","pushed_at":"2015-11-08T19:17:18Z","git_url":"git://github.com/balajirrao/purescript.git","ssh_url":"git@github.com:balajirrao/purescript.git","clone_url":"https://github.com/balajirrao/purescript.git","svn_url":"https://github.com/balajirrao/purescript","homepage":"http://purescript.org","size":3990,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"07e8adc7becd26c816d07c2932483f446b6dafb4","user":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":13206906,"name":"purescript","full_name":"purescript/purescript","owner":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/purescript","description":"A small strongly typed language that compiles to Javascript","fork":false,"url":"https://api.github.com/repos/purescript/purescript","forks_url":"https://api.github.com/repos/purescript/purescript/forks","keys_url":"https://api.github.com/repos/purescript/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/purescript/teams","hooks_url":"https://api.github.com/repos/purescript/purescript/hooks","issue_events_url":"https://api.github.com/repos/purescript/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/purescript/events","assignees_url":"https://api.github.com/repos/purescript/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/purescript/tags","blobs_url":"https://api.github.com/repos/purescript/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/purescript/languages","stargazers_url":"https://api.github.com/repos/purescript/purescript/stargazers","contributors_url":"https://api.github.com/repos/purescript/purescript/contributors","subscribers_url":"https://api.github.com/repos/purescript/purescript/subscribers","subscription_url":"https://api.github.com/repos/purescript/purescript/subscription","commits_url":"https://api.github.com/repos/purescript/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/purescript/merges","archive_url":"https://api.github.com/repos/purescript/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/purescript/downloads","issues_url":"https://api.github.com/repos/purescript/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/purescript/labels{/name}","releases_url":"https://api.github.com/repos/purescript/purescript/releases{/id}","created_at":"2013-09-30T05:29:23Z","updated_at":"2015-11-08T01:16:32Z","pushed_at":"2015-11-08T19:19:15Z","git_url":"git://github.com/purescript/purescript.git","ssh_url":"git@github.com:purescript/purescript.git","clone_url":"https://github.com/purescript/purescript.git","svn_url":"https://github.com/purescript/purescript","homepage":"http://purescript.org","size":14017,"stargazers_count":1902,"watchers_count":1902,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":182,"forks":168,"open_issues":182,"watchers":1902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1618"},"html":{"href":"https://github.com/purescript/purescript/pull/1618"},"issue":{"href":"https://api.github.com/repos/purescript/purescript/issues/1618"},"comments":{"href":"https://api.github.com/repos/purescript/purescript/issues/1618/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1618/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1618/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/purescript/statuses/e7e100d913d804ff57ffe96fdffcfd4e0dfc16dd"}}}}