{"action":"created","comment":{"url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/comments/40865523","id":40865523,"diff_hunk":"@@ -227,7 +227,7 @@ and [<AllowNullLiteral>]\n             x.Pack( ms )  \n             // x.Hash <- HashByteArrayWithLength( ms.GetBufferPosLength()  )\n             let (ms, pos, len) = ms.GetBufferPosLength()\n-            x.Hash <- ms.ComputeSHA256(int64 pos, int64 len)\n+            x.Hash <- ms.ComputeDefaultHash(int64 pos, int64 len)","path":"src/CoreLib/assembly.fs","position":5,"original_position":5,"commit_id":"2aabe8c45548a10a01334962d7e0afca618ee1a1","original_commit_id":"2aabe8c45548a10a01334962d7e0afca618ee1a1","user":{"login":"jinlmsft","id":7265672,"avatar_url":"https://avatars.githubusercontent.com/u/7265672?v=3","gravatar_id":"","url":"https://api.github.com/users/jinlmsft","html_url":"https://github.com/jinlmsft","followers_url":"https://api.github.com/users/jinlmsft/followers","following_url":"https://api.github.com/users/jinlmsft/following{/other_user}","gists_url":"https://api.github.com/users/jinlmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jinlmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinlmsft/subscriptions","organizations_url":"https://api.github.com/users/jinlmsft/orgs","repos_url":"https://api.github.com/users/jinlmsft/repos","events_url":"https://api.github.com/users/jinlmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jinlmsft/received_events","type":"User","site_admin":false},"body":"I have discussed with Bruno. Let's use strong hash (SHA256) for assembly and files. Otherwise, we are open ourselves to attack scenarios. Specifically, let's use strong hash for BlobKind.AssemblyManagedDLL, BlobKind.AssemblyUnmanagedDir, BlobKind.JobDependencyFile","created_at":"2015-09-30T23:29:03Z","updated_at":"2015-09-30T23:29:03Z","html_url":"https://github.com/MSRCCS/Prajna/pull/62#discussion_r40865523","pull_request_url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/comments/40865523"},"html":{"href":"https://github.com/MSRCCS/Prajna/pull/62#discussion_r40865523"},"pull_request":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62","id":45970936,"html_url":"https://github.com/MSRCCS/Prajna/pull/62","diff_url":"https://github.com/MSRCCS/Prajna/pull/62.diff","patch_url":"https://github.com/MSRCCS/Prajna/pull/62.patch","issue_url":"https://api.github.com/repos/MSRCCS/Prajna/issues/62","number":62,"state":"open","locked":false,"title":"Adding Fletcher64 hashing to replace SHA256","user":{"login":"BrunoBozza","id":13823256,"avatar_url":"https://avatars.githubusercontent.com/u/13823256?v=3","gravatar_id":"","url":"https://api.github.com/users/BrunoBozza","html_url":"https://github.com/BrunoBozza","followers_url":"https://api.github.com/users/BrunoBozza/followers","following_url":"https://api.github.com/users/BrunoBozza/following{/other_user}","gists_url":"https://api.github.com/users/BrunoBozza/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoBozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoBozza/subscriptions","organizations_url":"https://api.github.com/users/BrunoBozza/orgs","repos_url":"https://api.github.com/users/BrunoBozza/repos","events_url":"https://api.github.com/users/BrunoBozza/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoBozza/received_events","type":"User","site_admin":false},"body":"SHA256 was way overkill what we are doing. This Fletcher64 implementation is more than sufficient for checksuming, over 50x faster, and does around 5GB/s in my machine.","created_at":"2015-09-25T02:16:29Z","updated_at":"2015-09-30T23:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79e324ccf51d9b4b0f25d6b3255a0bed2dfbab50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62/commits","review_comments_url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62/comments","review_comment_url":"https://api.github.com/repos/MSRCCS/Prajna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MSRCCS/Prajna/issues/62/comments","statuses_url":"https://api.github.com/repos/MSRCCS/Prajna/statuses/2aabe8c45548a10a01334962d7e0afca618ee1a1","head":{"label":"BrunoBozza:master","ref":"master","sha":"2aabe8c45548a10a01334962d7e0afca618ee1a1","user":{"login":"BrunoBozza","id":13823256,"avatar_url":"https://avatars.githubusercontent.com/u/13823256?v=3","gravatar_id":"","url":"https://api.github.com/users/BrunoBozza","html_url":"https://github.com/BrunoBozza","followers_url":"https://api.github.com/users/BrunoBozza/followers","following_url":"https://api.github.com/users/BrunoBozza/following{/other_user}","gists_url":"https://api.github.com/users/BrunoBozza/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoBozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoBozza/subscriptions","organizations_url":"https://api.github.com/users/BrunoBozza/orgs","repos_url":"https://api.github.com/users/BrunoBozza/repos","events_url":"https://api.github.com/users/BrunoBozza/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoBozza/received_events","type":"User","site_admin":false},"repo":{"id":40840477,"name":"Prajna","full_name":"BrunoBozza/Prajna","owner":{"login":"BrunoBozza","id":13823256,"avatar_url":"https://avatars.githubusercontent.com/u/13823256?v=3","gravatar_id":"","url":"https://api.github.com/users/BrunoBozza","html_url":"https://github.com/BrunoBozza","followers_url":"https://api.github.com/users/BrunoBozza/followers","following_url":"https://api.github.com/users/BrunoBozza/following{/other_user}","gists_url":"https://api.github.com/users/BrunoBozza/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoBozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoBozza/subscriptions","organizations_url":"https://api.github.com/users/BrunoBozza/orgs","repos_url":"https://api.github.com/users/BrunoBozza/repos","events_url":"https://api.github.com/users/BrunoBozza/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoBozza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrunoBozza/Prajna","description":"Prajna: A Distributed Functional Programming Platform for Interactive Big Data Analytics and Cloud Service Building","fork":true,"url":"https://api.github.com/repos/BrunoBozza/Prajna","forks_url":"https://api.github.com/repos/BrunoBozza/Prajna/forks","keys_url":"https://api.github.com/repos/BrunoBozza/Prajna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrunoBozza/Prajna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrunoBozza/Prajna/teams","hooks_url":"https://api.github.com/repos/BrunoBozza/Prajna/hooks","issue_events_url":"https://api.github.com/repos/BrunoBozza/Prajna/issues/events{/number}","events_url":"https://api.github.com/repos/BrunoBozza/Prajna/events","assignees_url":"https://api.github.com/repos/BrunoBozza/Prajna/assignees{/user}","branches_url":"https://api.github.com/repos/BrunoBozza/Prajna/branches{/branch}","tags_url":"https://api.github.com/repos/BrunoBozza/Prajna/tags","blobs_url":"https://api.github.com/repos/BrunoBozza/Prajna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrunoBozza/Prajna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrunoBozza/Prajna/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrunoBozza/Prajna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrunoBozza/Prajna/statuses/{sha}","languages_url":"https://api.github.com/repos/BrunoBozza/Prajna/languages","stargazers_url":"https://api.github.com/repos/BrunoBozza/Prajna/stargazers","contributors_url":"https://api.github.com/repos/BrunoBozza/Prajna/contributors","subscribers_url":"https://api.github.com/repos/BrunoBozza/Prajna/subscribers","subscription_url":"https://api.github.com/repos/BrunoBozza/Prajna/subscription","commits_url":"https://api.github.com/repos/BrunoBozza/Prajna/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrunoBozza/Prajna/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrunoBozza/Prajna/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrunoBozza/Prajna/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrunoBozza/Prajna/contents/{+path}","compare_url":"https://api.github.com/repos/BrunoBozza/Prajna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrunoBozza/Prajna/merges","archive_url":"https://api.github.com/repos/BrunoBozza/Prajna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrunoBozza/Prajna/downloads","issues_url":"https://api.github.com/repos/BrunoBozza/Prajna/issues{/number}","pulls_url":"https://api.github.com/repos/BrunoBozza/Prajna/pulls{/number}","milestones_url":"https://api.github.com/repos/BrunoBozza/Prajna/milestones{/number}","notifications_url":"https://api.github.com/repos/BrunoBozza/Prajna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrunoBozza/Prajna/labels{/name}","releases_url":"https://api.github.com/repos/BrunoBozza/Prajna/releases{/id}","created_at":"2015-08-16T20:58:15Z","updated_at":"2015-08-16T20:58:17Z","pushed_at":"2015-09-30T22:19:29Z","git_url":"git://github.com/BrunoBozza/Prajna.git","ssh_url":"git@github.com:BrunoBozza/Prajna.git","clone_url":"https://github.com/BrunoBozza/Prajna.git","svn_url":"https://github.com/BrunoBozza/Prajna","homepage":"http://MSRCCS.github.io/Prajna","size":4324,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MSRCCS:master","ref":"master","sha":"15b5bc6c9ad454098cbc73fc7e9f20bb8587df77","user":{"login":"MSRCCS","id":13593104,"avatar_url":"https://avatars.githubusercontent.com/u/13593104?v=3","gravatar_id":"","url":"https://api.github.com/users/MSRCCS","html_url":"https://github.com/MSRCCS","followers_url":"https://api.github.com/users/MSRCCS/followers","following_url":"https://api.github.com/users/MSRCCS/following{/other_user}","gists_url":"https://api.github.com/users/MSRCCS/gists{/gist_id}","starred_url":"https://api.github.com/users/MSRCCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSRCCS/subscriptions","organizations_url":"https://api.github.com/users/MSRCCS/orgs","repos_url":"https://api.github.com/users/MSRCCS/repos","events_url":"https://api.github.com/users/MSRCCS/events{/privacy}","received_events_url":"https://api.github.com/users/MSRCCS/received_events","type":"Organization","site_admin":false},"repo":{"id":40625359,"name":"Prajna","full_name":"MSRCCS/Prajna","owner":{"login":"MSRCCS","id":13593104,"avatar_url":"https://avatars.githubusercontent.com/u/13593104?v=3","gravatar_id":"","url":"https://api.github.com/users/MSRCCS","html_url":"https://github.com/MSRCCS","followers_url":"https://api.github.com/users/MSRCCS/followers","following_url":"https://api.github.com/users/MSRCCS/following{/other_user}","gists_url":"https://api.github.com/users/MSRCCS/gists{/gist_id}","starred_url":"https://api.github.com/users/MSRCCS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSRCCS/subscriptions","organizations_url":"https://api.github.com/users/MSRCCS/orgs","repos_url":"https://api.github.com/users/MSRCCS/repos","events_url":"https://api.github.com/users/MSRCCS/events{/privacy}","received_events_url":"https://api.github.com/users/MSRCCS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MSRCCS/Prajna","description":"Prajna: A Distributed Functional Programming Platform for Interactive Big Data Analytics and Cloud Service Building","fork":false,"url":"https://api.github.com/repos/MSRCCS/Prajna","forks_url":"https://api.github.com/repos/MSRCCS/Prajna/forks","keys_url":"https://api.github.com/repos/MSRCCS/Prajna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSRCCS/Prajna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSRCCS/Prajna/teams","hooks_url":"https://api.github.com/repos/MSRCCS/Prajna/hooks","issue_events_url":"https://api.github.com/repos/MSRCCS/Prajna/issues/events{/number}","events_url":"https://api.github.com/repos/MSRCCS/Prajna/events","assignees_url":"https://api.github.com/repos/MSRCCS/Prajna/assignees{/user}","branches_url":"https://api.github.com/repos/MSRCCS/Prajna/branches{/branch}","tags_url":"https://api.github.com/repos/MSRCCS/Prajna/tags","blobs_url":"https://api.github.com/repos/MSRCCS/Prajna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSRCCS/Prajna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSRCCS/Prajna/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSRCCS/Prajna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSRCCS/Prajna/statuses/{sha}","languages_url":"https://api.github.com/repos/MSRCCS/Prajna/languages","stargazers_url":"https://api.github.com/repos/MSRCCS/Prajna/stargazers","contributors_url":"https://api.github.com/repos/MSRCCS/Prajna/contributors","subscribers_url":"https://api.github.com/repos/MSRCCS/Prajna/subscribers","subscription_url":"https://api.github.com/repos/MSRCCS/Prajna/subscription","commits_url":"https://api.github.com/repos/MSRCCS/Prajna/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSRCCS/Prajna/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSRCCS/Prajna/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSRCCS/Prajna/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSRCCS/Prajna/contents/{+path}","compare_url":"https://api.github.com/repos/MSRCCS/Prajna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSRCCS/Prajna/merges","archive_url":"https://api.github.com/repos/MSRCCS/Prajna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSRCCS/Prajna/downloads","issues_url":"https://api.github.com/repos/MSRCCS/Prajna/issues{/number}","pulls_url":"https://api.github.com/repos/MSRCCS/Prajna/pulls{/number}","milestones_url":"https://api.github.com/repos/MSRCCS/Prajna/milestones{/number}","notifications_url":"https://api.github.com/repos/MSRCCS/Prajna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSRCCS/Prajna/labels{/name}","releases_url":"https://api.github.com/repos/MSRCCS/Prajna/releases{/id}","created_at":"2015-08-12T21:32:16Z","updated_at":"2015-09-30T06:06:55Z","pushed_at":"2015-09-30T22:32:20Z","git_url":"git://github.com/MSRCCS/Prajna.git","ssh_url":"git@github.com:MSRCCS/Prajna.git","clone_url":"https://github.com/MSRCCS/Prajna.git","svn_url":"https://github.com/MSRCCS/Prajna","homepage":"http://MSRCCS.github.io/Prajna","size":5698,"stargazers_count":65,"watchers_count":65,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62"},"html":{"href":"https://github.com/MSRCCS/Prajna/pull/62"},"issue":{"href":"https://api.github.com/repos/MSRCCS/Prajna/issues/62"},"comments":{"href":"https://api.github.com/repos/MSRCCS/Prajna/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MSRCCS/Prajna/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/MSRCCS/Prajna/statuses/2aabe8c45548a10a01334962d7e0afca618ee1a1"}}}}