{"action":"created","comment":{"url":"https://api.github.com/repos/ipa320/cob_control/pulls/comments/37743691","id":37743691,"diff_hunk":"@@ -111,26 +111,15 @@ bool FrameToCollision::initSelfCollision(XmlRpc::XmlRpcValue& self_collision_par\n \n     if(success)\n     {\n-        ROS_INFO(\"Additional ignore links: \");\n         for(MapIter_t it = this->self_collision_frames_.begin(); it != this->self_collision_frames_.end(); it++)\n         {\n-            PtrConstLink_t link = this->model_.getLink(it->first);\n-            if(NULL != link)\n-            {\n-                PtrLink_t p_link = link->getParent();\n-                ROS_INFO_STREAM(\"Current link: \" << it->first);\n-                ROS_INFO_STREAM(\" Parent link to be ignored: \" << p_link->name);\n-                it->second.push_back(p_link->name);\n-                for(PtrLink_t c_link : link->child_links)\n-                {\n-                    ROS_INFO_STREAM(\"  Child link to be ignored: \" << c_link->name);\n-                    it->second.push_back(c_link->name);\n-                }\n-            }\n+            ROS_INFO_STREAM(\"Create self-collision obstacle for: \" << it->first);\n \n             // Create real obstacles now.\n             PtrIMarkerShape_t ptr_obstacle;\n             this->getMarkerShapeFromUrdf(Eigen::Vector3d(), Eigen::Quaterniond(), it->first, ptr_obstacle);\n+            //ptr_obstacle->setDrawable(false); // do not draw the marker in rviz again (are available in robot model->collision enabled...\n+            ptr_obstacle->setDrawable(true); // do not draw the marker in rviz again (are available in robot model->collision enabled...","path":"cob_obstacle_distance/src/frame_to_collision.cpp","position":35,"original_position":35,"commit_id":"be69d897f12af35569743c810c8352abbae0d632","original_commit_id":"be69d897f12af35569743c810c8352abbae0d632","user":{"login":"ipa-fxm-mb","id":11269199,"avatar_url":"https://avatars.githubusercontent.com/u/11269199?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm-mb","html_url":"https://github.com/ipa-fxm-mb","followers_url":"https://api.github.com/users/ipa-fxm-mb/followers","following_url":"https://api.github.com/users/ipa-fxm-mb/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm-mb/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm-mb/orgs","repos_url":"https://api.github.com/users/ipa-fxm-mb/repos","events_url":"https://api.github.com/users/ipa-fxm-mb/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm-mb/received_events","type":"User","site_admin":false},"body":"Fixed! ","created_at":"2015-08-24T12:04:11Z","updated_at":"2015-08-24T12:04:11Z","html_url":"https://github.com/ipa320/cob_control/pull/51#discussion_r37743691","pull_request_url":"https://api.github.com/repos/ipa320/cob_control/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/comments/37743691"},"html":{"href":"https://github.com/ipa320/cob_control/pull/51#discussion_r37743691"},"pull_request":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/ipa320/cob_control/pulls/51","id":42382598,"html_url":"https://github.com/ipa320/cob_control/pull/51","diff_url":"https://github.com/ipa320/cob_control/pull/51.diff","patch_url":"https://github.com/ipa320/cob_control/pull/51.patch","issue_url":"https://api.github.com/repos/ipa320/cob_control/issues/51","number":51,"state":"open","locked":false,"title":"[WIP] Finalizing/Testing of TwistController features","user":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"body":"This is a WIP/CodeReview PR that still needs some more tweaking. Do not merge yet!\r\n(Mainly motivated by @ipa-fxm-mb finalizing his thesis soon)\r\n\r\nAlso, all remaining issues regarding package_xml_migration will be handled here for the following packages (as I keep merging back and forth all the time): \r\n - cob_cartesian_controller\r\n - cob_frame_tracker\r\n - cob_obstacle_distance\r\n - cob_twist_controller\r\n\r\n@ipa-fxm-mb FYI","created_at":"2015-08-13T18:27:27Z","updated_at":"2015-08-24T12:04:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd5480e1103103801a1b205f0a35965d3c7b780","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipa320/cob_control/pulls/51/commits","review_comments_url":"https://api.github.com/repos/ipa320/cob_control/pulls/51/comments","review_comment_url":"https://api.github.com/repos/ipa320/cob_control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipa320/cob_control/issues/51/comments","statuses_url":"https://api.github.com/repos/ipa320/cob_control/statuses/be69d897f12af35569743c810c8352abbae0d632","head":{"label":"ipa-fxm:test_of_feature","ref":"test_of_feature","sha":"be69d897f12af35569743c810c8352abbae0d632","user":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"repo":{"id":20218732,"name":"cob_control","full_name":"ipa-fxm/cob_control","owner":{"login":"ipa-fxm","id":508006,"avatar_url":"https://avatars.githubusercontent.com/u/508006?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa-fxm","html_url":"https://github.com/ipa-fxm","followers_url":"https://api.github.com/users/ipa-fxm/followers","following_url":"https://api.github.com/users/ipa-fxm/following{/other_user}","gists_url":"https://api.github.com/users/ipa-fxm/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-fxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-fxm/subscriptions","organizations_url":"https://api.github.com/users/ipa-fxm/orgs","repos_url":"https://api.github.com/users/ipa-fxm/repos","events_url":"https://api.github.com/users/ipa-fxm/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-fxm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ipa-fxm/cob_control","description":"The cob_control stack includes packages that are used to do low level control tasks with Care-O-bot hardware over ROS.","fork":true,"url":"https://api.github.com/repos/ipa-fxm/cob_control","forks_url":"https://api.github.com/repos/ipa-fxm/cob_control/forks","keys_url":"https://api.github.com/repos/ipa-fxm/cob_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipa-fxm/cob_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipa-fxm/cob_control/teams","hooks_url":"https://api.github.com/repos/ipa-fxm/cob_control/hooks","issue_events_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues/events{/number}","events_url":"https://api.github.com/repos/ipa-fxm/cob_control/events","assignees_url":"https://api.github.com/repos/ipa-fxm/cob_control/assignees{/user}","branches_url":"https://api.github.com/repos/ipa-fxm/cob_control/branches{/branch}","tags_url":"https://api.github.com/repos/ipa-fxm/cob_control/tags","blobs_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipa-fxm/cob_control/statuses/{sha}","languages_url":"https://api.github.com/repos/ipa-fxm/cob_control/languages","stargazers_url":"https://api.github.com/repos/ipa-fxm/cob_control/stargazers","contributors_url":"https://api.github.com/repos/ipa-fxm/cob_control/contributors","subscribers_url":"https://api.github.com/repos/ipa-fxm/cob_control/subscribers","subscription_url":"https://api.github.com/repos/ipa-fxm/cob_control/subscription","commits_url":"https://api.github.com/repos/ipa-fxm/cob_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipa-fxm/cob_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipa-fxm/cob_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipa-fxm/cob_control/contents/{+path}","compare_url":"https://api.github.com/repos/ipa-fxm/cob_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipa-fxm/cob_control/merges","archive_url":"https://api.github.com/repos/ipa-fxm/cob_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipa-fxm/cob_control/downloads","issues_url":"https://api.github.com/repos/ipa-fxm/cob_control/issues{/number}","pulls_url":"https://api.github.com/repos/ipa-fxm/cob_control/pulls{/number}","milestones_url":"https://api.github.com/repos/ipa-fxm/cob_control/milestones{/number}","notifications_url":"https://api.github.com/repos/ipa-fxm/cob_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipa-fxm/cob_control/labels{/name}","releases_url":"https://api.github.com/repos/ipa-fxm/cob_control/releases{/id}","created_at":"2014-05-27T12:11:10Z","updated_at":"2015-05-04T12:25:06Z","pushed_at":"2015-08-24T09:38:49Z","git_url":"git://github.com/ipa-fxm/cob_control.git","ssh_url":"git@github.com:ipa-fxm/cob_control.git","clone_url":"https://github.com/ipa-fxm/cob_control.git","svn_url":"https://github.com/ipa-fxm/cob_control","homepage":"www.care-o-bot.org","size":5409,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"indigo_dev"}},"base":{"label":"ipa320:indigo_dev","ref":"indigo_dev","sha":"771ed89183ca7c76de4144436455967b9f7d5646","user":{"login":"ipa320","id":155854,"avatar_url":"https://avatars.githubusercontent.com/u/155854?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa320","html_url":"https://github.com/ipa320","followers_url":"https://api.github.com/users/ipa320/followers","following_url":"https://api.github.com/users/ipa320/following{/other_user}","gists_url":"https://api.github.com/users/ipa320/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa320/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa320/subscriptions","organizations_url":"https://api.github.com/users/ipa320/orgs","repos_url":"https://api.github.com/users/ipa320/repos","events_url":"https://api.github.com/users/ipa320/events{/privacy}","received_events_url":"https://api.github.com/users/ipa320/received_events","type":"Organization","site_admin":false},"repo":{"id":19740527,"name":"cob_control","full_name":"ipa320/cob_control","owner":{"login":"ipa320","id":155854,"avatar_url":"https://avatars.githubusercontent.com/u/155854?v=3","gravatar_id":"","url":"https://api.github.com/users/ipa320","html_url":"https://github.com/ipa320","followers_url":"https://api.github.com/users/ipa320/followers","following_url":"https://api.github.com/users/ipa320/following{/other_user}","gists_url":"https://api.github.com/users/ipa320/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa320/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa320/subscriptions","organizations_url":"https://api.github.com/users/ipa320/orgs","repos_url":"https://api.github.com/users/ipa320/repos","events_url":"https://api.github.com/users/ipa320/events{/privacy}","received_events_url":"https://api.github.com/users/ipa320/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipa320/cob_control","description":"The cob_control stack includes packages that are used to do low level control tasks with Care-O-bot hardware over ROS.","fork":false,"url":"https://api.github.com/repos/ipa320/cob_control","forks_url":"https://api.github.com/repos/ipa320/cob_control/forks","keys_url":"https://api.github.com/repos/ipa320/cob_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipa320/cob_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipa320/cob_control/teams","hooks_url":"https://api.github.com/repos/ipa320/cob_control/hooks","issue_events_url":"https://api.github.com/repos/ipa320/cob_control/issues/events{/number}","events_url":"https://api.github.com/repos/ipa320/cob_control/events","assignees_url":"https://api.github.com/repos/ipa320/cob_control/assignees{/user}","branches_url":"https://api.github.com/repos/ipa320/cob_control/branches{/branch}","tags_url":"https://api.github.com/repos/ipa320/cob_control/tags","blobs_url":"https://api.github.com/repos/ipa320/cob_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipa320/cob_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipa320/cob_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipa320/cob_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipa320/cob_control/statuses/{sha}","languages_url":"https://api.github.com/repos/ipa320/cob_control/languages","stargazers_url":"https://api.github.com/repos/ipa320/cob_control/stargazers","contributors_url":"https://api.github.com/repos/ipa320/cob_control/contributors","subscribers_url":"https://api.github.com/repos/ipa320/cob_control/subscribers","subscription_url":"https://api.github.com/repos/ipa320/cob_control/subscription","commits_url":"https://api.github.com/repos/ipa320/cob_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipa320/cob_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipa320/cob_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipa320/cob_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipa320/cob_control/contents/{+path}","compare_url":"https://api.github.com/repos/ipa320/cob_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipa320/cob_control/merges","archive_url":"https://api.github.com/repos/ipa320/cob_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipa320/cob_control/downloads","issues_url":"https://api.github.com/repos/ipa320/cob_control/issues{/number}","pulls_url":"https://api.github.com/repos/ipa320/cob_control/pulls{/number}","milestones_url":"https://api.github.com/repos/ipa320/cob_control/milestones{/number}","notifications_url":"https://api.github.com/repos/ipa320/cob_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipa320/cob_control/labels{/name}","releases_url":"https://api.github.com/repos/ipa320/cob_control/releases{/id}","created_at":"2014-05-13T13:41:29Z","updated_at":"2015-05-04T12:09:27Z","pushed_at":"2015-08-24T09:38:50Z","git_url":"git://github.com/ipa320/cob_control.git","ssh_url":"git@github.com:ipa320/cob_control.git","clone_url":"https://github.com/ipa320/cob_control.git","svn_url":"https://github.com/ipa320/cob_control","homepage":"www.care-o-bot.org","size":5352,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":7,"forks":21,"open_issues":7,"watchers":0,"default_branch":"indigo_dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/51"},"html":{"href":"https://github.com/ipa320/cob_control/pull/51"},"issue":{"href":"https://api.github.com/repos/ipa320/cob_control/issues/51"},"comments":{"href":"https://api.github.com/repos/ipa320/cob_control/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipa320/cob_control/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/ipa320/cob_control/statuses/be69d897f12af35569743c810c8352abbae0d632"}}}}