{"action":"created","issue":{"url":"https://api.github.com/repos/smurfy/fahrplan/issues/201","labels_url":"https://api.github.com/repos/smurfy/fahrplan/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/smurfy/fahrplan/issues/201/comments","events_url":"https://api.github.com/repos/smurfy/fahrplan/issues/201/events","html_url":"https://github.com/smurfy/fahrplan/pull/201","id":78737115,"number":201,"title":"Fix for QObject* ownership bugs","user":{"login":"412b","id":12436202,"avatar_url":"https://avatars.githubusercontent.com/u/12436202?v=3","gravatar_id":"","url":"https://api.github.com/users/412b","html_url":"https://github.com/412b","followers_url":"https://api.github.com/users/412b/followers","following_url":"https://api.github.com/users/412b/following{/other_user}","gists_url":"https://api.github.com/users/412b/gists{/gist_id}","starred_url":"https://api.github.com/users/412b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/412b/subscriptions","organizations_url":"https://api.github.com/users/412b/orgs","repos_url":"https://api.github.com/users/412b/repos","events_url":"https://api.github.com/users/412b/events{/privacy}","received_events_url":"https://api.github.com/users/412b/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-20T23:10:07Z","updated_at":"2015-05-21T10:14:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/smurfy/fahrplan/pulls/201","html_url":"https://github.com/smurfy/fahrplan/pull/201","diff_url":"https://github.com/smurfy/fahrplan/pull/201.diff","patch_url":"https://github.com/smurfy/fahrplan/pull/201.patch"},"body":"Due to returning QObject* in calls to C++ objects from QML (e.g.\r\ngetItem(i)), those objects were changing ownership to QML and were\r\nsubject to gc. That could've been noticed during switching between\r\njourney results and journey details results (instantly switch back and\r\nforth to create enough garbage).\r\n`var item = result.getItem(i);`\r\n`item` would be null after some time. So it was ending up in page\r\nshowing loader and not doing anything or in a bit more rare cases with\r\nsegfault."},"comment":{"url":"https://api.github.com/repos/smurfy/fahrplan/issues/comments/104212929","html_url":"https://github.com/smurfy/fahrplan/pull/201#issuecomment-104212929","issue_url":"https://api.github.com/repos/smurfy/fahrplan/issues/201","id":104212929,"user":{"login":"412b","id":12436202,"avatar_url":"https://avatars.githubusercontent.com/u/12436202?v=3","gravatar_id":"","url":"https://api.github.com/users/412b","html_url":"https://github.com/412b","followers_url":"https://api.github.com/users/412b/followers","following_url":"https://api.github.com/users/412b/following{/other_user}","gists_url":"https://api.github.com/users/412b/gists{/gist_id}","starred_url":"https://api.github.com/users/412b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/412b/subscriptions","organizations_url":"https://api.github.com/users/412b/orgs","repos_url":"https://api.github.com/users/412b/repos","events_url":"https://api.github.com/users/412b/events{/privacy}","received_events_url":"https://api.github.com/users/412b/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T10:13:59Z","updated_at":"2015-05-21T10:13:59Z","body":"This changes wasn't intented to fix memory leaks in c++ part of the app.\r\ncalling `delete` will help only with a proper destructor in place and that one is missing at the moment.\r\ni can push the needed changes from my other branch."}}