{"action":"created","issue":{"url":"https://api.github.com/repos/nipy/dipy/issues/572","labels_url":"https://api.github.com/repos/nipy/dipy/issues/572/labels{/name}","comments_url":"https://api.github.com/repos/nipy/dipy/issues/572/comments","events_url":"https://api.github.com/repos/nipy/dipy/issues/572/events","html_url":"https://github.com/nipy/dipy/pull/572","id":56166328,"number":572,"title":"NF : nlmeans now support arrays of noise std","user":{"login":"samuelstjean","id":3030760,"avatar_url":"https://avatars.githubusercontent.com/u/3030760?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelstjean","html_url":"https://github.com/samuelstjean","followers_url":"https://api.github.com/users/samuelstjean/followers","following_url":"https://api.github.com/users/samuelstjean/following{/other_user}","gists_url":"https://api.github.com/users/samuelstjean/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelstjean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelstjean/subscriptions","organizations_url":"https://api.github.com/users/samuelstjean/orgs","repos_url":"https://api.github.com/users/samuelstjean/repos","events_url":"https://api.github.com/users/samuelstjean/events{/privacy}","received_events_url":"https://api.github.com/users/samuelstjean/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nipy/dipy/milestones/1","html_url":"https://github.com/nipy/dipy/milestones/0.9","labels_url":"https://api.github.com/repos/nipy/dipy/milestones/1/labels","id":1005268,"number":1,"title":"0.9","description":"","creator":{"login":"stefanv","id":45071,"avatar_url":"https://avatars.githubusercontent.com/u/45071?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanv","html_url":"https://github.com/stefanv","followers_url":"https://api.github.com/users/stefanv/followers","following_url":"https://api.github.com/users/stefanv/following{/other_user}","gists_url":"https://api.github.com/users/stefanv/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanv/subscriptions","organizations_url":"https://api.github.com/users/stefanv/orgs","repos_url":"https://api.github.com/users/stefanv/repos","events_url":"https://api.github.com/users/stefanv/events{/privacy}","received_events_url":"https://api.github.com/users/stefanv/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":10,"state":"open","created_at":"2015-03-04T08:01:43Z","updated_at":"2015-07-30T16:15:31Z","due_on":"2015-03-14T07:00:00Z","closed_at":null},"comments":31,"created_at":"2015-02-01T15:13:01Z","updated_at":"2015-08-31T19:54:33Z","closed_at":"2015-07-13T13:17:38Z","pull_request":{"url":"https://api.github.com/repos/nipy/dipy/pulls/572","html_url":"https://github.com/nipy/dipy/pull/572","diff_url":"https://github.com/nipy/dipy/pull/572.diff","patch_url":"https://github.com/nipy/dipy/pull/572.patch"},"body":"So that's it, the upper wrapper function now also supports 3D arrays in addition to a single value for the nosie standard deviation. All the inner functions now also works on arrays, but that is transparent ot the user. In addition, one can now supply his own variable estimation, such as a volume computed with piesno for example.\r\n\r\nAll the test passes for whatever it's worth, and I also ran it on a T2 image I had lying around, seems to work nicely in the same way as the old one."},"comment":{"url":"https://api.github.com/repos/nipy/dipy/issues/comments/136482265","html_url":"https://github.com/nipy/dipy/pull/572#issuecomment-136482265","issue_url":"https://api.github.com/repos/nipy/dipy/issues/572","id":136482265,"user":{"login":"samuelstjean","id":3030760,"avatar_url":"https://avatars.githubusercontent.com/u/3030760?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelstjean","html_url":"https://github.com/samuelstjean","followers_url":"https://api.github.com/users/samuelstjean/followers","following_url":"https://api.github.com/users/samuelstjean/following{/other_user}","gists_url":"https://api.github.com/users/samuelstjean/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelstjean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelstjean/subscriptions","organizations_url":"https://api.github.com/users/samuelstjean/orgs","repos_url":"https://api.github.com/users/samuelstjean/repos","events_url":"https://api.github.com/users/samuelstjean/events{/privacy}","received_events_url":"https://api.github.com/users/samuelstjean/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T19:54:33Z","updated_at":"2015-08-31T19:54:33Z","body":"The only speed drawback seems that acessing arrays in C is slower than having a single variable, that seems to be the only performance hit incurred. That being said, I also think it's a terrible idea to duplicate the whole thing just because of that, since if anything needs to be fixed/improved in the future, pretty sure one version or the other will be left behind and produce different result because of that.\r\n\r\nNow, I have no idea how the two could be used without major copy-paste of stuff and keep only a single version which would branch out in each case as needed, so if you have suggestion feel free to post stuff. And about the speed perofrmance, I don't think it can be made faster as the change is only some lines about memcopy stuff and whatnot."}}