{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3","id":47898134,"html_url":"https://github.com/alexcurtis/express-x-hub/pull/3","diff_url":"https://github.com/alexcurtis/express-x-hub/pull/3.diff","patch_url":"https://github.com/alexcurtis/express-x-hub/pull/3.patch","issue_url":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/3","number":3,"state":"open","locked":false,"title":"Add support for UTF-8 characters when calculating the signature","user":{"login":"lildude","id":627280,"avatar_url":"https://avatars.githubusercontent.com/u/627280?v=3","gravatar_id":"","url":"https://api.github.com/users/lildude","html_url":"https://github.com/lildude","followers_url":"https://api.github.com/users/lildude/followers","following_url":"https://api.github.com/users/lildude/following{/other_user}","gists_url":"https://api.github.com/users/lildude/gists{/gist_id}","starred_url":"https://api.github.com/users/lildude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lildude/subscriptions","organizations_url":"https://api.github.com/users/lildude/orgs","repos_url":"https://api.github.com/users/lildude/repos","events_url":"https://api.github.com/users/lildude/events{/privacy}","received_events_url":"https://api.github.com/users/lildude/received_events","type":"User","site_admin":true},"body":"The `crypto` module [defaults to using a `binary` encoding](https://nodejs.org/api/crypto.html#crypto_hash_update_data_input_encoding).  This doesn't play nice when using UTF-8 characters in the content the signature is being calculated for and results in an invalid signature.\r\n\r\nBy deliberately setting the hmac.update() encoding to 'utf-8' we resolve this issue.\r\n\r\nI've added a test too.","created_at":"2015-10-16T11:16:48Z","updated_at":"2015-10-16T11:16:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e8977b83541696bce4c5a097c565ecfaba0d2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3/commits","review_comments_url":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3/comments","review_comment_url":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/3/comments","statuses_url":"https://api.github.com/repos/alexcurtis/express-x-hub/statuses/c17d5e7f8cbf61a8a57748b1329364d8ec9e3354","head":{"label":"lildude:add-utf8-support","ref":"add-utf8-support","sha":"c17d5e7f8cbf61a8a57748b1329364d8ec9e3354","user":{"login":"lildude","id":627280,"avatar_url":"https://avatars.githubusercontent.com/u/627280?v=3","gravatar_id":"","url":"https://api.github.com/users/lildude","html_url":"https://github.com/lildude","followers_url":"https://api.github.com/users/lildude/followers","following_url":"https://api.github.com/users/lildude/following{/other_user}","gists_url":"https://api.github.com/users/lildude/gists{/gist_id}","starred_url":"https://api.github.com/users/lildude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lildude/subscriptions","organizations_url":"https://api.github.com/users/lildude/orgs","repos_url":"https://api.github.com/users/lildude/repos","events_url":"https://api.github.com/users/lildude/events{/privacy}","received_events_url":"https://api.github.com/users/lildude/received_events","type":"User","site_admin":true},"repo":{"id":44379445,"name":"express-x-hub","full_name":"lildude/express-x-hub","owner":{"login":"lildude","id":627280,"avatar_url":"https://avatars.githubusercontent.com/u/627280?v=3","gravatar_id":"","url":"https://api.github.com/users/lildude","html_url":"https://github.com/lildude","followers_url":"https://api.github.com/users/lildude/followers","following_url":"https://api.github.com/users/lildude/following{/other_user}","gists_url":"https://api.github.com/users/lildude/gists{/gist_id}","starred_url":"https://api.github.com/users/lildude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lildude/subscriptions","organizations_url":"https://api.github.com/users/lildude/orgs","repos_url":"https://api.github.com/users/lildude/repos","events_url":"https://api.github.com/users/lildude/events{/privacy}","received_events_url":"https://api.github.com/users/lildude/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/lildude/express-x-hub","description":"X-Hub-Signature Express.js Middleware","fork":true,"url":"https://api.github.com/repos/lildude/express-x-hub","forks_url":"https://api.github.com/repos/lildude/express-x-hub/forks","keys_url":"https://api.github.com/repos/lildude/express-x-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lildude/express-x-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lildude/express-x-hub/teams","hooks_url":"https://api.github.com/repos/lildude/express-x-hub/hooks","issue_events_url":"https://api.github.com/repos/lildude/express-x-hub/issues/events{/number}","events_url":"https://api.github.com/repos/lildude/express-x-hub/events","assignees_url":"https://api.github.com/repos/lildude/express-x-hub/assignees{/user}","branches_url":"https://api.github.com/repos/lildude/express-x-hub/branches{/branch}","tags_url":"https://api.github.com/repos/lildude/express-x-hub/tags","blobs_url":"https://api.github.com/repos/lildude/express-x-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lildude/express-x-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lildude/express-x-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/lildude/express-x-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lildude/express-x-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/lildude/express-x-hub/languages","stargazers_url":"https://api.github.com/repos/lildude/express-x-hub/stargazers","contributors_url":"https://api.github.com/repos/lildude/express-x-hub/contributors","subscribers_url":"https://api.github.com/repos/lildude/express-x-hub/subscribers","subscription_url":"https://api.github.com/repos/lildude/express-x-hub/subscription","commits_url":"https://api.github.com/repos/lildude/express-x-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/lildude/express-x-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/lildude/express-x-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/lildude/express-x-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/lildude/express-x-hub/contents/{+path}","compare_url":"https://api.github.com/repos/lildude/express-x-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lildude/express-x-hub/merges","archive_url":"https://api.github.com/repos/lildude/express-x-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lildude/express-x-hub/downloads","issues_url":"https://api.github.com/repos/lildude/express-x-hub/issues{/number}","pulls_url":"https://api.github.com/repos/lildude/express-x-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/lildude/express-x-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/lildude/express-x-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lildude/express-x-hub/labels{/name}","releases_url":"https://api.github.com/repos/lildude/express-x-hub/releases{/id}","created_at":"2015-10-16T10:53:16Z","updated_at":"2015-10-16T10:53:16Z","pushed_at":"2015-10-16T11:13:37Z","git_url":"git://github.com/lildude/express-x-hub.git","ssh_url":"git@github.com:lildude/express-x-hub.git","clone_url":"https://github.com/lildude/express-x-hub.git","svn_url":"https://github.com/lildude/express-x-hub","homepage":"","size":94,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexcurtis:master","ref":"master","sha":"908a674f92a9f37ab204f47b2e4b5337ec053a98","user":{"login":"alexcurtis","id":379213,"avatar_url":"https://avatars.githubusercontent.com/u/379213?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcurtis","html_url":"https://github.com/alexcurtis","followers_url":"https://api.github.com/users/alexcurtis/followers","following_url":"https://api.github.com/users/alexcurtis/following{/other_user}","gists_url":"https://api.github.com/users/alexcurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcurtis/subscriptions","organizations_url":"https://api.github.com/users/alexcurtis/orgs","repos_url":"https://api.github.com/users/alexcurtis/repos","events_url":"https://api.github.com/users/alexcurtis/events{/privacy}","received_events_url":"https://api.github.com/users/alexcurtis/received_events","type":"User","site_admin":false},"repo":{"id":19919792,"name":"express-x-hub","full_name":"alexcurtis/express-x-hub","owner":{"login":"alexcurtis","id":379213,"avatar_url":"https://avatars.githubusercontent.com/u/379213?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcurtis","html_url":"https://github.com/alexcurtis","followers_url":"https://api.github.com/users/alexcurtis/followers","following_url":"https://api.github.com/users/alexcurtis/following{/other_user}","gists_url":"https://api.github.com/users/alexcurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcurtis/subscriptions","organizations_url":"https://api.github.com/users/alexcurtis/orgs","repos_url":"https://api.github.com/users/alexcurtis/repos","events_url":"https://api.github.com/users/alexcurtis/events{/privacy}","received_events_url":"https://api.github.com/users/alexcurtis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcurtis/express-x-hub","description":"X-Hub-Signature Express.js Middleware","fork":false,"url":"https://api.github.com/repos/alexcurtis/express-x-hub","forks_url":"https://api.github.com/repos/alexcurtis/express-x-hub/forks","keys_url":"https://api.github.com/repos/alexcurtis/express-x-hub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcurtis/express-x-hub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcurtis/express-x-hub/teams","hooks_url":"https://api.github.com/repos/alexcurtis/express-x-hub/hooks","issue_events_url":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/events{/number}","events_url":"https://api.github.com/repos/alexcurtis/express-x-hub/events","assignees_url":"https://api.github.com/repos/alexcurtis/express-x-hub/assignees{/user}","branches_url":"https://api.github.com/repos/alexcurtis/express-x-hub/branches{/branch}","tags_url":"https://api.github.com/repos/alexcurtis/express-x-hub/tags","blobs_url":"https://api.github.com/repos/alexcurtis/express-x-hub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcurtis/express-x-hub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcurtis/express-x-hub/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcurtis/express-x-hub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcurtis/express-x-hub/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcurtis/express-x-hub/languages","stargazers_url":"https://api.github.com/repos/alexcurtis/express-x-hub/stargazers","contributors_url":"https://api.github.com/repos/alexcurtis/express-x-hub/contributors","subscribers_url":"https://api.github.com/repos/alexcurtis/express-x-hub/subscribers","subscription_url":"https://api.github.com/repos/alexcurtis/express-x-hub/subscription","commits_url":"https://api.github.com/repos/alexcurtis/express-x-hub/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcurtis/express-x-hub/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcurtis/express-x-hub/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcurtis/express-x-hub/contents/{+path}","compare_url":"https://api.github.com/repos/alexcurtis/express-x-hub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcurtis/express-x-hub/merges","archive_url":"https://api.github.com/repos/alexcurtis/express-x-hub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcurtis/express-x-hub/downloads","issues_url":"https://api.github.com/repos/alexcurtis/express-x-hub/issues{/number}","pulls_url":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcurtis/express-x-hub/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcurtis/express-x-hub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcurtis/express-x-hub/labels{/name}","releases_url":"https://api.github.com/repos/alexcurtis/express-x-hub/releases{/id}","created_at":"2014-05-18T20:04:04Z","updated_at":"2015-06-17T16:14:32Z","pushed_at":"2015-10-16T11:16:48Z","git_url":"git://github.com/alexcurtis/express-x-hub.git","ssh_url":"git@github.com:alexcurtis/express-x-hub.git","clone_url":"https://github.com/alexcurtis/express-x-hub.git","svn_url":"https://github.com/alexcurtis/express-x-hub","homepage":"","size":246,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3"},"html":{"href":"https://github.com/alexcurtis/express-x-hub/pull/3"},"issue":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/3"},"comments":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/alexcurtis/express-x-hub/statuses/c17d5e7f8cbf61a8a57748b1329364d8ec9e3354"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":8,"deletions":1,"changed_files":2}}