{"action":"created","comment":{"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/comments/44617216","id":44617216,"diff_hunk":"@@ -70,34 +69,32 @@ public static void sStop() {\n         singleton = null;\n     }\n \n-    public static boolean IsConfigured(Context ctx) {\n+    public static boolean isConfigured(Context ctx) {\n         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(ctx);\n         String recieversIpAddresses = prefs.getString(\"wifi_recievers_addresses\", \"\");\n-        if(recieversIpAddresses == null || recieversIpAddresses.equals(\"\") ) {\n+        if (recieversIpAddresses == null || recieversIpAddresses.equals(\"\")) {\n             return false;\n         }\n         return true;\n     }\n \n-    public static boolean almostEquals( TransmitterRawData e1, TransmitterRawData e2)\n-    {\n-        if (e1 == null || e2==null) {\n+    public static boolean almostEquals(TransmitterRawData e1, TransmitterRawData e2) {\n+        if (e1 == null || e2 == null) {\n             return false;\n         }\n         // relative time is in ms\n-        if ((Math.abs(e1.CaptureDateTime - e2.CaptureDateTime) < 120 * 1000 ) &&\n+        if ((Math.abs(e1.CaptureDateTime - e2.CaptureDateTime) < 120 * 1000) &&\n                 (e1.TransmissionId == e2.TransmissionId)) {\n             return true;\n         }\n         return false;\n     }\n \n- // last in the array, is first in time\n-    public static List<TransmitterRawData> Merge2Lists(List<TransmitterRawData> list1 , List<TransmitterRawData> list2)\n-    {\n-        List<TransmitterRawData> merged = new LinkedList <TransmitterRawData>();\n+    // last in the array, is first in time\n+    public static List<TransmitterRawData> merge2Lists(List<TransmitterRawData> list1, List<TransmitterRawData> list2) {","path":"app/src/main/java/com/eveningoutpost/dexdrip/Services/WixelReader.java","position":93,"original_position":93,"commit_id":"60e360544c38af14123e2b9f7ff5d8f2efc8b631","original_commit_id":"60e360544c38af14123e2b9f7ff5d8f2efc8b631","user":{"login":"mgranberry","id":152687,"avatar_url":"https://avatars.githubusercontent.com/u/152687?v=3","gravatar_id":"","url":"https://api.github.com/users/mgranberry","html_url":"https://github.com/mgranberry","followers_url":"https://api.github.com/users/mgranberry/followers","following_url":"https://api.github.com/users/mgranberry/following{/other_user}","gists_url":"https://api.github.com/users/mgranberry/gists{/gist_id}","starred_url":"https://api.github.com/users/mgranberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgranberry/subscriptions","organizations_url":"https://api.github.com/users/mgranberry/orgs","repos_url":"https://api.github.com/users/mgranberry/repos","events_url":"https://api.github.com/users/mgranberry/events{/privacy}","received_events_url":"https://api.github.com/users/mgranberry/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/versioned/images/favicon.png) Issue found: [The method merge2Lists() has an NPath complexity of 49](https://www.codacy.com/app/matthias-granberry/xDrip-Experimental/file/1313443989/issues/source?bid=2735053&fileBranchId=2735067#l94)","created_at":"2015-11-12T03:02:12Z","updated_at":"2015-11-12T03:02:12Z","html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75#discussion_r44617216","pull_request_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/comments/44617216"},"html":{"href":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75#discussion_r44617216"},"pull_request":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75","id":38392902,"html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75","diff_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75.diff","patch_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75.patch","issue_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/75","number":75,"state":"open","locked":false,"title":"Small code cleanup","user":{"login":"AdrianLxM","id":9692866,"avatar_url":"https://avatars.githubusercontent.com/u/9692866?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianLxM","html_url":"https://github.com/AdrianLxM","followers_url":"https://api.github.com/users/AdrianLxM/followers","following_url":"https://api.github.com/users/AdrianLxM/following{/other_user}","gists_url":"https://api.github.com/users/AdrianLxM/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianLxM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianLxM/subscriptions","organizations_url":"https://api.github.com/users/AdrianLxM/orgs","repos_url":"https://api.github.com/users/AdrianLxM/repos","events_url":"https://api.github.com/users/AdrianLxM/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianLxM/received_events","type":"User","site_admin":false},"body":"I just did some small changes to make the code better readable:\r\n\r\nchanged local variables to lower case (Usually class names start with capital letters, method calls are now distinguishable from static calls)\r\nchanged constructor to private (full singleton design pattern)\r\nran automatic code rearrangement in Android Studio\r\nran automatic code formatting standardization in Android Studio","created_at":"2015-06-23T23:09:37Z","updated_at":"2015-11-12T03:02:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8f360fe83d1d828f4ff84765d789ecbbda229de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75/commits","review_comments_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75/comments","review_comment_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/75/comments","statuses_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/statuses/60e360544c38af14123e2b9f7ff5d8f2efc8b631","head":{"label":"AdrianLxM:patch-3","ref":"patch-3","sha":"60e360544c38af14123e2b9f7ff5d8f2efc8b631","user":{"login":"AdrianLxM","id":9692866,"avatar_url":"https://avatars.githubusercontent.com/u/9692866?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianLxM","html_url":"https://github.com/AdrianLxM","followers_url":"https://api.github.com/users/AdrianLxM/followers","following_url":"https://api.github.com/users/AdrianLxM/following{/other_user}","gists_url":"https://api.github.com/users/AdrianLxM/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianLxM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianLxM/subscriptions","organizations_url":"https://api.github.com/users/AdrianLxM/orgs","repos_url":"https://api.github.com/users/AdrianLxM/repos","events_url":"https://api.github.com/users/AdrianLxM/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianLxM/received_events","type":"User","site_admin":false},"repo":{"id":36123212,"name":"xDrip-Experimental","full_name":"AdrianLxM/xDrip-Experimental","owner":{"login":"AdrianLxM","id":9692866,"avatar_url":"https://avatars.githubusercontent.com/u/9692866?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianLxM","html_url":"https://github.com/AdrianLxM","followers_url":"https://api.github.com/users/AdrianLxM/followers","following_url":"https://api.github.com/users/AdrianLxM/following{/other_user}","gists_url":"https://api.github.com/users/AdrianLxM/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianLxM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianLxM/subscriptions","organizations_url":"https://api.github.com/users/AdrianLxM/orgs","repos_url":"https://api.github.com/users/AdrianLxM/repos","events_url":"https://api.github.com/users/AdrianLxM/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianLxM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdrianLxM/xDrip-Experimental","description":"Experimental Branches for Collaboration on DexDrip","fork":true,"url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental","forks_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/forks","keys_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/teams","hooks_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/hooks","issue_events_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/issues/events{/number}","events_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/events","assignees_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/assignees{/user}","branches_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/branches{/branch}","tags_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/tags","blobs_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/languages","stargazers_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/stargazers","contributors_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/contributors","subscribers_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/subscribers","subscription_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/subscription","commits_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/contents/{+path}","compare_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/merges","archive_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/downloads","issues_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/issues{/number}","pulls_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/labels{/name}","releases_url":"https://api.github.com/repos/AdrianLxM/xDrip-Experimental/releases{/id}","created_at":"2015-05-23T12:56:42Z","updated_at":"2015-05-23T12:56:43Z","pushed_at":"2015-09-30T13:33:50Z","git_url":"git://github.com/AdrianLxM/xDrip-Experimental.git","ssh_url":"git@github.com:AdrianLxM/xDrip-Experimental.git","clone_url":"https://github.com/AdrianLxM/xDrip-Experimental.git","svn_url":"https://github.com/AdrianLxM/xDrip-Experimental","homepage":null,"size":5685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StephenBlackWasAlreadyTaken:master","ref":"master","sha":"24f357cd624e74471c15e9068261b27e701e1fb7","user":{"login":"StephenBlackWasAlreadyTaken","id":649942,"avatar_url":"https://avatars.githubusercontent.com/u/649942?v=3","gravatar_id":"","url":"https://api.github.com/users/StephenBlackWasAlreadyTaken","html_url":"https://github.com/StephenBlackWasAlreadyTaken","followers_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/followers","following_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/following{/other_user}","gists_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/subscriptions","organizations_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/orgs","repos_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/repos","events_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/events{/privacy}","received_events_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/received_events","type":"User","site_admin":false},"repo":{"id":30898542,"name":"xDrip-Experimental","full_name":"StephenBlackWasAlreadyTaken/xDrip-Experimental","owner":{"login":"StephenBlackWasAlreadyTaken","id":649942,"avatar_url":"https://avatars.githubusercontent.com/u/649942?v=3","gravatar_id":"","url":"https://api.github.com/users/StephenBlackWasAlreadyTaken","html_url":"https://github.com/StephenBlackWasAlreadyTaken","followers_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/followers","following_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/following{/other_user}","gists_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/subscriptions","organizations_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/orgs","repos_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/repos","events_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/events{/privacy}","received_events_url":"https://api.github.com/users/StephenBlackWasAlreadyTaken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental","description":"Experimental Branches for Collaboration on DexDrip","fork":false,"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental","forks_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/forks","keys_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/teams","hooks_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/hooks","issue_events_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/events{/number}","events_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/events","assignees_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/assignees{/user}","branches_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/branches{/branch}","tags_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/tags","blobs_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/languages","stargazers_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/stargazers","contributors_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/contributors","subscribers_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/subscribers","subscription_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/subscription","commits_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/contents/{+path}","compare_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/merges","archive_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/downloads","issues_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues{/number}","pulls_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/labels{/name}","releases_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/releases{/id}","created_at":"2015-02-17T02:04:01Z","updated_at":"2015-10-18T07:32:36Z","pushed_at":"2015-11-11T04:11:07Z","git_url":"git://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental.git","ssh_url":"git@github.com:StephenBlackWasAlreadyTaken/xDrip-Experimental.git","clone_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental.git","svn_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental","homepage":null,"size":6920,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":19,"forks":37,"open_issues":19,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75"},"html":{"href":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/75"},"issue":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/75"},"comments":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/statuses/60e360544c38af14123e2b9f7ff5d8f2efc8b631"}}}}