{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85","id":43120501,"html_url":"https://github.com/swmaestro06-apus/apus/pull/85","diff_url":"https://github.com/swmaestro06-apus/apus/pull/85.diff","patch_url":"https://github.com/swmaestro06-apus/apus/pull/85.patch","issue_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/85","number":85,"state":"closed","locked":false,"title":"Jeongmin/vm/data type table v3","user":{"login":"JeongMinCha","id":4997737,"avatar_url":"https://avatars.githubusercontent.com/u/4997737?v=3","gravatar_id":"","url":"https://api.github.com/users/JeongMinCha","html_url":"https://github.com/JeongMinCha","followers_url":"https://api.github.com/users/JeongMinCha/followers","following_url":"https://api.github.com/users/JeongMinCha/following{/other_user}","gists_url":"https://api.github.com/users/JeongMinCha/gists{/gist_id}","starred_url":"https://api.github.com/users/JeongMinCha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeongMinCha/subscriptions","organizations_url":"https://api.github.com/users/JeongMinCha/orgs","repos_url":"https://api.github.com/users/JeongMinCha/repos","events_url":"https://api.github.com/users/JeongMinCha/events{/privacy}","received_events_url":"https://api.github.com/users/JeongMinCha/received_events","type":"User","site_admin":false},"body":"이전 커멘트를 남기고자 v2 PR은 남겨두었습니다\r\n\r\n1. ToString -> type_to_string으로 변경하였고\r\n2. 모든 타입에 대해서 string 전부 출력할 수 있도록 수정했습니다 \r\n3. 가장 마지막 테스트 루틴에 data type table에 있는 data type들이 있는지 ASSERT로 확인하면서, 그 안에 내부에 있는 Data type까지 확인하는 루틴을 추가하였습니다.","created_at":"2015-08-23T12:27:39Z","updated_at":"2015-08-23T15:12:49Z","closed_at":"2015-08-23T15:12:49Z","merged_at":"2015-08-23T15:12:49Z","merge_commit_sha":"34185c138ee152cb5faf06102d03f184a46d236a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85/commits","review_comments_url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85/comments","review_comment_url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/85/comments","statuses_url":"https://api.github.com/repos/swmaestro06-apus/apus/statuses/8b6b881e3fbb96d7644498306a99100336697241","head":{"label":"swmaestro06-apus:jeongmin/vm/data_type_table-v3","ref":"jeongmin/vm/data_type_table-v3","sha":"8b6b881e3fbb96d7644498306a99100336697241","user":{"login":"swmaestro06-apus","id":13348818,"avatar_url":"https://avatars.githubusercontent.com/u/13348818?v=3","gravatar_id":"","url":"https://api.github.com/users/swmaestro06-apus","html_url":"https://github.com/swmaestro06-apus","followers_url":"https://api.github.com/users/swmaestro06-apus/followers","following_url":"https://api.github.com/users/swmaestro06-apus/following{/other_user}","gists_url":"https://api.github.com/users/swmaestro06-apus/gists{/gist_id}","starred_url":"https://api.github.com/users/swmaestro06-apus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swmaestro06-apus/subscriptions","organizations_url":"https://api.github.com/users/swmaestro06-apus/orgs","repos_url":"https://api.github.com/users/swmaestro06-apus/repos","events_url":"https://api.github.com/users/swmaestro06-apus/events{/privacy}","received_events_url":"https://api.github.com/users/swmaestro06-apus/received_events","type":"Organization","site_admin":false},"repo":{"id":39132675,"name":"apus","full_name":"swmaestro06-apus/apus","owner":{"login":"swmaestro06-apus","id":13348818,"avatar_url":"https://avatars.githubusercontent.com/u/13348818?v=3","gravatar_id":"","url":"https://api.github.com/users/swmaestro06-apus","html_url":"https://github.com/swmaestro06-apus","followers_url":"https://api.github.com/users/swmaestro06-apus/followers","following_url":"https://api.github.com/users/swmaestro06-apus/following{/other_user}","gists_url":"https://api.github.com/users/swmaestro06-apus/gists{/gist_id}","starred_url":"https://api.github.com/users/swmaestro06-apus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swmaestro06-apus/subscriptions","organizations_url":"https://api.github.com/users/swmaestro06-apus/orgs","repos_url":"https://api.github.com/users/swmaestro06-apus/repos","events_url":"https://api.github.com/users/swmaestro06-apus/events{/privacy}","received_events_url":"https://api.github.com/users/swmaestro06-apus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swmaestro06-apus/apus","description":"apus program. it's a binary parser using programmable formats.","fork":false,"url":"https://api.github.com/repos/swmaestro06-apus/apus","forks_url":"https://api.github.com/repos/swmaestro06-apus/apus/forks","keys_url":"https://api.github.com/repos/swmaestro06-apus/apus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swmaestro06-apus/apus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swmaestro06-apus/apus/teams","hooks_url":"https://api.github.com/repos/swmaestro06-apus/apus/hooks","issue_events_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/events{/number}","events_url":"https://api.github.com/repos/swmaestro06-apus/apus/events","assignees_url":"https://api.github.com/repos/swmaestro06-apus/apus/assignees{/user}","branches_url":"https://api.github.com/repos/swmaestro06-apus/apus/branches{/branch}","tags_url":"https://api.github.com/repos/swmaestro06-apus/apus/tags","blobs_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/refs{/sha}","trees_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swmaestro06-apus/apus/statuses/{sha}","languages_url":"https://api.github.com/repos/swmaestro06-apus/apus/languages","stargazers_url":"https://api.github.com/repos/swmaestro06-apus/apus/stargazers","contributors_url":"https://api.github.com/repos/swmaestro06-apus/apus/contributors","subscribers_url":"https://api.github.com/repos/swmaestro06-apus/apus/subscribers","subscription_url":"https://api.github.com/repos/swmaestro06-apus/apus/subscription","commits_url":"https://api.github.com/repos/swmaestro06-apus/apus/commits{/sha}","git_commits_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/commits{/sha}","comments_url":"https://api.github.com/repos/swmaestro06-apus/apus/comments{/number}","issue_comment_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/comments{/number}","contents_url":"https://api.github.com/repos/swmaestro06-apus/apus/contents/{+path}","compare_url":"https://api.github.com/repos/swmaestro06-apus/apus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swmaestro06-apus/apus/merges","archive_url":"https://api.github.com/repos/swmaestro06-apus/apus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swmaestro06-apus/apus/downloads","issues_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues{/number}","pulls_url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls{/number}","milestones_url":"https://api.github.com/repos/swmaestro06-apus/apus/milestones{/number}","notifications_url":"https://api.github.com/repos/swmaestro06-apus/apus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swmaestro06-apus/apus/labels{/name}","releases_url":"https://api.github.com/repos/swmaestro06-apus/apus/releases{/id}","created_at":"2015-07-15T11:15:18Z","updated_at":"2015-08-04T03:54:32Z","pushed_at":"2015-08-23T15:12:50Z","git_url":"git://github.com/swmaestro06-apus/apus.git","ssh_url":"git@github.com:swmaestro06-apus/apus.git","clone_url":"https://github.com/swmaestro06-apus/apus.git","svn_url":"https://github.com/swmaestro06-apus/apus","homepage":null,"size":9964,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"swmaestro06-apus:master","ref":"master","sha":"d3b75f5bb45153b81d463045267340a6c7322c12","user":{"login":"swmaestro06-apus","id":13348818,"avatar_url":"https://avatars.githubusercontent.com/u/13348818?v=3","gravatar_id":"","url":"https://api.github.com/users/swmaestro06-apus","html_url":"https://github.com/swmaestro06-apus","followers_url":"https://api.github.com/users/swmaestro06-apus/followers","following_url":"https://api.github.com/users/swmaestro06-apus/following{/other_user}","gists_url":"https://api.github.com/users/swmaestro06-apus/gists{/gist_id}","starred_url":"https://api.github.com/users/swmaestro06-apus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swmaestro06-apus/subscriptions","organizations_url":"https://api.github.com/users/swmaestro06-apus/orgs","repos_url":"https://api.github.com/users/swmaestro06-apus/repos","events_url":"https://api.github.com/users/swmaestro06-apus/events{/privacy}","received_events_url":"https://api.github.com/users/swmaestro06-apus/received_events","type":"Organization","site_admin":false},"repo":{"id":39132675,"name":"apus","full_name":"swmaestro06-apus/apus","owner":{"login":"swmaestro06-apus","id":13348818,"avatar_url":"https://avatars.githubusercontent.com/u/13348818?v=3","gravatar_id":"","url":"https://api.github.com/users/swmaestro06-apus","html_url":"https://github.com/swmaestro06-apus","followers_url":"https://api.github.com/users/swmaestro06-apus/followers","following_url":"https://api.github.com/users/swmaestro06-apus/following{/other_user}","gists_url":"https://api.github.com/users/swmaestro06-apus/gists{/gist_id}","starred_url":"https://api.github.com/users/swmaestro06-apus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swmaestro06-apus/subscriptions","organizations_url":"https://api.github.com/users/swmaestro06-apus/orgs","repos_url":"https://api.github.com/users/swmaestro06-apus/repos","events_url":"https://api.github.com/users/swmaestro06-apus/events{/privacy}","received_events_url":"https://api.github.com/users/swmaestro06-apus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swmaestro06-apus/apus","description":"apus program. it's a binary parser using programmable formats.","fork":false,"url":"https://api.github.com/repos/swmaestro06-apus/apus","forks_url":"https://api.github.com/repos/swmaestro06-apus/apus/forks","keys_url":"https://api.github.com/repos/swmaestro06-apus/apus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swmaestro06-apus/apus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swmaestro06-apus/apus/teams","hooks_url":"https://api.github.com/repos/swmaestro06-apus/apus/hooks","issue_events_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/events{/number}","events_url":"https://api.github.com/repos/swmaestro06-apus/apus/events","assignees_url":"https://api.github.com/repos/swmaestro06-apus/apus/assignees{/user}","branches_url":"https://api.github.com/repos/swmaestro06-apus/apus/branches{/branch}","tags_url":"https://api.github.com/repos/swmaestro06-apus/apus/tags","blobs_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/refs{/sha}","trees_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swmaestro06-apus/apus/statuses/{sha}","languages_url":"https://api.github.com/repos/swmaestro06-apus/apus/languages","stargazers_url":"https://api.github.com/repos/swmaestro06-apus/apus/stargazers","contributors_url":"https://api.github.com/repos/swmaestro06-apus/apus/contributors","subscribers_url":"https://api.github.com/repos/swmaestro06-apus/apus/subscribers","subscription_url":"https://api.github.com/repos/swmaestro06-apus/apus/subscription","commits_url":"https://api.github.com/repos/swmaestro06-apus/apus/commits{/sha}","git_commits_url":"https://api.github.com/repos/swmaestro06-apus/apus/git/commits{/sha}","comments_url":"https://api.github.com/repos/swmaestro06-apus/apus/comments{/number}","issue_comment_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues/comments{/number}","contents_url":"https://api.github.com/repos/swmaestro06-apus/apus/contents/{+path}","compare_url":"https://api.github.com/repos/swmaestro06-apus/apus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swmaestro06-apus/apus/merges","archive_url":"https://api.github.com/repos/swmaestro06-apus/apus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swmaestro06-apus/apus/downloads","issues_url":"https://api.github.com/repos/swmaestro06-apus/apus/issues{/number}","pulls_url":"https://api.github.com/repos/swmaestro06-apus/apus/pulls{/number}","milestones_url":"https://api.github.com/repos/swmaestro06-apus/apus/milestones{/number}","notifications_url":"https://api.github.com/repos/swmaestro06-apus/apus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swmaestro06-apus/apus/labels{/name}","releases_url":"https://api.github.com/repos/swmaestro06-apus/apus/releases{/id}","created_at":"2015-07-15T11:15:18Z","updated_at":"2015-08-04T03:54:32Z","pushed_at":"2015-08-23T15:12:50Z","git_url":"git://github.com/swmaestro06-apus/apus.git","ssh_url":"git@github.com:swmaestro06-apus/apus.git","clone_url":"https://github.com/swmaestro06-apus/apus.git","svn_url":"https://github.com/swmaestro06-apus/apus","homepage":null,"size":9964,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85"},"html":{"href":"https://github.com/swmaestro06-apus/apus/pull/85"},"issue":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/issues/85"},"comments":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/swmaestro06-apus/apus/statuses/8b6b881e3fbb96d7644498306a99100336697241"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"namhyung","id":48503,"avatar_url":"https://avatars.githubusercontent.com/u/48503?v=3","gravatar_id":"","url":"https://api.github.com/users/namhyung","html_url":"https://github.com/namhyung","followers_url":"https://api.github.com/users/namhyung/followers","following_url":"https://api.github.com/users/namhyung/following{/other_user}","gists_url":"https://api.github.com/users/namhyung/gists{/gist_id}","starred_url":"https://api.github.com/users/namhyung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namhyung/subscriptions","organizations_url":"https://api.github.com/users/namhyung/orgs","repos_url":"https://api.github.com/users/namhyung/repos","events_url":"https://api.github.com/users/namhyung/events{/privacy}","received_events_url":"https://api.github.com/users/namhyung/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":6,"additions":518,"deletions":34,"changed_files":7}}