{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/26540527","id":26540527,"diff_hunk":"@@ -250,25 +251,79 @@ public TagHelperContent EndTagHelperWritingScope()\n         }\n \n         /// <summary>\n-        /// Writes an <see cref=\"ITextWriterCopyable\"/> to the <see cref=\"Output\"/>.\n+        /// Writes the output of a specified <see cref=\"TagHelperExecutionContext\"/>.\n         /// </summary>\n-        /// <param name=\"copyableTextWriter\">Contains the data to be written.</param>\n-        public void Write(ITextWriterCopyable copyableTextWriter)\n+        /// <param name=\"tagHelperExecutionContext\">The execution context containing the output.</param>\n+        public async Task WriteTagHelperAsync([NotNull] TagHelperExecutionContext tagHelperExecutionContext)\n         {\n-            WriteTo(Output, copyableTextWriter);\n+            await WriteTagHelperToAsync(Output, tagHelperExecutionContext);\n         }\n \n         /// <summary>\n-        /// Writes an <see cref=\"ITextWriterCopyable\"/> to the <paramref name=\"writer\"/>.\n+        /// Wrutes the output of a specified <see cref=\"TagHelperExecutionContext\"/> to the specified\n+        /// <paramref name=\"writer\"/>.\n         /// </summary>\n-        /// <param name=\"writer\">The <see cref=\"TextWriter\"/> to which the\n-        /// <paramref name=\"copyableTextWriter\"/> is written.</param>\n-        /// <param name=\"copyableTextWriter\">Contains the data to be written.</param>\n-        public void WriteTo([NotNull] TextWriter writer, ITextWriterCopyable copyableTextWriter)\n+        /// <param name=\"writer\">The <see cref=\"TextWriter\"/> instance to write to.</param>\n+        /// <param name=\"tagHelperExecutionContext\">The execution context containing the output.</param>\n+        public async Task WriteTagHelperToAsync(\n+            [NotNull] TextWriter writer, [NotNull] TagHelperExecutionContext tagHelperExecutionContext)\n+        {\n+            var tagHelperOutput = tagHelperExecutionContext.Output;\n+            var isTagNameNullOrWhitespace = string.IsNullOrWhiteSpace(tagHelperOutput.TagName);\n+\n+            if (!isTagNameNullOrWhitespace)\n+            {\n+                writer.Write('<');\n+                writer.Write(tagHelperOutput.TagName);\n+\n+                foreach (var attribute in tagHelperOutput.Attributes)\n+                {\n+                    var value = HtmlEncoder.HtmlEncode(attribute.Value);\n+                    writer.Write(' ');\n+                    writer.Write(attribute.Key);\n+                    writer.Write(\"=\\\"\");\n+                    writer.Write(value);\n+                    writer.Write('\"');\n+                }\n+\n+                if (tagHelperOutput.SelfClosing)\n+                {\n+                    writer.Write(\" /\");\n+                }\n+\n+                writer.Write('>');\n+            }\n+\n+            if (isTagNameNullOrWhitespace || !tagHelperOutput.SelfClosing)\n+            {\n+                WriteTagHelperContentTo(writer, tagHelperOutput.PreContent);\n+                if (tagHelperOutput.IsContentModified)\n+                {\n+                    WriteTagHelperContentTo(writer, tagHelperOutput.Content);\n+                }\n+                else if (tagHelperExecutionContext.ChildContentRetrieved)\n+                {\n+                    WriteTagHelperContentTo(writer, await tagHelperExecutionContext.GetChildContentAsync());","path":"src/Microsoft.AspNet.Mvc.Razor/RazorPage.cs","position":73,"original_position":73,"commit_id":"09ca55a191d275255c3d1e44af1d7bca3c077e2a","original_commit_id":"09ca55a191d275255c3d1e44af1d7bca3c077e2a","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"break this bit into two since it's now in a helper method and not code gen'd:\r\n```C#\r\nvar childContent = await tagHelperExecutionContext.GetChildContentAsync();\r\nWriteTagHelperContentTo(writer, childContent);\r\n```","created_at":"2015-03-17T00:24:34Z","updated_at":"2015-03-17T00:24:34Z","html_url":"https://github.com/aspnet/Mvc/pull/2180#discussion_r26540527","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2180","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/26540527"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2180#discussion_r26540527"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2180"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2180","id":31265742,"html_url":"https://github.com/aspnet/Mvc/pull/2180","diff_url":"https://github.com/aspnet/Mvc/pull/2180.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2180.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2180","number":2180,"state":"open","locked":false,"title":"Reacting to Razor changes for removing Generate*() methods.","user":{"login":"sornaks","id":6588965,"avatar_url":"https://avatars.githubusercontent.com/u/6588965?v=3","gravatar_id":"","url":"https://api.github.com/users/sornaks","html_url":"https://github.com/sornaks","followers_url":"https://api.github.com/users/sornaks/followers","following_url":"https://api.github.com/users/sornaks/following{/other_user}","gists_url":"https://api.github.com/users/sornaks/gists{/gist_id}","starred_url":"https://api.github.com/users/sornaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sornaks/subscriptions","organizations_url":"https://api.github.com/users/sornaks/orgs","repos_url":"https://api.github.com/users/sornaks/repos","events_url":"https://api.github.com/users/sornaks/events{/privacy}","received_events_url":"https://api.github.com/users/sornaks/received_events","type":"User","site_admin":false},"body":"1. Removed HtmlEncoder dependency for TagHelperOutput.\r\n2. Removed ITextWriterCopyable dependency.\r\n3. Removed Write/WriteTo for TagHelperContent.\r\n4. Added WriteTagHelper/WriteTagHelperTo methods.\r\n5. Updated tests for the same.","created_at":"2015-03-16T17:33:05Z","updated_at":"2015-03-17T00:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11a3c57faf298cbb1521084fd11a0a56cd595e17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2180/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/09ca55a191d275255c3d1e44af1d7bca3c077e2a","head":{"label":"aspnet:RemoveGenerate","ref":"RemoveGenerate","sha":"09ca55a191d275255c3d1e44af1d7bca3c077e2a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-17T00:19:56Z","pushed_at":"2015-03-17T00:19:55Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":93508,"stargazers_count":1487,"watchers_count":1487,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":222,"forks":463,"open_issues":222,"watchers":1487,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"e16d263cd587f25e8b7dd05e856e9461f4c6b914","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-03-17T00:19:56Z","pushed_at":"2015-03-17T00:19:55Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":93508,"stargazers_count":1487,"watchers_count":1487,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":222,"forks":463,"open_issues":222,"watchers":1487,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2180"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2180"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2180"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/09ca55a191d275255c3d1e44af1d7bca3c077e2a"}}}}