{"action":"created","issue":{"url":"https://api.github.com/repos/google/cadvisor/issues/801","labels_url":"https://api.github.com/repos/google/cadvisor/issues/801/labels{/name}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/801/comments","events_url":"https://api.github.com/repos/google/cadvisor/issues/801/events","html_url":"https://github.com/google/cadvisor/pull/801","id":93369722,"number":801,"title":"Fix incorrect use of metadata library, correct typo","user":{"login":"AnanyaKumar","id":1862850,"avatar_url":"https://avatars.githubusercontent.com/u/1862850?v=3","gravatar_id":"","url":"https://api.github.com/users/AnanyaKumar","html_url":"https://github.com/AnanyaKumar","followers_url":"https://api.github.com/users/AnanyaKumar/followers","following_url":"https://api.github.com/users/AnanyaKumar/following{/other_user}","gists_url":"https://api.github.com/users/AnanyaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/AnanyaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnanyaKumar/subscriptions","organizations_url":"https://api.github.com/users/AnanyaKumar/orgs","repos_url":"https://api.github.com/users/AnanyaKumar/repos","events_url":"https://api.github.com/users/AnanyaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/AnanyaKumar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-06T20:26:33Z","updated_at":"2015-07-06T20:27:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/801","html_url":"https://github.com/google/cadvisor/pull/801","diff_url":"https://github.com/google/cadvisor/pull/801.diff","patch_url":"https://github.com/google/cadvisor/pull/801.patch"},"body":"Sorry, I thought I tested my cloud-provider-info code on GCE, but I must have tested the version of the code before Victor's code review (I probably wasn't checked into the right branch, or didn't rebase my changes, when testing on a GCE instance). I've tested this code on my desktop, and on a GCE n1-standard-1 instance.\r\n\r\nSo when I execute \"curl http://localhost:8080/api/v2.0/machine\"\r\nLocally, I get: \"cloud_provider\":\"Unknown\",\"instance_type\":\"Unknown\"\r\nOn the n1-standard-1 instance, I get: \"cloud_provider\":\"GCE\",\"instance_type\":\"n1-standard-1\"\r\n\r\nAll integration tests pass except TestDockerContainerNetworkStats. We might want to look at this test again, since I thought Victor's PR last Wednesday should fix this test."},"comment":{"url":"https://api.github.com/repos/google/cadvisor/issues/comments/118987762","html_url":"https://github.com/google/cadvisor/pull/801#issuecomment-118987762","issue_url":"https://api.github.com/repos/google/cadvisor/issues/801","id":118987762,"user":{"login":"rjnagal","id":5420489,"avatar_url":"https://avatars.githubusercontent.com/u/5420489?v=3","gravatar_id":"","url":"https://api.github.com/users/rjnagal","html_url":"https://github.com/rjnagal","followers_url":"https://api.github.com/users/rjnagal/followers","following_url":"https://api.github.com/users/rjnagal/following{/other_user}","gists_url":"https://api.github.com/users/rjnagal/gists{/gist_id}","starred_url":"https://api.github.com/users/rjnagal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjnagal/subscriptions","organizations_url":"https://api.github.com/users/rjnagal/orgs","repos_url":"https://api.github.com/users/rjnagal/repos","events_url":"https://api.github.com/users/rjnagal/events{/privacy}","received_events_url":"https://api.github.com/users/rjnagal/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T20:27:27Z","updated_at":"2015-07-06T20:27:27Z","body":"ok to test"}}