{"action":"created","comment":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/23498257","id":23498257,"diff_hunk":"@@ -200,6 +200,30 @@ describe('modules/string-checker', function() {\n         });\n     });\n \n+    describe('esprima options', function() {\n+        it('uses custom esprima options when provided to the constructor', function() {\n+            checker = new Checker({ esnext: true, esprimaOptions: { tolerant: true } });\n+            checker.registerDefaultRules();\n+\n+            var errors = checker.checkString('(function () {import * as foo from \"bar\"; return foo; })()');\n+            console.log(errors);\n+            assert(errors.isEmpty());\n+        });\n+\n+        it('uses custom esprima options when set in the config', function() {\n+            checker = new Checker();\n+            checker.registerDefaultRules();\n+            checker.configure({ esnext: true, esprimaOptions: { tolerant: true } });\n+\n+            var errors = checker.checkString('(function () { import * as bar from \"bar\"; return bar; })();');\n+            // Make sure that multiple checks don't fail\n+            var errors2 = checker.checkString('(function () { import * as bar from \"foo\"; return bar; })()');\n+            console.log(errors);\n+            assert(errors.isEmpty());\n+            assert(errors2.isEmpty());","path":"test/string-checker.js","position":24,"original_position":24,"commit_id":"d9a1cec88540ae3a8bd5c52fb0abd6168ae2ee2a","original_commit_id":"d9a1cec88540ae3a8bd5c52fb0abd6168ae2ee2a","user":{"login":"mikesherov","id":364532,"avatar_url":"https://avatars.githubusercontent.com/u/364532?v=3","gravatar_id":"","url":"https://api.github.com/users/mikesherov","html_url":"https://github.com/mikesherov","followers_url":"https://api.github.com/users/mikesherov/followers","following_url":"https://api.github.com/users/mikesherov/following{/other_user}","gists_url":"https://api.github.com/users/mikesherov/gists{/gist_id}","starred_url":"https://api.github.com/users/mikesherov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikesherov/subscriptions","organizations_url":"https://api.github.com/users/mikesherov/orgs","repos_url":"https://api.github.com/users/mikesherov/repos","events_url":"https://api.github.com/users/mikesherov/events{/privacy}","received_events_url":"https://api.github.com/users/mikesherov/received_events","type":"User","site_admin":false},"body":"combine with `:220`","created_at":"2015-01-24T18:27:48Z","updated_at":"2015-01-24T18:27:48Z","html_url":"https://github.com/jscs-dev/node-jscs/pull/944#discussion_r23498257","pull_request_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944","_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/23498257"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/944#discussion_r23498257"},"pull_request":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944"}}},"pull_request":{"url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944","id":27736611,"html_url":"https://github.com/jscs-dev/node-jscs/pull/944","diff_url":"https://github.com/jscs-dev/node-jscs/pull/944.diff","patch_url":"https://github.com/jscs-dev/node-jscs/pull/944.patch","issue_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/944","number":944,"state":"open","locked":false,"title":"Add support for custom esprima options; fixes #903","user":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"body":"Work-in-progress attempt at fixing #903.\r\nThis seems to pass through the options properly. The 2 new tests currently fail because `esprima-harmony-jscs` is outdated and doesn't include https://github.com/ariya/esprima/commit/b1dd29e985b353648a6e0fa8b9f852cd2db228ac (Should I file an issue at https://github.com/jscs-dev/esprima-harmony for that?)","created_at":"2015-01-21T05:38:35Z","updated_at":"2015-01-24T18:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a1b6f49a642000a9f6b6c228b35a1a9b7e1a15f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944/commits","review_comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944/comments","review_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/944/comments","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/d9a1cec88540ae3a8bd5c52fb0abd6168ae2ee2a","head":{"label":"cvrebert:esprima-options","ref":"esprima-options","sha":"d9a1cec88540ae3a8bd5c52fb0abd6168ae2ee2a","user":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"repo":{"id":29573178,"name":"node-jscs","full_name":"cvrebert/node-jscs","owner":{"login":"cvrebert","id":419884,"avatar_url":"https://avatars.githubusercontent.com/u/419884?v=3","gravatar_id":"","url":"https://api.github.com/users/cvrebert","html_url":"https://github.com/cvrebert","followers_url":"https://api.github.com/users/cvrebert/followers","following_url":"https://api.github.com/users/cvrebert/following{/other_user}","gists_url":"https://api.github.com/users/cvrebert/gists{/gist_id}","starred_url":"https://api.github.com/users/cvrebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvrebert/subscriptions","organizations_url":"https://api.github.com/users/cvrebert/orgs","repos_url":"https://api.github.com/users/cvrebert/repos","events_url":"https://api.github.com/users/cvrebert/events{/privacy}","received_events_url":"https://api.github.com/users/cvrebert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvrebert/node-jscs","description":"JavaScript Code Style checker","fork":true,"url":"https://api.github.com/repos/cvrebert/node-jscs","forks_url":"https://api.github.com/repos/cvrebert/node-jscs/forks","keys_url":"https://api.github.com/repos/cvrebert/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvrebert/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvrebert/node-jscs/teams","hooks_url":"https://api.github.com/repos/cvrebert/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/cvrebert/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/cvrebert/node-jscs/events","assignees_url":"https://api.github.com/repos/cvrebert/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/cvrebert/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/cvrebert/node-jscs/tags","blobs_url":"https://api.github.com/repos/cvrebert/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvrebert/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvrebert/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvrebert/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvrebert/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/cvrebert/node-jscs/languages","stargazers_url":"https://api.github.com/repos/cvrebert/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/cvrebert/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/cvrebert/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/cvrebert/node-jscs/subscription","commits_url":"https://api.github.com/repos/cvrebert/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvrebert/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvrebert/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvrebert/node-jscs/issues/comments/{number}","contents_url":"https://api.github.com/repos/cvrebert/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/cvrebert/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvrebert/node-jscs/merges","archive_url":"https://api.github.com/repos/cvrebert/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvrebert/node-jscs/downloads","issues_url":"https://api.github.com/repos/cvrebert/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/cvrebert/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/cvrebert/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/cvrebert/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvrebert/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/cvrebert/node-jscs/releases{/id}","created_at":"2015-01-21T05:29:12Z","updated_at":"2015-01-21T05:29:17Z","pushed_at":"2015-01-21T22:53:09Z","git_url":"git://github.com/cvrebert/node-jscs.git","ssh_url":"git@github.com:cvrebert/node-jscs.git","clone_url":"https://github.com/cvrebert/node-jscs.git","svn_url":"https://github.com/cvrebert/node-jscs","homepage":"http://jscs.info/","size":1939,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jscs-dev:master","ref":"master","sha":"30049c1da94b590b783c1ba948da1d639b8c06bc","user":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":10697582,"name":"node-jscs","full_name":"jscs-dev/node-jscs","owner":{"login":"jscs-dev","id":8018201,"avatar_url":"https://avatars.githubusercontent.com/u/8018201?v=3","gravatar_id":"","url":"https://api.github.com/users/jscs-dev","html_url":"https://github.com/jscs-dev","followers_url":"https://api.github.com/users/jscs-dev/followers","following_url":"https://api.github.com/users/jscs-dev/following{/other_user}","gists_url":"https://api.github.com/users/jscs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/jscs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscs-dev/subscriptions","organizations_url":"https://api.github.com/users/jscs-dev/orgs","repos_url":"https://api.github.com/users/jscs-dev/repos","events_url":"https://api.github.com/users/jscs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/jscs-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jscs-dev/node-jscs","description":"JavaScript Code Style checker","fork":false,"url":"https://api.github.com/repos/jscs-dev/node-jscs","forks_url":"https://api.github.com/repos/jscs-dev/node-jscs/forks","keys_url":"https://api.github.com/repos/jscs-dev/node-jscs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jscs-dev/node-jscs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jscs-dev/node-jscs/teams","hooks_url":"https://api.github.com/repos/jscs-dev/node-jscs/hooks","issue_events_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/events{/number}","events_url":"https://api.github.com/repos/jscs-dev/node-jscs/events","assignees_url":"https://api.github.com/repos/jscs-dev/node-jscs/assignees{/user}","branches_url":"https://api.github.com/repos/jscs-dev/node-jscs/branches{/branch}","tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/tags","blobs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/{sha}","languages_url":"https://api.github.com/repos/jscs-dev/node-jscs/languages","stargazers_url":"https://api.github.com/repos/jscs-dev/node-jscs/stargazers","contributors_url":"https://api.github.com/repos/jscs-dev/node-jscs/contributors","subscribers_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscribers","subscription_url":"https://api.github.com/repos/jscs-dev/node-jscs/subscription","commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jscs-dev/node-jscs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jscs-dev/node-jscs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues/comments/{number}","contents_url":"https://api.github.com/repos/jscs-dev/node-jscs/contents/{+path}","compare_url":"https://api.github.com/repos/jscs-dev/node-jscs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jscs-dev/node-jscs/merges","archive_url":"https://api.github.com/repos/jscs-dev/node-jscs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jscs-dev/node-jscs/downloads","issues_url":"https://api.github.com/repos/jscs-dev/node-jscs/issues{/number}","pulls_url":"https://api.github.com/repos/jscs-dev/node-jscs/pulls{/number}","milestones_url":"https://api.github.com/repos/jscs-dev/node-jscs/milestones{/number}","notifications_url":"https://api.github.com/repos/jscs-dev/node-jscs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jscs-dev/node-jscs/labels{/name}","releases_url":"https://api.github.com/repos/jscs-dev/node-jscs/releases{/id}","created_at":"2013-06-14T20:53:48Z","updated_at":"2015-01-24T18:03:58Z","pushed_at":"2015-01-24T18:03:58Z","git_url":"git://github.com/jscs-dev/node-jscs.git","ssh_url":"git@github.com:jscs-dev/node-jscs.git","clone_url":"https://github.com/jscs-dev/node-jscs.git","svn_url":"https://github.com/jscs-dev/node-jscs","homepage":"http://jscs.info/","size":7319,"stargazers_count":2405,"watchers_count":2405,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":232,"mirror_url":null,"open_issues_count":103,"forks":232,"open_issues":103,"watchers":2405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944"},"html":{"href":"https://github.com/jscs-dev/node-jscs/pull/944"},"issue":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/944"},"comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/issues/944/comments"},"review_comments":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944/comments"},"review_comment":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/pulls/944/commits"},"statuses":{"href":"https://api.github.com/repos/jscs-dev/node-jscs/statuses/d9a1cec88540ae3a8bd5c52fb0abd6168ae2ee2a"}}}}