{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22","id":47993338,"html_url":"https://github.com/henrikengstrom/k9r/pull/22","diff_url":"https://github.com/henrikengstrom/k9r/pull/22.diff","patch_url":"https://github.com/henrikengstrom/k9r/pull/22.patch","issue_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/22","number":22,"state":"closed","locked":false,"title":"Concerns about blocking io in the right places","user":{"login":"johanandren","id":666915,"avatar_url":"https://avatars.githubusercontent.com/u/666915?v=3","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false},"body":"For vague reasons we defined Generator.generate to return\r\na future although all the implementations does is blocking\r\nio in a very imperative fashion. We then went on to juggle\r\nfutures like crazy clowns without much reason (however fun\r\ncrazy clowns are).\r\n\r\nI have now removed those, and made sure the blocking call\r\nto generate is wrapped in a future and executed on a separate\r\ncontext for blocking io in the controller. Presto - much cleaner\r\ncode.","created_at":"2015-10-17T19:21:49Z","updated_at":"2015-10-19T14:05:52Z","closed_at":"2015-10-19T14:05:52Z","merged_at":"2015-10-19T14:05:52Z","merge_commit_sha":"91fa2af63270a279b720723d4c6e75695a0ece30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22/commits","review_comments_url":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22/comments","review_comment_url":"https://api.github.com/repos/henrikengstrom/k9r/pulls/comments{/number}","comments_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/22/comments","statuses_url":"https://api.github.com/repos/henrikengstrom/k9r/statuses/57ec88c9a8b86a2bd038bd61b93aafc61715dacf","head":{"label":"henrikengstrom:wip-sane-futures-johanandren","ref":"wip-sane-futures-johanandren","sha":"57ec88c9a8b86a2bd038bd61b93aafc61715dacf","user":{"login":"henrikengstrom","id":506945,"avatar_url":"https://avatars.githubusercontent.com/u/506945?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikengstrom","html_url":"https://github.com/henrikengstrom","followers_url":"https://api.github.com/users/henrikengstrom/followers","following_url":"https://api.github.com/users/henrikengstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikengstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikengstrom/orgs","repos_url":"https://api.github.com/users/henrikengstrom/repos","events_url":"https://api.github.com/users/henrikengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikengstrom/received_events","type":"User","site_admin":false},"repo":{"id":44300956,"name":"k9r","full_name":"henrikengstrom/k9r","owner":{"login":"henrikengstrom","id":506945,"avatar_url":"https://avatars.githubusercontent.com/u/506945?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikengstrom","html_url":"https://github.com/henrikengstrom","followers_url":"https://api.github.com/users/henrikengstrom/followers","following_url":"https://api.github.com/users/henrikengstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikengstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikengstrom/orgs","repos_url":"https://api.github.com/users/henrikengstrom/repos","events_url":"https://api.github.com/users/henrikengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikengstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henrikengstrom/k9r","description":"K(ickstart)r for Typesafe projects","fork":false,"url":"https://api.github.com/repos/henrikengstrom/k9r","forks_url":"https://api.github.com/repos/henrikengstrom/k9r/forks","keys_url":"https://api.github.com/repos/henrikengstrom/k9r/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henrikengstrom/k9r/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henrikengstrom/k9r/teams","hooks_url":"https://api.github.com/repos/henrikengstrom/k9r/hooks","issue_events_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/events{/number}","events_url":"https://api.github.com/repos/henrikengstrom/k9r/events","assignees_url":"https://api.github.com/repos/henrikengstrom/k9r/assignees{/user}","branches_url":"https://api.github.com/repos/henrikengstrom/k9r/branches{/branch}","tags_url":"https://api.github.com/repos/henrikengstrom/k9r/tags","blobs_url":"https://api.github.com/repos/henrikengstrom/k9r/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henrikengstrom/k9r/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henrikengstrom/k9r/git/refs{/sha}","trees_url":"https://api.github.com/repos/henrikengstrom/k9r/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henrikengstrom/k9r/statuses/{sha}","languages_url":"https://api.github.com/repos/henrikengstrom/k9r/languages","stargazers_url":"https://api.github.com/repos/henrikengstrom/k9r/stargazers","contributors_url":"https://api.github.com/repos/henrikengstrom/k9r/contributors","subscribers_url":"https://api.github.com/repos/henrikengstrom/k9r/subscribers","subscription_url":"https://api.github.com/repos/henrikengstrom/k9r/subscription","commits_url":"https://api.github.com/repos/henrikengstrom/k9r/commits{/sha}","git_commits_url":"https://api.github.com/repos/henrikengstrom/k9r/git/commits{/sha}","comments_url":"https://api.github.com/repos/henrikengstrom/k9r/comments{/number}","issue_comment_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/comments{/number}","contents_url":"https://api.github.com/repos/henrikengstrom/k9r/contents/{+path}","compare_url":"https://api.github.com/repos/henrikengstrom/k9r/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henrikengstrom/k9r/merges","archive_url":"https://api.github.com/repos/henrikengstrom/k9r/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henrikengstrom/k9r/downloads","issues_url":"https://api.github.com/repos/henrikengstrom/k9r/issues{/number}","pulls_url":"https://api.github.com/repos/henrikengstrom/k9r/pulls{/number}","milestones_url":"https://api.github.com/repos/henrikengstrom/k9r/milestones{/number}","notifications_url":"https://api.github.com/repos/henrikengstrom/k9r/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henrikengstrom/k9r/labels{/name}","releases_url":"https://api.github.com/repos/henrikengstrom/k9r/releases{/id}","created_at":"2015-10-15T07:30:37Z","updated_at":"2015-10-19T09:54:00Z","pushed_at":"2015-10-19T14:05:52Z","git_url":"git://github.com/henrikengstrom/k9r.git","ssh_url":"git@github.com:henrikengstrom/k9r.git","clone_url":"https://github.com/henrikengstrom/k9r.git","svn_url":"https://github.com/henrikengstrom/k9r","homepage":null,"size":654,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"henrikengstrom:master","ref":"master","sha":"ea700208525db1a561b821bf044c6c366e48727a","user":{"login":"henrikengstrom","id":506945,"avatar_url":"https://avatars.githubusercontent.com/u/506945?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikengstrom","html_url":"https://github.com/henrikengstrom","followers_url":"https://api.github.com/users/henrikengstrom/followers","following_url":"https://api.github.com/users/henrikengstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikengstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikengstrom/orgs","repos_url":"https://api.github.com/users/henrikengstrom/repos","events_url":"https://api.github.com/users/henrikengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikengstrom/received_events","type":"User","site_admin":false},"repo":{"id":44300956,"name":"k9r","full_name":"henrikengstrom/k9r","owner":{"login":"henrikengstrom","id":506945,"avatar_url":"https://avatars.githubusercontent.com/u/506945?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikengstrom","html_url":"https://github.com/henrikengstrom","followers_url":"https://api.github.com/users/henrikengstrom/followers","following_url":"https://api.github.com/users/henrikengstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikengstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikengstrom/orgs","repos_url":"https://api.github.com/users/henrikengstrom/repos","events_url":"https://api.github.com/users/henrikengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikengstrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henrikengstrom/k9r","description":"K(ickstart)r for Typesafe projects","fork":false,"url":"https://api.github.com/repos/henrikengstrom/k9r","forks_url":"https://api.github.com/repos/henrikengstrom/k9r/forks","keys_url":"https://api.github.com/repos/henrikengstrom/k9r/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henrikengstrom/k9r/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henrikengstrom/k9r/teams","hooks_url":"https://api.github.com/repos/henrikengstrom/k9r/hooks","issue_events_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/events{/number}","events_url":"https://api.github.com/repos/henrikengstrom/k9r/events","assignees_url":"https://api.github.com/repos/henrikengstrom/k9r/assignees{/user}","branches_url":"https://api.github.com/repos/henrikengstrom/k9r/branches{/branch}","tags_url":"https://api.github.com/repos/henrikengstrom/k9r/tags","blobs_url":"https://api.github.com/repos/henrikengstrom/k9r/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henrikengstrom/k9r/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henrikengstrom/k9r/git/refs{/sha}","trees_url":"https://api.github.com/repos/henrikengstrom/k9r/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henrikengstrom/k9r/statuses/{sha}","languages_url":"https://api.github.com/repos/henrikengstrom/k9r/languages","stargazers_url":"https://api.github.com/repos/henrikengstrom/k9r/stargazers","contributors_url":"https://api.github.com/repos/henrikengstrom/k9r/contributors","subscribers_url":"https://api.github.com/repos/henrikengstrom/k9r/subscribers","subscription_url":"https://api.github.com/repos/henrikengstrom/k9r/subscription","commits_url":"https://api.github.com/repos/henrikengstrom/k9r/commits{/sha}","git_commits_url":"https://api.github.com/repos/henrikengstrom/k9r/git/commits{/sha}","comments_url":"https://api.github.com/repos/henrikengstrom/k9r/comments{/number}","issue_comment_url":"https://api.github.com/repos/henrikengstrom/k9r/issues/comments{/number}","contents_url":"https://api.github.com/repos/henrikengstrom/k9r/contents/{+path}","compare_url":"https://api.github.com/repos/henrikengstrom/k9r/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henrikengstrom/k9r/merges","archive_url":"https://api.github.com/repos/henrikengstrom/k9r/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henrikengstrom/k9r/downloads","issues_url":"https://api.github.com/repos/henrikengstrom/k9r/issues{/number}","pulls_url":"https://api.github.com/repos/henrikengstrom/k9r/pulls{/number}","milestones_url":"https://api.github.com/repos/henrikengstrom/k9r/milestones{/number}","notifications_url":"https://api.github.com/repos/henrikengstrom/k9r/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henrikengstrom/k9r/labels{/name}","releases_url":"https://api.github.com/repos/henrikengstrom/k9r/releases{/id}","created_at":"2015-10-15T07:30:37Z","updated_at":"2015-10-19T09:54:00Z","pushed_at":"2015-10-19T14:05:52Z","git_url":"git://github.com/henrikengstrom/k9r.git","ssh_url":"git@github.com:henrikengstrom/k9r.git","clone_url":"https://github.com/henrikengstrom/k9r.git","svn_url":"https://github.com/henrikengstrom/k9r","homepage":null,"size":654,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22"},"html":{"href":"https://github.com/henrikengstrom/k9r/pull/22"},"issue":{"href":"https://api.github.com/repos/henrikengstrom/k9r/issues/22"},"comments":{"href":"https://api.github.com/repos/henrikengstrom/k9r/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/henrikengstrom/k9r/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/henrikengstrom/k9r/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/henrikengstrom/k9r/statuses/57ec88c9a8b86a2bd038bd61b93aafc61715dacf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"henrikengstrom","id":506945,"avatar_url":"https://avatars.githubusercontent.com/u/506945?v=3","gravatar_id":"","url":"https://api.github.com/users/henrikengstrom","html_url":"https://github.com/henrikengstrom","followers_url":"https://api.github.com/users/henrikengstrom/followers","following_url":"https://api.github.com/users/henrikengstrom/following{/other_user}","gists_url":"https://api.github.com/users/henrikengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikengstrom/subscriptions","organizations_url":"https://api.github.com/users/henrikengstrom/orgs","repos_url":"https://api.github.com/users/henrikengstrom/repos","events_url":"https://api.github.com/users/henrikengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/henrikengstrom/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":104,"deletions":121,"changed_files":6}}