{"action":"created","issue":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/342","labels_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/342/comments","events_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/342/events","html_url":"https://github.com/jbalsas/liferay-portal/pull/342","id":124282838,"number":342,"title":"LPS-61332, LPS-61643 Migrate ui:diff-html taglib to frontend-taglib module","user":{"login":"thektan","id":4496722,"avatar_url":"https://avatars.githubusercontent.com/u/4496722?v=3","gravatar_id":"","url":"https://api.github.com/users/thektan","html_url":"https://github.com/thektan","followers_url":"https://api.github.com/users/thektan/followers","following_url":"https://api.github.com/users/thektan/following{/other_user}","gists_url":"https://api.github.com/users/thektan/gists{/gist_id}","starred_url":"https://api.github.com/users/thektan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thektan/subscriptions","organizations_url":"https://api.github.com/users/thektan/orgs","repos_url":"https://api.github.com/users/thektan/repos","events_url":"https://api.github.com/users/thektan/events{/privacy}","received_events_url":"https://api.github.com/users/thektan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-29T23:32:06Z","updated_at":"2015-12-30T00:26:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/pulls/342","html_url":"https://github.com/jbalsas/liferay-portal/pull/342","diff_url":"https://github.com/jbalsas/liferay-portal/pull/342.diff","patch_url":"https://github.com/jbalsas/liferay-portal/pull/342.patch"},"body":"Hi Chema!\r\n\r\nAttached is an update for [LPS-61332](http://issues.liferay.com/browse/LPS-61332) and [LPS-61643](https://issues.liferay.com/browse/LPS-61643). I extracted the language key `these-versions-are-not-comparable`. It's the only language key being used in this taglib.\r\n\r\nI had some trouble connecting the `Language.properties` files to the `diff-html` taglib to get:\r\n```\r\n<liferay-ui:message key=\"these-versions-are-not-comparable\" />\r\n```\r\nto print correctly, but I was able to get the correct language key by instead using:\r\n```\r\n<%= LanguageUtil.get(resourceBundle, \"these-versions-are-not-comparable\") %>\r\n```\r\nI made this change in 5ec4cfb411f39403b8718c039e4e7a2583425e00.\r\n\r\nLooking at other modules, it seems like I might have to create extra java classes or a specific language module, so this seems to be the simplest solution. Let me know if there's a more ideal way or if I'm missing anything.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/comments/167904338","html_url":"https://github.com/jbalsas/liferay-portal/pull/342#issuecomment-167904338","issue_url":"https://api.github.com/repos/jbalsas/liferay-portal/issues/342","id":167904338,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2015-12-30T00:26:15Z","updated_at":"2015-12-30T00:26:15Z","body":"<h1>Some tests FAILED!</h1><p>Build Time: 51 minutes 50 seconds</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a><br />Branch GIT ID: <a href=\"https://github.com/liferay/liferay-portal/commit/bb2ec9731a3839ab37521268dedeb089637bd8f6\">bb2ec9731a3839ab37521268dedeb089637bd8f6</a></p><h4>Job Summary:</h4><ul><li><strike><strong><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest(master)/711/\">test-portal-acceptance-pullrequest(master)</a></strong></strike></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12016/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-hypersonic/0</a></li><li><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11473/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/0</a></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12017/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/1</a></li><li><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19796/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/2</a></li><li><a href=\"https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12753/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/3</a></li><li><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11211/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/4</a></li><li><a href=\"https://test-1-17.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/9194/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/5</a></li><li><a href=\"https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11155/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/6</a></li><li><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19748/\">test-portal-acceptance-pullrequest-batch(master)/integration-db2</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19740/\">test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12915/\">test-portal-acceptance-pullrequest-batch(master)/integration-mysql</a></li><li><a href=\"https://test-1-15.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11435/\">test-portal-acceptance-pullrequest-batch(master)/integration-oracle</a></li><li><a href=\"https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19808/\">test-portal-acceptance-pullrequest-batch(master)/integration-postgresql</a></li><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19898/\">test-portal-acceptance-pullrequest-batch(master)/integration-sybase</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12916/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2</a></li><li><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19749/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic</a></li><li><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11415/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19741/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle</a></li><li><a href=\"https://test-1-15.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11436/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql</a></li><li><a href=\"https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19809/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase</a></li><li><strike><strong><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19708/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit</a></strong></strike></li><li><strike><strong><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19899/\">test-portal-acceptance-pullrequest-batch(master)/plugins-compile</a></strong></strike></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11893/\">test-portal-acceptance-pullrequest-batch(master)/portal-web</a></li><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19900/\">test-portal-acceptance-pullrequest-batch(master)/ruby-sass-compiler</a></li><li><a href=\"https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/12961/\">test-portal-acceptance-pullrequest-batch(master)/service-builder</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/11894/\">test-portal-acceptance-pullrequest-batch(master)/tck</a></li><li><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/18883/\">test-portal-acceptance-pullrequest-batch(master)/unit</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/1867/\">test-portal-acceptance-pullrequest-source(master)</a></li></ul><h5>For more details click <a href=\"https://test-1-14.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/711/jenkins-report.html\">here</a>.</h5><hr /><h4>Failed Jobs:</h4><ol><li><h5><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest(master)/711/\">test-portal-acceptance-pullrequest(master)</a></h5><h6>Job Results:</h6><p>26 Jobs Passed.<br />3 Jobs Failed.</p><pre>Completed with the status of FAILURE.</pre></li><li><h5 job-result=\"UNSTABLE\"><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19708/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit</a></h5><h6>Job Results:</h6><p>1111 Tests Passed.<br />1 Test Failed.</p><ol><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch%28master%29/AXIS_VARIABLE=3,label_exp=!master/19708//testReport/com.liferay.source.formatter/SourceFormatterTest/testSourceFormatter\">SourceFormatterTest.testSourceFormatter</a></li></ol></li><li><h5 job-result=\"FAILURE\"><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/19899/\">test-portal-acceptance-pullrequest-batch(master)/plugins-compile</a></h5><h6>Job Results:</h6><p>1 Test Passed.<br />1 Test Failed.</p><ol><li><strong><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch%28master%29/AXIS_VARIABLE=0,label_exp=!master/19899/\">test-portal-acceptance-pullrequest-batch&#40;master&#41; ?? 0,!master #19899</a></strong><p>To include a plugin fix for this pull request, please edit your <a href=\"https://github.com/thektan/liferay-portal/blob/LPS-61332-diff-html-pr2/git-commit-plugins\">git-commit-plugins</a>. Click <a href=\"https://in.liferay.com/web/global.engineering/blog/-/blogs/new-tests-for-the-pull-request-tester-\">here</a> for more details.</p><pre><br />     &#91;copy&#93; Copying 77 files to /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/docroot/WEB-INF/classes<br />     &#91;copy&#93; Copied 56 empty directories to 36 empty directories under /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/docroot/WEB-INF/classes<br />    &#91;javac&#93; Compiling 147 source files to /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/docroot/WEB-INF/classes<br />    &#91;javac&#93; Note: Some input files use or override a deprecated API.<br />    &#91;javac&#93; Note: Recompile with -Xlint:deprecation for details.<br />    &#91;javac&#93; Note: Some input files use unchecked or unsafe operations.<br />    &#91;javac&#93; Note: Recompile with -Xlint:unchecked for details.<br />     &#91;copy&#93; Copying 1 file to /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/docroot/WEB-INF<br />    &#91;mkdir&#93; Created dir: /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/20151229155047801<br />     &#91;echo&#93; Dec 29, 2015 3:50:48 PM org.apache.jasper.compiler.TldLocationsCache tldScanJar<br />     &#91;echo&#93; INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.<br />     &#91;echo&#93; org.apache.jasper.JasperException: file:/opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/docroot/admin/common/history.jsp &#40;line: 173, column: 5&#41; No tag &#34;diff-html&#34; defined in tag library imported with prefix &#34;liferay-ui&#34;<br />   &#91;delete&#93; Deleting directory /opt/dev/projects/github/liferay-plugins/portlets/knowledge-base-portlet/20151229155047801/src<br />     &#91;echo&#93; The following error occurred while executing this line:<br />     &#91;echo&#93; /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:288: The following error occurred while executing this line:<br />     &#91;echo&#93; /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:290: The following error occurred while executing this line:<br />     &#91;echo&#93; /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:266: The following error occurred while executing this line:<br />     &#91;echo&#93; /opt/dev/projects/github/liferay-plugins/build-common-plugin.xml:711: The following error occurred while executing this line:<br />     &#91;echo&#93; /opt/dev/projects/github/liferay-plugins/build-common-plugin.xml:360: JSPs failed to compile.<br /><br /></pre></li></ol></li></ol>"}}