{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/kafka/pulls/comments/39095244","id":39095244,"diff_hunk":"@@ -22,11 +22,12 @@\n import org.apache.kafka.streams.processor.ProcessorDef;\n \n import java.util.ArrayList;\n+import java.util.List;\n \n public class MockProcessorDef<K, V> implements ProcessorDef {\n \n-    public final ArrayList<String> processed = new ArrayList<>();\n-    public final ArrayList<Long> punctuated = new ArrayList<>();\n+    public final List<String> processed = new ArrayList<>();","path":"streams/src/test/java/org/apache/kafka/test/MockProcessorDef.java","position":10,"original_position":10,"commit_id":"a6e321ab8c5b98cd5605248b09fce7ad29b22ef5","original_commit_id":"a6e321ab8c5b98cd5605248b09fce7ad29b22ef5","user":{"login":"ymatsuda","id":169548,"avatar_url":"https://avatars.githubusercontent.com/u/169548?v=3","gravatar_id":"","url":"https://api.github.com/users/ymatsuda","html_url":"https://github.com/ymatsuda","followers_url":"https://api.github.com/users/ymatsuda/followers","following_url":"https://api.github.com/users/ymatsuda/following{/other_user}","gists_url":"https://api.github.com/users/ymatsuda/gists{/gist_id}","starred_url":"https://api.github.com/users/ymatsuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymatsuda/subscriptions","organizations_url":"https://api.github.com/users/ymatsuda/orgs","repos_url":"https://api.github.com/users/ymatsuda/repos","events_url":"https://api.github.com/users/ymatsuda/events{/privacy}","received_events_url":"https://api.github.com/users/ymatsuda/received_events","type":"User","site_admin":false},"body":"ArrayList is fine. No need to use List.","created_at":"2015-09-09T20:56:51Z","updated_at":"2015-09-09T20:56:51Z","html_url":"https://github.com/confluentinc/kafka/pull/40#discussion_r39095244","pull_request_url":"https://api.github.com/repos/confluentinc/kafka/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/comments/39095244"},"html":{"href":"https://github.com/confluentinc/kafka/pull/40#discussion_r39095244"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/kafka/pulls/40","id":44598324,"html_url":"https://github.com/confluentinc/kafka/pull/40","diff_url":"https://github.com/confluentinc/kafka/pull/40.diff","patch_url":"https://github.com/confluentinc/kafka/pull/40.patch","issue_url":"https://api.github.com/repos/confluentinc/kafka/issues/40","number":40,"state":"open","locked":false,"title":"Address some comments","user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"body":"@ymatsuda ","created_at":"2015-09-09T20:47:19Z","updated_at":"2015-09-09T20:56:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f79e534522ae3302ff4f724fdb9a5589b2229ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/kafka/pulls/40/commits","review_comments_url":"https://api.github.com/repos/confluentinc/kafka/pulls/40/comments","review_comment_url":"https://api.github.com/repos/confluentinc/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/kafka/issues/40/comments","statuses_url":"https://api.github.com/repos/confluentinc/kafka/statuses/a6e321ab8c5b98cd5605248b09fce7ad29b22ef5","head":{"label":"guozhangwang:MiscComments","ref":"MiscComments","sha":"a6e321ab8c5b98cd5605248b09fce7ad29b22ef5","user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"repo":{"id":39164613,"name":"kafka","full_name":"guozhangwang/kafka","owner":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guozhangwang/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/guozhangwang/kafka","forks_url":"https://api.github.com/repos/guozhangwang/kafka/forks","keys_url":"https://api.github.com/repos/guozhangwang/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guozhangwang/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guozhangwang/kafka/teams","hooks_url":"https://api.github.com/repos/guozhangwang/kafka/hooks","issue_events_url":"https://api.github.com/repos/guozhangwang/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/guozhangwang/kafka/events","assignees_url":"https://api.github.com/repos/guozhangwang/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/guozhangwang/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/guozhangwang/kafka/tags","blobs_url":"https://api.github.com/repos/guozhangwang/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guozhangwang/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guozhangwang/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/guozhangwang/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guozhangwang/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/guozhangwang/kafka/languages","stargazers_url":"https://api.github.com/repos/guozhangwang/kafka/stargazers","contributors_url":"https://api.github.com/repos/guozhangwang/kafka/contributors","subscribers_url":"https://api.github.com/repos/guozhangwang/kafka/subscribers","subscription_url":"https://api.github.com/repos/guozhangwang/kafka/subscription","commits_url":"https://api.github.com/repos/guozhangwang/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/guozhangwang/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/guozhangwang/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/guozhangwang/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/guozhangwang/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/guozhangwang/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guozhangwang/kafka/merges","archive_url":"https://api.github.com/repos/guozhangwang/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guozhangwang/kafka/downloads","issues_url":"https://api.github.com/repos/guozhangwang/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/guozhangwang/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/guozhangwang/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/guozhangwang/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guozhangwang/kafka/labels{/name}","releases_url":"https://api.github.com/repos/guozhangwang/kafka/releases{/id}","created_at":"2015-07-15T22:40:38Z","updated_at":"2015-07-15T22:40:41Z","pushed_at":"2015-09-09T20:46:39Z","git_url":"git://github.com/guozhangwang/kafka.git","ssh_url":"git@github.com:guozhangwang/kafka.git","clone_url":"https://github.com/guozhangwang/kafka.git","svn_url":"https://github.com/guozhangwang/kafka","homepage":null,"size":22012,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"confluentinc:streaming","ref":"streaming","sha":"279676d958ccb1723da4396533d5e3916c15343c","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":37555321,"name":"kafka","full_name":"confluentinc/kafka","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/confluentinc/kafka","forks_url":"https://api.github.com/repos/confluentinc/kafka/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka/releases{/id}","created_at":"2015-06-16T20:48:28Z","updated_at":"2015-09-08T03:39:19Z","pushed_at":"2015-09-09T20:47:20Z","git_url":"git://github.com/confluentinc/kafka.git","ssh_url":"git@github.com:confluentinc/kafka.git","clone_url":"https://github.com/confluentinc/kafka.git","svn_url":"https://github.com/confluentinc/kafka","homepage":null,"size":23014,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/40"},"html":{"href":"https://github.com/confluentinc/kafka/pull/40"},"issue":{"href":"https://api.github.com/repos/confluentinc/kafka/issues/40"},"comments":{"href":"https://api.github.com/repos/confluentinc/kafka/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/kafka/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/kafka/statuses/a6e321ab8c5b98cd5605248b09fce7ad29b22ef5"}}}}