{"action":"created","issue":{"url":"https://api.github.com/repos/Codeception/Codeception/issues/2413","labels_url":"https://api.github.com/repos/Codeception/Codeception/issues/2413/labels{/name}","comments_url":"https://api.github.com/repos/Codeception/Codeception/issues/2413/comments","events_url":"https://api.github.com/repos/Codeception/Codeception/issues/2413/events","html_url":"https://github.com/Codeception/Codeception/pull/2413","id":108755944,"number":2413,"title":"humanize WebDriverBy step arguments","user":{"login":"oehlschl","id":721402,"avatar_url":"https://avatars.githubusercontent.com/u/721402?v=3","gravatar_id":"","url":"https://api.github.com/users/oehlschl","html_url":"https://github.com/oehlschl","followers_url":"https://api.github.com/users/oehlschl/followers","following_url":"https://api.github.com/users/oehlschl/following{/other_user}","gists_url":"https://api.github.com/users/oehlschl/gists{/gist_id}","starred_url":"https://api.github.com/users/oehlschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oehlschl/subscriptions","organizations_url":"https://api.github.com/users/oehlschl/orgs","repos_url":"https://api.github.com/users/oehlschl/repos","events_url":"https://api.github.com/users/oehlschl/events{/privacy}","received_events_url":"https://api.github.com/users/oehlschl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-28T22:02:40Z","updated_at":"2015-09-29T16:59:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Codeception/Codeception/pulls/2413","html_url":"https://github.com/Codeception/Codeception/pull/2413","diff_url":"https://github.com/Codeception/Codeception/pull/2413.diff","patch_url":"https://github.com/Codeception/Codeception/pull/2413.patch"},"body":"Although WebDriverBy are acceptable arguments to many of the WebDriver module steps taken by the AcceptanceTester, the arguments are not very human-readable when output during test execution:\r\n\r\n* I click \"Facebook\\WebDriver\\WebDriverBy\"\r\n* I click \"Facebook\\WebDriver\\WebDriverBy\"\r\n\r\nThis change uses the Locator util to humanize the arguments, making them more readable:\r\n\r\n* I click \"css selector '.something'\"\r\n\r\nA unit test (StepTest::testGetArguments()) asserting correctness is also included.\r\n "},"comment":{"url":"https://api.github.com/repos/Codeception/Codeception/issues/comments/144120745","html_url":"https://github.com/Codeception/Codeception/pull/2413#issuecomment-144120745","issue_url":"https://api.github.com/repos/Codeception/Codeception/issues/2413","id":144120745,"user":{"login":"oehlschl","id":721402,"avatar_url":"https://avatars.githubusercontent.com/u/721402?v=3","gravatar_id":"","url":"https://api.github.com/users/oehlschl","html_url":"https://github.com/oehlschl","followers_url":"https://api.github.com/users/oehlschl/followers","following_url":"https://api.github.com/users/oehlschl/following{/other_user}","gists_url":"https://api.github.com/users/oehlschl/gists{/gist_id}","starred_url":"https://api.github.com/users/oehlschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oehlschl/subscriptions","organizations_url":"https://api.github.com/users/oehlschl/orgs","repos_url":"https://api.github.com/users/oehlschl/repos","events_url":"https://api.github.com/users/oehlschl/events{/privacy}","received_events_url":"https://api.github.com/users/oehlschl/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T16:59:48Z","updated_at":"2015-09-29T16:59:48Z","body":"I rebased, made the change to use get_class() as you requested, and moved the WebDriverBy check into the existing is_object() condition (as get_class() apparently yields an error on non-object arguments). Thanks."}}