{"action":"closed","number":4064,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/4064","id":25563522,"html_url":"https://github.com/odoo/odoo/pull/4064","diff_url":"https://github.com/odoo/odoo/pull/4064.diff","patch_url":"https://github.com/odoo/odoo/pull/4064.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/4064","number":4064,"state":"closed","locked":false,"title":"[FIX] Sale Order Line onchange methods differs in form/tree view","user":{"login":"andrius-preimantas","id":8121748,"avatar_url":"https://avatars.githubusercontent.com/u/8121748?v=3","gravatar_id":"","url":"https://api.github.com/users/andrius-preimantas","html_url":"https://github.com/andrius-preimantas","followers_url":"https://api.github.com/users/andrius-preimantas/followers","following_url":"https://api.github.com/users/andrius-preimantas/following{/other_user}","gists_url":"https://api.github.com/users/andrius-preimantas/gists{/gist_id}","starred_url":"https://api.github.com/users/andrius-preimantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrius-preimantas/subscriptions","organizations_url":"https://api.github.com/users/andrius-preimantas/orgs","repos_url":"https://api.github.com/users/andrius-preimantas/repos","events_url":"https://api.github.com/users/andrius-preimantas/events{/privacy}","received_events_url":"https://api.github.com/users/andrius-preimantas/received_events","type":"User","site_admin":false},"body":"**Onchange methods on Sale Order Line differs in form and tree view**\r\n\r\nThe commit which introduces this bug: https://github.com/odoo/odoo/commit/86f785ae1b2741ab67384f3022b971ab638daeb8#diff-23bba7b359689cdd952fbe0961ff11eeL41\r\n\r\nSo the situation is that you get different behaviour if entering a SO line in editable list and in form view (which you get when there are too much columns to display).\r\n\r\nThere are multiple strange situations because of this bug but the quickest to notice is that changing product in editable tree would cause the system to throw a warning when there's not enough stock to fulfil sale order (\"You plan to sell ... but you only have ... available\") where changing a product in a form view will not cause this check.\r\n\r\nNotice that this PR would only make the system behave the same way in tree and form view, but it does not suggest that it's a good way of handling those onchanges.\r\n\r\nCheers","created_at":"2014-12-05T11:07:53Z","updated_at":"2015-09-17T10:03:13Z","closed_at":"2015-09-17T10:03:13Z","merged_at":null,"merge_commit_sha":"1c561cf9890e5cab020749649bf6856f79f3feee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/4064/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/4064/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/4064/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/35379eeb6087e0b9aa0bf344bc9b9686d1543d45","head":{"label":"andrius-preimantas:8.0","ref":"8.0","sha":"35379eeb6087e0b9aa0bf344bc9b9686d1543d45","user":{"login":"andrius-preimantas","id":8121748,"avatar_url":"https://avatars.githubusercontent.com/u/8121748?v=3","gravatar_id":"","url":"https://api.github.com/users/andrius-preimantas","html_url":"https://github.com/andrius-preimantas","followers_url":"https://api.github.com/users/andrius-preimantas/followers","following_url":"https://api.github.com/users/andrius-preimantas/following{/other_user}","gists_url":"https://api.github.com/users/andrius-preimantas/gists{/gist_id}","starred_url":"https://api.github.com/users/andrius-preimantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrius-preimantas/subscriptions","organizations_url":"https://api.github.com/users/andrius-preimantas/orgs","repos_url":"https://api.github.com/users/andrius-preimantas/repos","events_url":"https://api.github.com/users/andrius-preimantas/events{/privacy}","received_events_url":"https://api.github.com/users/andrius-preimantas/received_events","type":"User","site_admin":false},"repo":{"id":21684169,"name":"odoo","full_name":"andrius-preimantas/odoo","owner":{"login":"andrius-preimantas","id":8121748,"avatar_url":"https://avatars.githubusercontent.com/u/8121748?v=3","gravatar_id":"","url":"https://api.github.com/users/andrius-preimantas","html_url":"https://github.com/andrius-preimantas","followers_url":"https://api.github.com/users/andrius-preimantas/followers","following_url":"https://api.github.com/users/andrius-preimantas/following{/other_user}","gists_url":"https://api.github.com/users/andrius-preimantas/gists{/gist_id}","starred_url":"https://api.github.com/users/andrius-preimantas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrius-preimantas/subscriptions","organizations_url":"https://api.github.com/users/andrius-preimantas/orgs","repos_url":"https://api.github.com/users/andrius-preimantas/repos","events_url":"https://api.github.com/users/andrius-preimantas/events{/privacy}","received_events_url":"https://api.github.com/users/andrius-preimantas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrius-preimantas/odoo","description":"Odoo (formerly OpenERP). Open Source Business Apps.","fork":true,"url":"https://api.github.com/repos/andrius-preimantas/odoo","forks_url":"https://api.github.com/repos/andrius-preimantas/odoo/forks","keys_url":"https://api.github.com/repos/andrius-preimantas/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrius-preimantas/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrius-preimantas/odoo/teams","hooks_url":"https://api.github.com/repos/andrius-preimantas/odoo/hooks","issue_events_url":"https://api.github.com/repos/andrius-preimantas/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/andrius-preimantas/odoo/events","assignees_url":"https://api.github.com/repos/andrius-preimantas/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/andrius-preimantas/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/andrius-preimantas/odoo/tags","blobs_url":"https://api.github.com/repos/andrius-preimantas/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrius-preimantas/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrius-preimantas/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrius-preimantas/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrius-preimantas/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/andrius-preimantas/odoo/languages","stargazers_url":"https://api.github.com/repos/andrius-preimantas/odoo/stargazers","contributors_url":"https://api.github.com/repos/andrius-preimantas/odoo/contributors","subscribers_url":"https://api.github.com/repos/andrius-preimantas/odoo/subscribers","subscription_url":"https://api.github.com/repos/andrius-preimantas/odoo/subscription","commits_url":"https://api.github.com/repos/andrius-preimantas/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrius-preimantas/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrius-preimantas/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrius-preimantas/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrius-preimantas/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/andrius-preimantas/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrius-preimantas/odoo/merges","archive_url":"https://api.github.com/repos/andrius-preimantas/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrius-preimantas/odoo/downloads","issues_url":"https://api.github.com/repos/andrius-preimantas/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/andrius-preimantas/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/andrius-preimantas/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/andrius-preimantas/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrius-preimantas/odoo/labels{/name}","releases_url":"https://api.github.com/repos/andrius-preimantas/odoo/releases{/id}","created_at":"2014-07-10T07:22:02Z","updated_at":"2014-11-13T13:15:53Z","pushed_at":"2015-06-22T11:15:23Z","git_url":"git://github.com/andrius-preimantas/odoo.git","ssh_url":"git@github.com:andrius-preimantas/odoo.git","clone_url":"https://github.com/andrius-preimantas/odoo.git","svn_url":"https://github.com/andrius-preimantas/odoo","homepage":"https://www.odoo.com","size":705390,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odoo:8.0","ref":"8.0","sha":"6e59ea5db9fd8c3a6f51c559b309ecbc4355a3d9","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-09-17T08:21:10Z","pushed_at":"2015-09-17T09:59:19Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1513022,"stargazers_count":3085,"watchers_count":3085,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2677,"mirror_url":null,"open_issues_count":2600,"forks":2677,"open_issues":2600,"watchers":3085,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4064"},"html":{"href":"https://github.com/odoo/odoo/pull/4064"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/4064"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/4064/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4064/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/4064/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/35379eeb6087e0b9aa0bf344bc9b9686d1543d45"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":10,"deletions":4,"changed_files":1}}