{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/6384","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/6384/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/6384/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/6384/events","html_url":"https://github.com/edx/edx-platform/pull/6384","id":53012440,"number":6384,"title":"LMS: Student Notes - Toggle Visibility (UX-1125)","user":{"login":"talbs","id":163763,"avatar_url":"https://avatars.githubusercontent.com/u/163763?v=3","gravatar_id":"","url":"https://api.github.com/users/talbs","html_url":"https://github.com/talbs","followers_url":"https://api.github.com/users/talbs/followers","following_url":"https://api.github.com/users/talbs/following{/other_user}","gists_url":"https://api.github.com/users/talbs/gists{/gist_id}","starred_url":"https://api.github.com/users/talbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talbs/subscriptions","organizations_url":"https://api.github.com/users/talbs/orgs","repos_url":"https://api.github.com/users/talbs/repos","events_url":"https://api.github.com/users/talbs/events{/privacy}","received_events_url":"https://api.github.com/users/talbs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-28T23:22:08Z","updated_at":"2015-01-05T00:51:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/6384","html_url":"https://github.com/edx/edx-platform/pull/6384","diff_url":"https://github.com/edx/edx-platform/pull/6384.diff","patch_url":"https://github.com/edx/edx-platform/pull/6384.patch"},"body":"This work styles the toggle notes on and off UI being added to the LMS. Included in this work is:\r\n\r\n* partial abstraction of utility-based navigation styling/markup\r\n* brief clean up of Sass partial organization (adding in modules)\r\n* styling/rendering of toggle notes specific UI\r\n* styling/rendering of toggle notes errors (both system and vendor errors)\r\n\r\n- - -\r\n\r\n**Known Concerns**\r\n* The calculator's styling and markup are particular to that element - the UI added here has been positioned around this element, but utility navigation should be more robust when supporting multiple items per course.\r\n* This UI may not play well with the chat feature, which has not been reviewed.\r\n* The vendor's error message is still displayed when the notes server cannot be reached\r\n* The system message (for when there is an error in toggling) is limited in content and is currently not using a known system feedback pattern\r\n\r\n- - -\r\n\r\n**TODOS**\r\n* ~~Wire in the ``.has-error`` stateful class to ``.edx-notes-visibility`` element (display is controlled by this toggle)~~\r\n* ~~Wire correctly the ``.is-active`` class on the ``.action-toggle-notes`` elements (currently added in HTML, but JS is not toggling class while maintaining state)~~\r\n* ~~Provide RTL styling support~~\r\n\r\n- - -\r\n\r\n**Screengrab - Notes Toggled Off**\r\n![screen shot 2014-12-29 at 2 27 42 pm](https://cloud.githubusercontent.com/assets/163763/5572099/80697b54-8f67-11e4-9124-596c44e63898.png)\r\n\r\n**Screengrab - Notes Toggled On**\r\n![screen shot 2014-12-29 at 2 27 26 pm](https://cloud.githubusercontent.com/assets/163763/5572098/7b7c0eb8-8f67-11e4-9129-6a761a617b17.png)\r\n\r\n**Screengrab - Notes Toggle with System Error**\r\n![screen shot 2014-12-29 at 2 29 35 pm](https://cloud.githubusercontent.com/assets/163763/5572103/8c4a79b4-8f67-11e4-987c-027c07d91c7c.png)"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/68657676","html_url":"https://github.com/edx/edx-platform/pull/6384#issuecomment-68657676","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/6384","id":68657676,"user":{"login":"explorerleslie","id":5643426,"avatar_url":"https://avatars.githubusercontent.com/u/5643426?v=3","gravatar_id":"","url":"https://api.github.com/users/explorerleslie","html_url":"https://github.com/explorerleslie","followers_url":"https://api.github.com/users/explorerleslie/followers","following_url":"https://api.github.com/users/explorerleslie/following{/other_user}","gists_url":"https://api.github.com/users/explorerleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/explorerleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/explorerleslie/subscriptions","organizations_url":"https://api.github.com/users/explorerleslie/orgs","repos_url":"https://api.github.com/users/explorerleslie/repos","events_url":"https://api.github.com/users/explorerleslie/events{/privacy}","received_events_url":"https://api.github.com/users/explorerleslie/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T00:51:00Z","updated_at":"2015-01-05T00:51:00Z","body":"@talbs I'm a :+1: if things haven't changed since the last time we talked, but I would appreciate seeing it locally tomorrow. Could you please swing by at one point to show me? Thanks!"}}