{"action":"created","comment":{"url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/comments/46747325","id":46747325,"diff_hunk":"@@ -34,11 +34,7 @@\n     def for_each_process(sidekiq_role, &block)\n       sidekiq_processes = fetch(:\"#{ sidekiq_role }_processes\") rescue 1\n       sidekiq_processes.times do |idx|\n-        if idx.zero? && sidekiq_processes <= 1\n-          pid_file = fetch(:sidekiq_pid)\n-        else\n-          pid_file = fetch(:sidekiq_pid).gsub(/\\.pid$/, \"-#{idx}.pid\")\n-        end\n+        pid_file = fetch(:sidekiq_pid).gsub(/\\.pid$/, \"-#{idx}.pid\")","path":"lib/capistrano/tasks/capistrano2.rb","position":9,"original_position":9,"commit_id":"a4f508bc5002a8468e5874a4d5942f20c1b38323","original_commit_id":"a4f508bc5002a8468e5874a4d5942f20c1b38323","user":{"login":"edslocomb","id":627297,"avatar_url":"https://avatars.githubusercontent.com/u/627297?v=3","gravatar_id":"","url":"https://api.github.com/users/edslocomb","html_url":"https://github.com/edslocomb","followers_url":"https://api.github.com/users/edslocomb/followers","following_url":"https://api.github.com/users/edslocomb/following{/other_user}","gists_url":"https://api.github.com/users/edslocomb/gists{/gist_id}","starred_url":"https://api.github.com/users/edslocomb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edslocomb/subscriptions","organizations_url":"https://api.github.com/users/edslocomb/orgs","repos_url":"https://api.github.com/users/edslocomb/repos","events_url":"https://api.github.com/users/edslocomb/events{/privacy}","received_events_url":"https://api.github.com/users/edslocomb/received_events","type":"User","site_admin":false},"body":"The problems all stem from the fact that capistrano-sidekiq is now incompatible with the command line tool ‘sidekiq’ with the -C option for a config file.\n\nFor a week we’ve been chasing unexpected multiple instances of sidekiq running against the same queues, unable to figure out where the errant processes have been coming from.  We use multiple tools to start and stop sidekiq, and we really, really need all of the tools we use to do the same thing, not least because we have a hard ceiling on sidekiq concurrency at 12, above which our solr server will stop accepting connections and bring down the whole app.\n\nI do understand the benefit of the naming scheme for those running multiple sidekiq instances on a single machine, but for anyone else it is completely unexpected.  And in our case at least, it breaks system management, which breaks the app.\n\nWe’ve reverted to 0.5.3.\n\n\n> On Dec 4, 2015, at 2:27 PM, Abdelkader Boudih <notifications@github.com> wrote:\n> \n> In lib/capistrano/tasks/capistrano2.rb:\n> \n> > @@ -34,11 +34,7 @@\n> >      def for_each_process(sidekiq_role, &block)\n> >        sidekiq_processes = fetch(:\"#{ sidekiq_role }_processes\") rescue 1\n> >        sidekiq_processes.times do |idx|\n> > -        if idx.zero? && sidekiq_processes <= 1\n> > -          pid_file = fetch(:sidekiq_pid)\n> > -        else\n> > -          pid_file = fetch(:sidekiq_pid).gsub(/\\.pid$/, \"-#{idx}.pid\")\n> > -        end\n> > +        pid_file = fetch(:sidekiq_pid).gsub(/\\.pid$/, \"-#{idx}.pid\")\n> \n> what serious problems ?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n\n","created_at":"2015-12-05T00:02:44Z","updated_at":"2015-12-05T00:02:44Z","html_url":"https://github.com/seuros/capistrano-sidekiq/pull/116#discussion_r46747325","pull_request_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/comments/46747325"},"html":{"href":"https://github.com/seuros/capistrano-sidekiq/pull/116#discussion_r46747325"},"pull_request":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116","id":48859459,"html_url":"https://github.com/seuros/capistrano-sidekiq/pull/116","diff_url":"https://github.com/seuros/capistrano-sidekiq/pull/116.diff","patch_url":"https://github.com/seuros/capistrano-sidekiq/pull/116.patch","issue_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/116","number":116,"state":"closed","locked":false,"title":"Change pidfile handling, always add index to pidfile name","user":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"body":"Fix this issue. https://github.com/seuros/capistrano-sidekiq/issues/44\r\n\r\nChanged always add index to pidfile.","created_at":"2015-10-27T11:41:44Z","updated_at":"2015-12-05T00:02:44Z","closed_at":"2015-10-27T11:57:26Z","merged_at":"2015-10-27T11:57:26Z","merge_commit_sha":"e0914d9548032fde2fd4fb010a0c88b56bd1599a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116/commits","review_comments_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116/comments","review_comment_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/116/comments","statuses_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/statuses/a4f508bc5002a8468e5874a4d5942f20c1b38323","head":{"label":"w1mvy:fix_pidfile_handling","ref":"fix_pidfile_handling","sha":"a4f508bc5002a8468e5874a4d5942f20c1b38323","user":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"repo":{"id":45029595,"name":"capistrano-sidekiq","full_name":"w1mvy/capistrano-sidekiq","owner":{"login":"w1mvy","id":362371,"avatar_url":"https://avatars.githubusercontent.com/u/362371?v=3","gravatar_id":"","url":"https://api.github.com/users/w1mvy","html_url":"https://github.com/w1mvy","followers_url":"https://api.github.com/users/w1mvy/followers","following_url":"https://api.github.com/users/w1mvy/following{/other_user}","gists_url":"https://api.github.com/users/w1mvy/gists{/gist_id}","starred_url":"https://api.github.com/users/w1mvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1mvy/subscriptions","organizations_url":"https://api.github.com/users/w1mvy/orgs","repos_url":"https://api.github.com/users/w1mvy/repos","events_url":"https://api.github.com/users/w1mvy/events{/privacy}","received_events_url":"https://api.github.com/users/w1mvy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w1mvy/capistrano-sidekiq","description":"Sidekiq integration for Capistrano","fork":true,"url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq","forks_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/forks","keys_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/teams","hooks_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/hooks","issue_events_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/events","assignees_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/tags","blobs_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/languages","stargazers_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/stargazers","contributors_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/contributors","subscribers_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/subscribers","subscription_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/subscription","commits_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/merges","archive_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/downloads","issues_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/w1mvy/capistrano-sidekiq/releases{/id}","created_at":"2015-10-27T09:17:37Z","updated_at":"2015-10-27T09:17:38Z","pushed_at":"2015-10-30T02:21:36Z","git_url":"git://github.com/w1mvy/capistrano-sidekiq.git","ssh_url":"git@github.com:w1mvy/capistrano-sidekiq.git","clone_url":"https://github.com/w1mvy/capistrano-sidekiq.git","svn_url":"https://github.com/w1mvy/capistrano-sidekiq","homepage":null,"size":212,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seuros:master","ref":"master","sha":"521ea271aa767675210eac92cd9e1ac5c78744eb","user":{"login":"seuros","id":2394703,"avatar_url":"https://avatars.githubusercontent.com/u/2394703?v=3","gravatar_id":"","url":"https://api.github.com/users/seuros","html_url":"https://github.com/seuros","followers_url":"https://api.github.com/users/seuros/followers","following_url":"https://api.github.com/users/seuros/following{/other_user}","gists_url":"https://api.github.com/users/seuros/gists{/gist_id}","starred_url":"https://api.github.com/users/seuros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seuros/subscriptions","organizations_url":"https://api.github.com/users/seuros/orgs","repos_url":"https://api.github.com/users/seuros/repos","events_url":"https://api.github.com/users/seuros/events{/privacy}","received_events_url":"https://api.github.com/users/seuros/received_events","type":"User","site_admin":false},"repo":{"id":17669530,"name":"capistrano-sidekiq","full_name":"seuros/capistrano-sidekiq","owner":{"login":"seuros","id":2394703,"avatar_url":"https://avatars.githubusercontent.com/u/2394703?v=3","gravatar_id":"","url":"https://api.github.com/users/seuros","html_url":"https://github.com/seuros","followers_url":"https://api.github.com/users/seuros/followers","following_url":"https://api.github.com/users/seuros/following{/other_user}","gists_url":"https://api.github.com/users/seuros/gists{/gist_id}","starred_url":"https://api.github.com/users/seuros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seuros/subscriptions","organizations_url":"https://api.github.com/users/seuros/orgs","repos_url":"https://api.github.com/users/seuros/repos","events_url":"https://api.github.com/users/seuros/events{/privacy}","received_events_url":"https://api.github.com/users/seuros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seuros/capistrano-sidekiq","description":"Sidekiq integration for Capistrano","fork":false,"url":"https://api.github.com/repos/seuros/capistrano-sidekiq","forks_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/forks","keys_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/teams","hooks_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/hooks","issue_events_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/events{/number}","events_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/events","assignees_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/assignees{/user}","branches_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/branches{/branch}","tags_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/tags","blobs_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/statuses/{sha}","languages_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/languages","stargazers_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/stargazers","contributors_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/contributors","subscribers_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/subscribers","subscription_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/subscription","commits_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/contents/{+path}","compare_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/merges","archive_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/downloads","issues_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues{/number}","pulls_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls{/number}","milestones_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/milestones{/number}","notifications_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/labels{/name}","releases_url":"https://api.github.com/repos/seuros/capistrano-sidekiq/releases{/id}","created_at":"2014-03-12T14:21:45Z","updated_at":"2015-12-02T20:42:43Z","pushed_at":"2015-12-01T22:42:59Z","git_url":"git://github.com/seuros/capistrano-sidekiq.git","ssh_url":"git@github.com:seuros/capistrano-sidekiq.git","clone_url":"https://github.com/seuros/capistrano-sidekiq.git","svn_url":"https://github.com/seuros/capistrano-sidekiq","homepage":null,"size":161,"stargazers_count":244,"watchers_count":244,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":20,"forks":110,"open_issues":20,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116"},"html":{"href":"https://github.com/seuros/capistrano-sidekiq/pull/116"},"issue":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/116"},"comments":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/seuros/capistrano-sidekiq/statuses/a4f508bc5002a8468e5874a4d5942f20c1b38323"}}}}