{"action":"created","issue":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1448","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1448/labels{/name}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1448/comments","events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1448/events","html_url":"https://github.com/paparazzi/paparazzi/pull/1448","id":119370743,"number":1448,"title":"Change register_periodic_telemetry() to use msg ID and support other protocols (mavlink)","user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-29T17:06:23Z","updated_at":"2015-11-30T15:38:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1448","html_url":"https://github.com/paparazzi/paparazzi/pull/1448","diff_url":"https://github.com/paparazzi/paparazzi/pull/1448.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1448.patch"},"body":"Alternative to #1442:\r\n- Change register_periodic_telemetry() to use msg ID\r\n- possibility to use register_periodic_telemetry for mavlink and others.\r\n -  in the telemetry xml file a type can be specified for the process (default is \"pprz\").\r\n - You can also set \"mavlink\" and use mavlink messages, which will be sent as specified if the mavlink module is loaded and that mavlink message is registered there.\r\n- use PPRZ_MSG_ID_x instead of DL_x\r\n\r\nThis requires an extra unit8_t id field in the struct (so if you have 20 different messages in the telmetry file, this would add an extra 20bytes compared to #1442).\r\nAt runtime it will loop over the periodic messages until it finds the matching id (compared to already knowing the index).\r\nAlso this really makes it impossible to register \"meta/alias\" messages... but I would argue that even in #1442 this is not nice since you need to provide the #ifndefs in the code..."},"comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments/160663743","html_url":"https://github.com/paparazzi/paparazzi/pull/1448#issuecomment-160663743","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1448","id":160663743,"user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T15:38:44Z","updated_at":"2015-11-30T15:38:44Z","body":"ping @dewagter @martinmm would be great if you could chip in here... would like to merge this ASAP..."}}