{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/express-csp/pulls/comments/26360874","id":26360874,"diff_hunk":"@@ -1,4 +1,18 @@\n language: node_js\n node_js:\n-    - \"0.10\"\n-    - \"0.12\"\n+    - 0.1\n+    - 0.12\n+notifications:\n+    email:\n+        recipients:\n+            - ypt-team@yahoo-inc.com\n+        on_success: change\n+        on_failure: always\n+deploy:\n+    provider: npm\n+    email: ypt-team@yahoo-inc.com\n+    api_key: \n+        secure: s5KbfZ2QmDElovpw8PZYFwiwYIcvmORO1dpnsbSpuNrdgW/vr79vxmETg1RdaTOC+eprtJgf3DkqBeuUeavc2S9ksO9sbryhL48Sfu3wQBQWIfana6H1weVpHxUfS4TU9bT2zRlxRDQsYuFmmtacaJ0DpDKrnpdpVBgXxKJWq4o=\n+    on:\n+        tags: true","path":".travis.yml","position":19,"original_position":19,"commit_id":"e0ba12301799826246f00067a12fd0735c26c1bd","original_commit_id":"e0ba12301799826246f00067a12fd0735c26c1bd","user":{"login":"jasonmit","id":3108309,"avatar_url":"https://avatars.githubusercontent.com/u/3108309?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"body":"This will only trigger an npm publish when we tag a release on github.\r\n\r\nThis may be a better workflow then listening for package.version changes since it prevents us for getting in the habit of not tagging.\r\n\r\n/cc @ericf @caridy - thoughts?","created_at":"2015-03-13T02:11:46Z","updated_at":"2015-03-13T02:11:46Z","html_url":"https://github.com/yahoo/express-csp/pull/2#discussion_r26360874","pull_request_url":"https://api.github.com/repos/yahoo/express-csp/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/comments/26360874"},"html":{"href":"https://github.com/yahoo/express-csp/pull/2#discussion_r26360874"},"pull_request":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/express-csp/pulls/2","id":31094093,"html_url":"https://github.com/yahoo/express-csp/pull/2","diff_url":"https://github.com/yahoo/express-csp/pull/2.diff","patch_url":"https://github.com/yahoo/express-csp/pull/2.patch","issue_url":"https://api.github.com/repos/yahoo/express-csp/issues/2","number":2,"state":"open","locked":false,"title":"Moving logic to constructor + prototype functions","user":{"login":"jasonmit","id":3108309,"avatar_url":"https://avatars.githubusercontent.com/u/3108309?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"body":"I did some minor changes while looking through the code.\r\n\r\nThe diff is substantial but it's simply moving logic out of the scoped function block of `exports.extend` and into a constructor with prototype functions.\r\n\r\n/cc @caridy ","created_at":"2015-03-13T01:45:53Z","updated_at":"2015-03-13T02:11:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efcbc940e50ba0d940431f2082817331e00a3751","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/express-csp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/yahoo/express-csp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/yahoo/express-csp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/express-csp/issues/2/comments","statuses_url":"https://api.github.com/repos/yahoo/express-csp/statuses/e0ba12301799826246f00067a12fd0735c26c1bd","head":{"label":"yahoo:travis-deploy","ref":"travis-deploy","sha":"e0ba12301799826246f00067a12fd0735c26c1bd","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":32099438,"name":"express-csp","full_name":"yahoo/express-csp","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/express-csp","description":"Express extension for Content Security Policy","fork":false,"url":"https://api.github.com/repos/yahoo/express-csp","forks_url":"https://api.github.com/repos/yahoo/express-csp/forks","keys_url":"https://api.github.com/repos/yahoo/express-csp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/express-csp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/express-csp/teams","hooks_url":"https://api.github.com/repos/yahoo/express-csp/hooks","issue_events_url":"https://api.github.com/repos/yahoo/express-csp/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/express-csp/events","assignees_url":"https://api.github.com/repos/yahoo/express-csp/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/express-csp/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/express-csp/tags","blobs_url":"https://api.github.com/repos/yahoo/express-csp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/express-csp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/express-csp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/express-csp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/express-csp/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/express-csp/languages","stargazers_url":"https://api.github.com/repos/yahoo/express-csp/stargazers","contributors_url":"https://api.github.com/repos/yahoo/express-csp/contributors","subscribers_url":"https://api.github.com/repos/yahoo/express-csp/subscribers","subscription_url":"https://api.github.com/repos/yahoo/express-csp/subscription","commits_url":"https://api.github.com/repos/yahoo/express-csp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/express-csp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/express-csp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/express-csp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/express-csp/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/express-csp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/express-csp/merges","archive_url":"https://api.github.com/repos/yahoo/express-csp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/express-csp/downloads","issues_url":"https://api.github.com/repos/yahoo/express-csp/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/express-csp/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/express-csp/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/express-csp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/express-csp/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/express-csp/releases{/id}","created_at":"2015-03-12T20:04:38Z","updated_at":"2015-03-12T20:12:53Z","pushed_at":"2015-03-13T02:06:48Z","git_url":"git://github.com/yahoo/express-csp.git","ssh_url":"git@github.com:yahoo/express-csp.git","clone_url":"https://github.com/yahoo/express-csp.git","svn_url":"https://github.com/yahoo/express-csp","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"75b2924d1d1e6ca24840d69da9c04369a1e441db","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":32099438,"name":"express-csp","full_name":"yahoo/express-csp","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/express-csp","description":"Express extension for Content Security Policy","fork":false,"url":"https://api.github.com/repos/yahoo/express-csp","forks_url":"https://api.github.com/repos/yahoo/express-csp/forks","keys_url":"https://api.github.com/repos/yahoo/express-csp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/express-csp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/express-csp/teams","hooks_url":"https://api.github.com/repos/yahoo/express-csp/hooks","issue_events_url":"https://api.github.com/repos/yahoo/express-csp/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/express-csp/events","assignees_url":"https://api.github.com/repos/yahoo/express-csp/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/express-csp/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/express-csp/tags","blobs_url":"https://api.github.com/repos/yahoo/express-csp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/express-csp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/express-csp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/express-csp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/express-csp/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/express-csp/languages","stargazers_url":"https://api.github.com/repos/yahoo/express-csp/stargazers","contributors_url":"https://api.github.com/repos/yahoo/express-csp/contributors","subscribers_url":"https://api.github.com/repos/yahoo/express-csp/subscribers","subscription_url":"https://api.github.com/repos/yahoo/express-csp/subscription","commits_url":"https://api.github.com/repos/yahoo/express-csp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/express-csp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/express-csp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/express-csp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/express-csp/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/express-csp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/express-csp/merges","archive_url":"https://api.github.com/repos/yahoo/express-csp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/express-csp/downloads","issues_url":"https://api.github.com/repos/yahoo/express-csp/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/express-csp/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/express-csp/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/express-csp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/express-csp/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/express-csp/releases{/id}","created_at":"2015-03-12T20:04:38Z","updated_at":"2015-03-12T20:12:53Z","pushed_at":"2015-03-13T02:06:48Z","git_url":"git://github.com/yahoo/express-csp.git","ssh_url":"git@github.com:yahoo/express-csp.git","clone_url":"https://github.com/yahoo/express-csp.git","svn_url":"https://github.com/yahoo/express-csp","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/2"},"html":{"href":"https://github.com/yahoo/express-csp/pull/2"},"issue":{"href":"https://api.github.com/repos/yahoo/express-csp/issues/2"},"comments":{"href":"https://api.github.com/repos/yahoo/express-csp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/express-csp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/express-csp/statuses/e0ba12301799826246f00067a12fd0735c26c1bd"}}}}