{"action":"created","comment":{"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/comments/41198506","id":41198506,"diff_hunk":"@@ -153,12 +154,18 @@ struct BCFKeyValueData_body {\n     ActiveMetadata amd;\n     std::mutex statsMutex;\n     StatsRangeQuery statsRq; // statistics for range queries\n+    std::unique_ptr<BCFBucketCache> bucketCache;\n };\n \n auto collections { \"config\", \"sampleset\", \"sample_dataset\", \"header\", \"bcf\" };\n \n BCFKeyValueData::BCFKeyValueData() = default;\n-BCFKeyValueData::~BCFKeyValueData() = default;\n+\n+BCFKeyValueData::~BCFKeyValueData() {\n+    body_->rangeHelper.reset();\n+    body_->bucketCache.reset();\n+}","path":"src/BCFKeyValueData.cc","position":22,"original_position":22,"commit_id":"b77274849849122b62ed23da6527000197798c22","original_commit_id":"b77274849849122b62ed23da6527000197798c22","user":{"login":"mlin","id":356550,"avatar_url":"https://avatars.githubusercontent.com/u/356550?v=3","gravatar_id":"","url":"https://api.github.com/users/mlin","html_url":"https://github.com/mlin","followers_url":"https://api.github.com/users/mlin/followers","following_url":"https://api.github.com/users/mlin/following{/other_user}","gists_url":"https://api.github.com/users/mlin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlin/subscriptions","organizations_url":"https://api.github.com/users/mlin/orgs","repos_url":"https://api.github.com/users/mlin/repos","events_url":"https://api.github.com/users/mlin/events{/privacy}","received_events_url":"https://api.github.com/users/mlin/received_events","type":"User","site_admin":false},"body":"Are these resets redundant leftovers from fighting the memory leak?","created_at":"2015-10-05T21:13:02Z","updated_at":"2015-10-05T21:13:02Z","html_url":"https://github.com/dnanexus-rnd/GLnexus/pull/25#discussion_r41198506","pull_request_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/comments/41198506"},"html":{"href":"https://github.com/dnanexus-rnd/GLnexus/pull/25#discussion_r41198506"},"pull_request":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25","id":46561772,"html_url":"https://github.com/dnanexus-rnd/GLnexus/pull/25","diff_url":"https://github.com/dnanexus-rnd/GLnexus/pull/25.diff","patch_url":"https://github.com/dnanexus-rnd/GLnexus/pull/25.patch","issue_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/25","number":25,"state":"open","locked":false,"title":"Bcf bucket cache mt","user":{"login":"orodeh","id":7037561,"avatar_url":"https://avatars.githubusercontent.com/u/7037561?v=3","gravatar_id":"","url":"https://api.github.com/users/orodeh","html_url":"https://github.com/orodeh","followers_url":"https://api.github.com/users/orodeh/followers","following_url":"https://api.github.com/users/orodeh/following{/other_user}","gists_url":"https://api.github.com/users/orodeh/gists{/gist_id}","starred_url":"https://api.github.com/users/orodeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orodeh/subscriptions","organizations_url":"https://api.github.com/users/orodeh/orgs","repos_url":"https://api.github.com/users/orodeh/repos","events_url":"https://api.github.com/users/orodeh/events{/privacy}","received_events_url":"https://api.github.com/users/orodeh/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-01T18:51:17Z","updated_at":"2015-10-05T21:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ba79f31b3b628dcc742c0e74f313b8f1304c489","assignee":{"login":"mlin","id":356550,"avatar_url":"https://avatars.githubusercontent.com/u/356550?v=3","gravatar_id":"","url":"https://api.github.com/users/mlin","html_url":"https://github.com/mlin","followers_url":"https://api.github.com/users/mlin/followers","following_url":"https://api.github.com/users/mlin/following{/other_user}","gists_url":"https://api.github.com/users/mlin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlin/subscriptions","organizations_url":"https://api.github.com/users/mlin/orgs","repos_url":"https://api.github.com/users/mlin/repos","events_url":"https://api.github.com/users/mlin/events{/privacy}","received_events_url":"https://api.github.com/users/mlin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25/commits","review_comments_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25/comments","review_comment_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/25/comments","statuses_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/statuses/b77274849849122b62ed23da6527000197798c22","head":{"label":"dnanexus-rnd:bcf_bucket_cache_mt","ref":"bcf_bucket_cache_mt","sha":"b77274849849122b62ed23da6527000197798c22","user":{"login":"dnanexus-rnd","id":11299902,"avatar_url":"https://avatars.githubusercontent.com/u/11299902?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus-rnd","html_url":"https://github.com/dnanexus-rnd","followers_url":"https://api.github.com/users/dnanexus-rnd/followers","following_url":"https://api.github.com/users/dnanexus-rnd/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus-rnd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus-rnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus-rnd/subscriptions","organizations_url":"https://api.github.com/users/dnanexus-rnd/orgs","repos_url":"https://api.github.com/users/dnanexus-rnd/repos","events_url":"https://api.github.com/users/dnanexus-rnd/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus-rnd/received_events","type":"Organization","site_admin":false},"repo":{"id":33585912,"name":"GLnexus","full_name":"dnanexus-rnd/GLnexus","owner":{"login":"dnanexus-rnd","id":11299902,"avatar_url":"https://avatars.githubusercontent.com/u/11299902?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus-rnd","html_url":"https://github.com/dnanexus-rnd","followers_url":"https://api.github.com/users/dnanexus-rnd/followers","following_url":"https://api.github.com/users/dnanexus-rnd/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus-rnd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus-rnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus-rnd/subscriptions","organizations_url":"https://api.github.com/users/dnanexus-rnd/orgs","repos_url":"https://api.github.com/users/dnanexus-rnd/repos","events_url":"https://api.github.com/users/dnanexus-rnd/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus-rnd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnanexus-rnd/GLnexus","description":"Scalable datastore for population genome sequencing, with on-demand joint genotyping","fork":false,"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus","forks_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/forks","keys_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/teams","hooks_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/hooks","issue_events_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/events{/number}","events_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/events","assignees_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/assignees{/user}","branches_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/branches{/branch}","tags_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/tags","blobs_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/statuses/{sha}","languages_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/languages","stargazers_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/stargazers","contributors_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/contributors","subscribers_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/subscribers","subscription_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/subscription","commits_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/contents/{+path}","compare_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/merges","archive_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/downloads","issues_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues{/number}","pulls_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls{/number}","milestones_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/milestones{/number}","notifications_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/labels{/name}","releases_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/releases{/id}","created_at":"2015-04-08T05:05:05Z","updated_at":"2015-09-19T20:39:38Z","pushed_at":"2015-10-05T18:57:10Z","git_url":"git://github.com/dnanexus-rnd/GLnexus.git","ssh_url":"git@github.com:dnanexus-rnd/GLnexus.git","clone_url":"https://github.com/dnanexus-rnd/GLnexus.git","svn_url":"https://github.com/dnanexus-rnd/GLnexus","homepage":"","size":4585,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dnanexus-rnd:master","ref":"master","sha":"a4ec63b6f33aa821ee9cbbe3d1be786f2ed80452","user":{"login":"dnanexus-rnd","id":11299902,"avatar_url":"https://avatars.githubusercontent.com/u/11299902?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus-rnd","html_url":"https://github.com/dnanexus-rnd","followers_url":"https://api.github.com/users/dnanexus-rnd/followers","following_url":"https://api.github.com/users/dnanexus-rnd/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus-rnd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus-rnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus-rnd/subscriptions","organizations_url":"https://api.github.com/users/dnanexus-rnd/orgs","repos_url":"https://api.github.com/users/dnanexus-rnd/repos","events_url":"https://api.github.com/users/dnanexus-rnd/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus-rnd/received_events","type":"Organization","site_admin":false},"repo":{"id":33585912,"name":"GLnexus","full_name":"dnanexus-rnd/GLnexus","owner":{"login":"dnanexus-rnd","id":11299902,"avatar_url":"https://avatars.githubusercontent.com/u/11299902?v=3","gravatar_id":"","url":"https://api.github.com/users/dnanexus-rnd","html_url":"https://github.com/dnanexus-rnd","followers_url":"https://api.github.com/users/dnanexus-rnd/followers","following_url":"https://api.github.com/users/dnanexus-rnd/following{/other_user}","gists_url":"https://api.github.com/users/dnanexus-rnd/gists{/gist_id}","starred_url":"https://api.github.com/users/dnanexus-rnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnanexus-rnd/subscriptions","organizations_url":"https://api.github.com/users/dnanexus-rnd/orgs","repos_url":"https://api.github.com/users/dnanexus-rnd/repos","events_url":"https://api.github.com/users/dnanexus-rnd/events{/privacy}","received_events_url":"https://api.github.com/users/dnanexus-rnd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dnanexus-rnd/GLnexus","description":"Scalable datastore for population genome sequencing, with on-demand joint genotyping","fork":false,"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus","forks_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/forks","keys_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/teams","hooks_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/hooks","issue_events_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/events{/number}","events_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/events","assignees_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/assignees{/user}","branches_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/branches{/branch}","tags_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/tags","blobs_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/statuses/{sha}","languages_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/languages","stargazers_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/stargazers","contributors_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/contributors","subscribers_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/subscribers","subscription_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/subscription","commits_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/contents/{+path}","compare_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/merges","archive_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/downloads","issues_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues{/number}","pulls_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls{/number}","milestones_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/milestones{/number}","notifications_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/labels{/name}","releases_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/releases{/id}","created_at":"2015-04-08T05:05:05Z","updated_at":"2015-09-19T20:39:38Z","pushed_at":"2015-10-05T18:57:10Z","git_url":"git://github.com/dnanexus-rnd/GLnexus.git","ssh_url":"git@github.com:dnanexus-rnd/GLnexus.git","clone_url":"https://github.com/dnanexus-rnd/GLnexus.git","svn_url":"https://github.com/dnanexus-rnd/GLnexus","homepage":"","size":4585,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25"},"html":{"href":"https://github.com/dnanexus-rnd/GLnexus/pull/25"},"issue":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/25"},"comments":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/dnanexus-rnd/GLnexus/statuses/b77274849849122b62ed23da6527000197798c22"}}}}