{"action":"closed","number":715,"pull_request":{"url":"https://api.github.com/repos/openstax/tutor-js/pulls/715","id":43948872,"html_url":"https://github.com/openstax/tutor-js/pull/715","diff_url":"https://github.com/openstax/tutor-js/pull/715.diff","patch_url":"https://github.com/openstax/tutor-js/pull/715.patch","issue_url":"https://api.github.com/repos/openstax/tutor-js/issues/715","number":715,"state":"closed","locked":false,"title":"Fix bug where external assignment not counted when manually opened in a new tab ","user":{"login":"nathanstitt","id":79566,"avatar_url":"https://avatars.githubusercontent.com/u/79566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanstitt","html_url":"https://github.com/nathanstitt","followers_url":"https://api.github.com/users/nathanstitt/followers","following_url":"https://api.github.com/users/nathanstitt/following{/other_user}","gists_url":"https://api.github.com/users/nathanstitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanstitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanstitt/subscriptions","organizations_url":"https://api.github.com/users/nathanstitt/orgs","repos_url":"https://api.github.com/users/nathanstitt/repos","events_url":"https://api.github.com/users/nathanstitt/events{/privacy}","received_events_url":"https://api.github.com/users/nathanstitt/received_events","type":"User","site_admin":false},"body":"When a link is right or middle mouse button clicked to open\r\nin a new window, the current page does not receive any events.  This\r\nmeans the link will be loaded, but the step not marked as completed \r\nsince the onClick handler is never called.\r\n\r\nTo work around this, we setup a new destination url and have the link\r\npoint to that.  If the onClick hander is called, we open the external\r\nlink in a new window (tab) and mark the step as complete.  If the\r\nhandler isn't called and the destination page is loaded, we mark it\r\ncomplete there and open the window at that time.","created_at":"2015-09-02T02:47:45Z","updated_at":"2015-09-11T16:20:16Z","closed_at":"2015-09-11T16:20:16Z","merged_at":null,"merge_commit_sha":"6b0d4a3ae7bc1c8e8a15544cf8a8ddf7e4caa52c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstax/tutor-js/pulls/715/commits","review_comments_url":"https://api.github.com/repos/openstax/tutor-js/pulls/715/comments","review_comment_url":"https://api.github.com/repos/openstax/tutor-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/tutor-js/issues/715/comments","statuses_url":"https://api.github.com/repos/openstax/tutor-js/statuses/df64d59670e08d9d95eb0f1ec1dbd85357510580","head":{"label":"openstax:fix/external-task-new-tab","ref":"fix/external-task-new-tab","sha":"df64d59670e08d9d95eb0f1ec1dbd85357510580","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":24433756,"name":"tutor-js","full_name":"openstax/tutor-js","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/tutor-js","description":":mortar_board: Javascript frontend for openstax tutor","fork":false,"url":"https://api.github.com/repos/openstax/tutor-js","forks_url":"https://api.github.com/repos/openstax/tutor-js/forks","keys_url":"https://api.github.com/repos/openstax/tutor-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/tutor-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/tutor-js/teams","hooks_url":"https://api.github.com/repos/openstax/tutor-js/hooks","issue_events_url":"https://api.github.com/repos/openstax/tutor-js/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/tutor-js/events","assignees_url":"https://api.github.com/repos/openstax/tutor-js/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/tutor-js/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/tutor-js/tags","blobs_url":"https://api.github.com/repos/openstax/tutor-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/tutor-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/tutor-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/tutor-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/tutor-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/tutor-js/languages","stargazers_url":"https://api.github.com/repos/openstax/tutor-js/stargazers","contributors_url":"https://api.github.com/repos/openstax/tutor-js/contributors","subscribers_url":"https://api.github.com/repos/openstax/tutor-js/subscribers","subscription_url":"https://api.github.com/repos/openstax/tutor-js/subscription","commits_url":"https://api.github.com/repos/openstax/tutor-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/tutor-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/tutor-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/tutor-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/tutor-js/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/tutor-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/tutor-js/merges","archive_url":"https://api.github.com/repos/openstax/tutor-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/tutor-js/downloads","issues_url":"https://api.github.com/repos/openstax/tutor-js/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/tutor-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/tutor-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/tutor-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/tutor-js/labels{/name}","releases_url":"https://api.github.com/repos/openstax/tutor-js/releases{/id}","created_at":"2014-09-24T21:42:26Z","updated_at":"2015-05-14T23:01:26Z","pushed_at":"2015-09-11T03:41:47Z","git_url":"git://github.com/openstax/tutor-js.git","ssh_url":"git@github.com:openstax/tutor-js.git","clone_url":"https://github.com/openstax/tutor-js.git","svn_url":"https://github.com/openstax/tutor-js","homepage":"","size":13357,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"1de415d571d844b42569bbb5e4d898a208ebc6f4","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":24433756,"name":"tutor-js","full_name":"openstax/tutor-js","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/tutor-js","description":":mortar_board: Javascript frontend for openstax tutor","fork":false,"url":"https://api.github.com/repos/openstax/tutor-js","forks_url":"https://api.github.com/repos/openstax/tutor-js/forks","keys_url":"https://api.github.com/repos/openstax/tutor-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/tutor-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/tutor-js/teams","hooks_url":"https://api.github.com/repos/openstax/tutor-js/hooks","issue_events_url":"https://api.github.com/repos/openstax/tutor-js/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/tutor-js/events","assignees_url":"https://api.github.com/repos/openstax/tutor-js/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/tutor-js/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/tutor-js/tags","blobs_url":"https://api.github.com/repos/openstax/tutor-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/tutor-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/tutor-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/tutor-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/tutor-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/tutor-js/languages","stargazers_url":"https://api.github.com/repos/openstax/tutor-js/stargazers","contributors_url":"https://api.github.com/repos/openstax/tutor-js/contributors","subscribers_url":"https://api.github.com/repos/openstax/tutor-js/subscribers","subscription_url":"https://api.github.com/repos/openstax/tutor-js/subscription","commits_url":"https://api.github.com/repos/openstax/tutor-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/tutor-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/tutor-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/tutor-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/tutor-js/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/tutor-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/tutor-js/merges","archive_url":"https://api.github.com/repos/openstax/tutor-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/tutor-js/downloads","issues_url":"https://api.github.com/repos/openstax/tutor-js/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/tutor-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/tutor-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/tutor-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/tutor-js/labels{/name}","releases_url":"https://api.github.com/repos/openstax/tutor-js/releases{/id}","created_at":"2014-09-24T21:42:26Z","updated_at":"2015-05-14T23:01:26Z","pushed_at":"2015-09-11T03:41:47Z","git_url":"git://github.com/openstax/tutor-js.git","ssh_url":"git@github.com:openstax/tutor-js.git","clone_url":"https://github.com/openstax/tutor-js.git","svn_url":"https://github.com/openstax/tutor-js","homepage":"","size":13357,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/tutor-js/pulls/715"},"html":{"href":"https://github.com/openstax/tutor-js/pull/715"},"issue":{"href":"https://api.github.com/repos/openstax/tutor-js/issues/715"},"comments":{"href":"https://api.github.com/repos/openstax/tutor-js/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/tutor-js/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/tutor-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/tutor-js/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/tutor-js/statuses/df64d59670e08d9d95eb0f1ec1dbd85357510580"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":7,"commits":6,"additions":137,"deletions":16,"changed_files":9}}