{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6061","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6061/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6061/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6061/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/6061","id":64780766,"number":6061,"title":"Suspicious logic in proxier.go","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/component/kube-proxy","name":"component/kube-proxy","color":"0052cc"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-27T15:11:02Z","updated_at":"2015-03-30T18:34:16Z","closed_at":null,"body":"https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/proxy/proxier.go#L480-L483\r\n\r\nI think this is:\r\n```\r\nif A & B & C {\r\ncontinue\r\n}\r\nif A & (!B || !C || !D) {\r\ndo something\r\n}\r\n```\r\n\r\nI think the !D can never be a factor in the second if statement.  !D only comes in to play if A & B & C, but in that case the first if statement would have been hit.\r\n\r\nI'm thinking that the first if statement should be `if A & B & C & D`.  And that then we can just reduce the second one to `if A`, in this case `if exists`\r\n\r\n@thockin - looks like you touched this last?  Do you agree?"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/87782831","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/6061#issuecomment-87782831","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6061","id":87782831,"user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T18:34:15Z","updated_at":"2015-03-30T18:34:15Z","body":"Agreed. I sent PR #6123 on Friday to fix this same issue, albeit without the simplification of the second condition. I'll update it to include the simplification."}}