{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/25136814","id":25136814,"diff_hunk":"@@ -64,16 +64,20 @@ def allocate_load_balancer(action_handler, lb_spec, lb_options, machine_specs)\n       if lb_options[:security_group_id]\n         security_group = ec2.security_groups[:security_group_id]\n       elsif lb_options[:security_group_name]\n-        security_group = ec2.security_groups.filter('group-name', lb_options[:security_group_name])\n+        security_group = ec2.security_groups.filter('group-name', lb_options[:security_group_name]).first","path":"lib/chef/provisioning/aws_driver/driver.rb","position":5,"original_position":5,"commit_id":"c8e75e3173570b39e6ad53b7bd31a1b7b0980507","original_commit_id":"c8e75e3173570b39e6ad53b7bd31a1b7b0980507","user":{"login":"erikvanbrakel","id":111406,"avatar_url":"https://avatars.githubusercontent.com/u/111406?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanbrakel","html_url":"https://github.com/erikvanbrakel","followers_url":"https://api.github.com/users/erikvanbrakel/followers","following_url":"https://api.github.com/users/erikvanbrakel/following{/other_user}","gists_url":"https://api.github.com/users/erikvanbrakel/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanbrakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanbrakel/subscriptions","organizations_url":"https://api.github.com/users/erikvanbrakel/orgs","repos_url":"https://api.github.com/users/erikvanbrakel/repos","events_url":"https://api.github.com/users/erikvanbrakel/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanbrakel/received_events","type":"User","site_admin":false},"body":"Ah, I think I wrongly diagnosed the bug. The bug is not so much in the calling to the AWS API, but one of the log writes assumes a singular result. Thus this should work with multiple security groups, but fails. Will fix, brb.","created_at":"2015-02-22T21:28:41Z","updated_at":"2015-02-22T21:28:41Z","html_url":"https://github.com/chef/chef-provisioning-aws/pull/97#discussion_r25136814","pull_request_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/25136814"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/97#discussion_r25136814"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97","id":29010205,"html_url":"https://github.com/chef/chef-provisioning-aws/pull/97","diff_url":"https://github.com/chef/chef-provisioning-aws/pull/97.diff","patch_url":"https://github.com/chef/chef-provisioning-aws/pull/97.patch","issue_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/97","number":97,"state":"open","locked":false,"title":"Add scheme and subnets to loadbalancer","user":{"login":"erikvanbrakel","id":111406,"avatar_url":"https://avatars.githubusercontent.com/u/111406?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanbrakel","html_url":"https://github.com/erikvanbrakel","followers_url":"https://api.github.com/users/erikvanbrakel/followers","following_url":"https://api.github.com/users/erikvanbrakel/following{/other_user}","gists_url":"https://api.github.com/users/erikvanbrakel/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanbrakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanbrakel/subscriptions","organizations_url":"https://api.github.com/users/erikvanbrakel/orgs","repos_url":"https://api.github.com/users/erikvanbrakel/repos","events_url":"https://api.github.com/users/erikvanbrakel/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanbrakel/received_events","type":"User","site_admin":false},"body":"The subnets option allows for creating a loadbalancer in a different subnet, to put it in another VPC than the default one.\r\nThe scheme option allows for creating an internal loadbalancer, as opposed to the default which is internet-facing (even though the docs say otherwise)\r\n\r\nref: http://docs.aws.amazon.com/AWSRubySDK/latest/AWS/ELB/LoadBalancerCollection.html#create-instance_method","created_at":"2015-02-10T14:21:00Z","updated_at":"2015-02-22T21:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb22195cca13beb350f188fbac7927b13e168f8b","assignee":null,"milestone":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones/1","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones/1/labels","id":855361,"number":1,"title":"1.0","description":"","creator":{"login":"jkeiser","id":654882,"avatar_url":"https://avatars.githubusercontent.com/u/654882?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeiser","html_url":"https://github.com/jkeiser","followers_url":"https://api.github.com/users/jkeiser/followers","following_url":"https://api.github.com/users/jkeiser/following{/other_user}","gists_url":"https://api.github.com/users/jkeiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeiser/subscriptions","organizations_url":"https://api.github.com/users/jkeiser/orgs","repos_url":"https://api.github.com/users/jkeiser/repos","events_url":"https://api.github.com/users/jkeiser/events{/privacy}","received_events_url":"https://api.github.com/users/jkeiser/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":20,"state":"open","created_at":"2014-11-05T23:51:07Z","updated_at":"2015-02-22T06:19:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97/commits","review_comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97/comments","review_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/97/comments","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/c8e75e3173570b39e6ad53b7bd31a1b7b0980507","head":{"label":"erikvanbrakel:add_scheme_and_subnets_to_loadbalancer","ref":"add_scheme_and_subnets_to_loadbalancer","sha":"c8e75e3173570b39e6ad53b7bd31a1b7b0980507","user":{"login":"erikvanbrakel","id":111406,"avatar_url":"https://avatars.githubusercontent.com/u/111406?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanbrakel","html_url":"https://github.com/erikvanbrakel","followers_url":"https://api.github.com/users/erikvanbrakel/followers","following_url":"https://api.github.com/users/erikvanbrakel/following{/other_user}","gists_url":"https://api.github.com/users/erikvanbrakel/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanbrakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanbrakel/subscriptions","organizations_url":"https://api.github.com/users/erikvanbrakel/orgs","repos_url":"https://api.github.com/users/erikvanbrakel/repos","events_url":"https://api.github.com/users/erikvanbrakel/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanbrakel/received_events","type":"User","site_admin":false},"repo":{"id":28628364,"name":"chef-provisioning-aws","full_name":"erikvanbrakel/chef-provisioning-aws","owner":{"login":"erikvanbrakel","id":111406,"avatar_url":"https://avatars.githubusercontent.com/u/111406?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanbrakel","html_url":"https://github.com/erikvanbrakel","followers_url":"https://api.github.com/users/erikvanbrakel/followers","following_url":"https://api.github.com/users/erikvanbrakel/following{/other_user}","gists_url":"https://api.github.com/users/erikvanbrakel/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanbrakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanbrakel/subscriptions","organizations_url":"https://api.github.com/users/erikvanbrakel/orgs","repos_url":"https://api.github.com/users/erikvanbrakel/repos","events_url":"https://api.github.com/users/erikvanbrakel/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanbrakel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikvanbrakel/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":true,"url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws","forks_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/erikvanbrakel/chef-provisioning-aws/releases{/id}","created_at":"2014-12-30T11:25:47Z","updated_at":"2015-02-02T13:44:00Z","pushed_at":"2015-02-18T21:08:25Z","git_url":"git://github.com/erikvanbrakel/chef-provisioning-aws.git","ssh_url":"git@github.com:erikvanbrakel/chef-provisioning-aws.git","clone_url":"https://github.com/erikvanbrakel/chef-provisioning-aws.git","svn_url":"https://github.com/erikvanbrakel/chef-provisioning-aws","homepage":"","size":270,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"a0d2953116b7c75a7fcef4637ce5e878b3b4c889","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24198103,"name":"chef-provisioning-aws","full_name":"chef/chef-provisioning-aws","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-aws","forks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-aws/releases{/id}","created_at":"2014-09-18T17:32:40Z","updated_at":"2015-02-21T18:53:27Z","pushed_at":"2015-02-21T18:53:29Z","git_url":"git://github.com/chef/chef-provisioning-aws.git","ssh_url":"git@github.com:chef/chef-provisioning-aws.git","clone_url":"https://github.com/chef/chef-provisioning-aws.git","svn_url":"https://github.com/chef/chef-provisioning-aws","homepage":"","size":1168,"stargazers_count":24,"watchers_count":24,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/97"},"issue":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/97"},"comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/c8e75e3173570b39e6ad53b7bd31a1b7b0980507"}}}}