{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/comments/48523235","id":48523235,"diff_hunk":"@@ -74,6 +74,24 @@ public function execute(array $params = array(), $hydrationMode = null)\n             $queryBuilder->resetDQLPart('orderBy');\n         }\n \n+        /* By default, always add a sort on the identifier fields of the first\n+            * used entity in the query, because RDBMS do not guarantee a","path":"Datagrid/ProxyQuery.php","position":5,"original_position":5,"commit_id":"10923ecbc23a199313af4d6ffb68df21cce55a40","original_commit_id":"10923ecbc23a199313af4d6ffb68df21cce55a40","user":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"body":"i think i saw something like this, but i'm not sure :smile: \r\n\r\nping @rande ","created_at":"2015-12-29T06:23:45Z","updated_at":"2015-12-29T06:23:45Z","html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511#discussion_r48523235","pull_request_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/comments/48523235"},"html":{"href":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511#discussion_r48523235"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511","id":54603150,"html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511","diff_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511.diff","patch_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/511","number":511,"state":"open","locked":false,"title":"Always sort","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"If no ORDER BY query is specified, the order of elements cannot be\r\nguaranteed between executions. See\r\nhttp://stackoverflow.com/questions/1793147/sql-best-practice-to-deal-with-default-sort-order\r\nThis change finds out the identifier keys of the main entity at hand,\r\nand adds a sort based on these keys.\r\nFixes #507 .","created_at":"2015-12-26T14:38:26Z","updated_at":"2015-12-29T06:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5ef02042a97d058173fbdf85cb9510758fdb40d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/511/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/statuses/10923ecbc23a199313af4d6ffb68df21cce55a40","head":{"label":"greg0ire:always_sort","ref":"always_sort","sha":"10923ecbc23a199313af4d6ffb68df21cce55a40","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"repo":{"id":19698925,"name":"SonataDoctrineORMAdminBundle","full_name":"greg0ire/SonataDoctrineORMAdminBundle","owner":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greg0ire/SonataDoctrineORMAdminBundle","description":"Integrates the Doctrine ORM Project into the AdminBundle","fork":true,"url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle","forks_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/forks","keys_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/teams","hooks_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/events","assignees_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/tags","blobs_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/languages","stargazers_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/subscription","commits_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/merges","archive_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/downloads","issues_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/greg0ire/SonataDoctrineORMAdminBundle/releases{/id}","created_at":"2014-05-12T13:04:08Z","updated_at":"2014-05-12T13:52:57Z","pushed_at":"2015-12-26T14:50:40Z","git_url":"git://github.com/greg0ire/SonataDoctrineORMAdminBundle.git","ssh_url":"git@github.com:greg0ire/SonataDoctrineORMAdminBundle.git","clone_url":"https://github.com/greg0ire/SonataDoctrineORMAdminBundle.git","svn_url":"https://github.com/greg0ire/SonataDoctrineORMAdminBundle","homepage":"http://sonata-project.org/bundles/doctrine-orm-admin","size":715,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"a08761ad76eec615bbae33d8b0e65caa8ce15fc5","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":2687013,"name":"SonataDoctrineORMAdminBundle","full_name":"sonata-project/SonataDoctrineORMAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle","description":"Integrates the Doctrine ORM Project into the AdminBundle","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/releases{/id}","created_at":"2011-11-01T11:12:33Z","updated_at":"2015-12-21T07:52:15Z","pushed_at":"2015-12-28T06:09:24Z","git_url":"git://github.com/sonata-project/SonataDoctrineORMAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataDoctrineORMAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle","homepage":"http://sonata-project.org/bundles/doctrine-orm-admin","size":1324,"stargazers_count":165,"watchers_count":165,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":128,"forks":252,"open_issues":128,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511"},"html":{"href":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/511"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/511"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/statuses/10923ecbc23a199313af4d6ffb68df21cce55a40"}}}}