{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/44323688","id":44323688,"diff_hunk":"@@ -76,7 +76,7 @@ serve:\n \tnode server.js\n \n test:\n-\t./node_modules/.bin/jasmine-node test/katex-spec.js\n+\t./node_modules/.bin/jasmine-node test/*-spec.js","path":"Makefile","position":5,"original_position":5,"commit_id":"d762d986824bab81cb481641dc048a652b0e0b07","original_commit_id":"ac45d7db5943fb2d4a7ad925b67f68ec3cc85627","user":{"login":"xymostech","id":217900,"avatar_url":"https://avatars.githubusercontent.com/u/217900?v=3","gravatar_id":"","url":"https://api.github.com/users/xymostech","html_url":"https://github.com/xymostech","followers_url":"https://api.github.com/users/xymostech/followers","following_url":"https://api.github.com/users/xymostech/following{/other_user}","gists_url":"https://api.github.com/users/xymostech/gists{/gist_id}","starred_url":"https://api.github.com/users/xymostech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymostech/subscriptions","organizations_url":"https://api.github.com/users/xymostech/orgs","repos_url":"https://api.github.com/users/xymostech/repos","events_url":"https://api.github.com/users/xymostech/events{/privacy}","received_events_url":"https://api.github.com/users/xymostech/received_events","type":"User","site_admin":false},"body":"Switching to mocha sounds fine to me! It might take some work to convert our matchers, but sounds like it'll be worth it.","created_at":"2015-11-09T20:05:48Z","updated_at":"2015-11-09T20:05:48Z","html_url":"https://github.com/Khan/KaTeX/pull/385#discussion_r44323688","pull_request_url":"https://api.github.com/repos/Khan/KaTeX/pulls/385","_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/44323688"},"html":{"href":"https://github.com/Khan/KaTeX/pull/385#discussion_r44323688"},"pull_request":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/385"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/385","id":50153359,"html_url":"https://github.com/Khan/KaTeX/pull/385","diff_url":"https://github.com/Khan/KaTeX/pull/385.diff","patch_url":"https://github.com/Khan/KaTeX/pull/385.patch","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/385","number":385,"state":"open","locked":false,"title":"Added unit tests for error messages","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"body":"This is an attempt to actually exercise all the code paths which can lead to a `ParserError` exception (from malformed user input, without tinkering with any KaTeX internals or exploiting a KaTeX bug).  It documents the current state of affairs, without changing any error messages.  Comments indicate future work, particularly with respect to the position often associated with these error messages.\r\n\r\nThis should fix #297.","created_at":"2015-11-09T17:41:57Z","updated_at":"2015-11-09T20:05:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d8f08bd747d8be622fc311e73604bd2551e4d9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Khan/KaTeX/pulls/385/commits","review_comments_url":"https://api.github.com/repos/Khan/KaTeX/pulls/385/comments","review_comment_url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/385/comments","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/d762d986824bab81cb481641dc048a652b0e0b07","head":{"label":"gagern:testErrors","ref":"testErrors","sha":"d762d986824bab81cb481641dc048a652b0e0b07","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"repo":{"id":37335285,"name":"KaTeX","full_name":"gagern/KaTeX","owner":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gagern/KaTeX","description":"Fast math typesetting for the web.","fork":true,"url":"https://api.github.com/repos/gagern/KaTeX","forks_url":"https://api.github.com/repos/gagern/KaTeX/forks","keys_url":"https://api.github.com/repos/gagern/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gagern/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gagern/KaTeX/teams","hooks_url":"https://api.github.com/repos/gagern/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/gagern/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/gagern/KaTeX/events","assignees_url":"https://api.github.com/repos/gagern/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/gagern/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/gagern/KaTeX/tags","blobs_url":"https://api.github.com/repos/gagern/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gagern/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gagern/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/gagern/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gagern/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/gagern/KaTeX/languages","stargazers_url":"https://api.github.com/repos/gagern/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/gagern/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/gagern/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/gagern/KaTeX/subscription","commits_url":"https://api.github.com/repos/gagern/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/gagern/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/gagern/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/gagern/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/gagern/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/gagern/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gagern/KaTeX/merges","archive_url":"https://api.github.com/repos/gagern/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gagern/KaTeX/downloads","issues_url":"https://api.github.com/repos/gagern/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/gagern/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/gagern/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/gagern/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gagern/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/gagern/KaTeX/releases{/id}","created_at":"2015-06-12T17:29:51Z","updated_at":"2015-08-07T12:01:22Z","pushed_at":"2015-11-09T19:32:26Z","git_url":"git://github.com/gagern/KaTeX.git","ssh_url":"git@github.com:gagern/KaTeX.git","clone_url":"https://github.com/gagern/KaTeX.git","svn_url":"https://github.com/gagern/KaTeX","homepage":"http://khan.github.io/KaTeX/","size":24288,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"browserstack"}},"base":{"label":"Khan:master","ref":"master","sha":"21a26b807cb1c3b411257e9eddd581a7fe48b2b6","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":11195700,"name":"KaTeX","full_name":"Khan/KaTeX","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/KaTeX","description":"Fast math typesetting for the web.","fork":false,"url":"https://api.github.com/repos/Khan/KaTeX","forks_url":"https://api.github.com/repos/Khan/KaTeX/forks","keys_url":"https://api.github.com/repos/Khan/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/KaTeX/teams","hooks_url":"https://api.github.com/repos/Khan/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/Khan/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/KaTeX/events","assignees_url":"https://api.github.com/repos/Khan/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/KaTeX/tags","blobs_url":"https://api.github.com/repos/Khan/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/KaTeX/languages","stargazers_url":"https://api.github.com/repos/Khan/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/Khan/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/Khan/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/Khan/KaTeX/subscription","commits_url":"https://api.github.com/repos/Khan/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/KaTeX/merges","archive_url":"https://api.github.com/repos/Khan/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/KaTeX/downloads","issues_url":"https://api.github.com/repos/Khan/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/Khan/KaTeX/releases{/id}","created_at":"2013-07-05T09:01:54Z","updated_at":"2015-11-09T19:28:50Z","pushed_at":"2015-11-09T19:32:28Z","git_url":"git://github.com/Khan/KaTeX.git","ssh_url":"git@github.com:Khan/KaTeX.git","clone_url":"https://github.com/Khan/KaTeX.git","svn_url":"https://github.com/Khan/KaTeX","homepage":"http://khan.github.io/KaTeX/","size":15709,"stargazers_count":4087,"watchers_count":4087,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":235,"mirror_url":null,"open_issues_count":102,"forks":235,"open_issues":102,"watchers":4087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/385"},"html":{"href":"https://github.com/Khan/KaTeX/pull/385"},"issue":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/385"},"comments":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/KaTeX/statuses/d762d986824bab81cb481641dc048a652b0e0b07"}}}}