{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19","id":27989879,"html_url":"https://github.com/lewisd32/lint-maven-plugin/pull/19","diff_url":"https://github.com/lewisd32/lint-maven-plugin/pull/19.diff","patch_url":"https://github.com/lewisd32/lint-maven-plugin/pull/19.patch","issue_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/19","number":19,"state":"closed","locked":false,"title":"Fix for issue #15","user":{"login":"Stephan202","id":513280,"avatar_url":"https://avatars.githubusercontent.com/u/513280?v=3","gravatar_id":"","url":"https://api.github.com/users/Stephan202","html_url":"https://github.com/Stephan202","followers_url":"https://api.github.com/users/Stephan202/followers","following_url":"https://api.github.com/users/Stephan202/following{/other_user}","gists_url":"https://api.github.com/users/Stephan202/gists{/gist_id}","starred_url":"https://api.github.com/users/Stephan202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stephan202/subscriptions","organizations_url":"https://api.github.com/users/Stephan202/orgs","repos_url":"https://api.github.com/users/Stephan202/repos","events_url":"https://api.github.com/users/Stephan202/events{/privacy}","received_events_url":"https://api.github.com/users/Stephan202/received_events","type":"User","site_admin":false},"body":"You were right that resolution of #4 made resolution of #15 very easy.\r\n\r\nOne question: what about testing? We can either:\r\n1. Decide that a code review and manual testing using the POM in #15 is good enough.\r\n2. Create an IT with the example POM and prevent the original issue from being merely logged, but have it bubble up as a fatal exception instead. (E.g. by changing the `IllegalStateException` at `AbstractReduntantVersionRule:135` to an `AssertionError`.)\r\n3. Create an IT with the example POM and verify that no warning is logged anymore. This is probably more trouble than it's worth. (Never done this with log4j directly. If you were to use SLF4J, I'd use [slf4j-test](http://projects.lidalia.org.uk/slf4j-test/).)\r\n\r\nLet me know what you think :)","created_at":"2015-01-25T09:35:38Z","updated_at":"2015-01-27T03:59:27Z","closed_at":"2015-01-27T03:59:26Z","merged_at":"2015-01-27T03:59:26Z","merge_commit_sha":"f7537421f4934fd163d763880c8739cd7390d489","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19/commits","review_comments_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19/comments","review_comment_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/19/comments","statuses_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/statuses/1281097eed60c1c212d3edf1b41c0bc3e2ecd2a3","head":{"label":"Stephan202:fix-for-issue-15","ref":"fix-for-issue-15","sha":"1281097eed60c1c212d3edf1b41c0bc3e2ecd2a3","user":{"login":"Stephan202","id":513280,"avatar_url":"https://avatars.githubusercontent.com/u/513280?v=3","gravatar_id":"","url":"https://api.github.com/users/Stephan202","html_url":"https://github.com/Stephan202","followers_url":"https://api.github.com/users/Stephan202/followers","following_url":"https://api.github.com/users/Stephan202/following{/other_user}","gists_url":"https://api.github.com/users/Stephan202/gists{/gist_id}","starred_url":"https://api.github.com/users/Stephan202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stephan202/subscriptions","organizations_url":"https://api.github.com/users/Stephan202/orgs","repos_url":"https://api.github.com/users/Stephan202/repos","events_url":"https://api.github.com/users/Stephan202/events{/privacy}","received_events_url":"https://api.github.com/users/Stephan202/received_events","type":"User","site_admin":false},"repo":{"id":29808482,"name":"lint-maven-plugin","full_name":"Stephan202/lint-maven-plugin","owner":{"login":"Stephan202","id":513280,"avatar_url":"https://avatars.githubusercontent.com/u/513280?v=3","gravatar_id":"","url":"https://api.github.com/users/Stephan202","html_url":"https://github.com/Stephan202","followers_url":"https://api.github.com/users/Stephan202/followers","following_url":"https://api.github.com/users/Stephan202/following{/other_user}","gists_url":"https://api.github.com/users/Stephan202/gists{/gist_id}","starred_url":"https://api.github.com/users/Stephan202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stephan202/subscriptions","organizations_url":"https://api.github.com/users/Stephan202/orgs","repos_url":"https://api.github.com/users/Stephan202/repos","events_url":"https://api.github.com/users/Stephan202/events{/privacy}","received_events_url":"https://api.github.com/users/Stephan202/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Stephan202/lint-maven-plugin","description":"POM lint plugin for maven","fork":true,"url":"https://api.github.com/repos/Stephan202/lint-maven-plugin","forks_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/forks","keys_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/teams","hooks_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/events","assignees_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/tags","blobs_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/subscription","commits_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/merges","archive_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/downloads","issues_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/Stephan202/lint-maven-plugin/releases{/id}","created_at":"2015-01-25T08:59:54Z","updated_at":"2015-01-26T21:14:41Z","pushed_at":"2015-01-26T22:04:41Z","git_url":"git://github.com/Stephan202/lint-maven-plugin.git","ssh_url":"git@github.com:Stephan202/lint-maven-plugin.git","clone_url":"https://github.com/Stephan202/lint-maven-plugin.git","svn_url":"https://github.com/Stephan202/lint-maven-plugin","homepage":"","size":414,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lewisd32:master","ref":"master","sha":"1154f4c2620d206a08f8f0554cc7e918d0100f30","user":{"login":"lewisd32","id":1637393,"avatar_url":"https://avatars.githubusercontent.com/u/1637393?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisd32","html_url":"https://github.com/lewisd32","followers_url":"https://api.github.com/users/lewisd32/followers","following_url":"https://api.github.com/users/lewisd32/following{/other_user}","gists_url":"https://api.github.com/users/lewisd32/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisd32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisd32/subscriptions","organizations_url":"https://api.github.com/users/lewisd32/orgs","repos_url":"https://api.github.com/users/lewisd32/repos","events_url":"https://api.github.com/users/lewisd32/events{/privacy}","received_events_url":"https://api.github.com/users/lewisd32/received_events","type":"User","site_admin":false},"repo":{"id":4006928,"name":"lint-maven-plugin","full_name":"lewisd32/lint-maven-plugin","owner":{"login":"lewisd32","id":1637393,"avatar_url":"https://avatars.githubusercontent.com/u/1637393?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisd32","html_url":"https://github.com/lewisd32","followers_url":"https://api.github.com/users/lewisd32/followers","following_url":"https://api.github.com/users/lewisd32/following{/other_user}","gists_url":"https://api.github.com/users/lewisd32/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisd32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisd32/subscriptions","organizations_url":"https://api.github.com/users/lewisd32/orgs","repos_url":"https://api.github.com/users/lewisd32/repos","events_url":"https://api.github.com/users/lewisd32/events{/privacy}","received_events_url":"https://api.github.com/users/lewisd32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lewisd32/lint-maven-plugin","description":"POM lint plugin for maven","fork":false,"url":"https://api.github.com/repos/lewisd32/lint-maven-plugin","forks_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/forks","keys_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/teams","hooks_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/events","assignees_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/tags","blobs_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/subscription","commits_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/comments/{number}","contents_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/merges","archive_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/downloads","issues_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/lewisd32/lint-maven-plugin/releases{/id}","created_at":"2012-04-12T16:47:45Z","updated_at":"2015-01-26T01:07:14Z","pushed_at":"2015-01-27T03:59:26Z","git_url":"git://github.com/lewisd32/lint-maven-plugin.git","ssh_url":"git@github.com:lewisd32/lint-maven-plugin.git","clone_url":"https://github.com/lewisd32/lint-maven-plugin.git","svn_url":"https://github.com/lewisd32/lint-maven-plugin","homepage":"","size":545,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19"},"html":{"href":"https://github.com/lewisd32/lint-maven-plugin/pull/19"},"issue":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/19"},"comments":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/lewisd32/lint-maven-plugin/statuses/1281097eed60c1c212d3edf1b41c0bc3e2ecd2a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lewisd32","id":1637393,"avatar_url":"https://avatars.githubusercontent.com/u/1637393?v=3","gravatar_id":"","url":"https://api.github.com/users/lewisd32","html_url":"https://github.com/lewisd32","followers_url":"https://api.github.com/users/lewisd32/followers","following_url":"https://api.github.com/users/lewisd32/following{/other_user}","gists_url":"https://api.github.com/users/lewisd32/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisd32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisd32/subscriptions","organizations_url":"https://api.github.com/users/lewisd32/orgs","repos_url":"https://api.github.com/users/lewisd32/repos","events_url":"https://api.github.com/users/lewisd32/events{/privacy}","received_events_url":"https://api.github.com/users/lewisd32/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":69,"deletions":0,"changed_files":5}}