{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/27805696","id":27805696,"diff_hunk":"@@ -174,12 +174,14 @@ struct BoltStats {\n   3: required map<string, map<GlobalStreamId, double>> process_ms_avg;\n   4: required map<string, map<GlobalStreamId, i64>> executed;  \n   5: required map<string, map<GlobalStreamId, double>> execute_ms_avg;\n+  6: required map<string, map<GlobalStreamId, double>> deserialize_time;","path":"storm-core/src/storm.thrift","position":4,"original_position":4,"commit_id":"43865fdfb0c7de183d7f020dda731915d31b8f5d","original_commit_id":"43865fdfb0c7de183d7f020dda731915d31b8f5d","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"This is still marked as required, if we want a rolling upgrade this needs to be optional, possibly with a reasonable default, and every time we access it, mostly for reads, we need to check to see if it is set.","created_at":"2015-04-06T15:51:08Z","updated_at":"2015-04-06T15:51:08Z","html_url":"https://github.com/apache/storm/pull/442#discussion_r27805696","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/27805696"},"html":{"href":"https://github.com/apache/storm/pull/442#discussion_r27805696"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/442","id":29974089,"html_url":"https://github.com/apache/storm/pull/442","diff_url":"https://github.com/apache/storm/pull/442.diff","patch_url":"https://github.com/apache/storm/pull/442.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/442","number":442,"state":"open","locked":false,"title":"[STORM-671] Measure tuple serialization/deserialization latency.","user":{"login":"Lewuathe","id":1713047,"avatar_url":"https://avatars.githubusercontent.com/u/1713047?v=3","gravatar_id":"","url":"https://api.github.com/users/Lewuathe","html_url":"https://github.com/Lewuathe","followers_url":"https://api.github.com/users/Lewuathe/followers","following_url":"https://api.github.com/users/Lewuathe/following{/other_user}","gists_url":"https://api.github.com/users/Lewuathe/gists{/gist_id}","starred_url":"https://api.github.com/users/Lewuathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lewuathe/subscriptions","organizations_url":"https://api.github.com/users/Lewuathe/orgs","repos_url":"https://api.github.com/users/Lewuathe/repos","events_url":"https://api.github.com/users/Lewuathe/events{/privacy}","received_events_url":"https://api.github.com/users/Lewuathe/received_events","type":"User","site_admin":false},"body":"Measure deserialization time in spout and bolt.\r\nThese values can be see on dashboard UI.\r\n\r\n![screen shot 2015-02-25 at 19 05 37](https://cloud.githubusercontent.com/assets/1713047/6368582/558c07a2-bd21-11e4-8af9-bc1ad245edab.png)\r\n","created_at":"2015-02-25T10:04:02Z","updated_at":"2015-04-06T15:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a016936a4e8fb4615cff81a4cb56626fd404926e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/442/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/442/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/442/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/43865fdfb0c7de183d7f020dda731915d31b8f5d","head":{"label":"Lewuathe:deserialization-time","ref":"deserialization-time","sha":"43865fdfb0c7de183d7f020dda731915d31b8f5d","user":{"login":"Lewuathe","id":1713047,"avatar_url":"https://avatars.githubusercontent.com/u/1713047?v=3","gravatar_id":"","url":"https://api.github.com/users/Lewuathe","html_url":"https://github.com/Lewuathe","followers_url":"https://api.github.com/users/Lewuathe/followers","following_url":"https://api.github.com/users/Lewuathe/following{/other_user}","gists_url":"https://api.github.com/users/Lewuathe/gists{/gist_id}","starred_url":"https://api.github.com/users/Lewuathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lewuathe/subscriptions","organizations_url":"https://api.github.com/users/Lewuathe/orgs","repos_url":"https://api.github.com/users/Lewuathe/repos","events_url":"https://api.github.com/users/Lewuathe/events{/privacy}","received_events_url":"https://api.github.com/users/Lewuathe/received_events","type":"User","site_admin":false},"repo":{"id":26883853,"name":"storm","full_name":"Lewuathe/storm","owner":{"login":"Lewuathe","id":1713047,"avatar_url":"https://avatars.githubusercontent.com/u/1713047?v=3","gravatar_id":"","url":"https://api.github.com/users/Lewuathe","html_url":"https://github.com/Lewuathe","followers_url":"https://api.github.com/users/Lewuathe/followers","following_url":"https://api.github.com/users/Lewuathe/following{/other_user}","gists_url":"https://api.github.com/users/Lewuathe/gists{/gist_id}","starred_url":"https://api.github.com/users/Lewuathe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lewuathe/subscriptions","organizations_url":"https://api.github.com/users/Lewuathe/orgs","repos_url":"https://api.github.com/users/Lewuathe/repos","events_url":"https://api.github.com/users/Lewuathe/events{/privacy}","received_events_url":"https://api.github.com/users/Lewuathe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lewuathe/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/Lewuathe/storm","forks_url":"https://api.github.com/repos/Lewuathe/storm/forks","keys_url":"https://api.github.com/repos/Lewuathe/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lewuathe/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lewuathe/storm/teams","hooks_url":"https://api.github.com/repos/Lewuathe/storm/hooks","issue_events_url":"https://api.github.com/repos/Lewuathe/storm/issues/events{/number}","events_url":"https://api.github.com/repos/Lewuathe/storm/events","assignees_url":"https://api.github.com/repos/Lewuathe/storm/assignees{/user}","branches_url":"https://api.github.com/repos/Lewuathe/storm/branches{/branch}","tags_url":"https://api.github.com/repos/Lewuathe/storm/tags","blobs_url":"https://api.github.com/repos/Lewuathe/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lewuathe/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lewuathe/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lewuathe/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lewuathe/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/Lewuathe/storm/languages","stargazers_url":"https://api.github.com/repos/Lewuathe/storm/stargazers","contributors_url":"https://api.github.com/repos/Lewuathe/storm/contributors","subscribers_url":"https://api.github.com/repos/Lewuathe/storm/subscribers","subscription_url":"https://api.github.com/repos/Lewuathe/storm/subscription","commits_url":"https://api.github.com/repos/Lewuathe/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lewuathe/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lewuathe/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lewuathe/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lewuathe/storm/contents/{+path}","compare_url":"https://api.github.com/repos/Lewuathe/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lewuathe/storm/merges","archive_url":"https://api.github.com/repos/Lewuathe/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lewuathe/storm/downloads","issues_url":"https://api.github.com/repos/Lewuathe/storm/issues{/number}","pulls_url":"https://api.github.com/repos/Lewuathe/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/Lewuathe/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/Lewuathe/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lewuathe/storm/labels{/name}","releases_url":"https://api.github.com/repos/Lewuathe/storm/releases{/id}","created_at":"2014-11-19T22:04:18Z","updated_at":"2015-04-06T14:22:46Z","pushed_at":"2015-04-06T14:25:06Z","git_url":"git://github.com/Lewuathe/storm.git","ssh_url":"git@github.com:Lewuathe/storm.git","clone_url":"https://github.com/Lewuathe/storm.git","svn_url":"https://github.com/Lewuathe/storm","homepage":null,"size":19058,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e2e17e1c7899fb918562bbad21a7e68394b5f285","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-04-06T08:50:20Z","pushed_at":"2015-04-06T14:57:33Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":919086,"stargazers_count":1763,"watchers_count":1763,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1141,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":66,"forks":1141,"open_issues":66,"watchers":1763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/442"},"html":{"href":"https://github.com/apache/storm/pull/442"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/442"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/43865fdfb0c7de183d7f020dda731915d31b8f5d"}}}}