{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29094826","id":29094826,"diff_hunk":"@@ -176,6 +176,8 @@ type RunContainerOptions struct {\n \t// into docker's container runtime.\n \tNetMode string\n \tIpcMode string\n+\t// The parent cgroup to pass to Docker\n+\tCgroupRoot string","path":"pkg/kubelet/container/runtime.go","position":5,"original_position":5,"commit_id":"d12e5c0bbc56865d4a8b63ee6624e0d2a500c9cd","original_commit_id":"7efe2172c0bc77376c5566b87dced988e9e6a961","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"I'm not blocking it.\n\nOn Fri, Apr 24, 2015 at 3:10 PM, Victor Marmol <notifications@github.com>\nwrote:\n\n> In pkg/kubelet/container/runtime.go\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/7277#discussion_r29090057>\n> :\n>\n> > @@ -176,6 +176,8 @@ type RunContainerOptions struct {\n> >  \t// into docker's container runtime.\n> >  \tNetMode string\n> >  \tIpcMode string\n> > +\t// The parent cgroup to pass to Docker\n> > +\tCgroupRoot string\n>\n> This is the only change that remains in case you missed it @guenter\n> <https://github.com/guenter>\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GoogleCloudPlatform/kubernetes/pull/7277/files#r29090057>\n> .\n>\n","created_at":"2015-04-25T00:02:25Z","updated_at":"2015-04-25T00:02:25Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277#discussion_r29094826","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29094826"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277#discussion_r29094826"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277","id":34011625,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7277","number":7277,"state":"open","locked":false,"title":"Add --cgroup_parent flag to Kubelet to set the parent cgroup for pods","user":{"login":"guenter","id":53613,"avatar_url":"https://avatars.githubusercontent.com/u/53613?v=3","gravatar_id":"","url":"https://api.github.com/users/guenter","html_url":"https://github.com/guenter","followers_url":"https://api.github.com/users/guenter/followers","following_url":"https://api.github.com/users/guenter/following{/other_user}","gists_url":"https://api.github.com/users/guenter/gists{/gist_id}","starred_url":"https://api.github.com/users/guenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guenter/subscriptions","organizations_url":"https://api.github.com/users/guenter/orgs","repos_url":"https://api.github.com/users/guenter/repos","events_url":"https://api.github.com/users/guenter/events{/privacy}","received_events_url":"https://api.github.com/users/guenter/received_events","type":"User","site_admin":false},"body":"Implements #6991.\r\n\r\ncc @bgrant0607 @davidopp @jdef @ConnorDoyle","created_at":"2015-04-24T01:16:34Z","updated_at":"2015-04-25T00:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65cb0a1ec9f9ea28d95c02f15f346549f4a81f64","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7277/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/d12e5c0bbc56865d4a8b63ee6624e0d2a500c9cd","head":{"label":"guenter:cgroup-parent","ref":"cgroup-parent","sha":"d12e5c0bbc56865d4a8b63ee6624e0d2a500c9cd","user":{"login":"guenter","id":53613,"avatar_url":"https://avatars.githubusercontent.com/u/53613?v=3","gravatar_id":"","url":"https://api.github.com/users/guenter","html_url":"https://github.com/guenter","followers_url":"https://api.github.com/users/guenter/followers","following_url":"https://api.github.com/users/guenter/following{/other_user}","gists_url":"https://api.github.com/users/guenter/gists{/gist_id}","starred_url":"https://api.github.com/users/guenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guenter/subscriptions","organizations_url":"https://api.github.com/users/guenter/orgs","repos_url":"https://api.github.com/users/guenter/repos","events_url":"https://api.github.com/users/guenter/events{/privacy}","received_events_url":"https://api.github.com/users/guenter/received_events","type":"User","site_admin":false},"repo":{"id":33633914,"name":"kubernetes","full_name":"guenter/kubernetes","owner":{"login":"guenter","id":53613,"avatar_url":"https://avatars.githubusercontent.com/u/53613?v=3","gravatar_id":"","url":"https://api.github.com/users/guenter","html_url":"https://github.com/guenter","followers_url":"https://api.github.com/users/guenter/followers","following_url":"https://api.github.com/users/guenter/following{/other_user}","gists_url":"https://api.github.com/users/guenter/gists{/gist_id}","starred_url":"https://api.github.com/users/guenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guenter/subscriptions","organizations_url":"https://api.github.com/users/guenter/orgs","repos_url":"https://api.github.com/users/guenter/repos","events_url":"https://api.github.com/users/guenter/events{/privacy}","received_events_url":"https://api.github.com/users/guenter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guenter/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/guenter/kubernetes","forks_url":"https://api.github.com/repos/guenter/kubernetes/forks","keys_url":"https://api.github.com/repos/guenter/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guenter/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guenter/kubernetes/teams","hooks_url":"https://api.github.com/repos/guenter/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/guenter/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/guenter/kubernetes/events","assignees_url":"https://api.github.com/repos/guenter/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/guenter/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/guenter/kubernetes/tags","blobs_url":"https://api.github.com/repos/guenter/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guenter/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guenter/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/guenter/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guenter/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/guenter/kubernetes/languages","stargazers_url":"https://api.github.com/repos/guenter/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/guenter/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/guenter/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/guenter/kubernetes/subscription","commits_url":"https://api.github.com/repos/guenter/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/guenter/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/guenter/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/guenter/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/guenter/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/guenter/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guenter/kubernetes/merges","archive_url":"https://api.github.com/repos/guenter/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guenter/kubernetes/downloads","issues_url":"https://api.github.com/repos/guenter/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/guenter/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/guenter/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/guenter/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guenter/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/guenter/kubernetes/releases{/id}","created_at":"2015-04-08T21:45:50Z","updated_at":"2015-04-23T20:48:30Z","pushed_at":"2015-04-24T21:53:16Z","git_url":"git://github.com/guenter/kubernetes.git","ssh_url":"git@github.com:guenter/kubernetes.git","clone_url":"https://github.com/guenter/kubernetes.git","svn_url":"https://github.com/guenter/kubernetes","homepage":"http://kubernetes.io","size":47915,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"0f22b6fc4d0e0667adb4c7003304485f2b866828","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-24T23:55:03Z","pushed_at":"2015-04-24T23:55:03Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":206204,"stargazers_count":7335,"watchers_count":7335,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1462,"mirror_url":null,"open_issues_count":933,"forks":1462,"open_issues":933,"watchers":7335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7277"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7277"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7277/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7277/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/d12e5c0bbc56865d4a8b63ee6624e0d2a500c9cd"}}}}