{"push_id":789926126,"size":6,"distinct_size":6,"ref":"refs/heads/1.25","head":"b886a158d272e260d987545a4b868474f9de28cc","before":"5cd599b6ef08b5fdb212614641d5d383fbef16f3","commits":[{"sha":"8dbac1e52f264290535b602a462108de4233de12","author":{"email":"08db85df4388a447908ff89a25ac64228354b299@gmail.com","name":"Eric Snow"},"message":"Do not close the channel in CertificateUpdater.TearDown.","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/8dbac1e52f264290535b602a462108de4233de12"},{"sha":"d01577eb3200aa38e83843db030aafd994e59fd0","author":{"email":"08db85df4388a447908ff89a25ac64228354b299@gmail.com","name":"Eric Snow"},"message":"Add a comment about where certChangedChan gets closed.","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/d01577eb3200aa38e83843db030aafd994e59fd0"},{"sha":"f0076b15267105926c595e262d1f3599ab5e9810","author":{"email":"08db85df4388a447908ff89a25ac64228354b299@gmail.com","name":"Eric Snow"},"message":"Excise the cert-changed channel from CertificateUpdater.","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/f0076b15267105926c595e262d1f3599ab5e9810"},{"sha":"e2e55055b8d1380cafcec7506c9a31da1fabfcdc","author":{"email":"08db85df4388a447908ff89a25ac64228354b299@gmail.com","name":"Eric Snow"},"message":"Add a TODO.","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/e2e55055b8d1380cafcec7506c9a31da1fabfcdc"},{"sha":"1cf8902023712c0b7b7fd4e0b529fbb7d1cb3800","author":{"email":"08db85df4388a447908ff89a25ac64228354b299@gmail.com","name":"Eric Snow"},"message":"Fix some tests.","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/1cf8902023712c0b7b7fd4e0b529fbb7d1cb3800"},{"sha":"b886a158d272e260d987545a4b868474f9de28cc","author":{"email":"28c2b79e213f53c52a14677e00898d5b855059a0@users.noreply.github.com","name":"Juju bot"},"message":"Merge pull request #3265 from ericsnowcurrently/fix-certupdater-panic-1493123\n\nFix certupdater panic 1493123\n\n(fixes https://bugs.launchpad.net/juju-core/+bug/1493123)\r\n\r\nThis patch addresses a corner case where a shared channel is improperly closed, leading to a panic. See the bug report for more info. For now we are just going to not close the channel. I have thoughts on how we can facilitate closing it when the machine agent is stopped. However, that can wait; basically the channel will be open for the duration of the jujud process anyway. I'd still like to fix that, but it's not critical.\r\n\r\n(Review request: http://reviews.vapour.ws/r/2644/)","distinct":true,"url":"https://api.github.com/repos/juju/juju/commits/b886a158d272e260d987545a4b868474f9de28cc"}]}