{"action":"created","issue":{"url":"https://api.github.com/repos/01org/wysiwidi/issues/85","labels_url":"https://api.github.com/repos/01org/wysiwidi/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/01org/wysiwidi/issues/85/comments","events_url":"https://api.github.com/repos/01org/wysiwidi/issues/85/events","html_url":"https://github.com/01org/wysiwidi/pull/85","id":57346322,"number":85,"title":"Fix video formats","user":{"login":"kanavin","id":1011938,"avatar_url":"https://avatars.githubusercontent.com/u/1011938?v=3","gravatar_id":"","url":"https://api.github.com/users/kanavin","html_url":"https://github.com/kanavin","followers_url":"https://api.github.com/users/kanavin/followers","following_url":"https://api.github.com/users/kanavin/following{/other_user}","gists_url":"https://api.github.com/users/kanavin/gists{/gist_id}","starred_url":"https://api.github.com/users/kanavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanavin/subscriptions","organizations_url":"https://api.github.com/users/kanavin/orgs","repos_url":"https://api.github.com/users/kanavin/repos","events_url":"https://api.github.com/users/kanavin/events{/privacy}","received_events_url":"https://api.github.com/users/kanavin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-11T17:14:05Z","updated_at":"2015-02-12T13:50:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/wysiwidi/pulls/85","html_url":"https://github.com/01org/wysiwidi/pull/85","diff_url":"https://github.com/01org/wysiwidi/pull/85.diff","patch_url":"https://github.com/01org/wysiwidi/pull/85.patch"},"body":"Video format declarations weren't suitable for sinks, so these patches fix the problem.\r\n\r\nAlso, gstreamer source and sink now declare that they support everything (instead of just basic 640x480), and the format selector now considers also profile and level when comparing formats. It would be good to test with 3rd party sources and sinks if that affects (improves) the stream quality.\r\n\r\nThe exchange between our source and sink looks like this now:\r\n\r\n(desktop-source-test:27619): rtsp-DEBUG: Sending RTSP message:\r\nGET_PARAMETER rtsp://localhost/wfd1.0 RTSP/1.0\r\nCSeq: 2\r\nContent-Type: text/parameters\r\nContent-Length: 59\r\n\r\nwfd_video_formats\r\nwfd_audio_codecs\r\nwfd_client_rtp_ports\r\n\r\n(desktop-source-test:27619): rtsp-DEBUG: Received RTSP message:\r\nRTSP/1.0 200 OK\r\nCSeq: 2\r\nContent-Type: text/parameters\r\nContent-Length: 276\r\n\r\nwfd_audio_codecs: LPCM 00000003 00, AAC 0000000F 00, AC3 00000007 00\r\nwfd_client_rtp_ports: RTP/AVP/UDP;unicast 51066 0 mode=play\r\nwfd_video_formats: 40 00 02 10 0001FFFF 1FFFFFFF 00000FFF 00 0000 0000 00 none none, 01 10 0001FFFF 1FFFFFFF 00000FFF 00 0000 0000 00 none none\r\n\r\n(desktop-source-test:27619): rtsp-DEBUG: Sending RTSP message:\r\nSET_PARAMETER rtsp://localhost/wfd1.0 RTSP/1.0\r\nCSeq: 3\r\nContent-Type: text/parameters\r\nContent-Length: 209\r\n\r\nwfd_client_rtp_ports: RTP/AVP/UDP;unicast 51066 0 mode=play\r\nwfd_presentation_URL: rtsp://127.0.0.1/wfd1.0/streamid=0 none\r\nwfd_video_formats: 00 00 02 10 00000100 00000000 00000000 00 0000 0000 00 none none\r\n\r\n(desktop-source-test:27619): rtsp-DEBUG: Received RTSP message:\r\nRTSP/1.0 200 OK\r\nCSeq: 3\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/01org/wysiwidi/issues/comments/74072875","html_url":"https://github.com/01org/wysiwidi/pull/85#issuecomment-74072875","issue_url":"https://api.github.com/repos/01org/wysiwidi/issues/85","id":74072875,"user":{"login":"kanavin","id":1011938,"avatar_url":"https://avatars.githubusercontent.com/u/1011938?v=3","gravatar_id":"","url":"https://api.github.com/users/kanavin","html_url":"https://github.com/kanavin","followers_url":"https://api.github.com/users/kanavin/followers","following_url":"https://api.github.com/users/kanavin/following{/other_user}","gists_url":"https://api.github.com/users/kanavin/gists{/gist_id}","starred_url":"https://api.github.com/users/kanavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanavin/subscriptions","organizations_url":"https://api.github.com/users/kanavin/orgs","repos_url":"https://api.github.com/users/kanavin/repos","events_url":"https://api.github.com/users/kanavin/events{/privacy}","received_events_url":"https://api.github.com/users/kanavin/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T13:50:13Z","updated_at":"2015-02-12T13:50:13Z","body":"For microsoft adapter we pick CEA1920x1080p30.\r\n\r\nAt the moment the source simply declares that it supports every format in the spec. It doesn't check with the pipeline what is the possible range of the actual stream (or adjust the pipeline to match to selected format exactly), I didn't investigate how to do that, and at the moment it looks like more trouble than benefit, since sinks seem to cope ok anyway."}}