{"action":"created","issue":{"url":"https://api.github.com/repos/preillyme/v8js/issues/132","labels_url":"https://api.github.com/repos/preillyme/v8js/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/preillyme/v8js/issues/132/comments","events_url":"https://api.github.com/repos/preillyme/v8js/issues/132/events","html_url":"https://github.com/preillyme/v8js/pull/132","id":51869888,"number":132,"title":"Code cleanup","user":{"login":"stesie","id":113068,"avatar_url":"https://avatars.githubusercontent.com/u/113068?v=3","gravatar_id":"","url":"https://api.github.com/users/stesie","html_url":"https://github.com/stesie","followers_url":"https://api.github.com/users/stesie/followers","following_url":"https://api.github.com/users/stesie/following{/other_user}","gists_url":"https://api.github.com/users/stesie/gists{/gist_id}","starred_url":"https://api.github.com/users/stesie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stesie/subscriptions","organizations_url":"https://api.github.com/users/stesie/orgs","repos_url":"https://api.github.com/users/stesie/repos","events_url":"https://api.github.com/users/stesie/events{/privacy}","received_events_url":"https://api.github.com/users/stesie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-12-13T00:50:41Z","updated_at":"2015-01-03T21:05:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/preillyme/v8js/pulls/132","html_url":"https://github.com/preillyme/v8js/pull/132","diff_url":"https://github.com/preillyme/v8js/pull/132.diff","patch_url":"https://github.com/preillyme/v8js/pull/132.patch"},"body":"This is a major code cleanup I'd like to propose before tackling issue #72 which is going to introduce new classes and a trait.\r\n\r\nCurrently the v8js.cc file is rather messy IMHO as it not only holds everything related to our V8Js main class, but also V8Object & V8Function classes as well as all exception classes + v8 initialization.\r\nI've now split all that stuff into seperate files (v8js_class.cc, v8js_v8object_class.cc, v8js_exceptions.cc + non class stuff in v8js_timer.cc & v8js_v8.cc)\r\n\r\nBesides I found the similarly named handler functions relating to v8js (php_v8js_XXX) and v8object (php_v8js_v8_XXX) classes rather confusing and hence renamed the latter to v8js_v8object_XXX (i.e. with \"object\" term in it)\r\n\r\nAlso we had a huge mess with symbols beginning with \"php_v8js_\" and just  \"v8js_\"; e.g. `php_v8js_ctx`, `php_v8js_execute_string` as opposed to `v8js_to_zval`, `v8js_persistent_obj_t` et al.\r\nSo I removed all the leading php_ prefixes.\r\n\r\n@preillyme @cscott please let me know what you think about that change; if you agree or if I go too far (especially with the renaming of existing symbols, not just moving them around)\r\n\r\ncheers\r\n  ~stesie"},"comment":{"url":"https://api.github.com/repos/preillyme/v8js/issues/comments/68609540","html_url":"https://github.com/preillyme/v8js/pull/132#issuecomment-68609540","issue_url":"https://api.github.com/repos/preillyme/v8js/issues/132","id":68609540,"user":{"login":"preillyme","id":51323,"avatar_url":"https://avatars.githubusercontent.com/u/51323?v=3","gravatar_id":"","url":"https://api.github.com/users/preillyme","html_url":"https://github.com/preillyme","followers_url":"https://api.github.com/users/preillyme/followers","following_url":"https://api.github.com/users/preillyme/following{/other_user}","gists_url":"https://api.github.com/users/preillyme/gists{/gist_id}","starred_url":"https://api.github.com/users/preillyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/preillyme/subscriptions","organizations_url":"https://api.github.com/users/preillyme/orgs","repos_url":"https://api.github.com/users/preillyme/repos","events_url":"https://api.github.com/users/preillyme/events{/privacy}","received_events_url":"https://api.github.com/users/preillyme/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T21:05:14Z","updated_at":"2015-01-03T21:05:14Z","body":"@stesie do you still want this merged? It looks good to me."}}