{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/834","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/834/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/834/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/834/events","html_url":"https://github.com/dotnet/coreclr/issues/834","id":71298575,"number":834,"title":"Endianness comments in BitConverter.DoubleToInt32Bits and Int32BitsToDouble are irrelevant","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/up-for-grabs","name":"up-for-grabs","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-27T14:23:35Z","updated_at":"2015-04-27T15:14:22Z","closed_at":null,"body":"Similar to the comments highlighted in #833, the `BitConverter.DoubleToInt32Bits` and `Int32BitsToDouble` methods contain endianness comments which are almost certainly irrelevant.\r\n\r\n* The .NET Framework doesn't support, and is unlikely to ever support, any architecture which uses a different endianness for its internal representation of integers and floating-point numbers.\r\n* The current implementation of this method *does* already work on both little- and big-endian machines, provided the `Contract.Assert` call is not there.\r\n\r\nI recommend these comments as well as the calls to `Contract.Assert` be removed, and the documentation updated to explicitly include the following text (or an equivalent variant) stating a precondition that has always existed but was previously undocumented.\r\n\r\n> This method assumes the hardward uses the same endianness for integers and floating-point numbers."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/96697017","html_url":"https://github.com/dotnet/coreclr/issues/834#issuecomment-96697017","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/834","id":96697017,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T15:14:22Z","updated_at":"2015-04-27T15:14:22Z","body":"I agree that this comment it bogus and should be removed."}}