{"action":"created","issue":{"url":"https://api.github.com/repos/timmolter/XChange/issues/837","labels_url":"https://api.github.com/repos/timmolter/XChange/issues/837/labels{/name}","comments_url":"https://api.github.com/repos/timmolter/XChange/issues/837/comments","events_url":"https://api.github.com/repos/timmolter/XChange/issues/837/events","html_url":"https://github.com/timmolter/XChange/issues/837","id":55301152,"number":837,"title":"Proposal to change Map<CurrencyPair, ? extends TradeMetaData> getTradeMetaDataMap()..","user":{"login":"timmolter","id":738972,"avatar_url":"https://avatars.githubusercontent.com/u/738972?v=3","gravatar_id":"","url":"https://api.github.com/users/timmolter","html_url":"https://github.com/timmolter","followers_url":"https://api.github.com/users/timmolter/followers","following_url":"https://api.github.com/users/timmolter/following{/other_user}","gists_url":"https://api.github.com/users/timmolter/gists{/gist_id}","starred_url":"https://api.github.com/users/timmolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmolter/subscriptions","organizations_url":"https://api.github.com/users/timmolter/orgs","repos_url":"https://api.github.com/users/timmolter/repos","events_url":"https://api.github.com/users/timmolter/events{/privacy}","received_events_url":"https://api.github.com/users/timmolter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-01-23T16:25:28Z","updated_at":"2015-01-24T21:42:18Z","closed_at":null,"body":"to `Map<CurrencyPair, TradeMetaData> getTradeMetaDataMap()` in `PollingTradeService`, where `TradeMetaData` is a regular ol' DTO containing the union of all the meta data params found across all exchanges. \r\n\r\nWe would then add an adapter and adapt call in the *Raw tradeservice class, just like for everything else.\r\n\r\n@rafalkrupinski This is mostly a question directed towards you. I'd like to change it to be consistent with the rest of XChange's API. I guess I need to know how you're using this method. Are guess you are casting to a specific MetaData Impl like:\r\n\r\n    HitbtcTradeMetaData eur = (HitbtcTradeMetaData) metaMap.get(CurrencyPair.BTC_EUR);\r\n\r\nIt's important to me to that this library follows the principle of least surprise and this \"outlier\" breaks the pattern.\r\n\r\nDo you have a compelling reason for it to be the way you created it?\r\n"},"comment":{"url":"https://api.github.com/repos/timmolter/XChange/issues/comments/71338809","html_url":"https://github.com/timmolter/XChange/issues/837#issuecomment-71338809","issue_url":"https://api.github.com/repos/timmolter/XChange/issues/837","id":71338809,"user":{"login":"rafalkrupinski","id":3732079,"avatar_url":"https://avatars.githubusercontent.com/u/3732079?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalkrupinski","html_url":"https://github.com/rafalkrupinski","followers_url":"https://api.github.com/users/rafalkrupinski/followers","following_url":"https://api.github.com/users/rafalkrupinski/following{/other_user}","gists_url":"https://api.github.com/users/rafalkrupinski/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalkrupinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalkrupinski/subscriptions","organizations_url":"https://api.github.com/users/rafalkrupinski/orgs","repos_url":"https://api.github.com/users/rafalkrupinski/repos","events_url":"https://api.github.com/users/rafalkrupinski/events{/privacy}","received_events_url":"https://api.github.com/users/rafalkrupinski/received_events","type":"User","site_admin":false},"created_at":"2015-01-24T21:42:18Z","updated_at":"2015-01-24T21:42:18Z","body":"Regarding comments to 7550e6a, would it be possible to continue this work in a separate branch, and move develop back to 75a20b9 ?"}}