{"action":"opened","number":3350,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350","id":49724135,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/3350","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3350.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3350.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3350","number":3350,"state":"open","locked":false,"title":"[Android] Only merge JARs which we have built ourselves.","user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"body":"Add a new parameter to merge_jars.py, --build-dir, and exclude JAR files\nwhich lie outside this directory from merging.\n\nThe immediate effect is that android-support-v13.jar will not be part of\nxwalk_core_library.jar anymore. The dependency on\norg.apache.http.legacy.jar was already dropped with chromium-crosswalk\ncommit 5909ede (\"[Android] Stop using org.apache.http classes in\nAccessibilityInjector\").\n\nWe should not bundle android-support-v13.jar in xwalk_core_library.jar,\nas it can cause build problems for users of the embedding API that also\npull the same package themselves or via another dependency. Gradle, for\nexample, produces the following error message:\n\n```\nUNEXPECTED TOP-LEVEL EXCEPTION:\ncom.android.dex.DexException: Multiple dex files define Landroid/support/annotation/AnimRes;\n\tat com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:596)\n\tat com.android.dx.merge.DexMerger.getSortedTypes(DexMerger.java:554)\n\tat com.android.dx.merge.DexMerger.mergeClassDefs(DexMerger.java:535)\n\tat com.android.dx.merge.DexMerger.mergeDexes(DexMerger.java:171)\n\tat com.android.dx.merge.DexMerger.merge(DexMerger.java:189)\n\tat com.android.dx.command.dexer.Main.mergeLibraryDexBuffers(Main.java:454)\n\tat com.android.dx.command.dexer.Main.runMonoDex(Main.java:303)\n\tat com.android.dx.command.dexer.Main.run(Main.java:246)\n\tat com.android.dx.command.dexer.Main.main(Main.java:215)\n\tat com.android.dx.command.Main.main(Main.java:106)\n```\n\nBackgroundSyncLauncherService in content/ is currently the only class\npart of Crosswalk's build that depends on android-support-v13.jar\nbecause it uses android.support.v4 API (which is bundled in the\nsupport-v13 JAR).\n\nUsers of the embedding API must now depend on at least\nandroid-support-v4.jar themselves. It appears to be done by default for\nnew applications in both Eclipse and Android Studio. We may need to\nupdate our documentation and make the dependency explicit in Maven as\nwell as cordova-plugin-crosswalk-webview.\n\nRelated to: XWALK-5092","created_at":"2015-11-04T18:09:22Z","updated_at":"2015-11-04T18:09:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3350/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/862201b941e2bb9bbe63357ef2e540feb6fd63d6","head":{"label":"rakuco:do-not-merge-jars-we-do-not-produce","ref":"do-not-merge-jars-we-do-not-produce","sha":"862201b941e2bb9bbe63357ef2e540feb6fd63d6","user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"repo":{"id":11696807,"name":"crosswalk","full_name":"rakuco/crosswalk","owner":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rakuco/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/rakuco/crosswalk","forks_url":"https://api.github.com/repos/rakuco/crosswalk/forks","keys_url":"https://api.github.com/repos/rakuco/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rakuco/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rakuco/crosswalk/teams","hooks_url":"https://api.github.com/repos/rakuco/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/rakuco/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/rakuco/crosswalk/events","assignees_url":"https://api.github.com/repos/rakuco/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/rakuco/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/rakuco/crosswalk/tags","blobs_url":"https://api.github.com/repos/rakuco/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rakuco/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rakuco/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rakuco/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rakuco/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/rakuco/crosswalk/languages","stargazers_url":"https://api.github.com/repos/rakuco/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/rakuco/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/rakuco/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/rakuco/crosswalk/subscription","commits_url":"https://api.github.com/repos/rakuco/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rakuco/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rakuco/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rakuco/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rakuco/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/rakuco/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rakuco/crosswalk/merges","archive_url":"https://api.github.com/repos/rakuco/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rakuco/crosswalk/downloads","issues_url":"https://api.github.com/repos/rakuco/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/rakuco/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/rakuco/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/rakuco/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rakuco/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/rakuco/crosswalk/releases{/id}","created_at":"2013-07-26T23:26:44Z","updated_at":"2015-02-24T02:16:02Z","pushed_at":"2015-11-04T17:30:13Z","git_url":"git://github.com/rakuco/crosswalk.git","ssh_url":"git@github.com:rakuco/crosswalk.git","clone_url":"https://github.com/rakuco/crosswalk.git","svn_url":"https://github.com/rakuco/crosswalk","homepage":null,"size":15065,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"f47111ac5a24e1d6c6456956c5fafe8c720b7dc3","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2015-11-04T14:42:20Z","pushed_at":"2015-11-04T18:09:22Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":140552,"stargazers_count":1102,"watchers_count":1102,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":305,"mirror_url":null,"open_issues_count":116,"forks":305,"open_issues":116,"watchers":1102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3350"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3350"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3350/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3350/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/862201b941e2bb9bbe63357ef2e540feb6fd63d6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":5,"changed_files":2}}