{"action":"opened","number":1057,"pull_request":{"url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057","id":49754755,"html_url":"https://github.com/rotty3000/liferay-portal/pull/1057","diff_url":"https://github.com/rotty3000/liferay-portal/pull/1057.diff","patch_url":"https://github.com/rotty3000/liferay-portal/pull/1057.patch","issue_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/1057","number":1057,"state":"open","locked":false,"title":"LPS-60183 layout.friendly.url.keywords contains keywords that should not be reserved and does not contain various servlet paths","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"body":"Hey Ray,\r\n\r\nThere are some friendly URL keywords that are being blacklisted but they are legacy URLs. Also there are some servlet mappings that are not being excluded which may cause some issues. The only one left out is \"/documents\" since there is special logic with VirtualHostFilter to handle that case. @holatuwol was looking this over we me and it seems that the property \"layout.friendly.url.keywords\" is really there to make sure VirtualHostFilter doesn't mess anything up but we couldn't think of a way to refactor it to not need to check against these servlet mappings. Please let me know if you think these changes will break existing behavior or if there is some way to make VirtualHostFilter more intelligent to dispatch to the appropriate servlet.\r\n\r\nThanks!","created_at":"2015-11-04T22:23:12Z","updated_at":"2015-11-04T22:23:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057/commits","review_comments_url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057/comments","review_comment_url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/1057/comments","statuses_url":"https://api.github.com/repos/rotty3000/liferay-portal/statuses/07f37e47e4c20efa7884e5497f5fe54105e38843","head":{"label":"jonathanmccann:LPS-60183","ref":"LPS-60183","sha":"07f37e47e4c20efa7884e5497f5fe54105e38843","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"repo":{"id":4877415,"name":"liferay-portal","full_name":"jonathanmccann/liferay-portal","owner":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathanmccann/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/jonathanmccann/liferay-portal","forks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/forks","keys_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/events","assignees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/merges","archive_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/releases{/id}","created_at":"2012-07-03T20:58:23Z","updated_at":"2015-05-08T17:01:19Z","pushed_at":"2015-11-04T22:19:36Z","git_url":"git://github.com/jonathanmccann/liferay-portal.git","ssh_url":"git@github.com:jonathanmccann/liferay-portal.git","clone_url":"https://github.com/jonathanmccann/liferay-portal.git","svn_url":"https://github.com/jonathanmccann/liferay-portal","homepage":"http://liferay.com","size":5201553,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"rotty3000:master","ref":"master","sha":"05998a9de8c9be86b780e3e0c9a69323b9659b54","user":{"login":"rotty3000","id":146764,"avatar_url":"https://avatars.githubusercontent.com/u/146764?v=3","gravatar_id":"","url":"https://api.github.com/users/rotty3000","html_url":"https://github.com/rotty3000","followers_url":"https://api.github.com/users/rotty3000/followers","following_url":"https://api.github.com/users/rotty3000/following{/other_user}","gists_url":"https://api.github.com/users/rotty3000/gists{/gist_id}","starred_url":"https://api.github.com/users/rotty3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotty3000/subscriptions","organizations_url":"https://api.github.com/users/rotty3000/orgs","repos_url":"https://api.github.com/users/rotty3000/repos","events_url":"https://api.github.com/users/rotty3000/events{/privacy}","received_events_url":"https://api.github.com/users/rotty3000/received_events","type":"User","site_admin":false},"repo":{"id":1942549,"name":"liferay-portal","full_name":"rotty3000/liferay-portal","owner":{"login":"rotty3000","id":146764,"avatar_url":"https://avatars.githubusercontent.com/u/146764?v=3","gravatar_id":"","url":"https://api.github.com/users/rotty3000","html_url":"https://github.com/rotty3000","followers_url":"https://api.github.com/users/rotty3000/followers","following_url":"https://api.github.com/users/rotty3000/following{/other_user}","gists_url":"https://api.github.com/users/rotty3000/gists{/gist_id}","starred_url":"https://api.github.com/users/rotty3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotty3000/subscriptions","organizations_url":"https://api.github.com/users/rotty3000/orgs","repos_url":"https://api.github.com/users/rotty3000/repos","events_url":"https://api.github.com/users/rotty3000/events{/privacy}","received_events_url":"https://api.github.com/users/rotty3000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rotty3000/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/rotty3000/liferay-portal","forks_url":"https://api.github.com/repos/rotty3000/liferay-portal/forks","keys_url":"https://api.github.com/repos/rotty3000/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rotty3000/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rotty3000/liferay-portal/teams","hooks_url":"https://api.github.com/repos/rotty3000/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/rotty3000/liferay-portal/events","assignees_url":"https://api.github.com/repos/rotty3000/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/rotty3000/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/rotty3000/liferay-portal/tags","blobs_url":"https://api.github.com/repos/rotty3000/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rotty3000/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rotty3000/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/rotty3000/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rotty3000/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/rotty3000/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/rotty3000/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/rotty3000/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/rotty3000/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/rotty3000/liferay-portal/subscription","commits_url":"https://api.github.com/repos/rotty3000/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/rotty3000/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/rotty3000/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/rotty3000/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/rotty3000/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rotty3000/liferay-portal/merges","archive_url":"https://api.github.com/repos/rotty3000/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rotty3000/liferay-portal/downloads","issues_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/rotty3000/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/rotty3000/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rotty3000/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/rotty3000/liferay-portal/releases{/id}","created_at":"2011-06-23T16:21:20Z","updated_at":"2015-05-08T07:18:42Z","pushed_at":"2015-11-04T16:58:45Z","git_url":"git://github.com/rotty3000/liferay-portal.git","ssh_url":"git@github.com:rotty3000/liferay-portal.git","clone_url":"https://github.com/rotty3000/liferay-portal.git","svn_url":"https://github.com/rotty3000/liferay-portal","homepage":"http://liferay.com","size":5297091,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057"},"html":{"href":"https://github.com/rotty3000/liferay-portal/pull/1057"},"issue":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/issues/1057"},"comments":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/issues/1057/comments"},"review_comments":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057/comments"},"review_comment":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/1057/commits"},"statuses":{"href":"https://api.github.com/repos/rotty3000/liferay-portal/statuses/07f37e47e4c20efa7884e5497f5fe54105e38843"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":6,"changed_files":1}}