{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/scooch/issues/33","labels_url":"https://api.github.com/repos/mobify/scooch/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/mobify/scooch/issues/33/comments","events_url":"https://api.github.com/repos/mobify/scooch/issues/33/events","html_url":"https://github.com/mobify/scooch/pull/33","id":82612491,"number":33,"title":"CSOPS-1458: Refactor scooch centering","user":{"login":"cdegit","id":2857810,"avatar_url":"https://avatars.githubusercontent.com/u/2857810?v=3","gravatar_id":"","url":"https://api.github.com/users/cdegit","html_url":"https://github.com/cdegit","followers_url":"https://api.github.com/users/cdegit/followers","following_url":"https://api.github.com/users/cdegit/following{/other_user}","gists_url":"https://api.github.com/users/cdegit/gists{/gist_id}","starred_url":"https://api.github.com/users/cdegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdegit/subscriptions","organizations_url":"https://api.github.com/users/cdegit/orgs","repos_url":"https://api.github.com/users/cdegit/repos","events_url":"https://api.github.com/users/cdegit/events{/privacy}","received_events_url":"https://api.github.com/users/cdegit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-29T22:31:55Z","updated_at":"2015-12-15T22:45:27Z","closed_at":"2015-12-15T22:05:16Z","pull_request":{"url":"https://api.github.com/repos/mobify/scooch/pulls/33","html_url":"https://github.com/mobify/scooch/pull/33","diff_url":"https://github.com/mobify/scooch/pull/33.diff","patch_url":"https://github.com/mobify/scooch/pull/33.patch"},"body":"Images were missing on Firefox due to the way we handled centering when displaying fixed-width items. It used large negative margins to position the elements. Unfortunately, Firefox would incorrectly calculate the width of .m-scooch-inner because of margin-right: -30000px on the last .m-item. This PR changes how we handle centering fixed-width images, which corrects the bug in Firefox.\r\n\r\nStatus: Ready for review\r\nReviewers: @donnielrt @fractaltheory\r\n\r\n## GH Tickets:\r\n- https://github.com/mobify/scooch/issues/30\r\n\r\n## Changes\r\n- Remove all old styles pertaining to .m-center:not(.m-fluid)\r\n- Set the margin of the first item to 50%\r\n- For all items, transform: translate(-50%)\r\n\r\n## Notes\r\n- This is an alternative fix to https://github.com/mobify/scooch/pull/32"},"comment":{"url":"https://api.github.com/repos/mobify/scooch/issues/comments/164921739","html_url":"https://github.com/mobify/scooch/pull/33#issuecomment-164921739","issue_url":"https://api.github.com/repos/mobify/scooch/issues/33","id":164921739,"user":{"login":"donnielrt","id":1524374,"avatar_url":"https://avatars.githubusercontent.com/u/1524374?v=3","gravatar_id":"","url":"https://api.github.com/users/donnielrt","html_url":"https://github.com/donnielrt","followers_url":"https://api.github.com/users/donnielrt/followers","following_url":"https://api.github.com/users/donnielrt/following{/other_user}","gists_url":"https://api.github.com/users/donnielrt/gists{/gist_id}","starred_url":"https://api.github.com/users/donnielrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnielrt/subscriptions","organizations_url":"https://api.github.com/users/donnielrt/orgs","repos_url":"https://api.github.com/users/donnielrt/repos","events_url":"https://api.github.com/users/donnielrt/events{/privacy}","received_events_url":"https://api.github.com/users/donnielrt/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T22:45:27Z","updated_at":"2015-12-15T22:45:27Z","body":":boom: "}}