{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments/41208387","id":41208387,"diff_hunk":"@@ -265,28 +265,58 @@ def _assign_container_ip(self):\n \n         :return IPAddress which has been assigned\n         \"\"\"\n+        def _assign(ip):","path":"calico_kubernetes/calico_kubernetes.py","position":13,"original_position":13,"commit_id":"811a68b01f3881780b161bac4115a960f7b57123","original_commit_id":"811a68b01f3881780b161bac4115a960f7b57123","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"Yeah, good point.  I likely this because you didn't end up with multiple `assign` methods like `_assign_container_ip` and `__actually_assign_ip` or something like that, but I can probably make something work.","created_at":"2015-10-05T22:55:36Z","updated_at":"2015-10-05T22:55:36Z","html_url":"https://github.com/projectcalico/calico-kubernetes/pull/58#discussion_r41208387","pull_request_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments/41208387"},"html":{"href":"https://github.com/projectcalico/calico-kubernetes/pull/58#discussion_r41208387"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58","id":46595894,"html_url":"https://github.com/projectcalico/calico-kubernetes/pull/58","diff_url":"https://github.com/projectcalico/calico-kubernetes/pull/58.diff","patch_url":"https://github.com/projectcalico/calico-kubernetes/pull/58.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/58","number":58,"state":"open","locked":false,"title":"Handle duplicate IP assignments when using Docker IPAM","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"Seen when restarting docker service or Kubernetes node.\r\n\r\nPartial workaround for kubernetes/kubernetes#14940","created_at":"2015-10-02T01:32:37Z","updated_at":"2015-10-05T22:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4b052832784e68d53cda9f93b14a879d223e77b","assignee":{"login":"Symmetric","id":1524910,"avatar_url":"https://avatars.githubusercontent.com/u/1524910?v=3","gravatar_id":"","url":"https://api.github.com/users/Symmetric","html_url":"https://github.com/Symmetric","followers_url":"https://api.github.com/users/Symmetric/followers","following_url":"https://api.github.com/users/Symmetric/following{/other_user}","gists_url":"https://api.github.com/users/Symmetric/gists{/gist_id}","starred_url":"https://api.github.com/users/Symmetric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Symmetric/subscriptions","organizations_url":"https://api.github.com/users/Symmetric/orgs","repos_url":"https://api.github.com/users/Symmetric/repos","events_url":"https://api.github.com/users/Symmetric/events{/privacy}","received_events_url":"https://api.github.com/users/Symmetric/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/58/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/811a68b01f3881780b161bac4115a960f7b57123","head":{"label":"caseydavenport:cd4-docker-ipam","ref":"cd4-docker-ipam","sha":"811a68b01f3881780b161bac4115a960f7b57123","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"repo":{"id":40203754,"name":"calico-kubernetes","full_name":"caseydavenport/calico-kubernetes","owner":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caseydavenport/calico-kubernetes","description":"","fork":true,"url":"https://api.github.com/repos/caseydavenport/calico-kubernetes","forks_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/forks","keys_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/teams","hooks_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/events","assignees_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/tags","blobs_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/languages","stargazers_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/subscription","commits_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/merges","archive_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/downloads","issues_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/caseydavenport/calico-kubernetes/releases{/id}","created_at":"2015-08-04T19:02:35Z","updated_at":"2015-08-12T21:40:43Z","pushed_at":"2015-10-05T18:49:13Z","git_url":"git://github.com/caseydavenport/calico-kubernetes.git","ssh_url":"git@github.com:caseydavenport/calico-kubernetes.git","clone_url":"https://github.com/caseydavenport/calico-kubernetes.git","svn_url":"https://github.com/caseydavenport/calico-kubernetes","homepage":null,"size":333,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"1376e019a6e0e9d00a068d3f0f9729cfc626aaa2","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39913632,"name":"calico-kubernetes","full_name":"projectcalico/calico-kubernetes","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-kubernetes","description":"Calico Kubernetes Networking Plugin","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-kubernetes","forks_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-kubernetes/releases{/id}","created_at":"2015-07-29T20:04:46Z","updated_at":"2015-09-25T18:55:55Z","pushed_at":"2015-10-05T22:16:16Z","git_url":"git://github.com/projectcalico/calico-kubernetes.git","ssh_url":"git@github.com:projectcalico/calico-kubernetes.git","clone_url":"https://github.com/projectcalico/calico-kubernetes.git","svn_url":"https://github.com/projectcalico/calico-kubernetes","homepage":"","size":897,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58"},"html":{"href":"https://github.com/projectcalico/calico-kubernetes/pull/58"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/58"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-kubernetes/statuses/811a68b01f3881780b161bac4115a960f7b57123"}}}}