{"action":"created","issue":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/571","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/571/labels{/name}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/571/comments","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/571/events","html_url":"https://github.com/ligo-cbc/pycbc/pull/571","id":115917100,"number":571,"title":"Fixes to plots showing histograms of rate vs signal significance","user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/milestones/9","html_url":"https://github.com/ligo-cbc/pycbc/milestones/1.3.0","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/milestones/9/labels","id":1406487,"number":9,"title":"1.3.0","description":"Production O1 Release for review runs.","creator":{"login":"duncan-brown","id":11262902,"avatar_url":"https://avatars.githubusercontent.com/u/11262902?v=3","gravatar_id":"","url":"https://api.github.com/users/duncan-brown","html_url":"https://github.com/duncan-brown","followers_url":"https://api.github.com/users/duncan-brown/followers","following_url":"https://api.github.com/users/duncan-brown/following{/other_user}","gists_url":"https://api.github.com/users/duncan-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/duncan-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncan-brown/subscriptions","organizations_url":"https://api.github.com/users/duncan-brown/orgs","repos_url":"https://api.github.com/users/duncan-brown/repos","events_url":"https://api.github.com/users/duncan-brown/events{/privacy}","received_events_url":"https://api.github.com/users/duncan-brown/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":10,"state":"open","created_at":"2015-11-11T12:52:33Z","updated_at":"2015-11-12T02:55:22Z","due_on":"2015-11-12T05:00:00Z","closed_at":null},"comments":4,"created_at":"2015-11-09T16:49:03Z","updated_at":"2015-11-12T03:01:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/571","html_url":"https://github.com/ligo-cbc/pycbc/pull/571","diff_url":"https://github.com/ligo-cbc/pycbc/pull/571.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/571.patch"},"body":"Update snr ifar plots\r\n\r\n* add trials factor option\r\n* add non-cumulative plot option\r\n* go from two sided to one side sigma shading"},"comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments/155983477","html_url":"https://github.com/ligo-cbc/pycbc/pull/571#issuecomment-155983477","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/571","id":155983477,"user":{"login":"duncan-brown","id":11262902,"avatar_url":"https://avatars.githubusercontent.com/u/11262902?v=3","gravatar_id":"","url":"https://api.github.com/users/duncan-brown","html_url":"https://github.com/duncan-brown","followers_url":"https://api.github.com/users/duncan-brown/followers","following_url":"https://api.github.com/users/duncan-brown/following{/other_user}","gists_url":"https://api.github.com/users/duncan-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/duncan-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncan-brown/subscriptions","organizations_url":"https://api.github.com/users/duncan-brown/orgs","repos_url":"https://api.github.com/users/duncan-brown/repos","events_url":"https://api.github.com/users/duncan-brown/events{/privacy}","received_events_url":"https://api.github.com/users/duncan-brown/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T03:01:40Z","updated_at":"2015-11-12T03:01:40Z","body":"@ahnitz @cdcapano please see the comments below from Greg:\r\n\r\n * There should be no trials factor in the uncombined plots.\r\n * Keep the sigmas, but the 0-1 sigma region should be shaded as well.\r\n * Use the same symbols as in our other plots, i.e., blue triangles for the foreground, crosses for the background. (Different colors for the sigma contours are OK, it it helps distinguish the plot in some way.)\r\n\r\nI would also suggest:\r\n\r\n * Fix the axes labels to use latex symbols, rather than text.\r\n * The sigma labels are hard to find at the top of the plot. Keep them to the right, as in the yellow plots.\r\n * Shade the region outside the maximum sigma and indicate that it is > x sigma."}}