{"action":"created","comment":{"url":"https://api.github.com/repos/plv8/plv8/pulls/comments/30950143","id":30950143,"diff_hunk":"@@ -6,6 +6,8 @@\n  *-------------------------------------------------------------------------\n  */\n #include \"plv8.h\"\n+#include <libplatform/libplatform.h>","path":"plv8.cc","position":4,"original_position":4,"commit_id":"f30426b72c68306570eac781ba2e766d925971e5","original_commit_id":"f30426b72c68306570eac781ba2e766d925971e5","user":{"login":"umitanuki","id":33334,"avatar_url":"https://avatars.githubusercontent.com/u/33334?v=3","gravatar_id":"","url":"https://api.github.com/users/umitanuki","html_url":"https://github.com/umitanuki","followers_url":"https://api.github.com/users/umitanuki/followers","following_url":"https://api.github.com/users/umitanuki/following{/other_user}","gists_url":"https://api.github.com/users/umitanuki/gists{/gist_id}","starred_url":"https://api.github.com/users/umitanuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umitanuki/subscriptions","organizations_url":"https://api.github.com/users/umitanuki/orgs","repos_url":"https://api.github.com/users/umitanuki/repos","events_url":"https://api.github.com/users/umitanuki/events{/privacy}","received_events_url":"https://api.github.com/users/umitanuki/received_events","type":"User","site_admin":false},"body":"If it's from v8 header, use double quotes","created_at":"2015-05-24T04:46:53Z","updated_at":"2015-05-24T04:46:53Z","html_url":"https://github.com/plv8/plv8/pull/115#discussion_r30950143","pull_request_url":"https://api.github.com/repos/plv8/plv8/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/plv8/plv8/pulls/comments/30950143"},"html":{"href":"https://github.com/plv8/plv8/pull/115#discussion_r30950143"},"pull_request":{"href":"https://api.github.com/repos/plv8/plv8/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/plv8/plv8/pulls/115","id":31305388,"html_url":"https://github.com/plv8/plv8/pull/115","diff_url":"https://github.com/plv8/plv8/pull/115.diff","patch_url":"https://github.com/plv8/plv8/pull/115.patch","issue_url":"https://api.github.com/repos/plv8/plv8/issues/115","number":115,"state":"open","locked":false,"title":"Support for recent (4.1.0.x) V8 version","user":{"login":"schwebke","id":6435375,"avatar_url":"https://avatars.githubusercontent.com/u/6435375?v=3","gravatar_id":"","url":"https://api.github.com/users/schwebke","html_url":"https://github.com/schwebke","followers_url":"https://api.github.com/users/schwebke/followers","following_url":"https://api.github.com/users/schwebke/following{/other_user}","gists_url":"https://api.github.com/users/schwebke/gists{/gist_id}","starred_url":"https://api.github.com/users/schwebke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwebke/subscriptions","organizations_url":"https://api.github.com/users/schwebke/orgs","repos_url":"https://api.github.com/users/schwebke/repos","events_url":"https://api.github.com/users/schwebke/events{/privacy}","received_events_url":"https://api.github.com/users/schwebke/received_events","type":"User","site_admin":false},"body":"Recent V8 versions changed the API quite a bit. See the V8's project change notes\r\nhttps://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/\r\nor this blog post for a summary\r\nhttp://strongloop.com/strongblog/node-js-v0-12-c-apis-breaking/\r\n\r\nWith the changes from this pull request plv8 builds with the 4.1.0.x V8 version. This version currently ships with chromium stable:\r\nhttp://www.chromium.org/developers/calendar\r\nDepending on the minor 4.1.0.x version the actually supported gcc versions vary. The compile flags try to compensate for this. gcc 4.8.2 on Ubuntu 14.04 is working fine here. In case of issues building V8 on older systems try falling back to an other V8 from 4.1 branch, e.g. 4.1.0.14.","created_at":"2015-03-17T03:48:38Z","updated_at":"2015-05-24T04:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80195606897852b918cebec8fed3308a85eb0320","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plv8/plv8/pulls/115/commits","review_comments_url":"https://api.github.com/repos/plv8/plv8/pulls/115/comments","review_comment_url":"https://api.github.com/repos/plv8/plv8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plv8/plv8/issues/115/comments","statuses_url":"https://api.github.com/repos/plv8/plv8/statuses/f30426b72c68306570eac781ba2e766d925971e5","head":{"label":"schwebke:es6","ref":"es6","sha":"f30426b72c68306570eac781ba2e766d925971e5","user":{"login":"schwebke","id":6435375,"avatar_url":"https://avatars.githubusercontent.com/u/6435375?v=3","gravatar_id":"","url":"https://api.github.com/users/schwebke","html_url":"https://github.com/schwebke","followers_url":"https://api.github.com/users/schwebke/followers","following_url":"https://api.github.com/users/schwebke/following{/other_user}","gists_url":"https://api.github.com/users/schwebke/gists{/gist_id}","starred_url":"https://api.github.com/users/schwebke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwebke/subscriptions","organizations_url":"https://api.github.com/users/schwebke/orgs","repos_url":"https://api.github.com/users/schwebke/repos","events_url":"https://api.github.com/users/schwebke/events{/privacy}","received_events_url":"https://api.github.com/users/schwebke/received_events","type":"User","site_admin":false},"repo":{"id":32342574,"name":"plv8","full_name":"schwebke/plv8","owner":{"login":"schwebke","id":6435375,"avatar_url":"https://avatars.githubusercontent.com/u/6435375?v=3","gravatar_id":"","url":"https://api.github.com/users/schwebke","html_url":"https://github.com/schwebke","followers_url":"https://api.github.com/users/schwebke/followers","following_url":"https://api.github.com/users/schwebke/following{/other_user}","gists_url":"https://api.github.com/users/schwebke/gists{/gist_id}","starred_url":"https://api.github.com/users/schwebke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwebke/subscriptions","organizations_url":"https://api.github.com/users/schwebke/orgs","repos_url":"https://api.github.com/users/schwebke/repos","events_url":"https://api.github.com/users/schwebke/events{/privacy}","received_events_url":"https://api.github.com/users/schwebke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schwebke/plv8","description":" V8 Engine Javascript Procedural Language add-on for PostgreSQL","fork":true,"url":"https://api.github.com/repos/schwebke/plv8","forks_url":"https://api.github.com/repos/schwebke/plv8/forks","keys_url":"https://api.github.com/repos/schwebke/plv8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schwebke/plv8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schwebke/plv8/teams","hooks_url":"https://api.github.com/repos/schwebke/plv8/hooks","issue_events_url":"https://api.github.com/repos/schwebke/plv8/issues/events{/number}","events_url":"https://api.github.com/repos/schwebke/plv8/events","assignees_url":"https://api.github.com/repos/schwebke/plv8/assignees{/user}","branches_url":"https://api.github.com/repos/schwebke/plv8/branches{/branch}","tags_url":"https://api.github.com/repos/schwebke/plv8/tags","blobs_url":"https://api.github.com/repos/schwebke/plv8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schwebke/plv8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schwebke/plv8/git/refs{/sha}","trees_url":"https://api.github.com/repos/schwebke/plv8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schwebke/plv8/statuses/{sha}","languages_url":"https://api.github.com/repos/schwebke/plv8/languages","stargazers_url":"https://api.github.com/repos/schwebke/plv8/stargazers","contributors_url":"https://api.github.com/repos/schwebke/plv8/contributors","subscribers_url":"https://api.github.com/repos/schwebke/plv8/subscribers","subscription_url":"https://api.github.com/repos/schwebke/plv8/subscription","commits_url":"https://api.github.com/repos/schwebke/plv8/commits{/sha}","git_commits_url":"https://api.github.com/repos/schwebke/plv8/git/commits{/sha}","comments_url":"https://api.github.com/repos/schwebke/plv8/comments{/number}","issue_comment_url":"https://api.github.com/repos/schwebke/plv8/issues/comments{/number}","contents_url":"https://api.github.com/repos/schwebke/plv8/contents/{+path}","compare_url":"https://api.github.com/repos/schwebke/plv8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schwebke/plv8/merges","archive_url":"https://api.github.com/repos/schwebke/plv8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schwebke/plv8/downloads","issues_url":"https://api.github.com/repos/schwebke/plv8/issues{/number}","pulls_url":"https://api.github.com/repos/schwebke/plv8/pulls{/number}","milestones_url":"https://api.github.com/repos/schwebke/plv8/milestones{/number}","notifications_url":"https://api.github.com/repos/schwebke/plv8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schwebke/plv8/labels{/name}","releases_url":"https://api.github.com/repos/schwebke/plv8/releases{/id}","created_at":"2015-03-16T17:50:04Z","updated_at":"2015-04-21T17:49:04Z","pushed_at":"2015-04-22T16:24:06Z","git_url":"git://github.com/schwebke/plv8.git","ssh_url":"git@github.com:schwebke/plv8.git","clone_url":"https://github.com/schwebke/plv8.git","svn_url":"https://github.com/schwebke/plv8","homepage":"","size":624,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plv8:master","ref":"master","sha":"10273c6804cfbdfba787dfd4efba76812fd51654","user":{"login":"plv8","id":11472311,"avatar_url":"https://avatars.githubusercontent.com/u/11472311?v=3","gravatar_id":"","url":"https://api.github.com/users/plv8","html_url":"https://github.com/plv8","followers_url":"https://api.github.com/users/plv8/followers","following_url":"https://api.github.com/users/plv8/following{/other_user}","gists_url":"https://api.github.com/users/plv8/gists{/gist_id}","starred_url":"https://api.github.com/users/plv8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plv8/subscriptions","organizations_url":"https://api.github.com/users/plv8/orgs","repos_url":"https://api.github.com/users/plv8/repos","events_url":"https://api.github.com/users/plv8/events{/privacy}","received_events_url":"https://api.github.com/users/plv8/received_events","type":"Organization","site_admin":false},"repo":{"id":32193707,"name":"plv8","full_name":"plv8/plv8","owner":{"login":"plv8","id":11472311,"avatar_url":"https://avatars.githubusercontent.com/u/11472311?v=3","gravatar_id":"","url":"https://api.github.com/users/plv8","html_url":"https://github.com/plv8","followers_url":"https://api.github.com/users/plv8/followers","following_url":"https://api.github.com/users/plv8/following{/other_user}","gists_url":"https://api.github.com/users/plv8/gists{/gist_id}","starred_url":"https://api.github.com/users/plv8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plv8/subscriptions","organizations_url":"https://api.github.com/users/plv8/orgs","repos_url":"https://api.github.com/users/plv8/repos","events_url":"https://api.github.com/users/plv8/events{/privacy}","received_events_url":"https://api.github.com/users/plv8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plv8/plv8","description":" V8 Engine Javascript Procedural Language add-on for PostgreSQL","fork":false,"url":"https://api.github.com/repos/plv8/plv8","forks_url":"https://api.github.com/repos/plv8/plv8/forks","keys_url":"https://api.github.com/repos/plv8/plv8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plv8/plv8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plv8/plv8/teams","hooks_url":"https://api.github.com/repos/plv8/plv8/hooks","issue_events_url":"https://api.github.com/repos/plv8/plv8/issues/events{/number}","events_url":"https://api.github.com/repos/plv8/plv8/events","assignees_url":"https://api.github.com/repos/plv8/plv8/assignees{/user}","branches_url":"https://api.github.com/repos/plv8/plv8/branches{/branch}","tags_url":"https://api.github.com/repos/plv8/plv8/tags","blobs_url":"https://api.github.com/repos/plv8/plv8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plv8/plv8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plv8/plv8/git/refs{/sha}","trees_url":"https://api.github.com/repos/plv8/plv8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plv8/plv8/statuses/{sha}","languages_url":"https://api.github.com/repos/plv8/plv8/languages","stargazers_url":"https://api.github.com/repos/plv8/plv8/stargazers","contributors_url":"https://api.github.com/repos/plv8/plv8/contributors","subscribers_url":"https://api.github.com/repos/plv8/plv8/subscribers","subscription_url":"https://api.github.com/repos/plv8/plv8/subscription","commits_url":"https://api.github.com/repos/plv8/plv8/commits{/sha}","git_commits_url":"https://api.github.com/repos/plv8/plv8/git/commits{/sha}","comments_url":"https://api.github.com/repos/plv8/plv8/comments{/number}","issue_comment_url":"https://api.github.com/repos/plv8/plv8/issues/comments{/number}","contents_url":"https://api.github.com/repos/plv8/plv8/contents/{+path}","compare_url":"https://api.github.com/repos/plv8/plv8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plv8/plv8/merges","archive_url":"https://api.github.com/repos/plv8/plv8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plv8/plv8/downloads","issues_url":"https://api.github.com/repos/plv8/plv8/issues{/number}","pulls_url":"https://api.github.com/repos/plv8/plv8/pulls{/number}","milestones_url":"https://api.github.com/repos/plv8/plv8/milestones{/number}","notifications_url":"https://api.github.com/repos/plv8/plv8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plv8/plv8/labels{/name}","releases_url":"https://api.github.com/repos/plv8/plv8/releases{/id}","created_at":"2015-03-14T03:15:40Z","updated_at":"2015-05-23T17:11:48Z","pushed_at":"2015-04-22T16:24:06Z","git_url":"git://github.com/plv8/plv8.git","ssh_url":"git@github.com:plv8/plv8.git","clone_url":"https://github.com/plv8/plv8.git","svn_url":"https://github.com/plv8/plv8","homepage":"","size":845,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":38,"forks":9,"open_issues":38,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plv8/plv8/pulls/115"},"html":{"href":"https://github.com/plv8/plv8/pull/115"},"issue":{"href":"https://api.github.com/repos/plv8/plv8/issues/115"},"comments":{"href":"https://api.github.com/repos/plv8/plv8/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/plv8/plv8/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/plv8/plv8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plv8/plv8/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/plv8/plv8/statuses/f30426b72c68306570eac781ba2e766d925971e5"}}}}