{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/31515820","id":31515820,"diff_hunk":"@@ -80,7 +80,8 @@ enum PacketType {\n     PacketTypeIceServerHeartbeat, // 50\n     PacketTypeUnverifiedPing,\n     PacketTypeUnverifiedPingReply,\n-    PacketTypeParticleEntitiesFix\n+    PacketTypeParticleEntitiesFix,\n+    PacketTypeLinePoints","path":"libraries/networking/src/PacketHeaders.h","position":6,"original_position":6,"commit_id":"f51ad6b8da0e576c27b390a64bab0cf071421124","original_commit_id":"f51ad6b8da0e576c27b390a64bab0cf071421124","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"I can't comment lines that don't have changes so I'll add my comment here, but it is for line 186 of this file.\r\n\r\nAfter `const PacketVersion VERSION_ENTITIES_PARTICLE_FIX = 28;` is where you should add your new packet version. I suggest `const PacketVersion VERSION_ENTITIES_LINE_POINTS = 29;`","created_at":"2015-06-02T12:16:02Z","updated_at":"2015-06-02T12:16:02Z","html_url":"https://github.com/highfidelity/hifi/pull/5010#discussion_r31515820","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5010","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/31515820"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5010#discussion_r31515820"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5010"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5010","id":36590332,"html_url":"https://github.com/highfidelity/hifi/pull/5010","diff_url":"https://github.com/highfidelity/hifi/pull/5010.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5010.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5010","number":5010,"state":"open","locked":false,"title":"Modified the line entity to take two new properties: lineWidth and linePoints","user":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"body":"linePoints is an array of absolute points the script writer can specify, which is converted to a qVector of glm::vec3's on the c++ side. Each line can be composed of max ~100 points (due to MTU limit f ~1400 buytes for each property). This is still considerably more efficient than the current limit of two points per line and should allow for rich 2D and 3D drawing (and other) experiences.","created_at":"2015-05-31T22:02:43Z","updated_at":"2015-06-02T12:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"161645e1a6d6b22ded6c1c77524760cab3d1117a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5010/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5010/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5010/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/f51ad6b8da0e576c27b390a64bab0cf071421124","head":{"label":"ericrius1:lineEntity","ref":"lineEntity","sha":"f51ad6b8da0e576c27b390a64bab0cf071421124","user":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"repo":{"id":33081860,"name":"hifi","full_name":"ericrius1/hifi","owner":{"login":"ericrius1","id":908702,"avatar_url":"https://avatars.githubusercontent.com/u/908702?v=3","gravatar_id":"","url":"https://api.github.com/users/ericrius1","html_url":"https://github.com/ericrius1","followers_url":"https://api.github.com/users/ericrius1/followers","following_url":"https://api.github.com/users/ericrius1/following{/other_user}","gists_url":"https://api.github.com/users/ericrius1/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrius1/subscriptions","organizations_url":"https://api.github.com/users/ericrius1/orgs","repos_url":"https://api.github.com/users/ericrius1/repos","events_url":"https://api.github.com/users/ericrius1/events{/privacy}","received_events_url":"https://api.github.com/users/ericrius1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericrius1/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/ericrius1/hifi","forks_url":"https://api.github.com/repos/ericrius1/hifi/forks","keys_url":"https://api.github.com/repos/ericrius1/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericrius1/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericrius1/hifi/teams","hooks_url":"https://api.github.com/repos/ericrius1/hifi/hooks","issue_events_url":"https://api.github.com/repos/ericrius1/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/ericrius1/hifi/events","assignees_url":"https://api.github.com/repos/ericrius1/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/ericrius1/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/ericrius1/hifi/tags","blobs_url":"https://api.github.com/repos/ericrius1/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericrius1/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericrius1/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericrius1/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericrius1/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/ericrius1/hifi/languages","stargazers_url":"https://api.github.com/repos/ericrius1/hifi/stargazers","contributors_url":"https://api.github.com/repos/ericrius1/hifi/contributors","subscribers_url":"https://api.github.com/repos/ericrius1/hifi/subscribers","subscription_url":"https://api.github.com/repos/ericrius1/hifi/subscription","commits_url":"https://api.github.com/repos/ericrius1/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericrius1/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericrius1/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericrius1/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericrius1/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/ericrius1/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericrius1/hifi/merges","archive_url":"https://api.github.com/repos/ericrius1/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericrius1/hifi/downloads","issues_url":"https://api.github.com/repos/ericrius1/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/ericrius1/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/ericrius1/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/ericrius1/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericrius1/hifi/labels{/name}","releases_url":"https://api.github.com/repos/ericrius1/hifi/releases{/id}","created_at":"2015-03-29T17:21:39Z","updated_at":"2015-05-04T23:40:14Z","pushed_at":"2015-06-01T22:39:12Z","git_url":"git://github.com/ericrius1/hifi.git","ssh_url":"git@github.com:ericrius1/hifi.git","clone_url":"https://github.com/ericrius1/hifi.git","svn_url":"https://github.com/ericrius1/hifi","homepage":"","size":155808,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"ef5fa48c2a6a494453ccb5e04e1e2233d29e19d6","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-05-24T12:28:07Z","pushed_at":"2015-06-02T06:36:08Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":214983,"stargazers_count":270,"watchers_count":270,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":49,"forks":155,"open_issues":49,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5010"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5010"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5010"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5010/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5010/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5010/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/f51ad6b8da0e576c27b390a64bab0cf071421124"}}}}