{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/30744458","id":30744458,"diff_hunk":"@@ -106,6 +106,8 @@ func (a *Addr) Set(value string) error {\n \n \tif !a.AllowPrefix {\n \t\taddr.Path = \"\"\n+\t} else if addr.Path == \"/\" {","path":"pkg/cmd/flagtypes/addr.go","position":4,"original_position":4,"commit_id":"02d03ab890bc5160a08cc38eea22e0dca738d940","original_commit_id":"02d03ab890bc5160a08cc38eea22e0dca738d940","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"It's important to normalize the original value we get, so it doesn't result in duplicates in config depending on how it was provided to the command, for example.","created_at":"2015-05-20T20:19:23Z","updated_at":"2015-05-20T20:19:23Z","html_url":"https://github.com/openshift/origin/pull/2387#discussion_r30744458","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2387","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/30744458"},"html":{"href":"https://github.com/openshift/origin/pull/2387#discussion_r30744458"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2387"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2387","id":35857495,"html_url":"https://github.com/openshift/origin/pull/2387","diff_url":"https://github.com/openshift/origin/pull/2387.diff","patch_url":"https://github.com/openshift/origin/pull/2387.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2387","number":2387,"state":"open","locked":false,"title":"Issue 2358 - better handling of server url parsing in osc login","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"Fixes #2358.\r\n\r\nNotice this only fixes the server url parsing on login. At some point we may want to move `flagtypes.Addr` upstream and change the `--server` flag type to `Addr` instead of `string`. ","created_at":"2015-05-20T17:44:33Z","updated_at":"2015-05-20T20:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb83493b0e5b78fa35acda640bcda82c51bf0f0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2387/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2387/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2387/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/02d03ab890bc5160a08cc38eea22e0dca738d940","head":{"label":"fabianofranz:issues_2358","ref":"issues_2358","sha":"02d03ab890bc5160a08cc38eea22e0dca738d940","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"repo":{"id":23366851,"name":"origin","full_name":"fabianofranz/origin","owner":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabianofranz/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/fabianofranz/origin","forks_url":"https://api.github.com/repos/fabianofranz/origin/forks","keys_url":"https://api.github.com/repos/fabianofranz/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabianofranz/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabianofranz/origin/teams","hooks_url":"https://api.github.com/repos/fabianofranz/origin/hooks","issue_events_url":"https://api.github.com/repos/fabianofranz/origin/issues/events{/number}","events_url":"https://api.github.com/repos/fabianofranz/origin/events","assignees_url":"https://api.github.com/repos/fabianofranz/origin/assignees{/user}","branches_url":"https://api.github.com/repos/fabianofranz/origin/branches{/branch}","tags_url":"https://api.github.com/repos/fabianofranz/origin/tags","blobs_url":"https://api.github.com/repos/fabianofranz/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabianofranz/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabianofranz/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabianofranz/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabianofranz/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabianofranz/origin/languages","stargazers_url":"https://api.github.com/repos/fabianofranz/origin/stargazers","contributors_url":"https://api.github.com/repos/fabianofranz/origin/contributors","subscribers_url":"https://api.github.com/repos/fabianofranz/origin/subscribers","subscription_url":"https://api.github.com/repos/fabianofranz/origin/subscription","commits_url":"https://api.github.com/repos/fabianofranz/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabianofranz/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabianofranz/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabianofranz/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabianofranz/origin/contents/{+path}","compare_url":"https://api.github.com/repos/fabianofranz/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabianofranz/origin/merges","archive_url":"https://api.github.com/repos/fabianofranz/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabianofranz/origin/downloads","issues_url":"https://api.github.com/repos/fabianofranz/origin/issues{/number}","pulls_url":"https://api.github.com/repos/fabianofranz/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabianofranz/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabianofranz/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabianofranz/origin/labels{/name}","releases_url":"https://api.github.com/repos/fabianofranz/origin/releases{/id}","created_at":"2014-08-26T21:06:40Z","updated_at":"2015-04-24T16:39:47Z","pushed_at":"2015-05-20T19:55:35Z","git_url":"git://github.com/fabianofranz/origin.git","ssh_url":"git@github.com:fabianofranz/origin.git","clone_url":"https://github.com/fabianofranz/origin.git","svn_url":"https://github.com/fabianofranz/origin","homepage":"https://openshift.github.io","size":107631,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"49ceb32fab13be6d1d3930895136f9ef4bc02354","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-05-19T04:29:35Z","pushed_at":"2015-05-20T20:17:34Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":174244,"stargazers_count":427,"watchers_count":427,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":209,"mirror_url":null,"open_issues_count":214,"forks":209,"open_issues":214,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2387"},"html":{"href":"https://github.com/openshift/origin/pull/2387"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2387"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2387/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2387/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2387/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/02d03ab890bc5160a08cc38eea22e0dca738d940"}}}}