{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199","id":45361618,"html_url":"https://github.com/Alignak-monitoring/alignak/pull/199","diff_url":"https://github.com/Alignak-monitoring/alignak/pull/199.diff","patch_url":"https://github.com/Alignak-monitoring/alignak/pull/199.patch","issue_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/199","number":199,"state":"closed","locked":false,"title":"Enh: Tests - Rework setup file to remove duplication","user":{"login":"Seb-Solon","id":856137,"avatar_url":"https://avatars.githubusercontent.com/u/856137?v=3","gravatar_id":"","url":"https://api.github.com/users/Seb-Solon","html_url":"https://github.com/Seb-Solon","followers_url":"https://api.github.com/users/Seb-Solon/followers","following_url":"https://api.github.com/users/Seb-Solon/following{/other_user}","gists_url":"https://api.github.com/users/Seb-Solon/gists{/gist_id}","starred_url":"https://api.github.com/users/Seb-Solon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seb-Solon/subscriptions","organizations_url":"https://api.github.com/users/Seb-Solon/orgs","repos_url":"https://api.github.com/users/Seb-Solon/repos","events_url":"https://api.github.com/users/Seb-Solon/events{/privacy}","received_events_url":"https://api.github.com/users/Seb-Solon/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nBig cleaning of tests directory. \r\nI edited setup_with_file function to always (unless specified) add the default configuration in the test case with the one specified. This allow the second configuration file to be (usually) only few lines of configuration. \r\n\r\nI also merged all configuration in the specific test config file. In my opinion for test purpose it's better to have all in one file than splitting (like we did in the root etc directory)\r\n\r\nThe diff is really big because I removed a lot of duplicated \"basic\" config file (only used to add cfg_file statement)\r\n\r\nHave fun reviewing this. In my opinion the only thing to review is Travis ( not failing) and that the test files that I have modify are fine.","created_at":"2015-09-18T01:48:29Z","updated_at":"2015-09-18T09:36:59Z","closed_at":"2015-09-18T09:36:59Z","merged_at":"2015-09-18T09:36:59Z","merge_commit_sha":"4fd599f03a7033209a6f48bfea8e50767e137246","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199/commits","review_comments_url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199/comments","review_comment_url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/199/comments","statuses_url":"https://api.github.com/repos/Alignak-monitoring/alignak/statuses/dab938b47f608cb904d4d9430c224dbd5d7eeae4","head":{"label":"Alignak-monitoring:Enh_clear_tests","ref":"Enh_clear_tests","sha":"dab938b47f608cb904d4d9430c224dbd5d7eeae4","user":{"login":"Alignak-monitoring","id":12305279,"avatar_url":"https://avatars.githubusercontent.com/u/12305279?v=3","gravatar_id":"","url":"https://api.github.com/users/Alignak-monitoring","html_url":"https://github.com/Alignak-monitoring","followers_url":"https://api.github.com/users/Alignak-monitoring/followers","following_url":"https://api.github.com/users/Alignak-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/Alignak-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/Alignak-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alignak-monitoring/subscriptions","organizations_url":"https://api.github.com/users/Alignak-monitoring/orgs","repos_url":"https://api.github.com/users/Alignak-monitoring/repos","events_url":"https://api.github.com/users/Alignak-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/Alignak-monitoring/received_events","type":"Organization","site_admin":false},"repo":{"id":35242228,"name":"alignak","full_name":"Alignak-monitoring/alignak","owner":{"login":"Alignak-monitoring","id":12305279,"avatar_url":"https://avatars.githubusercontent.com/u/12305279?v=3","gravatar_id":"","url":"https://api.github.com/users/Alignak-monitoring","html_url":"https://github.com/Alignak-monitoring","followers_url":"https://api.github.com/users/Alignak-monitoring/followers","following_url":"https://api.github.com/users/Alignak-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/Alignak-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/Alignak-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alignak-monitoring/subscriptions","organizations_url":"https://api.github.com/users/Alignak-monitoring/orgs","repos_url":"https://api.github.com/users/Alignak-monitoring/repos","events_url":"https://api.github.com/users/Alignak-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/Alignak-monitoring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alignak-monitoring/alignak","description":"","fork":false,"url":"https://api.github.com/repos/Alignak-monitoring/alignak","forks_url":"https://api.github.com/repos/Alignak-monitoring/alignak/forks","keys_url":"https://api.github.com/repos/Alignak-monitoring/alignak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alignak-monitoring/alignak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alignak-monitoring/alignak/teams","hooks_url":"https://api.github.com/repos/Alignak-monitoring/alignak/hooks","issue_events_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/events{/number}","events_url":"https://api.github.com/repos/Alignak-monitoring/alignak/events","assignees_url":"https://api.github.com/repos/Alignak-monitoring/alignak/assignees{/user}","branches_url":"https://api.github.com/repos/Alignak-monitoring/alignak/branches{/branch}","tags_url":"https://api.github.com/repos/Alignak-monitoring/alignak/tags","blobs_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alignak-monitoring/alignak/statuses/{sha}","languages_url":"https://api.github.com/repos/Alignak-monitoring/alignak/languages","stargazers_url":"https://api.github.com/repos/Alignak-monitoring/alignak/stargazers","contributors_url":"https://api.github.com/repos/Alignak-monitoring/alignak/contributors","subscribers_url":"https://api.github.com/repos/Alignak-monitoring/alignak/subscribers","subscription_url":"https://api.github.com/repos/Alignak-monitoring/alignak/subscription","commits_url":"https://api.github.com/repos/Alignak-monitoring/alignak/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alignak-monitoring/alignak/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alignak-monitoring/alignak/contents/{+path}","compare_url":"https://api.github.com/repos/Alignak-monitoring/alignak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alignak-monitoring/alignak/merges","archive_url":"https://api.github.com/repos/Alignak-monitoring/alignak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alignak-monitoring/alignak/downloads","issues_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues{/number}","pulls_url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls{/number}","milestones_url":"https://api.github.com/repos/Alignak-monitoring/alignak/milestones{/number}","notifications_url":"https://api.github.com/repos/Alignak-monitoring/alignak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alignak-monitoring/alignak/labels{/name}","releases_url":"https://api.github.com/repos/Alignak-monitoring/alignak/releases{/id}","created_at":"2015-05-07T20:35:42Z","updated_at":"2015-09-16T23:28:03Z","pushed_at":"2015-09-18T09:36:59Z","git_url":"git://github.com/Alignak-monitoring/alignak.git","ssh_url":"git@github.com:Alignak-monitoring/alignak.git","clone_url":"https://github.com/Alignak-monitoring/alignak.git","svn_url":"https://github.com/Alignak-monitoring/alignak","homepage":null,"size":45148,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":40,"forks":9,"open_issues":40,"watchers":13,"default_branch":"develop"}},"base":{"label":"Alignak-monitoring:develop","ref":"develop","sha":"12f9c34ba5ad20e68409a96144c1d801da19ea42","user":{"login":"Alignak-monitoring","id":12305279,"avatar_url":"https://avatars.githubusercontent.com/u/12305279?v=3","gravatar_id":"","url":"https://api.github.com/users/Alignak-monitoring","html_url":"https://github.com/Alignak-monitoring","followers_url":"https://api.github.com/users/Alignak-monitoring/followers","following_url":"https://api.github.com/users/Alignak-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/Alignak-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/Alignak-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alignak-monitoring/subscriptions","organizations_url":"https://api.github.com/users/Alignak-monitoring/orgs","repos_url":"https://api.github.com/users/Alignak-monitoring/repos","events_url":"https://api.github.com/users/Alignak-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/Alignak-monitoring/received_events","type":"Organization","site_admin":false},"repo":{"id":35242228,"name":"alignak","full_name":"Alignak-monitoring/alignak","owner":{"login":"Alignak-monitoring","id":12305279,"avatar_url":"https://avatars.githubusercontent.com/u/12305279?v=3","gravatar_id":"","url":"https://api.github.com/users/Alignak-monitoring","html_url":"https://github.com/Alignak-monitoring","followers_url":"https://api.github.com/users/Alignak-monitoring/followers","following_url":"https://api.github.com/users/Alignak-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/Alignak-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/Alignak-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alignak-monitoring/subscriptions","organizations_url":"https://api.github.com/users/Alignak-monitoring/orgs","repos_url":"https://api.github.com/users/Alignak-monitoring/repos","events_url":"https://api.github.com/users/Alignak-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/Alignak-monitoring/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alignak-monitoring/alignak","description":"","fork":false,"url":"https://api.github.com/repos/Alignak-monitoring/alignak","forks_url":"https://api.github.com/repos/Alignak-monitoring/alignak/forks","keys_url":"https://api.github.com/repos/Alignak-monitoring/alignak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alignak-monitoring/alignak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alignak-monitoring/alignak/teams","hooks_url":"https://api.github.com/repos/Alignak-monitoring/alignak/hooks","issue_events_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/events{/number}","events_url":"https://api.github.com/repos/Alignak-monitoring/alignak/events","assignees_url":"https://api.github.com/repos/Alignak-monitoring/alignak/assignees{/user}","branches_url":"https://api.github.com/repos/Alignak-monitoring/alignak/branches{/branch}","tags_url":"https://api.github.com/repos/Alignak-monitoring/alignak/tags","blobs_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alignak-monitoring/alignak/statuses/{sha}","languages_url":"https://api.github.com/repos/Alignak-monitoring/alignak/languages","stargazers_url":"https://api.github.com/repos/Alignak-monitoring/alignak/stargazers","contributors_url":"https://api.github.com/repos/Alignak-monitoring/alignak/contributors","subscribers_url":"https://api.github.com/repos/Alignak-monitoring/alignak/subscribers","subscription_url":"https://api.github.com/repos/Alignak-monitoring/alignak/subscription","commits_url":"https://api.github.com/repos/Alignak-monitoring/alignak/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alignak-monitoring/alignak/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alignak-monitoring/alignak/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alignak-monitoring/alignak/contents/{+path}","compare_url":"https://api.github.com/repos/Alignak-monitoring/alignak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alignak-monitoring/alignak/merges","archive_url":"https://api.github.com/repos/Alignak-monitoring/alignak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alignak-monitoring/alignak/downloads","issues_url":"https://api.github.com/repos/Alignak-monitoring/alignak/issues{/number}","pulls_url":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls{/number}","milestones_url":"https://api.github.com/repos/Alignak-monitoring/alignak/milestones{/number}","notifications_url":"https://api.github.com/repos/Alignak-monitoring/alignak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alignak-monitoring/alignak/labels{/name}","releases_url":"https://api.github.com/repos/Alignak-monitoring/alignak/releases{/id}","created_at":"2015-05-07T20:35:42Z","updated_at":"2015-09-16T23:28:03Z","pushed_at":"2015-09-18T09:36:59Z","git_url":"git://github.com/Alignak-monitoring/alignak.git","ssh_url":"git@github.com:Alignak-monitoring/alignak.git","clone_url":"https://github.com/Alignak-monitoring/alignak.git","svn_url":"https://github.com/Alignak-monitoring/alignak","homepage":null,"size":45148,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":40,"forks":9,"open_issues":40,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199"},"html":{"href":"https://github.com/Alignak-monitoring/alignak/pull/199"},"issue":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/199"},"comments":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/Alignak-monitoring/alignak/statuses/dab938b47f608cb904d4d9430c224dbd5d7eeae4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ddurieux","id":239744,"avatar_url":"https://avatars.githubusercontent.com/u/239744?v=3","gravatar_id":"","url":"https://api.github.com/users/ddurieux","html_url":"https://github.com/ddurieux","followers_url":"https://api.github.com/users/ddurieux/followers","following_url":"https://api.github.com/users/ddurieux/following{/other_user}","gists_url":"https://api.github.com/users/ddurieux/gists{/gist_id}","starred_url":"https://api.github.com/users/ddurieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddurieux/subscriptions","organizations_url":"https://api.github.com/users/ddurieux/orgs","repos_url":"https://api.github.com/users/ddurieux/repos","events_url":"https://api.github.com/users/ddurieux/events{/privacy}","received_events_url":"https://api.github.com/users/ddurieux/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6749,"deletions":25261,"changed_files":586}}