{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/27846655","id":27846655,"diff_hunk":"@@ -170,12 +170,14 @@ namespace facter { namespace facts { namespace linux {\n \n     string virtualization_resolver::get_vmware_vm()\n     {\n-        auto result = execute(\"vmware\", { \"-v\" });\n-        if (!result.first) {\n+        bool success;\n+        string output, error;\n+        tie(success, output, error) = execute(\"vmware\", { \"-v\" });","path":"lib/src/facts/linux/virtualization_resolver.cc","position":8,"original_position":8,"commit_id":"2b31c894153d313abf7d7b787c14a3145d921f56","original_commit_id":"2b31c894153d313abf7d7b787c14a3145d921f56","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Same, change error to something that makes it obvious it's a dummy because stderr redirects to null.","created_at":"2015-04-07T01:53:18Z","updated_at":"2015-04-07T01:53:18Z","html_url":"https://github.com/puppetlabs/facter/pull/900#discussion_r27846655","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/900","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/27846655"},"html":{"href":"https://github.com/puppetlabs/facter/pull/900#discussion_r27846655"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/900","id":32279222,"html_url":"https://github.com/puppetlabs/facter/pull/900","diff_url":"https://github.com/puppetlabs/facter/pull/900.diff","patch_url":"https://github.com/puppetlabs/facter/pull/900.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/900","number":900,"state":"open","locked":false,"title":"(FACT-865) Split stdout and stderr handling in execution.","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"body":"This implements a new pipe for reading stderr in addition to stdout from\r\nchild processes.  Previously, stderr was optionally redirected to\r\nstdout or to the null device if not merging the two streams.  This change\r\nallows child process execution to treat stdout and stderr as two\r\nseparate streams, enabling the ability to process stdout while logging\r\nstderr messages (e.g. external executable facts).\r\n\r\nThe execute functions now return a tuple of both the stdout and stderr\r\ncontents.  The each_line functions now take an additional function\r\nobject to call when a line of stderr is read.\r\n","created_at":"2015-03-30T23:53:12Z","updated_at":"2015-04-07T01:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b58040e612a85011677ed37fc800a980ce5ddd","assignee":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/900/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/900/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/900/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/2b31c894153d313abf7d7b787c14a3145d921f56","head":{"label":"peterhuene:splitting-stderr","ref":"splitting-stderr","sha":"2b31c894153d313abf7d7b787c14a3145d921f56","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"repo":{"id":15720773,"name":"facter","full_name":"peterhuene/facter","owner":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterhuene/facter","description":"","fork":true,"url":"https://api.github.com/repos/peterhuene/facter","forks_url":"https://api.github.com/repos/peterhuene/facter/forks","keys_url":"https://api.github.com/repos/peterhuene/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterhuene/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterhuene/facter/teams","hooks_url":"https://api.github.com/repos/peterhuene/facter/hooks","issue_events_url":"https://api.github.com/repos/peterhuene/facter/issues/events{/number}","events_url":"https://api.github.com/repos/peterhuene/facter/events","assignees_url":"https://api.github.com/repos/peterhuene/facter/assignees{/user}","branches_url":"https://api.github.com/repos/peterhuene/facter/branches{/branch}","tags_url":"https://api.github.com/repos/peterhuene/facter/tags","blobs_url":"https://api.github.com/repos/peterhuene/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterhuene/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterhuene/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterhuene/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterhuene/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/peterhuene/facter/languages","stargazers_url":"https://api.github.com/repos/peterhuene/facter/stargazers","contributors_url":"https://api.github.com/repos/peterhuene/facter/contributors","subscribers_url":"https://api.github.com/repos/peterhuene/facter/subscribers","subscription_url":"https://api.github.com/repos/peterhuene/facter/subscription","commits_url":"https://api.github.com/repos/peterhuene/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterhuene/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterhuene/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterhuene/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterhuene/facter/contents/{+path}","compare_url":"https://api.github.com/repos/peterhuene/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterhuene/facter/merges","archive_url":"https://api.github.com/repos/peterhuene/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterhuene/facter/downloads","issues_url":"https://api.github.com/repos/peterhuene/facter/issues{/number}","pulls_url":"https://api.github.com/repos/peterhuene/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/peterhuene/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/peterhuene/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterhuene/facter/labels{/name}","releases_url":"https://api.github.com/repos/peterhuene/facter/releases{/id}","created_at":"2014-01-08T00:16:20Z","updated_at":"2015-03-23T21:30:48Z","pushed_at":"2015-04-06T19:51:16Z","git_url":"git://github.com/peterhuene/facter.git","ssh_url":"git@github.com:peterhuene/facter.git","clone_url":"https://github.com/peterhuene/facter.git","svn_url":"https://github.com/peterhuene/facter","homepage":"http://projects.puppetlabs.com/projects/facter","size":11020,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"1da150f116f6dc36ebd7b00ca1b7137152c6ee8a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","created_at":"2010-09-14T19:31:04Z","updated_at":"2015-04-06T21:26:31Z","pushed_at":"2015-04-06T21:26:31Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppetlabs.com/browse/FACT","size":19098,"stargazers_count":367,"watchers_count":367,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":357,"mirror_url":null,"open_issues_count":3,"forks":357,"open_issues":3,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/900"},"html":{"href":"https://github.com/puppetlabs/facter/pull/900"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/900"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/2b31c894153d313abf7d7b787c14a3145d921f56"}}}}