{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/26467551","id":26467551,"diff_hunk":"@@ -0,0 +1,54 @@\n+using NHibernate.SqlCommand;\n+using NHibernate.SqlCommand.Parser;\n+\n+namespace NHibernate.Dialect\n+{\n+\t/// <summary> \n+\t/// A dialect specifically for use with Oracle 10g.\n+\t/// </summary>\n+\t/// <remarks>\n+\t/// The main difference between this dialect and <see cref=\"Oracle12cDialect\"/>\n+\t/// is the use of \"ANSI join syntax\" here...\n+\t/// </remarks>\n+\tpublic class Oracle12cDialect : Oracle10gDialect\n+\t{\n+\t\t/// <summary>\n+\t\t/// Oracle 12c supports a query statement that provides <c>LIMIT</c>\n+\t\t/// functionality with an offset.\n+\t\t/// </summary>\n+\t\t/// <value><c>false</c></value>\n+\t\tpublic override bool UseMaxForLimit\n+\t\t{\n+\t\t\tget { return false; }\n+\t\t}\n+\n+\t\tpublic override SqlString GetLimitString(SqlString querySqlString, SqlString offset, SqlString limit)\n+\t\t{\n+\t\t\tvar tokenEnum = new SqlTokenizer(querySqlString).GetEnumerator();\n+\t\t\tif (!tokenEnum.TryParseUntilFirstMsSqlSelectColumn()) return null;\n+\n+\t\t\tvar result = new SqlStringBuilder(querySqlString);\n+\t\t\tif (!tokenEnum.TryParseUntil(\"order\"))\n+\t\t\t{\n+\t\t\t\tresult.Add(\" ORDER BY CURRENT_TIMESTAMP\");","path":"src/NHibernate/Dialect/Oracle12cDialect.cs","position":33,"original_position":33,"commit_id":"95bd717635cdc712079c17058d72297292f74935","original_commit_id":"95bd717635cdc712079c17058d72297292f74935","user":{"login":"hazzik","id":144791,"avatar_url":"https://avatars.githubusercontent.com/u/144791?v=3","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"body":"This has been added to Sql Server dialect, because it does not allow to use new fetching syntax without ordering results.","created_at":"2015-03-16T08:40:57Z","updated_at":"2015-03-16T08:40:57Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/413#discussion_r26467551","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/26467551"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/413#discussion_r26467551"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413","id":31224328,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/413","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/413.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/413.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/413","number":413,"state":"open","locked":false,"title":"NH-3495 - Oracle12c dialect","user":{"login":"lnu","id":1829553,"avatar_url":"https://avatars.githubusercontent.com/u/1829553?v=3","gravatar_id":"","url":"https://api.github.com/users/lnu","html_url":"https://github.com/lnu","followers_url":"https://api.github.com/users/lnu/followers","following_url":"https://api.github.com/users/lnu/following{/other_user}","gists_url":"https://api.github.com/users/lnu/gists{/gist_id}","starred_url":"https://api.github.com/users/lnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnu/subscriptions","organizations_url":"https://api.github.com/users/lnu/orgs","repos_url":"https://api.github.com/users/lnu/repos","events_url":"https://api.github.com/users/lnu/events{/privacy}","received_events_url":"https://api.github.com/users/lnu/received_events","type":"User","site_admin":false},"body":"New `Oracle12cDialect`. It adds the pagination using `OFFSET` and `FETCH`.\r\nIt is based on the `MSSql2012Dialect`.","created_at":"2015-03-16T08:31:37Z","updated_at":"2015-03-16T08:40:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07aae6649749283485d88693a7b65339d0e36c9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/413/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/95bd717635cdc712079c17058d72297292f74935","head":{"label":"lnu:oracle12c","ref":"oracle12c","sha":"95bd717635cdc712079c17058d72297292f74935","user":{"login":"lnu","id":1829553,"avatar_url":"https://avatars.githubusercontent.com/u/1829553?v=3","gravatar_id":"","url":"https://api.github.com/users/lnu","html_url":"https://github.com/lnu","followers_url":"https://api.github.com/users/lnu/followers","following_url":"https://api.github.com/users/lnu/following{/other_user}","gists_url":"https://api.github.com/users/lnu/gists{/gist_id}","starred_url":"https://api.github.com/users/lnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnu/subscriptions","organizations_url":"https://api.github.com/users/lnu/orgs","repos_url":"https://api.github.com/users/lnu/repos","events_url":"https://api.github.com/users/lnu/events{/privacy}","received_events_url":"https://api.github.com/users/lnu/received_events","type":"User","site_admin":false},"repo":{"id":29667836,"name":"nhibernate-core","full_name":"lnu/nhibernate-core","owner":{"login":"lnu","id":1829553,"avatar_url":"https://avatars.githubusercontent.com/u/1829553?v=3","gravatar_id":"","url":"https://api.github.com/users/lnu","html_url":"https://github.com/lnu","followers_url":"https://api.github.com/users/lnu/followers","following_url":"https://api.github.com/users/lnu/following{/other_user}","gists_url":"https://api.github.com/users/lnu/gists{/gist_id}","starred_url":"https://api.github.com/users/lnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnu/subscriptions","organizations_url":"https://api.github.com/users/lnu/orgs","repos_url":"https://api.github.com/users/lnu/repos","events_url":"https://api.github.com/users/lnu/events{/privacy}","received_events_url":"https://api.github.com/users/lnu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lnu/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/lnu/nhibernate-core","forks_url":"https://api.github.com/repos/lnu/nhibernate-core/forks","keys_url":"https://api.github.com/repos/lnu/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lnu/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lnu/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/lnu/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/lnu/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/lnu/nhibernate-core/events","assignees_url":"https://api.github.com/repos/lnu/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/lnu/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/lnu/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/lnu/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lnu/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lnu/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/lnu/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lnu/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/lnu/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/lnu/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/lnu/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/lnu/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/lnu/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/lnu/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/lnu/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/lnu/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/lnu/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/lnu/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/lnu/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lnu/nhibernate-core/merges","archive_url":"https://api.github.com/repos/lnu/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lnu/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/lnu/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/lnu/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/lnu/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/lnu/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lnu/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/lnu/nhibernate-core/releases{/id}","created_at":"2015-01-22T07:59:06Z","updated_at":"2015-03-13T06:45:37Z","pushed_at":"2015-03-16T08:31:00Z","git_url":"git://github.com/lnu/nhibernate-core.git","ssh_url":"git@github.com:lnu/nhibernate-core.git","clone_url":"https://github.com/lnu/nhibernate-core.git","svn_url":"https://github.com/lnu/nhibernate-core","homepage":"http://nhibernate.info","size":68317,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"a7acbed01834ededf77626e51a9cc78c94eceba3","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","created_at":"2011-08-14T17:51:09Z","updated_at":"2015-03-13T13:05:23Z","pushed_at":"2015-03-06T22:37:12Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":101298,"stargazers_count":762,"watchers_count":762,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":510,"mirror_url":null,"open_issues_count":57,"forks":510,"open_issues":57,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/413"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/413"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/95bd717635cdc712079c17058d72297292f74935"}}}}